sean-k-mooney | "Feb 04 23:58:11 cyborg devstack@cyborg-api.service[1026]: 2020-02-04 23:58:11.561 1162 DEBUG wsme.api [req-e73cfa00-93fe-48ec-ac53-f7cde5e7ba68 587231efdc20474ba378d4dff3c7bfd3 aaa44c9e9ced4e328a3503c86899f01f - default default] Client-side error: ExtArq not found with uuid=cb27c864-8a56-4440-85f1-09023019e1ab format_exception /usr/local/lib/python3.7/dist-packages/wsme/api.py:222" that is the error | 00:00 |
---|---|---|
sean-k-mooney | in the cyborg log | 00:00 |
sean-k-mooney | oh there is a traceback in the cyborg conductor too | 00:01 |
sean-k-mooney | oh that is unrealated i tried to create duplicate profiles previously | 00:03 |
sean-k-mooney | oh i found the issue its the same one i had before i think http://paste.openstack.org/show/789142/ | 00:05 |
sean-k-mooney | so it looks like the cyborg api is not able to call back the nova api to notify it of the binding completion | 00:05 |
sean-k-mooney | im sligly confused why the cyborg api woudl be trying to do that and not the cyborg conductor but that is the issue | 00:06 |
sean-k-mooney | efried: dansmith sundar ^ any ideas. i might look at the tempest jobs to see what they are setting | 00:07 |
dansmith | yeah, I dunno, but agreed it seems weird that it would be cyborg api | 00:08 |
dansmith | is the "conductor" really the compute agent? | 00:08 |
sean-k-mooney | no that is seperate | 00:08 |
sean-k-mooney | they have all 3 | 00:08 |
sean-k-mooney | copying novas architecure | 00:08 |
dansmith | okay, I guess I'd have thought it'd be the compute agent sending that then, but I guess if the conductor is blocking on the compute to finish then maybe that makes sense | 00:09 |
dansmith | I gotta run in a sec to meet people, but maybe we can get an answer from sundar tomorrow | 00:09 |
sean-k-mooney | well it seams like the api is blocking on the agent or conductor | 00:09 |
sean-k-mooney | ya | 00:10 |
dansmith | that sounds like a recipe for disaster :/ | 00:10 |
sean-k-mooney | im going to call it a day anyway | 00:10 |
dansmith | cool, thanks for looking at this | 00:10 |
sean-k-mooney | no worries | 00:11 |
sean-k-mooney | huh so in the ci i see " Ignoring Nova notification error that the instance 79390576-dd09-4f1c-a925-5f8d30c83bdc is not yet associated with a host." at the point i see the trace back in my setup. so im guessing if we win the race so that nova has assocaited the instance with the host cyborg expolodes | 00:18 |
dansmith | okay that's an expected situation for the fake driver | 00:19 |
dansmith | should not be tracing on the cyborg side, but.. | 00:19 |
sean-k-mooney | well both are the fake driver | 00:19 |
sean-k-mooney | anyway tomorrows problem o/ | 00:20 |
*** mlavalle has quit IRC | 00:22 | |
*** rcernin has joined #openstack-nova | 01:06 | |
*** bbowen has quit IRC | 01:11 | |
*** slaweq_ has joined #openstack-nova | 01:11 | |
*** bbowen has joined #openstack-nova | 01:11 | |
*** Liang__ has joined #openstack-nova | 01:12 | |
*** slaweq_ has quit IRC | 01:16 | |
*** mdbooth has quit IRC | 01:20 | |
*** mdbooth has joined #openstack-nova | 01:22 | |
*** ociuhandu has joined #openstack-nova | 01:31 | |
*** ociuhandu has quit IRC | 01:35 | |
*** TxGirlGeek has quit IRC | 01:36 | |
*** vesper has joined #openstack-nova | 01:38 | |
huaqiang | stephenfin: got your message, thanks. | 01:38 |
*** vesper11 has quit IRC | 01:39 | |
*** igordc has joined #openstack-nova | 01:52 | |
*** gyee has quit IRC | 02:00 | |
*** Liang__ has quit IRC | 02:04 | |
*** vishalmanchanda has joined #openstack-nova | 02:10 | |
*** damien_r has joined #openstack-nova | 02:11 | |
*** TxGirlGeek has joined #openstack-nova | 02:45 | |
*** mkrai has joined #openstack-nova | 03:08 | |
*** slaweq_ has joined #openstack-nova | 03:11 | |
*** TxGirlGeek has quit IRC | 03:14 | |
*** slaweq_ has quit IRC | 03:16 | |
*** rcernin has quit IRC | 03:31 | |
*** nweinber_ has joined #openstack-nova | 03:34 | |
*** TxGirlGeek has joined #openstack-nova | 03:38 | |
*** kiseok7 has quit IRC | 03:39 | |
*** nweinber_ has quit IRC | 04:10 | |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: Bump compute rpcapi version and reduce Cyborg calls. https://review.opendev.org/704227 | 04:31 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: Add cyborg tempest job. https://review.opendev.org/670999 | 04:31 |
*** links has joined #openstack-nova | 04:43 | |
*** adriant has quit IRC | 04:45 | |
*** adriant has joined #openstack-nova | 04:49 | |
*** udesale has joined #openstack-nova | 04:53 | |
*** bnemec has joined #openstack-nova | 04:53 | |
*** hongbin has joined #openstack-nova | 04:55 | |
*** rcernin has joined #openstack-nova | 04:57 | |
*** rcernin has quit IRC | 04:58 | |
*** rcernin has joined #openstack-nova | 04:58 | |
*** igordc has quit IRC | 04:59 | |
*** slaweq_ has joined #openstack-nova | 05:11 | |
*** slaweq_ has quit IRC | 05:15 | |
*** TxGirlGeek has quit IRC | 05:20 | |
*** hongbin has quit IRC | 05:28 | |
*** evrardjp has quit IRC | 05:33 | |
*** evrardjp has joined #openstack-nova | 05:34 | |
*** ratailor has joined #openstack-nova | 05:40 | |
*** mkrai has quit IRC | 05:43 | |
*** mkrai has joined #openstack-nova | 05:57 | |
*** rcernin has quit IRC | 06:03 | |
*** Liang__ has joined #openstack-nova | 06:05 | |
*** tetsuro has joined #openstack-nova | 06:06 | |
*** tetsuro has quit IRC | 06:10 | |
*** tetsuro has joined #openstack-nova | 06:15 | |
*** Liang__ has quit IRC | 06:16 | |
*** tetsuro has quit IRC | 06:27 | |
openstackgerrit | Qiu Fossen proposed openstack/nova-specs master: Support fuzzy querying instance by tag https://review.opendev.org/691651 | 06:37 |
*** tetsuro has joined #openstack-nova | 06:58 | |
*** tetsuro has quit IRC | 07:01 | |
*** tetsuro has joined #openstack-nova | 07:01 | |
*** tetsuro has quit IRC | 07:02 | |
*** tetsuro has joined #openstack-nova | 07:03 | |
*** slaweq_ has joined #openstack-nova | 07:11 | |
*** slaweq_ has quit IRC | 07:16 | |
*** tetsuro has quit IRC | 07:17 | |
huaqiang | ls | 07:18 |
*** tetsuro has joined #openstack-nova | 07:19 | |
*** tetsuro has quit IRC | 07:19 | |
*** tetsuro has joined #openstack-nova | 07:20 | |
*** MUUSEE_ has joined #openstack-nova | 07:21 | |
MUUSEE_ | Hi can anyone help me with a query regarding " libvirt: virtio-net multiqueue " | 07:23 |
*** tetsuro has quit IRC | 07:31 | |
*** tetsuro has joined #openstack-nova | 07:32 | |
*** yedongcan has joined #openstack-nova | 07:34 | |
*** ociuhandu has joined #openstack-nova | 07:38 | |
*** jaosorior has joined #openstack-nova | 07:38 | |
*** dpawlik has joined #openstack-nova | 07:49 | |
*** ociuhandu has quit IRC | 07:50 | |
*** dpawlik has quit IRC | 07:53 | |
*** jaosorior has quit IRC | 07:53 | |
*** iurygregory has quit IRC | 07:53 | |
*** dpawlik has joined #openstack-nova | 07:56 | |
*** tetsuro has quit IRC | 07:57 | |
*** tetsuro has joined #openstack-nova | 08:00 | |
*** slaweq_ has joined #openstack-nova | 08:00 | |
*** maciejjozefczyk has joined #openstack-nova | 08:03 | |
*** jaosorior has joined #openstack-nova | 08:06 | |
*** slaweq__ has joined #openstack-nova | 08:09 | |
*** slaweq_ has quit IRC | 08:10 | |
*** iurygregory has joined #openstack-nova | 08:11 | |
*** tkajinam has quit IRC | 08:12 | |
*** tetsuro has quit IRC | 08:14 | |
*** slaweq has joined #openstack-nova | 08:14 | |
*** tesseract has joined #openstack-nova | 08:16 | |
*** slaweq__ has quit IRC | 08:16 | |
*** ociuhandu has joined #openstack-nova | 08:30 | |
*** rcernin has joined #openstack-nova | 08:31 | |
*** rpittau|afk is now known as rpittau | 08:34 | |
*** ociuhandu has quit IRC | 08:34 | |
*** ociuhandu has joined #openstack-nova | 08:36 | |
*** ociuhandu has quit IRC | 08:40 | |
gibi | cores: easy +A potential https://review.opendev.org/#/c/698053 | 08:42 |
*** ralonsoh has joined #openstack-nova | 08:42 | |
*** ociuhandu has joined #openstack-nova | 08:44 | |
bauzas | gibi: looking | 08:45 |
bauzas | easy indeed | 08:45 |
*** rcernin has quit IRC | 08:48 | |
*** slaweq has quit IRC | 08:48 | |
*** slaweq_ has joined #openstack-nova | 08:49 | |
*** ociuhandu has quit IRC | 08:49 | |
*** rcernin has joined #openstack-nova | 08:54 | |
*** xek has joined #openstack-nova | 08:54 | |
*** ociuhandu has joined #openstack-nova | 08:59 | |
*** slaweq__ has joined #openstack-nova | 09:06 | |
*** slaweq_ has quit IRC | 09:07 | |
*** rcernin has quit IRC | 09:07 | |
*** ociuhandu has quit IRC | 09:13 | |
*** rcernin has joined #openstack-nova | 09:16 | |
*** rcernin has quit IRC | 09:20 | |
*** slaweq__ is now known as slaweq | 09:25 | |
*** rcernin has joined #openstack-nova | 09:26 | |
*** ociuhandu has joined #openstack-nova | 09:32 | |
*** rcernin has quit IRC | 09:33 | |
*** martinkennelly has joined #openstack-nova | 09:35 | |
*** ociuhandu has quit IRC | 09:38 | |
*** derekh has joined #openstack-nova | 09:40 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: Store instance action event exc_val fault details https://review.opendev.org/694428 | 09:55 |
*** ociuhandu has joined #openstack-nova | 10:14 | |
*** ociuhandu has quit IRC | 10:20 | |
openstackgerrit | Qiu Fossen proposed openstack/nova-specs master: specify mac for creating instance https://review.opendev.org/700429 | 10:36 |
openstackgerrit | Merged openstack/nova master: Minor improvements to cell commands https://review.opendev.org/698053 | 10:37 |
*** abhishekk is now known as abhishekk|away | 10:39 | |
*** slaweq_ has joined #openstack-nova | 10:40 | |
*** slaweq has quit IRC | 10:42 | |
*** yedongcan has left #openstack-nova | 10:53 | |
*** slaweq__ has joined #openstack-nova | 11:01 | |
*** slaweq_ has quit IRC | 11:03 | |
*** mkrai has quit IRC | 11:05 | |
stephenfin | gibi: Could you revisit https://review.opendev.org/#/c/705760/ ? ralonsoh spotted some paths I'd missed | 11:07 |
stephenfin | and dansmith had comments but I've addressed them, afaict | 11:07 |
*** rpittau is now known as rpittau|bbl | 11:10 | |
*** sandonov has joined #openstack-nova | 11:12 | |
sandonov | openstack-nova | 11:12 |
*** udesale_ has joined #openstack-nova | 11:13 | |
*** sandonov has left #openstack-nova | 11:14 | |
*** udesale has quit IRC | 11:16 | |
*** gentoorax has quit IRC | 11:17 | |
*** gentoorax has joined #openstack-nova | 11:18 | |
*** psachin has joined #openstack-nova | 11:30 | |
openstackgerrit | Brin Zhang proposed openstack/nova-specs master: FUP: Fixed the invalid index in References https://review.opendev.org/705933 | 11:35 |
*** pcaruana has quit IRC | 11:37 | |
*** MUUSEE_ has quit IRC | 11:41 | |
*** tbachman has quit IRC | 11:44 | |
*** pcaruana has joined #openstack-nova | 11:50 | |
*** ociuhandu has joined #openstack-nova | 11:52 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove unused 'cache_utils' APIs https://review.opendev.org/705652 | 11:52 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Address TODO https://review.opendev.org/705653 | 11:52 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Bump minimum version of websockify https://review.opendev.org/705654 | 11:52 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Merge unnecessary 'NovaProxyRequestHandlerBase' separation https://review.opendev.org/705655 | 11:52 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove 'run_once' helper https://review.opendev.org/705656 | 11:52 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Integrate mypy https://review.opendev.org/676208 | 11:52 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: mypy: Add type annotations to 'nova.pci' https://review.opendev.org/676209 | 11:52 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: mypy: Add nova.cmd, nova.conf, nova.console https://review.opendev.org/705657 | 11:52 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: mypy: Add type annotations to top-level modules https://review.opendev.org/705658 | 11:52 |
*** mkrai has joined #openstack-nova | 11:52 | |
*** ociuhandu has quit IRC | 11:58 | |
kashyap | stephenfin: Hiya; I've addressed your questions, and added additional useful bits where needed: https://review.opendev.org/#/c/693844/ | 12:03 |
*** ociuhandu has joined #openstack-nova | 12:05 | |
*** derekh has quit IRC | 12:07 | |
*** derekh has joined #openstack-nova | 12:08 | |
*** ociuhandu has quit IRC | 12:11 | |
*** tosky has joined #openstack-nova | 12:12 | |
*** ociuhandu has joined #openstack-nova | 12:17 | |
*** Liang__ has joined #openstack-nova | 12:19 | |
*** slaweq__ has quit IRC | 12:19 | |
*** ociuhandu has quit IRC | 12:22 | |
*** slaweq__ has joined #openstack-nova | 12:23 | |
openstackgerrit | Merged openstack/nova master: nova-net: Remove use of legacy 'SecurityGroup' object https://review.opendev.org/697155 | 12:25 |
*** mkrai has quit IRC | 12:26 | |
*** mriosfer has joined #openstack-nova | 12:28 | |
*** brinzhang has joined #openstack-nova | 12:29 | |
*** brinzhang has quit IRC | 12:30 | |
*** brinzhang has joined #openstack-nova | 12:30 | |
*** brinzhang has quit IRC | 12:31 | |
*** brinzhang has joined #openstack-nova | 12:32 | |
*** amoralej has joined #openstack-nova | 12:34 | |
mriosfer | Hi, We got Openstack Queens RDO. Some customers are telling us that their Windows VM CPU performs bad as a hell. We deployed the lasted virtio already to check improvements. I got a video an its true work its frustating, I/O is less than <1ms | 12:36 |
sean-k-mooney | what are you deploying on libvirt/kvm | 12:40 |
sean-k-mooney | the first thing i woudl do is alter the cpu topology to be sane for windows | 12:41 |
sean-k-mooney | by defualt we allcoate 1 cpu socket per favor.vcpu | 12:41 |
mriosfer | we're ussing quemu-kvm for instances . | 12:42 |
sean-k-mooney | if the guest dont have a numa toplogy set hw:cpu_sockets=1 and hw:cpu:threads=2 | 12:42 |
mriosfer | How do you do that? | 12:42 |
sean-k-mooney | assuming the host has Hyper thread enabled. | 12:42 |
mriosfer | yes of course | 12:43 |
mriosfer | do you setup that extra features in the flavors? | 12:43 |
sean-k-mooney | yes you can do it in the flavor or image | 12:43 |
sean-k-mooney | in the image its hw_ instead of hw: | 12:43 |
mriosfer | i prefer image | 12:44 |
sean-k-mooney | that should help the windows shcduler if you have more then 4 vcpu in the vm | 12:44 |
mriosfer | yes.. some cpu got 8cpu or 12vcpu | 12:44 |
mriosfer | and with terminal server the performance its terrible | 12:44 |
sean-k-mooney | ya so windows will see that as 8 to 12 cpu sockets with out default setting | 12:45 |
*** brinzhang has quit IRC | 12:45 | |
sean-k-mooney | the next thing to look at would be the graphics device model | 12:45 |
sean-k-mooney | you said you were on queens | 12:45 |
mriosfer | yes | 12:45 |
mriosfer | our nodes dont have pcie addtional graphic card just the integrated one by Dell | 12:45 |
sean-k-mooney | ya that is ok | 12:46 |
sean-k-mooney | on train+ would suggest using the virtio gpu but on queens you should set hw_video_model=qxl | 12:46 |
sean-k-mooney | i belive qxl is the best performing graphic device that qemu can emulate prior to support for virtio | 12:47 |
sean-k-mooney | https://github.com/openstack/glance/blob/master/etc/metadefs/compute-libvirt-image.json#L71-L84 | 12:47 |
sean-k-mooney | you could also use the hw_video_ram element to increase that | 12:47 |
sean-k-mooney | i belive it default to 64mb | 12:47 |
mriosfer | thath ram uses the instance ram no? | 12:48 |
sean-k-mooney | no | 12:48 |
sean-k-mooney | its addtional host ram | 12:48 |
mriosfer | oh , ok | 12:48 |
sean-k-mooney | it can only be set on the image if the flavor allows it by setting hw_video:ram_max_mb | 12:48 |
sean-k-mooney | i would start with the qxl video model and then if that is not enough after the cpu changes then increae the ram to say 128 or 256 | 12:49 |
mriosfer | sean do you know why error? https://gyazo.com/10156259f833a20decbdce821ef8e31b | 12:49 |
sean-k-mooney | yes | 12:50 |
sean-k-mooney | this is one of the model that is in the metadefs | 12:50 |
sean-k-mooney | so there is a drop down for it | 12:50 |
sean-k-mooney | use the filter box above | 12:50 |
sean-k-mooney | instead of a custom filed | 12:50 |
sean-k-mooney | our you can scoll down there should be a libvirt dropdown in the availabel metadata | 12:51 |
mriosfer | oh | 12:51 |
*** damien_r has quit IRC | 12:51 | |
mriosfer | im fuck*** noob | 12:51 |
sean-k-mooney | the gui is "trying" to be help full | 12:52 |
sean-k-mooney | it actully really annoyed me when they added that "feature"] | 12:52 |
mriosfer | rebooting instance will apply the new changes? | 12:52 |
sean-k-mooney | no | 12:52 |
sean-k-mooney | unfortunetly not | 12:52 |
sean-k-mooney | you can only update the instnace with a rebuild | 12:53 |
sean-k-mooney | which would loose data on the root disk | 12:53 |
mriosfer | oh fuck | 12:53 |
sean-k-mooney | we make a copy of the data in the vm when we boot it so that it intentionall will not be affected by change in glance | 12:54 |
sean-k-mooney | if we did not you could break all your deployed vms with a typo | 12:54 |
sean-k-mooney | which would be bad | 12:54 |
sean-k-mooney | in your case once you are happy with the final image and its performace | 12:54 |
mriosfer | mmm maybe i can do a workarround at ceph level :) | 12:55 |
sean-k-mooney | you could do a db update to add the missing keys to the copy | 12:55 |
sean-k-mooney | then a hard reboot of the vm would fix it | 12:55 |
sean-k-mooney | i belive we store the instance image keys in the system_metadata table prefixed with img_ | 12:56 |
mriosfer | now looks much better the image : https://gyazo.com/cacf129fc79e2f1b23b607704b645d71 | 12:56 |
sean-k-mooney | yes but you will need to update the flaovr to have the hw_video_ram work | 12:56 |
*** ociuhandu has joined #openstack-nova | 12:57 | |
sean-k-mooney | the reason being we did not want tenant to be abel to upload there own image and request 256GB of video ram | 12:58 |
mriosfer | do you also setup the Max vCPU threats and vCpu Cores at flavor level? | 12:59 |
sean-k-mooney | you dont need too but can | 12:59 |
sean-k-mooney | for the video ram it will hit this code https://github.com/openstack/nova/blob/a948a803b561606a892133940915caae610c080b/nova/virt/vmwareapi/vmops.py#L334-L338 | 12:59 |
mriosfer | that just for vmware no? | 13:00 |
sean-k-mooney | oh wrong file let me check the libvirt driver | 13:00 |
sean-k-mooney | vmware would reject it if the flavor is not set | 13:00 |
sean-k-mooney | ya its the same https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L5057-L5063 | 13:01 |
sean-k-mooney | i would just lave that out for now | 13:01 |
sean-k-mooney | as you would also have to update the embeded copy of the flavor or do a resize to pick up the change | 13:02 |
mriosfer | yes i will do for sure | 13:02 |
sean-k-mooney | if you find qxl and the toplogy chagne are not enough the try the ram change | 13:02 |
mriosfer | if it works i will send you a pack a beers! | 13:03 |
sean-k-mooney | ha :) well on other question is the slowness you are finding with the horizon console or do you still see that with rdp in the guest | 13:03 |
mriosfer | i see in the rdp guest | 13:04 |
stephenfin | bauzas: Assuming efried and dansmith aren't online yet, I think you ought to look at this and send it through so we can unblock neutron | 13:04 |
mriosfer | i dont recomend users work through horizon | 13:04 |
sean-k-mooney | right ok then ya this shoudl help | 13:04 |
stephenfin | We can use a follow-up if dansmith isn't happy with any of my answers | 13:04 |
* bauzas has to disappear for 30 mins | 13:04 | |
sean-k-mooney | i have seen issue with novnc adding lag in the past | 13:05 |
bauzas | stephenfin: which change do you want me ? | 13:05 |
stephenfin | bauzas: oh, whoops https://review.opendev.org/#/c/705760 | 13:05 |
sean-k-mooney | not in recent times but i had to swap to spice at one point to work around it | 13:05 |
bauzas | ah | 13:05 |
bauzas | will look at it in 30 mins | 13:05 |
stephenfin | perfect, thanks :) | 13:05 |
sean-k-mooney | mriosfer: anyway hopefully that will help | 13:05 |
sean-k-mooney | im going to go get lunch | 13:06 |
mriosfer | yes be sure that yes at least much more than google | 13:07 |
* mriosfer lunch | 13:07 | |
*** tbachman has joined #openstack-nova | 13:10 | |
*** slaweq has joined #openstack-nova | 13:11 | |
*** ratailor has quit IRC | 13:12 | |
*** slaweq__ has quit IRC | 13:13 | |
*** ociuhandu has quit IRC | 13:13 | |
*** mkrai has joined #openstack-nova | 13:15 | |
*** rpittau|bbl is now known as rpittau | 13:15 | |
*** smcginnis|FOSDEM is now known as smcginnis | 13:19 | |
*** brinzhang has joined #openstack-nova | 13:20 | |
*** brinzhang_ has joined #openstack-nova | 13:20 | |
*** damien_r has joined #openstack-nova | 13:20 | |
*** ociuhandu has joined #openstack-nova | 13:22 | |
*** lpetrut has joined #openstack-nova | 13:24 | |
*** ociuhandu has quit IRC | 13:27 | |
*** ociuhandu has joined #openstack-nova | 13:28 | |
*** ociuhandu has quit IRC | 13:29 | |
*** ociuhandu has joined #openstack-nova | 13:29 | |
*** amoralej is now known as amoralej|lunch | 13:31 | |
*** mkrai has quit IRC | 13:35 | |
*** liuyulong has joined #openstack-nova | 13:58 | |
*** Liang__ is now known as LiangFang | 14:00 | |
*** eharney has joined #openstack-nova | 14:01 | |
*** amoralej|lunch is now known as amoralej | 14:01 | |
*** rpittau is now known as rpittau|mtg | 14:03 | |
*** HagunKim has quit IRC | 14:04 | |
*** dtantsur is now known as dtantsur|brb | 14:05 | |
*** nweinber has joined #openstack-nova | 14:10 | |
gibi | stephenfin: I have a question in https://review.opendev.org/#/c/705784/1/nova/network/neutron.py@2662 | 14:15 |
*** pcaruana has quit IRC | 14:17 | |
bauzas | sean-k-mooney: efried: I'm currently writing a new revision for https://review.opendev.org/#/c/552924 given https://etherpad.openstack.org/p/mem_page_size_and_placement | 14:24 |
bauzas | sean-k-mooney: efried: and I'm a bit afraid about a possible issue | 14:24 |
bauzas | should we always ask for MEMORY_PAGE_SIZE_SMALL ? | 14:25 |
*** rpittau|mtg is now known as rpittau | 14:25 | |
bauzas | I mean, if so, we won't get hosts not having NUMA topogilies | 14:25 |
*** psachin has quit IRC | 14:25 | |
bauzas | topologies | 14:25 |
bauzas | eg. a flavor with VCPU=2 and MEMORY_MB=4096 | 14:26 |
bauzas | (see https://etherpad.openstack.org/p/mem_page_size_and_placement L62) | 14:27 |
*** ociuhandu has quit IRC | 14:29 | |
stephenfin | gibi: replied | 14:31 |
stephenfin | gibi: tl;dr: in theory yes, but I don't think we need to worry about it | 14:31 |
stephenfin | cos quotas | 14:31 |
dansmith | stephenfin: bauzas: replied in the neutron fix thing.. I didn't -1 and there was no need to hold it for me, I was just unsure (still am a little) but if it's right and works... | 14:32 |
gibi | stephenfin: OK, thanks | 14:32 |
*** ociuhandu has joined #openstack-nova | 14:33 | |
efried | bauzas: Remember, these queries are only for flavors that *do* request a NUMA topology. | 14:34 |
bauzas | efried: ok, if so I was confused by L62 | 14:34 |
bauzas | and I agree with you | 14:34 |
efried | in the spec or the etherpad? | 14:34 |
*** jamesdenton has joined #openstack-nova | 14:34 | |
bauzas | in the etherpad like I said | 14:35 |
bauzas | dansmith: ack, like I said, I'm not really a network expert so I was afraid you should have concerns | 14:35 |
efried | bauzas: Yeah, so best to confirm with sean-k-mooney, but I think if no page size is requested, you want to add MEMORY_PAGE_SIZE_SMALL, because that's the default today. | 14:35 |
bauzas | you at least know it better than me :) | 14:35 |
bauzas | efried: that's my point | 14:36 |
efried | bauzas: And no, you won't land on a host that doesn't have the NUMA split. But you weren't going to land there anyway, because segregation. | 14:36 |
bauzas | efried: if you don't ask for page sizes, we should call placement with this trait | 14:36 |
efried | yes | 14:36 |
bauzas | we shouldn't* grah | 14:36 |
efried | we *should* | 14:36 |
efried | because otherwise you might land on huge pages | 14:36 |
efried | which we don't want. | 14:36 |
bauzas | efried: then, if so, you won't get other hosts | 14:36 |
efried | If by "other hosts" you mean flat non-NUMA hosts, that's correct, and that's what we want. | 14:37 |
bauzas | the ones that don't have this trait, ie. the ones that weren't modified | 14:37 |
bauzas | right | 14:37 |
bauzas | but, | 14:37 |
bauzas | see the problem | 14:37 |
efried | I don't | 14:37 |
efried | not yet | 14:37 |
bauzas | example | 14:37 |
bauzas | : | 14:37 |
*** brinzhang_ has quit IRC | 14:37 | |
*** ociuhandu has quit IRC | 14:37 | |
bauzas | I'm an operator and I don't configure any host for asking a NUMA topology | 14:38 |
bauzas | so, none of my hosts have this trait | 14:38 |
bauzas | now, I have existing flavors | 14:38 |
bauzas | but I upgrade to Ussuri | 14:38 |
bauzas | and then the scheduler now transforms the Placement call to ask for this trait | 14:39 |
bauzas | then I will get NoValidHosts | 14:39 |
stephenfin | dansmith: replied (you read it correctly, yeah) | 14:39 |
bauzas | efried: I don't see a way to say : ask for this trait for all NUMA hosts, but don't ask for it for the others | 14:40 |
efried | bauzas: We talked about this yesterday a bit. You're correct: if you upgrade but don't switch your hosts to NUMA-aware, you won't be able to land NUMA flavors. That's as designed. | 14:41 |
dansmith | stephenfin: can you read my reply just now in that case? | 14:41 |
sean-k-mooney | efried: i need to sumerise the options for the config option in the spec form the irc conversation and other i had. ill try and do that in about an hour | 14:42 |
sean-k-mooney | i need to run to the bank now | 14:42 |
stephenfin | dansmith: I think what's there is correct | 14:42 |
stephenfin | line 2678 is going to retrieve the list of ports, which will look like this https://docs.openstack.org/api-ref/network/v2/?expanded=list-ports-detail#list-ports | 14:43 |
bauzas | efried: I'm unclear sorry | 14:44 |
sean-k-mooney | bauzas: efried if we go with the bool config option one of the out standing question is the default for that value. long term it should default to true. not sure if we should default to true in u or v however | 14:44 |
efried | bauzas: one way or another, you're going to have to decide which hosts are going to NUMA and which are going to be flat. | 14:44 |
sean-k-mooney | any brb | 14:44 |
dansmith | stephenfin: I was going on the blob you put in the comment, but maybe that's wrong? I don't see a nested port_details in he api ref like you have in your blob | 14:44 |
stephenfin | dansmith: Oh, there isn't one | 14:44 |
stephenfin | This is something I made up | 14:45 |
stephenfin | wait | 14:45 |
bauzas | efried: if we say that this trait is needed *anyway* (eg. even with a standard flavor asking for memory and vcpus), then I'm afraid we would get NoValidHosts for "flat" hosts | 14:45 |
stephenfin | dansmith: Sorry, confusing myself. I made up the 'network_details' field | 14:46 |
stephenfin | but the port_details field _is_ returned by the '/v2.0/floatingips' API https://docs.openstack.org/api-ref/network/v2/?expanded=list-ports-detail,list-floating-ips-detail#list-floating-ips | 14:46 |
bauzas | efried: unless "flat" hosts also have this trait | 14:46 |
efried | bauzas: we were going to get that anyway. One way or another, with the proposed segregation, NUMA flavors will all & only land on hosts with the NUMA flag on; and flat flavors will all & only land on hosts with the NUMA flag off. | 14:46 |
dansmith | stephenfin: right, isn't that what you're trying to fake/fill-in here? | 14:46 |
efried | That's what we *want* | 14:47 |
stephenfin | port_details, yeah | 14:47 |
bauzas | efried: the latter is not what we agreed | 14:47 |
stephenfin | but it's not always there | 14:47 |
efried | um | 14:47 |
stephenfin | it's dependent on the extension being present/enabled | 14:47 |
dansmith | stephenfin: right, so I get that part | 14:47 |
bauzas | efried: flat flavors will get NoValidHosts | 14:47 |
bauzas | because we're asking for a trait anyway | 14:47 |
efried | They will only get NVH if you don't have any flat hosts in your cloud | 14:48 |
dansmith | stephenfin: the thing I'm asking is whether or not ports[port_id] is equivalent to the port_details field on that api, because according to the example blob in your comment from just now, it should have port_details *inside* it | 14:48 |
bauzas | efried: no, again | 14:48 |
bauzas | see L62 | 14:48 |
dansmith | stephenfin: but I don't see that on the list_ports api-ref, so I think that example blob is wrong about that nesting.. right? | 14:48 |
bauzas | if we ask for MEMORY_PAGE_SIZE_SMALL, then all flat hosts won't get it | 14:48 |
sean-k-mooney | bauzas: we wont alway add the trait:numa_node=require trait only if you request numa | 14:48 |
efried | bauzas: ohh, I see the confusion. | 14:48 |
efried | You only add MEMORY_PAGE_SIZE_SMALL if you're translating a *NUMA* flavor | 14:48 |
efried | yeah, what sean-k-mooney said. | 14:49 |
bauzas | again, L62 is very confusing | 14:49 |
efried | The etherpad is only talking about what we do for NUMA-aware hosts | 14:49 |
efried | and yeah, the etherpad is confusing, so we should really write it more cleanly, say, in a spec :P | 14:49 |
bauzas | there are gaps then that I need to provide | 14:49 |
bauzas | ok, then we need to trigger exactly when asking for this trait | 14:50 |
*** links has quit IRC | 14:50 | |
stephenfin | dansmith: Not sure I get you, so apologies if I repeat stuff you already know | 14:50 |
efried | bauzas: All of the stuff in the etherpad is triggered under the same condition: if the flavor asks for a numa topo. | 14:50 |
stephenfin | if the extension is present, we'd expect a response like this http://paste.openstack.org/show/789164/ | 14:50 |
stephenfin | If that's not enabled, the port_details field isn't present so we add it manually | 14:51 |
dansmith | stephenfin: yes, understand, it's the "adding it manually" part I'm talking about | 14:51 |
dansmith | stephenfin: but let me just stop you for a sec | 14:51 |
efried | bauzas: there are things other than PAGE_SIZE_* that make sure you always & only land on a NUMA host. For instance, the NUMA_ROOT trait. | 14:51 |
dansmith | stephenfin: I think the problem is in a comment by you on the gerrit review, not the code as it is now, if i'm reading the api-ref correctly | 14:51 |
bauzas | efried: correct, but I need to think about this | 14:52 |
dansmith | stephenfin: are we able to test this with an old or duly configured neutron (i.e. without that extension) to prove it works? other than you manually with a devstack? | 14:52 |
efried | okay. Happy to help. (I have a call at the top of the hour FYI.) | 14:52 |
bauzas | cool | 14:52 |
stephenfin | dansmith: Yeah, let me whip up a functional test real quick | 14:53 |
stephenfin | this is what I expect our "fake" response to look like with this change, btw http://paste.openstack.org/show/789165/ | 14:53 |
stephenfin | we only return the list, stripping the outer container, of course | 14:53 |
*** ociuhandu has joined #openstack-nova | 14:54 | |
dansmith | stephenfin: yeah understand that's the desired output of your function | 14:54 |
dansmith | stephenfin: a functional test isn't going to tell us anything if you're faking the response from neutron I think | 14:54 |
stephenfin | It should, assuming our mock of the 'list_ports' API is correct | 14:55 |
stephenfin | which I really hope it is since we use it everywhere | 14:55 |
stephenfin | Could we do a depends-on from the affected neutron project(s)? | 14:55 |
dansmith | oh, maybe I misunderstood you.. stephenfin when you said "Oh, yes, that exactly. This should return something like:" did you mean "this whole function should return..." or did you mean "list_ports should return" | 14:55 |
stephenfin | Doh /o\ "This" = this function, not "list_ports" | 14:56 |
dansmith | okay, I had quoted and was asking about list_ports originally, so I thought you were giving me the output of list_ports | 14:57 |
stephenfin | Yup, my mistake. Sorry | 14:57 |
dansmith | this is why I was saying I think the comment is the problem, because api-ref makes it look like your code is correct | 14:57 |
stephenfin | Yeah, per api-ref 'list_ports' will return something like https://docs.openstack.org/api-ref/network/v2/?expanded=list-ports-detail#list-ports of course | 14:58 |
dansmith | yeah when I first asked, I was expecting a detail=True to get the detailed listing, which I think is how ours works | 14:58 |
stephenfin | Yup, I don't think we need that since we don't need the detailed view. 'device_id' is the only thing we do care about and that's always there | 15:00 |
dansmith | you mean for our current usage I guess | 15:00 |
stephenfin | yeah | 15:00 |
stephenfin | if the extension is enabled and 'port_details' _is_ present, we'd only be getting a summary view anyway | 15:00 |
dansmith | if we only put device_id in there, then someday someone could expect port_details to be full and not understand why it's not | 15:00 |
stephenfin | we could, but given these are only used by the deprecated network API proxies, I figured the risk was low | 15:01 |
dansmith | I'm assuming this is only a neutron-goes-first upgrade scenario and we'll never hit this in the future because someone turned off this extension | 15:01 |
dansmith | right | 15:01 |
stephenfin | I'm under the impression that the networking backends choose their extensions or something | 15:02 |
stephenfin | because ralonsoh referred to OVN specifically | 15:02 |
dansmith | really? | 15:02 |
stephenfin | and we didn't see this blow up in our gate, which I guess is using ml2-ovs or ml2-lb | 15:02 |
ralonsoh | stephenfin, yes, this is failing in OVN | 15:02 |
ralonsoh | but this could happen in other situations, luckily we found it in the CI | 15:03 |
stephenfin | ralonsoh: am I correct in thinking that's because networking-ovn needs to add support for this extension? | 15:03 |
ralonsoh | stephenfin, it can... but this is not a requirement | 15:03 |
stephenfin | well, what was networking-ovn and is now in the core | 15:03 |
stephenfin | right, and ml2-ovs _does_ have it? | 15:04 |
ralonsoh | yes | 15:04 |
stephenfin | dansmith: ^ | 15:04 |
dansmith | yikes :/ | 15:04 |
stephenfin | so I should probably bug lucasagomes or someone to go add that for us at some point | 15:05 |
stephenfin | can I just say neutron's extension model is weird :) | 15:05 |
ralonsoh | stephenfin, I can do it | 15:05 |
stephenfin | not bad. just weird | 15:05 |
ralonsoh | but as commented, this is not mandatory | 15:05 |
ralonsoh | https://github.com/openstack/openstacksdk/blob/master/openstack/network/v2/floating_ip.py#L60-L64 | 15:05 |
stephenfin | ralonsoh: No huge panic. Again, this is only used by deprecated networking proxy APIs in nova, which we'd be hoping no one would be using any more | 15:06 |
stephenfin | but then again, OVN is the future so... | 15:06 |
* stephenfin thinks if we hit something like this again, we might want to consider a gating OVN tempest job | 15:07 | |
*** tbachman has quit IRC | 15:08 | |
*** mriedem has joined #openstack-nova | 15:10 | |
*** eharney has quit IRC | 15:13 | |
*** jmlowe has joined #openstack-nova | 15:13 | |
*** jmlowe has quit IRC | 15:17 | |
*** jmlowe has joined #openstack-nova | 15:17 | |
*** awestin1 has quit IRC | 15:19 | |
*** awestin1 has joined #openstack-nova | 15:20 | |
*** ociuhandu_ has joined #openstack-nova | 15:22 | |
*** CeeMac has joined #openstack-nova | 15:25 | |
sean-k-mooney | we could run a ovn job on nova and have it trigger on any cnages to nova/network subtree | 15:25 |
sean-k-mooney | we can just grab the neutorn one and set a filter on ther files | 15:25 |
*** ociuhandu has quit IRC | 15:25 | |
sean-k-mooney | want me to submit a patch for that? | 15:26 |
*** ociuhandu_ has quit IRC | 15:27 | |
sean-k-mooney | by the way im not sure we need the port detail form the floating ip. we need the port detail from the port that has the floating ip but that is different | 15:27 |
sean-k-mooney | stephenfin: ralonsoh ^ i have been looking at other things so im not fully in sync with what the patch/code is doing and your conversation | 15:28 |
*** lpetrut has quit IRC | 15:28 | |
sean-k-mooney | but the only thing nova uses is the port detail form the neutron port itself | 15:28 |
ralonsoh | sean-k-mooney, I've submitted a patch to add this extension in OVN | 15:29 |
sean-k-mooney | that will always be populated if the port is bound | 15:29 |
ralonsoh | https://review.opendev.org/#/c/705982/ | 15:29 |
sean-k-mooney | ralonsoh: sure but nova never need that info and enduser should not be relying on it | 15:29 |
ralonsoh | yes, that's why I insisted saying that this extension is not mandatory | 15:30 |
sean-k-mooney | im pretty sure that optional extention was added after we deprecated the proxy apis in nova | 15:30 |
sean-k-mooney | ralonsoh: i assume there is more to supporting the exteion then just adding that 1 line | 15:31 |
ralonsoh | this is the list of supported OVN extensions | 15:32 |
sean-k-mooney | unless this is entrily implement in the ml2 core plugin above the drivers? | 15:32 |
ralonsoh | this dict is used to create the config in the CI too | 15:32 |
sean-k-mooney | right but if networking-ovn does not have code support for it and its not implemented at teh plugin level then that is incorrect to add | 15:32 |
ralonsoh | sean-k-mooney, http://codesearch.openstack.org/?q=ML2_SUPPORTED_API_EXTENSIONS&i=nope&files=&repos= | 15:32 |
sean-k-mooney | so im asking does the networking-ovn ml2 driver need to be extended to supprot it | 15:32 |
ralonsoh | https://opendev.org/openstack/networking-ovn/src/branch/master/networking_ovn/l3/l3_ovn.py | 15:33 |
mriosfer | is recomended enable watchdog in openstack instances? | 15:33 |
sean-k-mooney | ok so this still seams wrong to me you should not need to enable it in the neutorn tree the driver networking-ovn repo should be provideing the support exteion list | 15:34 |
sean-k-mooney | mriosfer: am i dont know of any guidence either way. if yo need it then you can use it but its just an optional feature some operators wanted | 15:35 |
ralonsoh | sean-k-mooney, this is something still under discussion | 15:35 |
sean-k-mooney | ralonsoh: is the neutron/common/ovn/extensions directory added as part of try ing to merge networking-ovn back in tree | 15:35 |
mriosfer | sean: im going to test your notes in instances right now :) | 15:36 |
ralonsoh | sean-k-mooney, yes, thats in the neutron repo now | 15:36 |
* sean-k-mooney hides in case it goes wrong hehe | 15:36 | |
sean-k-mooney | ralonsoh: so networking-ovn is nolonger required at all | 15:37 |
ralonsoh | nope | 15:37 |
sean-k-mooney | ralonsoh: actully thats off topic we can talk about it someother time | 15:37 |
ralonsoh | sean-k-mooney, sure! | 15:37 |
stephenfin | sean-k-mooney: I changed the behaviour to rely on that 'port_details' field in a recent patch because I didn't know it was an optional extension | 15:42 |
stephenfin | sean-k-mooney: we need that info purely so we can get the 'device_id' field, which is the instance UUID, for the deprecated floating IP proxy APIs | 15:43 |
stephenfin | deprecated by not removed | 15:43 |
sean-k-mooney | we should not need that however. | 15:46 |
sean-k-mooney | we can list the ports assocaiated with an insnatce and then we should eb able to list the floating ips assinged ot each port | 15:47 |
mriosfer | sean : :The requested amount of video memory 128 is higher than the maximum allowed by flavor 0 :( something i changed wrong https://gyazo.com/302f96f1f0e2363da2b9dd10ad741e3e?token=b6e41e022fa6260b90802950e02137bf | 15:47 |
stephenfin | sean-k-mooney: That sounds like a lot more rework though :) | 15:48 |
stephenfin | Possible, yes. Worth it? | 15:48 |
* stephenfin shrugs | 15:48 | |
*** brinzhang has quit IRC | 15:48 | |
*** pcaruana has joined #openstack-nova | 15:49 | |
*** Sundar has joined #openstack-nova | 15:50 | |
mriosfer | sean: found the parameter is : hw_video:ram_max_mb | 15:53 |
*** dtantsur|brb is now known as dtantsur | 15:53 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Rework how we check for extensions https://review.opendev.org/705792 | 15:54 |
sean-k-mooney | mriosfer: that is the flavor one | 15:54 |
sean-k-mooney | yes | 15:54 |
Sundar | sean-k-mooney: I am here if you have any comments or questions about your evaluation of Cyborg patches. | 15:56 |
sean-k-mooney | Sundar: when i tested them yesterday it failed in the cyborg api to send the arq binding notification to nova | 15:56 |
Sundar | sean-k-mooney: Could you point me to the cyborg logs? | 15:59 |
*** ociuhandu has joined #openstack-nova | 16:01 | |
*** TxGirlGeek has joined #openstack-nova | 16:01 | |
*** tbachman has joined #openstack-nova | 16:01 | |
sean-k-mooney | Sundar: http://paste.openstack.org/show/789142/ | 16:02 |
*** eharney has joined #openstack-nova | 16:03 | |
*** tbachman has quit IRC | 16:05 | |
Sundar | sean-k-mooney: Looks like you are pulling in an old version of Cyborg patches. NovaAPIConnectFailure exception has been replaced with InvalidAPIResponse exception: https://review.opendev.org/#/c/698846/6/cyborg/common/nova_client.py | 16:05 |
*** openstackstatus has joined #openstack-nova | 16:05 | |
*** ChanServ sets mode: +v openstackstatus | 16:05 | |
*** ociuhandu has quit IRC | 16:05 | |
mriosfer | sean: dxdiag should show the param of 128MB for vRAM? | 16:06 |
mriosfer | https://gyazo.com/1ad894cd16911a7d6f3a9083fbd65fad | 16:07 |
*** jmlowe has quit IRC | 16:08 | |
sean-k-mooney | i think so yes | 16:09 |
*** brinzhang has joined #openstack-nova | 16:09 | |
sean-k-mooney | but i have not tested that | 16:10 |
*** mlavalle has joined #openstack-nova | 16:18 | |
*** slaweq_ has joined #openstack-nova | 16:23 | |
*** udesale_ has quit IRC | 16:24 | |
*** slaweq has quit IRC | 16:25 | |
mriosfer | humm im not sure if machine is getting the 128MB vram | 16:32 |
mriosfer | sockets and threats now looks better | 16:32 |
efried | dansmith: Left a review on https://review.opendev.org/#/c/631243/ | 16:32 |
efried | TL;DR: the structural comments from PS43 still need to be addressed. | 16:32 |
efried | But dansmith (and gibi) it would be nice if you could scan through my analysis and see if you agree, or if I'm making a big deal out of nothing. | 16:32 |
efried | Basically I'm saying the steps of processing the device profiles should follow the steps of processing bandwidth requests. | 16:33 |
dansmith | efried: I don't have context on the bandwidth stuff to make that comparison, but will read | 16:34 |
efried | dansmith: I seeded the code with comments in the appropriate places, hopefully it's easy enough to follow. | 16:34 |
dansmith | ack | 16:34 |
dansmith | efried: I think we've told him specifically to follow the network_info and block_device_info patterns everywhere, which I think his code does | 16:37 |
dansmith | efried: i.e. make these look like our other attachable things, which are ports and volumes | 16:37 |
efried | I don't think what I'm suggesting deviates from that, does it? | 16:38 |
*** psachin has joined #openstack-nova | 16:38 | |
dansmith | seems like it, but I'm still reading | 16:38 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Report COMPUTE_RESCUE_BFV and check during rescue https://review.opendev.org/701429 | 16:40 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: api: Introduce microverion 2.82 allowing boot from volume rescue https://review.opendev.org/701430 | 16:40 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Extract _get_bdm_image_metadata into nova.utils https://review.opendev.org/705212 | 16:40 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Support boot from volume instance rescue https://review.opendev.org/701431 | 16:40 |
dansmith | I'm also pretty sure we specifically told him to not use the legacy reqspec.from_components stuff | 16:41 |
dansmith | let me see if I can find that | 16:41 |
*** Sundar has quit IRC | 16:42 | |
efried | What he's got will work fine afaict and does seem simpler at first glance. | 16:44 |
efried | My concern is that it's logically very similar to how we're processing port bandwidth requests (pull stuff from flavor and $api, create granular request groups, put them in a special place in the request spec), | 16:44 |
efried | so it would be nice if the reader could follow that logic similarly for both kinds of resource. | 16:44 |
dansmith | https://review.opendev.org/#/c/631243/30/nova/objects/request_spec.py | 16:44 |
dansmith | granted what he was doing was a lot more than what I _think_ you want him using from_components() for | 16:45 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Add MigrationTypeField https://review.opendev.org/706013 | 16:46 |
efried | dansmith: okay, yeah, I agree we shouldn't be doing the api callout from there. In what I'm suggesting, the device_profile_request_groups come into from_components ready-made, just like the port_resource_requests in the preceding chunk. | 16:46 |
dansmith | efried: shouldn't port_resource_requests just be resource_requests though? | 16:46 |
efried | yeah, that would be another great way to do it. | 16:46 |
dansmith | I'd much prefer that than just adding a new parameter of the same type of thing for each high level thing we add | 16:47 |
*** jmlowe has joined #openstack-nova | 16:47 | |
efried | Agree: fold port & device resource requests (and any others in the future) together prior to from_components. ++ | 16:47 |
efried | so yeah -- how early can we fold those together? The earlier the better. | 16:48 |
efried | Maybe as early as the construction of base_options. Need to see how the supports_port_bandwith_requests business plays in. | 16:49 |
dansmith | that's not my preference, I'm just saying if we're still going to call this legacy method to set a single attribute, then they should be combined | 16:49 |
dansmith | what I'd *rather* is he leave what he has here and I follow up and move that port_resource_requests outside of from_components where it belongs in the first place, IMHO | 16:49 |
efried | I just don't love that from_components is initializing resource_requests, and then we're extending it after, outside of that method. | 16:50 |
dansmith | ack, that's legit | 16:50 |
dansmith | so can I follow up after his set and make PRR set after from_components() like he is doing here? | 16:50 |
efried | But you're right, we could easily accept what's here and refactor later. | 16:50 |
dansmith | if so I shall commit to it in writing | 16:51 |
efried | so, remove that as a param from from_components() entirely? | 16:51 |
*** sean-k-mooney has quit IRC | 16:51 | |
dansmith | yeah | 16:51 |
efried | I don't have the big picture on from_components; you hinted we should be able to get rid of it entirely? | 16:51 |
dansmith | it was supposed to be bridge code to get us to objects and removed in mitaka or something | 16:52 |
efried | oh, didn't mriedem propose a WIP that started doing that? | 16:52 |
dansmith | he complained about it a lot, so probably | 16:52 |
efried | https://review.opendev.org/#/c/697686/ ? | 16:53 |
efried | no, not quite | 16:53 |
dansmith | well, that's what you're thinking of probably | 16:53 |
*** artom has quit IRC | 16:54 | |
efried | yeah | 16:54 |
dansmith | regardless, as you can see, from_components is just "set a bunch of things and no other logic" | 16:54 |
*** maciejjozefczyk has quit IRC | 16:54 | |
efried | yeah. but it's common to both build and cold migrate | 16:54 |
dansmith | to what end? | 16:55 |
efried | just DRY | 16:55 |
dansmith | it's not really though | 16:55 |
efried | like, I'm not sure I see a better split logically. Whether we want to get rid of the filter_properties in some way, that's fine | 16:55 |
dansmith | because the actual constructor can take field values | 16:55 |
efried | There's a *little* bit of logic in there. | 16:56 |
efried | All these _from_* methods | 16:56 |
dansmith | okay, I guess so | 16:57 |
dansmith | but that would also kinda mean that the setting of a field that doesn't need any handling shouldn't be in here | 16:57 |
*** tbachman has joined #openstack-nova | 16:58 | |
*** psachin has quit IRC | 16:58 | |
efried | So your refactor would be like the caller doing | 16:58 |
efried | reqspec = RequestSpec(foo=bar, ...) | 16:58 |
efried | for all foo/bar that are static, and then | 16:58 |
efried | reqspec.fold_in_other_shit(filter_properties, maybe_others, ...) | 16:58 |
efried | where the latter is from_components with all the static setters removed? | 16:59 |
dansmith | well, that's a potential bigger refactor, because from_components is a classmethod | 17:00 |
dansmith | and, I'm not sure that would really work with the way the _from things work.. they may expect to "go first" | 17:00 |
dansmith | so I would just take the req_spec that comes from from_components, and follow up with the direct things | 17:01 |
*** brinzhang has quit IRC | 17:01 | |
dansmith | req_spec = from_components(..); req_spec.requested_resources = port_requested_resources + accel_requested_resources; etc | 17:01 |
*** mriosfer has quit IRC | 17:03 | |
*** efried has quit IRC | 17:03 | |
*** efried has joined #openstack-nova | 17:04 | |
efried | I guess I don't see the benefit of assigning some fields in the classmethod and some afterwards. Similar reasoning as mentioned previously: then you always have to go make sure you're assigning the right pieces the right way on the right side of the method boundary. | 17:06 |
efried | but I don't feel strongly enough to -1 that. | 17:06 |
mriedem | beware the request spec quagmire | 17:06 |
efried | I think we're already quagged. | 17:06 |
mriedem | if you go one up that stack https://review.opendev.org/#/c/697697/ and read my comments, unwinding a bunch of that stuff is going to be dependent on doing a major conductor rpc api version | 17:07 |
mriedem | because there is backward compat code to handle the older version | 17:08 |
mriedem | which relies on a lot of this bridge code | 17:08 |
*** iurygregory has quit IRC | 17:08 | |
dansmith | efried: I commented and I'm late for another meeting | 17:08 |
stephenfin | melwitt: Does my reply at https://review.opendev.org/#/c/705654/ make sense? | 17:11 |
stephenfin | before I rewrite the thing | 17:11 |
larsks | asd | 17:12 |
melwitt | stephenfin: oh, wow. so ... we are ok to remove the helper method so long as the minimum python version is 3.6 because the native method is doing the same thing? are we (deployers) guaranteed to not be running <= 3.6 at this point? | 17:15 |
stephenfin | melwitt: yup https://github.com/openstack/nova/blob/master/setup.cfg#L9 | 17:16 |
stephenfin | you can't install nova on anything less | 17:16 |
melwitt | stephenfin: cool, thanks | 17:16 |
melwitt | yup, that all makes sense then | 17:16 |
stephenfin | appears to have been the behavior since Python 3.3 | 17:17 |
stephenfin | https://github.com/python/cpython/blob/v3.3.0/Lib/http/server.py#L562-L565 | 17:17 |
stephenfin | cool, I'll rework that so. Thanks for the review | 17:17 |
*** tbachman_ has joined #openstack-nova | 17:25 | |
*** tbachman has quit IRC | 17:26 | |
melwitt | stephenfin: I just looked this up, apparently the original commit you referenced _would_ fix the issue because the reverse dns lookup was happening as a result of simply logging a message (I did not expect this) https://github.com/openstack/nova/commit/c0f773a616fb48bf699539c5ac18bd9c55a540c9 | 17:28 |
*** gyee has joined #openstack-nova | 17:29 | |
*** tbachman_ has quit IRC | 17:29 | |
stephenfin | melwitt:Oh, fun. Fancy suggesting a commit message I should use? :) | 17:30 |
*** tbachman has joined #openstack-nova | 17:30 | |
melwitt | stephenfin: technically your commit message is right, so I think we can leave it. let me just add a comment and change my vote | 17:32 |
*** evrardjp has quit IRC | 17:33 | |
*** evrardjp has joined #openstack-nova | 17:34 | |
*** igordc has joined #openstack-nova | 17:34 | |
stephenfin | melwitt: Okay. I do need to repush that series to address gibi's comments on the base patch though so if I do need to edit the commit message, let me know in the next 2 mins :) | 17:35 |
*** sean-k-mooney has joined #openstack-nova | 17:36 | |
melwitt | stephenfin: k, I think it's fine as-is | 17:39 |
*** sean-k-mooney has quit IRC | 17:41 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove unused 'cache_utils' APIs https://review.opendev.org/705652 | 17:43 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Fetch 'Service' objects once when building AZs https://review.opendev.org/705653 | 17:43 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Bump minimum version of websockify https://review.opendev.org/705654 | 17:43 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Merge unnecessary 'NovaProxyRequestHandlerBase' separation https://review.opendev.org/705655 | 17:43 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove 'run_once' helper https://review.opendev.org/705656 | 17:43 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Integrate mypy https://review.opendev.org/676208 | 17:43 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: mypy: Add type annotations to 'nova.pci' https://review.opendev.org/676209 | 17:43 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: mypy: Add nova.cmd, nova.conf, nova.console https://review.opendev.org/705657 | 17:43 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: mypy: Add type annotations to top-level modules https://review.opendev.org/705658 | 17:43 |
*** sean-k-mooney has joined #openstack-nova | 17:43 | |
*** vdrok has quit IRC | 17:45 | |
*** vdrok has joined #openstack-nova | 17:45 | |
stephenfin | melwitt: There's a super trivial follow-up to that too, btw, if you'd like to take a look https://review.opendev.org/#/c/705655/ | 17:47 |
stephenfin | I, however, am outta here | 17:47 |
* stephenfin ->🏃 | 17:47 | |
*** dtantsur is now known as dtantsur|afk | 17:48 | |
*** sean-k-mooney1 has joined #openstack-nova | 17:48 | |
efried | sean-k-mooney (sean-k-mooney1): https://blueprints.launchpad.net/nova/+spec/config-tsc-freq looks like something you would be able to grok. I talked to umbSublime and he's interested in working the implementation. At a glance, it seems like it should be fairly straightforward, but I'd like your opinion if you've got a moment to look. | 17:48 |
melwitt | stephenfin: will do | 17:48 |
*** sean-k-mooney has quit IRC | 17:48 | |
*** sean-k-mooney1 is now known as sean-k-mooney | 17:49 | |
sean-k-mooney | ya i was ment to write up a spec/blueprint | 17:49 |
sean-k-mooney | or help them | 17:49 |
*** jaosorior has quit IRC | 17:49 | |
*** NobodyCam has quit IRC | 17:50 | |
sean-k-mooney | efried: the propoasal was to basically to add 2 extra specs one for the tsc frequency and the other for enableing invtsc | 17:50 |
*** NobodyCam has joined #openstack-nova | 17:51 | |
sean-k-mooney | also add a trait to land on host that support invtsc | 17:51 |
efried | sean-k-mooney: cool. This would be umbSublime's first contribution, so he'll need some mentoring... | 17:52 |
sean-k-mooney | looking at my browser history we created 1 an i think i was ment to help draft the update to the bluepirnt. | 17:53 |
sean-k-mooney | https://etherpad.openstack.org/p/invtsc | 17:53 |
sean-k-mooney | is umbSublime about | 17:53 |
efried | That etherpad looks like the same content as what's in the bp description. | 17:54 |
sean-k-mooney | my isp decied to force recet my router again and broke my internet | 17:54 |
sean-k-mooney | yes | 17:54 |
sean-k-mooney | so i obvioulsy never wrote the updated draft | 17:54 |
efried | from what I could glean, "we" decided at some point that the blueprint could be specless. | 17:54 |
*** jmlowe has quit IRC | 17:54 | |
sean-k-mooney | yes i brought it up in the nova meeting | 17:54 |
sean-k-mooney | and we said if we spell out the minor changes need then it could be specless | 17:55 |
efried | great | 17:55 |
*** martinkennelly has quit IRC | 17:56 | |
sean-k-mooney | umbSublime: this sliped off my radar sorry. | 17:56 |
umbSublime | reporting in o/ | 17:57 |
sean-k-mooney | umbSublime: if you are still up for working on the code cahgne ill try and draft some worth in the ether path to describe what is needed. if you are happy with tem we can update the blueprint and i can help you with reviewing your patch | 17:58 |
umbSublime | Sounds good to me! I don't think I'll have much time to work on this this week, but next week should be fine! | 17:58 |
umbSublime | sean-k-mooney, in which etherpad would that be ? | 17:59 |
efried | sean-k-mooney, umbSublime: we'll want something in approvable form by next week (spec freeze). | 17:59 |
sean-k-mooney | https://etherpad.openstack.org/p/invtsc | 18:00 |
umbSublime | efried, I see | 18:00 |
sean-k-mooney | umbSublime: so looking at my private irc logs from talking to you in novemeber | 18:00 |
*** TheJulia has quit IRC | 18:01 | |
sean-k-mooney | i think the proposal was to add a hw:tsc_freq_mhz flavor extra spec | 18:01 |
*** TheJulia has joined #openstack-nova | 18:01 | |
sean-k-mooney | and a hw:invtsc=on|off extra spec | 18:01 |
*** rpittau is now known as rpittau|afk | 18:01 | |
sean-k-mooney | that would be how you requested the feature i the flavor | 18:02 |
umbSublime | yes iirc that's we had discussed last time. I'll have to read back my notes to | 18:02 |
sean-k-mooney | form a shcduler point of view we would need a new trait for invtsc support | 18:02 |
*** johnsom has quit IRC | 18:03 | |
sean-k-mooney | which would be auto added if you enabled the flavor extra spec | 18:03 |
*** johnsom has joined #openstack-nova | 18:03 | |
*** mriosfer has joined #openstack-nova | 18:03 | |
sean-k-mooney | and then the last bit was just the libvirt driver chagne to add the xml elements and report support | 18:03 |
mriosfer | Hi , where i can find a suported list of gpu supported by queens? | 18:04 |
mriosfer | sean: looks like hw:video_ram dont report vram to windows for some reason :S | 18:05 |
sean-k-mooney | umbSublime: do you want to take go at writing that up? or shall i? | 18:05 |
sean-k-mooney | umbSublime: i also linked https://review.opendev.org/#/c/671338/ to you as an example of how to add the feature just to refresh your memory | 18:05 |
sean-k-mooney | mriosfer: so in the image its hw_video_ram and you need to set hw_video:max_ram in the flavor i think | 18:06 |
mriosfer | yes i got it | 18:06 |
mriosfer | im going to double check | 18:06 |
umbSublime | Considering I'm not really familiar with the codebase yet, I think it would help me if you'd point me in the right direction (right I had forgotten that link). I'll read on this and take a closer look this afternoon. I'll report back if have any questions/concerns | 18:06 |
*** artom has joined #openstack-nova | 18:06 | |
sean-k-mooney | umbSublime: ok i wont get to it today but ill write a rough draft of the chagne in the etherpad tomorrow. then we can update the blue print and review it with the nova team | 18:08 |
sean-k-mooney | umbSublime: would you be able to attend the nova team meeting tommorow in case people have questions about your usecase | 18:09 |
umbSublime | Thank you so much, I hope this isn't too much of a burden :/ | 18:09 |
umbSublime | Yes I should be available tomorrow | 18:09 |
sean-k-mooney | well normally if we had more time its something that we would help to do. its almost the feature proposal deadline so it will need to be approve this week or next so i can help a little more then normal | 18:10 |
*** tesseract has quit IRC | 18:11 | |
umbSublime | There a few few "newcoming contributer" docs out there for OS, but is there one more specific to nova I should up on ? | 18:12 |
sean-k-mooney | we do have a nova one im not sure if it differe much form the generic one let me see if i can find it | 18:12 |
sean-k-mooney | umbSublime: they are here https://docs.openstack.org/nova/latest/contributor/index.html | 18:14 |
umbSublime | \o/ | 18:14 |
sean-k-mooney | umbSublime: you might find this one useful https://docs.openstack.org/nova/latest/contributor/how-to-get-involved.html | 18:15 |
umbSublime | I'll try and get up to speed on this tonight | 18:16 |
*** amoralej is now known as amoralej|off | 18:16 | |
*** masayukig has quit IRC | 18:34 | |
*** masayukig has joined #openstack-nova | 18:35 | |
*** tbachman has quit IRC | 18:35 | |
openstackgerrit | Merged openstack/nova master: nova-net: Remove now unnecessary nova-net workaround https://review.opendev.org/702440 | 18:38 |
*** tbachman has joined #openstack-nova | 18:41 | |
*** tbachman has quit IRC | 18:45 | |
*** eharney has quit IRC | 18:49 | |
openstackgerrit | Eric Fried proposed openstack/nova master: WIP: refactor: Do network & accel discovery near volumes https://review.opendev.org/706083 | 18:49 |
efried | dansmith: Does that ^ refactor look like what you had in mind? | 18:49 |
dansmith | efried: from a skim, yeah | 18:51 |
efried | dansmith: If so, my main objections to the preceding patch are addressed. The other bits I noted are still worth doing, but could conceivably be FUP'd if there's motivation not to respin the series. | 18:52 |
dansmith | ack | 18:53 |
*** ralonsoh has quit IRC | 18:54 | |
*** dpawlik has quit IRC | 19:04 | |
*** dpawlik has joined #openstack-nova | 19:05 | |
*** artom has quit IRC | 19:15 | |
*** larsks has left #openstack-nova | 19:28 | |
*** sean-k-mooney has quit IRC | 19:29 | |
*** sean-k-mooney has joined #openstack-nova | 19:32 | |
*** LiangFang has quit IRC | 19:36 | |
*** masayukig has quit IRC | 19:38 | |
*** NobodyCam has quit IRC | 19:39 | |
*** vdrok has quit IRC | 19:39 | |
*** awestin1 has quit IRC | 19:39 | |
*** TheJulia has quit IRC | 19:39 | |
*** johnsom has quit IRC | 19:40 | |
*** tbachman has joined #openstack-nova | 19:46 | |
*** xek_ has joined #openstack-nova | 19:48 | |
*** xek has quit IRC | 19:51 | |
*** TxGirlGe_ has joined #openstack-nova | 19:59 | |
*** jmlowe has joined #openstack-nova | 20:01 | |
*** TxGirlGeek has quit IRC | 20:01 | |
*** jmlowe has quit IRC | 20:01 | |
*** eharney has joined #openstack-nova | 20:04 | |
openstackgerrit | Mykola Yakovliev proposed openstack/nova master: Fix boot_roles in InstanceSystemMetadata https://review.opendev.org/698040 | 20:07 |
*** jmlowe has joined #openstack-nova | 20:15 | |
*** artom has joined #openstack-nova | 20:17 | |
*** dklyle has quit IRC | 20:19 | |
*** david-lyle has joined #openstack-nova | 20:19 | |
*** TxGirlGe_ has quit IRC | 20:28 | |
*** TxGirlGeek has joined #openstack-nova | 20:29 | |
*** mriosfer has quit IRC | 20:31 | |
sean-k-mooney | umbSublime: i have updated https://etherpad.openstack.org/p/invtsc with what i think woudl be sufficent for the blueprint. | 20:33 |
sean-k-mooney | umbSublime: i have not spellchecked it and as efried will attest that is likely required. | 20:34 |
sean-k-mooney | ill add this to the end of the nova meeting agendra for tomorrow but if you are happy with the content can you update the blueprint. | 20:35 |
*** slaweq_ has quit IRC | 20:44 | |
*** slaweq_ has joined #openstack-nova | 20:47 | |
umbSublime | sean-k-mooney, thanks! I did a first pass on spellcheck. I think I'll wait until tomorrow to post it in case I think of something to add in the meantime | 20:49 |
*** mgariepy has quit IRC | 20:54 | |
sean-k-mooney | umbSublime: ya if you want to reframe the problem statement etc feel free | 20:55 |
*** jmlowe has quit IRC | 21:08 | |
*** jmlowe has joined #openstack-nova | 21:10 | |
*** TxGirlGe_ has joined #openstack-nova | 21:14 | |
*** slaweq_ has quit IRC | 21:15 | |
*** TxGirlGeek has quit IRC | 21:15 | |
*** tosky has quit IRC | 21:18 | |
*** spatel has joined #openstack-nova | 21:19 | |
spatel | sean-k-mooney: hey | 21:19 |
spatel | I am seeing strange performance issue, I am running erlang application on openstack instance which is giving me very poor performance but if i run same application on bare metal performance is really good | 21:20 |
spatel | I have created big VM and allocated all vCPU to instance so only single VM running on compute node.. | 21:21 |
spatel | trying to understand where is the bottleneck | 21:21 |
*** jmlowe has quit IRC | 21:22 | |
*** xek_ has quit IRC | 21:27 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Fetch 'Service' objects once when building AZs https://review.opendev.org/705653 | 21:31 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Bump minimum version of websockify https://review.opendev.org/705654 | 21:31 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Merge unnecessary 'NovaProxyRequestHandlerBase' separation https://review.opendev.org/705655 | 21:31 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove 'run_once' helper https://review.opendev.org/705656 | 21:31 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Integrate mypy https://review.opendev.org/676208 | 21:31 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: mypy: Add type annotations to 'nova.pci' https://review.opendev.org/676209 | 21:31 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: mypy: Add nova.cmd, nova.conf, nova.console https://review.opendev.org/705657 | 21:31 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: mypy: Add type annotations to top-level modules https://review.opendev.org/705658 | 21:31 |
sean-k-mooney | spatel: erlang is pretty memory sensitive so using hugepages in the gust and likely on the host for the vm should help | 21:32 |
sean-k-mooney | spatel: you shoudl also look into http://erlang.org/doc/man/HiPE_app.html | 21:33 |
openstackgerrit | Merged openstack/nova master: Handle neutron without the fip-port-details extension https://review.opendev.org/705760 | 21:35 |
spatel | sean-k-mooney: i am using hugepage | 21:38 |
spatel | I have tried all possible best practices | 21:38 |
spatel | earlier i gave all CPU to vm (32 core) so thinking i should just create VM with 16 vCPU so it stay one side of NUMA zone to see how its performing.. | 21:39 |
*** liuyulong has quit IRC | 21:41 | |
sean-k-mooney | ya numa affinitising the vm might help or create a dual numa guest | 21:42 |
sean-k-mooney | that would report the numa affintiy to erlang but if you are using hugepags it has a numa toplogy of 1 already | 21:42 |
spatel | I am only curious if i run same benchmark on bare metal then i get good result but if i run on VM then it gives poor result | 21:43 |
sean-k-mooney | what it could be is the cpu model | 21:43 |
sean-k-mooney | if you are not useing host-passthouhg you might not have all the cpu feature in the vm that you have in the host | 21:43 |
spatel | my CPU mode is passthrough | 21:43 |
sean-k-mooney | well if you have it numa affined and cpu passthohg | 21:43 |
sean-k-mooney | are you using cpu pinning | 21:44 |
spatel | Yes | 21:44 |
spatel | CPU pinning | 21:44 |
sean-k-mooney | then the only bottelnecs you have left are disk io or netwrok | 21:44 |
sean-k-mooney | what disk cache mode are you using | 21:44 |
spatel | I am using SR-IOV and not seeing any single packetloss or performance issue on network layer | 21:44 |
spatel | We have SSD | 21:45 |
spatel | not sure about disk cache mode? | 21:45 |
sean-k-mooney | https://docs.openstack.org/nova/latest/configuration/config.html#libvirt.disk_cachemodes | 21:45 |
spatel | I have noticed in SS command lost of packet getting in queue and increasing latency | 21:46 |
sean-k-mooney | file=writeback,block=writeback,network=writeback would be the highest performace setting in most cases | 21:46 |
spatel | hmm | 21:48 |
spatel | I will try that too | 21:48 |
spatel | is that kvm setting ? | 21:48 |
sean-k-mooney | ya its a setting for the libvirt dirver | 21:49 |
spatel | I have flavor setting numa_node=2 | 21:49 |
sean-k-mooney | so in the [libvirt] section | 21:49 |
spatel | ok.. i will give it a try and see if that make any difference | 21:49 |
spatel | tomorrow i am going to run more erlang test and see where is the bottleneck.. i will keep you posted.. | 21:50 |
*** spatel has quit IRC | 21:51 | |
*** nicolasbock has joined #openstack-nova | 21:56 | |
*** damien_r has quit IRC | 21:57 | |
*** maciejjozefczyk has joined #openstack-nova | 22:02 | |
*** nweinber has quit IRC | 22:07 | |
*** maciejjozefczyk has quit IRC | 22:18 | |
*** mriedem has left #openstack-nova | 22:19 | |
*** nicolasbock has quit IRC | 22:23 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Deprecate base rules in favor of new rules https://review.opendev.org/701624 | 22:26 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix os-attach-interfaces policy to be admin_or_owner https://review.opendev.org/705135 | 22:26 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Remove old policy enforcement in attach_interfaces https://review.opendev.org/705127 | 22:26 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing attach_interfaces policies https://review.opendev.org/705126 | 22:26 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-attach-interfaces https://review.opendev.org/705799 | 22:27 |
*** N3l1x has quit IRC | 22:38 | |
efried | gibi: stephenfin, other: how many people were in the room at the Shanghai PTG? | 22:44 |
*** tkajinam has joined #openstack-nova | 22:48 | |
*** vdrok has joined #openstack-nova | 23:00 | |
*** NobodyCam has joined #openstack-nova | 23:00 | |
*** TheJulia has joined #openstack-nova | 23:00 | |
*** masayukig has joined #openstack-nova | 23:00 | |
*** awestin1 has joined #openstack-nova | 23:02 | |
*** johnsom has joined #openstack-nova | 23:02 | |
*** sean-k-mooney has quit IRC | 23:28 | |
*** sean-k-mooney has joined #openstack-nova | 23:29 | |
*** ociuhandu has joined #openstack-nova | 23:30 | |
*** mlavalle has quit IRC | 23:32 | |
*** ociuhandu has quit IRC | 23:35 | |
alex_xu | efried: 20 maybe | 23:36 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!