*** Liang__ has quit IRC | 00:03 | |
*** Liang__ has joined #openstack-nova | 00:04 | |
*** rcernin has joined #openstack-nova | 00:07 | |
*** artom has quit IRC | 00:10 | |
*** slaweq has joined #openstack-nova | 00:11 | |
*** artom has joined #openstack-nova | 00:14 | |
*** artom has quit IRC | 00:15 | |
*** artom has joined #openstack-nova | 00:15 | |
*** slaweq has quit IRC | 00:16 | |
*** tosky has quit IRC | 00:38 | |
*** macz has quit IRC | 00:38 | |
*** rcernin has quit IRC | 00:55 | |
*** rcernin has joined #openstack-nova | 00:55 | |
*** masayukig is now known as migawa|AFK | 01:08 | |
*** migawa|AFK is now known as migawa | 01:09 | |
*** slaweq has joined #openstack-nova | 01:11 | |
*** slaweq has quit IRC | 01:16 | |
*** brinzhang has quit IRC | 01:22 | |
*** damien_r has joined #openstack-nova | 01:25 | |
*** brinzhang has joined #openstack-nova | 01:51 | |
*** slaweq has joined #openstack-nova | 02:11 | |
*** damien_r has quit IRC | 02:14 | |
*** slaweq has quit IRC | 02:16 | |
*** macz has joined #openstack-nova | 02:40 | |
*** macz has quit IRC | 02:45 | |
*** rcernin has quit IRC | 03:06 | |
*** mkrai has joined #openstack-nova | 03:11 | |
*** slaweq has joined #openstack-nova | 03:11 | |
*** slaweq has quit IRC | 03:16 | |
*** tbachman has quit IRC | 03:20 | |
*** psachin has joined #openstack-nova | 03:22 | |
*** rcernin has joined #openstack-nova | 03:23 | |
*** mkrai has quit IRC | 03:45 | |
*** udesale has joined #openstack-nova | 04:05 | |
*** gyee has quit IRC | 04:08 | |
*** slaweq has joined #openstack-nova | 04:11 | |
*** vishalmanchanda has joined #openstack-nova | 04:13 | |
*** slaweq has quit IRC | 04:16 | |
*** rcernin has quit IRC | 04:16 | |
*** rcernin has joined #openstack-nova | 04:16 | |
*** mkrai has joined #openstack-nova | 04:22 | |
*** TxGirlGeek has quit IRC | 04:32 | |
*** psachin has quit IRC | 04:33 | |
*** artom has quit IRC | 04:35 | |
*** macz has joined #openstack-nova | 04:41 | |
*** dave-mccowan has quit IRC | 04:43 | |
*** macz has quit IRC | 04:46 | |
*** migawa is now known as migawa|lunch|AFK | 04:50 | |
*** rcernin is now known as rcernin|lunch | 05:01 | |
*** slaweq has joined #openstack-nova | 05:11 | |
*** slaweq has quit IRC | 05:16 | |
*** migawa|lunch|AFK is now known as migawa|lunch | 05:18 | |
*** evrardjp has quit IRC | 05:34 | |
*** evrardjp has joined #openstack-nova | 05:34 | |
*** mmethot_ has joined #openstack-nova | 05:35 | |
*** mmethot has quit IRC | 05:37 | |
*** macz has joined #openstack-nova | 05:41 | |
*** zhanglong has joined #openstack-nova | 05:42 | |
*** macz has quit IRC | 05:45 | |
*** ratailor has joined #openstack-nova | 05:51 | |
*** macz has joined #openstack-nova | 05:58 | |
*** macz has quit IRC | 06:03 | |
*** slaweq has joined #openstack-nova | 06:11 | |
*** slaweq has quit IRC | 06:16 | |
*** mlycka has joined #openstack-nova | 06:40 | |
*** slaweq has joined #openstack-nova | 07:08 | |
*** slaweq has quit IRC | 07:15 | |
*** rpittau|afk is now known as rpittau | 07:21 | |
*** ivve has quit IRC | 07:24 | |
*** macz has joined #openstack-nova | 07:24 | |
*** yoctozepto has quit IRC | 07:28 | |
*** yoctozepto has joined #openstack-nova | 07:28 | |
*** macz has quit IRC | 07:29 | |
*** brinzhang has quit IRC | 07:29 | |
*** lpetrut has joined #openstack-nova | 07:31 | |
*** yoctozepto has quit IRC | 07:33 | |
*** iurygregory has joined #openstack-nova | 07:35 | |
*** slaweq has joined #openstack-nova | 07:51 | |
*** imacdonn has quit IRC | 07:54 | |
*** imacdonn has joined #openstack-nova | 07:54 | |
*** maciejjozefczyk has joined #openstack-nova | 07:54 | |
*** slaweq has quit IRC | 07:57 | |
*** slaweq has joined #openstack-nova | 07:59 | |
*** yoctozepto has joined #openstack-nova | 07:59 | |
*** xek_ has joined #openstack-nova | 08:09 | |
*** tkajinam has quit IRC | 08:10 | |
*** tosky has joined #openstack-nova | 08:22 | |
*** Liang__ has quit IRC | 08:22 | |
*** Liang__ has joined #openstack-nova | 08:23 | |
*** amoralej|off is now known as amoralej | 08:26 | |
*** ccamacho has joined #openstack-nova | 08:27 | |
*** mkrai has quit IRC | 08:33 | |
*** mkrai has joined #openstack-nova | 08:37 | |
*** ralonsoh has joined #openstack-nova | 08:38 | |
*** ivve has joined #openstack-nova | 08:45 | |
*** dtantsur|afk is now known as dtantsur | 08:45 | |
gibi | efried_afk, sean-k-mooney, dansmith: read up on the numa fallback discussion from yesterday. impressive work. I need to digest the result | 09:02 |
---|---|---|
*** iurygregory has quit IRC | 09:21 | |
*** tetsuro has joined #openstack-nova | 09:27 | |
*** jangutter has joined #openstack-nova | 09:27 | |
openstackgerrit | ZhouHeng proposed openstack/nova-specs master: Support set port vnic type to create server https://review.opendev.org/672400 | 09:30 |
*** xiaolin has quit IRC | 09:34 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Fix attached encrypted LUKSv1 volume extension https://review.opendev.org/706900 | 09:38 |
*** iurygregory has joined #openstack-nova | 09:39 | |
*** ileixe has quit IRC | 09:43 | |
*** xiaolin has joined #openstack-nova | 09:43 | |
openstackgerrit | Guo Jingyu proposed openstack/nova-specs master: Proposal for a safer noVNC console with password authentication https://review.opendev.org/623120 | 09:44 |
*** ileixe has joined #openstack-nova | 09:44 | |
*** ileixe has joined #openstack-nova | 09:45 | |
*** ociuhandu has joined #openstack-nova | 09:56 | |
*** martinkennelly has joined #openstack-nova | 09:56 | |
bauzas | gibi: yeah I did it too | 10:00 |
bauzas | I'll work on a new revision | 10:01 |
*** xiaolin has quit IRC | 10:03 | |
*** derekh has joined #openstack-nova | 10:13 | |
bauzas | gibi: honestly, I'm looking at https://review.opendev.org/#/c/552924/17/specs/ussuri/approved/numa-topology-with-rps.rst@516 and I don't know what the outcome consensus... | 10:14 |
bauzas | what is* | 10:14 |
bauzas | gibi: efried_afk tried to summarize but that's still a bit confusing for me | 10:15 |
*** ileixe has quit IRC | 10:18 | |
*** rcernin|lunch has quit IRC | 10:22 | |
*** kaisers has quit IRC | 10:27 | |
*** kaisers has joined #openstack-nova | 10:35 | |
*** rcernin|lunch has joined #openstack-nova | 10:36 | |
*** jangutter has quit IRC | 10:51 | |
*** mkrai has quit IRC | 10:57 | |
*** udesale has quit IRC | 11:06 | |
*** vishalmanchanda has quit IRC | 11:12 | |
*** zhanglong has quit IRC | 11:19 | |
gibi | bauzas: I had a doctors appointment until now and now jump on the meeting. After that I will try to summarize how I understood the consensus | 11:26 |
gibi | and crosscheck it with your summary | 11:26 |
bauzas | merging two calls AFAIK | 11:26 |
bauzas | AFAICU* | 11:26 |
bauzas | anyway, i'll try to provide a new revision | 11:27 |
*** rpittau is now known as rpittau|bbl | 11:33 | |
*** tbachman has joined #openstack-nova | 11:36 | |
*** tbachman has quit IRC | 11:42 | |
sean-k-mooney | bauzas: gibi im just going to grab a coffe but do you want to have a quick bluejeans call to recap on where we are with the numa spec | 11:46 |
sean-k-mooney | i can explain what the alternitive is in more detail. i think the last sticking point is just the default and how the query is done | 11:47 |
openstackgerrit | Sylvain Bauza proposed openstack/nova-specs master: Proposes NUMA topology with RPs https://review.opendev.org/552924 | 11:48 |
bauzas | sean-k-mooney: sorry but no | 11:48 |
bauzas | I need to go lunch and then I'll have a doctor appointment | 11:48 |
bauzas | at 2pm | 11:48 |
bauzas | (my time) | 11:48 |
bauzas | remember, not all people work after 6pm | 11:48 |
bauzas | sean-k-mooney: and when i read your comments that are around 3am your time, my point is : 'heh, Sean, please go to bed!" ;) | 11:49 |
sean-k-mooney | hehe | 11:49 |
sean-k-mooney | i did whihc is why i started at 11 | 11:49 |
bauzas | I was a night owl | 11:50 |
bauzas | but then my brain fried 4 years ago | 11:50 |
bauzas | or maybe 3 | 11:50 |
bauzas | actually, 3 | 11:50 |
sean-k-mooney | i can try and sumerises in the spec but and in our internal tech call what i discussed with dansmith and efried_afk last night | 11:50 |
sean-k-mooney | i was fine with the pervisous revision with the fallback query | 11:51 |
openstackgerrit | ZhouHeng proposed openstack/nova-specs master: Support set port vnic type to create server https://review.opendev.org/672400 | 11:51 |
sean-k-mooney | but the alternitive is to enable numa reporting by default and then make all non numa instance have a numa toplogy dynamicaly by makeing multiple queries with differnt numa toplogies upt to a max numer of numa nodes | 11:52 |
sean-k-mooney | so large instance that cant fit on one numa node would dynamicaly get split across up to X numa nodes as defiend in the schduler config | 11:53 |
sean-k-mooney | if you set the max to 0 it disabel the implcit numa creation and large non numa guest could only land on hosts with numa reporting disabled or train hosts during an upgrade | 11:54 |
*** jaosorior has joined #openstack-nova | 12:01 | |
*** nicolasbock has joined #openstack-nova | 12:06 | |
*** ociuhandu has quit IRC | 12:09 | |
*** ociuhandu has joined #openstack-nova | 12:10 | |
sean-k-mooney | bauzas: also not sure if you saw ^ we can talk about it in the tech call too if you can make that | 12:11 |
*** mkrai has joined #openstack-nova | 12:15 | |
*** udesale has joined #openstack-nova | 12:34 | |
*** mkrai has quit IRC | 12:35 | |
*** ratailor has quit IRC | 12:36 | |
*** ratailor has joined #openstack-nova | 12:38 | |
*** ratailor has quit IRC | 12:43 | |
bauzas | sean-k-mooney: thanks, I need to be in a doctor's appointment in 15 mins, back around 1.45pm UTC I think | 12:43 |
*** nweinber has joined #openstack-nova | 12:54 | |
openstackgerrit | ZhouHeng proposed openstack/nova-specs master: Support set port vnic type to create server https://review.opendev.org/672400 | 12:54 |
*** amoralej is now known as amoralej|lunch | 12:56 | |
*** Liang__ has quit IRC | 13:03 | |
*** Liang__ has joined #openstack-nova | 13:04 | |
*** rpittau|bbl is now known as rpittau | 13:05 | |
*** ociuhandu has quit IRC | 13:11 | |
*** derekh has quit IRC | 13:30 | |
stephenfin | efried_afk, bauzas, gibi, others: I hope I'm not overstepping things by -2ing this, but it seems clear to me that we've decided not to do orchestration stuff, right? https://review.opendev.org/#/c/672400/ | 13:32 |
gibi | stephenfin: I support your -2 | 13:32 |
gibi | stephenfin: a similar spec for port mac address https://review.opendev.org/#/c/700429/ | 13:33 |
stephenfin | gibi: I've also -2'd that. Happy to take the backlash | 13:37 |
gibi | good :) thanks :) | 13:37 |
*** nicolasbock has quit IRC | 13:43 | |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: Remove 'test_cold_migrate_with_physnet_fails' test https://review.opendev.org/703115 | 13:45 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: Block rebuild when NUMA topology changed https://review.opendev.org/703116 | 13:45 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: Disable NUMATopologyFilter on rebuild https://review.opendev.org/703117 | 13:45 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: FUP for in-place numa rebuild https://review.opendev.org/703118 | 13:45 |
lyarwood | sean-k-mooney: ^ just rebasing as stable/rocky should be passing again now and I'd like to land this before we switch over to EM | 13:45 |
lyarwood | aaaaaand I missed elod's comment | 13:46 |
*** nicolasbock has joined #openstack-nova | 13:48 | |
*** ociuhandu has joined #openstack-nova | 13:48 | |
*** rcernin|lunch has quit IRC | 13:50 | |
*** liuyulong has joined #openstack-nova | 13:51 | |
*** ociuhandu has quit IRC | 13:52 | |
*** eharney has quit IRC | 13:55 | |
bauzas | gibi: sean-k-mooney: I'm back | 13:56 |
*** rosmaita has left #openstack-nova | 13:57 | |
*** amoralej|lunch is now known as amoralej | 13:58 | |
gibi | bauzas: just replied with my understanding of Eric's summary | 13:59 |
*** Liang__ is now known as LiangFang | 14:00 | |
*** lbragstad has quit IRC | 14:02 | |
*** lbragstad has joined #openstack-nova | 14:02 | |
*** ociuhandu has joined #openstack-nova | 14:04 | |
*** derekh has joined #openstack-nova | 14:05 | |
*** lbragstad has quit IRC | 14:08 | |
*** vishalmanchanda has joined #openstack-nova | 14:11 | |
*** ociuhandu has quit IRC | 14:15 | |
*** tesseract has quit IRC | 14:20 | |
sean-k-mooney | bauzas: just back too | 14:24 |
sean-k-mooney | had to go to my bank to sort things for the house purchase | 14:24 |
bauzas | gibi: coolio thanks | 14:25 |
sean-k-mooney | gibi: ya that is more or less a good summary | 14:29 |
gibi | bauzas: I think I got enough from efried_afk's summary that I see that my issue is solved by this propsal as well | 14:29 |
sean-k-mooney | gibi: well this still has the fallback which solves your main issue but also make the numa reporting the default which solve erics main issue of people using the fature after all this work | 14:30 |
gibi | sean-k-mooney: I treated the splitting algo as an impl detail for now. I think we can make it good enough and if not we have a way out | 14:30 |
gibi | sean-k-mooney: yeah, I'm OK that U compute is reshape by default | 14:30 |
sean-k-mooney | gibi: ya honelsty the poc i did would be good enouch in my book | 14:30 |
gibi | sean-k-mooney: agree | 14:30 |
sean-k-mooney | i will likely refacto that algoritim and submit a standalone patch later in the week | 14:31 |
sean-k-mooney | allowing asymetic spliting by default when you just set hw:numa_nodes is a minor change | 14:31 |
sean-k-mooney | and would be useful for numa instnaces | 14:32 |
*** jaosorior has quit IRC | 14:32 | |
*** jaosorior has joined #openstack-nova | 14:32 | |
sean-k-mooney | once we do that its just a matter of calling the get_numa_constratis function in a loop and generting the multiple queies and merging the results | 14:32 |
*** tbachman has joined #openstack-nova | 14:33 | |
*** eharney has joined #openstack-nova | 14:41 | |
huaqiang | hi alex_xu | 14:44 |
alex_xu | huaqiang: i'm here | 14:44 |
huaqiang | do you mean, in the review of spec https://review.opendev.org/#/c/668656/, we have to mix 'hw:pinned_cpus' with 'resources:P|VCPU' | 14:45 |
huaqiang | BUT we should avoid the mixing of 'hw_pinned_cpus' with 'resources:xx; | 14:46 |
huaqiang | right? | 14:46 |
alex_xu | huaqiang: I mean it have to, althought we don't want that. | 14:47 |
alex_xu | I don't think we have other choice | 14:47 |
huaqiang | then there is no problem for setting the 'mixed' policy and cpu bitmask in image properties and then specify the PCPU and VCPU in flavor 'resources:P|VCPU'? | 14:49 |
*** efried_afk is now known as efried | 14:50 | |
*** tbachman has quit IRC | 14:51 | |
*** ociuhandu has joined #openstack-nova | 14:53 | |
*** Sundar has joined #openstack-nova | 14:54 | |
sean-k-mooney | i have the mixed cpu spec open by the way so im going to try and finish reviewing it in the next hour or so before my next meeting | 14:54 |
*** jaosorior has quit IRC | 14:54 | |
alex_xu | huaqiang: yes, I think there is no problem | 14:54 |
alex_xu | sean-k-mooney: thanks | 14:55 |
huaqiang | sean-k-mooney: thank you :) | 14:55 |
huaqiang | alex_xu: got. thanks | 14:55 |
sean-k-mooney | alex_xu: are you largly happy with it? | 14:57 |
alex_xu | sean-k-mooney: yes, I think so | 14:57 |
sean-k-mooney | ok just wondering if you had pending comments. ill try and go through it form top to bottom now so | 14:57 |
alex_xu | no more pending comments. | 14:58 |
*** ociuhandu has quit IRC | 14:58 | |
Sundar | gibi, dansmith, efried, sean-k-mooney: Trying to get my head around the rescheduling thing. Previously, the creation and binding of ARQs were happening in the compute manager. So, on failure, we just deleted the ARQs (which will be unbound by Cyborg if needed) and the retry would presumably have created/bound the ARQs on another node. Now the | 15:03 |
Sundar | create/bind are moved to the conductor, but that is done just before the RPC call to compute manager. So, could we still delete and recreate/rebind the ARQs? | 15:03 |
dansmith | Sundar: why is it any different? | 15:04 |
sean-k-mooney | so on a resudue instead of delete and recreate we can just rebind in the conductor | 15:04 |
dansmith | can we rebind? if so, then sure | 15:05 |
sean-k-mooney | if we cant delete and recreeate is fine too | 15:05 |
sean-k-mooney | we can update the host for an exisitng binding | 15:05 |
sean-k-mooney | it woudl be needed for move opertions anyway | 15:05 |
dansmith | well, not necessarily | 15:05 |
dansmith | depends on how they want to do it | 15:05 |
sean-k-mooney | i guess we could use a souce and dest arg | 15:06 |
sean-k-mooney | *arq | 15:06 |
sean-k-mooney | that might be better in some ways | 15:06 |
dansmith | if they wanted another ARQ bound to the new host and a switch, or whatever | 15:06 |
dansmith | that's not what he's asking though I assume | 15:06 |
sean-k-mooney | ya like we now do with neutron ports | 15:06 |
*** spatel has joined #openstack-nova | 15:06 | |
dansmith | right | 15:06 |
Sundar | dansmith, sean-k-mooney: It may be simpler to delete and re-create, similar to the rest of the patches. | 15:06 |
dansmith | yeah, that's fine | 15:07 |
Sundar | Yes, I am not talking about migration, which is out of scope for now | 15:07 |
sean-k-mooney | Sundar: i think dansmith and i both think thats fine | 15:07 |
Sundar | Cool, thanks, dansmith and sean-k-mooney. | 15:07 |
*** jmlowe has joined #openstack-nova | 15:08 | |
sean-k-mooney | if delete and recreate makes runing through the cyborg state machicne to prepare the device on the dest simpler i think it also makes sense to just do that | 15:08 |
sean-k-mooney | i.e. for that reason on its own in addtion to the fact thats what the other patches do and the workflow you have been using | 15:09 |
*** spatel has quit IRC | 15:11 | |
*** artom has joined #openstack-nova | 15:11 | |
*** mkrai has joined #openstack-nova | 15:11 | |
Sundar | sean-k-mooney: The Cyborg state machine can technically handle ARQ_UNBOUND state, which is reached when you unbind an existing ARQ without deleting it (and distinct from Initial state). That may be of use in the future, but for now it is simpler IMHO to just delete and recreate. | 15:11 |
sean-k-mooney | cool works for me | 15:11 |
sean-k-mooney | Sundar: speaking of delete where you able to repoduce the vm delete issue i hit | 15:12 |
Sundar | I am not hitting it even after reboots. | 15:12 |
sean-k-mooney | with the fake driver | 15:12 |
Sundar | I mostly used the real FPGA driver, but shouldn't matter, one would think. But let me try with the fake anyway. | 15:13 |
sean-k-mooney | its a keystone auth issue so the driver should not make a difference but i dont know | 15:14 |
sean-k-mooney | i do now have access to a system with the same fpga you have. but 1 im not sure what image to use and 2 it currently has rhel 7.7 so i have not figured out how to deploy opensatck on it yet | 15:14 |
*** lbragstad has joined #openstack-nova | 15:15 | |
sean-k-mooney | i might see if it can be reinstalled with centos 7.7 or ubuntu 18.04 so that i can use devstack | 15:15 |
*** priteau has joined #openstack-nova | 15:15 | |
*** dtantsur is now known as dtantsur|brb | 15:18 | |
Sundar | What's the issue with RHEL 7.7? | 15:18 |
Sundar | I am using Centos 7.7 | 15:19 |
sean-k-mooney | its not supported by devstack and im not sure i will be able to get it to install with out enable eple and rdo repos which dont technicaly support RHEL | 15:21 |
sean-k-mooney | im going to try and stack in a vm first with RHEL 7.7 but im expecting the subsription manager to get in the way | 15:21 |
*** jmlowe has quit IRC | 15:21 | |
sean-k-mooney | tl;dr im expecting missing packages | 15:21 |
Sundar | Got it. | 15:22 |
sean-k-mooney | if your using centos 7.7 and i have to reinstall ill just use that | 15:22 |
*** lpetrut has quit IRC | 15:24 | |
*** ociuhandu has joined #openstack-nova | 15:25 | |
sean-k-mooney | huaqiang: some minor nits to clean up in a follow up patch but im +1 on the mixed cpu spec | 15:30 |
*** mlavalle has joined #openstack-nova | 15:31 | |
*** rpittau is now known as rpittau|afk | 15:31 | |
sean-k-mooney | stephenfin: i think you are probaly the best person to be the final +2 on https://review.opendev.org/#/c/668656/19 if you think its ready. | 15:31 |
*** jmlowe has joined #openstack-nova | 15:34 | |
*** tbachman has joined #openstack-nova | 15:44 | |
*** READ10 has joined #openstack-nova | 15:53 | |
efried | stephenfin: yes please, what sean-k-mooney said ^ | 15:55 |
*** spatel has joined #openstack-nova | 15:56 | |
stephenfin | Looking | 15:59 |
sean-k-mooney | i just responed to alex_xu coment regarding the service object version bump. i think we can use a comptue capablity trait instead and avoid the need for that | 16:00 |
sean-k-mooney | but excpetion for that point im good with it | 16:00 |
*** udesale has quit IRC | 16:02 | |
*** udesale has joined #openstack-nova | 16:02 | |
*** tesseract has joined #openstack-nova | 16:02 | |
*** maciejjozefczyk has quit IRC | 16:06 | |
*** jmlowe has quit IRC | 16:13 | |
openstackgerrit | Merged openstack/nova stable/queens: Use stable constraint for Tempest pinned stable branches https://review.opendev.org/706714 | 16:16 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Block deleting compute services with in-progress migrations https://review.opendev.org/699718 | 16:21 |
*** ivve has quit IRC | 16:23 | |
*** tbachman has quit IRC | 16:25 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Skip to run all integration jobs for policy-only changes. https://review.opendev.org/707268 | 16:33 |
gmann | stephenfin: melwitt updated ^^ | 16:33 |
melwitt | gmann: do you have a Depends-On change that shows what gets run on a policy change? I think that's the best way to check whether it's doing what we want before +2ing | 16:34 |
gmann | melwitt: ok, i can do that. | 16:34 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-console-output policies https://review.opendev.org/707041 | 16:35 |
gmann | melwitt: ^^ done. let's see once gate finish | 16:36 |
melwitt | thanks gmann | 16:36 |
melwitt | gmann: oh, you have a typo Depednds-On | 16:37 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-console-output policies https://review.opendev.org/707041 | 16:37 |
gmann | ah sorry, updated | 16:37 |
*** tbachman has joined #openstack-nova | 16:38 | |
*** priteau has quit IRC | 16:38 | |
*** martinkennelly has quit IRC | 16:39 | |
*** priteau has joined #openstack-nova | 16:39 | |
*** TxGirlGeek has joined #openstack-nova | 16:40 | |
Sundar | sean-k-mooney: Do you think https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L655 is a good place to delete the old ARQs? | 16:40 |
gmann | melwitt: I am not sure if default GET AZ to admin is right things. can you check this - https://review.opendev.org/#/c/706683/ | 16:42 |
melwitt | gmann: ok, will look | 16:43 |
gmann | It is currently admin-or-owner which is open for everyone due to bug or that is expected and admin-or-owner in policy is just misleading | 16:43 |
gmann | melwitt: thanks | 16:43 |
*** macz has joined #openstack-nova | 16:43 | |
*** macz has quit IRC | 16:43 | |
*** macz has joined #openstack-nova | 16:44 | |
*** martinkennelly has joined #openstack-nova | 16:44 | |
melwitt | gmann: I think it should be admin_or_owner, is it possible to just fix the bug? AZ is user-facing but usually only project members would be able to see which AZ in a instance is in (not everybody from other projects) | 16:48 |
*** macz has quit IRC | 16:50 | |
* melwitt added a comment on the review | 16:50 | |
*** udesale has quit IRC | 16:51 | |
*** priteau has quit IRC | 16:51 | |
*** udesale has joined #openstack-nova | 16:52 | |
*** gyee has joined #openstack-nova | 16:52 | |
*** martinkennelly has quit IRC | 16:53 | |
*** iurygregory has quit IRC | 16:58 | |
*** tbachman has quit IRC | 17:00 | |
*** mkrai has quit IRC | 17:04 | |
*** udesale has quit IRC | 17:08 | |
sean-k-mooney | Sundar: looking | 17:08 |
gmann | melwitt: but issue is we do not know the owner while GET AZ. | 17:08 |
melwitt | oh ... /me looks again | 17:08 |
gmann | melwitt: this is list and detail API - https://github.com/openstack/nova/blob/1fcd74730d343b7cee12a0a50ea537dc4ff87f65/nova/api/openstack/compute/availability_zone.py#L108 | 17:08 |
sean-k-mooney | am we could. althoh i belive we will do a cleaup of the failed spawn before that so you might be able to do it earlier. | 17:09 |
sean-k-mooney | that is proably the latest i would delete and recreate the ARQ | 17:10 |
sean-k-mooney | Sundar: you could also do it here https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L694 | 17:10 |
sean-k-mooney | which i think is where i would expect it to happen | 17:11 |
melwitt | gmann: ohhhh this is just giving a list of all the AZs that exist, not the AZ of any particular instance. yeah, sorry, let me comment again | 17:11 |
gmann | melwitt: "which AZ is instance is in" is admin-or-owner which is via GET /servers API | 17:11 |
gmann | melwitt: yeah | 17:12 |
Sundar | sean-k-mooney: Ok, got it. Thanks. | 17:12 |
sean-k-mooney | im not 100% if you want to be in our out side of the if but you likely should be doing the clean up in that exeption handeling code https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L674-L699 | 17:12 |
melwitt | gmann: yeah, I agree it should be allowing everyone to see AZ list by default. I added a comment | 17:14 |
gmann | melwitt: ok. detail make sense to be admin-only as it has host info | 17:15 |
melwitt | gmann: right, agreed | 17:15 |
gmann | thanks. I will modify accordingly | 17:16 |
*** igordc has joined #openstack-nova | 17:17 | |
*** tbachman has joined #openstack-nova | 17:20 | |
*** READ10 has quit IRC | 17:23 | |
stephenfin | sean-k-mooney: You can only specify the number of instance CPUs via the flavor, right? | 17:29 |
stephenfin | i.e. not via the image | 17:29 |
sean-k-mooney | yes | 17:30 |
*** tesseract has quit IRC | 17:32 | |
sean-k-mooney | technically you could do evial things with a cyborg device profile but if you put VCPU or PCPU int eh device profile your on your own | 17:32 |
*** ociuhandu_ has joined #openstack-nova | 17:32 | |
*** evrardjp has quit IRC | 17:34 | |
*** evrardjp has joined #openstack-nova | 17:34 | |
sean-k-mooney | *evil | 17:35 |
*** ociuhandu has quit IRC | 17:36 | |
*** ociuhandu_ has quit IRC | 17:37 | |
sean-k-mooney | lyarwood: by the way did you want me to do anything with the backprots for the numa inplace rebuild patches | 17:38 |
sean-k-mooney | lyarwood: you pinged my earlier but i was not sure if you already fixt them up or if there was still stuff pending | 17:39 |
stephenfin | huaqiang: Reviewed https://review.opendev.org/#/c/668656/. You need to drop the image metadata option and avoid the need to mix placement'y syntax extra specs with legacy extra specs. Do that and I'm +2 | 17:39 |
stephenfin | sean-k-mooney, efried, alex_xu: ^ | 17:39 |
sean-k-mooney | what do you think about the need for the service bump | 17:40 |
*** iurygregory has joined #openstack-nova | 17:40 | |
sean-k-mooney | e.g. do you think we could use a compute capablity trait isntead | 17:40 |
stephenfin | vs. a capability? | 17:40 |
sean-k-mooney | ya | 17:40 |
sean-k-mooney | i would be fine with leaving that to impleenation to decied | 17:40 |
sean-k-mooney | but i think the trait would work | 17:41 |
sean-k-mooney | there may be another reason for the service version bump that i missed | 17:41 |
stephenfin | I used a capability for the PCPU work | 17:41 |
stephenfin | so yeah, I'd probably do the same again | 17:42 |
*** xek__ has joined #openstack-nova | 17:42 | |
stephenfin | commit f329ee5a3b6 | 17:42 |
sean-k-mooney | using the capablity trait means we can support rolling upgrades too rather then requiring all nodes to be upgraded | 17:42 |
sean-k-mooney | just the contoler and the host it lands on will need to be ussuri | 17:43 |
*** ivve has joined #openstack-nova | 17:44 | |
*** xek_ has quit IRC | 17:44 | |
stephenfin | Exactly | 17:44 |
sean-k-mooney | there is a usecase for keeping the image property by the way | 17:45 |
sean-k-mooney | we support setting the realtime mask in the image | 17:45 |
stephenfin | We do, but I think that's wrong | 17:45 |
sean-k-mooney | so for parity we could support the pinned cpus there too | 17:45 |
sean-k-mooney | why | 17:45 |
stephenfin | For the same reasons | 17:45 |
stephenfin | You boot an N core instance | 17:46 |
sean-k-mooney | the idea is the vnf vendor will package teh image and expres the requirements in the image properties | 17:46 |
stephenfin | Right, but they can't express the number of CPUs | 17:46 |
stephenfin | which is probably also required | 17:46 |
sean-k-mooney | well the can express a min numa of cpus in the image | 17:46 |
stephenfin | Via the topology stuff? | 17:47 |
sean-k-mooney | the same way they can express a min amount of ram or disk | 17:47 |
stephenfin | That's a bit of hack | 17:47 |
sean-k-mooney | no | 17:47 |
sean-k-mooney | one sec | 17:47 |
sean-k-mooney | medtadef time | 17:47 |
sean-k-mooney | actully im not sure this is even a metadef it migh be directly on the image | 17:47 |
stephenfin | Hmm, we do also have 'hw_numa_cpus' there | 17:48 |
stephenfin | That's wrong too, IMO :( | 17:48 |
stephenfin | I wonder if we should do this just to be compatible even if it's not a great design though | 17:49 |
stephenfin | We have a 'img_bittorrent' field on the 'ImageMetaProps' object. Good Lord | 17:49 |
sean-k-mooney | oh looks like it only has min disk and min ram | 17:50 |
sean-k-mooney | https://docs.openstack.org/python-openstackclient/pike/cli/command-objects/image.html#image-create | 17:50 |
sean-k-mooney | stephenfin: its by design | 17:50 |
sean-k-mooney | again the intent was to allow the image to descibr the toplogy | 17:51 |
*** vishalmanchanda has quit IRC | 17:51 | |
sean-k-mooney | and the flavor to describe the quantity | 17:51 |
stephenfin | sean-k-mooney: But remember, that's a not a simple list | 17:51 |
stephenfin | or actually, maybe it is for the image metadata | 17:51 |
stephenfin | what happens if you create an N node instance that lists M CPUs in the 'hw_numa_cpus' image metadata option? | 17:52 |
sean-k-mooney | stephenfin: i agree that we should not mix it with the resouces:* syntax | 17:52 |
stephenfin | yeah, I really don't think we need the image metadata option. If anything, I'd be looking to deprecate the likes of 'hw_numa_cpus' | 17:53 |
sean-k-mooney | but if we are seting hw_cpu_policy=mixed in the image seting hw_pinned_cpus=1-5 i think is ok | 17:53 |
sean-k-mooney | stephenfin: i dont think that we shoudl do that | 17:54 |
sean-k-mooney | we could but its there for a reason | 17:54 |
stephenfin | so if we boot using a flavor with 4 cores, what happens? | 17:54 |
stephenfin | or with 8 cores? | 17:54 |
sean-k-mooney | partly to prevent falvor explosion | 17:54 |
sean-k-mooney | with 4 course it woudl be rejected by the numa constraint in the api | 17:55 |
stephenfin | by having image explosion instead? | 17:55 |
sean-k-mooney | before we even create the instance record | 17:55 |
sean-k-mooney | stephenfin: for 8 cors 0,6,7 would be un pinned | 17:55 |
stephenfin | Yeah, that seems wrong to me | 17:56 |
stephenfin | I'd be okay with a ratio | 17:56 |
stephenfin | i.e. 3:1 pinned:unpinned | 17:56 |
stephenfin | because it's a hint | 17:56 |
sean-k-mooney | right but we said its a list | 17:56 |
stephenfin | but I don't think anyone's asked for that | 17:56 |
stephenfin | has anyone actually said they need the image metadata option? | 17:57 |
sean-k-mooney | a ratio is not ok in general | 17:57 |
sean-k-mooney | thats a question for huaqiang and alex_xu | 17:57 |
stephenfin | well we have that in a manner already | 17:57 |
stephenfin | that's what e.g. the 'hw_cpu_cores' thing is doing | 17:57 |
stephenfin | the ratio of cores to threads and sockets | 17:58 |
sean-k-mooney | yes although its not really a raitio | 17:58 |
sean-k-mooney | it indireclty is | 17:58 |
sean-k-mooney | but ya | 17:58 |
stephenfin | a flat number of unpinned cores would also be okay for me | 17:58 |
redrobot | Hi friends! I have a question about your pep8 gate configuration. | 17:59 |
stephenfin | but again, I don't know how much that achieves | 17:59 |
sean-k-mooney | its really socket per vm, cores per socket and then threads per core | 17:59 |
stephenfin | redrobot: shoot | 17:59 |
redrobot | Seeing this error right now: | 17:59 |
redrobot | > F841 local variable '_' is assigned to but never used | 17:59 |
redrobot | I'm used to _ being used for throwaways in tests | 17:59 |
redrobot | but I was wondering if y'all handled it differently? | 17:59 |
stephenfin | Yeah, I thought that was usually ignored | 17:59 |
sean-k-mooney | it depens on the context i think | 18:00 |
stephenfin | Got a link to a build? We're just using flake8 + hacking | 18:00 |
sean-k-mooney | if you do _ = 4 | 18:00 |
sean-k-mooney | i think we will raise an error | 18:00 |
stephenfin | yeah, maybe | 18:00 |
sean-k-mooney | if you for _ , i in x: | 18:00 |
sean-k-mooney | i think it will be fine | 18:00 |
stephenfin | yup | 18:00 |
sean-k-mooney | or if you do multiple assingment | 18:00 |
stephenfin | in my experience, anyway | 18:00 |
redrobot | stephenfin, https://zuul.opendev.org/t/openstack/build/342ef93cbf464e01b72564695b2d610d | 18:00 |
*** derekh has quit IRC | 18:01 | |
sean-k-mooney | so _, x = sum_fun() | 18:01 |
stephenfin | redrobot: I'm not seeing that issue | 18:01 |
stephenfin | I'm seeing this | 18:01 |
stephenfin | ./nova/console/websocketproxy.py:326:32: F632 use ==/!= to compare str, bytes, and int literals | 18:01 |
stephenfin | ./nova/tests/unit/cmd/test_baseproxy.py:93:50: E241 multiple spaces after ',' | 18:01 |
sean-k-mooney | ya same i dont see it compain about _ | 18:02 |
redrobot | oh d'oh. It's complaining about _ when I run tox -e pep8 locally | 18:02 |
redrobot | but also the extra space | 18:02 |
redrobot | I'll follow up the patch with the fix for the space and hopefully that'll work. | 18:02 |
openstackgerrit | Sylvain Bauza proposed openstack/nova-specs master: Proposes NUMA topology with RPs https://review.opendev.org/552924 | 18:03 |
stephenfin | redrobot: Ah, yes, this https://review.opendev.org/#/c/679502/10/nova/tests/unit/console/test_websocketproxy.py@642 | 18:03 |
stephenfin | You don't need that assignment | 18:03 |
stephenfin | If you don't want the value, don't assign to anything | 18:03 |
stephenfin | so just | 18:03 |
stephenfin | websocketproxy.NovaWebSocketProxy(ssl_minimum_version=minver) | 18:03 |
stephenfin | instead of | 18:03 |
stephenfin | _ = websocketproxy.NovaWebSocketProxy(ssl_minimum_version=minver) | 18:03 |
sean-k-mooney | so yes dont do https://review.opendev.org/#/c/679502/10/nova/tests/unit/console/test_websocketproxy.py@631 | 18:03 |
stephenfin | 'zactly ^ | 18:03 |
sean-k-mooney | that should raise a style error | 18:03 |
* stephenfin has to run but trusts sean-k-mooney can answer other questions here :) | 18:04 | |
redrobot | stephenfin, ack, I'll change that | 18:04 |
redrobot | thanks for the help, y'all! | 18:04 |
sean-k-mooney | no worries | 18:05 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Correctly resize encrypted LUKSv1 volumes https://review.opendev.org/706900 | 18:05 |
bauzas | efried: sean-k-mooney: gibi: dansmith: stephenfin: just wrote the last round of the NUMA/placement spec | 18:05 |
bauzas | it's fuckingly 7pm and I'm deprived of meat | 18:06 |
openstackgerrit | Douglas Mendizábal proposed openstack/nova master: Allow TLS ciphers/protocols to be configurable for console proxies https://review.opendev.org/679502 | 18:06 |
sean-k-mooney | bauzas: go get foods hehe | 18:06 |
bauzas | to make it clear, I turn-voted into *not* reshaping by default in Ussuri because i think it's important for us to be very conservative and super cautious | 18:06 |
bauzas | we will have time to make it mandatory for Victoria and write some nice nova-status command later in Ussuri | 18:07 |
*** igordc has quit IRC | 18:08 | |
bauzas | sean-k-mooney: well, I also have to join a city council meeting since I run for a mayor's list :) | 18:08 |
* bauzas starts politics | 18:08 | |
sean-k-mooney | ireland had some interesting political change over the weekend too. | 18:09 |
sean-k-mooney | im going to similarly go to the store and get stuff for dinner but ill review it in the next hour or so | 18:09 |
*** READ10 has joined #openstack-nova | 18:15 | |
*** Sundar has quit IRC | 18:15 | |
*** eharney has quit IRC | 18:18 | |
gmann | melwitt: stephenfin you can see the jobs running for policy-only changes with proposed change- https://review.opendev.org/#/c/707041/ | 18:20 |
melwitt | gmann: cool thanks | 18:20 |
lyarwood | sean-k-mooney: sorry missed your pings earlier, yeah can you take a look at elod's comments in the first change and address them if you have time this week? | 18:22 |
lyarwood | sean-k-mooney: I was just rebasing to get them passing in CI again now that gmann++ fixed up stable/rocky | 18:22 |
*** igordc has joined #openstack-nova | 18:23 | |
*** amoralej is now known as amoralej|off | 18:36 | |
*** READ10 has quit IRC | 18:37 | |
*** jmlowe has joined #openstack-nova | 18:40 | |
*** tosky has quit IRC | 18:47 | |
*** ralonsoh has quit IRC | 19:04 | |
*** TxGirlGeek has quit IRC | 19:06 | |
*** mlycka has quit IRC | 19:10 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing deferred_delete policies https://review.opendev.org/707455 | 19:15 |
*** eharney has joined #openstack-nova | 19:17 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix os-os-deferred-delete policy to be admin_or_owner https://review.opendev.org/707457 | 19:31 |
*** TxGirlGeek has joined #openstack-nova | 19:35 | |
sean-k-mooney | lyarwood: ok ya ill take a look at that tomorrow | 19:37 |
lyarwood | sean-k-mooney: ack thanks | 19:37 |
*** TxGirlGeek has quit IRC | 19:46 | |
*** gentoorax is now known as gentoorax_away | 19:50 | |
*** gentoorax_away is now known as gentoorax | 19:50 | |
*** dtantsur|brb is now known as dtantsur|afk | 19:51 | |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: func tests: move _run_periodics() into own mixin https://review.opendev.org/705545 | 19:53 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: tests: work around malformed serial XML https://review.opendev.org/705546 | 19:53 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: Functional tests for NUMA live migration https://review.opendev.org/672595 | 19:53 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: NUMA LM: Add func test for bug 1845146 https://review.opendev.org/687404 | 19:53 |
openstack | bug 1845146 in OpenStack Compute (nova) train "NUMA aware live migration failed when vCPU pin set" [High,Fix committed] https://launchpad.net/bugs/1845146 - Assigned to Dan Smith (danms) | 19:53 |
*** igordc has quit IRC | 19:58 | |
*** LiangFang has quit IRC | 20:05 | |
*** jmlowe has quit IRC | 20:08 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Correct os-availability-zone policy check_str https://review.opendev.org/706683 | 20:12 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing availability-zone policies https://review.opendev.org/706682 | 20:13 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix os-create-backup policy to be admin_or_owner https://review.opendev.org/706727 | 20:22 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing create_backup policies https://review.opendev.org/706726 | 20:23 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-create-backup https://review.opendev.org/707038 | 20:23 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-create-backup policies https://review.opendev.org/707039 | 20:23 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing availability-zone policies https://review.opendev.org/706682 | 20:24 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-availability-zone https://review.opendev.org/706684 | 20:44 |
*** N3l1x has joined #openstack-nova | 20:48 | |
*** ChanServ has quit IRC | 20:50 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-availability-zone policies https://review.opendev.org/706686 | 20:53 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the actual target in os-availability-zone policy https://review.opendev.org/706691 | 20:54 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing availability-zone policies https://review.opendev.org/706682 | 21:00 |
openstackgerrit | Douglas Mendizábal proposed openstack/nova master: Allow TLS ciphers/protocols to be configurable for console proxies https://review.opendev.org/679502 | 21:05 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-availability-zone https://review.opendev.org/706684 | 21:10 |
*** artom has quit IRC | 21:12 | |
*** ChanServ has joined #openstack-nova | 21:13 | |
*** orwell.freenode.net sets mode: +o ChanServ | 21:13 | |
*** rcernin has joined #openstack-nova | 21:18 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-availability-zone policies https://review.opendev.org/706686 | 21:19 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the actual target in os-availability-zone policy https://review.opendev.org/706691 | 21:19 |
*** jmlowe has joined #openstack-nova | 21:28 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing deferred_delete policies https://review.opendev.org/707455 | 21:29 |
*** ivve has quit IRC | 21:31 | |
openstackgerrit | Corey Bryant proposed openstack/nova master: Monkey patch original current_thread _active https://review.opendev.org/707474 | 21:34 |
*** ociuhandu has joined #openstack-nova | 21:37 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-deferred_delete https://review.opendev.org/707476 | 21:38 |
*** ociuhandu has quit IRC | 21:48 | |
*** ociuhandu has joined #openstack-nova | 21:49 | |
*** READ10 has joined #openstack-nova | 21:50 | |
*** spatel has quit IRC | 21:50 | |
*** READ10 has quit IRC | 21:52 | |
*** ociuhandu has quit IRC | 21:52 | |
*** nweinber has quit IRC | 21:54 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-deferred_delete policies https://review.opendev.org/707485 | 22:15 |
*** slaweq has quit IRC | 22:26 | |
*** jmlowe has quit IRC | 22:40 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Correct os-availability-zone policy check_str https://review.opendev.org/706683 | 22:40 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing availability-zone policies https://review.opendev.org/706682 | 22:41 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing availability-zone policies https://review.opendev.org/706682 | 22:41 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-availability-zone https://review.opendev.org/706684 | 22:41 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-availability-zone policies https://review.opendev.org/706686 | 22:41 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the actual target in os-availability-zone policy https://review.opendev.org/706691 | 22:41 |
*** jmlowe has joined #openstack-nova | 22:43 | |
*** jmlowe has quit IRC | 22:53 | |
*** tkajinam has joined #openstack-nova | 22:54 | |
*** jmlowe has joined #openstack-nova | 22:56 | |
*** xek__ has quit IRC | 23:08 | |
*** spatel has joined #openstack-nova | 23:11 | |
*** jmlowe has quit IRC | 23:12 | |
*** spatel has quit IRC | 23:16 | |
*** xek has joined #openstack-nova | 23:37 | |
*** tbachman has quit IRC | 23:55 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!