Wednesday, 2020-03-18

*** mlavalle has quit IRC00:06
openstackgerritGhanshyam Mann proposed openstack/nova master: Add test coverage of existing flavor_access policies  https://review.opendev.org/71355600:20
*** tetsuro has joined #openstack-nova00:28
openstackgerritGhanshyam Mann proposed openstack/nova master: Add test coverage of existing flavor_access policies  https://review.opendev.org/71355600:35
*** lbragstad has joined #openstack-nova00:37
*** gyee has quit IRC00:38
*** ociuhandu has joined #openstack-nova00:42
openstackgerritGhanshyam Mann proposed openstack/nova master: Introduce scope_types in os-flavor-access  https://review.opendev.org/71355900:46
*** mriedem has left #openstack-nova00:47
*** larainema has quit IRC00:48
openstackgerritGhanshyam Mann proposed openstack/nova master: Add test coverage of existing flavor_access policies  https://review.opendev.org/71355600:48
openstackgerritGhanshyam Mann proposed openstack/nova master: Introduce scope_types in os-flavor-access  https://review.opendev.org/71355900:48
*** ociuhandu has quit IRC00:49
*** dave-mccowan has quit IRC00:55
*** nicolasbock has quit IRC01:01
openstackgerritGhanshyam Mann proposed openstack/nova master: Add test coverage of existing flavor_access policies  https://review.opendev.org/71355601:05
openstackgerritGhanshyam Mann proposed openstack/nova master: Introduce scope_types in os-flavor-access  https://review.opendev.org/71355901:05
openstackgerritGhanshyam Mann proposed openstack/nova master: Introduce scope_types in os-flavor-access  https://review.opendev.org/71355901:06
*** boldo has quit IRC01:08
*** brinzhang__ has joined #openstack-nova01:20
*** brinzhang_ has quit IRC01:23
*** ivve has quit IRC01:27
*** tbachman has quit IRC01:27
openstackgerritMerged openstack/nova master: FUP: Remove noqa and tone down an exception  https://review.opendev.org/69805401:28
*** tbachman has joined #openstack-nova01:42
openstackgerritKevin Zhao proposed openstack/nova master: fix scsi disk unit number of the attaching volume when cdrom bus is scsi  https://review.opendev.org/71260701:45
*** mmethot has quit IRC01:53
*** mmethot has joined #openstack-nova01:53
*** yaawang has quit IRC01:56
*** yaawang has joined #openstack-nova01:57
*** tbachman has quit IRC01:57
openstackgerritBrin Zhang proposed openstack/python-novaclient master: Microversion 2.83: Add volume-attachment-update CLI  https://review.opendev.org/71265102:43
*** factor has quit IRC02:52
*** tetsuro_ has joined #openstack-nova02:53
*** mkrai has joined #openstack-nova02:55
*** tetsuro has quit IRC02:56
openstackgerritmelanie witt proposed openstack/nova master: DNM: try to get some debug info for bug 1844929  https://review.opendev.org/70147803:04
openstackbug 1844929 in OpenStack Compute (nova) "grenade jobs failing due to "Timed out waiting for response from cell" in scheduler" [High,Confirmed] https://launchpad.net/bugs/184492903:04
*** mmethot_ has joined #openstack-nova03:05
*** mmethot has quit IRC03:07
*** yaawang has quit IRC03:08
*** yaawang has joined #openstack-nova03:09
openstackgerritYingji Sun proposed openstack/nova master: set different VirtualDevice.key  https://review.opendev.org/71356503:18
*** dave-mccowan has joined #openstack-nova03:18
*** alex_xu has quit IRC03:29
*** zhanglong has joined #openstack-nova03:38
openstackgerritYingji Sun proposed openstack/nova master: Set different VirtualDevice.key  https://review.opendev.org/71356503:53
*** yaawang has quit IRC04:24
*** yaawang has joined #openstack-nova04:25
*** tetsuro has joined #openstack-nova04:29
*** tetsuro_ has quit IRC04:32
*** tkajinam has quit IRC04:33
*** tkajinam has joined #openstack-nova04:34
*** chenhaw has quit IRC04:49
*** udesale has joined #openstack-nova04:54
*** dave-mccowan has quit IRC04:56
*** dklyle has quit IRC05:04
*** ratailor has joined #openstack-nova05:13
*** TxGirlGeek has quit IRC05:26
*** lbragstad has quit IRC05:29
*** tetsuro_ has joined #openstack-nova05:32
*** tetsuro has quit IRC05:34
*** evrardjp has quit IRC05:35
*** evrardjp has joined #openstack-nova05:36
*** links has joined #openstack-nova05:40
openstackgerritLuyao Zhong proposed openstack/nova master: support live migration with vpmems  https://review.opendev.org/68785605:47
openstackgerritLuyao Zhong proposed openstack/nova master: Track orphan instances and error migrations in resource tracker  https://review.opendev.org/67845105:47
*** jdillaman has quit IRC05:51
*** jdillaman has joined #openstack-nova05:54
openstackgerritmashuting proposed openstack/nova master: Revert "Deprecate the vmwareapi driver"  https://review.opendev.org/71340106:19
*** tetsuro has joined #openstack-nova06:40
*** tetsuro_ has quit IRC06:44
*** ociuhandu has joined #openstack-nova06:48
openstackgerritKevin Zhao proposed openstack/nova master: fix scsi disk unit number of the attaching volume when cdrom bus is scsi  https://review.opendev.org/71260706:50
*** ociuhandu has quit IRC06:52
*** tetsuro_ has joined #openstack-nova07:04
*** tetsuro has quit IRC07:07
*** dpawlik has joined #openstack-nova07:10
*** dpawlik has quit IRC07:26
*** ralonsoh has joined #openstack-nova07:31
*** mkrai has quit IRC07:33
*** dtantsur|afk is now known as dtantsur07:34
gibiartom: ack, I will do a sweep07:39
*** damien_r has joined #openstack-nova07:46
*** tesseract has joined #openstack-nova07:50
gibibauzas: do you still working on https://review.opendev.org/#/c/472685 ?07:55
*** tosky has joined #openstack-nova07:57
*** mkrai has joined #openstack-nova07:58
*** dpawlik has joined #openstack-nova07:58
*** maciejjozefczyk has joined #openstack-nova07:59
*** slaweq has joined #openstack-nova08:04
*** maciejjozefczyk_ has joined #openstack-nova08:04
*** maciejjozefczyk has quit IRC08:05
gibistephenfin: is this still relevant? https://review.opendev.org/#/c/49882008:08
gibistephenfin: and this https://review.opendev.org/#/c/498819 ?08:08
*** yoctozepto9 has joined #openstack-nova08:15
*** yoctozepto has quit IRC08:15
*** yoctozepto9 is now known as yoctozepto08:15
*** tkajinam has quit IRC08:18
*** rcernin has quit IRC08:21
*** amoralej|off is now known as amoralej08:24
*** slaweq has quit IRC08:28
*** slaweq has joined #openstack-nova08:29
*** xek has joined #openstack-nova08:31
*** tetsuro has joined #openstack-nova08:35
*** tetsuro_ has quit IRC08:38
*** lee1 has joined #openstack-nova08:43
*** lee1 is now known as lyarwood08:43
*** ociuhandu has joined #openstack-nova08:45
*** rpittau|afk is now known as rpittau08:45
*** yoctozepto has quit IRC08:49
*** yoctozepto has joined #openstack-nova08:59
*** tetsuro has quit IRC09:00
*** maciejjozefczyk_ is now known as maciejjozefczyk09:01
*** dpawlik has quit IRC09:03
*** dpawlik has joined #openstack-nova09:03
bauzasgibi: morning09:03
gibibauzas: hi!09:03
bauzasgibi: not really, I can abandon it09:03
bauzasgibi: how are you ? are you locked down too ?09:03
gibibauzas: please abandon it. thanks09:04
gibibauzas: general lockdown yes. groceries are open between 6:00 - 15:00 everything else is closed09:04
bauzasgibi: and you can walk outside home ?09:05
* bauzas is glad to have a dog09:05
gibibauzas: yeah walks and forests are open09:05
gibionly the gatherings are forbidden09:05
gibibauzas: do you only allowed to walk outside if you have a dog?09:06
bauzasokay, b/c for us, we have to stay home unless 5 reasons09:06
bauzasfood, work (but only if very needed), urgent needing, and dogwalks yes :p09:06
bauzasyou can't for example run outside09:07
bauzasonly around your house (like 100m)09:07
gibiinteresting distinction09:07
*** dpawlik has quit IRC09:08
gibianyhow I mostly agree with the closedown09:09
*** zhanglong has quit IRC09:09
bauzasme too09:11
gibimy wife will make the flat soo clean as she has nothing else to really do :)09:11
bauzasjust the fact that it's a bit difficult to both work and teach my children09:11
gibiyeah home schooling is an extra job09:12
*** iurygregory has quit IRC09:12
*** ociuhandu has quit IRC09:12
*** ociuhandu has joined #openstack-nova09:12
gibibut we have no kids so I only know that hardness from my coworkers and my sister09:13
*** iurygregory has joined #openstack-nova09:14
gibiartom: I abandoned a bunch of patches thanks for pushing me looking at that list.09:19
*** martinkennelly has joined #openstack-nova09:32
*** derekh has joined #openstack-nova09:33
kashyapbauzas: Running is still allowed here.09:42
kashyapgibi: We will only be able to lockdown is the right decision retrospectively.09:43
*** mmethot has joined #openstack-nova09:52
*** mmethot_ has quit IRC09:54
bauzashttps://www.thelocal.fr/20200318/frances-coronavirus-lockdown-form-your-questions-answered09:58
bauzaskashyap: ^ as you can read, running is possible but with a very short distance09:59
*** yoctozepto has quit IRC09:59
bauzaswithin*09:59
* kashyap nods09:59
bauzas(and alone)09:59
kashyapYeah10:00
bauzasthe main issue is that kids have zero possibilities to go outside, they're literally locked down for 3 or more weeks10:00
bauzasI'm glad I have a house with garden10:00
*** corvus_ has joined #openstack-nova10:01
*** mkrai_ has joined #openstack-nova10:02
*** mkrai has quit IRC10:02
*** yoctozepto has joined #openstack-nova10:03
*** corvus has quit IRC10:04
openstackgerritBalazs Gibizer proposed openstack/nova master: Support unshelve with qos ports  https://review.opendev.org/70475910:05
openstackgerritBalazs Gibizer proposed openstack/nova master: Enable unshelve with qos ports  https://review.opendev.org/70547510:06
*** ociuhandu has quit IRC10:09
*** ociuhandu has joined #openstack-nova10:10
stephenfingibi: FYI https://github.com/testing-cabal/subunit/commit/26d31fa7c34019fad9038addf8114bbb4b656c9210:13
*** yoctozepto2 has joined #openstack-nova10:13
*** yoctozepto has quit IRC10:13
*** yoctozepto2 is now known as yoctozepto10:13
stephenfinThat should kill the "subunit parser error" errors we were getting any time we logged too many warning10:14
stephenfin*s10:14
*** ociuhandu has quit IRC10:15
gibistephenfin: woot \o/10:16
gibiwe just need to bump the subunit dependency to 1.4.010:17
stephenfinIt's already done in openstack/requirements. We just need to fix lower-constraints now, yeah10:17
gibistephenfin: hit me with any review where I can help10:18
gibistephenfin: I really appreciate your effort on fixing this long outstanding bug10:18
openstackgerritStephen Finucane proposed openstack/nova master: Bump python-subunit minimum to 1.4.0  https://review.opendev.org/71361110:21
*** ociuhandu has joined #openstack-nova10:21
stephenfingibi: ^10:21
stephenfinAlso, if you're in the reviewing mood, these two patches are super trivial and good to go https://review.opendev.org/#/c/704533/1 https://review.opendev.org/#/c/710276/210:22
lyarwoodstephenfin: morning morning, how was your lock-in yesterday?10:25
gibistephenfin: regarding https://review.opendev.org/#/c/710276/2/tox.ini , those thing that you removed are the default now?10:26
lyarwoodstephenfin: Could you hit https://review.opendev.org/#/q/status:open+topic:workaround_native_luksv1 & https://review.opendev.org/#/q/status:open+topic:rbd_block_device today if you have time?10:26
bauzasstephenfin: with thoughts ot Saint Patrick, I gladly drank a beer yesterday night to celebrate his memory10:26
*** ociuhandu has quit IRC10:27
openstackgerritMerged openstack/os-resource-classes master: setup.cfg: Configure 'python-requires'  https://review.opendev.org/70453310:46
*** jawad_axd has joined #openstack-nova10:50
*** tbachman has joined #openstack-nova10:51
lyarwoodRandom question, trying to force an instance to launch on a given host in a fresh stable/queens devstack env using --availability-zone nova:unassigned-hostname but it's always failing in n-sch somehow (shouldn't it skip the filters?)11:03
*** nicolasbock has joined #openstack-nova11:03
lyarwood^ is there any config updates required to make that work with a default devstack env on stable/queens?11:03
* lyarwood is trying to reproduce some bdm reservation weirdness when launching an instance on a specific host fails11:04
*** jaosorior has quit IRC11:06
bauzaslyarwood: which exact command do you issue ?11:08
lyarwoodopenstack server create --image cirros-0.3.5-x86_64-disk --flavor m1.xlarge --block-device-mapping vdb=4776528c-f18c-4750-844d-41cbfaf802ab --availability-zone nova:unassigned-hostname test11:09
bauzaslyarwood: and IIRC, --az <host>:<node>:az11:09
bauzaslemme double-check the API11:09
lyarwoodhttps://docs.openstack.org/nova/queens/admin/availability-zones.html11:10
lyarwood^ is what I was going off11:10
lyarwoodand the customers reproducer downstream11:10
lyarwoodthat uses az:host11:10
bauzassec, checking11:10
lyarwoodcompute_api.parse_availability_zone also uses that11:10
bauzashttps://github.com/openstack/nova/blob/master/nova/compute/api.py#L47511:11
bauzaslyarwood: but look11:11
bauzasif you don't provide a tuple of 3 items (az, host, node) but only 2 (az, host) then you need to double ":"11:12
bauzaslyarwood: ^11:12
bauzashttps://github.com/openstack/nova/blob/master/nova/compute/api.py#L48811:12
bauzasholy snap11:12
bauzasI'm wrong11:12
lyarwoodyeah you only need 111:13
bauzas"::" is for (az, host11:13
bauzasdamn11:13
bauzas(az, node)11:13
bauzaslyarwood: I guess you have nova service-list telling you that you have nova-compute on some random host literrally named 'unassigned-hostname' ?11:14
lyarwood$ openstack compute service list --service nova-compute11:14
lyarwood+----+--------------+---------------------+------+---------+-------+----------------------------+11:14
lyarwood| ID | Binary       | Host                | Zone | Status  | State | Updated At                 |11:14
lyarwood+----+--------------+---------------------+------+---------+-------+----------------------------+11:14
lyarwood|  2 | nova-compute | unassigned-hostname | nova | enabled | up    | 2020-03-18T11:14:39.000000 |11:14
lyarwood+----+--------------+---------------------+------+---------+-------+----------------------------+11:15
lyarwoodyeah11:15
*** tesseract-RH has joined #openstack-nova11:16
lyarwoodMar 18 07:02:06 unassigned-hostname nova-scheduler[3674]: DEBUG nova.scheduler.manager [None req-27d6db0a-3f02-4350-8bab-7cc9f93639d0 admin admin] Got no allocation candidates from the Placement API. This may be a temporary occurrence as compute nodes start up and begin reporting inventory to the Placement service.  - ah11:16
lyarwoodmaybe we are bailing on before we even get to filtering the hosts11:17
*** tesseract has quit IRC11:18
*** ociuhandu has joined #openstack-nova11:19
*** jaosorior has joined #openstack-nova11:20
lyarwoodhttps://github.com/openstack/nova/blob/78e53bd388a5c2305da5249f1f217923d3fe2aac/nova/scheduler/manager.py#L134-L139 yup that's it11:20
bauzaslyarwood: we don't go with checking the filters if you specify a target like this11:20
lyarwoodyeah it's failing before we get anywhere near there11:20
lyarwoodI think it's the hostname causing issues11:20
lyarwoodI'll unstack, set something valid and try again11:20
bauzasweirdo11:21
lyarwoodyup indeed11:21
*** ociuhandu has quit IRC11:35
*** martinkennelly has quit IRC11:43
stephenfinlyarwood: Sorry, meetings. Yup, I'll take a look11:45
stephenfinand my lock was me cooped up at home, figuring out how traefik worked with a single beer11:45
*** mkrai_ has quit IRC11:46
*** ivve has joined #openstack-nova11:47
stephenfingibi: replied on https://review.opendev.org/#/c/710276/11:48
*** martinkennelly has joined #openstack-nova11:48
lyarwoodstephenfin: my deepest condolences11:48
stephenfinI should have been clearer in the commit message - I'd forgotten half the reason I'd done some of that myself. Can edit it if you'd like11:48
lyarwoodbauzas: so I'm still getting no allocation candidates from placement11:49
stephenfinyo, bauzas, can you hit https://review.opendev.org/#/c/710239 please?11:50
* bauzas goes for lunch but will back in 1 hour11:51
lyarwoodah wait I'm being stupid11:52
*** sapd1 has quit IRC11:53
openstackgerritMerged openstack/nova master: bug-fix: Reject live migration with vpmem  https://review.opendev.org/70811011:55
*** rpittau is now known as rpittau|bbl12:01
*** ralonsoh has quit IRC12:05
openstackgerritMerged openstack/nova master: VMware VMDK detach: get adapter type from instance VM  https://review.opendev.org/65373812:09
*** ralonsoh has joined #openstack-nova12:09
*** zhanglong has joined #openstack-nova12:10
openstackgerritLuyao Zhong proposed openstack/nova master: support live migration with vpmems  https://review.opendev.org/68785612:14
*** nweinber has joined #openstack-nova12:18
openstackgerritLuyao Zhong proposed openstack/nova master: Track orphan instances and error migrations in resource tracker  https://review.opendev.org/67845112:21
*** ratailor has quit IRC12:32
lyarwoodeh when did ubuntu make upgrade and dist-upgrade different?12:42
lyarwoodI hit this again https://bugs.launchpad.net/os-vif/+bug/1749972 because virt-builder is just running upgrade when you build with --update12:42
openstackLaunchpad bug 1749972 in os-vif "`brctl setageing $bridge 0` fails on Ubuntu 16.04 4.4.0-21-generic" [Undecided,Invalid]12:42
lyarwood*sigh*12:43
sean-k-mooneylyarwood: its always been different12:43
sean-k-mooneylyarwood: dist-upgrade upgrades your kernel and all other packages12:43
sean-k-mooneyupgrade will hold back some packages that would require a hots reboot to take effect12:44
*** udesale_ has joined #openstack-nova12:44
lyarwoodsean-k-mooney: ack thanks, I haven't used Ubuntu as a daily OS in something like 12 years so I guess I had just forgotten this12:44
*** jaosorior has quit IRC12:45
sean-k-mooneyya i use it daily so i swap between the two depening on what behavior i want12:45
jkulikupgrade will also hold back packages needing new dependencies to be installed or other packages to be uninstalled. not only reboots. at least in debian.12:45
sean-k-mooneyjkulik: correctg12:46
sean-k-mooneyupgrade is more concervitive12:46
*** udesale has quit IRC12:47
sean-k-mooneylyarwood: how did that affect that bug12:47
sean-k-mooneywas brctl not upgraded?12:47
sean-k-mooneylyarwood: also why are you using 16.04? aren't all stable brnaches that use that em at this point?12:49
*** amoralej is now known as amoralej|lunch12:53
lyarwoodsean-k-mooney: deploying stable/queens12:54
sean-k-mooneyi think queens runs fine on 18.04 as well12:54
sean-k-mooneybut ok12:55
lyarwoodsean-k-mooney: as you said in that bug it appears that something in the kernel changed during the lifecycle of that release12:55
lyarwoodsean-k-mooney: yeah I was just copying CI12:55
sean-k-mooneyi had completely forgoten about that bug report so thanks for marking it invalid12:55
lyarwoodnp12:56
* lyarwood -> lunch brb12:56
*** rpittau|bbl is now known as rpittau13:01
artomgibi, thanks for the cleanup :)13:01
artomI would have been even more agressive - like https://review.opendev.org/#/c/525335 is from 2 years ago with no response13:02
artomBut I won't tell you how to do your job ;)13:02
openstackgerritwaleed mousa proposed openstack/os-vif master: [Follow Up] OVS DPDK port representors support  https://review.opendev.org/70501813:03
*** ygk_12345 has joined #openstack-nova13:04
luyaoartom: Hi13:04
ygk_12345hi all13:04
ygk_12345i have rocky setup.13:04
ygk_12345when I try to launch an instance on a specific compute node , it is throwing this error in the nova-compute logs13:05
ygk_12345Failed to retrieve resource provider tree from placement API for UUID ea3af0ff-fb69-449a-b484-5ac722010a1f13:05
*** tesseract has joined #openstack-nova13:05
gibiartom: you recently asked questions on https://review.opendev.org/#/c/525335 so I allow the author to answer. :)13:07
sean-k-mooneyygk_12345: does the vm launch correctly13:07
*** lbragstad has joined #openstack-nova13:07
ygk_12345sean-k-mooney no . it is going  into error state13:08
*** tesseract-RH has quit IRC13:08
*** obre has quit IRC13:08
sean-k-mooneyygk_12345: i cant recall which release we made placmenert mandatory but have you deployed the placement service13:08
ygk_12345sean-k-mooney its rocky 18.1.9 branch in openstack ansible13:08
sean-k-mooneydid you delete the compute node and recreate it?13:09
ygk_12345sean-k-mooney i tried upgrading the working rocky setup to stein . it failed and so rolled back to rocky now13:09
ygk_12345yes13:09
ygk_12345sean-k-mooney how to delete the compute node  ?13:10
ygk_12345sean-k-mooney i re ran the nova playbook13:10
sean-k-mooneyso this is not a nova issue. its and issue with osa and the operation you performed.13:10
ygk_12345sean-k-mooney so whats the workaround now ?13:11
sean-k-mooneyi think we have disucssed this before but if you delete the compute service and you restart the agent without altering the host name of the compute host then it will create a new compute service record in the db with a differnet uuid13:11
sean-k-mooneybut that will prevent the the agent form creating the resouce provider with the new uuid as the RP name will still be in use13:12
sean-k-mooneycan you validate that by checking if there is a placmenet RP with the hostname?13:12
ygk_12345sean-k-mooney i have altered the hostname and it created the new record in resource_providers db in nova_api table13:12
luyaoartom:  If you see my message, could you help look at https://review.opendev.org/#/c/687856/15/nova/compute/manager.py@8336, I change the order of cleanup during post live migration. We do post_live_migration_at_destination first and then cleanup source  host in existing code logic, if there are some specific reason ? Or if the order doesn't matter?13:12
ygk_12345sean-k-mooney how to do that  ?13:12
*** obre has joined #openstack-nova13:15
*** ccamacho has quit IRC13:16
artomgibi, fair enough :)13:16
sean-k-mooneyyou can use the plamcent openstack client plugin to list the resouce providers and grep for the hostname13:17
gibiartom: ping me next week and I will close out the next patch of reviews including the one you commented :)13:17
ygk_12345sean-k-mooney is placement included at all in rocky ?13:17
artomluyao, looking...13:18
artomgibi, hehe, ack13:18
sean-k-mooneyygk_12345: it was intoduced in pike maybe earlier13:18
*** sapd1 has joined #openstack-nova13:18
sean-k-mooneyygk_12345: so yes it should be included in rocky13:19
luyaoartom: thanks13:19
*** vishalmanchanda has joined #openstack-nova13:19
ygk_12345sean-k-mooney how to install the placement plugin for the openstack client13:20
sean-k-mooneyi think its just "pip install osc-placement"13:21
ygk_12345sean-k-mooney should I do it in the utility node  in openstack ansible ?13:21
sean-k-mooneywell "python3 -m pip install --user osc-placement" woudl be more modern way of doing it13:21
lyarwoodbauzas: random scheduler question for you, if we fail to schedule an instance and it moves to ERROR can we ever retry launching that instance or can we only delete it?13:21
lyarwoodbauzas: working through an issue where failure to schedule an instance with attached volumes leaves these volumes in a reserved state13:22
sean-k-mooneyygk_12345: this really isnt a supprot channel and definetly not for openstack ansible so i dont know.13:22
lyarwoodbauzas: but if we are able to schedule and/or go straight to a specific host and then fail the volumes become available13:22
lyarwoodI assume we want things to stay reserved *if* we can relaunch the instances somehow13:23
ygk_12345sean-k-mooney oh ok13:23
*** brinzhang__ has quit IRC13:31
*** brinzhang__ has joined #openstack-nova13:31
*** zhanglong has quit IRC13:31
*** zhanglong has joined #openstack-nova13:32
*** ociuhandu has joined #openstack-nova13:34
luyaostephenfin: Hi, I saw you rechecked my vpmem-live-migration patch. FYI, I submitted a new version, there are a bug in the previous one causing the tempest test failed under mixed-version compute services, I think I addressed it for now, you can look at it if you have time.13:35
bauzaslyarwood: I'm back13:37
kashyaplyarwood: I can't see how your patch is the reason for the 'tempest-integrated-compute' failure13:37
kashyap(Not that you're claiming it :))13:37
*** ociuhandu has quit IRC13:38
lyarwoodkashyap: which one sorry?13:39
luyaoartom: I'm afraid I can't response to you promptly in IRC , so I'll appreciate that if you can leave comments under that patch.13:39
kashyaplyarwood: The blockCopy one; sorry - https://zuul.opendev.org/t/openstack/build/1796646647854d128ba128b45d5c7a1413:39
artomluyao, yeah, that's fine13:40
* kashyap goes for a bike ride, to alleviate some cabin fever13:40
bauzaslyarwood: to answer your question, you could rebuild I think but not just 'create' again13:42
*** umbSublime_ has joined #openstack-nova13:42
*** lbragstad_ has joined #openstack-nova13:42
artomdansmith, when you're about, you don't have to look at the entire patch, but just the https://review.opendev.org/#/c/687856/15/nova/conductor/tasks/live_migrate.py@57 bit, about using compute service versions to judge support for a thing13:42
*** jraju__ has joined #openstack-nova13:43
lyarwoodbauzas: so we can't just `nova start $instance`13:43
lyarwoodbauzas: we have to rebuild?13:43
*** links has quit IRC13:44
lyarwoodbauzas: either way, I'd assume that given that's an option the volumes should stay reserved right?13:44
*** umbSublime has quit IRC13:44
*** lbragstad has quit IRC13:44
*** amoralej|lunch is now known as amoralej13:46
*** liuyulong has joined #openstack-nova13:46
bauzaslyarwood: 'start' recreates the guest XML but doesn't ask for cinder and neutron13:49
bauzas(AFAIR)13:49
lyarwoodbauzas: it should update the attachment but it wouldn't recreate it13:50
bauzasyup, this13:51
bauzaseither way ,if the instance was set to ERROR on scheduling stage, then the related cell is cell°13:51
bauzascell0 sorry13:51
bauzasso you're messed up13:52
bauzasthat's why a rebuild or resize is the only option13:52
sean-k-mooneythe nova start api action calls power on the virt driver which in the libvirt driver calls hard reboot because reasons13:56
*** Liang__ has joined #openstack-nova13:57
*** Liang__ is now known as LiangFang13:57
sean-k-mooneyso yes it recreates the xml. it might rettrive attachemnt info form cinder but it will not modify the sate of the volume in cinder13:57
*** dave-mccowan has joined #openstack-nova13:57
*** zhanglong has quit IRC13:57
lyarwoodsean-k-mooney / bauzas ; ack thanks13:57
lyarwoodso I'm thinking that either way the volume needs to remain reserved13:58
lyarwoodif we ERROR out during scheduling (current behaviour)13:58
*** zhanglong has joined #openstack-nova13:58
lyarwoodor if we ERROR out in the virt driver during spawn (currently moves back to available)13:58
sean-k-mooneywell if you stop an instance then start it we should not hit the scuduler13:58
sean-k-mooneywe dont for a hard reboot13:58
lyarwoodright13:58
sean-k-mooneya rebuild need to hit the schduler to assert the new image does not contian metadata that invaldiate the current host13:59
sean-k-mooneybut start and reboot dont cause nothing changes13:59
lyarwoodright13:59
sean-k-mooneylyarwood: whats the issue you are looking at by the way13:59
lyarwoodsean-k-mooney: as above, when we ERROR out during scheduling attached volumes remain in a reserved state (as we don't delete their attachments in cinder), if we fail during spawn the compute layer moves the volume back to available (by deleting the attachments in cinder).14:01
nightmare_unrealhello where can I see list of bugs for openstack CLI client  or nova related bugs14:01
sean-k-mooneylyarwood: ah ok14:01
lyarwoodsean-k-mooney: so I'm thinking that for the latter we should keep the volume reserved to avoid something or someone else coming along and using it14:01
lyarwoodif it isn't multiattach etc etc14:01
* lyarwood goes to write a functional test14:02
*** zhanglong has quit IRC14:02
sean-k-mooneylyarwood: the later being during spawn when we delete the attachemtn we leave it in a reserved sate14:02
lyarwoodsean-k-mooney: when we delete the attachments the volume moves back to an available state14:03
lyarwoodsean-k-mooney: I'd like to change this to keep it reserved by not deleting the attachments14:03
sean-k-mooneyin the case wehre start fails or boot fails or both14:04
sean-k-mooneyfor boot it will end up in cell 0 and have host so no attachemts14:04
sean-k-mooney*no host14:04
lyarwoodfor spawn, so we have a host and a cell already14:05
lyarwoodbrb14:06
*** dklyle has joined #openstack-nova14:11
*** yoctozepto1 has joined #openstack-nova14:12
*** yoctozepto has quit IRC14:13
*** yoctozepto1 is now known as yoctozepto14:13
*** brinzhang__ has quit IRC14:14
*** ccamacho has joined #openstack-nova14:21
sean-k-mooneynightmare_unreal: nova bugs are here https://bugs.launchpad.net/nova14:24
sean-k-mooneynightmare_unreal: the openstack client uses storyborad14:24
sean-k-mooneyso here https://storyboard.openstack.org/#!/project/openstack/python-openstackclient but this is all the releated projects https://storyboard.openstack.org/#!/project_group/8014:25
nightmare_unrealthanks :)14:26
*** ygk_12345 has quit IRC14:30
dansmithartom: your sigh about migration func testing is lack of review I assume?14:34
dansmithI'm sure I'm at least partially to blame there14:34
artomdansmith, no, mostly towards myself14:35
dansmithoh okay14:35
artomFor not staying on top of it14:35
artomI wanted to do a push, well, starting now14:36
artomI still have stephenfin's feedback from the previous millenium to address (about the 2/3 NUMA nodes split)14:36
artomBut if we manage to land it before the VPMEM live migration patch, it would make things easier14:37
dansmithack14:37
dansmithI'm pretty un-jazzed about that patch14:37
openstackgerritBalazs Gibizer proposed openstack/nova master: Support unshelve with qos ports  https://review.opendev.org/70475914:38
openstackgerritBalazs Gibizer proposed openstack/nova master: Enable unshelve with qos ports  https://review.opendev.org/70547514:38
artomdansmith, live migration with VPMEM?14:38
dansmithyes14:38
artomIn terms of current implementation or the concept in general?14:39
artomI'm just neutral-jazzed - I got involved because my pawprints are all over that code after NUMA live migration14:39
dansmithwell, I'm rather negative on the vpmem stuff in general, but that ship has sailed..But yeah, the current patch more acutely14:39
openstackgerritBalazs Gibizer proposed openstack/nova master: Merge qos related renos for Ussuri  https://review.opendev.org/70676614:40
dansmithit smacks of "let me just move around all these critical things so they work the way I need them"14:40
artomYeah...14:40
lyarwoodsean-k-mooney: https://bugs.launchpad.net/neutron/+bug/1867936 seen this before?14:40
openstackLaunchpad bug 1867936 in neutron "test_update_delete_extra_route failing due to timeout when creating subnets" [Undecided,New]14:40
artomdansmith, you've essentially put words on a vague feeling I had14:41
sean-k-mooneylyarwood: only in the failure of one of your patches14:41
artomWhich is why I would really be more comfortable if we at least had NUMA LM func tests in-tree before merging14:41
gibidansmith: hi! added the global service version check to https://review.opendev.org/#/c/70547514:42
artomThose at least exercise those code paths14:42
dansmithartom: well, I certainly don't think that's unreasonable, as long as we can get that moving14:42
artomdansmith, ack, lemme get on that14:42
lyarwoodsean-k-mooney: yeah I've seen it a few times, was just wondering if someones already raised a more specific bug report for this14:42
dansmithartom: using your patch to validate what we have in tree so we can more directly assess the changes this one makes would be helpful14:43
dansmithgibi: ack14:43
artomdansmith, the bottom two of https://review.opendev.org/#/c/705545/ would be ready, I'd say14:43
sean-k-mooneylyarwood: there have been some issue with the dhcp agent by the way. e.g. it not seting up the dhcp config in a timely manner14:43
dansmithgibi: I feel like we might be at the point with the cyborg set where someone else needs to take over it.. I'm not fully caught up yet this morning but I think feedback has been pending for a while now14:43
sean-k-mooneythis might just be a side effect of that althogh i though that neuton had fixed that14:43
artomdansmith, if you have any -1s to get in on those, do it now ;)14:44
lyarwoodsean-k-mooney: kk14:44
dansmithartom: at least the bottom one is -W, should it not be?14:44
gibidansmith: I agree. I can spend some review time on that series but I cannot promise to take over the impl14:44
artomdansmith, it's to indicate that the top 2 aren't ready14:44
artomIt shouldn't stop you from -1'ing :)14:45
dansmithgibi: no, not asking the latter, but it would be good if we could have the next few above your +2s reviewed and then make a big effort there14:45
gibidansmith: OK. I will look into those patches soon14:45
dansmithgibi: thanks, I'll start in on your unshelve patch14:46
gibidansmith: thanks14:46
gibidansmith: I'm working on retrofitting the service version check to the other qos move operations implemented in Ussuri14:47
gibidansmith: but the pattern is there in the unshelve patch14:48
*** dtantsur is now known as dtantsur|brb14:48
dansmithgibi: okay, things that are already landed are kinda already out of the bag, unless you mean gating everything on this service version for people that haven't rolled yet14:48
gibidansmith: I'm planning to gate it on the service version I added at the unshelve patch14:49
gibidansmith: does it make sense to you?14:49
gibidansmith: I don't think many people rolled Ussuri yet14:49
dansmithokay.. technically that is kinda making history go backwards, but for the practical case where people are just deploying releases, it makes sense14:49
dansmithI don't really want to get too far into that line of thinking, because it leads us towards "break things during the release as long as we fix before GA" but... this isn't quite that14:50
gibidansmith: I consider it as a bug that was introduced in Ussuri and fixed in Ussuri14:50
* dansmith nods14:51
* gibi going back to code14:51
nightmare_unrealhow can i report a bug , it's related to openstack client14:51
nightmare_unrealuse storyboard ?14:51
*** mkrai has joined #openstack-nova14:52
stephenfinnightmare_unreal: yeah, I think so14:53
*** macz_ has joined #openstack-nova14:55
*** corvus_ is now known as jeblair14:56
*** jeblair is now known as corvus14:56
*** lbragstad__ has joined #openstack-nova14:57
*** lbragstad_ has quit IRC14:59
*** priteau has joined #openstack-nova15:00
lyarwoodsean-k-mooney: https://zuul.opendev.org/t/openstack/build/b62f4ef603904e05bc34e2a32a4d2866/log/logs/screen-n-cpu.txt#6754 - so the nova-live-migration evacuation failure looks like another race between libvirtd and n-cpu btw15:03
lyarwoodat least in this example15:04
lyarwoodah ignore me that's an earlier negative test15:08
*** TxGirlGeek has joined #openstack-nova15:10
dansmithgibi: maybe you can save me some time checking on this, but... it looks like we do set reqspec.requested_resources in various places,15:15
dansmithbut this patch just blindly sets that on reqspec (as you do elsewhere)15:16
dansmithis the _only_ time any of requested_resources gets used is for port qos right now and you're just taking the shortcut of being aggressive there?15:16
*** mlavalle has joined #openstack-nova15:16
dansmithI note the comment to that effect, but I just want to make sure you're positive that it's only used for that, and that it's always safe to blow those away15:17
gibidansmith: I'm positive it is use only for that (except the cyborg case where I'm not sure what is merged yet)15:17
dansmithnothing for it is merged, so that's safe15:17
gibibut I do remember that the cyborg change was proper and did not overwrite the requested_resources15:18
gibidansmith: so I think we are safe there15:18
dansmithseems a little risky to just be blind about these early cases, and that it's going to be a source of bugs later where cyborg uses it for spawn, for example but unshelve overwrites those15:18
openstackgerritLee Yarwood proposed openstack/nova master: gate: Ensure n-cpu is stopped on the subnode during evacuation testing  https://review.opendev.org/71367415:19
lyarwoodsean-k-mooney: ^ so I wonder if n-cpu running on the subnode is borking things here even if it is marked as down in the API?15:19
lyarwoodI can see the subnode refreshing the instance network info cache for example15:20
lyarwoodwhile we are trying to evacuate15:20
gibidansmith: the field is not persisted so I don't think we will overwrite existing data from the past. every user of the requested_resources needs to re-fill it for each operation15:20
dansmithahh, okay that makes sense15:20
sean-k-mooneylyarwood: well the mark host down api has  a prequisite that the host is actully down and the agents are stoped15:25
sean-k-mooneylyarwood: if we voilate that expectation then perhaps it coudl cause issues15:26
sean-k-mooneylyarwood: in the evacuate case we proably should be storping n-cpu on the compute host as it is not properly fenced if it is running and able to connect to the message bus/db15:27
lyarwoodsean-k-mooney: yup, if it's pinging neutron behind our backs I'm assuming that's going to cause issues when it comes to evacuting the instance from the node15:28
sean-k-mooneywell i have not check how the info cache works but unless its per host then it could replace the binding info in the cache with the stale prot bindin info for the orginal host15:29
sean-k-mooneyalthough im not sure if that would cause an issue15:29
sean-k-mooneyits certenly safter to not have it messing with the info cache15:29
sean-k-mooneythe warning is pretty clear in the api docs too on this point "tting a service forced down without completely fencing it will likely result in the corruption of VMs on that host."15:30
*** vishalmanchanda has quit IRC15:31
*** udesale_ has quit IRC15:32
openstackgerritBalazs Gibizer proposed openstack/nova master: Add service version check for live migrate with qos  https://review.opendev.org/71367915:32
openstackgerritBalazs Gibizer proposed openstack/nova master: Add service version check for evacuate with qos  https://review.opendev.org/71368015:32
gibidansmith: fyi I retrofitted the service version check to the rest of the Ussuri qos move code ^^15:33
openstackgerritLee Yarwood proposed openstack/nova master: WIP gate: Ensure n-cpu is stopped on the subnode during evacuation  https://review.opendev.org/71367415:36
openstackgerritBalazs Gibizer proposed openstack/nova stable/stein: Fix intermittently failing regression case  https://review.opendev.org/71368215:37
openstackgerritLee Yarwood proposed openstack/nova master: WIP gate: Ensure n-cpu is stopped on the subnode during evacuation  https://review.opendev.org/71367415:37
openstackgerritBalazs Gibizer proposed openstack/nova stable/stein: Fix intermittently failing regression case  https://review.opendev.org/71368215:37
*** LiangFang has quit IRC15:41
*** jawad_axd has quit IRC15:45
openstackgerritBalazs Gibizer proposed openstack/nova master: [Community goal] Update contributor documentation  https://review.opendev.org/71242015:52
dansmithgibi: can you look at my concern here real quick? https://review.opendev.org/#/c/713679/1/nova/api/openstack/compute/migrate_server.py16:01
*** mkrai has quit IRC16:02
gibidansmith: looking16:02
openstackgerritMerged openstack/os-resource-classes master: Switch to hacking 2.x  https://review.opendev.org/71027616:03
gibidansmith: make sense. I can reword the API error, and LOG the detailed info16:03
dansmithgibi: okay, thanks16:04
dansmithalso, vmware ci did report on the un-deprecate patch... but it failed and only ran two tempest tests (both of which failed)16:04
gibidansmith: I will respin th whole series and fix your nits on the bottom too.16:04
dansmithgibi: same api concern here: https://review.opendev.org/#/c/705475/6/nova/api/openstack/compute/shelve.py16:05
dansmithgibi: cool, I'll circle back quickly when you do16:05
gibidansmith: yepp, and in the evac patch too16:05
gibidansmith: regarding vmware. I think it is fair to say that we need those self selected tempest test to pass16:05
dansmithI think we need to see it working on a wide scale for a substantial period of time,16:06
dansmithbecause this pattern of making it work for two weeks until it breaks again doesn't really translate to quality16:06
gibidansmith: yes, you have a point16:07
gibidansmith: does it only triggers to vmware related patcheS? because then there will be not many changes that triggers them16:08
dansmithAFAICT, it's manually triggered it seems16:08
gibithat feels like cheating for a CI machinery16:09
*** sapd1 has quit IRC16:09
*** lbragstad__ has quit IRC16:14
*** lbragstad has joined #openstack-nova16:23
*** slaweq has quit IRC16:28
*** mlavalle has quit IRC16:35
*** mlavalle has joined #openstack-nova16:35
openstackgerritLee Yarwood proposed openstack/nova master: WIP gate: Ensure n-cpu is stopped on the subnode during evacuation  https://review.opendev.org/71367416:39
*** mlavalle has quit IRC16:42
*** mlavalle has joined #openstack-nova16:42
*** mlavalle has quit IRC16:44
*** mlavalle has joined #openstack-nova16:45
*** johanssone has quit IRC16:51
*** mlavalle has quit IRC16:53
*** mlavalle has joined #openstack-nova16:53
*** jraju__ has quit IRC16:54
*** johanssone has joined #openstack-nova16:56
*** johanssone has quit IRC16:57
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in os-flavor-access policies  https://review.opendev.org/71369716:59
*** tesseract has quit IRC16:59
*** johanssone has joined #openstack-nova17:03
*** johanssone has quit IRC17:03
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in os-flavor-access policies  https://review.opendev.org/71369717:05
*** johanssone has joined #openstack-nova17:05
gmannjohnthetubaguy: list flavor-access policy is little wired. old defaults are admin-or-owner which i think should be admin as multiple projects can have access to single flavor so owner is not suitable things for flavor. ^^ updating it with more accurate new defaults.  you can see details in bug https://bugs.launchpad.net/nova/+bug/186784017:05
openstackLaunchpad bug 1867840 in OpenStack Compute (nova) "os-flavor-access API policy should be admin only" [Undecided,New] - Assigned to Ghanshyam Mann (ghanshyammann)17:05
*** johanssone has quit IRC17:05
*** johanssone has joined #openstack-nova17:06
gmanni did not fix the old default as bug because that can break existing deployment. so thinking to keep supporting them and cleanup during we move to system scope by default17:06
*** johanssone has quit IRC17:08
*** dtantsur|brb is now known as dtantsur17:09
*** johanssone has joined #openstack-nova17:14
*** johanssone has quit IRC17:15
*** johanssone has joined #openstack-nova17:20
*** johanssone has quit IRC17:20
*** johanssone has joined #openstack-nova17:23
*** gyee has joined #openstack-nova17:27
*** johanssone has quit IRC17:27
*** johanssone has joined #openstack-nova17:30
*** johanssone has quit IRC17:32
*** evrardjp has quit IRC17:36
*** evrardjp has joined #openstack-nova17:36
*** priteau has quit IRC17:42
*** johanssone has joined #openstack-nova17:46
*** lbragstad has quit IRC17:47
*** lbragstad has joined #openstack-nova17:48
openstackgerritMerged openstack/nova master: db: Remove unused ec2 DB APIs  https://review.opendev.org/69888017:53
*** johanssone has quit IRC17:54
*** derekh has quit IRC18:00
*** johanssone has joined #openstack-nova18:02
*** johanssone has quit IRC18:02
*** johanssone has joined #openstack-nova18:03
openstackgerritMerged openstack/nova master: libvirt: Check the guest support UEFI  https://review.opendev.org/68567818:05
*** johanssone has quit IRC18:08
openstackgerritBalazs Gibizer proposed openstack/nova master: Support unshelve with qos ports  https://review.opendev.org/70475918:10
openstackgerritBalazs Gibizer proposed openstack/nova master: Enable unshelve with qos ports  https://review.opendev.org/70547518:10
*** dtantsur is now known as dtantsur|afk18:11
*** jawad_axd has joined #openstack-nova18:13
*** johanssone has joined #openstack-nova18:13
openstackgerritBalazs Gibizer proposed openstack/nova master: Add service version check for live migrate with qos  https://review.opendev.org/71367918:13
openstackgerritBalazs Gibizer proposed openstack/nova master: Merge qos related renos for Ussuri  https://review.opendev.org/70676618:13
openstackgerritBalazs Gibizer proposed openstack/nova master: Add service version check for evacuate with qos  https://review.opendev.org/71368018:15
*** amoralej is now known as amoralej|off18:15
gibidansmith: updated the whole qos series ^^18:15
* gibi leaveas for today18:15
dansmithgibi: sweet18:15
gibidansmith: thanks for the review18:15
dansmithnp, will hit those soon18:15
*** johanssone has quit IRC18:19
sean-k-mooneylyarwood: it looks like your evacuate change is hitting some where errors https://zuul.opendev.org/t/openstack/build/daabc75c8992406f8a089a808c2553b9/log/logs/screen-n-cpu.txt#778918:22
*** johanssone has joined #openstack-nova18:22
sean-k-mooneyit disconnect an iscsi volume then reports rbd issues and finally fails with a virtual interface createion faild error18:23
sean-k-mooneyalthough i dont know why that is being raided18:23
*** johanssone has quit IRC18:25
*** johanssone has joined #openstack-nova18:34
*** johanssone has quit IRC18:37
*** johanssone has joined #openstack-nova18:43
*** nicolasbock has quit IRC18:47
*** johanssone has quit IRC18:47
*** johanssone has joined #openstack-nova18:50
*** nicolasbock has joined #openstack-nova18:54
*** jawad_axd has quit IRC18:54
*** maciejjozefczyk has quit IRC18:56
*** johanssone has quit IRC18:57
*** prometheanfire has joined #openstack-nova19:02
lyarwoodsean-k-mooney: which one was that sorry?19:03
lyarwoodsean-k-mooney: oh the evacuation fix19:03
lyarwoodsean-k-mooney: it looked like the same issue again in console.log19:03
lyarwoodsean-k-mooney: I didn't even think to look at n-cpu sorry19:04
* lyarwood checks19:04
*** johanssone has joined #openstack-nova19:04
*** johanssone has quit IRC19:04
sean-k-mooneythe n-cpu logs honestly confuse me19:05
sean-k-mooneyi did not look at teh code but i think the virutal interface creation excpetion is a redheiring19:05
*** johanssone has joined #openstack-nova19:06
*** johanssone has quit IRC19:06
lyarwoodsean-k-mooney: https://zuul.opendev.org/t/openstack/build/daabc75c8992406f8a089a808c2553b9/log/logs/screen-n-cpu.txt#7760 it's the same issue19:07
lyarwoodsean-k-mooney: we hit the vif timeout first and call disconnect_volume19:08
lyarwoodsean-k-mooney: I think the RBD cleanup failures are due to the domain still being active on the subnode19:08
* lyarwood wonders why we are connecting iscsi volumes19:09
lyarwoodoh right because ceph.sh only sets up ephemeral storage on ceph19:09
lyarwoodnot c-vol19:09
prometheanfirelooks like alembic is still failing for nova / neutron https://review.opendev.org/70870619:10
sean-k-mooneyah ok19:10
sean-k-mooneythe ceph thing was confusing me19:10
sean-k-mooneyand ya that kind of makes sense19:10
sean-k-mooneyso we not only need to stop the compute agent but the vms on the sub node too19:11
sean-k-mooneywhich i guess makes sense19:11
*** johanssone has joined #openstack-nova19:11
sean-k-mooneyso we should stop the compute agent. then use libvirt to stop all the vms on the subnode19:12
sean-k-mooneythen do an evacuate19:12
*** johanssone has quit IRC19:14
lyarwoodsean-k-mooney: kk, I'll give that a go.19:16
lyarwoodsean-k-mooney: here's a thought, shouldn't all devstack@* services be stopped on the subnode?19:16
sean-k-mooneyi was consider doing a power off on the subnode19:17
sean-k-mooneybut i think we need logs from it19:17
sean-k-mooneybut yes you could do "sudo systemctl stop devstack@*"19:18
sean-k-mooneythat would be totally valid to do provide we dont install cpeh there19:18
sean-k-mooneyif we are installing ceph in the devstack slice then that woudl be an issue19:19
*** noonedeadpunk has joined #openstack-nova19:21
*** johanssone has joined #openstack-nova19:21
noonedeadpunkhi! is there any reason (like security or other) why flavor transition from public to private or vice versa is not supported?19:22
sean-k-mooneynoonedeadpunk: private flavors was a half impleneted feature that is not commonly used19:22
sean-k-mooneynoonedeadpunk: so support was not added.19:23
noonedeadpunkoh really? Like I was using it pretty much in several clouds19:23
openstackgerritLee Yarwood proposed openstack/nova master: WIP gate: Ensure n-cpu is stopped on the subnode during evacuation  https://review.opendev.org/71367419:23
lyarwoodsean-k-mooney: ^ awful hacks, no idea if that would even work but there we go. This would actually be easier to do if this was a playbook...19:23
noonedeadpunkOk, I see. Just wondering if it makes sense to look into it to propose a patch19:24
noonedeadpunkAs there's no blockers which are aware for everyone, will try that out19:25
sean-k-mooneynoonedeadpunk: its an api change which would require a microverion bump and a spec19:26
sean-k-mooneyso it cant be done as a bug fix19:26
sean-k-mooneyhttps://docs.openstack.org/api-ref/compute/?expanded=remove-flavor-access-from-tenant-removetenantaccess-action-detail#flavors-access-flavors-os-flavor-access19:26
sean-k-mooneythe flavor acess api is what is normally used instead19:26
noonedeadpunksean-k-mooney: the thing I'm missing is transition from is_public: true to is_public: false....19:28
sean-k-mooneyyep19:29
noonedeadpunkbut yeah, it needs api version bump...19:29
noonedeadpunkanyway thanks for answering:)19:30
sean-k-mooneynoonedeadpunk: most flavor fileds are imuntable after its created19:30
sean-k-mooneythe update endpoint only supports updating the description19:31
noonedeadpunkI can understand about flavor properties, as it will mix up isntances19:31
sean-k-mooneyhttps://docs.openstack.org/api-ref/compute/?expanded=update-flavor-description-detail#update-flavor-description19:31
noonedeadpunkbut is_public is kinda visability thing, which should be safe to update in that terms19:31
sean-k-mooneyin theory yes.19:32
sean-k-mooneyalthough updating it wont change the status of the is_public flag in the embded flavor in an instnace19:32
gmannbut it might cause restriction access to few tenants which are not in access list.19:32
openstackgerritmelanie witt proposed openstack/nova master: DNM: try to get some debug info for bug 1844929  https://review.opendev.org/70147819:33
openstackbug 1844929 in OpenStack Compute (nova) "grenade jobs failing due to "Timed out waiting for response from cell" in scheduler" [High,Confirmed] https://launchpad.net/bugs/184492919:33
sean-k-mooneygmann: well this is not using the os-flavor-acces api19:34
sean-k-mooneythis is setting the is_public flag in the flavor itself19:34
sean-k-mooneythe os-flavor-acces api is normally what peopel shoudl use19:34
sean-k-mooneyso to make a flavor private you just add acess to only the admin/service project19:34
sean-k-mooneythen no other tenats can see it19:35
gmannyeah but we restrict the public flavor to process in flavor-access api19:35
gmannyeah, removing all other tenants make it private19:35
sean-k-mooneynoonedeadpunk: does ^ makes sense19:36
sean-k-mooneynoonedeadpunk: is_public on the flavor is a hold over from before we had per tenant contol over flaovr visablity19:37
noonedeadpunkhm, let me check that19:37
noonedeadpunk(actully deploy latest sandbox and test)19:38
sean-k-mooneylyarwood: looking at https://github.com/openstack/devstack-plugin-ceph/blob/master/devstack/lib/ceph#L1213-L1251 it looks like ceph is not in the devstack slice19:38
sean-k-mooneyso stop devstack@* should be ok19:38
*** ociuhandu has joined #openstack-nova19:39
sean-k-mooneyyou would still have to do "killall qemu" or use virish stop on all active domains too to stop the rbd device in use error19:39
lyarwoodsean-k-mooney: right and I don't think we deploy anything on the subnode in this case anyway19:39
gmannonly thing is you would not be able to add projects or list access info on public flavor19:39
sean-k-mooneygmann: you can use the flavor acess api to do that19:40
sean-k-mooneyhorizon allows you to take a standard public flavor and add tenants too it19:40
*** rpittau is now known as rpittau|afk19:40
* lyarwood calls it a night \o19:41
gmannsean-k-mooney: no, after 2.7 add project is restricted on non-public and list access is for non-public only from stating19:41
sean-k-mooneygmann: i tought the os-flaovr-acess api basically ignored the is_public atribte19:41
gmannhttps://github.com/openstack/nova/blob/c9f5b583b6072f542d1757e35fd6305b9698496a/nova/api/openstack/compute/flavor_access.py#L50-L7519:41
sean-k-mooneygmann: right so if you use an older microversion then what happens19:41
gmannwith older than 2.7 yes you can add.19:42
sean-k-mooney i suspect horizon is using older then 2.719:42
sean-k-mooneywhy did we make that change?19:42
gmannwell, public means for everyone so we do not really need to add access things right19:43
sean-k-mooneygmann: basicaly i tought we effectivly deprecated is_public and ignored it19:44
sean-k-mooneygmann: so if you use falvor acess it effectivly became private19:44
sean-k-mooneyexcpet to the tenants listed19:44
sean-k-mooneygmann: if that is not the case then i agree that this should be mutable in the flavor api19:46
sean-k-mooneyyou cant really gracefully retire a flavor othersize.19:46
sean-k-mooneyit looks like it was change as a result of this bug https://bugs.launchpad.net/nova/+bug/136147619:47
openstackLaunchpad bug 1361476 in OpenStack Compute (nova) "flavor access create should check public/private first" [Low,Fix released] - Assigned to Sergey Nikitin (snikitin)19:47
gmannhumm, but will change in is_public on embedded instances effect like make that flavor stale. the reason we do not allow flavor modification on other parameters.19:47
sean-k-mooneymy expectation is that if a flaovr is public and i add a tenatn via os-flavor-access then any tenant other then those listed via flavor access would not see it19:48
sean-k-mooneygmann: is public on the embeded instance has no meaning19:48
gmannand keep is_public same ?19:49
sean-k-mooneyso i dont think its an issue19:49
gmannlisting flavor?19:49
sean-k-mooneyyes19:49
sean-k-mooneyso my expectation is is_public would still be public/true19:49
sean-k-mooneyand flavor list would not list19:49
sean-k-mooneyit19:49
sean-k-mooneyunless you were in the tenant on the access list or an admin19:49
sean-k-mooneyso basicaly i think https://bugs.launchpad.net/nova/+bug/1361476 was invalid19:50
openstackLaunchpad bug 1361476 in OpenStack Compute (nova) "flavor access create should check public/private first" [Low,Fix released] - Assigned to Sergey Nikitin (snikitin)19:50
gmanni mean we have is_public in list flavor filters if anyone listing by their instance's flavor is_public flag19:51
sean-k-mooneywell actully maybe not19:51
sean-k-mooneygmann: can you say that again19:51
sean-k-mooneylooking at the bug i would expect "nova flavor-access-list --flavor 1" to work but i would not expect the flavor to be in "openstack flavor list" unless you were in a tenant with acess or an admin19:52
gmanni mean will is_public change the flavor signature or not? even that does not make any change in real configueation but still a attribute in flavor user facing dict19:52
sean-k-mooneyis_public only changes if you can see the flaovr or not19:53
sean-k-mooneyso i think that is just metadata about the flaovr19:53
sean-k-mooneynot a part of it19:53
gmannyeah. kind of.19:54
sean-k-mooneykind of like the description wich we allow to be udpated19:54
gmannor we just remove this flag.19:54
sean-k-mooneyi think the only benift to it is the defualt polciy19:54
sean-k-mooneye.g. should it be  visable by default or not19:55
sean-k-mooneybut i certenly dont think we should be blocking the use of the flaovr acess api based on it19:55
sean-k-mooneyi would be ok with removing it too but im not sure how others would feel19:56
sean-k-mooneye.g. do operators use it frequently. if soo i think it should be kept and mutable. if not remove and just use flavor acess api for this19:56
gmannok, even list public flavor on list access is not wrong which is why that bug did the change in add access19:56
*** ociuhandu has quit IRC19:57
gmannsorry, need to go for lunch, ttyl19:57
sean-k-mooneyno worries19:57
*** gmann is now known as gmann_afk19:57
sean-k-mooneyim going for food too19:57
*** ociuhandu has joined #openstack-nova19:58
noonedeadpunkit was pretty interesting discussion. Like I thought it is a bit more simple than it is19:59
sean-k-mooneywell the code is simple to change but it has several other implications obvirously19:59
sean-k-mooneynoonedeadpunk: this is why we generally require a spec for api changes as this type of discussion normally happens when we dig into it20:00
noonedeadpunkyeah and it is fair20:00
*** ralonsoh has quit IRC20:01
noonedeadpunkwill try to write down it as it seems that some patching is required anyway20:01
*** ociuhandu has quit IRC20:02
*** ociuhandu has joined #openstack-nova20:02
*** nweinber has quit IRC20:20
*** gmann_afk is now known as gmann20:33
gmannyeah, spec can be better idea to discuss if something we miss. sean-k-mooney proposal looks ok to me for now.20:36
*** ociuhandu has quit IRC20:37
*** ociuhandu has joined #openstack-nova20:38
*** dklyle has quit IRC20:39
*** ociuhandu has quit IRC20:39
*** ociuhandu has joined #openstack-nova20:40
*** damien_r has quit IRC20:40
*** nicolasbock has quit IRC20:40
*** dklyle has joined #openstack-nova20:40
*** damien_r has joined #openstack-nova20:44
openstackgerritMerged openstack/nova master: Lowercase ironic driver hash ring and ignore case in cache  https://review.opendev.org/71168020:50
*** ociuhandu has quit IRC20:56
*** ociuhandu has joined #openstack-nova20:57
openstackgerritmelanie witt proposed openstack/nova stable/train: Lowercase ironic driver hash ring and ignore case in cache  https://review.opendev.org/71373921:00
*** ociuhandu has quit IRC21:02
*** slaweq has joined #openstack-nova21:15
*** openstackstatus has joined #openstack-nova21:16
*** ChanServ sets mode: +v openstackstatus21:16
*** xek has quit IRC21:17
*** ociuhandu has joined #openstack-nova21:18
*** ociuhandu has quit IRC21:27
openstackgerritLee Yarwood proposed openstack/nova master: WIP gate: Ensure n-cpu is stopped on the subnode during evacuation  https://review.opendev.org/71367421:36
*** ociuhandu has joined #openstack-nova21:41
*** ociuhandu has quit IRC21:46
*** slaweq has quit IRC22:00
*** david-lyle has joined #openstack-nova22:01
*** ociuhandu has joined #openstack-nova22:01
*** dklyle has quit IRC22:03
*** ociuhandu has quit IRC22:06
*** david-lyle has quit IRC22:08
*** nicolasbock has joined #openstack-nova22:22
*** nicolasbock has quit IRC22:27
*** nicolasbock has joined #openstack-nova22:28
*** rcernin has joined #openstack-nova22:44
*** tkajinam has joined #openstack-nova22:50
*** ivve has quit IRC22:50
*** macz_ has quit IRC22:56
*** threestrands has joined #openstack-nova22:58
*** sean-k-mooney1 has joined #openstack-nova23:02
*** sean-k-mooney has quit IRC23:04
*** spatel has joined #openstack-nova23:27
*** alex_xu has joined #openstack-nova23:34
alex_xudansmith: artom, thanks for the review https://review.opendev.org/#/c/687856/15/nova/compute/manager.py@8346, I reply that, but yes,  we tried differnt options, and back and forward many times ourselve, looking for suggestion :)23:36
*** spatel has quit IRC23:51

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!