| *** ileixe has joined #openstack-nova | 00:18 | |
| *** ileixe has quit IRC | 00:19 | |
| *** ileixe has joined #openstack-nova | 00:20 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Expose instance action event details out of the API https://review.opendev.org/694430 | 00:24 |
|---|---|---|
| openstackgerrit | Brin Zhang proposed openstack/nova master: Add instance actions v284 samples test https://review.opendev.org/706251 | 00:24 |
| gmann | brinzhang_: thanks, lgtm. though you are racing on 2.84 with stephenfin. let's see who win. | 00:27 |
| brinzhang_ | gmann: np, thanks for concerning this | 00:28 |
| *** david-lyle has joined #openstack-nova | 00:35 | |
| *** ileixe has quit IRC | 00:35 | |
| *** TxGirlGe_ has joined #openstack-nova | 00:36 | |
| *** huaqiang has joined #openstack-nova | 00:37 | |
| *** dklyle has quit IRC | 00:38 | |
| *** alex_xu has quit IRC | 00:38 | |
| *** TxGirlGeek has quit IRC | 00:38 | |
| *** artom has quit IRC | 00:41 | |
| *** bbowen_ has quit IRC | 00:46 | |
| *** bbowen_ has joined #openstack-nova | 00:47 | |
| *** mvkr has quit IRC | 00:50 | |
| brinzhang_ | gibi, stephenfin: instance action events patch updated done. https://review.opendev.org/#/c/694430/ | 00:52 |
| openstackgerrit | Merged openstack/nova master: Create and bind Cyborg ARQs. https://review.opendev.org/631244 | 00:53 |
| *** macz_ has joined #openstack-nova | 00:54 | |
| *** lbragstad has quit IRC | 00:57 | |
| *** macz_ has quit IRC | 00:59 | |
| *** eandersson8 has joined #openstack-nova | 01:00 | |
| *** lbragstad has joined #openstack-nova | 01:01 | |
| *** eandersson has quit IRC | 01:01 | |
| *** eandersson8 is now known as eandersson | 01:01 | |
| *** mvkr has joined #openstack-nova | 01:02 | |
| *** prometheanfire has joined #openstack-nova | 01:02 | |
| *** dklyle_ has joined #openstack-nova | 01:03 | |
| *** Liang__ has joined #openstack-nova | 01:03 | |
| gmann | johnthetubaguy: how about making GET flavor access default to @ instead of admin-only. we cannot verify the owner in this API so anyone trying this API and not having the access to flavor will anyway get 404. changing to admin as i proposed currently will disallow the tenants who have access to flavor - https://review.opendev.org/#/c/713697/3/nova/policies/flavor_access.py@68 | 01:05 |
| *** TxGirlGe_ has quit IRC | 01:06 | |
| *** david-lyle has quit IRC | 01:06 | |
| gmann | johnthetubaguy: keeping @ will keep existing deployment working as it is and also does not show flavor-access info to all who does not have access. | 01:06 |
| *** TxGirlGeek has joined #openstack-nova | 01:07 | |
| *** sapd1 has quit IRC | 01:22 | |
| *** zhanglong has joined #openstack-nova | 01:25 | |
| openstackgerrit | Kevin Zhao proposed openstack/nova master: fix scsi disk unit number of the attaching volume when cdrom bus is scsi https://review.opendev.org/712607 | 01:34 |
| *** sapd1 has joined #openstack-nova | 01:46 | |
| *** tetsuro has joined #openstack-nova | 01:51 | |
| *** tetsuro has quit IRC | 01:53 | |
| *** tetsuro_ has joined #openstack-nova | 01:53 | |
| openstackgerrit | Merged openstack/nova master: Pass accelerator requests to each virt driver from compute manager. https://review.opendev.org/698581 | 02:07 |
| brinzhang_ | gmann: Can I push a new to change the os-volume-attachment:update policy to os-volume-attachment:swap policy for swap volume api? | 02:09 |
| brinzhang_ | gmann: and I would update the releasenote message with update attachments API changes | 02:09 |
| gmann | brinzhang_: you mean to do in this ? https://review.opendev.org/#/c/711194/7 | 02:10 |
| brinzhang_ | gmann: I dont want to change this in the update attachments API, it will looks complex | 02:11 |
| brinzhang_ | gmann: yes | 02:11 |
| gmann | brinzhang_: yeah that is fine. but functional tests you are merging right ? | 02:11 |
| brinzhang_ | The 2 point you said | 02:11 |
| brinzhang_ | gmann: maybe not merge the functional tests | 02:12 |
| gmann | api-ref and functional sample test change we should do while changing code | 02:12 |
| gmann | policy change is ok to do in separate as it change the other polciy also but api-ref and functional tests we do together with code change to get the complete picture in same patch | 02:12 |
| brinzhang_ | To be honest, doing this function from scratch will waste my double time. I started thinking that now Dansmith insists, and I regret that I didn't insist on doing so at the time. | 02:13 |
| brinzhang_ | gmann: ok, I can consinder merge the functional tests to the api change | 02:13 |
| brinzhang_ | s/Dansmith/dansmith/ | 02:14 |
| brinzhang_ | gmann: I think the PS32 what I should next to do https://review.opendev.org/#/c/580336/32/specs/ussuri/approved/destroy-instance-with-datavolume.rst | 02:15 |
| brinzhang_ | Although I haven't finished all the reviews | 02:16 |
| gmann | brinzhang_: yeah that way. but do not worry about spec update. we can do that later once code is done | 02:16 |
| brinzhang_ | gmann: yeah, I will try my best, try not to postpone | 02:17 |
| gmann | brinzhang_: if i remember that is 1. making volumeId in request as optional 2. if it is present and different then url volume_id perform swap operation OR if not present or same as url volume_id then update the delete flag. | 02:20 |
| brinzhang_ | gmann: yes, that's the same as wrote in PS32 of its SPEC | 02:21 |
| gmann | ok. | 02:21 |
| *** dswebb has quit IRC | 02:38 | |
| *** sapd1_x has joined #openstack-nova | 02:39 | |
| *** artom has joined #openstack-nova | 02:43 | |
| *** artom has quit IRC | 02:43 | |
| *** artom has joined #openstack-nova | 02:44 | |
| *** gyee has quit IRC | 02:53 | |
| *** lbragstad has quit IRC | 03:04 | |
| *** tetsuro_ has quit IRC | 03:11 | |
| *** mkrai has joined #openstack-nova | 03:13 | |
| *** psachin has joined #openstack-nova | 03:40 | |
| *** Liang__ is now known as LiangFang | 03:46 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-hypervisors policies https://review.opendev.org/715071 | 03:47 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the actual target in os-hypervisors policy https://review.opendev.org/715074 | 03:48 |
| *** mkrai_ has joined #openstack-nova | 03:52 | |
| *** mkrai has quit IRC | 03:52 | |
| *** zhanglong has quit IRC | 03:59 | |
| *** tetsuro has joined #openstack-nova | 04:30 | |
| *** ociuhandu has joined #openstack-nova | 04:32 | |
| *** ociuhandu has quit IRC | 04:37 | |
| *** haleyb has quit IRC | 04:46 | |
| *** zhanglong has joined #openstack-nova | 04:53 | |
| *** ociuhandu has joined #openstack-nova | 05:01 | |
| *** sapd1 has quit IRC | 05:04 | |
| *** sapd1_y has joined #openstack-nova | 05:04 | |
| *** udesale has joined #openstack-nova | 05:06 | |
| *** tetsuro has quit IRC | 05:10 | |
| *** ociuhandu has quit IRC | 05:18 | |
| *** ociuhandu has joined #openstack-nova | 05:20 | |
| *** ratailor has joined #openstack-nova | 05:22 | |
| *** mkrai_ has quit IRC | 05:24 | |
| *** mkrai__ has joined #openstack-nova | 05:24 | |
| *** ociuhandu has quit IRC | 05:25 | |
| *** TxGirlGeek has quit IRC | 05:26 | |
| *** links has joined #openstack-nova | 05:30 | |
| *** ericyoung has quit IRC | 05:31 | |
| *** ericyoung has joined #openstack-nova | 05:32 | |
| *** evrardjp has quit IRC | 05:36 | |
| *** evrardjp has joined #openstack-nova | 05:36 | |
| *** zhanglong has quit IRC | 05:44 | |
| *** mkrai__ has quit IRC | 05:52 | |
| *** mkrai has joined #openstack-nova | 05:52 | |
| *** zhanglong has joined #openstack-nova | 05:57 | |
| *** tetsuro has joined #openstack-nova | 06:00 | |
| *** zhanglong has quit IRC | 06:02 | |
| *** ociuhandu has joined #openstack-nova | 06:06 | |
| openstackgerrit | Kevin Zhao proposed openstack/nova master: fix scsi disk unit number of the attaching volume when cdrom bus is scsi https://review.opendev.org/712607 | 06:08 |
| *** zhanglong has joined #openstack-nova | 06:18 | |
| *** ociuhandu has quit IRC | 06:20 | |
| openstackgerrit | Kevin Zhao proposed openstack/nova master: fix scsi disk unit number of the attaching volume when cdrom bus is scsi https://review.opendev.org/712607 | 06:29 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Change policy name of swap volume API https://review.opendev.org/715356 | 06:49 |
| openstackgerrit | Kevin Zhao proposed openstack/nova master: fix scsi disk unit number of the attaching volume when cdrom bus is scsi https://review.opendev.org/712607 | 06:53 |
| *** dklyle_ has quit IRC | 06:53 | |
| *** ralonsoh has joined #openstack-nova | 07:08 | |
| *** dpawlik has joined #openstack-nova | 07:11 | |
| *** ratailor has quit IRC | 07:12 | |
| *** ociuhandu has joined #openstack-nova | 07:13 | |
| *** vishalmanchanda has joined #openstack-nova | 07:16 | |
| *** ratailor has joined #openstack-nova | 07:29 | |
| *** factor has joined #openstack-nova | 07:31 | |
| *** maciejjozefczyk has joined #openstack-nova | 07:34 | |
| *** sapd1_y has quit IRC | 07:37 | |
| gibi | sean-k-mooney: thanks for checking the os-vif repo. Do we need to mark somehow that the previous release is the final one for Ussuir? | 07:41 |
| *** xek__ has joined #openstack-nova | 07:43 | |
| aarents | Hi! lyarwood: if you have some time today: https://review.opendev.org/#/c/696084/ | 07:46 |
| *** amoralej|off is now known as amoralej | 07:59 | |
| *** ociuhandu has quit IRC | 07:59 | |
| *** slaweq has joined #openstack-nova | 08:00 | |
| *** nightmare_unreal has joined #openstack-nova | 08:01 | |
| *** psachin has quit IRC | 08:04 | |
| openstackgerrit | Merged openstack/nova master: Compose accelerator PCI devices into domain XML in libvirt driver. https://review.opendev.org/631245 | 08:05 |
| *** lpetrut has joined #openstack-nova | 08:06 | |
| *** mkrai has quit IRC | 08:07 | |
| *** zhanglong has quit IRC | 08:10 | |
| *** zhanglong has joined #openstack-nova | 08:12 | |
| *** elod has quit IRC | 08:13 | |
| *** tesseract has joined #openstack-nova | 08:14 | |
| gibi | brinzhang_: thanks for the update on https://review.opendev.org/#/c/694430 I have on suggestion for the policy doc wording. If you can quickly respin then I'm +2 right away | 08:14 |
| brinzhang_ | gibi: yeah, I will update that | 08:18 |
| *** tkajinam has quit IRC | 08:18 | |
| gibi | brinzhang_: thanks | 08:18 |
| gibi | brinzhang_: I see that you saw the result of the yesterday's discusson on the PATCH v.s. PUT. If you need any help to make this change happen then let me know | 08:19 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Expose instance action event details out of the API https://review.opendev.org/694430 | 08:20 |
| brinzhang_ | gibi: done, thanks | 08:21 |
| *** ociuhandu has joined #openstack-nova | 08:21 | |
| *** mkrai has joined #openstack-nova | 08:22 | |
| brinzhang_ | gibi: I'm not sure if I can make it in the near future. I'm full next week. I understand what dansmith said, that's what I wrote in SPEC's PS32. Of course I would be happy if someone is willing to help update. | 08:23 |
| *** rpittau|afk is now known as rpittau | 08:23 | |
| gibi | brinzhang_: thanks I'm +2 on the event details patch | 08:24 |
| brinzhang_ | gibi: If no one can help, I will try to complete it ASAP. | 08:24 |
| gibi | brinzhang_: ack. If you can make the update then we can review with dansmith if you cannot then I think dansmith is willing to do the update but then we need to bring in another core to review | 08:25 |
| brinzhang_ | gibi: I know this. | 08:26 |
| brinzhang_ | gibi: I think gmann, stephenfin, alex_xu and you can review quickly | 08:28 |
| brinzhang_ | gibi: I don't want the feature freeze to not complete it because I don't have time to do it. | 08:29 |
| brinzhang_ | So expose this risk early. | 08:30 |
| gibi | thanks for being honest | 08:30 |
| gibi | about the risk | 08:30 |
| gibi | I will talk to dansmith when he is up today | 08:30 |
| gibi | as I understand you think it would be better if he (or somebody else) takes over the patch | 08:31 |
| brinzhang_ | thanks gibi | 08:32 |
| brinzhang_ | gibi: Yes, as dansmith said, this change is not difficult, it just takes time and I can take the time to review it together. | 08:34 |
| *** elod has joined #openstack-nova | 08:57 | |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: support live migration with vpmem https://review.opendev.org/687856 | 08:59 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: partial support for live migration with specific resources https://review.opendev.org/715362 | 08:59 |
| *** zhanglong has quit IRC | 09:18 | |
| *** ociuhandu has quit IRC | 09:24 | |
| *** dtantsur|afk is now known as dtantsur | 09:28 | |
| *** tosky has joined #openstack-nova | 09:29 | |
| *** udesale_ has joined #openstack-nova | 09:35 | |
| *** udesale has quit IRC | 09:38 | |
| *** takamatsu has joined #openstack-nova | 09:38 | |
| *** ociuhandu has joined #openstack-nova | 09:41 | |
| *** ccamacho has joined #openstack-nova | 09:42 | |
| *** derekh has joined #openstack-nova | 09:42 | |
| openstackgerrit | jayaditya gupta proposed openstack/nova master: Support for nova-manage placement heal_allocations --cell https://review.opendev.org/714459 | 09:47 |
| *** martinkennelly has joined #openstack-nova | 09:50 | |
| *** LiangFang has quit IRC | 09:53 | |
| *** martinkennelly has quit IRC | 09:55 | |
| *** martinkennelly has joined #openstack-nova | 09:55 | |
| *** zzzeek has quit IRC | 10:04 | |
| *** zzzeek has joined #openstack-nova | 10:05 | |
| *** zhanglong has joined #openstack-nova | 10:14 | |
| *** ociuhandu has quit IRC | 10:14 | |
| openstackgerrit | John Garbutt proposed openstack/nova master: Add legacy limits and usage to unified limits https://review.opendev.org/713498 | 10:19 |
| openstackgerrit | John Garbutt proposed openstack/nova master: Update quota apis with keystone limits and usage https://review.opendev.org/713499 | 10:20 |
| openstackgerrit | John Garbutt proposed openstack/nova master: Add reno for unified limits https://review.opendev.org/715271 | 10:21 |
| *** zhanglong has quit IRC | 10:21 | |
| *** tetsuro has quit IRC | 10:33 | |
| *** ociuhandu has joined #openstack-nova | 10:41 | |
| *** priteau has joined #openstack-nova | 10:57 | |
| *** spatel has joined #openstack-nova | 10:57 | |
| *** brinzhang_ has quit IRC | 10:57 | |
| *** brinzhang_ has joined #openstack-nova | 10:57 | |
| *** xek_ has joined #openstack-nova | 10:59 | |
| *** rnoriega_ has quit IRC | 11:00 | |
| *** spatel has quit IRC | 11:01 | |
| *** xek__ has quit IRC | 11:02 | |
| *** rnoriega_ has joined #openstack-nova | 11:03 | |
| *** tkajinam has joined #openstack-nova | 11:04 | |
| *** brinzhang_ has quit IRC | 11:05 | |
| *** priteau has quit IRC | 11:07 | |
| sean-k-mooney | gibi: i dont think so. at least not currently. the release team will propose a patch to all the project after the first rc is out to bump all the releases for the stable branch creation | 11:08 |
| gibi | sean-k-mooney: OK, cool | 11:09 |
| openstackgerrit | jayaditya gupta proposed openstack/nova master: Support for --overwrite flag for nova-manage placement heal_allocations command https://review.opendev.org/715395 | 11:09 |
| *** ociuhandu has quit IRC | 11:12 | |
| luyao | stephenfin: Hi, Thanks for review, :). I have addressed your comments, also split the patch . https://review.opendev.org/#/q/topic:bp/support-live-migration-with-virtual-persistent-memory+(status:open) | 11:15 |
| nightmare_unreal | stephenfin: I have made changes in https://review.opendev.org/#/c/713881/ as mentioned in the comments. Thanks | 11:16 |
| *** ociuhandu has joined #openstack-nova | 11:18 | |
| *** arxcruz is now known as arxcruz|off | 11:19 | |
| tkajinam | stephenfin, around ? | 11:28 |
| stephenfin | yup | 11:28 |
| tkajinam | stephenfin, it would be nice if I can ask your check about my update in https://review.opendev.org/#/c/456571/ | 11:29 |
| tkajinam | currently we still use the deprecated parameter in puppet-nova, and tripleo which depends on puppet-tripleo. | 11:30 |
| tkajinam | I've already submitted a patch for puppet-nova to use the new parameters, so it's appreciated if we can merge this in early timing | 11:31 |
| sean-k-mooney | stephenfin: for what its worth i still prefer having the live_migration_uri | 11:31 |
| sean-k-mooney | i would prefer to keep that and not add the new paramter as i think that is a nicer interface | 11:31 |
| *** rpittau is now known as rpittau|bbl | 11:32 | |
| tkajinam | sean-k-mooney, I think that is a valid option, though then we should remove deprecated mark about live_migration_uri, IMO. | 11:32 |
| sean-k-mooney | tkajinam: i think its to late for that at this point. the removal has been underway for a while. i just never liked the intoduction of all the other parmaters | 11:33 |
| tkajinam | sean-k-mooney, I see | 11:34 |
| stephenfin | sean-k-mooney: The existing parameter is hard to template | 11:36 |
| sean-k-mooney | not really with jinja | 11:37 |
| stephenfin | and has been the cause of multiple bug reports in TripleO at least | 11:37 |
| *** sapd1_x has quit IRC | 11:37 | |
| sean-k-mooney | i fully expect this to not reduce any bugs | 11:38 |
| sean-k-mooney | they will still happen and now operators will have to learn a new way to configure the config | 11:38 |
| sean-k-mooney | with that said i know why this is being done | 11:39 |
| *** jangutter has joined #openstack-nova | 11:39 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/stein: Functional test for UnexpectedDeletingTaskStateError https://review.opendev.org/715399 | 11:40 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/stein: Unplug VIFs as part of cleanup of networks https://review.opendev.org/715400 | 11:40 |
| sean-k-mooney | just because this nessary it does not mean i like it :) | 11:41 |
| *** macz_ has joined #openstack-nova | 11:46 | |
| *** sapd1 has joined #openstack-nova | 11:46 | |
| *** macz_ has quit IRC | 11:51 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/rocky: Functional test for UnexpectedDeletingTaskStateError https://review.opendev.org/715403 | 11:52 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/rocky: Unplug VIFs as part of cleanup of networks https://review.opendev.org/715404 | 11:52 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/queens: Functional test for UnexpectedDeletingTaskStateError https://review.opendev.org/715405 | 11:53 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/queens: Unplug VIFs as part of cleanup of networks https://review.opendev.org/715406 | 11:53 |
| *** sapd1_x has joined #openstack-nova | 11:55 | |
| *** takamatsu has quit IRC | 11:56 | |
| openstackgerrit | Merged openstack/nova master: Delete ARQs for an instance when the instance is deleted. https://review.opendev.org/673735 | 12:10 |
| *** dtantsur is now known as dtantsur|brb | 12:15 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Integrate mypy https://review.opendev.org/676208 | 12:15 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Update and correct typing information https://review.opendev.org/714694 | 12:15 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Add typing information https://review.opendev.org/714695 | 12:15 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Split instance NUMA object tests https://review.opendev.org/714696 | 12:15 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Replace 'cpu_pinning_requested' helper https://review.opendev.org/714697 | 12:15 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Don't consider overhead CPUs for unpinned instances https://review.opendev.org/714698 | 12:15 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Remove handling of pre-Train compute nodes https://review.opendev.org/714699 | 12:15 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Add validation for 'cpu_realtime_mask' https://review.opendev.org/468203 | 12:15 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Tweak the 'cpu_realtime_mask' handling slightly https://review.opendev.org/461456 | 12:15 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Rework 'get_realtime_constraint' https://review.opendev.org/714700 | 12:15 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Invert order of NUMA topology generation https://review.opendev.org/714701 | 12:15 |
| *** elod_ has joined #openstack-nova | 12:20 | |
| nightmare_unreal | what does greynade-py3 checks/do ? | 12:39 |
| nightmare_unreal | i am getting failure for that on review.openstack | 12:39 |
| *** zhanglong has joined #openstack-nova | 12:41 | |
| *** elod has quit IRC | 12:53 | |
| *** elod_ is now known as elod | 12:53 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Remove '_numa_fit_instance_cell_with_pinning' https://review.opendev.org/714703 | 12:58 |
| *** lbragstad has joined #openstack-nova | 12:59 | |
| *** spatel has joined #openstack-nova | 13:00 | |
| *** openstackstatus has quit IRC | 13:01 | |
| *** openstack has joined #openstack-nova | 13:03 | |
| *** ChanServ sets mode: +o openstack | 13:03 | |
| *** ratailor has quit IRC | 13:07 | |
| *** rpittau|bbl is now known as rpittau | 13:10 | |
| *** zzzeek has quit IRC | 13:18 | |
| *** nweinber has joined #openstack-nova | 13:19 | |
| *** zzzeek has joined #openstack-nova | 13:20 | |
| *** macz_ has joined #openstack-nova | 13:21 | |
| *** macz_ has quit IRC | 13:21 | |
| *** ociuhandu has quit IRC | 13:21 | |
| *** macz_ has joined #openstack-nova | 13:21 | |
| *** rcernin has quit IRC | 13:23 | |
| *** derekh has quit IRC | 13:24 | |
| *** tkajinam has quit IRC | 13:25 | |
| *** mriedem has joined #openstack-nova | 13:27 | |
| *** haleyb has joined #openstack-nova | 13:27 | |
| openstackgerrit | jayaditya gupta proposed openstack/nova master: Support for --overwrite flag for nova-manage placement heal_allocations command https://review.opendev.org/715395 | 13:27 |
| *** ociuhandu has joined #openstack-nova | 13:29 | |
| *** ociuhandu has quit IRC | 13:38 | |
| *** dtantsur|brb is now known as dtantsur | 13:40 | |
| dansmith | gibi: ack, I'll start on that | 13:44 |
| gibi | dansmith: thanks | 13:44 |
| gibi | and good morning | 13:45 |
| dansmith | gibi: 'mornin' | 13:45 |
| dansmith | gibi: am I seeing this right that these are not in a related stack? | 13:45 |
| dansmith | er, wait, maybe there are just some that are outside the stack | 13:45 |
| gibi | there is at least a separate patch that renames the existing update policy | 13:45 |
| dansmith | okay I started on that and yeah, okay | 13:46 |
| gibi | this is the policy rename https://review.opendev.org/#/c/715356/ | 13:46 |
| *** sapd1_x has quit IRC | 13:46 | |
| gibi | the rest is in a stack starting at https://review.opendev.org/#/c/693828/19 | 13:46 |
| dansmith | yep, I got it | 13:46 |
| dansmith | this needs a microversion rebase anyway | 13:47 |
| dansmith | gibi: it might be good to start lining up any other patches that have a microversion so we're not spending lots of time re-versioning things | 13:47 |
| gibi | true, and good point | 13:47 |
| owalsh | sean-k-mooney: hey, re https://bugs.launchpad.net/nova/+bug/1677913 | 13:48 |
| openstack | Launchpad bug 1677913 in OpenStack Compute (nova) "percent must be escaped in live_migration_uri" [Low,In progress] - Assigned to Stephen Finucane (stephenfinucane) | 13:48 |
| gibi | at least I haven't approved any new microversion bumping patch today | 13:48 |
| owalsh | sean-k-mooney: problem is that nova is doing string interpolation e.g uri % dest | 13:49 |
| owalsh | which is fine for qemu+ssh://%s:123/ | 13:49 |
| sean-k-mooney | owalsh: yes but you should not be url encoding extra params unless they are unsupportd | 13:49 |
| sean-k-mooney | e.g. once that libvirt does not know about | 13:49 |
| owalsh | sean-k-mooney: and url endeded extra params contain % | 13:49 |
| sean-k-mooney | if they are part of the standard set you dont need to encode them | 13:49 |
| sean-k-mooney | owalsh: then ooo should have escaped them properly | 13:50 |
| owalsh | sean-k-mooney: nope, we had to double escape them | 13:50 |
| owalsh | i.e %% so the nova sting interpolation replaces it with a single % | 13:51 |
| sean-k-mooney | owalsh: so you had to put 4 % | 13:51 |
| sean-k-mooney | owalsh: yes im saying that is the correct thing to do | 13:51 |
| sean-k-mooney | owalsh: nova reuired you to provide a vail python sting that will be interperalted | 13:51 |
| sean-k-mooney | so ooo should have escaped the % | 13:52 |
| sean-k-mooney | owalsh: looking at the standard extra paramater i dont think any of them shoudl reuire a % | 13:53 |
| sean-k-mooney | https://libvirt.org/uri.html#Remote_URI_parameters | 13:53 |
| sean-k-mooney | which one was ooo trying to use | 13:53 |
| dansmith | gibi: gmann it looks like the put expects the client to remove the 'device' from the put? meaning if it does a get on the thing, then it has to remove 'device' before it can put that back... | 13:53 |
| dansmith | gibi: gmann that makes no sense to me, but hopefully it's okay to change that in the new microversion to just be ignored so you can get/put the thing REST-style? | 13:54 |
| owalsh | sean-k-mooney: erm, it's been years.. probably ssh key path | 13:54 |
| sean-k-mooney | owalsh: why would that contain a % | 13:54 |
| sean-k-mooney | while technically legal in a file name it would not be common or expect practic to see a % in a path | 13:55 |
| owalsh | sean-k-mooney: libvirt docs say "Note that parameter values must be URI-escaped" | 13:55 |
| sean-k-mooney | no read the full sentence | 13:55 |
| owalsh | pretty sure it means all parameter values | 13:56 |
| sean-k-mooney | Any others are passed unmodified through to the back end | 13:56 |
| *** derekh has joined #openstack-nova | 13:56 | |
| sean-k-mooney | it only applies to the parmater not supproted in the table below as far as i know | 13:56 |
| owalsh | that would be weird TBH, not a valid uri | 13:57 |
| gibi | dansmith: I think that is an artifact of the implementation, the device gets automatically calculated | 13:57 |
| sean-k-mooney | a uri is not a url | 13:57 |
| gmann | dansmith: volume attachment PUT right ? | 13:57 |
| nightmare_unreal | mriedem: ping | 13:57 |
| sean-k-mooney | they do not have the same constratits on formating | 13:57 |
| *** amoralej is now known as amoralej|lunch | 13:58 | |
| dansmith | gibi: I know in create, but on update you should be able to GET, modify, PUT, without having to delete things.. things that aren't update-able that are unchanged are just retained | 13:58 |
| dansmith | gmann: yes | 13:58 |
| gmann | dansmith: yeah we restrict it on schema side- https://github.com/openstack/nova/blob/e78343dcff7feb0975ffd10ff41ab4368611c285/nova/api/openstack/compute/schemas/volumes.py#L95 | 13:58 |
| owalsh | sean-k-mooney: wasn't just ooo that hit this FWIW, I'll try to dig up the info from back then | 13:59 |
| dansmith | gmann: exactly.. I'm saying we should add that back in in the new microversion | 13:59 |
| gibi | dansmith: you are right about the generic PUT behavior. However I'm not sure if there is a swap volume nova will keep the device name the same | 13:59 |
| dansmith | gibi: I know, you can't *change* it, you should just be allowed to pass it | 13:59 |
| gibi | it might be that you pass the same value in via PUT (swap case) but as a result the value of the device field changes by nova | 14:00 |
| dansmith | sure, fine | 14:00 |
| dansmith | but right now, it's not allowed by schema | 14:00 |
| dansmith | so in the new microversion I want it to be allowed, just not change-able, so you can PUT what you GET | 14:01 |
| mriedem | allowing a field that you can't change in a PUT request is weird | 14:01 |
| dansmith | eh? | 14:01 |
| dansmith | that's the whole point of PUT, that you're PUTting the whole thing back, otherwise it'd be a PATCH | 14:02 |
| gibi | so if cinder will not provide the device then nova will reject? | 14:02 |
| dansmith | gibi: no,we can keep it optional | 14:02 |
| gibi | dansmith: OK, in that case I'm fine | 14:02 |
| gibi | with the change | 14:02 |
| dansmith | cool | 14:02 |
| sean-k-mooney | owalsh: dont waste time looking it up. the patch is going to proceed anyway. its way to late to change the direction at this point since we alerady added other config options | 14:02 |
| gmann | other PUT are same like PUT server etc | 14:03 |
| dansmith | mriedem: to be clear, I can enforce that you gave me the same value I gave you (i.e. you didn't change it), the client just shouldn't have to trim out the result of the GET to be able to PUT it back | 14:03 |
| owalsh | sean-k-mooney: ack. I'm pretty sure I ran all of that past danpb at the time, and he probably wrote those docs | 14:03 |
| dansmith | gmann: exactly | 14:03 |
| sean-k-mooney | owalsh: i just dont think this was a bug. it was a feature request and the original bug was in ooo | 14:03 |
| owalsh | sean-k-mooney: nova doc bug at the very least | 14:03 |
| sean-k-mooney | owalsh: yes that too | 14:04 |
| gmann | dansmith: and 400 if non-updatable things are passed with change in value ? | 14:04 |
| dansmith | gmann: yep | 14:04 |
| gmann | ok then it will not create confusion to client that what he/she requested for change are done or not. that I was thinking. so accepting all and 400 for non-updatable if requested lgtm | 14:05 |
| dansmith | cool | 14:06 |
| gmann | and you mean for all PUT to make consistent not just attachment one ? | 14:06 |
| dansmith | I don't understand the question | 14:07 |
| gmann | i mean other APIS like PUT servers etc, other PUT i have to check what they accept. | 14:07 |
| dansmith | I think all our PUTs should behave that way, I'm sure not all of them do, but when we have a chance (like this) to make it behave this way, then we should | 14:07 |
| gmann | yeah, then it make consistent. Aslo we replicate the GET response to PUT at least for server we do so doing same in request make sense also. | 14:08 |
| dansmith | yes | 14:09 |
| openstackgerrit | jayaditya gupta proposed openstack/nova master: Support for --overwrite flag for nova-manage placement heal_allocations command https://review.opendev.org/715395 | 14:09 |
| mriedem | nightmare_unreal: pong | 14:10 |
| *** zhanglong has quit IRC | 14:11 | |
| nightmare_unreal | mriedem: can you leave comment for my patch : https://review.opendev.org/#/c/715395/ | 14:11 |
| nightmare_unreal | mriedem: I think i have made some mistake with test case | 14:11 |
| nightmare_unreal | if you can review it :) that will be helpful | 14:11 |
| nightmare_unreal | also what does greynade-py3 checks/do | 14:12 |
| mriedem | grenade job is for upgrade testing, | 14:13 |
| mriedem | so for ussuri changes it installs train devstack, runs smoke tests, saves off some resources (servers/volumes), then upgrades to master devstack, runs smoke tests and makes sure those saved resources are still available | 14:14 |
| mriedem | https://docs.openstack.org/grenade/latest/readme.html | 14:14 |
| gmann | dansmith: gibi added in API cleanup etherpad. L81: https://etherpad.openstack.org/p/nova-api-cleanup | 14:15 |
| gibi | gmann: ack, thanks | 14:16 |
| openstackgerrit | sean mooney proposed openstack/nova master: [WIP] cyborg evacuate support https://review.opendev.org/715326 | 14:22 |
| mriedem | nightmare_unreal: comments inline | 14:25 |
| nightmare_unreal | thank you :D | 14:25 |
| mriedem | nightmare_unreal: remember to run `tox -e flake8` before pushing up your changes | 14:26 |
| mriedem | err, | 14:26 |
| mriedem | tox -e fast8 | 14:26 |
| nightmare_unreal | I'll remember that . So far I was running only tox -e pep8 , tox-e py36 | 14:26 |
| stephenfin | or do 'pre-commit install --allow-missing-config' | 14:27 |
| stephenfin | then it'll run automatically whenever you make a commit | 14:27 |
| nightmare_unreal | aah that's nice | 14:27 |
| nightmare_unreal | I will do it | 14:28 |
| *** vishalmanchanda has quit IRC | 14:32 | |
| *** ociuhandu has joined #openstack-nova | 14:32 | |
| mriedem | you don't need py36 if you're doing functional tests | 14:34 |
| mriedem | tox -e functional | 14:35 |
| mriedem | py36 == unit tests | 14:35 |
| mriedem | for nova running all of those tests locally will probably take awhile | 14:35 |
| mriedem | unless you're sean-k-mooney | 14:35 |
| sean-k-mooney | hehe actully that server is kind of unhappy at the momemtn so im back to using a laptop | 14:36 |
| sean-k-mooney | i think the motherboad has issues or maybe the memory. its raising machine check excptions which are not fun | 14:37 |
| *** bnemec is now known as beekneemech | 14:37 | |
| *** ociuhandu has quit IRC | 14:37 | |
| sean-k-mooney | but some day ill have 48 thread to make it fast again. some day | 14:38 |
| *** sapd1_x has joined #openstack-nova | 14:42 | |
| *** amoralej|lunch is now known as amoralej | 14:43 | |
| *** mlavalle has quit IRC | 14:43 | |
| *** dklyle has joined #openstack-nova | 14:57 | |
| openstackgerrit | Kevin Zhao proposed openstack/nova master: fix scsi disk unit number of the attaching volume when cdrom bus is scsi https://review.opendev.org/712607 | 14:58 |
| *** mlavalle has joined #openstack-nova | 15:02 | |
| *** ociuhandu has joined #openstack-nova | 15:04 | |
| *** mkrai has quit IRC | 15:10 | |
| *** mkrai_ has joined #openstack-nova | 15:10 | |
| melwitt | mriedem: I proposed this yesterday for the troubleshooting doc about the affinity stuff https://review.opendev.org/715092 | 15:16 |
| *** udesale_ has quit IRC | 15:20 | |
| *** _mlavalle_1 has joined #openstack-nova | 15:22 | |
| *** _mlavalle_1 has quit IRC | 15:22 | |
| *** TxGirlGeek has joined #openstack-nova | 15:24 | |
| *** mlavalle has quit IRC | 15:25 | |
| openstackgerrit | Kevin Zhao proposed openstack/nova master: fix scsi disk unit number of the attaching volume when cdrom bus is scsi https://review.opendev.org/712607 | 15:27 |
| openstackgerrit | Merged openstack/nova master: Enable hard/soft reboot with accelerators. https://review.opendev.org/697940 | 15:32 |
| mriedem | melwitt: soft -1 to put that into a sub-page | 15:35 |
| mriedem | also added dansmith | 15:35 |
| melwitt | mriedem: ack, thanks | 15:36 |
| mriedem | just thought of something else, i'll leave another comment | 15:37 |
| openstackgerrit | Merged openstack/nova master: Enable start/stop of instances with accelerators. https://review.opendev.org/699553 | 15:38 |
| *** gyee has joined #openstack-nova | 15:40 | |
| melwitt | k | 15:41 |
| *** mkrai_ has quit IRC | 15:51 | |
| *** sean-k-mooney has quit IRC | 16:02 | |
| *** sean-k-mooney has joined #openstack-nova | 16:03 | |
| *** melwitt is now known as jgwentworth | 16:12 | |
| * jgwentworth 877 cash now | 16:12 | |
| *** slaweq has quit IRC | 16:18 | |
| *** ociuhandu_ has joined #openstack-nova | 16:20 | |
| *** ociuhandu has quit IRC | 16:23 | |
| *** ociuhandu_ has quit IRC | 16:23 | |
| *** ociuhandu has joined #openstack-nova | 16:23 | |
| *** links has quit IRC | 16:26 | |
| *** hemna is now known as pewp | 16:27 | |
| *** pewp is now known as _pewp_ | 16:30 | |
| *** _pewp_ is now known as hemna | 16:34 | |
| *** hemna is now known as _pewp_ | 16:35 | |
| *** _pewp_ is now known as hemna | 16:37 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing ips policies https://review.opendev.org/715477 | 16:40 |
| *** mriedem is now known as hansmoleman | 16:41 | |
| *** dpawlik has quit IRC | 16:41 | |
| *** maciejjozefczyk has quit IRC | 16:43 | |
| *** bbowen_ has quit IRC | 16:44 | |
| *** bbowen has joined #openstack-nova | 16:46 | |
| *** smcginnis has quit IRC | 16:50 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Allow PUT volume attachments API to modify delete_on_termination https://review.opendev.org/693828 | 16:52 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Separate update and swap volume policies https://review.opendev.org/711194 | 16:52 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add functional tests for PATCH volume attachments API https://review.opendev.org/710965 | 16:52 |
| dansmith | gibi: gmann: ^ | 16:52 |
| gmann | dansmith: thanks i will check. cmt msg title of func tests patch still has 'PATCH'. ^^ | 16:54 |
| dansmith | gmann: I didn't update that commit message because I figured we're squashing that after we review the diff, but will -W with that to make it obvious | 16:55 |
| gmann | dansmith: ohk, did not read your comment. | 16:56 |
| *** bbowen_ has joined #openstack-nova | 16:56 | |
| *** bbowen has quit IRC | 16:56 | |
| dansmith | gmann: I also didn't update the api-ref just yet, so just FYI | 16:56 |
| gmann | got it, | 16:59 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Provide the parent pGPU when creating a new vGPU https://review.opendev.org/715489 | 17:11 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: WIP: Support different vGPU types per pGPU https://review.opendev.org/715490 | 17:11 |
| *** jangutter has quit IRC | 17:20 | |
| *** jangutter has joined #openstack-nova | 17:21 | |
| *** jangutter has quit IRC | 17:26 | |
| *** tesseract has quit IRC | 17:31 | |
| gmann | dansmith: commented, +1 on adding tag in updatable items | 17:33 |
| *** martinkennelly has quit IRC | 17:35 | |
| *** evrardjp has quit IRC | 17:36 | |
| *** evrardjp has joined #openstack-nova | 17:36 | |
| gmann | dansmith: policy patch lgtm with 1 comment on passing project_id as target for admin policy. | 17:37 |
| *** dpawlik has joined #openstack-nova | 17:41 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix os-ips policy to be admin_or_owner https://review.opendev.org/715496 | 17:45 |
| hansmoleman | so did the PATCH thing get dropped because https://review.opendev.org/#/c/693828/ is still talking about PATCH | 17:46 |
| dansmith | hansmoleman: I just commented, but as we discussed here and on the last patch, I haven't updated all the meta and docs yet, nor squashed the last patch into the first one as planned because I'm trying to allow for review of just the PATCH->PUT code changes before I go moving everything around | 17:50 |
| *** nightmare_unreal has quit IRC | 17:51 | |
| hansmoleman | ok so it's diverged quite a bit from the spec, i suppose in an effort to still try to get something in for ussuri? | 17:52 |
| *** dpawlik has quit IRC | 17:52 | |
| hansmoleman | because i was originally advocating doing this with PUT in the spec but not with a swap volume operation, but then that all changed at some point to PATCH | 17:53 |
| hansmoleman | and now the PATCH thing is getting dropped | 17:53 |
| dansmith | hansmoleman: we discussed that in IRC yesterday | 17:53 |
| dansmith | gibi, gmann, myself and brin | 17:53 |
| *** ociuhandu has quit IRC | 17:57 | |
| *** ociuhandu has joined #openstack-nova | 17:57 | |
| sean-k-mooney | dansmith: just an fyi im finishing up for the day shortly. ill continue working on https://review.opendev.org/#/c/715326/ on monday but i think getting rebuild and evacuation working with cyborg should not be too hard | 17:58 |
| dansmith | sean-k-mooney: sounds good, enjoy the weekend | 17:58 |
| sean-k-mooney | you too o/ | 17:58 |
| *** derekh has quit IRC | 18:00 | |
| *** ociuhandu has quit IRC | 18:03 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/queens: Functional test for UnexpectedDeletingTaskStateError https://review.opendev.org/715405 | 18:04 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/queens: Unplug VIFs as part of cleanup of networks https://review.opendev.org/715406 | 18:04 |
| stephenfin | artom: if you've time to kill before the end of the day, the series ending here continues work on cleaning up a lot of crap from hardware.py https://review.opendev.org/#/c/714703/ | 18:07 |
| artom | stephenfin, tbh probably not today, because kids | 18:07 |
| stephenfin | fair | 18:07 |
| * stephenfin -> 🏠🍺 | 18:07 | |
| *** smcginnis has joined #openstack-nova | 18:08 | |
| *** sapd1_x has quit IRC | 18:12 | |
| *** amoralej is now known as amoralej|off | 18:12 | |
| artom | stephenfin, but I'll keep that on my review list | 18:15 |
| artom | stephenfin, and if you're still around, gentle reminder that https://review.opendev.org/#/c/714228/ and the patches on top are still a thing | 18:16 |
| artom | And if you're not, happy 🍺'ing | 18:16 |
| *** xek__ has joined #openstack-nova | 18:28 | |
| *** xek_ has quit IRC | 18:31 | |
| *** lpetrut has quit IRC | 18:33 | |
| *** spatel has quit IRC | 18:44 | |
| *** rpittau is now known as rpittau|afk | 18:57 | |
| *** gmann is now known as gmann_lunch | 18:59 | |
| *** ociuhandu has joined #openstack-nova | 19:01 | |
| *** ociuhandu has quit IRC | 19:06 | |
| *** dtantsur is now known as dtantsur|afk | 19:13 | |
| *** ralonsoh has quit IRC | 19:16 | |
| *** gmann_lunch is now known as gmann | 19:29 | |
| *** elod has quit IRC | 19:46 | |
| *** iurygregory has quit IRC | 19:46 | |
| *** elod has joined #openstack-nova | 19:46 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing ips policies https://review.opendev.org/715477 | 19:52 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-ips https://review.opendev.org/715529 | 20:01 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing ips policies https://review.opendev.org/715477 | 20:08 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-ips https://review.opendev.org/715529 | 20:08 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-ips policies https://review.opendev.org/715545 | 20:32 |
| *** nweinber has quit IRC | 21:07 | |
| *** jangutter has joined #openstack-nova | 21:23 | |
| *** macz_ has quit IRC | 21:25 | |
| *** jangutter has quit IRC | 21:27 | |
| *** hansmoleman has left #openstack-nova | 21:28 | |
| *** ociuhandu has joined #openstack-nova | 22:03 | |
| *** TxGirlGeek has quit IRC | 22:03 | |
| *** ociuhandu has quit IRC | 22:07 | |
| *** macz_ has joined #openstack-nova | 22:09 | |
| *** bbowen_ has quit IRC | 22:14 | |
| *** macz_ has quit IRC | 22:18 | |
| *** TxGirlGeek has joined #openstack-nova | 22:31 | |
| *** TxGirlGeek has quit IRC | 22:56 | |
| openstackgerrit | Merged openstack/nova stable/stein: libvirt: Provide the backing file format when creating qcow2 disks https://review.opendev.org/710790 | 23:16 |
| *** bbowen has joined #openstack-nova | 23:31 | |
| * mordred read that as "Provide the hacking file format" and I was like "what the heck does hacking have to do with qcow2 disks" | 23:47 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!