| *** READ10 has joined #openstack-nova | 00:33 | |
| *** READ10 has quit IRC | 00:44 | |
| openstackgerrit | Arthur Dayne proposed openstack/nova master: libvirt:driver:Disallow AIO=native when 'O_DIRECT' is not available https://review.opendev.org/682772 | 00:49 |
|---|---|---|
| *** ttsiouts has joined #openstack-nova | 00:52 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the actual target in server group policy https://review.opendev.org/717176 | 00:57 |
| *** gyee has quit IRC | 01:07 | |
| *** zhanglong has joined #openstack-nova | 01:11 | |
| *** yedongcan has joined #openstack-nova | 01:12 | |
| *** Liang__ has joined #openstack-nova | 01:13 | |
| *** ttsiouts has quit IRC | 01:25 | |
| brinzhang_ | gmann:https://review.opendev.org/#/c/711194 this patch, I understand damsmith's approach is ok for you, right? | 01:28 |
| brinzhang_ | gmann: https://review.opendev.org/#/c/711194/14/nova/tests/unit/policies/test_volumes.py@224 this case I should move to class VolumeAttachScopeTypePolicyTest ? | 01:29 |
| gmann | brinzhang_: yes, with mentioning the same in policy description doc | 01:30 |
| gmann | brinzhang_: VolumeAttachScopeTypePolicyTest should run all tests in is its parent class | 01:30 |
| gmann | you can update in same class which should run in scope test class also | 01:31 |
| brinzhang_ | gmann: you mean, keep that case in parent class and copy it to the class VolumeAttachScopeTypePolicyTest? | 01:32 |
| gmann | brinzhang_: no, i mean only update the tests with comments not the location of tests | 01:33 |
| brinzhang_ | gmann: add "new 'update' policy about 'for swap + update' request (which is possible only >2.85) only <swap policy> is checked. We expect <swap policy> to be always superset of this policy permission." to comment this test? | 01:36 |
| gmann | brinzhang_: that is to update in 'update' policy doc | 01:38 |
| gmann | policy descritpnio | 01:38 |
| brinzhang_ | gmann: two things, 1) add above description to https://review.opendev.org/#/c/711194/14/nova/policies/volumes_attachments.py@71 and 2):I should add comments on the test case, such as: """<swap policy> to be always superset of update API policy permission""" | 01:45 |
| gmann | brinzhang_: only doc is fine. tests case is ok with verification only | 01:51 |
| *** artom has quit IRC | 02:03 | |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: Introduce 'pcpuset' field for InstanceNUMACell https://review.opendev.org/714658 | 02:03 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: Introduce the 'CPUAllocationPolicy.MIXED' enum https://review.opendev.org/716267 | 02:03 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: hardware: Add support for 'hw:cpu_dedicated_mask' extra spec https://review.opendev.org/714706 | 02:03 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: computer: validate cpu pinning configuration for mixed instance https://review.opendev.org/716268 | 02:03 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: Calculate the pinned and unpinned CPU usage for mixed instance https://review.opendev.org/716269 | 02:03 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: mark mixed policy as ready, bump compute service version https://review.opendev.org/716270 | 02:03 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: Setup 'mixed' instance through 'PCPU' and 'VCPU' resource https://review.opendev.org/713355 | 02:03 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: metadata: export the vCPU IDs that are pinning on the host CPUs https://review.opendev.org/688936 | 02:03 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: libvirt/hardware: refactor numa_get_constraints https://review.opendev.org/718294 | 02:03 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Separate update and swap volume policies https://review.opendev.org/711194 | 02:05 |
| brinzhang_ | gmann: done, pls review again, thanks | 02:05 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Separate update and swap volume policies https://review.opendev.org/711194 | 02:06 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: mark mixed policy as ready, bump compute service version https://review.opendev.org/716271 | 02:18 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: libvirt/hardware: refactor numa_get_constraints https://review.opendev.org/718294 | 02:18 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: Setup 'mixed' instance through 'PCPU' and 'VCPU' resource https://review.opendev.org/713355 | 02:18 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: metadata: export the vCPU IDs that are pinning on the host CPUs https://review.opendev.org/688936 | 02:18 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in server group policies https://review.opendev.org/717175 | 02:21 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: computer: validate cpu pinning configuration for mixed instance https://review.opendev.org/716268 | 02:25 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: Calculate the pinned and unpinned CPU usage for mixed instance https://review.opendev.org/716269 | 02:25 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: mark mixed policy as ready, bump compute service version https://review.opendev.org/716271 | 02:25 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: libvirt/hardware: refactor numa_get_constraints https://review.opendev.org/718294 | 02:25 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: Setup 'mixed' instance through 'PCPU' and 'VCPU' resource https://review.opendev.org/713355 | 02:25 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: metadata: export the vCPU IDs that are pinning on the host CPUs https://review.opendev.org/688936 | 02:25 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Separate update and swap volume policies https://review.opendev.org/711194 | 02:25 |
| *** mkrai has joined #openstack-nova | 02:35 | |
| *** zhanglong has quit IRC | 02:35 | |
| *** zhanglong has joined #openstack-nova | 02:40 | |
| *** brinzhang_ has quit IRC | 02:59 | |
| *** brinzhang_ has joined #openstack-nova | 02:59 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Reset the cell cache for database access in Service https://review.opendev.org/717662 | 03:20 |
| *** ttsiouts has joined #openstack-nova | 03:22 | |
| *** psachin has joined #openstack-nova | 03:28 | |
| openstackgerrit | Merged openstack/python-novaclient master: Microversion 2.83 - Add more filters for the nova list command https://review.opendev.org/713089 | 03:34 |
| *** zhanglong has quit IRC | 03:38 | |
| *** zhanglong has joined #openstack-nova | 03:43 | |
| *** yaawang__ has quit IRC | 03:53 | |
| *** vishalmanchanda has joined #openstack-nova | 03:53 | |
| *** ttsiouts has quit IRC | 03:56 | |
| *** mkrai has quit IRC | 04:01 | |
| *** mkrai has joined #openstack-nova | 04:02 | |
| openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.84 - action event fault details https://review.opendev.org/714561 | 04:10 |
| openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.85: Change volume-update CLI https://review.opendev.org/712651 | 04:10 |
| openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.86 - Extra spec validation https://review.opendev.org/718057 | 04:11 |
| openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.87 - Stable device boot from volume rescue https://review.opendev.org/714956 | 04:11 |
| brinzhang_ | alex_xu, gmann, gibi: I rebased the novalient merge conflict patch https://review.opendev.org/#/c/714561/9, need +A again, thanks | 04:17 |
| *** evrardjp has quit IRC | 04:36 | |
| *** evrardjp has joined #openstack-nova | 04:37 | |
| *** ociuhandu has joined #openstack-nova | 04:47 | |
| *** ociuhandu has quit IRC | 04:51 | |
| openstackgerrit | Qiu Fossen proposed openstack/nova master: The instance is volume backed and power state is PAUSED，shelve the instance failed https://review.opendev.org/711609 | 04:52 |
| *** brinzhang has joined #openstack-nova | 05:08 | |
| *** brinzhang_ has quit IRC | 05:11 | |
| *** ratailor has joined #openstack-nova | 05:17 | |
| *** udesale has joined #openstack-nova | 05:22 | |
| *** udesale has quit IRC | 05:23 | |
| *** udesale has joined #openstack-nova | 05:23 | |
| *** igordc has quit IRC | 05:32 | |
| *** ttsiouts has joined #openstack-nova | 05:53 | |
| *** yaawang has joined #openstack-nova | 05:58 | |
| *** links has joined #openstack-nova | 06:20 | |
| huaqiang | a | 06:22 |
| *** iurygregory has quit IRC | 06:25 | |
| *** ttsiouts has quit IRC | 06:27 | |
| *** iurygregory has joined #openstack-nova | 06:27 | |
| *** nightmare_unreal has joined #openstack-nova | 06:39 | |
| *** ttsiouts has joined #openstack-nova | 06:45 | |
| openstackgerrit | Merged openstack/python-novaclient master: Microversion 2.84 - action event fault details https://review.opendev.org/714561 | 06:45 |
| *** dklyle has quit IRC | 06:48 | |
| *** tesseract has joined #openstack-nova | 06:52 | |
| bauzas | good morning Nova | 06:55 |
| *** slaweq_ has joined #openstack-nova | 06:57 | |
| *** maciejjozefczyk has joined #openstack-nova | 07:00 | |
| *** yaawang has quit IRC | 07:04 | |
| *** yaawang has joined #openstack-nova | 07:05 | |
| *** lpetrut has joined #openstack-nova | 07:09 | |
| *** mkrai has quit IRC | 07:14 | |
| *** belmoreira has joined #openstack-nova | 07:16 | |
| *** rpittau|afk is now known as rpittau | 07:17 | |
| alex_xu | gibi: would you like to take a look those patches https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/use-pcpu-and-vcpu-in-one-instance, the refactor patches from stephenfin looks good now | 07:17 |
| *** ralonsoh has joined #openstack-nova | 07:33 | |
| *** mkrai has joined #openstack-nova | 07:34 | |
| gibi | stephenfin: did you see that https://review.opendev.org/#/c/713089/ merged last night? | 07:37 |
| gibi | stephenfin: do you think we should do something about it? | 07:38 |
| *** ccamacho has joined #openstack-nova | 07:39 | |
| brinzhang | gibi: although we merged that patch, but the config_drive issue also exist, what do you want to plan to do? | 07:40 |
| *** dtantsur|afk is now known as dtantsur | 07:41 | |
| gibi | brinzhang: there is a Nova API bug regarding config_drive filtering, that I don't want to solve this week due to FF and due to the fact that it would need a bigger API change to make it consistent across the API. Regarding the client side, the client now works as a pass through which is not wrong but stephenfin argued for a bit nicer CLI interface | 07:42 |
| gibi | alex_xu: I will try but no promisses | 07:43 |
| alex_xu | gibi: thanks | 07:44 |
| *** ociuhandu has joined #openstack-nova | 07:44 | |
| brinzhang | gibi: ok, I left some comment in bug 1871409, and I looked your chat records, yes, it's a bigger change | 07:45 |
| openstack | bug 1871409 in OpenStack Compute (nova) "cannot filter the list servers to show only those that does not have config drive" [Medium,In progress] https://launchpad.net/bugs/1871409 - Assigned to Balazs Gibizer (balazs-gibizer) | 07:45 |
| brinzhang | gibi: we are decide to completed this in gmann's next cleanup api? | 07:45 |
| gibi | brinzhang: no, we only added it to the list | 07:45 |
| brinzhang | gibi: ok, thanks, got it, if need my help that I can. | 07:47 |
| gibi | brinzhang: thanks. I would not rush on that as config_driver filtering is broken at least in the last 3 years and nobody filed a bug | 07:47 |
| gibi | so we will take the time to figure out how we want to fix it | 07:48 |
| *** brinzhang_ has joined #openstack-nova | 07:48 | |
| brinzhang_ | gibi: Yes, we rarely use config_drive to filter servers too. | 07:49 |
| *** brinzhang has quit IRC | 07:51 | |
| brinzhang_ | gibi: the bp/destroy-instance-with-datavolume separate patch updated and the novaclient also update, if you have time today, pls review again, I am sorry to add your work, thanks. | 07:54 |
| *** mkrai has quit IRC | 07:54 | |
| *** mkrai has joined #openstack-nova | 07:57 | |
| *** zhanglong has quit IRC | 07:59 | |
| gibi | brinzhang_: I have comment about the unit test https://review.opendev.org/#/c/711194 | 08:00 |
| *** tosky has joined #openstack-nova | 08:00 | |
| gibi | now I will look at the client patch | 08:01 |
| brinzhang_ | gibi: thanks, will update | 08:01 |
| *** ociuhandu has quit IRC | 08:02 | |
| *** ociuhandu has joined #openstack-nova | 08:03 | |
| brinzhang_ | gibi: the test case that I missed the api_version=2.85, and I will add d-o-t to the request body, and set 2.85 in request | 08:05 |
| *** dpawlik has joined #openstack-nova | 08:08 | |
| *** ociuhandu has quit IRC | 08:08 | |
| bauzas | gibi: morning, FWIW I worked last night on the functional test, even if it's still a WIP, we verify whether traits work for two pGPUs https://review.opendev.org/#/c/717975/8/nova/tests/functional/libvirt/test_vgpu.py@214 | 08:09 |
| bauzas | and Zuul says +1 :p | 08:09 |
| *** brinzhang has joined #openstack-nova | 08:10 | |
| bauzas | (WIP because I need to update some tests for the fakelibvirt) | 08:10 |
| *** zhanglong has joined #openstack-nova | 08:11 | |
| gibi | bauzas: morning. ack | 08:12 |
| *** brinzhang_ has quit IRC | 08:13 | |
| *** brinzhang_ has joined #openstack-nova | 08:14 | |
| *** mkrai has quit IRC | 08:15 | |
| *** brinzhang has quit IRC | 08:15 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Separate update and swap volume policies https://review.opendev.org/711194 | 08:16 |
| brinzhang_ | gibi: the test update done, thanks | 08:16 |
| gibi | brinzhang_: could you quickly fix this nit? then I will +2 https://review.opendev.org/#/c/711194/18/nova/tests/unit/policies/test_volumes.py@199 | 08:19 |
| bauzas | stephenfin: fwiw, left comments on https://review.opendev.org/#/c/708436/ but I'm mostly +2 | 08:19 |
| gibi | brinzhang_: two nits actually | 08:20 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Separate update and swap volume policies https://review.opendev.org/711194 | 08:20 |
| *** mkrai has joined #openstack-nova | 08:20 | |
| gibi | brinzhang_: thanks | 08:21 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Separate update and swap volume policies https://review.opendev.org/711194 | 08:22 |
| brinzhang_ | gibi: yes, that caused for me, I am sorry to that unexpected errors. | 08:22 |
| bauzas | stephenfin: also I wonder whether we should document the fact that some keys having namespaces would be strictly validated | 08:23 |
| bauzas | stephenfin: inhttps://review.opendev.org/#/c/710037/ | 08:23 |
| brinzhang_ | gibi: maybe you should +2 again, I missed your +2, my network is not very good | 08:24 |
| gibi | brinzhang_: done :) | 08:24 |
| brinzhang_ | gibi: thanks | 08:24 |
| *** rcernin has quit IRC | 08:27 | |
| *** martinkennelly has joined #openstack-nova | 08:28 | |
| bauzas | stephenfin: also, please help me, I don't get how you autodoc https://6319631a8afc7845c7f6-af2016a5632320f910deb9dcbf495ac6.ssl.cf2.rackcdn.com/710037/13/check/openstack-tox-docs/eb7469b/docs/configuration/extra-specs.html | 08:29 |
| brinzhang_ | gibi: about the base patch of bp/destroy-instance-with-datavolume, I have some nits and lack some test case pre v2.85 need to follow up, and I will do that tomorrow, that I am not forget ^^ | 08:29 |
| gibi | brinzhang_: if there is only nits and test then such change can go in after FF | 08:29 |
| bauzas | stephenfin: I mean, i understood this was done by https://review.opendev.org/#/c/710037/13/doc/ext/extra_specs.py | 08:30 |
| brinzhang_ | gibi: ok, thanks for remind, that's better for me | 08:30 |
| bauzas | stephenfin: actually, nevermind I found it | 08:31 |
| *** zhanglong has quit IRC | 08:32 | |
| *** derekh has joined #openstack-nova | 08:33 | |
| *** zhanglong has joined #openstack-nova | 08:36 | |
| *** slaweq_ is now known as slaweq | 08:36 | |
| stephenfin | bauzas: cool, let me know if you still have issues with it. I wrote a good guide for the Sphinx doc on this thing https://www.sphinx-doc.org/en/master/development/tutorials/recipe.html | 08:43 |
| stephenfin | though it's a bit more complicated than what we're doing | 08:43 |
| *** ociuhandu has joined #openstack-nova | 08:45 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: api: Introduce microverion 2.87 allowing boot from volume rescue https://review.opendev.org/701430 | 08:46 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Extract _get_bdm_image_metadata into nova.utils https://review.opendev.org/705212 | 08:46 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Support boot from volume stable device instance rescue https://review.opendev.org/701431 | 08:46 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Break up get_disk_mapping within blockinfo https://review.opendev.org/714962 | 08:46 |
| lyarwood | stephenfin: ^ I did need the API samples after all for my microversion | 08:47 |
| stephenfin | how come? | 08:47 |
| stephenfin | why didn't I? :-\ | 08:47 |
| *** yaawang has quit IRC | 08:48 | |
| bauzas | stephenfin: not really, I don't want to hold this | 08:48 |
| lyarwood | stephenfin: my functional tests in nova/tests/functional/api_sample_tests/test_rescue.py are rerunning the sample tests against the microversion, slightly over the top but meh. | 08:49 |
| gibi | stephenfin: do you feel that we need to do someting with the way 2.83 client support merged during the night? https://review.opendev.org/#/c/713089/ | 08:50 |
| *** yaawang has joined #openstack-nova | 08:50 | |
| *** ociuhandu has quit IRC | 08:50 | |
| stephenfin | gibi: We don't *have* to, but I'm drafting the patch now to see if it makes sense :) | 08:51 |
| *** tkajinam has quit IRC | 08:51 | |
| gibi | stephenfin: that patch would be top of the current merged solution or would revert the current solution first? | 08:51 |
| stephenfin | I think on top would be wisest? | 08:51 |
| gibi | stephenfin: yeah, I'm not too affraid of doing a breaking CLI change as nobody consumed the patch we merged during the night yet | 08:52 |
| stephenfin | Yeah, exactly | 08:52 |
| stephenfin | Catch it before it's released | 08:52 |
| *** ociuhandu has joined #openstack-nova | 08:52 | |
| gibi | stephenfin: release will happen tomorrow night so we have some time | 08:53 |
| gibi | stephenfin: I'm really glad that you have the time to tinker with that client patch, I feel a bit overwhelmed due to FF | 08:53 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing server policies https://review.opendev.org/718348 | 08:56 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing server policies https://review.opendev.org/718348 | 08:56 |
| openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: Make 'server list --config-drive' a boolean option https://review.opendev.org/718349 | 08:59 |
| stephenfin | gibi: Yeah, I just want to nip this one in the bud before it gets released and that's not possible | 08:59 |
| johnthetubaguy | what is the REST API bug? | 09:02 |
| bauzas | gibi: stephenfin: hum, just catching-up but I feel this somehow has to be cleared in between us : https://review.opendev.org/#/c/713089/ | 09:02 |
| openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: Make 'server list --config-drive' a boolean option https://review.opendev.org/718349 | 09:03 |
| bauzas | gibi: stephenfin: FWIW, we should ask not to merge nova api changes unless there are novaclient patches in Depends-ON | 09:03 |
| johnthetubaguy | bauzas: really we should ask for openstack cli right? | 09:03 |
| bauzas | johnthetubaguy: OSC is more problematic in my mind | 09:03 |
| bauzas | but yeah we *should* | 09:03 |
| johnthetubaguy | agreed, I spend hours with customers telling them which commands are totally broken in there | 09:04 |
| *** ociuhandu has quit IRC | 09:04 | |
| stephenfin | johnthetubaguy: 'Instance.config_drive' is a string field but we treat it as sort of a boolean, storing the string 'True' for true and the empty string for False | 09:04 |
| bauzas | at least, a depends-on should be there for a microversion patch | 09:04 |
| stephenfin | johnthetubaguy: only the API rejects '?config_drive=' (the empty string) | 09:04 |
| gibi | bauzas: do you mean the API change depends-on the client patch not the other way around? | 09:04 |
| *** ociuhandu has joined #openstack-nova | 09:04 | |
| stephenfin | so it's not possible to say "give me all servers without a config drive" | 09:05 |
| bauzas | gibi: indeed, because of the release cadence | 09:05 |
| johnthetubaguy | stephenfin: and you can't do 'False' I guess? | 09:05 |
| johnthetubaguy | because empty string is falsey | 09:05 |
| stephenfin | nope, because whatever we provide is passed straight through to the DB query on the server side | 09:05 |
| stephenfin | and I guess an exact match lookup done | 09:06 |
| bauzas | gibi: anyway, just a can of worms for now | 09:06 |
| bauzas | and I don't want to go to the rabbit cave | 09:06 |
| *** brinzhang has joined #openstack-nova | 09:06 | |
| gibi | bauzas: could you please add you thinking to the etherpad https://etherpad.openstack.org/p/nova-victoria-ptg around L84 | 09:06 |
| stephenfin | that's my understanding of it, anyway. gibi can correct me if I'm wrong, though he's probably correct in saying we should wait til after feature freeze to work on this bugfix | 09:06 |
| bauzas | but I'm afraid we would run against client changes if we don't do it | 09:06 |
| gibi | stephenfin: you are correct | 09:07 |
| stephenfin | \o/ | 09:07 |
| bauzas | gibi: and the fact that stephenfin takes time to write the client changes instead of the BP owner makes me think that I'm right | 09:07 |
| gibi | stephenfin: I would also add that this bug exists at least since 2017 | 09:07 |
| gibi | bauzas: it is not exactly that. the owner wrote a change, we even merged a fixed version of it, stephenfin just has an improvement idea on the CLI interface | 09:08 |
| bauzas | gibi: writing client changes should be the responsibility of the bp owner, not the nova maintainers IMHO | 09:08 |
| stephenfin | bauzas: tbc, the client changes were done. I'm just tweaking it because I didn't like how it was done | 09:08 |
| bauzas | oh ok, then nevermind | 09:08 |
| stephenfin | but my patch is by no means mandatory | 09:08 |
| bauzas | cool then | 09:08 |
| stephenfin | if anything, I'm at fault because lyarwood drafted the novaclient change for *my* series /o\ | 09:08 |
| bauzas | again, it's just my personal thoughts, not a policy | 09:09 |
| gibi | bauzas: btw merging the client code before the API version bump means we need to agree what microversion number an API change will take _before_ we merge the API change | 09:09 |
| bauzas | don't take it wrong | 09:09 |
| lyarwood | stephenfin: wait, did I screw that up? | 09:09 |
| *** brinzhang_ has quit IRC | 09:09 | |
| *** ociuhandu has quit IRC | 09:09 | |
| stephenfin | lyarwood: no no, it was good, thanks :) | 09:09 |
| bauzas | gibi: when we're close to FF, I feel we somehow organize it already :) | 09:10 |
| gibi | bauzas: I'm not saying we should not do that, I say this will add complexity | 09:10 |
| stephenfin | gibi, bauzas: Yeah, let's bring this up at the PTG. Only two microversions left to go for this cycle, hopefully | 09:10 |
| gibi | bauzas: on the nova side it is by chance, on the client side, it is driven by the allocated microversion | 09:10 |
| bauzas | just because of the potential merge conflicts that would require a Zuul respin | 09:10 |
| gibi | stephenfin: +! | 09:10 |
| gibi | stephenfin: +1 | 09:10 |
| bauzas | I can add thoughts on this, not solutions | 09:10 |
| lyarwood | and both are no-ops in the client | 09:10 |
| * gibi goes back reviewing the 2.85 on the client side | 09:11 | |
| * bauzas is surprised being more active upstream when he's locked down with kids | 09:11 | |
| lyarwood | we all assumed you had farmed some of your work out to your kids ;) | 09:12 |
| bauzas | should I say "please keep me locked down for a while ?" | 09:12 |
| lyarwood | /s | 09:12 |
| bauzas | lyarwood: you can't imagine how you're right : this weekend's TODO : teach 'Scratch' to my 9yo daughter, she wants to | 09:13 |
| lyarwood | that's awesome :) | 09:13 |
| bauzas | she did read children books about girls doing STEM, she now wants to code | 09:13 |
| bauzas | not sure how long it will last tho | 09:14 |
| *** yaawang has quit IRC | 09:14 | |
| bauzas | https://www.penguinrandomhouse.com/series/GWC/girls-who-code FTW | 09:16 |
| *** yaawang has joined #openstack-nova | 09:16 | |
| bauzas | gibi: looking at https://launchpad.net/nova/+milestone/ussuri-3 I only see lyarwood's and gmann's changes requiring reviews, right? | 09:21 |
| bauzas | gibi: other bps aren't marked 'Needs Code review' | 09:22 |
| bauzas | (besides my own BP of course) | 09:22 |
| gibi | brinzhang: something is either wrong with https://review.opendev.org/#/c/712651/15 or with the API code, as I cannot change d-o-t from True to False | 09:22 |
| gibi | bauzas: don't trust Needs Code review field | 09:22 |
| gibi | I'm pretty sure it is not up-to-date | 09:22 |
| bauzas | gibi: I usually don't but other BPs are either implemented or 'Started' but are actually either merged or still WIP :) | 09:23 |
| gibi | bauzas: hm, stephenfin's extra spec validation also open | 09:23 |
| bauzas | of the 3 'Started', one is already got +2 from me, the other one is the 2.85 microversion change we just discussed and the third one is in the gate :) | 09:24 |
| bauzas | gibi: I just +2d the whole series with comments | 09:24 |
| stephenfin | yeah, that's blocked by this tempest change. I'm hoping gmann can expedite it today https://review.opendev.org/#/c/707223/ | 09:24 |
| gibi | bauzas: cool | 09:24 |
| bauzas | either way, jumping to lyarwood's then | 09:25 |
| gibi | I got pinged about the https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/use-pcpu-and-vcpu-in-one-instance too | 09:25 |
| gibi | bauzas: yeah, lyarwood should be close | 09:25 |
| gibi | bauzas: thanks | 09:25 |
| gibi | I mean lyarwood's | 09:25 |
| bauzas | gibi: want me to look at https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/use-pcpu-and-vcpu-in-one-instance too ? | 09:25 |
| gibi | bauzas: honestly I don't know if it still has a chance to land, there is a lot of patches there | 09:26 |
| bauzas | that's what I see | 09:26 |
| gibi | and I haven't really followed the series so I have no context how complex it is | 09:27 |
| gibi | gmann's policy patches are fairly simple in the other hand | 09:27 |
| stephenfin | I'm happy to keep reviewing the policy patches, if you could take a look at the pcpu-and-vcpu one, bauzas | 09:27 |
| stephenfin | fwiw, the complexity is only in the last two patches or | 09:27 |
| stephenfin | ....so | 09:27 |
| gibi | also there is https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/unified-limits-nova I started reviewing lately but I had no time to get back to it and re-review | 09:28 |
| stephenfin | the rest is an attempt to make that code readable :( | 09:28 |
| stephenfin | it's so, so bad | 09:28 |
| * gibi goes back to 2.85 client patch again | 09:28 | |
| bauzas | ok, entering the frightening tho exciting world of mystery that are volume-backed instances | 09:29 |
| bauzas | lyarwood: ^ | 09:29 |
| bauzas | stephenfin: okay, then you're next in my queue after bfv rescuse | 09:30 |
| bauzas | rescue* | 09:30 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Follow-up for flavor-extra-spec-validators series https://review.opendev.org/718357 | 09:30 |
| bauzas | stephenfin: I'd appreciate some reading of https://review.opendev.org/#/c/715489/ | 09:30 |
| bauzas | (btw.) | 09:31 |
| bauzas | bonus stage : https://review.opendev.org/#/c/717975/8 | 09:31 |
| lyarwood | bauzas: I've got that open at the moment btw, taking a while as I've never looked at vGPU stuff before. | 09:32 |
| bauzas | lyarwood: that's the reason why I invested a bit of time on functionally testing the feature https://review.opendev.org/#/c/717975/ | 09:32 |
| bauzas | worth reading the last bit, fresh as of this night. | 09:33 |
| lyarwood | ack thanks | 09:34 |
| *** yaawang has quit IRC | 09:35 | |
| *** yaawang has joined #openstack-nova | 09:36 | |
| brinzhang | gibi: seem like you missed the "--os-compute-api-version 2.85" in you CLI | 09:37 |
| gibi | brinzhang: hm, interesting | 09:37 |
| gibi | checking... | 09:37 |
| gibi | nova client should default to max microversion | 09:38 |
| gibi | and False to True worked | 09:38 |
| gibi | but let me double check it | 09:38 |
| *** Liang__ has quit IRC | 09:38 | |
| brinzhang | Emm..interesting.. | 09:38 |
| *** ociuhandu has joined #openstack-nova | 09:40 | |
| gibi | brinzhang: here is a repro http://paste.openstack.org/show/791792/ | 09:40 |
| gibi | False -> True works, True -> False seems to be ignored | 09:41 |
| gibi | let's try to attach a debugger | 09:42 |
| brinzhang | gibi: looks like the phenomenon is not in nocalient | 09:42 |
| gibi | you mean, this a potential bug in the nova API change? | 09:42 |
| brinzhang | gibi: I am not sure, I will rebuild my env, I think it's not fast | 09:43 |
| gibi | OK, I'm also looking into this in parallel with you | 09:43 |
| gibi | I will let you know if I found something | 09:43 |
| *** zhanglong has quit IRC | 09:44 | |
| brinzhang | "False -> True works, True -> False seems to be ignored", that from False to True works, and I reviewed again in novalient code, it's ok for me, so I am not sure whether is it have something in nova API | 09:44 |
| openstackgerrit | Mikhail Ushanov proposed openstack/nova stable/ocata: Support qemu >= 2.10 https://review.opendev.org/693851 | 09:47 |
| *** brinzhang_ has joined #openstack-nova | 09:52 | |
| gibi | brinzhang: it seems to me that converting from the 'False' string to boolean is missing from the API code | 09:53 |
| gibi | (Pdb) bdm.delete_on_termination = att['delete_on_termination'] | 09:53 |
| gibi | (Pdb) bdm.delete_on_termination | 09:53 |
| gibi | True | 09:53 |
| openstackgerrit | Andreas Jaeger proposed openstack/nova-specs master: Cleanup py27 support https://review.opendev.org/718368 | 09:53 |
| gibi | (Pdb) att['delete_on_termination'] | 09:53 |
| gibi | 'False' | 09:53 |
| gibi | (Pdb) | 09:53 |
| gibi | and ovo converst the non empty string ('False') to True automatically | 09:53 |
| gibi | the schema enforces the boolean-ness of the field but we did not covert it to boolean | 09:55 |
| *** brinzhang has quit IRC | 09:55 | |
| gibi | yep, I confirmed that the string boolean conversion is missing | 09:59 |
| gibi | filing bug... | 09:59 |
| brinzhang_ | gibi: yeah, happened in https://review.opendev.org/#/c/693828/27/nova/api/openstack/compute/volumes.py@454 | 10:00 |
| gibi | yep, a bool_from_string calls is missing there, and also we don't have proper test coverage as we did not catch the bug | 10:01 |
| gibi | I'm filling a bug, do you have time to start creating a fix? | 10:02 |
| brinzhang_ | gibi: of course | 10:02 |
| gibi | thanks, I wil link the bug here soon | 10:03 |
| brinzhang_ | gibi: thanks | 10:03 |
| *** links has quit IRC | 10:08 | |
| gibi | brinzhang_: https://bugs.launchpad.net/nova/+bug/1871598 | 10:08 |
| openstack | Launchpad bug 1871598 in OpenStack Compute (nova) "PUT /servers/{server_id}/os-volume_attachments/{volume_id} does not update delete_on_termination from True to False" [Medium,Triaged] | 10:08 |
| brinzhang_ | gibi: I will fix it today, before I get home | 10:08 |
| gibi | brinzhang_: thanks | 10:09 |
| gibi | ping me when you push the fix and I will review it | 10:09 |
| brinzhang_ | gibi: np | 10:09 |
| *** avolkov has joined #openstack-nova | 10:14 | |
| * gibi moves to review the extra_spec validation series | 10:15 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Remove '_numa_fit_instance_cell_with_pinning' https://review.opendev.org/714703 | 10:20 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Introduce 'pcpuset' field for InstanceNUMACell https://review.opendev.org/714658 | 10:20 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Introduce the 'CPUAllocationPolicy.MIXED' enum https://review.opendev.org/716267 | 10:20 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Add support for 'hw:cpu_dedicated_mask' extra spec https://review.opendev.org/714706 | 10:20 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: computer: validate cpu pinning configuration for mixed instance https://review.opendev.org/716268 | 10:20 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Calculate the pinned and unpinned CPU usage for mixed instance https://review.opendev.org/716269 | 10:20 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: mark mixed policy as ready, bump compute service version https://review.opendev.org/716271 | 10:20 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt/hardware: refactor numa_get_constraints https://review.opendev.org/718294 | 10:20 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Setup 'mixed' instance through 'PCPU' and 'VCPU' resource https://review.opendev.org/713355 | 10:20 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: metadata: export the vCPU IDs that are pinning on the host CPUs https://review.opendev.org/688936 | 10:20 |
| *** slaweq has quit IRC | 10:23 | |
| *** rpittau is now known as rpittau|bbl | 10:24 | |
| *** slaweq has joined #openstack-nova | 10:25 | |
| gibi | stephenfin: one question / nit in https://review.opendev.org/#/c/717789/2/nova/api/validation/extra_specs/validators.py@50 | 10:27 |
| *** links has joined #openstack-nova | 10:31 | |
| stephenfin | gibi: Replied. I'll have a test shortly | 10:32 |
| alex_xu | gibi: quick question, I don't think we need obj_make_compatible method for notification object, right? https://review.opendev.org/#/c/714658/6/nova/notifications/objects/request_spec.py@187 | 10:33 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Follow-up for flavor-extra-spec-validators series https://review.opendev.org/718357 | 10:36 |
| *** brinzhang has joined #openstack-nova | 10:37 | |
| gibi | stephenfin: thanks. +A | 10:37 |
| stephenfin | ta | 10:38 |
| gibi | alex_xu: at the momen there is no way to ask nova to emit older than the latest version of the notifications. So obj_make_compatible is unused for notification ovos | 10:38 |
| gibi | alex_xu: so no, we don't need it | 10:39 |
| * gibi lunches | 10:39 | |
| *** brinzhang_ has quit IRC | 10:40 | |
| alex_xu | gibi: thanks | 10:40 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Convert delete_on_termination from string to boolean https://review.opendev.org/718387 | 10:54 |
| brinzhang | gibi: fixed done, pls review https://review.opendev.org/718387 | 10:54 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Follow-up for flavor-extra-spec-validators series https://review.opendev.org/718357 | 10:56 |
| stephenfin | bauzas: had to respin that ^ | 10:56 |
| bauzas | ack | 10:56 |
| gibi | brinzhang: ack, will check, thanks | 10:57 |
| *** brinzhang_ has joined #openstack-nova | 10:57 | |
| *** brinzhang has quit IRC | 11:00 | |
| openstackgerrit | Merged openstack/nova master: Add new default roles in security group policies https://review.opendev.org/716793 | 11:02 |
| openstackgerrit | Merged openstack/nova master: Allow versioned discovery unauthenticated https://review.opendev.org/685181 | 11:11 |
| openstackgerrit | Merged openstack/nova master: Fix new context comparison workaround in base tests class https://review.opendev.org/717825 | 11:12 |
| *** ratailor has quit IRC | 11:16 | |
| openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.85: Change volume-update CLI https://review.opendev.org/712651 | 11:20 |
| lyarwood | https://review.opendev.org/#/q/topic:workaround_native_luksv1+status:open+project:openstack/nova - looking for core reviews on this btw, appreciate everyone is busy ahead of M3 but wanted to ask anyway. | 11:22 |
| brinzhang_ | gibi, lyarwood: novalient for microversion 2.85 updated too. | 11:22 |
| gibi | brinzhang_: ack | 11:23 |
| *** mkrai has quit IRC | 11:30 | |
| *** ociuhandu has quit IRC | 11:34 | |
| gibi | stephenfin: feedback in https://review.opendev.org/#/c/708436/ would you like to fix it in a FUP? | 11:34 |
| lyarwood | brinzhang_: ack thanks, I think the call to bool_from_string should use strict=True | 11:34 |
| *** ociuhandu has joined #openstack-nova | 11:35 | |
| brinzhang_ | lyarwood: I looked you comment, agree add strict=True | 11:37 |
| *** ociuhandu has quit IRC | 11:39 | |
| *** zhanglong has joined #openstack-nova | 11:40 | |
| *** links has quit IRC | 11:44 | |
| *** zhanglong has quit IRC | 11:45 | |
| brinzhang_ | lyarwood: [True, 'True', 'TRUE', 'true', '1', 'ON', 'On', 'on', 'YES', 'Yes', 'yes'] for true, [False, 'False', 'FALSE', 'false', '0', 'OFF', 'Off', 'off', 'NO', 'No', 'no'] for False, does them all tests? | 11:45 |
| *** links has joined #openstack-nova | 11:45 | |
| brinzhang_ | if yes, I will do a for cycle to test | 11:45 |
| sean-k-mooney | what is this for? | 11:45 |
| sean-k-mooney | if your trying to do string to bool conversion use https://github.com/openstack/oslo.utils/blob/master/oslo_utils/strutils.py#L123-L158 | 11:46 |
| *** brinzhang has joined #openstack-nova | 11:47 | |
| sean-k-mooney | if you use bool_from_string you dont need to test all the combinations | 11:47 |
| sean-k-mooney | we know the oslo function works | 11:47 |
| lyarwood | brinzhang_: I don't think we need to test them all but just more than False | 11:47 |
| *** zhanglong has joined #openstack-nova | 11:47 | |
| lyarwood | brinzhang_: and a bad value obviously | 11:48 |
| openstackgerrit | Merged openstack/nova master: Add test coverage of existing simple tenant usage policies https://review.opendev.org/717546 | 11:49 |
| openstackgerrit | Merged openstack/nova master: Add test coverage of existing server migrations policies https://review.opendev.org/717531 | 11:49 |
| openstackgerrit | Merged openstack/nova master: Fix server tags policy to be admin_or_owner https://review.opendev.org/717947 | 11:49 |
| openstackgerrit | Merged openstack/nova master: Add test coverage of existing server tags policies https://review.opendev.org/717425 | 11:49 |
| brinzhang | ok, I will add a true value e.g. '1' to tests | 11:50 |
| openstackgerrit | Merged openstack/nova master: Introduce scope_types in server tags policy https://review.opendev.org/717948 | 11:50 |
| openstackgerrit | Merged openstack/nova master: Add new default roles in server tags policies https://review.opendev.org/717954 | 11:50 |
| openstackgerrit | Merged openstack/nova master: Introduce scope_types in server migration https://review.opendev.org/717588 | 11:50 |
| openstackgerrit | Merged openstack/nova master: Add new default roles in server migration policies https://review.opendev.org/717590 | 11:50 |
| openstackgerrit | Merged openstack/nova master: Fix server password policy to be admin_or_owner https://review.opendev.org/717212 | 11:50 |
| *** brinzhang_ has quit IRC | 11:50 | |
| brinzhang | lyarwood: what is the bad value? can you give me a example? I used 'x' to test that it's false | 11:50 |
| openstackgerrit | Merged openstack/nova master: Add test coverage of existing server password policies https://review.opendev.org/717204 | 11:50 |
| openstackgerrit | Merged openstack/nova master: Introduce scope_types in server password policy https://review.opendev.org/717415 | 11:50 |
| openstackgerrit | Merged openstack/nova master: Pass the actual target in server migration policy https://review.opendev.org/717591 | 11:51 |
| *** ociuhandu has joined #openstack-nova | 11:51 | |
| lyarwood | brinzhang: None with strict=True | 11:52 |
| gibi | stephenfin: does the extra_spec series still depends on the tempest fix? as far as I see tempest uses top level keys instead of known namespaces | 11:55 |
| sean-k-mooney | brinzhang: are you using bool_from_string because x is not a vaild value | 11:56 |
| sean-k-mooney | brinzhang: with strict 'x' should raise an error | 11:56 |
| brinzhang | >>> from oslo_utils import strutils | 11:56 |
| brinzhang | >>> strutils.bool_from_string('dd') | 11:56 |
| brinzhang | False | 11:56 |
| brinzhang | sean-k-mooney: I test in python3 | 11:56 |
| sean-k-mooney | right that is becasue you are hitting this https://github.com/openstack/oslo.utils/blob/master/oslo_utils/strutils.py#L157-L158 | 11:56 |
| brinzhang | yeah | 11:57 |
| sean-k-mooney | the default is false and if you dont have stict then any unrecognised value returns the default | 11:57 |
| brinzhang | yes, the strict=Fasle, if we change this to True, it will be an invalid value | 11:59 |
| *** zhanglong has quit IRC | 12:01 | |
| brinzhang | lyarwood:nova.exception.ValidationError: Invalid input for field/attribute delete_on_termination. Value: xxx. 'xxx' is not one of [True, 'True', 'TRUE', 'true', '1', 'ON', 'On', 'on', 'YES', 'Yes', 'yes', False, 'False', 'FALSE', 'false', '0', 'OFF', 'Off', 'off', 'NO', 'No', 'no'] | 12:07 |
| brinzhang | while I change the value to error, it cannot pass the schema check, do I necessary to do the bad value test? | 12:07 |
| *** artom has joined #openstack-nova | 12:08 | |
| lyarwood | brinzhang: ah no then sorry, the schema check is enough. | 12:10 |
| lyarwood | brinzhang: but we should still leave strict=True on to be safe | 12:10 |
| brinzhang | lyarwood: yeah, I will give up this test | 12:10 |
| *** ociuhandu has quit IRC | 12:10 | |
| brinzhang | and add body['volumeAttachment']['delete_on_termination'] = '1' to assertTure() | 12:10 |
| brinzhang | lyarwood: yes, I was added strict=True to the bool_from_string() | 12:11 |
| *** ociuhandu has joined #openstack-nova | 12:11 | |
| lyarwood | brinzhang: ack yeah anything to assert true being passed in would be nice to have | 12:11 |
| *** tkajinam has joined #openstack-nova | 12:14 | |
| stephenfin | gibi: Oh, that's a good point. It probably doesn't now :) | 12:14 |
| * stephenfin drops that Depends-On | 12:14 | |
| gibi | \o/ | 12:14 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Convert delete_on_termination from string to boolean https://review.opendev.org/718387 | 12:16 |
| jkulik | is there anything in or around nova, that would help defragment host memory? move VMs around, so that a bigger VM can fit on a host again | 12:16 |
| *** ociuhandu has quit IRC | 12:16 | |
| brinzhang | lyarwood, sean-k-mooney: update done. | 12:16 |
| brinzhang | good morning all, have a nice day, bye. | 12:16 |
| gibi | brinzhang: thanks! good night! | 12:16 |
| lyarwood | \o | 12:17 |
| gibi | jkulik: nova itself allows you to move VMs to other host. top of nova there is https://wiki.openstack.org/wiki/Watcher but don't know the health of the watcher project | 12:18 |
| *** brinzhang has quit IRC | 12:19 | |
| jkulik | thanks for the hint | 12:20 |
| *** rpittau|bbl is now known as rpittau | 12:23 | |
| *** brinzhang has joined #openstack-nova | 12:23 | |
| bauzas | stephenfin: question, you turned up your vote to +2 for lyarwood's, could you please tell me why ? did lyarwood provided a FUP or your comment on https://review.opendev.org/#/c/700812/21/nova/virt/libvirt/blockinfo.py@99 is wrong ? | 12:35 |
| bauzas | because https://review.opendev.org/#/c/700812/21/nova/virt/libvirt/blockinfo.py@99 afraids me | 12:35 |
| stephenfin | because I was expecting a follow-up | 12:35 |
| stephenfin | the -1 was accidental | 12:36 |
| bauzas | cool then | 12:37 |
| bauzas | stephenfin: and you don't see a problem with https://review.opendev.org/#/c/700812/21/nova/virt/libvirt/blockinfo.py@99 | 12:38 |
| bauzas | ? | 12:38 |
| * bauzas trying to see whether it's an issue or not | 12:38 | |
| stephenfin | they should be combined, yes, but I didn't think it was a blocking issue so long as it was resolved in a follow-up | 12:39 |
| stephenfin | Happy to drop the +2 until that follow-up is there though | 12:39 |
| huaqiang | @stephenfin: can you have a look at url:https://review.opendev.org/#/c/718345/ | 12:39 |
| huaqiang | if this patch is accepted, some of mixed instance patch will be easier | 12:40 |
| *** xek_ has joined #openstack-nova | 12:40 | |
| stephenfin | huaqiang: We have to work without that because feature freeze has passed for oslo | 12:41 |
| stephenfin | so it'll be Victoria before we can merge that | 12:41 |
| huaqiang | ok | 12:41 |
| huaqiang | I'll make workaround for now | 12:42 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Follow-up for flavor-extra-spec-validators series https://review.opendev.org/718357 | 12:43 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Add framework for extra spec validation https://review.opendev.org/704643 | 12:47 |
| bauzas | lyarwood: left a comment giving you only a +1 on https://review.opendev.org/#/c/700812/21 | 12:48 |
| bauzas | tl;dr: I understand this can be unstable to rescue an instance with attached disks, but this is *not* unstable when we talk of a single instance with only one disk | 12:49 |
| bauzas | (and this saved me more than a couple of times when I was operating an Essex cloud) | 12:50 |
| bauzas | lyarwood: also, remember me, but can't you detach disks before rescuing ? | 12:50 |
| bauzas | that won't make your workloads happy for sure, but you can still access the guest | 12:51 |
| bauzas | it looks to me very like booting as single user, you only get a very limited access but you got it to | 12:52 |
| bauzas | tho* | 12:52 |
| *** ttsiouts has quit IRC | 12:53 | |
| *** ttsiouts has joined #openstack-nova | 12:57 | |
| *** spatel has joined #openstack-nova | 12:58 | |
| *** spatel has quit IRC | 12:59 | |
| lyarwood | bauzas / stephenfin ; I somehow missed that rebase error, I can get rid of that now assuming stephenfin has had to push changes to his series I'm based on | 13:02 |
| stephenfin | lyarwood: That or a follow-up. I'm hoping I don't have to rebase the rest of my series but I think Gerrit will force me to | 13:03 |
| lyarwood | bauzas: I can remove this use of unstable here and just call it a rescue. It's still unstable in the sense of disk ordering even with a single disk instance but I can see how this term might confuse people. | 13:04 |
| lyarwood | bauzas: you can detach non-root disks but not bfv root disks. | 13:05 |
| lyarwood | bauzas: and yeah stable rescue essentially gives you the same experience as you would have with bare metal machines entering into rescue mode | 13:06 |
| lyarwood | bauzas: everything attached in the same order etc. | 13:06 |
| lyarwood | stephenfin: kk fup might be easier in that case | 13:06 |
| openstackgerrit | sean mooney proposed openstack/nova master: cyborg evacuate support https://review.opendev.org/715326 | 13:07 |
| sean-k-mooney | gibi: dansmith ^ just fixed the pep8 issues and a minor style tweek but tha is otherwise the same as the one i pushed last night | 13:08 |
| gibi | sean-k-mooney: ack | 13:09 |
| sean-k-mooney | dansmith: gibi i tested that local last night and it apears to correcly handel rebuild and evac including all the arq binding and placementa allocations | 13:09 |
| sean-k-mooney | im not sure if we want to included it in ussuri but it should be read for review | 13:10 |
| gibi | stephenfin: fyi relevant testcase failed in the FUP of extra_specs | 13:12 |
| sean-k-mooney | lyarwood: :) | 13:15 |
| openstackgerrit | Arthur Dayne proposed openstack/nova master: libvirt:driver:Disallow AIO=native when 'O_DIRECT' is not available https://review.opendev.org/682772 | 13:16 |
| *** udesale_ has joined #openstack-nova | 13:18 | |
| bauzas | lyarwood: yup, I knew for the flipped ordering | 13:18 |
| bauzas | lyarwood: but again, this saves a guest OS | 13:18 |
| bauzas | maybe I'm bikeshedding on some naming this being said | 13:18 |
| sean-k-mooney | lyarwood: for what its worth on a normal machine if you boot form usb the disk order used to change as it would become sda :P | 13:19 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Add support for new cyborg extra specs https://review.opendev.org/716222 | 13:19 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Drop concept of '?validation' parameter https://review.opendev.org/717789 | 13:19 |
| sean-k-mooney | at least on linux on window its proably different | 13:20 |
| lyarwood | sean-k-mooney: I've never seen that tbh, was that under a particular BIOS? | 13:20 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Add microversion for extra spec validation https://review.opendev.org/708436 | 13:20 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Add documentation for flavor extra specs https://review.opendev.org/710037 | 13:20 |
| *** udesale has quit IRC | 13:20 | |
| sean-k-mooney | lyarwood: its what used to happen on the servers i used at intel | 13:20 |
| lyarwood | sean-k-mooney: weird | 13:20 |
| lyarwood | sean-k-mooney: I guess that's one way to change the boot order | 13:20 |
| sean-k-mooney | i have seen it about 50% of the other laptops and servers have at home | 13:20 |
| *** zhanglong has joined #openstack-nova | 13:21 | |
| lyarwood | bauzas: no issues, my use of unstable is just confusing there so I'll remove it. | 13:21 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Follow-up for flavor-extra-spec-validators series https://review.opendev.org/718357 | 13:21 |
| sean-k-mooney | lyarwood: i dont think it hapens for uefi for what its worth | 13:21 |
| *** nweinber has joined #openstack-nova | 13:21 | |
| sean-k-mooney | only legacy boot mode | 13:21 |
| bauzas | lyarwood: thanks for your good comments on https://review.opendev.org/#/c/715490/ I'll upload a FUP | 13:22 |
| bauzas | lyarwood: if you don't disagree | 13:22 |
| stephenfin | gibi: Respun that. Good spot. /o\ | 13:22 |
| bauzas | (I just want to avoid a new zuul CI respin) | 13:22 |
| lyarwood | bauzas: yeah np | 13:22 |
| bauzas | ack thanks | 13:23 |
| sean-k-mooney | stephenfin: bauzas lyarwood since ye are all here care to review the final few patches for cyborg. the first two are real staight forward and dont require much knoladge of cyborg | 13:24 |
| bauzas | sean-k-mooney: I can take a look today | 13:24 |
| sean-k-mooney | https://review.opendev.org/#/c/716185/6 https://review.opendev.org/#/c/716186/6 and https://review.opendev.org/#/c/715326/7 | 13:24 |
| lyarwood | sean-k-mooney: yup I can | 13:24 |
| sean-k-mooney | i think sundar is nolonger working on this stuff so if there are any issue ill respin the patches | 13:24 |
| bauzas | I'm mostly done on reviewing lyarwood's stable rescue thingies, so either I go with pinned/non-pinned stephenfin's patches or cyborg ones | 13:25 |
| bauzas | but I think cyborg is moar important upstream | 13:25 |
| bauzas | stephenfin: amirite ? | 13:25 |
| sean-k-mooney | they are shorter. the first one is the release note/api docs the second is a minor fix and the last is rebuild/evacuate | 13:26 |
| sean-k-mooney | we should land the first two definetly. | 13:26 |
| bauzas | FWIW, I'd be glad if we could merge my own stuff which is small too :p | 13:26 |
| sean-k-mooney | the last need proper review so if you cover the first two you could always swap back to stephens | 13:26 |
| bauzas | kk | 13:27 |
| bauzas | finishing lyarwood's patch review on this new trait first and then going on cyborg | 13:27 |
| sean-k-mooney | yes im getting coffee but after that im proably goign to go review the rest of your series then lyarwood's or stephenfin's ones | 13:28 |
| *** eharney has joined #openstack-nova | 13:28 | |
| *** zhanglong has quit IRC | 13:30 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: fup: Combine SUPPORTED_DEVICE_BUS and SUPPORTED_STORAGE_BUSES https://review.opendev.org/718448 | 13:31 |
| *** zhanglong has joined #openstack-nova | 13:31 | |
| *** ociuhandu has joined #openstack-nova | 13:33 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: fup: Remove the use of the term `unstable rescue` INFO logs https://review.opendev.org/718451 | 13:36 |
| gibi | stephenfin: does 'trait:CUSTOM_FOO' : 'foo' is only passing validation if the CUSTOM trait exists or not at all? | 13:43 |
| gibi | sorry 'trait:CUSTOM_FOO' : 'required' | 13:43 |
| stephenfin | Nope, it's a wildcard | 13:43 |
| stephenfin | trait:CUSTOM_* | 13:43 |
| gibi | then I think we have a bug | 13:44 |
| gibi | this fails | 13:44 |
| gibi | def test_create_trait_spec(self): | 13:44 |
| gibi | body = {'extra_specs': { | 13:44 |
| gibi | 'trait:CUSTOM_FOO': 'required', | 13:44 |
| gibi | }} | 13:44 |
| gibi | self.admin_api.post_extra_spec(self.flavor_id, body) | 13:44 |
| stephenfin | gibi: Cool, let me look | 13:46 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add new default roles in server password policies https://review.opendev.org/717417 | 13:47 |
| stephenfin | gibi: Wait - are custom traits a thing? | 13:47 |
| stephenfin | I didn't think they were. That's why I've nothing handling them | 13:48 |
| stephenfin | whereas I do for resources https://review.opendev.org/#/c/704643/23/nova/api/validation/extra_specs/resources.py@41 | 13:48 |
| gibi | stephenfin: they are https://docs.openstack.org/api-ref/placement/?expanded=update-traits-detail#list-traits | 13:48 |
| gibi | qos using them (but now view flavor extra_spec) | 13:49 |
| stephenfin | gdi, of course they are. Good spot. Will fix | 13:49 |
| gibi | (but not via flavor extra_spec) | 13:49 |
| *** dtantsur is now known as dtantsur|brb | 13:50 | |
| *** jraju__ has joined #openstack-nova | 13:50 | |
| *** Liang__ has joined #openstack-nova | 13:50 | |
| sean-k-mooney | gibi: we can use custome traits via flavor extra specs | 13:51 |
| sean-k-mooney | or via images | 13:52 |
| *** links has quit IRC | 13:52 | |
| gibi | sean-k-mooney: ack. I meant that qos is using CUSTOM traits through the port not the flavor | 13:52 |
| sean-k-mooney | oh you ment qos does not use them via flavor extra specs | 13:52 |
| gibi | yepp | 13:52 |
| gibi | I just type something crazy first :D | 13:53 |
| gibi | typed | 13:53 |
| sean-k-mooney | looking at the validator i dont see wher CUSTOM_ traits are being blocked | 13:54 |
| sean-k-mooney | https://review.opendev.org/#/c/718357/5/nova/api/validation/extra_specs/traits.py is not blocking it anyway | 13:55 |
| bauzas | sean-k-mooney: gibi: I have a functional test that proves it works :p | 13:55 |
| bauzas | (adding custom traits to a flavor) | 13:55 |
| sean-k-mooney | i think we have a couple actully | 13:56 |
| * bauzas shamelessly provides a link for it https://review.opendev.org/#/c/717975/8/nova/tests/functional/libvirt/test_vgpu.py | 13:56 | |
| sean-k-mooney | bauzas: dont we have one for the compute status trait | 13:57 |
| sean-k-mooney | we used used a custom one breifly | 13:57 |
| bauzas | sean-k-mooney: indeed, and we always ask for it | 13:57 |
| bauzas | but that's not a custom one | 13:57 |
| sean-k-mooney | not anymore | 13:57 |
| bauzas | root_required=!COMPUTE_DISABLED or something like this | 13:57 |
| bauzas | but that's 'root' required | 13:58 |
| sean-k-mooney | matt used a custome one for dev i can recall if we merged it after the standard one was added and release in os-traits or not | 13:58 |
| sean-k-mooney | we proably waited | 13:58 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Allow custom traits https://review.opendev.org/718461 | 13:58 |
| bauzas | I was afraid of custom traits on a child RP not being bobbled up to the tree for verification but it does work | 13:58 |
| stephenfin | gibi: done ^ | 13:58 |
| *** liuyulong has joined #openstack-nova | 13:59 | |
| bauzas | I was able to tag CUSTOM_NVIDIA_XX on a child RP and just request this trait on a flavor which was getting me the right RP as a result | 13:59 |
| sean-k-mooney | bauzas: yes if you add them to the unumbered group i think we check the tree | 13:59 |
| bauzas | sean-k-mooney: that's what the api-ref says at least :) | 13:59 |
| bauzas | https://docs.openstack.org/api-ref/placement/?expanded=list-allocation-candidates-detail#list-allocation-candidates | 14:00 |
| bauzas | "Allocation requests in the response will be for resource providers that have capacity for all requested resources and the set of those resource providers will collectively contain all of the required traits. These traits may be satisfied by any provider in the same non-sharing tree or associated via aggregate. " | 14:00 |
| bauzas | custom traits are just treated equally | 14:00 |
| *** Liang__ is now known as LiangFang | 14:00 | |
| sean-k-mooney | yep | 14:01 |
| gibi | stephenfin: ack, still someting feels wrong | 14:01 |
| gibi | def test_create_invalid_resource_spec(self): | 14:01 |
| gibi | body = {'extra_specs': { | 14:01 |
| gibi | 'resource:CUSTOM_FOO': 'boo', | 14:01 |
| gibi | }} | 14:01 |
| gibi | self.admin_api.post_extra_spec(self.flavor_id, body) | 14:01 |
| gibi | this should fail as 'boo' is not int, but it is accepted | 14:02 |
| *** belmoreira has quit IRC | 14:02 | |
| gibi | haven't checked the latest ps | 14:02 |
| gibi | pulling it now | 14:03 |
| stephenfin | gimme a few | 14:03 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: fup: Add missing docstrings from get_rescue_device|bus diskinfo funcs https://review.opendev.org/718464 | 14:05 |
| sean-k-mooney | gibi: are you useing the correct microversion | 14:06 |
| gibi | sean-k-mooney: I'm using the functional test env | 14:06 |
| *** ttsiouts has quit IRC | 14:06 | |
| gibi | sean-k-mooney: and that sets it to 2.86 | 14:06 |
| sean-k-mooney | right well it might not be using the latest microverions | 14:06 |
| *** ttsiouts has joined #openstack-nova | 14:06 | |
| sean-k-mooney | ah ok | 14:06 |
| sean-k-mooney | https://review.opendev.org/#/c/704643/23/nova/api/validation/extra_specs/resources.py | 14:06 |
| sean-k-mooney | so the valu is defiend as an int | 14:07 |
| gibi | there are a bunch of tests alreay there that works as expected | 14:07 |
| gibi | something is wrong with the parameterized namespaced keys | 14:07 |
| sean-k-mooney | its possible that boo is being treated as hex | 14:07 |
| sean-k-mooney | actully proably not | 14:08 |
| gibi | yepp, it accepts not-an-int as well | 14:08 |
| stephenfin | gibi: s/resource/resources/ | 14:09 |
| gibi | /o\ | 14:09 |
| sean-k-mooney | stephenfin: should your typo chekcing not catch that :P | 14:09 |
| stephenfin | nope, it's an unknown namespace :) | 14:10 |
| gibi | stephenfin: you are right. resources works as expected | 14:10 |
| sean-k-mooney | ... oh because we are droping ?validation | 14:10 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Allow custom traits https://review.opendev.org/718461 | 14:10 |
| *** kaisers_ has joined #openstack-nova | 14:11 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM - Test stable device rescue tests with BFV instances https://review.opendev.org/710050 | 14:12 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM test stable rescue tempest/devstack changes https://review.opendev.org/700815 | 14:13 |
| gmann | stephenfin: on extra spec tempest failure. new validation is with microversion right? and old microversion keep accepting the invalid things as they were ? | 14:21 |
| stephenfin | gmann: Correct | 14:21 |
| gmann | in that case tempest should not fail | 14:22 |
| stephenfin | Oh, does Tempest default to the oldest microversion? | 14:22 |
| stephenfin | Somewhat related, that change is actually not critical now since we've changed how validation works. Now we only care about known namespaces (e.g. 'hw:') | 14:23 |
| gmann | yeah, 2.1 is default | 14:23 |
| *** martinkennelly has quit IRC | 14:23 | |
| stephenfin | Ah, I wonder if one of the gate jobs was setting a higher default because I thought I saw failures early on | 14:23 |
| stephenfin | before we changed to the current namespace-only model, that is | 14:24 |
| *** zhanglong has quit IRC | 14:24 | |
| gmann | i do not think we have any job run with latest. all microversion tests are with cap. | 14:25 |
| *** martinkennelly has joined #openstack-nova | 14:25 | |
| gmann | but uncapped tests can be run with any microversion via configuration. so your change lgtm overall. I was curious if nova code is blocked due to tempest things | 14:25 |
| *** zhanglong has joined #openstack-nova | 14:26 | |
| *** efried has quit IRC | 14:30 | |
| gmann | stephenfin: +A on tempest fix. | 14:31 |
| *** efried has joined #openstack-nova | 14:32 | |
| aarents | Hi there, I'm wondering if someone can evaluate this: https://review.opendev.org/#/c/717037 it's about a space available calucation issue during host periodic task | 14:32 |
| gmann | stephenfin: can you review this policy warning things on olso.policy - https://review.opendev.org/#/c/717879/2 | 14:32 |
| gmann | gibi: stephenfin : RE on config-drive things. sorry i could have hold +W. not allowing that filter for now or just allow as bool (what stephenfin proposal) make more sense. | 14:37 |
| gibi | gmann: no worries | 14:38 |
| openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: Make 'server list --config-drive' a boolean option https://review.opendev.org/718349 | 14:38 |
| stephenfin | gmann: Good timing :) ^ | 14:38 |
| stephenfin | Looking at that oslo patch now | 14:38 |
| gmann | thanks. checking.. | 14:38 |
| bauzas | aarents: we're very close to FF, could you please ping us this one on Friday ? | 14:39 |
| aarents | bauzas: sure | 14:39 |
| gibi | bauzas: will you work on this Friday? | 14:40 |
| *** tesseract has quit IRC | 14:40 | |
| bauzas | gibi: yup, our bank holiday is usually Monday | 14:40 |
| bauzas | (only I mean) | 14:40 |
| bauzas | gibi: you ? | 14:40 |
| bauzas | Friday and Monday ? | 14:40 |
| gibi | interesting we have both Friday and Monday off due to easter | 14:40 |
| *** mlavalle has joined #openstack-nova | 14:41 | |
| bauzas | heh, of course France only has a very few PTO days | 14:41 |
| bauzas | poor of us | 14:41 |
| *** tesseract has joined #openstack-nova | 14:42 | |
| * stephenfin 's heart bleeds for the poor French man | 14:42 | |
| stephenfin | :P | 14:42 |
| gibi | :P | 14:43 |
| aarents | :) | 14:43 |
| bauzas | wait for May, dudes, wait for May... | 14:43 |
| lyarwood | ha | 14:43 |
| bauzas | actually, that makes a good call, Easter makes difficult any potential exception we could make | 14:44 |
| bauzas | as it would differ for at least 2 working days | 14:44 |
| bauzas | haven't realized that | 14:44 |
| *** igordc has joined #openstack-nova | 14:45 | |
| *** udesale_ has quit IRC | 14:46 | |
| *** lpetrut has quit IRC | 14:46 | |
| gmann | gibi: stephenfin how about not exposing non-working option --no-config-drive https://review.opendev.org/#/c/718349/3/novaclient/v2/shell.py@1561 | 14:48 |
| gmann | or we should say something about non-working in help message so that users would get false un-filtered servers list | 14:49 |
| stephenfin | gmann: That depends on whether we want to fix that filter with a microversion or not | 14:49 |
| gmann | exactly, that is why i was thinking about not exposing as we do not know solution yet. | 14:50 |
| gmann | and we may left that option always non-working for older version. | 14:50 |
| stephenfin | Hmm, fair point. I think it's okay to keep it but I also see your point. I'll let someone else decide | 14:51 |
| gmann | and we end up fix without microversion then we can always add as part of current bug fix | 14:51 |
| gmann | +1. yeah. | 14:51 |
| bauzas | sean-k-mooney: FWIW, got comments on https://review.opendev.org/#/c/716185/6 | 14:53 |
| gmann | lbragstad: did you get chance to test the new flag of new defaults switch - https://review.opendev.org/#/c/717943/2 | 14:54 |
| bauzas | sean-k-mooney: since it's already sent to the gate, I left a +1 to not fuck gibi's and lyarwood's stats :p | 14:54 |
| lbragstad | gmann i have an environment up - i should be able to do it today | 14:54 |
| gmann | lbragstad: i tried to simulate it on nova but somehow due to our fake_policy things for tests not letting me or something i am missing - https://review.opendev.org/#/c/717945/ | 14:54 |
| gmann | lbragstad: great thanks a lot. | 14:54 |
| *** hoonetorg has quit IRC | 14:56 | |
| bauzas | sean-k-mooney: -1 on https://review.opendev.org/#/c/716186/6 | 14:56 |
| bauzas | is Sundar no longer around ? | 14:56 |
| bauzas | who from the cyborg team can handover this ? | 14:56 |
| gmann | stephenfin: should i fix those nits if you are here to re+2 on this ? otherwise do not want to lose that +2- https://review.opendev.org/#/c/717879/2 | 14:57 |
| sean-k-mooney | bauzas: im taking over his nova work | 14:57 |
| sean-k-mooney | i can go file a bug report and add the bug link | 14:57 |
| bauzas | please | 14:57 |
| sean-k-mooney | bauzas: were you ok with the code | 14:57 |
| stephenfin | gmann: yes, if you can fix them, I'm okay to re +2 | 14:57 |
| bauzas | sean-k-mooney: from what I've seen, yes | 14:58 |
| bauzas | sean-k-mooney: maybe just one question, can _delete_arqs_by_uuid() raise some Exception ? | 14:58 |
| sean-k-mooney | cool ill see if i can adress your other commens in a seperate follow up patch | 14:58 |
| sean-k-mooney | bauzas: yes | 14:58 |
| bauzas | from what i've seen, we just call the API and treat the error | 14:59 |
| bauzas | oh, _call_cyborg can return an exception ? | 14:59 |
| sean-k-mooney | basically i can rais an exception for auth issue or normal network issues | 14:59 |
| sean-k-mooney | e.g. since ita an api requst cyborg could be dead | 14:59 |
| bauzas | OK, I just wonder whether this would trample the user if we got an exception in the meantime | 15:00 |
| *** dklyle has joined #openstack-nova | 15:00 | |
| sean-k-mooney | i dont think so | 15:00 |
| sean-k-mooney | maybe but i dont think it will | 15:00 |
| bauzas | correct, but then we need to handle it to return AcceleratorRequestOpFailed correctly then | 15:00 |
| gmann | stephenfin: done - https://review.opendev.org/#/c/717879/ | 15:00 |
| bauzas | sean-k-mooney: I wouldn't usually worry by exception handling on nova-computes, but here we talk of the API | 15:01 |
| bauzas | and this exception can be populated down to the end user | 15:01 |
| *** LiangFang has quit IRC | 15:01 | |
| sean-k-mooney | i think this is only used in bind_arqs | 15:02 |
| sean-k-mooney | and i think we cach all error form that but i have to check | 15:02 |
| sean-k-mooney | bauzas: its handeled here https://github.com/openstack/nova/blob/66965e48e1bf013e275148720b860dc5becba6bd/nova/conductor/manager.py#L840-L850 | 15:03 |
| sean-k-mooney | bauzas: so the exception never gets to the end user we just log it | 15:04 |
| bauzas | sean-k-mooney: not if _delete_arqs_by_uuid() which was just added raises an exception when trying to reach Cyborg API | 15:04 |
| bauzas | right? | 15:04 |
| *** priteau has joined #openstack-nova | 15:06 | |
| sean-k-mooney | _create_and_bind_arqs calls bind_arqs which is the only thing that calls _delete_arqs_by_uuid | 15:07 |
| sean-k-mooney | and _create_and_bind_arqs is called in a try block that catches all exception and logs them | 15:08 |
| sean-k-mooney | bauzas: acully im not sure _create_and_bind_arqs can raise an exception | 15:09 |
| sean-k-mooney | def _call_cyborg(self, func, *args, **kwargs): | 15:10 |
| sean-k-mooney | resp = err_msg = None | 15:10 |
| sean-k-mooney | try: | 15:10 |
| sean-k-mooney | resp = func(*args, **kwargs) | 15:10 |
| sean-k-mooney | if not resp: | 15:10 |
| sean-k-mooney | msg = _('Invalid response from Cyborg: ') | 15:10 |
| sean-k-mooney | err_msg = msg + str(resp) | 15:10 |
| sean-k-mooney | except ks_exc.ClientException as exc: | 15:10 |
| sean-k-mooney | err_msg = _('Could not communicate with Cyborg.') | 15:10 |
| sean-k-mooney | LOG.exception('%s: %s', err_msg, six.text_type(exc)) | 15:10 |
| sean-k-mooney | ya it should not unless we get like a type error form func | 15:11 |
| sean-k-mooney | ks_exc.ClientException should catch all exception related to the network | 15:11 |
| *** gyee has joined #openstack-nova | 15:13 | |
| *** zhanglong has quit IRC | 15:14 | |
| *** zhanglong has joined #openstack-nova | 15:16 | |
| bauzas | sean-k-mooney: OK, then we're all good | 15:21 |
| bauzas | sean-k-mooney: create a bug and I'll +2 | 15:21 |
| gibi | stephenfin: does the solution for https://review.opendev.org/#/c/718349/3/novaclient/v2/shell.py@1669 is to use different dest for the two flag? | 15:24 |
| sean-k-mooney | bauzas: cool ill do it after downstream call finishes | 15:25 |
| *** zhanglong has quit IRC | 15:27 | |
| melwitt | gibi: hi, I am looking for review on a gate bug fix https://review.opendev.org/717662 "timed out waiting for response from cell" | 15:27 |
| gibi | melwitt: looking | 15:28 |
| melwitt | thanks | 15:32 |
| gibi | melwitt: +2, thanks | 15:34 |
| melwitt | dansmith: you might be interested in reviewing as well? ^ | 15:35 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: Introduce 'pcpuset' field for InstanceNUMACell https://review.opendev.org/714658 | 15:37 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: Introduce the 'CPUAllocationPolicy.MIXED' enum https://review.opendev.org/716267 | 15:37 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: hardware: Add support for 'hw:cpu_dedicated_mask' extra spec https://review.opendev.org/714706 | 15:37 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: computer: validate cpu pinning configuration for mixed instance https://review.opendev.org/716268 | 15:37 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: Calculate the pinned and unpinned CPU usage for mixed instance https://review.opendev.org/716269 | 15:37 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: mark mixed policy as ready, bump compute service version https://review.opendev.org/716271 | 15:37 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: libvirt/hardware: refactor numa_get_constraints https://review.opendev.org/718294 | 15:37 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: Setup 'mixed' instance through 'PCPU' and 'VCPU' resource https://review.opendev.org/713355 | 15:37 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: metadata: export the vCPU IDs that are pinning on the host CPUs https://review.opendev.org/688936 | 15:37 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: online data migration for cpuset of dedicated instance https://review.opendev.org/718493 | 15:37 |
| stephenfin | gibi: For https://review.opendev.org/#/c/718461/2/nova/api/validation/extra_specs/traits.py@65 should I enforce upper-case? | 15:38 |
| gibi | stephenfin: if we don't do that then GET allocation_candidates query will return no canididates during scheduling so I think this needs to be considered as a typo | 15:40 |
| gibi | I'm OK not to have the length requirement enforced that is harder to justify as a typo | 15:40 |
| dansmith | melwitt: ack yep | 15:43 |
| melwitt | danke | 15:43 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix servers policy for admin_or_owner https://review.opendev.org/718501 | 15:47 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix servers policy for admin_or_owner https://review.opendev.org/718501 | 15:48 |
| *** dtantsur|brb is now known as dtantsur | 15:48 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing server policies https://review.opendev.org/718348 | 15:48 |
| dansmith | melwitt: commented on something, if you can link me to that quicker than I can find it that'd be helpful :) | 15:49 |
| melwitt | yeah hang on | 15:50 |
| *** mkrai has joined #openstack-nova | 15:55 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Allow custom traits https://review.opendev.org/718461 | 15:58 |
| stephenfin | gibi: done and done ^ | 15:58 |
| gibi | stephenfin: ack | 15:59 |
| gibi | will review before I leave today | 16:00 |
| *** xek__ has joined #openstack-nova | 16:00 | |
| *** ttsiouts has quit IRC | 16:00 | |
| *** hoonetorg has joined #openstack-nova | 16:01 | |
| *** xek_ has quit IRC | 16:02 | |
| melwitt | dansmith: finally replied. tracing that always confuses me for whatever reason | 16:03 |
| *** xek__ has quit IRC | 16:05 | |
| gibi | stephenfin: does the solution for https://review.opendev.org/#/c/718349/3/novaclient/v2/shell.py@1669 is to use different dest for the two flags? I'm failing to implement mutual exclusivity in 2.85 | 16:09 |
| stephenfin | oh, so error out if e.g. both the 'config_drive' and 'no_config_drive' dests are set? | 16:09 |
| gibi | most probably I've already fried my brain for today | 16:09 |
| stephenfin | that would work | 16:10 |
| stephenfin | let me try it | 16:10 |
| gibi | stephenfin: I let you fix 2.83 while I do similar things for 2.85 | 16:10 |
| stephenfin | ack | 16:10 |
| stephenfin | bauzas: question at https://review.opendev.org/#/c/715489/8/nova/virt/libvirt/driver.py@6953 | 16:10 |
| bauzas | stephenfin: thanks, replying | 16:13 |
| bauzas | stephenfin: replied. | 16:15 |
| *** ociuhandu has quit IRC | 16:16 | |
| *** ociuhandu has joined #openstack-nova | 16:17 | |
| stephenfin | bauzas: cool, thanks for the clarification | 16:18 |
| bauzas | stephenfin: yeah sorry this patch is mostly a cleanup prep work | 16:19 |
| *** ociuhandu has quit IRC | 16:22 | |
| *** rpittau is now known as rpittau|afk | 16:23 | |
| *** psachin has quit IRC | 16:24 | |
| openstackgerrit | Merged openstack/nova master: Introduce scope_types in simple tenant usage https://review.opendev.org/717586 | 16:28 |
| openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: Make 'server list --config-drive' a boolean option https://review.opendev.org/718349 | 16:28 |
| stephenfin | gibi: you'll probably want that for 2.85, assuming you like the approach ^ | 16:28 |
| gibi | ack | 16:28 |
| *** dpawlik has quit IRC | 16:29 | |
| *** nweinber has quit IRC | 16:30 | |
| gibi | stephenfin: +2 | 16:33 |
| stephenfin | \o/ | 16:33 |
| *** evrardjp has quit IRC | 16:37 | |
| *** evrardjp has joined #openstack-nova | 16:37 | |
| gibi | stephenfin: and +2 on both of the extra spec FUPs | 16:37 |
| *** mkrai has quit IRC | 16:40 | |
| bauzas | gibi: stephenfin: sorry I dropped my attention from the issue gibi found (thanks btw.!) but can I take a look at it now ? | 16:43 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Functional test with pGPUs https://review.opendev.org/717975 | 16:43 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: FUP: Support multiple vGPU types https://review.opendev.org/718516 | 16:43 |
| stephenfin | yup, I think so | 16:43 |
| bauzas | gibi: stephenfin: FWIW, I worked the func tests for verifying both types and provided a FUP based on lyarwood's comments ^ | 16:43 |
| bauzas | I totally understand how vGPU in libvirt is old greek, that's why you can ask me for more functional testing if you want | 16:44 |
| bauzas | gibi: FWIW, your reshape test also simulates a Train compute and I didn't had to change this reshape test (except where to call the config) for making it work, which proves I didn't regress | 16:45 |
| bauzas | stephenfin: and ack, will review your last bits before I go | 16:45 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Functional test with pGPUs https://review.opendev.org/717975 | 16:52 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: FUP: Support multiple vGPU types https://review.opendev.org/718516 | 16:52 |
| dansmith | melwitt: so, I didn't go looking, but where's the entrypoint for the thing when we're running underneath a proper WSGI server like apache or nginx? I'm guessing maybe that won't suffer from the same issue because it's forked from the main process before it gets to any nova/oslo stuff, but.. did you confirm? | 16:52 |
| *** xek__ has joined #openstack-nova | 16:53 | |
| melwitt | dansmith: oh, no ... I had looked only at the nova/cmd because I was focused on nova-scheduler. hmm | 16:55 |
| melwitt | but I'd guess the same | 16:55 |
| *** bbowen has quit IRC | 16:56 | |
| dansmith | melwitt: okay one more comment on the wsgi service if you can look | 16:56 |
| openstackgerrit | Balazs Gibizer proposed openstack/python-novaclient master: Microversion 2.85: Change volume-update CLI https://review.opendev.org/712651 | 16:56 |
| dansmith | not related to scheduler of course, but ... | 16:56 |
| *** bbowen has joined #openstack-nova | 16:56 | |
| openstackgerrit | Merged openstack/nova master: partial support for live migration with specific resources https://review.opendev.org/715362 | 16:57 |
| gibi | stephenfin: 2.85 client patch enhanced by following your lead https://review.opendev.org/712651 | 16:57 |
| gibi | and that marks the end of my day. | 16:57 |
| stephenfin | I'm knocking off shortly. Will grab that before then (y) | 16:58 |
| *** xek__ is now known as xek | 16:58 | |
| gibi | see you folks tomorrow o/ | 16:58 |
| melwitt | dansmith: oh, dang, I had meant to add to WSGIService as well but it slipped my mind, likely because WSGIService derives from Service ... but it overrides start() so I need to | 16:58 |
| dansmith | melwitt: yeah | 16:59 |
| melwitt | ok lemme do that. thanks for catching | 16:59 |
| *** derekh has quit IRC | 16:59 | |
| bauzas | gibi: have a good one \o | 16:59 |
| dansmith | melwitt: yeah you'd kinda assume it inherits from Service above, but not so much.. I've been burned by that one before | 17:00 |
| melwitt | oh it doesn't lol ... even THAT burned me | 17:00 |
| melwitt | service.Service vs Service | 17:00 |
| openstackgerrit | Merged openstack/nova master: Pass the actual target in limits policy https://review.opendev.org/715761 | 17:01 |
| stephenfin | bauzas: loads of comments on https://review.opendev.org/#/c/715490/ for the morning | 17:02 |
| bauzas | stephenfin: days are long at home | 17:02 |
| *** yedongcan has left #openstack-nova | 17:03 | |
| openstackgerrit | Merged openstack/nova master: Support live migration with vpmem https://review.opendev.org/687856 | 17:04 |
| bauzas | stephenfin: actually, looking at your comments and trying to get the main problems so I could fix them while you sleep | 17:04 |
| bauzas | you said caching | 17:04 |
| bauzas | but we already cache it per se | 17:04 |
| stephenfin | yeah, for the call to '_get_supported_vgpu_types' | 17:04 |
| bauzas | stephenfin: well, we now lookup self.supported_vgpu_types | 17:05 |
| sean-k-mooney | if you need to cache things use functool.lru_cache decorator | 17:05 |
| bauzas | which is instanciated at startup | 17:05 |
| stephenfin | bauzas: you're right. Sorry, I missed that /o\ | 17:06 |
| bauzas | stephenfin: no worries I'll address your comments tho | 17:06 |
| stephenfin | cool. Happy to toggle when there's a follow up | 17:07 |
| bauzas | stephenfin: I just provided a mapping table lookup method for getting the vgpu type, that's probably what confused you | 17:07 |
| sean-k-mooney | bauzas: you did comment about not wanting to check the config too many times in a respocnc too lee which confused me a bit as ya its only don on agent start | 17:07 |
| *** dtantsur is now known as dtantsur|afk | 17:07 | |
| bauzas | sean-k-mooney: the comment was on the previous patch IIRC | 17:07 |
| bauzas | unless I'm wrong | 17:08 |
| sean-k-mooney | yes | 17:08 |
| *** tesseract has quit IRC | 17:08 | |
| sean-k-mooney | but i have had that in my mind while reviing the followup | 17:08 |
| bauzas | ok, so, the previous patch calls self._get_supported_types N times | 17:08 |
| sean-k-mooney | e.g. that was something you were were concerned about so i am watching for that | 17:08 |
| bauzas | but this patch introduces some startup call that instanciates an object in the driver | 17:08 |
| bauzas | that's not really a cached object | 17:09 |
| bauzas | ie. we don't need to update it | 17:09 |
| bauzas | we just read it once at startup, that's it | 17:09 |
| sean-k-mooney | yep which is fine | 17:09 |
| bauzas | (and that's how folks I tried to avoid the known issue of cache invalidation) | 17:09 |
| *** ociuhandu has joined #openstack-nova | 17:10 | |
| sean-k-mooney | yep but use to reiterate if people feel they need cacheing of functions now that we can depend on being python 3 we shoudl use https://docs.python.org/3/library/functools.html#functools.lru_cache | 17:11 |
| bauzas | sean-k-mooney: gtk | 17:11 |
| * bauzas looks | 17:11 | |
| bauzas | ah, interesting | 17:12 |
| sean-k-mooney | there is a backport in cachetools which is technically in the requirements repo but i never felt there was a justification for using it in nova as an extra dep | 17:12 |
| bauzas | but I wouldn't use it for simple dicts | 17:12 |
| bauzas | yeah, it's intended for large dicts with high access rate | 17:13 |
| bauzas | hence the name FWIW | 17:13 |
| bauzas | sean-k-mooney: and honestly, maybe just worth it for nova-api | 17:14 |
| sean-k-mooney | there are other places where it makes sense | 17:14 |
| sean-k-mooney | if we ever think maybe we should add a cache and go to add a maunal modle level dict | 17:14 |
| sean-k-mooney | we shoudl see if this can be used instead | 17:14 |
| *** priteau has quit IRC | 17:15 | |
| *** ociuhandu has quit IRC | 17:16 | |
| sean-k-mooney | for example this would be good for caching the pci whitelist parsing | 17:16 |
| sean-k-mooney | we currently parse it over and over again in the periodics but we dont have too | 17:17 |
| sean-k-mooney | its not a muteable config option but the patches to intoduced that were consider too trival to merge for the extra code of doing it manallly | 17:17 |
| sean-k-mooney | jsut adding a decorator however is much lighter weight | 17:18 |
| bauzas | sean-k-mooney: maybe, at least just having some object in memory isn't crazy | 17:25 |
| bauzas | sean-k-mooney: I was more talking about using this lib, which is intended for high frequency rates, which isn't the case | 17:25 |
| sean-k-mooney | bauzas: https://pypi.org/project/cachetools/ that one | 17:26 |
| bauzas | ah ok | 17:27 |
| * bauzas bails out for dinner, but will be around later | 17:27 | |
| sean-k-mooney | it would have been perfect for https://review.opendev.org/#/c/599071/ | 17:27 |
| bauzas | (like the two other nights) | 17:27 |
| sean-k-mooney | bauzas: o/ | 17:27 |
| bauzas | gosh, I missed working upstream... | 17:27 |
| sean-k-mooney | i shoudl really go back and replace that and the other memorize decoratos at some point | 17:29 |
| *** nweinber has joined #openstack-nova | 17:31 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Reset the cell cache for database access in Service https://review.opendev.org/717662 | 17:55 |
| *** xek_ has joined #openstack-nova | 17:56 | |
| melwitt | dansmith: finally updated ^ I spun around for awhile trying to find a way to restart the func test nova-api service (OSAPIFixture) before concluding that it doesn't leverage the WSGIService in any way. so I instead used the OSMetadataServer fixture | 17:56 |
| *** xek has quit IRC | 17:58 | |
| *** ralonsoh has quit IRC | 18:01 | |
| *** nightmare_unreal has quit IRC | 18:14 | |
| *** avolkov has quit IRC | 18:24 | |
| *** ociuhandu has joined #openstack-nova | 18:26 | |
| *** mriedem has joined #openstack-nova | 18:29 | |
| *** kaisers_ has quit IRC | 18:31 | |
| openstackgerrit | Merged openstack/nova master: Correct server topology policy check_str https://review.opendev.org/717525 | 18:49 |
| *** slaweq_ has joined #openstack-nova | 18:59 | |
| *** slaweq has quit IRC | 19:00 | |
| *** maciejjozefczyk has quit IRC | 19:24 | |
| openstackgerrit | Merged openstack/nova master: Separate update and swap volume policies https://review.opendev.org/711194 | 19:32 |
| openstackgerrit | Merged openstack/nova master: Fix server metadata policy to be admin_or_owner https://review.opendev.org/717189 | 19:32 |
| openstackgerrit | Merged openstack/nova master: Add test coverage of existing server metadata policies https://review.opendev.org/717182 | 19:32 |
| openstackgerrit | Merged openstack/nova master: Introduce scope_types in server metadata https://review.opendev.org/717215 | 19:32 |
| openstackgerrit | Merged openstack/nova master: Add new default roles in server metadata policies https://review.opendev.org/717255 | 19:32 |
| *** vishalmanchanda has quit IRC | 19:32 | |
| *** tbachman has quit IRC | 19:41 | |
| openstackgerrit | Merged openstack/nova master: Add release notes for Cyborg-Nova integration. https://review.opendev.org/716185 | 19:50 |
| *** tbachman has joined #openstack-nova | 19:59 | |
| *** ccamacho has quit IRC | 20:08 | |
| melwitt | gibi: I had to respin https://review.opendev.org/717662 to add a cache clearing to WSGIService, if you could pls re-review when you get a chance | 20:16 |
| *** igordc has quit IRC | 20:17 | |
| *** igordc has joined #openstack-nova | 20:18 | |
| *** xek_ has quit IRC | 20:44 | |
| *** jraju__ has quit IRC | 21:07 | |
| *** nweinber has quit IRC | 21:15 | |
| *** mriedem has left #openstack-nova | 21:24 | |
| *** slaweq_ has quit IRC | 21:38 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Support different vGPU types per pGPU https://review.opendev.org/715490 | 21:57 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Functional test with pGPUs https://review.opendev.org/717975 | 21:57 |
| *** iurygregory has quit IRC | 22:09 | |
| *** slaweq_ has joined #openstack-nova | 22:13 | |
| *** martinkennelly has quit IRC | 22:25 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing server policies https://review.opendev.org/718348 | 22:28 |
| *** rcernin has joined #openstack-nova | 22:32 | |
| *** gyee has quit IRC | 22:49 | |
| *** threestrands has joined #openstack-nova | 23:10 | |
| *** tosky has quit IRC | 23:20 | |
| *** gary_perkins has quit IRC | 23:26 | |
| *** gary_perkins has joined #openstack-nova | 23:32 | |
| lbragstad | gmann https://review.opendev.org/#/c/717943/2 looks good to me - i tested it locally | 23:50 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!