Monday, 2020-05-04

*** spatel has quit IRC00:04
*** Nel1x has joined #openstack-nova00:14
*** ociuhandu has joined #openstack-nova00:26
openstackgerritGhanshyam Mann proposed openstack/nova stable/ussuri: Add nova-status upgrade check and reno for policy new defaults  https://review.opendev.org/72514600:27
*** ociuhandu has quit IRC00:36
*** ociuhandu has joined #openstack-nova00:38
*** ociuhandu has quit IRC00:43
openstackgerritGhanshyam Mann proposed openstack/nova stable/train: DNM: testing what all grenade jobs running  https://review.opendev.org/72514700:57
*** gregwork has quit IRC01:33
*** hemna has quit IRC01:41
*** hemna has joined #openstack-nova01:42
*** spatel has joined #openstack-nova01:50
*** spatel has quit IRC01:54
*** tetsuro has joined #openstack-nova02:04
*** spatel has joined #openstack-nova02:23
alex_xusean-k-mooney: gibi fyi, we will have someone working on provider config xml.02:33
*** tetsuro has quit IRC02:33
*** sapd1_x has joined #openstack-nova03:12
*** sapd1_x has quit IRC03:17
*** sapd1_x has joined #openstack-nova03:31
*** mkrai has joined #openstack-nova03:32
*** psachin has joined #openstack-nova03:33
*** jangutter has quit IRC03:44
*** jangutter has joined #openstack-nova03:45
*** ociuhandu has joined #openstack-nova03:56
*** ociuhandu has quit IRC04:02
*** lbragstad has quit IRC04:10
*** ratailor has joined #openstack-nova04:31
*** evrardjp has quit IRC04:35
*** evrardjp has joined #openstack-nova04:36
*** sapd1_x has quit IRC04:40
*** udesale has joined #openstack-nova04:42
*** sapd1_x has joined #openstack-nova04:54
*** jmlowe has quit IRC05:00
*** spatel has quit IRC05:01
*** jmlowe has joined #openstack-nova05:02
openstackgerritTakashi Natsume proposed openstack/python-novaclient master: [WIP] Switch legacy Zuul jobs to native Zuul v3 jobs  https://review.opendev.org/72516305:08
*** ociuhandu has joined #openstack-nova05:23
*** ociuhandu has quit IRC05:33
*** Nel1x has quit IRC05:37
*** vishalmanchanda has joined #openstack-nova05:43
*** dpawlik has joined #openstack-nova06:04
*** dpawlik has quit IRC06:04
*** dpawlik has joined #openstack-nova06:07
*** dpawlik has quit IRC06:07
*** dpawlik has joined #openstack-nova06:08
*** slaweq has joined #openstack-nova06:13
*** ratailor has quit IRC06:19
*** ratailor has joined #openstack-nova06:19
*** rchurch has quit IRC06:31
*** rchurch has joined #openstack-nova06:32
*** rpittau|afk is now known as rpittau06:33
*** ociuhandu has joined #openstack-nova06:38
*** ircuser-1 has quit IRC06:42
*** belmoreira has joined #openstack-nova06:54
gibialex_xu: ack, thanks06:55
*** sapd1_x has quit IRC07:18
*** ccamacho has joined #openstack-nova07:23
*** mkrai has quit IRC07:24
*** sapd1_x has joined #openstack-nova07:30
*** tosky has joined #openstack-nova07:32
*** xek has joined #openstack-nova07:33
*** jsuchome has joined #openstack-nova07:42
*** ociuhandu has quit IRC07:51
*** mkrai has joined #openstack-nova07:55
*** ociuhandu has joined #openstack-nova08:00
*** nightmare_unreal has joined #openstack-nova08:00
*** sapd1_x has quit IRC08:20
gibistephenfin: hi! Do you have an idea why the reno job fails on this backport to stable/ussuri? https://review.opendev.org/#/c/725146/1 It is green for me locally but locally the releasenotes tox target does not try to generate stable/ussuri notes08:33
*** sapd1_x has joined #openstack-nova08:34
*** dtantsur|afk is now known as dtantsur08:43
*** udesale has quit IRC08:49
bauzasgibi: me looks08:56
bauzasgibi: I don't see any problems with the reno file itself, just testing it locally08:59
bauzas  Warning, treated as error: <reno.sphinxext stable/ussuri>:115:Duplicate target name, cannot be used as a unique reference: "upgrade notes".08:59
bauzasthat's why we get -1 ^09:00
*** salmankhan has joined #openstack-nova09:00
bauzasahah I think we probably have something missing https://docs.openstack.org/reno/latest/user/usage.html#updating-stable-branch-release-notes09:03
bauzas"Occasionally it is necessary to update release notes for past releases due to URLs changing or errors not being noticed until after they have been released. In cases like these, it is important to note that any updates to these release notes should be proposed directly to the stable branch where they were introduced."09:03
*** salmankhan1 has joined #openstack-nova09:04
*** salmankhan has quit IRC09:05
*** salmankhan1 is now known as salmankhan09:05
* bauzas reads https://docs.openstack.org/project-team-guide/release-management.html#how-to-preview-release-notes-at-rc-time09:05
bauzasok, so, relnotes are correctly written against master, but cherry-picking the change to my local stable/ussuri branch and retesting09:11
bauzasI think I found the problem09:11
* bauzas needs to reproduce 09:11
*** ttsiouts has joined #openstack-nova09:12
bauzasgibi: we don't have *yet* ussuri release notes so reno writes the patch note against master twice09:12
bauzashence the duplicate09:12
bauzasagainst 'unreleased' rather09:12
bauzaslemme see if creating a ussuri.rst file would help09:13
gibibauzas: thanks for helping, I'm sitting on a meeting09:14
bauzasok, we have https://github.com/openstack/nova/blob/master/releasenotes/source/ussuri.rst09:14
bauzasin master09:14
bauzaswhich is normal09:14
bauzasgibi: np09:14
bauzasgibi: i think I have some potential findings but I need to test09:15
bauzasand it takes a while to generate the relnotes locally as it scans all my branches09:15
gibiyeah it is slow09:16
bauzasinteresting09:16
bauzasit did worked fine on my box09:16
bauzasinterestingly, my current branch is ussuri when i'm testing on a local stable/ussuro09:18
bauzaswhich is not the case with the job https://zuul.opendev.org/t/openstack/build/9c4f698044dc4af2b5bcb326b6a3e823/log/job-output.txt09:18
gibiyeah, I also cannot reproduce the problem locally09:20
*** lpetrut has joined #openstack-nova09:25
*** udesale has joined #openstack-nova09:27
*** jangutter has quit IRC09:32
bauzasgibi: maybe a job issue09:35
gibibauzas: interestingly the job tries to generate reno for stable/ussuri the local tox target does not try that for me09:36
gibilocally I get09:38
gibiscanning /home/gibizer/upstream/git/nova/releasenotes/notes for current branch release notes09:38
gibigot versions []09:38
gibiin the job09:39
gibi2020-05-04 07:58:23.877287 | ubuntu-bionic | scanning /home/zuul/src/opendev.org/openstack/nova/releasenotes/notes for current branch release notes09:39
gibi2020-05-04 07:59:02.632023 | ubuntu-bionic | got versions ['21.0.0.0rc1-16']09:39
gibi2020-05-04 07:59:02.664924 | ubuntu-bionic | reading sources... [100%] ussuri09:39
gibi2020-05-04 07:59:02.670555 | ubuntu-bionic | scanning /home/zuul/src/opendev.org/openstack/nova/releasenotes/notes for stable/ussuri release notes09:39
gibi2020-05-04 08:00:13.350874 | ubuntu-bionic | got versions ['21.0.0.0rc1-5', '21.0.0.0rc1']09:39
bauzaslemme doublecheck mine09:41
gibiare these versions '21.0.0.0rc1-5' are git tags?09:41
gibiI only have 21.0.0.0rc1 tag09:41
bauzasgibi: that's my env http://paste.openstack.org/show/793033/09:42
bauzasgibi: I branched stable/ussuri and cherry-picked the change into it09:42
bauzasgibi: yup, AFAIR, reno works with git commits and tags09:43
gibiit is pretty similar to mine except you have got versions ['21.0.0.0rc1-5']09:43
bauzaswhich is expected09:43
bauzasgibi: if I tag my branch as 21.0.1 per se09:44
bauzasgibi: then you'll be seeing it09:44
bauzasgibi: see https://docs.openstack.org/project-team-guide/release-management.html#how-to-preview-release-notes-at-rc-time09:44
bauzasgibi: remember that reno tries to see which tags are related to which releasenotes09:45
bauzasonce you tag a .z version, then you'll see it09:45
*** ttsiouts has quit IRC09:46
gibibauzas: does it mean that the gate job temporarly tag the repo and then generate the notes?09:46
bauzasI don't think so09:47
gibiOK. I'm lost :)09:47
* bauzas just tagged a fake 21.0.1 09:47
bauzasand see whether reno finds it09:48
gibiok09:48
bauzaswe need dhellmann or someone else from the reno team IMHO09:48
bauzasgibi: what's not normal is that we scan both the current branch and the stable/ussuri one09:49
bauzas(against a stable/ussuri change)09:50
bauzasbecause both are identical09:50
bauzasgibi: you understand this ?09:50
gibiI accept this as a probable problem. I just blocked by the fact that I cannot reproduce the result locally09:50
bauzashttps://zuul.opendev.org/t/openstack/build/9c4f698044dc4af2b5bcb326b6a3e823/log/job-output.txt#1415 and https://zuul.opendev.org/t/openstack/build/9c4f698044dc4af2b5bcb326b6a3e823/log/job-output.txt#1418 generate the same09:50
bauzasgibi: yeah, me too09:51
*** ociuhandu has quit IRC09:51
*** ociuhandu has joined #openstack-nova09:52
bauzasgibi: what we could do is trying to avoid to present the upgrade note in master09:54
bauzasgibi: I can try to provide a DNM for testing09:54
bauzasgibi: actually, the upgrade note is invalid for Victoria, right ?09:55
bauzasgibi: see what happens when you tag locally : http://paste.openstack.org/show/793034/09:56
*** ociuhandu has quit IRC09:57
bauzasgibi: and by looking at my html build, I see the note, yeepee09:57
bauzas(marked against my fake 21.0.1)09:57
gibiso locally it is still not generate notes for stable/ussuri09:57
bauzasit does09:57
bauzasbut as 'unreleased'09:58
bauzassee https://docs.openstack.org/releasenotes/nova/unreleased.html09:58
bauzasgibi: this is bad ^09:58
bauzasbecause the upgrade issue is when you upgrade from Train to Ussuri, right?09:58
gibibauzas: so we have to remove the reno from master (V)?09:58
bauzasgibi: we'll ignore it09:59
bauzashttps://docs.openstack.org/project-team-guide/release-management.html#updating-stable-branch-release-notes09:59
bauzasgibi: I'm just forging a :ignore-notes: directive10:00
gibiahh10:00
gibithanks10:00
*** ociuhandu has joined #openstack-nova10:00
gibiso we need the ignore-notes patch on master?10:01
bauzasI *think*10:01
bauzasgibi: we wrote it for the T->U upgrade, right?10:01
gibiright10:01
bauzasok, so let's ignore it or it will appear in the 22.0.0 relnotes10:01
gibiwe just merged it first on master10:01
gibiand then backport10:02
bauzasgibi: sure, i understood but reno files are different10:02
gibiyeah, I get to feel that10:02
gibi:)10:02
bauzasgibi: see the warnings in the reno docs :)10:02
bauzasif you wanna fix some specific reno file on a stable branch, you need to make it a stable-only change10:02
bauzasmy reno skills are rusty and I forgot to warn this10:03
gibiso the good first solution would have been not to add reno for the policy upgrade check on master just in the backport to stable/ussuri10:03
bauzasgibi: yup10:03
bauzasMay 1st killed my productivity10:03
*** ralonsoh has joined #openstack-nova10:03
bauzasgibi: and tbc, git deleting a YAML file is bad10:04
gibibauzas: you mean that we should not fix the issue with a partial revert on master that would delete the reno file but use ignore-notes instead10:04
bauzasgibi: yep10:04
* gibi learns every day10:05
bauzasgibi: I can't remember why this is bad, but I think it's because reno walks above every commit and generates10:05
*** rpittau is now known as rpittau|bbl10:14
openstackgerritSylvain Bauza proposed openstack/nova master: Don't show upgr note for policy validation in V  https://review.opendev.org/72522610:28
bauzasgibi: ^10:29
gibilooking10:29
bauzashopefully it should fix the issue10:29
bauzasI tested locally and the note isn't appearing10:29
bauzasthen we should recheck10:30
bauzasthe stable/ussuri change10:30
gibibauzas: so we merge your ignore patch then recheck the stable/ussuri backport10:31
bauzaswe can try at least10:31
bauzasif you feel brave enough to fast approve it...10:31
gibidoes lyarwood off today too?10:32
* gibi goes to lunch10:33
bauzasgibi: he's a bit off and on10:34
bauzasstephenfin: if you mind approving this one quickly https://review.opendev.org/#/c/725226/110:36
bauzaswe need it in order to unfuck https://review.opendev.org/#/c/725146/ which is holding RC210:37
*** ttsiouts has joined #openstack-nova10:48
*** avolkov has joined #openstack-nova10:52
zigoMy PR here is not good. I've been asked to add a functional test, I tried copying it from the Keystone one but failed. Can anyone help ?11:00
zigohttps://review.opendev.org/72468411:00
zigobauzas: ^11:00
zigo:)11:00
zigoIMO, it's in the wrong place (he: where CORS is tested), and not doing the right thing. My intention is that it only checks the HTTP 200 return, which is the only thing that should be tested...11:01
zigoI'd love to have a easy way to functional test this that I could copy in all projects later on.11:02
*** kevinz has quit IRC11:04
*** mkrai has quit IRC11:07
*** slaweq_ has joined #openstack-nova11:18
*** slaweq has quit IRC11:21
*** ttsiouts has quit IRC11:28
*** ociuhandu has quit IRC11:29
*** ociuhandu has joined #openstack-nova11:30
*** ttsiouts has joined #openstack-nova11:30
*** ociuhandu has quit IRC11:35
*** ttsiouts has quit IRC11:36
*** ttsiouts has joined #openstack-nova11:38
*** nweinber has joined #openstack-nova11:45
*** raildo has joined #openstack-nova11:58
*** ttsiouts has quit IRC12:03
*** bbowen has joined #openstack-nova12:04
bauzaszigo: I'm not a paste specialist, but maybe you should add it to https://review.opendev.org/#/c/724684/5/etc/nova/api-paste.ini@L7812:06
*** mkrai has joined #openstack-nova12:09
zigobauzas: The issue is only the functional test, not the api-paste.ini which i tested.12:10
*** ociuhandu has joined #openstack-nova12:11
bauzaszigo: then I guess requests is not using parse12:13
bauzasahah, we have an APIPasteFixture object :)12:15
bauzasbingo12:16
bauzaszigo: ^12:16
*** sapd1_x has quit IRC12:16
bauzaszigo: look at this https://github.com/openstack/nova/blob/master/nova/tests/functional/api_paste_fixture.py#L51-L5912:17
*** ttsiouts has joined #openstack-nova12:17
*** ociuhandu has quit IRC12:17
*** eharney has joined #openstack-nova12:20
*** rpittau|bbl is now known as rpittau12:22
bauzaszigo: you should probably pdb the fixture to see what you get as paste.ini12:25
zigoOk.12:26
* zigo is in a meeting.12:26
*** ociuhandu has joined #openstack-nova12:30
*** ttsiouts has quit IRC12:37
*** udesale_ has joined #openstack-nova12:38
*** udesale has quit IRC12:41
*** hemna has quit IRC12:44
*** hemna has joined #openstack-nova12:44
bauzasoh but today is a bank holiday in Ireland12:49
bauzasstephenfin: my bad12:49
bauzasstephenfin: my badhttps://review.opendev.org/#/c/725226/ ?12:50
bauzasI can +W it12:50
bauzaslyarwood: around maybe ?12:50
*** mkrai has quit IRC12:52
*** cz3 is now known as poweredgelord12:53
*** spatel has joined #openstack-nova12:53
*** poweredgelord is now known as cz312:57
bauzaszigo: fwiw, pdb'ing 72468413:01
*** jamesden_ is now known as jamesdenton13:07
*** lbragstad has joined #openstack-nova13:07
*** mkrai has joined #openstack-nova13:08
*** lbragstad has quit IRC13:08
*** lbragstad has joined #openstack-nova13:12
*** ttsiouts has joined #openstack-nova13:14
*** psachin has quit IRC13:14
*** ttsiouts has quit IRC13:18
*** ociuhandu has quit IRC13:20
*** ociuhandu has joined #openstack-nova13:21
*** tbachman has joined #openstack-nova13:21
*** hemna has quit IRC13:23
*** hemna has joined #openstack-nova13:24
*** ociuhandu has quit IRC13:25
*** KeithMnemonic has joined #openstack-nova13:31
bauzaszigo: ah, I think I found the problem13:33
zigo:)13:33
* zigo is still in a meeting, but soon finished...13:34
bauzaszigo: http://paste.openstack.org/show/793050/13:34
bauzaslooks like it tries to call a /v2 endpoint13:34
zigoOh ! :)13:34
zigoIt should be just /healthcheck indeed...13:35
zigoAnd probably without any auth as well.13:35
*** hemna has quit IRC13:36
*** hemna has joined #openstack-nova13:36
*** ociuhandu has joined #openstack-nova13:36
*** ralonsoh has quit IRC13:37
*** artom has joined #openstack-nova13:37
openstackgerritFrançois Palin proposed openstack/nova stable/rocky: Add retry to cinder API calls related to volume detach  https://review.opendev.org/72527213:38
*** salmankhan1 has joined #openstack-nova13:39
*** salmankhan has quit IRC13:40
*** salmankhan1 is now known as salmankhan13:40
*** hemna has quit IRC13:43
*** hemna has joined #openstack-nova13:43
*** mkrai has quit IRC13:44
zigobauzas: What's the way to make it not prefix the URL then?13:48
bauzasagain, I'm not an API specialist unfortunately13:48
bauzasI can't really answer why we transform this URL13:49
*** lpetrut has quit IRC13:49
bauzasbut lemme try something13:49
*** ralonsoh has joined #openstack-nova13:49
bauzasahah found13:51
bauzashttps://github.com/openstack/nova/blob/master/nova/tests/functional/api/client.py#L14713:51
zigostrip_version=True and I'm good to go?13:52
*** hemna has quit IRC13:53
*** ratailor has quit IRC13:53
*** hemna has joined #openstack-nova13:54
bauzaszigo: fwiw, I just tested to call 'http://728dd5ee-0231-4919-b991-a21cae822084:80/healthcheck' and I got a 200 :)13:54
bauzasjust trying strip_version13:54
zigo:)13:54
zigoThanks.13:54
zigoTrying.13:54
bauzasgot a 30013:55
bauzasthat's... fun :)13:55
openstackgerritThomas Goirand proposed openstack/nova master: Add a /healthcheck URL  https://review.opendev.org/72468413:55
bauzaszigo: hold your change13:56
bauzasit won't work (yet)13:56
bauzasahah !13:58
bauzas> /home/sbauza/git/openstack/nova/nova/tests/functional/api/client.py(172)api_request()13:58
bauzas-> response = self.request(full_uri, **kwargs)13:58
bauzas(Pdb) full_uri13:58
bauzas'http://94193b57-ca75-4e13-9d4c-2cc961eeaf5b:80/6f70656e737461636b20342065766572//healthcheck'13:58
bauzas(Pdb) n13:58
bauzaswe don't want the project here13:58
bauzas(Pdb) good_uri = 'http://94193b57-ca75-4e13-9d4c-2cc961eeaf5b:80/healthcheck'13:59
bauzas(Pdb) self.request(good_uri, **kwargs).status_code13:59
bauzas20013:59
bauzaszigo: ^13:59
*** ttsiouts has joined #openstack-nova14:01
*** huaqiang has quit IRC14:02
bauzaszigo: found how to solve it14:03
bauzaszigo: https://github.com/openstack/nova/blob/master/nova/tests/fixtures.py#L93114:03
openstackgerritThomas Goirand proposed openstack/nova master: Add a /healthcheck URL  https://review.opendev.org/72468414:03
bauzaszigo: stop eating our CI resources, please :)14:04
zigoWill do ! :)14:04
bauzaszigo: I'm close to the resolution14:04
bauzaszigo: I can propose a revision if you're okay with ?14:05
zigoSure, thanks !14:05
*** huaqiang has joined #openstack-nova14:05
bauzaszigo: ok, I'll just propose another test class14:05
*** ttsiouts has quit IRC14:06
zigoIndeed, it's probably fine in this file, but not the same class, I thought about fixing that too !14:09
*** mriedem has joined #openstack-nova14:15
gibimelwitt: you looked at this bug report before: https://bugs.launchpad.net/nova/+bug/1818671 There are some new data in there. I looked at it. I cannot reproduce it on master and the bugfix that seems relevant backported to the version of used by the last commenter14:17
openstackLaunchpad bug 1818671 in OpenStack Compute (nova) "Openstack usage list not showing all projects" [Undecided,New]14:17
gibimelwitt: I don't have a queens devstack at hand. Do you have any idea what fixed the problem since Queens?14:18
bauzaszigo: I'm done with your change14:28
bauzaszigo: it works locally14:28
bauzaszigo: but I'd like to add a negative test14:28
bauzaszigo: how can I fake healthcheck to say "sorry but no" ?14:29
zigobauzas: Of what kind? What will you negatively test?14:29
zigoOh...14:29
* bauzas reading oslo.middleware documentation14:30
openstackgerritDoug Hellmann proposed openstack/nova master: increase verbose level for release notes build  https://review.opendev.org/72529014:33
bauzasok, nevermind, you haven't enabled the disabled_per_file option14:34
bauzaswill just verify the JSON output14:35
*** ttsiouts has joined #openstack-nova14:36
bauzasahah, very interesting14:37
bauzas/home/sbauza/git/openstack/nova/.tox/functional/lib/python3.7/site-packages/paste/deploy/util.py:55: DeprecationWarning: Using function/method 'Healthcheck.factory()' is deprecated: The healthcheck middleware must now be configured as an application, not as a filter14:37
zigobauzas: I don't see any reason why it would be needed, but yeah, we could set /etc/nova/disable_healthcheck by default.14:37
bauzaszigo: let's not overthink this14:37
zigoOh ! :)14:37
bauzasthis being said, see the deprecation warning above14:37
zigoI've seen it as an app somewhere.14:37
bauzaszigo: https://github.com/openstack/oslo.middleware/blob/2e56b4379ab5a8bd5c42e885253c81d2a5f021c2/oslo_middleware/healthcheck/__init__.py#L242-L24814:38
bauzaszigo: just amending my revision14:38
zigoThanks a lot for all of this, this will really be helpful for operators.14:39
zigoTypically, in haproxy, you'd setup:14:40
zigobackend novabackend14:40
zigo  option httpchk GET /healthcheck14:40
zigoIf you don't, then you get crap in the nova-api.log ...14:40
zigoAs in, haproxy tries to open the connection, does no request, and close the connection, which is *very* hugly.14:40
gmannbauzas: i feel we can keep those upgrade notes for V upgrade also as we will remove the old defaults in W cycle  (along with U)- https://review.opendev.org/#/c/725226/114:45
bauzaszigo: okay, you know what ? I can't really help on the paste issue, but I'll upload my new rev14:47
bauzaszigo: then you can ask gmann or other API specialists to look at your paste config14:47
*** mlavalle has joined #openstack-nova14:48
*** ttsiouts has quit IRC14:48
openstackgerritSylvain Bauza proposed openstack/nova master: Add a /healthcheck URL  https://review.opendev.org/72468414:51
bauzaszigo: okay, I left the deprecated usage but the functional test should work14:52
bauzaszigo: this being said, I'll -1 because of the deprecation usage, please try to look at it14:52
zigoWill do, let's first wait to see if it passes the gate.14:53
bauzaszigo: it will :14:55
bauzasfunctional run-test: commands[1] | stestr slowest14:55
bauzasTest id                                                                           Runtime (s)14:55
bauzas--------------------------------------------------------------------------------  -----------14:55
bauzasnova.tests.functional.test_middleware.TestHealthCheckMiddleware.test_healthcheck  4.46014:55
bauzas__________________________________________________________________________________________________________________ summary ___________________________________________________________________________________________________________________14:55
bauzas  functional: commands succeeded14:55
bauzas  congratulations :)14:55
*** dhellmann has joined #openstack-nova14:58
dhellmannbauzas : o/14:58
artombauzas, zigo, also, since you're collaborating on that patch, reno and docs plz :)14:58
bauzasdhellmann: thanks for joining :)14:58
bauzasartom: I just helped zigo with his functest issue, nothing really important14:58
bauzasnow back on the RC2 holding bug14:58
dhellmannI think the fix for the issue is to change the way the prelude links to the upgrade notes section, but I'm not sure of the best way to do that because you're in the middle of the RCs14:58
bauzasdhellmann: ah, that's because we made an implicit target?14:59
dhellmannafter a final release, the rc sections are collapsed into that final version number, so the link targets change14:59
dhellmannyes14:59
dhellmannI'm experimenting with a fix locally14:59
bauzasdhellmann: so https://review.opendev.org/#/c/725226/ wouldn't help with the issue ?14:59
*** ttsiouts has joined #openstack-nova14:59
bauzas(sorry, got dragged from a bit)15:00
bauzasgibi: you could be interested in this15:00
bauzasdhellmann: we honestly used the implicit target for the prelude a lot of times15:01
bauzasdhellmann: and i don't understand why it would be a problem due to https://review.opendev.org/#/q/Id9cd65877e53577bff22e408ca07bbeec4407f6e15:01
gmannyeah that was i am wondering as it merged previous notes or section without comlain15:02
dhellmannbauzas : no, that patch won't fix it. you might want that change anyway, but that's not the problem.15:02
dhellmannbauzas : the problem is that with gmann's patch there are now 2 sections on the same page with the same title, so sphinx doesn't know which one you want to link to15:02
dhellmannafter the final release is tagged, they will be collapsed into 1 section, which is probably what you've seen on other releases15:03
dhellmannand the problem is not really that there are 2 sections, it is that there are *links* to those sections in the text15:03
jsuchomedansmith: Hi again, I rebased https://review.opendev.org/#/c/572805 and https://review.opendev.org/#/c/574301/ , could I get some reviews, please?15:03
dhellmannso sphinx has to resolve where those links should go15:03
bauzasdhellmann: looking at the paste you provided15:04
bauzasokay, I *think* I understand15:05
bauzasby merging gmann's patch, we're creating a new section15:06
dhellmannright15:06
dansmithjsuchome: I had feedback, so addressing that is necessary in addition to just rebasing it15:06
dhellmannsheesh, there are a lot of changes in nova :-) generating the release notes takes ages15:07
gmanndhellmann: should not merge section happen when it is release say rc2 version relese? and till then anything new goes into unreleased section instead of ussuri release section ?15:10
dhellmannI think I have a fix, give me a sec to rebase15:10
gmanndhellmann: ok, thanks15:11
* gibi reads back15:11
gmannbauzas: dhellmann may be i could have edited the existing reno instead of new so that it would conflict but that just hides this issue does not solve.15:12
gmannbauzas: gibi i was searching and could not find any such issue (where new reno added in rc) for train and stein rc.15:13
*** ttsiouts has quit IRC15:15
gibihonestly I can only agree what you found with the reno problem but I cannot give to that discussion. I hope dhellmann's fix will help15:17
*** ttsiouts has joined #openstack-nova15:19
openstackgerritDoug Hellmann proposed openstack/nova stable/ussuri: Add nova-status upgrade check and reno for policy new defaults  https://review.opendev.org/72514615:19
openstackgerritDoug Hellmann proposed openstack/nova stable/ussuri: use more distinct link references in release notes  https://review.opendev.org/72530115:19
dhellmannlet's see if ^ helps15:19
jsuchomedansmith: well, yeah, I'm not sure how to address it. Are you suggesting some different path then using this formerly deprecated entry point? As I'm not the creator of the original code I would rather not rework it completely...15:22
dhellmanngibi : sphinx is like a compiler & linker for docs instead of for code. If there are 2 sections on a page with the same name, that's like having 2 functions in a module with the same name. Sphinx can't figure out which one you want to link to.15:22
gibidhellmann: thanks. and also thanks for fixing it15:23
dansmithjsuchome: yes, I'm not okay with undeprecating that hook mechanism just to add something in-tree for it15:23
dhellmannthis is only related to reno because it's assembling the notes files into rst for sphinx. the same error could have happened if the text had been written by hand15:23
*** gyee has joined #openstack-nova15:25
*** ttsiouts has quit IRC15:29
*** belmoreira has quit IRC15:29
gibidhellmann: so your patch can fix it as it changes the references current pointing to the ambiguous title to point to some specific title that is not duplicated by gmann's recent patch15:30
dhellmannthat's right15:31
gmanndhellmann: thanks for fixing. and that did not complain in original change because Sphinx already merged the Upgrade Section - https://review.opendev.org/#/c/725301/1/releasenotes/notes/ussuri-prelude-4b96f1244cefcdf4.yaml15:31
dhellmannthe patch isn't quite right (it failed locally) but it's a different error15:31
bauzassorry was in a meeting15:31
gmanndhellmann: any way Sphinx can error or warning for using implicit links at least for same link in same page? just for future so that it can be fixed in original change itself.15:32
dhellmanngood question. I don't know.15:33
dhellmannthere's a `reno lint` command, maybe that's a check it could do?15:33
bauzasI'm a bit afraid of https://review.opendev.org/#/c/725301/ because it would be a bit more difficult for people to provide their own reno notes15:33
gmanndhellmann:  ok. let me try sometime later.15:34
bauzasbut we're close to RC2 so I wouldn't be picky15:34
dhellmannanother possible improvement for reno is to have it automatically add unique anchors for each file so that the prelude could have used those anchor names15:34
dhellmannthe problem with that is that the same note can appear in multiple series (backports) so you can't just use the filename15:35
bauzasdhellmann: gmann: gibi: if you wanna get MHO, I'd just prefer to https://review.opendev.org/#/c/725146/2/releasenotes/notes/bug-1875418-0df3198e36530ec7.yaml to just amend an existing upgrade note instead of creating this YAML file15:36
gmanndhellmann:  yeah, asking for explicit anchor is much safe in case of backporting things.15:36
bauzaswe could leave some placeholder YAML file for backports15:36
bauzasthis would be simplier to manage rather than explicit sphinx targets15:36
dhellmannbauzas : the whole point of reno is you don't have to do that sort of thing15:36
bauzasI know :(15:37
gmannbauzas: but that does not solve the whole things, same issue can occur for any new reno while backport15:37
dhellmannanother fix would be to remove the links in the prelude entirely15:37
gibibauzas: would you like to do that change on master first to keep the reno (even if it is ignored) in sync between branches?15:37
bauzasgibi: which change ?N15:38
gibibauzas: ammending the existing upgrade reno instead of adding a new one15:38
*** ociuhandu has quit IRC15:38
openstackgerritDoug Hellmann proposed openstack/nova stable/ussuri: use more distinct link references in release notes  https://review.opendev.org/72530115:38
openstackgerritDoug Hellmann proposed openstack/nova stable/ussuri: Add nova-status upgrade check and reno for policy new defaults  https://review.opendev.org/72514615:38
dhellmannok, I think ^ solves it15:39
*** ociuhandu has joined #openstack-nova15:39
dhellmannthe 2nd problem was that the text of the links was the same, too, so `title <url1>`_ and `title <url2>`_ was causing a conflict. The fix was to use double underscore so sphinx doesn't try to "define" a link with the title15:39
bauzassorry, still in a meeting :/15:39
gmanni think, the idea of not have link in prelude make sense as there is only one 'Upgrade section' in merged releasenotes .15:40
dhellmannI have to go do some other stuff, so I'll leave the bots to run and let you decide how you want to fix it.15:40
gibidhellmann: thanks15:40
gmanndhellmann: sure, thanks again.15:40
dhellmanngmann : for projects with 2 real releases in one stable branch there could be multiple upgrade sections15:40
dhellmannso if there are upgrade notes from 21.0.0 to 21.0.1 then you'll have the same thing again15:41
gibigmann, bauzas: I have to drop for today. I would go with the current proposed solution just because it is already proposed and we have limited time15:41
gmanndhellmann: i see.15:41
bauzasgibi: fair enough15:41
gmannok15:41
bauzasand I'm on the same tangency15:41
gibibauzas: but we can talk about rules for the future to avoid this15:41
bauzasI also have very limited brain now to understand all the issues15:42
bauzasgibi: worth +2ing both dhellmann's changes and then I +W them ?15:42
gmannbauzas: gibi this is good things to note down for rc backport somewhere to handle in master side itself, any good place you recommend. wiki/doc ?15:42
jsuchomedansmith: what are my options? Would it be acceptable just to extend load_transfer_modules to explicitly load rbd download mechanism?15:42
bauzasgmann: we have the contributor docs15:43
gibibauzas: I'm not a stable core15:43
gmannreview guide ?15:43
gibigmann: review guide is a good place yes15:43
bauzasgmann: we have the contributor docs https://docs.openstack.org/nova/latest/contributor/releasenotes.html15:43
gmann let me add something there and we can find common way whatever we agree on.15:43
gibigmann: thanks!15:43
bauzasgibi: you are for ussuri15:43
dansmithjsuchome: I have to look at it in more detail to figure out what the right thing to do is, but using the external plug point (and changing the behavior of that in the process) isn't the best plan, IMHO15:44
gibibauzas: I tried I only have +1 right15:44
bauzasgibi: waaaaaat ?15:44
*** ociuhandu has quit IRC15:44
gibielod: If you have time there is stable/ussuri reno fix to merge before RC2 https://review.opendev.org/#/c/72530115:44
dansmithjsuchome: I'm guessing that the rbd image module can probably pass a download routine to glance but I'd need to go look15:44
jsuchomedansmith: it was written in some release notes that in case some users are already using it, it might be the way to un-deprecate it. That's exactly the case here15:44
dansmithjsuchome: I don't want to un-deprecate it15:44
bauzasgibi: okay, the ship halfly-sailed, we need +W15:46
gibibauzas: I've pinged elod, he will chekck it15:46
bauzasleave it for now, I'll chase up another stable-core15:46
bauzasgibi: but this isn't normal you can't +2 on stable/ussuri15:47
*** xek has quit IRC15:47
gibiand I have to leave so talk to you tomorrow15:47
bauzasgibi: np, \o15:47
gibio/15:47
gmannbauzas: gibi thanks. ttyt15:51
kashyapbauzas: Here's the 'nova-next' in-progress job :) -- https://review.opendev.org/#/c/708701/15:57
kashyapNeed to dig into the Ubuntu-based failures15:58
*** dpawlik has quit IRC15:59
dansmithjsuchome: I'll put up some code as an example of a path forward in a bit16:00
jsuchomedansmith: thanks!16:00
*** ociuhandu has joined #openstack-nova16:04
*** rpittau is now known as rpittau|afk16:08
*** ociuhandu has quit IRC16:09
kashyapgibi: When you get time tomm, please have a gander at point-166 here: https://etherpad.opendev.org/p/nova-victoria-ptg  (Cc: bauzas)16:13
*** ircuser-1 has joined #openstack-nova16:19
*** smcginnis has quit IRC16:19
*** ociuhandu has joined #openstack-nova16:27
*** smcginnis has joined #openstack-nova16:28
dansmithjsuchome: do you want me to mangle the existing patch a bit to show what I think needs to happen? it'll take it into WIP state, but should be able to form a basis for moving forward16:34
*** ttsiouts has joined #openstack-nova16:35
*** evrardjp has quit IRC16:35
*** evrardjp has joined #openstack-nova16:36
*** ociuhandu has quit IRC16:38
*** ociuhandu has joined #openstack-nova16:38
*** ttsiouts has quit IRC16:48
*** ociuhandu has quit IRC16:50
*** dtantsur is now known as dtantsur|afk16:57
openstackgerritDan Smith proposed openstack/nova master: Remove deprecated nova.image.download hook  https://review.opendev.org/72533816:58
*** udesale_ has quit IRC17:06
*** ralonsoh has quit IRC17:07
elodbauzas dhellmann : the releasenotes job works now, but the links seem incorrect in the generated docs: https://review.opendev.org/#/c/725301/ ... or do I miss something?17:07
dhellmannelod : you're right17:10
dhellmannI probably messed up the link syntax17:10
openstackgerritDoug Hellmann proposed openstack/nova stable/ussuri: use more distinct link references in release notes  https://review.opendev.org/72530117:11
openstackgerritDoug Hellmann proposed openstack/nova stable/ussuri: Add nova-status upgrade check and reno for policy new defaults  https://review.opendev.org/72514617:11
dhellmannelod : let's try ^17:11
dhellmannif that doesn't work, then we will want `Upgrade Notes <#unique-value>`__17:11
*** ygk_12345 has joined #openstack-nova17:13
ygk_12345hi17:13
ygk_12345can someone look into this please17:14
ygk_12345https://bugs.launchpad.net/openstack-ansible/+bug/187676917:14
openstackLaunchpad bug 1876769 in openstack-ansible "Failed to create resource provider" [Undecided,New]17:14
*** vishalmanchanda has quit IRC17:15
ygk_12345https://bugs.launchpad.net/nova/+bug/187677217:16
openstackLaunchpad bug 1876772 in OpenStack Compute (nova) "Failed to create resource provider" [Undecided,New]17:16
*** ygk_12345 has quit IRC17:17
eloddhellmann: thanks for fixing! I will look into to generated docs whenever it's ready (or at least tomorrow morning (my morning, CEST timezone), as for me it's already end-of-day-ish :))17:18
dhellmannelod : +1, thanks for noticing the issue17:19
jsuchomedansmith: I still have hopes that most of the patch could stay as it already it, it "just" needs to be put the some different place. If you have some time of it, great, but I may just need only some good pointer///17:20
dansmithjsuchome: the download() method of the module being relocated, and the removal of all the module scaffolding is what I'm talking about doing17:21
*** salmankhan has quit IRC17:21
dansmithjsuchome: is that what you mean?17:21
*** CeeMac has joined #openstack-nova17:22
jsuchomeI think so, yeah. So we need the right place for relocation is17:23
*** hoonetorg has quit IRC17:23
jsuchome(sorry for my sentence structure, I'm doing too many things in paralel)17:24
*** ociuhandu has joined #openstack-nova17:25
dansmithjsuchome: yeah, I think it's pretty clear where it can go, so let me mangle the patch to something untested but demonstrative and then we can go from there17:27
*** ociuhandu has quit IRC17:33
openstackgerritDan Smith proposed openstack/nova master: WIP: Add ability to download Glance images into the libvirt image cache via RBD  https://review.opendev.org/57430117:35
*** maciejjozefczyk has joined #openstack-nova17:45
*** nightmare_unreal has quit IRC17:52
*** maciejjozefczyk has quit IRC17:53
*** maciejjozefczyk has joined #openstack-nova17:57
jsuchome+118:00
dansmithjsuchome: so I have nothing pre-existing to test with in order to finish this out.. can you take that from here?18:02
jsuchomethanks, I'm gonna look at it (tommorow, now it's 8pm here)18:09
dansmithcool18:09
*** Jeffrey4l has quit IRC18:23
*** ociuhandu has joined #openstack-nova18:23
openstackgerritElod Illes proposed openstack/nova stable/ussuri: use more distinct link references in release notes  https://review.opendev.org/72530118:29
*** Jeffrey4l has joined #openstack-nova18:31
*** redrobot has joined #openstack-nova18:33
openstackgerritElod Illes proposed openstack/nova stable/ussuri: Add nova-status upgrade check and reno for policy new defaults  https://review.opendev.org/72514618:33
*** dklyle has joined #openstack-nova18:36
*** Jeffrey4l has quit IRC18:36
*** Jeffrey4l has joined #openstack-nova18:43
*** maciejjozefczyk has quit IRC18:45
*** ociuhandu has quit IRC18:58
*** hoonetorg has joined #openstack-nova19:00
*** jsuchome has quit IRC19:13
openstackgerritGhanshyam Mann proposed openstack/nova master: Moving functional jobs to Victoria testing runtime  https://review.opendev.org/72537219:15
*** munimeha1 has joined #openstack-nova19:17
*** xek has joined #openstack-nova19:33
*** ociuhandu has joined #openstack-nova19:34
*** lseki has joined #openstack-nova19:51
*** nweinber has quit IRC20:14
*** threestrands has joined #openstack-nova20:34
*** ociuhandu has quit IRC20:57
*** slaweq_ has quit IRC21:08
*** xek has quit IRC21:09
*** ociuhandu has joined #openstack-nova21:10
*** slaweq_ has joined #openstack-nova21:14
*** slaweq_ has quit IRC21:19
*** ociuhandu has quit IRC21:22
*** ociuhandu has joined #openstack-nova21:23
*** ociuhandu has quit IRC21:27
*** ccamacho has quit IRC21:39
*** avolkov has quit IRC21:42
*** mriedem has left #openstack-nova22:00
*** raildo has quit IRC22:08
*** tobiash has quit IRC22:13
*** rcernin has joined #openstack-nova22:22
*** rchurch has quit IRC22:36
*** rchurch has joined #openstack-nova22:39
openstackgerritSean McGinnis proposed openstack/nova master: Remove monotonic usage  https://review.opendev.org/72542522:40
*** spatel has quit IRC22:49
openstackgerritGhanshyam Mann proposed openstack/nova stable/train: DNM: testing what all grenade jobs running  https://review.opendev.org/72514723:10
*** mlavalle has quit IRC23:25
*** munimeha1 has quit IRC23:26
*** tosky has quit IRC23:28

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!