*** spatel has quit IRC | 00:04 | |
*** Nel1x has joined #openstack-nova | 00:14 | |
*** ociuhandu has joined #openstack-nova | 00:26 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova stable/ussuri: Add nova-status upgrade check and reno for policy new defaults https://review.opendev.org/725146 | 00:27 |
---|---|---|
*** ociuhandu has quit IRC | 00:36 | |
*** ociuhandu has joined #openstack-nova | 00:38 | |
*** ociuhandu has quit IRC | 00:43 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova stable/train: DNM: testing what all grenade jobs running https://review.opendev.org/725147 | 00:57 |
*** gregwork has quit IRC | 01:33 | |
*** hemna has quit IRC | 01:41 | |
*** hemna has joined #openstack-nova | 01:42 | |
*** spatel has joined #openstack-nova | 01:50 | |
*** spatel has quit IRC | 01:54 | |
*** tetsuro has joined #openstack-nova | 02:04 | |
*** spatel has joined #openstack-nova | 02:23 | |
alex_xu | sean-k-mooney: gibi fyi, we will have someone working on provider config xml. | 02:33 |
*** tetsuro has quit IRC | 02:33 | |
*** sapd1_x has joined #openstack-nova | 03:12 | |
*** sapd1_x has quit IRC | 03:17 | |
*** sapd1_x has joined #openstack-nova | 03:31 | |
*** mkrai has joined #openstack-nova | 03:32 | |
*** psachin has joined #openstack-nova | 03:33 | |
*** jangutter has quit IRC | 03:44 | |
*** jangutter has joined #openstack-nova | 03:45 | |
*** ociuhandu has joined #openstack-nova | 03:56 | |
*** ociuhandu has quit IRC | 04:02 | |
*** lbragstad has quit IRC | 04:10 | |
*** ratailor has joined #openstack-nova | 04:31 | |
*** evrardjp has quit IRC | 04:35 | |
*** evrardjp has joined #openstack-nova | 04:36 | |
*** sapd1_x has quit IRC | 04:40 | |
*** udesale has joined #openstack-nova | 04:42 | |
*** sapd1_x has joined #openstack-nova | 04:54 | |
*** jmlowe has quit IRC | 05:00 | |
*** spatel has quit IRC | 05:01 | |
*** jmlowe has joined #openstack-nova | 05:02 | |
openstackgerrit | Takashi Natsume proposed openstack/python-novaclient master: [WIP] Switch legacy Zuul jobs to native Zuul v3 jobs https://review.opendev.org/725163 | 05:08 |
*** ociuhandu has joined #openstack-nova | 05:23 | |
*** ociuhandu has quit IRC | 05:33 | |
*** Nel1x has quit IRC | 05:37 | |
*** vishalmanchanda has joined #openstack-nova | 05:43 | |
*** dpawlik has joined #openstack-nova | 06:04 | |
*** dpawlik has quit IRC | 06:04 | |
*** dpawlik has joined #openstack-nova | 06:07 | |
*** dpawlik has quit IRC | 06:07 | |
*** dpawlik has joined #openstack-nova | 06:08 | |
*** slaweq has joined #openstack-nova | 06:13 | |
*** ratailor has quit IRC | 06:19 | |
*** ratailor has joined #openstack-nova | 06:19 | |
*** rchurch has quit IRC | 06:31 | |
*** rchurch has joined #openstack-nova | 06:32 | |
*** rpittau|afk is now known as rpittau | 06:33 | |
*** ociuhandu has joined #openstack-nova | 06:38 | |
*** ircuser-1 has quit IRC | 06:42 | |
*** belmoreira has joined #openstack-nova | 06:54 | |
gibi | alex_xu: ack, thanks | 06:55 |
*** sapd1_x has quit IRC | 07:18 | |
*** ccamacho has joined #openstack-nova | 07:23 | |
*** mkrai has quit IRC | 07:24 | |
*** sapd1_x has joined #openstack-nova | 07:30 | |
*** tosky has joined #openstack-nova | 07:32 | |
*** xek has joined #openstack-nova | 07:33 | |
*** jsuchome has joined #openstack-nova | 07:42 | |
*** ociuhandu has quit IRC | 07:51 | |
*** mkrai has joined #openstack-nova | 07:55 | |
*** ociuhandu has joined #openstack-nova | 08:00 | |
*** nightmare_unreal has joined #openstack-nova | 08:00 | |
*** sapd1_x has quit IRC | 08:20 | |
gibi | stephenfin: hi! Do you have an idea why the reno job fails on this backport to stable/ussuri? https://review.opendev.org/#/c/725146/1 It is green for me locally but locally the releasenotes tox target does not try to generate stable/ussuri notes | 08:33 |
*** sapd1_x has joined #openstack-nova | 08:34 | |
*** dtantsur|afk is now known as dtantsur | 08:43 | |
*** udesale has quit IRC | 08:49 | |
bauzas | gibi: me looks | 08:56 |
bauzas | gibi: I don't see any problems with the reno file itself, just testing it locally | 08:59 |
bauzas | Warning, treated as error: <reno.sphinxext stable/ussuri>:115:Duplicate target name, cannot be used as a unique reference: "upgrade notes". | 08:59 |
bauzas | that's why we get -1 ^ | 09:00 |
*** salmankhan has joined #openstack-nova | 09:00 | |
bauzas | ahah I think we probably have something missing https://docs.openstack.org/reno/latest/user/usage.html#updating-stable-branch-release-notes | 09:03 |
bauzas | "Occasionally it is necessary to update release notes for past releases due to URLs changing or errors not being noticed until after they have been released. In cases like these, it is important to note that any updates to these release notes should be proposed directly to the stable branch where they were introduced." | 09:03 |
*** salmankhan1 has joined #openstack-nova | 09:04 | |
*** salmankhan has quit IRC | 09:05 | |
*** salmankhan1 is now known as salmankhan | 09:05 | |
* bauzas reads https://docs.openstack.org/project-team-guide/release-management.html#how-to-preview-release-notes-at-rc-time | 09:05 | |
bauzas | ok, so, relnotes are correctly written against master, but cherry-picking the change to my local stable/ussuri branch and retesting | 09:11 |
bauzas | I think I found the problem | 09:11 |
* bauzas needs to reproduce | 09:11 | |
*** ttsiouts has joined #openstack-nova | 09:12 | |
bauzas | gibi: we don't have *yet* ussuri release notes so reno writes the patch note against master twice | 09:12 |
bauzas | hence the duplicate | 09:12 |
bauzas | against 'unreleased' rather | 09:12 |
bauzas | lemme see if creating a ussuri.rst file would help | 09:13 |
gibi | bauzas: thanks for helping, I'm sitting on a meeting | 09:14 |
bauzas | ok, we have https://github.com/openstack/nova/blob/master/releasenotes/source/ussuri.rst | 09:14 |
bauzas | in master | 09:14 |
bauzas | which is normal | 09:14 |
bauzas | gibi: np | 09:14 |
bauzas | gibi: i think I have some potential findings but I need to test | 09:15 |
bauzas | and it takes a while to generate the relnotes locally as it scans all my branches | 09:15 |
gibi | yeah it is slow | 09:16 |
bauzas | interesting | 09:16 |
bauzas | it did worked fine on my box | 09:16 |
bauzas | interestingly, my current branch is ussuri when i'm testing on a local stable/ussuro | 09:18 |
bauzas | which is not the case with the job https://zuul.opendev.org/t/openstack/build/9c4f698044dc4af2b5bcb326b6a3e823/log/job-output.txt | 09:18 |
gibi | yeah, I also cannot reproduce the problem locally | 09:20 |
*** lpetrut has joined #openstack-nova | 09:25 | |
*** udesale has joined #openstack-nova | 09:27 | |
*** jangutter has quit IRC | 09:32 | |
bauzas | gibi: maybe a job issue | 09:35 |
gibi | bauzas: interestingly the job tries to generate reno for stable/ussuri the local tox target does not try that for me | 09:36 |
gibi | locally I get | 09:38 |
gibi | scanning /home/gibizer/upstream/git/nova/releasenotes/notes for current branch release notes | 09:38 |
gibi | got versions [] | 09:38 |
gibi | in the job | 09:39 |
gibi | 2020-05-04 07:58:23.877287 | ubuntu-bionic | scanning /home/zuul/src/opendev.org/openstack/nova/releasenotes/notes for current branch release notes | 09:39 |
gibi | 2020-05-04 07:59:02.632023 | ubuntu-bionic | got versions ['21.0.0.0rc1-16'] | 09:39 |
gibi | 2020-05-04 07:59:02.664924 | ubuntu-bionic | reading sources... [100%] ussuri | 09:39 |
gibi | 2020-05-04 07:59:02.670555 | ubuntu-bionic | scanning /home/zuul/src/opendev.org/openstack/nova/releasenotes/notes for stable/ussuri release notes | 09:39 |
gibi | 2020-05-04 08:00:13.350874 | ubuntu-bionic | got versions ['21.0.0.0rc1-5', '21.0.0.0rc1'] | 09:39 |
bauzas | lemme doublecheck mine | 09:41 |
gibi | are these versions '21.0.0.0rc1-5' are git tags? | 09:41 |
gibi | I only have 21.0.0.0rc1 tag | 09:41 |
bauzas | gibi: that's my env http://paste.openstack.org/show/793033/ | 09:42 |
bauzas | gibi: I branched stable/ussuri and cherry-picked the change into it | 09:42 |
bauzas | gibi: yup, AFAIR, reno works with git commits and tags | 09:43 |
gibi | it is pretty similar to mine except you have got versions ['21.0.0.0rc1-5'] | 09:43 |
bauzas | which is expected | 09:43 |
bauzas | gibi: if I tag my branch as 21.0.1 per se | 09:44 |
bauzas | gibi: then you'll be seeing it | 09:44 |
bauzas | gibi: see https://docs.openstack.org/project-team-guide/release-management.html#how-to-preview-release-notes-at-rc-time | 09:44 |
bauzas | gibi: remember that reno tries to see which tags are related to which releasenotes | 09:45 |
bauzas | once you tag a .z version, then you'll see it | 09:45 |
*** ttsiouts has quit IRC | 09:46 | |
gibi | bauzas: does it mean that the gate job temporarly tag the repo and then generate the notes? | 09:46 |
bauzas | I don't think so | 09:47 |
gibi | OK. I'm lost :) | 09:47 |
* bauzas just tagged a fake 21.0.1 | 09:47 | |
bauzas | and see whether reno finds it | 09:48 |
gibi | ok | 09:48 |
bauzas | we need dhellmann or someone else from the reno team IMHO | 09:48 |
bauzas | gibi: what's not normal is that we scan both the current branch and the stable/ussuri one | 09:49 |
bauzas | (against a stable/ussuri change) | 09:50 |
bauzas | because both are identical | 09:50 |
bauzas | gibi: you understand this ? | 09:50 |
gibi | I accept this as a probable problem. I just blocked by the fact that I cannot reproduce the result locally | 09:50 |
bauzas | https://zuul.opendev.org/t/openstack/build/9c4f698044dc4af2b5bcb326b6a3e823/log/job-output.txt#1415 and https://zuul.opendev.org/t/openstack/build/9c4f698044dc4af2b5bcb326b6a3e823/log/job-output.txt#1418 generate the same | 09:50 |
bauzas | gibi: yeah, me too | 09:51 |
*** ociuhandu has quit IRC | 09:51 | |
*** ociuhandu has joined #openstack-nova | 09:52 | |
bauzas | gibi: what we could do is trying to avoid to present the upgrade note in master | 09:54 |
bauzas | gibi: I can try to provide a DNM for testing | 09:54 |
bauzas | gibi: actually, the upgrade note is invalid for Victoria, right ? | 09:55 |
bauzas | gibi: see what happens when you tag locally : http://paste.openstack.org/show/793034/ | 09:56 |
*** ociuhandu has quit IRC | 09:57 | |
bauzas | gibi: and by looking at my html build, I see the note, yeepee | 09:57 |
bauzas | (marked against my fake 21.0.1) | 09:57 |
gibi | so locally it is still not generate notes for stable/ussuri | 09:57 |
bauzas | it does | 09:57 |
bauzas | but as 'unreleased' | 09:58 |
bauzas | see https://docs.openstack.org/releasenotes/nova/unreleased.html | 09:58 |
bauzas | gibi: this is bad ^ | 09:58 |
bauzas | because the upgrade issue is when you upgrade from Train to Ussuri, right? | 09:58 |
gibi | bauzas: so we have to remove the reno from master (V)? | 09:58 |
bauzas | gibi: we'll ignore it | 09:59 |
bauzas | https://docs.openstack.org/project-team-guide/release-management.html#updating-stable-branch-release-notes | 09:59 |
bauzas | gibi: I'm just forging a :ignore-notes: directive | 10:00 |
gibi | ahh | 10:00 |
gibi | thanks | 10:00 |
*** ociuhandu has joined #openstack-nova | 10:00 | |
gibi | so we need the ignore-notes patch on master? | 10:01 |
bauzas | I *think* | 10:01 |
bauzas | gibi: we wrote it for the T->U upgrade, right? | 10:01 |
gibi | right | 10:01 |
bauzas | ok, so let's ignore it or it will appear in the 22.0.0 relnotes | 10:01 |
gibi | we just merged it first on master | 10:01 |
gibi | and then backport | 10:02 |
bauzas | gibi: sure, i understood but reno files are different | 10:02 |
gibi | yeah, I get to feel that | 10:02 |
gibi | :) | 10:02 |
bauzas | gibi: see the warnings in the reno docs :) | 10:02 |
bauzas | if you wanna fix some specific reno file on a stable branch, you need to make it a stable-only change | 10:02 |
bauzas | my reno skills are rusty and I forgot to warn this | 10:03 |
gibi | so the good first solution would have been not to add reno for the policy upgrade check on master just in the backport to stable/ussuri | 10:03 |
bauzas | gibi: yup | 10:03 |
bauzas | May 1st killed my productivity | 10:03 |
*** ralonsoh has joined #openstack-nova | 10:03 | |
bauzas | gibi: and tbc, git deleting a YAML file is bad | 10:04 |
gibi | bauzas: you mean that we should not fix the issue with a partial revert on master that would delete the reno file but use ignore-notes instead | 10:04 |
bauzas | gibi: yep | 10:04 |
* gibi learns every day | 10:05 | |
bauzas | gibi: I can't remember why this is bad, but I think it's because reno walks above every commit and generates | 10:05 |
*** rpittau is now known as rpittau|bbl | 10:14 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova master: Don't show upgr note for policy validation in V https://review.opendev.org/725226 | 10:28 |
bauzas | gibi: ^ | 10:29 |
gibi | looking | 10:29 |
bauzas | hopefully it should fix the issue | 10:29 |
bauzas | I tested locally and the note isn't appearing | 10:29 |
bauzas | then we should recheck | 10:30 |
bauzas | the stable/ussuri change | 10:30 |
gibi | bauzas: so we merge your ignore patch then recheck the stable/ussuri backport | 10:31 |
bauzas | we can try at least | 10:31 |
bauzas | if you feel brave enough to fast approve it... | 10:31 |
gibi | does lyarwood off today too? | 10:32 |
* gibi goes to lunch | 10:33 | |
bauzas | gibi: he's a bit off and on | 10:34 |
bauzas | stephenfin: if you mind approving this one quickly https://review.opendev.org/#/c/725226/1 | 10:36 |
bauzas | we need it in order to unfuck https://review.opendev.org/#/c/725146/ which is holding RC2 | 10:37 |
*** ttsiouts has joined #openstack-nova | 10:48 | |
*** avolkov has joined #openstack-nova | 10:52 | |
zigo | My PR here is not good. I've been asked to add a functional test, I tried copying it from the Keystone one but failed. Can anyone help ? | 11:00 |
zigo | https://review.opendev.org/724684 | 11:00 |
zigo | bauzas: ^ | 11:00 |
zigo | :) | 11:00 |
zigo | IMO, it's in the wrong place (he: where CORS is tested), and not doing the right thing. My intention is that it only checks the HTTP 200 return, which is the only thing that should be tested... | 11:01 |
zigo | I'd love to have a easy way to functional test this that I could copy in all projects later on. | 11:02 |
*** kevinz has quit IRC | 11:04 | |
*** mkrai has quit IRC | 11:07 | |
*** slaweq_ has joined #openstack-nova | 11:18 | |
*** slaweq has quit IRC | 11:21 | |
*** ttsiouts has quit IRC | 11:28 | |
*** ociuhandu has quit IRC | 11:29 | |
*** ociuhandu has joined #openstack-nova | 11:30 | |
*** ttsiouts has joined #openstack-nova | 11:30 | |
*** ociuhandu has quit IRC | 11:35 | |
*** ttsiouts has quit IRC | 11:36 | |
*** ttsiouts has joined #openstack-nova | 11:38 | |
*** nweinber has joined #openstack-nova | 11:45 | |
*** raildo has joined #openstack-nova | 11:58 | |
*** ttsiouts has quit IRC | 12:03 | |
*** bbowen has joined #openstack-nova | 12:04 | |
bauzas | zigo: I'm not a paste specialist, but maybe you should add it to https://review.opendev.org/#/c/724684/5/etc/nova/api-paste.ini@L78 | 12:06 |
*** mkrai has joined #openstack-nova | 12:09 | |
zigo | bauzas: The issue is only the functional test, not the api-paste.ini which i tested. | 12:10 |
*** ociuhandu has joined #openstack-nova | 12:11 | |
bauzas | zigo: then I guess requests is not using parse | 12:13 |
bauzas | ahah, we have an APIPasteFixture object :) | 12:15 |
bauzas | bingo | 12:16 |
bauzas | zigo: ^ | 12:16 |
*** sapd1_x has quit IRC | 12:16 | |
bauzas | zigo: look at this https://github.com/openstack/nova/blob/master/nova/tests/functional/api_paste_fixture.py#L51-L59 | 12:17 |
*** ttsiouts has joined #openstack-nova | 12:17 | |
*** ociuhandu has quit IRC | 12:17 | |
*** eharney has joined #openstack-nova | 12:20 | |
*** rpittau|bbl is now known as rpittau | 12:22 | |
bauzas | zigo: you should probably pdb the fixture to see what you get as paste.ini | 12:25 |
zigo | Ok. | 12:26 |
* zigo is in a meeting. | 12:26 | |
*** ociuhandu has joined #openstack-nova | 12:30 | |
*** ttsiouts has quit IRC | 12:37 | |
*** udesale_ has joined #openstack-nova | 12:38 | |
*** udesale has quit IRC | 12:41 | |
*** hemna has quit IRC | 12:44 | |
*** hemna has joined #openstack-nova | 12:44 | |
bauzas | oh but today is a bank holiday in Ireland | 12:49 |
bauzas | stephenfin: my bad | 12:49 |
bauzas | stephenfin: my badhttps://review.opendev.org/#/c/725226/ ? | 12:50 |
bauzas | I can +W it | 12:50 |
bauzas | lyarwood: around maybe ? | 12:50 |
*** mkrai has quit IRC | 12:52 | |
*** cz3 is now known as poweredgelord | 12:53 | |
*** spatel has joined #openstack-nova | 12:53 | |
*** poweredgelord is now known as cz3 | 12:57 | |
bauzas | zigo: fwiw, pdb'ing 724684 | 13:01 |
*** jamesden_ is now known as jamesdenton | 13:07 | |
*** lbragstad has joined #openstack-nova | 13:07 | |
*** mkrai has joined #openstack-nova | 13:08 | |
*** lbragstad has quit IRC | 13:08 | |
*** lbragstad has joined #openstack-nova | 13:12 | |
*** ttsiouts has joined #openstack-nova | 13:14 | |
*** psachin has quit IRC | 13:14 | |
*** ttsiouts has quit IRC | 13:18 | |
*** ociuhandu has quit IRC | 13:20 | |
*** ociuhandu has joined #openstack-nova | 13:21 | |
*** tbachman has joined #openstack-nova | 13:21 | |
*** hemna has quit IRC | 13:23 | |
*** hemna has joined #openstack-nova | 13:24 | |
*** ociuhandu has quit IRC | 13:25 | |
*** KeithMnemonic has joined #openstack-nova | 13:31 | |
bauzas | zigo: ah, I think I found the problem | 13:33 |
zigo | :) | 13:33 |
* zigo is still in a meeting, but soon finished... | 13:34 | |
bauzas | zigo: http://paste.openstack.org/show/793050/ | 13:34 |
bauzas | looks like it tries to call a /v2 endpoint | 13:34 |
zigo | Oh ! :) | 13:34 |
zigo | It should be just /healthcheck indeed... | 13:35 |
zigo | And probably without any auth as well. | 13:35 |
*** hemna has quit IRC | 13:36 | |
*** hemna has joined #openstack-nova | 13:36 | |
*** ociuhandu has joined #openstack-nova | 13:36 | |
*** ralonsoh has quit IRC | 13:37 | |
*** artom has joined #openstack-nova | 13:37 | |
openstackgerrit | François Palin proposed openstack/nova stable/rocky: Add retry to cinder API calls related to volume detach https://review.opendev.org/725272 | 13:38 |
*** salmankhan1 has joined #openstack-nova | 13:39 | |
*** salmankhan has quit IRC | 13:40 | |
*** salmankhan1 is now known as salmankhan | 13:40 | |
*** hemna has quit IRC | 13:43 | |
*** hemna has joined #openstack-nova | 13:43 | |
*** mkrai has quit IRC | 13:44 | |
zigo | bauzas: What's the way to make it not prefix the URL then? | 13:48 |
bauzas | again, I'm not an API specialist unfortunately | 13:48 |
bauzas | I can't really answer why we transform this URL | 13:49 |
*** lpetrut has quit IRC | 13:49 | |
bauzas | but lemme try something | 13:49 |
*** ralonsoh has joined #openstack-nova | 13:49 | |
bauzas | ahah found | 13:51 |
bauzas | https://github.com/openstack/nova/blob/master/nova/tests/functional/api/client.py#L147 | 13:51 |
zigo | strip_version=True and I'm good to go? | 13:52 |
*** hemna has quit IRC | 13:53 | |
*** ratailor has quit IRC | 13:53 | |
*** hemna has joined #openstack-nova | 13:54 | |
bauzas | zigo: fwiw, I just tested to call 'http://728dd5ee-0231-4919-b991-a21cae822084:80/healthcheck' and I got a 200 :) | 13:54 |
bauzas | just trying strip_version | 13:54 |
zigo | :) | 13:54 |
zigo | Thanks. | 13:54 |
zigo | Trying. | 13:54 |
bauzas | got a 300 | 13:55 |
bauzas | that's... fun :) | 13:55 |
openstackgerrit | Thomas Goirand proposed openstack/nova master: Add a /healthcheck URL https://review.opendev.org/724684 | 13:55 |
bauzas | zigo: hold your change | 13:56 |
bauzas | it won't work (yet) | 13:56 |
bauzas | ahah ! | 13:58 |
bauzas | > /home/sbauza/git/openstack/nova/nova/tests/functional/api/client.py(172)api_request() | 13:58 |
bauzas | -> response = self.request(full_uri, **kwargs) | 13:58 |
bauzas | (Pdb) full_uri | 13:58 |
bauzas | 'http://94193b57-ca75-4e13-9d4c-2cc961eeaf5b:80/6f70656e737461636b20342065766572//healthcheck' | 13:58 |
bauzas | (Pdb) n | 13:58 |
bauzas | we don't want the project here | 13:58 |
bauzas | (Pdb) good_uri = 'http://94193b57-ca75-4e13-9d4c-2cc961eeaf5b:80/healthcheck' | 13:59 |
bauzas | (Pdb) self.request(good_uri, **kwargs).status_code | 13:59 |
bauzas | 200 | 13:59 |
bauzas | zigo: ^ | 13:59 |
*** ttsiouts has joined #openstack-nova | 14:01 | |
*** huaqiang has quit IRC | 14:02 | |
bauzas | zigo: found how to solve it | 14:03 |
bauzas | zigo: https://github.com/openstack/nova/blob/master/nova/tests/fixtures.py#L931 | 14:03 |
openstackgerrit | Thomas Goirand proposed openstack/nova master: Add a /healthcheck URL https://review.opendev.org/724684 | 14:03 |
bauzas | zigo: stop eating our CI resources, please :) | 14:04 |
zigo | Will do ! :) | 14:04 |
bauzas | zigo: I'm close to the resolution | 14:04 |
bauzas | zigo: I can propose a revision if you're okay with ? | 14:05 |
zigo | Sure, thanks ! | 14:05 |
*** huaqiang has joined #openstack-nova | 14:05 | |
bauzas | zigo: ok, I'll just propose another test class | 14:05 |
*** ttsiouts has quit IRC | 14:06 | |
zigo | Indeed, it's probably fine in this file, but not the same class, I thought about fixing that too ! | 14:09 |
*** mriedem has joined #openstack-nova | 14:15 | |
gibi | melwitt: you looked at this bug report before: https://bugs.launchpad.net/nova/+bug/1818671 There are some new data in there. I looked at it. I cannot reproduce it on master and the bugfix that seems relevant backported to the version of used by the last commenter | 14:17 |
openstack | Launchpad bug 1818671 in OpenStack Compute (nova) "Openstack usage list not showing all projects" [Undecided,New] | 14:17 |
gibi | melwitt: I don't have a queens devstack at hand. Do you have any idea what fixed the problem since Queens? | 14:18 |
bauzas | zigo: I'm done with your change | 14:28 |
bauzas | zigo: it works locally | 14:28 |
bauzas | zigo: but I'd like to add a negative test | 14:28 |
bauzas | zigo: how can I fake healthcheck to say "sorry but no" ? | 14:29 |
zigo | bauzas: Of what kind? What will you negatively test? | 14:29 |
zigo | Oh... | 14:29 |
* bauzas reading oslo.middleware documentation | 14:30 | |
openstackgerrit | Doug Hellmann proposed openstack/nova master: increase verbose level for release notes build https://review.opendev.org/725290 | 14:33 |
bauzas | ok, nevermind, you haven't enabled the disabled_per_file option | 14:34 |
bauzas | will just verify the JSON output | 14:35 |
*** ttsiouts has joined #openstack-nova | 14:36 | |
bauzas | ahah, very interesting | 14:37 |
bauzas | /home/sbauza/git/openstack/nova/.tox/functional/lib/python3.7/site-packages/paste/deploy/util.py:55: DeprecationWarning: Using function/method 'Healthcheck.factory()' is deprecated: The healthcheck middleware must now be configured as an application, not as a filter | 14:37 |
zigo | bauzas: I don't see any reason why it would be needed, but yeah, we could set /etc/nova/disable_healthcheck by default. | 14:37 |
bauzas | zigo: let's not overthink this | 14:37 |
zigo | Oh ! :) | 14:37 |
bauzas | this being said, see the deprecation warning above | 14:37 |
zigo | I've seen it as an app somewhere. | 14:37 |
bauzas | zigo: https://github.com/openstack/oslo.middleware/blob/2e56b4379ab5a8bd5c42e885253c81d2a5f021c2/oslo_middleware/healthcheck/__init__.py#L242-L248 | 14:38 |
bauzas | zigo: just amending my revision | 14:38 |
zigo | Thanks a lot for all of this, this will really be helpful for operators. | 14:39 |
zigo | Typically, in haproxy, you'd setup: | 14:40 |
zigo | backend novabackend | 14:40 |
zigo | option httpchk GET /healthcheck | 14:40 |
zigo | If you don't, then you get crap in the nova-api.log ... | 14:40 |
zigo | As in, haproxy tries to open the connection, does no request, and close the connection, which is *very* hugly. | 14:40 |
gmann | bauzas: i feel we can keep those upgrade notes for V upgrade also as we will remove the old defaults in W cycle (along with U)- https://review.opendev.org/#/c/725226/1 | 14:45 |
bauzas | zigo: okay, you know what ? I can't really help on the paste issue, but I'll upload my new rev | 14:47 |
bauzas | zigo: then you can ask gmann or other API specialists to look at your paste config | 14:47 |
*** mlavalle has joined #openstack-nova | 14:48 | |
*** ttsiouts has quit IRC | 14:48 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add a /healthcheck URL https://review.opendev.org/724684 | 14:51 |
bauzas | zigo: okay, I left the deprecated usage but the functional test should work | 14:52 |
bauzas | zigo: this being said, I'll -1 because of the deprecation usage, please try to look at it | 14:52 |
zigo | Will do, let's first wait to see if it passes the gate. | 14:53 |
bauzas | zigo: it will : | 14:55 |
bauzas | functional run-test: commands[1] | stestr slowest | 14:55 |
bauzas | Test id Runtime (s) | 14:55 |
bauzas | -------------------------------------------------------------------------------- ----------- | 14:55 |
bauzas | nova.tests.functional.test_middleware.TestHealthCheckMiddleware.test_healthcheck 4.460 | 14:55 |
bauzas | __________________________________________________________________________________________________________________ summary ___________________________________________________________________________________________________________________ | 14:55 |
bauzas | functional: commands succeeded | 14:55 |
bauzas | congratulations :) | 14:55 |
*** dhellmann has joined #openstack-nova | 14:58 | |
dhellmann | bauzas : o/ | 14:58 |
artom | bauzas, zigo, also, since you're collaborating on that patch, reno and docs plz :) | 14:58 |
bauzas | dhellmann: thanks for joining :) | 14:58 |
bauzas | artom: I just helped zigo with his functest issue, nothing really important | 14:58 |
bauzas | now back on the RC2 holding bug | 14:58 |
dhellmann | I think the fix for the issue is to change the way the prelude links to the upgrade notes section, but I'm not sure of the best way to do that because you're in the middle of the RCs | 14:58 |
bauzas | dhellmann: ah, that's because we made an implicit target? | 14:59 |
dhellmann | after a final release, the rc sections are collapsed into that final version number, so the link targets change | 14:59 |
dhellmann | yes | 14:59 |
dhellmann | I'm experimenting with a fix locally | 14:59 |
bauzas | dhellmann: so https://review.opendev.org/#/c/725226/ wouldn't help with the issue ? | 14:59 |
*** ttsiouts has joined #openstack-nova | 14:59 | |
bauzas | (sorry, got dragged from a bit) | 15:00 |
bauzas | gibi: you could be interested in this | 15:00 |
bauzas | dhellmann: we honestly used the implicit target for the prelude a lot of times | 15:01 |
bauzas | dhellmann: and i don't understand why it would be a problem due to https://review.opendev.org/#/q/Id9cd65877e53577bff22e408ca07bbeec4407f6e | 15:01 |
gmann | yeah that was i am wondering as it merged previous notes or section without comlain | 15:02 |
dhellmann | bauzas : no, that patch won't fix it. you might want that change anyway, but that's not the problem. | 15:02 |
dhellmann | bauzas : the problem is that with gmann's patch there are now 2 sections on the same page with the same title, so sphinx doesn't know which one you want to link to | 15:02 |
dhellmann | after the final release is tagged, they will be collapsed into 1 section, which is probably what you've seen on other releases | 15:03 |
dhellmann | and the problem is not really that there are 2 sections, it is that there are *links* to those sections in the text | 15:03 |
jsuchome | dansmith: Hi again, I rebased https://review.opendev.org/#/c/572805 and https://review.opendev.org/#/c/574301/ , could I get some reviews, please? | 15:03 |
dhellmann | so sphinx has to resolve where those links should go | 15:03 |
bauzas | dhellmann: looking at the paste you provided | 15:04 |
bauzas | okay, I *think* I understand | 15:05 |
bauzas | by merging gmann's patch, we're creating a new section | 15:06 |
dhellmann | right | 15:06 |
dansmith | jsuchome: I had feedback, so addressing that is necessary in addition to just rebasing it | 15:06 |
dhellmann | sheesh, there are a lot of changes in nova :-) generating the release notes takes ages | 15:07 |
gmann | dhellmann: should not merge section happen when it is release say rc2 version relese? and till then anything new goes into unreleased section instead of ussuri release section ? | 15:10 |
dhellmann | I think I have a fix, give me a sec to rebase | 15:10 |
gmann | dhellmann: ok, thanks | 15:11 |
* gibi reads back | 15:11 | |
gmann | bauzas: dhellmann may be i could have edited the existing reno instead of new so that it would conflict but that just hides this issue does not solve. | 15:12 |
gmann | bauzas: gibi i was searching and could not find any such issue (where new reno added in rc) for train and stein rc. | 15:13 |
*** ttsiouts has quit IRC | 15:15 | |
gibi | honestly I can only agree what you found with the reno problem but I cannot give to that discussion. I hope dhellmann's fix will help | 15:17 |
*** ttsiouts has joined #openstack-nova | 15:19 | |
openstackgerrit | Doug Hellmann proposed openstack/nova stable/ussuri: Add nova-status upgrade check and reno for policy new defaults https://review.opendev.org/725146 | 15:19 |
openstackgerrit | Doug Hellmann proposed openstack/nova stable/ussuri: use more distinct link references in release notes https://review.opendev.org/725301 | 15:19 |
dhellmann | let's see if ^ helps | 15:19 |
jsuchome | dansmith: well, yeah, I'm not sure how to address it. Are you suggesting some different path then using this formerly deprecated entry point? As I'm not the creator of the original code I would rather not rework it completely... | 15:22 |
dhellmann | gibi : sphinx is like a compiler & linker for docs instead of for code. If there are 2 sections on a page with the same name, that's like having 2 functions in a module with the same name. Sphinx can't figure out which one you want to link to. | 15:22 |
gibi | dhellmann: thanks. and also thanks for fixing it | 15:23 |
dansmith | jsuchome: yes, I'm not okay with undeprecating that hook mechanism just to add something in-tree for it | 15:23 |
dhellmann | this is only related to reno because it's assembling the notes files into rst for sphinx. the same error could have happened if the text had been written by hand | 15:23 |
*** gyee has joined #openstack-nova | 15:25 | |
*** ttsiouts has quit IRC | 15:29 | |
*** belmoreira has quit IRC | 15:29 | |
gibi | dhellmann: so your patch can fix it as it changes the references current pointing to the ambiguous title to point to some specific title that is not duplicated by gmann's recent patch | 15:30 |
dhellmann | that's right | 15:31 |
gmann | dhellmann: thanks for fixing. and that did not complain in original change because Sphinx already merged the Upgrade Section - https://review.opendev.org/#/c/725301/1/releasenotes/notes/ussuri-prelude-4b96f1244cefcdf4.yaml | 15:31 |
dhellmann | the patch isn't quite right (it failed locally) but it's a different error | 15:31 |
bauzas | sorry was in a meeting | 15:31 |
gmann | dhellmann: any way Sphinx can error or warning for using implicit links at least for same link in same page? just for future so that it can be fixed in original change itself. | 15:32 |
dhellmann | good question. I don't know. | 15:33 |
dhellmann | there's a `reno lint` command, maybe that's a check it could do? | 15:33 |
bauzas | I'm a bit afraid of https://review.opendev.org/#/c/725301/ because it would be a bit more difficult for people to provide their own reno notes | 15:33 |
gmann | dhellmann: ok. let me try sometime later. | 15:34 |
bauzas | but we're close to RC2 so I wouldn't be picky | 15:34 |
dhellmann | another possible improvement for reno is to have it automatically add unique anchors for each file so that the prelude could have used those anchor names | 15:34 |
dhellmann | the problem with that is that the same note can appear in multiple series (backports) so you can't just use the filename | 15:35 |
bauzas | dhellmann: gmann: gibi: if you wanna get MHO, I'd just prefer to https://review.opendev.org/#/c/725146/2/releasenotes/notes/bug-1875418-0df3198e36530ec7.yaml to just amend an existing upgrade note instead of creating this YAML file | 15:36 |
gmann | dhellmann: yeah, asking for explicit anchor is much safe in case of backporting things. | 15:36 |
bauzas | we could leave some placeholder YAML file for backports | 15:36 |
bauzas | this would be simplier to manage rather than explicit sphinx targets | 15:36 |
dhellmann | bauzas : the whole point of reno is you don't have to do that sort of thing | 15:36 |
bauzas | I know :( | 15:37 |
gmann | bauzas: but that does not solve the whole things, same issue can occur for any new reno while backport | 15:37 |
dhellmann | another fix would be to remove the links in the prelude entirely | 15:37 |
gibi | bauzas: would you like to do that change on master first to keep the reno (even if it is ignored) in sync between branches? | 15:37 |
bauzas | gibi: which change ?N | 15:38 |
gibi | bauzas: ammending the existing upgrade reno instead of adding a new one | 15:38 |
*** ociuhandu has quit IRC | 15:38 | |
openstackgerrit | Doug Hellmann proposed openstack/nova stable/ussuri: use more distinct link references in release notes https://review.opendev.org/725301 | 15:38 |
openstackgerrit | Doug Hellmann proposed openstack/nova stable/ussuri: Add nova-status upgrade check and reno for policy new defaults https://review.opendev.org/725146 | 15:38 |
dhellmann | ok, I think ^ solves it | 15:39 |
*** ociuhandu has joined #openstack-nova | 15:39 | |
dhellmann | the 2nd problem was that the text of the links was the same, too, so `title <url1>`_ and `title <url2>`_ was causing a conflict. The fix was to use double underscore so sphinx doesn't try to "define" a link with the title | 15:39 |
bauzas | sorry, still in a meeting :/ | 15:39 |
gmann | i think, the idea of not have link in prelude make sense as there is only one 'Upgrade section' in merged releasenotes . | 15:40 |
dhellmann | I have to go do some other stuff, so I'll leave the bots to run and let you decide how you want to fix it. | 15:40 |
gibi | dhellmann: thanks | 15:40 |
gmann | dhellmann: sure, thanks again. | 15:40 |
dhellmann | gmann : for projects with 2 real releases in one stable branch there could be multiple upgrade sections | 15:40 |
dhellmann | so if there are upgrade notes from 21.0.0 to 21.0.1 then you'll have the same thing again | 15:41 |
gibi | gmann, bauzas: I have to drop for today. I would go with the current proposed solution just because it is already proposed and we have limited time | 15:41 |
gmann | dhellmann: i see. | 15:41 |
bauzas | gibi: fair enough | 15:41 |
gmann | ok | 15:41 |
bauzas | and I'm on the same tangency | 15:41 |
gibi | bauzas: but we can talk about rules for the future to avoid this | 15:41 |
bauzas | I also have very limited brain now to understand all the issues | 15:42 |
bauzas | gibi: worth +2ing both dhellmann's changes and then I +W them ? | 15:42 |
gmann | bauzas: gibi this is good things to note down for rc backport somewhere to handle in master side itself, any good place you recommend. wiki/doc ? | 15:42 |
jsuchome | dansmith: what are my options? Would it be acceptable just to extend load_transfer_modules to explicitly load rbd download mechanism? | 15:42 |
bauzas | gmann: we have the contributor docs | 15:43 |
gibi | bauzas: I'm not a stable core | 15:43 |
gmann | review guide ? | 15:43 |
gibi | gmann: review guide is a good place yes | 15:43 |
bauzas | gmann: we have the contributor docs https://docs.openstack.org/nova/latest/contributor/releasenotes.html | 15:43 |
gmann | let me add something there and we can find common way whatever we agree on. | 15:43 |
gibi | gmann: thanks! | 15:43 |
bauzas | gibi: you are for ussuri | 15:43 |
dansmith | jsuchome: I have to look at it in more detail to figure out what the right thing to do is, but using the external plug point (and changing the behavior of that in the process) isn't the best plan, IMHO | 15:44 |
gibi | bauzas: I tried I only have +1 right | 15:44 |
bauzas | gibi: waaaaaat ? | 15:44 |
*** ociuhandu has quit IRC | 15:44 | |
gibi | elod: If you have time there is stable/ussuri reno fix to merge before RC2 https://review.opendev.org/#/c/725301 | 15:44 |
dansmith | jsuchome: I'm guessing that the rbd image module can probably pass a download routine to glance but I'd need to go look | 15:44 |
jsuchome | dansmith: it was written in some release notes that in case some users are already using it, it might be the way to un-deprecate it. That's exactly the case here | 15:44 |
dansmith | jsuchome: I don't want to un-deprecate it | 15:44 |
bauzas | gibi: okay, the ship halfly-sailed, we need +W | 15:46 |
gibi | bauzas: I've pinged elod, he will chekck it | 15:46 |
bauzas | leave it for now, I'll chase up another stable-core | 15:46 |
bauzas | gibi: but this isn't normal you can't +2 on stable/ussuri | 15:47 |
*** xek has quit IRC | 15:47 | |
gibi | and I have to leave so talk to you tomorrow | 15:47 |
bauzas | gibi: np, \o | 15:47 |
gibi | o/ | 15:47 |
gmann | bauzas: gibi thanks. ttyt | 15:51 |
kashyap | bauzas: Here's the 'nova-next' in-progress job :) -- https://review.opendev.org/#/c/708701/ | 15:57 |
kashyap | Need to dig into the Ubuntu-based failures | 15:58 |
*** dpawlik has quit IRC | 15:59 | |
dansmith | jsuchome: I'll put up some code as an example of a path forward in a bit | 16:00 |
jsuchome | dansmith: thanks! | 16:00 |
*** ociuhandu has joined #openstack-nova | 16:04 | |
*** rpittau is now known as rpittau|afk | 16:08 | |
*** ociuhandu has quit IRC | 16:09 | |
kashyap | gibi: When you get time tomm, please have a gander at point-166 here: https://etherpad.opendev.org/p/nova-victoria-ptg (Cc: bauzas) | 16:13 |
*** ircuser-1 has joined #openstack-nova | 16:19 | |
*** smcginnis has quit IRC | 16:19 | |
*** ociuhandu has joined #openstack-nova | 16:27 | |
*** smcginnis has joined #openstack-nova | 16:28 | |
dansmith | jsuchome: do you want me to mangle the existing patch a bit to show what I think needs to happen? it'll take it into WIP state, but should be able to form a basis for moving forward | 16:34 |
*** ttsiouts has joined #openstack-nova | 16:35 | |
*** evrardjp has quit IRC | 16:35 | |
*** evrardjp has joined #openstack-nova | 16:36 | |
*** ociuhandu has quit IRC | 16:38 | |
*** ociuhandu has joined #openstack-nova | 16:38 | |
*** ttsiouts has quit IRC | 16:48 | |
*** ociuhandu has quit IRC | 16:50 | |
*** dtantsur is now known as dtantsur|afk | 16:57 | |
openstackgerrit | Dan Smith proposed openstack/nova master: Remove deprecated nova.image.download hook https://review.opendev.org/725338 | 16:58 |
*** udesale_ has quit IRC | 17:06 | |
*** ralonsoh has quit IRC | 17:07 | |
elod | bauzas dhellmann : the releasenotes job works now, but the links seem incorrect in the generated docs: https://review.opendev.org/#/c/725301/ ... or do I miss something? | 17:07 |
dhellmann | elod : you're right | 17:10 |
dhellmann | I probably messed up the link syntax | 17:10 |
openstackgerrit | Doug Hellmann proposed openstack/nova stable/ussuri: use more distinct link references in release notes https://review.opendev.org/725301 | 17:11 |
openstackgerrit | Doug Hellmann proposed openstack/nova stable/ussuri: Add nova-status upgrade check and reno for policy new defaults https://review.opendev.org/725146 | 17:11 |
dhellmann | elod : let's try ^ | 17:11 |
dhellmann | if that doesn't work, then we will want `Upgrade Notes <#unique-value>`__ | 17:11 |
*** ygk_12345 has joined #openstack-nova | 17:13 | |
ygk_12345 | hi | 17:13 |
ygk_12345 | can someone look into this please | 17:14 |
ygk_12345 | https://bugs.launchpad.net/openstack-ansible/+bug/1876769 | 17:14 |
openstack | Launchpad bug 1876769 in openstack-ansible "Failed to create resource provider" [Undecided,New] | 17:14 |
*** vishalmanchanda has quit IRC | 17:15 | |
ygk_12345 | https://bugs.launchpad.net/nova/+bug/1876772 | 17:16 |
openstack | Launchpad bug 1876772 in OpenStack Compute (nova) "Failed to create resource provider" [Undecided,New] | 17:16 |
*** ygk_12345 has quit IRC | 17:17 | |
elod | dhellmann: thanks for fixing! I will look into to generated docs whenever it's ready (or at least tomorrow morning (my morning, CEST timezone), as for me it's already end-of-day-ish :)) | 17:18 |
dhellmann | elod : +1, thanks for noticing the issue | 17:19 |
jsuchome | dansmith: I still have hopes that most of the patch could stay as it already it, it "just" needs to be put the some different place. If you have some time of it, great, but I may just need only some good pointer/// | 17:20 |
dansmith | jsuchome: the download() method of the module being relocated, and the removal of all the module scaffolding is what I'm talking about doing | 17:21 |
*** salmankhan has quit IRC | 17:21 | |
dansmith | jsuchome: is that what you mean? | 17:21 |
*** CeeMac has joined #openstack-nova | 17:22 | |
jsuchome | I think so, yeah. So we need the right place for relocation is | 17:23 |
*** hoonetorg has quit IRC | 17:23 | |
jsuchome | (sorry for my sentence structure, I'm doing too many things in paralel) | 17:24 |
*** ociuhandu has joined #openstack-nova | 17:25 | |
dansmith | jsuchome: yeah, I think it's pretty clear where it can go, so let me mangle the patch to something untested but demonstrative and then we can go from there | 17:27 |
*** ociuhandu has quit IRC | 17:33 | |
openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301 | 17:35 |
*** maciejjozefczyk has joined #openstack-nova | 17:45 | |
*** nightmare_unreal has quit IRC | 17:52 | |
*** maciejjozefczyk has quit IRC | 17:53 | |
*** maciejjozefczyk has joined #openstack-nova | 17:57 | |
jsuchome | +1 | 18:00 |
dansmith | jsuchome: so I have nothing pre-existing to test with in order to finish this out.. can you take that from here? | 18:02 |
jsuchome | thanks, I'm gonna look at it (tommorow, now it's 8pm here) | 18:09 |
dansmith | cool | 18:09 |
*** Jeffrey4l has quit IRC | 18:23 | |
*** ociuhandu has joined #openstack-nova | 18:23 | |
openstackgerrit | Elod Illes proposed openstack/nova stable/ussuri: use more distinct link references in release notes https://review.opendev.org/725301 | 18:29 |
*** Jeffrey4l has joined #openstack-nova | 18:31 | |
*** redrobot has joined #openstack-nova | 18:33 | |
openstackgerrit | Elod Illes proposed openstack/nova stable/ussuri: Add nova-status upgrade check and reno for policy new defaults https://review.opendev.org/725146 | 18:33 |
*** dklyle has joined #openstack-nova | 18:36 | |
*** Jeffrey4l has quit IRC | 18:36 | |
*** Jeffrey4l has joined #openstack-nova | 18:43 | |
*** maciejjozefczyk has quit IRC | 18:45 | |
*** ociuhandu has quit IRC | 18:58 | |
*** hoonetorg has joined #openstack-nova | 19:00 | |
*** jsuchome has quit IRC | 19:13 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Moving functional jobs to Victoria testing runtime https://review.opendev.org/725372 | 19:15 |
*** munimeha1 has joined #openstack-nova | 19:17 | |
*** xek has joined #openstack-nova | 19:33 | |
*** ociuhandu has joined #openstack-nova | 19:34 | |
*** lseki has joined #openstack-nova | 19:51 | |
*** nweinber has quit IRC | 20:14 | |
*** threestrands has joined #openstack-nova | 20:34 | |
*** ociuhandu has quit IRC | 20:57 | |
*** slaweq_ has quit IRC | 21:08 | |
*** xek has quit IRC | 21:09 | |
*** ociuhandu has joined #openstack-nova | 21:10 | |
*** slaweq_ has joined #openstack-nova | 21:14 | |
*** slaweq_ has quit IRC | 21:19 | |
*** ociuhandu has quit IRC | 21:22 | |
*** ociuhandu has joined #openstack-nova | 21:23 | |
*** ociuhandu has quit IRC | 21:27 | |
*** ccamacho has quit IRC | 21:39 | |
*** avolkov has quit IRC | 21:42 | |
*** mriedem has left #openstack-nova | 22:00 | |
*** raildo has quit IRC | 22:08 | |
*** tobiash has quit IRC | 22:13 | |
*** rcernin has joined #openstack-nova | 22:22 | |
*** rchurch has quit IRC | 22:36 | |
*** rchurch has joined #openstack-nova | 22:39 | |
openstackgerrit | Sean McGinnis proposed openstack/nova master: Remove monotonic usage https://review.opendev.org/725425 | 22:40 |
*** spatel has quit IRC | 22:49 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova stable/train: DNM: testing what all grenade jobs running https://review.opendev.org/725147 | 23:10 |
*** mlavalle has quit IRC | 23:25 | |
*** munimeha1 has quit IRC | 23:26 | |
*** tosky has quit IRC | 23:28 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!