Wednesday, 2020-05-13

tony_sugibi: Thanks for your review. I have changed 'Feature liasison' person from efried to gibi and uploaded the new patch 3. https://review.opendev.org/#/c/72578800:06
*** grandchild has quit IRC00:15
*** tetsuro has joined #openstack-nova00:30
*** amodi has quit IRC00:30
*** brinzhang has joined #openstack-nova00:36
*** ociuhandu has joined #openstack-nova00:36
*** tetsuro_ has joined #openstack-nova00:40
*** tetsuro has quit IRC00:43
*** ociuhandu has quit IRC00:44
*** Liang__ has joined #openstack-nova00:59
openstackgerritGhanshyam Mann proposed openstack/os-resource-classes master: Fix hacking min version to 3.0.1  https://review.opendev.org/72755701:21
openstackgerritGhanshyam Mann proposed openstack/os-traits master: Fix hacking min version to 3.0.1  https://review.opendev.org/72755901:21
*** sapd1 has joined #openstack-nova01:31
openstackgerritWenping Song proposed openstack/nova master: delete sub resource provider when delete resource provider  https://review.opendev.org/72756001:31
*** redrobot has quit IRC01:34
*** brinzhang_ has joined #openstack-nova01:35
*** brinzhang has quit IRC01:39
*** brinzhang_ has quit IRC01:41
*** brinzhang_ has joined #openstack-nova01:41
*** tetsuro has joined #openstack-nova01:44
*** tetsuro_ has quit IRC01:47
*** lbragstad_ is now known as lbragstad01:52
*** sapd1_x has joined #openstack-nova02:04
*** awalende has joined #openstack-nova02:07
*** tetsuro_ has joined #openstack-nova02:12
*** awalende has quit IRC02:12
*** tetsuro has quit IRC02:15
openstackgerritBrin Zhang proposed openstack/nova master: Fix flake8 error from hacking <3.0.1x  https://review.opendev.org/72758902:22
openstackgerritMerged openstack/python-novaclient master: Bump hacking min version to 3.0.1  https://review.opendev.org/72721402:24
openstackgerritWenping Song proposed openstack/nova master: delete sub resource provider when delete resource provider  https://review.opendev.org/71916302:27
openstackgerritWenping Song proposed openstack/nova master: delete sub resource provider when delete resource provider  https://review.opendev.org/72756002:27
*** kevinz has joined #openstack-nova02:35
openstackgerritBrin Zhang proposed openstack/nova master: Fix flake8 error from hacking <3.0.1  https://review.opendev.org/72758902:36
openstackgerritWenping Song proposed openstack/nova master: delete sub resource provider when delete resource provider  https://review.opendev.org/71916302:59
*** tetsuro has joined #openstack-nova03:06
*** tetsuro_ has quit IRC03:09
*** lbragstad has quit IRC03:18
*** gyee has quit IRC03:18
*** dustinc has quit IRC03:34
*** psachin has joined #openstack-nova03:37
*** tetsuro_ has joined #openstack-nova04:06
*** tetsuro has quit IRC04:09
*** ratailor has joined #openstack-nova04:09
*** evrardjp has quit IRC04:36
*** evrardjp has joined #openstack-nova04:36
*** ociuhandu has joined #openstack-nova04:42
*** ociuhandu has quit IRC04:49
*** psachin has quit IRC04:56
*** mtreinish has quit IRC05:01
*** dklyle has quit IRC05:01
*** dpawlik has quit IRC05:04
openstackgerritHuaqiang Wang proposed openstack/nova master: tox: Integrate mypy  https://review.opendev.org/67620805:14
openstackgerritHuaqiang Wang proposed openstack/nova master: hardware: Update and correct typing information  https://review.opendev.org/71469405:14
openstackgerritHuaqiang Wang proposed openstack/nova master: libvirt: Add typing information  https://review.opendev.org/71469505:14
openstackgerritHuaqiang Wang proposed openstack/nova master: tests: Split instance NUMA object tests  https://review.opendev.org/71469605:14
openstackgerritHuaqiang Wang proposed openstack/nova master: objects: Replace 'cpu_pinning_requested' helper  https://review.opendev.org/71469705:14
openstackgerritHuaqiang Wang proposed openstack/nova master: hardware: Don't consider overhead CPUs for unpinned instances  https://review.opendev.org/71469805:14
openstackgerritHuaqiang Wang proposed openstack/nova master: hardware: Remove handling of pre-Train compute nodes  https://review.opendev.org/71469905:14
openstackgerritHuaqiang Wang proposed openstack/nova master: hardware: Add validation for 'cpu_realtime_mask'  https://review.opendev.org/46820305:14
openstackgerritHuaqiang Wang proposed openstack/nova master: hardware: Tweak the 'cpu_realtime_mask' handling slightly  https://review.opendev.org/46145605:14
openstackgerritHuaqiang Wang proposed openstack/nova master: hardware: Rework 'get_realtime_constraint'  https://review.opendev.org/71470005:14
openstackgerritHuaqiang Wang proposed openstack/nova master: hardware: Invert order of NUMA topology generation  https://review.opendev.org/71470105:14
openstackgerritHuaqiang Wang proposed openstack/nova master: hardware: Remove '_numa_fit_instance_cell_with_pinning'  https://review.opendev.org/71470305:14
*** mtreinish has joined #openstack-nova05:34
*** links has joined #openstack-nova05:34
*** udesale has joined #openstack-nova05:36
*** tetsuro has joined #openstack-nova05:43
*** tetsuro_ has quit IRC05:47
*** awalende has joined #openstack-nova06:00
*** ccamacho has joined #openstack-nova06:00
*** awalende has quit IRC06:04
openstackgerritLiang Fang proposed openstack/nova master: [WIP] rbd patch for volume local cache  https://review.opendev.org/72676206:07
openstackgerritWenping Song proposed openstack/nova master: delete sub resource provider when delete resource provider  https://review.opendev.org/71916306:12
*** tetsuro_ has joined #openstack-nova06:23
*** nightmare_unreal has joined #openstack-nova06:23
*** belmoreira has joined #openstack-nova06:25
*** dpawlik has joined #openstack-nova06:25
*** tetsuro has quit IRC06:26
*** xek_ has joined #openstack-nova06:26
*** xek has quit IRC06:29
*** tetsuro has joined #openstack-nova06:29
*** ociuhandu has joined #openstack-nova06:30
*** ttsiouts has joined #openstack-nova06:30
*** tetsuro_ has quit IRC06:32
*** efried has quit IRC06:33
*** links has quit IRC06:37
*** ttsiouts has quit IRC06:39
*** links has joined #openstack-nova06:40
*** ttsiouts has joined #openstack-nova06:41
*** lpetrut has joined #openstack-nova06:42
*** slaweq has joined #openstack-nova06:51
*** tony_su has quit IRC06:53
openstackgerritJiri Suchomel proposed openstack/nova-specs master: Add spec for downloading images via RBD  https://review.opendev.org/57280506:57
*** jsuchome has joined #openstack-nova06:59
*** tesseract has joined #openstack-nova07:02
*** vishalmanchanda has joined #openstack-nova07:03
openstackgerritMerged openstack/nova master: Moving functional jobs to Victoria testing runtime  https://review.opendev.org/72537207:13
openstackgerritmelanie witt proposed openstack/nova master: DNM Try out running sphinx-build in parallel for releasenotes  https://review.opendev.org/72742907:22
*** tetsuro_ has joined #openstack-nova07:24
*** damien_r has joined #openstack-nova07:25
*** tetsuro has quit IRC07:27
bauzasgood morning Nova07:27
*** ociuhandu has quit IRC07:27
*** ociuhandu_ has joined #openstack-nova07:27
*** xek__ has joined #openstack-nova07:28
gibigood morning07:28
*** rpittau|afk is now known as rpittau07:29
*** ralonsoh has joined #openstack-nova07:29
*** xek_ has quit IRC07:30
*** tosky has joined #openstack-nova07:35
*** tony_ has joined #openstack-nova07:38
*** maciejjozefczyk has joined #openstack-nova07:38
*** tony_ is now known as tony_su07:38
*** awalende has joined #openstack-nova07:39
tony_suc07:51
tony_suclear07:52
tony_suexit07:52
tony_suexit07:52
gibitony_su: thanks for the spec update, I have +2d it07:52
tony_sugibi: got it and will go to next step. Thanks gibi.07:58
*** tony_su has quit IRC07:59
*** tesseract has quit IRC08:05
*** tesseract has joined #openstack-nova08:06
*** tony_ has joined #openstack-nova08:09
*** tony_ is now known as tony_su08:10
*** martinkennelly has joined #openstack-nova08:22
gibisean-k-mooney, dansmith: read back your discussion about the pre-filter. Good idea. Would that be backportable solution?08:29
gibisean-k-mooney, dansmith: also I replied in the patch https://review.opendev.org/#/c/727261 and will continue investigating turning off the cache today08:30
*** salmankhan has joined #openstack-nova08:30
*** xiaolin has quit IRC08:31
*** ttsiouts has quit IRC08:34
brinzhang_gibi: this re-propose spec comes from U release https://review.opendev.org/#/c/719720/, hope you can review again08:37
openstackgerritNalini Varshney proposed openstack/nova master: Add migration to make key field type VARBINARY in aggregate_metadata table,  https://review.opendev.org/72552208:40
openstackgerritsean mooney proposed openstack/nova master: Delete ARQs by UUID if Cyborg ARQ bind fails.  https://review.opendev.org/71618608:43
*** xiaolin has joined #openstack-nova08:45
*** tetsuro_ has quit IRC08:47
*** ttsiouts has joined #openstack-nova08:53
*** salmankhan1 has joined #openstack-nova08:57
*** salmankhan has quit IRC08:59
*** salmankhan1 is now known as salmankhan08:59
sean-k-mooneygibi: we only have prefilters back to rocky08:59
sean-k-mooneygibi: i guess we could backport it that far back.08:59
sean-k-mooneynormlaly i a prefilter would be a feature but in this case its a bug so if the stable team is ok with it maybe09:00
sean-k-mooneygibi: the prefilter would result in us over allocating the storage so we also need to srink the allocation on the compute node09:03
sean-k-mooneythat said we still need to be careful for rolling updates09:07
*** tetsuro has joined #openstack-nova09:07
*** xiaolin has quit IRC09:10
*** dtantsur|afk is now known as dtantsur09:13
openstackgerritsean mooney proposed openstack/nova master: Delete ARQs by UUID if Cyborg ARQ bind fails.  https://review.opendev.org/71618609:20
*** tetsuro has quit IRC09:23
*** avolkov has joined #openstack-nova09:27
*** jraju__ has joined #openstack-nova09:27
*** links has quit IRC09:28
*** Liang__ has quit IRC09:32
*** links has joined #openstack-nova09:47
*** jraju__ has quit IRC09:47
openstackgerritLee Yarwood proposed openstack/nova master: Add functional test for bug 1550919  https://review.opendev.org/63129410:00
openstackbug 1550919 in OpenStack Compute (nova) "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Lee Yarwood (lyarwood)10:00
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Don't delete disks on shared storage during evacuate  https://review.opendev.org/57884610:00
lyarwoodstephenfin: ^ blast from the past, you were pretty happy with this a while ago if you have anytime today to take another look?10:01
*** ociuhandu_ has quit IRC10:01
stephenfinSure. I've my head stuck into something rn though so it might be tomorrow10:01
*** ociuhandu has joined #openstack-nova10:02
lyarwoodack np10:02
*** derekh has joined #openstack-nova10:20
*** dpawlik has quit IRC10:21
*** hrw has quit IRC10:28
openstackgerritsean mooney proposed openstack/nova master: Delete ARQs by UUID if Cyborg ARQ bind fails.  https://review.opendev.org/71618610:34
openstackgerritsean mooney proposed openstack/nova master: cyborg evacuate support  https://review.opendev.org/71532610:34
*** udesale_ has joined #openstack-nova10:36
*** udesale has quit IRC10:38
sean-k-mooneygibi: procedual question for you. do i need to file a spec for ^ or a blueprint?10:46
sean-k-mooneygibi: the first patch is clearly a bug but i likely wont have time to complete all the other move operation for cyborg this cycle at least not unless we finish the numa in placment work before m1 or m210:47
sean-k-mooneygibi: so i would like to get rebuild/evacuate merged but not sure ill get much more done in the near term10:47
sean-k-mooneywould you be oke tracking rebuild/evacuate via a bug or speclesss blueprint?10:48
gibisean-k-mooney: re: image cache, I will keep the pre-filter impl independent from the disable cache impl so we can decide about the backport independently10:49
sean-k-mooneygibi: ya i think that makes sense10:50
sean-k-mooneygibi: the disable config option is much simpler to backport but is really just a workaround10:50
gibisean-k-mooney: about cyborg + evac I think at least a bp is needed for tracking10:50
sean-k-mooneygibi: ok ill file one so10:50
sean-k-mooneyfor the provider.yaml work im going to copy paste the spec form last cycle and repopose it10:51
gibisean-k-mooney: provider yaml was re-proposed already10:51
sean-k-mooneyoh ok cool10:51
gibihttps://review.opendev.org/#/c/725788/10:51
gibiI think tony_su from intel is willing to take it over10:52
sean-k-mooneyok cool. the only feedback that was pending was consolidating the negitive test into a yaml file or the posityve into python so they are consistnet10:53
sean-k-mooneyif they can take it over then cool i can spend a little time working on it this cycle if it merges early i.e. if we can get it dont before m110:53
gibiOK10:56
*** songwenping_ has joined #openstack-nova11:00
*** songwenping__ has quit IRC11:03
*** rpittau is now known as rpittau|bbl11:04
gibisean-k-mooney: also it would be nice to check brinzhang_ and the cyborg team about supporting other server operations with cyborg in V. I assume they would like to continue that work so you can join forces11:06
brinzhang_gibi, sean-k-mooney: if you have some idea that you can add that in https://etherpad.opendev.org/p/cyborg-victoria-goals, that will be discuss in PTG11:08
sean-k-mooneygibi: ya maybe. honestly i dont think its that much work to make it work. its a littel non tivaial but it can be done iteritivly11:08
gibisean-k-mooney: sure, I'm not talking about evac specially, but all the missing / unsupported server operation in general.11:09
sean-k-mooneybrinzhang_: well it was more just completeing the list here https://review.opendev.org/#/c/715326/10/api-guide/source/accelerator-support.rst11:09
huaqianghi, I have a question I wonder if anyone can give me some comment or deliver a conclusion directly. Does it tolerate to loose some information in a process of 'versioned_object.obj_to_primitive'? especially generating a primitive dict in a lower version number.11:09
sean-k-mooneyeverything except for live migrate should be doable11:10
sean-k-mooneygibi: ya i was originally planning to submit a patch for each of them im unst unlikely to have time to do that this cycle. that said i might work on it on and off this cycle.11:11
brinzhang_sean-k-mooney, gibi: yeah, in accelerator-support.rst marked unsuport all need to be consider to support, as sean-k-mooney said  except for live migrate11:11
sean-k-mooneybrinzhang_: suspend/resume and shelve/unshelve should be fairly simple to do11:12
gibibrinzhang_: do you or the cyborg team will have bandwidth during V to work on adding support for the missing operations?11:12
sean-k-mooneyresize/coldmigreate needs a little more work but they are effectvly the same operation11:12
brinzhang_sean-k-mooney: got it ^11:13
gibihuaqiang: if you generate a lower version dict then you need to drop the fields that was not present in that lower version. So that is a necessary loss of information. Other than that I think we tend to keep the information. I think dansmith is the best person to ask11:14
brinzhang_gibi: yes, we will, during V we will open block operation asap, but we should talked in PTG,11:14
gibibrinzhang_: OK. Thanks. I just wanted to make sure that you and sean-k-mooney are in sync about who does what in V11:15
sean-k-mooneybrinzhang_: there should not be any gaps in cyborg by the way for the remaining ops11:16
sean-k-mooneyits all jus nova work11:16
gibibrinzhang_: checked https://review.opendev.org/#/c/719720/ and I left one comment about the password length11:17
sean-k-mooneysuspend/resume just need to be exteded to hot unplug the acclerator on suspend and hot plug them on resume like we do for normla pci passtough or sriov devices11:17
brinzhang_gibi: I follow sean-k-mooney, many operation may I cannt test, because of limit the hard device11:17
gibibrinzhang_: I hope we can add functional test cases for most of it.11:17
sean-k-mooneysheleve need to delete the arq binding in shelve offload and it need to claim(in placmemnt) the acclerateor and bind arques on unshelve11:17
sean-k-mooneygibi: we can test most of it with the fake dirver too11:18
gibicool11:18
sean-k-mooneywe might want to add some extra logging in placese to be extra sure or enhance it slightly so we have something observable11:19
brinzhang_sean-k-mooney: cool, thanks, I will try to test that scenario11:19
sean-k-mooneye.g. adding or remvoing an xml comment for example instead of doing nothing so we can se the fake device "added" or "removed"11:20
brinzhang_sean-k-mooney: I add your said in my list, I will check these thing, e.g. log, and suspend/resume or shelve/unshelve11:22
*** ociuhandu has quit IRC11:23
gibilyarwood: hi! I see a lot of rescue failure in the lvm job http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22cannot%20be%20rescued%5C%22 is it a known issue?11:25
huaqianggibi: Got. so the 'obj_to_primitive' offers the capability to run, but not with the full object function.11:25
sean-k-mooneyhuaqiang: its not that it does not have full fucntion11:25
sean-k-mooneyits more that any feature that depends on data only contained in a later version cannot be used11:26
sean-k-mooneyhuaqiang: when you are backleveling object you baseically are restited to the feature set of the oldest code base invovled in the rpc11:27
huaqiangI am think my design for 'mixed-instance', that is an instance mixed with dedicated cpus and shared cpus, when I deal with the compatibility 'instanceNUMATopology', maybe one choice is dropping the dedicated CPUs directly11:28
sean-k-mooneythere are some expctions to that but in generall we dont try to caluate the valuse in new codebases if the object was created in an older version11:28
*** salmankhan1 has joined #openstack-nova11:28
*** salmankhan has quit IRC11:28
*** salmankhan1 is now known as salmankhan11:28
sean-k-mooneyhuaqiang: well there are two cases11:29
huaqiangsean-k-mooney: pls11:29
sean-k-mooneyif a field existied in an older version  but the value was not supported we raise an excpetion if you try to backlevel it11:29
sean-k-mooneybut if the filed does not exist we remove the filed11:30
sean-k-mooneylet me find an example quick11:30
huaqiangyes...11:30
sean-k-mooneyhttps://github.com/openstack/nova/blob/master/nova/objects/image_meta.py#L194-L20011:30
sean-k-mooneyso in 1.22 we extended the hw_video_model filed11:31
huaqiangYes. raised an exception11:32
sean-k-mooneyif an object was created using one of the values that was only supported in 1.22+ we raise an excption11:32
sean-k-mooneybut for hw_time_hpet when it is backleveled it is dropped11:32
sean-k-mooneyso for your feature11:32
*** dpawlik has joined #openstack-nova11:32
sean-k-mooneywe would raise an excpetion for the cpu policy11:32
sean-k-mooneye.g. you would not be allowed to backevel an object with cpu_policy=mixed11:33
huaqiangYes. I agree11:33
sean-k-mooneybecause that woudl result in incorrect behavior11:33
huaqianghow about InstanceNUMACell11:33
huaqiangthe closest example is this:https://github.com/openstack/nova/blob/master/nova/objects/numa.py#L4911:34
huaqiangIt dropped the host 'pcpuset' directly11:34
sean-k-mooneyyes11:35
huaqiangNot translate the pcpuset to exsiting cpuset11:35
sean-k-mooneyso for mixed cpus you should not need to modify the OVOs out side fo adding the new value for the cpu policy correct11:35
sean-k-mooneywe dont need to modify the host cell object11:36
huaqiangI don't11:36
brinzhang_gibi: can you open this link http://people.redhat.com/pbonzini/qemu-test-doc/_build/html/topics/vnc_005fsecurity.html11:36
sean-k-mooneyso the allowed values of https://github.com/openstack/nova/blob/master/nova/objects/instance_numa.py#L59 will change11:36
sean-k-mooneybut the cpu_pinning_raw value can be used in both the dedicated or mixed case11:37
sean-k-mooneyin the dedicated case it will have an entry for all cpus11:37
sean-k-mooneyin the mixed case it will have a mapping only for the pinned cpus and the floating cpus will not be listed11:37
gibibrinzhang_: yes. Now I see where the limit is coming from. Maybe link this in the spec11:38
brinzhang_gibi: Ok, I will add this to spec11:38
gibibrinzhang_: cool, thanks!11:38
huaqiangsean-k-mooney: yes. cpu_pinning_raw for pinned cpus only11:38
sean-k-mooneyso what you will need to do is add a line here https://github.com/openstack/nova/blob/master/nova/objects/instance_numa.py#L4211:39
huaqiangsean-k-mooney: https://review.opendev.org/#/c/716267/5/nova/objects/instance_numa.py11:39
sean-k-mooneywhich will raise an excpetion if you try to backlevel an object with the policy set to mixed and i think that is all11:40
sean-k-mooneyhuaqiang: yep exactly11:40
huaqiangFor in 'obj_make_compatible' for version 1.6, we have choice to through a exception11:40
huaqiangand we have another choice to ' primitive.pop('pcpuset', None)' in generating version prior to 1.511:41
huaqiangI am thinking which one is better11:41
sean-k-mooneythat the thing we dont have a choice11:41
sean-k-mooneyfor 1.6 we have to raise an excption11:42
sean-k-mooneyif we dropped the value then we would cahgne form mixed to shared11:42
sean-k-mooneythat is wrong11:42
huaqiangYes. I don't allow change from a mixed to shared11:42
huaqiangsound reasonable11:42
sean-k-mooneyi think what is being done for 1.5 and 1.6 in those patches is correct11:43
huaqiangsean-k-mooney: Thanks11:44
huaqiangIt is clear for me.11:44
huaqiangsean-k-mooney: another thing11:45
huaqiangsince v1.6 is not compatible with v1.511:46
huaqiangshould be bump the major version number?11:46
openstackgerritBrin Zhang proposed openstack/nova-specs master: Re-proposes 'Proposal for a safer remote console with password authentication'  https://review.opendev.org/71972011:46
sean-k-mooneywe dont really use the major version number11:46
brinzhang_gibi: done, thanks11:46
huaqiangs/should be/ should we/11:46
sean-k-mooneybut we could i guess11:46
sean-k-mooneythat wone i would want dansmith to weigh in on as i dont know why we dont bump the major version11:47
sean-k-mooneyproably because its only conditionally incompatiable11:47
huaqiangI'll leave it for revewer for designe11:47
huaqiangs/designe/decision/11:47
sean-k-mooneye.g. if you are using shraed or dedicated we can backlevel it11:47
sean-k-mooneyso since it not a hard incompatiablity we dont need to modify the major version11:48
huaqiangit true.11:48
*** brinzhang_ has quit IRC11:48
huaqiangok, thanks11:48
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.PY2 and six.PY3  https://review.opendev.org/72651211:49
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.add_metaclass  https://review.opendev.org/72656511:49
gibibrtknr: thanks, +211:49
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.reraise  https://review.opendev.org/72689811:49
brtknrgibi: wp11:50
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.moves  https://review.opendev.org/72722411:50
gibibrtknr: sorry11:50
brtknrnp :)11:50
openstackgerritsean mooney proposed openstack/nova master: Provider Config File: YAML file loading and schema validation  https://review.opendev.org/67334111:52
openstackgerritsean mooney proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs  https://review.opendev.org/67602911:52
openstackgerritsean mooney proposed openstack/nova master: Provider Config File: Functions to merge provider configs to provider tree  https://review.opendev.org/67652211:52
openstackgerritsean mooney proposed openstack/nova master: Provider Config File: Enable loading and merging of provider configs  https://review.opendev.org/69346011:52
sean-k-mooneygibi: that is just a strait rebae with the merge conflicts and pep8 issues resolved by the way so its basically the same as the previous version11:53
gibisean-k-mooney: thanks. you and tony_su should sync on who will work on that patch series11:54
sean-k-mooneygibi: yep11:55
sean-k-mooneytony_su: if you want to take it over and have time to adress https://review.opendev.org/#/c/676029/34/nova/tests/unit/compute/test_provider_config.py@174 that was the only open item form last cycle i belive11:56
sean-k-mooneyok i have been awaked since 3:30 and working more or less since 4:30 so im going to take a break for a few hours. ill be back after i have lunch and relax for a bit11:59
*** martinkennelly has quit IRC12:01
*** ociuhandu has joined #openstack-nova12:04
*** raildo has joined #openstack-nova12:05
gibisean-k-mooney: have a nice lunch12:09
*** ociuhandu has quit IRC12:10
*** ociuhandu has joined #openstack-nova12:10
*** mriedem has joined #openstack-nova12:16
*** rpittau|bbl is now known as rpittau12:19
jkulikanybody else experiencing problems with querying /servers for multiple uuids? nova seems to only get one uuid for filtering. I guess the MultiDict used by webob.Request gets botched here https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L178 see http://paste.openstack.org/show/793512/ for some python-console fuu showing the problem12:22
jkulikdocs for the MultiDict stuff https://docs.pylonsproject.org/projects/webob/en/stable/reference.html#query-post-variables12:23
*** tkajinam has quit IRC12:24
*** ociuhandu has quit IRC12:27
*** ociuhandu has joined #openstack-nova12:28
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.moves  https://review.opendev.org/72722412:28
jkulikshould I just open a bug report if I fear something is broken instead of asking on IRC for someone to confirm?12:29
sean-k-mooneyjkulik: im not sure if this is actully supported12:30
jkulikoh, down the line it's checked against a list12:30
jkuliklet me find that part again12:30
sean-k-mooneyjkulik: the servers endpoint only supprot one uuid https://docs.openstack.org/api-ref/compute/?expanded=show-server-details-detail#show-server-details12:31
sean-k-mooneynot a list of them12:31
sean-k-mooneyat least the server detials endpoint12:32
jkulikindex does support more in theory, though. it ends up here in the end https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L1849-L185412:32
jkulikoh, I mean query params to /servers or /servers/detail12:33
sean-k-mooneywell the docs text is12:33
sean-k-mooneyright so its not supported for /servers/detail12:33
sean-k-mooneywell i guess it might be12:33
sean-k-mooneythe docs text reads12:34
sean-k-mooneyuuid (Optional)12:34
sean-k-mooney12:34
sean-k-mooneyquery12:34
sean-k-mooney12:34
sean-k-mooneystring12:34
sean-k-mooney12:34
sean-k-mooneyFilter the server list result by the UUID of the server.12:34
sean-k-mooneyThis parameter is only valid when specified by administrators. If non-admin users specify this parameter, it is ignored.12:34
sean-k-mooneyso based on the docs we dont supprot it12:34
jkulikit would explicitly state that's it supports a list?12:34
sean-k-mooneyit might be possibel but its not intended to work12:34
sean-k-mooneyit filters the list of servers by the uuid12:35
jkulik(because for neutron ports "id", it looked the same but works)12:35
sean-k-mooneyit does not say it supports a list of uuids12:35
jkuliksure, but the code has extra ifs for a list ;)12:35
jkulikhttps://github.com/openstack/nova/blob/master/nova/compute/api.py#L2838-L284112:36
sean-k-mooneyjkulik: do we have api test for the list case12:36
jkulikhaven't checked. will do.12:36
*** lpetrut has quit IRC12:46
*** nweinber has joined #openstack-nova12:47
jkulikcan't find any in the unit-tests at least. for a lot of other query-params, there are tests, but uuid doesn't seem to be in there.12:48
sean-k-mooneyjkulik: looking at the code if ti ever worke i suspect it was a nova v2 or nova v1 capablity that was never fully supproted and is not supproted anymore12:49
jkuliklooking at the code, it seems totally supported, if we would just convert the MultiDict's multiple entries to a list instead12:50
sean-k-mooneyhttps://github.com/openstack/nova/commit/3f35fe6a88672ea2ab7e080a55235c5cca45dc2c12:50
sean-k-mooneythat code is related to listing instance by ip12:51
sean-k-mooneyjkulik: its not for listing servers by uuid12:51
francoisplyarwood, bauzas hello, when you get a chance: https://review.opendev.org/#/c/726508/ (this time around for Queens) - thanks!12:51
bauzasack, will look12:52
sean-k-mooneyjkulik: we support a list there becasue you can have multiple servers with the same ip adress12:52
sean-k-mooneybut we dont support the uuid query arg being a list12:52
jkuliksean-k-mooney, but is uses the uuid key out of search_opts which comes from the query-params12:53
jkulikwhich cannot be a list because it's broken12:53
sean-k-mooneyjkulik: the  uuid quey arg is not ment to be a list12:53
sean-k-mooneyit susing it here so you can filter by ip and uuid12:53
jkulikmy use-case would be retrieving infos for multiple servers I know the UUID of in one request btw.12:53
sean-k-mooneythe docs say uuid singualr12:54
sean-k-mooneyjkulik: yep which as far as im aware we do not support12:54
jkuliksure. the docs say the same for "id" in ports, so I didn't think that's so important ;)12:54
jkulikand since search_opts gets passed down to the db layer in the end, which also can support a list, we would just have to adjust that one line to make it work12:55
sean-k-mooneygmann: your one of our api experst do you know if we have ever supported filtering server list by a list of uuids12:55
jkulikbut if it's not supposed to, that's fine, too. I just think the code would support it.12:55
*** martinkennelly has joined #openstack-nova12:55
sean-k-mooneyjkulik: there is a difference between things that work as a result of internal impemnstion details and what is actully supported12:55
jkuliksean-k-mooney, thanks for looking at it :)12:56
sean-k-mooneyjkulik: this is the relevent spec for filtering https://specs.openstack.org/openstack/nova-specs/specs/ocata/implemented/add-whitelist-for-server-list-filter-sort-parameters.html12:57
sean-k-mooneyjkulik: so i think we suport filterign with a singel value but not lists or any advance queries.13:00
*** ttsiouts has quit IRC13:04
*** ratailor has quit IRC13:04
jkulikI don't see any mentioning of either in the spec, but I can live with the answer "works as designed".13:05
sean-k-mooneyit is a feature you could request or propose as a blueprit/spec.13:07
sean-k-mooneyi belive its working as designed currently13:07
sean-k-mooneybut i dont nessicaly thing it woudl be too contovertall to add support for what you want13:07
sean-k-mooneyits just not a bug since i dont think it was ever inteded to wrok13:07
*** ttsiouts has joined #openstack-nova13:13
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.iteritems/itervalues/iterkeys  https://review.opendev.org/72775713:18
openstackgerritLee Yarwood proposed openstack/nova master: Add functional test for bug 1550919  https://review.opendev.org/63129413:21
openstackbug 1550919 in OpenStack Compute (nova) "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Lee Yarwood (lyarwood)13:21
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Don't delete disks on shared storage during evacuate  https://review.opendev.org/57884613:21
*** lbragstad has joined #openstack-nova13:23
*** ociuhandu has quit IRC13:24
*** sapd1_x has quit IRC13:31
*** ttsiouts has quit IRC13:32
*** redrobot has joined #openstack-nova13:34
jkulikfunctional tests don't support testing the "uuid as list" case either https://github.com/openstack/nova/blob/master/nova/tests/functional/api/client.py#L248-L25013:39
*** READ10 has joined #openstack-nova13:39
jkulikthe lack of tests for 'uuid' in search_opts isn't good, though :D13:39
*** efried has joined #openstack-nova13:44
sean-k-mooneyjkulik: yep again i think that is becasue we did not orginally plan to expose this via the api and retroactivly had to try and fix it13:45
openstackgerritJiri Suchomel proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD  https://review.opendev.org/57430113:46
*** liuyulong has joined #openstack-nova13:49
*** jamesdenton has quit IRC14:03
*** ociuhandu has joined #openstack-nova14:05
*** ociuhandu has quit IRC14:11
*** jamesdenton has joined #openstack-nova14:11
*** ttsiouts has joined #openstack-nova14:12
*** ociuhandu has joined #openstack-nova14:12
*** ttsiouts has quit IRC14:17
*** ociuhandu has quit IRC14:18
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.byte2int/int2byte  https://review.opendev.org/72777714:24
*** lpetrut has joined #openstack-nova14:29
*** ociuhandu has joined #openstack-nova14:33
gmannjkulik: sean-k-mooney yeah, multi filters things are not supported.  for this case where you want to list multiple servers you can use some other query filter which matches multiple servers. like ?name=test so it will return all servers matching with 'test*'14:34
gmannremember, multiple filters are with AND condition14:35
gmannin current behaviour only last present item is being used even you are asking for multi dict14:38
*** ociuhandu has quit IRC14:39
gmannjkulik: it should not be hard to support that, we just need to change the way we fetch filter from GET and query DB with OR condition.14:41
gmannjkulik: anyways, all API change need spec process, please feel free to add BP and spec for the same14:41
*** mlavalle has joined #openstack-nova14:42
*** dklyle has joined #openstack-nova14:42
gmannbut remember any other filter present with mutli dict filter will be with AND condition. so you would not be able to do 'server-uuid1 OR (server-uuid2 AND vm_state=active)' it will be '(server-uuid1 OR server-uuid2) AND vm_state=active)'14:43
*** ociuhandu has joined #openstack-nova15:01
*** priteau has joined #openstack-nova15:01
*** links has quit IRC15:02
*** lpetrut has quit IRC15:08
*** JamesBenson has joined #openstack-nova15:16
*** belmoreira has quit IRC15:24
* gibi hates the imagebackend code15:31
lyarwoodwe should start a club :)15:32
lyarwoodgibi: I've not had a chance to look at your caching change btw, I'll try to get to it tomorrow15:33
gibilyarwood: dont rush it is a very incomplete messy pile of boo15:34
gibilyarwood: I just figured out that the current imagebacked code my temporarily use double of the image size disk space. For example if an image is a qcow in glance but nova configured to force_raw_images then after image download we copy out the raw data from qcow and the delete the qcow file we downloaded :/15:36
*** dtantsur is now known as dtantsur|afk15:36
gibis/my/might/15:36
gibiwho thought that we will have disk space for that operation?!15:36
gibiI get to feel that I have no power to patch this code in a way I imagined15:38
dansmithlyarwood: is it a club if everyone is a member?15:38
dansmithI think that's called "a population"15:38
dansmithgibi: did you catch the scrollback of our convo yesterday?15:39
lyarwooddansmith: ^_^15:39
lyarwoodgibi: yeah I don't think we can convert in-place tbh15:39
gibidansmith: yes. but honestly I have to go back to it as I already forget what was the pre-filter idea15:40
*** tesseract has quit IRC15:40
dansmithgibi: so, I think it's not unreasonable to say "to boot an instance of $root from an image of $imgsize, the host needs to have $root+$imgsize free space, as a rule15:40
dansmithalthough you know what..15:41
dansmithI think we were totally missing something yesterday, now that I re-state that with a fresh mind15:41
* gibi is listening15:41
*** jamesdenton has quit IRC15:42
dansmithfor that to even help, we have to account for the base in the inventory or allocations somehow, which is what we were trying to avoid there15:42
dansmithso, hrmph15:42
dansmithgibi: I will say that although I understand the desire to disable the cache as a workaround, it's really not a useful solution for anything other than a very small subset of cases15:43
dansmithi.e. where you expect only one of each image type to be booted in a disk-constrained place anyway15:43
*** gyee has joined #openstack-nova15:43
gibiand I think it is pretty impossible to do properly due to what assumption the code currently makes15:43
dansmithso I wouldn't want to spend a bunch of effort or cause a bunch of destabilization in the image backend to do so15:43
dansmithgibi: right, hence my concern yesterday :)15:43
gibiI needed to feel the pain to understand :)15:44
dansmith:D15:44
*** jamesdenton has joined #openstack-nova15:46
dansmithgibi: so, one thing I was wondering15:47
gibieven if we start making allocation according to the images in the cache, the current code sometimes copy things over for conversions and that doubles the disk usage temporarly, or fail if no disk space for such operation15:47
*** sapd1_x has joined #openstack-nova15:47
dansmithgibi: did you find somewhere that the DiskFilter considered the size of the image? Because even considering disk free space, you don't know if the target host will need room for the image (if it's not cached) PLUS the root, etc disks as well15:47
dansmithbecause I don't think it really took that into account.. i.e. adding the flavor disks and the possible space required for a separate image15:48
gibiDiskFilter used the disk_available_least value from the DB. There we count current available free space in the $instances_path (among other things)15:49
dansmithgibi: yeah, and like I said yesterday if we start doing allocations for images, we have a lot of cases we need to cover, a lot of new potential needs for healing that data, etc.. it concerns me to make a decision to start doing that so quickly15:49
gibidansmith: ^^ agree15:49
dansmithgibi: right, but the scheduler only looks to see if root+swap+ephemeral will fit in that space, but it may still fail because the compute node doesn't have the image cached already and thus need root+swap+ephemeral+image space to do the work15:50
dansmithit's less of a problem, but it's similar15:50
gibicorrect (shit, another edge case)15:50
dansmithso here's a couple of less impactful options:15:52
dansmith1. Each time we cache an image, or run the periodic, we generate a disk allocation for the compute node uuid which consumes inventory according to how much space the cache is using15:52
dansmith2. Same as above, but adjust the reserved amount15:53
dansmithboth cases need to consider the case where the _base is not on the same filesystem as the instances, but there's less synchronization involved, and we're not spraying tons of new allocations into place15:53
dansmithwe could also make it a workaround that you opt into in the short term to see how it goes, because cleanup from it would be much easier (just nuke one $cnuuid allocation)15:54
dansmithand we could make compute node startup nuke that allocation if present and the workaround is disabled (or the self-correcting reserved amount)15:55
gibiright, I would use allocation instead of reserved as allocation has a consumer attached15:55
gibireserved would be a sum of configured + detected15:56
gibiwhich is math, that I dont like :)15:56
dansmithhopefully glance gives us enough information to be able to increase that allocation before we start the download, so we know "oh sorry, inventory says we don't have room for this base image, so fail()"15:56
dansmithI know it would, but I think reserved would be more obvious to an operator15:56
dansmitheven though it's a composite value15:57
dansmithjust because listing allocations are a bunch of meaningless-to-the-human UUIDs15:57
dansmithI'm not arguing for that, I'm just saying there're benefits both ways15:57
gibiI see. yes it is a tradeoff15:57
dansmithI gotta get on a call15:58
dansmithfood for thought15:58
gibidansmith: thanks! I appreciate your help15:59
gibiI've checked. glance give use the physical size of the image on the API. Which is good for ensuring we have still disk for the download16:00
gibialso I think even if nova is converting a qcow2 glace image to raw locally (due to force_raw_images config) the resulting raw file is sparse16:02
gibibut it might dependent on the host OS + file system support16:02
*** maciejjozefczyk has quit IRC16:04
*** jamesdenton has quit IRC16:16
*** liuyulong has quit IRC16:17
*** rpittau is now known as rpittau|afk16:21
*** gary_perkins has quit IRC16:23
*** gary_perkins has joined #openstack-nova16:24
gibidansmith: if we start allocating / reserving the cache disk usage in placement then do we still need a pre-filter as well?  For me it is OK to simply let the boot fail on the compute side if the extra DISK_GB resource for the cache cannot be allocated?16:26
gibis/?//16:27
gibianyhow documented your idea in the bug report16:27
dansmithgibi: weighing aside, any compute with enough space for an instance but not enough for the instance+image will become a magnet for new builds, which will all fail16:27
dansmithso, yeah, we can just pretend that's not worth solving, but it also sucks because avoiding that is what we're trying to solve with placement16:28
gibiOK, I can imagine this as a two step solution then. First the allocation / reservation management in the compute then second the pre-filter that uses instance + image DISK_GB request but allocate only the instance disk for the instance_uuid in placement16:31
dansmithperhaps16:32
*** udesale_ has quit IRC16:33
*** evrardjp has quit IRC16:36
*** evrardjp has joined #openstack-nova16:36
*** jamesdenton has joined #openstack-nova16:38
*** sapd1_x has quit IRC16:40
openstackgerritmelanie witt proposed openstack/nova master: DNM Try out running sphinx-build in parallel for releasenotes  https://review.opendev.org/72742916:40
*** sapd__x has joined #openstack-nova16:40
*** ociuhandu has quit IRC16:42
*** ociuhandu has joined #openstack-nova16:43
*** ociuhandu has quit IRC16:43
*** ociuhandu has joined #openstack-nova16:43
openstackgerritBalazs Gibizer proposed openstack/nova master: WIP: allow disabling image cache for raw images  https://review.opendev.org/72726116:48
*** grandchild has joined #openstack-nova17:01
*** derekh has quit IRC17:03
*** jamesdenton has quit IRC17:15
*** ociuhandu has quit IRC17:21
*** nightmare_unreal has quit IRC17:22
*** salmankhan has quit IRC17:22
*** ociuhandu has joined #openstack-nova17:23
openstackgerritmelanie witt proposed openstack/nova master: DNM Try out running sphinx-build in parallel for releasenotes  https://review.opendev.org/72742917:23
*** hemna_ has quit IRC17:29
*** hemna has joined #openstack-nova17:29
*** ociuhandu has quit IRC17:33
*** ociuhandu has joined #openstack-nova17:34
*** dpawlik has quit IRC17:36
*** priteau has quit IRC17:38
*** ociuhandu has quit IRC17:40
*** ralonsoh has quit IRC17:44
*** jamesdenton has joined #openstack-nova17:57
*** jamesdenton has quit IRC18:04
*** jamesdenton has joined #openstack-nova18:09
*** sapd__x has quit IRC18:31
*** ociuhandu has joined #openstack-nova18:32
*** ociuhandu has quit IRC18:40
*** ociuhandu has joined #openstack-nova18:40
*** READ10 has quit IRC18:41
*** jamesdenton has quit IRC18:53
*** jamesdenton has joined #openstack-nova18:57
*** belmoreira has joined #openstack-nova19:05
openstackgerritJiri Suchomel proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD  https://review.opendev.org/57430119:05
*** maciejjozefczyk has joined #openstack-nova19:08
*** maciejjozefczyk has quit IRC19:25
*** ociuhandu has quit IRC19:27
*** ociuhandu has joined #openstack-nova19:28
*** dklyle has quit IRC19:38
*** ociuhandu has quit IRC19:39
*** ociuhandu has joined #openstack-nova19:40
*** ociuhandu has quit IRC19:40
*** ociuhandu has joined #openstack-nova19:40
*** dklyle has joined #openstack-nova19:46
*** ociuhandu has quit IRC19:51
*** ociuhandu has joined #openstack-nova19:52
*** ociuhandu has quit IRC19:52
*** ociuhandu has joined #openstack-nova19:52
*** martinkennelly has quit IRC19:57
*** ociuhandu has quit IRC20:02
*** jsuchome has quit IRC20:02
*** ociuhandu has joined #openstack-nova20:03
*** ociuhandu has quit IRC20:03
*** ociuhandu has joined #openstack-nova20:03
*** belmoreira has quit IRC20:07
*** ttsiouts has joined #openstack-nova20:13
*** ociuhandu has quit IRC20:14
*** ociuhandu has joined #openstack-nova20:15
*** jamesdenton has quit IRC20:16
openstackgerritmelanie witt proposed openstack/nova master: DNM Try out running sphinx-build in parallel for releasenotes  https://review.opendev.org/72742920:20
*** ociuhandu has quit IRC20:26
*** ociuhandu has joined #openstack-nova20:27
*** ociuhandu has quit IRC20:27
*** ociuhandu has joined #openstack-nova20:27
*** ttsiouts has quit IRC20:30
*** jamesdenton has joined #openstack-nova20:30
*** vishalmanchanda has quit IRC20:31
*** ttsiouts has joined #openstack-nova20:32
*** ociuhandu has quit IRC20:37
*** ociuhandu has joined #openstack-nova20:38
*** ociuhandu has quit IRC20:38
*** ociuhandu has joined #openstack-nova20:39
*** ociuhandu has quit IRC20:49
*** ociuhandu has joined #openstack-nova20:50
*** ociuhandu has quit IRC20:50
*** ociuhandu has joined #openstack-nova20:50
openstackgerritSean McGinnis proposed openstack/nova master: DNM: Test making EM branch release notes static  https://review.opendev.org/72787520:54
*** ccamacho has quit IRC20:54
*** ociuhandu has quit IRC21:01
*** ociuhandu has joined #openstack-nova21:02
*** ociuhandu has quit IRC21:07
*** nweinber has quit IRC21:10
*** damien_r has quit IRC21:19
*** jamesdenton has quit IRC21:30
*** mriedem has left #openstack-nova21:34
*** awalende has quit IRC21:38
*** awalende has joined #openstack-nova21:39
*** awalende has quit IRC21:43
*** raildo has quit IRC21:46
*** slaweq has quit IRC21:57
*** spatel has joined #openstack-nova22:08
*** slaweq has joined #openstack-nova22:09
*** spatel has quit IRC22:12
*** grandchild has quit IRC22:12
*** slaweq has quit IRC22:13
*** CeeMac has quit IRC22:16
*** JamesBenson has quit IRC22:18
*** spatel has joined #openstack-nova22:20
*** slaweq has joined #openstack-nova22:23
*** slaweq has quit IRC22:28
*** tbachman has quit IRC22:36
*** ttsiouts has quit IRC22:43
*** ttsiouts has joined #openstack-nova22:44
*** spatel has quit IRC22:45
*** tkajinam has joined #openstack-nova22:46
*** hongbin has joined #openstack-nova23:05
*** tosky has quit IRC23:06
melwittgmann: do you understand why even after version bump we can get pep8 errors in gate? https://review.opendev.org/72758923:15
gmannmelwitt: it would be an error now as hacking min version bump will stop the new checks added in flake8 3.8.0 version.23:18
gmannthis one- https://review.opendev.org/#/c/727347/123:18
melwittgmann: yeah but... (sorry) I thought bumping the version _stops_ the new checks from getting pulled in>23:19
melwitts/>/?/23:19
gmannsorry *would not be an error23:19
gmannmissing *not*23:19
melwittok, makes sense. so why second patch needed? is it nice to have for future flake8 or something>23:20
melwittgah I keep hitting >23:20
gmannyeah for future but we will not be able to verify it or all error till we have new hacking pulling new checks.23:21
melwittyeah, ok.23:21
gmannI am going to release the new hacking version 4.0.0 which will pull new checks and then in 727589 patch we will bump hacking version to so that we can verify the fix23:21
gmannI mean fix + new hacking version bump in a single patch.23:22
*** threestrands has joined #openstack-nova23:29
*** Liang__ has joined #openstack-nova23:29
*** tbachman has joined #openstack-nova23:30
*** rcernin has quit IRC23:31
melwittgmann: yeah makes sense. +2 on the 3.0.1 patch though I wondered if it's needed to avoid gate failures, would have thought we'd have a gate-failure bug around it. that is, it wasn't clear to me if the patch is needed to fix gate failure23:31
*** rcernin has joined #openstack-nova23:32
gmannmelwitt: I did nova patch earlier before i described the situation in other patches cmt msg like this- https://review.opendev.org/#/c/727576/23:34
gmannmelwitt: basically it will 1. fix local run where the latest fixed hacking 3.0.1 is not pulled automatically. in case of gate it is pulled as fresh installation. 2. it will protect if future flake8 3.9.0 version pull other new checks.23:35
melwittah I see23:35
melwittoh ok so not a gate issue23:35
melwittcool thanks for explaining23:36
melwittI was confused before heh23:36
*** ociuhandu has joined #openstack-nova23:36
gmannotherwise hacking before 3.0.1 is capping "flake8<4.0.0" so flake8 3.8.0 which ic current release and 3.9.0 future release both can be protected by bumping hacking to 3.0.123:37
melwittright23:37
melwittyeah, so needed for future23:37
gmannit is actually confusing as all inbuild deps actually. hacking does protect cap for flake8 and flake8 does protect cap for pycodestyle. but if pycodestyle is pulled as latest by some flake8 plugins then again it fail like flake8-import-order then we need pycodestyle cap explicitly. like tempest case- https://review.opendev.org/#/c/727276/2/test-requirements.txt23:39
gmannso our way of handling the flake8 with plugins is not so great.23:40
melwittwow. mind blown23:40
gmanni added PR on flake8-import-order but not sure if they will accept or not with our hacky use case :) - https://github.com/PyCQA/flake8-import-order/pull/17223:41
melwittah, good luck :)23:41
*** avolkov has quit IRC23:46
*** ociuhandu has quit IRC23:52
*** xek has joined #openstack-nova23:58
*** xek__ has quit IRC23:59

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!