*** tosky has quit IRC | 00:01 | |
mriedem | dansmith: question in that docs patch | 00:04 |
---|---|---|
*** tetsuro has joined #openstack-nova | 00:09 | |
openstackgerrit | melanie witt proposed openstack/nova master: rbd_utils: increase _destroy_volume timeout https://review.opendev.org/705764 | 00:09 |
*** mlavalle has quit IRC | 00:15 | |
*** threestrands has joined #openstack-nova | 00:19 | |
openstackgerrit | Merged openstack/nova stable/train: Revert "nova shared storage: rbd is always shared storage" https://review.opendev.org/726861 | 00:26 |
*** hamalq has quit IRC | 00:30 | |
*** francoisp has quit IRC | 00:46 | |
*** xiaolin has joined #openstack-nova | 01:03 | |
*** lbragstad has joined #openstack-nova | 01:10 | |
*** gyee has quit IRC | 01:19 | |
*** mriedem has left #openstack-nova | 01:26 | |
*** Liang__ has joined #openstack-nova | 01:56 | |
*** xiaolin has quit IRC | 01:57 | |
*** lvbin01 has quit IRC | 02:01 | |
*** lvbin01 has joined #openstack-nova | 02:01 | |
*** Yumeng has joined #openstack-nova | 02:32 | |
*** ociuhandu has joined #openstack-nova | 03:05 | |
*** sapd1_x has joined #openstack-nova | 03:08 | |
*** ociuhandu has quit IRC | 03:10 | |
openstackgerrit | Qiu Fossen proposed openstack/nova stable/stein: Update scheduler instance info at confirm resize https://review.opendev.org/729505 | 03:31 |
*** psachin has joined #openstack-nova | 03:36 | |
*** Yumeng is now known as Yumeng_ | 03:54 | |
*** Yumeng_ is now known as Yumeng | 03:55 | |
*** ratailor has joined #openstack-nova | 04:14 | |
*** lifeless has quit IRC | 04:22 | |
*** ratailor has quit IRC | 04:27 | |
*** ratailor has joined #openstack-nova | 04:28 | |
*** evrardjp has quit IRC | 04:33 | |
*** evrardjp has joined #openstack-nova | 04:33 | |
openstackgerrit | Qiu Fossen proposed openstack/nova-specs master: specify mac for creating instance https://review.opendev.org/700429 | 04:46 |
*** lifeless has joined #openstack-nova | 04:52 | |
openstackgerrit | Merged openstack/nova master: libvirt: Remove MIN_LIBVIRT_MULTIATTACH https://review.opendev.org/710238 | 04:58 |
*** lvbin02 has joined #openstack-nova | 05:02 | |
*** udesale has joined #openstack-nova | 05:04 | |
*** lvbin01 has quit IRC | 05:04 | |
*** lvbin02 is now known as lvbin01 | 05:04 | |
*** psachin has quit IRC | 05:05 | |
*** damien_r has joined #openstack-nova | 05:08 | |
*** damien_r has quit IRC | 05:12 | |
*** brinzhang_ has joined #openstack-nova | 05:14 | |
*** brinzhang has quit IRC | 05:14 | |
*** dklyle has quit IRC | 05:25 | |
*** links has joined #openstack-nova | 05:31 | |
*** ccamacho has joined #openstack-nova | 05:34 | |
*** lifeless has quit IRC | 05:41 | |
*** ccamacho has quit IRC | 05:42 | |
*** links has quit IRC | 05:43 | |
*** links has joined #openstack-nova | 05:45 | |
*** lifeless has joined #openstack-nova | 05:50 | |
*** xiaolin has joined #openstack-nova | 05:55 | |
*** brinzhang has joined #openstack-nova | 05:56 | |
*** dpawlik has joined #openstack-nova | 05:57 | |
*** brinzhang_ has quit IRC | 05:59 | |
*** brinzhang_ has joined #openstack-nova | 06:00 | |
*** brinzhang_ has quit IRC | 06:02 | |
*** brinzhang_ has joined #openstack-nova | 06:02 | |
*** brinzhang has quit IRC | 06:03 | |
*** lvbin02 has joined #openstack-nova | 06:16 | |
*** lvbin01 has quit IRC | 06:17 | |
*** lvbin02 is now known as lvbin01 | 06:17 | |
*** Liang__ has quit IRC | 06:18 | |
*** ccamacho has joined #openstack-nova | 06:19 | |
*** Liang__ has joined #openstack-nova | 06:28 | |
*** jawad_axd has joined #openstack-nova | 06:31 | |
*** brinzhang has joined #openstack-nova | 06:40 | |
openstackgerrit | Qiu Fossen proposed openstack/nova stable/stein: Update scheduler instance info at confirm resize https://review.opendev.org/729505 | 06:41 |
*** brinzhang_ has quit IRC | 06:43 | |
*** jsuchome has joined #openstack-nova | 06:44 | |
*** tbachman has quit IRC | 06:44 | |
*** mkrai has joined #openstack-nova | 06:44 | |
*** slaweq has joined #openstack-nova | 06:46 | |
*** belmoreira has joined #openstack-nova | 06:50 | |
*** ralonsoh has joined #openstack-nova | 06:50 | |
*** nightmare_unreal has joined #openstack-nova | 06:51 | |
gibi | good morning nova | 06:58 |
*** tetsuro_ has joined #openstack-nova | 07:01 | |
*** tesseract has joined #openstack-nova | 07:02 | |
*** mkrai has quit IRC | 07:04 | |
*** mkrai_ has joined #openstack-nova | 07:04 | |
*** ociuhandu has joined #openstack-nova | 07:04 | |
*** tetsuro has quit IRC | 07:04 | |
*** maciejjozefczyk has joined #openstack-nova | 07:07 | |
*** ociuhandu has quit IRC | 07:14 | |
*** ociuhandu has joined #openstack-nova | 07:14 | |
*** ttsiouts has joined #openstack-nova | 07:15 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova stable/ussuri: Reserve DISK_GB resource for the image cache https://review.opendev.org/729523 | 07:25 |
*** vishalmanchanda has joined #openstack-nova | 07:25 | |
*** ociuhandu has quit IRC | 07:27 | |
*** tosky has joined #openstack-nova | 07:30 | |
openstackgerrit | Qiu Fossen proposed openstack/nova stable/rocky: Update scheduler instance info at confirm resize https://review.opendev.org/729527 | 07:33 |
*** ttsiouts has quit IRC | 07:37 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova stable/stein: Reproduce bug 1869050 https://review.opendev.org/729530 | 07:51 |
openstack | bug 1869050 in OpenStack Compute (nova) stein "migration of anti-affinity server fails due to stale scheduler instance info" [Low,In progress] https://launchpad.net/bugs/1869050 | 07:51 |
*** tbachman has joined #openstack-nova | 07:51 | |
*** ttsiouts has joined #openstack-nova | 07:54 | |
*** mkrai_ has quit IRC | 07:55 | |
*** mkrai has joined #openstack-nova | 07:55 | |
openstackgerrit | Qiu Fossen proposed openstack/nova stable/stein: Create instance action when burying in cell0 https://review.opendev.org/729531 | 07:57 |
*** mkrai has quit IRC | 08:02 | |
*** ociuhandu has joined #openstack-nova | 08:04 | |
*** martinkennelly has joined #openstack-nova | 08:08 | |
*** hamalq has joined #openstack-nova | 08:08 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova stable/stein: Update scheduler instance info at confirm resize https://review.opendev.org/729538 | 08:10 |
openstackgerrit | Huaqiang Wang proposed openstack/nova master: Use annotated ddt for test_cpu_policy_constraint https://review.opendev.org/692205 | 08:10 |
*** huaqiang has joined #openstack-nova | 08:11 | |
*** mkrai has joined #openstack-nova | 08:11 | |
*** ociuhandu has quit IRC | 08:12 | |
lyarwood | morning \o | 08:13 |
*** ociuhandu has joined #openstack-nova | 08:15 | |
openstackgerrit | Wenping Song proposed openstack/nova master: error may occur when filter scheduler with accelerator https://review.opendev.org/722651 | 08:16 |
gibi | lyarwood: o/ | 08:17 |
openstackgerrit | Balazs Gibizer proposed openstack/nova stable/queens: Reproduce bug 1862633 https://review.opendev.org/729539 | 08:19 |
openstack | bug 1862633 in OpenStack Compute (nova) "unshelve leak allocation if update port fails" [Medium,Fix released] https://launchpad.net/bugs/1862633 - Assigned to Balazs Gibizer (balazs-gibizer) | 08:19 |
openstackgerrit | Balazs Gibizer proposed openstack/nova stable/queens: Clean up allocation if unshelve fails due to neutron https://review.opendev.org/729540 | 08:19 |
*** tkajinam has quit IRC | 08:23 | |
*** xek has joined #openstack-nova | 08:24 | |
aarents | good morning | 08:28 |
aarents | dansmith, about your yesterday interrogation, Yes we benefit of cache purge, and yes we have host with big cache usage (unremovable) that prevent to put more instance than expected. this is random. we have plenty of case where, for example a customer boot from its big snapshot(not sharable with neighborhood), or we have plenty of small image in cache all 'Debian 9' but because we maintain security | 08:29 |
aarents | update frequently on our public image, those image are different. We still have benefit to cache image, sometime a bit less. | 08:29 |
*** derekh has joined #openstack-nova | 08:35 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: Don't age swap files in the image cache https://review.opendev.org/641093 | 08:36 |
brinzhang | sean-k-mooney, gibi: hi, I have a question. If the ARQs instance in SHELVED (not shelved_offload) state, do we need to delete it's bind arqs info? | 08:43 |
brinzhang | when do shelve_instance action | 08:44 |
brinzhang | IMO, if the instance in SHELVED status, it should always occupied the arqs resources, we dont delete it's binding arqs when we shelve it, right? | 08:46 |
*** Aditi20 has joined #openstack-nova | 08:50 | |
Aditi20 | Hi, I have a doubt regarding openstack. Could you please provide me inputs? | 08:53 |
Aditi20 | is - https://opendev.org/openstack/nova/src/branch/master/nova/virt/libvirt/config.py this file creates libvirt.xml file for instances. And it doesn't have any support for nested-hv currently. | 08:53 |
*** ociuhandu has quit IRC | 09:10 | |
*** ociuhandu has joined #openstack-nova | 09:11 | |
openstackgerrit | Huaqiang Wang proposed openstack/nova master: test_hardware: code formating for multiline construct https://review.opendev.org/728793 | 09:12 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: Add admin doc information about image cache resource accounting https://review.opendev.org/729350 | 09:13 |
*** ociuhandu has quit IRC | 09:14 | |
*** ociuhandu has joined #openstack-nova | 09:14 | |
openstackgerrit | Huaqiang Wang proposed openstack/nova master: Use annotated ddt for test_cpu_policy_constraint https://review.opendev.org/692205 | 09:20 |
*** tetsuro_ has quit IRC | 09:21 | |
*** links has quit IRC | 09:22 | |
*** links has joined #openstack-nova | 09:24 | |
openstackgerrit | Huaqiang Wang proposed openstack/nova master: Use annotated ddt for test_cpu_policy_constraint https://review.opendev.org/692205 | 09:29 |
*** jraju__ has joined #openstack-nova | 09:29 | |
*** links has quit IRC | 09:30 | |
*** tetsuro has joined #openstack-nova | 09:31 | |
*** brinzhang has quit IRC | 09:35 | |
*** brinzhang has joined #openstack-nova | 09:35 | |
sean-k-mooney | brinzhang: no we only delete the ARQs in shelve offload | 09:36 |
brinzhang | sean-k-mooney: got it, I talked with alex_xu | 09:37 |
brinzhang | sean-k-monney: thanks, I will submit a poc code for unshelve/shelve instance, hope you can review that when you have free time. | 09:38 |
*** xiaolin69 has joined #openstack-nova | 09:44 | |
sean-k-mooney | my mothewr rang so ill review when im done | 09:46 |
openstackgerrit | Jiri Suchomel proposed openstack/nova master: Remove deprecated nova.image.download hook https://review.opendev.org/725338 | 09:47 |
openstackgerrit | Jiri Suchomel proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301 | 09:47 |
brinzhang | sean-k-mooney: thanks ^ | 09:47 |
openstackgerrit | Huaqiang Wang proposed openstack/nova master: [WIP] Use annotated ddt for test_cpu_policy_constraint https://review.opendev.org/692205 | 09:48 |
jsuchome | lyarwood: Hi, I've addressed your comments, in some parts we still disagree (same with some dansmith's ones btw) | 09:48 |
lyarwood | jsuchome: ack, I'll take a look now | 09:50 |
*** ociuhandu has quit IRC | 09:53 | |
*** ociuhandu has joined #openstack-nova | 09:53 | |
*** ociuhandu has quit IRC | 09:58 | |
*** ociuhandu has joined #openstack-nova | 09:59 | |
*** avolkov has joined #openstack-nova | 10:03 | |
openstackgerrit | Huaqiang Wang proposed openstack/nova master: test_hardware: show test parameter details for causing a test failure https://review.opendev.org/692205 | 10:13 |
*** Liang__ has quit IRC | 10:15 | |
*** hamalq has quit IRC | 10:21 | |
*** tetsuro has quit IRC | 10:31 | |
*** lvbin02 has joined #openstack-nova | 10:37 | |
*** tetsuro has joined #openstack-nova | 10:39 | |
*** lvbin01 has quit IRC | 10:39 | |
*** lvbin02 is now known as lvbin01 | 10:39 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: WIP: Cyborg shelve/unshelve support https://review.opendev.org/729563 | 10:47 |
*** jraju__ has quit IRC | 10:55 | |
*** raildo has joined #openstack-nova | 11:02 | |
*** ociuhandu has quit IRC | 11:03 | |
*** ociuhandu has joined #openstack-nova | 11:04 | |
*** lvbin02 has joined #openstack-nova | 11:05 | |
*** lvbin01 has quit IRC | 11:07 | |
*** lvbin02 is now known as lvbin01 | 11:07 | |
openstackgerrit | Merged openstack/nova master: trivial: Remove remaining '_LE' instances https://review.opendev.org/728963 | 11:08 |
*** ociuhandu has quit IRC | 11:11 | |
*** brinzhang_ has joined #openstack-nova | 11:14 | |
*** xiaolin has quit IRC | 11:14 | |
*** brinzhang has quit IRC | 11:17 | |
*** jraju__ has joined #openstack-nova | 11:18 | |
*** lvbin02 has joined #openstack-nova | 11:18 | |
*** ociuhandu has joined #openstack-nova | 11:19 | |
lyarwood | jsuchome: sorry was side tracked, just updated. | 11:20 |
*** brinzhang_ has quit IRC | 11:20 | |
*** lvbin01 has quit IRC | 11:20 | |
*** lvbin02 is now known as lvbin01 | 11:20 | |
*** brinzhang_ has joined #openstack-nova | 11:20 | |
lyarwood | jsuchome: apologies for the mistakes before, I really think we need to break this up a little to make the logic more clear to reviewers | 11:20 |
*** tetsuro has quit IRC | 11:23 | |
jsuchome | lyarwood: the main part is somewhat confusing, I agree ... I'm not sure though how to make it better | 11:26 |
jsuchome | maybe by moving the verification bits into different method... | 11:26 |
*** ociuhandu has quit IRC | 11:27 | |
*** sapd1_x has quit IRC | 11:41 | |
*** Luzi has joined #openstack-nova | 11:44 | |
lyarwood | jsuchome: yeah I think that would be useful | 11:52 |
brinzhang_ | sean-k-mooney: IMO, you should move https://review.opendev.org/#/c/729563/1/nova/compute/api.py@4041 this common block code to the cyborg as a common function, | 11:53 |
sean-k-mooney | yep that is more or less what i was referint too when i commented on your follow up | 11:53 |
brinzhang_ | sean-mooney: I was rebased on your patch, if I move this that you cannot call it in your patch | 11:53 |
sean-k-mooney | i noticed you wer basically doint the same thing and extracting it to a common function we can both use makes sense | 11:54 |
*** brinzhang has joined #openstack-nova | 11:55 | |
sean-k-mooney | brinzhang_: i was also being lazy and suggesting you could refactor my code :P but ill see if i can update it later today | 11:56 |
brinzhang | after you update, I will update again, to call the common function ^ | 11:56 |
brinzhang | sean-k-mooney: ok, if I have time tomorrow, I will do | 11:56 |
brinzhang | I am meeting now, after meetting , I will go home today. | 11:57 |
sean-k-mooney | brinzhang: cool no worries i have a meeting in an hour. im not sure if i will get it done before then but ill try to update it in the afternoon | 11:57 |
brinzhang | sean-k-mooney: thanks ^^ | 11:58 |
*** brinzhang_ has quit IRC | 11:58 | |
sean-k-mooney | brinzhang: while you are hear you said i should handel the excepiotn in rebuild like is done at X but the link you provded did not have any expcetion handeling | 11:58 |
sean-k-mooney | can you let me know what you wanted me to do | 11:59 |
sean-k-mooney | brinzhang: im refering to this comment https://review.opendev.org/#/c/715326/11/nova/conductor/manager.py@1232 | 11:59 |
brinzhang | create_and_bind_arqs will raise an exception, when bind failed, so I think that should catch the exception | 12:00 |
sean-k-mooney | ah right | 12:00 |
sean-k-mooney | i taught i was handeling that elsewhere but perhaps i missed updating this code path | 12:01 |
sean-k-mooney | ill take a look | 12:01 |
brinzhang | ah, you are busy in works | 12:02 |
sean-k-mooney | not too busy but im trying to start wraping my head around the numa in plamcnet code changes so im trying to context switch away form cyborg for a day or two | 12:03 |
sean-k-mooney | that said i have not really started on the numa in placment stuff yet so i still have the cyborg context loaded in my brain for the moment | 12:03 |
*** raildo has quit IRC | 12:03 | |
sean-k-mooney | im still happy to review your cyborg patches but that why im slitly distracted as im preparing a second dev env to work on the numa stuff in parallel | 12:04 |
brinzhang | I can understand you sean-k-mooney, I will try my best to do these thing, to reduce your work in cybrog | 12:04 |
brinzhang | sean-k-money: hope you can keep cyborg service in your environment, maybe need your test in your environment for some actions | 12:06 |
sean-k-mooney | brinzhang: well i actully dont mind working on the cycborg stuff its just on on our internal roadmap for the next major release e.g. 17.0 to have it productised so i have to blance it with stuff that is on our road map | 12:06 |
sean-k-mooney | brinzhang: :) that i why im setting up a second multi node dev env for numa | 12:06 |
*** raildo has joined #openstack-nova | 12:06 | |
sean-k-mooney | brinzhang: i have openstack deploy at home so im just created 2 more vms for working on numa | 12:06 |
sean-k-mooney | im keeping my cyborg vms running too | 12:07 |
brinzhang | thanks ^^ | 12:07 |
brinzhang | I have to continue my meetting sean-k-mooney | 12:08 |
nightmare_unreal | hello, sometimes when i run openstack server migrate , it does not throw any error but doesn't actually migrate. But when I run cmd again it works ( if I run it 3rd time then it throws error which is normal) | 12:13 |
nightmare_unreal | is it possible that sometimes the cmd are ignored or something ? I am not sure ( I will try to reproduce it) | 12:14 |
sean-k-mooney | nightmare_unreal: no the command should not be ignored | 12:14 |
sean-k-mooney | we auto rollback on some internal errors | 12:14 |
sean-k-mooney | did you do resize --confrim on the second migration before the third | 12:15 |
sean-k-mooney | if you did not confim the cold migration then i would expect the third to error | 12:15 |
nightmare_unreal | if I don't do resize confirm then it throws error : which is expected and intended behavior | 12:15 |
nightmare_unreal | but once i do confirm and run cmd again it works ( which it should IMO) | 12:15 |
sean-k-mooney | yep | 12:16 |
sean-k-mooney | so where you confriming after the second sucessfful migration and then seeing it error on the third migration | 12:16 |
*** vishalmanchanda has quit IRC | 12:17 | |
sean-k-mooney | if you look in the compute node logs for the first migration there likely is an error somewhere that caused a rollback. similarly i would expect there to be an error somewhere for the thrid failid migration | 12:17 |
nightmare_unreal | I got it | 12:17 |
nightmare_unreal | i can share the screenshot | 12:18 |
nightmare_unreal | this happened again | 12:18 |
sean-k-mooney | sure, link? | 12:18 |
nightmare_unreal | cold migration strange behavior https://usercontent.irccloud-cdn.com/file/NvweRHRz/weird_cold.png | 12:18 |
nightmare_unreal | is it available ? above | 12:18 |
sean-k-mooney | yep | 12:18 |
sean-k-mooney | so migration is an async operation | 12:19 |
sean-k-mooney | so i dont think we expect the client to return anything do we? | 12:19 |
nightmare_unreal | i ran the 1st cmd check the status it was still in SHUTOFF , I ran 2nd time now it's in RESIZE mode | 12:19 |
nightmare_unreal | now I ran 3rd time it throws error like it should Cannot 'migrate' instance aef212b9-6de7-4869-877c-a21c0b08de69 while it is in vm_state resized | 12:19 |
sean-k-mooney | did you run them back to back | 12:19 |
sean-k-mooney | well iguess you waited | 12:20 |
*** damien_r has joined #openstack-nova | 12:20 | |
sean-k-mooney | to check it was off | 12:20 |
nightmare_unreal | I waited for like 5 sec | 12:20 |
lyarwood | yeah it takes longer to shutoff the instance | 12:20 |
sean-k-mooney | ya i was wondering if you were racing with the instance state change | 12:20 |
lyarwood | we try to do a soft power off iirc | 12:20 |
nightmare_unreal | the VM was already in shutoff mode though | 12:20 |
lyarwood | if it's already shutoff then that's different | 12:20 |
sean-k-mooney | you still could be racing with the change to move ti to resizing | 12:21 |
*** mkrai has quit IRC | 12:21 | |
nightmare_unreal | thing is I am making script to do some automation for migration . and I rely on status changes for e.g. if state changes from SHUTOFF to resize then cmd worked | 12:21 |
nightmare_unreal | probably | 12:21 |
sean-k-mooney | nightmare_unreal: the first command should still work without the second | 12:22 |
nightmare_unreal | true , maybe it should throw error then. | 12:22 |
sean-k-mooney | maybe just add a retry loop to your state change check | 12:22 |
sean-k-mooney | e.g. try 3 times with a 5 second sleep or something | 12:22 |
nightmare_unreal | yeah i was thinking same. maybe 3 tries with some timeout | 12:22 |
*** udesale_ has joined #openstack-nova | 12:23 | |
nightmare_unreal | cool thanks sean-k-mooney | 12:23 |
*** udesale has quit IRC | 12:25 | |
*** ttsiouts has quit IRC | 12:27 | |
*** ociuhandu has joined #openstack-nova | 12:30 | |
*** lpetrut has joined #openstack-nova | 12:32 | |
*** nweinber has joined #openstack-nova | 12:34 | |
*** ociuhandu has quit IRC | 12:40 | |
*** derekh has quit IRC | 12:42 | |
*** francoisp has joined #openstack-nova | 12:44 | |
openstackgerrit | Jiri Suchomel proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301 | 12:55 |
jsuchome | lyarwood: new PS ^. It's not pretty, but I think it's more readable than before. | 12:56 |
*** derekh has joined #openstack-nova | 12:59 | |
*** mriedem has joined #openstack-nova | 13:00 | |
*** martinkennelly has quit IRC | 13:00 | |
*** hemna has quit IRC | 13:02 | |
*** hemna has joined #openstack-nova | 13:03 | |
*** ociuhandu has joined #openstack-nova | 13:06 | |
*** damien_r has quit IRC | 13:15 | |
*** damien_r has joined #openstack-nova | 13:15 | |
*** jamesdenton has joined #openstack-nova | 13:15 | |
*** lbragstad has quit IRC | 13:16 | |
*** Aditi20 has quit IRC | 13:16 | |
*** lbragstad has joined #openstack-nova | 13:18 | |
*** ttsiouts has joined #openstack-nova | 13:19 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Track blockjob status in DEBUG when polling for completion https://review.opendev.org/729595 | 13:23 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove blockjob.end == 0 workaround resolved in libvirt v2.3.0 https://review.opendev.org/729596 | 13:23 |
*** ttsiouts has quit IRC | 13:24 | |
lyarwood | kashyap: random question, what's the preferred way of polling blockjobs today? A comment from Matt I've removed from the comments above suggests there was an events framework we could use? | 13:24 |
lyarwood | jsuchome: ack will look shortly | 13:24 |
kashyap | lyarwood: Hiya | 13:24 |
*** ratailor has quit IRC | 13:24 | |
kashyap | lyarwood: Yes, the idea we discussed in the past was to listen on: | 13:25 |
kashyap | _BLOCK_JOB_READY events that QEMU (which in turn libvirt also relays) emits once a copy job has synced | 13:25 |
kashyap | lyarwood: I recall writin up that design somewhere, need to dig; but buried in a few downstream tasks before I go offline tomm & Fri | 13:26 |
kashyap | Give me a few, I'll find the relevant pointers :) | 13:26 |
lyarwood | ack np | 13:26 |
lyarwood | thanks | 13:26 |
*** ttsiouts has joined #openstack-nova | 13:27 | |
kashyap | lyarwood: Context-1: the thorny problem CI in Nova identified was this write-up: http://lists.openstack.org/pipermail/openstack-dev/2016-October/105158.html ("Debugging blockRebase() - "active block copy not ready for pivot") | 13:29 |
kashyap | lyarwood: Context-2: from the above, I filed this libvirt bug in 2016, and is fixed (in Jan-2019): https://bugzilla.redhat.com/show_bug.cgi?id=1382165 | 13:29 |
openstack | bugzilla.redhat.com bug 1382165 in libvirt "virDomainGetBlockJobInfo: Adjust job reporting based on QEMU stats & the "ready" field of `query-block-jobs`" [Unspecified,Closed: nextrelease] - Assigned to pkrempa | 13:29 |
kashyap | lyarwood: Context-3: https://libvirt.org/git/?p=libvirt.git;a=commit;h=73ce3911a | 13:31 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Track blockjob status in DEBUG when polling for completion https://review.opendev.org/729595 | 13:31 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove blockjob.end == 0 workaround resolved in libvirt v2.3.0 https://review.opendev.org/729596 | 13:31 |
kashyap | (There "some clients" is referring to OpenStack :-)) | 13:31 |
kashyap | So yeah, in short: what's needed is to listen on VIR_DOMAIN_BLOCK_JOB_READY event. | 13:32 |
kashyap | Instead of polling (to avoid the race that we debugged in the Context-1 link) | 13:32 |
lyarwood | https://libvirt.org/html/libvirt-libvirt-domain.html#virConnectDomainEventBlockJobCallback using this I assume? | 13:34 |
lyarwood | we don't want to listen over QMP | 13:34 |
*** sapd1_x has joined #openstack-nova | 13:34 | |
kashyap | lyarwood: No, we're not doing over QMP, of course | 13:35 |
kashyap | libvirt itself emits events; there's even an XML flag for the 'ready' bit | 13:35 |
lyarwood | kk | 13:35 |
kashyap | (The actual thing is being transmitted over QMP anyway; but we don't manually do it; that's what I meant) | 13:35 |
lyarwood | yup understood thanks | 13:36 |
kashyap | And check out this bit (read it in full in the URL): "The attribute 'ready', if present, tracks progress of the job [...]": https://libvirt.org/formatdomain.html | 13:37 |
kashyap | [Under the 'mirror' documentation] | 13:37 |
lyarwood | kashyap: yeah we already poll on that | 13:39 |
kashyap | Ah, nod. /me bbiab; need to finish this other bit early. | 13:40 |
lyarwood | kashyap: I added that a while ago https://review.opendev.org/#/c/399735/ | 13:40 |
kashyap | (But I reviewed your clean-up; looks good to me) | 13:40 |
lyarwood | ack thanks | 13:40 |
kashyap | lyarwood: Oh, yea; now I recall it. Thx | 13:41 |
*** vishalmanchanda has joined #openstack-nova | 13:41 | |
*** Liang__ has joined #openstack-nova | 13:50 | |
*** Liang__ is now known as LiangFang | 13:52 | |
*** liuyulong has joined #openstack-nova | 13:52 | |
*** Luzi has quit IRC | 13:58 | |
*** martinkennelly has joined #openstack-nova | 14:11 | |
*** ttsiouts has quit IRC | 14:15 | |
*** mkrai has joined #openstack-nova | 14:16 | |
*** huaqiang has quit IRC | 14:16 | |
*** dklyle has joined #openstack-nova | 14:17 | |
*** brinzhang_ has joined #openstack-nova | 14:18 | |
*** KeithMnemonic has joined #openstack-nova | 14:19 | |
*** brinzhang has quit IRC | 14:21 | |
*** brinzhang_ has quit IRC | 14:22 | |
*** brinzhang_ has joined #openstack-nova | 14:22 | |
lyarwood | artom / melwitt / stephenfin ; would you all mind taking a swing at https://review.opendev.org/#/c/631294/ sometime this week? | 14:29 |
artom | lyarwood, ack | 14:30 |
lyarwood | thanks, it's a total pig thanks to the backport requirement but all I can do at the moment | 14:31 |
openstackgerrit | Balazs Gibizer proposed openstack/nova-specs master: template: consider openstack client besides novaclient https://review.opendev.org/717722 | 14:32 |
*** threestrands has quit IRC | 14:34 | |
*** brinzhang_ has quit IRC | 14:45 | |
*** lpetrut has quit IRC | 14:46 | |
stephenfin | lyarwood: ack, I was waiting on the WIP patches theren ow | 14:47 |
stephenfin | *now | 14:47 |
*** mlavalle has joined #openstack-nova | 14:49 | |
*** martinkennelly has quit IRC | 14:51 | |
*** priteau has joined #openstack-nova | 14:52 | |
*** belmoreira has quit IRC | 14:54 | |
*** munimeha1 has joined #openstack-nova | 14:58 | |
*** ociuhandu has quit IRC | 14:59 | |
*** lvbin01 has quit IRC | 14:59 | |
*** lvbin01 has joined #openstack-nova | 15:00 | |
*** ociuhandu has joined #openstack-nova | 15:00 | |
*** ociuhandu has quit IRC | 15:05 | |
*** JamesBenson has joined #openstack-nova | 15:11 | |
*** LiangFang has quit IRC | 15:15 | |
*** ttsiouts has joined #openstack-nova | 15:18 | |
*** mkrai has quit IRC | 15:20 | |
*** ociuhandu has joined #openstack-nova | 15:24 | |
*** priteau has quit IRC | 15:33 | |
*** ttsiouts has quit IRC | 15:40 | |
*** ttsiouts has joined #openstack-nova | 15:40 | |
*** gyee has joined #openstack-nova | 15:40 | |
*** ttsiouts has quit IRC | 15:40 | |
*** JamesBenson has quit IRC | 15:45 | |
*** priteau has joined #openstack-nova | 15:47 | |
jsuchome | lyarwood: fyi, I missed broken tests, will have to rewrite it once more... | 15:47 |
lyarwood | jsuchome: ack np I was waiting on CI for that very reason :) | 15:50 |
jsuchome | I accidentally ran wrong tests localy and was surprised it was passing :-) | 15:54 |
*** damien_r has quit IRC | 16:03 | |
*** rcernin has quit IRC | 16:04 | |
openstackgerrit | Jiri Suchomel proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301 | 16:05 |
bauzas | gibi: fwiw, I'll be off tomorrow and Friday | 16:11 |
bauzas | May the Force be with French folks | 16:12 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove 'NovaObjectDictCompat' from 'Migration' https://review.opendev.org/723572 | 16:15 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove 'NovaObjectDictCompat' from 'InstancePCIRequest' https://review.opendev.org/723573 | 16:15 |
openstackgerrit | Merged openstack/nova stable/stein: Revert "nova shared storage: rbd is always shared storage" https://review.opendev.org/726862 | 16:16 |
openstackgerrit | Merged openstack/nova master: Add admin doc information about image cache resource accounting https://review.opendev.org/729350 | 16:17 |
openstackgerrit | Merged openstack/nova master: Increase code reuse in test_numa_servers https://review.opendev.org/714125 | 16:17 |
*** jraju__ has quit IRC | 16:20 | |
*** tesseract has quit IRC | 16:27 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Track blockjob status in DEBUG when polling for completion https://review.opendev.org/729595 | 16:30 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove blockjob.end == 0 workaround resolved in libvirt v2.3.0 https://review.opendev.org/729596 | 16:30 |
*** nightmare_unreal has quit IRC | 16:33 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove log translations https://review.opendev.org/728966 | 16:33 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: hacking: Modify checks for translated logs https://review.opendev.org/728967 | 16:33 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove hooks https://review.opendev.org/728968 | 16:33 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Remove workaround for unsupported libvirt version https://review.opendev.org/729656 | 16:33 |
*** alistarle has joined #openstack-nova | 16:36 | |
*** ociuhandu has quit IRC | 16:37 | |
*** ociuhandu has joined #openstack-nova | 16:41 | |
*** sapd1_x has quit IRC | 16:52 | |
stephenfin | lyarwood: one request on https://review.opendev.org/#/c/631294/ to keep me happy | 16:52 |
*** ociuhandu has quit IRC | 16:54 | |
lyarwood | stephenfin: ack thanks | 16:56 |
*** liuyulong has quit IRC | 17:00 | |
*** lbragstad has quit IRC | 17:02 | |
*** sapd1_x has joined #openstack-nova | 17:04 | |
*** udesale_ has quit IRC | 17:07 | |
*** alistarle has quit IRC | 17:08 | |
*** derekh has quit IRC | 17:11 | |
*** dpawlik has quit IRC | 17:15 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: Add functional test for bug 1550919 https://review.opendev.org/631294 | 17:16 |
openstack | bug 1550919 in OpenStack Compute (nova) "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Lee Yarwood (lyarwood) | 17:16 |
lyarwood | stephenfin: ^ thanks again, I'll comment on the fix in the morning | 17:17 |
*** hamalq has joined #openstack-nova | 17:18 | |
*** lbragstad has joined #openstack-nova | 17:23 | |
*** jmlowe has quit IRC | 17:23 | |
*** ociuhandu has joined #openstack-nova | 17:24 | |
*** raildo has quit IRC | 17:25 | |
*** raildo has joined #openstack-nova | 17:25 | |
*** jmlowe has joined #openstack-nova | 17:26 | |
*** priteau has quit IRC | 17:28 | |
*** ociuhandu has quit IRC | 17:37 | |
openstackgerrit | Elod Illes proposed openstack/nova stable/stein: Reproduce bug 1869050 https://review.opendev.org/729530 | 17:52 |
openstack | bug 1869050 in OpenStack Compute (nova) stein "migration of anti-affinity server fails due to stale scheduler instance info" [Low,In progress] https://launchpad.net/bugs/1869050 - Assigned to Balazs Gibizer (balazs-gibizer) | 17:52 |
*** ralonsoh has quit IRC | 17:54 | |
*** amodi has quit IRC | 18:00 | |
*** nweinber has quit IRC | 18:02 | |
*** nweinber has joined #openstack-nova | 18:03 | |
openstackgerrit | Elod Illes proposed openstack/nova stable/stein: Update scheduler instance info at confirm resize https://review.opendev.org/729538 | 18:03 |
*** ociuhandu has joined #openstack-nova | 18:07 | |
openstackgerrit | Elod Illes proposed openstack/nova stable/train: Make quotas respect instance_list_per_project_cells https://review.opendev.org/729087 | 18:18 |
*** munimeha1 has quit IRC | 18:18 | |
*** sapd1_x has quit IRC | 18:26 | |
*** jsuchome has quit IRC | 19:07 | |
*** avolkov has quit IRC | 19:09 | |
*** lbragstad_ has joined #openstack-nova | 19:19 | |
*** lbragstad has quit IRC | 19:22 | |
*** ociuhandu has quit IRC | 19:23 | |
openstackgerrit | Andreas Jaeger proposed openstack/nova master: Fix pygments_style https://review.opendev.org/729747 | 19:57 |
melwitt | thanks | 19:57 |
*** mgoddard has quit IRC | 19:59 | |
openstackgerrit | Merged openstack/nova master: trivial: Remove remaining '_LW' instances https://review.opendev.org/728964 | 20:09 |
*** ccamacho has quit IRC | 20:25 | |
*** maciejjozefczyk has quit IRC | 20:30 | |
*** mgoddard has joined #openstack-nova | 20:34 | |
*** vishalmanchanda has quit IRC | 20:37 | |
*** larainema has quit IRC | 20:38 | |
*** xek has quit IRC | 20:49 | |
*** gyee has quit IRC | 21:01 | |
*** gyee has joined #openstack-nova | 21:06 | |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: Handle Neutron errors in _post_live_migration() https://review.opendev.org/729763 | 21:15 |
*** mlavalle has quit IRC | 21:53 | |
*** nweinber has quit IRC | 21:54 | |
*** raildo has quit IRC | 21:56 | |
*** raildo_ has joined #openstack-nova | 21:56 | |
*** mlavalle has joined #openstack-nova | 22:07 | |
*** klindgren has quit IRC | 22:09 | |
*** slaweq has quit IRC | 22:13 | |
*** slaweq has joined #openstack-nova | 22:21 | |
*** slaweq has quit IRC | 22:25 | |
*** mriedem has left #openstack-nova | 22:28 | |
*** tkajinam has joined #openstack-nova | 22:37 | |
*** slaweq has joined #openstack-nova | 22:39 | |
*** slaweq has quit IRC | 22:44 | |
*** raildo_ has quit IRC | 23:03 | |
*** rcernin has joined #openstack-nova | 23:08 | |
*** ociuhandu has joined #openstack-nova | 23:38 | |
*** ociuhandu has quit IRC | 23:43 | |
*** mlavalle has quit IRC | 23:43 | |
*** tosky has quit IRC | 23:48 | |
*** gyee has quit IRC | 23:48 | |
*** threestrands has joined #openstack-nova | 23:49 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!