Friday, 2020-05-22

*** tosky has quit IRC00:01
*** avolkov has quit IRC00:24
*** brinzhang_ has joined #openstack-nova01:07
*** brinzhang has quit IRC01:10
*** ociuhandu has joined #openstack-nova01:30
*** ociuhandu has quit IRC01:35
*** lbragstad_ is now known as lbragstad01:54
*** lvbin02 has joined #openstack-nova01:57
*** lvbin01 has quit IRC01:58
*** lvbin02 is now known as lvbin0101:58
*** mlavalle has quit IRC02:20
openstackgerritzhangboye proposed openstack/nova-specs master: Fix hacking min version to 3.0.1  https://review.opendev.org/73016202:40
*** brinzhang has joined #openstack-nova03:03
*** brinzhang_ has quit IRC03:06
openstackgerritzhaoleilc proposed openstack/nova master: Fix an erroneous grammar in explanatory notes  https://review.opendev.org/73017603:12
*** brinzhang_ has joined #openstack-nova03:18
*** brinzhang has quit IRC03:21
*** elod has quit IRC03:23
*** tobberydberg has quit IRC03:25
*** tobberydberg has joined #openstack-nova03:35
*** elod has joined #openstack-nova03:35
*** psachin has joined #openstack-nova03:35
*** brinzhang has joined #openstack-nova03:36
*** brinzhang_ has quit IRC03:40
*** tetsuro has joined #openstack-nova03:45
*** ratailor has joined #openstack-nova04:17
*** evrardjp has quit IRC04:33
*** evrardjp has joined #openstack-nova04:33
*** songwenping__ has quit IRC04:38
*** songwenping__ has joined #openstack-nova04:39
*** xek_ has joined #openstack-nova04:48
*** xek has quit IRC04:50
*** mkrai has joined #openstack-nova05:04
*** mkrai has quit IRC05:26
*** songwenping__ has quit IRC05:29
*** tetsuro has quit IRC05:30
*** tetsuro has joined #openstack-nova05:32
*** ircuser-1 has quit IRC05:36
openstackgerritWenping Song proposed openstack/nova master: cyborg evacuate support  https://review.opendev.org/71532605:43
*** ircuser-1 has joined #openstack-nova05:48
*** hamalq has joined #openstack-nova05:56
*** hamalq has quit IRC05:56
*** hamalq has joined #openstack-nova05:57
*** ociuhandu has joined #openstack-nova06:01
*** ociuhandu has quit IRC06:05
openstackgerritjunbo proposed openstack/nova master: use dpdk interface type for ovs dpdk representor port  https://review.opendev.org/72987406:07
*** ociuhandu has joined #openstack-nova06:16
*** nightmare_unreal has joined #openstack-nova06:18
*** ralonsoh has joined #openstack-nova06:33
*** jsuchome has joined #openstack-nova06:38
*** udesale has joined #openstack-nova06:39
*** slaweq has joined #openstack-nova06:49
*** slaweq has quit IRC06:54
*** slaweq has joined #openstack-nova06:56
*** belmoreira has joined #openstack-nova07:02
*** dklyle has quit IRC07:02
*** xek_ has quit IRC07:19
*** ociuhandu has quit IRC07:19
*** xek has joined #openstack-nova07:20
*** ttsiouts has joined #openstack-nova07:20
*** xek_ has joined #openstack-nova07:23
*** xek has quit IRC07:25
*** jawad_axd has joined #openstack-nova07:28
*** xek_ has quit IRC07:29
*** xek has joined #openstack-nova07:30
*** tosky has joined #openstack-nova07:34
*** breizhkoala has joined #openstack-nova07:58
*** tkajinam_ has quit IRC08:05
*** kashyap has quit IRC08:15
*** ttsiouts has quit IRC08:20
*** ttsiouts has joined #openstack-nova08:21
*** ociuhandu has joined #openstack-nova08:22
*** lpetrut has joined #openstack-nova08:26
*** ociuhandu has quit IRC08:28
*** ociuhandu has joined #openstack-nova08:28
*** ociuhandu has quit IRC08:29
*** larainema has joined #openstack-nova08:29
*** ociuhandu has joined #openstack-nova08:30
*** ociuhandu has quit IRC08:35
*** ociuhandu has joined #openstack-nova08:37
*** derekh has joined #openstack-nova08:39
*** elod has quit IRC08:43
*** artom has quit IRC08:45
*** artom has joined #openstack-nova08:46
openstackgerritBalazs Gibizer proposed openstack/nova stable/queens: Clean up allocation if unshelve fails due to neutron  https://review.opendev.org/72954008:48
*** avolkov has joined #openstack-nova08:48
*** elod has joined #openstack-nova08:50
openstackgerritBalazs Gibizer proposed openstack/nova stable/queens: Reproduce bug 1862633  https://review.opendev.org/72953908:56
openstackbug 1862633 in OpenStack Compute (nova) "unshelve leak allocation if update port fails" [Medium,Fix released] https://launchpad.net/bugs/1862633 - Assigned to Balazs Gibizer (balazs-gibizer)08:56
openstackgerritBalazs Gibizer proposed openstack/nova stable/queens: Clean up allocation if unshelve fails due to neutron  https://review.opendev.org/72954008:56
*** elod has quit IRC08:56
*** yaawang has quit IRC08:57
*** yaawang has joined #openstack-nova08:57
*** elod has joined #openstack-nova08:58
openstackgerritWenping Song proposed openstack/nova master: WIP: Cyborg shelve/unshelve support  https://review.opendev.org/72956309:00
*** martinkennelly has joined #openstack-nova09:06
*** elod has quit IRC09:10
*** elod has joined #openstack-nova09:10
*** songwenping__ has joined #openstack-nova09:13
*** ttsiouts has quit IRC09:14
*** ttsiouts has joined #openstack-nova09:16
openstackgerritMerged openstack/nova-specs master: re-propose numa with placement  https://review.opendev.org/72800909:24
*** tetsuro has quit IRC09:30
gibistephenfin: hi! I'm not sure about your suggestion in https://review.opendev.org/#/c/729924/1/nova/compute/manager.py@a28009:32
stephenfingibi: Ah, I'm wrong then. I was searching for Migration._from_db_object since it was a static method09:34
gibistephenfin: ack09:34
*** songwenping_ has joined #openstack-nova09:38
*** sean-k-mooney has joined #openstack-nova09:39
*** songwenping__ has quit IRC09:42
openstackgerritBalazs Gibizer proposed openstack/nova master: Remove inject_file from compute manager and virt driver  https://review.opendev.org/72993409:49
elodlyarwood: any reason holding up the +W here: https://review.opendev.org/#/c/729530/ ?09:50
gibistephenfin: also yesterday I collected some cleanups for after RPC 6.0 here https://etherpad.opendev.org/p/compute-rpc-6.0 If you see more just plug it there09:51
lyarwoodelod: no, I likely had the tab open prior to your review, apologies.09:54
lyarwood+W'd09:54
gibithanks guys!09:59
sean-k-mooneyoh we are finally removing file injection10:06
gibiit was dead code10:06
sean-k-mooneythat been deprecated almost as long as nova networks10:06
sean-k-mooneygibi: was it not used for the vm personalities10:07
openstackgerritBalazs Gibizer proposed openstack/nova master: Remove compatibility check from migrate_data  https://review.opendev.org/72994910:07
gibisean-k-mooney: the RPC method was removed in compute RPC 3.1810:07
gibiand there was no other usage for the driver call too10:08
elodlyarwood: ok, thanks! I just thought that we should wait for something and was curious :]10:08
sean-k-mooneyah ok10:08
*** derekh has quit IRC10:09
*** derekh has joined #openstack-nova10:09
sean-k-mooneygibi: ah so you are just removing the function not the file inject capablity10:16
gibisean-k-mooney: is there another way to inject_files other than inject_file virt driver method?10:17
sean-k-mooneyyes10:17
sean-k-mooneyvia the deprecated personality server atibute10:18
sean-k-mooneyalthough i dont know if that ends up calling that function or not10:19
sean-k-mooneyyou have not removed any fo the personality code10:19
*** ttsiouts has quit IRC10:19
sean-k-mooneygibi: like this https://github.com/openstack/nova/blob/c6218428e9b29a2c52808ec7d27b4b21aadc0299/nova/api/openstack/compute/helpers.py#L106-L11610:19
gibisean-k-mooney: thanks. looking10:21
sean-k-mooneygibi: we pass the injected files to build_instance10:21
*** ttsiouts has joined #openstack-nova10:21
sean-k-mooneyso i dont think we use a dedicated rpc call10:22
gibisean-k-mooney: yeah I just checked the driver.spawn() also take injected_files argument so I think server create and rebuild still inject_files10:25
sean-k-mooneyyep10:25
sean-k-mooneyso we stoped using the dedicated rpc and move to passing it as part of create or rebuild10:25
sean-k-mooneybut only when using the de10:26
sean-k-mooneydeprecated personality attibute10:26
sean-k-mooneygibi: anyway i think the code you pointed too is still dead code so it should be fine to remove10:28
gibisean-k-mooney: yepp. and removing personalities attribute wasn't my goal. I was actually collected what can be deleted after RPC 6.0 when I found that this can already be deleted10:29
sean-k-mooneyack10:30
*** derekh has quit IRC10:33
*** derekh has joined #openstack-nova10:34
*** derekh has quit IRC10:35
*** derekh has joined #openstack-nova10:35
*** breizhkoala has quit IRC10:38
*** brinzhang has quit IRC11:09
*** sapd1_x has quit IRC11:11
*** yaawang has quit IRC11:20
*** hamalq has quit IRC11:21
*** jawad_axd has quit IRC11:21
*** nweinber has joined #openstack-nova11:24
*** maciejjozefczyk is now known as mjozefcz|lunch11:30
*** jawad_axd has joined #openstack-nova11:37
openstackgerritMerged openstack/nova stable/ussuri: Add admin doc information about image cache resource accounting  https://review.opendev.org/72985311:41
openstackgerritMerged openstack/nova master: hardware: Raise useful error for invalid mempage size  https://review.opendev.org/72996711:41
openstackgerritMerged openstack/nova stable/stein: Reproduce bug 1869050  https://review.opendev.org/72953011:41
openstackbug 1869050 in OpenStack Compute (nova) stein "migration of anti-affinity server fails due to stale scheduler instance info" [Low,In progress] https://launchpad.net/bugs/1869050 - Assigned to Elod Illes (elod-illes)11:41
*** jawad_axd has quit IRC11:42
openstackgerritBalazs Gibizer proposed openstack/nova master: Remove compatibility check from migrate_data  https://review.opendev.org/72994911:43
sean-k-mooneyoh i found a bug yesteraday, rememebr the patch that change how we recaulate the next avaiable slot on a disk bus11:55
sean-k-mooneyit does not take account of the fact the bus might be empty11:56
sean-k-mooneyso if you boot a vm from an iso you cant add a data volume to install too11:56
sean-k-mooneyhttp://paste.openstack.org/show/793880/11:59
*** ttsiouts has quit IRC11:59
gibiuups11:59
*** jawad_axd has joined #openstack-nova12:00
sean-k-mooneyif i boot a ubuntu imagae with local sotorage and then try to do a rescue it also fails12:00
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [req-a5b97168-4a74-4314-ba7f-9b1af4a8508d 0eb84fc371204ddb8c1dd829464d9284 468fb37037924eaeaf7104b34c4c077d - default default] [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] Failed to attach 858fdfc4-632d-47d3-bc60-d7f6aa76dc7b at /dev/sdb: libvirt.libvirtError: internal error: child reported (status=125): unable to open /dev/sdg: No such device12:01
sean-k-mooneyor address12:01
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] Traceback (most recent call last):12:01
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]   File "/var/lib/kolla/venv/lib/python3.6/site-packages/nova/compute/manager.py", line 6915, in _attach_volume12:01
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]     do_driver_attach=True)12:01
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]   File "/var/lib/kolla/venv/lib/python3.6/site-packages/nova/virt/block_device.py", line 46, in wrapped12:01
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]     ret_val = method(obj, context, *args, **kwargs)12:01
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]   File "/var/lib/kolla/venv/lib/python3.6/site-packages/nova/virt/block_device.py", line 673, in attach12:01
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]     virt_driver, do_driver_attach)12:01
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]   File "/var/lib/kolla/venv/lib/python3.6/site-packages/nova/virt/block_device.py", line 660, in _do_attach12:01
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]     do_driver_attach)12:01
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]   File "/var/lib/kolla/venv/lib/python3.6/site-packages/nova/virt/block_device.py", line 607, in _volume_attach12:01
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]     attachment_id)12:01
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]   File "/var/lib/kolla/venv/lib/python3.6/site-packages/oslo_utils/excutils.py", line 220, in __exit__12:01
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]     self.force_reraise()12:01
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]   File "/var/lib/kolla/venv/lib/python3.6/site-packages/oslo_utils/excutils.py", line 196, in force_reraise12:01
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]     six.reraise(self.type_, self.value, self.tb)12:01
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]   File "/usr/lib/python3.6/site-packages/six.py", line 703, in reraise12:01
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]     raise value12:01
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]   File "/var/lib/kolla/venv/lib/python3.6/site-packages/nova/virt/block_device.py", line 598, in _volume_attach12:01
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]     device_type=self['device_type'], encryption=encryption)12:01
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]   File "/var/lib/kolla/venv/lib/python3.6/site-packages/nova/virt/libvirt/driver.py", line 1763, in attach_volume12:01
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]     encryption=encryption)12:01
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]   File "/var/lib/kolla/venv/lib/python3.6/site-packages/oslo_utils/excutils.py", line 220, in __exit__12:01
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]     self.force_reraise()12:01
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]   File "/var/lib/kolla/venv/lib/python3.6/site-packages/oslo_utils/excutils.py", line 196, in force_reraise12:01
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]     six.reraise(self.type_, self.value, self.tb)12:01
gibiups again :)12:01
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]   File "/usr/lib/python3.6/site-packages/six.py", line 703, in reraise12:01
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]     raise value12:01
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]   File "/var/lib/kolla/venv/lib/python3.6/site-packages/nova/virt/libvirt/driver.py", line 1736, in attach_volume12:01
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]     guest.attach_device(conf, persistent=True, live=live)12:02
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]   File "/var/lib/kolla/venv/lib/python3.6/site-packages/nova/virt/libvirt/guest.py", line 293, in attach_device12:02
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]     self._domain.attachDeviceFlags(device_xml, flags=flags)12:02
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]   File "/var/lib/kolla/venv/lib/python3.6/site-packages/eventlet/tpool.py", line 190, in doit12:02
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]     result = proxy_call(self._autowrap, f, *args, **kwargs)12:02
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]   File "/var/lib/kolla/venv/lib/python3.6/site-packages/eventlet/tpool.py", line 148, in proxy_call12:02
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]     rv = execute(f, *args, **kwargs)12:02
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]   File "/var/lib/kolla/venv/lib/python3.6/site-packages/eventlet/tpool.py", line 129, in execute12:02
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]     six.reraise(c, e, tb)12:02
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]   File "/usr/lib/python3.6/site-packages/six.py", line 703, in reraise12:02
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]     raise value12:02
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]   File "/var/lib/kolla/venv/lib/python3.6/site-packages/eventlet/tpool.py", line 83, in tworker12:02
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]     rv = meth(*args, **kwargs)12:02
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]   File "/usr/lib64/python3.6/site-packages/libvirt.py", line 614, in attachDeviceFlags12:02
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5]     if ret == -1: raise libvirtError ('virDomainAttachDeviceFlags() failed', dom=self)12:02
sean-k-mooney2020-05-22 00:28:20.355 6 ERROR nova.compute.manager [instance: 8cfaf7ce-13ae-4b50-9bd8-20c957a8dfb5] libvirt.libvirtError: internal error: child reported (status=125): unable to open /dev/sdg: No such device or address12:02
sean-k-mooneyops12:02
sean-k-mooneyhttp://paste.openstack.org/show/793881/12:02
sean-k-mooneyment to past the link12:02
sean-k-mooneylyarwood: are you still working on stable rescue?12:02
gibiI think stable rescue was finished in ussuri12:02
sean-k-mooneythis might be related or might not. i have different disk_bus and cdrom_bus image proterties set in my orginal image and the rescue image12:03
sean-k-mooneyi might do an upgrade of my cloud and see if the issue still exists. i have a random commit off master deployed12:03
*** ociuhandu has quit IRC12:05
lyarwoodsean-k-mooney: finished in U, what's up?12:06
*** ociuhandu has joined #openstack-nova12:06
sean-k-mooneyif we use q35 i have found at least two cases where attach volume is broken12:06
sean-k-mooneyone is when you boot form an iso12:06
sean-k-mooneythe other is if you try to use an iso for rescue12:07
*** ttsiouts has joined #openstack-nova12:07
lyarwoodsean-k-mooney: in both cases is it trying to use an IDE bus?12:07
sean-k-mooneyno12:07
sean-k-mooneythe iso image is using sata12:08
sean-k-mooneyi set cdrom_bus=sata in the image meta12:08
openstackgerritLee Yarwood proposed openstack/nova master: DNM: Test m1.nano flavor with 96MB to avoid tmpfs exhaustion  https://review.opendev.org/73030812:09
sean-k-mooneylyarwood: i do not have rescue_bus set in any of the cases12:09
lyarwoodsean-k-mooney: kk can you write up some bugs for that?12:10
lyarwoodI've had my head in cirros sysvinit scripts all morning12:10
sean-k-mooneyyep i found it last night after trying to create a windows vm from an iso12:10
*** ociuhandu has quit IRC12:11
sean-k-mooneythe code is now different on master https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L1416-L142512:13
sean-k-mooneybut it might stil have the bug12:14
openstackgerritMerged openstack/nova stable/stein: Update scheduler instance info at confirm resize  https://review.opendev.org/72953812:14
sean-k-mooneymax([])12:14
sean-k-mooneyTraceback (most recent call last):12:14
sean-k-mooney  File "<stdin>", line 1, in <module>12:14
sean-k-mooneyValueError: max() arg is an empty sequence12:14
sean-k-mooneyyep it does12:14
sean-k-mooneyoh no its fixed12:14
sean-k-mooney max(ret) + 1 if ret else 012:15
sean-k-mooneythe if will prevent the ValueError12:15
*** mjozefcz|lunch is now known as mjozefcz12:18
sean-k-mooneyhttps://github.com/openstack/nova/commit/c8d6767cf8baaf3cc81496c83db10c8ae72fce06 is what im missing12:20
sean-k-mooneyso we should backport https://review.opendev.org/#/c/712607/12:21
*** raildo has joined #openstack-nova12:21
*** jawad_axd has quit IRC12:24
*** derekh has quit IRC12:24
gibisean-k-mooney: +1 on that to backport12:24
sean-k-mooneyill check how far back we had the old logic and then start propsoing them12:25
gibicool12:26
*** priteau has joined #openstack-nova12:33
sean-k-mooneyapparently forever or at last to ocata. ill backport to queens12:33
openstackgerritsean mooney proposed openstack/nova stable/train: fix scsi disk unit number of the attaching volume when cdrom bus is scsi  https://review.opendev.org/73031012:35
openstackgerritsean mooney proposed openstack/nova stable/stein: fix scsi disk unit number of the attaching volume when cdrom bus is scsi  https://review.opendev.org/73031112:36
openstackgerritsean mooney proposed openstack/nova stable/rocky: fix scsi disk unit number of the attaching volume when cdrom bus is scsi  https://review.opendev.org/73031212:36
openstackgerritsean mooney proposed openstack/nova stable/queens: fix scsi disk unit number of the attaching volume when cdrom bus is scsi  https://review.opendev.org/73031312:37
*** rcernin has quit IRC12:39
openstackgerritElod Illes proposed openstack/nova stable/ussuri: remove support of oslo.messaging 9.8.0 warning message  https://review.opendev.org/72805512:51
*** breizhkoala has joined #openstack-nova12:52
*** ratailor has quit IRC12:55
jsuchomelyarwood: hey, just a humble ping with a request for a new review...12:56
lyarwoodjsuchome: ack looking12:59
openstackgerritLee Yarwood proposed openstack/nova master: zuul: Make barbican-simple-crypto-devstack-tempest a non-voting check job  https://review.opendev.org/73031913:08
openstackgerritLee Yarwood proposed openstack/nova master: zuul: Make devstack-plugin-ceph-tempest-py3 a voting check job again  https://review.opendev.org/73032013:08
*** ociuhandu has joined #openstack-nova13:08
sean-k-mooneygibi: dansmith added https://github.com/openstack/nova/commit/04e79b5b7e18f033053d4057edc768281b91a4d7 to reserve migration for ussuri but we also merged https://github.com/openstack/nova/commit/75a2d600fc26beda78bdafd209e92f0bc980292713:10
sean-k-mooneyhttps://github.com/openstack/nova/commit/75a2d600fc26beda78bdafd209e92f0bc9802927 is not on stable/ussuri however13:10
sean-k-mooneydo you know why we have 2 set of placeholder migration for ussuri13:11
sean-k-mooneyand why only one of them is in stable ussuri13:11
sean-k-mooneyis the commit message in https://github.com/openstack/nova/commit/75a2d600fc26beda78bdafd209e92f0bc9802927 just wrong and those are for victoria13:12
gibisean-k-mooney: good question13:14
sean-k-mooneyit add  ussuri_placeholders = list(range(408, 413)) to the migration tests13:15
sean-k-mooneybut i would expect that to get run on stable/ussuri but i guess i dont really follow how this is ment to work13:15
gibiI think only the commit message is missleading both patches are correct, they reserve db migration for bugfixes13:16
sean-k-mooneyright the patches are more or less idential13:16
sean-k-mooneyim just wondering what we expect to see on stable/ussuri13:17
sean-k-mooneyi see the place holder up to 072 https://github.com/openstack/nova/tree/stable/ussuri/nova/db/sqlalchemy/api_migrations/migrate_repo/versions13:17
sean-k-mooneywhich were intoduced by dansmith13:17
sean-k-mooneyso i think that is correct13:17
sean-k-mooneybut if i look at his patch those are listed as train_placeholders = list(range(68, 73))13:18
gibiwhen you want to backport a migraiton to ussuri you have to use one of the reserved migration from https://review.opendev.org/#/c/722546 if you want to add a new migration that is not backported then you have to use 07813:18
sean-k-mooneyright but what is confutin me is we are calling them train_placeholders in the tests13:19
gibitrain_placeholders means for me that such versions are reserved for migration that might need to be backported to train13:19
sean-k-mooneyok that a different way to look at it13:20
gibiwhen we started ussuri we reserved migrations for stable/train  when we started V we reserved migration for stable/ussur13:20
gibii13:20
sean-k-mooneybut see that does not fully make sense to me13:20
sean-k-mooneyoh well maybe13:20
sean-k-mooneywhen we do the backprot to stable usue it would start with 73?13:21
sean-k-mooneywhich is hte first migration we reseved in the vicrotia cycle13:21
sean-k-mooneyfor backport to ussuri13:21
sean-k-mooneyok i think i understand how this work now13:22
gibicool13:23
*** udesale_ has joined #openstack-nova13:24
sean-k-mooneyi still find it slightly backwards but i am now following at least13:24
sean-k-mooneyii was expecteing each release to add backport slot for backport to that release but i was off by 113:25
*** udesale has quit IRC13:27
openstackgerritBalazs Gibizer proposed openstack/nova stable/train: Reserve DISK_GB resource for the image cache  https://review.opendev.org/73032413:33
openstackgerritBalazs Gibizer proposed openstack/nova stable/train: Add admin doc information about image cache resource accounting  https://review.opendev.org/73032613:34
*** lpetrut has quit IRC13:35
lyarwoodsean-k-mooney: https://github.com/cirros-dev/cirros/issues/53 - something to be aware of in the future with cirros 0.5.0 and q3513:47
mnaserhttps://review.opendev.org/#/c/729088/ if anyone wants to finish backporting it all the way back :)13:47
sean-k-mooneylyarwood: aw you mean we cant keep using or normal 64mb nano images13:48
sean-k-mooneylyarwood: is that memory the guest memory or host memoery13:48
lyarwoodsean-k-mooney: guest AFAICT13:49
sean-k-mooneythats strange13:49
sean-k-mooneyusing uefi should not affect the guest minium memeory13:49
lyarwoodsean-k-mooney: https://review.opendev.org/#/c/730307/ tbh we are also breaking to the nano flavor with 0.4.0 anyway13:49
lyarwooddue to*13:49
sean-k-mooneylyarwood: you might as well just bump it to 12813:50
sean-k-mooneywe are tight on memory in the ci but not that tight13:50
lyarwoodI wasn't sure if that would bork some providers tbh13:50
lyarwoodyeah given the other change I'll move this to 12813:50
sean-k-mooneyit does not depend on the provider13:50
sean-k-mooneyall proviers provide an image with 8G of ram13:51
sean-k-mooneyunless you use a special node set with  a different lable13:51
lyarwoodack13:51
* lyarwood waits for zuul to report before pushing another PS13:52
sean-k-mooneybut ya im still not sure why it would need more guest ram for uefi13:52
sean-k-mooneyi mean sure there are the uefi runtim services but they should not be consuming enough ram to be meaningful13:53
*** owalsh has quit IRC13:55
*** jawad_axd has joined #openstack-nova13:57
*** ttsiouts has quit IRC13:58
*** priteau has quit IRC13:59
*** jawad_axd has quit IRC14:02
*** owalsh has joined #openstack-nova14:13
*** ttsiouts has joined #openstack-nova14:15
*** jawad_axd has joined #openstack-nova14:19
*** jawad_axd has quit IRC14:23
*** psachin has quit IRC14:26
openstackgerritBalazs Gibizer proposed openstack/nova stable/rocky: Reproduce bug 1869050  https://review.opendev.org/73034314:28
openstackbug 1869050 in OpenStack Compute (nova) rocky "migration of anti-affinity server fails due to stale scheduler instance info" [Low,In progress] https://launchpad.net/bugs/186905014:28
openstackgerritBalazs Gibizer proposed openstack/nova stable/rocky: Update scheduler instance info at confirm resize  https://review.opendev.org/73034414:28
*** ttsiouts has quit IRC14:31
*** psachin has joined #openstack-nova14:35
openstackgerritJiri Suchomel proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD  https://review.opendev.org/57430114:37
openstackgerritStephen Finucane proposed openstack/nova master: Remove unnecessary retrieval of Migration object  https://review.opendev.org/73035114:38
openstackgerritStephen Finucane proposed openstack/nova master: Remove unused function parameters  https://review.opendev.org/73035214:38
jsuchomelyarwood: ok, addressed your notes except 2 things: 1. the error handling in case of failed write/verification (not really sure if your suggestion would make it better). and 2. I know nothingabout barbican :-(14:38
*** jawad_axd has joined #openstack-nova14:39
openstackgerritDan Smith proposed openstack/nova-specs master: Add rbd-glance-multistore spec  https://review.opendev.org/73012614:40
*** psachin has quit IRC14:42
*** jawad_axd has quit IRC14:44
lyarwoodjsuchome: barbican-simple-crypto-devstack-tempest runs some additional image verification tests I'd like to see pass against your changes14:45
lyarwoodjsuchome: it's in the experimental queue I triggered earlier14:45
jsuchomeah, I see14:47
lyarwoodjsuchome: could you trigger it again for your latest patchset?14:48
lyarwoodjsuchome: it should cancel the previous run14:48
jsuchomedone14:49
lyarwoodthanks14:49
*** mlavalle has joined #openstack-nova14:56
*** jawad_axd has joined #openstack-nova15:00
*** jawad_axd has quit IRC15:05
openstackgerritMerged openstack/nova stable/rocky: Revert "nova shared storage: rbd is always shared storage"  https://review.opendev.org/72686315:06
openstackgerritMerged openstack/nova stable/ussuri: Silence amqp heartbeat warning  https://review.opendev.org/72805415:06
*** gyee has joined #openstack-nova15:17
*** dklyle has joined #openstack-nova15:22
*** vishalmanchanda has joined #openstack-nova15:28
openstackgerritStephen Finucane proposed openstack/nova master: mypy: Add type annotations to 'nova.pci'  https://review.opendev.org/67620915:36
openstackgerritStephen Finucane proposed openstack/nova master: mypy: Add nova.cmd, nova.conf, nova.console  https://review.opendev.org/70565715:36
openstackgerritStephen Finucane proposed openstack/nova master: WIP: mypy: Add type annotations to top-level modules  https://review.opendev.org/70565815:36
*** ociuhandu has quit IRC15:39
openstackgerritStephen Finucane proposed openstack/nova master: Fix configure() called after DatabaseAtVersion fixture  https://review.opendev.org/61972315:40
*** ociuhandu has joined #openstack-nova15:41
*** ttsiouts has joined #openstack-nova15:41
*** ociuhandu has quit IRC15:46
openstackgerritStephen Finucane proposed openstack/nova master: Remove eventlet hub workaround for monotonic clock  https://review.opendev.org/64423715:47
openstackgerritStephen Finucane proposed openstack/nova master: Add missing test bindep on openssl  https://review.opendev.org/64423815:47
stephenfinlyarwood: I don't have the power to abandon these. Can you? https://review.opendev.org/#/q/topic:bug1840912+(status:open+OR+status:merged)15:55
openstackgerritStephen Finucane proposed openstack/nova master: Cleanup libvirt test_mount unit tests  https://review.opendev.org/69217315:56
*** belmoreira has quit IRC16:02
*** belmoreira has joined #openstack-nova16:02
*** belmoreira has quit IRC16:02
lyarwoodstephenfin: done16:06
stephenfinthanks16:07
*** psachin has joined #openstack-nova16:10
*** tbachman has quit IRC16:15
*** psachin has quit IRC16:17
*** psachin has joined #openstack-nova16:20
*** tbachman has joined #openstack-nova16:20
openstackgerritStephen Finucane proposed openstack/nova master: quota: remove get_quota_classes() driver method  https://review.opendev.org/61561516:23
openstackgerritStephen Finucane proposed openstack/nova master: quota: remove Context.quota_class  https://review.opendev.org/61561616:23
openstackgerritStephen Finucane proposed openstack/nova master: quota: remove FakeContext from quota unit tests  https://review.opendev.org/61561716:23
openstackgerritStephen Finucane proposed openstack/nova master: quota: remove _no_class tests  https://review.opendev.org/61561816:23
openstackgerritStephen Finucane proposed openstack/nova master: quota: clean up DbQuotaDriver unit tests  https://review.opendev.org/61561916:23
openstackgerritStephen Finucane proposed openstack/nova master: quota: rename arguments to clarify they are limits  https://review.opendev.org/61563316:23
*** ttsiouts has quit IRC16:24
*** tbachman has quit IRC16:27
*** tbachman has joined #openstack-nova16:28
openstackgerritStephen Finucane proposed openstack/nova master: quota: remove Context.quota_class  https://review.opendev.org/61561616:30
openstackgerritStephen Finucane proposed openstack/nova master: quota: remove FakeContext from quota unit tests  https://review.opendev.org/61561716:30
openstackgerritStephen Finucane proposed openstack/nova master: quota: remove _no_class tests  https://review.opendev.org/61561816:30
openstackgerritStephen Finucane proposed openstack/nova master: quota: clean up DbQuotaDriver unit tests  https://review.opendev.org/61561916:30
openstackgerritStephen Finucane proposed openstack/nova master: quota: rename arguments to clarify they are limits  https://review.opendev.org/61563316:30
*** psachin has quit IRC16:38
*** psachin has joined #openstack-nova16:41
openstackgerritStephen Finucane proposed openstack/nova master: Fix configure() called after DatabaseAtVersion fixture  https://review.opendev.org/61972316:45
*** psachin has quit IRC16:52
*** ociuhandu has joined #openstack-nova16:53
*** tbachman has quit IRC16:54
*** tbachman has joined #openstack-nova16:56
*** ociuhandu has quit IRC16:57
*** psachin has joined #openstack-nova16:59
*** psachin has quit IRC17:18
*** udesale_ has quit IRC17:20
openstackgerritMerged openstack/nova stable/ussuri: remove support of oslo.messaging 9.8.0 warning message  https://review.opendev.org/72805517:20
*** ociuhandu has joined #openstack-nova17:21
openstackgerritAndreas Jaeger proposed openstack/nova-specs master: Switch to newer openstackdocstheme and reno versions  https://review.opendev.org/72861117:24
openstackgerritAndreas Jaeger proposed openstack/nova-specs master: Switch to newer openstackdocstheme and reno versions  https://review.opendev.org/72861117:24
openstackgerritAndreas Jaeger proposed openstack/os-vif master: Switch to newer openstackdocstheme and reno versions  https://review.opendev.org/72861217:30
*** nightmare_unreal has quit IRC17:36
openstackgerritStephen Finucane proposed openstack/nova master: Add emulated TPM support to Nova  https://review.opendev.org/63136317:40
openstackgerritStephen Finucane proposed openstack/nova master: WIP: Add support for resize and cold migration of emulated TPM files  https://review.opendev.org/63993417:40
openstackgerritStephen Finucane proposed openstack/nova master: virt: Add 'context', drop 'network_info' parameters for 'unrescue'  https://review.opendev.org/73038217:40
*** xek has quit IRC17:46
*** tosky has quit IRC17:50
*** tosky has joined #openstack-nova17:51
*** damien_r has joined #openstack-nova17:55
*** ociuhandu has quit IRC17:55
*** ociuhandu has joined #openstack-nova17:56
*** ociuhandu has quit IRC18:01
*** ralonsoh has quit IRC18:14
*** artom has quit IRC18:30
*** sean-k-mooney has quit IRC18:31
*** ociuhandu has joined #openstack-nova18:47
*** efried has quit IRC19:05
*** nweinber has quit IRC19:07
*** efried has joined #openstack-nova19:08
*** breizhkoala has quit IRC19:13
*** ociuhandu has quit IRC19:18
*** ociuhandu has joined #openstack-nova19:19
*** ociuhandu has quit IRC19:24
*** elod has quit IRC19:26
*** elod has joined #openstack-nova19:27
*** jsuchome has quit IRC19:33
*** avolkov has quit IRC19:37
*** slaweq has quit IRC19:49
*** slaweq has joined #openstack-nova19:55
*** slaweq has quit IRC19:59
*** ociuhandu has joined #openstack-nova20:03
*** ociuhandu has quit IRC20:15
openstackgerritMerged openstack/nova master: Fix configure() called after DatabaseAtVersion fixture  https://review.opendev.org/61972320:35
*** hamalq has joined #openstack-nova20:36
*** lpetrut has joined #openstack-nova20:43
*** raildo has quit IRC21:08
*** bnemec is now known as beekneemech21:13
*** lpetrut has quit IRC21:15
*** lpetrut has joined #openstack-nova21:26
*** vishalmanchanda has quit IRC21:49
*** lpetrut has quit IRC22:00
*** sapd1_x has joined #openstack-nova22:05
*** sapd1_y has quit IRC22:05
*** eharney has quit IRC22:07
*** jmlowe has quit IRC22:20
*** jmlowe has joined #openstack-nova22:22
*** ccstone9 has joined #openstack-nova22:23
*** ccstone has quit IRC22:24
*** ccstone9 is now known as ccstone22:24
*** smcginnis has quit IRC22:24
*** smcginnis has joined #openstack-nova22:30
*** mlavalle has quit IRC22:58
*** tosky has quit IRC22:59
*** larainema has quit IRC23:00
*** ociuhandu has joined #openstack-nova23:04
*** ociuhandu has quit IRC23:08
openstackgerritMerged openstack/nova master: rbd_utils: increase _destroy_volume timeout  https://review.opendev.org/70576423:16
*** damien_r has quit IRC23:19

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!