Wednesday, 2020-06-17

*** gyee has quit IRC00:01
*** artom has quit IRC00:08
*** boxiang_ has joined #openstack-nova00:15
*** hamalq has quit IRC00:15
*** mlavalle has quit IRC00:15
*** brinzhang has joined #openstack-nova00:16
*** boxiang has quit IRC00:16
*** tetsuro has joined #openstack-nova00:42
openstackgerritsunhao proposed openstack/nova stable/ussuri: hardware: Raise useful error for invalid mempage size  https://review.opendev.org/73607301:05
openstackgerritsunhao proposed openstack/nova stable/train: hardware: Raise useful error for invalid mempage size  https://review.opendev.org/73595001:14
*** Liang__ has joined #openstack-nova01:15
*** spatel has joined #openstack-nova01:21
openstackgerritsunhao proposed openstack/nova stable/train: hardware: Raise useful error for invalid mempage size  https://review.opendev.org/73595001:31
*** xiaolin has joined #openstack-nova01:40
*** mriedem has quit IRC02:23
*** lbragstad has quit IRC02:31
*** tbachman has quit IRC02:43
*** tbachman_ has joined #openstack-nova02:43
*** psachin has joined #openstack-nova02:48
*** rcernin has quit IRC02:49
*** rcernin has joined #openstack-nova02:54
*** mkrai has joined #openstack-nova02:59
*** rcernin has quit IRC03:08
*** boxiang_ has quit IRC03:13
*** boxiang has joined #openstack-nova03:13
*** tbachman has joined #openstack-nova03:19
*** tbachman_ has quit IRC03:21
*** eharney has quit IRC03:30
*** psachin has quit IRC03:31
*** psachin has joined #openstack-nova03:33
*** rcernin has joined #openstack-nova03:45
*** rcernin has quit IRC03:45
openstackgerritHarshavardhan Metla proposed openstack/nova master: Raising a failure in case of 403  https://review.opendev.org/73506803:46
*** tbachman_ has joined #openstack-nova03:47
*** tbachman has quit IRC03:47
*** tbachman_ is now known as tbachman03:47
*** rcernin has joined #openstack-nova03:50
*** eharney has joined #openstack-nova03:52
*** brinzhang0 has joined #openstack-nova04:11
*** brinzhang has quit IRC04:14
*** Liang__ has quit IRC04:19
*** hamalq has joined #openstack-nova04:22
*** Liang__ has joined #openstack-nova04:23
*** hamalq has quit IRC04:23
*** tbachman_ has joined #openstack-nova04:25
*** tbachman has quit IRC04:26
*** tbachman_ is now known as tbachman04:26
*** markvoelker has joined #openstack-nova04:27
*** evrardjp has quit IRC04:33
*** markvoelker has quit IRC04:33
*** evrardjp has joined #openstack-nova04:33
*** vishalmanchanda has joined #openstack-nova04:43
*** hamalq has joined #openstack-nova04:44
*** hamalq has quit IRC04:49
*** ratailor has joined #openstack-nova05:10
*** factor__ has joined #openstack-nova05:19
*** hamalq has joined #openstack-nova05:21
*** icarusfactor has quit IRC05:22
*** hamalq has quit IRC05:26
*** threestrands has joined #openstack-nova05:27
*** spatel has quit IRC05:29
*** threestrands has quit IRC05:33
*** udesale has joined #openstack-nova05:33
openstackgerritBrin Zhang proposed openstack/nova master: Accurately clean up ARQs resources during build_instances in conductor  https://review.opendev.org/72043905:53
*** jsuchome has joined #openstack-nova06:03
gibistephenfin: yepp, deleting the venv and the pyc files does not help06:46
gibiit is somehow py37 specific as py38 passes in the same repo06:46
gibiwe don't run py37 unit test in the gate as far as I see06:48
bauzasgood morning Nova06:51
bauzasgibi: what's the problem ?06:51
bauzasgibi: nevermind, saw your pastebin06:52
* bauzas testing it locally06:52
*** ircuser-1 has joined #openstack-nova06:55
brinzhang0morning gibi, bauzas06:56
*** rpittau|afk is now known as rpittau06:56
brinzhang0Can I fix this bug ?https://bugs.launchpad.net/nova/+bug/146899206:57
openstackLaunchpad bug 1468992 in OpenStack Compute (nova) "nova list's --tenant filter does not return expected servers" [Low,Triaged] - Assigned to Vishakha Agarwal (vishakha.agarwal)06:57
brinzhang0I saw in the list servers api doesnot contain tenant_id to filter servers, but the CLI can do by novaclinet06:58
*** hamalq has joined #openstack-nova06:58
brinzhang0Do you have time to check this bug?06:59
*** slaweq has joined #openstack-nova07:00
bauzasgibi: no issues with py37 testing http://paste.openstack.org/show/794847/07:01
bauzasfor me07:01
bauzasgibi: I'd suggest you to 'git clean -xfd' your repo07:01
bauzasbrinzhang0: looking07:02
*** hamalq has quit IRC07:02
brinzhang0bauzas: cool07:04
bauzasbrinzhang0: saw johnthetubaguy's comment ? https://bugs.launchpad.net/nova/+bug/1468992/comments/507:05
openstackLaunchpad bug 1468992 in OpenStack Compute (nova) "nova list's --tenant filter does not return expected servers" [Low,Triaged] - Assigned to Vishakha Agarwal (vishakha.agarwal)07:05
bauzasI agree with him, we should discuss this in a spec07:05
brinzhang0bauzas: I saw07:05
brinzhang0I would like to submit a spec, so I want to ensure for you, that I will continue07:06
*** mkrai has quit IRC07:08
*** tesseract has joined #openstack-nova07:08
bauzasbrinzhang0: sorry but I don't understand your question, do you want to be sure I'll review the spec ?07:09
brinzhang0bauzas: no, I just want to ensure that I can push a spec for this bug07:10
brinzhang0I worry about doing meaningless things, so I ask you firstly07:11
*** ccamacho has joined #openstack-nova07:12
*** ttsiouts has joined #openstack-nova07:13
*** psachin has quit IRC07:15
brinzhang0bauzas: how about now? I think I said clearly ^07:15
gibibauzas: git clean did not help, removing venv did not help. But removing $HOME/.cache/pip directory and then removing the venv did helped.07:16
bauzasgibi: ack, gtk07:16
bauzasbrinzhang0: ahah, gotcha, well, it changes the API, right?07:17
*** psachin has joined #openstack-nova07:17
bauzasif so, we need a microversion, hence a spec07:17
brinzhang0gibi: in my env installed 3.6.8, Can I install py3.7 directly? Then directly ./stack.sh?07:18
bauzaswhen i say "it changes the API", that means that the API will behave differently for the same call07:18
brinzhang0bauzas: yes, I will submit a spec07:18
gibibauzas, stephenfin: by removing $HOME/.cache/pip dir I got different dependency versions so some of it caused the fail for me locally http://paste.openstack.org/show/794848/07:20
gibibrinzhang0: I think you can, but I talking about unit test not devstack07:20
openstackgerritSylvain Bauza proposed openstack/nova-specs master: Routed network scheduling spec  https://review.opendev.org/73370307:21
brinzhang0I know, that I want to update my local env, but I am not sure after I update the py37 it can work good07:21
bauzasgibi: you're still having problems ?07:22
brinzhang0gibi: I donot know do you have the same same experience^07:22
gibibauzas: with the new deps the test passes now locally.07:22
gibibauzas: so I guess there is some deps that we should blacklist07:23
bauzasahah, gotcha07:23
bauzaswell, we don't use tooz for example07:23
gibibauzas: I guess we get tooz transitively07:24
bauzasneither taskflow AFAIK07:24
gibibauzas: virt/powervm uses taskflow in nova07:24
bauzasgibi: sure but the issue you got was on mock, right?07:25
gibiyeah, it was a mock issue07:25
bauzasargh /o\07:25
*** dklyle has quit IRC07:25
gibiso none of the deps stands out07:25
gibibrinzhang0: I think you are save to upgrade to 3.707:25
bauzasgibi: I had problems with my local env when I upgraded from an old Fedora release (which was using py2) to F3107:25
brinzhang0gibi: trying now07:26
bauzasbut i fixed all of them by cleaning up my repos07:26
bauzasgibi: have you changed your OS too ?07:26
gibibauzas: it was a fresh machine I had to move of my testing effort so it is a fresh install of ubuntu 18.04 where I see the problem07:27
gibiI guess when I run the test on that machine first I got some bad deps and then later new version of those deps was released so the problem gone now as I forced the redownload07:29
gibiby deleting the local pip cache07:30
* gibi rest his case and goes to do some workout07:30
*** mkrai has joined #openstack-nova07:36
*** tosky has joined #openstack-nova07:36
*** nightmare_unreal has joined #openstack-nova07:41
*** hamalq has joined #openstack-nova07:43
*** rcernin has quit IRC07:47
*** hamalq has quit IRC07:48
*** ttsiouts has quit IRC07:49
*** ttsiouts has joined #openstack-nova07:57
*** ralonsoh has joined #openstack-nova07:57
*** Liang__ has quit IRC08:01
*** maciejjozefczyk has joined #openstack-nova08:02
*** Liang__ has joined #openstack-nova08:02
*** maciejjozefczyk has quit IRC08:03
*** maciejjozefczyk has joined #openstack-nova08:03
*** hamalq has joined #openstack-nova08:16
*** martinkennelly has joined #openstack-nova08:16
*** hamalq_ has joined #openstack-nova08:18
openstackgerritTakashi Natsume proposed openstack/nova master: Remove hacking rules for python 2/3 compatibility  https://review.opendev.org/73398708:19
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.PY2 and six.PY3  https://review.opendev.org/72651208:19
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.add_metaclass  https://review.opendev.org/72656508:19
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.reraise  https://review.opendev.org/72689808:20
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.moves  https://review.opendev.org/72722408:20
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.iteritems/itervalues/iterkeys  https://review.opendev.org/72775708:20
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.byte2int/int2byte  https://review.opendev.org/72777708:20
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.binary_type/integer_types/string_types  https://review.opendev.org/72809408:20
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.text_type (1/2)  https://review.opendev.org/72810908:21
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.text_type (2/2)  https://review.opendev.org/72811708:21
*** hamalq has quit IRC08:21
*** hamalq_ has quit IRC08:23
*** hamalq has joined #openstack-nova08:34
*** hamalq has quit IRC08:38
*** priteau has joined #openstack-nova08:50
*** ociuhandu has quit IRC08:51
*** salmankhan has joined #openstack-nova08:52
*** links has joined #openstack-nova08:55
*** salmankhan1 has joined #openstack-nova08:55
*** tkajinam has quit IRC08:57
*** salmankhan has quit IRC08:57
*** salmankhan1 is now known as salmankhan08:57
*** mkrai has quit IRC09:08
*** mkrai_ has joined #openstack-nova09:08
*** mkrai_ has quit IRC09:09
*** mkrai has joined #openstack-nova09:09
*** Liang__ has quit IRC09:33
openstackgerritWenping Song proposed openstack/nova master: delete sub resource provider when delete resource provider  https://review.opendev.org/71916309:35
*** yaawang_ has quit IRC09:40
openstackgerritsunhao proposed openstack/nova stable/train: hardware: Raise useful error for invalid mempage size  https://review.opendev.org/73595009:48
stephenfinbauzas: Care to review https://review.opendev.org/#/c/734658/ ?10:04
bauzasI can10:04
stephenfinta10:04
bauzasfwiw, I want to look at runways10:04
*** derekh has joined #openstack-nova10:17
*** yaawang_ has joined #openstack-nova10:17
*** rpittau is now known as rpittau|bbl10:18
*** hamalq has joined #openstack-nova10:20
*** ttsiouts has quit IRC10:22
*** ttsiouts has joined #openstack-nova10:23
*** hamalq has quit IRC10:25
*** ttsiouts has quit IRC10:27
*** sean-k-mooney has joined #openstack-nova10:30
*** psachin has quit IRC10:31
*** hamalq has joined #openstack-nova10:37
*** hamalq has quit IRC10:42
brinzhang0stephenfin: hi, we encounter an issue, and I register a blueprint, can you review it? https://blueprints.launchpad.net/oslo.cache/+spec/enable-sasl-protocol10:47
brinzhang0stephenfin: thanks10:48
*** mkrai has quit IRC10:51
*** mkrai_ has joined #openstack-nova10:51
*** derekh has quit IRC11:00
*** derekh has joined #openstack-nova11:00
*** purplerbot has joined #openstack-nova11:00
*** ttsiouts has joined #openstack-nova11:02
*** psachin has joined #openstack-nova11:03
*** tbachman has quit IRC11:05
*** tbachman has joined #openstack-nova11:07
*** ttsiouts has quit IRC11:08
*** mkrai_ has quit IRC11:10
*** ociuhandu has joined #openstack-nova11:12
*** jangutter_ is now known as jangutter11:13
*** artom has joined #openstack-nova11:20
*** ttsiouts has joined #openstack-nova11:25
*** ttsiouts has quit IRC11:26
*** ttsiouts has joined #openstack-nova11:26
*** martinkennelly has quit IRC11:35
*** martinkennelly has joined #openstack-nova11:35
*** mkrai_ has joined #openstack-nova11:42
*** tetsuro_ has joined #openstack-nova11:42
*** raildo has joined #openstack-nova11:44
*** tetsuro has quit IRC11:46
*** tetsuro_ has quit IRC11:51
*** tosky has quit IRC11:56
*** tetsuro has joined #openstack-nova11:57
openstackgerritAlexandre Arents proposed openstack/nova master: Snapshot: offload glance upload in a native thread  https://review.opendev.org/73477611:57
openstackgerritBalazs Gibizer proposed openstack/nova master: Extend is_ipv6_supported() to cover more error cases  https://review.opendev.org/73616711:57
*** psachin has quit IRC11:58
*** boxiang_ has joined #openstack-nova11:58
*** tosky has joined #openstack-nova11:59
*** martinkennelly has quit IRC11:59
*** psachin has joined #openstack-nova12:00
*** martinkennelly has joined #openstack-nova12:00
*** boxiang has quit IRC12:02
openstackgerritAlexandre Arents proposed openstack/nova master: Limit the number of concurrent snapshots  https://review.opendev.org/73616912:02
*** rpittau|bbl is now known as rpittau12:06
*** ratailor has quit IRC12:11
*** ttsiouts has quit IRC12:16
*** ttsiouts has joined #openstack-nova12:16
openstackgerritSean McGinnis proposed openstack/nova master: Use unittest.mock instead of third party mock  https://review.opendev.org/71467612:17
*** ttsiouts has quit IRC12:21
*** martinkennelly has quit IRC12:24
*** ttsiouts has joined #openstack-nova12:25
openstackgerritSean McGinnis proposed openstack/nova master: hacking: force explicit import of python's mock  https://review.opendev.org/70876812:27
*** martinkennelly has joined #openstack-nova12:28
*** jmlowe has quit IRC12:29
*** jmlowe has joined #openstack-nova12:31
*** mkrai_ has quit IRC12:31
*** spatel has joined #openstack-nova12:31
*** jangutter_ has joined #openstack-nova12:33
*** spatel has quit IRC12:36
*** jangutter has quit IRC12:36
*** lbragstad has joined #openstack-nova12:39
openstackgerritMerged openstack/nova master: libvirt: Don't allow "reserving" file-backed memory  https://review.opendev.org/73465812:41
*** nweinber has joined #openstack-nova12:41
*** slaweq_ has joined #openstack-nova12:48
*** slaweq has quit IRC12:48
*** mtreinish has joined #openstack-nova12:50
*** martinkennelly has quit IRC12:58
*** martinkennelly has joined #openstack-nova12:58
*** lvdombrkr has joined #openstack-nova12:58
openstackgerritAlexandre Arents proposed openstack/nova master: Limit the number of concurrent snapshots  https://review.opendev.org/73616913:00
*** martinkennelly has quit IRC13:01
*** alex_xu has joined #openstack-nova13:01
*** slaweq_ is now known as slaweq13:03
openstackgerritAlexandre Arents proposed openstack/nova master: Snapshot: offload glance upload in a native thread  https://review.opendev.org/73477613:04
*** tetsuro has quit IRC13:15
*** ttsiouts has quit IRC13:18
*** ttsiouts has joined #openstack-nova13:19
*** ttsiouts has quit IRC13:19
*** ttsiouts has joined #openstack-nova13:19
*** udesale_ has joined #openstack-nova13:26
*** JamesBenson has quit IRC13:27
*** udesale has quit IRC13:28
openstackgerritStephen Finucane proposed openstack/nova stable/ussuri: libvirt: Don't allow "reserving" file-backed memory  https://review.opendev.org/73621913:37
*** rpittau is now known as rpittau|brb13:39
*** priteau has quit IRC13:40
*** CeeMac has joined #openstack-nova13:44
*** kberger_ has joined #openstack-nova13:45
*** kberger_ has quit IRC13:46
*** kberger_ has joined #openstack-nova13:46
*** KeithMnemonic has quit IRC13:49
*** Liang__ has joined #openstack-nova13:52
*** Liang__ is now known as LiangFang13:53
*** rpittau|brb is now known as rpittau13:53
*** lpetrut has joined #openstack-nova13:56
*** priteau has joined #openstack-nova13:56
*** LiangFang has quit IRC13:57
*** mkrai has joined #openstack-nova13:59
openstackgerritBalazs Gibizer proposed openstack/nova master: Extend is_ipv6_supported() to cover more error cases  https://review.opendev.org/73616714:02
*** martinkennelly has joined #openstack-nova14:03
*** jangutter_ is now known as jangutter14:04
*** liuyulong has joined #openstack-nova14:07
*** rchurch has quit IRC14:14
*** rchurch has joined #openstack-nova14:16
*** ttsiouts has quit IRC14:16
*** ttsiouts has joined #openstack-nova14:17
*** ttsiouts has quit IRC14:21
*** ttsiouts has joined #openstack-nova14:22
TheJuliaGreetings nova folks, would nova be generally amenable if the ironic virt driver had a capability for a user of reserving a physical baremetal machine but not actually triggering the deployment. We're thinking this would basically be a trait, and we could teach ironic to just ignore the deploy if the trait is present, but we woudl also likely update permissions so the user is "leased" the physical node.14:24
dansmithTheJulia: you mean exclude machines with that trait set from the scheduling decision right?14:25
TheJuliawell, mark it in use/active in nova14:25
TheJuliaand tell ironic "hey, this user asked for and is now allocated this hardware" and then the user can pivot APIs to perform super advanced operations14:26
dansmithmeaning nova just "reserves" the node in ironic but does nothing with it, assuming the user is going to do stuff with it out of band?14:26
TheJuliano, more like we just skip the final step telling ironic to perform the deployment14:26
dansmithhow is that different?14:27
TheJuliatoday we actually trigger a deployment which means the machine is delivered in an active state14:27
dansmithI mean how is what you said not what I said?14:28
sean-k-mooneyTheJulia: this sound more like a blazar usecase14:28
dansmithif nova reserves the node (i.e. in placement) but just doesn't ask ironic to do anything with it, that's what you're asking right?14:28
* TheJulia sighs14:28
dansmithsean-k-mooney: agreed14:28
sean-k-mooneythat said we have a trait for marking a compute node as down today14:28
sean-k-mooneyif it was a maintaince usecase then that woudl be approporte to use14:28
sean-k-mooneywe dont really have a reservation concept in nova however14:29
sean-k-mooneynot sure how we would cleanly add one14:29
dansmithsean-k-mooney: I think TheJulia is asking for the opposite of that, for nova to do everything we would normally do to boot on a node, but just ... not boot on the node14:29
dansmithsean-k-mooney: which is basically making nova a reserve-but-don't-touch service, which wouldn't be sensical for anything other than resources that already exist (i.e. physical machines)14:29
sean-k-mooneydansmith: right so still run through the schduler and select the node14:29
TheJuliaLets just drop this because this discussion is just going to not be productive14:29
sean-k-mooneywe had a concept of allowing boot to put instancve into states other then active. e.g. the boot to shelved usecase14:30
*** boxiang has joined #openstack-nova14:30
sean-k-mooneywould something like that make sense14:30
sean-k-mooneyTheJulia: ^ im just not sure what state you would want the instance to be in Nova14:31
TheJuliasean-k-mooney: possibly, I'll pass along the idea14:31
dansmithsean-k-mooney: you mean "we discussed that thing once upon a time" :)14:31
TheJuliasean-k-mooney: ideally active to nova's perception14:31
sean-k-mooneydansmith: yes14:31
dansmithsean-k-mooney: I think the goal here is to use nova's scheduler but not the nova-compute part, which would kinda be akin to "we provision empty VMs on the hypervisor and then you do what you want with them,14:32
sean-k-mooneyTheJulia: so rather then a trait if i was to propose something like this i would proably use an extra spec14:32
dansmithwhich goes against the whole "don't manage our VMs out of band" goal14:32
sean-k-mooneydansmith: right it would conflict with that14:32
dansmithand it would make alllll the other operations you can do on an instance have to be disabled somehow14:32
*** boxiang_ has quit IRC14:32
*** mriedem has joined #openstack-nova14:32
sean-k-mooneywe did have some driver that wanted to prespawn some vms and reallocate one on a boot request in the past right14:33
dansmithlike, what does it mean for you to do a reboot or rebuild or anything else on an instance in that case14:33
dansmithI dunno about that14:33
sean-k-mooneyTheJulia: do they just not want to do the provisioning e.g. would boot without and image be an alternitive14:33
*** mlavalle has joined #openstack-nova14:34
*** psachin has quit IRC14:34
sean-k-mooneyTheJulia: actully ignoring the schduling bit is there a reason they cant just deploy using ironics api14:35
sean-k-mooneypresumable ironic could claim the resouces in placment when you go to ironic directly so that nova/placement would know the host is in use14:37
*** links has quit IRC14:37
*** dklyle has joined #openstack-nova14:44
TheJuliasean-k-mooney: trying to focus on the discussion call I'm on right now, I'll answer afterwards14:50
sean-k-mooneyTheJulia: no worries im watching an internal call too14:51
*** ttsiouts has quit IRC15:01
*** boxiang has quit IRC15:01
*** ttsiouts has joined #openstack-nova15:01
*** boxiang has joined #openstack-nova15:02
*** ratailor has joined #openstack-nova15:05
*** ttsiouts has quit IRC15:06
*** ttsiouts has joined #openstack-nova15:17
*** hamalq has joined #openstack-nova15:17
melwittgmann: have you seen this gate bug before? "ls: cannot access 'uwsgi*': No such file or directory" https://zuul.opendev.org/t/openstack/build/5c1bfbb79c314b11b518a8af51441a00/log/logs/grenade.sh.txt#535415:18
gmannmelwitt: yeah that is ongoing fixes in devstack, and we have merged all the stable branch fix now15:18
*** hamalq_ has joined #openstack-nova15:19
dansmithsince monday I think15:20
melwittgmann: ah thanks, I missed that15:20
melwittI had a thing on stable (stein) fail zuul overnight15:20
gmannyeah,15:21
melwittso I was wonderin15:21
gmannbut grenade multinode job is still issue, fixing in ussuri by backporting running zuulv3 native - https://review.opendev.org/#/c/735948/115:21
gmanntrain and stein might need to make it n-v till we backport the grenade zuulv3 till stein. that is we are discussing in qa channel15:22
*** hamalq has quit IRC15:23
melwittok I'm seeing neutron-grenade-multinode and nova-grenade-live-migration and grenade-py3 failing on stein15:25
melwittand then nova-live-migration is failing with "/opt/stack/new/devstack/lib/infra: line 32: virtualenv: command not found" on stein https://zuul.opendev.org/t/openstack/build/509288c2a75a49609c2f7f4b2e158a60/log/logs/devstack-subnodes-early.txt#294815:28
gmannmelwitt: yeah, that need devstack-gate fix which is not preferred so i am trying to backport the grenade zuulv3 till train.15:33
*** ttsiouts has quit IRC15:33
*** ttsiouts has joined #openstack-nova15:33
*** ttsiouts has quit IRC15:38
melwittgmann: ok, thanks. devstack-gate is branchless I assume?15:45
gmannmelwitt: yeah.15:45
melwittgmann: thanks. have you heard of the other failure before "/opt/stack/new/devstack/lib/infra: line 32: virtualenv: command not found"? for nova-live-migration15:49
*** martinkennelly has quit IRC15:51
*** udesale_ has quit IRC15:53
gibimelwitt: could this be due to http://lists.openstack.org/pipermail/openstack-discuss/2020-June/015425.html ?15:54
melwittgibi: oh maybe, thanks. I missed that, was looking for "gate" in ML15:55
gmannmelwitt: that is same issue grenade multinode job facing15:55
gmannand need fix in devstack-gate15:55
melwittoh, the error message was different so I didn't realize it was related15:56
*** gyee has joined #openstack-nova15:58
*** ratailor has quit IRC16:04
TheJuliadansmith: the goal is more, have the nova-compute driver ask ironic to hold the node, set appropriate values to represent the user has possesion of it and allow the user to do the needful.16:11
TheJuliasean-k-mooney: the conundrum is the users expect to use nova, and currently get resources via nova today, and what they are doing is basically going and making internal invasive chagnes inside the deployed instance to re-install the instance using a kickstart16:11
dansmithTheJulia: yeah that's the same as what I said, just with nova-compute being slightly involved in the enablement of the out-of-band activities16:11
*** dtantsur is now known as dtantsur|afk16:12
TheJuliaWell, it may be logical to enable setting the "leasee" field in ironic's api anyway16:12
TheJuliawhich would allow operators to optionally grant direct api rights16:12
TheJuliaI guess there could always be a trait that populates itself that just signals "don't actually deploy this machine, just allocate it"16:13
dansmiththat's akin to nova setting up a libvirt VM and then tolerating the user or admin mucking with the underlying VM XML16:13
TheJuliaand we could do that under the hood in ironic fairly easily.16:13
dansmithwhich today we declare as "not okay"16:13
*** dlbewley has joined #openstack-nova16:14
TheJuliaWell, we should still eventually store who asked for the thing and if we have community consensus behind a "delayed deployment" trigger, then that is totally up to the operators and their running policy to decide if they want to permit or not to meet their use cases16:15
sean-k-mooneydansmith: for what its worth we had someone asking about pxe booting nova instance a few weeks ago16:17
*** rpittau is now known as rpittau|afk16:17
*** nweinber has quit IRC16:18
sean-k-mooneythey were confused by the fact that if you enable the qemu boot menu via the image porperty you can select pxeboot as an option in the boot menu via the console16:18
*** mkrai has quit IRC16:18
*** nweinber has joined #openstack-nova16:18
sean-k-mooneybut  could not figure out how to configure it which makes sense since we dont support you pxe booting the vms booted by nova16:18
dansmithsean-k-mooney: you mean asking again16:18
sean-k-mooneyit came up on irc like a month ago i assuem it has come up before16:19
dansmithmany times16:19
dansmithI dunno if there would be any ironic parallels here, but changing the image from inside the guest means that anything we do after that based on the image metadata will be wrong16:19
sean-k-mooneyi basically just said thats not supported sorry, it just a leaky abstraction16:20
dansmithlike attaching a device and using the correct device model, or migrating somewhere that looks at image metadata for OS properties, etc16:20
*** dlbewley has quit IRC16:20
sean-k-mooneydansmith: well so i have heard of people upgradeing form like 16.04 to 18.0416:20
sean-k-mooneybut then you get into the pets vs cattle debate16:20
dansmithwhich is wholly uncloudy, but is a lot less bad than going from 16.04 to Windows 1016:20
dansmithyup16:20
*** dlbewley has joined #openstack-nova16:21
sean-k-mooneyya updating the same disto is not really a problem different openrating systemsn entierely like linux to windows or esxi is a tolltal differnt matter16:21
sean-k-mooneyTheJulia: honestly it sound like they should update there kickstart playbook to delegate the os imagiang and provisioning to openstack/ironic and then just deal with boot straping the deployed hosts16:25
TheJuliathe case that is coming up at CERN is apparently they are deploying nodes with configurations that are impossible to articulate in images, so they are making the necessary major changes to get to their required end state after the fact16:26
sean-k-mooneyTheJulia: sure that makes sense but i dont know wny they would not just orcestrat the software payload via ansible and have a seperate role to deploy the orginal server16:27
sean-k-mooneyTheJulia: kind of like kaobe16:27
TheJuliaReally, ideally they should jsut be talking with ironic in some of these cases, but I guess they are trying to force their users into cloudy mindsets/patterns/behaviors16:27
dansmithyup16:28
TheJuliaIt is a mixed vm/baremetal environment, fwiw16:28
dansmithwhat are the "node configurations that are impossible to articulate in images" ?16:29
TheJuliaAnd high level consistency seems to be the key they need, it is almost like power users just need that extra next step16:29
sean-k-mooneyya that is not really an issue johnthetubaguy  could proably tell you more about how they orcestrate the deployment of the Square Kilometer Array (SKA)16:29
TheJuliamulti-disk/raid/lvm/etc16:29
TheJuliadansmith: this came out of the whole disk partitioning discussion getting resurrected16:29
dansmithack, well, addressing that makes more sense to me than just saying "short-circuit the bottom half of nova because it's easier"16:30
*** dlbewley has quit IRC16:30
*** dlbewley has joined #openstack-nova16:30
TheJuliaexcept, then get into the whole pets/cattle argument again and everyone tableflips and walks away16:30
sean-k-mooneycern have a blog post on that but it seam sto be down the stack hpc one is up however https://www.stackhpc.com/software-raid-in-ironic.html16:31
dansmiththat's not a convincing argument to do the short-circuit :)16:31
TheJuliadansmith: it is a solid reason people have downstream patches and are why they are not upgrading though, because their business processes need something along those lines. Anyway, if we enable them to short circuit in ironci, I think that is fine. Nova will believe it is happy. they can do whatever special config assertion as long as we populate leasee which we should be doing anyway.16:32
sean-k-mooneyTheJulia: there are ways to do per instance raid config today howere right16:33
TheJuliawhich _should_ make the world a happier place. Dogs and cats could get married and all16:34
dansmithwhatever, it's just avoiding an abstraction because it's hard16:34
TheJuliasean-k-mooney: it is not just raid sadly, the convergence seemed to be that there are teams with whole kickstart configs and to try and articulate that with traits will just make flavor/trait explosion even worse.16:34
dansmitheven though our only purpose in life is to be an abstraction16:35
TheJuliain a perfect end state, I'd prefer them to get everything in glance and then tie it all together on an image basis, but smaller building blocks16:37
sean-k-mooneyTheJulia: well im not sure i agree that this should all live in glance or in the flavor16:37
sean-k-mooneysome of it should be user-data16:37
dansmithit's not a smaller building block, it's a hammer to break the existing blocks16:38
dansmithit doesn't build us toward a solution, it's an exit plan16:38
dansmithinstead of ever building new blocks, it's a forever solution of "get it to 40% complete and then do the rest custom out of band"16:38
*** ociuhandu_ has joined #openstack-nova16:38
sean-k-mooneyTheJulia: it sound like a way to pass info on a per instance basis to the ironic python agent would partly solve there issue. e.g. if the agent had a defien api of actions such as bios and raid config that could be pass on a per instance basis it would help with the image/flavor explosion issue16:39
TheJuliawoudl it help to have a larger discussion regarding this again, because where this always stalled out was the "how do we end up having something that nova will agree to" in the past in terms of data. and I think the last agreement of a possible solution involved templates stored in glance associated via traits or something which I think made it complex and cumbersome to interact with16:39
sean-k-mooneythe problem is that that for that to make sense it has to be somewhat abstract  as we will not know the precise host ahead of time by design16:40
*** dlbewley has quit IRC16:40
dansmithwe did have a long conversation about this in dublin,16:40
*** dlbewley has joined #openstack-nova16:40
TheJuliasean-k-mooney: we're actually have it, just turns out people want to do even more complex things their own way16:41
*** lvdombrkr has quit IRC16:41
dansmithwhich involved nova just knowing about a hardware template that gets passed to ironic to define these things16:41
dansmiththere was no tableflipping16:41
sean-k-mooneydansmith: to do that we would want to do it in a way that did not invovle specifying the template in the flavor or image right16:41
TheJuliamaybe I was thinking of the time before16:41
sean-k-mooneysuch as a swift url or glance artifcact uuid in server metadata or something else instance based16:42
dansmithsean-k-mooney: I dunno, in the image seems fine to me16:42
sean-k-mooneydansmith: in the image would work only to a point16:42
*** ociuhandu has quit IRC16:42
openstackgerritAlexandre Arents proposed openstack/nova stable/stein: Add admin doc information about image cache resource accounting  https://review.opendev.org/73254216:42
sean-k-mooneyif you assume the raid config is an atribute of that image then sure16:43
*** ociuhandu_ has quit IRC16:43
sean-k-mooneybut if the workload in that image has different performace configurtion it can be deployed in for different slas then you need multiple images16:43
dansmithsean-k-mooney: how the user gets to select it (if at all) is really a smaller concern than all the components supporting that thing regardless of how it's presented16:43
sean-k-mooneytrue16:44
TheJuliaI suspect your thinking that fitting the needs is a conundrum, but in these sorts of cases, the user knows exactly what the hardware is because they have a special flavor to use to match it16:44
dansmithI tend to think that flavors and images are our templating mechanism and optimizing for a one-off deployment of one thing with weird config is not the direction we should go16:45
dansmithTheJulia: right, which is why I think that in the flavor is reasonable in a lot of cases16:45
dansmiththey're already selecting an ironic machine class via flavor anyway16:46
TheJuliaFrom the flip side of that, another operator on the call we had today basically stressed that if they ahd to do that their flavors would explode even more and I think they already have tens of thousands16:46
sean-k-mooneyother then the fact openstack flavor list will be ... difficut to use did they have a partical problem with that16:47
TheJulia(approximately 350,000 physical machines in their fleet is what they say)16:47
*** ociuhandu has joined #openstack-nova16:47
dansmithI suspect that means they're doing it wrong, but regardless, if you literally have thousands of bespoke configurations, you're going to end  up with thousands of incompatible objects somewhere in the system16:47
sean-k-mooneyTheJulia: but presumable that is grouped into a manageable set of SKUs16:47
dansmithsean-k-mooney: that's why I said I expect they're doing it wrong.. they obviously have less than 350k unique configurations of machines, they probably just want to think of each machine as a snowflake16:48
sean-k-mooneyTheJulia: do you know how many unique ironic resouce classes they have16:48
TheJuliasean-k-mooney: I'll ask, I don't know off the top of my head16:49
sean-k-mooneydansmith: right they should have 1 flavor per ironic resouce class + there vm flavors16:49
dansmithright, and not an ironic resource class for every unique serial number :)16:50
*** dlbewley has quit IRC16:50
TheJuliathat is not how anyone is implementing it because they are also needing to access control on the back end who has the ability to access specific resource classes16:50
sean-k-mooneyTheJulia: well that is where they are doing it wrong16:50
sean-k-mooneynova has ways to do access contol on flaovr or via aggreates based on tenatns16:50
*** dlbewley has joined #openstack-nova16:51
TheJuliaarne_wiebalck: ^^^ fyi, you might find this interesting or super frustrating16:51
sean-k-mooneynova has the idea of private flavors so you can create 1 flaovr an choose what tenats can see it16:51
*** ociuhandu has quit IRC16:51
TheJuliaasked the super large operator, I think cern is operating with something like like ~130-140 distinct SKUs across their fleet, some of it is private skus for hyper specific needs/purposes, others are general from what I understand. I believe they've mentioned some crazy number of flavors as well.16:52
TheJuliaugh, apparently the super large operator has lots of downstream patches wrapped around flavors/classes, so their huge numbers are not exactly valid for this discussion since we don't understand the entire story/composition there.16:53
sean-k-mooneyi can see them doing thing like adding a customer specific resouce class so they can dedicate specifc pools to them16:54
sean-k-mooneybut that is not how its ment to be done16:54
TheJuliasean-k-mooney: I _think_ cern has mentioned them doing private flavors before, but that it adds up for admins to dump the list out16:55
mnaserfwiw openstack cli shows public flavors only by default, even for admins16:55
mnaseryou have to explicitly give it --private to get those16:55
*** liuyulong has quit IRC16:56
dansmithsean-k-mooney: exactly16:56
sean-k-mooneywell it can but when you create private flavor you dont create the same flavor multiple times for different tenatnts. you create it once and add the teant 1:1 to the existing flavor16:56
*** jsuchome has quit IRC16:56
*** maciejjozefczyk has quit IRC16:56
*** maciejjozefczyk has joined #openstack-nova16:57
sean-k-mooneymnaser: that is true today but i actully want to change how that work. i want ti to be private if you add a tenat too the flavor acess list and public if not16:57
dansmithand again, if you want thousands of different configs, you'll either end up with thousands of flavors, or thousands of instances with whatever bespoke thing you've asked for, it will just be far less discoverable16:57
sean-k-mooneymnaser: at the moemnt you cant change the private public status and that causes pain16:57
dansmithso people having "all the same flavor" which have been individually hand-managed to be different is just going to end up with that madness being hidden16:57
mnasersean-k-mooney: yeah the move private => public is a bit harsh but im not sure why/how/when it's been the case.  i would have never touched the db and manually changed that field before.  ever.16:58
dansmithwhich is kinda the point of what we're doing here -- trying to manage N things as a unit, where N is too large for any human to do manually16:58
mnaseralso, i agree about the comments wrt instance type shouldn't mean different things, it sucks to manage it at scale, but, there's tons of ways you can (relatively easily) automate something like this16:59
mnasersay, this ansible16:59
sean-k-mooneymnaser: its useful to go from public to private too for decomisioning old flavors16:59
mnasersean-k-mooney: yes, that's true too.  i'm sure someone out there knows the real reason behind it16:59
mnaseri have risked moving private to public, but not public to private as that seemed a little more intense in terms of the things that can break16:59
*** dlbewley has quit IRC17:00
sean-k-mooneymnaser: yep i discussed this with gmann a while back and its on the list of things to "clean up" in a future microverions but we have not put up a blueprint for it yet17:00
*** dlbewley has joined #openstack-nova17:01
*** derekh has quit IRC17:01
sean-k-mooneymnaser: when private flavors where added the ability to move between them was just never adressed so in that regard its a half implemnted feature17:01
sean-k-mooneybut its one i think we can improve.17:01
sean-k-mooneydansmith: i guess the problem is that right now they are managing the N things with kickstart17:02
*** lpetrut has quit IRC17:02
sean-k-mooneyand not tacking advantage of the abstractions provided by openstack17:03
dansmithsean-k-mooney: I thought the tenants were doing that, but yeah17:03
TheJuliasean-k-mooney: no, they are only using kickstart files to rebuild machines17:04
TheJuliabecause they simply need a way more complex running configuration17:04
sean-k-mooneyTheJulia: right but if openstack coudl provide that config would they use it or whould they keep doing it the way they are now so that they can support non openstack envs17:05
sean-k-mooneyby the way i do not use ironic that often so im not sure what capablity you can use via ironic direct vs ironic via nova but even though ironic direct can leverage ironic to do raid and bios config today they are not using it17:07
TheJuliasean-k-mooney: in a perfect world, they would want to be able to re-use the same config or formatting instead of having to go through a bunch of additional steps or abstractions to just get the job done for the day. The point here is they want everything through openstack because of the single pane of glass benefit.17:07
sean-k-mooneyTheJulia: right which is why im confused that they would reimage the machine since that is the opisiste of doing everythin vis openstack17:08
dansmithsean-k-mooney: they want to put a break statement anywhere they want in the workflow to use as much or little openstack as they want17:09
TheJuliasean-k-mooney: because the constraints in which openstack puts them with are insufficent to meet their needs of their business for their 10, 100, 1000 machines they may ask for on a given day17:09
gmannmnaser: sean-k-mooney: on flavor things, its in list to cleanup - item 10 in https://etherpad.opendev.org/p/nova-api-cleanup17:10
gmannwhich is basically get rid of is_public thing and every flavor is private and accessible to allowed tenants only17:10
sean-k-mooneygmann: yep i knew you added it to the list but i did not have it bookmarked17:11
sean-k-mooneygmann: that is not what i had in mind17:11
gmannand that bug adding public flavor things is since liberty - https://bugs.launchpad.net/nova/+bug/136147617:12
openstackLaunchpad bug 1361476 in OpenStack Compute (nova) "flavor access create should check public/private first" [Low,Fix released] - Assigned to Sergey Nikitin (snikitin)17:12
sean-k-mooneygmann: i was thinking every flavor would be public unless you addd a tenatn via flavor access in which case it would only be visable to those that were in the list17:12
gmanni sex, what is is_public default?17:12
gmannsec17:12
sean-k-mooneyit defaults to public/true17:13
sean-k-mooneyso i wanted to keep that behavior17:13
sean-k-mooneybut instead of seting it to public or private explictly base it on the flavor acess info17:13
gmannyeah https://github.com/openstack/nova/blob/6ed556f4adfd8a98fae2e91204f1ce0484f5dd9d/nova/api/openstack/compute/flavor_manage.py#L6917:14
sean-k-mooneye.g. is_public =  "select count(*) form flavor_access where flavor_id = $whatever" == 017:14
gmannright, keeping the same behavior but allowing it to add tenant access and so does list17:15
openstackgerritSean McGinnis proposed openstack/nova master: Use unittest.mock instead of third party mock  https://review.opendev.org/71467617:15
sean-k-mooneyright so you start with a public flaovr. then if you add a tenant to the acess list it "private" and only that tenatn and an admin can see it17:16
sean-k-mooneyif you remove them it avaiable to all again17:16
*** spatel has joined #openstack-nova17:16
sean-k-mooneynova flavor-access-list --flavor <my public flavor> should have eitehr retruned None17:17
sean-k-mooneyso the "fix" to https://bugs.launchpad.net/nova/+bug/1361476 in my view was incorrect17:17
openstackLaunchpad bug 1361476 in OpenStack Compute (nova) "flavor access create should check public/private first" [Low,Fix released] - Assigned to Sergey Nikitin (snikitin)17:17
sean-k-mooneybut it was also done in liberty so its not really important right now17:18
*** JamesBenson has joined #openstack-nova17:18
gmannyeah, its been long it is like that17:18
sean-k-mooneyand since we use or dont use microverions with osc eveyone that use osc does not expect the new behavior17:19
sean-k-mooneynew beign "2.7"17:19
sean-k-mooneythey get the old behavior where its not an error17:19
sean-k-mooneyso you can add flavor access even today you jsut use the old microverion17:20
gmannis it not max version behavior in osc?17:20
sean-k-mooneyno min17:20
gmannby default17:20
*** kberger_ has quit IRC17:20
sean-k-mooneyso by defcault everythin uses 2.117:20
gmanni remember novaclient is default to min but not sure about osc17:20
sean-k-mooneygmann: other way around novaclinet uses latest17:21
sean-k-mooneyosc uses min17:21
sean-k-mooneyso nova clients behavior change depending on the clinet version and api you are talking too17:21
gmannah yeah otherway around.17:21
sean-k-mooneyosc is consitent regardless of the verion or cloud17:21
*** JamesBenson has quit IRC17:21
*** nightmare_unreal has quit IRC17:24
*** KeithMnemonic has joined #openstack-nova17:25
*** KeithMnemonic has quit IRC17:27
*** jangutter has quit IRC17:37
*** KeithMnemonic has joined #openstack-nova17:37
*** KeithMnemonic has quit IRC17:43
melwittsean-k-mooney: do you know of a way of changing a guest's video model other than virsh editing it? context is the cirrus-vga type got deprecated https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/8.2_release_notes/deprecated_functionality#deprecated-functionality_virtualization and can result in bad looking low res vnc console18:02
melwittit used to look fine prior to an upgrade to stein, then looked messed up. so I'm trying to determine how users could update their existing instances18:04
*** dlbewley has quit IRC18:04
*** dlbewley has joined #openstack-nova18:05
*** tesseract has quit IRC18:12
sean-k-mooneymelwitt: yes you can use hw_video_model in the image metadata18:24
sean-k-mooneymelwitt: i always use virtio18:25
melwittsean-k-mooney: ok, how to get an already existing instance to pick that up without rebuilding it?18:25
sean-k-mooneymelwitt: db edit18:25
melwittok, so db edit instead of a virsh edit.. and then hard reboot the instance?18:25
sean-k-mooneyadd img_hw_video_memory=virtio in the system_metadata table18:26
sean-k-mooneyyep18:26
melwittok. guh18:26
sean-k-mooney img_hw_video_model=virtio not memory18:26
sean-k-mooneymelwitt: is this for a customer or you?18:27
melwittwe're defaulting to the deprecaed 'cirrus' on master even, so I think that needs to change https://github.com/openstack/nova/blob/6ed556f4adfd8a98fae2e91204f1ce0484f5dd9d/nova/virt/libvirt/config.py#L194918:27
melwittcustomer18:27
sean-k-mooney ah then rebuild18:27
sean-k-mooneywe also just added docs for this in OSP and no one metioned the deprecate or asked us to not sure that docs appies18:28
sean-k-mooneythat is for base rhel not the advance virt stream which we use in osp18:28
melwittsean-k-mooney: do you happen to know which value would be an appropriate default being that cirrus is deprecated? the choices in the aforementioned 8.2 release notes give choices of stdvga, virtio-vga, or qxl18:28
sean-k-mooneythe only one of those 3 that would work is qxl that doc is for using kvm directly18:29
sean-k-mooney*libvirt not kvm18:29
melwittah good to know18:29
melwittyeah, the customer is working around by setting hw_video_model=qxl but obvs that only works for new instances18:29
melwitt*setting in image meta18:30
sean-k-mooneywhat release is it18:30
sean-k-mooneyhttps://bugzilla.redhat.com/show_bug.cgi?id=171450818:30
openstackbugzilla.redhat.com bug 1714508 in openstack-nova "[RFE] add support for virtio-gpu" [Low,Verified] - Assigned to smooney18:30
melwittsean-k-mooney: what were you saying earlier about we just added docs for this in OSP? can you point me to what you're talking about18:30
sean-k-mooneythat was traicking the virtio-gpu supprot added in train18:30
melwittsean-k-mooney: stein18:30
sean-k-mooneyya so stein they should use qxl18:31
sean-k-mooneymelwitt: yep we just added docs an im looking for them now18:31
melwittsean-k-mooney: does this mean you don't think this is something we need to change upstream too for the default? I would have thought if the default is deprecated in qemu we should have a default that works for all distros?18:33
sean-k-mooneyvirtio does not work for windows by default18:34
sean-k-mooneybut it is the default we shoudl use18:34
sean-k-mooneyqxl works for linux and windows guests18:34
melwittdoes that mean qxl doesn't work on windows?18:34
melwittok. I was thinking maybe the default should be qxl18:35
sean-k-mooneybut while its the best of the non virto option im not sure we should default to it18:35
sean-k-mooneyqxl was developed to have a better gpu for spice18:35
melwittbut defaulting to a deprecated thing?18:35
sean-k-mooneyit work with novnc too18:35
sean-k-mooneymelwitt: without recored the current gpu we could break people on upgrade18:35
sean-k-mooneyso if we want to chang eit we need to record the current value18:36
sean-k-mooneywere recordign the current value is just popluating that value in the system metadata table18:36
*** spatel has quit IRC18:37
melwittguh, I don't know enough about this stuff to understand what needs to be done here. all I know is the cirrus default messes up novnc18:37
*** dlbewley has quit IRC18:37
melwitton rhel 8.218:37
sean-k-mooneymelwitt: as of when because it used to work18:37
*** dlbewley has joined #openstack-nova18:37
melwittit works, it's just greyscale and low res18:37
sean-k-mooneyah so its a rhel 8.2 issue with what the qemu version we use or no vnc18:37
melwittyeah18:38
sean-k-mooneythat sound like a qemu bug18:38
sean-k-mooneybasically if we change the default and you upgrade then hard reboot18:38
sean-k-mooneythe gpu pci device would change18:38
sean-k-mooneyif you dont have the qxl driver then the console would not work right18:39
sean-k-mooneyqxl has a vga comapatible interface to the generic window vga driver will work with it an dit should work on linux out of the box18:39
melwittI see18:39
*** spatel has joined #openstack-nova18:39
sean-k-mooneymelwitt: are we setting a default graphic model if you dont request one?18:44
sean-k-mooneyor are we currently leaving it to libvirt/qemu18:44
melwittyeah, the link I posted earlier https://github.com/openstack/nova/blob/6ed556f4adfd8a98fae2e91204f1ce0484f5dd9d/nova/virt/libvirt/config.py#L1949 we set cirrus18:45
*** hamalq_ has quit IRC18:50
sean-k-mooneymelwitt: ya we proably should just remove that line18:50
melwittok. I'll do some local tests to see what happens when I remove it18:51
sean-k-mooneywell we need to set it to none i guess and only populate the xml atribute if its set18:52
sean-k-mooneywe also have another place we defualt it i think18:52
*** hamalq has joined #openstack-nova18:53
sean-k-mooneywe should not be defaulting it in that file in anycase18:53
melwittin driver.py we set it special based on things like virt_type or guest arch or spice18:53
sean-k-mooneyyep that is what im thinking of18:53
*** hamalq_ has joined #openstack-nova18:53
melwittbut in the customer's case it's cirrus because of what's in the default config.py18:53
sean-k-mooneywe should only be adding this if you have a vnc/spice console too18:54
melwitt"this" meaning what, qxl?18:54
sean-k-mooneythe graphics device18:55
melwittoh that config section altogether you mean18:55
sean-k-mooneyya if you use the serial console you should not have a graphics device18:55
melwittah yeah, we are actually only doing it for certain consoles in driver.py18:56
sean-k-mooneyif you use novnc or spice then we auto add a graphic element to provide the frame buffer18:56
melwittI just didn't see that earlier18:56
melwittyeah we're only doing for novnc and spice18:56
sean-k-mooneyyep which is correct18:57
melwittthat we add that xml section for the video device18:57
sean-k-mooneywell i guess we would do it for RDP18:57
sean-k-mooneymaybe?18:57
melwittI don't see rdp in here18:57
sean-k-mooneyoh RDP is only supported with hyperv18:57
*** hamalq has quit IRC18:57
melwittyeah it's hyperv18:57
melwittok, so sounds like everything is good except we shouldn't be setting a default and just let qemu/kvm handle it18:57
sean-k-mooneyhttps://github.com/openstack/nova/blob/6ed556f4adfd8a98fae2e91204f1ce0484f5dd9d/nova/virt/libvirt/driver.py#L5989-L599818:58
sean-k-mooneymelwitt: that would alow them to contol the default and or deprecation18:58
melwittmake sense18:58
sean-k-mooneybut the downside is we loose contol over that18:58
sean-k-mooneyso our guest abi will alter with theres18:58
sean-k-mooneythat is ok i guess since you can use the image property if you care18:59
melwittand yeah that's the code I was looking and the helper function being called there18:59
sean-k-mooneyya so this https://github.com/openstack/nova/blob/6ed556f4adfd8a98fae2e91204f1ce0484f5dd9d/nova/virt/libvirt/driver.py#L5351-L5367 is basically working around libvit/qemu not doing the right thing by default19:00
sean-k-mooneywell and the fact we set a default in the xml generation class19:01
sean-k-mooneyso if we remove that default19:01
sean-k-mooneythen we might not need all those specal cases19:02
melwittok, well one step at a time I guess :P19:02
melwittI do some local tests to see what happens when I remove the default19:02
melwitt*I'll19:02
sean-k-mooneyok let me know an i can review. https://www.kraxel.org/blog/2019/09/display-devices-in-qemu/ is a review of some to the option and recomendations19:03
melwittthanks19:04
sean-k-mooneyi need to remove the gop device i added by mistake last cycle and add https://www.kraxel.org/blog/2019/09/display-devices-in-qemu/#bochs-display19:04
sean-k-mooneyapparently gop is only for the bhve hypervior but the libvirt doc did not mention that19:04
sean-k-mooneybochs implements a uefi graphic output protocol (gop) device for kvm19:06
sean-k-mooneyso that is the one i should have added19:07
*** spatel has quit IRC19:08
sean-k-mooneymelwitt: during the ptg we disucssed breifly the idea of a resize for something other then a flavor change19:10
sean-k-mooneymaybe this could be another usecause for that19:10
*** dlbewley has quit IRC19:10
*** dlbewley has joined #openstack-nova19:11
sean-k-mooneyi think this was in the context of changing machine_types where i was suggeign a new retype server action but perhaps something more generic that would update the embed flavor and image with the latest would make more sense19:12
sean-k-mooneye.g. a recreate action but that preserved all ports, volume and disks19:12
melwitthow was that suggestion received, I'm curious heh19:14
melwittlike, I know lots of people would like to do that. in my case, I'm trying to recover from what I consider a bug, the default being set to a deprecated thing and glitching out the vnc console19:14
sean-k-mooneyreusing resize was dansmith idea i was thinking it shoudl be its onw server action. not sure if dansmith actully was in favor or just saying if it was to be done i would start there19:15
melwittah, cool19:15
sean-k-mooneymelwitt: the main think would be that recreate would have to be a move operation like resize so we can validate the new requirement19:16
sean-k-mooneysince we cant assume the current host is valid anymore19:16
melwittyeah. well, we validate the new stuff on a rebuild too since a few releases ago19:16
sean-k-mooneybut i think it would fix a lot of the thing that hard reboot fix but which require the flaovr or image properties to be modified19:16
sean-k-mooneymelwitt: only if the image changes19:17
melwittyeah, it would make life a lot easier for a lot of people19:17
sean-k-mooneyyeah so i think it has merit but not sure where it sits in the priortiy queue19:17
melwittyeah, I'm just saying that we validate even during rebuild so I think it makes sense to validate on a recreate/resize if we're consuming new image props etc19:17
melwittwe're already doing it19:18
melwitt*doing similar19:18
sean-k-mooneyfor me i think it would be a good way to opt into changing the machine type for example19:18
sean-k-mooneyanyway im going to go buy icecream and i guess other food before the stores start to close19:19
* sean-k-mooney does need to go grocery shopping but is craving ben and jerry's19:21
*** dlbewley has quit IRC19:21
*** dlbewley has joined #openstack-nova19:21
*** ralonsoh has quit IRC19:22
sean-k-mooneyhum not sure if good pr or pr blunder https://www.benjerry.ie/flavours/netflix-and-chillld-ice-cream19:22
melwittthanks for the video model chat o/19:28
*** ttsiouts has joined #openstack-nova19:32
mnaseris there reasoning behind what has ended up being validated in the api layer and what doesn't get validated in the api layer?19:36
mnaseri haven't replicated this yet (but in theory i can imagine it's possible): end user tried to create a vm where image size > disk size when doing bfv19:37
mnaserand they don't really get much more of a helpful error (and their request gets refused too obviously)19:37
mnaserbut only after it fails, in what i assume nova-compute trying to ask cinder to create a disk that's impossible to create19:37
*** vishalmanchanda has quit IRC19:38
*** spatel has joined #openstack-nova19:40
*** dlbewley has quit IRC19:41
*** dlbewley has joined #openstack-nova19:42
*** ttsiouts has quit IRC19:42
*** ttsiouts has joined #openstack-nova19:43
*** ttsiouts has quit IRC19:47
*** ociuhandu has joined #openstack-nova19:52
melwittmnaser: generally we validate whatever we can in the api layer to fail fast and avoid the behavior you're describing (fail later on nova-compute). within reason though, as some checks would involve rpc call to the compute host and we avoid that to some degree19:53
melwittmnaser: I found this part where we validate the image_min_disk against the volume disk size, but that might be different than just the image size as in your example? https://github.com/openstack/nova/blob/master/nova/compute/api.py#L68119:54
mnasermelwitt: oh interesting, you're right, i wonder if this is a case where the user did not have min_disk specified..19:56
mnasermelwitt: oh but we don't do image_size > dest_size19:56
mnaserunlike https://github.com/openstack/nova/blob/master/nova/compute/api.py#L693-L69519:57
mnaserso i _think_ the scenario is no min_disk but no checks on image_size / dst_size19:58
melwittright thats what I was saying I wonder if thats different19:58
melwittactually don't know why it's different but I'm not a bfv expert19:59
mnasermelwitt: i think it is, min_size is taken from a glance property which is user-provided (unless a snapshot is taken)19:59
mnaserso i assume user here uploaded an image without min_size19:59
melwittyeah I mean I don't know why we wouldn't do the same checks for the volume case20:01
melwittlike is that intentional or an oversight20:01
mnasermelwitt: yeah -- in my opinion its an oversight but indeed, maybe someone knows better :)20:02
mnaseranyhow20:02
mnaserill have a patch up shortly20:03
*** CeeMac has quit IRC20:04
mnasermelwitt: i swear i saw you mention a while back a key to click before copying from github which gave you a commit hash'd url instead of master20:05
melwittit's 'y'20:05
mnaseroh awesome, thanks20:09
mnaserhttps://bugs.launchpad.net/nova/+bug/188396920:09
openstackLaunchpad bug 1883969 in OpenStack Compute (nova) "Nova doesn't fail at API layer when image_size > volume_size with BFV" [Undecided,New]20:09
* mnaser has a patch and doing unit tests20:10
*** pas-ha_ has joined #openstack-nova20:11
*** tobberydberg_ has joined #openstack-nova20:12
*** tosky_ has joined #openstack-nova20:12
melwittsweet mnaser++20:13
*** tosky has quit IRC20:13
*** tosky_ is now known as tosky20:13
*** irclogbot_3 has quit IRC20:14
openstackgerritMohammed Naser proposed openstack/nova master: bfv: check if image_size > volume_size in API  https://review.opendev.org/73637020:14
mnasermelwitt: ^ voila, the unit test i wrote passed locally but i didnt run the whole suite20:14
mnaserit makes sense to me™20:14
*** CeeMac has joined #openstack-nova20:15
*** gyee has quit IRC20:17
*** brinzhang0 has quit IRC20:18
*** brinzhang0 has joined #openstack-nova20:18
*** purplerbot has quit IRC20:18
*** tobberydberg has quit IRC20:18
*** alex_xu has quit IRC20:18
*** masayukig has quit IRC20:18
*** pas-ha has quit IRC20:18
*** mgoddard has quit IRC20:18
*** dtruong has quit IRC20:18
*** kevinbenton has quit IRC20:18
*** amorin has quit IRC20:18
*** pas-ha_ is now known as pas-ha20:18
*** brinzhang0 has quit IRC20:19
*** dtruong has joined #openstack-nova20:19
*** kevinbenton has joined #openstack-nova20:19
openstackgerritMohammed Naser proposed openstack/nova master: bfv: check if image_size > volume_size in API  https://review.opendev.org/73637020:20
*** amorin has joined #openstack-nova20:20
*** irclogbot_1 has joined #openstack-nova20:21
*** mgoddard has joined #openstack-nova20:21
*** purplerbot has joined #openstack-nova20:23
*** masayukig has joined #openstack-nova20:24
*** gyee has joined #openstack-nova20:31
*** nweinber has quit IRC20:35
*** pas-ha has quit IRC20:35
melwittmnaser: cool I'll check it20:36
*** csatari has quit IRC20:39
*** knikolla has quit IRC20:40
*** dlbewley has quit IRC20:40
*** dlbewley has joined #openstack-nova20:41
*** knikolla has joined #openstack-nova20:42
*** tonyb[m] has quit IRC20:43
*** mriedem has left #openstack-nova20:46
*** ociuhandu has quit IRC20:48
*** PrinzElvis has quit IRC20:49
*** priteau has quit IRC20:49
*** dlbewley has quit IRC20:50
*** dlbewley has joined #openstack-nova20:51
*** knikolla has quit IRC20:52
*** ttsiouts has joined #openstack-nova20:52
*** PrinzElvis has joined #openstack-nova20:53
*** ttsiouts has quit IRC20:57
*** PrinzElvis has quit IRC20:57
*** maciejjozefczyk has quit IRC21:00
*** dlbewley has quit IRC21:06
*** dlbewley has joined #openstack-nova21:06
*** spatel has quit IRC21:13
*** ociuhandu has joined #openstack-nova21:19
*** xek has quit IRC21:20
*** ociuhandu has quit IRC21:24
*** amodi has quit IRC21:25
*** dlbewley has quit IRC21:25
*** dlbewley has joined #openstack-nova21:26
*** salmankhan has quit IRC21:27
*** xiaolin has quit IRC21:27
*** pas-ha has joined #openstack-nova21:34
*** PrinzElvis has joined #openstack-nova21:35
*** dlbewley has quit IRC21:35
*** dlbewley has joined #openstack-nova21:36
*** tonyb[m] has joined #openstack-nova21:38
*** csatari has joined #openstack-nova21:38
*** spatel has joined #openstack-nova21:38
*** knikolla has joined #openstack-nova21:40
*** slaweq has quit IRC21:41
*** raildo has quit IRC21:42
*** spatel has quit IRC21:43
*** spatel has joined #openstack-nova21:45
*** tosky has quit IRC21:56
*** tosky has joined #openstack-nova21:56
*** spatel has quit IRC22:02
*** dlbewley has quit IRC22:05
*** dlbewley has joined #openstack-nova22:06
gmannsean-k-mooney: mnaser and to make listing flavor better (instead of need of --private or --all explicitly ) we should add the admin as default tenant access in private flavor.  currently what all admin can list the flavors by default and what all it can delete is not matching.22:09
gmannalso --private and --all is all admin things and for non-admin --private is just ignored - https://github.com/openstack/nova/blob/6ed556f4adfd8a98fae2e91204f1ce0484f5dd9d/nova/api/openstack/compute/flavors.py#L10622:09
gmannif we add admin as default tenant access in private flavor then i think we can solve it in backward compatible way but it will be interop issue so that still need microversion.22:13
*** spatel has joined #openstack-nova22:29
*** spatel has quit IRC22:32
*** rcernin has joined #openstack-nova22:42
*** gyee has quit IRC22:52
*** tkajinam has joined #openstack-nova22:54
*** tosky has quit IRC23:09
*** hoonetorg has quit IRC23:10
*** hoonetorg has joined #openstack-nova23:22
*** CeeMac has quit IRC23:34

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!