*** gyee has quit IRC | 00:01 | |
*** artom has quit IRC | 00:08 | |
*** boxiang_ has joined #openstack-nova | 00:15 | |
*** hamalq has quit IRC | 00:15 | |
*** mlavalle has quit IRC | 00:15 | |
*** brinzhang has joined #openstack-nova | 00:16 | |
*** boxiang has quit IRC | 00:16 | |
*** tetsuro has joined #openstack-nova | 00:42 | |
openstackgerrit | sunhao proposed openstack/nova stable/ussuri: hardware: Raise useful error for invalid mempage size https://review.opendev.org/736073 | 01:05 |
---|---|---|
openstackgerrit | sunhao proposed openstack/nova stable/train: hardware: Raise useful error for invalid mempage size https://review.opendev.org/735950 | 01:14 |
*** Liang__ has joined #openstack-nova | 01:15 | |
*** spatel has joined #openstack-nova | 01:21 | |
openstackgerrit | sunhao proposed openstack/nova stable/train: hardware: Raise useful error for invalid mempage size https://review.opendev.org/735950 | 01:31 |
*** xiaolin has joined #openstack-nova | 01:40 | |
*** mriedem has quit IRC | 02:23 | |
*** lbragstad has quit IRC | 02:31 | |
*** tbachman has quit IRC | 02:43 | |
*** tbachman_ has joined #openstack-nova | 02:43 | |
*** psachin has joined #openstack-nova | 02:48 | |
*** rcernin has quit IRC | 02:49 | |
*** rcernin has joined #openstack-nova | 02:54 | |
*** mkrai has joined #openstack-nova | 02:59 | |
*** rcernin has quit IRC | 03:08 | |
*** boxiang_ has quit IRC | 03:13 | |
*** boxiang has joined #openstack-nova | 03:13 | |
*** tbachman has joined #openstack-nova | 03:19 | |
*** tbachman_ has quit IRC | 03:21 | |
*** eharney has quit IRC | 03:30 | |
*** psachin has quit IRC | 03:31 | |
*** psachin has joined #openstack-nova | 03:33 | |
*** rcernin has joined #openstack-nova | 03:45 | |
*** rcernin has quit IRC | 03:45 | |
openstackgerrit | Harshavardhan Metla proposed openstack/nova master: Raising a failure in case of 403 https://review.opendev.org/735068 | 03:46 |
*** tbachman_ has joined #openstack-nova | 03:47 | |
*** tbachman has quit IRC | 03:47 | |
*** tbachman_ is now known as tbachman | 03:47 | |
*** rcernin has joined #openstack-nova | 03:50 | |
*** eharney has joined #openstack-nova | 03:52 | |
*** brinzhang0 has joined #openstack-nova | 04:11 | |
*** brinzhang has quit IRC | 04:14 | |
*** Liang__ has quit IRC | 04:19 | |
*** hamalq has joined #openstack-nova | 04:22 | |
*** Liang__ has joined #openstack-nova | 04:23 | |
*** hamalq has quit IRC | 04:23 | |
*** tbachman_ has joined #openstack-nova | 04:25 | |
*** tbachman has quit IRC | 04:26 | |
*** tbachman_ is now known as tbachman | 04:26 | |
*** markvoelker has joined #openstack-nova | 04:27 | |
*** evrardjp has quit IRC | 04:33 | |
*** markvoelker has quit IRC | 04:33 | |
*** evrardjp has joined #openstack-nova | 04:33 | |
*** vishalmanchanda has joined #openstack-nova | 04:43 | |
*** hamalq has joined #openstack-nova | 04:44 | |
*** hamalq has quit IRC | 04:49 | |
*** ratailor has joined #openstack-nova | 05:10 | |
*** factor__ has joined #openstack-nova | 05:19 | |
*** hamalq has joined #openstack-nova | 05:21 | |
*** icarusfactor has quit IRC | 05:22 | |
*** hamalq has quit IRC | 05:26 | |
*** threestrands has joined #openstack-nova | 05:27 | |
*** spatel has quit IRC | 05:29 | |
*** threestrands has quit IRC | 05:33 | |
*** udesale has joined #openstack-nova | 05:33 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: Accurately clean up ARQs resources during build_instances in conductor https://review.opendev.org/720439 | 05:53 |
*** jsuchome has joined #openstack-nova | 06:03 | |
gibi | stephenfin: yepp, deleting the venv and the pyc files does not help | 06:46 |
gibi | it is somehow py37 specific as py38 passes in the same repo | 06:46 |
gibi | we don't run py37 unit test in the gate as far as I see | 06:48 |
bauzas | good morning Nova | 06:51 |
bauzas | gibi: what's the problem ? | 06:51 |
bauzas | gibi: nevermind, saw your pastebin | 06:52 |
* bauzas testing it locally | 06:52 | |
*** ircuser-1 has joined #openstack-nova | 06:55 | |
brinzhang0 | morning gibi, bauzas | 06:56 |
*** rpittau|afk is now known as rpittau | 06:56 | |
brinzhang0 | Can I fix this bug ?https://bugs.launchpad.net/nova/+bug/1468992 | 06:57 |
openstack | Launchpad bug 1468992 in OpenStack Compute (nova) "nova list's --tenant filter does not return expected servers" [Low,Triaged] - Assigned to Vishakha Agarwal (vishakha.agarwal) | 06:57 |
brinzhang0 | I saw in the list servers api doesnot contain tenant_id to filter servers, but the CLI can do by novaclinet | 06:58 |
*** hamalq has joined #openstack-nova | 06:58 | |
brinzhang0 | Do you have time to check this bug? | 06:59 |
*** slaweq has joined #openstack-nova | 07:00 | |
bauzas | gibi: no issues with py37 testing http://paste.openstack.org/show/794847/ | 07:01 |
bauzas | for me | 07:01 |
bauzas | gibi: I'd suggest you to 'git clean -xfd' your repo | 07:01 |
bauzas | brinzhang0: looking | 07:02 |
*** hamalq has quit IRC | 07:02 | |
brinzhang0 | bauzas: cool | 07:04 |
bauzas | brinzhang0: saw johnthetubaguy's comment ? https://bugs.launchpad.net/nova/+bug/1468992/comments/5 | 07:05 |
openstack | Launchpad bug 1468992 in OpenStack Compute (nova) "nova list's --tenant filter does not return expected servers" [Low,Triaged] - Assigned to Vishakha Agarwal (vishakha.agarwal) | 07:05 |
bauzas | I agree with him, we should discuss this in a spec | 07:05 |
brinzhang0 | bauzas: I saw | 07:05 |
brinzhang0 | I would like to submit a spec, so I want to ensure for you, that I will continue | 07:06 |
*** mkrai has quit IRC | 07:08 | |
*** tesseract has joined #openstack-nova | 07:08 | |
bauzas | brinzhang0: sorry but I don't understand your question, do you want to be sure I'll review the spec ? | 07:09 |
brinzhang0 | bauzas: no, I just want to ensure that I can push a spec for this bug | 07:10 |
brinzhang0 | I worry about doing meaningless things, so I ask you firstly | 07:11 |
*** ccamacho has joined #openstack-nova | 07:12 | |
*** ttsiouts has joined #openstack-nova | 07:13 | |
*** psachin has quit IRC | 07:15 | |
brinzhang0 | bauzas: how about now? I think I said clearly ^ | 07:15 |
gibi | bauzas: git clean did not help, removing venv did not help. But removing $HOME/.cache/pip directory and then removing the venv did helped. | 07:16 |
bauzas | gibi: ack, gtk | 07:16 |
bauzas | brinzhang0: ahah, gotcha, well, it changes the API, right? | 07:17 |
*** psachin has joined #openstack-nova | 07:17 | |
bauzas | if so, we need a microversion, hence a spec | 07:17 |
brinzhang0 | gibi: in my env installed 3.6.8, Can I install py3.7 directly? Then directly ./stack.sh? | 07:18 |
bauzas | when i say "it changes the API", that means that the API will behave differently for the same call | 07:18 |
brinzhang0 | bauzas: yes, I will submit a spec | 07:18 |
gibi | bauzas, stephenfin: by removing $HOME/.cache/pip dir I got different dependency versions so some of it caused the fail for me locally http://paste.openstack.org/show/794848/ | 07:20 |
gibi | brinzhang0: I think you can, but I talking about unit test not devstack | 07:20 |
openstackgerrit | Sylvain Bauza proposed openstack/nova-specs master: Routed network scheduling spec https://review.opendev.org/733703 | 07:21 |
brinzhang0 | I know, that I want to update my local env, but I am not sure after I update the py37 it can work good | 07:21 |
bauzas | gibi: you're still having problems ? | 07:22 |
brinzhang0 | gibi: I donot know do you have the same same experience^ | 07:22 |
gibi | bauzas: with the new deps the test passes now locally. | 07:22 |
gibi | bauzas: so I guess there is some deps that we should blacklist | 07:23 |
bauzas | ahah, gotcha | 07:23 |
bauzas | well, we don't use tooz for example | 07:23 |
gibi | bauzas: I guess we get tooz transitively | 07:24 |
bauzas | neither taskflow AFAIK | 07:24 |
gibi | bauzas: virt/powervm uses taskflow in nova | 07:24 |
bauzas | gibi: sure but the issue you got was on mock, right? | 07:25 |
gibi | yeah, it was a mock issue | 07:25 |
bauzas | argh /o\ | 07:25 |
*** dklyle has quit IRC | 07:25 | |
gibi | so none of the deps stands out | 07:25 |
gibi | brinzhang0: I think you are save to upgrade to 3.7 | 07:25 |
bauzas | gibi: I had problems with my local env when I upgraded from an old Fedora release (which was using py2) to F31 | 07:25 |
brinzhang0 | gibi: trying now | 07:26 |
bauzas | but i fixed all of them by cleaning up my repos | 07:26 |
bauzas | gibi: have you changed your OS too ? | 07:26 |
gibi | bauzas: it was a fresh machine I had to move of my testing effort so it is a fresh install of ubuntu 18.04 where I see the problem | 07:27 |
gibi | I guess when I run the test on that machine first I got some bad deps and then later new version of those deps was released so the problem gone now as I forced the redownload | 07:29 |
gibi | by deleting the local pip cache | 07:30 |
* gibi rest his case and goes to do some workout | 07:30 | |
*** mkrai has joined #openstack-nova | 07:36 | |
*** tosky has joined #openstack-nova | 07:36 | |
*** nightmare_unreal has joined #openstack-nova | 07:41 | |
*** hamalq has joined #openstack-nova | 07:43 | |
*** rcernin has quit IRC | 07:47 | |
*** hamalq has quit IRC | 07:48 | |
*** ttsiouts has quit IRC | 07:49 | |
*** ttsiouts has joined #openstack-nova | 07:57 | |
*** ralonsoh has joined #openstack-nova | 07:57 | |
*** Liang__ has quit IRC | 08:01 | |
*** maciejjozefczyk has joined #openstack-nova | 08:02 | |
*** Liang__ has joined #openstack-nova | 08:02 | |
*** maciejjozefczyk has quit IRC | 08:03 | |
*** maciejjozefczyk has joined #openstack-nova | 08:03 | |
*** hamalq has joined #openstack-nova | 08:16 | |
*** martinkennelly has joined #openstack-nova | 08:16 | |
*** hamalq_ has joined #openstack-nova | 08:18 | |
openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove hacking rules for python 2/3 compatibility https://review.opendev.org/733987 | 08:19 |
openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.PY2 and six.PY3 https://review.opendev.org/726512 | 08:19 |
openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.add_metaclass https://review.opendev.org/726565 | 08:19 |
openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.reraise https://review.opendev.org/726898 | 08:20 |
openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.moves https://review.opendev.org/727224 | 08:20 |
openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.iteritems/itervalues/iterkeys https://review.opendev.org/727757 | 08:20 |
openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.byte2int/int2byte https://review.opendev.org/727777 | 08:20 |
openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.binary_type/integer_types/string_types https://review.opendev.org/728094 | 08:20 |
openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.text_type (1/2) https://review.opendev.org/728109 | 08:21 |
openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.text_type (2/2) https://review.opendev.org/728117 | 08:21 |
*** hamalq has quit IRC | 08:21 | |
*** hamalq_ has quit IRC | 08:23 | |
*** hamalq has joined #openstack-nova | 08:34 | |
*** hamalq has quit IRC | 08:38 | |
*** priteau has joined #openstack-nova | 08:50 | |
*** ociuhandu has quit IRC | 08:51 | |
*** salmankhan has joined #openstack-nova | 08:52 | |
*** links has joined #openstack-nova | 08:55 | |
*** salmankhan1 has joined #openstack-nova | 08:55 | |
*** tkajinam has quit IRC | 08:57 | |
*** salmankhan has quit IRC | 08:57 | |
*** salmankhan1 is now known as salmankhan | 08:57 | |
*** mkrai has quit IRC | 09:08 | |
*** mkrai_ has joined #openstack-nova | 09:08 | |
*** mkrai_ has quit IRC | 09:09 | |
*** mkrai has joined #openstack-nova | 09:09 | |
*** Liang__ has quit IRC | 09:33 | |
openstackgerrit | Wenping Song proposed openstack/nova master: delete sub resource provider when delete resource provider https://review.opendev.org/719163 | 09:35 |
*** yaawang_ has quit IRC | 09:40 | |
openstackgerrit | sunhao proposed openstack/nova stable/train: hardware: Raise useful error for invalid mempage size https://review.opendev.org/735950 | 09:48 |
stephenfin | bauzas: Care to review https://review.opendev.org/#/c/734658/ ? | 10:04 |
bauzas | I can | 10:04 |
stephenfin | ta | 10:04 |
bauzas | fwiw, I want to look at runways | 10:04 |
*** derekh has joined #openstack-nova | 10:17 | |
*** yaawang_ has joined #openstack-nova | 10:17 | |
*** rpittau is now known as rpittau|bbl | 10:18 | |
*** hamalq has joined #openstack-nova | 10:20 | |
*** ttsiouts has quit IRC | 10:22 | |
*** ttsiouts has joined #openstack-nova | 10:23 | |
*** hamalq has quit IRC | 10:25 | |
*** ttsiouts has quit IRC | 10:27 | |
*** sean-k-mooney has joined #openstack-nova | 10:30 | |
*** psachin has quit IRC | 10:31 | |
*** hamalq has joined #openstack-nova | 10:37 | |
*** hamalq has quit IRC | 10:42 | |
brinzhang0 | stephenfin: hi, we encounter an issue, and I register a blueprint, can you review it? https://blueprints.launchpad.net/oslo.cache/+spec/enable-sasl-protocol | 10:47 |
brinzhang0 | stephenfin: thanks | 10:48 |
*** mkrai has quit IRC | 10:51 | |
*** mkrai_ has joined #openstack-nova | 10:51 | |
*** derekh has quit IRC | 11:00 | |
*** derekh has joined #openstack-nova | 11:00 | |
*** purplerbot has joined #openstack-nova | 11:00 | |
*** ttsiouts has joined #openstack-nova | 11:02 | |
*** psachin has joined #openstack-nova | 11:03 | |
*** tbachman has quit IRC | 11:05 | |
*** tbachman has joined #openstack-nova | 11:07 | |
*** ttsiouts has quit IRC | 11:08 | |
*** mkrai_ has quit IRC | 11:10 | |
*** ociuhandu has joined #openstack-nova | 11:12 | |
*** jangutter_ is now known as jangutter | 11:13 | |
*** artom has joined #openstack-nova | 11:20 | |
*** ttsiouts has joined #openstack-nova | 11:25 | |
*** ttsiouts has quit IRC | 11:26 | |
*** ttsiouts has joined #openstack-nova | 11:26 | |
*** martinkennelly has quit IRC | 11:35 | |
*** martinkennelly has joined #openstack-nova | 11:35 | |
*** mkrai_ has joined #openstack-nova | 11:42 | |
*** tetsuro_ has joined #openstack-nova | 11:42 | |
*** raildo has joined #openstack-nova | 11:44 | |
*** tetsuro has quit IRC | 11:46 | |
*** tetsuro_ has quit IRC | 11:51 | |
*** tosky has quit IRC | 11:56 | |
*** tetsuro has joined #openstack-nova | 11:57 | |
openstackgerrit | Alexandre Arents proposed openstack/nova master: Snapshot: offload glance upload in a native thread https://review.opendev.org/734776 | 11:57 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Extend is_ipv6_supported() to cover more error cases https://review.opendev.org/736167 | 11:57 |
*** psachin has quit IRC | 11:58 | |
*** boxiang_ has joined #openstack-nova | 11:58 | |
*** tosky has joined #openstack-nova | 11:59 | |
*** martinkennelly has quit IRC | 11:59 | |
*** psachin has joined #openstack-nova | 12:00 | |
*** martinkennelly has joined #openstack-nova | 12:00 | |
*** boxiang has quit IRC | 12:02 | |
openstackgerrit | Alexandre Arents proposed openstack/nova master: Limit the number of concurrent snapshots https://review.opendev.org/736169 | 12:02 |
*** rpittau|bbl is now known as rpittau | 12:06 | |
*** ratailor has quit IRC | 12:11 | |
*** ttsiouts has quit IRC | 12:16 | |
*** ttsiouts has joined #openstack-nova | 12:16 | |
openstackgerrit | Sean McGinnis proposed openstack/nova master: Use unittest.mock instead of third party mock https://review.opendev.org/714676 | 12:17 |
*** ttsiouts has quit IRC | 12:21 | |
*** martinkennelly has quit IRC | 12:24 | |
*** ttsiouts has joined #openstack-nova | 12:25 | |
openstackgerrit | Sean McGinnis proposed openstack/nova master: hacking: force explicit import of python's mock https://review.opendev.org/708768 | 12:27 |
*** martinkennelly has joined #openstack-nova | 12:28 | |
*** jmlowe has quit IRC | 12:29 | |
*** jmlowe has joined #openstack-nova | 12:31 | |
*** mkrai_ has quit IRC | 12:31 | |
*** spatel has joined #openstack-nova | 12:31 | |
*** jangutter_ has joined #openstack-nova | 12:33 | |
*** spatel has quit IRC | 12:36 | |
*** jangutter has quit IRC | 12:36 | |
*** lbragstad has joined #openstack-nova | 12:39 | |
openstackgerrit | Merged openstack/nova master: libvirt: Don't allow "reserving" file-backed memory https://review.opendev.org/734658 | 12:41 |
*** nweinber has joined #openstack-nova | 12:41 | |
*** slaweq_ has joined #openstack-nova | 12:48 | |
*** slaweq has quit IRC | 12:48 | |
*** mtreinish has joined #openstack-nova | 12:50 | |
*** martinkennelly has quit IRC | 12:58 | |
*** martinkennelly has joined #openstack-nova | 12:58 | |
*** lvdombrkr has joined #openstack-nova | 12:58 | |
openstackgerrit | Alexandre Arents proposed openstack/nova master: Limit the number of concurrent snapshots https://review.opendev.org/736169 | 13:00 |
*** martinkennelly has quit IRC | 13:01 | |
*** alex_xu has joined #openstack-nova | 13:01 | |
*** slaweq_ is now known as slaweq | 13:03 | |
openstackgerrit | Alexandre Arents proposed openstack/nova master: Snapshot: offload glance upload in a native thread https://review.opendev.org/734776 | 13:04 |
*** tetsuro has quit IRC | 13:15 | |
*** ttsiouts has quit IRC | 13:18 | |
*** ttsiouts has joined #openstack-nova | 13:19 | |
*** ttsiouts has quit IRC | 13:19 | |
*** ttsiouts has joined #openstack-nova | 13:19 | |
*** udesale_ has joined #openstack-nova | 13:26 | |
*** JamesBenson has quit IRC | 13:27 | |
*** udesale has quit IRC | 13:28 | |
openstackgerrit | Stephen Finucane proposed openstack/nova stable/ussuri: libvirt: Don't allow "reserving" file-backed memory https://review.opendev.org/736219 | 13:37 |
*** rpittau is now known as rpittau|brb | 13:39 | |
*** priteau has quit IRC | 13:40 | |
*** CeeMac has joined #openstack-nova | 13:44 | |
*** kberger_ has joined #openstack-nova | 13:45 | |
*** kberger_ has quit IRC | 13:46 | |
*** kberger_ has joined #openstack-nova | 13:46 | |
*** KeithMnemonic has quit IRC | 13:49 | |
*** Liang__ has joined #openstack-nova | 13:52 | |
*** Liang__ is now known as LiangFang | 13:53 | |
*** rpittau|brb is now known as rpittau | 13:53 | |
*** lpetrut has joined #openstack-nova | 13:56 | |
*** priteau has joined #openstack-nova | 13:56 | |
*** LiangFang has quit IRC | 13:57 | |
*** mkrai has joined #openstack-nova | 13:59 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Extend is_ipv6_supported() to cover more error cases https://review.opendev.org/736167 | 14:02 |
*** martinkennelly has joined #openstack-nova | 14:03 | |
*** jangutter_ is now known as jangutter | 14:04 | |
*** liuyulong has joined #openstack-nova | 14:07 | |
*** rchurch has quit IRC | 14:14 | |
*** rchurch has joined #openstack-nova | 14:16 | |
*** ttsiouts has quit IRC | 14:16 | |
*** ttsiouts has joined #openstack-nova | 14:17 | |
*** ttsiouts has quit IRC | 14:21 | |
*** ttsiouts has joined #openstack-nova | 14:22 | |
TheJulia | Greetings nova folks, would nova be generally amenable if the ironic virt driver had a capability for a user of reserving a physical baremetal machine but not actually triggering the deployment. We're thinking this would basically be a trait, and we could teach ironic to just ignore the deploy if the trait is present, but we woudl also likely update permissions so the user is "leased" the physical node. | 14:24 |
dansmith | TheJulia: you mean exclude machines with that trait set from the scheduling decision right? | 14:25 |
TheJulia | well, mark it in use/active in nova | 14:25 |
TheJulia | and tell ironic "hey, this user asked for and is now allocated this hardware" and then the user can pivot APIs to perform super advanced operations | 14:26 |
dansmith | meaning nova just "reserves" the node in ironic but does nothing with it, assuming the user is going to do stuff with it out of band? | 14:26 |
TheJulia | no, more like we just skip the final step telling ironic to perform the deployment | 14:26 |
dansmith | how is that different? | 14:27 |
TheJulia | today we actually trigger a deployment which means the machine is delivered in an active state | 14:27 |
dansmith | I mean how is what you said not what I said? | 14:28 |
sean-k-mooney | TheJulia: this sound more like a blazar usecase | 14:28 |
dansmith | if nova reserves the node (i.e. in placement) but just doesn't ask ironic to do anything with it, that's what you're asking right? | 14:28 |
* TheJulia sighs | 14:28 | |
dansmith | sean-k-mooney: agreed | 14:28 |
sean-k-mooney | that said we have a trait for marking a compute node as down today | 14:28 |
sean-k-mooney | if it was a maintaince usecase then that woudl be approporte to use | 14:28 |
sean-k-mooney | we dont really have a reservation concept in nova however | 14:29 |
sean-k-mooney | not sure how we would cleanly add one | 14:29 |
dansmith | sean-k-mooney: I think TheJulia is asking for the opposite of that, for nova to do everything we would normally do to boot on a node, but just ... not boot on the node | 14:29 |
dansmith | sean-k-mooney: which is basically making nova a reserve-but-don't-touch service, which wouldn't be sensical for anything other than resources that already exist (i.e. physical machines) | 14:29 |
sean-k-mooney | dansmith: right so still run through the schduler and select the node | 14:29 |
TheJulia | Lets just drop this because this discussion is just going to not be productive | 14:29 |
sean-k-mooney | we had a concept of allowing boot to put instancve into states other then active. e.g. the boot to shelved usecase | 14:30 |
*** boxiang has joined #openstack-nova | 14:30 | |
sean-k-mooney | would something like that make sense | 14:30 |
sean-k-mooney | TheJulia: ^ im just not sure what state you would want the instance to be in Nova | 14:31 |
TheJulia | sean-k-mooney: possibly, I'll pass along the idea | 14:31 |
dansmith | sean-k-mooney: you mean "we discussed that thing once upon a time" :) | 14:31 |
TheJulia | sean-k-mooney: ideally active to nova's perception | 14:31 |
sean-k-mooney | dansmith: yes | 14:31 |
dansmith | sean-k-mooney: I think the goal here is to use nova's scheduler but not the nova-compute part, which would kinda be akin to "we provision empty VMs on the hypervisor and then you do what you want with them, | 14:32 |
sean-k-mooney | TheJulia: so rather then a trait if i was to propose something like this i would proably use an extra spec | 14:32 |
dansmith | which goes against the whole "don't manage our VMs out of band" goal | 14:32 |
sean-k-mooney | dansmith: right it would conflict with that | 14:32 |
dansmith | and it would make alllll the other operations you can do on an instance have to be disabled somehow | 14:32 |
*** boxiang_ has quit IRC | 14:32 | |
*** mriedem has joined #openstack-nova | 14:32 | |
sean-k-mooney | we did have some driver that wanted to prespawn some vms and reallocate one on a boot request in the past right | 14:33 |
dansmith | like, what does it mean for you to do a reboot or rebuild or anything else on an instance in that case | 14:33 |
dansmith | I dunno about that | 14:33 |
sean-k-mooney | TheJulia: do they just not want to do the provisioning e.g. would boot without and image be an alternitive | 14:33 |
*** mlavalle has joined #openstack-nova | 14:34 | |
*** psachin has quit IRC | 14:34 | |
sean-k-mooney | TheJulia: actully ignoring the schduling bit is there a reason they cant just deploy using ironics api | 14:35 |
sean-k-mooney | presumable ironic could claim the resouces in placment when you go to ironic directly so that nova/placement would know the host is in use | 14:37 |
*** links has quit IRC | 14:37 | |
*** dklyle has joined #openstack-nova | 14:44 | |
TheJulia | sean-k-mooney: trying to focus on the discussion call I'm on right now, I'll answer afterwards | 14:50 |
sean-k-mooney | TheJulia: no worries im watching an internal call too | 14:51 |
*** ttsiouts has quit IRC | 15:01 | |
*** boxiang has quit IRC | 15:01 | |
*** ttsiouts has joined #openstack-nova | 15:01 | |
*** boxiang has joined #openstack-nova | 15:02 | |
*** ratailor has joined #openstack-nova | 15:05 | |
*** ttsiouts has quit IRC | 15:06 | |
*** ttsiouts has joined #openstack-nova | 15:17 | |
*** hamalq has joined #openstack-nova | 15:17 | |
melwitt | gmann: have you seen this gate bug before? "ls: cannot access 'uwsgi*': No such file or directory" https://zuul.opendev.org/t/openstack/build/5c1bfbb79c314b11b518a8af51441a00/log/logs/grenade.sh.txt#5354 | 15:18 |
gmann | melwitt: yeah that is ongoing fixes in devstack, and we have merged all the stable branch fix now | 15:18 |
*** hamalq_ has joined #openstack-nova | 15:19 | |
dansmith | since monday I think | 15:20 |
melwitt | gmann: ah thanks, I missed that | 15:20 |
melwitt | I had a thing on stable (stein) fail zuul overnight | 15:20 |
gmann | yeah, | 15:21 |
melwitt | so I was wonderin | 15:21 |
gmann | but grenade multinode job is still issue, fixing in ussuri by backporting running zuulv3 native - https://review.opendev.org/#/c/735948/1 | 15:21 |
gmann | train and stein might need to make it n-v till we backport the grenade zuulv3 till stein. that is we are discussing in qa channel | 15:22 |
*** hamalq has quit IRC | 15:23 | |
melwitt | ok I'm seeing neutron-grenade-multinode and nova-grenade-live-migration and grenade-py3 failing on stein | 15:25 |
melwitt | and then nova-live-migration is failing with "/opt/stack/new/devstack/lib/infra: line 32: virtualenv: command not found" on stein https://zuul.opendev.org/t/openstack/build/509288c2a75a49609c2f7f4b2e158a60/log/logs/devstack-subnodes-early.txt#2948 | 15:28 |
gmann | melwitt: yeah, that need devstack-gate fix which is not preferred so i am trying to backport the grenade zuulv3 till train. | 15:33 |
*** ttsiouts has quit IRC | 15:33 | |
*** ttsiouts has joined #openstack-nova | 15:33 | |
*** ttsiouts has quit IRC | 15:38 | |
melwitt | gmann: ok, thanks. devstack-gate is branchless I assume? | 15:45 |
gmann | melwitt: yeah. | 15:45 |
melwitt | gmann: thanks. have you heard of the other failure before "/opt/stack/new/devstack/lib/infra: line 32: virtualenv: command not found"? for nova-live-migration | 15:49 |
*** martinkennelly has quit IRC | 15:51 | |
*** udesale_ has quit IRC | 15:53 | |
gibi | melwitt: could this be due to http://lists.openstack.org/pipermail/openstack-discuss/2020-June/015425.html ? | 15:54 |
melwitt | gibi: oh maybe, thanks. I missed that, was looking for "gate" in ML | 15:55 |
gmann | melwitt: that is same issue grenade multinode job facing | 15:55 |
gmann | and need fix in devstack-gate | 15:55 |
melwitt | oh, the error message was different so I didn't realize it was related | 15:56 |
*** gyee has joined #openstack-nova | 15:58 | |
*** ratailor has quit IRC | 16:04 | |
TheJulia | dansmith: the goal is more, have the nova-compute driver ask ironic to hold the node, set appropriate values to represent the user has possesion of it and allow the user to do the needful. | 16:11 |
TheJulia | sean-k-mooney: the conundrum is the users expect to use nova, and currently get resources via nova today, and what they are doing is basically going and making internal invasive chagnes inside the deployed instance to re-install the instance using a kickstart | 16:11 |
dansmith | TheJulia: yeah that's the same as what I said, just with nova-compute being slightly involved in the enablement of the out-of-band activities | 16:11 |
*** dtantsur is now known as dtantsur|afk | 16:12 | |
TheJulia | Well, it may be logical to enable setting the "leasee" field in ironic's api anyway | 16:12 |
TheJulia | which would allow operators to optionally grant direct api rights | 16:12 |
TheJulia | I guess there could always be a trait that populates itself that just signals "don't actually deploy this machine, just allocate it" | 16:13 |
dansmith | that's akin to nova setting up a libvirt VM and then tolerating the user or admin mucking with the underlying VM XML | 16:13 |
TheJulia | and we could do that under the hood in ironic fairly easily. | 16:13 |
dansmith | which today we declare as "not okay" | 16:13 |
*** dlbewley has joined #openstack-nova | 16:14 | |
TheJulia | Well, we should still eventually store who asked for the thing and if we have community consensus behind a "delayed deployment" trigger, then that is totally up to the operators and their running policy to decide if they want to permit or not to meet their use cases | 16:15 |
sean-k-mooney | dansmith: for what its worth we had someone asking about pxe booting nova instance a few weeks ago | 16:17 |
*** rpittau is now known as rpittau|afk | 16:17 | |
*** nweinber has quit IRC | 16:18 | |
sean-k-mooney | they were confused by the fact that if you enable the qemu boot menu via the image porperty you can select pxeboot as an option in the boot menu via the console | 16:18 |
*** mkrai has quit IRC | 16:18 | |
*** nweinber has joined #openstack-nova | 16:18 | |
sean-k-mooney | but could not figure out how to configure it which makes sense since we dont support you pxe booting the vms booted by nova | 16:18 |
dansmith | sean-k-mooney: you mean asking again | 16:18 |
sean-k-mooney | it came up on irc like a month ago i assuem it has come up before | 16:19 |
dansmith | many times | 16:19 |
dansmith | I dunno if there would be any ironic parallels here, but changing the image from inside the guest means that anything we do after that based on the image metadata will be wrong | 16:19 |
sean-k-mooney | i basically just said thats not supported sorry, it just a leaky abstraction | 16:20 |
dansmith | like attaching a device and using the correct device model, or migrating somewhere that looks at image metadata for OS properties, etc | 16:20 |
*** dlbewley has quit IRC | 16:20 | |
sean-k-mooney | dansmith: well so i have heard of people upgradeing form like 16.04 to 18.04 | 16:20 |
sean-k-mooney | but then you get into the pets vs cattle debate | 16:20 |
dansmith | which is wholly uncloudy, but is a lot less bad than going from 16.04 to Windows 10 | 16:20 |
dansmith | yup | 16:20 |
*** dlbewley has joined #openstack-nova | 16:21 | |
sean-k-mooney | ya updating the same disto is not really a problem different openrating systemsn entierely like linux to windows or esxi is a tolltal differnt matter | 16:21 |
sean-k-mooney | TheJulia: honestly it sound like they should update there kickstart playbook to delegate the os imagiang and provisioning to openstack/ironic and then just deal with boot straping the deployed hosts | 16:25 |
TheJulia | the case that is coming up at CERN is apparently they are deploying nodes with configurations that are impossible to articulate in images, so they are making the necessary major changes to get to their required end state after the fact | 16:26 |
sean-k-mooney | TheJulia: sure that makes sense but i dont know wny they would not just orcestrat the software payload via ansible and have a seperate role to deploy the orginal server | 16:27 |
sean-k-mooney | TheJulia: kind of like kaobe | 16:27 |
TheJulia | Really, ideally they should jsut be talking with ironic in some of these cases, but I guess they are trying to force their users into cloudy mindsets/patterns/behaviors | 16:27 |
dansmith | yup | 16:28 |
TheJulia | It is a mixed vm/baremetal environment, fwiw | 16:28 |
dansmith | what are the "node configurations that are impossible to articulate in images" ? | 16:29 |
TheJulia | And high level consistency seems to be the key they need, it is almost like power users just need that extra next step | 16:29 |
sean-k-mooney | ya that is not really an issue johnthetubaguy could proably tell you more about how they orcestrate the deployment of the Square Kilometer Array (SKA) | 16:29 |
TheJulia | multi-disk/raid/lvm/etc | 16:29 |
TheJulia | dansmith: this came out of the whole disk partitioning discussion getting resurrected | 16:29 |
dansmith | ack, well, addressing that makes more sense to me than just saying "short-circuit the bottom half of nova because it's easier" | 16:30 |
*** dlbewley has quit IRC | 16:30 | |
*** dlbewley has joined #openstack-nova | 16:30 | |
TheJulia | except, then get into the whole pets/cattle argument again and everyone tableflips and walks away | 16:30 |
sean-k-mooney | cern have a blog post on that but it seam sto be down the stack hpc one is up however https://www.stackhpc.com/software-raid-in-ironic.html | 16:31 |
dansmith | that's not a convincing argument to do the short-circuit :) | 16:31 |
TheJulia | dansmith: it is a solid reason people have downstream patches and are why they are not upgrading though, because their business processes need something along those lines. Anyway, if we enable them to short circuit in ironci, I think that is fine. Nova will believe it is happy. they can do whatever special config assertion as long as we populate leasee which we should be doing anyway. | 16:32 |
sean-k-mooney | TheJulia: there are ways to do per instance raid config today howere right | 16:33 |
TheJulia | which _should_ make the world a happier place. Dogs and cats could get married and all | 16:34 |
dansmith | whatever, it's just avoiding an abstraction because it's hard | 16:34 |
TheJulia | sean-k-mooney: it is not just raid sadly, the convergence seemed to be that there are teams with whole kickstart configs and to try and articulate that with traits will just make flavor/trait explosion even worse. | 16:34 |
dansmith | even though our only purpose in life is to be an abstraction | 16:35 |
TheJulia | in a perfect end state, I'd prefer them to get everything in glance and then tie it all together on an image basis, but smaller building blocks | 16:37 |
sean-k-mooney | TheJulia: well im not sure i agree that this should all live in glance or in the flavor | 16:37 |
sean-k-mooney | some of it should be user-data | 16:37 |
dansmith | it's not a smaller building block, it's a hammer to break the existing blocks | 16:38 |
dansmith | it doesn't build us toward a solution, it's an exit plan | 16:38 |
dansmith | instead of ever building new blocks, it's a forever solution of "get it to 40% complete and then do the rest custom out of band" | 16:38 |
*** ociuhandu_ has joined #openstack-nova | 16:38 | |
sean-k-mooney | TheJulia: it sound like a way to pass info on a per instance basis to the ironic python agent would partly solve there issue. e.g. if the agent had a defien api of actions such as bios and raid config that could be pass on a per instance basis it would help with the image/flavor explosion issue | 16:39 |
TheJulia | woudl it help to have a larger discussion regarding this again, because where this always stalled out was the "how do we end up having something that nova will agree to" in the past in terms of data. and I think the last agreement of a possible solution involved templates stored in glance associated via traits or something which I think made it complex and cumbersome to interact with | 16:39 |
sean-k-mooney | the problem is that that for that to make sense it has to be somewhat abstract as we will not know the precise host ahead of time by design | 16:40 |
*** dlbewley has quit IRC | 16:40 | |
dansmith | we did have a long conversation about this in dublin, | 16:40 |
*** dlbewley has joined #openstack-nova | 16:40 | |
TheJulia | sean-k-mooney: we're actually have it, just turns out people want to do even more complex things their own way | 16:41 |
*** lvdombrkr has quit IRC | 16:41 | |
dansmith | which involved nova just knowing about a hardware template that gets passed to ironic to define these things | 16:41 |
dansmith | there was no tableflipping | 16:41 |
sean-k-mooney | dansmith: to do that we would want to do it in a way that did not invovle specifying the template in the flavor or image right | 16:41 |
TheJulia | maybe I was thinking of the time before | 16:41 |
sean-k-mooney | such as a swift url or glance artifcact uuid in server metadata or something else instance based | 16:42 |
dansmith | sean-k-mooney: I dunno, in the image seems fine to me | 16:42 |
sean-k-mooney | dansmith: in the image would work only to a point | 16:42 |
*** ociuhandu has quit IRC | 16:42 | |
openstackgerrit | Alexandre Arents proposed openstack/nova stable/stein: Add admin doc information about image cache resource accounting https://review.opendev.org/732542 | 16:42 |
sean-k-mooney | if you assume the raid config is an atribute of that image then sure | 16:43 |
*** ociuhandu_ has quit IRC | 16:43 | |
sean-k-mooney | but if the workload in that image has different performace configurtion it can be deployed in for different slas then you need multiple images | 16:43 |
dansmith | sean-k-mooney: how the user gets to select it (if at all) is really a smaller concern than all the components supporting that thing regardless of how it's presented | 16:43 |
sean-k-mooney | true | 16:44 |
TheJulia | I suspect your thinking that fitting the needs is a conundrum, but in these sorts of cases, the user knows exactly what the hardware is because they have a special flavor to use to match it | 16:44 |
dansmith | I tend to think that flavors and images are our templating mechanism and optimizing for a one-off deployment of one thing with weird config is not the direction we should go | 16:45 |
dansmith | TheJulia: right, which is why I think that in the flavor is reasonable in a lot of cases | 16:45 |
dansmith | they're already selecting an ironic machine class via flavor anyway | 16:46 |
TheJulia | From the flip side of that, another operator on the call we had today basically stressed that if they ahd to do that their flavors would explode even more and I think they already have tens of thousands | 16:46 |
sean-k-mooney | other then the fact openstack flavor list will be ... difficut to use did they have a partical problem with that | 16:47 |
TheJulia | (approximately 350,000 physical machines in their fleet is what they say) | 16:47 |
*** ociuhandu has joined #openstack-nova | 16:47 | |
dansmith | I suspect that means they're doing it wrong, but regardless, if you literally have thousands of bespoke configurations, you're going to end up with thousands of incompatible objects somewhere in the system | 16:47 |
sean-k-mooney | TheJulia: but presumable that is grouped into a manageable set of SKUs | 16:47 |
dansmith | sean-k-mooney: that's why I said I expect they're doing it wrong.. they obviously have less than 350k unique configurations of machines, they probably just want to think of each machine as a snowflake | 16:48 |
sean-k-mooney | TheJulia: do you know how many unique ironic resouce classes they have | 16:48 |
TheJulia | sean-k-mooney: I'll ask, I don't know off the top of my head | 16:49 |
sean-k-mooney | dansmith: right they should have 1 flavor per ironic resouce class + there vm flavors | 16:49 |
dansmith | right, and not an ironic resource class for every unique serial number :) | 16:50 |
*** dlbewley has quit IRC | 16:50 | |
TheJulia | that is not how anyone is implementing it because they are also needing to access control on the back end who has the ability to access specific resource classes | 16:50 |
sean-k-mooney | TheJulia: well that is where they are doing it wrong | 16:50 |
sean-k-mooney | nova has ways to do access contol on flaovr or via aggreates based on tenatns | 16:50 |
*** dlbewley has joined #openstack-nova | 16:51 | |
TheJulia | arne_wiebalck: ^^^ fyi, you might find this interesting or super frustrating | 16:51 |
sean-k-mooney | nova has the idea of private flavors so you can create 1 flaovr an choose what tenats can see it | 16:51 |
*** ociuhandu has quit IRC | 16:51 | |
TheJulia | asked the super large operator, I think cern is operating with something like like ~130-140 distinct SKUs across their fleet, some of it is private skus for hyper specific needs/purposes, others are general from what I understand. I believe they've mentioned some crazy number of flavors as well. | 16:52 |
TheJulia | ugh, apparently the super large operator has lots of downstream patches wrapped around flavors/classes, so their huge numbers are not exactly valid for this discussion since we don't understand the entire story/composition there. | 16:53 |
sean-k-mooney | i can see them doing thing like adding a customer specific resouce class so they can dedicate specifc pools to them | 16:54 |
sean-k-mooney | but that is not how its ment to be done | 16:54 |
TheJulia | sean-k-mooney: I _think_ cern has mentioned them doing private flavors before, but that it adds up for admins to dump the list out | 16:55 |
mnaser | fwiw openstack cli shows public flavors only by default, even for admins | 16:55 |
mnaser | you have to explicitly give it --private to get those | 16:55 |
*** liuyulong has quit IRC | 16:56 | |
dansmith | sean-k-mooney: exactly | 16:56 |
sean-k-mooney | well it can but when you create private flavor you dont create the same flavor multiple times for different tenatnts. you create it once and add the teant 1:1 to the existing flavor | 16:56 |
*** jsuchome has quit IRC | 16:56 | |
*** maciejjozefczyk has quit IRC | 16:56 | |
*** maciejjozefczyk has joined #openstack-nova | 16:57 | |
sean-k-mooney | mnaser: that is true today but i actully want to change how that work. i want ti to be private if you add a tenat too the flavor acess list and public if not | 16:57 |
dansmith | and again, if you want thousands of different configs, you'll either end up with thousands of flavors, or thousands of instances with whatever bespoke thing you've asked for, it will just be far less discoverable | 16:57 |
sean-k-mooney | mnaser: at the moemnt you cant change the private public status and that causes pain | 16:57 |
dansmith | so people having "all the same flavor" which have been individually hand-managed to be different is just going to end up with that madness being hidden | 16:57 |
mnaser | sean-k-mooney: yeah the move private => public is a bit harsh but im not sure why/how/when it's been the case. i would have never touched the db and manually changed that field before. ever. | 16:58 |
dansmith | which is kinda the point of what we're doing here -- trying to manage N things as a unit, where N is too large for any human to do manually | 16:58 |
mnaser | also, i agree about the comments wrt instance type shouldn't mean different things, it sucks to manage it at scale, but, there's tons of ways you can (relatively easily) automate something like this | 16:59 |
mnaser | say, this ansible | 16:59 |
sean-k-mooney | mnaser: its useful to go from public to private too for decomisioning old flavors | 16:59 |
mnaser | sean-k-mooney: yes, that's true too. i'm sure someone out there knows the real reason behind it | 16:59 |
mnaser | i have risked moving private to public, but not public to private as that seemed a little more intense in terms of the things that can break | 16:59 |
*** dlbewley has quit IRC | 17:00 | |
sean-k-mooney | mnaser: yep i discussed this with gmann a while back and its on the list of things to "clean up" in a future microverions but we have not put up a blueprint for it yet | 17:00 |
*** dlbewley has joined #openstack-nova | 17:01 | |
*** derekh has quit IRC | 17:01 | |
sean-k-mooney | mnaser: when private flavors where added the ability to move between them was just never adressed so in that regard its a half implemnted feature | 17:01 |
sean-k-mooney | but its one i think we can improve. | 17:01 |
sean-k-mooney | dansmith: i guess the problem is that right now they are managing the N things with kickstart | 17:02 |
*** lpetrut has quit IRC | 17:02 | |
sean-k-mooney | and not tacking advantage of the abstractions provided by openstack | 17:03 |
dansmith | sean-k-mooney: I thought the tenants were doing that, but yeah | 17:03 |
TheJulia | sean-k-mooney: no, they are only using kickstart files to rebuild machines | 17:04 |
TheJulia | because they simply need a way more complex running configuration | 17:04 |
sean-k-mooney | TheJulia: right but if openstack coudl provide that config would they use it or whould they keep doing it the way they are now so that they can support non openstack envs | 17:05 |
sean-k-mooney | by the way i do not use ironic that often so im not sure what capablity you can use via ironic direct vs ironic via nova but even though ironic direct can leverage ironic to do raid and bios config today they are not using it | 17:07 |
TheJulia | sean-k-mooney: in a perfect world, they would want to be able to re-use the same config or formatting instead of having to go through a bunch of additional steps or abstractions to just get the job done for the day. The point here is they want everything through openstack because of the single pane of glass benefit. | 17:07 |
sean-k-mooney | TheJulia: right which is why im confused that they would reimage the machine since that is the opisiste of doing everythin vis openstack | 17:08 |
dansmith | sean-k-mooney: they want to put a break statement anywhere they want in the workflow to use as much or little openstack as they want | 17:09 |
TheJulia | sean-k-mooney: because the constraints in which openstack puts them with are insufficent to meet their needs of their business for their 10, 100, 1000 machines they may ask for on a given day | 17:09 |
gmann | mnaser: sean-k-mooney: on flavor things, its in list to cleanup - item 10 in https://etherpad.opendev.org/p/nova-api-cleanup | 17:10 |
gmann | which is basically get rid of is_public thing and every flavor is private and accessible to allowed tenants only | 17:10 |
sean-k-mooney | gmann: yep i knew you added it to the list but i did not have it bookmarked | 17:11 |
sean-k-mooney | gmann: that is not what i had in mind | 17:11 |
gmann | and that bug adding public flavor things is since liberty - https://bugs.launchpad.net/nova/+bug/1361476 | 17:12 |
openstack | Launchpad bug 1361476 in OpenStack Compute (nova) "flavor access create should check public/private first" [Low,Fix released] - Assigned to Sergey Nikitin (snikitin) | 17:12 |
sean-k-mooney | gmann: i was thinking every flavor would be public unless you addd a tenatn via flavor access in which case it would only be visable to those that were in the list | 17:12 |
gmann | i sex, what is is_public default? | 17:12 |
gmann | sec | 17:12 |
sean-k-mooney | it defaults to public/true | 17:13 |
sean-k-mooney | so i wanted to keep that behavior | 17:13 |
sean-k-mooney | but instead of seting it to public or private explictly base it on the flavor acess info | 17:13 |
gmann | yeah https://github.com/openstack/nova/blob/6ed556f4adfd8a98fae2e91204f1ce0484f5dd9d/nova/api/openstack/compute/flavor_manage.py#L69 | 17:14 |
sean-k-mooney | e.g. is_public = "select count(*) form flavor_access where flavor_id = $whatever" == 0 | 17:14 |
gmann | right, keeping the same behavior but allowing it to add tenant access and so does list | 17:15 |
openstackgerrit | Sean McGinnis proposed openstack/nova master: Use unittest.mock instead of third party mock https://review.opendev.org/714676 | 17:15 |
sean-k-mooney | right so you start with a public flaovr. then if you add a tenant to the acess list it "private" and only that tenatn and an admin can see it | 17:16 |
sean-k-mooney | if you remove them it avaiable to all again | 17:16 |
*** spatel has joined #openstack-nova | 17:16 | |
sean-k-mooney | nova flavor-access-list --flavor <my public flavor> should have eitehr retruned None | 17:17 |
sean-k-mooney | so the "fix" to https://bugs.launchpad.net/nova/+bug/1361476 in my view was incorrect | 17:17 |
openstack | Launchpad bug 1361476 in OpenStack Compute (nova) "flavor access create should check public/private first" [Low,Fix released] - Assigned to Sergey Nikitin (snikitin) | 17:17 |
sean-k-mooney | but it was also done in liberty so its not really important right now | 17:18 |
*** JamesBenson has joined #openstack-nova | 17:18 | |
gmann | yeah, its been long it is like that | 17:18 |
sean-k-mooney | and since we use or dont use microverions with osc eveyone that use osc does not expect the new behavior | 17:19 |
sean-k-mooney | new beign "2.7" | 17:19 |
sean-k-mooney | they get the old behavior where its not an error | 17:19 |
sean-k-mooney | so you can add flavor access even today you jsut use the old microverion | 17:20 |
gmann | is it not max version behavior in osc? | 17:20 |
sean-k-mooney | no min | 17:20 |
gmann | by default | 17:20 |
*** kberger_ has quit IRC | 17:20 | |
sean-k-mooney | so by defcault everythin uses 2.1 | 17:20 |
gmann | i remember novaclient is default to min but not sure about osc | 17:20 |
sean-k-mooney | gmann: other way around novaclinet uses latest | 17:21 |
sean-k-mooney | osc uses min | 17:21 |
sean-k-mooney | so nova clients behavior change depending on the clinet version and api you are talking too | 17:21 |
gmann | ah yeah otherway around. | 17:21 |
sean-k-mooney | osc is consitent regardless of the verion or cloud | 17:21 |
*** JamesBenson has quit IRC | 17:21 | |
*** nightmare_unreal has quit IRC | 17:24 | |
*** KeithMnemonic has joined #openstack-nova | 17:25 | |
*** KeithMnemonic has quit IRC | 17:27 | |
*** jangutter has quit IRC | 17:37 | |
*** KeithMnemonic has joined #openstack-nova | 17:37 | |
*** KeithMnemonic has quit IRC | 17:43 | |
melwitt | sean-k-mooney: do you know of a way of changing a guest's video model other than virsh editing it? context is the cirrus-vga type got deprecated https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/8.2_release_notes/deprecated_functionality#deprecated-functionality_virtualization and can result in bad looking low res vnc console | 18:02 |
melwitt | it used to look fine prior to an upgrade to stein, then looked messed up. so I'm trying to determine how users could update their existing instances | 18:04 |
*** dlbewley has quit IRC | 18:04 | |
*** dlbewley has joined #openstack-nova | 18:05 | |
*** tesseract has quit IRC | 18:12 | |
sean-k-mooney | melwitt: yes you can use hw_video_model in the image metadata | 18:24 |
sean-k-mooney | melwitt: i always use virtio | 18:25 |
melwitt | sean-k-mooney: ok, how to get an already existing instance to pick that up without rebuilding it? | 18:25 |
sean-k-mooney | melwitt: db edit | 18:25 |
melwitt | ok, so db edit instead of a virsh edit.. and then hard reboot the instance? | 18:25 |
sean-k-mooney | add img_hw_video_memory=virtio in the system_metadata table | 18:26 |
sean-k-mooney | yep | 18:26 |
melwitt | ok. guh | 18:26 |
sean-k-mooney | img_hw_video_model=virtio not memory | 18:26 |
sean-k-mooney | melwitt: is this for a customer or you? | 18:27 |
melwitt | we're defaulting to the deprecaed 'cirrus' on master even, so I think that needs to change https://github.com/openstack/nova/blob/6ed556f4adfd8a98fae2e91204f1ce0484f5dd9d/nova/virt/libvirt/config.py#L1949 | 18:27 |
melwitt | customer | 18:27 |
sean-k-mooney | ah then rebuild | 18:27 |
sean-k-mooney | we also just added docs for this in OSP and no one metioned the deprecate or asked us to not sure that docs appies | 18:28 |
sean-k-mooney | that is for base rhel not the advance virt stream which we use in osp | 18:28 |
melwitt | sean-k-mooney: do you happen to know which value would be an appropriate default being that cirrus is deprecated? the choices in the aforementioned 8.2 release notes give choices of stdvga, virtio-vga, or qxl | 18:28 |
sean-k-mooney | the only one of those 3 that would work is qxl that doc is for using kvm directly | 18:29 |
sean-k-mooney | *libvirt not kvm | 18:29 |
melwitt | ah good to know | 18:29 |
melwitt | yeah, the customer is working around by setting hw_video_model=qxl but obvs that only works for new instances | 18:29 |
melwitt | *setting in image meta | 18:30 |
sean-k-mooney | what release is it | 18:30 |
sean-k-mooney | https://bugzilla.redhat.com/show_bug.cgi?id=1714508 | 18:30 |
openstack | bugzilla.redhat.com bug 1714508 in openstack-nova "[RFE] add support for virtio-gpu" [Low,Verified] - Assigned to smooney | 18:30 |
melwitt | sean-k-mooney: what were you saying earlier about we just added docs for this in OSP? can you point me to what you're talking about | 18:30 |
sean-k-mooney | that was traicking the virtio-gpu supprot added in train | 18:30 |
melwitt | sean-k-mooney: stein | 18:30 |
sean-k-mooney | ya so stein they should use qxl | 18:31 |
sean-k-mooney | melwitt: yep we just added docs an im looking for them now | 18:31 |
melwitt | sean-k-mooney: does this mean you don't think this is something we need to change upstream too for the default? I would have thought if the default is deprecated in qemu we should have a default that works for all distros? | 18:33 |
sean-k-mooney | virtio does not work for windows by default | 18:34 |
sean-k-mooney | but it is the default we shoudl use | 18:34 |
sean-k-mooney | qxl works for linux and windows guests | 18:34 |
melwitt | does that mean qxl doesn't work on windows? | 18:34 |
melwitt | ok. I was thinking maybe the default should be qxl | 18:35 |
sean-k-mooney | but while its the best of the non virto option im not sure we should default to it | 18:35 |
sean-k-mooney | qxl was developed to have a better gpu for spice | 18:35 |
melwitt | but defaulting to a deprecated thing? | 18:35 |
sean-k-mooney | it work with novnc too | 18:35 |
sean-k-mooney | melwitt: without recored the current gpu we could break people on upgrade | 18:35 |
sean-k-mooney | so if we want to chang eit we need to record the current value | 18:36 |
sean-k-mooney | were recordign the current value is just popluating that value in the system metadata table | 18:36 |
*** spatel has quit IRC | 18:37 | |
melwitt | guh, I don't know enough about this stuff to understand what needs to be done here. all I know is the cirrus default messes up novnc | 18:37 |
*** dlbewley has quit IRC | 18:37 | |
melwitt | on rhel 8.2 | 18:37 |
sean-k-mooney | melwitt: as of when because it used to work | 18:37 |
*** dlbewley has joined #openstack-nova | 18:37 | |
melwitt | it works, it's just greyscale and low res | 18:37 |
sean-k-mooney | ah so its a rhel 8.2 issue with what the qemu version we use or no vnc | 18:37 |
melwitt | yeah | 18:38 |
sean-k-mooney | that sound like a qemu bug | 18:38 |
sean-k-mooney | basically if we change the default and you upgrade then hard reboot | 18:38 |
sean-k-mooney | the gpu pci device would change | 18:38 |
sean-k-mooney | if you dont have the qxl driver then the console would not work right | 18:39 |
sean-k-mooney | qxl has a vga comapatible interface to the generic window vga driver will work with it an dit should work on linux out of the box | 18:39 |
melwitt | I see | 18:39 |
*** spatel has joined #openstack-nova | 18:39 | |
sean-k-mooney | melwitt: are we setting a default graphic model if you dont request one? | 18:44 |
sean-k-mooney | or are we currently leaving it to libvirt/qemu | 18:44 |
melwitt | yeah, the link I posted earlier https://github.com/openstack/nova/blob/6ed556f4adfd8a98fae2e91204f1ce0484f5dd9d/nova/virt/libvirt/config.py#L1949 we set cirrus | 18:45 |
*** hamalq_ has quit IRC | 18:50 | |
sean-k-mooney | melwitt: ya we proably should just remove that line | 18:50 |
melwitt | ok. I'll do some local tests to see what happens when I remove it | 18:51 |
sean-k-mooney | well we need to set it to none i guess and only populate the xml atribute if its set | 18:52 |
sean-k-mooney | we also have another place we defualt it i think | 18:52 |
*** hamalq has joined #openstack-nova | 18:53 | |
sean-k-mooney | we should not be defaulting it in that file in anycase | 18:53 |
melwitt | in driver.py we set it special based on things like virt_type or guest arch or spice | 18:53 |
sean-k-mooney | yep that is what im thinking of | 18:53 |
*** hamalq_ has joined #openstack-nova | 18:53 | |
melwitt | but in the customer's case it's cirrus because of what's in the default config.py | 18:53 |
sean-k-mooney | we should only be adding this if you have a vnc/spice console too | 18:54 |
melwitt | "this" meaning what, qxl? | 18:54 |
sean-k-mooney | the graphics device | 18:55 |
melwitt | oh that config section altogether you mean | 18:55 |
sean-k-mooney | ya if you use the serial console you should not have a graphics device | 18:55 |
melwitt | ah yeah, we are actually only doing it for certain consoles in driver.py | 18:56 |
sean-k-mooney | if you use novnc or spice then we auto add a graphic element to provide the frame buffer | 18:56 |
melwitt | I just didn't see that earlier | 18:56 |
melwitt | yeah we're only doing for novnc and spice | 18:56 |
sean-k-mooney | yep which is correct | 18:57 |
melwitt | that we add that xml section for the video device | 18:57 |
sean-k-mooney | well i guess we would do it for RDP | 18:57 |
sean-k-mooney | maybe? | 18:57 |
melwitt | I don't see rdp in here | 18:57 |
sean-k-mooney | oh RDP is only supported with hyperv | 18:57 |
*** hamalq has quit IRC | 18:57 | |
melwitt | yeah it's hyperv | 18:57 |
melwitt | ok, so sounds like everything is good except we shouldn't be setting a default and just let qemu/kvm handle it | 18:57 |
sean-k-mooney | https://github.com/openstack/nova/blob/6ed556f4adfd8a98fae2e91204f1ce0484f5dd9d/nova/virt/libvirt/driver.py#L5989-L5998 | 18:58 |
sean-k-mooney | melwitt: that would alow them to contol the default and or deprecation | 18:58 |
melwitt | make sense | 18:58 |
sean-k-mooney | but the downside is we loose contol over that | 18:58 |
sean-k-mooney | so our guest abi will alter with theres | 18:58 |
sean-k-mooney | that is ok i guess since you can use the image property if you care | 18:59 |
melwitt | and yeah that's the code I was looking and the helper function being called there | 18:59 |
sean-k-mooney | ya so this https://github.com/openstack/nova/blob/6ed556f4adfd8a98fae2e91204f1ce0484f5dd9d/nova/virt/libvirt/driver.py#L5351-L5367 is basically working around libvit/qemu not doing the right thing by default | 19:00 |
sean-k-mooney | well and the fact we set a default in the xml generation class | 19:01 |
sean-k-mooney | so if we remove that default | 19:01 |
sean-k-mooney | then we might not need all those specal cases | 19:02 |
melwitt | ok, well one step at a time I guess :P | 19:02 |
melwitt | I do some local tests to see what happens when I remove the default | 19:02 |
melwitt | *I'll | 19:02 |
sean-k-mooney | ok let me know an i can review. https://www.kraxel.org/blog/2019/09/display-devices-in-qemu/ is a review of some to the option and recomendations | 19:03 |
melwitt | thanks | 19:04 |
sean-k-mooney | i need to remove the gop device i added by mistake last cycle and add https://www.kraxel.org/blog/2019/09/display-devices-in-qemu/#bochs-display | 19:04 |
sean-k-mooney | apparently gop is only for the bhve hypervior but the libvirt doc did not mention that | 19:04 |
sean-k-mooney | bochs implements a uefi graphic output protocol (gop) device for kvm | 19:06 |
sean-k-mooney | so that is the one i should have added | 19:07 |
*** spatel has quit IRC | 19:08 | |
sean-k-mooney | melwitt: during the ptg we disucssed breifly the idea of a resize for something other then a flavor change | 19:10 |
sean-k-mooney | maybe this could be another usecause for that | 19:10 |
*** dlbewley has quit IRC | 19:10 | |
*** dlbewley has joined #openstack-nova | 19:11 | |
sean-k-mooney | i think this was in the context of changing machine_types where i was suggeign a new retype server action but perhaps something more generic that would update the embed flavor and image with the latest would make more sense | 19:12 |
sean-k-mooney | e.g. a recreate action but that preserved all ports, volume and disks | 19:12 |
melwitt | how was that suggestion received, I'm curious heh | 19:14 |
melwitt | like, I know lots of people would like to do that. in my case, I'm trying to recover from what I consider a bug, the default being set to a deprecated thing and glitching out the vnc console | 19:14 |
sean-k-mooney | reusing resize was dansmith idea i was thinking it shoudl be its onw server action. not sure if dansmith actully was in favor or just saying if it was to be done i would start there | 19:15 |
melwitt | ah, cool | 19:15 |
sean-k-mooney | melwitt: the main think would be that recreate would have to be a move operation like resize so we can validate the new requirement | 19:16 |
sean-k-mooney | since we cant assume the current host is valid anymore | 19:16 |
melwitt | yeah. well, we validate the new stuff on a rebuild too since a few releases ago | 19:16 |
sean-k-mooney | but i think it would fix a lot of the thing that hard reboot fix but which require the flaovr or image properties to be modified | 19:16 |
sean-k-mooney | melwitt: only if the image changes | 19:17 |
melwitt | yeah, it would make life a lot easier for a lot of people | 19:17 |
sean-k-mooney | yeah so i think it has merit but not sure where it sits in the priortiy queue | 19:17 |
melwitt | yeah, I'm just saying that we validate even during rebuild so I think it makes sense to validate on a recreate/resize if we're consuming new image props etc | 19:17 |
melwitt | we're already doing it | 19:18 |
melwitt | *doing similar | 19:18 |
sean-k-mooney | for me i think it would be a good way to opt into changing the machine type for example | 19:18 |
sean-k-mooney | anyway im going to go buy icecream and i guess other food before the stores start to close | 19:19 |
* sean-k-mooney does need to go grocery shopping but is craving ben and jerry's | 19:21 | |
*** dlbewley has quit IRC | 19:21 | |
*** dlbewley has joined #openstack-nova | 19:21 | |
*** ralonsoh has quit IRC | 19:22 | |
sean-k-mooney | hum not sure if good pr or pr blunder https://www.benjerry.ie/flavours/netflix-and-chillld-ice-cream | 19:22 |
melwitt | thanks for the video model chat o/ | 19:28 |
*** ttsiouts has joined #openstack-nova | 19:32 | |
mnaser | is there reasoning behind what has ended up being validated in the api layer and what doesn't get validated in the api layer? | 19:36 |
mnaser | i haven't replicated this yet (but in theory i can imagine it's possible): end user tried to create a vm where image size > disk size when doing bfv | 19:37 |
mnaser | and they don't really get much more of a helpful error (and their request gets refused too obviously) | 19:37 |
mnaser | but only after it fails, in what i assume nova-compute trying to ask cinder to create a disk that's impossible to create | 19:37 |
*** vishalmanchanda has quit IRC | 19:38 | |
*** spatel has joined #openstack-nova | 19:40 | |
*** dlbewley has quit IRC | 19:41 | |
*** dlbewley has joined #openstack-nova | 19:42 | |
*** ttsiouts has quit IRC | 19:42 | |
*** ttsiouts has joined #openstack-nova | 19:43 | |
*** ttsiouts has quit IRC | 19:47 | |
*** ociuhandu has joined #openstack-nova | 19:52 | |
melwitt | mnaser: generally we validate whatever we can in the api layer to fail fast and avoid the behavior you're describing (fail later on nova-compute). within reason though, as some checks would involve rpc call to the compute host and we avoid that to some degree | 19:53 |
melwitt | mnaser: I found this part where we validate the image_min_disk against the volume disk size, but that might be different than just the image size as in your example? https://github.com/openstack/nova/blob/master/nova/compute/api.py#L681 | 19:54 |
mnaser | melwitt: oh interesting, you're right, i wonder if this is a case where the user did not have min_disk specified.. | 19:56 |
mnaser | melwitt: oh but we don't do image_size > dest_size | 19:56 |
mnaser | unlike https://github.com/openstack/nova/blob/master/nova/compute/api.py#L693-L695 | 19:57 |
mnaser | so i _think_ the scenario is no min_disk but no checks on image_size / dst_size | 19:58 |
melwitt | right thats what I was saying I wonder if thats different | 19:58 |
melwitt | actually don't know why it's different but I'm not a bfv expert | 19:59 |
mnaser | melwitt: i think it is, min_size is taken from a glance property which is user-provided (unless a snapshot is taken) | 19:59 |
mnaser | so i assume user here uploaded an image without min_size | 19:59 |
melwitt | yeah I mean I don't know why we wouldn't do the same checks for the volume case | 20:01 |
melwitt | like is that intentional or an oversight | 20:01 |
mnaser | melwitt: yeah -- in my opinion its an oversight but indeed, maybe someone knows better :) | 20:02 |
mnaser | anyhow | 20:02 |
mnaser | ill have a patch up shortly | 20:03 |
*** CeeMac has quit IRC | 20:04 | |
mnaser | melwitt: i swear i saw you mention a while back a key to click before copying from github which gave you a commit hash'd url instead of master | 20:05 |
melwitt | it's 'y' | 20:05 |
mnaser | oh awesome, thanks | 20:09 |
mnaser | https://bugs.launchpad.net/nova/+bug/1883969 | 20:09 |
openstack | Launchpad bug 1883969 in OpenStack Compute (nova) "Nova doesn't fail at API layer when image_size > volume_size with BFV" [Undecided,New] | 20:09 |
* mnaser has a patch and doing unit tests | 20:10 | |
*** pas-ha_ has joined #openstack-nova | 20:11 | |
*** tobberydberg_ has joined #openstack-nova | 20:12 | |
*** tosky_ has joined #openstack-nova | 20:12 | |
melwitt | sweet mnaser++ | 20:13 |
*** tosky has quit IRC | 20:13 | |
*** tosky_ is now known as tosky | 20:13 | |
*** irclogbot_3 has quit IRC | 20:14 | |
openstackgerrit | Mohammed Naser proposed openstack/nova master: bfv: check if image_size > volume_size in API https://review.opendev.org/736370 | 20:14 |
mnaser | melwitt: ^ voila, the unit test i wrote passed locally but i didnt run the whole suite | 20:14 |
mnaser | it makes sense to me™ | 20:14 |
*** CeeMac has joined #openstack-nova | 20:15 | |
*** gyee has quit IRC | 20:17 | |
*** brinzhang0 has quit IRC | 20:18 | |
*** brinzhang0 has joined #openstack-nova | 20:18 | |
*** purplerbot has quit IRC | 20:18 | |
*** tobberydberg has quit IRC | 20:18 | |
*** alex_xu has quit IRC | 20:18 | |
*** masayukig has quit IRC | 20:18 | |
*** pas-ha has quit IRC | 20:18 | |
*** mgoddard has quit IRC | 20:18 | |
*** dtruong has quit IRC | 20:18 | |
*** kevinbenton has quit IRC | 20:18 | |
*** amorin has quit IRC | 20:18 | |
*** pas-ha_ is now known as pas-ha | 20:18 | |
*** brinzhang0 has quit IRC | 20:19 | |
*** dtruong has joined #openstack-nova | 20:19 | |
*** kevinbenton has joined #openstack-nova | 20:19 | |
openstackgerrit | Mohammed Naser proposed openstack/nova master: bfv: check if image_size > volume_size in API https://review.opendev.org/736370 | 20:20 |
*** amorin has joined #openstack-nova | 20:20 | |
*** irclogbot_1 has joined #openstack-nova | 20:21 | |
*** mgoddard has joined #openstack-nova | 20:21 | |
*** purplerbot has joined #openstack-nova | 20:23 | |
*** masayukig has joined #openstack-nova | 20:24 | |
*** gyee has joined #openstack-nova | 20:31 | |
*** nweinber has quit IRC | 20:35 | |
*** pas-ha has quit IRC | 20:35 | |
melwitt | mnaser: cool I'll check it | 20:36 |
*** csatari has quit IRC | 20:39 | |
*** knikolla has quit IRC | 20:40 | |
*** dlbewley has quit IRC | 20:40 | |
*** dlbewley has joined #openstack-nova | 20:41 | |
*** knikolla has joined #openstack-nova | 20:42 | |
*** tonyb[m] has quit IRC | 20:43 | |
*** mriedem has left #openstack-nova | 20:46 | |
*** ociuhandu has quit IRC | 20:48 | |
*** PrinzElvis has quit IRC | 20:49 | |
*** priteau has quit IRC | 20:49 | |
*** dlbewley has quit IRC | 20:50 | |
*** dlbewley has joined #openstack-nova | 20:51 | |
*** knikolla has quit IRC | 20:52 | |
*** ttsiouts has joined #openstack-nova | 20:52 | |
*** PrinzElvis has joined #openstack-nova | 20:53 | |
*** ttsiouts has quit IRC | 20:57 | |
*** PrinzElvis has quit IRC | 20:57 | |
*** maciejjozefczyk has quit IRC | 21:00 | |
*** dlbewley has quit IRC | 21:06 | |
*** dlbewley has joined #openstack-nova | 21:06 | |
*** spatel has quit IRC | 21:13 | |
*** ociuhandu has joined #openstack-nova | 21:19 | |
*** xek has quit IRC | 21:20 | |
*** ociuhandu has quit IRC | 21:24 | |
*** amodi has quit IRC | 21:25 | |
*** dlbewley has quit IRC | 21:25 | |
*** dlbewley has joined #openstack-nova | 21:26 | |
*** salmankhan has quit IRC | 21:27 | |
*** xiaolin has quit IRC | 21:27 | |
*** pas-ha has joined #openstack-nova | 21:34 | |
*** PrinzElvis has joined #openstack-nova | 21:35 | |
*** dlbewley has quit IRC | 21:35 | |
*** dlbewley has joined #openstack-nova | 21:36 | |
*** tonyb[m] has joined #openstack-nova | 21:38 | |
*** csatari has joined #openstack-nova | 21:38 | |
*** spatel has joined #openstack-nova | 21:38 | |
*** knikolla has joined #openstack-nova | 21:40 | |
*** slaweq has quit IRC | 21:41 | |
*** raildo has quit IRC | 21:42 | |
*** spatel has quit IRC | 21:43 | |
*** spatel has joined #openstack-nova | 21:45 | |
*** tosky has quit IRC | 21:56 | |
*** tosky has joined #openstack-nova | 21:56 | |
*** spatel has quit IRC | 22:02 | |
*** dlbewley has quit IRC | 22:05 | |
*** dlbewley has joined #openstack-nova | 22:06 | |
gmann | sean-k-mooney: mnaser and to make listing flavor better (instead of need of --private or --all explicitly ) we should add the admin as default tenant access in private flavor. currently what all admin can list the flavors by default and what all it can delete is not matching. | 22:09 |
gmann | also --private and --all is all admin things and for non-admin --private is just ignored - https://github.com/openstack/nova/blob/6ed556f4adfd8a98fae2e91204f1ce0484f5dd9d/nova/api/openstack/compute/flavors.py#L106 | 22:09 |
gmann | if we add admin as default tenant access in private flavor then i think we can solve it in backward compatible way but it will be interop issue so that still need microversion. | 22:13 |
*** spatel has joined #openstack-nova | 22:29 | |
*** spatel has quit IRC | 22:32 | |
*** rcernin has joined #openstack-nova | 22:42 | |
*** gyee has quit IRC | 22:52 | |
*** tkajinam has joined #openstack-nova | 22:54 | |
*** tosky has quit IRC | 23:09 | |
*** hoonetorg has quit IRC | 23:10 | |
*** hoonetorg has joined #openstack-nova | 23:22 | |
*** CeeMac has quit IRC | 23:34 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!