*** mlavalle has quit IRC | 00:15 | |
openstackgerrit | Wenping Song proposed openstack/nova master: delete sub resource provider when delete resource provider https://review.opendev.org/719163 | 00:29 |
---|---|---|
*** dolpher has joined #openstack-nova | 00:50 | |
*** spatel has joined #openstack-nova | 00:57 | |
*** tbachman_ has joined #openstack-nova | 01:04 | |
*** tbachman has quit IRC | 01:05 | |
*** tbachman_ is now known as tbachman | 01:05 | |
*** tbachman_ has joined #openstack-nova | 01:11 | |
*** tbachman has quit IRC | 01:12 | |
*** tbachman_ is now known as tbachman | 01:12 | |
*** dlbewley has quit IRC | 01:18 | |
*** dlbewley has joined #openstack-nova | 01:18 | |
*** factor__ has quit IRC | 01:53 | |
*** factor__ has joined #openstack-nova | 01:53 | |
*** gyee has quit IRC | 01:58 | |
*** mriedem has quit IRC | 02:00 | |
*** factor__ has quit IRC | 02:02 | |
*** rcernin has quit IRC | 02:12 | |
*** mkrai has joined #openstack-nova | 02:28 | |
*** dlbewley has quit IRC | 02:28 | |
*** dlbewley has joined #openstack-nova | 02:28 | |
*** dlbewley has quit IRC | 02:38 | |
*** dlbewley has joined #openstack-nova | 02:39 | |
*** lbragstad has quit IRC | 03:00 | |
*** yaawang_ has quit IRC | 03:08 | |
*** yaawang_ has joined #openstack-nova | 03:09 | |
*** tetsuro has quit IRC | 03:11 | |
*** rcernin has joined #openstack-nova | 03:17 | |
openstackgerrit | Wenping Song proposed openstack/nova master: delete sub resource provider when delete resource provider https://review.opendev.org/719163 | 03:21 |
*** psachin has joined #openstack-nova | 03:29 | |
*** Liang__ has joined #openstack-nova | 03:30 | |
*** tetsuro has joined #openstack-nova | 03:45 | |
*** dlbewley has quit IRC | 03:51 | |
*** dlbewley has joined #openstack-nova | 03:52 | |
*** mkrai has quit IRC | 04:11 | |
*** dlbewley has quit IRC | 04:11 | |
*** mkrai_ has joined #openstack-nova | 04:11 | |
*** dlbewley has joined #openstack-nova | 04:12 | |
*** markvoelker has joined #openstack-nova | 04:24 | |
*** markvoelker has quit IRC | 04:29 | |
*** evrardjp has quit IRC | 04:33 | |
*** evrardjp has joined #openstack-nova | 04:33 | |
*** arjunbaindur has joined #openstack-nova | 04:36 | |
arjunbaindur | hey, have a question about configuring PCI passthrough. We have a device that has 2 functions. On the hypervisor, the PCI address has it on same bus and same slot. When it shows up inside the VM, the PCI address has it under different slots | 04:38 |
arjunbaindur | for example, suppose device has two functions at 83:00.0 and 83:00.1 | 04:39 |
arjunbaindur | Under the VM, the devices show up under different slots, for example 0:5.0 and 0:6.0 | 04:40 |
arjunbaindur | any idea why? | 04:40 |
*** vishalmanchanda has joined #openstack-nova | 04:40 | |
*** markvoelker has joined #openstack-nova | 05:09 | |
*** markvoelker has quit IRC | 05:14 | |
*** links has joined #openstack-nova | 05:16 | |
*** udesale has joined #openstack-nova | 05:34 | |
*** links has quit IRC | 05:42 | |
*** links has joined #openstack-nova | 05:43 | |
*** yaawang_ has quit IRC | 05:52 | |
*** spatel has quit IRC | 05:59 | |
*** dklyle has quit IRC | 06:01 | |
*** dlbewley has quit IRC | 06:06 | |
*** dlbewley has joined #openstack-nova | 06:06 | |
*** ratailor has joined #openstack-nova | 06:08 | |
*** ratailor has quit IRC | 06:22 | |
openstackgerrit | Wenping Song proposed openstack/nova master: Delete sub resource provider when delete resource provider https://review.opendev.org/719163 | 06:29 |
*** tosky has joined #openstack-nova | 06:30 | |
*** ratailor has joined #openstack-nova | 06:30 | |
*** tetsuro has quit IRC | 06:32 | |
*** tetsuro has joined #openstack-nova | 06:40 | |
*** rpittau|afk is now known as rpittau | 06:44 | |
*** links has quit IRC | 06:46 | |
*** belmoreira has joined #openstack-nova | 06:52 | |
*** slaweq has joined #openstack-nova | 07:00 | |
*** links has joined #openstack-nova | 07:01 | |
*** ircuser-1 has quit IRC | 07:06 | |
*** markvoelker has joined #openstack-nova | 07:10 | |
*** markvoelker has quit IRC | 07:15 | |
*** ttsiouts has joined #openstack-nova | 07:15 | |
*** ttsiouts_ has joined #openstack-nova | 07:17 | |
*** dtantsur|afk is now known as dtantsur | 07:17 | |
*** tesseract has joined #openstack-nova | 07:17 | |
*** dlbewley has quit IRC | 07:17 | |
*** dlbewley has joined #openstack-nova | 07:18 | |
*** ttsiouts_ has quit IRC | 07:20 | |
*** ttsiouts has quit IRC | 07:21 | |
*** ttsiouts has joined #openstack-nova | 07:21 | |
*** tetsuro has quit IRC | 07:24 | |
*** ttsiouts has quit IRC | 07:26 | |
*** ttsiouts has joined #openstack-nova | 07:27 | |
*** damien_r has joined #openstack-nova | 07:31 | |
*** damien_r has quit IRC | 07:36 | |
*** damien_r has joined #openstack-nova | 07:36 | |
*** links has quit IRC | 07:37 | |
*** ralonsoh has joined #openstack-nova | 07:38 | |
*** bhagyashris|away is now known as bhagyashris | 07:39 | |
*** damien_r has quit IRC | 07:42 | |
*** damien_r has joined #openstack-nova | 07:42 | |
*** damien_r has quit IRC | 07:42 | |
*** damien_r has joined #openstack-nova | 07:42 | |
*** yaawang has joined #openstack-nova | 07:45 | |
*** damien_r has quit IRC | 07:46 | |
*** damien_r has joined #openstack-nova | 07:50 | |
*** rcernin has quit IRC | 07:59 | |
*** maciejjozefczyk_ has joined #openstack-nova | 08:14 | |
*** maciejjozefczyk has quit IRC | 08:18 | |
*** sapd1 has joined #openstack-nova | 08:20 | |
*** mkrai_ has quit IRC | 08:23 | |
*** mkrai has joined #openstack-nova | 08:24 | |
*** salmankhan has joined #openstack-nova | 08:32 | |
*** markvoelker has joined #openstack-nova | 08:34 | |
*** salmankhan has quit IRC | 08:36 | |
*** salmankhan has joined #openstack-nova | 08:36 | |
*** ttsiouts has quit IRC | 08:38 | |
*** markvoelker has quit IRC | 08:39 | |
*** links has joined #openstack-nova | 08:40 | |
openstackgerrit | Stephen Finucane proposed openstack/nova stable/ussuri: libvirt: Mark e1000e VIF as supported https://review.opendev.org/736957 | 08:45 |
*** mugsie has quit IRC | 08:48 | |
*** mugsie has joined #openstack-nova | 08:48 | |
openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: libvirt: Mark e1000e VIF as supported https://review.opendev.org/736962 | 08:51 |
*** martinkennelly has joined #openstack-nova | 08:52 | |
*** rcernin has joined #openstack-nova | 08:54 | |
*** ttsiouts has joined #openstack-nova | 08:54 | |
gibi | aarents: there is a bug in the image cache disk reservation patch. https://bugs.launchpad.net/nova/+bug/1884214 | 08:59 |
openstack | Launchpad bug 1884214 in OpenStack Compute (nova) "reserve disk usage for image cache fails on a fresh hypervisor" [Medium,Confirmed] - Assigned to Balazs Gibizer (balazs-gibizer) | 08:59 |
*** rcernin has quit IRC | 09:01 | |
*** links has quit IRC | 09:01 | |
*** links has joined #openstack-nova | 09:04 | |
gibi | aarents: I will push a fix soon | 09:04 |
*** huaqiang has quit IRC | 09:12 | |
*** huaqiang has joined #openstack-nova | 09:18 | |
aarents | gibi: I saw that, thank you, I was wondering if nova create _base directory only when needed at first cache() but I did not check | 09:21 |
*** tkajinam has quit IRC | 09:21 | |
*** rcernin has joined #openstack-nova | 09:23 | |
*** huaqiang has quit IRC | 09:25 | |
*** xek has joined #openstack-nova | 09:27 | |
gibi | aarents: yeah I also missed that case | 09:29 |
*** priteau has joined #openstack-nova | 09:36 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Guard against missing image cache directory https://review.opendev.org/736964 | 09:37 |
gibi | aarents: ^^ | 09:39 |
aarents | gibi: checking | 09:41 |
*** huaqiang has joined #openstack-nova | 09:41 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Guard against missing image cache directory https://review.opendev.org/736964 | 09:54 |
*** rcernin has quit IRC | 09:58 | |
*** huaqiang has quit IRC | 10:08 | |
*** huaqiang has joined #openstack-nova | 10:09 | |
*** maciejjozefczyk_ is now known as maciejjozefczyk | 10:13 | |
*** dlbewley has quit IRC | 10:18 | |
*** dlbewley has joined #openstack-nova | 10:18 | |
*** brinzhang has quit IRC | 10:21 | |
*** rpittau is now known as rpittau|bbl | 10:22 | |
*** Liang__ has quit IRC | 10:24 | |
*** mkrai has quit IRC | 10:36 | |
*** dlbewley has quit IRC | 10:37 | |
*** dlbewley has joined #openstack-nova | 10:38 | |
*** markvoelker has joined #openstack-nova | 10:44 | |
*** markvoelker has quit IRC | 10:49 | |
*** rcernin has joined #openstack-nova | 10:54 | |
*** rcernin has quit IRC | 11:08 | |
*** ratailor has quit IRC | 11:09 | |
*** dlbewley has quit IRC | 11:12 | |
*** dlbewley has joined #openstack-nova | 11:13 | |
*** dlbewley has quit IRC | 11:22 | |
*** dlbewley has joined #openstack-nova | 11:23 | |
*** mkrai has joined #openstack-nova | 11:29 | |
*** martinkennelly has quit IRC | 11:30 | |
openstackgerrit | Wenping Song proposed openstack/nova master: Delete resource provider in tree by top-down traversable order https://review.opendev.org/719163 | 11:30 |
*** martinkennelly has joined #openstack-nova | 11:30 | |
*** dlbewley has quit IRC | 11:32 | |
*** links has quit IRC | 11:32 | |
*** dlbewley has joined #openstack-nova | 11:33 | |
songwenping_ | Hi, gibi. Pls review my latest commit for the patch:https://review.opendev.org/719163 | 11:34 |
*** derekh has joined #openstack-nova | 11:36 | |
*** raildo has joined #openstack-nova | 11:50 | |
*** rcernin has joined #openstack-nova | 11:53 | |
gibi | songwenping_: I will try to look at it next week | 11:55 |
songwenping_ | OK. Thanks. | 11:56 |
*** boxiang has joined #openstack-nova | 12:01 | |
*** boxiang_ has quit IRC | 12:02 | |
*** ociuhandu has quit IRC | 12:03 | |
*** tkajinam has joined #openstack-nova | 12:04 | |
*** ttsiouts has quit IRC | 12:04 | |
*** mkrai has quit IRC | 12:06 | |
*** rcernin has quit IRC | 12:06 | |
*** ttsiouts has joined #openstack-nova | 12:13 | |
*** rpittau|bbl is now known as rpittau | 12:19 | |
*** lbragstad has joined #openstack-nova | 12:19 | |
*** ociuhandu has joined #openstack-nova | 12:31 | |
*** derekh has quit IRC | 12:33 | |
*** markvoelker has joined #openstack-nova | 12:39 | |
*** sangeet has joined #openstack-nova | 12:41 | |
*** nweinber has joined #openstack-nova | 12:43 | |
*** udesale_ has joined #openstack-nova | 12:44 | |
*** udesale has quit IRC | 12:46 | |
*** huaqiang has quit IRC | 12:47 | |
*** spatel has joined #openstack-nova | 12:48 | |
*** huaqiang has joined #openstack-nova | 12:48 | |
*** derekh has joined #openstack-nova | 12:51 | |
*** spatel has quit IRC | 12:53 | |
*** markvoelker has quit IRC | 12:55 | |
*** dlbewley has quit IRC | 13:01 | |
*** dlbewley has joined #openstack-nova | 13:01 | |
openstackgerrit | Huaqiang Wang proposed openstack/nova master: release note: add new features introduces by use-pcpu-and-vcpu-in-one-instance https://review.opendev.org/736997 | 13:05 |
*** dtantsur is now known as dtantsur|brb | 13:11 | |
*** mriedem has joined #openstack-nova | 13:14 | |
*** huaqiang has quit IRC | 13:31 | |
*** huaqiang has joined #openstack-nova | 13:31 | |
sangeet | efried .. if the put cafile only in identity, compute fail to find it. | 13:31 |
*** ttsiouts has quit IRC | 13:33 | |
*** ttsiouts has joined #openstack-nova | 13:36 | |
stephenfin | huaqiang: I'm about to push up a rebase of the bp/use-pcpu-and-vcpu-in-one-instance series to address comments on the bottom 10 or so patches. Is that okay with you? | 13:38 |
*** eharney has joined #openstack-nova | 13:38 | |
*** rpittau is now known as rpittau|brb | 13:54 | |
*** mlavalle has joined #openstack-nova | 13:54 | |
*** rpittau|brb is now known as rpittau|afk | 14:00 | |
*** psachin has quit IRC | 14:01 | |
*** tbachman has quit IRC | 14:02 | |
*** dlbewley has quit IRC | 14:05 | |
*** dlbewley has joined #openstack-nova | 14:05 | |
*** ociuhandu has quit IRC | 14:07 | |
*** tosky has quit IRC | 14:08 | |
*** martinkennelly has quit IRC | 14:11 | |
*** martinkennelly has joined #openstack-nova | 14:11 | |
*** ociuhandu has joined #openstack-nova | 14:12 | |
*** martinkennelly has quit IRC | 14:13 | |
*** tkajinam has quit IRC | 14:13 | |
*** martinkennelly has joined #openstack-nova | 14:20 | |
*** KeithMnemonic has joined #openstack-nova | 14:23 | |
*** martinkennelly has quit IRC | 14:24 | |
*** martinkennelly has joined #openstack-nova | 14:24 | |
efried | sangeet: ack. | 14:25 |
*** martinkennelly has quit IRC | 14:26 | |
dansmith | gibi: wanna circle back on these? just made some minor changes for melwitt: https://review.opendev.org/#/c/731550/4 | 14:27 |
*** dtantsur|brb is now known as dtantsur | 14:28 | |
*** rchurch has quit IRC | 14:29 | |
*** rchurch has joined #openstack-nova | 14:32 | |
*** tbachman has joined #openstack-nova | 14:37 | |
dansmith | stephenfin: thoughts on this? https://review.opendev.org/#/c/736964/2/nova/virt/libvirt/imagecache.py | 14:39 |
dansmith | I know it's kinda minor, but... | 14:39 |
stephenfin | dansmith: makes sense to me | 14:40 |
*** dlbewley has quit IRC | 14:40 | |
dansmith | stephenfin: okay if gibi doesn't show up here soon to object I'll just fix it for him and we can push that in | 14:40 |
*** dlbewley has joined #openstack-nova | 14:41 | |
*** dklyle has joined #openstack-nova | 14:46 | |
*** ccamacho has quit IRC | 14:48 | |
*** ttsiouts has quit IRC | 14:55 | |
*** bbowen has quit IRC | 14:58 | |
*** bbowen has joined #openstack-nova | 14:58 | |
openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Add libvirt RBD configuration doc https://review.opendev.org/731577 | 15:00 |
openstackgerrit | Dan Smith proposed openstack/nova master: DNM: Try to make a glance multistore job https://review.opendev.org/734184 | 15:00 |
*** bbowen has quit IRC | 15:03 | |
*** jdillaman has joined #openstack-nova | 15:05 | |
*** amodi has joined #openstack-nova | 15:05 | |
huaqiang | stephenfin: I am OK with your rebase. Go ahead. | 15:10 |
stephenfin | sweet, thanks | 15:10 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Update and correct typing information https://review.opendev.org/714694 | 15:11 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Add typing information https://review.opendev.org/714695 | 15:11 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Add validation for 'cpu_realtime_mask' https://review.opendev.org/468203 | 15:11 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Split instance NUMA object tests https://review.opendev.org/714696 | 15:11 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Replace 'cpu_pinning_requested' helper https://review.opendev.org/714697 | 15:11 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Don't consider overhead CPUs for unpinned instances https://review.opendev.org/714698 | 15:11 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Remove handling of pre-Train compute nodes https://review.opendev.org/714699 | 15:11 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Rework 'get_realtime_constraint' https://review.opendev.org/714700 | 15:11 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Tweak the 'cpu_realtime_mask' handling slightly https://review.opendev.org/461456 | 15:11 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Invert order of NUMA topology generation https://review.opendev.org/714701 | 15:11 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Remove '_numa_fit_instance_cell_with_pinning' https://review.opendev.org/714703 | 15:11 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Introduce 'pcpuset' field for InstanceNUMACell https://review.opendev.org/714658 | 15:11 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: notifications: add the pcpuset info to instance numa cell payload https://review.opendev.org/728480 | 15:11 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Introduce the 'CPUAllocationPolicy.MIXED' enum https://review.opendev.org/716267 | 15:11 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: apply mixed instance CPU policy https://review.opendev.org/728481 | 15:11 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Validate CPU pinning configuration for mixed instance https://review.opendev.org/716268 | 15:11 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Calculate the CPU usage for mixed instance https://review.opendev.org/716269 | 15:11 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: online data migration for cpuset of dedicated instance https://review.opendev.org/718493 | 15:11 |
*** ociuhandu has quit IRC | 15:14 | |
*** mlavalle has quit IRC | 15:21 | |
*** mlavalle has joined #openstack-nova | 15:25 | |
*** boxiang has quit IRC | 15:30 | |
*** dlbewley has quit IRC | 15:32 | |
*** rchurch has quit IRC | 15:32 | |
*** dlbewley has joined #openstack-nova | 15:32 | |
*** rchurch has joined #openstack-nova | 15:32 | |
*** tbachman has quit IRC | 15:33 | |
*** purplerbot has quit IRC | 15:35 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Rework 'get_realtime_constraint' https://review.opendev.org/714700 | 15:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Allow 'hw:cpu_realtime_mask' to be omitted https://review.opendev.org/737026 | 15:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Tweak the 'cpu_realtime_mask' handling slightly https://review.opendev.org/461456 | 15:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Invert order of NUMA topology generation https://review.opendev.org/714701 | 15:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Remove '_numa_fit_instance_cell_with_pinning' https://review.opendev.org/714703 | 15:35 |
*** masterpe has quit IRC | 15:35 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Introduce 'pcpuset' field for InstanceNUMACell https://review.opendev.org/714658 | 15:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: notifications: add the pcpuset info to instance numa cell payload https://review.opendev.org/728480 | 15:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Introduce the 'CPUAllocationPolicy.MIXED' enum https://review.opendev.org/716267 | 15:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: apply mixed instance CPU policy https://review.opendev.org/728481 | 15:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Validate CPU pinning configuration for mixed instance https://review.opendev.org/716268 | 15:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Calculate the CPU usage for mixed instance https://review.opendev.org/716269 | 15:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: online data migration for cpuset of dedicated instance https://review.opendev.org/718493 | 15:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: scheduler: mixed instance CPU resource translating https://review.opendev.org/728482 | 15:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: flavor: Enable 'hw:cpu_dedicated_mask' for creating a mixed instance https://review.opendev.org/714706 | 15:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: compute: bump nova-compute service version for mixed instance https://review.opendev.org/716271 | 15:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: create 'mixed' instance for realtime and shared CPUs https://review.opendev.org/728485 | 15:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt/hardware: refactor numa_get_constraints https://review.opendev.org/718294 | 15:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Setup 'mixed' instance through 'PCPU' and 'VCPU' resource https://review.opendev.org/713355 | 15:35 |
*** jmlowe has quit IRC | 15:45 | |
*** dlbewley has quit IRC | 15:47 | |
*** dlbewley has joined #openstack-nova | 15:48 | |
*** hamalq has joined #openstack-nova | 15:49 | |
*** tosky has joined #openstack-nova | 15:50 | |
*** ttsiouts has joined #openstack-nova | 15:51 | |
*** hamalq_ has joined #openstack-nova | 15:51 | |
artom | stephenfin, wait, are you proposing we *remove* the "must start with a ^" validation on the realtime mask? | 15:52 |
artom | So we call it a mask, except when the user doesn't feel like, and then it's not a mask? | 15:52 |
*** purplerbot has joined #openstack-nova | 15:52 | |
artom | I actually had no idea it was validated to start with ^ in 2.86 | 15:52 |
stephenfin | it's still a mask | 15:52 |
artom | My opinion would be to keep it, and make the dedicated mask the same | 15:52 |
stephenfin | it's just not an exclusion mask | 15:53 |
stephenfin | it behaves sanely with this change | 15:53 |
artom | I've always understood mask to mean exclusion mask | 15:53 |
artom | In fact, "exclusion mask" would be a pleonasm in my book | 15:54 |
dansmith | not me | 15:54 |
*** hamalq has quit IRC | 15:54 | |
stephenfin | that's not how taskset would work | 15:54 |
dansmith | mask could be inclusion or inclusion to me | 15:54 |
dansmith | ahah | 15:54 |
dansmith | inclusion or exclusion :) | 15:54 |
artom | OK, I guess it's just me then, and I had it wrong? | 15:54 |
stephenfin | bad artom | 15:55 |
artom | *sigh* yeah | 15:55 |
dansmith | select()'s FDSET is an inclusion mask yeah? | 15:55 |
*** ttsiouts has quit IRC | 15:56 | |
stephenfin | oh, err, I think so? | 15:56 |
dansmith | it is, the question mark was rhetorical :) | 15:57 |
stephenfin | oh | 15:57 |
* stephenfin hasn't had to worry about that for a while | 15:57 | |
artom | dansmith, I'm trying to understand what you mean by reading `man 2 select` | 15:57 |
stephenfin | we'll come fish you out of that rabbit hole later | 15:57 |
artom | There's FD_SET(), but that's a macro | 15:57 |
dansmith | artom: the readfds, for example is a pointer to a word, with bits set nonzero if the FD represented by that bit should be checked for readability | 15:58 |
artom | (Also, `man 2 select` is the perfect title for a geek version of The Bachelorette) | 15:58 |
artom | dansmith, there's nothing about masks in the readfds para... | 16:02 |
artom | It's a set of file descriptors | 16:02 |
dansmith | artom: no, it's not, you're just not meant to know how it works under the covers | 16:02 |
dansmith | FD_SET is just readfds|=(1 << fd) | 16:03 |
*** xek has quit IRC | 16:04 | |
*** dtantsur is now known as dtantsur|afk | 16:13 | |
*** tesseract has quit IRC | 16:17 | |
*** dolpher has quit IRC | 16:18 | |
*** dlbewley has quit IRC | 16:23 | |
*** dlbewley has joined #openstack-nova | 16:24 | |
*** udesale_ has quit IRC | 16:26 | |
*** hamalq_ has quit IRC | 16:47 | |
*** hamalq has joined #openstack-nova | 16:47 | |
*** dlbewley has quit IRC | 16:53 | |
*** dlbewley has joined #openstack-nova | 16:53 | |
*** ChanServ has quit IRC | 16:59 | |
*** derekh has quit IRC | 17:02 | |
*** salmankhan has quit IRC | 17:05 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Guard against missing image cache directory https://review.opendev.org/736964 | 17:05 |
stephenfin | dansmith: ^ | 17:07 |
dansmith | stephenfin: I think you got that logic wrong | 17:09 |
stephenfin | crap | 17:09 |
dansmith | if the directory does not exist, then True, else if it does, True if st_dev matches | 17:09 |
stephenfin | At first glance it reads correctly to me. Bear with me | 17:11 |
dansmith | it's okay it's confusing, so make sure I'm right here | 17:11 |
dansmith | if the directory does exist, then we need to check to see if the st_dev matches.. if the directory does not exist, then we return True because when we create it, it will be on the same device | 17:12 |
stephenfin | right, yeah, makes sense | 17:12 |
stephenfin | yay, Fridays | 17:12 |
stephenfin | I'll respin again | 17:12 |
*** gmann is now known as gmann_afk | 17:13 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Guard against missing image cache directory https://review.opendev.org/736964 | 17:18 |
*** efried has quit IRC | 17:19 | |
dansmith | stephenfin: got it | 17:23 |
stephenfin | I've done enough on that so I'll defer to melwitt or someone to approve | 17:24 |
melwitt | yeah I'll review it | 17:24 |
dansmith | ack, I think that's a good idea | 17:25 |
*** ChanServ has joined #openstack-nova | 17:37 | |
*** tepper.freenode.net sets mode: +o ChanServ | 17:37 | |
*** mlavalle has quit IRC | 17:40 | |
*** efried has joined #openstack-nova | 17:41 | |
*** salmankhan has joined #openstack-nova | 17:43 | |
melwitt | dansmith: added some comments, am I missing something? because to me it seems this is doing the opposite of what is wanted in the commit message https://review.opendev.org/736964 | 17:47 |
melwitt | I see that you've said the first time an image is cached, the dir will be created, but update_provider_tree is a periodic task right? what will ensure the cache dir is created by the time we ask for get_disk_usage()? | 17:48 |
dansmith | nothing will ensure that it's created | 17:49 |
dansmith | the bug is that if it's not created and this runs, it doesn't handle the case where it's not created | 17:49 |
*** tesseract has joined #openstack-nova | 17:49 | |
dansmith | however, we don't just want to do nothing if it's not created, we want to take the path that assumes that when it does get created, it will necessarily be on the same st_dev, and thus not report any cache | 17:49 |
melwitt | yeah, I got that part but from what I was looking, if the cache dir doesn't exist it will fall through and start checking usage of the cache dir and if it doesn't exist won't that be bad? | 17:50 |
dansmith | where will it fall through? | 17:51 |
melwitt | cause we'll end up here if the dir doesn't exist https://github.com/openstack/nova/blob/f5f7c2540150c7ee7640c834d5caec31b3f5a7ab/nova/virt/libvirt/imagecache.py#L366 | 17:51 |
*** ttsiouts has joined #openstack-nova | 17:52 | |
dansmith | er wait, maybe I'm inverting that in my head | 17:52 |
melwitt | it will return 0 disk usage if self.cache_dir_is_on_same_dev_as_instances_dir is False, right? | 17:52 |
dansmith | okay right right, I forgot how this ended up | 17:52 |
dansmith | we initially talked about reporting inventory for the cache disk itself, | 17:52 |
melwitt | else it will do the math on the cache dir | 17:53 |
dansmith | and this is the opposite where we reserve only if the cache is the _same_ disk, which I think is why we endded up checking the reverse condition instead of what we're looking for | 17:53 |
*** dlbewley has quit IRC | 17:53 | |
dansmith | so yeah, we need to bail if the directory doesn't exist because we're checking the cache_dir which might not exist yet | 17:54 |
dansmith | I still think the property shouldnt' explode if the directory doesn't exist, | 17:54 |
dansmith | but you're right, it'll still hit the same problem but a little later on | 17:54 |
*** dlbewley has joined #openstack-nova | 17:54 | |
dansmith | the logic is right, it just doesn't prevent us from hitting the same problem in the sum() | 17:55 |
melwitt | oh, ok, so the logic on exists() should not be inverted to remove the 'not' | 17:55 |
dansmith | no, because if it does not exist, the not will make that true, which will short-circuit and return true without evaluating the st_dev part | 17:56 |
melwitt | oh, right | 17:57 |
dansmith | I'll pull this down and make that change, just a sec | 17:58 |
melwitt | ok, cool | 17:59 |
dansmith | eff, just realized I didn't commit something I did earlier today unrelated | 17:59 |
openstackgerrit | Dan Smith proposed openstack/nova master: DNM: Try to make a glance multistore job https://review.opendev.org/734184 | 17:59 |
dansmith | so another few days in the queue for me | 17:59 |
melwitt | heh :( | 18:00 |
openstackgerrit | Dan Smith proposed openstack/nova master: Guard against missing image cache directory https://review.opendev.org/736964 | 18:10 |
dansmith | melwitt: ^ | 18:10 |
*** mlavalle has joined #openstack-nova | 18:11 | |
dansmith | added comments to hopefully make it clearer why each thing is happening | 18:12 |
melwitt | looking ... ah yep, that is helpful | 18:14 |
dansmith | thanks. I was clearly focused on getting that property to return the right thing all the time and not realizing we'd be introducing a new vector to the error :) | 18:19 |
*** songwenping__ has joined #openstack-nova | 18:21 | |
*** songwenping_ has quit IRC | 18:24 | |
*** ttsiouts has quit IRC | 18:25 | |
*** artom has quit IRC | 18:32 | |
*** artom has joined #openstack-nova | 18:32 | |
*** Supersphere1 has joined #openstack-nova | 18:37 | |
*** Supersphere1 has quit IRC | 18:39 | |
*** dlbewley has quit IRC | 18:43 | |
*** dlbewley has joined #openstack-nova | 18:43 | |
*** dlbewley has quit IRC | 18:53 | |
*** jmlowe has joined #openstack-nova | 18:53 | |
*** dlbewley has joined #openstack-nova | 18:54 | |
*** belmoreira has quit IRC | 18:57 | |
*** bnemec is now known as beekneemech | 19:08 | |
*** salmankhan has quit IRC | 19:21 | |
*** dlbewley has quit IRC | 19:22 | |
*** dlbewley has joined #openstack-nova | 19:23 | |
*** markvoelker has joined #openstack-nova | 19:31 | |
*** markvoelker has quit IRC | 19:36 | |
*** mriedem is now known as hughjazz | 19:59 | |
*** KeithMnemonic has quit IRC | 19:59 | |
*** tesseract has quit IRC | 20:00 | |
*** dlbewley has quit IRC | 20:00 | |
*** dlbewley has joined #openstack-nova | 20:01 | |
*** markvoelker has joined #openstack-nova | 20:04 | |
*** nweinber has quit IRC | 20:05 | |
*** markvoelker has quit IRC | 20:09 | |
*** gmann_afk is now known as gmann | 20:15 | |
*** _mlavalle_1 has joined #openstack-nova | 20:25 | |
*** mlavalle has quit IRC | 20:26 | |
*** ralonsoh has quit IRC | 20:33 | |
*** priteau has quit IRC | 20:36 | |
*** vishalmanchanda has quit IRC | 20:40 | |
mnaser | just wanna put eyes on https://review.opendev.org/#/c/736370/ if/when possible :) | 20:43 |
*** gyee has joined #openstack-nova | 20:46 | |
*** xek has joined #openstack-nova | 20:54 | |
*** ttsiouts has joined #openstack-nova | 21:01 | |
*** factor has joined #openstack-nova | 21:04 | |
sean-k-mooney | mnaser: form the title that makes sense | 21:04 |
sean-k-mooney | ill take a look on monday | 21:05 |
*** dlbewley has quit IRC | 21:05 | |
sean-k-mooney | actully its pretty short | 21:05 |
*** raildo has quit IRC | 21:05 | |
*** dlbewley has joined #openstack-nova | 21:05 | |
mnaser | sean-k-mooney: thank you! | 21:07 |
sean-k-mooney | melwitt: just finished reviewing https://review.opendev.org/#/c/736370/2 want to take a look? | 21:18 |
sean-k-mooney | mnaser: the only thing im not sure is do we want to have a release note or not. | 21:18 |
sean-k-mooney | mnaser: this would have failed anyway later so the only behavior change is that by failing in _validate_flavor_image_nostatus we now fail before creating a server record | 21:19 |
sean-k-mooney | so instead of ending up with a server in error state we just get an excption form spawn | 21:20 |
sean-k-mooney | which is better but as an operator would you want that called out in the release notes give the excption you are raising inherits form FlavorDiskTooSmall which can already casue the same behvoiur if the volume is less the min_gb | 21:21 |
sean-k-mooney | mnaser: ^ | 21:21 |
*** xek_ has joined #openstack-nova | 21:25 | |
*** xek has quit IRC | 21:28 | |
arjunbaindur | hey, have a question about configuring PCI passthrough. We have a device that has 2 functions. On the hypervisor, the PCI address has it on same bus and same slot. When it shows up inside the VM, the PCI address has it under different slots | 21:31 |
*** dlbewley has quit IRC | 21:31 | |
arjunbaindur | for example, suppose device has two functions at 83:00.0 and 83:00.1 | 21:31 |
arjunbaindur | Under the VM, the devices show up under different slots, for example 0:5.0 and 0:6.0 | 21:31 |
*** dlbewley has joined #openstack-nova | 21:31 | |
*** lbragstad has quit IRC | 21:32 | |
sean-k-mooney | im guessing its a gpu with a second function for the audio encoder on the gpu? | 21:32 |
arjunbaindur | any idea how to get them to show up as two functions under the same slot | 21:32 |
sean-k-mooney | or a similar device | 21:32 |
sean-k-mooney | unfortunetly we do not have a way to do that currently | 21:32 |
sean-k-mooney | we did dicuss it breifly about 3-6 months ago | 21:33 |
sean-k-mooney | efffectivly we would need to modify the pci alisia to support multifuntion devices | 21:33 |
sean-k-mooney | such as allowing one pci aliase to refrence another and adding a multifuntion=true tag | 21:34 |
sean-k-mooney | so the parent alias would refence the child aliase and but or would have the multifunction=ture tag | 21:35 |
*** ttsiouts has quit IRC | 21:35 | |
sean-k-mooney | arjunbaindur: i think on windows this can break the audio encoder on nvidga gpus since the driver is expecting it to be a second fuction on the same bus/slot | 21:36 |
sean-k-mooney | but on linux it works | 21:36 |
sean-k-mooney | im sure it would be an issue for other device that had the same toplogy | 21:36 |
arjunbaindur | to be specific, this is a Xilinx card | 21:39 |
arjunbaindur | https://www.xilinx.com/support/documentation/boards_and_kits/accelerator-cards/1_5/ug1301-getting-started-guide-alveo-accelerator-cards.pdf | 21:39 |
arjunbaindur | since the two devices show up under diff PCI slots, we arent able to install drivers | 21:39 |
sean-k-mooney | ah ok well its the same issue unfortunetly | 21:40 |
sean-k-mooney | are you trying to reproguam the aclerat using 1 fucntion | 21:40 |
sean-k-mooney | and consume it using the second | 21:40 |
*** songwenping_ has joined #openstack-nova | 21:41 | |
*** lbragstad has joined #openstack-nova | 21:42 | |
sean-k-mooney | 32-64GB of ddr4 + and fpga and some qsfp ports. that looks like a pretty interesting card | 21:42 |
sean-k-mooney | arjunbaindur: are you trying to use this via cyborg or just novas pci passhtough | 21:43 |
arjunbaindur | just Nova PCI passthrough: followed this doc basically: https://docs.openstack.org/nova/rocky/admin/pci-passthrough.html | 21:44 |
*** songwenping__ has quit IRC | 21:44 | |
arjunbaindur | Added the two PCI addresses for each function in the whitelist | 21:44 |
sean-k-mooney | ya so as i said we are missing the ablity to group multiple fucntion together form teh same device that are schulded togehter | 21:44 |
arjunbaindur | is there an upstream bug or anything to track this? | 21:45 |
sean-k-mooney | i was trying to find one. its not really a bug since it was never part of the orginial design | 21:45 |
sean-k-mooney | i suspcet this would need a short spec or maybe a specless blueprint | 21:46 |
sean-k-mooney | arjunbaindur: looking at the open blueprints no | 21:48 |
sean-k-mooney | so the feature you need is support for "multifunction pci device passthough" | 21:48 |
sean-k-mooney | if you want to file a blueprint for that and add the details of your specific usecase we could bring it up in the next meeting or dicsuss it here next week when more people are online | 21:49 |
sean-k-mooney | it has been asked for before and should not be too invasive to add but on the other hand not many people review the pci code so getting reviews might be the bigger stubleing block to addign this | 21:50 |
sean-k-mooney | its a cpablity i suspect cyborg will want eventually too so the libvirt driver work to supprot generintg the correct xml is likely to be need regardless of if we add the feature to novas pci pasthough | 21:51 |
*** xek_ has quit IRC | 21:54 | |
*** eharney has quit IRC | 21:58 | |
*** markvoelker has joined #openstack-nova | 22:05 | |
*** markvoelker has quit IRC | 22:10 | |
*** _mlavalle_2 has joined #openstack-nova | 22:23 | |
*** _mlavalle_1 has quit IRC | 22:24 | |
*** _mlavalle3 has joined #openstack-nova | 22:29 | |
sean-k-mooney | dansmith: it finally passed https://review.opendev.org/#/c/734184/ :) | 22:29 |
sean-k-mooney | dansmith: ah you modified devstack in the end https://review.opendev.org/#/c/736231 | 22:31 |
*** _mlavalle_2 has quit IRC | 22:31 | |
*** gyee has quit IRC | 22:42 | |
*** hughjazz has left #openstack-nova | 22:51 | |
*** _mlavalle3 has quit IRC | 22:57 | |
*** jdillaman has quit IRC | 23:02 | |
*** hamalq has quit IRC | 23:11 | |
artom | sean-k-mooney, if by some weirdness of circumstance you're still working: https://review.opendev.org/#/c/737052/2 | 23:26 |
*** spatel has joined #openstack-nova | 23:32 | |
*** ttsiouts has joined #openstack-nova | 23:32 | |
sean-k-mooney | im watching a c++ code review of command and conquer https://www.youtube.com/watch?v=Oee7gje-XRc&t=929s | 23:32 |
sean-k-mooney | but since my laptop is broken im using my work one | 23:33 |
sean-k-mooney | until i buy a new one | 23:33 |
sean-k-mooney | so ya you unabandonted that? | 23:33 |
sean-k-mooney | or is this a different fix | 23:33 |
sean-k-mooney | that is instead of https://review.opendev.org/#/c/737038/ | 23:34 |
sean-k-mooney | artom: ah ok i see whats happening we are installing pacages via pip before devstack runs for crudini | 23:36 |
sean-k-mooney | so devstack has not allready installed pip | 23:36 |
sean-k-mooney | artom: so this is happing because of http://lists.openstack.org/pipermail/openstack-discuss/2020-June/015204.html | 23:44 |
sean-k-mooney | artom: so +2 from me the ci passes and the patch makes sense | 23:44 |
*** tosky has quit IRC | 23:45 | |
artom | I dunno what I expected | 23:46 |
artom | Thank you! | 23:46 |
artom | Also, you're a lunatic | 23:46 |
sean-k-mooney | for likeing c++ | 23:46 |
artom | Sure, why not | 23:46 |
sean-k-mooney | or for having irc open on a different monitor while i watch youtube | 23:47 |
artom | That last part is almost reasonnable | 23:48 |
dansmith | sean-k-mooney: it didn't setup glance properly though, for some devstack reason I don't understand | 23:48 |
dansmith | so I'll have to work on that on monday | 23:48 |
sean-k-mooney | dansmith: ah ok i can take a look on monday too if you like the main issue is i dont know how to configure what you want to configure | 23:49 |
sean-k-mooney | dansmith: but let me know if i can help | 23:49 |
dansmith | sean-k-mooney: well, you can see what I've got in local.conf, and that didn't end up in glance-api.conf like it did before | 23:49 |
dansmith | but anyway, I can take a look and then come crawling to you, which'll make it even more sweet for you :) | 23:49 |
sean-k-mooney | :) | 23:50 |
*** martinkennelly has joined #openstack-nova | 23:52 | |
sean-k-mooney | oh ya https://zuul.opendev.org/t/openstack/build/d083edcf35d649768506fbbf7dbbf64c/log/controller/logs/etc/glance/glance-api_conf.txt does not have the values but https://zuul.opendev.org/t/openstack/build/d083edcf35d649768506fbbf7dbbf64c/log/controller/logs/etc/glance/glance-image-import_conf.txt does | 23:52 |
dansmith | I gotta begin my weekend, later | 23:53 |
sean-k-mooney | dansmith: o/ | 23:53 |
*** songwenping__ has joined #openstack-nova | 23:57 | |
sean-k-mooney | dansmith: for what its worth i think your hitting a devstack bug since its in the local.conf correctly. so i think your zuul file is correct. | 23:59 |
sean-k-mooney | e.g. someitng in devstack is modifying the config after the post config phase which is a bug | 23:59 |
sean-k-mooney | just a guess | 23:59 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!