Tuesday, 2020-06-23

« Monday, 2020-06-22 Index Wednesday, 2020-06-24 »
*** sean-k-mooney1 has joined #openstack-nova00:00
*** sean-k-mooney has quit IRC00:01
*** sean-k-mooney2 has joined #openstack-nova00:29
*** sean-k-mooney1 has quit IRC00:32
*** dlbewley has quit IRC00:32
*** dlbewley has joined #openstack-nova00:32
*** swp20 has joined #openstack-nova00:34
*** artom has quit IRC00:39
*** artom has joined #openstack-nova00:40
*** xiaolin has joined #openstack-nova00:43
*** artom has quit IRC00:45
openstackgerritMerged openstack/nova stable/train: Check cherry-pick hashes in pep8 tox target  https://review.opendev.org/73727900:47
*** dlbewley has quit IRC00:57
*** dlbewley has joined #openstack-nova00:57
openstackgerritGhanshyam Mann proposed openstack/nova stable/train: DNM: testing virtualenv not found fix  https://review.opendev.org/73740000:57
*** hamalq has joined #openstack-nova01:16
*** hamalq has quit IRC01:18
*** Liang__ has joined #openstack-nova01:18
*** gyee has quit IRC01:23
*** lseki has quit IRC01:31
*** ociuhandu has joined #openstack-nova01:31
*** hamalq has joined #openstack-nova01:33
*** ociuhandu has quit IRC01:35
*** hamalq has quit IRC01:39
*** dlbewley has quit IRC01:39
*** dlbewley has joined #openstack-nova01:40
*** sean-k-mooney has joined #openstack-nova01:58
*** sean-k-mooney2 has quit IRC01:59
*** swp20 has quit IRC02:15
*** swp20 has joined #openstack-nova02:15
*** dlbewley has quit IRC02:25
*** dlbewley has joined #openstack-nova02:26
*** hamalq has joined #openstack-nova02:32
*** dlbewley has quit IRC02:34
*** dlbewley has joined #openstack-nova02:35
*** hamalq has quit IRC02:36
*** rcernin has quit IRC02:41
*** rcernin has joined #openstack-nova02:43
*** hamalq has joined #openstack-nova02:48
*** swp20 has quit IRC02:51
*** hamalq has quit IRC02:52
*** markvoelker has joined #openstack-nova03:06
*** markvoelker has quit IRC03:11
*** vishalmanchanda has joined #openstack-nova03:15
*** hamalq has joined #openstack-nova03:25
*** hamalq has quit IRC03:30
*** hamalq has joined #openstack-nova03:54
*** hamalq has quit IRC03:58
*** hamalq has joined #openstack-nova04:10
*** hamalq has quit IRC04:15
*** rchurch has quit IRC04:23
*** rchurch has joined #openstack-nova04:24
*** evrardjp has quit IRC04:33
*** evrardjp has joined #openstack-nova04:33
*** udesale has joined #openstack-nova04:41
*** markvoelker has joined #openstack-nova04:44
*** markvoelker has quit IRC04:49
*** dlbewley has quit IRC04:57
*** dlbewley has joined #openstack-nova04:58
*** markvoelker has joined #openstack-nova05:04
*** ratailor has joined #openstack-nova05:08
*** markvoelker has quit IRC05:09
*** dtantsur|afk has quit IRC05:14
*** dtantsur has joined #openstack-nova05:15
*** Liang__ has quit IRC05:17
*** Liang__ has joined #openstack-nova05:18
*** links has joined #openstack-nova05:24
*** cataling has quit IRC05:45
*** mgariepy has quit IRC05:52
*** mgariepy has joined #openstack-nova06:10
*** jsuchome has joined #openstack-nova06:11
*** damien_r has joined #openstack-nova06:13
*** damien_r has quit IRC06:18
*** mgariepy has quit IRC06:22
*** mgariepy has joined #openstack-nova06:24
*** dklyle has quit IRC06:26
*** rpittau|afk is now known as rpittau06:34
*** ralonsoh has joined #openstack-nova06:37
*** nightmare_unreal has joined #openstack-nova06:38
*** hamalq has joined #openstack-nova06:46
*** hamalq has quit IRC06:47
*** belmoreira has joined #openstack-nova06:49
*** dlbewley has quit IRC06:54
*** dlbewley has joined #openstack-nova06:55
*** ccamacho has joined #openstack-nova07:02
*** tesseract has joined #openstack-nova07:03
*** hamalq has joined #openstack-nova07:03
*** markvoelker has joined #openstack-nova07:05
openstackgerritWenping Song proposed openstack/nova master: Delete resource provider in tree by top-down traversable order  https://review.opendev.org/71916307:07
*** maciejjozefczyk has joined #openstack-nova07:08
*** hamalq has quit IRC07:08
*** ttsiouts has joined #openstack-nova07:09
*** dlbewley has quit IRC07:09
*** dlbewley has joined #openstack-nova07:10
*** markvoelker has quit IRC07:11
*** xek has joined #openstack-nova07:11
openstackgerritWenping Song proposed openstack/nova master: Delete resource provider in tree by top-down traversable order  https://review.opendev.org/71916307:25
*** tosky has joined #openstack-nova07:35
*** xek has quit IRC07:36
*** xek has joined #openstack-nova07:36
*** markvoelker has joined #openstack-nova07:49
*** dlbewley has quit IRC07:51
*** dlbewley has joined #openstack-nova07:52
*** damien_r has joined #openstack-nova07:53
*** markvoelker has quit IRC07:54
*** dlbewley has quit IRC08:02
*** dlbewley has joined #openstack-nova08:03
*** ttsiouts has quit IRC08:03
*** ttsiouts has joined #openstack-nova08:07
*** hamalq has joined #openstack-nova08:08
*** hamalq has quit IRC08:12
*** arjunbaindur has quit IRC08:13
*** rcernin has quit IRC08:18
*** martinkennelly has joined #openstack-nova08:21
*** dlbewley has quit IRC08:21
*** dlbewley has joined #openstack-nova08:22
*** hamalq has joined #openstack-nova08:24
*** hamalq has quit IRC08:29
*** jcath has joined #openstack-nova08:30
*** hamalq has joined #openstack-nova08:30
*** hamalq has quit IRC08:30
jcathhello,friends, how I can attach a volume to an exist instance as an ide disk/cdrom? whatever you set hw_disk_bus/hw_cdrom_bus in the image metadata, it does not work08:31
*** hamalq has joined #openstack-nova08:46
*** hamalq has quit IRC08:51
*** ociuhandu has joined #openstack-nova08:52
*** dlbewley has quit IRC08:55
*** dlbewley has joined #openstack-nova08:56
*** priteau has joined #openstack-nova08:58
*** owalsh has quit IRC09:08
*** tobiash has quit IRC09:08
*** janno has quit IRC09:08
*** owalsh_ has joined #openstack-nova09:08
*** janno has joined #openstack-nova09:10
*** tobiash has joined #openstack-nova09:12
*** xek has quit IRC09:12
*** xek has joined #openstack-nova09:14
*** hamalq has joined #openstack-nova09:21
*** hamalq has quit IRC09:26
*** derekh has joined #openstack-nova09:30
*** dlbewley has quit IRC09:30
*** dlbewley has joined #openstack-nova09:30
*** fumesover3 has joined #openstack-nova09:31
openstackgerritHervé Beraud proposed openstack/nova master: Remove elementtree deprecated methods  https://review.opendev.org/73747209:34
*** tetsuro has quit IRC09:39
*** udesale_ has joined #openstack-nova09:46
*** udesale has quit IRC09:49
*** markvoelker has joined #openstack-nova09:50
*** ratailor_ has joined #openstack-nova09:51
*** ratailor has quit IRC09:54
*** markvoelker has quit IRC09:55
*** dlbewley has quit IRC09:57
*** dlbewley has joined #openstack-nova09:57
*** jcath has quit IRC09:58
*** rpittau is now known as rpittau|bbl10:12
*** tkajinam has quit IRC10:17
*** Liang__ has quit IRC10:23
*** jhesketh has quit IRC10:36
*** jhesketh has joined #openstack-nova10:37
nightmare_unreala quick question can a cell have multiple compute nodes ?10:48
*** dlbewley has quit IRC10:49
*** dlbewley has joined #openstack-nova10:50
*** ttsiouts has quit IRC10:58
*** ttsiouts has joined #openstack-nova11:01
*** ociuhandu has quit IRC11:04
gibinightmare_unreal: yes a cell is a set of computes that has its own cell conductor, a cell db, and a cell message bus11:06
nightmare_unrealthanks gibi , I forgot some stuff/terms11:07
gibistephenfin: I have a question in https://review.opendev.org/#/c/737026/11:18
*** raildo has joined #openstack-nova11:18
*** xek has quit IRC11:20
stephenfingibi: I'll trade https://review.opendev.org/#/c/736964/611:22
gibistephenfin: thanks11:23
openstackgerritHervé Beraud proposed openstack/nova master: Remove lxml deprecated methods  https://review.opendev.org/73747211:30
*** jawad_axd has joined #openstack-nova11:43
nightmare_unrealhow can i get list of all compute nodes  in a cell ?11:47
*** lpetrut has joined #openstack-nova11:51
*** markvoelker has joined #openstack-nova11:52
*** markvoelker has quit IRC11:57
*** dlbewley has quit IRC11:59
gibinightmare_unreal: nova-manage cell_v2 list_hosts11:59
*** dlbewley has joined #openstack-nova12:00
nightmare_unrealYeah found it . I am now looking to do it programatically  is nova-manage part of python-novaclient ?12:01
gibinightmare_unreal: no. the cell is a deployment level thing, it is not exposed via the REST API12:08
*** damien_r has quit IRC12:09
*** dlbewley has quit IRC12:09
nightmare_unrealAh, okay !!12:09
*** dlbewley has joined #openstack-nova12:10
*** xek has joined #openstack-nova12:12
*** rpittau|bbl is now known as rpittau12:14
openstackgerritBalazs Gibizer proposed openstack/nova master: Prevent libvirt driver to start on non Linux platform  https://review.opendev.org/73750812:14
gibistephenfin: ^^12:15
openstackgerritDirk Mueller proposed openstack/nova master: Switch from unittest2 compat methods to Python 3.x methods  https://review.opendev.org/73751112:16
*** ociuhandu has joined #openstack-nova12:19
*** dlbewley has quit IRC12:19
*** dlbewley has joined #openstack-nova12:20
gibistephenfin: responeded in https://review.opendev.org/#/c/736964 I don't get your comment about st_blocks12:25
*** hamalq has joined #openstack-nova12:30
*** hamalq has quit IRC12:35
*** martinkennelly has quit IRC12:35
*** dlbewley has quit IRC12:36
*** damien_r has joined #openstack-nova12:37
*** dlbewley has joined #openstack-nova12:37
*** derekh has quit IRC12:40
*** derekh has joined #openstack-nova12:40
*** ratailor_ has quit IRC12:44
*** chenhaw has joined #openstack-nova12:45
*** chenhaw has quit IRC12:46
*** chenhaw has joined #openstack-nova12:46
*** hamalq has joined #openstack-nova12:46
*** efried has quit IRC12:51
*** hamalq has quit IRC12:51
*** grandchild has joined #openstack-nova12:52
*** efried has joined #openstack-nova12:54
*** nweinber has joined #openstack-nova12:54
*** dklyle has joined #openstack-nova12:58
*** dlbewley has quit IRC13:01
*** dlbewley has joined #openstack-nova13:01
stephenfingibi: Ah, ignore me: momentary lapse13:01
gibistephenfin: no worries. Thanks for reviewing13:07
*** sangeet has joined #openstack-nova13:10
*** jsuchome has quit IRC13:15
*** dlbewley has quit IRC13:15
*** dlbewley has joined #openstack-nova13:15
*** eharney has joined #openstack-nova13:16
*** sangeet has quit IRC13:18
*** bbowen has joined #openstack-nova13:21
*** dlbewley has quit IRC13:25
*** dlbewley has joined #openstack-nova13:26
*** markvoelker has joined #openstack-nova13:53
*** jsuchome has joined #openstack-nova13:53
*** markvoelker has quit IRC13:57
aarentsdansmith: Let me know if those changes are ok: https://review.opendev.org/#/c/736169/ https://review.opendev.org/#/c/734776/14:07
openstackgerritDan Smith proposed openstack/nova master: DNM: Try to make a glance multistore job  https://review.opendev.org/73418414:14
*** bnemec has quit IRC14:16
*** bnemec has joined #openstack-nova14:20
dansmithaarents: looks like it from a high level.. will try to get back to those today if I can14:25
aarentsdansmith: thks14:27
*** dave-mccowan has joined #openstack-nova14:30
sean-k-mooneydansmith: so based on https://review.opendev.org/#/c/737548/14:35
sean-k-mooneydansmith: are we only going to then copy the image if we own it14:35
sean-k-mooneyor do you intned to have nova fall back to admin credetials14:35
dansmithwe're only going to be allowed to copy it if we own it at the moment, and we should not copy it with admin credentials14:35
dansmithso basically, much less useful14:36
sean-k-mooneyya that is what i was worreid about14:36
sean-k-mooneybut it also makes sense14:36
dansmiththe argument is that the owner of the image, despite being viewable, is "charged" to the owner for each location14:36
dansmithalthough there isn't a resource usage report to convey this14:36
sean-k-mooneyyep14:36
dansmithit seems to me that if an image is made public, charging the owner for it doesn't make much sense,14:36
*** dlbewley has quit IRC14:36
sean-k-mooneythat is what i was wondering yesterday re billing14:37
*** dlbewley has joined #openstack-nova14:37
sean-k-mooneydansmith: the image can only be public if you are an admi14:37
dansmithI think this is a very leaky concept unfortunately14:37
sean-k-mooneycommuntiy images are also more or less public14:37
sean-k-mooneythose can be uploaded by non admins14:37
sean-k-mooneybut are not in the defualt image list i think14:38
dansmithso my example is that you own an image, you push it to a site, get charged for it being there, I boot an instance from it, you delete it from that store, but my instance is still backed, so I'm still consuming the space, although glance can't reflect that, so I get it for free14:38
dansmithit doesn't matter, if I can see an image I don't own, and can boot instances from it, then I can consume resources you're charged for14:38
*** mlavalle has joined #openstack-nova14:39
sean-k-mooneyya so that model does nto really work though14:39
sean-k-mooneyare you still chared for the glance image after its deleted14:39
*** markvoelker has joined #openstack-nova14:39
sean-k-mooneyif you have vms that were booted form it?14:39
sean-k-mooneythat seams like double billing14:39
dansmiththe question is whether *other* users have instances14:40
sean-k-mooneywell even if the dont14:40
dansmithI would hope that if you try to remove an image from a store, you fail if there are instances booted from it14:40
sean-k-mooneyif you upload an iamge boot a vm and delete the image14:40
sean-k-mooneyyou should not be changed for the iamge storage right14:40
dansmithwhich means if I push an image to an edge site and am charged for it, and someone *else* boots an image to pin it there, I can't delete it and stop being billed until this other user I don't know stops using it14:40
sean-k-mooneydansmith: removing a image in genrall we would not block removing an image form the store maybe14:41
dansmithin that case, we leak it and either have no way to delete it later, or have no way to charge it to anyone14:41
sean-k-mooneythe glance store concept is also problemeatinc in this regrad14:41
dansmithit's broken in one of three ways I think14:41
sean-k-mooneywell for the file backend once i boot a vm form it i dont need the glance copy right14:42
sean-k-mooneyfor the rbd backedn or cinder backend then that is different14:42
dansmithyeah, I'm talking about rbd or any other managed shared backend type14:42
sean-k-mooneybecause we are doing a shallow snapshot fo the new volume14:42
dansmithbut the copy-to-store functionality was added for this rbd edge case specifically14:43
sean-k-mooneybut i dont think i should be change for that backing volume since im paying for the space via the vm14:43
sean-k-mooneyand in the case where you use my iamge you are paying for the space with your image14:43
dansmiththat's another good point, I'm not sure how that works either..14:43
sean-k-mooneybecause without this we would have flatened it14:44
dansmithbasically, I thought image billing was done by just listing the images and counting up the image_size attributes, which would not include the multiple copies14:44
dansmithwhich I understand might not be right, in terms of actual bytes used14:44
*** markvoelker has quit IRC14:44
sean-k-mooneydansmith: that i assuemd would be the case too14:44
sean-k-mooneymulti sotre potentally changes that14:45
dansmithyeah14:45
sean-k-mooneybut i dont think it should nessisarly14:45
sean-k-mooneyis this something we would want to expose to an operator via a nova config option14:45
dansmithwell, one argument is you could be consuming 10x your image size in multiple stores, so I get that, but... it all breaks down somewhere if multiple users can see an image14:46
sean-k-mooneyso they could choie if we do the copy via admin or not or no14:46
dansmithI think what will have to happen is we will have some property on an image that determines if it's a public free-for-all image, and nova will only copy it if that attribute is set (or they are the owner)14:46
sean-k-mooneyit would have to be supported on shared, public and community images14:47
sean-k-mooneyshared are shared by adding other tenats to a member list14:47
sean-k-mooneycomunity is visable to everyone but only in the default image list if you are added to the image member-list14:47
dansmithI think it would be any image with that set, and then we'd use admin creds to copy it14:47
dansmithregardless of the sharing mode14:48
sean-k-mooneyya14:48
sean-k-mooneythat should work14:48
sean-k-mooneyi was wondigin if we need to chagne the error code however14:48
dansmithI don't like it because it means nova will never be able to decide if you can boot an image on a node until it is starting to build it14:48
dansmithsince only the compute node knows what rbd store it is connected to (without a lot more work)14:48
sean-k-mooneyso if glance should assert you are allows to copy it by virute fo being in the member list or not14:49
dansmithbut yeah, better than nothing14:49
sean-k-mooneydansmith: does this affct the ablity to boot on a node. i guess if we have that never donwlaod config?14:49
sean-k-mooneyotherwise we could fall back right14:49
sean-k-mooneyif we cant do an import and just flatten the image14:50
dansmithimport and flatten is never the answer14:50
sean-k-mooneywell that is what we woudl do today right14:50
dansmithyes14:50
dansmithnever the *right* answer I mean :)14:51
sean-k-mooney:)14:51
sean-k-mooneythe behavior of the new config option is to treate the need to flatten as an error right14:51
sean-k-mooneyleadign to a reshdule14:51
*** jawad_axd has quit IRC14:51
dansmithwell, (a) we never reschedule anymore, we consume one of the alternates, but (b) yes, the workaround makes it an error14:52
*** priteau has quit IRC14:52
sean-k-mooneydansmith: sorry yes you are  right about the alternive hosts14:52
sean-k-mooneydansmith: although that does cause issues for mutlicreate and anti affinity groups but thats another matter14:52
dansmithwe also can't download it and upload it as a new base and add it to the image as a location because... we don't own the image and if we did that as admin, we'd start charging the owner, which is a roundabout way to do what we could already do as admin14:53
sean-k-mooneydansmith: well i was not suggesting uplaoad as a new location14:53
sean-k-mooneyi ment jus tdo want we do today download it localy the stream it into the rbd volume14:54
sean-k-mooneywhich sucks because we loose copy on write14:54
dansmithno, I know, but that is never the right answer.. I'm saying we couldn't make nova do the slightly smarter thing of uploading it as a new base image14:54
sean-k-mooneydansmith: ah right14:54
dansmithimport and flatten means you consume N*size for N instances, which defeats the whole point and consumes a lot of expensive storage14:54
sean-k-mooneywell i think the image metadat property for allow_multistore_copy=true|false makes sense14:55
sean-k-mooneywhat would the default be. i would like it to be true but i guess it has to be false if not set14:55
dansmithI'm having a hard time understanding how "public" isn't a good enough flag to use, honestly14:56
dansmithunsure about shared/community, but.. public images for sure seem like they should be copyable14:57
sean-k-mooneyi guess its allow_admin_multistore_copy too rather then allow_multistore_copy14:57
sean-k-mooneyya so maybe it coudl be based on visablity14:57
sean-k-mooneye.g. the default14:57
sean-k-mooneyso true for public by defualt not sure baout shared or commuity iehter14:57
sean-k-mooneyshared i would be tempetd to say false by default and comunnity false would be conservitive but true might make sense14:59
sean-k-mooneydansmith: the other angel to this is geofenceing15:00
sean-k-mooneydansmith: moving it to another store might move it to another geo which may be an export violation altough in the curent case we do that indirectly so not sure it a problem or not15:00
dansmiththat's a glance policy enforcement problem separate from this I think15:01
*** dlbewley has quit IRC15:01
sean-k-mooneyya i think so too15:01
*** dlbewley has joined #openstack-nova15:02
sean-k-mooneyok i better go get some work done. thanks for bring me up to speed o/15:02
dansmithyup15:03
*** owalsh_ is now known as owalsh15:07
*** belmoreira has quit IRC15:09
*** artom has joined #openstack-nova15:12
*** dlbewley has quit IRC15:21
*** dlbewley has joined #openstack-nova15:22
*** _mlavalle_1 has joined #openstack-nova15:23
*** mlavalle has quit IRC15:25
*** JamesBenson has joined #openstack-nova15:26
*** hamalq has joined #openstack-nova15:28
*** links has quit IRC15:30
*** dlbewley has quit IRC15:32
*** mriedem has joined #openstack-nova15:36
*** lpetrut has quit IRC15:44
*** maciejjozefczyk has quit IRC15:50
*** hamalq has quit IRC15:55
*** hamalq has joined #openstack-nova15:55
*** hamalq_ has joined #openstack-nova15:57
*** gyee has joined #openstack-nova15:59
*** rpittau is now known as rpittau|afk16:00
*** hamalq has quit IRC16:00
*** ociuhandu_ has joined #openstack-nova16:09
gibipublic announcement: I will be off tomorrow but will be back on Thurstday16:11
*** gibi is now known as gibi_off16:11
sean-k-mooneygibi_off: enjoy16:12
gibi_offsean-k-mooney: thanks16:12
*** ociuhandu has quit IRC16:12
*** ociuhandu_ has quit IRC16:14
*** mgoddard has quit IRC16:15
*** dave-mccowan has quit IRC16:17
*** ociuhandu has joined #openstack-nova16:19
*** mgoddard has joined #openstack-nova16:21
*** ociuhandu has quit IRC16:23
*** dave-mccowan has joined #openstack-nova16:27
*** dtantsur is now known as dtantsur|afk16:29
*** markvoelker has joined #openstack-nova16:40
*** markvoelker has quit IRC16:45
*** udesale_ has quit IRC17:05
*** spatel has joined #openstack-nova17:09
*** ircuser-1 has joined #openstack-nova17:15
*** derekh has quit IRC17:15
*** ociuhandu has joined #openstack-nova17:18
sean-k-mooneyefried: not sure if you are about but do you know if there is any reason we have not made provider trees or proviers to be iterable over there childeren?17:23
sean-k-mooneyi know that is not stirctly need but it would be nice to be able to pretty print them and it makes some operation nicer17:24
*** factor has quit IRC17:25
efriedYes, there's a function to iterate over them in order. We use it in the master update_provider_tree loop.17:25
sean-k-mooneyefried: oh ok we just did not implement __iter__17:26
efriedI would believe that.17:26
efriedIt recently came up here: https://review.opendev.org/#/c/719163/18/nova/scheduler/client/report.py17:26
sean-k-mooneythat gives use the provider uuids but not the provider objects but ok i was looking at that17:27
*** ralonsoh has quit IRC17:28
sean-k-mooneyefried: thanks im trying to think how i will go about the transfroamtion for modeling nuam in placement and i want a nice way to visualise the tree17:28
*** mgariepy has quit IRC17:28
openstackgerritStephen Finucane proposed openstack/nova master: hardware: Invert order of NUMA topology generation  https://review.opendev.org/71470117:32
openstackgerritStephen Finucane proposed openstack/nova master: hardware: Remove '_numa_fit_instance_cell_with_pinning'  https://review.opendev.org/71470317:32
openstackgerritStephen Finucane proposed openstack/nova master: hardware: Allow 'hw:cpu_realtime_mask' to be omitted  https://review.opendev.org/73702617:32
openstackgerritStephen Finucane proposed openstack/nova master: hardware: Tweak the 'cpu_realtime_mask' handling slightly  https://review.opendev.org/46145617:32
efriedI thought gibi_off wrote some kind of tool to prettyprint those trees.17:33
sean-k-mooneymaybe17:33
efriedI don't have it in front of me, but looking provider_tree.py for that iterator function.17:33
efriedIt's not __iter__ but I'm pretty sure I made a getter that gives them to you in a predictable order.17:33
sean-k-mooneyit looks like its doing a depth frist traversal from the root with childern lexically sorted by uuid17:33
sean-k-mooneyefried: ya its fine ill figure it out. i might make it iterable jsut to make it spelper and immperment __repr__ for provier17:35
sean-k-mooney*simpler and implement17:35
*** mgariepy has joined #openstack-nova17:41
*** xek_ has joined #openstack-nova17:46
*** xek has quit IRC17:48
*** ttsiouts has quit IRC17:51
sean-k-mooneyefried: so ya i just need to add17:51
sean-k-mooney   def __iter__(self):17:51
sean-k-mooney        for uuid in self.get_provider_uuids():17:51
sean-k-mooney            yield self._find_with_lock(uuid)17:51
*** ttsiouts has joined #openstack-nova17:52
sean-k-mooneybut i might invert the logic an make get_provier_uuids use the iterator17:52
sean-k-mooneyit would avoid the need to call fine_with_lock twice once in get_provier_uuids and then again in the iterator17:53
sean-k-mooneythanks for the pointer17:53
*** markvoelker has joined #openstack-nova17:54
*** xiaolin has quit IRC17:59
*** markvoelker has quit IRC17:59
efriedsean-k-mooney: feel free to add me to review if you spin up something there.18:01
efriedHere's where that thing is used https://github.com/openstack/nova/blob/f1ebc15dfc8ffb7f23b2cb9879f0ca9376931a90/nova/scheduler/client/report.py#L1348-L1349 (and IIRC the reason it was written)18:03
efriedso whatever you change, please keep in mind that that ^ is going to run every periodic -- so don't slow it down too much :P18:03
sean-k-mooneyya it should not be any slower18:04
*** tesseract has quit IRC18:05
sean-k-mooneybut sure ill add you to the review18:05
stephenfinmelwitt: could you hit this trivial requirements patch, please https://review.opendev.org/#/c/730960/ ?18:07
*** markvoelker has joined #openstack-nova18:11
*** markvoelker has quit IRC18:15
*** ttsiouts has quit IRC18:16
*** ttsiouts has joined #openstack-nova18:17
*** markvoelker has joined #openstack-nova18:21
*** ttsiouts has quit IRC18:22
openstackgerritsean mooney proposed openstack/nova master: [WIP] make provider tree and proviers iterable  https://review.opendev.org/73759418:25
sean-k-mooneyefried: that is the version where i have not inverted the logic ^18:25
sean-k-mooneywhich im testign with http://paste.openstack.org/show/795116/18:25
*** spatel has quit IRC18:29
sean-k-mooneywhich if i execute it looks like this http://paste.openstack.org/show/795117/18:29
efried++18:31
*** markvoelker has quit IRC18:31
sean-k-mooneyi should be able to make the provider tee actully do indenting too but that the quick hack for now18:32
*** nightmare_unreal has quit IRC18:44
*** jawad_axd has joined #openstack-nova18:50
*** ebbex has quit IRC19:00
*** ebbex has joined #openstack-nova19:02
*** jsuchome has quit IRC19:06
*** lseki has joined #openstack-nova19:07
*** lbragstad has quit IRC19:14
*** ebbex has quit IRC19:16
*** ebbex has joined #openstack-nova19:17
*** lbragstad has joined #openstack-nova19:21
melwittgmann: did you see the author's reply on this patch? https://review.opendev.org/#/c/730960/1//COMMIT_MSG@919:22
gmannmelwitt: checking19:22
gmannmelwitt: i forgot to test it locally and if any things we need to adjust from jsonschema FormatChecker. let me do it and review again. thanks for reminder19:27
melwittgmann: sweet thanks19:27
melwittstephenfin: gmann is gonna review ^ again, there was a local test he wanted to do19:29
*** spatel has joined #openstack-nova20:15
spatelsean-k-mooney: hey!20:15
*** xek_ has quit IRC20:24
*** markvoelker has joined #openstack-nova20:25
*** rchurch has quit IRC20:28
*** markvoelker has quit IRC20:29
*** nweinber has quit IRC20:30
*** rchurch has joined #openstack-nova20:30
*** vishalmanchanda has quit IRC20:54
*** spatel has quit IRC21:29
*** factor has joined #openstack-nova21:42
*** mriedem has left #openstack-nova21:44
*** lbragstad has quit IRC21:50
*** damien_r has quit IRC22:33
*** artom has quit IRC22:41
*** tosky has quit IRC22:42
*** tkajinam has joined #openstack-nova22:53
*** _mlavalle_1 has quit IRC22:56
*** rcernin has joined #openstack-nova23:02
*** ttsiouts has joined #openstack-nova23:05
*** rcernin has quit IRC23:08
*** rcernin has joined #openstack-nova23:08
*** ttsiouts has quit IRC23:10
*** markvoelker has joined #openstack-nova23:29
*** markvoelker has quit IRC23:34
*** raildo has quit IRC23:35
*** ttsiouts has joined #openstack-nova23:43
« Monday, 2020-06-22 Index Wednesday, 2020-06-24 »

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!