Wednesday, 2020-07-15

*** ccamacho has quit IRC00:01
*** tetsuro has joined #openstack-nova00:09
*** tetsuro_ has joined #openstack-nova00:10
*** tetsuro has quit IRC00:13
*** avolkov has quit IRC00:35
*** gyee has quit IRC00:36
*** k_mouza has joined #openstack-nova00:51
*** k_mouza has quit IRC00:56
*** k_mouza has joined #openstack-nova00:58
*** k_mouza has quit IRC01:04
melwittmnaser: I implemented a re-architecting of quotas in pike, which began counting quota usage on-the-fly by counting resources (this only does a read). prior to pike, we did do the select-for-update locking thing01:09
*** huaqiang has quit IRC01:18
*** k_mouza has joined #openstack-nova01:27
*** k_mouza has quit IRC01:31
*** mriedem has left #openstack-nova02:01
*** spatel has joined #openstack-nova02:10
*** Yumeng has joined #openstack-nova02:18
*** sapd__x has joined #openstack-nova02:20
openstackgerritJeffrey Zhang proposed openstack/nova master: Support inject-nmi action in watchdog  https://review.opendev.org/74107202:26
*** tetsuro_ has quit IRC02:40
*** spatel has quit IRC02:49
*** rcernin has quit IRC02:56
*** mkrai has joined #openstack-nova02:57
*** rcernin has joined #openstack-nova02:57
*** ociuhandu has joined #openstack-nova03:01
*** ociuhandu has quit IRC03:06
*** brinzhang0 has joined #openstack-nova03:15
openstackgerritMerged openstack/nova master: doc: Correct typo  https://review.opendev.org/74067003:18
*** brinzhang_ has quit IRC03:18
*** brinzhang has joined #openstack-nova03:19
*** spatel has joined #openstack-nova03:22
*** spatel has quit IRC03:22
*** brinzhang0 has quit IRC03:22
*** spatel has joined #openstack-nova03:23
*** spatel has quit IRC03:23
*** spatel has joined #openstack-nova03:30
*** spatel has quit IRC03:30
openstackgerritKeigo Noha proposed openstack/nova master: Change default num_retries for glance to 3  https://review.opendev.org/74038903:32
*** redrobot has quit IRC03:36
*** psachin has joined #openstack-nova03:39
*** brinzhang_ has joined #openstack-nova03:41
*** brinzhang has quit IRC03:44
*** k_mouza has joined #openstack-nova03:44
*** k_mouza has quit IRC03:48
*** brinzhang0 has joined #openstack-nova04:03
*** brinzhang_ has quit IRC04:05
*** yaawang has quit IRC04:10
*** markvoelker has joined #openstack-nova04:11
*** yaawang has joined #openstack-nova04:11
*** sapd__x has quit IRC04:12
*** markvoelker has quit IRC04:15
*** evrardjp has quit IRC04:33
*** evrardjp has joined #openstack-nova04:33
*** ratailor has joined #openstack-nova04:47
*** vishalmanchanda has joined #openstack-nova04:50
*** sapd__x has joined #openstack-nova04:58
*** markvoelker has joined #openstack-nova05:01
*** markvoelker has quit IRC05:05
*** links has joined #openstack-nova05:11
*** k_mouza has joined #openstack-nova05:13
*** brinzhang_ has joined #openstack-nova05:16
*** yaawang has quit IRC05:16
*** yaawang has joined #openstack-nova05:16
*** k_mouza has quit IRC05:18
*** brinzhang0 has quit IRC05:18
*** brinzhang0 has joined #openstack-nova05:21
*** udesale has joined #openstack-nova05:22
*** brinzhang_ has quit IRC05:24
*** ratailor has quit IRC05:27
*** ratailor has joined #openstack-nova05:27
*** bbowen has quit IRC05:32
*** bbowen has joined #openstack-nova05:34
openstackgerritJeffrey Zhang proposed openstack/nova master: Support inject-nmi action in watchdog  https://review.opendev.org/74107205:38
*** brinzhang_ has joined #openstack-nova05:40
*** brinzhang0 has quit IRC05:43
*** udesale has quit IRC06:07
*** bbowen has quit IRC06:17
*** udesale has joined #openstack-nova06:20
openstackgerritJie Li proposed openstack/nova-specs master: add volume backed server rebuild spec  https://review.opendev.org/73934906:22
*** yaawang has quit IRC06:26
*** yaawang has joined #openstack-nova06:27
*** bbowen has joined #openstack-nova06:29
*** dklyle has quit IRC06:35
*** ralonsoh has joined #openstack-nova06:48
*** takamatsu has quit IRC06:59
*** damien_r has joined #openstack-nova07:00
*** tesseract has joined #openstack-nova07:01
*** damien_r has quit IRC07:04
*** rcernin has quit IRC07:07
*** k_mouza has joined #openstack-nova07:09
*** jsuchome has joined #openstack-nova07:11
*** mkrai has quit IRC07:13
*** damien_r has joined #openstack-nova07:13
*** k_mouza has quit IRC07:13
*** ociuhandu has joined #openstack-nova07:17
*** happyhemant has joined #openstack-nova07:17
*** rcernin has joined #openstack-nova07:17
*** k_mouza has joined #openstack-nova07:18
*** k_mouza has quit IRC07:22
*** damien_r has quit IRC07:23
*** damien_r has joined #openstack-nova07:24
*** ociuhandu_ has joined #openstack-nova07:28
*** ociuhandu has quit IRC07:31
*** nightmare_unreal has joined #openstack-nova07:35
*** dtantsur|afk is now known as dtantsur07:45
*** tosky has joined #openstack-nova07:46
*** udesale has quit IRC07:47
*** udesale has joined #openstack-nova07:47
*** elod_off is now known as elod07:51
*** k_mouza has joined #openstack-nova07:54
*** maciejjozefczyk has joined #openstack-nova07:56
*** k_mouza has quit IRC07:59
*** k_mouza has joined #openstack-nova08:03
*** markvoelker has joined #openstack-nova08:12
*** avolkov has joined #openstack-nova08:12
*** markvoelker has quit IRC08:17
*** xek has joined #openstack-nova08:23
*** yaawang has quit IRC08:24
*** rcernin has quit IRC08:27
*** yaawang has joined #openstack-nova08:31
*** tetsuro has joined #openstack-nova08:31
*** ociuhandu_ has quit IRC08:33
*** ociuhandu has joined #openstack-nova08:33
*** tetsuro has quit IRC08:35
*** derekh has joined #openstack-nova08:36
*** bhagyashris is now known as bhagyashris|lunc08:43
*** mkrai has joined #openstack-nova08:45
*** ccamacho has joined #openstack-nova08:47
*** rcernin has joined #openstack-nova08:48
openstackgerritHuaqiang Wang proposed openstack/nova master: hardware: Enable 'hw:cpu_dedicated_mask' for creating a mixed instance  https://review.opendev.org/71470608:50
*** mkrai has quit IRC09:03
*** mkrai has joined #openstack-nova09:03
*** alex_xu has joined #openstack-nova09:13
*** rcernin has quit IRC09:17
*** martinkennelly has joined #openstack-nova09:17
*** mkrai has quit IRC09:58
*** mkrai has joined #openstack-nova10:05
*** happyhemant has quit IRC10:07
*** k_mouza has quit IRC10:07
*** k_mouza has joined #openstack-nova10:10
*** dpaclt has joined #openstack-nova10:13
dpacltHi All  I am unable to launch new vms .. http://paste.openstack.org/show/795937/ ..Anyone please suggest10:13
lyarwooddpaclt: this isn't a support channel but grep for the req-4ce3ba68-34f8-453c-bb2a-9be9ef9adcbd id across the api/scheduler/conductor logs and you should see why all of your hosts are unable to schedule the instance10:15
lyarwoodelod: https://review.opendev.org/#/c/732717/ (and the two under it) is finally ready btw if you have time today10:18
dpacltThanks lyarwood10:19
*** damien_r has quit IRC10:19
*** Yumeng has quit IRC10:24
*** yaawang has quit IRC10:24
*** yaawang has joined #openstack-nova10:25
*** dpaclt has left #openstack-nova10:27
*** jraju__ has joined #openstack-nova10:29
*** links has quit IRC10:30
*** mvkr has quit IRC10:34
*** bhagyashris|lunc is now known as bhagyashris10:37
elodlyarwood: sure, added to my TODOs :)10:44
lyarwoodthanks!10:45
openstackgerritMerged openstack/nova master: objects: Introduce 'pcpuset' field for InstanceNUMACell  https://review.opendev.org/71465810:49
*** martinkennelly has quit IRC10:51
*** tosky has quit IRC11:05
*** martinkennelly has joined #openstack-nova11:07
*** tosky has joined #openstack-nova11:10
*** martinkennelly has quit IRC11:18
*** sapd__x has quit IRC11:22
*** ccamacho has quit IRC11:29
*** rcernin has joined #openstack-nova11:31
*** udesale_ has joined #openstack-nova11:31
*** udesale has quit IRC11:34
*** rcernin has quit IRC11:47
openstackgerritElod Illes proposed openstack/nova stable/queens: Add functional test for bug 1550919  https://review.opendev.org/73271512:01
openstackbug 1550919 in OpenStack Compute (nova) queens "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Lee Yarwood (lyarwood)12:01
openstackgerritElod Illes proposed openstack/nova stable/queens: libvirt: Fix misleading debug msg "Instance is running"  https://review.opendev.org/73271612:01
*** mkrai has quit IRC12:03
*** damien_r has joined #openstack-nova12:04
*** mgariepy has joined #openstack-nova12:09
openstackgerritElod Illes proposed openstack/nova stable/queens: libvirt: Don't delete disks on shared storage during evacuate  https://review.opendev.org/73271712:10
jsuchomegibi: hi, could you take another look at https://review.opendev.org/#/c/738738/ ?12:16
*** tkajinam has quit IRC12:24
*** devfaz has joined #openstack-nova12:26
*** martinkennelly has joined #openstack-nova12:26
devfazHi, is this a bug or known. If I try to disable an nova-compute service of a system terminated just seconds ago I get a trace with "An error occurred while updating the COMPUTE_STATUS_DISABLED trait on compute node resource providers managed by host XX. The trait will be synchronized automatically by the compute service when the update_available_resource periodic task runs" and rabbitmq-msgid timeout.12:27
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.PY2 and six.PY3  https://review.opendev.org/72651212:27
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.add_metaclass  https://review.opendev.org/72656512:27
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.reraise  https://review.opendev.org/72689812:28
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.moves  https://review.opendev.org/72722412:28
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.iteritems/itervalues/iterkeys  https://review.opendev.org/72775712:29
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.byte2int/int2byte  https://review.opendev.org/72777712:29
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.binary_type/integer_types/string_types  https://review.opendev.org/72809412:29
*** vapjes has joined #openstack-nova12:35
*** ratailor has quit IRC12:38
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.text_type (1/2)  https://review.opendev.org/72810912:40
*** martinkennelly has quit IRC12:53
*** ccamacho has joined #openstack-nova12:55
*** ccamacho has quit IRC12:56
*** ccamacho has joined #openstack-nova12:57
*** ccamacho has quit IRC12:58
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.text_type (2/2)  https://review.opendev.org/72811713:00
lyarwooddansmith: https://bugs.launchpad.net/nova/+bug/1858667 - I'm hitting this odd locking issue in some func tests, this smells like some behaviour has changed in py38 tbh but I'm having a hard time pinning it down. Would you be able to take a look?13:02
openstackLaunchpad bug 1858667 in OpenStack Compute (nova) "TestMultiCellMigrate.test_poll_unconfirmed_resizes_with_(no_)upcall race failing with greenlet error: Error auto-confirming resize: Reader <greenlet.greenlet object at 0x7f55c19dd048> to writer privilege escalation not allowed. Will retry later." [Undecided,Confirmed]13:02
*** brinzhang_ has quit IRC13:17
lyarwoodmelwitt: ^ also if you have any time, I'm not even sure why we are wrapping target_cell if I'm honest13:21
lyarwoodCELL_CACHE is the only global thing I can see?13:21
dansmithlyarwood: the entire DB state is global, which is what the lock is protecting13:30
dansmithlyarwood: your python REPL examples aren't representative I think because the lock grabbing is serial in the code, yet you're nesting them (I think, without indentation)13:31
*** artom has joined #openstack-nova13:31
dansmithI'm not sure what the references to fasteners has to do with this, as we're using regular python.threading locks, IIRC13:32
dansmithif I had to guess, I'd say maybe we're recursing on the lock somewhere, i.e. targeting the cell and then calling something that targets the cell again?13:35
dansmithah lockutils uses fasteners, I see13:35
lyarwooddansmith: yeah sorry back13:35
lyarwooddansmith: and yeah I did use indentation, launchpad-- just removed it for some reason13:35
lyarwooddansmith: but yes my examples are bogus given what is actually being called13:36
dansmithack13:36
lyarwooddansmith: I just hit the error and got carried away :)13:36
dansmithis that in a periodic? poll unconfirmed resizes?13:37
dansmithI may be making this up, but I think melwitt might have added something much later than this to make the periodics run targeted to the right cell, so maybe that's where the conflict is here... this is now getting lucky and running a periodic when we previously didn't need to change the target or something13:38
lyarwoodyeah13:38
*** Guest14648 has joined #openstack-nova13:43
*** Guest14648 is now known as redrobot13:45
*** ftarasenko has joined #openstack-nova13:46
masterpeI try to live migrate a instance, but I get the message in the controller: "Unable to find record for source node compute40.domain.tld on compute48"13:48
masterpebut compute40 is incorrect13:48
masterpeWhat is wrong?13:49
sean-k-mooneythat looks like maybe the instace.host is wrong13:56
sean-k-mooneywhich can happen if you have previous failed migrations in post live migrate13:56
sean-k-mooneybut im not sure13:57
sean-k-mooneymasterpe: i would check that the vm is actully on the host nova thinks its on13:58
*** jangutter has quit IRC13:59
*** jangutter has joined #openstack-nova13:59
*** jangutter has quit IRC13:59
*** Liang__ has joined #openstack-nova13:59
*** Liang__ is now known as LiangFang13:59
*** jangutter has joined #openstack-nova14:00
masterpeIf I do a openstack server show instanceID:14:05
masterpeOS-EXT-SRV-ATTR:host                | compute4814:05
masterpeOS-EXT-SRV-ATTR:hypervisor_hostname | compute40.domain.tld14:05
openstackgerritHuaqiang Wang proposed openstack/nova master: compute: bump nova-compute version and check in API  https://review.opendev.org/74093314:08
openstackgerritHuaqiang Wang proposed openstack/nova master: hardware: create 'mixed' instance for realtime and shared CPUs  https://review.opendev.org/72848514:08
*** huaqiang has joined #openstack-nova14:09
masterpesean-k-mooney: How to correct this? I have try to do a "update instances set node = 'compute48.domain.tld' where uuid = 'e848a42b-a7b2-4885-a290-34da7beb98ad';"14:10
masterpeBut that did not solve it14:11
masterpeis is active on compute4814:16
sean-k-mooneyyou should not change that14:17
sean-k-mooneyactully that is strang14:17
sean-k-mooneywhat hypervior are you using14:18
masterpeqemu with kvm14:19
sean-k-mooneyok in that cas esthe host and hypervior host should start the same14:23
sean-k-mooneydid you rename the host in the nova config?14:24
sean-k-mooneyor chage its hostname at any point14:24
masterpethe hostname is not nova.conf14:24
*** mriedem has joined #openstack-nova14:25
masterpeno14:25
sean-k-mooneyok so you dont have host=compute48 https://github.com/openstack/nova/blob/master/nova/conf/netconf.py#L52-L5614:26
sean-k-mooneywhat is the actul host name currently14:26
sean-k-mooneyis it compute40 of compute 4814:26
*** efried has quit IRC14:31
*** mlavalle has joined #openstack-nova14:32
masterpecommand: hostnamectl status, gives Static hostname: compute4814:33
masterpeand /etc/hosts has 127.0.1.1 compute48.domain.tld compute48 & 10.8.1.48 compute48.domain.tld compute4814:35
*** efried has joined #openstack-nova14:36
*** dklyle has joined #openstack-nova14:36
masterpenova-compute --version is on 19.1.114:38
*** efried has quit IRC14:40
*** dave-mccowan has quit IRC14:43
masterpeWhen I create a new instance on that compute all is fine14:46
*** dave-mccowan has joined #openstack-nova14:47
lyarwooddansmith: as you thought https://review.opendev.org/#/c/699291/7/nova/compute/api.py@3702 is the issue in that change, the failing tests are calling target_cell when running the _poll_unconfirmed_resizes periodic https://github.com/openstack/nova/blob/1fa6799e4171d7c93f4d6330f2437891733d7d27/nova/tests/functional/test_cross_cell_migrate.py#L988-L991 resulting in the reader to writer error.14:50
openstackgerritArtom Lifshitz proposed openstack/nova master: Handle Neutron errors in _post_live_migration()  https://review.opendev.org/72976314:51
openstackgerritArtom Lifshitz proposed openstack/nova master: Add regression test for bug 1879787  https://review.opendev.org/74123014:51
openstackbug 1879787 in OpenStack Compute (nova) "post_live_migration does not handle Neutron errors" [Medium,In progress] https://launchpad.net/bugs/1879787 - Assigned to Artom Lifshitz (notartom)14:51
*** efried has joined #openstack-nova14:51
dansmithlyarwood: ah yep14:51
lyarwooddansmith: is there anyway of checking if a context is already correctly targetted at a cell?14:57
lyarwoodactually nvm _get_source_compute_service doesn't have any other callers I can just mock it14:57
dansmithyes, but it would be better to arrange for that not to happen I think, because if that gets called from a compute node it won't be able to target because it won't have api/connection14:58
*** mkrai has joined #openstack-nova15:09
*** LiangFang has quit IRC15:10
*** jraju__ has quit IRC15:12
*** bbowen has quit IRC15:15
openstackgerritLee Yarwood proposed openstack/nova master: Ensure source compute is up when confirming a resize  https://review.opendev.org/69929115:16
*** bbowen has joined #openstack-nova15:18
dansmithlyarwood: you were only seeing the failure in your change there?15:20
lyarwooddansmith: I am, however Matt had already created this bug a while ago.15:22
* lyarwood checks what he actually saw it against15:22
lyarwooddansmith: ah it's the same change15:22
dansmithyeah, but presumably that bug was just for the periodic not working, right?15:22
lyarwooddansmith: so we can close this out15:22
lyarwooddansmith: it's the same test failure15:23
dansmithI'm foncused15:24
dansmithyou filed a bug for the target recursion15:24
melwittre: the earlier mention, I didn't add anything to target cell in periodics. I did briefly work on trying to get periodics to re-use a same RequestContext every time (so that request-id stays consistent in logs) but never finished it15:24
melwittso that might be what you were thinking of15:25
dansmithmelwitt: oh I thought you had done something specific to the targeting, although maybe that re-used context would have made them pre-targeted to the right cell?15:25
dansmithlyarwood: did you see that target recursion anywhere other than on matt's change to the periodic?15:26
lyarwooddansmith: mriedem created https://bugs.launchpad.net/nova/+bug/1858667 a while ago that I referenced in my first ping, I missed that it only documents this failure in this unmerged change.15:26
openstackLaunchpad bug 1858667 in OpenStack Compute (nova) "TestMultiCellMigrate.test_poll_unconfirmed_resizes_with_(no_)upcall race failing with greenlet error: Error auto-confirming resize: Reader <greenlet.greenlet object at 0x7f55c19dd048> to writer privilege escalation not allowed. Will retry later." [Undecided,Confirmed]15:26
dansmithah, heh okay gotcha15:26
*** huaqiang has quit IRC15:26
dansmithoh, I didn't realize that bug was old, I thought you had just filed it15:27
melwittI don't think so, I don't remember doing anything related to periodics and targeting. and the re-using context thing I never finished and it never landed15:27
dansmithmelwitt: okay15:27
melwittwhat's interesting is that you'd think this would always happen... because generally nova-api will set_target_cell and then the CheatingSerializer will pass it on to nova-compute already targeted, and generally we have used 'with target_cell' to run periodics15:28
*** huaqiang has joined #openstack-nova15:29
dansmithwe can't use target_cell for periodics at least in reality because we don't (always) have the api db creds to be able to look up a mapping15:29
*** JamesBenson has joined #openstack-nova15:29
melwittright, I mean in func tests only15:29
dansmithor do you mean in tests where we poke them.. okay15:29
dansmithwell, it only matters when the periodic makes a call to something that calls target a second time15:30
dansmithwhich should never happen,15:30
melwittI'm just saying if it's a problem to 'with target_cell' on something that has already set_target_cell then lots of stuff should be failing all the time I'd think. surprising that it's only sometimes15:30
dansmithbecause periodics need to be calling compute-only code that assume the local cell15:30
dansmithit's not a problem with target_cell, it's a problem of calling code that calls target_cell from on the compute node I think15:31
melwittoh, I see, periodic is calling something that does a target_cell? I wonder why it's even doing that15:31
dansmithwell,15:31
dansmithit's only that one change,15:31
dansmithand it's for auto-confirming a cross-cell migration :)15:31
*** hamalq has joined #openstack-nova15:31
melwittI see, re-using (calling) a utility function that's normally only called by non nova-compute I guess?15:32
melwittI guess I could just look :P /me looks15:32
dansmithexactly15:33
melwitthuh, no it's not doing anything like that. mysterious ...15:33
dansmithit's adding code that calls target15:34
*** hamalq_ has joined #openstack-nova15:34
melwittin nova/compute/api.py confirm_resize method15:34
dansmithright, which is called by the periodic right?15:35
melwittmust be... I guess I hadn't expected a nova-compute periodic calling something in nova.compute.API? but it must be I guess15:35
dansmithwe do that in places15:36
dansmithlike we call compute.api.stop_instance9)15:36
dansmithand such15:36
melwittyeah, true15:36
dansmithwe probably shouldn't, but we've done that for a long time since before it mattered15:36
dansmithideally we'd have an inner method for "assume you're targeted or don't need to" that compute-specific code always calls, and then the compute "external" API just targets and then calls those things15:37
melwittyup there it is https://github.com/openstack/nova/blob/1fa6799e4171d7c93f4d6330f2437891733d7d27/nova/compute/manager.py#L909315:37
dansmithunmysterious :)15:37
melwittMYSTERY SOLVED15:37
*** hamalq has quit IRC15:38
*** martinkennelly has joined #openstack-nova15:40
dansmithsean-k-mooney: IIRC, we have some local hook mechanism we use for checking the devstack deployment, maybe after tempest runs? we used to (or still do) run db archiving I think.. is that still a thing?15:52
dansmithoh, is that post-run?15:54
melwitthttps://github.com/openstack/nova/blob/master/gate/post_test_hook.sh ?15:54
*** k_mouza has quit IRC15:55
melwittonly run by certain jobs https://github.com/openstack/nova/search?q=post_test_hook&unscoped_q=post_test_hook15:56
melwittnova-next, nova-live-migration, nova-grenade-multinode15:57
dansmithah yeah, but what runs that?15:57
dansmithor is that baked into d-g?15:57
melwittactually maybe it's only nova-next. I don't understand what the other two are doing15:58
melwittit appears you run it by specifying this role in the post.yaml for the job https://github.com/openstack/nova/blob/89e65bd976be8e02fdb6932bb710b5165d7e00a3/playbooks/nova-next/post.yaml15:58
melwittand the role is defined here https://github.com/openstack/nova/blob/89e65bd976be8e02fdb6932bb710b5165d7e00a3/roles/run-post-test-hook/tasks/main.yaml15:59
dansmithum,15:59
dansmithbut something has to tell the nova-next job to run that post.yaml right?15:59
melwittoh, yeah. that would be something in infra16:00
melwittI don't know which thing16:00
melwittmaybe it is d-g16:00
openstackgerritLee Yarwood proposed openstack/nova master: compute: Validate a BDMs disk_bus when provided  https://review.opendev.org/72484216:01
*** mkrai has quit IRC16:07
sean-k-mooneydansmith: we used to in devstack gate yes16:08
sean-k-mooneya post job would be the zuuv3 way16:08
sean-k-mooney*playbook16:09
sean-k-mooneydansmith: this used to be defiend project-config16:11
sean-k-mooneywhich hook to run16:11
sean-k-mooneybut i think it got moved in repo a long time ago16:11
*** k_mouza has joined #openstack-nova16:11
sean-k-mooneydansmith: melwitt we used to do something like this https://review.opendev.org/#/c/701051/1/playbooks/legacy/tempest-dsvm-networking-ovs-dpdk/run.yaml@a5816:14
sean-k-mooneywe defiend a pre_test_hook or post_test_hook function16:15
sean-k-mooneywhich was invoked by devstack gate if it existed16:15
*** k_mouza has quit IRC16:16
sean-k-mooneywe still do that for the grenate multi node https://github.com/openstack/nova/blob/master/playbooks/legacy/nova-grenade-multinode/run.yaml#L57-L6016:16
*** maciejjozefczyk has quit IRC16:18
sean-k-mooneyi may have missed the point of your question16:19
sean-k-mooneydansmith: did any of ^ help16:19
dansmithsean-k-mooney: on a call, biab16:20
sean-k-mooneycrap im ment to be on a call too i thnk16:20
*** mgariepy has quit IRC16:22
*** k_mouza has joined #openstack-nova16:24
*** k_mouza has quit IRC16:24
*** k_mouza has joined #openstack-nova16:24
*** k_mouza has quit IRC16:29
openstackgerritMerged openstack/nova stable/ussuri: catch libvirt exception when nodedev not found.  https://review.opendev.org/73959316:34
*** ociuhandu_ has joined #openstack-nova16:36
*** udesale_ has quit IRC16:38
*** ociuhandu has quit IRC16:39
*** ociuhandu_ has quit IRC16:40
*** psachin has quit IRC16:58
*** bbowen has quit IRC17:00
*** derekh has quit IRC17:00
*** mgariepy has joined #openstack-nova17:09
*** dtantsur is now known as dtantsur|afk17:18
openstackgerritMerged openstack/nova stable/ussuri: Correct reported system memory  https://review.opendev.org/74066617:24
openstackgerritStephen Finucane proposed openstack/nova master: Add emulated TPM support to Nova  https://review.opendev.org/63136317:29
openstackgerritStephen Finucane proposed openstack/nova master: WIP: Add support for resize and cold migration of emulated TPM files  https://review.opendev.org/63993417:29
openstackgerritStephen Finucane proposed openstack/nova master: docs: Add docs for vTPM support  https://review.opendev.org/73921317:29
openstackgerritStephen Finucane proposed openstack/nova master: tests: Move single use constants to their callers  https://review.opendev.org/74128017:29
openstackgerritStephen Finucane proposed openstack/nova master: tests: Define constants in '_IntegratedTestBase'  https://review.opendev.org/74128117:29
openstackgerritStephen Finucane proposed openstack/nova master: tests: Remove 'test_servers.ServersTestBase'  https://review.opendev.org/74128217:29
openstackgerritStephen Finucane proposed openstack/nova master: tests: Add 'PlacementHelperMixin', 'PlacementInstanceHelperMixin'  https://review.opendev.org/74128317:29
openstackgerritStephen Finucane proposed openstack/nova master: tests: Make '_IntegratedTestBase' subclass 'PlacementInstanceHelperMixin'  https://review.opendev.org/74128417:29
openstackgerritStephen Finucane proposed openstack/nova master: tests: Add helpers for suspend, resume and reboot of server  https://review.opendev.org/74128517:29
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Pass context, instance to '_create_domain'  https://review.opendev.org/74128617:30
*** gyee has joined #openstack-nova17:30
stephenfincleaning up after reverted resizes is hard work :(17:30
gmanndansmith: melwitt sean-k-mooney nova-next is zuulv3 native jobs and d-g not in pic. d-g run post script for legacy jobs only.  zuulv3 run three phase in order 1. 'pre-run' (in hierarchical inheritance order, parent >child)  2. 'run' (this is not run in inheritance order means only parent run if child define one). and last is 3 'post-run' (in hierarchical inheritance order, parent >child) here it trigger the17:31
gmannplaybooks/nova-next/post.yaml which run that script  (https://github.com/openstack/nova/blob/89e65bd976be8e02fdb6932bb710b5165d7e00a3/.zuul.yaml#L199)17:31
sean-k-mooneygmann: yep i know17:32
dansmithgmann: ack, that's what I was suspecting,17:32
dansmiththat we had to call the post playbook, I didn't even look17:32
dansmithI'm trying to get a glance job that will do some smoke testing of the devstack stuff, since baking devstack assumptions into tempest doesn't really matter17:32
dansmither, doesn't really make sense17:32
dansmithand I just want to like validate that the cirros image got imported as expected, with auto-added metadata and stuff17:33
dansmithand that's kinda like what we do in that post job where we check the db state17:33
gmanndansmith:  that is little tricky if you do in post pahse as parent post is run first where all logs etc are collected17:34
sean-k-mooneyah ok you want to just dump some extra info after the job run so we can validate the setup was correct17:35
dansmithsean-k-mooney: well, I want to validate it, not just dump it but yeah17:35
sean-k-mooneygmann: isint our post job run before our parent17:35
dansmithgmann: nova-next overrides post-run right?17:35
sean-k-mooneyi though it was like an onion or stack call17:35
dansmithI don't care the order, as long as I can fail and cause the job to fail17:36
sean-k-mooneyall our parent pre playbooks run firrst then ours then the un playbook then post run in reverse order17:36
gmannright child post-run playbook -> parent post-run playbook sean-k-mooney is right.17:36
gmannso we are good to run in nova-next post17:36
sean-k-mooneydansmith: the post playbook run regardless of if run passes or fails17:37
dansmithyeah, that's fine, I don't care the order17:37
dansmithsean-k-mooney: right, but if post-run fails, the job will fail right?17:37
sean-k-mooneybut if a pre playbook fails wee dont run the run playbook17:37
dansmithlike our db archive test17:37
sean-k-mooneyoh am yes17:37
gmannyeas, it will cause job failure17:37
dansmithright, I just want the job to fail if I decide17:37
sean-k-mooneybut you can ignore failure in the ansible playbook if you wan17:37
sean-k-mooneye.g. the ansible task can be marked to ignore any failures17:38
dansmithbasically, I will configure glance to auto-add a piece of metadata to images that get added, and then in post, just check that the cirros image has that metadata set, and if not, explode17:38
sean-k-mooneyso you can decied if a taks should mark the post playbook as a failure or not17:38
sean-k-mooneydansmith: yep that should be failrly simple17:38
dansmithyup17:38
sean-k-mooneyyou are already doing most of it with your  multistore job17:39
sean-k-mooneyin this case you need to enable the metadata plugin17:39
sean-k-mooneythen have a post job that just checks for it17:39
dansmithyup17:39
dansmithbut I'm going to do it for glance jobs, not mine17:39
sean-k-mooneysure17:39
dansmithjust because they're not testing any of that stuff right now,17:39
sean-k-mooneyit would be nice to do multi store for them too17:40
dansmithand it requires config, not something tempest can do, so I want to example them towards actually testing that stuff :)17:40
dansmithI think we're going to make the nova job global so they can run it too, right gmann ?17:40
gmannif you do it via role the nova or other job can reuse that17:40
sean-k-mooneydansmith: it already is17:40
sean-k-mooneythey just need to add it to there check pipeline17:40
sean-k-mooneyany repo can run any others jobs17:40
gmanndansmith: right, even on devstack-plugin-ceph gate17:40
dansmithsean-k-mooney: well, not yet because it's not landed17:40
dansmithbut yeah17:41
sean-k-mooneydansmith: it can with depend on but ya17:41
dansmithwell, anyway :)17:41
sean-k-mooneyzuul is awsome that way17:41
*** nightmare_unreal has quit IRC17:44
*** tesseract has quit IRC17:45
openstackgerritMerged openstack/nova stable/queens: Add functional test for bug 1550919  https://review.opendev.org/73271517:59
openstackbug 1550919 in OpenStack Compute (nova) queens "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Elod Illes (elod-illes)17:59
*** martinkennelly has quit IRC18:08
*** larsks has joined #openstack-nova18:14
*** bbowen has joined #openstack-nova18:16
*** admin0 has left #openstack-nova18:17
*** vishalmanchanda has quit IRC18:20
*** slaweq has joined #openstack-nova18:21
*** tosky has quit IRC18:25
*** tosky has joined #openstack-nova18:25
*** jsuchome has quit IRC18:39
*** ociuhandu has joined #openstack-nova18:46
*** ociuhandu has quit IRC18:50
*** jdillaman has joined #openstack-nova18:53
*** KeithMnemonic has joined #openstack-nova19:12
*** haleyb has joined #openstack-nova19:29
openstackgerritMerged openstack/nova stable/queens: libvirt: Fix misleading debug msg "Instance is running"  https://review.opendev.org/73271619:29
*** ralonsoh has quit IRC19:49
artommordred, just wanted to bring your attention to https://review.opendev.org/#/c/741295/ and the corresponding story19:56
* artom -> kids pick up19:57
openstackgerritLee Yarwood proposed openstack/nova stable/queens: Reject boot request for unsupported images  https://review.opendev.org/70860919:59
*** raildo has quit IRC20:16
*** raildo has joined #openstack-nova20:16
*** raildo has quit IRC20:22
*** raildo has joined #openstack-nova20:24
*** slaweq has quit IRC20:29
*** raildo has quit IRC20:30
*** jangutter has quit IRC20:40
*** jangutter_ has joined #openstack-nova20:40
*** hamalq_ has quit IRC20:46
*** hamalq has joined #openstack-nova20:48
*** hamalq has quit IRC20:52
*** hamalq has joined #openstack-nova20:52
openstackgerritSean McGinnis proposed openstack/nova master: Use unittest.mock instead of third party mock  https://review.opendev.org/71467620:52
*** gyee has quit IRC21:10
*** gyee has joined #openstack-nova21:11
*** mriedem has left #openstack-nova21:46
*** xek has quit IRC21:50
mordredartom: awesome - lgtm - thanks!21:59
openstackgerritMerged openstack/nova master: virt: Add 'context', drop 'network_info' parameters for 'unrescue'  https://review.opendev.org/73038222:09
*** logan- has quit IRC22:17
*** rcernin has joined #openstack-nova22:19
*** logan- has joined #openstack-nova22:19
*** rcernin has quit IRC22:20
*** rcernin has joined #openstack-nova22:21
*** prometheanfire has joined #openstack-nova22:26
prometheanfireit looks like it's just nova that fails with mock-4.0.2 https://review.opendev.org/74109122:27
*** spatel has joined #openstack-nova22:29
*** vapjes has quit IRC22:33
*** spatel has quit IRC22:34
openstackgerritMerged openstack/nova master: crypto: Add type hints  https://review.opendev.org/73920722:35
*** hamalq has quit IRC22:35
*** tosky has quit IRC22:48
melwittprometheanfire: will look22:52
melwittI wrote that test 😝22:53
*** tkajinam has joined #openstack-nova22:55
*** tkajinam has quit IRC22:55
*** xiaolin has quit IRC22:56
prometheanfire:D22:57
*** tkajinam has joined #openstack-nova22:58
*** mlavalle has quit IRC22:59
*** avolkov has quit IRC23:02
*** markvoelker has joined #openstack-nova23:11
*** markvoelker has quit IRC23:15
*** JamesBenson has quit IRC23:56

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!