Wednesday, 2020-07-22

openstackgerritGhanshyam Mann proposed openstack/nova master: Fix multinic policy for admin_or_owner  https://review.opendev.org/74231700:01
openstackgerritGhanshyam Mann proposed openstack/nova master: Add test coverage of multinic policies  https://review.opendev.org/74231500:01
*** gyee has quit IRC00:20
*** hamalq has quit IRC00:27
*** tetsuro has joined #openstack-nova00:27
*** zhanglong has joined #openstack-nova00:33
*** brinzhang has joined #openstack-nova00:44
*** brinzhang_ has joined #openstack-nova00:51
*** brinzhang has quit IRC00:53
*** k_mouza has joined #openstack-nova01:12
*** nweinber has joined #openstack-nova01:12
*** k_mouza has quit IRC01:16
*** zhanglong has quit IRC01:24
*** zhanglong has joined #openstack-nova01:24
*** hamalq has joined #openstack-nova01:30
*** hamalq_ has joined #openstack-nova01:31
*** hamalq has quit IRC01:36
openstackgerritGhanshyam Mann proposed openstack/nova master: Add test coverage of multinic policies  https://review.opendev.org/74231501:36
*** hamalq_ has quit IRC01:38
openstackgerritGhanshyam Mann proposed openstack/nova master: Introduce scope_types in multinic policy  https://review.opendev.org/74232801:40
*** nweinber has quit IRC01:44
*** zhanglong has quit IRC01:53
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in multinic policies  https://review.opendev.org/74233001:53
*** zhanglong has joined #openstack-nova01:55
*** yaawang has quit IRC01:57
*** yaawang has joined #openstack-nova01:58
*** hamalq has joined #openstack-nova02:04
openstackgerritMerged openstack/nova master: Remove broken legacy zuul jobs  https://review.opendev.org/74160302:09
*** hamalq has quit IRC02:10
openstackgerritBrin Zhang proposed openstack/nova master: Delete ARQs by UUID if Cyborg ARQ bind fails.  https://review.opendev.org/71618602:12
*** nweinber has joined #openstack-nova02:16
openstackgerritGhanshyam Mann proposed openstack/nova master: Add test coverage of multinic policies  https://review.opendev.org/74231502:17
openstackgerritGhanshyam Mann proposed openstack/nova master: Introduce scope_types in multinic policy  https://review.opendev.org/74232802:18
*** tetsuro has quit IRC02:20
openstackgerritMerged openstack/nova master: Reduce gen conflict in COMPUTE_STATUS_DISABLED handling  https://review.opendev.org/70486602:22
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in multinic policies  https://review.opendev.org/74233002:23
*** zhanglong has quit IRC02:29
*** zhanglong has joined #openstack-nova02:33
*** sapd1 has joined #openstack-nova02:41
*** nweinber has quit IRC02:42
openstackgerritMerged openstack/nova master: Make our ceph job test with glance in multistore mode  https://review.opendev.org/73418402:46
*** dave-mccowan has quit IRC02:51
*** huaqiang has quit IRC02:56
openstackgerritMerged openstack/nova stable/stein: Create instance action when burying in cell0  https://review.opendev.org/72953103:23
*** psachin has joined #openstack-nova03:31
*** Liang__ has joined #openstack-nova03:31
tony_sugibi: alex_xu: Thanks for your reviewing and comments. I will check them and update patches accordingly. In any way I have to change patches as there is merging conflict.03:32
*** redrobot has quit IRC03:42
*** ratailor has joined #openstack-nova04:14
*** ratailor_ has joined #openstack-nova04:26
*** ratailor has quit IRC04:26
*** zhanglong has quit IRC04:30
*** zhanglong has joined #openstack-nova04:34
*** hamalq has joined #openstack-nova04:43
*** hamalq_ has joined #openstack-nova04:44
*** hamalq has quit IRC04:48
*** hamalq_ has quit IRC04:55
*** udesale has joined #openstack-nova05:27
*** sapd1 has quit IRC05:32
*** tobias-urdin|pto has quit IRC05:39
*** maciejjozefczyk_ has joined #openstack-nova05:43
*** links has joined #openstack-nova05:44
*** sapd1 has joined #openstack-nova05:54
*** vishalmanchanda has joined #openstack-nova05:55
*** iurygregory has joined #openstack-nova06:25
*** elod is now known as elod_off06:31
openstackgerritAdit Sarfaty proposed openstack/nova master: Set different VirtualDevice.key  https://review.opendev.org/71356506:39
*** eharney has quit IRC06:40
*** eharney has joined #openstack-nova06:52
*** nightmare_unreal has joined #openstack-nova07:01
*** damien_r has joined #openstack-nova07:08
*** tesseract has joined #openstack-nova07:10
*** ociuhandu has quit IRC07:10
*** sapd1 has quit IRC07:10
*** zhanglong has quit IRC07:11
*** damien_r has quit IRC07:12
*** sapd1 has joined #openstack-nova07:13
*** zhanglong has joined #openstack-nova07:15
*** ralonsoh has joined #openstack-nova07:29
*** rcernin has quit IRC07:32
gibistephenfin: hi! you vtpm patches are the next for a runway slot, but if I understood correctly the main feature patches are in merge conflict.07:33
gibistephenfin: if you have a set of ready patches then I can pull that into a slot07:33
gibistephenfin: do you have a clear bottom that is ready?07:34
*** xek has joined #openstack-nova07:36
*** ociuhandu has joined #openstack-nova07:36
*** tosky has joined #openstack-nova07:39
*** zhanglong has quit IRC07:40
openstackgerritSergey Galas' proposed openstack/nova master: fixes broken shared live migration of a vm with a vif aka Bug #1888395  https://review.opendev.org/74218007:46
openstackbug 1888395 in OpenStack Compute (nova) "shared live migration of a vm with a vif is broken in train" [Undecided,New] https://launchpad.net/bugs/1888395 - Assigned to Sergey Galas' (shrike742)07:46
*** markvoelker has joined #openstack-nova07:47
*** markvoelker has quit IRC07:52
openstackgerritSergey Galas' proposed openstack/nova master: fixes broken shared live migration of a vm with a vif aka Bug #1888395  https://review.opendev.org/74218007:53
openstackbug 1888395 in OpenStack Compute (nova) "shared live migration of a vm with a vif is broken in train" [Undecided,New] https://launchpad.net/bugs/1888395 - Assigned to Sergey Galas' (shrike742)07:53
*** zhanglong has joined #openstack-nova07:59
*** kleini has joined #openstack-nova08:01
kleiniWhat means a cpu_allocation_ratio of zero actually in placement or scheduler?08:01
*** tosky has quit IRC08:04
*** tosky_ has joined #openstack-nova08:04
*** jangutter_ has joined #openstack-nova08:05
gibikleini: have you seen the Note in this doc ? https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.cpu_allocation_ratio08:07
kleiniYes, but it confuses me more, than it clarifies behavior for me.08:07
gibikleini: OK, then the next piece of doc is https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#allocation-ratios08:09
*** jangutter has quit IRC08:09
kleiniThat clarifies the defaults. Many thanks!08:09
kleiniI was already on the same page but did not read past compute filters *facepalm*08:11
gibiyou are welcome08:11
*** kaisers has joined #openstack-nova08:11
*** yaawang has quit IRC08:13
*** sapd1 has quit IRC08:13
*** yaawang has joined #openstack-nova08:13
*** aj_mailing has quit IRC08:13
gibikleini: don't be hard on yourself, allocation ratios is confusing08:14
*** aj_mailing has joined #openstack-nova08:14
*** aj_mailing has quit IRC08:14
kleiniyes, a whole OpenStack is huge and maintenance sometimes gives headaches but it always resolves somehow after some time of research.08:15
*** aj_mailing has joined #openstack-nova08:16
*** tosky_ is now known as tosky08:19
*** jraju__ has joined #openstack-nova08:21
*** links has quit IRC08:21
*** sapd1 has joined #openstack-nova08:22
*** tetsuro has joined #openstack-nova08:24
*** martinkennelly has joined #openstack-nova08:27
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices  https://review.opendev.org/74156108:33
*** tetsuro has quit IRC08:48
stephenfingibi: I can rebase, but I was hoping lyarwood might be able to hit some of the lower ones that you've already looked at before I did08:48
lyarwoodstephenfin: vtpm?08:49
lyarwoodstephenfin: I'll take a look this morning once I've woken up a little more, had a long night :|08:51
stephenfinlyarwood: yup and sure, no problem :D08:51
lyarwoodstephenfin / gibi ; https://review.opendev.org/#/c/741561/ should be ready for reviews now btw now that melwitt++ has updated the comments08:52
*** dtantsur|afk is now known as dtantsur08:52
*** kashyap has joined #openstack-nova08:53
kashyaplyarwood: I appreciate the commit message with informative (non-null) pointers  -- https://review.opendev.org/#/c/741561/.  Good sleuthing :-)08:59
*** ratailor__ has joined #openstack-nova09:04
lyarwoodI thought you might :)09:04
*** ratailor_ has quit IRC09:06
gibistephenfin: OK. we can put the lower ones into a slot09:06
gibilyarwood: approved https://review.opendev.org/#/c/741561/09:09
*** jangutter has joined #openstack-nova09:10
*** rcernin has joined #openstack-nova09:10
*** aj_mailing has quit IRC09:11
lyarwoodgibi: thanks09:12
*** jangutter_ has quit IRC09:13
stephenfinI really wish Gerrit had notifications a lá GitHub. Would save me parsing the emails every morning :-\09:15
*** zhanglong has quit IRC09:17
*** xek has quit IRC09:19
openstackgerritLee Yarwood proposed openstack/nova master: Detach is broken for multi-attached fs-based volumes  https://review.opendev.org/74171209:21
*** zhanglong has joined #openstack-nova09:27
*** rcernin has quit IRC09:35
openstackgerritMerged openstack/nova master: hardware: Enable 'hw:cpu_dedicated_mask' for creating a mixed instance  https://review.opendev.org/71470609:37
*** sapd1 has quit IRC09:37
*** Liang__ has quit IRC09:40
*** k_mouza has joined #openstack-nova09:53
*** udesale_ has joined #openstack-nova09:58
tony_sugibi: just status update for provider-config-file patches. I have updated the first two patches and is now working on the 3rd patch.10:00
*** udesale has quit IRC10:01
*** yaawang has quit IRC10:11
*** yaawang has joined #openstack-nova10:12
gibitony_su: thanks. i will try to get back those patches soon10:13
*** sapd1_y has quit IRC10:14
*** sapd1 has joined #openstack-nova10:14
openstackgerritYingji Sun proposed openstack/nova master: Set different VirtualDevice.key  https://review.opendev.org/71356510:15
stephenfinlyarwood: Could you also re-add https://review.opendev.org/742383 to your list?10:17
*** yaawang has quit IRC10:20
*** yaawang has joined #openstack-nova10:21
lyarwoodstephenfin: ack10:24
stephenfinta10:27
stephenfinbauzas: Got an old, pretty trivial patch for you here if you've got time today? https://review.opendev.org/#/c/684393/10:30
bauzasstephenfin: I can take a look10:32
*** priteau has joined #openstack-nova10:34
stephenfinbauzas: thanks!10:42
openstackgerritStephen Finucane proposed openstack/nova stable/stein: libvirt: Mark e1000e VIF as supported  https://review.opendev.org/74239010:43
openstackgerritStephen Finucane proposed openstack/nova stable/stein: libvirt: Mark e1000e VIF as supported  https://review.opendev.org/74239010:43
*** brinzhang0 has joined #openstack-nova10:58
*** tkajinam has quit IRC10:59
*** brinzhang_ has quit IRC11:01
openstackgerritAlex Deiter proposed openstack/nova master: Detach is broken for multi-attached fs-based volumes  https://review.opendev.org/74171211:27
*** raildo has joined #openstack-nova11:29
openstackgerritYingji Sun proposed openstack/nova master: resolve ResourceProviderSyncFailed issue  https://review.opendev.org/74239811:37
*** rcernin has joined #openstack-nova11:49
*** maciejjozefczyk_ has quit IRC12:01
*** maciejjozefczyk has joined #openstack-nova12:01
*** ociuhandu has quit IRC12:03
*** ociuhandu_ has joined #openstack-nova12:03
*** dave-mccowan has joined #openstack-nova12:10
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.PY2 and six.PY3  https://review.opendev.org/72651212:15
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.add_metaclass  https://review.opendev.org/72656512:15
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.reraise  https://review.opendev.org/72689812:16
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.moves  https://review.opendev.org/72722412:16
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.iteritems/itervalues/iterkeys  https://review.opendev.org/72775712:16
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.byte2int/int2byte  https://review.opendev.org/72777712:16
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.binary_type/integer_types/string_types  https://review.opendev.org/72809412:17
*** brinzhang_ has joined #openstack-nova12:17
*** brinzhang0 has quit IRC12:21
openstackgerritBalazs Gibizer proposed openstack/nova master: Undeprecate the vmwareapi driver  https://review.opendev.org/74240712:23
*** artom has quit IRC12:24
openstackgerritBalazs Gibizer proposed openstack/nova master: Undeprecate the vmwareapi driver  https://review.opendev.org/74240712:26
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.text_type (1/2)  https://review.opendev.org/72810912:28
openstackgerritTakashi Natsume proposed openstack/nova master: Remove six.text_type (2/2)  https://review.opendev.org/72811712:28
openstackgerritTakashi Natsume proposed openstack/nova master: objects: Update keypairs when saving an instance  https://review.opendev.org/68304312:29
*** yankcrime has quit IRC12:32
*** zhanglong has quit IRC12:34
*** seba has quit IRC12:38
*** rouk has quit IRC12:38
*** rm_work has quit IRC12:38
openstackgerritMerged openstack/nova master: libvirt: Re-enable live snapshot for paused instances  https://review.opendev.org/74033412:39
*** mordred has quit IRC12:40
*** masterpe has quit IRC12:40
stephenfingibi: Could you stick https://review.opendev.org/#/c/683043/ on your review queue, please? :)12:41
*** yankcrime has joined #openstack-nova12:41
gibistephenfin: ack, enqueued12:42
*** seba has joined #openstack-nova12:42
*** rm_work has joined #openstack-nova12:42
*** nweinber has joined #openstack-nova12:44
*** ratailor__ has quit IRC12:45
*** mordred has joined #openstack-nova12:45
openstackgerritMerged openstack/nova master: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices  https://review.opendev.org/74156112:52
*** masterpe has joined #openstack-nova12:54
*** sapd1 has quit IRC12:56
*** zhanglong has joined #openstack-nova12:56
*** zhanglong has quit IRC13:03
*** zhanglong has joined #openstack-nova13:06
openstackgerritLee Yarwood proposed openstack/nova stable/ussuri: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices  https://review.opendev.org/74241413:06
openstackgerritLee Yarwood proposed openstack/nova stable/train: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices  https://review.opendev.org/74241513:07
openstackgerritLee Yarwood proposed openstack/nova stable/stein: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices  https://review.opendev.org/74241613:07
openstackgerritLee Yarwood proposed openstack/nova stable/rocky: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices  https://review.opendev.org/74241713:08
*** zhanglong has quit IRC13:10
openstackgerritLee Yarwood proposed openstack/nova stable/queens: libvirt: Remove reference to transient domain when detaching devices  https://review.opendev.org/60818613:12
openstackgerritLee Yarwood proposed openstack/nova stable/queens: sync_guest_time: use the proper errno  https://review.opendev.org/74242313:12
openstackgerritLee Yarwood proposed openstack/nova stable/queens: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices  https://review.opendev.org/74242413:12
*** zhanglong has joined #openstack-nova13:14
lyarwoodbauzas: https://review.opendev.org/#/c/729595/ - would you mind hitting this again?13:21
bauzasack13:21
*** artom has joined #openstack-nova13:21
lyarwoodhttps://review.opendev.org/#/c/729261/ could also use some additional core review if anyone has bandwidth13:21
lyarwoodand https://review.opendev.org/#/c/724842/ both are pretty simple13:22
*** zhanglong has quit IRC13:23
*** xek has joined #openstack-nova13:26
gibilyarwood: added to my queue but I will focus on the sriov attach this afternoon so I can get to your patches tomorrow13:27
*** zhanglong has joined #openstack-nova13:27
*** brinzhang0 has joined #openstack-nova13:29
bauzaslyarwood: stephenfin: gibi: others, honestly, I'd be super happy if we could just provide a commit tag for py3-only changes13:29
bauzassomething like "Py3-only"13:29
bauzasso, stable cores looking at it would see it13:29
bauzasI know how this can be difficult to do it every time13:29
bauzasbut if people don't think about py3 styling, then I'm pretty sure we will get bugs in say one year13:30
*** bnemec has joined #openstack-nova13:30
bauzascontext https://review.opendev.org/#/c/729595/6/nova/virt/libvirt/guest.py@86813:30
bauzasI totally understand that people want to use py3 styling13:30
bauzasbut honestly, if you want to do it, think about backports13:31
gibibauzas: I would expect that such thing is caught by the unit test on the backported patch13:31
lyarwoodstable cores would see this, py2 jobs would bork due to this.13:31
*** brinzhang_ has quit IRC13:31
*** rcernin has quit IRC13:32
lyarwoodalso, the py3 style boat has sailed13:32
bauzasgibi: well, for https://review.opendev.org/#/c/729595/6/nova/virt/libvirt/guest.py@868 we don't test it, right?13:32
lyarwoodstephenfin has been landing stuff for most of the cycle already13:32
bauzaslyarwood: I don't see how CI can see it : https://review.opendev.org/#/c/729595/6/nova/virt/libvirt/guest.py@86813:32
lyarwoodbauzas: that's a DEBUG log in a codepath we hit loads in our tempest tests so that would definitley catch it13:32
bauzaswith py313:32
bauzaspy2 rather13:33
lyarwoodwe log at DEBUG in CI13:33
lyarwoodwe always run tests that hit that codepath13:33
bauzasagain, there will be conditions where some code wouldn't be tested by CI and then we would get bugs13:33
*** nweinber has quit IRC13:33
*** nweinber has joined #openstack-nova13:33
bauzasthis is not that I hate py3 styling, I'm just conservative with any change that can be backported, that's it13:34
*** nweinber has quit IRC13:34
bauzasfor a new feature ? sure.13:34
*** nweinber has joined #openstack-nova13:34
gibiI would rather improve our test coverage than rely on a manual commit tag13:34
bauzasmeh, ok, you're right13:36
bauzaslyarwood: fwiw, given you just told that stein jobs would hit this, I upvoted13:39
*** zhanglong has quit IRC13:39
bauzasmy main concern is, please be explicit when you write py3-styling and be clear whether you already thought about backports13:39
bauzasthe better commit msg you write, the easier it would be for reviewers13:39
bauzasthat's it, I don't want to rathole about f-strings anymore13:40
lyarwoodbauzas: FWIW I have no intention of backporting this, it was more to help debug some failures in master CI that look performance related13:41
gibibauzas: I agree that better commit message helps13:45
bauzaslyarwood: ack, gtk13:45
bauzasthanks13:45
*** brinzhang_ has joined #openstack-nova13:48
gibistephenfin: when the reno patch merges for the use-pcpu-and-vcpu-in-one-instance does it mean that the feature is done?13:50
* stephenfin checks where in the series that is13:51
*** brinzhang0 has quit IRC13:52
gibiI'm asking this as there are other patches open but they seem to be good to have not must hav13:52
stephenfingibi: Yep. The only thing that we don't support after that is requesting PCPU + VCPU via 'resources:' extra specs, which we're deferring since it's (a) low priority and (b) interferes with the NUMA in placement work13:52
gibiOK13:52
gibithen I will mark the bp complete (with a note about the deferred part) after the reno merge13:52
gibis13:53
gibithanks for checking it13:53
artomgibi, replied on https://review.opendev.org/#/c/741436/, but you seem to have found the right track on your own :)13:57
gibiartom: thanks. I will check if I can check for vlan13:58
*** Liang__ has joined #openstack-nova13:58
gibiartom: thanks for pointing me to the code that was supposed to clean up the metadata I missed that orignally13:58
artomgibi, it was well hidden. Blame mriedem ;)13:59
gibi:)13:59
artom(For real, it was his idea - performance-wise, it's the good choice. Code-understandability-wise, clearly not so great ;)13:59
*** Liang__ is now known as LiangFang13:59
gibiartom: as far as I see if I simply remove the tag in vif conditional then the code still don't do any expensive things, jut iterate through instance.device_metadata to find the metadata by vif.address14:01
artomgibi, maybe the easiest way to do it is to do a reverse lookup kind of thing: just loop through the device metadata regardless, and if the mac matches the vif mac, delete that entry.14:02
artomgibi, hah, jiinx14:02
gibithat the baseline code does today14:02
artomIOW, as you said, remove the conditional14:02
gibihttps://opendev.org/openstack/nova/src/branch/master/nova/network/neutron.py#L178814:02
gibiOk14:03
*** xek has quit IRC14:05
artomWhich reminds me, I really need to get https://bugs.launchpad.net/tempest/+bug/1775947 figured out14:06
openstackLaunchpad bug 1775947 in tempest "tempest.api.compute.servers.test_device_tagging.TaggedAttachmentsTest failing" [Medium,Confirmed]14:06
artomAnd fixed14:06
*** dave-mccowan has quit IRC14:07
*** LiangFang has quit IRC14:12
*** Liang__ has joined #openstack-nova14:14
*** dave-mccowan has joined #openstack-nova14:20
openstackgerritMerged openstack/nova master: libvirt: Remove workaround for really old QEMU  https://review.opendev.org/74033514:21
*** psachin has quit IRC14:24
*** dave-mccowan has quit IRC14:26
*** brinzhang0 has joined #openstack-nova14:31
*** brinzhang_ has quit IRC14:33
openstackgerritArtom Lifshitz proposed openstack/nova master: DNM: extra logging for tagged device detach  https://review.opendev.org/74245014:34
*** sapd1 has joined #openstack-nova14:37
openstackgerritBalazs Gibizer proposed openstack/nova master: Delete non tag related device metadata during detach  https://review.opendev.org/74245114:39
openstackgerritBalazs Gibizer proposed openstack/nova master: Delete non tag related device metadata during detach  https://review.opendev.org/74143614:42
*** mlavalle has joined #openstack-nova14:44
*** Guest23136 has joined #openstack-nova14:47
*** xek has joined #openstack-nova14:48
*** Guest23136 is now known as redrobot14:49
*** brinzhang_ has joined #openstack-nova14:58
*** KeithMnemonic has joined #openstack-nova14:59
*** brinzhang has joined #openstack-nova14:59
*** k_mouza has quit IRC15:00
*** brinzhang0 has quit IRC15:00
*** k_mouza has joined #openstack-nova15:01
*** brinzhang_ has quit IRC15:02
*** brinzhang_ has joined #openstack-nova15:05
*** brinzhang has quit IRC15:08
*** jraju__ has quit IRC15:13
*** Liang__ has quit IRC15:15
*** Liang__ has joined #openstack-nova15:19
*** Liang__ has quit IRC15:23
*** factor has joined #openstack-nova15:26
*** martinkennelly has quit IRC15:37
*** k_mouza has quit IRC15:41
*** k_mouza has joined #openstack-nova15:44
*** gyee has joined #openstack-nova15:48
*** k_mouza has quit IRC15:55
openstackgerritBalazs Gibizer proposed openstack/nova master: [WIP] Support SRIOV interface attach and detach  https://review.opendev.org/74099516:03
*** factor has quit IRC16:08
*** factor has joined #openstack-nova16:09
openstackgerritMerged openstack/nova master: hardware: create 'mixed' instance for realtime CPUs  https://review.opendev.org/72848516:09
*** factor has left #openstack-nova16:11
*** mriedem has joined #openstack-nova16:17
*** xek has quit IRC16:17
*** hamalq has joined #openstack-nova16:22
*** hamalq_ has joined #openstack-nova16:23
*** hamalq has quit IRC16:27
*** dtantsur is now known as dtantsur|afk16:35
*** udesale_ has quit IRC16:47
*** tesseract has quit IRC16:54
*** lbragstad_ has joined #openstack-nova16:54
*** lbragstad has quit IRC16:57
*** sapd1 has quit IRC17:03
*** ociuhandu has joined #openstack-nova17:11
*** ociuhandu_ has quit IRC17:14
*** brinzhang0 has joined #openstack-nova17:15
*** ociuhandu has quit IRC17:16
*** brinzhang_ has quit IRC17:18
*** ociuhandu has joined #openstack-nova17:22
*** nightmare_unreal has quit IRC17:22
*** brinzhang_ has joined #openstack-nova17:23
*** brinzhang0 has quit IRC17:26
*** ociuhandu has quit IRC17:26
*** brinzhang0 has joined #openstack-nova17:35
*** lbragstad_ has quit IRC17:37
*** lbragstad_ has joined #openstack-nova17:38
*** brinzhang_ has quit IRC17:38
*** lbragstad__ has joined #openstack-nova17:45
*** lbragstad_ has quit IRC17:47
*** k_mouza has joined #openstack-nova17:55
*** aj_mailing has joined #openstack-nova17:56
*** aj_mailing has quit IRC17:57
*** aj_mailing has joined #openstack-nova17:58
*** k_mouza has quit IRC17:59
*** _erlon_ has joined #openstack-nova18:02
openstackgerritGonéri Le Bouder proposed openstack/nova master: QEMU/KVM: accept vmxnet3 NIC  https://review.opendev.org/73869518:22
openstackgerritGonéri Le Bouder proposed openstack/nova master: QEMU/KVM: accept vmxnet3 NIC  https://review.opendev.org/73869518:41
*** brinzhang_ has joined #openstack-nova18:41
*** brinzhang has joined #openstack-nova18:43
*** brinzhang0 has quit IRC18:44
*** ralonsoh has quit IRC18:45
*** brinzhang_ has quit IRC18:46
*** brinzhang0 has joined #openstack-nova18:46
artomRandom thought - someone should probably remove efried and mriedem from https://review.opendev.org/#/admin/groups/25,members, no?18:48
artomNothing against you fellas, obviously :)18:48
*** xek has joined #openstack-nova18:49
*** brinzhang has quit IRC18:49
* mriedem cries so hard18:59
mriedemi'm removed myseflf19:00
mriedem*myself even19:00
mriedemand https://review.opendev.org/#/admin/groups/1936,members19:01
*** bnemec has quit IRC19:03
artommriedem, RIP in pieces :(19:07
artomI was randomly linking that page to someone who needed core review19:08
artomThis isn't a coup, is what I'm saying :)19:08
mriedemyup, np19:21
*** maciejjozefczyk has quit IRC19:26
*** ociuhandu has joined #openstack-nova19:31
*** ociuhandu_ has joined #openstack-nova19:34
*** ociuhand_ has joined #openstack-nova19:35
*** ociuhandu has quit IRC19:36
*** ociuhandu_ has quit IRC19:38
*** adrianc_ has joined #openstack-nova19:44
*** ociuhand_ has quit IRC19:45
*** adrianc has quit IRC19:47
*** jralbert has joined #openstack-nova19:48
*** jralbert has left #openstack-nova19:48
*** jralbert has joined #openstack-nova20:03
*** brinzhang_ has joined #openstack-nova20:13
*** brinzhang0 has quit IRC20:16
*** nweinber has quit IRC20:16
jralbertI've raised this question in #openstack and so far received no response; anybody here have any advice? I've just upgraded from Rocky to Stein, and Placement seems to have gotten very confused about resources in-use vs available. A number of compute nodes with running instances which are known to 'openstack server show' are reporting 0 running_vms20:22
jralbertin 'nova hypervisor-stats', and have no entries in the allocations table in the nova_api database. Running nova-manage placement heal_allocations for affected instances returns an error that "Compute host <compute_node> could not be found", but all the compute nodes are visible in nova-manage cell_v2 list_hosts. Has anyone encountered this? Any20:22
jralbertsuggestions on how to troubleshoot it further?20:22
*** hemna has quit IRC20:32
melwittjralbert: it sounds like your nova.instances records instance.host and instance.node aren't matching any records in nova.compute_nodes 'host' and 'hypervisor_hostname', as for why you're getting Compute host could not be found20:39
*** hemna has joined #openstack-nova20:39
melwittdid you replace any nova-compute services during the upgrade with different hostnames or something like that?20:40
jralbertmelwitt: Thanks, I'll have a look at those tables. We didn't change any hostnames during the upgrade, although because it was being orchestrated by OSA there may have been steps taken we weren't fully aware of20:41
melwittok. I can't tell you how things got into that state but just for the sake of understanding why heal_allocations won't work: it will look up the compute node for an instance by querying for the instance.host and instance.node in the nova.compute_nodes table and if it finds no match, you'll get the Compute host could not be found error20:43
melwittI'm not aware of any change from rocky to stein that could cause something like this. are you running with integrated placement (in nova) or did you split out to running extracted placement I wonder?20:45
jralbertI'm not 100% sure what integrated/extracted placement means, but I can find out - we're relying mostly on OSA defaults with some overrides, but that's not one I'm aware of.20:46
melwittif you've moved to extracted placement, there are additional steps you need to follow for an upgrade, linked from here: https://docs.openstack.org/releasenotes/nova/stein.html#prelude20:46
jralbertInterestingly, there is a bit of a hint in the tables: http://paste.openstack.org/show/796222/20:47
melwitthttps://docs.openstack.org/placement/latest/admin/upgrade-to-stein.html20:47
*** priteau has quit IRC20:47
jralbertThe compute nodes get '.openstack.local' hostnames in instances, but a genuine FQDN in compute_nodes20:47
melwittthe reason I ask about extracted placement is because you said your nova_api.allocations table is empty. did you already move to a separate placement db? do you have placement.allocations records?20:48
jralbertSorry, the allocations table isn't completely empty - it's just missing *some* instances on *some* compute nodes20:49
melwittok, I think that difference in the nodename is causing the failure to lookup the compute nodes for the heal_allocations command20:49
jralbertwe became aware of this because our instance/vcpu metrics suddenly dropped by about half during the upgrade, but all the instances were still running that had been20:49
melwittthis is where I see the lookup by host and node for heal_allocations https://github.com/openstack/nova/blob/stable/stein/nova/cmd/manage.py#L182920:50
jralbertSo would I safely be able to update those definitions directly in the database, or is there a better-bounded API/CLI approach?20:50
jralbertI guess I would have hoped that compute nodes would be identified by uuids since names (especially hostnames) often produce collisions like this, but I'm guessing there's a legacy reason why this is the way it is.20:52
melwittyeah, they are not linked by uuid. I don't know the history behind it. probably something like since you can delete/create services via the API, if we didn't link by name, you'd lose the association for all your instances even if the hostname is the same (service create makes a new uuid)20:55
jralbertYep, I can imagine. We too are victims of our own legacy here: our compute nodes always had shortnames rather than FQDNs, and I'm pretty sure that's how we got burned here20:56
melwittI think you'd have to update manually in the database for this (please backup first). I'm looking to see where the hypervisor_hostname comes from when the compute_nodes record is initially created, to see how it happened and whether it will happen again if you were to delete/create the nova-compute service later on20:56
*** hamalq_ has quit IRC20:57
jralbertI actually think I can maybe do this without futzing with the database, come to think of it: if I let nova-compute discover the node's FQDN and register itself as a "new" compute-service, it'll probably also create a new compute node record with FQDN, and ideally trigger a new resource allocation update. I'll try this with one node to see how it20:57
jralbertgoes - otherwise, I'll update in the database20:57
*** hamalq has joined #openstack-nova20:58
jralbertThank you very much for taking the time to help me with this today, I really appreciate it20:58
melwittyeah, that would be the ideal way. fingers crossed that it'll match what your instances already have stored in their host/node20:58
jralbertTo be discovered!20:58
*** brinzhang0 has joined #openstack-nova20:59
*** brinzhang_ has quit IRC21:02
*** bnemec has joined #openstack-nova21:04
*** bnemec has quit IRC21:11
*** bnemec has joined #openstack-nova21:18
*** raildo has quit IRC21:28
*** ociuhandu has joined #openstack-nova21:46
*** ociuhandu has quit IRC21:50
*** vishalmanchanda has quit IRC22:01
*** brinzhang_ has joined #openstack-nova22:07
*** brinzhang0 has quit IRC22:11
openstackgerritGhanshyam Mann proposed openstack/nova master: DNM: testing tempest copy-image test  https://review.opendev.org/74254722:11
*** efried has quit IRC22:27
*** jralbert has quit IRC22:30
*** efried has joined #openstack-nova22:31
efriedartom: It's not out of the question that I'll still review something here or there. But yeah, soon.22:44
artomefried, still addicted, eh? I thought you quit cold-turkey ;)22:45
artomBut ack, you're an adult, you can do the needful when it's time22:46
efriedI've quit almost nothing in my life cold turkey22:46
artom;)22:46
efriedWith the possible exception of running.22:47
efriedI actually had an orthopedic surgeon tell me I was too white to run marathons.22:47
artomHah, you told me that once22:47
artomI remember laughing like an idiot at the most recent Denver PTG22:48
efriedorite, because you were limping, s'how that conversation started. All recovered by now I assume (like three years later)22:49
artomYeah, back to running :)22:50
artomNo full marathons, but I've done a couple of halfs22:50
efriednice. I had a half where all the stars aligned, averaged 7:30/mi, reverse split. My best run ever.22:51
efried(which tells you all you need to know about my running talent)22:51
*** rcernin has joined #openstack-nova22:52
*** mriedem has left #openstack-nova22:54
*** rcernin has quit IRC22:58
*** mlavalle has quit IRC23:00
*** rcernin has joined #openstack-nova23:01
*** tosky has quit IRC23:03
*** rcernin has quit IRC23:04
*** rcernin has joined #openstack-nova23:05
*** brinzhang0 has joined #openstack-nova23:12
*** brinzhang_ has quit IRC23:16
*** markvoelker has joined #openstack-nova23:27
*** markvoelker has quit IRC23:32
*** ociuhandu has joined #openstack-nova23:47
*** ociuhandu has quit IRC23:52

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!