Thursday, 2020-07-30

*** artom has joined #openstack-nova00:08
*** yaawang has quit IRC00:14
*** yaawang has joined #openstack-nova00:14
*** tetsuro has joined #openstack-nova00:18
*** tetsuro has quit IRC00:25
*** mlavalle has quit IRC00:29
*** tetsuro has joined #openstack-nova00:40
*** tetsuro has quit IRC00:48
*** xiaolin has joined #openstack-nova00:52
*** tetsuro has joined #openstack-nova00:54
*** tetsuro has quit IRC00:59
*** tetsuro has joined #openstack-nova01:08
*** k_mouza has joined #openstack-nova01:19
openstackgerritTony Su proposed openstack/nova master: Provider Config File: YAML file loading and schema validation
*** k_mouza has quit IRC01:24
*** yaawang has quit IRC01:31
*** yaawang has joined #openstack-nova01:31
*** brinzhang_ has quit IRC01:43
*** k_mouza has joined #openstack-nova01:49
*** k_mouza has quit IRC01:53
*** gyee has quit IRC02:34
*** yaawang has quit IRC02:41
*** yaawang has joined #openstack-nova02:42
*** xinranwang__ has joined #openstack-nova02:42
*** k_mouza has joined #openstack-nova02:42
*** brinzhang has joined #openstack-nova02:44
openstackgerritBrin Zhang proposed openstack/nova master: Optimize _create_and_bind_arqs logic in conducor
openstackgerritBrin Zhang proposed openstack/nova master: cyborg evacuate support
*** k_mouza has quit IRC02:47
*** brinzhang_ has joined #openstack-nova02:54
*** brinzhang has quit IRC02:57
*** tetsuro has quit IRC03:00
*** yaawang has quit IRC03:14
*** yaawang has joined #openstack-nova03:15
*** k_mouza has joined #openstack-nova03:20
*** sapd1 has joined #openstack-nova03:21
*** k_mouza has quit IRC03:25
*** psachin has joined #openstack-nova03:36
*** yaawang has quit IRC03:47
*** yaawang has joined #openstack-nova03:48
openstackgerritTony Su proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs
*** mgariepy has quit IRC04:09
*** mgariepy has joined #openstack-nova04:10
*** ociuhandu has joined #openstack-nova04:22
*** ociuhandu has quit IRC04:26
*** evrardjp has quit IRC04:33
*** evrardjp has joined #openstack-nova04:33
*** takamatsu has quit IRC04:38
*** takamatsu has joined #openstack-nova04:38
*** links has joined #openstack-nova05:08
*** ratailor has joined #openstack-nova05:11
*** udesale has joined #openstack-nova05:13
*** yaawang has quit IRC05:23
*** yaawang has joined #openstack-nova05:24
*** sapd1 has quit IRC05:32
*** ralonsoh has joined #openstack-nova05:43
*** brinzhang0 has joined #openstack-nova05:46
*** vishalmanchanda has joined #openstack-nova05:49
*** brinzhang_ has quit IRC05:50
*** jsuchome has joined #openstack-nova06:11
*** xinranwang__ has quit IRC06:12
*** lpetrut has joined #openstack-nova06:22
*** Luzi has joined #openstack-nova06:27
*** ociuhandu has joined #openstack-nova06:30
*** tosky has joined #openstack-nova06:32
*** yaawang has quit IRC06:32
*** yaawang has joined #openstack-nova06:34
*** ociuhandu has quit IRC06:35
*** maciejjozefczyk has joined #openstack-nova06:52
*** dklyle has quit IRC06:59
*** sapd1 has joined #openstack-nova07:04
*** slaweq has joined #openstack-nova07:10
*** tesseract has joined #openstack-nova07:14
*** yaawang has quit IRC07:15
*** yaawang has joined #openstack-nova07:17
*** whoami-rajat has quit IRC07:23
*** yaawang has quit IRC07:26
*** yaawang has joined #openstack-nova07:26
*** bhagyashris is now known as bhagyashris|lunc07:28
*** rcernin has quit IRC07:32
openstackgerritTony Su proposed openstack/nova master: Provider Config File: YAML file loading and schema validation
openstackgerritTony Su proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs
*** ociuhandu has joined #openstack-nova07:39
bauzasstephenfin: not sure you got a chance to see my comment
tony_sustephenfin: the first patch is uploaded and in almost-completed phase, and the second patch is ready for a new round of review.07:53
*** nightmare_unreal has joined #openstack-nova07:58
*** markvoelker has joined #openstack-nova08:20
*** KeithMnemonic has quit IRC08:23
brinzhang0sean-k-mooney: please see, I agree with gibi, can we remove the eventlet.timeout.Timeout Exception?08:24
*** markvoelker has quit IRC08:25
*** bbowen_ has joined #openstack-nova08:25
*** bbowen_ has quit IRC08:27
*** bbowen has quit IRC08:27
*** xek has joined #openstack-nova08:27
*** bbowen_ has joined #openstack-nova08:27
*** rcernin has joined #openstack-nova08:28
*** martinkennelly has joined #openstack-nova08:32
*** rcernin has quit IRC08:34
*** derekh has joined #openstack-nova08:39
*** links has quit IRC08:55
openstackgerritAlexandre Arents proposed openstack/nova master: Rebase qcow2 images when unshelving an instance
*** yaawang has quit IRC08:58
*** spatel has joined #openstack-nova08:58
*** yaawang has joined #openstack-nova08:59
openstackgerritJie Li proposed openstack/nova-specs master: add volume backed server rebuild spec
*** dtantsur|afk is now known as dtantsur09:03
*** spatel has quit IRC09:04
*** links has joined #openstack-nova09:06
*** jangutter_ has joined #openstack-nova09:11
*** jangutter has quit IRC09:13
*** xek has quit IRC09:27
*** k_mouza has joined #openstack-nova09:36
*** bhagyashris|lunc is now known as bhagyashris09:37
*** jangutter_ is now known as jangutter09:39
*** jangutter has quit IRC09:45
*** jangutter has joined #openstack-nova09:46
*** mkrai has joined #openstack-nova10:03
sean-k-mooneybrinzhang0: i am not sure, i think it could be raised form any https request but if we remove it and it is raised it will still be caught by the generic Exception10:12
*** k_mouza has quit IRC10:13
sean-k-mooneyso it wont change behavior to remove it10:13
sean-k-mooneyso we could for brevity10:13
*** ociuhandu_ has joined #openstack-nova10:17
*** ociuhandu has quit IRC10:19
*** ociuhandu_ has quit IRC10:21
*** ociuhandu has joined #openstack-nova10:22
*** dtantsur is now known as dtantsur|brb10:23
*** martinkennelly has quit IRC10:27
*** ociuhandu has quit IRC10:27
*** martinkennelly has joined #openstack-nova10:31
*** k_mouza has joined #openstack-nova10:35
*** rcernin has joined #openstack-nova10:37
*** mgariepy has quit IRC10:50
*** rcernin has quit IRC10:54
*** nightmare_unreal has quit IRC10:59
*** ociuhandu has joined #openstack-nova11:00
openstackgerritHarshavardhan Metla proposed openstack/nova master: Removed the host FQDN from the exception message
*** markvoelker has joined #openstack-nova11:19
*** raildo has joined #openstack-nova11:25
*** markvoelker has quit IRC11:27
*** _erlon_ has joined #openstack-nova11:30
*** mkrai has quit IRC11:32
*** mkrai_ has joined #openstack-nova11:32
*** mkrai_ has quit IRC11:38
*** elod is now known as elod_afk11:42
*** ociuhandu has quit IRC11:44
*** sapd1 has quit IRC11:46
*** spatel has joined #openstack-nova11:52
*** udesale_ has joined #openstack-nova11:54
*** spatel has quit IRC11:56
*** ociuhandu has joined #openstack-nova11:57
*** udesale has quit IRC11:57
*** brinzhang_ has joined #openstack-nova12:00
*** brinzhang0 has quit IRC12:02
*** mgariepy has joined #openstack-nova12:09
*** brinzhang0 has joined #openstack-nova12:09
*** martinkennelly has quit IRC12:10
*** brinzhang_ has quit IRC12:11
*** ociuhandu_ has joined #openstack-nova12:15
*** ociuhandu has quit IRC12:18
gibi_ptodansmith: I've did a quick cleanup on the todays meeting agenda on the wiki for you12:19
* gibi_pto goes back to vacationing12:19
*** kaisers has quit IRC12:21
*** kaisers has joined #openstack-nova12:21
*** derekh has quit IRC12:23
*** k_mouza has quit IRC12:24
*** lpetrut_ has joined #openstack-nova12:33
*** lpetrut has quit IRC12:36
*** nweinber has joined #openstack-nova12:37
*** k_mouza has joined #openstack-nova12:39
*** k_mouza has quit IRC12:43
*** tkajinam has quit IRC12:47
*** yaawang has quit IRC12:51
*** yaawang has joined #openstack-nova12:53
*** dtantsur|brb is now known as dtantsur12:53
*** martinkennelly has joined #openstack-nova12:56
*** martinkennelly has quit IRC13:02
*** ratailor has quit IRC13:07
*** martinkennelly has joined #openstack-nova13:10
*** derekh has joined #openstack-nova13:11
*** k_mouza has joined #openstack-nova13:16
*** mriedem has joined #openstack-nova13:17
*** k_mouza has quit IRC13:20
*** bbowen has joined #openstack-nova13:20
*** bbowen_ has quit IRC13:21
dansmithgibi_pto: roger, thanks, I was just going to look at it this morning13:23
*** k_mouza has joined #openstack-nova13:26
openstackgerritAndrew Bonney proposed openstack/nova master: Fix misleading documentation for live_migration_inbound_addr
*** k_mouza has quit IRC13:30
bauzasdansmith: I guess you'll handle the v-2 tag ?13:34
* bauzas is leaving for 3 weeks starting tonight13:34
dansmithbauzas: apparently there's nothing to do, we worked that out last week I think13:34
bauzasmmmm really ?13:34
bauzaslemme doublecheck13:34
dansmithaccording to smcginnis, but if he tells me to do something I'll do it13:34
bauzasdansmith: can't see any nova proposed change in the releases repo13:36
bauzasfor victoria-2 I mean13:36
bauzasactually, nevermind13:37
dansmithlet's wait for smcginnis to respond13:37
bauzascan't see any service project change for victoria-1 either13:37
bauzasso I guess it changed13:37
bauzasyeah, that changed and I now remember ttx's email on openstack-discuss
bauzaswe no longer produce milestones, only rcs13:39
bauzas... and confirmed here
*** k_mouza has joined #openstack-nova13:41
*** sapd1 has joined #openstack-nova13:42
*** k_mouza has quit IRC13:45
*** k_mouza has joined #openstack-nova13:50
*** yoctozepto has quit IRC13:54
*** k_mouza has quit IRC13:54
*** yoctozepto has joined #openstack-nova13:55
*** k_mouza has joined #openstack-nova13:59
*** k_mouza has quit IRC14:04
smcginnisYep, no release needed now unless you know there is some downstream need for it.14:04
*** bbowen has quit IRC14:06
fungiam i now an object-oriented compiled language?14:10
*** Luzi_ has joined #openstack-nova14:10
*** k_mouza has joined #openstack-nova14:10
*** xek has joined #openstack-nova14:10
fungifungi99 was more flexible, even if you wound up with a lot more templating and boilerplate14:11
fungithough my heart still belongs to classic k&r fungi14:11
*** Luzi has quit IRC14:11
*** bbowen has joined #openstack-nova14:12
*** psachin has quit IRC14:12
* fungi increments by one and gets back to work14:13
*** k_mouza has quit IRC14:14
*** k_mouza has joined #openstack-nova14:15
*** lpetrut_ has quit IRC14:19
*** k_mouza has quit IRC14:19
*** k_mouza has joined #openstack-nova14:22
*** k_mouza has quit IRC14:27
*** elod_afk is now known as elod14:27
*** mlavalle has joined #openstack-nova14:43
*** bhagyashris is now known as bhagyashris|away14:47
ralonsohstephenfin, hi again14:47
ralonsohif you have a bit of time14:48
openstackgerritGhanshyam Mann proposed openstack/nova master: DNM: testing tempest copy-image test
openstackgerritGhanshyam Mann proposed openstack/nova master: DNM: testing tempest copy-image test
*** dklyle has joined #openstack-nova14:57
stephenfinralonsoh: How do you plan to use these traits? That's still not entirely clear to me14:59
ralonsohstephenfin, if needed, that will be enforced in the port info14:59
sean-k-mooneystephenfin: we will need nova changes next cycle to report the traits14:59
stephenfinwhat resource providers will they be reported on, and who sets them?14:59
ralonsohlet me check where exactly14:59
sean-k-mooneystephenfin: initally they will be reported on the compute node root rp if either sriov is enabled or numa vswitches15:00
sean-k-mooneystephenfin: if we start tracking pci device in plamcnet then it will be on the pci device RP15:01
ralonsohis this what you are asking?15:01
stephenfinah, there's a spec. That's what I was looking for15:01
* stephenfin looks15:01
ralonsohbut yes, we are not pointing to any specific RP15:02
stephenfinthis doesn't feel like a trait or something you'd want to report15:04
*** k_mouza has joined #openstack-nova15:04
ralonsohstephenfin, ?15:04
stephenfinso with this feature, we're saying you'll be able to state whether NUMA affinity is important or not on a port-by-port basis15:04
stephenfincool, so what do we need the trait for15:05
ralonsohto specify the policy15:05
sean-k-mooneyto select host that supprot numa affinity15:05
stephenfinthat's a single trait, not three15:06
sean-k-mooneystephenfin: its mostly required for numa_vswitchs15:06
stephenfinor something like that15:06
sean-k-mooneynot really numa_vsiwtch only support stict affinity today15:06
sean-k-mooneynot all 315:06
sean-k-mooneyalthough we woudl be changing that as part of the nova half of the feature15:07
stephenfinso it wouldn't report SUPPORTS_CONFIGURABLE_NUMA_AFFINITY15:07
stephenfin(again, just a placeholder trait name)15:07
sean-k-mooneystephenfin: perhaps but i think knowing which policy is support is imporant15:08
sean-k-mooneyim also expecting this to be resued for pmem and vgpus15:08
*** k_mouza has quit IRC15:08
stephenfinare there scenarios where we'd report each one of the traits by themselves?15:08
ralonsohonly one per port15:08
sean-k-mooneyi need to check if the numa policy is in the alias or pci white list15:09
stephenfinralonsoh: Sorry, my time's been split multiple different ways so I haven't gotten to sunk my teeth into this before now. Just teasing things out before we merge something we can't undo :)15:09
sean-k-mooneyif its in the whitelist then no15:09
sean-k-mooney* alias15:09
ralonsohstephenfin, sure15:09
sean-k-mooneyok so the numa policy is part of the alias
sean-k-mooneyso we dont need to cater for reporting device as only consumable with a singel policy15:11
sean-k-mooneyits not defiend in the whitelist15:11
stephenfinright, though it's only done that way because aliases are as granular as we get15:11
stephenfinwe didn't (don't) have a mechanism to say use the PCI device indicated by this alias and don't worry about NUMA affinity15:12
*** k_mouza has joined #openstack-nova15:12
sean-k-mooneyyes we do15:12
sean-k-mooneyoh you mean per alias15:12
stephenfinthe flavor extra spec applies to all PCI devices, not just one15:12
sean-k-mooneyright we dont15:12
stephenfinso that's still a TODO after this but we'll be able to do it for SR-IOV ports at least15:13
stephenfinbut the ability to do that smells like a simple binary capability15:13
sean-k-mooneystephenfin: we kind of hoped to stop using the alias and move pci deivce to the top level api or use cyborg15:14
ralonsohbut with this information in the port we don't need to limit that to sriov ports only15:14
sean-k-mooneywhich is why it was not added orginally15:14
stephenfini.e. I allow you to configure NUMA affinity of individual resources or I don't15:14
sean-k-mooneyralonsoh: right we are not15:14
sean-k-mooneythe trait is not technially need we can do the enforcement in the numa toplogy filter without it15:15
sean-k-mooneybut with out the trait we do that the proablem that plamcnet may not return hosts with the capablity if the limit is set too low15:15
stephenfinralonsoh: So I guess you're thinking we could have multiple child RPs, e.g. one for the OVS network, one for the SR-IOV device, one for a generic PCI device etc., and each could support their own type of policy?15:15
ralonsohthat's the goal15:16
sean-k-mooneywhich iw why we should have a trait but i guess it does not need to be 315:16
*** k_mouza has quit IRC15:16
stephenfinHmm, okay, that sounds reasonable. I'd been thinking the trait would be reported on the root provider (the compute node)15:16
stephenfinwhich makes little sense because you provide no granularity that way15:17
sean-k-mooneyby the way this is part of and bug 1780721 in openstack-nova "[RFE] Optional NUMA affinity for neutron ports" [High,New] - Assigned to smooney15:17 bug 1791834 in openstack-neutron "[RFE] Optional NUMA affinity for neutron ports" [High,New] - Assigned to amuller15:17
stephenfinsean-k-mooney: oh yeah, I understand and agree with the feature as a whole. It's just this trait bit that's tripping me up15:17
sean-k-mooneystephenfin: right now if we said we want strict affinity we have no way to guarrentee that15:18
sean-k-mooneybecasue placment if limit=10 could select 10 allocation candated form host that dont supprot numa affinity15:19
sean-k-mooneythe trait is basicaly to make it work in deployment like cerns where they have a really low limit15:19
stephenfinthe solution to that is NUMA in placement though, no?15:19
stephenfinmodel NUMA nodes as RPs in placement. Say all resources must share the same root RP (NUMA node)15:20
sean-k-mooneynuma in placmnet wont advertise which host have numa aware vswitches15:20
sean-k-mooneysince we dont model netowrk backend ports as a resouce15:20
*** k_mouza has joined #openstack-nova15:21
sean-k-mooneystephenfin: we would some how have to model the pysnet numa affinity in the rp tree15:21
ralonsohwe have this information in nova15:21
sean-k-mooneyyes but we cant model it in plamcnet15:22
ralonsohmore or less: you have the numa nodes of a physnet15:22
stephenfinsean-k-mooney: how does this help?15:22
sean-k-mooneyit just allow me to know the host has the feature15:22
sean-k-mooneyi guess we could have 3 different tratis.15:22
sean-k-mooneyone for numa-vsiwthc, one for sriov and one for numa affinity15:23
sean-k-mooneybut that feels messy15:23
stephenfinYou mean it has the NUMA-aware vSwitches feature enabled?15:23
openstackgerritJie Li proposed openstack/nova-specs master: add volume backed server rebuild spec
sean-k-mooneyif it was a non sriov port and it asked for strict affinity15:23
sean-k-mooneyit need to land on a host with numa aware vswtichs15:24
sean-k-mooneyor we shoudl reject it15:24
sean-k-mooneylegacy and prefer not require that15:24
sean-k-mooneybut strict means we have to guarrente numa affinity or not boot15:24
sean-k-mooneywe can do that in the numa toplogy filter proably15:25
*** gyee has joined #openstack-nova15:25
*** k_mouza has quit IRC15:25
sean-k-mooneybut then you have the cherry picking problem15:25
stephenfinso you're worried about NUMA-aware vSwitches being configured on some hosts and not others, and you want to makes sure instances never land on the latter15:25
stephenfinThe concern I have with that is that NUMA-aware vSwitches is a hack, and we knew it was a hack when we implemented it /o\15:26
sean-k-mooneyyes we wanted to evnetually move it to placment15:26
stephenfinand I'm concerned about encoding that hack into traits, which we can't ever drop15:26
sean-k-mooneywe dont actully need the traits right now15:27
stephenfincouldn't we just solve that particular issue with documentation?15:27
sean-k-mooneyso we can defer it15:27
sean-k-mooneyi wanted neutron to include the trait in the port resouce request15:27
sean-k-mooneybut we can have nova append it in the future if we want15:27
stephenfini.e. if you really care about NUMA affinity, make sure to configure this on all hosts or use host aggregates to separate from hosts without the config15:27
*** k_mouza has joined #openstack-nova15:28
sean-k-mooneymaybe it kind of feells like soemthing that should not need to be manual15:28
stephenfinI agree, but you could say the same about the NUMA-aware vSwitches feature in general15:28
sean-k-mooneywe did15:29
stephenfinTrue :)15:29
sean-k-mooneybe we also said we did not want to wait15:29
stephenfinbut it was a means to an end15:29
stephenfinI don't really want to pile more on top of that shaky foundation though15:29
stephenfinlike I said, we're stuck with traits once they're there15:29
sean-k-mooneyralonsoh: stephenfin ok so do we want to put the traits on pause untill we see if we will use them in the nova half of the feature15:29
ralonsohsean-k-mooney, np15:30
sean-k-mooneyralonsoh: what that means for you is you just dont need to add a trait request to the port15:30
stephenfinif that works for ralonsoh, I'd much rather that15:30
sean-k-mooneyand if nova want to use the traits in the futrue we can do it instead of neutorn15:30
ralonsohsean-k-mooney, but what should I add to the port info?15:30
stephenfinif it turns out we want a way to advertise these capabilities, then I'm all for revisiting15:30
ralonsohbecause I don't know how nova is going to read it15:30
sean-k-mooneyralonsoh: neutron need to add the polciy via the new extention15:31
sean-k-mooneybut it does not need to add the trait15:31
sean-k-mooneythe extenion was adding a new extended atibute to the port anyway right15:31
ralonsohsean-k-mooney, that means another parameter in the port dict15:31
ralonsohI'll need to revisit the spec15:31
sean-k-mooneyralonsoh: yes isnt that what the spec says15:31
*** k_mouza has quit IRC15:32
stephenfinralonsoh: again, apologies for only getting to this now. I didn't know that this work was as far along as it is. You've been busy :)15:32
ralonsohnp at all15:32
ralonsohI'll revisit the spec and the patches15:32
sean-k-mooneyoh its in the resouce attibute15:32
sean-k-mooneysorry no that is just an extend port attibute15:33
*** k_mouza has joined #openstack-nova15:33
sean-k-mooneyso im not sure you need to updat ehte spec other then to remove the port_resource['resource_request'] = {15:33
sean-k-mooney    'required': [os_traits.COMPUTE_NUMA_POLICY_REQUIRED]}15:33
ralonsohsean-k-mooney, I need to clean up this part yes15:34
sean-k-mooneynova will just read numa_affinity_policy field form the port and use that15:34
ralonsohperfect for me15:34
sean-k-mooneyralonsoh: i was worried that you were only going to pass the trait15:34
sean-k-mooneyralonsoh: that would not have been right from a nova point of view15:35
*** Luzi_ has quit IRC15:36
*** k_mouza has quit IRC15:37
*** mkrai has joined #openstack-nova15:42
sean-k-mooneystephenfin: by the way you also missed the mix hypervior usecase for the trait15:48
sean-k-mooneybut we can cross that bridge if we need too15:49
*** xek_ has joined #openstack-nova15:52
*** xek has quit IRC15:54
openstackgerritPavlo Shchelokovskyy proposed openstack/nova master: Raise 409 when removing security group from instance
*** hamalq has joined #openstack-nova16:03
*** hamalq has quit IRC16:03
*** hamalq has joined #openstack-nova16:04
openstackgerritsean mooney proposed openstack/nova master: Lookup nic feature by PCI address
sean-k-mooneyralonsoh: stephenfin by the way should i drop the funcitonal tests form the coverage job or make a coverage with sudo job for os-vif
stephenfindrop from coverage16:08
sean-k-mooneycool i can do that trivially16:08
ralonsohsean-k-mooney, why do you need to drop them?16:08
sean-k-mooneythe openstack-cover-jobs16:08
sean-k-mooneydoes not allow sudo to be used16:08
sean-k-mooneyso privsep fails16:09
sean-k-mooneyour functional tests actully need elevated right to run16:09
sean-k-mooneybecaue they acutlly use ovs16:09
sean-k-mooneywhich actully is alos not in stalled in that job16:09
sean-k-mooneyso ya if i want to run them i need a custom job that has sudo and installs ovs like our custom functional job16:10
ralonsohsean-k-mooney, you can take the neutron functional base one16:10
ralonsohif you want16:10
sean-k-mooneyno we have a base job for fucntional test16:11
*** tesseract has quit IRC16:11
ralonsohor this one yes16:11
sean-k-mooneybut i either need to inherit form that and chagne the env form functional to cover16:12
sean-k-mooneyor i drop the fucntional test16:12
sean-k-mooneyi was leaning to removing them so that you did not need sudo and ovs to run tox -e cover16:12
sean-k-mooneywe dont actully have covage report for os-vif currently so this is adding them16:13
*** udesale_ has quit IRC16:13
sean-k-mooneyjangutter: any opipion ^16:13
*** mgariepy has quit IRC16:14
sean-k-mooneyjangutter: question is shoudl os-vifs coverage tox enve run just unit test or unit and functional16:14
janguttersean-k-mooney: :reading:16:17
janguttersean-k-mooney: can we achieve full coverage with just unit tests? I'm almost leaning yeah.16:18
sean-k-mooneywe could16:18
sean-k-mooneyalthough that is not the goal16:18
sean-k-mooneybut i do want to more or less know what is and is not tested16:19
sean-k-mooney100% coverage is not need but if we are low in one module it would be good to look at why16:19
jangutterI agree - full coverage might might just be for bragging rights (and can be done badly). My feeling is that unit  testing should be slightly more than functional, but if we don't measure it we won't know it.16:22
sean-k-mooneyso are you ok with the coverage job just doing unit. i could add a second coverage-all that ran both16:23
sean-k-mooneyi would like to enable coverage by default when you run just tox16:23
sean-k-mooneybut if its runing the functional test i would prefer not to16:23
sean-k-mooneybasically i want you to be able to jsut git clone and then run "tox"16:24
sean-k-mooneywithout args and have it work16:24
jangutterSame for me: I tend to run just unit when I dev, but rely on the CI to run functional.16:24
sean-k-mooneyi run the fucnational test but not on my laptop16:24
sean-k-mooneyi do it in my devstack vms16:24
sean-k-mooneyso for small change i dont want to have to instlal ovs16:25
*** dtantsur is now known as dtantsur|afk16:25
openstackgerritSylvain Bauza proposed openstack/nova-specs master: Offline Reshape tool spec
jangutterI'm OK with adding more non-sudo stuff to the default tox run.16:26
sean-k-mooneyin os-vif the test are really fast so i was going to enable  py3,pep8,docs,releasenotes,cover16:27
sean-k-mooneyby default16:27
sean-k-mooneybasically that is what i would like peple to run before pushing16:28
jangutterI'm in agreement.16:29
sean-k-mooneyok ill remvoe the functional test from cover so for now at least16:30
sean-k-mooneystephenfin: jangutter ralonsoh as a head up i also want to change the default ovsdb backend in os-vif this cycle16:30
sean-k-mooneyi ment to do it af ew releases ago16:30
sean-k-mooneybut we are still defaulting to ovs-vsctl16:31
ralonsohsean-k-mooney, in os-vif?16:31
sean-k-mooneyralonsoh: ya16:31
ralonsohwe removed ovs-vsctl, we only have native now16:31
ralonsohin neutron16:31
sean-k-mooneyin neutron yes16:32
ralonsohjust to let you know16:32
sean-k-mooneywe never got around to doing it in os-vif16:32
sean-k-mooneyit was planed for train16:32
sean-k-mooneybut we forot to defualt in trian and hten remove in ussui16:32
ralonsohit doesn't makes sense to keep both16:32
sean-k-mooneyso im going to push a patch to do it now in victoria and remove in W16:32
sean-k-mooneyi would remove it now but we have to have a deprecation cycle16:33
ralonsohat least default to native, I think so16:33
sean-k-mooneyyep anyway ill push a patch for that shortly16:34
sean-k-mooneyjust tought ye would like to know16:34
*** slaweq has quit IRC16:37
*** jsuchome has quit IRC16:41
sean-k-mooneyis this pep failure new
sean-k-mooneylooks like py38 and pyflakes are unhappy16:43
*** links has quit IRC16:44
stephenfinsean-k-mooney: tox -e pep8 --recreate16:46
stephenfinyou're using an old version of the library, I suspect16:46
stephenfinthat or constraints isn't properly set up16:46
sean-k-mooneyi did recreate it16:47
sean-k-mooneybut i might need to rebase16:47
sean-k-mooneyoh this is the train branch16:47
sean-k-mooneyim backporting16:47
sean-k-mooneyit need python 3.616:47
sean-k-mooneyon train not 3.816:48
gmannsean-k-mooney: for 3.8 you need pyflakes 2.1.1 as min16:49
sean-k-mooneyya i just happened to use one of my 20.04 ubuntu vms to do the backport and i forgot it does not have a python old enough to run the train env16:49
stephenfinFedora has multiple Python versions...16:50
sean-k-mooneyi could update it to 2.1.116:50
openstackgerritHarshavardhan Metla proposed openstack/nova master: Raising a failure in case of 403
*** derekh has quit IRC16:50
sean-k-mooneyubunutu normally does as well16:50
sean-k-mooneyi just did not want to instal older ones16:50
*** ociuhandu_ has quit IRC17:02
*** ociuhandu has joined #openstack-nova17:09
*** mkrai has quit IRC17:14
openstackgerritStephen Finucane proposed openstack/nova master: tests: Add reproducer for bug #1889633
openstackbug 1889633 in OpenStack Compute (nova) ussuri "Pinned instance with thread policy can consume VCPU" [High,Triaged]
openstackgerritStephen Finucane proposed openstack/nova master: hardware: Reject requests for no hyperthreads on hosts with HT
stephenfinsean-k-mooney: ^17:14
*** ociuhandu has quit IRC17:14
stephenfinNeeds a unit test, I suspect. Will address tomorrow17:14
stephenfinFor now, run ti,me17:15
*** xek has joined #openstack-nova17:25
*** xek_ has quit IRC17:29
*** sapd1 has quit IRC17:29
*** mriedem has left #openstack-nova17:40
*** mgariepy has joined #openstack-nova17:41
openstackgerritHarshavardhan Metla proposed openstack/nova master: Removed the host FQDN from the exception message
*** ralonsoh has quit IRC18:00
sean-k-mooneystephenfin: one suggestion inline and a request for a release note18:10
sean-k-mooneystephenfin: but ya that should work, i think it can be slightly cleaner18:11
sean-k-mooneyare we ment to include a release not with every bug fix by the way18:13
sean-k-mooneyi forget if its all fixes or just some18:13
sean-k-mooneyi kind of feel like i shoudl ask for one but its also a 6 line patch so it also feels like over kill18:14
sean-k-mooneyit is for a public security hardening bug however which is why i think operator might care to see it in a release note18:15
openstackLaunchpad bug 1851587 in OpenStack Compute (nova) "HypervisorUnavailable error leaks compute host fqdn to non-admin users" [Undecided,In progress] - Assigned to Harshavardhan Metla (harsha24)18:15
openstackgerritHarshavardhan Metla proposed openstack/nova master: Moved the quoted section
*** maciejjozefczyk has quit IRC19:13
*** maciejjozefczyk has joined #openstack-nova19:13
openstackgerritMerged openstack/nova stable/ussuri: Handle multiple 'vcpusched' elements during live migrate
openstackgerritLee Yarwood proposed openstack/nova stable/train: Handle multiple 'vcpusched' elements during live migrate
*** martinkennelly has quit IRC19:45
*** maciejjozefczyk has quit IRC19:58
*** xek has quit IRC20:31
*** vishalmanchanda has quit IRC20:39
*** ociuhandu has joined #openstack-nova20:46
*** ociuhandu_ has joined #openstack-nova21:04
*** ociuhandu has quit IRC21:06
*** ociuhandu_ has quit IRC21:10
*** ociuhandu has joined #openstack-nova21:11
*** nweinber has quit IRC21:20
*** eharney has quit IRC21:28
*** raildo has quit IRC21:29
*** kaisers1 has joined #openstack-nova21:56
*** kaisers has quit IRC21:57
*** tkajinam has joined #openstack-nova22:05
openstackgerritsean mooney proposed openstack/nova master: Lookup nic feature by PCI address
openstackgerritGhanshyam Mann proposed openstack/os-vif master: [goal] migrate testing to ubuntu focal
*** rcernin has joined #openstack-nova23:13
*** rcernin has quit IRC23:14
*** rcernin has joined #openstack-nova23:14
*** tosky has quit IRC23:14
openstackgerritMerged openstack/nova master: libvirt: Remove blockjob.end == 0 workaround resolved in libvirt v2.3.0
openstackgerritMerged openstack/nova master: compute: Validate a BDMs disk_bus when provided
*** mlavalle has quit IRC23:31
*** artom has quit IRC23:32
*** hemna has quit IRC23:33
*** hemna has joined #openstack-nova23:38
openstackgerritMerged openstack/nova master: func: Add live migration rollback volume attachment tests
openstackgerritMerged openstack/nova master: Add regression tests for bug #1889108
openstackbug 1889108 in OpenStack Compute (nova) "failures during driver.pre_live_migration remove source attachments during rollback" [High,In progress] - Assigned to Lee Yarwood (lyarwood)23:40
*** artom has joined #openstack-nova23:40
*** tetsuro has joined #openstack-nova23:53

Generated by 2.17.2 by Marius Gedminas - find it at!