Friday, 2020-08-07

*** eharney has quit IRC00:05
*** bbowen has quit IRC00:07
*** grandchild has quit IRC00:13
*** eharney has joined #openstack-nova00:19
*** tetsuro has joined #openstack-nova00:33
*** brinzhang_ has joined #openstack-nova00:40
*** brinzhang0 has quit IRC00:42
*** rambo_li has joined #openstack-nova01:06
*** Liang__ has joined #openstack-nova01:15
*** hamalq has quit IRC01:28
*** rambo_li has quit IRC01:46
openstackgerritBrin Zhang proposed openstack/nova master: [Trivial] Remove wrong format_message() conversion  https://review.opendev.org/74428002:04
*** sapd__x has joined #openstack-nova02:27
*** markvoelker has joined #openstack-nova02:31
*** markvoelker has quit IRC02:35
*** markvoelker has joined #openstack-nova02:37
*** jmlowe has quit IRC02:42
*** markvoelker has quit IRC02:47
*** sapd1_x has quit IRC02:59
*** mkrai has joined #openstack-nova03:02
*** psachin has joined #openstack-nova03:31
*** dave-mccowan has quit IRC03:46
openstackgerritTony Su proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs  https://review.opendev.org/67602904:07
openstackgerritTony Su proposed openstack/nova master: Provider Config File: Functions to merge provider configs to provider tree  https://review.opendev.org/67652204:07
openstackgerritTony Su proposed openstack/nova master: Provider Config File: Enable loading and merging of provider configs  https://review.opendev.org/69346004:07
*** ratailor has joined #openstack-nova04:28
*** markvoelker has joined #openstack-nova04:31
*** evrardjp has quit IRC04:33
*** evrardjp has joined #openstack-nova04:33
*** markvoelker has quit IRC04:36
*** vishalmanchanda has joined #openstack-nova04:44
openstackgerritLuyao Zhong proposed openstack/nova master: introduce a new driver interface 'cleanup_instance'  https://review.opendev.org/71465304:47
openstackgerritLuyao Zhong proposed openstack/nova master: track error migrations in resource tracker  https://review.opendev.org/74528104:47
openstackgerritLuyao Zhong proposed openstack/nova master: track orphans in resource tracker  https://review.opendev.org/74528204:47
*** gyee has quit IRC04:48
*** udesale has joined #openstack-nova05:24
*** links has joined #openstack-nova05:27
*** tkajinam has quit IRC05:34
*** tkajinam has joined #openstack-nova05:35
*** tkajinam has quit IRC05:50
*** tkajinam has joined #openstack-nova05:51
*** yedongcan has joined #openstack-nova05:57
*** yaawang has quit IRC06:01
*** yaawang has joined #openstack-nova06:01
*** markvoelker has joined #openstack-nova06:21
*** markvoelker has quit IRC06:26
*** redrobot has quit IRC06:37
*** mkrai has quit IRC06:48
*** mkrai_ has joined #openstack-nova06:48
*** yedongcan has quit IRC06:52
*** mkrai_ has quit IRC06:57
openstackgerritLuyao Zhong proposed openstack/nova master: track error migrations in resource tracker  https://review.opendev.org/74528106:59
openstackgerritLuyao Zhong proposed openstack/nova master: track orphans in resource tracker  https://review.opendev.org/74528206:59
gibigood morning07:11
*** bhagyashris is now known as bhagyashris|off07:13
*** mvorwerk has joined #openstack-nova07:16
*** tetsuro has quit IRC07:17
*** tesseract has joined #openstack-nova07:19
*** k_mouza has joined #openstack-nova07:27
*** k_mouza has quit IRC07:27
*** dougsz has joined #openstack-nova07:33
tony_sustephenfin: gibi: alex_xu: new provider-config-file patches uploaded change log 1) all comments except one in the last patch relected in code or answered 2) add docstring for each test case07:38
tony_suunfortunately, so far I don't know how to use nova-manage command to help provider config.07:39
tony_sustephenfin: does it mean we need to upgrade nova-manage command to offer some new option to validate the validity of provider.yaml file?07:42
tony_sufor this comment https://review.opendev.org/#/c/693460/35/doc/source/admin/managing-resource-providers.rst@20507:42
*** yaawang has quit IRC07:45
*** yaawang has joined #openstack-nova07:46
*** slaweq has joined #openstack-nova07:50
*** markvoelker has joined #openstack-nova07:51
*** Liang__ has quit IRC07:51
stephenfintony_su: Yeah, exactly. I'm thinking we simply add a command (e.g. 'nova-manage placement validate-schema $SCHEMA') that attempts to load the provided schema and provides an error code and message if it's not valid07:52
*** brinzhang0 has joined #openstack-nova07:52
tony_suMust we do it this time or can we do it later? I am not fairly faimiliar with nova-manage command and I dont' know how long it can be done.07:53
tony_suI am a little bit worried we will miss Victoria if do so.07:54
*** ralonsoh has joined #openstack-nova07:54
*** brinzhang_ has quit IRC07:55
*** markvoelker has quit IRC07:56
*** Liang__ has joined #openstack-nova08:00
*** tosky has joined #openstack-nova08:04
*** ratailor has quit IRC08:21
*** sapd__x has quit IRC08:27
*** yaawang has quit IRC08:32
*** yaawang has joined #openstack-nova08:33
*** martinkennelly has joined #openstack-nova08:36
gibitony_su, stephenfin: I'm fine handling the nova-manage part as an addition on top of the series as I don't consider that as a blocker for the feature to merge. Let's focuse on merging what is ready (I know I should spend some time reviewing that series too).08:40
*** tetsuro has joined #openstack-nova08:41
*** tetsuro has quit IRC08:41
*** derekh has joined #openstack-nova08:52
*** ociuhandu has joined #openstack-nova08:56
*** ociuhandu_ has quit IRC08:57
*** markvoelker has joined #openstack-nova09:04
openstackgerritStephen Finucane proposed openstack/os-vif master: mypy: Add type annotations  https://review.opendev.org/74516209:07
openstackgerritStephen Finucane proposed openstack/os-vif master: mypy: Extend type annotations to 'vif_plug_noop'  https://review.opendev.org/74516309:07
*** markvoelker has quit IRC09:09
*** jangutter has joined #openstack-nova09:12
*** mkrai has joined #openstack-nova09:12
*** jangutter_ has quit IRC09:14
*** tkajinam has quit IRC09:17
*** ratailor has joined #openstack-nova09:24
*** dtantsur|afk is now known as dtantsur09:30
tony_sugibi: stephenfin has been doing great, detailed review for each patch.  your review can still effectively speedup our progress...09:31
*** ratailor_ has joined #openstack-nova09:32
*** k_mouza has joined #openstack-nova09:33
*** ratailor has quit IRC09:35
kashyaplyarwood: Can you remind me, please: does Nova stash 'host-capabilities' somewhere?09:36
kashyapIt does, IIRC09:37
lyarwoodkashyap: hmm I know we grab them at startup09:38
kashyaplyarwood: Damn09:38
kashyaplyarwood: So the problem I'm debugging w/ a TripleO upgrade dev is this:09:38
lyarwoodkashyap: it doesn't look like we stash them anywhere09:39
lyarwoodkashyap: we appear to be grabbing a fresh copy from libvirt everytime we need them09:40
kashyaplyarwood: Hmm.  Got a code pointer?09:40
lyarwoodkashyap: https://paste.centos.org/view/86fa486009:42
kashyaplyarwood: Excellent!  That helped09:44
kashyaplyarwood: Context:09:44
kashyaplyarwood: During FFU, some hosts report the CPU feature 'arch-facilities' (to make matters worse, it's called differently on EL8: 'arch-capabilities')09:45
kashyaplyarwood: So migration from EL7 to EL8 fails (on appropriate hardware) with: "libvirt.libvirtError: internal error: Unknown CPU feature arch-facilities"09:45
kashyaplyarwood: To 'workaround' that, we need to disable the 'arch-facilities' on the source host09:45
lyarwoodkashyap: isn't that a libvirt bug?09:46
kashyaps/disable/comment-out09:46
lyarwoodkashyap: ah wait, is it the way we generate the xml on the src?09:46
*** jangutter has quit IRC09:46
kashyaplyarwood: No, it's not :-(  I talked w/ Jiri Denemark today09:46
kashyapIn short, we (Nova) need to improve on how we're doing CPU checks.  Some checks are redundant (as libvirt does them anyway)09:46
*** jangutter has joined #openstack-nova09:46
lyarwoodkashyap: we can handle that in https://github.com/openstack/nova/blob/9ecefeb836964c52a5a2969b15c82b11c51d32ab/nova/virt/libvirt/migration.py#L56-L7009:46
kashyaplyarwood: Yeah, indeed.  The guest XML itself doesn't have 'arch-facilities'09:47
kashyaplyarwood: /me clicks09:50
*** viks____ has joined #openstack-nova09:50
* kashyap should make some time to omplement this - https://opendev.org/openstack/nova-specs/commit/70811da221035044e2709:50
kashyaplyarwood: So, let me explain the sequence of the current workaround:09:52
* kashyap types in an editor and pastes it here09:52
kashyap1. Double-check none of the EL7 instance XML contain 'arch-facilities' CPU feature.  Normally, the guests do _not_ have them.09:59
kashyap2. Run `virsh capabilities | grep arch-facilities` — it will be present09:59
kashyap3. Comment out 'arch-facilties' in /usr/share/libvirt/cpu_share.xml09:59
kashyap4. Restart 'libvirtd' and 'nova-compute' service (both are needed)09:59
kashyap5. Then run `virsh capabilities`, again: it will now be absent (expected)09:59
kashyap6. Now migrate the guest from EL7 to EL8: it _must_ succeed.09:59
kashyap(The above is when migrating only from source hardware that supports 'arch-facilities' CPU feature.)09:59
lyarwoodurgh we need to fix this in Nova tbh10:01
lyarwoodwe can check on the dest if arch-capabilities is set10:02
lyarwoodif it is, use it in the migration xml we send there10:02
lyarwoodif it isn't but arch-facilities is set on the src, remove that from the migration xml10:03
lyarwooddoes that sound right?10:03
kashyaplyarwood: Reading the scroll10:05
lyarwoodbrb coffee10:05
kashyaplyarwood: Right, that does sound correct.  I'm gonna file a bug for it10:06
kashyaplyarwood: Oh, but note: 'arch-facilties' is marked as *non-migratable*10:06
lyarwood /o\10:10
lyarwoodso should we always remove it?10:10
kashyaplyarwood: I'd change the plan to this: just drop 'arch-facilities' and let libvirt handle it — this works, Jiri from libvirt confirms10:12
* kashyap --> lunch; bbiab10:12
lyarwoodkashyap: ack that's simple enough then10:13
lyarwoodkashyap: as you're out on PTO next week I'd be happy to handle that once you've written up the bug10:15
openstackgerritStephen Finucane proposed openstack/nova master: Follow up for Ibf8dca4bd57b3bddb39955b53cc03564506f5754  https://review.opendev.org/74509510:22
openstackgerritStephen Finucane proposed openstack/nova master: tests: Add helpers for suspend, resume and reboot of server  https://review.opendev.org/74128510:25
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Pass context, instance to '_create_guest'  https://review.opendev.org/74128610:25
openstackgerritStephen Finucane proposed openstack/nova master: api: Reject non-spawn operations for vTPM  https://review.opendev.org/74150010:25
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Add emulated TPM support to Nova  https://review.opendev.org/63136310:25
openstackgerritStephen Finucane proposed openstack/nova master: docs: Add docs for vTPM support  https://review.opendev.org/73921310:25
openstackgerritStephen Finucane proposed openstack/nova master: Add type hints to 'nova.compute.manager'  https://review.opendev.org/74286310:25
openstackgerritStephen Finucane proposed openstack/nova master: Don't unset Instance.old_flavor, new_flavor until necessary  https://review.opendev.org/74199510:25
openstackgerritStephen Finucane proposed openstack/nova master: privsep: Add support for recursive chown, move_tree operations  https://review.opendev.org/74286410:25
openstackgerritStephen Finucane proposed openstack/nova master: Add type hints to 'nova.virt.libvirt.utils'  https://review.opendev.org/74286510:25
openstackgerritStephen Finucane proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files  https://review.opendev.org/63993410:25
kashyaplyarwood: A quick one, without checking the code, the migrate XML - is it the one we send to _compare_cpu() method or to libvirt's migrate API?10:30
kashyaplyarwood: I'll let you know once I've got the bug up...10:31
lyarwoodkashyap: libvirt's migrate API10:32
lyarwoodkashyap: is this failing in _compare_cpu?10:33
kashyaplyarwood: Yep, the failure is indeed from _compare_cpu()10:33
kashyapThis whole thing needs replacing; see my earlier-mentinoned spec on newer APIs.  I've got a draft patch branch for it somewhere (https://opendev.org/openstack/nova-specs/commit/70811da221035044e27)10:34
kashyapBut the "full replacing" can wait.  One step at a time10:34
kashyaplyarwood: Oh, sigh; 'arch-facilities' is a EL-only thing :-(10:35
lyarwood\o/10:35
kashyaplyarwood: So, I don't think it makes sense for upstream; perhaps a EL-8 downstream-specific patch is needed10:35
lyarwoodggwp libvirt10:35
kashyaplyarwood: Yeah, annoying:10:36
kashyap[quote]10:36
kashyap The kernel calls this feature arch_capabilities and RHEL/CentOS 7.* use10:36
kashyaparch-facilities. Apparently some CPU test files were gathered with the10:36
kashyapRHEL version of QEMU. Let's update the test files to avoid possible10:36
kashyapconfusion about the correct naming.10:36
kashyap[/quote]10:36
kashyapFrom here: https://libvirt.org/git/?p=libvirt.git;a=commit;h=511df17aec10:36
kashyapErr, wrong link10:36
kashyapNo, that's correct.  (Self, slow down)10:37
*** artom has quit IRC10:40
*** k_mouza has quit IRC10:43
*** k_mouza has joined #openstack-nova10:51
*** jangutter_ has joined #openstack-nova10:57
*** Liang__ has quit IRC10:58
*** jangutter has quit IRC11:00
*** markvoelker has joined #openstack-nova11:05
*** markvoelker has quit IRC11:10
*** jangutter has joined #openstack-nova11:12
*** jangutter_ has quit IRC11:15
*** stephenfin has quit IRC11:29
*** bbowen has joined #openstack-nova11:37
*** stephenfin has joined #openstack-nova11:38
*** artom has joined #openstack-nova11:43
*** k_mouza has quit IRC11:46
*** ociuhandu has quit IRC11:47
*** ociuhandu has joined #openstack-nova11:48
sean-k-mooneykashyap: we do cache the host capablities i belive too. i think i added that11:52
sean-k-mooneykashyap: but this is a downstream only bug anyway so not really  an issue with caching11:53
sean-k-mooneywell i think we cache the domain caps11:54
sean-k-mooneywhich is slitghly different11:54
*** k_mouza has joined #openstack-nova11:56
sean-k-mooneywe cache both https://github.com/openstack/nova/blob/stable/train/nova/virt/libvirt/host.py#L693-L84311:56
kashyapYeah, domain caps is different from host capabilities11:57
kashyap'virsh capabilities' vs. 'virsh domcapabilities'11:57
kashyapConfusing11:57
sean-k-mooneyyep11:57
sean-k-mooneyi know11:57
sean-k-mooneywe cache both11:57
*** vishalmanchanda has quit IRC11:58
sean-k-mooneylooks like we have cached the host capabilities since danpb added the function11:59
sean-k-mooneylibvirt caches the data too in the drivers so its not going to chagne without restart the libvirt deamon anyway11:59
*** k_mouza has quit IRC12:00
*** mkrai has quit IRC12:02
openstackgerritBalazs Gibizer proposed openstack/nova master: Add new default roles in FIP policies  https://review.opendev.org/74203012:05
openstackgerritBalazs Gibizer proposed openstack/nova master: Pass the actual target in FIP policy  https://review.opendev.org/74257012:06
*** brinzhang0 has quit IRC12:08
*** JamesBenson has joined #openstack-nova12:23
*** stephenfin has quit IRC12:24
*** rcernin has quit IRC12:32
*** stephenfin has joined #openstack-nova12:33
gibiand now I clogged the gate with all the open, and now approved, policy patches12:33
gibihappy Friday :D12:33
sean-k-mooney:)12:34
*** ratailor_ has quit IRC12:43
*** udesale_ has joined #openstack-nova12:44
*** udesale has quit IRC12:47
*** takamatsu has quit IRC12:52
*** jangutter_ has joined #openstack-nova12:54
*** jangutter has quit IRC12:58
*** jmlowe has joined #openstack-nova13:00
*** rcernin has joined #openstack-nova13:32
mnaseri'm trying to clean up our configs and start using the service catalog for auto discovery of services in nova13:36
mnaser(to stop using glance api_servers)13:36
mnaser"NOTE: The preferred mechanism for endpoint discovery is via keystoneauth1 loading options. Only use api_servers if you need multiple endpoints and are unable to use a load balancer for some reason."13:37
mnaserdoes this mean i would fill this up like the neutron section?13:37
mnaseror is there a common section?  the docs don't seem clera there13:37
*** rcernin has quit IRC13:37
sean-k-mooneyare you using haproxy infront of glance api13:40
sean-k-mooneyor are you listing multiple glance api_servers13:40
sean-k-mooneymnaser: you will have to fill it in if you are using nova as a loadbalncer for the glance api but ideally you would not use that and instead just deploy haproxy13:41
sean-k-mooneywicch you proably are already doing for other services13:41
mnasersean-k-mooney: we already have haproxy :) i mainly just dont wanna hardcode the api_servers value and let nova do service discovery13:43
*** dave-mccowan has joined #openstack-nova13:44
mnaserso pretty much just want nova to use the value inside the service catalog13:45
sean-k-mooneymnaser: yep that is what we woudl prefer peopel to do too. some want to remove that config option but other find it useful in small edge deployments13:45
gmannthanks gibi or all the reviews on policy work and updating FIP one.13:45
gibigmann: thanks for proposing these patches13:45
sean-k-mooneymnaser: the vaule in the service catalog will have to point to the ha proxy ip13:46
gmanngibi: I will do the audit of some TODO/cleanup if there us any by Monday/Tuesday and then we can mark that BP complete.13:46
mnasersean-k-mooney: so i guess i just have to put in credentials in there the same way that the [neutron] section is filled out with a username/pw/etc?13:47
sean-k-mooneymnaser: you cant list the mupltile api service in the catalonge and get teh same loadbalncing behavior13:47
gibigmann: cool. thanks13:47
mnasersean-k-mooney: right, but in my case, we use k8s and the internal api endpoint will always forward to one of the three pods running glance (serviceip)13:47
sean-k-mooneyah ok ya that works13:48
mnaserit would be nice if we can have one section that nova uses for all services13:48
mnaserfor those deployments where it makes sense13:48
sean-k-mooneythen i think ya you just need to set the auth values but not set the api url13:48
mnaserwhat's interesting is my current glance section actually has no credentials, only api_servers13:49
sean-k-mooneyyou might be able to abuse service user for that13:49
mnaserso i wonder where the credentials is being used13:49
sean-k-mooneymost of the time it would use the users token and not need them13:49
sean-k-mooneyfor neutron we do some admin only api calls which need it13:49
mnaseroh yes you're right, i forgot about that13:50
sean-k-mooneyfor glance i did not think we did but maybe we do for multiple locations13:50
mnaseri think that uses the service_user codebase,13:50
sean-k-mooneyi think the rbd direct url/ multi location stuff is either admin only or configurable13:51
mnaseryou can configure glance to expose the url13:51
mnaserso i think its not necessarily13:51
sean-k-mooneyso what i was suggesting with service_user was13:51
sean-k-mooneyif you did not set any other admin auth tokens13:51
sean-k-mooneyim not sure if setting service_user config options would be enough13:52
sean-k-mooneyif you use the same admin user for all services that is13:52
sean-k-mooneyi have never really checked if that would work.13:52
mnasersean-k-mooney: im actually hoping for a world where we deploy services using app credentials13:53
mnaserbased off the main 'admin' user13:53
mnaseressentially its the same thing anyways13:53
sean-k-mooneymnaser: that technical shoudl already work right13:55
*** jangutter_ has quit IRC13:55
sean-k-mooneywhen you create app creds dont you get a new user name and passward you could use13:55
sean-k-mooneyor do you jsut get a bearer token13:56
*** gokhani has quit IRC13:56
*** jangutter has joined #openstack-nova13:56
sean-k-mooneyits been quite a while since i looked at them13:56
*** k_mouza has joined #openstack-nova13:56
sean-k-mooneybut ya that would be quite nice if it coudl be made to work13:57
sean-k-mooneymnaser: https://docs.openstack.org/keystoneauth/latest/authentication-plugins.html13:58
mnasersean-k-mooney: it actually should 100% work :)13:59
mnaserkeystoneauth does support it yeah13:59
*** ociuhandu_ has joined #openstack-nova14:00
*** ociuhandu has quit IRC14:01
openstackgerritStephen Finucane proposed openstack/nova master: tests: Add reproducer for bug #1879878  https://review.opendev.org/74495014:07
openstackbug 1879878 in OpenStack Compute (nova) "VM become Error after confirming resize with Error info CPUUnpinningInvalid on source node " [Medium,In progress] https://launchpad.net/bugs/1879878 - Assigned to Stephen Finucane (stephenfinucane)14:07
openstackgerritStephen Finucane proposed openstack/nova master: Don't unset Instance.old_flavor, new_flavor until necessary  https://review.opendev.org/74495814:07
openstackgerritStephen Finucane proposed openstack/nova master: compute: Add type hints for resize functions  https://review.opendev.org/74534114:07
*** k_mouza has quit IRC14:14
*** k_mouza has joined #openstack-nova14:15
*** martinkennelly has quit IRC14:25
*** sapd__x has joined #openstack-nova14:28
lyarwoodelod: https://review.opendev.org/#/q/topic:bug/1889108+status:open - would you have anytime to look at this today14:31
lyarwoodelod: I'm including a number of func test refactors here as I'd like to keep things sane going back to stable/train14:31
openstackgerritMerged openstack/nova master: Add test coverage of tenant networks policies  https://review.opendev.org/74276514:37
openstackgerritMerged openstack/nova master: Introduce scope_types in tenant networks policy  https://review.opendev.org/74276614:38
openstackgerritMerged openstack/nova master: Add new default roles in tenant networks policies  https://review.opendev.org/74277114:38
openstackgerritMerged openstack/nova master: Add test coverage of security_groups policies  https://review.opendev.org/74272614:38
openstackgerritMerged openstack/nova master: Introduce scope_types in security_groups policy  https://review.opendev.org/74275714:38
*** dklyle has quit IRC14:40
*** david-lyle has joined #openstack-nova14:40
elodlyarwood: sure, looking!14:40
*** david-lyle is now known as dklyle14:41
lyarwoodelod: thanks! :)14:41
*** psachin has quit IRC14:58
*** Guest7899 has joined #openstack-nova15:03
*** Guest7899 is now known as redrobot15:06
*** ralonsoh has quit IRC15:08
*** ralonsoh has joined #openstack-nova15:08
gibiI'm wrapping up my week now. I'll be on PTO during the next two weeks. See you around 24th!15:24
*** gibi is now known as gibi_pto15:24
*** gibi_pto is now known as gibi_pto_til_24t15:24
*** gibi_pto_til_24t is now known as gibi_pto_24th15:24
*** mkrai has joined #openstack-nova15:28
*** rcernin has joined #openstack-nova15:34
*** rcernin has quit IRC15:38
openstackgerritMerged openstack/nova master: Add new default roles in security_groups policies  https://review.opendev.org/74276315:53
openstackgerritMerged openstack/nova master: Pass the actual target in security_groups policy  https://review.opendev.org/74276415:53
openstackgerritMerged openstack/nova master: Add test coverage of networks policies  https://review.opendev.org/74255815:53
openstackgerritMerged openstack/nova master: Introduce scope_types in networks policy  https://review.opendev.org/74256115:53
openstackgerritMerged openstack/nova master: Add test coverage of volumes policies  https://review.opendev.org/74277315:53
openstackgerritMerged openstack/nova master: Introduce scope_types in volumes policy  https://review.opendev.org/74277415:53
*** bbowen has quit IRC15:56
*** JamesBenson has quit IRC15:57
openstackgerritMerged openstack/nova master: Add new default roles in volumes policies  https://review.opendev.org/74277715:58
*** bbowen has joined #openstack-nova15:58
*** dougsz has quit IRC16:02
*** dtantsur is now known as dtantsur|afk16:04
*** mkrai has quit IRC16:07
*** eharney has quit IRC16:08
elodlyarwood: all good and +2'd :]16:10
*** dtantsur|afk has quit IRC16:11
*** hamalq has joined #openstack-nova16:12
*** hamalq has quit IRC16:13
*** hamalq has joined #openstack-nova16:13
*** sapd__x has quit IRC16:14
*** tesseract has quit IRC16:25
openstackgerritMerged openstack/nova master: Add test coverage of hosts policies  https://review.opendev.org/74301316:29
*** udesale_ has quit IRC16:41
*** tbachman has quit IRC17:00
*** derekh has quit IRC17:01
*** tbachman has joined #openstack-nova17:01
*** ralonsoh has quit IRC17:02
*** suryasingh has quit IRC17:03
*** k_mouza has quit IRC17:06
*** links has quit IRC17:09
openstackgerritElancheran S proposed openstack/nova master: Removes the delta file once image is extracted  https://review.opendev.org/73442117:14
*** tbachman_ has joined #openstack-nova17:14
*** tbachman has quit IRC17:16
*** tbachman_ is now known as tbachman17:16
openstackgerritMerged openstack/nova master: Introduce scope_types in hosts policy  https://review.opendev.org/74301417:18
lyarwoodelod: thanks :)17:19
smcginnisAnyone know if the AOE and DISCO libvirt volume drivers are still used/supported?17:26
smcginnisThey were both dropped from Cinder a long, long time ago.17:26
smcginnisI was looking at cleaning up some remnants in os-brick, but it looks like there is still some code present in nova.17:27
sean-k-mooneysmcginnis: if they were droped form cinder then its dead code17:31
lyarwoodI think they are only in nova because they were in cinder and os-brick so rm -rf away17:31
lyarwoodyeah17:31
sean-k-mooneysmcginnis: nova only uses os-brick for cinder volumes. if the cinder backend is remvoe then the nova code is nolonger useful in general unlesss the code is shared17:32
sean-k-mooneyalso wehn i see AOE i think fo Age of Empires17:33
lyarwoodsame haha17:34
melwittArea Of Effect17:35
lyarwood^_^17:41
*** mvorwerk has quit IRC17:42
openstackgerritGhanshyam Mann proposed openstack/nova master: migrate testing to ubuntu focal  https://review.opendev.org/73812617:43
*** k_mouza has joined #openstack-nova17:44
*** mvorwerk has joined #openstack-nova17:45
*** k_mouza has quit IRC17:49
openstackgerritMerged openstack/nova master: Add new default roles in hosts policies  https://review.opendev.org/74301517:54
openstackgerritMerged openstack/nova master: Add test coverage of extensions policies  https://review.opendev.org/74304517:54
lyarwoodmelwitt: https://review.opendev.org/#/q/topic:bug/1889108+status:open - would you mind taking a look at that today if you have time18:01
melwittlyarwood: sure thing18:01
lyarwoodthanks18:02
smcginnissean-k-mooney, lyarwood: Thanks, sounds good.18:06
smcginnisDo you think it needs to go through a deprecation cycle in nova? Or since it's just dead code anyway, all clear to just clean it out?18:06
lyarwoodsmcginnis: I think we can just remove it tbh18:08
smcginnisSounds good. I'll put up something to do that. Then we can see if anyone has any objects on the patch.18:09
lyarwoodsmcginnis: the only way of loading these volume drivers is through cinder providing connection_info with driver_volume_type set to aoe or disco https://github.com/openstack/nova/blob/09ed4c21db5005b1c699a87bfb0e7cb051553342/nova/virt/libvirt/driver.py#L1593-L159718:09
lyarwoodsmcginnis: if the c-vol drivers are dead then that can't happen18:09
smcginnisAh, that's how that works. Thanks, I've never dug into the nova side of these things.18:09
smcginnisSo this really has been dead code for quite awhile then.18:10
lyarwoodyup18:10
lyarwoodsmcginnis: actually thinking about it they were dropped more than a release ago from cinder right?18:11
* lyarwood was thinking about the upgrade case18:11
smcginnisYeah. Like Ocata for some.18:11
lyarwoodha18:11
lyarwoodokay rm -rf away sorry18:11
smcginnisThere might be more than those two, but if there's anything I see that hasn't been gone since at least Stein, I'll leave it for later cleanup.18:12
lyarwoodsmcginnis: are the removals from cinder tracked anywhere outside of the releasenotes btw? Like an easy to read support table or something18:15
smcginnisWe've started just marking them as unsupported, so there haven't been any new removals for at least a cycle now.18:16
smcginnisI think we did document the older ones though. Let me see if I can find that.18:16
smcginnisProbably incomplete though. I had to dig a bit to even figure out what the AOE connector was.18:17
smcginnis(assumed we didn't connect to the game ;) )18:17
lyarwoodhaha18:20
openstackgerritMerged openstack/nova master: Add test coverage of FIP pools policies  https://review.opendev.org/74179518:23
openstackgerritMerged openstack/nova master: Add test coverage of baremetal nodes policies  https://review.opendev.org/74170718:23
smcginnislyarwood: Some incomplete driver removal history: https://docs.openstack.org/cinder/latest/reference/support-matrix.html#driver-removal-history18:33
openstackgerritMerged openstack/os-vif master: [goal] migrate testing to ubuntu focal  https://review.opendev.org/73813018:36
lyarwoodsmcginnis: thanks18:42
*** bjolo has quit IRC18:42
openstackgerritSean McGinnis proposed openstack/nova master: Remove dead volume driver code  https://review.opendev.org/74539319:01
*** slaweq has quit IRC19:03
*** slaweq has joined #openstack-nova19:06
*** viks____ has quit IRC19:10
openstackgerritMerged openstack/nova master: Fix multinic policy for admin_or_owner  https://review.opendev.org/74231719:30
openstackgerritMerged openstack/nova master: Add test coverage of multinic policies  https://review.opendev.org/74231519:30
openstackgerritMerged openstack/nova master: Pass the actual target in tenant networks policy  https://review.opendev.org/74277219:30
openstackgerritMerged openstack/nova master: Introduce scope_types in FIP pools  https://review.opendev.org/74179619:30
*** KeithMnemonic has quit IRC19:31
*** mloza has joined #openstack-nova19:32
openstackgerritMerged openstack/nova master: Introduce scope_types in baremetal node  https://review.opendev.org/74170919:38
mlozahello, I have running instance which is launched with a invalid AZ and now, I can't do live migration. Where can I fix the issue in the db?19:40
*** k_mouza has joined #openstack-nova19:45
*** slaweq has quit IRC19:50
*** k_mouza has quit IRC19:50
*** slaweq has joined #openstack-nova19:58
*** bbowen has quit IRC20:00
*** slaweq has quit IRC20:15
mnasermloza: i didn't tell you this but nova.instances.availability_zone20:30
mnaserthat is an ID though20:30
mnasermloza: but you can use an id from one that you know is right, but its friday and you should play with db :)20:32
openstackgerritMerged openstack/nova master: Introduce scope_types in multinic policy  https://review.opendev.org/74232821:04
*** maciejjozefczyk has quit IRC21:10
*** raildo has quit IRC21:21
*** mvorwerk has quit IRC21:25
mlozamnaser: it shows the correct AZ in the nova db21:26
mnasermaybe check nova_api21:26
mlozalook like its in nova_api db, it's the request_specs table which shows the invalid AZ21:27
mlozamanage to get it corrected21:27
mlozaupdate request_specs set spec = replace (spec,'"availability_zone": "old-name"','"availability_zone": "new-name"') where instance_uuid = 'xxxxxxxxxxxxxxx';21:27
*** rcernin has joined #openstack-nova21:47
*** rcernin has quit IRC22:26
*** spatel has joined #openstack-nova22:27
*** rcernin has joined #openstack-nova22:32
*** spatel has quit IRC22:32
*** tosky has quit IRC22:58
*** artom has quit IRC23:00
*** k_mouza has joined #openstack-nova23:10
openstackgerritLee Yarwood proposed openstack/nova master: WIP libvirt: Remove host CPU checks during check_can_live_migrate_destination  https://review.opendev.org/74543123:14
*** k_mouza has quit IRC23:14
*** rcernin has quit IRC23:38
*** rcernin has joined #openstack-nova23:59

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!