Monday, 2020-08-17

*** songwenping_ has joined #openstack-nova00:23
*** zhanglong has joined #openstack-nova00:25
*** songwenping__ has quit IRC00:26
*** zhanglong has quit IRC00:32
*** zhanglong has joined #openstack-nova00:42
*** brinzhang has joined #openstack-nova00:51
brinzhanggibi_pto_24th, gmann, stephenfin, alex_xu, bauzas: I was update the runway slot, because some patches have reached the dealine in the slot00:55
*** ociuhandu has joined #openstack-nova01:00
*** hack-char has joined #openstack-nova01:01
*** ociuhandu has quit IRC01:05
*** suryasingh has joined #openstack-nova01:06
*** songwenping__ has joined #openstack-nova01:43
*** songwenping_ has quit IRC01:46
*** songwenping__ has quit IRC01:46
*** songwenping__ has joined #openstack-nova01:47
*** ociuhandu has joined #openstack-nova02:25
*** ociuhandu has quit IRC02:29
*** brinzhang_ has joined #openstack-nova02:34
*** brinzhang has quit IRC02:37
*** sapd1 has joined #openstack-nova02:50
*** brinzhang0 has joined #openstack-nova03:04
*** songwenping_ has joined #openstack-nova03:04
*** brinzhang_ has quit IRC03:07
*** songwenping__ has quit IRC03:07
*** mkrai has joined #openstack-nova03:20
*** psachin has joined #openstack-nova03:37
*** zhanglong has quit IRC04:27
*** evrardjp has quit IRC04:33
*** evrardjp has joined #openstack-nova04:33
*** ratailor has joined #openstack-nova04:56
*** links has joined #openstack-nova05:02
*** brinzhang_ has joined #openstack-nova05:04
*** brinzhang0 has quit IRC05:06
*** sapd1 has quit IRC05:11
*** zhanglong has joined #openstack-nova05:28
*** songwenping__ has joined #openstack-nova05:45
*** songwenping_ has quit IRC05:48
*** brinzhang0 has joined #openstack-nova05:54
*** songwenping_ has joined #openstack-nova05:54
*** slaweq has joined #openstack-nova05:55
*** songwenping__ has quit IRC05:57
*** brinzhang_ has quit IRC05:57
*** slaweq has quit IRC06:00
*** mkrai has quit IRC06:00
*** mkrai_ has joined #openstack-nova06:01
*** sapd1 has joined #openstack-nova06:10
*** sapd1 has quit IRC06:11
*** sapd1 has joined #openstack-nova06:13
*** damien_r has joined #openstack-nova06:24
*** damien_r has quit IRC06:24
*** xek has joined #openstack-nova06:26
*** maciejjozefczyk has joined #openstack-nova06:34
*** zhanglong has quit IRC06:37
*** zhanglong has joined #openstack-nova06:40
*** happyhemant has joined #openstack-nova06:40
*** songwenping__ has joined #openstack-nova06:43
*** belmoreira has joined #openstack-nova06:45
*** songwenping_ has quit IRC06:46
*** vishalmanchanda has joined #openstack-nova06:49
*** mvorwerk has joined #openstack-nova06:52
*** links has quit IRC06:52
*** tobias-urdin has joined #openstack-nova06:56
*** mvorwerk_ has joined #openstack-nova06:57
*** mvorwerk has quit IRC06:58
*** maciejjozefczyk_ has joined #openstack-nova06:59
*** maciejjozefczyk has quit IRC06:59
*** maciejjozefczyk_ is now known as maciejjozefczyk07:02
*** tesseract has joined #openstack-nova07:03
*** mkrai_ has quit IRC07:07
*** songwenping_ has joined #openstack-nova07:14
*** songwenping__ has quit IRC07:16
*** jsuchome has joined #openstack-nova07:24
*** zhanglong has quit IRC07:28
*** zhanglong has joined #openstack-nova07:30
*** songwenping__ has joined #openstack-nova07:44
*** songwenping_ has quit IRC07:46
openstackgerritHarshavardhan Metla proposed openstack/nova master: Raising a failure in case of 403  https://review.opendev.org/73506807:50
*** dtantsur|afk is now known as dtantsur07:55
*** tosky has joined #openstack-nova07:56
*** zhanglong has quit IRC08:00
*** k_mouza has joined #openstack-nova08:03
*** brinzhang_ has joined #openstack-nova08:04
*** brinzhang0 has quit IRC08:07
*** zhanglong has joined #openstack-nova08:13
*** martinkennelly has joined #openstack-nova08:18
*** mkrai has joined #openstack-nova08:30
*** k_mouza has quit IRC08:41
*** songwenping_ has joined #openstack-nova08:43
*** links has joined #openstack-nova08:44
*** k_mouza has joined #openstack-nova08:45
*** songwenping__ has quit IRC08:46
*** happyhemant has quit IRC08:50
*** zhanglong has quit IRC08:52
*** zhanglong has joined #openstack-nova08:54
*** slaweq has joined #openstack-nova09:07
*** luyao has quit IRC09:10
*** arne_wiebalck has quit IRC09:11
lyarwoodstephenfin: https://review.opendev.org/#/c/746210/ - would you mind hitting this today? simple fup from https://review.opendev.org/#/q/I7eb86edc130d186a66c04b229d46347ec5c0b625 as we all missed we are using < v4.1.0 in CI at the moment.09:12
openstackgerritStephen Finucane proposed openstack/nova stable/ussuri: [Trivial] Remove wrong format_message() conversion  https://review.opendev.org/74646409:12
*** songwenping__ has joined #openstack-nova09:13
stephenfinsure09:13
*** arne_wiebalck has joined #openstack-nova09:14
*** songwenping_ has quit IRC09:17
*** swp20 has joined #openstack-nova09:18
*** luyao has joined #openstack-nova09:19
*** songwenping__ has quit IRC09:20
lyarwoodstephenfin: are you rebasing the vtpm stuff today btw?09:25
stephenfinyup, in the middle of that atm09:25
lyarwoodwonderful09:25
openstackgerritStephen Finucane proposed openstack/nova master: tests: Add helpers for suspend, resume and reboot of server  https://review.opendev.org/74128509:30
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Pass context, instance to '_create_guest'  https://review.opendev.org/74128609:30
openstackgerritStephen Finucane proposed openstack/nova master: api: Reject non-spawn operations for vTPM  https://review.opendev.org/74150009:30
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Add emulated TPM support to Nova  https://review.opendev.org/63136309:31
openstackgerritStephen Finucane proposed openstack/nova master: docs: Add docs for vTPM support  https://review.opendev.org/73921309:31
openstackgerritStephen Finucane proposed openstack/nova master: Add type hints to 'nova.compute.manager'  https://review.opendev.org/74286309:31
openstackgerritStephen Finucane proposed openstack/nova master: Don't unset Instance.old_flavor, new_flavor until necessary  https://review.opendev.org/74199509:31
openstackgerritStephen Finucane proposed openstack/nova master: privsep: Add support for recursive chown, move_tree operations  https://review.opendev.org/74286409:31
openstackgerritStephen Finucane proposed openstack/nova master: Add type hints to 'nova.virt.libvirt.utils'  https://review.opendev.org/74286509:31
openstackgerritStephen Finucane proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files  https://review.opendev.org/63993409:31
*** slaweq has quit IRC09:32
*** ociuhandu has joined #openstack-nova09:44
*** tkajinam has quit IRC09:55
*** jangutter has joined #openstack-nova09:57
*** Luzi has joined #openstack-nova09:59
*** brinzhang_ has quit IRC10:04
*** brinzhang_ has joined #openstack-nova10:04
*** brinzhang_ has quit IRC10:06
*** brinzhang_ has joined #openstack-nova10:06
*** k_mouza has quit IRC10:10
*** k_mouza has joined #openstack-nova10:12
*** ociuhandu has quit IRC10:37
*** mkrai has quit IRC10:37
*** mkrai has joined #openstack-nova10:37
*** priteau has joined #openstack-nova10:41
*** mkrai has quit IRC10:48
*** mkrai has joined #openstack-nova10:48
*** k_mouza has quit IRC10:52
*** sapd1 has quit IRC10:52
*** k_mouza has joined #openstack-nova10:55
*** happyhemant has joined #openstack-nova11:25
*** breizhkoala has joined #openstack-nova11:26
*** tkajinam has joined #openstack-nova11:27
openstackgerritHao Sun proposed openstack/nova master: Add checks for volume status when rebuilding  https://review.opendev.org/73473411:32
*** songwenping_ has joined #openstack-nova11:34
*** brinzhang0 has joined #openstack-nova11:34
*** swp20 has quit IRC11:36
*** brinzhang_ has quit IRC11:37
*** dave-mccowan has joined #openstack-nova11:39
lyarwoodstephenfin: do you plan on blocking non-owner ops with vTPM instances in the API?11:41
*** raildo has joined #openstack-nova11:49
*** k_mouza has quit IRC11:57
openstackgerritMerged openstack/nova master: Remove dead volume driver code  https://review.opendev.org/74539312:07
*** songwenping__ has joined #openstack-nova12:09
*** mkrai has quit IRC12:10
*** songwenping_ has quit IRC12:11
*** brinzhang_ has joined #openstack-nova12:14
*** brinzhang0 has quit IRC12:17
*** tesseract has quit IRC12:17
*** ratailor has quit IRC12:21
*** songwenping_ has joined #openstack-nova12:23
*** songwenping__ has quit IRC12:26
*** zhanglong has quit IRC12:29
*** lbragstad has quit IRC12:32
*** dave-mccowan has quit IRC12:32
*** ociuhandu has joined #openstack-nova12:37
*** dave-mccowan has joined #openstack-nova12:41
*** ociuhandu has quit IRC12:42
*** lbragstad has joined #openstack-nova12:43
*** songwenping__ has joined #openstack-nova12:43
*** artom has joined #openstack-nova12:44
*** tesseract has joined #openstack-nova12:45
*** songwenping_ has quit IRC12:46
*** mkrai has joined #openstack-nova12:54
*** mkrai has quit IRC13:00
*** nweinber has joined #openstack-nova13:01
*** Luzi has quit IRC13:26
*** dtantsur has quit IRC13:32
lyarwoodmelwitt: https://review.opendev.org/#/c/746210/ - Morning, when you're online would you mind taking a look at this please?13:33
*** songwenping_ has joined #openstack-nova13:33
*** brinzhang0 has joined #openstack-nova13:33
*** brinzhang0 has quit IRC13:35
*** brinzhang0 has joined #openstack-nova13:35
*** brinzhang_ has quit IRC13:36
*** songwenping__ has quit IRC13:37
*** ociuhandu has joined #openstack-nova13:37
*** dtantsur has joined #openstack-nova13:38
*** k_mouza has joined #openstack-nova13:57
*** k_mouza has quit IRC14:02
*** tkajinam has quit IRC14:06
*** mvorwerk_ has quit IRC14:18
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Mock LoopingCallBase._sleep in rbd tests  https://review.opendev.org/74551214:20
lyarwoodstephenfin: ^ trivial one for you if you have bandwidth14:20
stephenfinlyarwood: done14:22
stephenfinas for your earlier question (sorry, missed it then), yeah, that probably makes sense. I assume all non-owner ops except delete, of course14:23
*** songwenping__ has joined #openstack-nova14:23
*** mvorwerk has joined #openstack-nova14:25
*** brinzhang has joined #openstack-nova14:25
*** ircuser-1 has joined #openstack-nova14:26
*** songwenping_ has quit IRC14:26
*** brinzhang0 has quit IRC14:27
*** k_mouza has joined #openstack-nova14:27
lyarwoodstephenfin: well any move ops really14:29
lyarwoodstephenfin: hard reboot as well thinking about it14:30
*** mvorwerk_ has joined #openstack-nova14:30
gmannlyarwood: stephenfin can you check this, Focal migration patch is ready- https://review.opendev.org/#/c/738126/14:32
*** mvorwerk has quit IRC14:33
*** brinzhang_ has joined #openstack-nova14:34
openstackgerritMerged openstack/nova stable/ussuri: [Trivial] Remove wrong format_message() conversion  https://review.opendev.org/74646414:36
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in baremetal nodes policies  https://review.opendev.org/74171614:36
openstackgerritGhanshyam Mann proposed openstack/nova master: Pass the actual target in baremetal nodes policy  https://review.opendev.org/74171714:36
*** brinzhang has quit IRC14:37
openstackgerritGhanshyam Mann proposed openstack/nova master: Add scope and new default roles in extensions policies  https://review.opendev.org/74304614:40
lyarwoodgmann: so what about that change moves us to focal? Wouldn't it be better to say that this is just bumping our reqs so we *can* move to focal in the future?14:42
*** songwenping_ has joined #openstack-nova14:43
gmannlyarwood: with the depends-on in previous PS tested all devstack based jobs on focal to it also made sure everything worked fine here so whenever base jobs moves to Focal nova automatically start tested on Focal14:44
*** psachin has quit IRC14:45
*** links has quit IRC14:46
*** songwenping__ has quit IRC14:46
lyarwoodgmann: shouldn't we have a .DNM change on top of this to ensure it's still working?14:47
lyarwoodgmann: oh I see the PS now14:48
gmannlyarwood: Patch Set 14 was that14:48
gmannyeah, i am testing first and then removing the depensd-on to merge it before base job migrate and break the gate14:48
lyarwoodgmann: hmm but that had a depends-on of https://review.opendev.org/#/c/746327/ ?14:48
lyarwoodgmann: that doesn't seem right14:49
lyarwoodoh and that was the tip of the focal changes14:49
gmannyeah14:49
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in networks policies  https://review.opendev.org/74256614:51
openstackgerritGhanshyam Mann proposed openstack/nova master: Pass the actual target in networks policy  https://review.opendev.org/74256814:52
openstackgerritArtom Lifshitz proposed openstack/nova stable/ussuri: func: Introduce a server_expected_state kwarg to InstanceHelperMixin._live_migrate  https://review.opendev.org/74652714:53
openstackgerritArtom Lifshitz proposed openstack/nova stable/ussuri: Add regression test for bug 1879787  https://review.opendev.org/74652814:53
openstackgerritArtom Lifshitz proposed openstack/nova stable/ussuri: Handle Neutron errors in _post_live_migration()  https://review.opendev.org/74652914:53
openstackbug 1879787 in OpenStack Compute (nova) "post_live_migration does not handle Neutron errors" [Medium,Fix released] https://launchpad.net/bugs/1879787 - Assigned to Artom Lifshitz (notartom)14:53
lyarwoodgmann: some quick nits in the commit message otherwise it LGTM14:56
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in FIP policies  https://review.opendev.org/74203014:57
openstackgerritGhanshyam Mann proposed openstack/nova master: Pass the actual target in FIP policy  https://review.opendev.org/74257014:58
*** gyee has joined #openstack-nova14:58
gmannstephenfin: gibi_pto_24th I have rebased the policy pacthes due to conflict. please re-approve those. I have made them in series to avoid any future conflict. - https://review.opendev.org/#/q/topic:bp/policy-defaults-refresh-deprecated-apis+status:open14:59
gmannlyarwood: thanks, checking14:59
openstackgerritGhanshyam Mann proposed openstack/nova master: [goal] Prepare for job migration to Ubuntu Focal (20.04)  https://review.opendev.org/73812615:00
*** purplerbot has quit IRC15:00
gmannlyarwood: ^^15:00
*** purplerbot has joined #openstack-nova15:01
melwittlyarwood: ack will do15:03
*** brinzhang0 has joined #openstack-nova15:04
*** brinzhang_ has quit IRC15:06
*** sapd1 has joined #openstack-nova15:08
openstackgerritLuyao Zhong proposed openstack/nova master: track error migrations in resource tracker  https://review.opendev.org/74528115:11
openstackgerritLuyao Zhong proposed openstack/nova master: improve orphans tracking in resource tracker  https://review.opendev.org/74528215:11
*** dklyle has joined #openstack-nova15:13
openstackgerritLuyao Zhong proposed openstack/nova master: improve orphans tracking in resource tracker  https://review.opendev.org/74528215:14
*** mlavalle has joined #openstack-nova15:15
*** belmoreira has quit IRC15:20
openstackgerritMerged openstack/nova master: Remove monotonic usage  https://review.opendev.org/72542515:29
openstackgerritMerged openstack/nova master: Rebase qcow2 images when unshelving an instance  https://review.opendev.org/69608415:29
*** prometheanfire has joined #openstack-nova15:30
prometheanfireany work nova side to support mock 4.0.2? https://review.opendev.org/71271315:31
*** songwenping__ has joined #openstack-nova15:34
*** happyhemant has quit IRC15:35
melwittprometheanfire: I spent a lot of time on it, didn't get anywhere, got discouraged. working up the will to try again15:35
prometheanfirefair15:37
*** songwenping_ has quit IRC15:37
*** martinkennelly has quit IRC15:41
*** priteau has quit IRC15:57
*** mkrai has joined #openstack-nova16:02
*** martinkennelly has joined #openstack-nova16:18
*** belmoreira has joined #openstack-nova16:33
*** songwenping_ has joined #openstack-nova16:33
*** belmoreira has quit IRC16:36
*** songwenping__ has quit IRC16:36
*** k_mouza has quit IRC16:37
*** brinzhang_ has joined #openstack-nova16:38
*** brinzhang0 has quit IRC16:42
*** alex_xu has quit IRC16:43
*** tesseract has quit IRC16:52
*** sapd1 has quit IRC16:56
*** dtantsur is now known as dtantsur|afk16:59
*** mkrai has quit IRC17:05
*** artom has quit IRC17:30
*** artom has joined #openstack-nova17:32
*** brinzhang0 has joined #openstack-nova17:37
*** vishalmanchanda has quit IRC17:37
*** brinzhang_ has quit IRC17:40
*** kegorov35 has joined #openstack-nova17:44
kegorov35hey! my supervisor told me that this review https://review.opendev.org/#/c/742180/ should be merged. can you please merge it or explain to me why can't you merge it17:45
kegorov35#openstack-nova urgent question17:56
prometheanfirekegorov35: better to ask for a review than a merge (a review allows the review to say no, a merge kinda expects a yes)17:58
dansmithkegorov35: it can't be merged because it hasn't been reviewed, and definitely because it has no tests, and also because it claims there's a bug being fixed, with non referenced and no reproducer information17:58
dansmithoh I see it's jammed in the subject, but still..18:01
*** kegorov35 has quit IRC18:08
*** mriedem has joined #openstack-nova18:08
openstackgerritLuigi Toscano proposed openstack/nova master: zuul: use the new barbican simple-crypto job  https://review.opendev.org/74658318:10
*** jsuchome has quit IRC18:29
*** hoonetorg has joined #openstack-nova18:29
*** breizhkoala has quit IRC18:36
*** songwenping__ has joined #openstack-nova18:44
*** slaweq has joined #openstack-nova18:44
prometheanfiremelwitt: for mock, my stance is that if nova is not gonna use the python builtin unittest.mock then it needs to update :|18:46
*** songwenping_ has quit IRC18:46
melwittprometheanfire: we want to and we can, but the snag is that the fixtures library we use (https://pypi.org/project/fixtures/) prefers the third-party mock library when it imports mock, and then it creates mocks using that library, and so when we "switch" to unittest.mock in some places, we end up with third-party mocks + unittest.mocks that don't know about each other and we can't "stop" a third-party mock embedded inside the fixtures18:49
melwitt library without importing third-party mock18:49
prometheanfiremelwitt: understood, I wasn't knocking you at all :D18:49
melwitteverything works fine if the third-party mock library is not installed in the venv at all but if it's present, fixtures prefers it and causes problems18:50
melwittI tried a bunch of workarounds and none worked, I ran out of ideas and I haven't been back yet to see if I could find some other way around18:50
prometheanfireeww, uses launchpad :P18:50
melwittmaybe if I did something like fixtures.<whatever>.mock.stopall() that might work18:51
mriedemhack idea: monkey patch the 3rd party lib with the std lib if found18:53
melwittyesss mriedem18:53
melwittthis is right up your alley18:54
melwittthanks. I will try that too18:54
prometheanfirehmm, I don't see fixtures itself calling mock, so I guess it's in how nova calls fixtures?18:55
mriedemmy guess is it's this down in here https://github.com/testing-cabal/fixtures/blob/41774d58ed86b92dd60d727f00f1040f862c8ed1/fixtures/_fixtures/mockpatch.py#L2218:56
melwittmriedem: yup, that's exactly it18:56
mriedemcould probably also avoid using those fixtures, there are other ways of doing those18:57
mriedembut their usage might be pervasive18:57
melwittyeah, fair18:57
mriedemnot sure how you _prevent_ their usage later without a hacking check18:57
prometheanfirehmm, ya, guess I was looking at what pypi linked to (launchpad) and not testing-cabal's org18:58
mriedemi remember quite a bit of this in nova which isn't using mock https://github.com/openstack/nova/blob/master/nova/test.py#L352 but _can_ be replaced with mock18:59
mriedemand stuff like https://github.com/openstack/nova/blob/master/nova/test.py#L423 could be replaced to just be mock rather than fixtures18:59
mriedemi smell a 3 year all encompassing blueprint coming on18:59
melwittwe could chance it and just fix the stuck cases (by not using fixtures in those spots) and then once third-party mock is gone from reqs, we are in the clear for future even with fixtures18:59
melwittlol @ 3 year blueprint. yes, I think we all want that in our life19:00
mriedemi've had to ween myself off the fixtures library because i don't think it works with pytest, and i'm in pytest land now19:01
melwittah19:01
*** belmoreira has joined #openstack-nova19:13
*** songwenping_ has joined #openstack-nova19:14
*** songwenping__ has quit IRC19:17
*** smcginnis has quit IRC19:19
*** smcginnis has joined #openstack-nova19:21
*** martinkennelly has quit IRC19:31
*** martinkennelly has joined #openstack-nova19:31
*** slaweq has quit IRC19:36
*** slaweq has joined #openstack-nova19:46
*** slaweq has quit IRC19:52
*** belmoreira has quit IRC20:43
*** nweinber has quit IRC20:45
*** xek has quit IRC21:00
*** maciejjozefczyk has quit IRC21:01
*** raildo has quit IRC21:22
openstackgerritKirill Egorov proposed openstack/nova master: fixes broken shared live migration of a vm with a vif aka Bug #1888395  https://review.opendev.org/74218021:23
openstackbug 1888395 in OpenStack Compute (nova) "shared live migration of a vm with a vif is broken in train" [Undecided,New] https://launchpad.net/bugs/1888395 - Assigned to Sergey Galas' (shrike742)21:23
*** songwenping__ has joined #openstack-nova21:34
*** songwenping_ has quit IRC21:37
*** ociuhandu has quit IRC21:39
*** brinzhang_ has joined #openstack-nova21:44
*** brinzhang0 has quit IRC21:47
*** mgoddard has quit IRC22:10
*** mgoddard has joined #openstack-nova22:18
*** mriedem has left #openstack-nova22:23
openstackgerritGhanshyam Mann proposed openstack/nova master: Few todo fixes for API new policies  https://review.opendev.org/74661022:28
*** rcernin has joined #openstack-nova22:33
*** songwenping_ has joined #openstack-nova22:34
*** mvorwerk_ has quit IRC22:35
*** songwenping__ has quit IRC22:37
*** mlavalle has quit IRC22:38
*** tosky has quit IRC22:57
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Do not reference VIR_ERR_DEVICE_MISSING when libvirt is < v4.1.0  https://review.opendev.org/74621023:00
*** martinkennelly has quit IRC23:00
*** breizhkoala has joined #openstack-nova23:03
*** tkajinam has joined #openstack-nova23:07
*** mvorwerk has joined #openstack-nova23:08
*** brinzhang0 has joined #openstack-nova23:09
*** brinzhang_ has quit IRC23:12
*** mvorwerk has quit IRC23:12
*** mvorwerk has joined #openstack-nova23:17
*** ociuhandu has joined #openstack-nova23:39
*** ociuhandu has quit IRC23:45

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!