| *** fyx has quit IRC | 00:03 | |
| *** fyx has joined #openstack-nova | 00:03 | |
| *** brinzhang0 has joined #openstack-nova | 00:09 | |
| *** tetsuro has joined #openstack-nova | 00:09 | |
| *** brinzhang_ has quit IRC | 00:12 | |
| *** markmcclain has quit IRC | 00:13 | |
| *** prometheanfire has left #openstack-nova | 00:14 | |
| *** markmcclain has joined #openstack-nova | 00:15 | |
| *** breizhkoala has quit IRC | 00:21 | |
| *** markmcclain has quit IRC | 00:24 | |
| *** tbachman has quit IRC | 00:27 | |
| *** songwenping__ has joined #openstack-nova | 00:34 | |
| *** songwenping_ has quit IRC | 00:37 | |
| *** slaweq has joined #openstack-nova | 00:39 | |
| *** slaweq has quit IRC | 00:45 | |
| *** slaweq has joined #openstack-nova | 00:46 | |
| *** brinzhang0 has quit IRC | 00:51 | |
| *** zhanglong has joined #openstack-nova | 00:52 | |
| *** slaweq has quit IRC | 00:53 | |
| *** tetsuro_ has joined #openstack-nova | 00:54 | |
| *** tetsuro has quit IRC | 00:58 | |
| *** slaweq has joined #openstack-nova | 01:02 | |
| *** songwenping_ has joined #openstack-nova | 01:04 | |
| *** slaweq has quit IRC | 01:07 | |
| *** songwenping__ has quit IRC | 01:07 | |
| *** slaweq has joined #openstack-nova | 01:15 | |
| *** songwenping__ has joined #openstack-nova | 01:18 | |
| *** slaweq has quit IRC | 01:20 | |
| *** songwenping_ has quit IRC | 01:21 | |
| *** slaweq has joined #openstack-nova | 01:26 | |
| *** slaweq has quit IRC | 01:31 | |
| *** slaweq has joined #openstack-nova | 01:45 | |
| *** tetsuro_ has quit IRC | 01:47 | |
| *** tetsuro has joined #openstack-nova | 01:48 | |
| *** tetsuro has quit IRC | 01:48 | |
| *** songwenping_ has joined #openstack-nova | 01:48 | |
| *** slaweq has quit IRC | 01:49 | |
| *** songwenping__ has quit IRC | 01:52 | |
| *** songwenping_ has quit IRC | 01:56 | |
| *** songwenping_ has joined #openstack-nova | 01:57 | |
| *** ociuhandu has joined #openstack-nova | 02:01 | |
| *** bbowen__ has joined #openstack-nova | 02:02 | |
| *** pots has quit IRC | 02:03 | |
| *** pots has joined #openstack-nova | 02:03 | |
| *** devfaz has quit IRC | 02:03 | |
| *** devfaz has joined #openstack-nova | 02:04 | |
| *** bbowen_ has quit IRC | 02:05 | |
| *** zzzeek has quit IRC | 02:05 | |
| *** mgoddard has quit IRC | 02:05 | |
| *** smcginnis has quit IRC | 02:05 | |
| *** gryf has quit IRC | 02:05 | |
| *** purplerbot has quit IRC | 02:06 | |
| *** benj_ has quit IRC | 02:06 | |
| *** ociuhandu has quit IRC | 02:06 | |
| *** smcginnis has joined #openstack-nova | 02:06 | |
| *** benj_ has joined #openstack-nova | 02:07 | |
| *** zzzeek has joined #openstack-nova | 02:11 | |
| *** slaweq has joined #openstack-nova | 02:12 | |
| *** mgoddard has joined #openstack-nova | 02:13 | |
| *** slaweq has quit IRC | 02:19 | |
| *** rcernin has quit IRC | 02:21 | |
| *** gryf has joined #openstack-nova | 02:22 | |
| *** tetsuro has joined #openstack-nova | 02:42 | |
| *** dave-mccowan has quit IRC | 02:44 | |
| *** slaweq has joined #openstack-nova | 02:46 | |
| *** slaweq has quit IRC | 02:51 | |
| *** slaweq has joined #openstack-nova | 02:54 | |
| *** slaweq has quit IRC | 02:58 | |
| *** rcernin has joined #openstack-nova | 02:59 | |
| *** slaweq has joined #openstack-nova | 03:00 | |
| *** slaweq has quit IRC | 03:04 | |
| *** slaweq has joined #openstack-nova | 03:21 | |
| *** slaweq has quit IRC | 03:25 | |
| *** vishalmanchanda has joined #openstack-nova | 03:30 | |
| *** psachin has joined #openstack-nova | 03:37 | |
| *** mkrai has joined #openstack-nova | 03:41 | |
| *** tetsuro_ has joined #openstack-nova | 03:47 | |
| *** slaweq has joined #openstack-nova | 03:50 | |
| *** tetsuro has quit IRC | 03:50 | |
| *** suryasingh has joined #openstack-nova | 03:51 | |
| *** slaweq has quit IRC | 04:01 | |
| *** zhanglong has quit IRC | 04:07 | |
| *** rcernin has quit IRC | 04:14 | |
| *** rcernin has joined #openstack-nova | 04:21 | |
| *** tetsuro has joined #openstack-nova | 04:24 | |
| *** tetsuro_ has quit IRC | 04:27 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #openstack-nova | 04:33 | |
| *** rcernin has quit IRC | 04:37 | |
| *** ratailor has joined #openstack-nova | 04:42 | |
| *** rcernin has joined #openstack-nova | 04:46 | |
| *** zhanglong has joined #openstack-nova | 05:17 | |
| *** kaisers has quit IRC | 05:17 | |
| *** gyee has quit IRC | 05:20 | |
| *** mvorwerk has joined #openstack-nova | 05:34 | |
| *** kaisers has joined #openstack-nova | 05:34 | |
| *** mvorwerk_ has joined #openstack-nova | 05:39 | |
| *** mvorwerk has quit IRC | 05:40 | |
| *** brinzhang has joined #openstack-nova | 05:42 | |
| *** links has joined #openstack-nova | 05:49 | |
| *** jmlowe has quit IRC | 05:50 | |
| *** tetsuro has quit IRC | 05:57 | |
| openstackgerrit | Mamduh proposed openstack/os-vif master: Fix - os-vif fails to get the correct UpLink Representor https://review.opendev.org/746836 | 06:00 |
|---|---|---|
| *** manuvakery has joined #openstack-nova | 06:01 | |
| openstackgerrit | Mamduh proposed openstack/os-vif master: Refactor code of linux_net to more cleaner and increase performace https://review.opendev.org/746673 | 06:07 |
| openstackgerrit | Mamduh proposed openstack/os-vif master: Fix - os-vif fails to get the correct UpLink Representor https://review.opendev.org/745895 | 06:24 |
| *** sapd1 has joined #openstack-nova | 06:25 | |
| *** jmlowe has joined #openstack-nova | 06:27 | |
| *** zhanglong has quit IRC | 06:29 | |
| *** happyhemant has joined #openstack-nova | 06:42 | |
| *** dklyle has quit IRC | 06:46 | |
| *** lpetrut has joined #openstack-nova | 06:51 | |
| *** brinzhang_ has joined #openstack-nova | 06:56 | |
| *** brinzhang has quit IRC | 07:00 | |
| *** mkrai has quit IRC | 07:13 | |
| *** mkrai has joined #openstack-nova | 07:13 | |
| *** tesseract has joined #openstack-nova | 07:14 | |
| *** slaweq has joined #openstack-nova | 07:14 | |
| *** damien_r has joined #openstack-nova | 07:17 | |
| *** belmoreira has joined #openstack-nova | 07:19 | |
| *** mkrai has quit IRC | 07:31 | |
| *** nightmare_unreal has joined #openstack-nova | 07:47 | |
| *** xinranwang__ has joined #openstack-nova | 07:55 | |
| *** kleini has joined #openstack-nova | 07:57 | |
| *** songwenping_ has quit IRC | 08:00 | |
| *** breizhkoala has joined #openstack-nova | 08:01 | |
| *** xek has joined #openstack-nova | 08:07 | |
| lyarwood | gmann: with the switch to focal, are we dropping support for bionic? | 08:11 |
| *** dtantsur|afk is now known as dtantsur | 08:16 | |
| *** Yumeng has joined #openstack-nova | 08:17 | |
| *** belmoreira has quit IRC | 08:21 | |
| *** mkrai has joined #openstack-nova | 08:23 | |
| *** slaweq has quit IRC | 08:25 | |
| *** tosky has joined #openstack-nova | 08:28 | |
| *** martinkennelly has joined #openstack-nova | 08:29 | |
| *** mkrai has quit IRC | 08:31 | |
| *** mkrai_ has joined #openstack-nova | 08:32 | |
| *** ociuhandu has joined #openstack-nova | 08:34 | |
| stephenfin | lyarwood++ Ta for reviewing those six patches by the way. I'm sure Takashi-san appreciates :) | 08:35 |
| stephenfin | *the reviews | 08:35 |
| *** mkrai_ has quit IRC | 08:55 | |
| *** mkrai has joined #openstack-nova | 08:55 | |
| lyarwood | stephenfin: np | 08:59 |
| *** k_mouza has joined #openstack-nova | 09:14 | |
| *** sapd1 has quit IRC | 09:23 | |
| *** ratailor has quit IRC | 09:27 | |
| *** ratailor_ has joined #openstack-nova | 09:27 | |
| *** artom has quit IRC | 09:27 | |
| *** slaweq has joined #openstack-nova | 09:29 | |
| *** martinkennelly has quit IRC | 09:33 | |
| *** mkrai has quit IRC | 09:39 | |
| *** mkrai_ has joined #openstack-nova | 09:39 | |
| *** rcernin has quit IRC | 09:43 | |
| *** martinkennelly has joined #openstack-nova | 09:45 | |
| *** martinkennelly has quit IRC | 09:48 | |
| *** jraju__ has joined #openstack-nova | 09:49 | |
| *** rcernin has joined #openstack-nova | 09:49 | |
| *** links has quit IRC | 09:49 | |
| *** Yumeng has quit IRC | 09:51 | |
| *** mkrai_ has quit IRC | 09:54 | |
| *** mkrai__ has joined #openstack-nova | 09:54 | |
| openstackgerrit | Stephen Finucane proposed openstack/os-vif master: mypy: Add type annotations https://review.opendev.org/745162 | 09:56 |
| openstackgerrit | Stephen Finucane proposed openstack/os-vif master: mypy: Extend type annotations to 'vif_plug_noop' https://review.opendev.org/745163 | 09:56 |
| openstackgerrit | Stephen Finucane proposed openstack/os-vif master: windows: Add missing return https://review.opendev.org/746870 | 09:56 |
| *** artom has joined #openstack-nova | 10:02 | |
| *** martinkennelly has joined #openstack-nova | 10:05 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Log exception when unable to import rbd https://review.opendev.org/746873 | 10:05 |
| stephenfin | lyarwood: https://review.opendev.org/#/c/734734/ might be of interest | 10:08 |
| * lyarwood clicks | 10:09 | |
| lyarwood | stephenfin: reviewed, issue with the test but agree with blocking that in the API | 10:19 |
| *** rcernin has quit IRC | 10:30 | |
| lyarwood | stephenfin: https://review.opendev.org/#/c/574301/ - Can you take a look at my notes/question in this, tl;dr we end up relying on [libvirt] specific configurables within nova.image.glance *if* the default ceph config doesn't provide access to the RBD pool hosting glance images. | 10:33 |
| lyarwood | stephenfin: I'm fine addressing that in FUPs in the future by introducing [glance] specific configurables for this | 10:33 |
| stephenfin | sure | 10:34 |
| lyarwood | stephenfin: but wanted other cores to agree with that approach before merging this | 10:34 |
| lyarwood | stephenfin: kk thanks | 10:34 |
| *** rcernin has joined #openstack-nova | 10:34 | |
| * lyarwood looks at the DNM job failure quickly | 10:35 | |
| *** mkrai__ has quit IRC | 10:36 | |
| lyarwood | ah right cinder volumes | 10:36 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM zuul: Enable [glance]/allowed_direct_url_schemes within nova-ceph-multistore https://review.opendev.org/743220 | 10:38 |
| stephenfin | lyarwood: yup, agreed with not using libvirt-specific stuff in a generic place. Left my comments on the patch | 10:47 |
| *** rcernin has quit IRC | 10:48 | |
| *** rcernin has joined #openstack-nova | 10:52 | |
| *** rcernin has quit IRC | 11:07 | |
| *** sapd1 has joined #openstack-nova | 11:09 | |
| sean-k-mooney | stephenfin: wehn you write c/c++ do you put the { on a new line after the funtion signiture followed by another new line before starting the body | 11:12 |
| stephenfin | Python isn't C | 11:13 |
| stephenfin | and I haven't written a lot of C in quite some time :( | 11:13 |
| sean-k-mooney | i know but you are formating things like peopel that do that. i have all been in the void myfunc(int arg) { camp or "auto myfunc(int arg) -> void {" where the code base is following almost always auto | 11:15 |
| tosky | sean-k-mooney: if you change existing code, follow that style; there are different styles around | 11:15 |
| sean-k-mooney | tosky: yes i do | 11:16 |
| tosky | tl;dr there is no correct answer :) | 11:16 |
| sean-k-mooney | well stephenfin is pushing to change the styple of every function in os-vif to a new one which i dislike | 11:16 |
| sean-k-mooney | but im still thinking about it | 11:16 |
| sean-k-mooney | it just reminds me of a c codeing style i always hateded | 11:17 |
| stephenfin | I'll win you over eventually :P | 11:17 |
| sean-k-mooney | i was just wondering if that was the style stephenfin was familar with | 11:17 |
| stephenfin | In other news, I got the live migration with SR-IOV test working \o/ | 11:18 |
| sean-k-mooney | which woudl explain his perfernce | 11:18 |
| sean-k-mooney | stephenfin: awsome | 11:18 |
| sean-k-mooney | i tought we had some limited functional test before but maybe that was numa | 11:18 |
| stephenfin | NUMA, yeah | 11:18 |
| stephenfin | artom wrote them | 11:18 |
| sean-k-mooney | cool | 11:18 |
| stephenfin | but no other live migration in nova.tests.functional.libvirt | 11:19 |
| sean-k-mooney | ya there were a few gaps which i guess you have not finished | 11:19 |
| sean-k-mooney | in the neutron fixture as well as pci code? | 11:19 |
| stephenfin | the gaps were in mocking | 11:20 |
| sean-k-mooney | althoguh i think we more or less had covered the pci stuff with numa | 11:20 |
| sean-k-mooney | yes | 11:20 |
| sean-k-mooney | that is what i ment | 11:20 |
| stephenfin | with the neutron fixture mostly, yeah | 11:20 |
| stephenfin | we had no SR-IOV with neutron coverage | 11:20 |
| sean-k-mooney | correct | 11:20 |
| sean-k-mooney | that is why i did not add the functional tests in the first plance | 11:20 |
| sean-k-mooney | it was trying to get it laned befor m3 and it then got pushed to early train | 11:21 |
| *** rcernin has joined #openstack-nova | 11:21 | |
| sean-k-mooney | anyway got a link i can review | 11:21 |
| stephenfin | just touching up the last few bits, making sure stuff passes | 11:24 |
| sean-k-mooney | we dont have a good way to simultate different config right i know i did an example that everyone hated | 11:25 |
| sean-k-mooney | but can we easily simulate different hardware toplogies on idfferent nodes | 11:26 |
| sean-k-mooney | we would just need different pci info objects right | 11:26 |
| stephenfin | yup, exactly | 11:26 |
| sean-k-mooney | i was wondering how easy it would be to create a repoducer for https://review.opendev.org/#/c/738432/3 | 11:27 |
| *** belmoreira has joined #openstack-nova | 11:27 | |
| sean-k-mooney | i feel like it will be a little tricky as i dont think we mock the eth device lookup but it also might be simipale if that all i have to mock | 11:29 |
| sean-k-mooney | we just need the netdev names to be different on each host which i think we can do with mocks | 11:29 |
| stephenfin | that's the main reason for doing these tests | 11:30 |
| stephenfin | I haven't got a test case for that yet though | 11:30 |
| stephenfin | baby steps and all that | 11:30 |
| *** k_mouza has quit IRC | 11:30 | |
| sean-k-mooney | i know how that bug happens i repoduced it on my local setup and the v1 patch fixed it | 11:30 |
| sean-k-mooney | i should proably test v3 | 11:30 |
| *** raildo has joined #openstack-nova | 11:39 | |
| *** sapd1 has quit IRC | 11:43 | |
| *** _erlon_ has joined #openstack-nova | 11:44 | |
| openstackgerrit | Merged openstack/os-vif master: update tox envs and support pdf docs https://review.opendev.org/728037 | 12:09 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301 | 12:21 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: rbd: Move rbd_utils out of libvirt driver under nova.storage https://review.opendev.org/746904 | 12:21 |
| stephenfin | lyarwood: I know you've started that already, but does this rbd direct download scheme make sense for other virt drivers? | 12:28 |
| stephenfin | i.e. did you give thought to my suggestion on making this virt driver-configurable? | 12:29 |
| stephenfin | sean-k-mooney: what's the expected behavior rn if you try to live migrate an instance with PCI devices attached? | 12:29 |
| sean-k-mooney | via an alias | 12:30 |
| stephenfin | yes | 12:30 |
| sean-k-mooney | it should be rejected in the conductor | 12:30 |
| openstackgerrit | Hao Sun proposed openstack/nova master: Add checks for volume status when rebuilding https://review.opendev.org/734734 | 12:30 |
| stephenfin | Hmm, I'm seeing the request request fail with NoValidHost | 12:30 |
| sean-k-mooney | yep | 12:30 |
| sean-k-mooney | well let me check | 12:30 |
| stephenfin | oh, so it's not validated at the API layer | 12:30 |
| sean-k-mooney | i think that could happen | 12:30 |
| stephenfin | ? | 12:30 |
| sean-k-mooney | i dont think so | 12:31 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/conductor/tasks/live_migrate.py#L229-L264 | 12:31 |
| lyarwood | stephenfin: yeah it is possible to do this in other virt drivers | 12:31 |
| sean-k-mooney | we dont know at the api if the hosts are new enough | 12:31 |
| sean-k-mooney | lyarwood: actully its not | 12:31 |
| lyarwood | yeah it is | 12:31 |
| sean-k-mooney | lyarwood: it would be possible to do it in other deivers | 12:32 |
| sean-k-mooney | but you cant live migrate with pci device period | 12:32 |
| lyarwood | sean-k-mooney: I'm replying to stephenfin from earlier about rbd imports | 12:32 |
| sean-k-mooney | the pci-sig sriov spec does not provide a fasicalty for it | 12:32 |
| lyarwood | sean-k-mooney: not whatever you're talking about now | 12:32 |
| sean-k-mooney | oh :) | 12:32 |
| lyarwood | :D | 12:32 |
| sean-k-mooney | ok ignore me then | 12:32 |
| stephenfin | we always do 0:) | 12:32 |
| lyarwood | oh look it's princess eugenie | 12:33 |
| sean-k-mooney | stephenfin: anyway _check_can_migrate_pci is the only check we do and thats in the conductor | 12:33 |
| lyarwood | https://i.pinimg.com/originals/c6/42/73/c64273010126b4ca904a776dc7a079e7.jpg <- context sorry that was a very British joke | 12:34 |
| *** k_mouza has joined #openstack-nova | 12:34 | |
| stephenfin | heh | 12:34 |
| sean-k-mooney | silly hats are silly | 12:34 |
| sean-k-mooney | stephenfin: you could add a check for pci aliase safely in the api | 12:35 |
| *** purplerbot has joined #openstack-nova | 12:35 | |
| sean-k-mooney | stephenfin: we currently do the check in this loop after schduling https://github.com/openstack/nova/blob/cff7382fb3de4eef7aeddc34b6ae3409cbe50ea0/nova/conductor/tasks/live_migrate.py#L523-L567 | 12:36 |
| sean-k-mooney | which eliminates all the hosts and results in a no valid hosts i guess | 12:36 |
| *** mvorwerk_ has quit IRC | 12:37 | |
| *** dave-mccowan has joined #openstack-nova | 12:38 | |
| *** mvorwerk has joined #openstack-nova | 12:38 | |
| sean-k-mooney | eventually _check_not_over_max_retries fires a MaxRetriesExceeded exception which gets translated to no valid host | 12:38 |
| *** rcernin has quit IRC | 12:46 | |
| *** rcernin has joined #openstack-nova | 12:48 | |
| *** mkrai has joined #openstack-nova | 12:52 | |
| *** jraju__ has quit IRC | 12:59 | |
| *** nweinber has joined #openstack-nova | 12:59 | |
| *** k_mouza has quit IRC | 12:59 | |
| *** k_mouza has joined #openstack-nova | 13:05 | |
| *** ratailor_ has quit IRC | 13:19 | |
| openstackgerrit | Hao Sun proposed openstack/nova master: Add checks for volume status when rebuilding https://review.opendev.org/734734 | 13:21 |
| gmann | lyarwood: Bionic will not be tested by default any more so we can say it is not tested so might work or might not. devstack drop the support (remove from supported distro list ) in next cycle from when we upgrade the distro so W cycle will be to drop the Bionic support in devstack. | 13:24 |
| *** mkrai has quit IRC | 13:27 | |
| sean-k-mooney | for vitoria we need it since we need it for grenade? | 13:28 |
| lyarwood | gmann: kk, so for Nova we'd only bump our MIN_LIBVIRT_VERSION to the focal version in W | 13:28 |
| sean-k-mooney | but form W on it will be 20.04 on both sides right | 13:28 |
| sean-k-mooney | lyarwood: i think kasyap has a workflow for this. when ever i have tried to change it i have got shouted at but apparently he is blessed | 13:29 |
| sean-k-mooney | lyarwood: are you thinkihng of bumping the min version to 6 | 13:30 |
| gmann | sean-k-mooney: yes, in V it will be Bionic->bionic upgrade testing and in W Focal->Focal | 13:30 |
| sean-k-mooney | gmann: yep because we dont do distro upgrades in grenade so we need to support bionic for one release longer | 13:30 |
| gmann | lyarwood: if no compatible issue then it is fine to bump in W which give upgrade compatibility also | 13:31 |
| sean-k-mooney | by the way that is not a suggestion to start doing disto upgrade in grenade :) | 13:31 |
| *** priteau has joined #openstack-nova | 13:31 | |
| lyarwood | sean-k-mooney: yeah, would be nice to move to >= 6.0.0 etc in W | 13:34 |
| lyarwood | gmann: yeah there shouldn't be any issues moving to 6.0.0 in W assuming we also drop support for el7 distros | 13:35 |
| gmann | ok | 13:35 |
| sean-k-mooney | i think we need to bump https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L228 so to 6 | 13:35 |
| *** nweinber has quit IRC | 13:35 | |
| aarents | Hi there, lyarwood FYI, I resummit with the missing tempest config : https://review.opendev.org/#/c/743708/ thks! | 13:36 |
| sean-k-mooney | lyarwood: sorry https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L235 | 13:36 |
| *** nweinber has joined #openstack-nova | 13:37 | |
| lyarwood | aarents: looking | 13:38 |
| sean-k-mooney | https://github.com/openstack/nova/commit/1b76c0f72ee1c1175a089b83a41e4ada94570820 | 13:38 |
| sean-k-mooney | so we should be moving to 5.0.0 in v ithink based on this | 13:38 |
| sean-k-mooney | we bumped NEXT_MIN_LIBVIRT_VERSION in ussuri | 13:39 |
| sean-k-mooney | to 5.0.0 | 13:39 |
| sean-k-mooney | lyarwood: we need a similar patch in V for W | 13:39 |
| sean-k-mooney | looking at https://wiki.openstack.org/wiki/LibvirtDistroSupportMatrix and https://repology.org/project/libvirt/versions | 13:42 |
| sean-k-mooney | 6.0.0 should be ok for W | 13:42 |
| sean-k-mooney | the only really concern i see would be debian buster(10) has 5.0.0 but bullseye(11) has 6.0.0 | 13:43 |
| *** manuvakery has quit IRC | 13:48 | |
| *** dklyle has joined #openstack-nova | 13:50 | |
| lyarwood | sean-k-mooney: yeah doesn't look like bullseye actually has a confirmed release date | 13:52 |
| *** seba has quit IRC | 13:52 | |
| lyarwood | sean-k-mooney: still raising NEXT_MIN_LIBVIRT_VERSION in V is still correct | 13:52 |
| * lyarwood writes up a patch | 13:52 | |
| sean-k-mooney | lyarwood: yes raising next min is correct | 13:52 |
| sean-k-mooney | you can also technicaly bump the min version to 5.0.0 | 13:52 |
| sean-k-mooney | we have 5.4 from ubuntu cloud archive on bionic | 13:53 |
| sean-k-mooney | lyarwood: actully we have 6.0.0 | 13:54 |
| sean-k-mooney | in the ussuri repos | 13:54 |
| sean-k-mooney | http://ubuntu-cloud.archive.canonical.com/ubuntu/dists/bionic-proposed/ussuri/main/binary-amd64/Packages | 13:54 |
| lyarwood | we do? | 13:54 |
| lyarwood | ah | 13:54 |
| sean-k-mooney | yep | 13:54 |
| sean-k-mooney | its in both proposed and updates repos | 13:55 |
| sean-k-mooney | http://ubuntu-cloud.archive.canonical.com/ubuntu/dists/bionic-updates/ussuri/main/binary-amd64/Packages | 13:55 |
| *** mkrai has joined #openstack-nova | 13:58 | |
| *** Liang__ has joined #openstack-nova | 13:59 | |
| *** Liang__ is now known as LiangFang | 14:00 | |
| *** KeithMnemonic has joined #openstack-nova | 14:09 | |
| *** happyhemant has quit IRC | 14:22 | |
| *** tkajinam has quit IRC | 14:33 | |
| lyarwood | stupid o.vo question if anyone has time, LibvirtLiveMigrateData is starting to gather fields that we no longer use, can we bump and remove these or do they need to stay forever? | 14:36 |
| *** rcernin has quit IRC | 14:37 | |
| lyarwood | ah just noticed notes about dropping things when we do a major version bump | 14:37 |
| *** slaweq has quit IRC | 14:38 | |
| *** slaweq has joined #openstack-nova | 14:40 | |
| stephenfin | lyarwood: FYI I went and updated the wiki a while back in preparation for version bump patches. Never did the actual bump though | 14:42 |
| stephenfin | so that might be helpful | 14:42 |
| stephenfin | also, yeah, we can drop but it needs a major version bump. I don't think we've done one of those since the Instance 2.0 object so that'll be interesting to see :) | 14:42 |
| * lyarwood adds a TODO and moves on | 14:43 | |
| *** mlavalle has joined #openstack-nova | 14:44 | |
| *** fumesover32 has quit IRC | 14:45 | |
| *** mriedem has joined #openstack-nova | 14:46 | |
| mandre | hi, anyone knows if nova AZs are case sensitive? can we create distinct AZs named MyAZ and myaz? | 14:47 |
| *** slaweq has quit IRC | 14:48 | |
| dansmith | lyarwood: you need a bridge release where you can speak both versions, just like RPC | 14:49 |
| dansmith | so it probably needs to be a need (to drop something) vs want (to clean up some things) to make it feel worthwhile :) | 14:49 |
| *** fumesover32 has joined #openstack-nova | 14:49 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Provide default 'host_info' for '_get_connection' https://review.opendev.org/746942 | 14:50 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Add 'start_compute' helper https://review.opendev.org/746943 | 14:50 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Use tempdir for CONF.instances_path https://review.opendev.org/746944 | 14:50 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Clean up PCI tests https://review.opendev.org/746945 | 14:50 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Add resize tests for PCI, SR-IOV servers https://review.opendev.org/746946 | 14:50 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: conductor: Don't use setattr https://review.opendev.org/746947 | 14:50 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Add test for SR-IOV neutron ports https://review.opendev.org/746948 | 14:50 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: fixtures: Handle binding of first port https://review.opendev.org/746949 | 14:50 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Add live migration tests for PCI, SR-IOV servers https://review.opendev.org/746950 | 14:50 |
| stephenfin | sean-k-mooney: Ta-da ^ | 14:50 |
| lyarwood | dansmith: yeah understood thanks | 14:50 |
| *** mvorwerk has quit IRC | 14:50 | |
| stephenfin | If you can think of ways I can improve those live migration tests to highlight bugs, lemme know | 14:50 |
| stephenfin | tbh I was expecting the resize test to fail because I thought you'd said that was broken, but clearly not. Maybe I'm thinking of another move operation | 14:51 |
| *** dklyle has quit IRC | 14:51 | |
| *** slaweq has joined #openstack-nova | 14:51 | |
| sean-k-mooney | stephenfin: nice | 14:52 |
| sean-k-mooney | ill start working my way through them | 14:52 |
| stephenfin | as for why I was seeing the HTTP 500 for NoValidHost, it's the use of the CastAsCall fixture | 14:52 |
| sean-k-mooney | gibi_pto_24th: wehn your back ^ will be of interest | 14:52 |
| sean-k-mooney | stephenfin: resize is broken if it does a retry i think | 14:53 |
| *** fumesover32 has quit IRC | 14:53 | |
| sean-k-mooney | stephenfin: tere are edgecases that fail for all move operations except live_migration with vnic_type=direct | 14:54 |
| stephenfin | sean-k-mooney: Feel free to stick in comments. I'm happy to keep bulking out these tests | 14:54 |
| stephenfin | given the hardwork is done now, I think | 14:54 |
| sean-k-mooney | so i think it will be nice to assert the correct behavior of gibis attach/detach feature | 14:54 |
| *** belmoreira has quit IRC | 14:55 | |
| *** mvorwerk has joined #openstack-nova | 14:55 | |
| sean-k-mooney | stephenfin: but ya i have a list in the downstream emial i sent | 14:55 |
| sean-k-mooney | stephenfin: one example of something that is broke is we do not update the neutron port mac address for pf migration | 14:56 |
| stephenfin | Cool. I can assert that kind of stuff in the test | 14:56 |
| sean-k-mooney | that is broken for both cold and live migration | 14:56 |
| sean-k-mooney | detach on livem migation with PFs is also broken | 14:57 |
| *** fumesover32 has joined #openstack-nova | 14:57 | |
| stephenfin | can you attach PFs via neutron? | 14:57 |
| sean-k-mooney | not after the vm is booted | 14:57 |
| sean-k-mooney | but on boot yes | 14:57 |
| * stephenfin assumed it was only VFs | 14:57 | |
| sean-k-mooney | vnic_type=direct-phsyical | 14:57 |
| sean-k-mooney | no it was rammed through as a feature without accounting form a bunch of basic edgecease | 14:58 |
| sean-k-mooney | and broke backwards compatiablei of the pci alias | 14:58 |
| stephenfin | sounds like CPU pinning and PCI in general | 14:59 |
| *** dklyle has joined #openstack-nova | 15:00 | |
| sean-k-mooney | not really | 15:01 |
| *** larainema has joined #openstack-nova | 15:04 | |
| *** mriedem has left #openstack-nova | 15:04 | |
| *** xinranwang__ has quit IRC | 15:05 | |
| *** mvorwerk has quit IRC | 15:05 | |
| *** kberger_ has joined #openstack-nova | 15:08 | |
| *** KeithMnemonic has quit IRC | 15:10 | |
| *** mvorwerk has joined #openstack-nova | 15:13 | |
| iurygregory | sean-k-mooney, hey I did the changes directly to the node (in setup time) and at least all non uefi/multinode jobs are green =) | 15:14 |
| *** mvorwerk has quit IRC | 15:19 | |
| *** mvorwerk has joined #openstack-nova | 15:20 | |
| sean-k-mooney | cool | 15:23 |
| *** sapd1 has joined #openstack-nova | 15:26 | |
| *** brinzhang0 has joined #openstack-nova | 15:29 | |
| *** fumesover32 has quit IRC | 15:30 | |
| *** fumesover32 has joined #openstack-nova | 15:30 | |
| *** brinzhang_ has quit IRC | 15:32 | |
| *** mvorwerk has quit IRC | 15:33 | |
| *** mvorwerk has joined #openstack-nova | 15:34 | |
| *** LiangFang has quit IRC | 15:35 | |
| *** mvorwerk has quit IRC | 15:39 | |
| *** mvorwerk has joined #openstack-nova | 15:41 | |
| *** gyee has joined #openstack-nova | 15:44 | |
| *** seba has joined #openstack-nova | 15:45 | |
| *** mkrai has quit IRC | 16:04 | |
| stephenfin | gmann: suuuuper dumb question. I'm attempting to enable policy by default in all tests but seeing policy failures https://review.opendev.org/#/c/745906/ | 16:05 |
| stephenfin | gmann: some of the rules are using PROJECT_MEMBER_OR_SYSTEM_ADMIN but I'm seeing requests using the non-admin user rejected | 16:06 |
| stephenfin | I assume I need to toggle that "enable new system-scoped policy" config option to get this working? | 16:06 |
| gmann | stephenfin: with PROJECT_MEMBER_OR_SYSTEM_ADMIN check_str we have is to validate the 'system:all' for SYSTEM_ADMIN part and projectid&&member role for PROJECT_MEMBER so non admin would not pass if it is different project | 16:08 |
| gmann | stephenfin: are you removing the old defaults also? if not then it should keep working | 16:08 |
| gmann | let me check the patch | 16:08 |
| *** mriedem has joined #openstack-nova | 16:08 | |
| stephenfin | gmann: okay, that's what I was expecting but it doesn't happen | 16:08 |
| gmann | if you enable enforce_scope then it will start failing. as it need scope checks also | 16:09 |
| stephenfin | if you could have a look, I'd be grateful :) I think it's a good idea (enabling policy by default) | 16:09 |
| gmann | stephenfin: yeah, that is really good idea to run tests with actual policy. though we might need to do lot of work on test side though | 16:10 |
| gmann | checking.. | 16:10 |
| stephenfin | not as much as you'd fear | 16:10 |
| *** xek has quit IRC | 16:10 | |
| gmann | stephenfin: if you try to do with admin (super access role) then yes no much changes but tests with real policy will be to use reader, member, admin roles. GET APIs by reader role not admin and so on | 16:13 |
| stephenfin | yeah, to be fair, I've only tested with legacy policy config and I've been blasting through things with admin credentials where necessary /o\ | 16:17 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Fix indentation in test__video_model_supported https://review.opendev.org/746979 | 16:25 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Add libvirt version mocks in test_private_destroy_* tests https://review.opendev.org/746980 | 16:25 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION and NEXT_MIN_{LIBVIRT,QEMU}_VERSION https://review.opendev.org/746981 | 16:25 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Remove MIN_LIBVIRT_FILE_BACKED_DISCARD_VERSION https://review.opendev.org/746982 | 16:25 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Remove MIN_{LIBVIRT,QEMU}_NATIVE_TLS_VERSION https://review.opendev.org/746983 | 16:25 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Remove MIN_LIBVIRT_BETTER_SIGKILL_HANDLING https://review.opendev.org/746984 | 16:25 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Remove MIN_LIBVIRT_VIDEO_MODEL_VERSIONS https://review.opendev.org/746985 | 16:25 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Remove MIN_{LIBVIRT,QEMU}_PMEM_SUPPORT https://review.opendev.org/746986 | 16:25 |
| gmann | stephenfin: ok. for legacy policy, that is ok. | 16:28 |
| *** xek has joined #openstack-nova | 16:30 | |
| *** ociuhandu_ has joined #openstack-nova | 16:30 | |
| gmann | stephenfin: those failing test missing ADMIN_API=True, i checked admin_action failed tests. because by default it is non admin API request, sample tests need to set ADMIN_API for admin APIs - https://github.com/openstack/nova/blob/cff7382fb3de4eef7aeddc34b6ae3409cbe50ea0/nova/tests/functional/integrated_helpers.py#L1036 | 16:33 |
| stephenfin | cool, that's what I've done in most cases | 16:33 |
| *** ociuhandu has quit IRC | 16:34 | |
| *** ociuhandu_ has quit IRC | 16:34 | |
| gmann | and for GET APIs where default is admin_or_owner they are failing for missing admin fields in response which confirms this and no other policy issue | 16:35 |
| stephenfin | so I'm going to run all the servers tests as admin to get those extra fields | 16:38 |
| stephenfin | but anything else, I'll just drop the admin-only fields from the response | 16:38 |
| gmann | stephenfin: from func sample tests? | 16:38 |
| stephenfin | yup | 16:38 |
| gmann | i think we should not, functional sample tests has complete response verification and we use that in api-ref also. | 16:39 |
| gmann | making servers tests as admin is ok i think | 16:40 |
| stephenfin | Sure, for this like 'GET /servers/{id}' | 16:40 |
| gmann | and other tests also as admin if it involve admin APi | 16:40 |
| stephenfin | what about things like the rescue action? | 16:41 |
| stephenfin | that's currently being tested as a non-admin user but the response we've documented in an admin-type response | 16:41 |
| stephenfin | I'm thinking those admin fields aren't important in that instance and we should keep showing a non-admin response | 16:42 |
| stephenfin | but maybe not | 16:42 |
| gmann | rescue does not add admin-only fields. you mean rebuild? | 16:43 |
| stephenfin | Sorry, I mean in the response | 16:43 |
| stephenfin | actually, never mind | 16:43 |
| gmann | yeah in response rescue return empty dict or admin_password | 16:43 |
| stephenfin | this is what I was referring to https://github.com/openstack/nova/blob/master/nova/tests/functional/api_sample_tests/test_rescue.py#L94 | 16:44 |
| stephenfin | but that's only for internal validation purposes | 16:44 |
| stephenfin | that sample response doesn't need admin-fields in it | 16:44 |
| gmann | stephenfin: ohk i got now. yes we can keep that with non-admin. if sample is not complete then yes keep testing that with non-admin. | 16:46 |
| *** xek has quit IRC | 16:46 | |
| gmann | stephenfin: even such test can just check state from response explicitly instead of comparing it with sample file response. | 16:47 |
| *** ociuhandu has joined #openstack-nova | 16:48 | |
| *** lpetrut has quit IRC | 16:50 | |
| *** ociuhandu has quit IRC | 16:52 | |
| *** psachin has quit IRC | 16:53 | |
| *** tesseract has quit IRC | 17:00 | |
| *** dtantsur is now known as dtantsur|afk | 17:01 | |
| *** artom has quit IRC | 17:05 | |
| *** k_mouza has quit IRC | 17:05 | |
| *** martinkennelly has quit IRC | 17:09 | |
| *** martinkennelly has joined #openstack-nova | 17:10 | |
| *** k_mouza has joined #openstack-nova | 17:15 | |
| *** nightmare_unreal has quit IRC | 17:17 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Move single-use function to its caller https://review.opendev.org/745904 | 17:19 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Drop '_api' suffix from placement fixture https://review.opendev.org/745905 | 17:19 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Enable real policy fixture by default https://review.opendev.org/745906 | 17:19 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Add and use 'GlanceFixture' https://review.opendev.org/745907 | 17:19 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Remove '_FakeImageService' https://review.opendev.org/745908 | 17:19 |
| stephenfin | gmann: ^ | 17:19 |
| stephenfin | I might have missed one or two tests (there were 109 failures, after all) but that should be pretty correct now :) | 17:19 |
| *** k_mouza has quit IRC | 17:20 | |
| gmann | stephenfin: ok, waiting for gate result | 17:21 |
| *** sapd1 has quit IRC | 17:28 | |
| *** sapd1 has joined #openstack-nova | 17:29 | |
| stephenfin | dansmith: melwitt: Can you folks look at https://review.opendev.org/#/c/744958/ again today? | 17:31 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: compute: Add type hints for resize functions https://review.opendev.org/745341 | 17:32 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: compute: Add more type hints for resize functions https://review.opendev.org/745675 | 17:32 |
| *** artom has joined #openstack-nova | 17:34 | |
| *** xek has joined #openstack-nova | 17:44 | |
| *** maciejjozefczyk_ has joined #openstack-nova | 17:47 | |
| *** brinzhang_ has joined #openstack-nova | 17:47 | |
| *** maciejjozefczyk has quit IRC | 17:48 | |
| *** maciejjozefczyk has joined #openstack-nova | 17:49 | |
| *** sapd1 has quit IRC | 17:50 | |
| *** brinzhang0 has quit IRC | 17:51 | |
| *** maciejjozefczyk_ has quit IRC | 17:52 | |
| *** k_mouza has joined #openstack-nova | 17:54 | |
| *** xek_ has joined #openstack-nova | 17:55 | |
| artom | stephenfin, lyarwood, did any of you start backporting Stephen's func tests refactors to train? Or did we want to socialize that a bit first? | 17:55 |
| artom | Nothing that I can find in gerrit, at any rate. Shall I start? | 17:56 |
| *** xek has quit IRC | 17:57 | |
| lyarwood | artom: I've not had a chance to get back to it so feel free to start | 17:58 |
| *** k_mouza has quit IRC | 17:59 | |
| lyarwood | elod: https://review.opendev.org/#/c/746529/ - that reminds me can you take a look at this series from artom when you have time please | 17:59 |
| *** xek_ has quit IRC | 18:00 | |
| artom | lyarwood, yep, thanks for poking elod for me | 18:01 |
| dansmith | artom: I think stephenfin did what you asked here, so can you throw your +1 back on it? https://review.opendev.org/#/c/744950/4 | 18:01 |
| dansmith | er, s/back// | 18:01 |
| lyarwood | melwitt: https://review.opendev.org/#/c/745512/ - trivial test cleanup if you have time today btw | 18:06 |
| *** k_mouza has joined #openstack-nova | 18:08 | |
| *** lpetrut has joined #openstack-nova | 18:10 | |
| *** k_mouza has quit IRC | 18:14 | |
| *** lpetrut has quit IRC | 18:17 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: rbd: Move rbd_utils out of libvirt driver under nova.storage https://review.opendev.org/746904 | 18:20 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301 | 18:20 |
| *** k_mouza has joined #openstack-nova | 18:23 | |
| melwitt | lyarwood: took too long to find what I was looking for, but commented on your patch that there's a fixture for doing that | 18:23 |
| dansmith | so that would only work with eventlet, | 18:25 |
| dansmith | which seems like an odd thing to favor | 18:25 |
| yankcrime | hey folks, i think i'm hitting this bug with an instance that was created circa rocky, but now a user has stopped and is attempting to start it again for this first time under ussuri: https://bugs.launchpad.net/nova/+bug/1864020 | 18:26 |
| openstack | Launchpad bug 1864020 in OpenStack Compute (nova) "libvirt.libvirtError: Requested operation is not valid: format of backing image %s of image %s was not specified in the image metadata (See https://libvirt.org/kbase/backing_chains.html for troubleshooting)" [Undecided,Fix committed] - Assigned to Lee Yarwood (lyarwood) | 18:26 |
| yankcrime | if i'm reading right, it's related to libvirt 6.0 and that fix only applies to new instances that are created with this vesion of libvirt | 18:26 |
| *** k_mouza has quit IRC | 18:26 | |
| *** martinkennelly has quit IRC | 18:30 | |
| lyarwood | yankcrime: yeah I thought libvirt then relaxed this in a later release? | 18:30 |
| *** artom has quit IRC | 18:30 | |
| melwitt | dansmith: yeah I guess loopingcall uses eventlet for its looping https://github.com/openstack/oslo.service/blob/master/oslo_service/loopingcall.py | 18:31 |
| lyarwood | yankcrime: sorry need to drop for the day now but if this isn't resolved by a later release of libvirt then you might need to convert the disks in place to include the format details of the backing file | 18:32 |
| * lyarwood drops | 18:33 | |
| dansmith | yeah that seems weird to me -- if we were to convert some of our stuff to real threads as we've discussed before, that'd be a problem | 18:33 |
| yankcrime | lyarwood: yeah that's the conclusion i'm coming to, wanted to make sure i wasn't missing anything | 18:34 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Remove MIN_LIBVIRT_FILE_BACKED_DISCARD_VERSION https://review.opendev.org/746982 | 18:34 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Remove MIN_{LIBVIRT,QEMU}_NATIVE_TLS_VERSION https://review.opendev.org/746983 | 18:34 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Remove MIN_LIBVIRT_BETTER_SIGKILL_HANDLING https://review.opendev.org/746984 | 18:34 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Remove MIN_LIBVIRT_VIDEO_MODEL_VERSIONS https://review.opendev.org/746985 | 18:34 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Remove MIN_{LIBVIRT,QEMU}_PMEM_SUPPORT https://review.opendev.org/746986 | 18:34 |
| lyarwood | yankcrime: yup sorry, I was sure the libvirt folks backed down after we complained about this but I can't seem to find the change | 18:34 |
| lyarwood | yankcrime: kashyap is the person to speak to about this, I'll follow up with him in the morning | 18:35 |
| * lyarwood really drops this time | 18:35 | |
| yankcrime | lyarwood: damn, fwiw i'm on 6.0.0-0ubuntu8.1~cloud0 | 18:35 |
| yankcrime | lyarwood: thanks! | 18:35 |
| *** maciejjozefczyk has quit IRC | 18:36 | |
| melwitt | dansmith: yeah, if we convert then we'd have to add support to loopingcall or stop using loopingcall I guess | 18:36 |
| *** maciejjozefczyk has joined #openstack-nova | 18:37 | |
| *** k_mouza has joined #openstack-nova | 18:40 | |
| *** k_mouza has quit IRC | 18:40 | |
| *** martinkennelly has joined #openstack-nova | 18:43 | |
| *** vishalmanchanda has quit IRC | 18:49 | |
| *** jdillaman has joined #openstack-nova | 18:57 | |
| *** martinkennelly has quit IRC | 19:00 | |
| *** ociuhandu has joined #openstack-nova | 19:04 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Add reproducer for bug #1879878 https://review.opendev.org/744950 | 19:32 |
| openstack | bug 1879878 in OpenStack Compute (nova) "VM become Error after confirming resize with Error info CPUUnpinningInvalid on source node " [Medium,In progress] https://launchpad.net/bugs/1879878 - Assigned to Stephen Finucane (stephenfinucane) | 19:32 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Don't unset Instance.old_flavor, new_flavor until necessary https://review.opendev.org/744958 | 19:32 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: manager: Move context manager up one level https://review.opendev.org/745674 | 19:32 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: compute: Add type hints for resize functions https://review.opendev.org/745341 | 19:32 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: compute: Add more type hints for resize functions https://review.opendev.org/745675 | 19:32 |
| stephenfin | dansmith: Addressed your comments ^ If you could take the third one in that series too, that'd be great (split out per your request) | 19:33 |
| *** ociuhandu has quit IRC | 19:34 | |
| *** priteau has quit IRC | 19:44 | |
| *** efried has quit IRC | 19:49 | |
| *** efried has joined #openstack-nova | 19:49 | |
| *** artom has joined #openstack-nova | 20:11 | |
| openstackgerrit | Merged openstack/nova master: libvirt: Mock LoopingCallBase._sleep in rbd tests https://review.opendev.org/745512 | 20:16 |
| *** breizhkoala has quit IRC | 20:19 | |
| *** ociuhandu has joined #openstack-nova | 20:22 | |
| mnaser | fyi, ceph jobs are breaking often and i tracked it down to https://review.opendev.org/747030 | 20:26 |
| mnaser | hoping to land that when we can :) | 20:26 |
| melwitt | thanks mnaser. looks like cinder core are core on devstack-plugin-ceph | 20:33 |
| *** dustinc has quit IRC | 20:49 | |
| *** nweinber has quit IRC | 21:01 | |
| *** raildo has quit IRC | 21:01 | |
| *** ociuhandu has quit IRC | 21:06 | |
| *** slaweq has quit IRC | 21:07 | |
| *** maciejjozefczyk has quit IRC | 21:08 | |
| *** damien_r has quit IRC | 21:12 | |
| *** kaisers1 has joined #openstack-nova | 21:15 | |
| *** kaisers has quit IRC | 21:17 | |
| *** slaweq has joined #openstack-nova | 21:19 | |
| openstackgerrit | Merged openstack/python-novaclient master: zuul functional job: drop the custom playbooks https://review.opendev.org/746649 | 21:21 |
| *** slaweq has quit IRC | 21:23 | |
| *** slaweq has joined #openstack-nova | 21:34 | |
| *** slaweq has quit IRC | 21:38 | |
| *** tosky has quit IRC | 21:47 | |
| *** tony_su has quit IRC | 21:49 | |
| *** efried has quit IRC | 21:59 | |
| *** xek has joined #openstack-nova | 22:05 | |
| *** xek has quit IRC | 22:07 | |
| *** xek has joined #openstack-nova | 22:08 | |
| *** xek has quit IRC | 22:12 | |
| *** xek has joined #openstack-nova | 22:15 | |
| *** mriedem has left #openstack-nova | 22:21 | |
| *** efried has joined #openstack-nova | 22:27 | |
| *** xek has quit IRC | 22:31 | |
| *** efried has quit IRC | 22:49 | |
| gmann | stephenfin: commented about server tag test failing with non-admin even this API is admin-or-owner. that is because of different project_id of server in SingleCellSimple and OSAPIFixture - https://review.opendev.org/#/c/745906/2/nova/tests/functional/api_sample_tests/test_server_tags.py@22 | 22:50 |
| gmann | also there are few tests does not need ADMIN_API=true which were passing with non-admin also in previous PS | 22:51 |
| *** tkajinam has joined #openstack-nova | 22:58 | |
| *** efried has joined #openstack-nova | 22:59 | |
| *** rcernin has joined #openstack-nova | 22:59 | |
| *** mlavalle has quit IRC | 23:03 | |
| *** ociuhandu has joined #openstack-nova | 23:06 | |
| *** ociuhandu has quit IRC | 23:11 | |
| *** spatel has joined #openstack-nova | 23:24 | |
| *** mvorwerk_ has joined #openstack-nova | 23:25 | |
| *** mvorwerk has quit IRC | 23:28 | |
| *** spatel has quit IRC | 23:30 | |
| *** suryasingh has quit IRC | 23:37 | |
| *** spatel has joined #openstack-nova | 23:40 | |
| *** tetsuro has joined #openstack-nova | 23:44 | |
| *** tetsuro has quit IRC | 23:57 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!
