*** pas-ha has joined #openstack-nova | 00:02 | |
*** csatari has joined #openstack-nova | 00:02 | |
*** evrardjp has quit IRC | 00:05 | |
*** evrardjp has joined #openstack-nova | 00:06 | |
*** _erlon_ has quit IRC | 00:21 | |
openstackgerrit | sean mooney proposed openstack/nova master: [WIP] Set migrate_data.vifs only when using multiple port bindings https://review.opendev.org/742180 | 00:30 |
---|---|---|
*** dave-mccowan has quit IRC | 00:45 | |
*** Liang__ has joined #openstack-nova | 01:26 | |
*** hongbin has quit IRC | 01:36 | |
*** gyee has quit IRC | 01:55 | |
*** hongbin has joined #openstack-nova | 02:06 | |
*** suryasingh has joined #openstack-nova | 02:12 | |
*** rcernin has quit IRC | 02:37 | |
openstackgerrit | Merged openstack/nova master: Pass the actual target in baremetal nodes policy https://review.opendev.org/741717 | 02:45 |
openstackgerrit | Merged openstack/nova master: Add scope and new default roles in extensions policies https://review.opendev.org/743046 | 02:45 |
openstackgerrit | Merged openstack/nova master: Add new default roles in networks policies https://review.opendev.org/742566 | 02:45 |
openstackgerrit | Merged openstack/nova master: Pass the actual target in networks policy https://review.opendev.org/742568 | 02:45 |
openstackgerrit | Merged openstack/nova master: libvirt: Do not reference VIR_ERR_DEVICE_MISSING when libvirt is < v4.1.0 https://review.opendev.org/746210 | 02:45 |
*** mkrai has joined #openstack-nova | 02:54 | |
*** rcernin has joined #openstack-nova | 02:58 | |
*** rcernin has quit IRC | 03:04 | |
*** rcernin has joined #openstack-nova | 03:04 | |
*** boxiang has joined #openstack-nova | 03:07 | |
*** evrardjp_ has joined #openstack-nova | 03:12 | |
*** evrardjp has quit IRC | 03:15 | |
*** psachin has joined #openstack-nova | 03:38 | |
*** sapd1 has joined #openstack-nova | 04:05 | |
*** Liang__ has quit IRC | 04:24 | |
*** Liang__ has joined #openstack-nova | 04:24 | |
*** evrardjp_ has quit IRC | 04:33 | |
*** evrardjp has joined #openstack-nova | 04:35 | |
*** hongbin has quit IRC | 04:36 | |
*** vishalmanchanda has joined #openstack-nova | 05:08 | |
*** ratailor has joined #openstack-nova | 05:13 | |
*** mkrai has quit IRC | 05:22 | |
*** sapd1 has quit IRC | 05:30 | |
*** mkrai has joined #openstack-nova | 05:32 | |
*** Liang__ has quit IRC | 05:56 | |
*** yonglihe has joined #openstack-nova | 05:57 | |
*** Liang__ has joined #openstack-nova | 05:58 | |
*** sapd1 has joined #openstack-nova | 06:28 | |
*** slaweq has joined #openstack-nova | 06:34 | |
*** sapd1 has quit IRC | 06:36 | |
*** tbachman has quit IRC | 06:38 | |
*** jdillaman has quit IRC | 06:38 | |
*** purplerbot has quit IRC | 06:38 | |
*** danpawlik has quit IRC | 06:38 | |
*** ganso has quit IRC | 06:38 | |
*** noonedeadpunk has quit IRC | 06:38 | |
*** rnoriega_ has quit IRC | 06:38 | |
*** mvorwerk has joined #openstack-nova | 06:43 | |
*** tbachman has joined #openstack-nova | 06:43 | |
*** jdillaman has joined #openstack-nova | 06:43 | |
*** purplerbot has joined #openstack-nova | 06:43 | |
*** danpawlik has joined #openstack-nova | 06:43 | |
*** ganso has joined #openstack-nova | 06:43 | |
*** noonedeadpunk has joined #openstack-nova | 06:43 | |
*** rnoriega_ has joined #openstack-nova | 06:43 | |
*** sapd1 has joined #openstack-nova | 06:48 | |
*** mvorwerk has quit IRC | 06:49 | |
*** mvorwerk has joined #openstack-nova | 06:49 | |
*** damien_r has joined #openstack-nova | 06:51 | |
*** sapd1 has quit IRC | 06:53 | |
*** ociuhandu has quit IRC | 06:56 | |
*** damien_r has quit IRC | 06:56 | |
*** ociuhandu has joined #openstack-nova | 06:57 | |
*** belmoreira has joined #openstack-nova | 06:57 | |
*** ociuhandu has quit IRC | 07:01 | |
*** damien_r has joined #openstack-nova | 07:03 | |
*** mkrai has quit IRC | 07:03 | |
*** sapd1 has joined #openstack-nova | 07:05 | |
*** happyhemant has joined #openstack-nova | 07:21 | |
*** rcernin has quit IRC | 07:22 | |
*** tesseract has joined #openstack-nova | 07:25 | |
*** jkulik has joined #openstack-nova | 07:28 | |
*** dtantsur|afk is now known as dtantsur | 07:31 | |
*** damien_r has quit IRC | 07:35 | |
*** damien_r has joined #openstack-nova | 07:36 | |
*** hongbin has joined #openstack-nova | 07:36 | |
*** priteau has joined #openstack-nova | 07:41 | |
*** hongbin has quit IRC | 07:41 | |
*** damien_r has quit IRC | 07:50 | |
*** slaweq has quit IRC | 07:50 | |
*** gibi_pto_24th has quit IRC | 07:50 | |
*** admin0 has quit IRC | 07:50 | |
*** mkrai has joined #openstack-nova | 08:02 | |
*** sapd1 has quit IRC | 08:14 | |
*** tosky has joined #openstack-nova | 08:22 | |
*** damien_r has joined #openstack-nova | 08:22 | |
*** slaweq has joined #openstack-nova | 08:22 | |
*** admin0 has joined #openstack-nova | 08:22 | |
*** gibi_pto_24th has joined #openstack-nova | 08:22 | |
*** sapd1 has joined #openstack-nova | 08:22 | |
*** lpetrut has joined #openstack-nova | 08:22 | |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/ussuri: libvirt: Do not reference VIR_ERR_DEVICE_MISSING when libvirt is < v4.1.0 https://review.opendev.org/747357 | 08:23 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: libvirt: Do not reference VIR_ERR_DEVICE_MISSING when libvirt is < v4.1.0 https://review.opendev.org/747358 | 08:27 |
*** k_mouza has joined #openstack-nova | 08:37 | |
*** brinzhang has joined #openstack-nova | 08:41 | |
*** arne_wiebalck has quit IRC | 08:44 | |
*** danpawlik has quit IRC | 08:45 | |
*** arne_wiebalck has joined #openstack-nova | 08:46 | |
*** danpawlik has joined #openstack-nova | 08:47 | |
*** dklyle has quit IRC | 08:49 | |
alex_xu | stephenfin: yea, guess, the db status and rt isn't update under same lock | 08:49 |
alex_xu | s/guess/guess so/ | 08:50 |
stephenfin | alex_xu: The ResourceTracker is so broken :'( | 08:50 |
stephenfin | Spent all day merely trying to figure out how broken it is, heh | 08:51 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: libvirt: Do not reference VIR_ERR_DEVICE_MISSING when libvirt is < v4.1.0 https://review.opendev.org/747360 | 08:51 |
alex_xu | hah | 08:51 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: libvirt: Do not reference VIR_ERR_DEVICE_MISSING when libvirt is < v4.1.0 https://review.opendev.org/747361 | 08:52 |
*** openstackgerrit has quit IRC | 08:54 | |
*** openstackgerrit has joined #openstack-nova | 08:55 | |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: libvirt: Do not reference VIR_ERR_DEVICE_MISSING when libvirt is < v4.1.0 https://review.opendev.org/747362 | 08:55 |
lyarwood | elod_off: https://review.opendev.org/#/q/topic:bug/1887946+status:open - When you're back this series will need some stable reviews :) | 08:56 |
*** rcernin has joined #openstack-nova | 09:07 | |
*** sapd1 has quit IRC | 09:10 | |
*** martinkennelly has joined #openstack-nova | 09:24 | |
*** k_mouza has quit IRC | 09:27 | |
*** ratailor has quit IRC | 09:38 | |
*** k_mouza has joined #openstack-nova | 09:42 | |
*** ociuhandu has joined #openstack-nova | 09:53 | |
*** ociuhandu has quit IRC | 09:53 | |
*** ociuhandu has joined #openstack-nova | 09:54 | |
openstackgerrit | Merged openstack/nova master: functional: Move single-use function to its caller https://review.opendev.org/745904 | 10:06 |
openstackgerrit | Merged openstack/nova master: functional: Drop '_api' suffix from placement fixture https://review.opendev.org/745905 | 10:06 |
*** belmoreira has quit IRC | 10:07 | |
*** rcernin has quit IRC | 10:13 | |
*** mkrai has quit IRC | 10:14 | |
*** k_mouza has quit IRC | 10:31 | |
*** k_mouza has joined #openstack-nova | 10:42 | |
*** brinzhang has quit IRC | 10:45 | |
*** Liang__ has quit IRC | 10:48 | |
*** jhesketh has quit IRC | 10:53 | |
*** jhesketh has joined #openstack-nova | 10:55 | |
*** rcernin has joined #openstack-nova | 10:59 | |
*** jangutter_ has joined #openstack-nova | 10:59 | |
*** jangutter has quit IRC | 11:02 | |
lyarwood | https://github.com/openstack/nova/blob/835440e3f9dace4074511036473ebdae22f72c25/nova/context.py#L268-L279 - does anyone know if there's a way to get an admin context with a populated service catalog? | 11:04 |
lyarwood | ^ at the moment we are using this during self.driver.resume_state_on_host_boot and failing when attempting to hard reboot instances with encrypted volumes as the key_manager service isn't listed in the service catalog | 11:05 |
lyarwood | appreciate that even if it was the admin context wouldn't be able to fetch user secrets without changing policy but I'd still like to fix this if possible | 11:06 |
*** rcernin has quit IRC | 11:12 | |
*** jangutter has joined #openstack-nova | 11:15 | |
*** jangutter_ has quit IRC | 11:17 | |
*** raildo has joined #openstack-nova | 11:22 | |
*** k_mouza has quit IRC | 11:34 | |
*** boxiang_ has joined #openstack-nova | 11:40 | |
*** boxiang has quit IRC | 11:43 | |
*** links has joined #openstack-nova | 11:46 | |
artom | sean-k-mooney, well my VPN just died, but https://github.com/openstack/nova/blob/master/nova/virt/libvirt/migration.py#L96 | 11:49 |
artom | And https://github.com/openstack/nova/blob/master/nova/virt/libvirt/migration.py#L144 | 11:50 |
*** yonglihe has quit IRC | 11:54 | |
*** _erlon_ has joined #openstack-nova | 11:57 | |
*** k_mouza has joined #openstack-nova | 12:06 | |
*** k_mouza has quit IRC | 12:21 | |
*** k_mouza has joined #openstack-nova | 12:21 | |
*** k_mouza has quit IRC | 12:26 | |
*** dave-mccowan has joined #openstack-nova | 12:38 | |
sean-k-mooney | artom that only does it for numa migration | 12:40 |
sean-k-mooney | artom: it does not print them for all migrations | 12:40 |
sean-k-mooney | because of https://github.com/openstack/nova/blob/835440e3f9dace4074511036473ebdae22f72c25/nova/virt/libvirt/migration.py#L66 | 12:40 |
sean-k-mooney | we should move the loging to the start and end of get_updated_guest_xml | 12:40 |
sean-k-mooney | so it does it for all migrations | 12:41 |
artom | sean-k-mooney, ah, in that sense, yeah | 12:43 |
sean-k-mooney | dansmith: by the way i figured out why https://bugs.launchpad.net/nova/+bug/1888395 happens im working on a repoducer now but the fix is basicaly https://review.opendev.org/#/c/742180/ | 12:44 |
openstack | Launchpad bug 1888395 in OpenStack Compute (nova) "shared live migration of a vm with a vif is broken in train" [High,In progress] - Assigned to sean mooney (sean-k-mooney) | 12:44 |
sean-k-mooney | stephenfin: is the only functional test with live migration and port your new one or do you know if gibi added some for bandwidth based schduling | 12:46 |
sean-k-mooney | i think he did but just going to look for them now | 12:46 |
sean-k-mooney | artom: you siad your numa live migation test dont use interface right | 12:47 |
artom | sean-k-mooney, nope | 12:48 |
sean-k-mooney | ah yes server = self._create_server(flavor_id=flavor, host=host, | 12:48 |
sean-k-mooney | networks='none') | 12:48 |
artom | sean-k-mooney, I'm wondering if it wouldn't be easier to reproduce that migrate_data.vifs bug with a DNM CI patch | 12:48 |
artom | Is there a way we can deploy Neutron in CI without the multiple port bindings extension? | 12:48 |
sean-k-mooney | no but i can hack the nova neutron client to always return false | 12:49 |
sean-k-mooney | that may or may not tirgger it i guess | 12:50 |
sean-k-mooney | i might however ill try that quickly i would prefer to have a regression test however | 12:50 |
artom | sean-k-mooney, yeah, long-term something merged in-tree would be better | 12:51 |
artom | Or a real CI job for it | 12:51 |
sean-k-mooney | im not standing up a contrial ci :P | 12:51 |
sean-k-mooney | live migration is really uncloudy we should maybe just remove it instead. it would be a lot less work and headaces then a contrail ci :) | 12:52 |
artom | lulz | 12:53 |
sean-k-mooney | it would "fix" all the live migration bugs :) | 12:53 |
sean-k-mooney | so there is a live migration test with the old microvertion that does not support it for bandwith | 12:58 |
sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/tests/functional/test_servers.py#L5993-L6029 | 12:58 |
sean-k-mooney | but not the new one so ya i think i would need stephenfin patches to cover the gaps in the neutron fixture | 12:58 |
sean-k-mooney | oh there are more test for move operatoins later | 12:59 |
sean-k-mooney | ah ha https://github.com/openstack/nova/blob/master/nova/tests/functional/test_servers.py#L7299 | 13:01 |
sean-k-mooney | test_live_migrate_with_qos_port | 13:01 |
sean-k-mooney | so even without stephenfin patches there is technically enough of a fixture to do the migration with a port | 13:02 |
sean-k-mooney | just not sriov which is fine | 13:02 |
sean-k-mooney | i just need to mock the fixture or alter it in the regression test. | 13:03 |
sean-k-mooney | i need to redefine https://github.com/openstack/nova/blob/835440e3f9dace4074511036473ebdae22f72c25/nova/tests/fixtures.py#L1739-L1752 | 13:04 |
sean-k-mooney | which i think i can do with a mock | 13:05 |
*** happyhemant has quit IRC | 13:10 | |
*** k_mouza has joined #openstack-nova | 13:19 | |
*** KeithMnemonic has joined #openstack-nova | 13:20 | |
*** mriedem has joined #openstack-nova | 13:21 | |
stephenfin | you could totally modify the fixture to remove "support" for multiple port bindings | 13:22 |
sean-k-mooney | im just replaceing the list_extensions function on my instance of the fixture object before i activate it | 13:26 |
sean-k-mooney | it looks like that shoudl work and is trivial to do | 13:26 |
sean-k-mooney | self.neutron = nova_fixtures.NeutronFixture(self) | 13:26 |
sean-k-mooney | self.neutron.list_extensions = self.list_extensions | 13:26 |
sean-k-mooney | self.useFixture(self.neutron) | 13:27 |
sean-k-mooney | basicly that | 13:27 |
sean-k-mooney | im basically modifing https://github.com/openstack/nova/blob/master/nova/tests/functional/regressions/test_bug_1862633.py | 13:27 |
dansmith | sean-k-mooney: I saw the discussion, thanks for chasing that down | 13:27 |
sean-k-mooney | well not modifing just copying it and creating a new one | 13:27 |
sean-k-mooney | dansmith: it was not obvious at first but i knew the code path it was taking was for multipel portbindings | 13:28 |
*** sapd1 has joined #openstack-nova | 13:29 | |
sean-k-mooney | anyway hopefully ill have a functional regression test for this today and we can do the too patch thing were i assert the behavior is broken and then that the patch fixes it | 13:29 |
dansmith | sweet | 13:30 |
*** nweinber has joined #openstack-nova | 13:32 | |
*** mlavalle has joined #openstack-nova | 14:01 | |
*** lpetrut has quit IRC | 14:15 | |
*** hongbin has joined #openstack-nova | 14:23 | |
*** links has quit IRC | 14:23 | |
*** mvorwerk has quit IRC | 14:31 | |
*** nweinber has quit IRC | 14:42 | |
*** dklyle has joined #openstack-nova | 14:54 | |
*** nweinber has joined #openstack-nova | 14:58 | |
*** slaweq has quit IRC | 15:17 | |
*** tkajinam has quit IRC | 15:26 | |
*** slaweq has joined #openstack-nova | 15:28 | |
*** gyee has joined #openstack-nova | 15:34 | |
openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.moves https://review.opendev.org/727224 | 15:41 |
openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.iteritems/itervalues/iterkeys https://review.opendev.org/727757 | 15:42 |
openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.byte2int/int2byte https://review.opendev.org/727777 | 15:43 |
openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.binary_type/integer_types/string_types https://review.opendev.org/728094 | 15:43 |
openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.text_type (1/2) https://review.opendev.org/728109 | 15:43 |
openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.text_type (2/2) https://review.opendev.org/728117 | 15:44 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Few todo fixes for API new policies https://review.opendev.org/746610 | 15:49 |
*** mkrai has joined #openstack-nova | 15:53 | |
*** ociuhandu_ has joined #openstack-nova | 15:53 | |
*** ociuhandu has quit IRC | 15:56 | |
*** ociuhandu_ has quit IRC | 15:57 | |
*** mlavalle has quit IRC | 15:59 | |
*** tosky has quit IRC | 16:00 | |
*** mlavalle has joined #openstack-nova | 16:02 | |
*** tesseract has quit IRC | 16:09 | |
*** suryasingh has quit IRC | 16:10 | |
*** ociuhandu has joined #openstack-nova | 16:15 | |
sean-k-mooney | anyone know of the top of your head how i get a valid admin context in a functional test | 16:16 |
stephenfin | sean-k-mooney: nova.context.get_admin_context() | 16:19 |
stephenfin | look for 'self.ctxt' in nova/tests/functional | 16:19 |
*** ociuhandu has quit IRC | 16:19 | |
sean-k-mooney | thanks | 16:19 |
*** k_mouza has quit IRC | 16:30 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Few todo fixes for API new policies https://review.opendev.org/746610 | 16:39 |
sean-k-mooney | oh i need to use the libvirt driver in this regression test | 16:40 |
sean-k-mooney | that explains why its passing wehn it shoudl not be. | 16:40 |
sean-k-mooney | ok that is still doable | 16:40 |
*** dtantsur is now known as dtantsur|afk | 16:50 | |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: Revert "Handle Neutron errors in _post_live_migration()" https://review.opendev.org/747443 | 16:52 |
* artom wants a Pulitzer prize for that commit message ^^ | 16:53 | |
artom | ... which I screwed up. | 16:53 |
sean-k-mooney | it certenly rivial some of the epics stephenfin has written lately | 16:55 |
sean-k-mooney | :) http://paste.openstack.org/show/797050/ | 16:56 |
sean-k-mooney | there we go repoduced it in a functional test | 16:56 |
stephenfin | not so fast | 16:57 |
artom | Noice. | 16:57 |
sean-k-mooney | i feel like im mocking more then i then i need to and could remove some of the fixture im using | 16:57 |
stephenfin | actually, yeah, that'd make sense for this bug | 16:57 |
sean-k-mooney | but on the other hand its working so.... | 16:58 |
stephenfin | was going to say that was failing for me because the NeutronFixture wasn't setting that field like neutron would in real-life | 16:58 |
stephenfin | but of course it'll only set it if the port-binding extension is present | 16:58 |
sean-k-mooney | actully that the correct behavior | 16:58 |
stephenfin | see the changes I made to https://review.opendev.org/#/c/746947/2/nova/conductor/tasks/live_migrate.py | 16:58 |
sean-k-mooney | currenlty we are setting migrate_data.vif unconditionally | 16:59 |
sean-k-mooney | im fixint that | 16:59 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: Revert "Handle Neutron errors in _post_live_migration()" https://review.opendev.org/747443 | 16:59 |
stephenfin | already fixed ^ | 16:59 |
sean-k-mooney | no that is not the fix | 16:59 |
sean-k-mooney | stephenfin: that code we determined can never be hit | 16:59 |
sean-k-mooney | the if will always be false | 17:00 |
artom | sean-k-mooney, that's just an argument to remove it, which stephenfin is doing | 17:00 |
sean-k-mooney | https://review.opendev.org/#/c/742180/6/nova/compute/manager.py | 17:00 |
sean-k-mooney | stephenfin: that id the fix | 17:00 |
sean-k-mooney | artom: ya i know | 17:00 |
artom | But yeah, they're different things | 17:00 |
sean-k-mooney | artom: also the do said to remove it in ussurit and its victoria | 17:00 |
* stephenfin doesn't have enough context and doesn't want to start at 6pm on a Friday, so will stay whisht | 17:02 | |
artom | stephenfin, understandable. It took sean-k-mooney and me 2 hours on gmeet to nail it. We considered recording it and just putting the YouTube link in the commit messages. | 17:03 |
*** jangutter has quit IRC | 17:03 | |
*** jangutter has joined #openstack-nova | 17:04 | |
sean-k-mooney | so we coudl say you can trust us or here 2 hours of trailing through the code to fiture it out | 17:04 |
*** mkrai has quit IRC | 17:04 | |
*** priteau has quit IRC | 17:07 | |
sean-k-mooney | stephenfin: your patch removing that is not wrong by the way we should do that anyway | 17:07 |
sean-k-mooney | but lets fix the other issue breaking live migation before merging it i want to try and keep the patches small for backproting | 17:11 |
*** psachin has quit IRC | 17:15 | |
*** k_mouza has joined #openstack-nova | 17:17 | |
*** chenhaw has joined #openstack-nova | 17:22 | |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: post live migration: don't call Neutron needlessly https://review.opendev.org/747451 | 17:38 |
artom | I'm pretty sure I broke some unit tests, let's see what CI says. | 17:38 |
*** dustinc has quit IRC | 17:45 | |
sean-k-mooney | there are a tone of places we saw that could also use the info from the infor case in pre livem migration too right | 17:46 |
artom | sean-k-mooney, I think they'd have to get double checked one by one... | 17:50 |
artom | That being said, maybe it wouldn't hurt to do them all in the same patch | 17:50 |
artom | Or least, more than 1 | 17:50 |
sean-k-mooney | i would do them in a followup | 17:50 |
sean-k-mooney | so just replace teh once case in post live migrate in that one | 17:51 |
sean-k-mooney | and then see if you could replace the other use in pre livemigate in a different patch | 17:51 |
*** sapd1 has quit IRC | 17:59 | |
openstackgerrit | sean mooney proposed openstack/nova master: [WIP] Set migrate_data.vifs only when using multiple port bindings https://review.opendev.org/742180 | 18:02 |
openstackgerrit | sean mooney proposed openstack/nova master: add functional regression test for bug #188395 https://review.opendev.org/747454 | 18:02 |
openstack | bug 188395 in pyTD "Strange Behavior of the game.creeps list" [Undecided,Fix released] https://launchpad.net/bugs/188395 | 18:02 |
sean-k-mooney | i still need to add unit tests and update the commit message but thats the repodcuer and fix | 18:02 |
sean-k-mooney | as a followup im also thinking of replacing all uses of | 18:04 |
sean-k-mooney | if 'vifs' in migrate_data and migrate_data.vifs: | 18:04 |
sean-k-mooney | with "if migrate_data.using_multiple_port_bindings():" | 18:04 |
artom | Would definitely be more readable, aye | 18:04 |
sean-k-mooney | i can do it as a property so its technically not an ovo change too | 18:05 |
sean-k-mooney | if we wanted to backport that | 18:05 |
sean-k-mooney | but it will be a spereate patch anyway | 18:05 |
sean-k-mooney | well it is an ovo change but not one that is visable when you serialise so its fine | 18:06 |
sean-k-mooney | apparently its only there 3 times | 18:11 |
sean-k-mooney | i tought it was more | 18:11 |
sean-k-mooney | guess not | 18:11 |
sean-k-mooney | anyway im going to call it a day o/ | 18:11 |
*** hongbin has quit IRC | 18:17 | |
*** mvorwerk has joined #openstack-nova | 18:23 | |
*** vishalmanchanda has quit IRC | 18:27 | |
*** martinkennelly has quit IRC | 18:38 | |
*** bnemec has quit IRC | 18:53 | |
*** bnemec has joined #openstack-nova | 19:01 | |
*** bnemec has quit IRC | 19:08 | |
*** mvorwerk has quit IRC | 19:09 | |
*** hongbin has joined #openstack-nova | 19:10 | |
*** mvorwerk_ has joined #openstack-nova | 19:11 | |
*** mvorwerk_ has quit IRC | 19:16 | |
*** nweinber_ has joined #openstack-nova | 19:28 | |
*** yoctozepto1 has joined #openstack-nova | 19:30 | |
*** raildo_ has joined #openstack-nova | 19:30 | |
*** raildo has quit IRC | 19:31 | |
*** arne_wiebalck_ has joined #openstack-nova | 19:31 | |
*** nweinber has quit IRC | 19:32 | |
*** arne_wiebalck has quit IRC | 19:32 | |
*** yoctozepto has quit IRC | 19:32 | |
*** arne_wiebalck_ is now known as arne_wiebalck | 19:32 | |
*** yoctozepto1 is now known as yoctozepto | 19:32 | |
*** gyee has quit IRC | 19:32 | |
*** gyee has joined #openstack-nova | 19:36 | |
*** csatari_ has joined #openstack-nova | 19:37 | |
*** jhesketh_ has joined #openstack-nova | 19:38 | |
*** slaweq has quit IRC | 19:42 | |
*** csatari has quit IRC | 19:42 | |
*** jhesketh has quit IRC | 19:42 | |
*** csatari_ is now known as csatari | 19:42 | |
*** mlavalle has quit IRC | 19:42 | |
*** mlavalle has joined #openstack-nova | 19:48 | |
*** slaweq has joined #openstack-nova | 19:53 | |
*** slaweq has quit IRC | 19:57 | |
*** slaweq has joined #openstack-nova | 20:03 | |
*** slaweq has quit IRC | 20:07 | |
*** artom has quit IRC | 20:21 | |
*** nweinber_ has quit IRC | 20:30 | |
*** tosky has joined #openstack-nova | 20:30 | |
*** artom has joined #openstack-nova | 21:13 | |
*** owalsh has quit IRC | 21:25 | |
*** bbowen__ has quit IRC | 21:29 | |
*** bbowen has joined #openstack-nova | 21:34 | |
*** KeithMnemonic has quit IRC | 21:40 | |
openstackgerrit | Merged openstack/nova master: Add new default roles in FIP policies https://review.opendev.org/742030 | 21:46 |
*** dave-mccowan has quit IRC | 22:03 | |
*** k_mouza has quit IRC | 22:11 | |
*** ociuhandu has joined #openstack-nova | 22:16 | |
*** ociuhandu has quit IRC | 22:21 | |
*** jamesdenton has joined #openstack-nova | 22:31 | |
*** _erlon_ has quit IRC | 22:46 | |
*** mriedem has quit IRC | 22:47 | |
*** mlavalle has quit IRC | 23:02 | |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: post live migration: don't call Neutron needlessly https://review.opendev.org/747451 | 23:16 |
*** tosky has quit IRC | 23:48 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!