Tuesday, 2020-08-25

*** artom has quit IRC00:26
*** tkajinam_ is now known as tkajinam01:04
*** rcernin has quit IRC01:14
*** rcernin has joined #openstack-nova01:15
*** elod has quit IRC01:21
*** elod has joined #openstack-nova01:23
*** gyee has quit IRC01:48
*** johnthetubaguy has quit IRC02:26
*** johnthetubaguy has joined #openstack-nova02:28
*** sapd1_x has joined #openstack-nova02:34
*** mkrai has joined #openstack-nova03:02
*** dave-mccowan has quit IRC03:16
*** ratailor has joined #openstack-nova03:39
*** sapd1_x has quit IRC04:29
*** rcernin has quit IRC04:32
*** evrardjp has quit IRC04:33
*** evrardjp has joined #openstack-nova04:35
*** hongbin has quit IRC04:39
*** rcernin has joined #openstack-nova05:03
*** ratailor has quit IRC05:09
*** elod has quit IRC05:39
*** rcernin has quit IRC05:41
*** vishalmanchanda has joined #openstack-nova05:50
*** elod has joined #openstack-nova05:53
*** jsuchome has joined #openstack-nova06:01
*** mvorwerk has joined #openstack-nova06:24
*** links has joined #openstack-nova06:26
*** ralonsoh has joined #openstack-nova06:28
*** ratailor has joined #openstack-nova06:31
*** slaweq has joined #openstack-nova06:36
bauzasgood morning Nova06:38
* bauzas puts the head out of his cave after 3 weeks06:38
*** xek has joined #openstack-nova06:44
*** swp20 has quit IRC06:49
*** mkrai has quit IRC06:52
gibibauzas: welcome back!06:52
*** mkrai_ has joined #openstack-nova06:52
bauzasgibi: I was around yesterday but I had email scrubbing + a number of paperwork to do06:53
*** rcernin has joined #openstack-nova06:57
*** tesseract has joined #openstack-nova07:02
gibiI mostly did paperwork yestarday too.07:02
*** xek has quit IRC07:02
*** rcernin has quit IRC07:03
*** rcernin has joined #openstack-nova07:05
*** devfaz has left #openstack-nova07:10
bauzasgibi: fwiw, I'm very well aware of victoria-3 milestone in two weeks07:13
gibisame here07:13
gibiit is painful07:14
bauzasgibi: I'll rush this week on the routed-networks stuff07:14
bauzasgibi: but you can surely ping me on any review ask07:14
*** rcernin has quit IRC07:14
gibithanks. I will go through the patches in the runway slots today07:14
bauzaswell, I'm used to face the milestone right after my long vacations07:15
bauzas:)07:15
bauzasgibi: good idea, I'll jump onto reviewing those patches07:15
*** iurygregory has joined #openstack-nova07:21
*** dtantsur|afk is now known as dtantsur07:26
*** tosky has joined #openstack-nova07:36
*** dklyle has quit IRC07:36
*** damien_r has joined #openstack-nova07:36
*** damien_r has quit IRC07:40
*** xek has joined #openstack-nova07:43
brinzhang_gibi, bauzas: optimiza create and bind arqs logical patch, need to review https://review.opendev.org/#/c/726564/607:45
gibibrinzhang_: hi! on my list for today07:46
brinzhang_gibi, bauzas: the cyborg evacuate support patch rebased on this patch, and it merge conflict, we will resolve the merge conflict07:46
brinzhang_gibi: cool, thanks07:46
*** xek has quit IRC08:04
openstackgerritBrin Zhang proposed openstack/nova master: Optimize _create_and_bind_arqs logic in conductor  https://review.opendev.org/72656408:06
openstackgerritBrin Zhang proposed openstack/nova master: Cyborg evacuate support  https://review.opendev.org/71532608:06
*** sridharg has joined #openstack-nova08:08
*** sapd1_x has joined #openstack-nova08:14
*** martinkennelly has joined #openstack-nova08:23
*** brinzhang0 has joined #openstack-nova08:32
*** brinzhang_ has quit IRC08:35
*** derekh has joined #openstack-nova08:41
*** spatel has joined #openstack-nova08:43
*** spatel has quit IRC08:48
*** xinranwang__ has joined #openstack-nova08:54
*** k_mouza has joined #openstack-nova08:57
*** dosaboy has quit IRC08:59
*** dosaboy has joined #openstack-nova08:59
*** swp20 has joined #openstack-nova09:01
swp20gibi: Hi, gibi. https://review.opendev.org/#/c/719163/16/nova/scheduler/client/report.py@L2168. can u give some idea to process these exceptions?09:03
xinranwang__gibi: sean-k-mooney:  Hi all, as we discussed during virtual PTG, I have proposed an overall spec https://review.opendev.org/#/c/742785/ to discuss sriov nic support in nova, neutron, and cyborg.  Hope you guys can review it and give comments on it,  there still some open questions need to be nailed down which really need you guys' comments and opinion.  Let's take this spec as a place to discuss it. Please09:04
xinranwang__review it when you guys got time. Thanks a lot!09:04
gibiswp20: I will check that comment from efried and try to recover the context09:07
swp20Thanks gibi.09:07
gibixinranwang__: you need to re-propose that spec to wallaby as we are past victory spec freeze. I cannot promise I will have time in the coming weeks to dig deep into this as the victoria feature freeze is coming fast. But please add this as a topic for the PTG so we won't forget about it09:10
gibixinranwang__: https://etherpad.opendev.org/p/nova-wallaby-ptg09:10
*** sapd1_x has quit IRC09:13
*** Yumeng has joined #openstack-nova09:16
xinranwang__gibi:  Understood, sure. I will re-propose it.09:17
*** mkrai_ has quit IRC09:18
*** mkrai__ has joined #openstack-nova09:18
xinranwang__gibi:  I'd like to point it out here because it is better that we can do some reviews before next ptg.  No rush, maybe after the feature freeze in V.09:20
gibixinranwang__: sure, I will try to prepare myself for the PTG by reading up on the possible PTG topics09:21
xinranwang__gibi:  great, thanks09:23
*** belmoreira has joined #openstack-nova09:25
*** k_mouza has quit IRC09:36
Yumenghi gibi and sean-k-mooney: just one more question for the smartnic spec, would you like xinranwang__ and I to split the discussions before next PTG and start discuss(we introduce one or two of the open issues first, and then once you guys have any questions, we can answer and discuss.)  the open issues directly one by one at your convenience? so09:41
Yumengthat we don't need to think and decide all of them at a very short time in PTG.09:41
openstackgerritStephen Finucane proposed openstack/nova master: functional: Enable real policy fixture by default  https://review.opendev.org/74590609:43
openstackgerritStephen Finucane proposed openstack/nova master: functional: Add and use 'GlanceFixture'  https://review.opendev.org/74590709:43
openstackgerritStephen Finucane proposed openstack/nova master: tests: Remove '_FakeImageService'  https://review.opendev.org/74590809:43
*** k_mouza has joined #openstack-nova09:45
stephenfingmann: Addressed your comments on that "use real policy" patch ^ Let me know if I missed anything :)09:45
*** itandops has joined #openstack-nova09:47
itandopsHi folks, I have some issue to restart nova API after rebooting the controller http://paste.openstack.org/show/797116/09:58
itandopsThere is a database with empty values nova_cell009:58
itandopsIt seems to be the root cause of this issue. Any suggestion to solve this ?09:59
lyarwooditandops: `Lost connection to MySQL server during query` it isn't that the db is empty10:03
itandopslyarwood: I used 2 controllers running nova API.10:06
lyarwooditandops: okay well there's a clear db connectivity issue there for you to debug now :)10:07
*** flaviof has quit IRC10:14
*** NobodyCam has quit IRC10:14
*** flaviof has joined #openstack-nova10:15
sean-k-mooneygibi are you going to try and resolve the sriov attach/detach feature before m310:15
*** johnsom has quit IRC10:16
*** NobodyCam has joined #openstack-nova10:16
sean-k-mooneygibi: im still trying to find time to work on numa in placement but im fully expecting that to slip to next cycle. but im going to try and at least have a poc of it before repoposing the spec next cycle10:16
*** johnsom has joined #openstack-nova10:17
gibisean-k-mooney: I will try to push that feature later this week but I think at some point I have to accept that it will slip10:19
gibiYumeng: if there is a clear list of open issues in the spec then that is enough10:19
sean-k-mooneyok, do you know what the status of provider.yaml is? https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/provider-config-file10:20
gibisean-k-mooney: I will go back to provider.yaml today, just finished reviewing the cyborg evac support. (going through the runway items)10:22
gibiso I can tell more in couple of hours10:22
sean-k-mooneyok it looks like the first patch merged and the second has a +2 from alex the 3rd or 4th patch makes the feature functional10:23
sean-k-mooneyso that look like its making progress ill try to review the runway items but maybe not today.10:24
jsuchomeok gibi, lyarwood, https://review.opendev.org/#/c/574301/ is green again, chance for new reviews?10:25
gibijsuchome: ohh, I was +2 on that before, so I hope I can make a quick rereview of that now10:25
*** k_mouza has quit IRC10:26
*** ratailor_ has joined #openstack-nova10:26
lyarwoodjsuchome: ack looking10:27
lyarwoodgibi: I went ahead and moved a few things around with that, there's another change underneath from me now moving rbd_utils out of nova.virt.libvirt for example10:27
lyarwoodgibi: and this change also introduces some generic configurables now10:27
gibilyarwood: yeah, I just opened your change below10:27
*** k_mouza has joined #openstack-nova10:28
lyarwoodjsuchome: https://review.opendev.org/#/c/728095/ can you update the releasenote to include the new configurables please10:28
*** ratailor has quit IRC10:28
lyarwoodbauzas: https://review.opendev.org/#/q/I32908b77c18f8ec08211dd67be49bbf903611c34 - would you mind hitting these today?10:31
bauzaslyarwood: I can take a look10:31
lyarwoodthanks10:32
lyarwoodhttps://review.opendev.org/#/q/I7eb86edc130d186a66c04b229d46347ec5c0b625 is the other change that's part of this bugfix10:33
openstackgerritLuyao Zhong proposed openstack/nova master: Track error migrations in resource tracker  https://review.opendev.org/74528110:49
openstackgerritLuyao Zhong proposed openstack/nova master: Improve orphans tracking in resource tracker  https://review.opendev.org/74528210:49
openstackgerritLuyao Zhong proposed openstack/nova master: Rollback when reset running live migration  https://review.opendev.org/74789910:49
*** pas-ha has quit IRC10:49
*** knikolla has quit IRC10:49
*** csatari has quit IRC10:49
*** rcernin has joined #openstack-nova10:57
*** jangutter has joined #openstack-nova10:59
openstackgerritLuyao Zhong proposed openstack/nova master: Rollback when reset running live migration  https://review.opendev.org/74789911:00
*** csatari has joined #openstack-nova11:01
*** pas-ha has joined #openstack-nova11:01
*** knikolla has joined #openstack-nova11:01
luyaostephenfin, alex_xu: Thank you for your comments.  if you get time, vpmem enhancement is ready for new round review. https://review.opendev.org/#/c/714653/11:03
*** jangutter_ has quit IRC11:03
openstackgerritJiri Suchomel proposed openstack/nova master: Bring back allowed_direct_url_schemes in support of RBD image download  https://review.opendev.org/72809511:09
*** jangutter has quit IRC11:14
*** jangutter has joined #openstack-nova11:15
sean-k-mooneyit would be really nice if you could resize a shelved instance11:21
* sean-k-mooney is resizing vms on my home cloud11:21
gibisean-k-mooney: you can automat that on the client side :) unshelve; resize; shelve11:23
sean-k-mooneyim going to file a bug for numa blancing later today and work on a patch to resolve it later in the week11:23
sean-k-mooneygibi: thats what im doing with horizon manually11:23
sean-k-mooneywhile i finished reading my email11:23
sean-k-mooneywhich is now alos done11:23
*** mkrai__ has quit IRC11:24
*** links has quit IRC11:24
sean-k-mooneygibi: it just feels like something that would be easy to do in the shevled offloaded state as its just a db update11:24
sean-k-mooneyresize while shelve offloaded that is11:24
gibihm, that makes more sense yes11:25
sean-k-mooneybut thats an api change and needs a spec so not this cycle11:25
*** nightmare_unreal has joined #openstack-nova11:25
*** links has joined #openstack-nova11:26
*** mkrai has joined #openstack-nova11:28
*** trident has quit IRC11:31
*** rs_goyal__ has joined #openstack-nova11:33
*** brinzhang_ has joined #openstack-nova11:41
gibiswp20: left some comments in https://review.opendev.org/#/c/719163/18/nova/scheduler/client/report.py@217011:41
openstackgerritBalazs Gibizer proposed openstack/nova master: Undeprecate the vmwareapi driver  https://review.opendev.org/74240711:42
*** brinzhang0 has quit IRC11:44
sean-k-mooneygibi: i know vmware jobs are now working again but do they trigger automatically or is it only when the recheck comment is left11:45
gibisean-k-mooney: it is triggered automatically11:46
gibiI just pushed a new ps and it will vote on it11:46
sean-k-mooneyok cool11:46
sean-k-mooneyinitally it looked like it was manual but i guess they made it automatic over the cycle11:46
sean-k-mooneyif its still it seams to be relitivly stable so if they continue to maintain it then un deprecating it makes sense.11:47
gibilooking at the recent history it of the job I think it is fairly stable. I also see some patches targeting the vmware driver so there is real maintenance on the code now11:48
gibie.g. https://review.opendev.org/#/c/742398/11:48
sean-k-mooneyya11:49
sean-k-mooneyreading the commit message for your change it makes sense to me11:49
openstackgerritsean mooney proposed openstack/nova master: libvirt: delegate ovs plug to os-vif  https://review.opendev.org/60243211:59
*** hoonetorg has quit IRC12:08
*** xek has joined #openstack-nova12:10
*** raildo has joined #openstack-nova12:13
*** dave-mccowan has joined #openstack-nova12:17
lyarwoodstephenfin: https://review.opendev.org/#/q/topic:bp/nova-image-download-via-rbd any chance you could add this to your queue, I'll get to the vTPM stuff tomorrow if that's okay12:19
*** hoonetorg has joined #openstack-nova12:21
gibistephenfin, sean-k-mooney: could you confirm that the "any number" here is a doc bug? https://github.com/openstack/nova/blame/master/doc/source/user/flavors.rst#L549-L551 I belive if hw:numa_nodes is not specified then it is defaulted to 112:28
jsuchomegibi, lyarwood so who could we ask for another +2?12:36
gibijsuchome: I think lyarwood just asked stephenfin above12:36
lyarwoodyup I did12:38
sean-k-mooneygibi: it depends on the context but ill check now12:39
sean-k-mooneygibi: the docs are correct12:40
*** hoonetorg has quit IRC12:41
gibisean-k-mooney: they why I remember that nova does not automatically split resources between host NUMA nodes?12:41
gibifor a single instance12:41
sean-k-mooneygibi: it does not but it does not crete a numa toplogy by default either12:41
sean-k-mooneyhw:numa_cpus and hw:numa_mem are only used if hw:numa_nodes>=212:42
gibiOK, so if nothing numa related are requested then we split resource between host numa nodes12:42
sean-k-mooneyand by default vms without a numa toplogy float over all host numa nodes12:42
sean-k-mooneygibi: no we dont split them12:42
gibibut if we request huge pages then a numa topology is created12:42
*** artom has joined #openstack-nova12:43
sean-k-mooneywe simply do not limit them to a specific numa node12:43
gibiand then numa_nodes defaults to 1 if not specified12:43
sean-k-mooneythe kernel will split and move tehm as it sees fit12:43
sean-k-mooneyyes12:43
sean-k-mooneyif you request hugepage or cpu pinning or pmem we default to 1 numa node12:43
gibiOK, cool12:43
gibithen it is not a doc bug12:43
gibiit is just a complication12:44
gibithanks12:44
sean-k-mooneyno worries12:44
sean-k-mooneythe other complication is while we support numa affinity policies with pci device/sriov ports we dont create a numa toplogy when you use them by default12:44
sean-k-mooneywe just enforce those policies if you also request numa for an instance12:44
gibiI see12:45
*** mkrai has quit IRC12:45
*** chenhaw has quit IRC12:45
sean-k-mooneythe descrioption of FLAVOR-NODES is not really correct12:46
sean-k-mooneyfor a different reason12:46
sean-k-mooneyno  of these values are related to host toplogy12:46
sean-k-mooneyhw:numa_nodes is the number of virtual numa_nodes that we present to the guest12:47
sean-k-mooneythe relationship with the host numa nodes is a libvirt driver implemeatnion detail and is not guarenteed by the api currenly12:47
*** Guest34946 has joined #openstack-nova12:47
sean-k-mooneyalthogh it is the behavior the numa toplogy filter will give you12:47
gibiit talks about where the cpus are run on and in that sense it is correc that they can run on any host numa nodes12:47
sean-k-mooneyyes12:48
sean-k-mooneybut we technically would be allowed to change the meaning of hw:numa_nodes in libvirto to mean spread to at most N host numa nodes instead of exactly N numa nodes with out violating that api guarentees today. although the proposed placment work will actully guarentee a 1:1 mapping12:49
*** Guest34946 is now known as redrobot12:50
gibiahha12:51
sean-k-mooneywell actully it does not have too but we likely will to keep the same behavior12:51
sean-k-mooneythe one thing we are not allowed to do by the current api semantics is take a vm that reqest 1 numa node and spread it across several host numa nodes12:52
sean-k-mooneyi.e. we cant split virutal numa nodes across host numa nodes without regressing performance12:53
gibiyes, that would be a serious bug12:53
sean-k-mooneythe other way around is ok but if we allow it in the futrue we would likely want to contol it via policy12:54
*** hoonetorg has joined #openstack-nova12:54
sean-k-mooneye.g. hw:numa_packing=true or something like that and default to false12:54
sean-k-mooneyanyway we dont need to worry about that right now anyway12:55
*** Luzi has joined #openstack-nova12:55
gibithanks for the explanation12:55
sean-k-mooneythe more this tribal knowadge spreads the less of a bus factor there is12:56
*** lpetrut has joined #openstack-nova12:57
*** bnemec has joined #openstack-nova13:00
gmannstephenfin: thanks, will check.13:01
gmannstephenfin: gibi this is last patch for deprecated api policy-work - https://review.opendev.org/#/c/747784/13:01
*** vdrok has quit IRC13:02
*** trident has joined #openstack-nova13:02
*** vdrok has joined #openstack-nova13:02
gibigmann: thanks13:02
gibi+213:02
*** masayukig has quit IRC13:05
stephenfingmann: Some grammar nits on the reno13:07
gmannstephenfin: thanks, will fix13:08
openstackgerritGhanshyam Mann proposed openstack/nova master: Add reno for deprecated APIs policy changes  https://review.opendev.org/74778413:09
gmannstephenfin: ^^13:09
stephenfinta13:09
gibiapproved13:10
rs_goyal__Hi guys, I am attaching second network interface to a compute instance based on Ubuntu OS. The issue I am facing is the name of second interface that gets created on instance when I try different ways to attach the network. First way is to attach the second interface while instance creation in which case the interface name comes as 'ens4'. Second way is attaching the interface after vm is created, where the13:10
rs_goyal__interface name is 'ens6'. This is only happening in case of ubuntu as it follows the 'ens*' naming of interfaces. Is there a way so that only one interface name comes in both cases so that it will be easy to create network configuration?13:10
*** masayukig has joined #openstack-nova13:16
gibirs_goyal__: I think what you are looking for is interface tagging https://notartom.net/2016/09/28/device-tagging-new-in-newton/13:18
*** ratailor_ has quit IRC13:18
*** KeithMnemonic has joined #openstack-nova13:22
*** jangutter_ has joined #openstack-nova13:27
*** jangutter has quit IRC13:30
*** jraju__ has joined #openstack-nova13:32
artomgibi, rs_goyal__, and the follow-up: https://notartom.net/2017/06/20/virtual-device-role-tagging-better-explained/13:32
artom(How long have I been saying that I should include this in an official guide?)13:32
*** links has quit IRC13:32
gibithere is even a sequel?! \o/13:34
rs_goyal__@artom @gibi13:38
rs_goyal__Is this only supported via nova cli or can be done via openstack cli also?13:38
gibirs_goyal__: looking at the help text it is not supported by the openstack cli13:42
artomrs_goyal__, I know *I* didn't add it to osc :)13:43
rs_goyal__okay Thanks.13:45
*** nweinber has joined #openstack-nova13:48
openstackgerritAlexandre Arents proposed openstack/nova master: Add a lock to prevent race during detach_interface  https://review.opendev.org/74795714:01
*** gyee has joined #openstack-nova14:03
openstackgerritsean mooney proposed openstack/nova master: Set migrate_data.vifs only when using multiple port bindings  https://review.opendev.org/74218014:09
rs_goyal__https://www.irccloud.com/pastebin/BUiY7qIX/14:14
sean-k-mooneylyarwood: this might be of interest to you https://review.opendev.org/#/c/747957/14:14
gmannstephenfin: gibi any of you can review this - https://review.opendev.org/#/c/738126/1714:15
rs_goyal__@gibi14:15
sean-k-mooneyyou were fixing issue we had with persitent xml and transient getting out of sync but maybe the locking will also help14:15
sean-k-mooneyaarents: there is potentially a seperate cause to that bug14:16
sean-k-mooneyhttps://bugs.launchpad.net/nova/+bug/189287014:16
openstackLaunchpad bug 1892870 in OpenStack Compute (nova) "concurrent interface detach/attach may accidently unbind port" [Undecided,In progress] - Assigned to Alexandre arents (aarents)14:16
sean-k-mooneyaarents: Detaching interface %(mac)s failed because the device is no longer found14:17
sean-k-mooney     on the guest.14:17
sean-k-mooneythis can happen for other reasons then a race at lest that seamed to be the case for volumes14:18
sean-k-mooneyaarents: that siad i dont nessacarly thing adding a lock is a bad thing although your commit mentions14:19
sean-k-mooney multiple detach/attach are run14:19
sean-k-mooneyconcurrently14:19
sean-k-mooneybut you are only locking detach14:19
sean-k-mooneyyou might want to use a shared lock between attach and detach14:19
sean-k-mooneyand add a lock to attach too14:19
*** dklyle has joined #openstack-nova14:19
lyarwoodsean-k-mooney: yeah I think we already lock for disks14:20
* lyarwood checks14:20
aarentssean-k-mooney: Yes because the race exists only because of detach that sends multiple UNBIND14:20
aarentsif it is fixed on detach attach should be consistent I think14:20
sean-k-mooneywhat happens if we do multiple attach api calls concurrently14:20
sean-k-mooneyaarents: since the syconisation woudl be on the interface uuid i think it would be fairly cheap to just lock both operation14:21
aarentssean-k-mooney: hum why not14:23
sean-k-mooneylyarwood: and yes we already lock in detach_volume using the volume_uuid14:23
aarentslock only on interface uuid not instance_uuid-interface_uuid but on bot attach and detach ?14:24
sean-k-mooneyso volumes lock on both attach and detach14:24
sean-k-mooneyi would change teh lock name from 'detach_interface-%s-%s' to 'interface-%s-%s'14:25
sean-k-mooneyyou can pass the instance uuid and port but honestly the neutron port uuid will be unique so the instance uuid is not actully needed14:26
aarentssean-k-mooney and put it on both detach and attach ?14:26
sean-k-mooneyyep14:27
aarentsmake sense14:27
sean-k-mooneyto keep it consitent with volumes14:27
aarentsyep14:27
sean-k-mooneyvolumes actully does  @utils.synchronized(instance.uuid)14:27
sean-k-mooneybut i prefer using the port uuid14:27
sean-k-mooneyunless we want to block detaching differnet ports in parallel14:28
sean-k-mooneyi guess that is why the instance uuid is used for volumes to prevent detaching multiple volumes in paralel14:28
sean-k-mooneybut im not sure that is actully required14:28
aarentssean-k-mooney: yeah but I want to keep it // I make some test14:29
sean-k-mooneyya using a uniqe lock name for this is fine14:30
sean-k-mooneyif at some point we really need to make it instance wide we can just drop the port uuid14:30
openstackgerritStephen Finucane proposed openstack/nova master: functional: Provide default 'host_info' for '_get_connection'  https://review.opendev.org/74694214:30
openstackgerritStephen Finucane proposed openstack/nova master: functional: Add 'start_compute' helper  https://review.opendev.org/74694314:30
openstackgerritStephen Finucane proposed openstack/nova master: functional: Use tempdir for CONF.instances_path  https://review.opendev.org/74694414:30
openstackgerritStephen Finucane proposed openstack/nova master: functional: Clean up PCI tests  https://review.opendev.org/74694514:30
openstackgerritStephen Finucane proposed openstack/nova master: functional: Add resize tests for PCI servers  https://review.opendev.org/74694614:30
openstackgerritStephen Finucane proposed openstack/nova master: conductor: Don't use setattr  https://review.opendev.org/74694714:30
openstackgerritStephen Finucane proposed openstack/nova master: functional: Add test for SR-IOV neutron ports  https://review.opendev.org/74694814:30
openstackgerritStephen Finucane proposed openstack/nova master: fixtures: Handle binding of first port  https://review.opendev.org/74694914:30
openstackgerritStephen Finucane proposed openstack/nova master: functional: Add live migration tests for PCI, SR-IOV servers  https://review.opendev.org/74695014:30
aarentssean-k-mooney, I made some test reauest 7 detach on same instance taking 4s to detach with a lock per instance-port and > 10sec when only instance14:31
sean-k-mooneyyep as long as libvirt safely handels the parrale detach request we dont need to lock at the instance levle14:32
gibisean-k-mooney, aarents: good catch about the parallel detach, I queued up the fix in my review list14:32
aarentsSo I prefer 'interface-%s-%s' on both14:32
sean-k-mooneygibi: aarents found it :)14:32
aarentsgibi: thanks14:33
gibithen aarents gets the prize :)14:33
*** bauzas has quit IRC14:33
aarentsThat one of my two downstream summer bugs :P other one will come soon..14:42
gibiI had summer vacation, you had summer bugs. I'm feeling lucky :D14:43
aarents:D14:44
*** rcernin has quit IRC14:45
*** bauzas has joined #openstack-nova14:47
*** mkrai has joined #openstack-nova14:49
*** chenhaw has joined #openstack-nova14:51
*** bauzas has quit IRC14:52
rs_goyal__@gibi   @artom :  I tried tagging the network, but the interface is getting created like I explained above. I used `nova interface-attach --net-id <network> --tag priv <instance>`for attaching a newtork interface on an existing vm.14:52
artomrs_goyal__, the actual interface names (eth0, ens1, etc) aren't affected14:53
artomrs_goyal__, you need to look in the metadata14:53
*** bauzas has joined #openstack-nova14:54
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration  https://review.opendev.org/74796915:00
rs_goyal__@artom : okay. thanks.15:01
gibilyarwood: +215:03
openstackgerritLee Yarwood proposed openstack/nova stable/ussuri: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration  https://review.opendev.org/74797215:03
lyarwoodgibi: thanks15:03
lyarwoodstephenfin: ^ master change is up btw15:03
gibilyarwood: I thank you to taking care of this15:03
openstackgerritLee Yarwood proposed openstack/nova stable/train: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration  https://review.opendev.org/74797315:04
openstackgerritLee Yarwood proposed openstack/nova stable/stein: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration  https://review.opendev.org/74797415:04
lyarwoodgibi: np :)15:04
openstackgerritLee Yarwood proposed openstack/nova stable/rocky: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration  https://review.opendev.org/74797515:06
*** mlavalle has joined #openstack-nova15:06
stephenfinlyarwood: done \o/15:07
openstackgerritLee Yarwood proposed openstack/nova stable/queens: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration  https://review.opendev.org/74797615:07
openstackgerritStephen Finucane proposed openstack/nova master: Add generic reproducer for bug #1879878  https://review.opendev.org/74774415:08
openstackbug 1879878 in OpenStack Compute (nova) "VM become Error after confirming resize with Error info CPUUnpinningInvalid on source node " [Medium,In progress] https://launchpad.net/bugs/1879878 - Assigned to Stephen Finucane (stephenfinucane)15:08
openstackgerritStephen Finucane proposed openstack/nova master: Don't unset Instance.old_flavor, new_flavor until necessary  https://review.opendev.org/74495815:08
openstackgerritStephen Finucane proposed openstack/nova master: Move confirm resize under semaphore  https://review.opendev.org/74774515:08
openstackgerritStephen Finucane proposed openstack/nova master: Move revert resize under semaphore  https://review.opendev.org/74774615:08
openstackgerritStephen Finucane proposed openstack/nova master: Cleanup 'drop_move_claim' and '_drop_move_claim'  https://review.opendev.org/74774715:08
openstackgerritStephen Finucane proposed openstack/nova master: manager: Address TODO  https://review.opendev.org/74774815:08
openstackgerritStephen Finucane proposed openstack/nova master: manager: Move context manager up one level  https://review.opendev.org/74567415:08
openstackgerritStephen Finucane proposed openstack/nova master: compute: Add type hints for resize functions  https://review.opendev.org/74534115:08
openstackgerritStephen Finucane proposed openstack/nova master: WIP: compute: Add more type hints for resize functions  https://review.opendev.org/74567515:08
*** itandops has quit IRC15:09
stephenfinartom: that failure in https://review.opendev.org/747744 is weird. Looks like the mock was being applied globally or something :-\15:09
stephenfinso I just removed the mock15:09
artomstephenfin, yeah, I can't reproduce it locally when running just that one single test15:09
*** boxiang_ has quit IRC15:09
artomBut maybe it's somehow related15:09
*** boxiang_ has joined #openstack-nova15:10
openstackgerritLee Yarwood proposed openstack/nova stable/pike: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration  https://review.opendev.org/74797815:10
*** xek has quit IRC15:14
openstackgerritStephen Finucane proposed openstack/nova master: functional: Enable real policy fixture by default  https://review.opendev.org/74590615:21
openstackgerritStephen Finucane proposed openstack/nova master: functional: Add and use 'GlanceFixture'  https://review.opendev.org/74590715:21
openstackgerritStephen Finucane proposed openstack/nova master: tests: Remove '_FakeImageService'  https://review.opendev.org/74590815:21
fricklerartom: rs_goyal__: there's some work in progress on adding tag support to OSC, help appreciated. https://review.opendev.org/#/q/topic:story/2002195+(status:open+OR+status:merged)15:25
*** mvorwerk has quit IRC15:26
*** mvorwerk has joined #openstack-nova15:26
fricklerbut I also admit that I didn't know about this feature up to now, which might help with some of my usecases, too, guess I need to take a deeper look anyhow. guess nobody did build cloud-init support for it, either15:28
*** Yumeng has quit IRC15:28
*** belmoreira has quit IRC15:29
*** brinzhang0 has joined #openstack-nova15:31
*** lpetrut has quit IRC15:32
*** brinzhang_ has quit IRC15:33
*** brinzhang has joined #openstack-nova15:34
*** mvorwerk has quit IRC15:34
artomfrickler, so I keep hearing that osc is moving to using the sdk... is that even true?15:36
*** owalsh has quit IRC15:36
*** brinzhang0 has quit IRC15:36
artomBecause I started an effort to bring sdk up to speed (from the nova pov at any rate), the logic being that's the more "future-proof" place to invest work15:36
artomBut then I keep seeing stuff being added to osc directly...15:37
artomIs there even a grand plan, or is this all ad-hoc patches?15:37
openstackgerritMerged openstack/nova master: Provider Config File: Function to further validate and retrieve configs  https://review.opendev.org/67602915:39
stephenfinlyarwood: reviewed the nova-image-download-via-rbd bp15:43
stephenfinartom: not frickler, wdym by "stuff [being added] to osc directly"15:44
artomstephenfin, I mean patches like https://review.opendev.org/#/q/topic:story/2002195+(status:open+OR+status:merged)15:44
stephenfindoesn't osc just call e.g. novaclient or sdk, with just a few shims for cases like novaclient dropping an API15:44
* stephenfin looks15:44
sean-k-mooneyit can call both as far as i know15:45
*** owalsh has joined #openstack-nova15:45
sean-k-mooneyso you would jsut have to migrate indiviaual calls form one ot the other15:45
artomstephenfin, ah, I see what you mean15:45
artomstephenfin, there's no request logic in osc itself, it just call novaclient15:45
*** owalsh has quit IRC15:45
artomI guess in that case I mean - not adding stuff to the sdk first15:46
artomIf it's supposed to be moving to the sdk, then why are new patches are being added that call novaclient?15:46
sean-k-mooneyartom: it just does parsing and passes the args on15:47
fricklerartom: mordred should be the right person to talk to about this, now that dtroyer seem to have moved on. sadly he also seems to be gone missing somehow15:47
sean-k-mooneythere is little  logic in osc beyond that in general15:47
sean-k-mooneythre are some microversion checks and other check to ensure its valid15:47
sean-k-mooneybut thats more validation of input then complex logic15:48
stephenfinartom: Is it possible to talk to SDK for nova commands? 'self.app.client_manager.compute' will point to the novaclient client at the moment15:48
stephenfinat least, last I checked15:49
artomstephenfin, would have to look it up15:49
sean-k-mooneystephenfin: you can just import the sdk modules15:49
sean-k-mooneyand call that15:49
stephenfinyou've have to init the sdk too, I'd imagine15:49
sean-k-mooneyproably unless there is a global instance you can use15:49
lyarwoodstephenfin: thanks, jsuchome I'll clean things up again unless you want to work through stephenfin's comments?15:50
sean-k-mooneybut its like how we use both sdk and keystone authclient and project client in nova15:50
sean-k-mooneyyou can mix and match15:50
jsuchomelyarwood: I'm changing those hard requests (doc + file handle), I would rather not go down the rabbit hole of new refactoring though15:51
artomstephenfin, frickler, I'm asking selfishly in the context of https://review.opendev.org/#/q/status:open+project:openstack/openstacksdk+branch:master+topic:story/200792915:52
artomI'm not going to continue that if nothing of "substance" (sorry openstack-ansible) will ever use the sdk15:52
artomThere are plenty of broken things in Nova that I can fix with that time ;)15:53
lyarwoodjsuchome: yup np, I can fix up my change once you're done15:53
lyarwoodjsuchome: and we can push the other stuff to follow ups hopefully15:53
openstackgerritJiri Suchomel proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD  https://review.opendev.org/57430115:53
artomI just kept hearing "osc is moving to sdk", so I figured catch up 1 thing (the sdk), start requiring the sdk for new API microversion, and then we don't have an ever increasing gap to close wrt to novaclient parity.15:54
lyarwoodTIL about http://rst.ninjs.org/15:54
lyarwoodno wonder stephenfin gets his rst correct first time15:54
fricklerartom: I'm pretty sure that the idea for OSC would be to use those things from the sdk, but I don't know if anyone commited to actually working on that. but surely a lot of people would approve that15:55
stephenfinartom: TIL (or rather remembered) I have core on sdk15:55
fricklerartom: maybe best continue that discussion in #openstack-sdks , also eod for me now15:56
artomfrickler, ack. o/15:56
fricklerjust as a final comment, OSC and sdk are a single project for a small while now, so in theory there shouldn't be any gap between those15:57
stephenfinjsuchome, lyarwood: Thoughts on https://review.opendev.org/#/c/574301/35/nova/image/glance.py@225 ?15:57
stephenfinApologies if I've missed some context on that decision (to bring back the deprecated opt)15:57
artomfrickler, "in theory" :D15:59
*** jraju__ has quit IRC15:59
lyarwoodstephenfin: I've not heard any plans for support for other support15:59
jsuchomestephenfin: in general, I don't think there's a big chance to expand it ... but well, who knows15:59
lyarwoodstephenfin: I'd prefer however that we ruled that out at a later date16:00
sean-k-mooneyi could see use adding swift maybe16:01
sean-k-mooneyto pull the image drectly from swrift rather then streaming it via glance16:01
jsuchomeI think it's already mentioned in the blueprint btw16:01
sean-k-mooneyno one has asked for that however16:01
sean-k-mooneybut ya swift is the only thing i can think of that we might ever expand it for and even then im not sure it makes sense16:02
sean-k-mooneyim jsut thinking off the top of my head16:02
sean-k-mooneythe advantage of using the exsiting deprecated option is installer tools whoudl already support it16:03
sean-k-mooneyif we use anything else that creates more work for them16:03
* gibi leaves for today16:03
gibio/16:03
sean-k-mooneyo/ enjoy your evening16:04
gibithanks16:04
sean-k-mooneywhich nova cores like networking and libvirt :)16:05
sean-k-mooneyzuul hasnt finished running yet but i have an old patch that i want to make sure lands before m316:06
sean-k-mooneyhttps://review.opendev.org/#/c/602432/ but it does not need to be reviewd right away the neutron dep merged earlier today so i finally got around to rebasing it16:06
openstackgerritMerged openstack/nova master: [goal] Prepare for job migration to Ubuntu Focal (20.04)  https://review.opendev.org/73812616:11
*** dtantsur is now known as dtantsur|afk16:19
*** owalsh has joined #openstack-nova16:23
*** k_mouza has quit IRC16:26
*** tesseract has quit IRC16:27
*** bnemec has quit IRC16:30
*** bnemec has joined #openstack-nova16:35
*** Luzi has quit IRC16:57
openstackgerritStephen Finucane proposed openstack/nova master: tests: Add helpers for rebuild, cold migrate, and shelve/unshelve  https://review.opendev.org/74779217:01
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Add emulated TPM support to Nova  https://review.opendev.org/63136317:01
openstackgerritStephen Finucane proposed openstack/nova master: docs: Add docs for vTPM support  https://review.opendev.org/73921317:01
openstackgerritStephen Finucane proposed openstack/nova master: Add type hints to 'nova.compute.manager'  https://review.opendev.org/74286317:01
openstackgerritStephen Finucane proposed openstack/nova master: Don't unset Instance.old_flavor, new_flavor until necessary  https://review.opendev.org/74199517:01
openstackgerritStephen Finucane proposed openstack/nova master: privsep: Add support for recursive chown, move_tree operations  https://review.opendev.org/74286417:01
openstackgerritStephen Finucane proposed openstack/nova master: Add type hints to 'nova.virt.libvirt.utils'  https://review.opendev.org/74286517:01
openstackgerritStephen Finucane proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files  https://review.opendev.org/63993417:01
*** mkrai has quit IRC17:07
openstackgerritMerged openstack/nova master: Add reno for deprecated APIs policy changes  https://review.opendev.org/74778417:09
*** derekh has quit IRC17:18
gmanngibi: reno patch is merged you can mark policy-defaults-refresh-deprecated-apis BP completed now.17:22
*** ralonsoh has quit IRC17:27
*** mriedem has joined #openstack-nova17:28
*** derekh has joined #openstack-nova17:33
*** nightmare_unreal has quit IRC17:36
*** bnemec has quit IRC17:50
*** derekh has quit IRC17:52
*** bnemec has joined #openstack-nova17:53
*** k_mouza has joined #openstack-nova17:53
*** k_mouza has quit IRC18:02
*** sridharg has quit IRC18:22
openstackgerritLee Yarwood proposed openstack/nova stable/pike: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration  https://review.opendev.org/74797818:25
*** mvorwerk has joined #openstack-nova18:35
*** mvorwerk_ has joined #openstack-nova18:45
*** mvorwerk has quit IRC18:47
*** pas-ha has quit IRC18:50
*** pas-ha has joined #openstack-nova18:53
*** xek has joined #openstack-nova18:59
*** velizarx has joined #openstack-nova19:05
*** mvorwerk has joined #openstack-nova19:09
*** mvorwerk_ has quit IRC19:11
*** mvorwerk_ has joined #openstack-nova19:24
*** mvorwerk has quit IRC19:27
*** kberger_ has joined #openstack-nova19:39
*** kberger_ has quit IRC19:40
*** kberger_ has joined #openstack-nova19:40
*** KeithMnemonic has quit IRC19:41
*** mvorwerk has joined #openstack-nova19:52
openstackgerritJiri Suchomel proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD  https://review.opendev.org/57430119:53
*** mvorwerk_ has quit IRC19:53
*** nweinber has quit IRC20:01
*** slaweq has quit IRC20:06
*** vishalmanchanda has quit IRC20:10
*** JamesBenson has quit IRC20:10
*** k_mouza has joined #openstack-nova20:13
*** jsuchome has quit IRC20:16
openstackgerritMerged openstack/nova master: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration  https://review.opendev.org/74796920:18
*** slaweq has joined #openstack-nova20:18
*** k_mouza has quit IRC20:18
*** jmlowe has quit IRC20:51
*** jmlowe has joined #openstack-nova20:53
*** mvorwerk_ has joined #openstack-nova21:01
*** brinzhang_ has joined #openstack-nova21:01
*** damien_r has joined #openstack-nova21:02
*** mvorwerk has quit IRC21:04
*** brinzhang has quit IRC21:04
lyarwoodmelwitt: thanks for the stable reviews, would you also mind looking at https://review.opendev.org/#/c/747357/ https://review.opendev.org/#/c/744553/ https://review.opendev.org/#/c/744550/ https://review.opendev.org/#/c/742706/ & https://review.opendev.org/#/c/729177/21:22
*** raildo has quit IRC21:31
melwittack will do21:34
lyarwoodawesome thanks :)21:38
openstackgerritElancheran S proposed openstack/nova stable/ussuri: Removes the delta file once image is extracted  https://review.opendev.org/74803421:47
openstackgerritElancheran S proposed openstack/nova stable/train: Removes the delta file once image is extracted  https://review.opendev.org/74803521:48
*** mriedem has left #openstack-nova21:54
*** rcernin has joined #openstack-nova22:01
*** rcernin has quit IRC22:01
*** rcernin has joined #openstack-nova22:02
*** JamesBenson has joined #openstack-nova22:03
*** bnemec has quit IRC22:14
*** JamesBenson has quit IRC22:17
*** martinkennelly has quit IRC22:36
*** mvorwerk_ has quit IRC22:45
*** mvorwerk has joined #openstack-nova22:45
*** mvorwerk has quit IRC22:51
*** mvorwerk has joined #openstack-nova22:52
*** JamesBenson has joined #openstack-nova22:56
*** mlavalle has quit IRC22:57
*** JamesBenson has quit IRC23:01
*** tosky has quit IRC23:04
*** velizarx has quit IRC23:29
openstackgerritMerged openstack/nova master: db: fix database migrations when name includes dash  https://review.opendev.org/74716423:29
*** JamesBenson has joined #openstack-nova23:37
*** JamesBenson has quit IRC23:42
*** spatel has joined #openstack-nova23:56

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!