| *** songwenping_ has joined #openstack-nova | 00:00 | |
| *** songwenping__ has quit IRC | 00:02 | |
| *** JamesBenson has joined #openstack-nova | 00:13 | |
| *** JamesBenson has quit IRC | 00:18 | |
| *** songwenping_ has quit IRC | 00:19 | |
| *** songwenping_ has joined #openstack-nova | 00:19 | |
| *** mlavalle has quit IRC | 00:27 | |
| *** mlavalle has joined #openstack-nova | 00:31 | |
| *** zhanglong has joined #openstack-nova | 00:36 | |
| *** rcernin_ has joined #openstack-nova | 00:45 | |
| *** rcernin has quit IRC | 00:47 | |
| *** JamesBenson has joined #openstack-nova | 00:56 | |
| *** JamesBenson has quit IRC | 01:00 | |
| *** xiaolin has joined #openstack-nova | 01:09 | |
| *** zhanglong has quit IRC | 01:31 | |
| *** JamesBenson has joined #openstack-nova | 01:35 | |
| *** JamesBenson has quit IRC | 01:40 | |
| *** zhanglong has joined #openstack-nova | 01:46 | |
| *** xiaolin has quit IRC | 01:50 | |
| *** xiaolin has joined #openstack-nova | 01:50 | |
| openstackgerrit | Yingji Sun proposed openstack/nova stable/stein: Set different VirtualDevice.key https://review.opendev.org/749415 | 01:51 |
|---|---|---|
| *** xiaolin has quit IRC | 01:55 | |
| openstackgerrit | Yingji Sun proposed openstack/nova stable/ussuri: Set different VirtualDevice.key https://review.opendev.org/749418 | 02:10 |
| *** manuvakery has joined #openstack-nova | 02:19 | |
| *** aj_mailing has quit IRC | 02:37 | |
| *** JamesBenson has joined #openstack-nova | 02:46 | |
| *** rcernin_ has quit IRC | 03:19 | |
| *** aj_mailing has joined #openstack-nova | 03:26 | |
| *** rcernin_ has joined #openstack-nova | 03:34 | |
| *** psachin has joined #openstack-nova | 03:35 | |
| *** dunweifu has joined #openstack-nova | 03:36 | |
| *** dunweifu has quit IRC | 03:47 | |
| *** zhanglong has quit IRC | 03:58 | |
| *** dunweifu has joined #openstack-nova | 04:04 | |
| *** aj_mailing has quit IRC | 04:05 | |
| *** dunweifu has quit IRC | 04:18 | |
| openstackgerrit | Merged openstack/nova master: Cyborg evacuate support https://review.opendev.org/715326 | 04:30 |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #openstack-nova | 04:33 | |
| *** manuvakery has quit IRC | 04:39 | |
| *** vishalmanchanda has joined #openstack-nova | 04:55 | |
| *** viks____ has joined #openstack-nova | 04:59 | |
| *** gyee has quit IRC | 05:07 | |
| *** links has joined #openstack-nova | 05:14 | |
| *** bhagyashris|away is now known as bhagyashris | 05:27 | |
| *** zhanglong has joined #openstack-nova | 05:34 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Reject resize operation for accelerator https://review.opendev.org/748560 | 05:34 |
| *** kevinz has joined #openstack-nova | 05:34 | |
| *** jsuchome has joined #openstack-nova | 05:39 | |
| *** aj_mailing has joined #openstack-nova | 05:39 | |
| *** slaweq has joined #openstack-nova | 05:53 | |
| brinzhang_ | stephenfin: can you +A for https://review.opendev.org/#/c/748560/, reabsed because of the merged conflict but lost the +A | 06:00 |
| *** viks____ has quit IRC | 06:01 | |
| *** luyao has quit IRC | 06:01 | |
| openstackgerrit | Jiri Suchomel proposed openstack/nova master: Describe '[glance]/enable_rbd_download' https://review.opendev.org/749437 | 06:01 |
| *** arne_wiebalck has quit IRC | 06:01 | |
| *** arne_wiebalck has joined #openstack-nova | 06:02 | |
| *** luyao has joined #openstack-nova | 06:02 | |
| *** viks____ has joined #openstack-nova | 06:04 | |
| *** ratailor has joined #openstack-nova | 06:15 | |
| *** slaweq has quit IRC | 06:18 | |
| *** Yumeng has joined #openstack-nova | 06:30 | |
| *** damien_r has joined #openstack-nova | 06:34 | |
| *** hemanth_n has joined #openstack-nova | 06:35 | |
| openstackgerrit | Elancheran S proposed openstack/nova stable/train: Removes the delta file once image is extracted https://review.opendev.org/748035 | 06:38 |
| *** damien_r has quit IRC | 06:38 | |
| *** ralonsoh has joined #openstack-nova | 06:39 | |
| *** JamesBenson has quit IRC | 06:39 | |
| bauzas | good morning Nova | 06:49 |
| *** rcernin_ has quit IRC | 06:51 | |
| *** rcernin_ has joined #openstack-nova | 06:54 | |
| *** slaweq has joined #openstack-nova | 06:55 | |
| *** manuvakery has joined #openstack-nova | 06:57 | |
| *** ralonsoh has quit IRC | 07:04 | |
| *** ralonsoh has joined #openstack-nova | 07:09 | |
| *** tesseract has joined #openstack-nova | 07:10 | |
| gibi | bauzas: good morning | 07:15 |
| gibi | sean-k-mooney: thanks for the tests | 07:22 |
| *** songwenping__ has joined #openstack-nova | 07:23 | |
| bauzas | gibi: you can't imagine how providing the networks is difficult... | 07:25 |
| *** songwenping_ has quit IRC | 07:26 | |
| gibi | maybe this was the reason why mriedem didn't go down that way | 07:27 |
| openstackgerrit | Wenping Song proposed openstack/nova-specs master: Correct some spell errors https://review.opendev.org/749449 | 07:30 |
| gibi | sean-k-mooney: could the 9.2 where the VFs are freed but not exists after a PF detach can be worked around by setting the host to auto allocate VFs via /etc/network/interfaces.d/ config? | 07:32 |
| * bauzas raises fist at why we don't provide all the physnets | 07:33 | |
| *** rcernin_ has quit IRC | 07:35 | |
| *** brinzhang0 has joined #openstack-nova | 07:35 | |
| *** tosky has joined #openstack-nova | 07:37 | |
| *** brinzhang_ has quit IRC | 07:38 | |
| *** ralonsoh has quit IRC | 07:43 | |
| *** martinkennelly has joined #openstack-nova | 08:07 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Delete non tag related device metadata during detach https://review.opendev.org/741436 | 08:21 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove unused vpn param from allocate_for_instance https://review.opendev.org/744933 | 08:21 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Move equality check into LibvirtConfigGuestInterface https://review.opendev.org/744524 | 08:21 |
| *** dtantsur|afk is now known as dtantsur | 08:23 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Only unplug vif after the device is detached from libvirt https://review.opendev.org/744934 | 08:24 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Make PCI claim NUMA aware during live migration https://review.opendev.org/748453 | 08:24 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use UUID as vif and network_id in vif tests https://review.opendev.org/748722 | 08:24 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: [WIP] Support SRIOV interface attach and detach https://review.opendev.org/740995 | 08:28 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: DNM: tracing the PCI allocation code path https://review.opendev.org/748454 | 08:30 |
| stephenfin | jangutter: care to look at https://review.opendev.org/#/c/744816/ ? | 08:31 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Track error migrations in resource tracker https://review.opendev.org/745281 | 08:38 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Rollback when reset running live migration https://review.opendev.org/747899 | 08:38 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Improve orphans tracking in resource tracker https://review.opendev.org/745282 | 08:38 |
| *** rcernin_ has joined #openstack-nova | 08:40 | |
| *** rcernin_ has quit IRC | 08:46 | |
| jangutter | stephenfin: ack, looking! | 09:01 |
| jsuchome | gibi: lyarwood artom: hi, please take a look at https://review.opendev.org/#/c/574301/ (patch updated with stephenfin idea)+ https://review.opendev.org/#/c/749437/ (release notes) | 09:03 |
| gibi | jsuchome: looking... | 09:04 |
| *** derekh has joined #openstack-nova | 09:05 | |
| gibi | jsuchome: thanks. I'm +2 | 09:09 |
| jangutter | stephenfin, sean-k-mooney: I see https://review.opendev.org/#/c/744816/ is already in the gate. +2 from me, with a potential followup to clean up one of the nits (if it's actually a nit). | 09:10 |
| stephenfin | jangutter: Yup, makes sense to me | 09:13 |
| lyarwood | gibi: thanks! | 09:17 |
| lyarwood | jsuchome: https://review.opendev.org/#/c/743220/ - could you update that to use the new configurables? | 09:18 |
| lyarwood | jsuchome: I'm going to be pretty busy downstream this week so I'll not be able to get to it for a while | 09:18 |
| lyarwood | https://review.opendev.org/#/c/748212/ is the actual job sorry | 09:19 |
| jsuchome | lyarwood: yep; later today I hope | 09:20 |
| lyarwood | jsuchome: cool thanks | 09:20 |
| suryasingh | sean-k-mooney: melwitt dansmith lyarwood Sorry to interrupt you all. I have simple query. Does the current nova-compute service(Data-plane) support graceful shutdown ? Will the nova-compute service stop(systemctl stop openstack-nova-compute.service) wait for the ongoing operation(instance provisioning) to finish ? | 09:25 |
| *** zzzeek has quit IRC | 09:32 | |
| *** zzzeek has joined #openstack-nova | 09:33 | |
| jkulik | suryasingh, there's https://review.opendev.org/#/c/666245/ for spawning VMs at least | 09:34 |
| openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Unified virtual persistent memory restrictions https://review.opendev.org/749472 | 09:35 |
| brinzhang0 | alex_xu: if you are free, please review https://review.opendev.org/#/c/749472/, modify the depency of vPMEM limit in the spec, make it keep consistent with admin guide docs | 09:38 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Add regression tests for bug #1889108 https://review.opendev.org/749232 | 09:39 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: compute: Don't delete the original attachment during pre LM rollback https://review.opendev.org/749233 | 09:39 |
| openstack | bug 1889108 in OpenStack Compute (nova) train "failures during driver.pre_live_migration remove source attachments during rollback" [Undecided,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood) | 09:39 |
| brinzhang0 | alex_xu: please check the dependency package version, is it reasonable? | 09:40 |
| lyarwood | bauzas / elod: would you mind taking a look at https://review.opendev.org/#/c/748496/ | 09:46 |
| suryasingh | @jkulik thanks for response and patch link. Did you tested this patch ? And is there any priority from nova-community side for this patch, if you know about it, sorry for asking. | 09:47 |
| *** zzzeek has quit IRC | 09:48 | |
| *** zzzeek has joined #openstack-nova | 09:49 | |
| jkulik | suryasingh, we're running some version of this patch in production on a queens code-base. I haven't seen any push from the nova-community for this. | 09:56 |
| bauzas | lyarwood: ack | 09:57 |
| suryasingh | @jkulik I see, thanks for info. | 09:58 |
| *** zhanglong has quit IRC | 10:04 | |
| openstackgerrit | Merged openstack/os-vif master: deprecate ovs-vsctl driver and make native the default https://review.opendev.org/744816 | 10:05 |
| *** aj_mailing has quit IRC | 10:06 | |
| *** zzzeek has quit IRC | 10:08 | |
| *** zzzeek has joined #openstack-nova | 10:10 | |
| *** sapd1_x has joined #openstack-nova | 10:21 | |
| frickler | what do I need to do in order to be able to extend an attached RBD volume? https://review.opendev.org/613039 makes me think that this should work since stein, but if I try via cinder, it wants to see an unattached volume. is there some special nova API for this? | 10:27 |
| lyarwood | frickler: isn't that a microversion thing on the c-api side? | 10:30 |
| lyarwood | frickler: https://docs.openstack.org/api-ref/block-storage/v3/index.html?expanded=extend-a-volume-size-detail#volume-actions-volumes-action | 10:30 |
| lyarwood | frickler: Prior to microversion 3.42 the volume status must be available. Starting with microversion 3.42, attached volumes with status in-use may be able to be extended depending on policy and backend volume and compute driver constraints in the cloud. Note that reserved is not a valid state for extend. | 10:30 |
| frickler | lyarwood: ha, I'll try that, thx | 10:31 |
| *** k_mouza has joined #openstack-nova | 10:32 | |
| elod | lyarwood: sure, I'll review those patches today | 10:34 |
| frickler | lyarwood: works like a charm, though seemingly only with the cinder CLI, not OSC, but that's a different topic. thx again | 10:37 |
| lyarwood | frickler: cool np :) | 10:37 |
| lyarwood | elod: awesome thanks! | 10:37 |
| *** lpetrut has joined #openstack-nova | 10:47 | |
| *** brinzhang_ has joined #openstack-nova | 10:48 | |
| *** songwenping_ has joined #openstack-nova | 10:50 | |
| *** brinzhang0 has quit IRC | 10:51 | |
| *** brinzhang has joined #openstack-nova | 10:51 | |
| *** songwenping__ has quit IRC | 10:53 | |
| *** brinzhang_ has quit IRC | 10:54 | |
| openstackgerrit | Merged openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301 | 10:57 |
| *** zzzeek has quit IRC | 10:57 | |
| *** zzzeek has joined #openstack-nova | 11:00 | |
| stephenfin | gibi: So, interesting problem. I'm trying to remove those XenAPI-only APIs and need to optionally disable their tests in Tempest on Victoria+. The pattern we have for that is to check if our max API version > the max of the past release, but Victoria's max is the same as Ussuri (we didn't add new microversions this cycle) | 11:02 |
| stephenfin | So i wonder if there are any last minute API changes we want to make/ :-D | 11:02 |
| stephenfin | ? | 11:02 |
| *** sridharg has joined #openstack-nova | 11:03 | |
| *** k_mouza has quit IRC | 11:09 | |
| alex_xu | brinzhang: that is better to have luyao to take a look at, but I think that is the version luyao tested | 11:09 |
| *** elod has quit IRC | 11:15 | |
| *** jangutter_ has joined #openstack-nova | 11:16 | |
| *** elod has joined #openstack-nova | 11:16 | |
| *** jangutter has quit IRC | 11:20 | |
| *** k_mouza has joined #openstack-nova | 11:30 | |
| *** k_mouza has quit IRC | 11:31 | |
| *** k_mouza has joined #openstack-nova | 11:32 | |
| *** k_mouza has quit IRC | 11:34 | |
| gibi | stephenfin: hm, that is an interesting catch | 11:40 |
| gibi | I'm not aware of inflight microversion bumps | 11:41 |
| gibi | yeah, looking through our bp list I don't think we have a version bump https://launchpad.net/nova/+milestone/victoria-3 | 11:42 |
| sean-k-mooney | gibi: i think that might be a first for m3 since they were added :) | 11:45 |
| sean-k-mooney | stephenfin: you could just add a microverion for this | 11:46 |
| gibi | I guess it is a definit signal that nova development is slowing down | 11:46 |
| sean-k-mooney | to singal the xenapi apis being removed | 11:46 |
| sean-k-mooney | then use that for tempest | 11:47 |
| sean-k-mooney | gibi: by the way i didnt find any thing broken in your code although there is that latent bug for keeping the vfs in teh db in sync with reality after a vf is detached | 11:50 |
| sean-k-mooney | was there anything in particalar you wanted me to test that i did not | 11:50 |
| gibi | sean-k-mooney: thanks for the tests. I think you covered everything. | 11:50 |
| gibi | sean-k-mooney: regarding the latent bug. when a pf is attached to a guest then the host deletes the vfs from the pf | 11:51 |
| gibi | and then when the pf is freed from the guest | 11:51 |
| gibi | the vfs are not recreated by the host | 11:51 |
| sean-k-mooney | kind of | 11:52 |
| gibi | I did added a bit of configuration to re-create the vfs | 11:52 |
| gibi | I mean host config | 11:52 |
| sean-k-mooney | that is the effect but its not somuch the host deleting the vf as we are unbining the pf from the kernel and the vf are destoyed when that happens | 11:52 |
| sean-k-mooney | basically i allocated the VFs using /sys and echo at run time | 11:53 |
| gibi | how the vfs was created in the first place? I guess by writing under /sys | 11:53 |
| gibi | yeah | 11:53 |
| gibi | so that steps is not persistent | 11:53 |
| sean-k-mooney | but that configurtion info is lost when you allocate teh pf to the vm | 11:53 |
| gibi | yepp | 11:53 |
| sean-k-mooney | then wehn qemu is done it does a functionl level pci reset | 11:53 |
| gibi | I think this is a host configuration task to keep the number of vfs perisitent | 11:53 |
| gibi | persistent | 11:53 |
| sean-k-mooney | it is | 11:53 |
| gibi | so I put | 11:54 |
| gibi | pre-up echo '4' > /sys/class/net/enp129s0f0/device/sriov_numvfs | 11:54 |
| sean-k-mooney | but we could also protect against it eaisly in nova | 11:54 |
| gibi | hm, how? | 11:54 |
| gibi | does nova know what is the number of vfs to be re-created? | 11:54 |
| sean-k-mooney | gibi: when we set teh vfs from unavaiable to avaiable after freeing the PF in the db we chould check with libvirt to make sure the exist | 11:54 |
| sean-k-mooney | if they dont we can delete them in the db | 11:55 |
| sean-k-mooney | or i guess we could count them and recreate them with that echo but deleteing seams simpler | 11:55 |
| gibi | ohh, yes, we could sync our db with reality | 11:55 |
| sean-k-mooney | yep | 11:55 |
| gibi | I don't want to recreate anything host level | 11:55 |
| sean-k-mooney | so syncing with reality shoudl be simple | 11:56 |
| gibi | I see | 11:56 |
| *** raildo has joined #openstack-nova | 11:56 | |
| sean-k-mooney | the other thning is that unless your udev rules are correct when you unbind the pf form the vm | 11:56 |
| sean-k-mooney | the pf might not bind back to the netdev vendor driver | 11:56 |
| sean-k-mooney | it can stay bound to vfio-pci | 11:57 |
| sean-k-mooney | in that case the vf wont be recreated by a pre-up command | 11:57 |
| songwenping_ | bauzas: hi, i'm test vGPU with VM and meet some problems. I have install nvidia-smi driver and my GPU's already set nvidia driver, but i cannot find mdev_bus at /sys/class path. | 11:57 |
| sean-k-mooney | but that is definetly out of nova scope | 11:57 |
| sean-k-mooney | songwenping_: what kernel are you using | 11:57 |
| gibi | sean-k-mooney: ack | 11:58 |
| sean-k-mooney | songwenping_: also i dont think that is where it is | 11:58 |
| bauzas | songwenping_: have you installed the nvidia driver in the compute service ? | 11:58 |
| songwenping_ | i use ubuntu 18.04. | 11:58 |
| songwenping_ | my centos env is ok. | 11:59 |
| sean-k-mooney | songwenping_: i think its /sys/bus/mdev not /sys/class/mdev but its only created after you modporbe vfio-mdev | 11:59 |
| sean-k-mooney | yep sean@pop-os:~$ ls /sys/bus/mdev/ | 12:00 |
| sean-k-mooney | devices drivers drivers_autoprobe drivers_probe uevent | 12:00 |
| songwenping_ | sean-k-mooney: also not find at /sys/bus/mdev | 12:00 |
| sean-k-mooney | yep you need to do "sudo modprobe vfio-mdev" | 12:00 |
| sean-k-mooney | to create it | 12:00 |
| sean-k-mooney | wait is this a ubuntu 18.04 host | 12:01 |
| *** JamesBenson has joined #openstack-nova | 12:01 | |
| sean-k-mooney | or guest | 12:01 |
| songwenping_ | host | 12:01 |
| sean-k-mooney | nvidia annoyingly does not have ubuntu host drivers | 12:01 |
| sean-k-mooney | for virtual gpus | 12:01 |
| sean-k-mooney | they only suppor ubuntu guests | 12:02 |
| sean-k-mooney | so unless you used alien or something to install the rhel rpm on your ubuntu host i dont see how you can install the correct driver and kernel module | 12:03 |
| sean-k-mooney | mdevs will work but not nvidia grid on a ubuntu host | 12:03 |
| songwenping_ | i get nvidia-* last week and create vm with vgpu success with devstack on ubuntu 18.04 host. | 12:04 |
| openstackgerrit | Johannes Kulik proposed openstack/nova master: vmware tests: Support different moref backend representations https://review.opendev.org/749488 | 12:04 |
| bauzas | songwenping_: what sean-k-mooney said, nvidia doesn't support ubunutu as a compute OS | 12:05 |
| jkulik | stephenfin, if you find some time, please have a look at https://review.opendev.org/749488 for the first patch for the oslo.vmware SOAP library switch. sorry for the long wait, downstream needed a lot more love than usual ... | 12:06 |
| songwenping_ | i really get the nivida-* is at /sys/class/mdev_bus as centos. but now i cannot get it. | 12:06 |
| *** derekh has quit IRC | 12:09 | |
| *** sridharg has quit IRC | 12:12 | |
| sean-k-mooney | songwenping_: i think that class path will only exist if you have mdevs allocated | 12:13 |
| sean-k-mooney | songwenping_: but as i said you cant use ubuntu as a host os for nvida grid | 12:13 |
| sean-k-mooney | i can be the guest os but nvidia does not make the host level driver availabel for ubuntu | 12:14 |
| songwenping_ | sean-k-mooney: yeah, i have allocated mdevs and i reinstall vgpu-kvm package. | 12:17 |
| *** dave-mccowan has joined #openstack-nova | 12:17 | |
| sean-k-mooney | songwenping_: where did you get the package for ubuntu? | 12:17 |
| songwenping_ | nvidia official website | 12:18 |
| songwenping_ | NVIDIA-Linux-x86_64-440.107-vgpu-kvm.run | 12:18 |
| sean-k-mooney | https://docs.nvidia.com/grid/10.0/product-support-matrix/index.html | 12:19 |
| sean-k-mooney | according to that ubnuntu is not supported as a host os | 12:19 |
| songwenping_ | the path is /sys/class/mdev_bus/0000\:af\:00.0/mdev_supported_types/ generate, but nothing in it.:( | 12:20 |
| sean-k-mooney | your going to have to talk to nvidia about that | 12:20 |
| sean-k-mooney | the offical nividia doc which was last update on the 21st of august says ubunut is not supported i think you install the ubunut guest driver on the host | 12:22 |
| songwenping_ | sean-k-mooney, bauzas: thanks a lot. i'll try to use ubuntu guest. | 12:22 |
| openstackgerrit | Yao wang proposed openstack/nova master: Use VIR_DOMAIN_XML_INACTIVE for detach volume https://review.opendev.org/749489 | 12:22 |
| *** songwenping__ has joined #openstack-nova | 12:33 | |
| *** lbragstad has quit IRC | 12:35 | |
| *** songwenping_ has quit IRC | 12:36 | |
| bauzas | songwenping__: FWIW, for nvidia specific issues like it, please look at their documentation for vGPUs https://docs.nvidia.com/grid/latest/grid-vgpu-user-guide/index.html#grid-vgpu-introduction | 12:36 |
| bauzas | the openstack community is not an nvidia support team :p | 12:37 |
| *** lbragstad has joined #openstack-nova | 12:38 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Add regression tests for bug #1889108 https://review.opendev.org/749232 | 12:46 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: compute: Don't delete the original attachment during pre LM rollback https://review.opendev.org/749233 | 12:46 |
| openstack | bug 1889108 in OpenStack Compute (nova) train "failures during driver.pre_live_migration remove source attachments during rollback" [Undecided,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood) | 12:46 |
| stephenfin | jkulik: sure, done | 12:47 |
| *** zhanglong has joined #openstack-nova | 12:53 | |
| *** derekh has joined #openstack-nova | 13:03 | |
| *** avolkov has joined #openstack-nova | 13:03 | |
| *** ratailor has quit IRC | 13:09 | |
| *** johanssone has quit IRC | 13:11 | |
| *** zhanglong has quit IRC | 13:15 | |
| *** zhanglong has joined #openstack-nova | 13:16 | |
| *** jangutter has joined #openstack-nova | 13:19 | |
| *** jangutte_ has joined #openstack-nova | 13:21 | |
| *** jangutter_ has quit IRC | 13:21 | |
| *** jangutter has quit IRC | 13:24 | |
| *** jangutte_ has quit IRC | 13:26 | |
| *** jangutter has joined #openstack-nova | 13:26 | |
| *** jangutter has quit IRC | 13:29 | |
| *** jangutter has joined #openstack-nova | 13:30 | |
| *** nweinber has joined #openstack-nova | 13:42 | |
| *** _mlavalle_1 has joined #openstack-nova | 13:44 | |
| *** nweinber has quit IRC | 13:45 | |
| *** nweinber has joined #openstack-nova | 13:45 | |
| *** zhanglong has quit IRC | 13:45 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: Resolve issues with various HTTP status codes https://review.opendev.org/749505 | 13:46 |
| stephenfin | gmann, sean-k-mooney, gibi: There's a potential solution to our "no microversion in Victoria" conundrum ^ If that's not completely bonkers, I could probably finish it today | 13:46 |
| *** mlavalle has quit IRC | 13:46 | |
| stephenfin | though, in fairness, it probably is completely bonkers :) | 13:47 |
| gibi | stephenfin: ack, will look. | 13:47 |
| * gibi is knee deep in sriov testing | 13:47 | |
| stephenfin | fair fair | 13:47 |
| *** kaisers has joined #openstack-nova | 13:50 | |
| bauzas | gibi: sean-k-mooney: /me needs help of a network specialist | 13:51 |
| gibi | bauzas: I'm not sure I can help but ask :) | 13:52 |
| bauzas | gibi: for instance create, we're passing requested_networks here https://github.com/openstack/nova/blob/b5d48043466b53fbdfe7b93c2e4efd449904e593/nova/compute/api.py#L954 | 13:53 |
| bauzas | it's a NetworkRequestList object | 13:53 |
| * sean-k-mooney im a "network" specialist, i just tought i did not hate networking | 13:53 | |
| sean-k-mooney | :) | 13:54 |
| bauzas | https://github.com/openstack/nova/blob/b5d48043466b53fbdfe7b93c2e4efd449904e593/nova/objects/network_request.py#L30 | 13:54 |
| bauzas | so I can try to add a new field in some object that would be NetworkRequestList | 13:54 |
| sean-k-mooney | stephenfin: our you could just add a microverion for the api removal too | 13:54 |
| bauzas | sean-k-mooney: gibi: for example, directly the RequestSpec | 13:55 |
| stephenfin | sean-k-mooney: it would be no-op though | 13:55 |
| bauzas | sean-k-mooney: gibi: but if so, I need to use the same for the other move operations | 13:55 |
| sean-k-mooney | well no after the version you would get 404 for the apis | 13:55 |
| sean-k-mooney | stephenfin: ill take a look at your patch after bauzas thing | 13:55 |
| stephenfin | right, but before the version you'd get nothing too | 13:55 |
| bauzas | sean-k-mooney: gibi: but then, we no longer have NetworkRequests, just VIF objects | 13:55 |
| stephenfin | since XenAPI is gone and those things only worked with XenAPI | 13:55 |
| sean-k-mooney | stephenfin: oh i guess ya | 13:56 |
| gibi | bauzas: yeah, so for boot you have network request for move you have either the cache or you can ask neutron for the bound ports of the instance | 13:56 |
| bauzas | sean-k-mooney: gibi: so I wonder if I can create a new NetworkRequest object by using a VIF object | 13:56 |
| gmann | stephenfin: ack, I will check in afternoon | 13:56 |
| bauzas | sean-k-mooney: gibi: like we do in https://github.com/openstack/nova/blob/b5d48043466b53fbdfe7b93c2e4efd449904e593/nova/objects/request_spec.py#L547 | 13:56 |
| sean-k-mooney | the vifs would have everything expction the pci_request_id i think | 13:57 |
| bauzas | sean-k-mooney: gibi: tbc, what's the difference between a VIF object and a NetworkRequest one | 13:57 |
| bauzas | sean-k-mooney: right, see https://github.com/openstack/nova/blob/b5d48043466b53fbdfe7b93c2e4efd449904e593/nova/network/neutron.py#L3064-L3076 | 13:58 |
| sean-k-mooney | no tags or pci requests https://github.com/openstack/nova/blob/master/nova/network/model.py#L380-L404 | 13:58 |
| gibi | I never tried to diff them, but I honeslty affraid of cached data as it might be stale | 13:58 |
| sean-k-mooney | but it will have the network id and port id | 13:58 |
| *** Liang__ has joined #openstack-nova | 13:58 | |
| gibi | I might try to recreate the network request from neutron | 13:59 |
| bauzas | gibi: do we persist it ? | 13:59 |
| sean-k-mooney | bauzas VIF object are constructed form the info we get back form neutron | 13:59 |
| *** Liang__ is now known as LiangFang | 13:59 | |
| sean-k-mooney | so they dont exist untill that point | 13:59 |
| sean-k-mooney | the newtork request obejct are created in the api | 13:59 |
| sean-k-mooney | based on the inital boot request | 14:00 |
| gibi | bauzas: I think we persist the info_cache but I can be mistaken | 14:00 |
| sean-k-mooney | yes | 14:00 |
| sean-k-mooney | they are only persited in the info cache | 14:00 |
| sean-k-mooney | they are also not ovo by the way | 14:00 |
| bauzas | okay, I think we just need network_id | 14:00 |
| bauzas | so this should work | 14:01 |
| sean-k-mooney | yep so the VIF has a network subobject | 14:01 |
| bauzas | ie. having a nested object be NetworkRequestList | 14:01 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/network/model.py#L332 | 14:01 |
| sean-k-mooney | which has the network id | 14:01 |
| sean-k-mooney | bauzas: but just to be clear this will only work for migrations | 14:01 |
| bauzas | and when moving, valuing this field like we do for https://github.com/openstack/nova/blob/master/nova/objects/request_spec.py#L538 by using the VIFs objects from instance info cache | 14:02 |
| sean-k-mooney | it will likely not work for new spawns | 14:02 |
| bauzas | sean-k-mooney: yeah that works, because we directly have the NetworkRequest objects when spawning | 14:02 |
| sean-k-mooney | for new spawns we dont populate the info cache untill the compute node | 14:02 |
| bauzas | yup, that's not a problem | 14:02 |
| sean-k-mooney | ok | 14:02 |
| bauzas | okay, I can try to provide a new revision today then | 14:03 |
| bauzas | thanks | 14:03 |
| gibi | I'm OK recovering the network_id from the cache and then populate network metadata based on that | 14:03 |
| sean-k-mooney | you will proably want to add a function on the network_metadata object to do that | 14:04 |
| bauzas | sean-k-mooney: I don't want to modify the network_medata object | 14:04 |
| bauzas | just the requestspec object or the destination one | 14:04 |
| sean-k-mooney | well you could put it in the request_sep too | 14:04 |
| bauzas | yup, either | 14:04 |
| sean-k-mooney | which ever object your adding the filed too | 14:04 |
| sean-k-mooney | just have a helper function to populated it | 14:05 |
| sean-k-mooney | basically i would like that fucntion to be testable on its own is all im really asking for | 14:05 |
| sean-k-mooney | so we dont have to do complicated mocking in unit tests | 14:05 |
| *** LiangFang has quit IRC | 14:12 | |
| *** _mlavalle_2 has joined #openstack-nova | 14:14 | |
| openstackgerrit | Merged openstack/nova master: Provider Config File: Coding style and test cases improvement https://review.opendev.org/748939 | 14:14 |
| *** Liang__ has joined #openstack-nova | 14:14 | |
| *** _mlavalle_1 has quit IRC | 14:17 | |
| *** johanssone has joined #openstack-nova | 14:36 | |
| lyarwood | stephenfin: https://review.opendev.org/#/c/639934 LGTM, asked a quick question wrt to actual gate testing, I assume this isn't something we could wire up right now correct? | 14:40 |
| stephenfin | looking | 14:45 |
| *** _mlavalle3 has joined #openstack-nova | 14:50 | |
| *** _mlavalle_2 has quit IRC | 14:53 | |
| sean-k-mooney | lyarwood: vtpm can be tested in the gate | 14:53 |
| *** _mlavalle3 has quit IRC | 14:53 | |
| sean-k-mooney | we just need tempest tests with a new compute feature flag | 14:54 |
| sean-k-mooney | to contol running them then we need to update devstack to install teh swtpm software and configure it | 14:54 |
| sean-k-mooney | so it could be tested but we would need to do the automation | 14:55 |
| sean-k-mooney | maybe this is somethign we can work with our qe folks to do | 14:55 |
| sean-k-mooney | e.g. the tempest tests | 14:56 |
| lyarwood | sean-k-mooney: wouldn't we need the clouds we are using to have vTPM enabled instances for us to passthrough? | 14:56 |
| sean-k-mooney | extenting devstack is really just adding a new flag and apt/dnf instaling the package | 14:56 |
| sean-k-mooney | no | 14:57 |
| lyarwood | sean-k-mooney: or is it fully emulated | 14:57 |
| sean-k-mooney | this is fully emulated | 14:57 |
| lyarwood | gah sorry I got confused reading the libvirt docs | 14:57 |
| openstackgerrit | Akhil Gudise proposed openstack/nova master: Introduced a service UP check for host to the Rebuild path https://review.opendev.org/749531 | 14:57 |
| lyarwood | if it's fully emulated then it would've been nice to have a WIP posted already for this tbh | 14:58 |
| sean-k-mooney | i could wip up a temp patch but we dont normally require tempest for a featre to merge | 14:58 |
| sean-k-mooney | e.g. jsut chnage the tempest flaovrs and hardcode the tpm extra specs | 14:59 |
| sean-k-mooney | and manulaly install swtpm | 14:59 |
| lyarwood | sean-k-mooney: we have required tempest changes in the past FWIW | 14:59 |
| *** belmoreira has joined #openstack-nova | 14:59 | |
| sean-k-mooney | not that im aware of | 14:59 |
| stephenfin | swtpm isn't packaged on Ubuntu yet :( | 14:59 |
| sean-k-mooney | we have said they shoudl be added but we have merged the code before hand | 14:59 |
| lyarwood | sean-k-mooney: I've had encrypted volume and stable rescue stuff held up in the past | 15:00 |
| stephenfin | so we'd need to enable some PPAs | 15:00 |
| sean-k-mooney | really | 15:00 |
| lyarwood | stephenfin: well we also have Fedora ;) | 15:00 |
| sean-k-mooney | stephenfin: ya that is easy to do | 15:00 |
| sean-k-mooney | any way moving on form that crazy fedora idea :P | 15:01 |
| sean-k-mooney | am do we want a quick DNM patch to hack in a full tempest run | 15:01 |
| stephenfin | also, the version of QEMU and libvirt on Ubuntu 18.04 is too old | 15:01 |
| sean-k-mooney | like we have done for numa before | 15:01 |
| *** jangutter_ has joined #openstack-nova | 15:01 | |
| stephenfin | I had to use Fedora 31 for testing this locally | 15:01 |
| lyarwood | *cough* Fedora *cough* | 15:01 |
| sean-k-mooney | stephenfin: we are ment to be on ubuntu 20.04 | 15:02 |
| sean-k-mooney | before m3 | 15:02 |
| lyarwood | yeah good luck with that | 15:02 |
| sean-k-mooney | its a comuntiy goal | 15:02 |
| sean-k-mooney | and we really really should have done it already | 15:02 |
| *** jangutter_ has quit IRC | 15:02 | |
| stephenfin | there a issues with some storage-related tests | 15:02 |
| stephenfin | lyarwood has the specifics, iirc | 15:02 |
| sean-k-mooney | that also affects cento8 and fedora | 15:02 |
| sean-k-mooney | since they use teh same version of libvirt and qemu | 15:02 |
| *** jangutter_ has joined #openstack-nova | 15:03 | |
| stephenfin | lyarwood: do we have a Fedora job I can hack on? | 15:03 |
| sean-k-mooney | at least centos 8 and ubuntu 20.04 do | 15:03 |
| sean-k-mooney | fedora might be newer | 15:03 |
| lyarwood | well I could at least reproduce it with bionic and the UCA | 15:04 |
| stephenfin | lyarwood, sean-k-mooney: oh, more fun, cirros doesn't support TPM so we'd have to use different guest images too | 15:04 |
| *** jangutter has quit IRC | 15:04 | |
| lyarwood | stephenfin: >< okay well this is getting harder, I just wanted to ensure the file copying part worked tbh | 15:04 |
| stephenfin | lyarwood: I can reproduce locally with DevStack master on Fedora 31, if that would help? Just go paste the results somewhere. | 15:05 |
| stephenfin | Happy to get whitebox tests going post-M3 then. We'll need them at some point anyway | 15:05 |
| lyarwood | stephenfin: yeah sure it's not worth holding this up for | 15:06 |
| lyarwood | stephenfin: the -1 was for the commit nit btw not this testing | 15:08 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.opendev.org/639934 | 15:10 |
| stephenfin | lyarwood: ta-da ^ | 15:10 |
| jsuchome | lyarwood: adapted https://review.opendev.org/#/c/748212/ | 15:11 |
| gibi | sean-k-mooney: as https://review.opendev.org/#/c/744816/ merged, will you propose an os-vif relase before the lib freeze? | 15:12 |
| sean-k-mooney | am yes although i want to review two other patches today | 15:13 |
| sean-k-mooney | ill propose a patch by eod | 15:13 |
| *** links has quit IRC | 15:19 | |
| stephenfin | gibi, sean-k-mooney: I can do it. Major or minor release, given the change in behavior? | 15:20 |
| stephenfin | I'm tempted to say major | 15:20 |
| sean-k-mooney | its minor we have not broke backwards compatblity | 15:21 |
| gibi | sean-k-mooney, stephenfin: It is OK to have it done tomorrow, no rush. | 15:21 |
| stephenfin | sean-k-mooney: cool | 15:22 |
| sean-k-mooney | https://review.opendev.org/#/c/746673/ and https://review.opendev.org/#/c/745895/ are the two i want to re review | 15:22 |
| *** mlavalle has joined #openstack-nova | 15:22 | |
| stephenfin | gibi: It was a 1 minute job (I timed it :)) https://review.opendev.org/749535 | 15:22 |
| stephenfin | releasing-as-code++ | 15:22 |
| gibi | stephenfin: because you are fast :D | 15:22 |
| sean-k-mooney | ya there is a tool you can run | 15:23 |
| sean-k-mooney | that generate the patch for you | 15:23 |
| gibi | stephenfin: thanks anyhow | 15:23 |
| stephenfin | I know hberaud had one alright. Didn't know there was a generic one | 15:23 |
| sean-k-mooney | its in the repo | 15:23 |
| sean-k-mooney | you just use tox | 15:23 |
| gibi | sean-k-mooney: hit me up with any of those patches if need a push on them before the freeze | 15:23 |
| sean-k-mooney | i need to see if the previous comments have been adressed | 15:24 |
| sean-k-mooney | it is a bug fix so we could backported anyway | 15:24 |
| stephenfin | gibi: Could you carry your +2 from https://review.opendev.org/#/c/741995/10 to https://review.opendev.org/#/c/744958/8 ? They should be identical, commit message aside | 15:25 |
| stephenfin | I had them separate to avoid intertwining two series, but that's not an issue now as the base patches for both have merged | 15:25 |
| stephenfin | I'll abandon https://review.opendev.org/#/c/741995/10 now | 15:26 |
| gibi | done | 15:27 |
| stephenfin | thanks | 15:27 |
| gibi | thanks for that ping, I forget about these duplications | 15:27 |
| stephenfin | and while I have you (last one, promise) - this has two changes since your last +2: a change to some mocks to mock out the new "does this user/group exist" check, and a commit message nit from lyarwood https://review.opendev.org/#/c/639934/ | 15:29 |
| *** Liang__ has quit IRC | 15:29 | |
| stephenfin | if you could revisit and close out the vTPM series \o/ | 15:29 |
| gibi | sure | 15:29 |
| gibi | on it | 15:29 |
| gibi | closing features before the FF week is nice :D | 15:29 |
| gibi | and I'm planning for asking favors on the SRIOV series soon (as it is getting close to be ready)... | 15:30 |
| stephenfin | fire 'em at me | 15:30 |
| gibi | stephenfin: I will, working on functional tests now | 15:31 |
| *** tosky has quit IRC | 15:31 | |
| gibi | +2 | 15:33 |
| sean-k-mooney | gibi: i havent reviewd the WIP patch fully although i tested it. are you ready to remove the WIP status from it | 15:34 |
| sean-k-mooney | i do think its close too | 15:34 |
| gibi | sean-k-mooney: from code perspective it is ready (and my next push will remove the WIP tag) from test perspective I will push the unit test coverage today, but the functional test needs another day | 15:35 |
| sean-k-mooney | ok thanks ill start reviewing the code so. | 15:35 |
| gibi | cool, thanks | 15:35 |
| openstackgerrit | Merged openstack/nova-specs master: Correct some spell errors https://review.opendev.org/749449 | 15:47 |
| *** lpetrut has quit IRC | 15:53 | |
| *** belmoreira has quit IRC | 15:53 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Remove '[vnc] keymap', '[spice] keymap' options https://review.opendev.org/749056 | 15:56 |
| openstackgerrit | Merged openstack/nova master: trivial: Use constants for libvirt version checks https://review.opendev.org/740921 | 16:02 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support SRIOV interface attach and detach https://review.opendev.org/740995 | 16:21 |
| gibi | sean-k-mooney, stephenfin: unit test coverage is ready, and there is the first passing functional test as well ^^ | 16:22 |
| gibi | I will continue with the functional tests tomorrow | 16:22 |
| stephenfin | great | 16:22 |
| stephenfin | can review in the AM too | 16:23 |
| *** links has joined #openstack-nova | 16:28 | |
| sean-k-mooney | stephenfin: speaking fo funcitonal tests what is the state of your sriov functional tests | 16:40 |
| sean-k-mooney | are those merged | 16:40 |
| sean-k-mooney | gibi: did you base your functional tests on stephens work? | 16:40 |
| sean-k-mooney | gibi: i guess you are not doing live migration tests | 16:40 |
| sean-k-mooney | so dont need to | 16:40 |
| sean-k-mooney | it is conflicting with stephens patches however | 16:41 |
| *** dtantsur is now known as dtantsur|afk | 16:57 | |
| *** gibi has quit IRC | 16:57 | |
| *** derekh has quit IRC | 17:08 | |
| *** psachin has quit IRC | 17:09 | |
| *** mgoddard has quit IRC | 17:12 | |
| *** tesseract has quit IRC | 17:29 | |
| *** aj_mailing has joined #openstack-nova | 17:42 | |
| *** jsuchome has quit IRC | 17:43 | |
| *** aj_mailing has quit IRC | 17:52 | |
| *** links has quit IRC | 17:59 | |
| *** manuvakery has quit IRC | 18:05 | |
| ganso | Hi nova folks! I know everyone is busy at the moment, but I'd like to ask for some input in https://bugs.launchpad.net/nova/+bug/1893263 , it is a blocker bug that I have already pushed a fix, would like someone's blessing on it. | 18:15 |
| openstack | Launchpad bug 1893263 in OpenStack Compute (nova) "Cannot create instance with multiqueue image and vif_type=tap (calico)" [Undecided,In progress] - Assigned to Rodrigo Barbieri (rodrigo-barbieri2010) | 18:15 |
| *** k_mouza has joined #openstack-nova | 18:32 | |
| *** k_mouza has quit IRC | 18:36 | |
| sean-k-mooney | ganso: you should be checking the vif_model | 18:40 |
| sean-k-mooney | you are also checking the image property via the system metadata table rather then form the image | 18:41 |
| sean-k-mooney | but yes that is where you would fix this but just not how you should fix this | 18:41 |
| ganso | sean-k-mooney: you mean check vif_model to confirm the vif_type before setting multiqueue? | 18:42 |
| sean-k-mooney | no check the vif_model to confirm its virtio | 18:42 |
| *** vishalmanchanda has quit IRC | 18:43 | |
| sean-k-mooney | if you set hw_vif_model=e1000 then you cant use multiqueue | 18:43 |
| sean-k-mooney | since its a virtio feature | 18:43 |
| ganso | sean-k-mooney: oh I see! | 18:43 |
| ganso | regarding the system metadata. I don't have access to the image in the vif.plug() method (or I am missing something) | 18:44 |
| sean-k-mooney | you have acess via the instance | 18:45 |
| sean-k-mooney | instance.image_meta | 18:45 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L250 | 18:45 |
| ganso | oh I see! when I printed those fields I didn't get that, probably due to object property lazy loading | 18:46 |
| ganso | sean-k-mooney: thanks, I will address those and push a new patch! | 18:46 |
| sean-k-mooney | and yes the image_meta is a property on the instance its not stored in the instnace table directly so the proerty makes sure we correctly build an instance of the class meaning we get validation of the data | 19:07 |
| sean-k-mooney | which is preferebale over parsing the raw data in the system metadta table | 19:07 |
| *** ftarasenko has joined #openstack-nova | 19:08 | |
| *** zzzeek has quit IRC | 19:17 | |
| *** zzzeek has joined #openstack-nova | 19:18 | |
| *** zzzeek has quit IRC | 19:25 | |
| *** zzzeek has joined #openstack-nova | 19:27 | |
| *** artom has quit IRC | 19:39 | |
| *** zzzeek has quit IRC | 19:53 | |
| *** zzzeek has joined #openstack-nova | 19:56 | |
| *** nweinber has quit IRC | 20:00 | |
| *** gyee has joined #openstack-nova | 20:17 | |
| sean-k-mooney | adrianc: https://review.opendev.org/#/c/745895/2/vif_plug_ovs/linux_net.py could you follow up with that offline | 20:20 |
| sean-k-mooney | adrianc: the client lib freeze is tomorrow | 20:21 |
| sean-k-mooney | so we need to resovle the outstaidn question or we wont have this in victoria | 20:21 |
| sean-k-mooney | we could backport it technically but that will be after the upstream release | 20:21 |
| sean-k-mooney | unless we ask for an exception. | 20:21 |
| sean-k-mooney | i just +2d the precedding refactor patch. ill ping gibi and stephenfin to review it again in the morning but we need to confirm if that regex will work with other vendors too | 20:23 |
| *** artom has joined #openstack-nova | 20:23 | |
| sean-k-mooney | the fact teh mellanox ci passed on it is somewhat reasuring unfortuntely the netronome one went away some time ago | 20:24 |
| *** martinkennelly has quit IRC | 20:32 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: post live migration: don't call Neutron needlessly https://review.opendev.org/747451 | 20:38 |
| artom | sean-k-mooney, lyarwood ^^ if you still have the time/energy | 20:38 |
| *** zzzeek has quit IRC | 20:50 | |
| *** zzzeek has joined #openstack-nova | 20:51 | |
| sean-k-mooney | so you just removed raise NotImplemted and moved the stub up | 20:56 |
| sean-k-mooney | well and update the doc string | 20:57 |
| artom | sean-k-mooney, I fixed the test logic as well | 20:57 |
| sean-k-mooney | stubing _notify_about_instance_usage instead of post_live_migration_at_source | 20:57 |
| sean-k-mooney | this is the delta https://review.opendev.org/#/c/747451/5..6/nova/tests/functional/compute/test_live_migration.py | 20:58 |
| artom | sean-k-mooney, since your migrate_data.vifs patch hasn't merged yet, we currently call driver.post_live_migration_at_source with a different network_info | 20:58 |
| artom | So we can't assert anything about it, so I went and mocked the notification helper instead | 20:58 |
| artom | To assert that we're using the correct network_info | 20:58 |
| sean-k-mooney | ah ok | 20:58 |
| *** dustinc has joined #openstack-nova | 20:58 | |
| sean-k-mooney | its a litle non obvious but i guess that works | 20:58 |
| artom | sean-k-mooney, I didn't have a better idea :/ | 20:59 |
| artom | Maybe I should add a note? | 20:59 |
| sean-k-mooney | neither do i so i +1d it | 20:59 |
| sean-k-mooney | well other then merge my patches | 20:59 |
| artom | Cheers! | 20:59 |
| artom | I need to review that | 20:59 |
| sean-k-mooney | sure https://review.opendev.org/#/q/topic:bug/1888395+(status:open+OR+status:merged) | 21:00 |
| sean-k-mooney | also im so shocked a test fixture that does not behave liek reality :P | 21:01 |
| sean-k-mooney | the sad thing is it proably did at one point and our assumetion and precondition have been broken in neturon | 21:01 |
| sean-k-mooney | but its equally likely it was broken form the start just doiong the minium we needed | 21:02 |
| sean-k-mooney | oh cool my devstack patch merged :) https://review.opendev.org/#/c/749295/ i can now stack and unstack without having to delete pyc file the whole time | 21:03 |
| *** sapd1_x has quit IRC | 21:04 | |
| artom | sean-k-mooney, no the fixture's actually fine | 21:04 |
| artom | We just clobber what it gives us with migrate_data.vifs | 21:05 |
| artom | Which makes the test pointless, because that never contains `migrating_to` in the peofile | 21:05 |
| *** rcernin_ has joined #openstack-nova | 21:06 | |
| *** rcernin_ has quit IRC | 21:12 | |
| *** k_mouza has joined #openstack-nova | 21:12 | |
| *** sapd1_x has joined #openstack-nova | 21:17 | |
| *** artom has quit IRC | 21:18 | |
| *** k_mouza has quit IRC | 21:21 | |
| *** artom has joined #openstack-nova | 21:23 | |
| *** k_mouza has joined #openstack-nova | 21:27 | |
| *** k_mouza has quit IRC | 21:31 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/nova master: Allow tap interface with multiqueue https://review.opendev.org/748533 | 21:35 |
| openstackgerrit | Merged openstack/nova master: Don't unset Instance.old_flavor, new_flavor until necessary https://review.opendev.org/744958 | 21:43 |
| openstackgerrit | Merged openstack/nova master: Describe '[glance]/enable_rbd_download' https://review.opendev.org/749437 | 21:44 |
| *** kevinbenton has quit IRC | 21:59 | |
| *** kevinbenton has joined #openstack-nova | 22:00 | |
| *** k_mouza has joined #openstack-nova | 22:07 | |
| *** k_mouza has quit IRC | 22:11 | |
| *** rcernin_ has joined #openstack-nova | 22:15 | |
| *** avolkov has quit IRC | 22:23 | |
| *** raildo_ has joined #openstack-nova | 22:30 | |
| *** raildo has quit IRC | 22:32 | |
| *** k_mouza has joined #openstack-nova | 22:41 | |
| *** k_mouza has quit IRC | 22:47 | |
| *** rcernin_ has quit IRC | 23:04 | |
| *** rcernin has joined #openstack-nova | 23:04 | |
| *** mlavalle has quit IRC | 23:07 | |
| *** dustinc has quit IRC | 23:08 | |
| *** k_mouza has joined #openstack-nova | 23:19 | |
| *** k_mouza has quit IRC | 23:24 | |
| *** lifeless has quit IRC | 23:29 | |
| *** irclogbot_0 has quit IRC | 23:29 | |
| gmann | stephenfin: replied on https://review.opendev.org/#/c/749505/. I remember we discussed this as one of the possible API clean during train cycle but dropped it as there are lot of API changes needed. But as this is API change we definitely need spec first. | 23:29 |
| *** irclogbot_1 has joined #openstack-nova | 23:33 | |
| *** k_mouza has joined #openstack-nova | 23:57 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!