*** zzzeek has joined #openstack-nova | 00:01 | |
*** k_mouza has joined #openstack-nova | 00:24 | |
*** k_mouza has quit IRC | 00:28 | |
*** spatel has joined #openstack-nova | 00:36 | |
*** zzzeek has quit IRC | 00:38 | |
*** zzzeek has joined #openstack-nova | 00:42 | |
*** k_mouza has joined #openstack-nova | 00:44 | |
*** mlavalle has quit IRC | 00:47 | |
*** k_mouza has quit IRC | 00:49 | |
*** gyee has quit IRC | 00:50 | |
*** k_mouza has joined #openstack-nova | 00:54 | |
*** k_mouza has quit IRC | 00:58 | |
*** jhui has joined #openstack-nova | 01:01 | |
*** k_mouza has joined #openstack-nova | 01:06 | |
*** k_mouza has quit IRC | 01:11 | |
*** yingjisun has joined #openstack-nova | 01:13 | |
*** k_mouza has joined #openstack-nova | 01:20 | |
*** openstackgerrit has joined #openstack-nova | 01:21 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: Cyborg shelve/unshelve support https://review.opendev.org/729563 | 01:21 |
---|---|---|
*** spatel has quit IRC | 01:24 | |
*** k_mouza has quit IRC | 01:24 | |
*** Liang__ has joined #openstack-nova | 01:25 | |
*** k_mouza has joined #openstack-nova | 01:33 | |
*** k_mouza has quit IRC | 01:38 | |
*** eandersson has quit IRC | 01:44 | |
*** eandersson has joined #openstack-nova | 01:45 | |
*** vishalmanchanda has joined #openstack-nova | 01:59 | |
*** zzzeek has quit IRC | 02:14 | |
*** chenhaw has quit IRC | 02:15 | |
*** zzzeek has joined #openstack-nova | 02:15 | |
*** chenhaw has joined #openstack-nova | 02:15 | |
*** Yumeng has joined #openstack-nova | 02:20 | |
*** artom has quit IRC | 02:28 | |
*** sapd1_x has joined #openstack-nova | 02:33 | |
openstackgerrit | Merged openstack/nova master: Set migrate_data.vifs only when using multiple port bindings https://review.opendev.org/742180 | 02:41 |
*** zzzeek has quit IRC | 02:45 | |
*** mkrai has joined #openstack-nova | 02:46 | |
*** zzzeek has joined #openstack-nova | 02:48 | |
*** rcernin has quit IRC | 02:50 | |
*** sapd1_x has quit IRC | 02:57 | |
*** rcernin has joined #openstack-nova | 02:59 | |
*** xinranwang__ has joined #openstack-nova | 03:10 | |
*** mkrai has quit IRC | 03:14 | |
*** mkrai has joined #openstack-nova | 03:14 | |
*** k_mouza has joined #openstack-nova | 03:16 | |
*** k_mouza has quit IRC | 03:20 | |
*** k_mouza has joined #openstack-nova | 03:25 | |
*** jhui has quit IRC | 03:29 | |
*** k_mouza has quit IRC | 03:30 | |
*** k_mouza has joined #openstack-nova | 03:35 | |
*** yingjisun has quit IRC | 03:38 | |
*** yingjisun has joined #openstack-nova | 03:38 | |
*** yingjisun has quit IRC | 03:38 | |
*** k_mouza has quit IRC | 03:39 | |
*** ratailor has joined #openstack-nova | 03:46 | |
*** brinzhang_ has joined #openstack-nova | 03:51 | |
*** songwenping__ has joined #openstack-nova | 03:52 | |
*** brinzhang0 has quit IRC | 03:54 | |
*** songwenping_ has quit IRC | 03:55 | |
*** dave-mccowan has quit IRC | 04:12 | |
*** sapd1_x has joined #openstack-nova | 04:19 | |
*** bhagyashris|rove is now known as bhagyashri|rover | 04:32 | |
*** k_mouza has joined #openstack-nova | 04:33 | |
*** evrardjp has quit IRC | 04:33 | |
*** evrardjp has joined #openstack-nova | 04:33 | |
*** k_mouza has quit IRC | 04:37 | |
openstackgerrit | MIKI Nobuhiro proposed openstack/nova master: libvirt: add IP address to libvirt guest metadata https://review.opendev.org/750552 | 04:39 |
*** mkrai has quit IRC | 04:53 | |
*** mkrai has joined #openstack-nova | 04:54 | |
*** yingjisun has joined #openstack-nova | 05:02 | |
*** k_mouza has joined #openstack-nova | 05:07 | |
*** k_mouza has quit IRC | 05:12 | |
*** k_mouza has joined #openstack-nova | 05:14 | |
*** k_mouza has quit IRC | 05:19 | |
*** Liang__ has quit IRC | 05:21 | |
*** Liang__ has joined #openstack-nova | 05:22 | |
openstackgerrit | Luyao Zhong proposed openstack/nova master: Track error migrations in resource tracker https://review.opendev.org/745281 | 05:31 |
openstackgerrit | Luyao Zhong proposed openstack/nova master: Rollback when reset running live migration https://review.opendev.org/747899 | 05:31 |
openstackgerrit | Luyao Zhong proposed openstack/nova master: Improve orphans tracking in resource tracker https://review.opendev.org/745282 | 05:31 |
*** jsuchome has joined #openstack-nova | 05:42 | |
*** k_mouza has joined #openstack-nova | 05:43 | |
*** sapd1_x has quit IRC | 05:43 | |
*** jhui has joined #openstack-nova | 05:45 | |
*** k_mouza has quit IRC | 05:48 | |
openstackgerrit | Federico Ressi proposed openstack/nova master: Log stack trace when fails launching a defined domain https://review.opendev.org/750652 | 05:57 |
*** zzzeek has quit IRC | 05:57 | |
*** k_mouza has joined #openstack-nova | 05:57 | |
*** zzzeek has joined #openstack-nova | 06:01 | |
*** k_mouza has quit IRC | 06:01 | |
*** k_mouza has joined #openstack-nova | 06:08 | |
*** k_mouza has quit IRC | 06:12 | |
*** brinzhang0 has joined #openstack-nova | 06:17 | |
*** brinzhang_ has quit IRC | 06:19 | |
*** k_mouza has joined #openstack-nova | 06:21 | |
*** k_mouza has quit IRC | 06:25 | |
*** suryasingh has joined #openstack-nova | 06:33 | |
*** ralonsoh has joined #openstack-nova | 06:34 | |
*** k_mouza has joined #openstack-nova | 06:35 | |
*** jhui_ has joined #openstack-nova | 06:38 | |
*** k_mouza has quit IRC | 06:39 | |
*** jhui has quit IRC | 06:39 | |
*** jhui_ is now known as jhui | 06:39 | |
*** dklyle has quit IRC | 06:43 | |
*** slaweq has joined #openstack-nova | 06:44 | |
*** k_mouza has joined #openstack-nova | 06:49 | |
*** mkrai has quit IRC | 06:53 | |
*** mkrai_ has joined #openstack-nova | 06:53 | |
*** k_mouza has quit IRC | 06:54 | |
gibi | good morning Nova | 06:57 |
*** jaosorior has joined #openstack-nova | 06:58 | |
*** k_mouza has joined #openstack-nova | 07:06 | |
*** k_mouza has quit IRC | 07:10 | |
*** mkrai_ has quit IRC | 07:12 | |
*** brinzhang_ has joined #openstack-nova | 07:14 | |
*** songwenping_ has joined #openstack-nova | 07:14 | |
*** priteau has joined #openstack-nova | 07:16 | |
*** songwenping__ has quit IRC | 07:17 | |
*** tesseract has joined #openstack-nova | 07:17 | |
*** brinzhang0 has quit IRC | 07:18 | |
bauzas | gibi: good morning | 07:26 |
bauzas | gibi: I need to go off for around 2 hours this morning for an appointment, ping me your new revision for the FUP and I'll try to look at it around noon | 07:29 |
gibi | bauzas: OK, I will ping you | 07:29 |
*** tosky has joined #openstack-nova | 07:32 | |
*** priteau has quit IRC | 07:47 | |
*** zzzeek has quit IRC | 07:48 | |
*** k_mouza has joined #openstack-nova | 07:48 | |
*** zzzeek has joined #openstack-nova | 07:50 | |
*** k_mouza has quit IRC | 07:53 | |
*** priteau has joined #openstack-nova | 07:53 | |
*** xek has joined #openstack-nova | 07:55 | |
*** tesseract has quit IRC | 07:55 | |
*** tesseract has joined #openstack-nova | 07:56 | |
*** k_mouza has joined #openstack-nova | 07:57 | |
*** xinranwang__ has quit IRC | 07:57 | |
*** CeeMac has joined #openstack-nova | 07:59 | |
*** k_mouza has quit IRC | 08:01 | |
*** mkrai_ has joined #openstack-nova | 08:08 | |
*** brinzhang0 has joined #openstack-nova | 08:09 | |
*** songwenping__ has joined #openstack-nova | 08:09 | |
*** xek has quit IRC | 08:09 | |
*** xek has joined #openstack-nova | 08:10 | |
*** jhui has quit IRC | 08:11 | |
*** songwenping_ has quit IRC | 08:12 | |
*** brinzhang_ has quit IRC | 08:12 | |
*** xek has quit IRC | 08:17 | |
*** k_mouza has joined #openstack-nova | 08:19 | |
*** k_mouza has quit IRC | 08:23 | |
*** martinkennelly has joined #openstack-nova | 08:25 | |
*** sapd1_x has joined #openstack-nova | 08:27 | |
*** k_mouza has joined #openstack-nova | 08:30 | |
openstackgerrit | Merged openstack/nova master: Use UUID as vif and network_id in vif tests https://review.opendev.org/748722 | 08:31 |
*** rcernin has quit IRC | 08:35 | |
*** Yumeng has quit IRC | 08:36 | |
*** yingjisun_ has joined #openstack-nova | 08:45 | |
*** slaweq has quit IRC | 08:46 | |
*** yingjisun has quit IRC | 08:46 | |
*** yingjisun_ is now known as yingjisun | 08:46 | |
*** k_mouza has quit IRC | 08:47 | |
*** k_mouza has joined #openstack-nova | 08:48 | |
*** derekh has joined #openstack-nova | 08:52 | |
*** ralonsoh has quit IRC | 08:54 | |
*** ralonsoh has joined #openstack-nova | 08:54 | |
*** aj_mailing has quit IRC | 08:54 | |
*** manuvakery has joined #openstack-nova | 09:06 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Follow up for I67504a37b0fe2ae5da3cba2f3122d9d0e18b9481 https://review.opendev.org/750184 | 09:08 |
gibi | bauzas: the friendly ping I promised ^^ | 09:08 |
*** dtantsur|afk is now known as dtantsur | 09:14 | |
luyao | stephenfin: Hi, I reply you at https://review.opendev.org/#/c/745281/, thanks for review | 09:15 |
luyao | alex_xu: could you have a look at https://review.opendev.org/#/q/topic:bp/vpmem-enhancement+(status:open+OR+status:merged) if you get time, there are some updates and discussion. thanks in advance. | 09:17 |
*** mkrai_ has quit IRC | 09:33 | |
*** mkrai__ has joined #openstack-nova | 09:33 | |
bauzas | gibi: +2d | 09:36 |
bauzas | stephenfin: your +2 is needed https://review.opendev.org/750184 | 09:37 |
* bauzas goes taxing for my children | 09:37 | |
bauzas | taxiing | 09:37 |
gibi | bauzas: thanks | 09:38 |
openstackgerrit | OpenStack Release Bot proposed openstack/os-vif stable/victoria: Update .gitreview for stable/victoria https://review.opendev.org/750924 | 09:45 |
openstackgerrit | OpenStack Release Bot proposed openstack/os-vif stable/victoria: Update TOX_CONSTRAINTS_FILE for stable/victoria https://review.opendev.org/750925 | 09:45 |
openstackgerrit | OpenStack Release Bot proposed openstack/os-vif master: Update master for stable/victoria https://review.opendev.org/750926 | 09:45 |
openstackgerrit | OpenStack Release Bot proposed openstack/os-vif master: Add Python3 wallaby unit tests https://review.opendev.org/750927 | 09:45 |
openstackgerrit | OpenStack Release Bot proposed openstack/python-novaclient stable/victoria: Update .gitreview for stable/victoria https://review.opendev.org/750932 | 09:46 |
openstackgerrit | OpenStack Release Bot proposed openstack/python-novaclient stable/victoria: Update TOX_CONSTRAINTS_FILE for stable/victoria https://review.opendev.org/750933 | 09:46 |
openstackgerrit | OpenStack Release Bot proposed openstack/python-novaclient master: Update master for stable/victoria https://review.opendev.org/750935 | 09:46 |
openstackgerrit | OpenStack Release Bot proposed openstack/python-novaclient master: Add Python3 wallaby unit tests https://review.opendev.org/750937 | 09:46 |
*** k_mouza_ has joined #openstack-nova | 09:49 | |
*** k_mouza has quit IRC | 09:51 | |
*** brinzhang0 has quit IRC | 09:54 | |
*** brinzhang has joined #openstack-nova | 09:58 | |
*** Liang__ has quit IRC | 10:04 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Cleanup unused code https://review.opendev.org/750947 | 10:05 |
admin0 | hi all .. is there a way to remove a entry from the host list ..like that host is removed and will not be added back | 10:08 |
openstackgerrit | wu.shiming proposed openstack/os-vif master: Remove Babel requirement https://review.opendev.org/750948 | 10:08 |
admin0 | host as in hypervisor | 10:08 |
admin0 | google search lists direct database commands | 10:09 |
*** slaweq has joined #openstack-nova | 10:20 | |
*** StevenK has quit IRC | 10:21 | |
*** jaosorior has quit IRC | 10:24 | |
*** jsuchome has quit IRC | 10:32 | |
*** rcernin has joined #openstack-nova | 10:39 | |
lyarwood | admin0: https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/compute-service.html | 10:39 |
lyarwood | stephenfin: is the ordering wrong between https://review.opendev.org/#/c/749303/ and https://review.opendev.org/#/c/749304/1 | 10:47 |
lyarwood | stephenfin: actually it doesn't matter | 10:47 |
stephenfin | I don't think so | 10:47 |
stephenfin | tooling is no use without the driver. Drive doesn't depend on tooling | 10:47 |
stephenfin | The driver | 10:47 |
lyarwood | stephenfin: oh sorry I thought the driver was using that | 10:49 |
lyarwood | stephenfin: so it's just stand alone tooling? | 10:49 |
stephenfin | afaict yes | 10:49 |
lyarwood | ah my bad | 10:49 |
lyarwood | stephenfin: remind me again, what were we waiting on for https://review.opendev.org/#/c/749308/ to start passing? | 10:54 |
*** k_mouza_ has quit IRC | 10:57 | |
stephenfin | lyarwood: | 10:59 |
stephenfin | <admin0> google search lists direct database commands | 10:59 |
stephenfin | whoops | 10:59 |
stephenfin | lyarwood: https://review.opendev.org/#/c/749527/ | 10:59 |
stephenfin | Well that's needed for the next change. It looks like https://review.opendev.org/#/c/749308/ removes an exception that's still required until the following patch. | 11:01 |
stephenfin | I'll reshuffle that series later today to put the patches that break tempest to the end, if possible | 11:01 |
lyarwood | stephenfin: ack yeah sorry I didn't look into the failure, I just recalled you saying something about tests being borked after a certain point and assumed I had found it ^_^ | 11:02 |
lyarwood | stephenfin: https://review.opendev.org/#/q/topic:sriov-functional-tests was the other series you wanted reviews on right? | 11:04 |
admin0 | @stephenfin, thanks .. it worked | 11:04 |
admin0 | @lyarwood, that worked :) | 11:04 |
admin0 | thanks guys | 11:05 |
lyarwood | np | 11:05 |
*** sapd1_x has quit IRC | 11:07 | |
sean-k-mooney | wait xenapi is the reason os-agents is a thing. that always confused me since all the agents are listed under os-services | 11:17 |
sean-k-mooney | at least when using libvirt | 11:18 |
*** StevenK_ has joined #openstack-nova | 11:19 | |
*** StevenK_ is now known as StevenK | 11:23 | |
*** k_mouza has joined #openstack-nova | 11:24 | |
lyarwood | stephenfin: https://review.opendev.org/#/c/746946/ - small nit here, shouldn't you hit the resize API in these tests even if the eventual codepaths are the same at the moment | 11:29 |
*** artom has joined #openstack-nova | 11:31 | |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: compute: refactor volume bdm rollback error handling https://review.opendev.org/749225 | 11:43 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: Add regression tests for bug #1889108 https://review.opendev.org/749226 | 11:43 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: compute: Don't delete the original attachment during pre LM rollback https://review.opendev.org/749227 | 11:43 |
openstack | bug 1889108 in OpenStack Compute (nova) rocky "failures during driver.pre_live_migration remove source attachments during rollback" [Undecided,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood) | 11:44 |
*** dave-mccowan has joined #openstack-nova | 11:45 | |
*** raildo has joined #openstack-nova | 11:52 | |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration https://review.opendev.org/747976 | 11:54 |
*** tesseract has quit IRC | 12:03 | |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration https://review.opendev.org/747976 | 12:05 |
*** tesseract has joined #openstack-nova | 12:05 | |
openstackgerrit | Merged openstack/nova master: virt: Highlight soon-to-be-unused driver APIs https://review.opendev.org/749300 | 12:19 |
openstackgerrit | Merged openstack/nova master: hacking: Stop special casing 'plugins.xenserver' https://review.opendev.org/749301 | 12:19 |
stephenfin | lyarwood: ah, the name of the test is wrong. It should be test_migrate_server | 12:19 |
openstackgerrit | Merged openstack/nova master: docs: Remove references to XenAPI driver https://review.opendev.org/749302 | 12:19 |
openstackgerrit | Merged openstack/nova master: tools: Remove xenserver tooling https://review.opendev.org/749303 | 12:19 |
openstackgerrit | Merged openstack/nova master: doc: Fix note directives https://review.opendev.org/750094 | 12:19 |
openstackgerrit | Merged openstack/nova master: functional: Provide default 'host_info' for '_get_connection' https://review.opendev.org/746942 | 12:19 |
sean-k-mooney | stephenfin: by the way sphinx support building docs in parralel but we dont use it currenlty because some of the sphix extenons we have dont declare supprot for that | 12:23 |
sean-k-mooney | stephenfin: i think they are ones we/you wrote | 12:23 |
stephenfin | yup, smcginnis added support for parallel reading/writing to a couple of the oslo.* Sphinx extensions but I don't think we've done any of the in-tree ones | 12:24 |
sean-k-mooney | parallel builds are much faster think its worth enabling it and fix/declareing support in the extensions | 12:24 |
sean-k-mooney | stephenfin: ya some of the tox envs can just run as is | 12:25 |
sean-k-mooney | it jsut depens on the extenions used in the tox env | 12:25 |
sean-k-mooney | i had a patch locally to just add -j auto to all them but it failed so i abandoned it | 12:25 |
sean-k-mooney | but i noticed gibi mentionsed slow pdf doc in a recheck so i was wondering if we wantted to give it a try | 12:26 |
gibi | I'm hoping that timeout was a one time thing | 12:27 |
sean-k-mooney | ya i know | 12:27 |
sean-k-mooney | but i was building doc for gmann change a few days ago | 12:27 |
sean-k-mooney | and i noticed how slow the release note where | 12:28 |
sean-k-mooney | so i tried adding -j auto to it and it was way faster | 12:28 |
sean-k-mooney | then i was sad when addign it to all the docs env failed because some had extensions that did not declare support | 12:28 |
*** ratailor has quit IRC | 12:29 | |
smcginnis | Some of the local tests I did really sped things up running parallel. | 12:30 |
smcginnis | Probably not as much in gate since there are less available cores, but still faster. | 12:31 |
sean-k-mooney | i use a dev vm that emulates the gate with 8 threads | 12:31 |
sean-k-mooney | and it was noticable | 12:31 |
sean-k-mooney | i say emulates because its got 2 numa node and 2 cpu socket with 2 core and 2 threads per core resulting in 8 thread total | 12:32 |
sean-k-mooney | so its not exactly the same but still it was faster | 12:32 |
*** nweinber has joined #openstack-nova | 12:34 | |
*** jangutter_ has joined #openstack-nova | 12:36 | |
stephenfin | weird, looks like the mirrors are not getting updated at the moment | 12:36 |
stephenfin | those last few merged patches aren't appearing | 12:37 |
*** yingjisun has quit IRC | 12:39 | |
*** jangutter has quit IRC | 12:39 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Add 'start_compute' helper https://review.opendev.org/746943 | 12:52 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Use tempdir for CONF.instances_path https://review.opendev.org/746944 | 12:52 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Clean up PCI tests https://review.opendev.org/746945 | 12:52 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Add cold migration tests for PCI servers https://review.opendev.org/746946 | 12:52 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: conductor: Don't use setattr https://review.opendev.org/746947 | 12:52 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Add test for SR-IOV neutron ports https://review.opendev.org/746948 | 12:52 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: fixtures: Handle binding of first port https://review.opendev.org/746949 | 12:52 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Add live migration tests for PCI, SR-IOV servers https://review.opendev.org/746950 | 12:52 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Expand SR-IOV live migration tests with NUMA https://review.opendev.org/749360 | 12:52 |
*** derekh has quit IRC | 12:58 | |
*** mriedem has joined #openstack-nova | 13:06 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: xenapi: Remove driver and tests https://review.opendev.org/749304 | 13:08 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: virt: Remove 'is_xenapi' helper https://review.opendev.org/749305 | 13:08 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: xenapi: Remove Xen-only code paths https://review.opendev.org/749306 | 13:08 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove 'XenapiLiveMigrateData' https://review.opendev.org/749307 | 13:08 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Final cleanup https://review.opendev.org/749308 | 13:08 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: virt: Remove 'get_console_pool_info' API https://review.opendev.org/749311 | 13:08 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: virt: Remove 'post_interrupted_snapshot_cleanup' API https://review.opendev.org/749313 | 13:08 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: virt: Remove 'set_bootable' API https://review.opendev.org/749314 | 13:08 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: virt: Remove various aggregate APIs https://review.opendev.org/749317 | 13:08 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: virt: Remove 'get_per_instance_usage' API https://review.opendev.org/749318 | 13:08 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Remove 'os-agents' API https://review.opendev.org/749309 | 13:08 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove Agent, AgentList https://review.opendev.org/749310 | 13:08 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: virt: Remove 'get_all_bw_counters' API https://review.opendev.org/749312 | 13:08 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: virt: Remove 'reset_network' API https://review.opendev.org/749315 | 13:09 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: virt: Remove 'change_instance_metadata' API https://review.opendev.org/749316 | 13:09 |
*** priteau has quit IRC | 13:11 | |
*** sorrison has quit IRC | 13:14 | |
*** sorrison has joined #openstack-nova | 13:14 | |
lyarwood | stephenfin: this is not helping my +ratio ^_^ | 13:14 |
lyarwood | stephenfin: what happened there? | 13:14 |
stephenfin | lyarwood: https://review.opendev.org/#/c/749304/2/nova/exception.py@1293 :( | 13:15 |
stephenfin | it should be trivially reapprovable O:) | 13:15 |
stephenfin | and for the SR-IOV series, see last comment from me on https://review.opendev.org/#/c/746943/ | 13:16 |
*** priteau has joined #openstack-nova | 13:16 | |
lyarwood | ACK I'll let CI run on both and reapprove once we are sure it's passing | 13:16 |
stephenfin | cool | 13:17 |
stephenfin | addressed your comment on https://review.opendev.org/#/c/746946/ too while I was respinning | 13:17 |
*** xek has joined #openstack-nova | 13:18 | |
lyarwood | yup thanks | 13:19 |
*** jangutter has joined #openstack-nova | 13:22 | |
stephenfin | gibi, lyarwood: One of you want to hit this vTPM doc change real quick? https://review.opendev.org/#/c/750675/ | 13:23 |
stephenfin | (basically note that resize and cold migrate are supported ops now) | 13:23 |
lyarwood | yup looking | 13:24 |
*** jangutter_ has quit IRC | 13:25 | |
*** brinzhang_ has joined #openstack-nova | 13:25 | |
*** brinzhang has quit IRC | 13:29 | |
*** jangutter_ has joined #openstack-nova | 13:31 | |
openstackgerrit | Artom Lifshitz proposed openstack/nova stable/queens: post live migration: don't call Neutron needlessly https://review.opendev.org/750993 | 13:33 |
*** jangutter has quit IRC | 13:34 | |
*** jangutte_ has joined #openstack-nova | 13:34 | |
*** belmoreira has quit IRC | 13:36 | |
*** jangutter_ has quit IRC | 13:37 | |
stephenfin | sean-k-mooney: Once this is released, we can turn on parallel builds, afaict https://review.opendev.org/750973 | 13:38 |
stephenfin | I'm not sure about whether we'll need to bump our lower-constraints or not. On one hand, if we add '-j auto' then we'll no longer be able to build docs using the older versions, but on the other hand, docs could still be build (just omit '-j auto') | 13:39 |
sean-k-mooney | yes that is what was failing | 13:41 |
sean-k-mooney | the feature classification | 13:41 |
sean-k-mooney | i could check i might see if we could make it conditional based on the sphinx version | 13:43 |
stephenfin | ah no, I wouldn't go that far | 13:44 |
sean-k-mooney | ill see what version of sphinx added it | 13:44 |
sean-k-mooney | if its not supper new then i think a min version bump would be fine | 13:45 |
stephenfin | sorry, I wasn't clear. I'm talking about lower-constraints for the various oslo packages plus sphinx-feature-classification | 13:45 |
sean-k-mooney | otherwise we can make it configurable via an environmnet varable or just postional arg | 13:45 |
sean-k-mooney | oh | 13:45 |
sean-k-mooney | not of sphinx build | 13:45 |
stephenfin | if you tried to build with '-j auto' using sphinx-feature-classification < 1.1.0, it'll fail | 13:45 |
sean-k-mooney | yes | 13:46 |
stephenfin | because it emits a warning saying this extension doesn't support parallel stuff | 13:46 |
sean-k-mooney | it did | 13:46 |
sean-k-mooney | yep | 13:46 |
sean-k-mooney | release nodes totally works | 13:46 |
stephenfin | so does that mean we need to set out lower-constraint for s-f-c to 1.1.0? | 13:46 |
stephenfin | or just assume people building docs with older versions will drop the '-j auto' | 13:46 |
sean-k-mooney | ya we would in wallaby | 13:46 |
sean-k-mooney | be can add -j auto to the other envs | 13:47 |
sean-k-mooney | that dont use that already | 13:47 |
bauzas | gibi: any notes you'd like to see in the prelude ? | 13:47 |
gibi | bauzas: I have nothing specific in my mind right now | 13:47 |
gibi | but I will do a scan of merged renos to get a view | 13:48 |
stephenfin | bauzas: have you noted that XenAPI is gone? | 13:48 |
stephenfin | that's merging as we spak | 13:48 |
stephenfin | *speak | 13:48 |
bauzas | gibi: I'll use your own cycle highlits as a base | 13:48 |
bauzas | stephenfin: ah, no, gtk | 13:48 |
bauzas | stephenfin: in general, I take a look at the main reno master page | 13:48 |
bauzas | so I'll see it, I guess ;) | 13:48 |
gibi | bauzas: cool | 13:49 |
sean-k-mooney | stephenfin: i started reviewin the xenapi removeal then stop as i realed it mainly just code deletion and lyarwood and gibi? had alredy reviewed most of it | 13:49 |
sean-k-mooney | im glad that is going to make it :) | 13:49 |
stephenfin | sean-k-mooney: you might be interested in https://review.opendev.org/#/c/748533/ | 13:50 |
sean-k-mooney | didnt i reveiew an previous version | 13:51 |
sean-k-mooney | i do need to take another look | 13:51 |
stephenfin | oh, so you did | 13:51 |
stephenfin | my bad | 13:51 |
sean-k-mooney | no its good to remind me to look again | 13:51 |
stephenfin | https://review.opendev.org/745605 still needs to be respun too :) | 13:52 |
sean-k-mooney | oh the filters | 13:53 |
sean-k-mooney | actully ill go do that now | 13:53 |
lyarwood | sean-k-mooney: some additional review on these would also be good btw, slightly out of my area tbh https://review.opendev.org/#/c/746949/ | 13:53 |
lyarwood | artom: ^ also if you have bandwidth | 13:53 |
sean-k-mooney | oh the fixture change | 13:54 |
*** Luzi has joined #openstack-nova | 13:54 | |
lyarwood | and the series on top adding the actual tests | 13:54 |
sean-k-mooney | am yes are they mergeragbe after today/feature freeze | 13:54 |
sean-k-mooney | if so ill do the filter deprecation first then ill take a look at those | 13:54 |
lyarwood | ah yeah of course sorry | 13:55 |
sean-k-mooney | no its fine i really should have reviewd that series properly by now | 13:56 |
sean-k-mooney | i have been putting it off | 13:56 |
sean-k-mooney | mainly for lack of brain power and opertunity to sit down and do it properly | 13:56 |
artom | lyarwood, ah, yeah, I'm slowly working my way up that series | 13:57 |
lyarwood | artom: cool thanks, I was fine with the house keeping stuff up until that point FWIW, I just don't have the context to know if we are asserting the right things in the actual LM tests | 14:05 |
artom | lyarwood, ack | 14:07 |
sean-k-mooney | smcginnis: oh you create the non clinet lib stable branches already | 14:39 |
sean-k-mooney | that is good to know. | 14:39 |
sean-k-mooney | we have 2 patches for os-vif to backprot to stable/victoria but they are not merged on master yet and i was going to wait a little while to ensure we dont have any issue before mergeing them anyway | 14:40 |
sean-k-mooney | but i guess this means i dont strictly have to wait to rc1 for master to be open for wallaby in os-vif | 14:40 |
sean-k-mooney | sill going to hold off for a bit however | 14:41 |
*** mriedem has left #openstack-nova | 14:47 | |
smcginnis | sean-k-mooney: Yep, non-client library freeze was last week. So those are already done for victoria. | 14:48 |
smcginnis | Sneaks up quick. | 14:49 |
sean-k-mooney | oh ya i know i am just used to waiting till the main project reach rc1 for the master branch to reopen and stable brances to be created | 14:53 |
sean-k-mooney | smcginnis: but creating the branch early also works | 14:54 |
*** dklyle has joined #openstack-nova | 14:54 | |
sean-k-mooney | smcginnis: also its nice to not have to manually do this in gerrit anymore although i guess i have not done that in a few releases at this point | 14:54 |
smcginnis | Unofficial projects would need to, but anything official should all be going through the releases repo. | 14:55 |
sean-k-mooney | yep | 14:55 |
*** songwenping_ has joined #openstack-nova | 14:58 | |
*** songwenping__ has quit IRC | 15:01 | |
*** jangutter has joined #openstack-nova | 15:02 | |
*** jangutter has quit IRC | 15:03 | |
*** jangutter has joined #openstack-nova | 15:03 | |
*** jangutte_ has quit IRC | 15:05 | |
*** tbachman_ has joined #openstack-nova | 15:12 | |
*** tbachman has quit IRC | 15:13 | |
*** tbachman_ has quit IRC | 15:17 | |
*** tbachman has joined #openstack-nova | 15:19 | |
*** mkrai__ has quit IRC | 15:22 | |
bauzas | lyarwood: gibi: we don't have better docs for glance image cloning but a spec ? https://specs.openstack.org/openstack/nova-specs/specs/victoria/approved/nova-image-download-via-rbd.html | 15:24 |
*** hongbin has joined #openstack-nova | 15:25 | |
gibi | bauzas: there is an open doc patch https://review.opendev.org/#/c/731577/ | 15:26 |
bauzas | uh ok | 15:27 |
bauzas | gibi: so we have 2 different things related to RBD | 15:28 |
bauzas | gibi: one is the glance multistore | 15:28 |
gibi | yes | 15:28 |
bauzas | the other being the precaching | 15:28 |
gibi | yes | 15:28 |
bauzas | honestly, I'd then write two different bullets | 15:28 |
bauzas | because most ops probably don't give a clue about what a glance multistore is | 15:28 |
bauzas | and both are independent | 15:29 |
bauzas | ie. you can precache with or without multistore, and the other way too | 15:29 |
bauzas | dansmith: amirite ? | 15:29 |
dansmith | precache in nova has nothing to do with glance multistore | 15:30 |
*** jangutter_ has joined #openstack-nova | 15:30 | |
bauzas | that's what I understood | 15:30 |
bauzas | the rbd dowload, that's the precache, right? | 15:30 |
dansmith | no | 15:30 |
bauzas | holy shit then | 15:31 |
bauzas | I'm confused | 15:31 |
dansmith | the rbd download thing is just letting nova download the image direct from rbd instead of streaming it through glance, if it has access to the rbd that backs glance | 15:31 |
* bauzas only took German as a 3rd foreign language, not volumes | 15:31 | |
bauzas | ok, that's what I understood, but then what's precaching ? | 15:31 |
bauzas | oh | 15:32 |
bauzas | pulling it to libvirt cache? | 15:32 |
bauzas | whether you pull it thru Glance or from the RBD directly | 15:32 |
bauzas | correct ? | 15:32 |
dansmith | yes, just triggering the image cache to download the image, separately from an actual instance boot | 15:32 |
bauzas | ok | 15:32 |
bauzas | so, what was merged in V ? | 15:33 |
*** jangutter has quit IRC | 15:33 | |
bauzas | from the notes, I see precaching | 15:33 |
bauzas | ah na | 15:33 |
bauzas | nvm | 15:33 |
dansmith | all of that is separate from the glance multistore support in nova :) | 15:33 |
bauzas | it's RBD download | 15:33 |
bauzas | precaching was a U thing | 15:33 |
bauzas | correct ? | 15:33 |
bauzas | U or T, I don't remind exactly | 15:33 |
dansmith | I think precaching was T yeah | 15:34 |
dansmith | sorry, U | 15:34 |
sean-k-mooney | so the two new things in V are the rbd direct download and seperate the multi store support | 15:35 |
dansmith | yes, but I'm not sure the rbd download thing is worth a special callout in the release notes, if that's what we're discussing here | 15:35 |
sean-k-mooney | in the prelude ya | 15:35 |
bauzas | dansmith: kk, now I understand, thanks | 15:36 |
bauzas | yeah, for the prelude, we'll see | 15:36 |
bauzas | we don't have a shit ton of new stuff, even a single microversion to provide | 15:36 |
bauzas | but I agree, this sounds just a small improvement | 15:36 |
bauzas | not worth a prelude | 15:37 |
bauzas | (even if that went somehow to the cycle highlights :p ) | 15:37 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Enable parallel docs build https://review.opendev.org/751034 | 15:40 |
*** k_mouza has quit IRC | 15:41 | |
sean-k-mooney | stephenfin: cool i basically only did the tox.ini part of that locally and didnt really know what to do for the extentions | 15:42 |
stephenfin | sean-k-mooney: it won't work though. oslo.config is borked | 15:42 |
stephenfin | I've pushed a patch for it but it could be a while before it lands. It's a bug but also not massively high priority | 15:42 |
sean-k-mooney | oh so they actully are not parralel safe | 15:42 |
stephenfin | afraid not | 15:43 |
sean-k-mooney | ah ok | 15:43 |
sean-k-mooney | well ya not super high priority the release notes job does seam to work properly | 15:43 |
sean-k-mooney | so maybe we coudl start with that and oter that work and do the rest later | 15:43 |
sean-k-mooney | but ya this is just a nice to have | 15:44 |
*** Luzi has quit IRC | 15:44 | |
gibi | nova meeting will start in 12 minutes on openstack-meeting-3 | 15:48 |
lyarwood | bauzas / elod ; would you mind hitting this for artom please https://review.opendev.org/#/q/topic:bug/1879787+branch:stable/ussuri+status:open | 15:48 |
bauzas | lyarwood: I can, | 15:49 |
bauzas | but rushing up to finish the prelude before the meeting | 15:49 |
*** rcernin has quit IRC | 15:50 | |
*** k_mouza has joined #openstack-nova | 15:54 | |
artom | I'm gonna have to skip the meeting, need lunch before running a time-sensitive errand | 15:54 |
gibi | artom: ack | 15:56 |
gibi | artom: enjoy | 15:56 |
elod | lyarwood: will do after the meeting, if I'm still needed there :) | 15:56 |
sean-k-mooney | what the env argument to get extra loging in func test | 15:58 |
sean-k-mooney | is it OS_DEBUG? | 15:58 |
artom | sean-k-mooney, yarp | 15:59 |
artom | But remember that if it passes, nothing is printed | 15:59 |
sean-k-mooney | its failing | 15:59 |
sean-k-mooney | also holy crap that a lot of logs | 15:59 |
artom | One might say it's a forrest :D | 16:00 |
* stephenfin weeps | 16:00 | |
bauzas | sean-k-mooney: OS_DEBUG=1 | 16:00 |
bauzas | and asserFalse | 16:00 |
bauzas | assertFalse(True) if you wanna get'em | 16:01 |
bauzas | or pdb | 16:01 |
sean-k-mooney | yep OS_DEBUG=True tox -e functional -- 1815153 works | 16:01 |
sean-k-mooney | but it pring all the db migration too | 16:01 |
bauzas | right | 16:01 |
bauzas | I generally pipe the output in a file | 16:01 |
bauzas | 2>&1 | tee myfile | 16:02 |
*** mlavalle has joined #openstack-nova | 16:02 | |
sean-k-mooney | ya i think ill send it to lnav or something | 16:02 |
bauzas | but most of the time, it's just for debugging purpose and in this case, I pdb directly | 16:02 |
bauzas | way faster | 16:02 |
sean-k-mooney | ya so the issue not really simple to pdb debug | 16:03 |
*** brinzhang0 has joined #openstack-nova | 16:03 | |
sean-k-mooney | i mean i can but if im going that far ill proaly just run it in a ide | 16:03 |
sean-k-mooney | for some reason changing form using the az filter to using placement for az is chaning the behviaor fo some tests | 16:04 |
*** k_mouza has quit IRC | 16:04 | |
sean-k-mooney | not in all cases but in like 8 tests | 16:04 |
sean-k-mooney | well also the compute status filter | 16:05 |
sean-k-mooney | this particalar case is not az related | 16:05 |
*** brinzhang_ has quit IRC | 16:06 | |
*** martinkennelly has quit IRC | 16:12 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: Support old & new versions of svm and vmx traits https://review.opendev.org/660515 | 16:13 |
*** k_mouza has joined #openstack-nova | 16:15 | |
*** martinkennelly has joined #openstack-nova | 16:15 | |
*** abhishekk has joined #openstack-nova | 16:17 | |
bauzas | stephenfin: can't see xenapi removal notes in https://docs.openstack.org/releasenotes/nova/unreleased.html | 16:17 |
bauzas | stephenfin: could you please point to me the patch itself ? | 16:17 |
stephenfin | bauzas: https://review.opendev.org/#/c/749304/ It was approved before I hit a merge conflict and lyarwood is waiting for a green gate before re-approving | 16:18 |
bauzas | stephenfin: k thanks, I'll proactively add this in the prelude section | 16:18 |
bauzas | actually, I'll hold on it | 16:19 |
*** dtantsur is now known as dtantsur|afk | 16:22 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova master: Victoria 22.0.0 prelude section https://review.opendev.org/751045 | 16:27 |
*** hamalq has joined #openstack-nova | 16:32 | |
*** artom has quit IRC | 16:34 | |
openstackgerrit | Merged openstack/python-novaclient master: Update master for stable/victoria https://review.opendev.org/750935 | 16:35 |
bauzas | gibi: https://review.opendev.org/751045 | 16:39 |
bauzas | it's a start | 16:39 |
gibi | bauzas: thanks | 16:39 |
gibi | I will read it tomorrow | 16:40 |
* gibi is leaving for today | 16:41 | |
lyarwood | \o | 16:42 |
*** k_mouza has quit IRC | 16:49 | |
sean-k-mooney | so ya there are races in these tests... | 16:52 |
sean-k-mooney | specificlaly looks like we are not waiting for the service to be forced_down before doing the evacuate | 16:53 |
sean-k-mooney | we are just calling the api then continuing | 16:53 |
*** gyee has joined #openstack-nova | 17:03 | |
*** k_mouza has joined #openstack-nova | 17:04 | |
lyarwood | sean-k-mooney: which tests are these? | 17:08 |
openstackgerrit | Merged openstack/nova master: docs: Remove resize, cold migration from vTPM limitations https://review.opendev.org/750675 | 17:08 |
lyarwood | oh gate/test_evacuate.sh doesn't wait until the service is down for the first round of evacuations | 17:10 |
*** tonyb has quit IRC | 17:15 | |
openstackgerrit | Merged openstack/nova master: functional: Add 'start_compute' helper https://review.opendev.org/746943 | 17:15 |
openstackgerrit | Merged openstack/nova master: functional: Use tempdir for CONF.instances_path https://review.opendev.org/746944 | 17:15 |
openstackgerrit | Merged openstack/nova master: functional: Clean up PCI tests https://review.opendev.org/746945 | 17:16 |
openstackgerrit | Luyao Zhong proposed openstack/nova master: Rollback when reset running live migration https://review.opendev.org/747899 | 17:16 |
openstackgerrit | Luyao Zhong proposed openstack/nova master: Improve orphans tracking in resource tracker https://review.opendev.org/745282 | 17:16 |
openstackgerrit | Merged openstack/nova master: functional: Add cold migration tests for PCI servers https://review.opendev.org/746946 | 17:16 |
stephenfin | sean-k-mooney: did you get that patch reworked? | 17:21 |
sean-k-mooney | stephenfin: no | 17:24 |
sean-k-mooney | lyarwood: on sec ill provid the link | 17:24 |
sean-k-mooney | stephenfin: some of the func test are not correct | 17:24 |
sean-k-mooney | stephenfin: they are not waiting for palcment to be updated after we set teh comptue service down | 17:25 |
*** xek has quit IRC | 17:25 | |
sean-k-mooney | lyarwood: stephenfin https://github.com/openstack/nova/blob/master/nova/tests/functional/regressions/test_bug_1815153.py#L108 | 17:26 |
sean-k-mooney | we put the service down | 17:26 |
sean-k-mooney | but form the debug logs i am not seing us update placment before we then do the migrate or eveacuate in the next test | 17:26 |
sean-k-mooney | https://review.opendev.org/#/c/654596/8/nova/compute/api.py@5156 should have made the api call update placment | 17:27 |
sean-k-mooney | and the tests are using the latest microverion | 17:28 |
lyarwood | sean-k-mooney: that's not due to something with the placement fixture? | 17:29 |
sean-k-mooney | it might be | 17:29 |
sean-k-mooney | im going to mock _update_compute_provider_status | 17:29 |
sean-k-mooney | and see if its called | 17:29 |
sean-k-mooney | but i dont think it is being called | 17:29 |
sean-k-mooney | well i dont see a http request to placment to update the traits | 17:29 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: test_evacuate: Wait until subnode is disabled before starting tests https://review.opendev.org/751065 | 17:29 |
lyarwood | anyway ^ is what I thought you were talking about, we should be waiting there as well tbh | 17:30 |
sean-k-mooney | ya so i was debating just pooling for the api to show the service down and sleeping | 17:31 |
*** tesseract has quit IRC | 17:31 | |
sean-k-mooney | i tried runing the periodic task to have update resouce provider un too but it didnt help | 17:31 |
sean-k-mooney | i think since the compute service is stopped that is why | 17:32 |
sean-k-mooney | since we both stop it and set force down | 17:32 |
sean-k-mooney | lyarwood: but yes waiting there also makes sense | 17:33 |
sean-k-mooney | lyarwood: we have similar logic in whitebox now for when we update the config | 17:33 |
*** suryasingh has quit IRC | 17:35 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: test_evacuate: Wait until subnode is disabled before starting tests https://review.opendev.org/751065 | 17:35 |
*** k_mouza has quit IRC | 17:37 | |
openstackgerrit | Merged openstack/python-novaclient master: Add Python3 wallaby unit tests https://review.opendev.org/750937 | 17:44 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Support SRIOV interface attach and detach https://review.opendev.org/740995 | 17:45 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Make PCI claim NUMA aware during live migration https://review.opendev.org/748453 | 17:45 |
sean-k-mooney | oh this is just doing self.rpcapi.set_host_enabled(context, service.host, enabled) | 17:49 |
sean-k-mooney | so the api is relying on the compute node to update it? that cant be right | 17:50 |
*** tonyb has joined #openstack-nova | 17:57 | |
*** manuvakery has quit IRC | 18:05 | |
*** artom has joined #openstack-nova | 18:09 | |
*** gmann is now known as gmann_afk | 18:11 | |
*** artom has quit IRC | 18:43 | |
openstackgerrit | Merged openstack/nova master: Move confirm resize under semaphore https://review.opendev.org/747745 | 18:49 |
openstackgerrit | Merged openstack/nova stable/ussuri: Reject resize operation for accelerator https://review.opendev.org/749701 | 18:52 |
openstackgerrit | Merged openstack/nova master: Undeprecate the vmwareapi driver https://review.opendev.org/742407 | 18:52 |
openstackgerrit | Merged openstack/nova stable/ussuri: func: Introduce a server_expected_state kwarg to InstanceHelperMixin._live_migrate https://review.opendev.org/746527 | 18:52 |
openstackgerrit | Merged openstack/nova stable/ussuri: Add regression test for bug 1879787 https://review.opendev.org/746528 | 18:53 |
openstack | bug 1879787 in OpenStack Compute (nova) "post_live_migration does not handle Neutron errors" [Medium,Fix released] https://launchpad.net/bugs/1879787 - Assigned to Artom Lifshitz (notartom) | 18:53 |
*** xek has joined #openstack-nova | 19:07 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: test_evacuate: Wait until subnode is down before starting tests https://review.opendev.org/751065 | 19:11 |
sean-k-mooney | lyarwood: oh right force down changes the state field | 19:15 |
*** priteau has quit IRC | 19:16 | |
*** hamalq_ has joined #openstack-nova | 19:23 | |
*** hamalq has quit IRC | 19:24 | |
lyarwood | sean-k-mooney: yup my bad | 19:26 |
lyarwood | sean-k-mooney: should be correct this time | 19:26 |
lyarwood | sean-k-mooney: was going to hack around with the evacuate job anyway this evening | 19:26 |
*** ralonsoh has quit IRC | 19:27 | |
*** yingjisun has joined #openstack-nova | 19:29 | |
openstackgerrit | Merged openstack/nova stable/ussuri: post live migration: don't call Neutron needlessly https://review.opendev.org/750374 | 19:33 |
*** yingjisun has quit IRC | 19:43 | |
*** slaweq has quit IRC | 19:53 | |
*** jangutter has joined #openstack-nova | 19:53 | |
*** jangutter has quit IRC | 19:54 | |
*** jangutter_ has quit IRC | 19:54 | |
*** jangutter has joined #openstack-nova | 19:54 | |
*** xek has quit IRC | 20:08 | |
*** nweinber has quit IRC | 20:10 | |
*** openstackgerrit has quit IRC | 20:36 | |
*** dklyle has quit IRC | 20:40 | |
*** david-lyle has joined #openstack-nova | 20:40 | |
*** artom has joined #openstack-nova | 20:46 | |
*** david-lyle is now known as dklyle | 20:56 | |
*** raildo has quit IRC | 21:30 | |
sean-k-mooney | lyarwood: so ya AssertionError: Expected '_update_compute_provider_status' to have been called once. Called 0 times. | 21:34 |
sean-k-mooney | also i dont think that would wokr anyway but i think there is something up with the fixture | 21:35 |
*** mgariepy has quit IRC | 21:35 | |
sean-k-mooney | self.api.put_service( | 21:35 |
sean-k-mooney | source_compute_id, {'forced_down': 'true'}) | 21:35 |
sean-k-mooney | is not causing that to run | 21:36 |
sean-k-mooney | and it should | 21:36 |
sean-k-mooney | it might be an issue with the OSAPIFixture | 21:37 |
*** mgariepy has joined #openstack-nova | 21:40 | |
*** vishalmanchanda has quit IRC | 22:21 | |
*** zzzeek has quit IRC | 22:26 | |
*** zzzeek has joined #openstack-nova | 22:27 | |
*** tosky has quit IRC | 22:42 | |
*** gmann_afk is now known as gmann | 22:49 | |
*** openstackgerrit has joined #openstack-nova | 22:54 | |
openstackgerrit | Merged openstack/nova master: Support SRIOV interface attach and detach https://review.opendev.org/740995 | 22:54 |
*** rcernin has joined #openstack-nova | 22:58 | |
*** rcernin has quit IRC | 22:59 | |
*** rcernin has joined #openstack-nova | 22:59 | |
*** mlavalle has quit IRC | 23:02 | |
sean-k-mooney | lyarwood: by the way i figured out what the issue with the test is i think | 23:10 |
sean-k-mooney | the test is seting the force donw flag | 23:11 |
sean-k-mooney | but its not disabling the service | 23:11 |
sean-k-mooney | https://github.com/openstack/nova/blob/c57d52e1978210fb3260bf8ea442237d548db576/nova/tests/functional/regressions/test_bug_1815153.py#L105-L107 | 23:11 |
sean-k-mooney | service_update is only chekcing for disabled | 23:13 |
sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L5820 | 23:13 |
sean-k-mooney | the compute api also does a call to the compute manager to actully do the placment update | 23:15 |
sean-k-mooney | https://github.com/openstack/nova/blob/509c01e86d7f1168cf3fc963608b557f65f47f74/nova/compute/api.py#L5798 | 23:15 |
sean-k-mooney | so that also wont work in this case. | 23:15 |
sean-k-mooney | so beacuse of this else https://github.com/openstack/nova/blob/6f6b63ee5f7ae180d5f81e61f04332f7aa14f9be/nova/scheduler/filters/compute_filter.py#L43-L47 the ComputeFilter and the compute_status_filter prefilter is not equivlent since the former check both for disable and up were as the later only check for disabled | 23:21 |
sean-k-mooney | so if i want to disable the ComputeFilter by default and use the prefilter instead i need to change teh api and periodic task to also chekc the state vaule not just the status. | 23:22 |
sean-k-mooney | or rahter check if the serivce is disable or down | 23:23 |
sean-k-mooney | and add COMPUTE_STATUS_DISABLED in both cases | 23:23 |
sean-k-mooney | or maybe add a COMPUTE_STATUS_DOWN trait too | 23:23 |
sean-k-mooney | if we dont want to over load COMPUTE_STATUS_DISABLED | 23:24 |
sean-k-mooney | so with that in mind i might undo the deprecation of the compute filter for victoria and just deprecte the az filter since the placment prefilter for that has the same behavior | 23:24 |
*** zzzeek has quit IRC | 23:24 | |
sean-k-mooney | and then fix the compute prefilter behavior in wallaby | 23:25 |
sean-k-mooney | stephenfin: gibi when ye are awake does ^ make sense to ye | 23:25 |
sean-k-mooney | also sriov attach/detach megered :) that is good | 23:26 |
*** zzzeek has joined #openstack-nova | 23:29 | |
*** tetsuro has joined #openstack-nova | 23:58 | |
*** zzzeek has quit IRC | 23:58 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!