Thursday, 2020-09-10

*** zzzeek has joined #openstack-nova00:01
*** k_mouza has joined #openstack-nova00:24
*** k_mouza has quit IRC00:28
*** spatel has joined #openstack-nova00:36
*** zzzeek has quit IRC00:38
*** zzzeek has joined #openstack-nova00:42
*** k_mouza has joined #openstack-nova00:44
*** mlavalle has quit IRC00:47
*** k_mouza has quit IRC00:49
*** gyee has quit IRC00:50
*** k_mouza has joined #openstack-nova00:54
*** k_mouza has quit IRC00:58
*** jhui has joined #openstack-nova01:01
*** k_mouza has joined #openstack-nova01:06
*** k_mouza has quit IRC01:11
*** yingjisun has joined #openstack-nova01:13
*** k_mouza has joined #openstack-nova01:20
*** openstackgerrit has joined #openstack-nova01:21
openstackgerritBrin Zhang proposed openstack/nova master: Cyborg shelve/unshelve support  https://review.opendev.org/72956301:21
*** spatel has quit IRC01:24
*** k_mouza has quit IRC01:24
*** Liang__ has joined #openstack-nova01:25
*** k_mouza has joined #openstack-nova01:33
*** k_mouza has quit IRC01:38
*** eandersson has quit IRC01:44
*** eandersson has joined #openstack-nova01:45
*** vishalmanchanda has joined #openstack-nova01:59
*** zzzeek has quit IRC02:14
*** chenhaw has quit IRC02:15
*** zzzeek has joined #openstack-nova02:15
*** chenhaw has joined #openstack-nova02:15
*** Yumeng has joined #openstack-nova02:20
*** artom has quit IRC02:28
*** sapd1_x has joined #openstack-nova02:33
openstackgerritMerged openstack/nova master: Set migrate_data.vifs only when using multiple port bindings  https://review.opendev.org/74218002:41
*** zzzeek has quit IRC02:45
*** mkrai has joined #openstack-nova02:46
*** zzzeek has joined #openstack-nova02:48
*** rcernin has quit IRC02:50
*** sapd1_x has quit IRC02:57
*** rcernin has joined #openstack-nova02:59
*** xinranwang__ has joined #openstack-nova03:10
*** mkrai has quit IRC03:14
*** mkrai has joined #openstack-nova03:14
*** k_mouza has joined #openstack-nova03:16
*** k_mouza has quit IRC03:20
*** k_mouza has joined #openstack-nova03:25
*** jhui has quit IRC03:29
*** k_mouza has quit IRC03:30
*** k_mouza has joined #openstack-nova03:35
*** yingjisun has quit IRC03:38
*** yingjisun has joined #openstack-nova03:38
*** yingjisun has quit IRC03:38
*** k_mouza has quit IRC03:39
*** ratailor has joined #openstack-nova03:46
*** brinzhang_ has joined #openstack-nova03:51
*** songwenping__ has joined #openstack-nova03:52
*** brinzhang0 has quit IRC03:54
*** songwenping_ has quit IRC03:55
*** dave-mccowan has quit IRC04:12
*** sapd1_x has joined #openstack-nova04:19
*** bhagyashris|rove is now known as bhagyashri|rover04:32
*** k_mouza has joined #openstack-nova04:33
*** evrardjp has quit IRC04:33
*** evrardjp has joined #openstack-nova04:33
*** k_mouza has quit IRC04:37
openstackgerritMIKI Nobuhiro proposed openstack/nova master: libvirt: add IP address to libvirt guest metadata  https://review.opendev.org/75055204:39
*** mkrai has quit IRC04:53
*** mkrai has joined #openstack-nova04:54
*** yingjisun has joined #openstack-nova05:02
*** k_mouza has joined #openstack-nova05:07
*** k_mouza has quit IRC05:12
*** k_mouza has joined #openstack-nova05:14
*** k_mouza has quit IRC05:19
*** Liang__ has quit IRC05:21
*** Liang__ has joined #openstack-nova05:22
openstackgerritLuyao Zhong proposed openstack/nova master: Track error migrations in resource tracker  https://review.opendev.org/74528105:31
openstackgerritLuyao Zhong proposed openstack/nova master: Rollback when reset running live migration  https://review.opendev.org/74789905:31
openstackgerritLuyao Zhong proposed openstack/nova master: Improve orphans tracking in resource tracker  https://review.opendev.org/74528205:31
*** jsuchome has joined #openstack-nova05:42
*** k_mouza has joined #openstack-nova05:43
*** sapd1_x has quit IRC05:43
*** jhui has joined #openstack-nova05:45
*** k_mouza has quit IRC05:48
openstackgerritFederico Ressi proposed openstack/nova master: Log stack trace when fails launching a defined domain  https://review.opendev.org/75065205:57
*** zzzeek has quit IRC05:57
*** k_mouza has joined #openstack-nova05:57
*** zzzeek has joined #openstack-nova06:01
*** k_mouza has quit IRC06:01
*** k_mouza has joined #openstack-nova06:08
*** k_mouza has quit IRC06:12
*** brinzhang0 has joined #openstack-nova06:17
*** brinzhang_ has quit IRC06:19
*** k_mouza has joined #openstack-nova06:21
*** k_mouza has quit IRC06:25
*** suryasingh has joined #openstack-nova06:33
*** ralonsoh has joined #openstack-nova06:34
*** k_mouza has joined #openstack-nova06:35
*** jhui_ has joined #openstack-nova06:38
*** k_mouza has quit IRC06:39
*** jhui has quit IRC06:39
*** jhui_ is now known as jhui06:39
*** dklyle has quit IRC06:43
*** slaweq has joined #openstack-nova06:44
*** k_mouza has joined #openstack-nova06:49
*** mkrai has quit IRC06:53
*** mkrai_ has joined #openstack-nova06:53
*** k_mouza has quit IRC06:54
gibigood morning Nova06:57
*** jaosorior has joined #openstack-nova06:58
*** k_mouza has joined #openstack-nova07:06
*** k_mouza has quit IRC07:10
*** mkrai_ has quit IRC07:12
*** brinzhang_ has joined #openstack-nova07:14
*** songwenping_ has joined #openstack-nova07:14
*** priteau has joined #openstack-nova07:16
*** songwenping__ has quit IRC07:17
*** tesseract has joined #openstack-nova07:17
*** brinzhang0 has quit IRC07:18
bauzasgibi: good morning07:26
bauzasgibi: I need to go off for around 2 hours this morning for an appointment, ping me your new revision for the FUP and I'll try to look at it around noon07:29
gibibauzas: OK, I will ping you07:29
*** tosky has joined #openstack-nova07:32
*** priteau has quit IRC07:47
*** zzzeek has quit IRC07:48
*** k_mouza has joined #openstack-nova07:48
*** zzzeek has joined #openstack-nova07:50
*** k_mouza has quit IRC07:53
*** priteau has joined #openstack-nova07:53
*** xek has joined #openstack-nova07:55
*** tesseract has quit IRC07:55
*** tesseract has joined #openstack-nova07:56
*** k_mouza has joined #openstack-nova07:57
*** xinranwang__ has quit IRC07:57
*** CeeMac has joined #openstack-nova07:59
*** k_mouza has quit IRC08:01
*** mkrai_ has joined #openstack-nova08:08
*** brinzhang0 has joined #openstack-nova08:09
*** songwenping__ has joined #openstack-nova08:09
*** xek has quit IRC08:09
*** xek has joined #openstack-nova08:10
*** jhui has quit IRC08:11
*** songwenping_ has quit IRC08:12
*** brinzhang_ has quit IRC08:12
*** xek has quit IRC08:17
*** k_mouza has joined #openstack-nova08:19
*** k_mouza has quit IRC08:23
*** martinkennelly has joined #openstack-nova08:25
*** sapd1_x has joined #openstack-nova08:27
*** k_mouza has joined #openstack-nova08:30
openstackgerritMerged openstack/nova master: Use UUID as vif and network_id in vif tests  https://review.opendev.org/74872208:31
*** rcernin has quit IRC08:35
*** Yumeng has quit IRC08:36
*** yingjisun_ has joined #openstack-nova08:45
*** slaweq has quit IRC08:46
*** yingjisun has quit IRC08:46
*** yingjisun_ is now known as yingjisun08:46
*** k_mouza has quit IRC08:47
*** k_mouza has joined #openstack-nova08:48
*** derekh has joined #openstack-nova08:52
*** ralonsoh has quit IRC08:54
*** ralonsoh has joined #openstack-nova08:54
*** aj_mailing has quit IRC08:54
*** manuvakery has joined #openstack-nova09:06
openstackgerritBalazs Gibizer proposed openstack/nova master: Follow up for I67504a37b0fe2ae5da3cba2f3122d9d0e18b9481  https://review.opendev.org/75018409:08
gibibauzas: the friendly ping I promised  ^^09:08
*** dtantsur|afk is now known as dtantsur09:14
luyaostephenfin: Hi, I reply you at https://review.opendev.org/#/c/745281/, thanks for review09:15
luyaoalex_xu: could you have a look at https://review.opendev.org/#/q/topic:bp/vpmem-enhancement+(status:open+OR+status:merged) if you get time, there are some updates and discussion. thanks in advance.09:17
*** mkrai_ has quit IRC09:33
*** mkrai__ has joined #openstack-nova09:33
bauzasgibi: +2d09:36
bauzasstephenfin: your +2 is needed https://review.opendev.org/75018409:37
* bauzas goes taxing for my children09:37
bauzastaxiing09:37
gibibauzas: thanks09:38
openstackgerritOpenStack Release Bot proposed openstack/os-vif stable/victoria: Update .gitreview for stable/victoria  https://review.opendev.org/75092409:45
openstackgerritOpenStack Release Bot proposed openstack/os-vif stable/victoria: Update TOX_CONSTRAINTS_FILE for stable/victoria  https://review.opendev.org/75092509:45
openstackgerritOpenStack Release Bot proposed openstack/os-vif master: Update master for stable/victoria  https://review.opendev.org/75092609:45
openstackgerritOpenStack Release Bot proposed openstack/os-vif master: Add Python3 wallaby unit tests  https://review.opendev.org/75092709:45
openstackgerritOpenStack Release Bot proposed openstack/python-novaclient stable/victoria: Update .gitreview for stable/victoria  https://review.opendev.org/75093209:46
openstackgerritOpenStack Release Bot proposed openstack/python-novaclient stable/victoria: Update TOX_CONSTRAINTS_FILE for stable/victoria  https://review.opendev.org/75093309:46
openstackgerritOpenStack Release Bot proposed openstack/python-novaclient master: Update master for stable/victoria  https://review.opendev.org/75093509:46
openstackgerritOpenStack Release Bot proposed openstack/python-novaclient master: Add Python3 wallaby unit tests  https://review.opendev.org/75093709:46
*** k_mouza_ has joined #openstack-nova09:49
*** k_mouza has quit IRC09:51
*** brinzhang0 has quit IRC09:54
*** brinzhang has joined #openstack-nova09:58
*** Liang__ has quit IRC10:04
openstackgerritBalazs Gibizer proposed openstack/nova master: Cleanup unused code  https://review.opendev.org/75094710:05
admin0hi all .. is there a way to remove a entry from the host list ..like that host is removed and will not be added back10:08
openstackgerritwu.shiming proposed openstack/os-vif master: Remove Babel requirement  https://review.opendev.org/75094810:08
admin0host as in hypervisor10:08
admin0google search lists direct database commands10:09
*** slaweq has joined #openstack-nova10:20
*** StevenK has quit IRC10:21
*** jaosorior has quit IRC10:24
*** jsuchome has quit IRC10:32
*** rcernin has joined #openstack-nova10:39
lyarwoodadmin0: https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/compute-service.html10:39
lyarwoodstephenfin: is the ordering wrong between https://review.opendev.org/#/c/749303/ and https://review.opendev.org/#/c/749304/110:47
lyarwoodstephenfin: actually it doesn't matter10:47
stephenfinI don't think so10:47
stephenfintooling is no use without the driver. Drive doesn't depend on tooling10:47
stephenfinThe driver10:47
lyarwoodstephenfin: oh sorry I thought the driver was using that10:49
lyarwoodstephenfin: so it's just stand alone tooling?10:49
stephenfinafaict yes10:49
lyarwoodah my bad10:49
lyarwoodstephenfin: remind me again, what were we waiting on for https://review.opendev.org/#/c/749308/ to start passing?10:54
*** k_mouza_ has quit IRC10:57
stephenfinlyarwood:10:59
stephenfin<admin0> google search lists direct database commands10:59
stephenfinwhoops10:59
stephenfinlyarwood: https://review.opendev.org/#/c/749527/10:59
stephenfinWell that's needed for the next change. It looks like https://review.opendev.org/#/c/749308/ removes an exception that's still required until the following patch.11:01
stephenfinI'll reshuffle that series later today to put the patches that break tempest to the end, if possible11:01
lyarwoodstephenfin: ack yeah sorry I didn't look into the failure, I just recalled you saying something about tests being borked after a certain point and assumed I had found it ^_^11:02
lyarwoodstephenfin: https://review.opendev.org/#/q/topic:sriov-functional-tests was the other series you wanted reviews on right?11:04
admin0@stephenfin,  thanks .. it worked11:04
admin0@lyarwood, that worked :)11:04
admin0thanks guys11:05
lyarwoodnp11:05
*** sapd1_x has quit IRC11:07
sean-k-mooneywait xenapi is the reason os-agents is a thing. that always confused me since all the agents are listed under os-services11:17
sean-k-mooneyat least when using libvirt11:18
*** StevenK_ has joined #openstack-nova11:19
*** StevenK_ is now known as StevenK11:23
*** k_mouza has joined #openstack-nova11:24
lyarwoodstephenfin: https://review.opendev.org/#/c/746946/ - small nit here, shouldn't you hit the resize API in these tests even if the eventual codepaths are the same at the moment11:29
*** artom has joined #openstack-nova11:31
openstackgerritLee Yarwood proposed openstack/nova stable/rocky: compute: refactor volume bdm rollback error handling  https://review.opendev.org/74922511:43
openstackgerritLee Yarwood proposed openstack/nova stable/rocky: Add regression tests for bug #1889108  https://review.opendev.org/74922611:43
openstackgerritLee Yarwood proposed openstack/nova stable/rocky: compute: Don't delete the original attachment during pre LM rollback  https://review.opendev.org/74922711:43
openstackbug 1889108 in OpenStack Compute (nova) rocky "failures during driver.pre_live_migration remove source attachments during rollback" [Undecided,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood)11:44
*** dave-mccowan has joined #openstack-nova11:45
*** raildo has joined #openstack-nova11:52
openstackgerritLee Yarwood proposed openstack/nova stable/queens: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration  https://review.opendev.org/74797611:54
*** tesseract has quit IRC12:03
openstackgerritLee Yarwood proposed openstack/nova stable/queens: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration  https://review.opendev.org/74797612:05
*** tesseract has joined #openstack-nova12:05
openstackgerritMerged openstack/nova master: virt: Highlight soon-to-be-unused driver APIs  https://review.opendev.org/74930012:19
openstackgerritMerged openstack/nova master: hacking: Stop special casing 'plugins.xenserver'  https://review.opendev.org/74930112:19
stephenfinlyarwood: ah, the name of the test is wrong. It should be test_migrate_server12:19
openstackgerritMerged openstack/nova master: docs: Remove references to XenAPI driver  https://review.opendev.org/74930212:19
openstackgerritMerged openstack/nova master: tools: Remove xenserver tooling  https://review.opendev.org/74930312:19
openstackgerritMerged openstack/nova master: doc: Fix note directives  https://review.opendev.org/75009412:19
openstackgerritMerged openstack/nova master: functional: Provide default 'host_info' for '_get_connection'  https://review.opendev.org/74694212:19
sean-k-mooneystephenfin: by the way sphinx support building docs in parralel  but we dont use it currenlty because some of the sphix extenons we have dont declare supprot for that12:23
sean-k-mooneystephenfin: i think they are ones we/you wrote12:23
stephenfinyup, smcginnis added support for parallel reading/writing to a couple of the oslo.* Sphinx extensions but I don't think we've done any of the in-tree ones12:24
sean-k-mooneyparallel builds are much faster think its worth enabling it and fix/declareing support in the extensions12:24
sean-k-mooneystephenfin: ya some of the tox envs can just run as is12:25
sean-k-mooneyit jsut depens on the extenions used in the tox env12:25
sean-k-mooneyi had a patch locally to just add -j auto to all them but it failed so i abandoned it12:25
sean-k-mooneybut i noticed gibi mentionsed slow pdf doc in a recheck so i was wondering if we wantted to give it a try12:26
gibiI'm hoping that timeout was a one time thing12:27
sean-k-mooneyya i know12:27
sean-k-mooneybut i was building doc for gmann change a few days ago12:27
sean-k-mooneyand i noticed how slow the release note where12:28
sean-k-mooneyso i tried adding -j auto to it and it was way faster12:28
sean-k-mooneythen i was sad when addign it to all the docs env failed because some had extensions that did not declare support12:28
*** ratailor has quit IRC12:29
smcginnisSome of the local tests I did really sped things up running parallel.12:30
smcginnisProbably not as much in gate since there are less available cores, but still faster.12:31
sean-k-mooneyi use a dev vm that emulates the gate with 8 threads12:31
sean-k-mooneyand it was noticable12:31
sean-k-mooneyi say emulates because its got 2 numa node and 2 cpu socket with 2 core and 2 threads per core resulting in 8 thread total12:32
sean-k-mooneyso its not exactly the same but still it was faster12:32
*** nweinber has joined #openstack-nova12:34
*** jangutter_ has joined #openstack-nova12:36
stephenfinweird, looks like the mirrors are not getting updated at the moment12:36
stephenfinthose last few merged patches aren't appearing12:37
*** yingjisun has quit IRC12:39
*** jangutter has quit IRC12:39
openstackgerritStephen Finucane proposed openstack/nova master: functional: Add 'start_compute' helper  https://review.opendev.org/74694312:52
openstackgerritStephen Finucane proposed openstack/nova master: functional: Use tempdir for CONF.instances_path  https://review.opendev.org/74694412:52
openstackgerritStephen Finucane proposed openstack/nova master: functional: Clean up PCI tests  https://review.opendev.org/74694512:52
openstackgerritStephen Finucane proposed openstack/nova master: functional: Add cold migration tests for PCI servers  https://review.opendev.org/74694612:52
openstackgerritStephen Finucane proposed openstack/nova master: conductor: Don't use setattr  https://review.opendev.org/74694712:52
openstackgerritStephen Finucane proposed openstack/nova master: functional: Add test for SR-IOV neutron ports  https://review.opendev.org/74694812:52
openstackgerritStephen Finucane proposed openstack/nova master: fixtures: Handle binding of first port  https://review.opendev.org/74694912:52
openstackgerritStephen Finucane proposed openstack/nova master: functional: Add live migration tests for PCI, SR-IOV servers  https://review.opendev.org/74695012:52
openstackgerritStephen Finucane proposed openstack/nova master: functional: Expand SR-IOV live migration tests with NUMA  https://review.opendev.org/74936012:52
*** derekh has quit IRC12:58
*** mriedem has joined #openstack-nova13:06
openstackgerritStephen Finucane proposed openstack/nova master: xenapi: Remove driver and tests  https://review.opendev.org/74930413:08
openstackgerritStephen Finucane proposed openstack/nova master: virt: Remove 'is_xenapi' helper  https://review.opendev.org/74930513:08
openstackgerritStephen Finucane proposed openstack/nova master: xenapi: Remove Xen-only code paths  https://review.opendev.org/74930613:08
openstackgerritStephen Finucane proposed openstack/nova master: objects: Remove 'XenapiLiveMigrateData'  https://review.opendev.org/74930713:08
openstackgerritStephen Finucane proposed openstack/nova master: trivial: Final cleanup  https://review.opendev.org/74930813:08
openstackgerritStephen Finucane proposed openstack/nova master: virt: Remove 'get_console_pool_info' API  https://review.opendev.org/74931113:08
openstackgerritStephen Finucane proposed openstack/nova master: virt: Remove 'post_interrupted_snapshot_cleanup' API  https://review.opendev.org/74931313:08
openstackgerritStephen Finucane proposed openstack/nova master: virt: Remove 'set_bootable' API  https://review.opendev.org/74931413:08
openstackgerritStephen Finucane proposed openstack/nova master: virt: Remove various aggregate APIs  https://review.opendev.org/74931713:08
openstackgerritStephen Finucane proposed openstack/nova master: virt: Remove 'get_per_instance_usage' API  https://review.opendev.org/74931813:08
openstackgerritStephen Finucane proposed openstack/nova master: api: Remove 'os-agents' API  https://review.opendev.org/74930913:08
openstackgerritStephen Finucane proposed openstack/nova master: objects: Remove Agent, AgentList  https://review.opendev.org/74931013:08
openstackgerritStephen Finucane proposed openstack/nova master: virt: Remove 'get_all_bw_counters' API  https://review.opendev.org/74931213:08
openstackgerritStephen Finucane proposed openstack/nova master: virt: Remove 'reset_network' API  https://review.opendev.org/74931513:09
openstackgerritStephen Finucane proposed openstack/nova master: virt: Remove 'change_instance_metadata' API  https://review.opendev.org/74931613:09
*** priteau has quit IRC13:11
*** sorrison has quit IRC13:14
*** sorrison has joined #openstack-nova13:14
lyarwoodstephenfin: this is not helping my +ratio ^_^13:14
lyarwoodstephenfin: what happened there?13:14
stephenfinlyarwood: https://review.opendev.org/#/c/749304/2/nova/exception.py@1293 :(13:15
stephenfinit should be trivially reapprovable O:)13:15
stephenfinand for the SR-IOV series, see last comment from me on https://review.opendev.org/#/c/746943/13:16
*** priteau has joined #openstack-nova13:16
lyarwoodACK I'll let CI run on both and reapprove once we are sure it's passing13:16
stephenfincool13:17
stephenfinaddressed your comment on https://review.opendev.org/#/c/746946/ too while I was respinning13:17
*** xek has joined #openstack-nova13:18
lyarwoodyup thanks13:19
*** jangutter has joined #openstack-nova13:22
stephenfingibi, lyarwood: One of you want to hit this vTPM doc change real quick? https://review.opendev.org/#/c/750675/13:23
stephenfin(basically note that resize and cold migrate are supported ops now)13:23
lyarwoodyup looking13:24
*** jangutter_ has quit IRC13:25
*** brinzhang_ has joined #openstack-nova13:25
*** brinzhang has quit IRC13:29
*** jangutter_ has joined #openstack-nova13:31
openstackgerritArtom Lifshitz proposed openstack/nova stable/queens: post live migration: don't call Neutron needlessly  https://review.opendev.org/75099313:33
*** jangutter has quit IRC13:34
*** jangutte_ has joined #openstack-nova13:34
*** belmoreira has quit IRC13:36
*** jangutter_ has quit IRC13:37
stephenfinsean-k-mooney: Once this is released, we can turn on parallel builds, afaict https://review.opendev.org/75097313:38
stephenfinI'm not sure about whether we'll need to bump our lower-constraints or not. On one hand, if we add '-j auto' then we'll no longer be able to build docs using the older versions, but on the other hand, docs could still be build (just omit '-j auto')13:39
sean-k-mooneyyes that is what was failing13:41
sean-k-mooneythe feature classification13:41
sean-k-mooneyi could check i might see if we could make it conditional based on the sphinx version13:43
stephenfinah no, I wouldn't go that far13:44
sean-k-mooneyill see what version of sphinx added it13:44
sean-k-mooneyif its not supper new then i think a min version bump would be fine13:45
stephenfinsorry, I wasn't clear. I'm talking about lower-constraints for the various oslo packages plus sphinx-feature-classification13:45
sean-k-mooneyotherwise we can make it configurable via an environmnet varable or just postional arg13:45
sean-k-mooneyoh13:45
sean-k-mooneynot of sphinx build13:45
stephenfinif you tried to build with '-j auto' using sphinx-feature-classification < 1.1.0, it'll fail13:45
sean-k-mooneyyes13:46
stephenfinbecause it emits a warning saying this extension doesn't support parallel stuff13:46
sean-k-mooneyit did13:46
sean-k-mooneyyep13:46
sean-k-mooneyrelease nodes totally works13:46
stephenfinso does that mean we need to set out lower-constraint for s-f-c to 1.1.0?13:46
stephenfinor just assume people building docs with older versions will drop the '-j auto'13:46
sean-k-mooneyya we would in wallaby13:46
sean-k-mooneybe can add -j auto to the other envs13:47
sean-k-mooneythat dont use that already13:47
bauzasgibi: any notes you'd like to see in the prelude ?13:47
gibibauzas: I have nothing specific in my mind right now13:47
gibibut I will do a scan of merged renos to get a view13:48
stephenfinbauzas: have you noted that XenAPI is gone?13:48
stephenfinthat's merging as we spak13:48
stephenfin*speak13:48
bauzasgibi: I'll use your own cycle highlits as a base13:48
bauzasstephenfin: ah, no, gtk13:48
bauzasstephenfin: in general, I take a look at the main reno master page13:48
bauzasso I'll see it, I guess ;)13:48
gibibauzas: cool13:49
sean-k-mooneystephenfin: i started reviewin the xenapi removeal then stop as i realed it mainly just code deletion and lyarwood and gibi? had alredy reviewed most of it13:49
sean-k-mooneyim glad that is going to make it :)13:49
stephenfinsean-k-mooney: you might be interested in https://review.opendev.org/#/c/748533/13:50
sean-k-mooneydidnt i reveiew an previous version13:51
sean-k-mooneyi do need to take another look13:51
stephenfinoh, so you did13:51
stephenfinmy bad13:51
sean-k-mooneyno its good to remind me to look again13:51
stephenfinhttps://review.opendev.org/745605 still needs to be respun too :)13:52
sean-k-mooneyoh the filters13:53
sean-k-mooneyactully ill go do that now13:53
lyarwoodsean-k-mooney: some additional review on these would also be good btw, slightly out of my area tbh https://review.opendev.org/#/c/746949/13:53
lyarwoodartom: ^ also if you have bandwidth13:53
sean-k-mooneyoh the fixture change13:54
*** Luzi has joined #openstack-nova13:54
lyarwoodand the series on top adding the actual tests13:54
sean-k-mooneyam yes are they mergeragbe after today/feature freeze13:54
sean-k-mooneyif so ill do the filter deprecation first then ill take a look at those13:54
lyarwoodah yeah of course sorry13:55
sean-k-mooneyno its fine i really should have reviewd that series properly by now13:56
sean-k-mooneyi have been putting it off13:56
sean-k-mooneymainly for lack of brain power and opertunity to sit down and do it properly13:56
artomlyarwood, ah, yeah, I'm slowly working my way up that series13:57
lyarwoodartom: cool thanks, I was fine with the house keeping stuff up until that point FWIW, I just don't have the context to know if we are asserting the right things in the actual LM tests14:05
artomlyarwood, ack14:07
sean-k-mooneysmcginnis: oh you create the non clinet lib stable branches already14:39
sean-k-mooneythat is  good to know.14:39
sean-k-mooneywe have 2 patches for os-vif to backprot to stable/victoria but they are not merged on master yet and i was going to wait a little while to ensure we dont have any issue before mergeing them anyway14:40
sean-k-mooneybut i guess this means i dont strictly have to wait to rc1 for master to be open for wallaby in os-vif14:40
sean-k-mooneysill going to hold off for a bit however14:41
*** mriedem has left #openstack-nova14:47
smcginnissean-k-mooney: Yep, non-client library freeze was last week. So those are already done for victoria.14:48
smcginnisSneaks up quick.14:49
sean-k-mooneyoh ya i know i am just used to waiting till the main project reach rc1 for the master branch to reopen and stable brances to be created14:53
sean-k-mooneysmcginnis: but creating the branch early also works14:54
*** dklyle has joined #openstack-nova14:54
sean-k-mooneysmcginnis: also its nice to not have to manually do this in gerrit anymore although i guess i have not done that in a few releases at this point14:54
smcginnisUnofficial projects would need to, but anything official should all be going through the releases repo.14:55
sean-k-mooneyyep14:55
*** songwenping_ has joined #openstack-nova14:58
*** songwenping__ has quit IRC15:01
*** jangutter has joined #openstack-nova15:02
*** jangutter has quit IRC15:03
*** jangutter has joined #openstack-nova15:03
*** jangutte_ has quit IRC15:05
*** tbachman_ has joined #openstack-nova15:12
*** tbachman has quit IRC15:13
*** tbachman_ has quit IRC15:17
*** tbachman has joined #openstack-nova15:19
*** mkrai__ has quit IRC15:22
bauzaslyarwood: gibi: we don't have better docs for glance image cloning but a spec ? https://specs.openstack.org/openstack/nova-specs/specs/victoria/approved/nova-image-download-via-rbd.html15:24
*** hongbin has joined #openstack-nova15:25
gibibauzas: there is an open doc patch https://review.opendev.org/#/c/731577/15:26
bauzasuh ok15:27
bauzasgibi: so we have 2 different things related to RBD15:28
bauzasgibi: one is the glance multistore15:28
gibiyes15:28
bauzasthe other being the precaching15:28
gibiyes15:28
bauzashonestly, I'd then write two different bullets15:28
bauzasbecause most ops probably don't give a clue about what a glance multistore is15:28
bauzasand both are independent15:29
bauzasie. you can precache with or without multistore, and the other way too15:29
bauzasdansmith: amirite ?15:29
dansmithprecache in nova has nothing to do with glance multistore15:30
*** jangutter_ has joined #openstack-nova15:30
bauzasthat's what I understood15:30
bauzasthe rbd dowload, that's the precache, right?15:30
dansmithno15:30
bauzasholy shit then15:31
bauzasI'm confused15:31
dansmiththe rbd download thing is just letting nova download the image direct from rbd instead of streaming it through glance, if it has access to the rbd that backs glance15:31
* bauzas only took German as a 3rd foreign language, not volumes15:31
bauzasok, that's what I understood, but then what's precaching ?15:31
bauzasoh15:32
bauzaspulling it to libvirt cache?15:32
bauzaswhether you pull it thru Glance or from the RBD directly15:32
bauzascorrect ?15:32
dansmithyes, just triggering the image cache to download the image, separately from an actual instance boot15:32
bauzasok15:32
bauzasso, what was merged in V ?15:33
*** jangutter has quit IRC15:33
bauzasfrom the notes, I see precaching15:33
bauzasah na15:33
bauzasnvm15:33
dansmithall of that is separate from the glance multistore support in nova :)15:33
bauzasit's RBD download15:33
bauzasprecaching was a U thing15:33
bauzascorrect ?15:33
bauzasU or T, I don't remind exactly15:33
dansmithI think precaching was T yeah15:34
dansmithsorry, U15:34
sean-k-mooneyso the two new things in V are the rbd direct download and seperate the multi store support15:35
dansmithyes, but I'm not sure the rbd download thing is worth a special callout in the release notes, if that's what we're discussing here15:35
sean-k-mooneyin the prelude ya15:35
bauzasdansmith: kk, now I understand, thanks15:36
bauzasyeah, for the prelude, we'll see15:36
bauzaswe don't have a shit ton of new stuff, even a single microversion to provide15:36
bauzasbut I agree, this sounds just a small improvement15:36
bauzasnot worth a prelude15:37
bauzas(even if that went somehow to the cycle highlights :p )15:37
openstackgerritStephen Finucane proposed openstack/nova master: tox: Enable parallel docs build  https://review.opendev.org/75103415:40
*** k_mouza has quit IRC15:41
sean-k-mooneystephenfin: cool i basically only did the tox.ini part of that locally and didnt really know what to do for the extentions15:42
stephenfinsean-k-mooney: it won't work though. oslo.config is borked15:42
stephenfinI've pushed a patch for it but it could be a while before it lands. It's a bug but also not massively high priority15:42
sean-k-mooneyoh so they actully are not parralel safe15:42
stephenfinafraid not15:43
sean-k-mooneyah ok15:43
sean-k-mooneywell ya not super high priority the release notes job does seam to work properly15:43
sean-k-mooneyso maybe we coudl start with that and oter that work and do the rest later15:43
sean-k-mooneybut ya this is just a nice to have15:44
*** Luzi has quit IRC15:44
gibinova meeting will start in 12 minutes on openstack-meeting-315:48
lyarwoodbauzas / elod ; would you mind hitting this for artom please https://review.opendev.org/#/q/topic:bug/1879787+branch:stable/ussuri+status:open15:48
bauzaslyarwood: I can,15:49
bauzasbut rushing up to finish the prelude before the meeting15:49
*** rcernin has quit IRC15:50
*** k_mouza has joined #openstack-nova15:54
artomI'm gonna have to skip the meeting, need lunch before running a time-sensitive errand15:54
gibiartom: ack15:56
gibiartom: enjoy15:56
elodlyarwood: will do after the meeting, if I'm still needed there :)15:56
sean-k-mooneywhat the env argument to get extra loging in func test15:58
sean-k-mooneyis it OS_DEBUG?15:58
artomsean-k-mooney, yarp15:59
artomBut remember that if it passes, nothing is printed15:59
sean-k-mooneyits failing15:59
sean-k-mooneyalso holy crap that a lot of logs15:59
artomOne might say it's a forrest :D16:00
* stephenfin weeps 16:00
bauzassean-k-mooney: OS_DEBUG=116:00
bauzasand asserFalse16:00
bauzasassertFalse(True) if you wanna get'em16:01
bauzasor pdb16:01
sean-k-mooneyyep OS_DEBUG=True tox -e functional -- 1815153 works16:01
sean-k-mooneybut it pring all the db migration too16:01
bauzasright16:01
bauzasI generally pipe the output in a file16:01
bauzas2>&1 | tee myfile16:02
*** mlavalle has joined #openstack-nova16:02
sean-k-mooneyya i think ill send it to lnav or something16:02
bauzasbut most of the time, it's just for debugging purpose and in this case, I pdb directly16:02
bauzasway faster16:02
sean-k-mooneyya so the issue not really simple to pdb debug16:03
*** brinzhang0 has joined #openstack-nova16:03
sean-k-mooneyi mean i can but if im going that far ill proaly just run it in a ide16:03
sean-k-mooneyfor some reason changing form using the az filter to using placement for az is chaning the behviaor fo some tests16:04
*** k_mouza has quit IRC16:04
sean-k-mooneynot in all cases but in like 8 tests16:04
sean-k-mooneywell also the compute status filter16:05
sean-k-mooneythis particalar case is not az related16:05
*** brinzhang_ has quit IRC16:06
*** martinkennelly has quit IRC16:12
openstackgerritStephen Finucane proposed openstack/nova master: WIP: Support old & new versions of svm and vmx traits  https://review.opendev.org/66051516:13
*** k_mouza has joined #openstack-nova16:15
*** martinkennelly has joined #openstack-nova16:15
*** abhishekk has joined #openstack-nova16:17
bauzasstephenfin: can't see xenapi removal notes in https://docs.openstack.org/releasenotes/nova/unreleased.html16:17
bauzasstephenfin: could you please point to me the patch itself ?16:17
stephenfinbauzas: https://review.opendev.org/#/c/749304/ It was approved before I hit a merge conflict and lyarwood is waiting for a green gate before re-approving16:18
bauzasstephenfin: k thanks, I'll proactively add this in the prelude section16:18
bauzasactually, I'll hold on it16:19
*** dtantsur is now known as dtantsur|afk16:22
openstackgerritSylvain Bauza proposed openstack/nova master: Victoria 22.0.0 prelude section  https://review.opendev.org/75104516:27
*** hamalq has joined #openstack-nova16:32
*** artom has quit IRC16:34
openstackgerritMerged openstack/python-novaclient master: Update master for stable/victoria  https://review.opendev.org/75093516:35
bauzasgibi: https://review.opendev.org/75104516:39
bauzasit's a start16:39
gibibauzas: thanks16:39
gibiI will read it tomorrow16:40
* gibi is leaving for today16:41
lyarwood\o16:42
*** k_mouza has quit IRC16:49
sean-k-mooneyso ya there are races in these tests...16:52
sean-k-mooneyspecificlaly looks like we are not waiting for the service to be forced_down before doing the evacuate16:53
sean-k-mooneywe are just calling the api then continuing16:53
*** gyee has joined #openstack-nova17:03
*** k_mouza has joined #openstack-nova17:04
lyarwoodsean-k-mooney: which tests are these?17:08
openstackgerritMerged openstack/nova master: docs: Remove resize, cold migration from vTPM limitations  https://review.opendev.org/75067517:08
lyarwoodoh gate/test_evacuate.sh doesn't wait until the service is down for the first round of evacuations17:10
*** tonyb has quit IRC17:15
openstackgerritMerged openstack/nova master: functional: Add 'start_compute' helper  https://review.opendev.org/74694317:15
openstackgerritMerged openstack/nova master: functional: Use tempdir for CONF.instances_path  https://review.opendev.org/74694417:15
openstackgerritMerged openstack/nova master: functional: Clean up PCI tests  https://review.opendev.org/74694517:16
openstackgerritLuyao Zhong proposed openstack/nova master: Rollback when reset running live migration  https://review.opendev.org/74789917:16
openstackgerritLuyao Zhong proposed openstack/nova master: Improve orphans tracking in resource tracker  https://review.opendev.org/74528217:16
openstackgerritMerged openstack/nova master: functional: Add cold migration tests for PCI servers  https://review.opendev.org/74694617:16
stephenfinsean-k-mooney: did you get that patch reworked?17:21
sean-k-mooneystephenfin: no17:24
sean-k-mooneylyarwood: on sec ill provid the link17:24
sean-k-mooneystephenfin: some of the func test are not correct17:24
sean-k-mooneystephenfin: they are not waiting for palcment to be updated after we set teh comptue service down17:25
*** xek has quit IRC17:25
sean-k-mooneylyarwood: stephenfin https://github.com/openstack/nova/blob/master/nova/tests/functional/regressions/test_bug_1815153.py#L10817:26
sean-k-mooneywe put the service down17:26
sean-k-mooneybut form the debug logs i am not seing us update placment before we then do the migrate or eveacuate in the next test17:26
sean-k-mooneyhttps://review.opendev.org/#/c/654596/8/nova/compute/api.py@5156 should have made the api call update placment17:27
sean-k-mooneyand the tests are using the latest microverion17:28
lyarwoodsean-k-mooney: that's not due to something with the placement fixture?17:29
sean-k-mooneyit might be17:29
sean-k-mooneyim going to mock _update_compute_provider_status17:29
sean-k-mooneyand see if its called17:29
sean-k-mooneybut i dont think it is being called17:29
sean-k-mooneywell i dont see a http request to placment to update the traits17:29
openstackgerritLee Yarwood proposed openstack/nova master: test_evacuate: Wait until subnode is disabled before starting tests  https://review.opendev.org/75106517:29
lyarwoodanyway ^ is what I thought you were talking about, we should be waiting there as well tbh17:30
sean-k-mooneyya so i was debating just pooling for the api to show the service down and sleeping17:31
*** tesseract has quit IRC17:31
sean-k-mooneyi tried runing the periodic task to have update resouce provider un too but it didnt help17:31
sean-k-mooneyi think since the compute service is stopped that is why17:32
sean-k-mooneysince we both stop it and set force down17:32
sean-k-mooneylyarwood: but yes waiting there also makes sense17:33
sean-k-mooneylyarwood: we have similar logic in whitebox now for when we update the config17:33
*** suryasingh has quit IRC17:35
openstackgerritLee Yarwood proposed openstack/nova master: test_evacuate: Wait until subnode is disabled before starting tests  https://review.opendev.org/75106517:35
*** k_mouza has quit IRC17:37
openstackgerritMerged openstack/python-novaclient master: Add Python3 wallaby unit tests  https://review.opendev.org/75093717:44
openstackgerritStephen Finucane proposed openstack/nova master: Support SRIOV interface attach and detach  https://review.opendev.org/74099517:45
openstackgerritStephen Finucane proposed openstack/nova master: Make PCI claim NUMA aware during live migration  https://review.opendev.org/74845317:45
sean-k-mooneyoh this is just doing self.rpcapi.set_host_enabled(context, service.host, enabled)17:49
sean-k-mooneyso the api is relying on the compute node to update it? that cant be right17:50
*** tonyb has joined #openstack-nova17:57
*** manuvakery has quit IRC18:05
*** artom has joined #openstack-nova18:09
*** gmann is now known as gmann_afk18:11
*** artom has quit IRC18:43
openstackgerritMerged openstack/nova master: Move confirm resize under semaphore  https://review.opendev.org/74774518:49
openstackgerritMerged openstack/nova stable/ussuri: Reject resize operation for accelerator  https://review.opendev.org/74970118:52
openstackgerritMerged openstack/nova master: Undeprecate the vmwareapi driver  https://review.opendev.org/74240718:52
openstackgerritMerged openstack/nova stable/ussuri: func: Introduce a server_expected_state kwarg to InstanceHelperMixin._live_migrate  https://review.opendev.org/74652718:52
openstackgerritMerged openstack/nova stable/ussuri: Add regression test for bug 1879787  https://review.opendev.org/74652818:53
openstackbug 1879787 in OpenStack Compute (nova) "post_live_migration does not handle Neutron errors" [Medium,Fix released] https://launchpad.net/bugs/1879787 - Assigned to Artom Lifshitz (notartom)18:53
*** xek has joined #openstack-nova19:07
openstackgerritLee Yarwood proposed openstack/nova master: test_evacuate: Wait until subnode is down before starting tests  https://review.opendev.org/75106519:11
sean-k-mooneylyarwood: oh right force down changes the state field19:15
*** priteau has quit IRC19:16
*** hamalq_ has joined #openstack-nova19:23
*** hamalq has quit IRC19:24
lyarwoodsean-k-mooney: yup my bad19:26
lyarwoodsean-k-mooney: should be correct this time19:26
lyarwoodsean-k-mooney: was going to hack around with the evacuate job anyway this evening19:26
*** ralonsoh has quit IRC19:27
*** yingjisun has joined #openstack-nova19:29
openstackgerritMerged openstack/nova stable/ussuri: post live migration: don't call Neutron needlessly  https://review.opendev.org/75037419:33
*** yingjisun has quit IRC19:43
*** slaweq has quit IRC19:53
*** jangutter has joined #openstack-nova19:53
*** jangutter has quit IRC19:54
*** jangutter_ has quit IRC19:54
*** jangutter has joined #openstack-nova19:54
*** xek has quit IRC20:08
*** nweinber has quit IRC20:10
*** openstackgerrit has quit IRC20:36
*** dklyle has quit IRC20:40
*** david-lyle has joined #openstack-nova20:40
*** artom has joined #openstack-nova20:46
*** david-lyle is now known as dklyle20:56
*** raildo has quit IRC21:30
sean-k-mooneylyarwood: so ya   AssertionError: Expected '_update_compute_provider_status' to have been called once. Called 0 times.21:34
sean-k-mooneyalso i dont think that would wokr anyway but i think there is something up with the fixture21:35
*** mgariepy has quit IRC21:35
sean-k-mooneyself.api.put_service(21:35
sean-k-mooney                source_compute_id, {'forced_down': 'true'})21:35
sean-k-mooneyis not causing that to run21:36
sean-k-mooneyand it should21:36
sean-k-mooneyit might be an issue with the OSAPIFixture21:37
*** mgariepy has joined #openstack-nova21:40
*** vishalmanchanda has quit IRC22:21
*** zzzeek has quit IRC22:26
*** zzzeek has joined #openstack-nova22:27
*** tosky has quit IRC22:42
*** gmann_afk is now known as gmann22:49
*** openstackgerrit has joined #openstack-nova22:54
openstackgerritMerged openstack/nova master: Support SRIOV interface attach and detach  https://review.opendev.org/74099522:54
*** rcernin has joined #openstack-nova22:58
*** rcernin has quit IRC22:59
*** rcernin has joined #openstack-nova22:59
*** mlavalle has quit IRC23:02
sean-k-mooneylyarwood: by the way i figured out what the issue with the test is i think23:10
sean-k-mooneythe test is seting the force donw flag23:11
sean-k-mooneybut its not disabling the service23:11
sean-k-mooneyhttps://github.com/openstack/nova/blob/c57d52e1978210fb3260bf8ea442237d548db576/nova/tests/functional/regressions/test_bug_1815153.py#L105-L10723:11
sean-k-mooneyservice_update is only chekcing for disabled23:13
sean-k-mooneyhttps://github.com/openstack/nova/blob/master/nova/compute/api.py#L582023:13
sean-k-mooneythe compute api also does a call to the compute manager to actully do the placment update23:15
sean-k-mooneyhttps://github.com/openstack/nova/blob/509c01e86d7f1168cf3fc963608b557f65f47f74/nova/compute/api.py#L579823:15
sean-k-mooneyso that also wont work in this case.23:15
sean-k-mooneyso beacuse of this else https://github.com/openstack/nova/blob/6f6b63ee5f7ae180d5f81e61f04332f7aa14f9be/nova/scheduler/filters/compute_filter.py#L43-L47 the ComputeFilter and the compute_status_filter prefilter is not equivlent since the former check both for disable and up were as the later only check for disabled23:21
sean-k-mooneyso if i want to disable the ComputeFilter by default and use the prefilter instead i need to change teh api and periodic task to also chekc the state vaule not just the status.23:22
sean-k-mooneyor rahter check if the serivce is disable or down23:23
sean-k-mooneyand add COMPUTE_STATUS_DISABLED in both cases23:23
sean-k-mooneyor maybe add a COMPUTE_STATUS_DOWN trait too23:23
sean-k-mooneyif we dont want to over load COMPUTE_STATUS_DISABLED23:24
sean-k-mooneyso with that in mind i might undo the deprecation of the compute filter for victoria and just deprecte the az filter since the placment prefilter for that has the same behavior23:24
*** zzzeek has quit IRC23:24
sean-k-mooneyand then fix the compute prefilter behavior in wallaby23:25
sean-k-mooneystephenfin: gibi when ye are awake does ^ make sense to ye23:25
sean-k-mooneyalso sriov attach/detach megered :) that is good23:26
*** zzzeek has joined #openstack-nova23:29
*** tetsuro has joined #openstack-nova23:58
*** zzzeek has quit IRC23:58

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!