brinzhang | gibi: ack, thanks | 00:00 |
---|---|---|
*** martinkennelly has quit IRC | 00:00 | |
*** spatel has quit IRC | 00:04 | |
*** eharney has quit IRC | 00:04 | |
*** artom has quit IRC | 00:07 | |
*** eharney has joined #openstack-nova | 00:07 | |
*** hongbin has quit IRC | 00:10 | |
*** yingjisun has joined #openstack-nova | 00:23 | |
*** LinPeiWen has joined #openstack-nova | 00:31 | |
*** jawad_axd has joined #openstack-nova | 00:34 | |
*** sapd1 has quit IRC | 00:38 | |
*** jawad_axd has quit IRC | 00:38 | |
openstackgerrit | Yao wang proposed openstack/nova master: Use VIR_DOMAIN_XML_INACTIVE for detach volume https://review.opendev.org/749489 | 00:44 |
*** tbachman has joined #openstack-nova | 00:53 | |
openstackgerrit | Yingji Sun proposed openstack/nova stable/train: Set different VirtualDevice.key https://review.opendev.org/752843 | 00:57 |
*** hamalq has quit IRC | 01:01 | |
*** jawad_axd has joined #openstack-nova | 01:15 | |
*** jawad_axd has quit IRC | 01:19 | |
*** gyee has quit IRC | 01:22 | |
*** Liang__ has joined #openstack-nova | 01:32 | |
*** jawad_axd has joined #openstack-nova | 01:36 | |
*** jawad_axd has quit IRC | 01:41 | |
*** eharney has quit IRC | 01:41 | |
*** eharney has joined #openstack-nova | 01:54 | |
*** jawad_axd has joined #openstack-nova | 01:57 | |
*** jawad_axd has quit IRC | 02:01 | |
*** sapd1 has joined #openstack-nova | 02:09 | |
*** songwenping_ has joined #openstack-nova | 02:11 | |
*** songwenping__ has quit IRC | 02:14 | |
*** swp20 has quit IRC | 02:14 | |
*** swp20 has joined #openstack-nova | 02:15 | |
*** songwenping__ has joined #openstack-nova | 02:20 | |
*** songwenping_ has quit IRC | 02:24 | |
*** hamalq has joined #openstack-nova | 02:25 | |
*** spatel has joined #openstack-nova | 02:50 | |
*** zzzeek has quit IRC | 02:51 | |
*** zzzeek has joined #openstack-nova | 02:54 | |
*** spatel has quit IRC | 02:55 | |
*** hongbin has joined #openstack-nova | 03:00 | |
*** spatel has joined #openstack-nova | 03:01 | |
*** spatel has quit IRC | 03:06 | |
*** ratailor has joined #openstack-nova | 03:41 | |
*** aj_mailing has quit IRC | 03:57 | |
*** aj_mailing has joined #openstack-nova | 03:57 | |
*** eharney has quit IRC | 04:10 | |
*** eharney has joined #openstack-nova | 04:23 | |
*** brinzhang_ has joined #openstack-nova | 04:28 | |
*** brinzhang has quit IRC | 04:31 | |
*** evrardjp has quit IRC | 04:33 | |
*** evrardjp has joined #openstack-nova | 04:33 | |
*** brinzhang0 has joined #openstack-nova | 04:36 | |
*** brinzhang_ has quit IRC | 04:39 | |
*** eharney has quit IRC | 05:03 | |
*** rcernin has quit IRC | 05:14 | |
*** hongbin has quit IRC | 05:26 | |
*** rcernin has joined #openstack-nova | 05:34 | |
*** xek has joined #openstack-nova | 05:44 | |
*** Liang__ has quit IRC | 05:48 | |
*** Liang__ has joined #openstack-nova | 05:49 | |
*** zzzeek has quit IRC | 05:54 | |
*** zzzeek has joined #openstack-nova | 05:54 | |
*** vishalmanchanda has joined #openstack-nova | 05:58 | |
*** hamalq has quit IRC | 06:11 | |
*** jsuchome has joined #openstack-nova | 06:14 | |
*** aj_mailing has quit IRC | 06:21 | |
*** zzzeek has quit IRC | 06:26 | |
*** ralonsoh has joined #openstack-nova | 06:28 | |
*** zzzeek has joined #openstack-nova | 06:28 | |
*** martinkennelly has joined #openstack-nova | 06:34 | |
*** xek has quit IRC | 06:38 | |
*** dklyle has quit IRC | 06:56 | |
*** maciejjozefczyk has joined #openstack-nova | 06:57 | |
*** Liang__ has quit IRC | 07:03 | |
*** Liang__ has joined #openstack-nova | 07:07 | |
*** slaweq has joined #openstack-nova | 07:09 | |
*** belmoreira has joined #openstack-nova | 07:10 | |
*** nightmare_unreal has joined #openstack-nova | 07:10 | |
*** links has joined #openstack-nova | 07:13 | |
*** rcernin has quit IRC | 07:13 | |
bauzas | good morning Nova | 07:19 |
*** jawad_axd has joined #openstack-nova | 07:22 | |
*** spatel has joined #openstack-nova | 07:29 | |
*** spatel has quit IRC | 07:34 | |
*** rcernin has joined #openstack-nova | 07:40 | |
*** tosky has joined #openstack-nova | 07:40 | |
lyarwood | Morning | 08:08 |
*** Yumeng has joined #openstack-nova | 08:13 | |
*** jangutter has quit IRC | 08:20 | |
*** jangutter has joined #openstack-nova | 08:21 | |
*** priteau has joined #openstack-nova | 08:24 | |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Improve CinderFixtureNewAttachFlow https://review.opendev.org/749228 | 08:31 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Robustify attachment tracking in CinderFixtureNewAttachFlow https://review.opendev.org/749229 | 08:31 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: compute: Use source_bdms to reset attachment_ids during LM rollback https://review.opendev.org/749230 | 08:31 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: compute: refactor volume bdm rollback error handling https://review.opendev.org/749231 | 08:31 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Add regression tests for bug #1889108 https://review.opendev.org/749232 | 08:31 |
openstack | bug 1889108 in OpenStack Compute (nova) queens "failures during driver.pre_live_migration remove source attachments during rollback" [Undecided,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood) | 08:31 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: compute: Don't delete the original attachment during pre LM rollback https://review.opendev.org/749233 | 08:31 |
lyarwood | https://2733627e1a0348401721-fb543e4b225e8fdb51d174f0fee213a6.ssl.cf1.rackcdn.com/746981/8/check/nova-tox-functional-py38/594be66/testr_results.html - hmm I've never seen this failure before in the gate | 08:34 |
lyarwood | nova.tests.functional.test_cross_cell_migrate.TestMultiCellMigrate.test_delete_while_in_verify_resize_status oslo_messaging.exceptions.MessagingTimeout: No reply on topic conductor | 08:35 |
*** derekh has joined #openstack-nova | 08:35 | |
*** priteau has quit IRC | 08:35 | |
*** jangutter_ has joined #openstack-nova | 08:42 | |
*** jangutte_ has joined #openstack-nova | 08:44 | |
*** jangutter has quit IRC | 08:45 | |
*** jangutter_ has quit IRC | 08:46 | |
*** priteau has joined #openstack-nova | 08:50 | |
nightmare_unreal | Hi , where can I find logs in a devstack machine. I tried /var/log/ but there was no logs there | 08:55 |
*** rcernin has quit IRC | 08:59 | |
*** dtantsur|afk is now known as dtantsur | 09:00 | |
*** rcernin has joined #openstack-nova | 09:00 | |
CeeMac | morning | 09:01 |
*** ratailor has quit IRC | 09:01 | |
CeeMac | regarding nova's roll in volume retyping an attached volume on a running instance | 09:01 |
CeeMac | does the quiesce operation rely on the guest agent being available on the instance, or should it be fully transparent to the instance | 09:02 |
CeeMac | trying to understand an issue with operating system disk corruption on an instance after a volume retype | 09:02 |
openstackgerrit | Stephen Finucane proposed openstack/nova stable/queens: hardware: fix memory check usage for small/large pages https://review.opendev.org/726867 | 09:07 |
openstackgerrit | Stephen Finucane proposed openstack/nova stable/queens: Fix overcommit for NUMA-based instances https://review.opendev.org/726868 | 09:07 |
openstackgerrit | Stephen Finucane proposed openstack/nova stable/queens: Fix typo https://review.opendev.org/753261 | 09:07 |
*** alex_xu has joined #openstack-nova | 09:09 | |
*** ociuhandu has joined #openstack-nova | 09:16 | |
kashyap | stephenfin: --^ That's quick; thanks! | 09:16 |
frickler | nightmare_unreal: most logs are in the systemd journal, try e.g. "journalctl -u devstack@n-api" | 09:16 |
kashyap | (Although, I don't need 'em myself, though) | 09:16 |
*** rcernin has quit IRC | 09:19 | |
nightmare_unreal | thanks frickler | 09:23 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION and NEXT_MIN_{LIBVIRT,QEMU}_VERSION https://review.opendev.org/746981 | 09:30 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_FILE_BACKED_DISCARD_VERSION https://review.opendev.org/746982 | 09:30 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_{LIBVIRT,QEMU}_NATIVE_TLS_VERSION https://review.opendev.org/746983 | 09:30 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_BETTER_SIGKILL_HANDLING https://review.opendev.org/746984 | 09:30 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_VIDEO_MODEL_VERSIONS https://review.opendev.org/746985 | 09:30 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_{LIBVIRT,QEMU}_PMEM_SUPPORT https://review.opendev.org/746986 | 09:30 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: test_evacuate.sh: Stop using libvirt-bin https://review.opendev.org/753267 | 09:30 |
lyarwood | CeeMac: I don't think we quiesce during a retype | 09:30 |
lyarwood | CeeMac: the entire operation should be transparent to the instance | 09:31 |
lyarwood | CeeMac: which version of nova and libvirt is this? | 09:32 |
*** k_mouza has joined #openstack-nova | 09:32 | |
*** links has quit IRC | 09:32 | |
*** yingjisun has quit IRC | 09:39 | |
*** jsuchome has quit IRC | 09:40 | |
CeeMac | Nova v18.1.1, libvirt 4.0.0 | 09:41 |
CeeMac | lyarwood: ^ | 09:41 |
CeeMac | that was my understanding too, but I've had a couple of instance corrupt after retyping the volume and I can't understand why | 09:49 |
*** Liang__ has quit IRC | 10:00 | |
*** links has joined #openstack-nova | 10:06 | |
*** owalsh has quit IRC | 10:15 | |
luyao | stephenfin, alex_xu: Hi, there are 2 patches for vpmem enhencement missed the feature freeze, hope you could review them again if you get time. Thanks. https://review.opendev.org/#/q/topic:bp/vpmem-enhancement+(status:open) | 10:20 |
*** spatel has joined #openstack-nova | 10:21 | |
*** spatel has quit IRC | 10:25 | |
lyarwood | CeeMac: sorry had to go afk, so with libvirt 4.0.0 we should still be using virDomainBlockRebase | 10:30 |
lyarwood | CeeMac: I'd be interested in looking at some example logs if you have any tbh | 10:30 |
lyarwood | CeeMac: if you could use the event list to find the request-id and create a bug for this I can review them | 10:31 |
lyarwood | CeeMac: openstack server event list $instance | 10:31 |
lyarwood | CeeMac: that should list a swap_volume event and associated request-id | 10:31 |
lyarwood | CeeMac: we might also need libvirtd logs from the host if available | 10:31 |
*** suryasingh has joined #openstack-nova | 10:32 | |
CeeMac | lyarwood: I'll see what I can find, not sure I'll get the exact logs for the broken instance as we didn't realise until alter in the day it was an issue | 10:32 |
*** k_mouza has quit IRC | 10:35 | |
*** rcernin has joined #openstack-nova | 10:37 | |
*** rcernin has joined #openstack-nova | 10:37 | |
*** ygk_12345 has joined #openstack-nova | 10:38 | |
brinzhang0 | stephenfin: I seem not understand what would you like to say of https://review.opendev.org/#/c/675304/21/openstackclient/compute/v2/server.py@1868 | 10:40 |
brinzhang0 | and the Line1888, the parsed_args.server can get the server name or id, right? and we have always used it in openstackclient | 10:41 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/ussuri: test_evacuate.sh: Support libvirt-bin and libvirtd systemd services https://review.opendev.org/753280 | 10:44 |
*** k_mouza has joined #openstack-nova | 10:44 | |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/ussuri: test_evacuate.sh: Stop using libvirt-bin https://review.opendev.org/753281 | 10:45 |
lyarwood | elod: ^ if you have time today, https://review.opendev.org/753281 should unblock the nova-live-migration job on stable/ussuri now it's using the train UCA | 10:46 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/ussuri: Ensure source compute is up when confirming a resize https://review.opendev.org/748369 | 10:46 |
*** k_mouza has quit IRC | 10:48 | |
*** k_mouza has joined #openstack-nova | 10:48 | |
elod | lyarwood: sure, I will look at it soon | 10:50 |
*** ratailor has joined #openstack-nova | 10:54 | |
stephenfin | brinzhang0: You can ignore that. I was suggesting something but then realized it wouldn't work | 10:54 |
stephenfin | Leaving the comment there for other reviewers | 10:54 |
brinzhang0 | stephenfin: ack, thanks, I will jump these two comments | 10:55 |
*** Luzi has joined #openstack-nova | 10:55 | |
ygk_12345 | hi all i am using OSA train 20.0.2, but when launching a vm, it is goging into error state with the following erro message | 10:55 |
ygk_12345 | libvirt.libvirtError: Requested operation is not valid: format of backing image '/var/lib/nova/instances/_base/a580bb66b9bb88e1af8354d582ab15a2afba3785' of image '/var/lib/nova/instances/9dd2ab12-f050-4eab-a887-ffc9c4a67dc3/disk' was not specified in the image me | 10:56 |
ygk_12345 | Requested operation is not valid: format of backing image '/var/lib/nova/instances/_base/a580bb66b9bb88e1af8354d582ab15a2afba3785' of image '/var/lib/nova/instances/9dd2ab12-f050-4eab-a887-ffc9c4a67dc3/disk' was not specified in the image metadata (See https://libvirt.org/kbase/backing_chains.html for troubleshooting) | 10:56 |
ygk_12345 | is this a known issue ? | 10:56 |
lyarwood | ygk_12345: yeah with libvirt >= 6.0.0 | 10:57 |
lyarwood | ygk_12345: are you using the train UCA? | 10:57 |
ygk_12345 | lyarwood it is OSA train 20.0.2 version | 10:58 |
lyarwood | ygk_12345: https://review.opendev.org/#/c/710788/ landed in stable train 20.2.0 and should resolve that | 10:59 |
lyarwood | ygk_12345: to be clear that's Nova 20.2.0 | 10:59 |
ygk_12345 | lyarwood so is this fixed in 20.2.0 OSA train version ? | 10:59 |
lyarwood | ygk_12345: it's fixed in the 20.2.0 version of Nova, I have no idea which version of OSA would use that | 11:00 |
ygk_12345 | oh ok | 11:00 |
lyarwood | https://github.com/openstack/nova/releases/tag/20.2.0 | 11:00 |
brinzhang0 | stephenfin: addressed your comments, except above :) thanks | 11:02 |
*** priteau has quit IRC | 11:08 | |
*** yingjisun has joined #openstack-nova | 11:09 | |
*** rcernin has quit IRC | 11:11 | |
*** yingjisun has quit IRC | 11:19 | |
*** mgariepy has quit IRC | 11:22 | |
elod | lyarwood: sorry, just one question: where can we see that we are already using train UCA? Is there a patch for that? | 11:23 |
CeeMac | lyarwood: would it just be the nova-compute logs or the others too you would need extracts from? We had to delete / recreate one of the instances so it'll be tricky tracking back to find the correct request ID for that one sadly but I have another one where only 1 of the disks succeeded in retyping, the other didnt and it is also now dead | 11:23 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Improve CinderFixtureNewAttachFlow https://review.opendev.org/749228 | 11:26 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Robustify attachment tracking in CinderFixtureNewAttachFlow https://review.opendev.org/749229 | 11:26 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: compute: Use source_bdms to reset attachment_ids during LM rollback https://review.opendev.org/749230 | 11:26 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: compute: refactor volume bdm rollback error handling https://review.opendev.org/749231 | 11:26 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Add regression tests for bug #1889108 https://review.opendev.org/749232 | 11:26 |
openstack | bug 1889108 in OpenStack Compute (nova) queens "failures during driver.pre_live_migration remove source attachments during rollback" [Undecided,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood) | 11:26 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: compute: Don't delete the original attachment during pre LM rollback https://review.opendev.org/749233 | 11:26 |
lyarwood | elod: https://review.opendev.org/#/c/752641/ sorry | 11:26 |
lyarwood | elod: I can respin the commit to point to that if you'd like | 11:26 |
lyarwood | CeeMac: nova-compute would be the most useful yes | 11:27 |
elod | lyarwood: no need for that, I just haven't found that :) | 11:27 |
*** ygk_12345 has quit IRC | 11:29 | |
*** ygk_12345 has joined #openstack-nova | 11:35 | |
*** xek has joined #openstack-nova | 11:40 | |
*** owalsh has joined #openstack-nova | 11:42 | |
*** Yumeng has quit IRC | 11:42 | |
*** links has quit IRC | 11:46 | |
*** owalsh has quit IRC | 11:49 | |
*** ratailor has quit IRC | 11:50 | |
CeeMac | lyarwood: where would libvirtd log to by default? | 11:56 |
sean-k-mooney | /var/log/libivrt | 11:57 |
sean-k-mooney | unless you are using ooo | 11:57 |
sean-k-mooney | in which case they are in /var/log/containers/nova/nova_libvirt or something like that | 11:58 |
CeeMac | using osa, will check | 11:59 |
CeeMac | ok, folder is there, which logs in particular? qemu presumably? | 12:00 |
CeeMac | I have libxl, lxc, qemu and uml folders | 12:00 |
lyarwood | CeeMac: libvirtd if you have it | 12:00 |
lyarwood | CeeMac: but it might not be enabled by OSA by default | 12:00 |
lyarwood | CeeMac: libvirtd.log that is | 12:00 |
CeeMac | lyarwood: can't see that one | 12:00 |
CeeMac | i found some things in nova-compute though | 12:01 |
CeeMac | i'll pull a bug together | 12:01 |
CeeMac | is it ok to paste the errors directly in the bug, or you'd prefer a paste url? | 12:01 |
CeeMac | hmm, 100 or so lines, maybe paste url for readability | 12:02 |
lyarwood | yeah pastebins are easier to read | 12:03 |
lyarwood | launchpad-- comments are pretty awful | 12:03 |
sean-k-mooney | you can put it at the end of the bug but paste it better | 12:03 |
sean-k-mooney | lyarwood: you have used bugzilla right :P | 12:03 |
sean-k-mooney | at least launchpad comments dont have conflicts | 12:03 |
CeeMac | no worries, i'll do a paste url :) | 12:03 |
sean-k-mooney | for that alone i forgive much | 12:03 |
*** links has joined #openstack-nova | 12:04 | |
*** owalsh has joined #openstack-nova | 12:07 | |
*** links has quit IRC | 12:12 | |
*** ygk_12345 has quit IRC | 12:14 | |
*** ygk_12345 has joined #openstack-nova | 12:15 | |
lyarwood | sean-k-mooney: yeah rhbz has many faults but the comments are readable and editable now :) | 12:15 |
sean-k-mooney | really even comment 0 | 12:18 |
*** mgariepy has joined #openstack-nova | 12:18 | |
lyarwood | sean-k-mooney: yeah even c#0, landed in the recent upgrade | 12:19 |
sean-k-mooney | well that is progress at least | 12:20 |
*** links has joined #openstack-nova | 12:26 | |
brinzhang0 | hi all, compared to appclient what benefits the introduction of openstacksdk can bring us? | 12:28 |
brinzhang0 | I saw we introduced it, but not used it, if I am not missing some key message | 12:28 |
sean-k-mooney | the sdk would be replacing keystone auth client and then eventrully replcing the other service python clients | 12:29 |
openstackgerrit | Mamduh proposed openstack/os-vif master: Fix - os-vif fails to get the correct UpLink Representor https://review.opendev.org/745895 | 12:29 |
*** sapd1 has quit IRC | 12:29 | |
brinzhang0 | benifit? | 12:30 |
sean-k-mooney | to not need to main tain project sepcicif clients and eventurlaly only have one python sdk with all features | 12:30 |
sean-k-mooney | eventually we will hopefully get rid of python-novaclint | 12:30 |
sean-k-mooney | but we need full parity in osc and sdk first | 12:31 |
*** jhesketh has quit IRC | 12:32 | |
sean-k-mooney | the sdk also papers over some of the interoperablity issue between clouds | 12:32 |
brinzhang0 | yeah, now the sdk cannot support the cli, if we decrapted it, that how to use the command? | 12:32 |
sean-k-mooney | osc can use the sdk if it wants too | 12:32 |
sean-k-mooney | but osc should replace all uses of nova cli eventually | 12:33 |
sean-k-mooney | i wanted to freeze all addtions to nova cli last cycle and require new feature to be added only to osc but others disagreed | 12:33 |
brinzhang0 | yeah, I remembered gibi said, there is still a big gap between osc and novaclient | 12:34 |
sean-k-mooney | yep i dont think we should be widening that by adding new feautres or comands to nova client | 12:34 |
brinzhang0 | sean-k-mooney: if we can required new feature and added the lack of feature to osc, I think it will be good start | 12:35 |
brinzhang0 | *interoperablity issue between clouds* can you give some example? | 12:35 |
*** ygk_12345 has quit IRC | 12:37 | |
sean-k-mooney | the sdk has 3 levels fo apis. 1 is a raw rest client that just handels auth, 1 is driect method for the indigivual apis and the final one is a high level api that abstrct the differnce between say the old glance image import and the new way using the correct one for the cloud its conneccting too | 12:37 |
brinzhang0 | Do we plan to replace the SDK? In W release or X release, or more further? | 12:37 |
*** ygk_12345 has joined #openstack-nova | 12:38 | |
sean-k-mooney | brinzhang0: another example is that the high level api provide a way to look up the ip you can ssh over taking into account floating ips and if the vm is directly connect to an external network | 12:38 |
sean-k-mooney | basically the functionality that shade provided | 12:38 |
sean-k-mooney | brinzhang0: replce the sdk? no adopt the SDK we should in thoery use it any time we need to call an new api in a different service | 12:39 |
sean-k-mooney | brinzhang0: for example we shoudl be interacting with cybrog via the sdk rahter then using a python-cyborgclient | 12:39 |
sean-k-mooney | im pretty sure we already do use the sdk to get a rest client and make direct rest call | 12:40 |
sean-k-mooney | if the sdk had cyborg supprot we would use that instead | 12:40 |
brinzhang0 | oh, that the sdk and novaclient will be all exist in Nova, it means we will maintain two tools | 12:41 |
sean-k-mooney | much of https://github.com/openstack/nova/blob/master/nova/accelerator/cyborg.py could live in the sdk | 12:41 |
sean-k-mooney | not all of it but much of it | 12:41 |
sean-k-mooney | brinzhang0: the sdk is a sperate repo | 12:41 |
sean-k-mooney | not part of nova | 12:41 |
sean-k-mooney | and novaclinet will eventually be deprecated and removed hopefully | 12:42 |
sean-k-mooney | just not in W or likely not in X either | 12:42 |
brinzhang0 | yeah, I know, but if we want to use sdk for the new api call, we need to deploy it, and add the api support in sdk | 12:42 |
sean-k-mooney | sure | 12:42 |
brinzhang0 | yes, now we interactiing with cyborg via cyborgclient | 12:43 |
sean-k-mooney | we do not use cyborgclient | 12:44 |
sean-k-mooney | and we should not | 12:44 |
sean-k-mooney | we use a raw rest client and make json queryies to the cyborg api | 12:45 |
sean-k-mooney | we have our own cyborg client https://github.com/openstack/nova/blob/master/nova/accelerator/cyborg.py#L81 | 12:45 |
sean-k-mooney | but its not the python-cyborgclient | 12:45 |
sean-k-mooney | we never use https://opendev.org/openstack/python-cyborgclient | 12:46 |
sean-k-mooney | and likely never will in nova | 12:46 |
brinzhang0 | sean-k-mooney: oh sorry, when we complete the nova-cyborg interaction we havenot completed the python-cyborgclient, so we cannot use the python-cyborgclient in that time | 12:47 |
sean-k-mooney | right but we also would not use it | 12:47 |
sean-k-mooney | we had already started adopting the sdk | 12:47 |
brinzhang0 | yes | 12:47 |
sean-k-mooney | so we would not add a dep on a new project sepcific client | 12:47 |
sean-k-mooney | we would jsut use the sdk | 12:48 |
brinzhang0 | we can use sdk instead of python-cyborgclient in future | 12:48 |
sean-k-mooney | yep we aldready use the sdk in some places by the way | 12:48 |
sean-k-mooney | anything you see "from openstack" thats using the sdk | 12:48 |
sean-k-mooney | https://github.com/openstack/nova/search?q=%22from+openstack%22 | 12:48 |
sean-k-mooney | or were we use get_sdk_adapter | 12:49 |
sean-k-mooney | that really shoudl be replacing all uses of the keystoneauth adapter eventually | 12:49 |
brinzhang0 | sean-k-mooney: thans, I will see it later :) | 12:50 |
sean-k-mooney | so far we are only using that for placement https://github.com/openstack/nova/blob/b1e34c594bc1b3a8c7c12e033e1e4576270e6be7/nova/scheduler/client/report.py#L231 and ironic https://github.com/openstack/nova/blob/99781d6fa96f7d776612bcd41c94f5b9a3724f3b/nova/virt/ironic/driver.py#L216 | 12:51 |
openstackgerrit | Federico Ressi proposed openstack/nova master: Log stack trace when fails launching a defined domain https://review.opendev.org/750652 | 12:51 |
openstackgerrit | Federico Ressi proposed openstack/nova master: Requires default python3-devel package on CentOS https://review.opendev.org/752073 | 12:52 |
brinzhang0 | I think placement only using sdk interacting with nova, and ironic now used python-ironicclient and sdk in Nova | 12:53 |
*** rcernin has joined #openstack-nova | 12:55 | |
sean-k-mooney | placment only used the sdk yes https://github.com/openstack/nova/commit/2a2379a63cab4414676882c068d25163874cf08e and i think ironic only uses it too https://github.com/openstack/nova/commit/0176390531aa7bba56a12960334be4de2dd409ef | 12:55 |
sean-k-mooney | ya the driver and client wrapper https://github.com/openstack/nova/blob/99781d6fa96f7d776612bcd41c94f5b9a3724f3b/nova/virt/ironic/client_wrapper.py do not import ironic client | 12:56 |
brinzhang0 | sean-k-mooney: yeah, from the code record *yes*, placement and ironic interacting with nova only use sdk | 12:57 |
sean-k-mooney | keep in mind that the openstack sdk and openstack client are not the same thing | 12:59 |
sean-k-mooney | then now are both develoep and maaged via the opesntack-sdks team but they were seperate projects | 12:59 |
brinzhang0 | yeah, got it | 12:59 |
brinzhang0 | sean-k-mooney: In ironic we also inint the client, maybe the ironicclient also available https://github.com/openstack/nova/blob/99781d6fa96f7d776612bcd41c94f5b9a3724f3b/nova/virt/ironic/driver.py#L202 | 13:01 |
sean-k-mooney | that uses the sdk i think | 13:02 |
sean-k-mooney | that nova ironic wrapper | 13:02 |
sean-k-mooney | oh its using importutils https://github.com/openstack/nova/blob/99781d6fa96f7d776612bcd41c94f5b9a3724f3b/nova/virt/ironic/client_wrapper.py#L55-L63 | 13:03 |
*** mgoddard has quit IRC | 13:04 | |
sean-k-mooney | ya so it looks like you are right we have not fully removed the use of ironic client | 13:05 |
brinzhang0 | yes, so the ironicclient still avaliable | 13:05 |
sean-k-mooney | we should do that | 13:05 |
brinzhang0 | yep | 13:05 |
*** mgoddard has joined #openstack-nova | 13:09 | |
*** rcernin has quit IRC | 13:10 | |
*** k_mouza has quit IRC | 13:12 | |
*** k_mouza has joined #openstack-nova | 13:14 | |
*** nweinber has joined #openstack-nova | 13:16 | |
*** jhesketh has joined #openstack-nova | 13:19 | |
openstackgerrit | sean mooney proposed openstack/nova master: libvirt: delegate ovs plug to os-vif https://review.opendev.org/602432 | 13:44 |
*** priteau has joined #openstack-nova | 13:46 | |
sean-k-mooney | ignore ^ for now just updated it to add a depens on against a neutron patch | 13:46 |
*** sapd1 has joined #openstack-nova | 13:49 | |
*** mlavalle has joined #openstack-nova | 13:59 | |
*** lpetrut has joined #openstack-nova | 14:02 | |
*** efried has quit IRC | 14:06 | |
CeeMac | lyarwood: https://bugs.launchpad.net/nova/+bug/1896621 | 14:13 |
openstack | Launchpad bug 1896621 in OpenStack Compute (nova) "instance corrupted after volume retype" [Undecided,New] | 14:13 |
*** artom has joined #openstack-nova | 14:15 | |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: Test for disabling greendns https://review.opendev.org/753072 | 14:19 |
*** efried has joined #openstack-nova | 14:20 | |
artom | dansmith, ^^ brain was fried yesterday, so I decided now leave the improved commit message until this morning | 14:20 |
dansmith | artom: thanks, much better commit message :) | 14:23 |
dansmith | artom: I was thinking yesterday later... is there some reason we shouldn't just slap an early call to nova.monkeypatch in the unit test __init__ file? | 14:24 |
dansmith | we end up patched in the end anyway, right? if we just take the reins and do it as cmd/* does super early, like tests/unit/__init__.py then ... would that do it? | 14:25 |
*** Luzi has quit IRC | 14:25 | |
artom | dansmith, true, worth a try, at any rate | 14:26 |
*** ygk_12345 has quit IRC | 14:26 | |
sean-k-mooney | dansmith: we did at one point i think and then removed it | 14:26 |
sean-k-mooney | https://github.com/openstack/nova/commit/ca1a2c42f5d98983b1fdff60993e6e884787a458 | 14:26 |
dansmith | sean-k-mooney: meaning some time in the past? was there a reason? | 14:27 |
dansmith | hrm | 14:27 |
sean-k-mooney | we indeneted to never need to monkey patch the unit tests | 14:27 |
sean-k-mooney | apparently | 14:27 |
dansmith | so we don't end up patched in the end I guess? | 14:27 |
dansmith | so, there's something else we could do, | 14:27 |
dansmith | which is split monkey_patch() into two things.. one that sets the params and imports eventlet, and one that does the monkey patching (the latter would call the former).. then we could just call the former in unit test init and be able to check for it | 14:28 |
dansmith | that would make our unit tests behave more like real life, if it ever mattered, without changing the monkeypatched-ness | 14:29 |
dansmith | because I was thinking that the rest of our unit tests are apparently running *with* greendns, but our prod code does not, which is a bit wonky | 14:29 |
dansmith | if we split it thusly, | 14:29 |
dansmith | we could also put a call to the set-and-import call in the functional init to make sure those tests also run with eventlet configured in the same way as runtime | 14:30 |
artom | dansmith, to be fair, unit tests should not depend on name resolution... should they? | 14:30 |
*** ygk_12345 has joined #openstack-nova | 14:31 | |
artom | Also, wouldn't that be changing our code to make unit tests happy? | 14:31 |
dansmith | wouldn't what be changing our code? | 14:31 |
*** ygk_12345 has quit IRC | 14:31 | |
artom | Splitting monkey_patch() into 2 | 14:31 |
dansmith | no, because the runtime code would be the same exact thing it is now | 14:31 |
artom | Also, in the case of greendns at least, we kinda need it to be monkeypatched to test it properly | 14:32 |
dansmith | it's totally cool to design code so it's easily testable right? | 14:32 |
artom | True | 14:32 |
artom | In fact, easy unit tests are usually an indication of good design | 14:32 |
dansmith | this is my point.. we're testing all our code with eventlet configured differently than we actually run it with | 14:32 |
dansmith | that's dumb and maybe there shouldn't be any behavior change as a result in the kind of tests we do, but.. there could be | 14:32 |
sean-k-mooney | dansmith: well i think the rational is unittest should never do io | 14:33 |
dansmith | so facilitating testing that it's configured as we expect, and running tests with it configured that way seems pretty sane | 14:33 |
sean-k-mooney | dansmith: so eventlets shoudl never context swtich | 14:33 |
dansmith | sean-k-mooney: sure I understand | 14:33 |
dansmith | sean-k-mooney: but all our functional tests used to be under unit/ and we still have plenty that do ... stuff :) | 14:33 |
artom | Yeah, functional tests definitely write to temp files | 14:34 |
sean-k-mooney | ya but they are monkeypatched | 14:34 |
artom | But then they import nova.monkey_path properly | 14:34 |
sean-k-mooney | the api used to not be monkeypatch in the past if it was run under uwsgi too | 14:34 |
sean-k-mooney | the conductor and comptue agent are always patched | 14:35 |
artom | Is eventlet just there for historical reasons, btw? Have we ever measured performance with and without it? | 14:35 |
dansmith | ? | 14:35 |
sean-k-mooney | had have been since twisted was removed form the code bas although that might predate the conductor. its before i started workign on nova | 14:35 |
dansmith | I forgot it was actually using our monkey patch | 14:35 |
artom | Or are we just so certain eventlet's monkeypatching makes our IO so much faster that we don't bother | 14:36 |
sean-k-mooney | artom: we have some explcit cases where we spawn thing directly too | 14:36 |
sean-k-mooney | its notall implcit | 14:36 |
dansmith | artom: eventlet is not a matter of speed (at all) and all the non-API services require it for doing more than one thing at a time :) | 14:36 |
sean-k-mooney | but i know we have some infinity loops | 14:36 |
*** k_mouza has quit IRC | 14:36 | |
*** dklyle has joined #openstack-nova | 14:36 | |
sean-k-mooney | if you dont patch it will eventually stop worrking | 14:36 |
dansmith | we also have plenty of code that it entirely thread unsafe, and just converting to regular threads will definitely create a million bugs we have to track down :) | 14:37 |
*** dklyle has quit IRC | 14:37 | |
sean-k-mooney | artom: we basically realy on it for coperative processing | 14:37 |
artom | Fair enough | 14:38 |
dansmith | sean-k-mooney: not basically.. we DO rely on it :) | 14:38 |
sean-k-mooney | so unless we used explcit corutines we would not really be able to do things as we do today and even then we woudl need an event loop | 14:38 |
*** jangutte_ is now known as jangutter | 14:38 | |
sean-k-mooney | dansmith: correct me if im wrong but we used twisted in the really realy days instead of eventlet right | 14:39 |
sean-k-mooney | as in pre catus maybe | 14:39 |
dansmith | sean-k-mooney: not that I ever knew.. old RAX stuff did I think , or something | 14:39 |
dansmith | artom: so I just put your test in functional/ and it passes just fine | 14:40 |
sean-k-mooney | maybe not once it was open sourced | 14:40 |
dansmith | because functional runs our monkey_patch routine right? | 14:40 |
dansmith | not sure why we lost sight of this yesterday | 14:40 |
sean-k-mooney | dansmith: its in the functionl test __init__.py | 14:40 |
dansmith | sean-k-mooney: right, I had thought it was doing bare eventlet monkey patching for some reason, but it calls our handler, so I don't see what the problem is | 14:41 |
sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/tests/functional/__init__.py | 14:41 |
artom | dansmith, yeah, I said that last night :) | 14:41 |
artom | In functional it's fine | 14:41 |
sean-k-mooney | no i might of before mdbooth refactored this 3 release ago | 14:41 |
artom | But we'd have to add code similar to osprofiler to skip it with an env var | 14:41 |
sean-k-mooney | yes it did https://github.com/openstack/nova/blame/59f1f187e5dceb5841a711f265280346d70a972b/nova/tests/functional/__init__.py | 14:41 |
artom | (Actually, wait, would we? Don't think we would) | 14:41 |
dansmith | right, which artom eh? | 14:42 |
artom | But... it's not a functional test, is it? | 14:42 |
sean-k-mooney | this https://github.com/openstack/nova/commit/3c5e2b0e9fac985294a949852bb8c83d4ed77e04 reworkd most of our monkey patching | 14:42 |
dansmith | artom: yeah, I'm not getting what you're saying.. in the functional set, we can just run it natively and it will test what we want with that environment as it is already | 14:42 |
artom | dansmith, true | 14:42 |
artom | But... it's not a functional test :) It doesn't start any services, access the DB, etc | 14:43 |
*** k_mouza has joined #openstack-nova | 14:43 | |
dansmith | sean-k-mooney: okay I totally looked at this file yesterday, but maybe I just "saw" the older bare monkey patching and that stuck in my head | 14:43 |
artom | Like, if you want it in there I don't care | 14:43 |
dansmith | artom: you're joking right? | 14:43 |
artom | No? | 14:43 |
dansmith | I think it's fine in functional. | 14:44 |
artom | Sure, I'll move it there | 14:44 |
dansmith | apologies if I missed something previous about that, but I wasn't chatting with you "last night" about this, so maybe I wasn't around when it came up | 14:45 |
artom | dansmith, last afternoon? | 14:45 |
artom | I guess it was morning for you | 14:45 |
dansmith | okay, well, sorry if I missed it | 14:45 |
artom | (Let's be honest, https://i.imgur.com/aWxtlff.jpg is my go-to reaction for this kind of thing :P ) | 14:46 |
*** iurygregory has quit IRC | 14:46 | |
artom | But because I get a chance to prove dansmith publicly wrong (however insignificant the subject actually is), I'll still do it: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2020-09-21.log.html#t2020-09-21T18:48:23 | 14:47 |
dansmith | ah, I see, right at the end | 14:48 |
dansmith | I had pretty much checked out, but I thought you were saying you'd need a way to turn it off and on (which I guess you were) and didn't go back to check or read what you were saying to grasp the reason | 14:48 |
dansmith | ANYWAY | 14:48 |
dansmith | I'd just do it there and then we can be done with it :) | 14:49 |
sean-k-mooney | to defend dansmith that also was not really night :P even in ireland | 14:49 |
dansmith | heh | 14:49 |
sean-k-mooney | by ya lets channel nike and just do it | 14:49 |
artom | sean-k-mooney, you're in no position to lecture people about time of day :P | 14:49 |
sean-k-mooney | :) | 14:49 |
*** iurygregory has joined #openstack-nova | 14:51 | |
*** dklyle has joined #openstack-nova | 14:55 | |
*** abhishekk is now known as abhishekk-afk | 14:55 | |
*** jawad_axd has quit IRC | 14:56 | |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: Test for disabling greendns https://review.opendev.org/753072 | 14:57 |
*** mgariepy has quit IRC | 15:01 | |
openstackgerrit | Merged openstack/nova master: doc: Fix rendering in the accelerator support doc https://review.opendev.org/751574 | 15:11 |
*** belmoreira has quit IRC | 15:21 | |
openstackgerrit | Merged openstack/nova master: doc: correct the link to user/flavor.rst https://review.opendev.org/740176 | 15:22 |
openstackgerrit | Merged openstack/nova master: docs: fix aggregate weight multiplier property names https://review.opendev.org/746128 | 15:27 |
*** abhishekk-afk is now known as abhishekk | 15:35 | |
*** xek has quit IRC | 15:36 | |
*** mgariepy has joined #openstack-nova | 15:43 | |
*** lpetrut has quit IRC | 15:49 | |
*** artom has quit IRC | 15:52 | |
openstackgerrit | Mark Goddard proposed openstack/nova stable/ussuri: docs: fix aggregate weight multiplier property names https://review.opendev.org/753392 | 15:55 |
*** ociuhandu_ has joined #openstack-nova | 15:55 | |
*** ociuhandu has quit IRC | 15:58 | |
*** LinPeiWen has quit IRC | 16:00 | |
*** ociuhandu_ has quit IRC | 16:00 | |
*** irclogbot_0 has quit IRC | 16:08 | |
*** bhagyashri|rover has quit IRC | 16:08 | |
*** irclogbot_3 has joined #openstack-nova | 16:09 | |
*** dosaboy has quit IRC | 16:09 | |
*** bhagyashris has joined #openstack-nova | 16:10 | |
*** sapd1 has quit IRC | 16:11 | |
*** maciejjozefczyk_ has joined #openstack-nova | 16:11 | |
kashyap | Is there a code name for the "x" release yet? I don't see anything on the list ... so presumably no | 16:12 |
*** dosaboy has joined #openstack-nova | 16:13 | |
*** maciejjozefczyk has quit IRC | 16:14 | |
*** sapd1 has joined #openstack-nova | 16:15 | |
*** hamalq has joined #openstack-nova | 16:16 | |
*** jangutter has quit IRC | 16:25 | |
*** redrobot has quit IRC | 16:25 | |
*** jangutter has joined #openstack-nova | 16:25 | |
*** k_mouza has quit IRC | 16:25 | |
*** johnsom has quit IRC | 16:26 | |
*** johnsom has joined #openstack-nova | 16:27 | |
*** k_mouza has joined #openstack-nova | 16:34 | |
*** dtantsur is now known as dtantsur|afk | 16:34 | |
*** k_mouza has quit IRC | 16:38 | |
*** mlavalle has quit IRC | 16:41 | |
*** k_mouza has joined #openstack-nova | 16:42 | |
*** mlavalle has joined #openstack-nova | 16:42 | |
*** k_mouza has quit IRC | 16:46 | |
*** k_mouza has joined #openstack-nova | 16:51 | |
*** derekh has quit IRC | 16:58 | |
*** k_mouza has quit IRC | 17:11 | |
*** aj_mailing has joined #openstack-nova | 17:13 | |
*** xek has joined #openstack-nova | 17:16 | |
*** k_mouza has joined #openstack-nova | 17:18 | |
*** k_mouza has quit IRC | 17:23 | |
*** sapd1 has quit IRC | 17:34 | |
*** aj_mailing has quit IRC | 17:35 | |
*** aj_mailing has joined #openstack-nova | 17:35 | |
*** k_mouza has joined #openstack-nova | 17:37 | |
*** ociuhandu has joined #openstack-nova | 17:38 | |
*** artom has joined #openstack-nova | 17:39 | |
*** ociuhandu has quit IRC | 17:39 | |
*** ociuhandu has joined #openstack-nova | 17:40 | |
*** k_mouza has quit IRC | 17:41 | |
*** hamalq has quit IRC | 17:41 | |
*** ociuhandu has quit IRC | 17:45 | |
*** ralonsoh has quit IRC | 17:46 | |
*** ozzzo has joined #openstack-nova | 17:46 | |
*** k_mouza has joined #openstack-nova | 17:46 | |
*** eharney has joined #openstack-nova | 17:46 | |
*** k_mouza has quit IRC | 17:51 | |
*** maciejjozefczyk_ has quit IRC | 17:52 | |
*** tbachman has quit IRC | 18:07 | |
*** tbachman has joined #openstack-nova | 18:08 | |
*** rouk has joined #openstack-nova | 18:09 | |
*** belmoreira has joined #openstack-nova | 18:14 | |
*** efried has quit IRC | 18:27 | |
*** efried has joined #openstack-nova | 18:33 | |
*** gyee has joined #openstack-nova | 18:34 | |
*** links has quit IRC | 18:44 | |
*** suryasingh has quit IRC | 18:49 | |
*** xek has quit IRC | 18:50 | |
*** JamesBenson has quit IRC | 18:57 | |
*** vishalmanchanda has quit IRC | 18:58 | |
*** zzzeek has quit IRC | 19:08 | |
*** hamalq has joined #openstack-nova | 19:09 | |
*** zzzeek has joined #openstack-nova | 19:09 | |
*** priteau has quit IRC | 19:23 | |
mnaser | kashyap: nope don't think we are there yet :) | 19:32 |
*** tbachman_ has joined #openstack-nova | 20:00 | |
*** tbachman has quit IRC | 20:01 | |
*** tbachman_ is now known as tbachman | 20:01 | |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Fix overcommit for NUMA-based instances https://review.opendev.org/726868 | 20:06 |
*** tbachman_ has joined #openstack-nova | 20:19 | |
*** tbachman has quit IRC | 20:20 | |
*** tbachman_ is now known as tbachman | 20:20 | |
*** maciejjozefczyk_ has joined #openstack-nova | 20:31 | |
*** maciejjozefczyk has joined #openstack-nova | 20:33 | |
*** ociuhandu has joined #openstack-nova | 20:34 | |
*** maciejjozefczyk_ has quit IRC | 20:35 | |
*** belmoreira has quit IRC | 20:40 | |
*** nweinber has quit IRC | 20:40 | |
*** tosky_ has joined #openstack-nova | 21:09 | |
*** k_mouza has joined #openstack-nova | 21:09 | |
*** martinkennelly has quit IRC | 21:10 | |
*** tosky is now known as Guest33200 | 21:10 | |
*** tosky_ is now known as tosky | 21:10 | |
*** eharney has quit IRC | 21:11 | |
*** k_mouza has quit IRC | 21:14 | |
*** slaweq has quit IRC | 21:18 | |
*** rouk has quit IRC | 21:27 | |
*** raildo has quit IRC | 21:43 | |
*** maciejjozefczyk has quit IRC | 21:44 | |
*** spatel has joined #openstack-nova | 21:59 | |
*** spatel has quit IRC | 21:59 | |
*** gmann has quit IRC | 22:04 | |
*** arne_wiebalck has quit IRC | 22:04 | |
*** gregwork has quit IRC | 22:04 | |
*** nicolasbock has quit IRC | 22:04 | |
*** gmann has joined #openstack-nova | 22:05 | |
*** arne_wiebalck has joined #openstack-nova | 22:05 | |
*** nicolasbock has joined #openstack-nova | 22:05 | |
*** gouthamr has quit IRC | 22:06 | |
*** mnaser has quit IRC | 22:06 | |
*** gregwork has joined #openstack-nova | 22:08 | |
*** gouthamr has joined #openstack-nova | 22:09 | |
*** gouthamr has quit IRC | 22:09 | |
*** mnaser has joined #openstack-nova | 22:09 | |
*** gouthamr has joined #openstack-nova | 22:09 | |
*** gouthamr has quit IRC | 22:09 | |
*** gouthamr has joined #openstack-nova | 22:10 | |
*** ociuhandu has quit IRC | 22:46 | |
*** tosky has quit IRC | 22:48 | |
*** rcernin has joined #openstack-nova | 22:55 | |
*** tkajinam has joined #openstack-nova | 22:57 | |
*** mlavalle has quit IRC | 22:57 | |
*** artom has quit IRC | 23:01 | |
*** zzzeek has quit IRC | 23:30 | |
*** zzzeek has joined #openstack-nova | 23:31 | |
*** spatel has joined #openstack-nova | 23:44 | |
*** spatel has quit IRC | 23:49 | |
*** tetsuro has joined #openstack-nova | 23:57 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!