Tuesday, 2020-09-22

brinzhanggibi: ack, thanks00:00
*** martinkennelly has quit IRC00:00
*** spatel has quit IRC00:04
*** eharney has quit IRC00:04
*** artom has quit IRC00:07
*** eharney has joined #openstack-nova00:07
*** hongbin has quit IRC00:10
*** yingjisun has joined #openstack-nova00:23
*** LinPeiWen has joined #openstack-nova00:31
*** jawad_axd has joined #openstack-nova00:34
*** sapd1 has quit IRC00:38
*** jawad_axd has quit IRC00:38
openstackgerritYao wang proposed openstack/nova master: Use VIR_DOMAIN_XML_INACTIVE for detach volume  https://review.opendev.org/74948900:44
*** tbachman has joined #openstack-nova00:53
openstackgerritYingji Sun proposed openstack/nova stable/train: Set different VirtualDevice.key  https://review.opendev.org/75284300:57
*** hamalq has quit IRC01:01
*** jawad_axd has joined #openstack-nova01:15
*** jawad_axd has quit IRC01:19
*** gyee has quit IRC01:22
*** Liang__ has joined #openstack-nova01:32
*** jawad_axd has joined #openstack-nova01:36
*** jawad_axd has quit IRC01:41
*** eharney has quit IRC01:41
*** eharney has joined #openstack-nova01:54
*** jawad_axd has joined #openstack-nova01:57
*** jawad_axd has quit IRC02:01
*** sapd1 has joined #openstack-nova02:09
*** songwenping_ has joined #openstack-nova02:11
*** songwenping__ has quit IRC02:14
*** swp20 has quit IRC02:14
*** swp20 has joined #openstack-nova02:15
*** songwenping__ has joined #openstack-nova02:20
*** songwenping_ has quit IRC02:24
*** hamalq has joined #openstack-nova02:25
*** spatel has joined #openstack-nova02:50
*** zzzeek has quit IRC02:51
*** zzzeek has joined #openstack-nova02:54
*** spatel has quit IRC02:55
*** hongbin has joined #openstack-nova03:00
*** spatel has joined #openstack-nova03:01
*** spatel has quit IRC03:06
*** ratailor has joined #openstack-nova03:41
*** aj_mailing has quit IRC03:57
*** aj_mailing has joined #openstack-nova03:57
*** eharney has quit IRC04:10
*** eharney has joined #openstack-nova04:23
*** brinzhang_ has joined #openstack-nova04:28
*** brinzhang has quit IRC04:31
*** evrardjp has quit IRC04:33
*** evrardjp has joined #openstack-nova04:33
*** brinzhang0 has joined #openstack-nova04:36
*** brinzhang_ has quit IRC04:39
*** eharney has quit IRC05:03
*** rcernin has quit IRC05:14
*** hongbin has quit IRC05:26
*** rcernin has joined #openstack-nova05:34
*** xek has joined #openstack-nova05:44
*** Liang__ has quit IRC05:48
*** Liang__ has joined #openstack-nova05:49
*** zzzeek has quit IRC05:54
*** zzzeek has joined #openstack-nova05:54
*** vishalmanchanda has joined #openstack-nova05:58
*** hamalq has quit IRC06:11
*** jsuchome has joined #openstack-nova06:14
*** aj_mailing has quit IRC06:21
*** zzzeek has quit IRC06:26
*** ralonsoh has joined #openstack-nova06:28
*** zzzeek has joined #openstack-nova06:28
*** martinkennelly has joined #openstack-nova06:34
*** xek has quit IRC06:38
*** dklyle has quit IRC06:56
*** maciejjozefczyk has joined #openstack-nova06:57
*** Liang__ has quit IRC07:03
*** Liang__ has joined #openstack-nova07:07
*** slaweq has joined #openstack-nova07:09
*** belmoreira has joined #openstack-nova07:10
*** nightmare_unreal has joined #openstack-nova07:10
*** links has joined #openstack-nova07:13
*** rcernin has quit IRC07:13
bauzasgood morning Nova07:19
*** jawad_axd has joined #openstack-nova07:22
*** spatel has joined #openstack-nova07:29
*** spatel has quit IRC07:34
*** rcernin has joined #openstack-nova07:40
*** tosky has joined #openstack-nova07:40
lyarwoodMorning08:08
*** Yumeng has joined #openstack-nova08:13
*** jangutter has quit IRC08:20
*** jangutter has joined #openstack-nova08:21
*** priteau has joined #openstack-nova08:24
openstackgerritLee Yarwood proposed openstack/nova stable/queens: Improve CinderFixtureNewAttachFlow  https://review.opendev.org/74922808:31
openstackgerritLee Yarwood proposed openstack/nova stable/queens: Robustify attachment tracking in CinderFixtureNewAttachFlow  https://review.opendev.org/74922908:31
openstackgerritLee Yarwood proposed openstack/nova stable/queens: compute: Use source_bdms to reset attachment_ids during LM rollback  https://review.opendev.org/74923008:31
openstackgerritLee Yarwood proposed openstack/nova stable/queens: compute: refactor volume bdm rollback error handling  https://review.opendev.org/74923108:31
openstackgerritLee Yarwood proposed openstack/nova stable/queens: Add regression tests for bug #1889108  https://review.opendev.org/74923208:31
openstackbug 1889108 in OpenStack Compute (nova) queens "failures during driver.pre_live_migration remove source attachments during rollback" [Undecided,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood)08:31
openstackgerritLee Yarwood proposed openstack/nova stable/queens: compute: Don't delete the original attachment during pre LM rollback  https://review.opendev.org/74923308:31
lyarwoodhttps://2733627e1a0348401721-fb543e4b225e8fdb51d174f0fee213a6.ssl.cf1.rackcdn.com/746981/8/check/nova-tox-functional-py38/594be66/testr_results.html - hmm I've never seen this failure before in the gate08:34
lyarwoodnova.tests.functional.test_cross_cell_migrate.TestMultiCellMigrate.test_delete_while_in_verify_resize_status oslo_messaging.exceptions.MessagingTimeout: No reply on topic conductor08:35
*** derekh has joined #openstack-nova08:35
*** priteau has quit IRC08:35
*** jangutter_ has joined #openstack-nova08:42
*** jangutte_ has joined #openstack-nova08:44
*** jangutter has quit IRC08:45
*** jangutter_ has quit IRC08:46
*** priteau has joined #openstack-nova08:50
nightmare_unrealHi , where can I find logs in a devstack machine. I tried /var/log/ but there was no logs there08:55
*** rcernin has quit IRC08:59
*** dtantsur|afk is now known as dtantsur09:00
*** rcernin has joined #openstack-nova09:00
CeeMacmorning09:01
*** ratailor has quit IRC09:01
CeeMacregarding nova's roll in volume retyping an attached volume on a running instance09:01
CeeMacdoes the quiesce operation rely on the guest agent being available on the instance, or should it be fully transparent to the instance09:02
CeeMactrying to understand an issue with operating system disk corruption on an instance after a volume retype09:02
openstackgerritStephen Finucane proposed openstack/nova stable/queens: hardware: fix memory check usage for small/large pages  https://review.opendev.org/72686709:07
openstackgerritStephen Finucane proposed openstack/nova stable/queens: Fix overcommit for NUMA-based instances  https://review.opendev.org/72686809:07
openstackgerritStephen Finucane proposed openstack/nova stable/queens: Fix typo  https://review.opendev.org/75326109:07
*** alex_xu has joined #openstack-nova09:09
*** ociuhandu has joined #openstack-nova09:16
kashyapstephenfin: --^ That's quick; thanks!09:16
fricklernightmare_unreal: most logs are in the systemd journal, try e.g. "journalctl -u devstack@n-api"09:16
kashyap(Although, I don't need 'em myself, though)09:16
*** rcernin has quit IRC09:19
nightmare_unrealthanks frickler09:23
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION and NEXT_MIN_{LIBVIRT,QEMU}_VERSION  https://review.opendev.org/74698109:30
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_FILE_BACKED_DISCARD_VERSION  https://review.opendev.org/74698209:30
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Remove MIN_{LIBVIRT,QEMU}_NATIVE_TLS_VERSION  https://review.opendev.org/74698309:30
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_BETTER_SIGKILL_HANDLING  https://review.opendev.org/74698409:30
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_VIDEO_MODEL_VERSIONS  https://review.opendev.org/74698509:30
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Remove MIN_{LIBVIRT,QEMU}_PMEM_SUPPORT  https://review.opendev.org/74698609:30
openstackgerritLee Yarwood proposed openstack/nova master: test_evacuate.sh: Stop using libvirt-bin  https://review.opendev.org/75326709:30
lyarwoodCeeMac: I don't think we quiesce during a retype09:30
lyarwoodCeeMac: the entire operation should be transparent to the instance09:31
lyarwoodCeeMac: which version of nova and libvirt is this?09:32
*** k_mouza has joined #openstack-nova09:32
*** links has quit IRC09:32
*** yingjisun has quit IRC09:39
*** jsuchome has quit IRC09:40
CeeMacNova v18.1.1, libvirt 4.0.009:41
CeeMaclyarwood: ^09:41
CeeMacthat was my understanding too, but I've had a couple of instance corrupt after retyping the volume and I can't understand why09:49
*** Liang__ has quit IRC10:00
*** links has joined #openstack-nova10:06
*** owalsh has quit IRC10:15
luyaostephenfin, alex_xu: Hi,  there are  2 patches for vpmem enhencement missed the  feature freeze, hope you could review them again if you get time. Thanks. https://review.opendev.org/#/q/topic:bp/vpmem-enhancement+(status:open)10:20
*** spatel has joined #openstack-nova10:21
*** spatel has quit IRC10:25
lyarwoodCeeMac: sorry had to go afk, so with libvirt 4.0.0 we should still be using virDomainBlockRebase10:30
lyarwoodCeeMac: I'd be interested in looking at some example logs if you have any tbh10:30
lyarwoodCeeMac: if you could use the event list to find the request-id and create a bug for this I can review them10:31
lyarwoodCeeMac: openstack server event list $instance10:31
lyarwoodCeeMac: that should list a swap_volume event and associated request-id10:31
lyarwoodCeeMac: we might also need libvirtd logs from the host if available10:31
*** suryasingh has joined #openstack-nova10:32
CeeMaclyarwood: I'll see what I can find, not sure I'll get the exact logs for the broken instance as we didn't realise until alter in the day it was an issue10:32
*** k_mouza has quit IRC10:35
*** rcernin has joined #openstack-nova10:37
*** rcernin has joined #openstack-nova10:37
*** ygk_12345 has joined #openstack-nova10:38
brinzhang0stephenfin: I seem not understand what would you like to say of https://review.opendev.org/#/c/675304/21/openstackclient/compute/v2/server.py@186810:40
brinzhang0and the Line1888, the parsed_args.server can get the server name or id, right? and we have always used it in openstackclient10:41
openstackgerritLee Yarwood proposed openstack/nova stable/ussuri: test_evacuate.sh: Support libvirt-bin and libvirtd systemd services  https://review.opendev.org/75328010:44
*** k_mouza has joined #openstack-nova10:44
openstackgerritLee Yarwood proposed openstack/nova stable/ussuri: test_evacuate.sh: Stop using libvirt-bin  https://review.opendev.org/75328110:45
lyarwoodelod: ^ if you have time today, https://review.opendev.org/753281 should unblock the nova-live-migration job on stable/ussuri now it's using the train UCA10:46
openstackgerritLee Yarwood proposed openstack/nova stable/ussuri: Ensure source compute is up when confirming a resize  https://review.opendev.org/74836910:46
*** k_mouza has quit IRC10:48
*** k_mouza has joined #openstack-nova10:48
elodlyarwood: sure, I will look at it soon10:50
*** ratailor has joined #openstack-nova10:54
stephenfinbrinzhang0: You can ignore that. I was suggesting something but then realized it wouldn't work10:54
stephenfinLeaving the comment there for other reviewers10:54
brinzhang0stephenfin: ack, thanks, I will jump these two comments10:55
*** Luzi has joined #openstack-nova10:55
ygk_12345hi all i am using OSA train 20.0.2, but when launching a vm, it is goging into error state with the following erro message10:55
ygk_12345 libvirt.libvirtError: Requested operation is not valid: format of backing image '/var/lib/nova/instances/_base/a580bb66b9bb88e1af8354d582ab15a2afba3785' of image '/var/lib/nova/instances/9dd2ab12-f050-4eab-a887-ffc9c4a67dc3/disk' was not specified in the image me10:56
ygk_12345Requested operation is not valid: format of backing image '/var/lib/nova/instances/_base/a580bb66b9bb88e1af8354d582ab15a2afba3785' of image '/var/lib/nova/instances/9dd2ab12-f050-4eab-a887-ffc9c4a67dc3/disk' was not specified in the image metadata (See https://libvirt.org/kbase/backing_chains.html for troubleshooting)10:56
ygk_12345is this a known issue ?10:56
lyarwoodygk_12345: yeah with libvirt >= 6.0.010:57
lyarwoodygk_12345: are you using the train UCA?10:57
ygk_12345lyarwood it is OSA train 20.0.2 version10:58
lyarwoodygk_12345: https://review.opendev.org/#/c/710788/ landed in stable train 20.2.0 and should resolve that10:59
lyarwoodygk_12345: to be clear that's Nova 20.2.010:59
ygk_12345lyarwood so is this fixed in 20.2.0 OSA train version ?10:59
lyarwoodygk_12345: it's fixed in the 20.2.0 version of Nova, I have no idea which version of OSA would use that11:00
ygk_12345oh ok11:00
lyarwoodhttps://github.com/openstack/nova/releases/tag/20.2.011:00
brinzhang0stephenfin: addressed your comments, except above :) thanks11:02
*** priteau has quit IRC11:08
*** yingjisun has joined #openstack-nova11:09
*** rcernin has quit IRC11:11
*** yingjisun has quit IRC11:19
*** mgariepy has quit IRC11:22
elodlyarwood: sorry, just one question: where can we see that we are already using train UCA? Is there a patch for that?11:23
CeeMaclyarwood: would it just be the nova-compute logs or the others too you would need extracts from?  We had to delete / recreate one of the instances so it'll be tricky tracking back to find the correct request ID for  that one sadly but I have another one where only 1 of the disks succeeded in retyping, the other didnt and it is also now dead11:23
openstackgerritLee Yarwood proposed openstack/nova stable/queens: Improve CinderFixtureNewAttachFlow  https://review.opendev.org/74922811:26
openstackgerritLee Yarwood proposed openstack/nova stable/queens: Robustify attachment tracking in CinderFixtureNewAttachFlow  https://review.opendev.org/74922911:26
openstackgerritLee Yarwood proposed openstack/nova stable/queens: compute: Use source_bdms to reset attachment_ids during LM rollback  https://review.opendev.org/74923011:26
openstackgerritLee Yarwood proposed openstack/nova stable/queens: compute: refactor volume bdm rollback error handling  https://review.opendev.org/74923111:26
openstackgerritLee Yarwood proposed openstack/nova stable/queens: Add regression tests for bug #1889108  https://review.opendev.org/74923211:26
openstackbug 1889108 in OpenStack Compute (nova) queens "failures during driver.pre_live_migration remove source attachments during rollback" [Undecided,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood)11:26
openstackgerritLee Yarwood proposed openstack/nova stable/queens: compute: Don't delete the original attachment during pre LM rollback  https://review.opendev.org/74923311:26
lyarwoodelod: https://review.opendev.org/#/c/752641/ sorry11:26
lyarwoodelod: I can respin the commit to point to that if you'd like11:26
lyarwoodCeeMac: nova-compute would be the most useful yes11:27
elodlyarwood: no need for that, I just haven't found that :)11:27
*** ygk_12345 has quit IRC11:29
*** ygk_12345 has joined #openstack-nova11:35
*** xek has joined #openstack-nova11:40
*** owalsh has joined #openstack-nova11:42
*** Yumeng has quit IRC11:42
*** links has quit IRC11:46
*** owalsh has quit IRC11:49
*** ratailor has quit IRC11:50
CeeMaclyarwood: where would libvirtd log to by default?11:56
sean-k-mooney/var/log/libivrt11:57
sean-k-mooneyunless you are using ooo11:57
sean-k-mooneyin which case they are in /var/log/containers/nova/nova_libvirt or something like that11:58
CeeMacusing osa, will check11:59
CeeMacok, folder is there, which logs in particular? qemu presumably?12:00
CeeMacI have libxl, lxc, qemu and uml folders12:00
lyarwoodCeeMac: libvirtd if you have it12:00
lyarwoodCeeMac: but it might not be enabled by OSA by default12:00
lyarwoodCeeMac: libvirtd.log that is12:00
CeeMaclyarwood: can't see that one12:00
CeeMaci found some things in nova-compute though12:01
CeeMaci'll pull a bug together12:01
CeeMacis it ok to paste the errors directly in the bug, or you'd prefer a paste url?12:01
CeeMachmm, 100 or so lines, maybe paste url for readability12:02
lyarwoodyeah pastebins are easier to read12:03
lyarwoodlaunchpad-- comments are pretty awful12:03
sean-k-mooneyyou can put it at the end of the bug but paste it better12:03
sean-k-mooneylyarwood: you have used bugzilla right :P12:03
sean-k-mooneyat least launchpad comments dont have conflicts12:03
CeeMacno worries, i'll do a paste url :)12:03
sean-k-mooneyfor that alone i forgive much12:03
*** links has joined #openstack-nova12:04
*** owalsh has joined #openstack-nova12:07
*** links has quit IRC12:12
*** ygk_12345 has quit IRC12:14
*** ygk_12345 has joined #openstack-nova12:15
lyarwoodsean-k-mooney: yeah rhbz has many faults but the comments are readable and editable now :)12:15
sean-k-mooneyreally even comment 012:18
*** mgariepy has joined #openstack-nova12:18
lyarwoodsean-k-mooney: yeah even c#0, landed in the recent upgrade12:19
sean-k-mooneywell that is progress at least12:20
*** links has joined #openstack-nova12:26
brinzhang0hi all, compared to appclient what benefits the introduction of openstacksdk can bring us?12:28
brinzhang0I saw we introduced it, but not used it, if I am not missing some key message12:28
sean-k-mooneythe sdk would be replacing keystone auth client and then eventrully replcing the other service python clients12:29
openstackgerritMamduh proposed openstack/os-vif master: Fix - os-vif fails to get the correct UpLink Representor  https://review.opendev.org/74589512:29
*** sapd1 has quit IRC12:29
brinzhang0benifit?12:30
sean-k-mooneyto not need to main tain project sepcicif clients and eventurlaly only have one python sdk with all features12:30
sean-k-mooneyeventually we will hopefully get rid of python-novaclint12:30
sean-k-mooneybut we need full parity in osc and sdk first12:31
*** jhesketh has quit IRC12:32
sean-k-mooneythe sdk also papers over some of the interoperablity issue between clouds12:32
brinzhang0yeah, now the sdk cannot support the cli, if we decrapted it, that how to use the command?12:32
sean-k-mooneyosc can use the sdk if it wants too12:32
sean-k-mooneybut osc should replace all uses of nova cli eventually12:33
sean-k-mooneyi wanted to freeze all addtions to nova cli last cycle and require new feature to be added only to osc but others disagreed12:33
brinzhang0yeah, I remembered gibi said, there is still a big gap between osc and novaclient12:34
sean-k-mooneyyep i dont think we should be widening that by adding new feautres or comands to nova client12:34
brinzhang0sean-k-mooney: if we can required new feature and added the lack of feature to osc, I think it will be good start12:35
brinzhang0*interoperablity issue between clouds* can you give some example?12:35
*** ygk_12345 has quit IRC12:37
sean-k-mooneythe sdk has 3 levels fo apis. 1 is a raw rest client that just handels auth, 1 is driect method for the indigivual apis and the final one is a high level api that abstrct the differnce between say the old glance image import and the new way using the correct one for the cloud its conneccting too12:37
brinzhang0Do we plan to replace the SDK? In W release or X release, or more further?12:37
*** ygk_12345 has joined #openstack-nova12:38
sean-k-mooneybrinzhang0: another example is that the high level api provide a way to look up the ip you can ssh over taking into account floating ips and if the vm is directly connect to an external network12:38
sean-k-mooneybasically the functionality that shade provided12:38
sean-k-mooneybrinzhang0: replce the sdk? no adopt the SDK we should in thoery use it any time we need to call an new api in a different service12:39
sean-k-mooneybrinzhang0: for example we shoudl be interacting with cybrog via the sdk rahter then using a python-cyborgclient12:39
sean-k-mooneyim pretty sure we already do use the sdk to get a rest client and make direct rest call12:40
sean-k-mooneyif the sdk had cyborg supprot we would use that instead12:40
brinzhang0oh, that the sdk and novaclient will be all exist in Nova, it means we will maintain two tools12:41
sean-k-mooneymuch of https://github.com/openstack/nova/blob/master/nova/accelerator/cyborg.py could live in the sdk12:41
sean-k-mooneynot all of it but much of it12:41
sean-k-mooneybrinzhang0: the sdk is a sperate repo12:41
sean-k-mooneynot part of nova12:41
sean-k-mooneyand novaclinet will eventually be deprecated and removed hopefully12:42
sean-k-mooneyjust not in W or likely not in X either12:42
brinzhang0yeah, I know, but if we want to use sdk for the new api call, we need to deploy it, and add the api support in sdk12:42
sean-k-mooneysure12:42
brinzhang0yes, now we interactiing with cyborg via cyborgclient12:43
sean-k-mooneywe do not use cyborgclient12:44
sean-k-mooney and we should not12:44
sean-k-mooneywe use a raw rest client and make json queryies to the cyborg api12:45
sean-k-mooneywe have our own cyborg client https://github.com/openstack/nova/blob/master/nova/accelerator/cyborg.py#L8112:45
sean-k-mooneybut its not the python-cyborgclient12:45
sean-k-mooneywe never use https://opendev.org/openstack/python-cyborgclient12:46
sean-k-mooneyand likely never will in nova12:46
brinzhang0sean-k-mooney: oh sorry, when we complete the nova-cyborg interaction we havenot completed the python-cyborgclient, so we cannot use the python-cyborgclient in that time12:47
sean-k-mooneyright but we also would not use it12:47
sean-k-mooneywe had already started adopting the sdk12:47
brinzhang0yes12:47
sean-k-mooneyso we would not add a dep on a new project sepcific client12:47
sean-k-mooneywe would jsut use the sdk12:48
brinzhang0we can use sdk instead of python-cyborgclient in future12:48
sean-k-mooneyyep we aldready use the sdk in some places by the way12:48
sean-k-mooneyanything you see "from openstack" thats using the sdk12:48
sean-k-mooneyhttps://github.com/openstack/nova/search?q=%22from+openstack%2212:48
sean-k-mooneyor were we use get_sdk_adapter12:49
sean-k-mooneythat really shoudl be replacing all uses of the keystoneauth adapter eventually12:49
brinzhang0sean-k-mooney: thans, I will see it later :)12:50
sean-k-mooneyso far we are only using that for placement https://github.com/openstack/nova/blob/b1e34c594bc1b3a8c7c12e033e1e4576270e6be7/nova/scheduler/client/report.py#L231 and ironic https://github.com/openstack/nova/blob/99781d6fa96f7d776612bcd41c94f5b9a3724f3b/nova/virt/ironic/driver.py#L21612:51
openstackgerritFederico Ressi proposed openstack/nova master: Log stack trace when fails launching a defined domain  https://review.opendev.org/75065212:51
openstackgerritFederico Ressi proposed openstack/nova master: Requires default python3-devel package on CentOS  https://review.opendev.org/75207312:52
brinzhang0I think placement only using sdk interacting with nova, and ironic now used python-ironicclient and sdk in Nova12:53
*** rcernin has joined #openstack-nova12:55
sean-k-mooneyplacment only used the sdk yes https://github.com/openstack/nova/commit/2a2379a63cab4414676882c068d25163874cf08e and i think ironic only uses it too https://github.com/openstack/nova/commit/0176390531aa7bba56a12960334be4de2dd409ef12:55
sean-k-mooneyya the driver and client wrapper  https://github.com/openstack/nova/blob/99781d6fa96f7d776612bcd41c94f5b9a3724f3b/nova/virt/ironic/client_wrapper.py do not import ironic client12:56
brinzhang0sean-k-mooney: yeah, from the code record *yes*, placement and ironic interacting with nova only use sdk12:57
sean-k-mooneykeep in mind that the openstack sdk and openstack client are not the same thing12:59
sean-k-mooneythen now are both develoep and maaged via the opesntack-sdks team but they were seperate projects12:59
brinzhang0yeah, got it12:59
brinzhang0sean-k-mooney: In ironic we also inint the client, maybe the ironicclient also available https://github.com/openstack/nova/blob/99781d6fa96f7d776612bcd41c94f5b9a3724f3b/nova/virt/ironic/driver.py#L20213:01
sean-k-mooney that uses the sdk i think13:02
sean-k-mooneythat nova ironic wrapper13:02
sean-k-mooneyoh its using importutils https://github.com/openstack/nova/blob/99781d6fa96f7d776612bcd41c94f5b9a3724f3b/nova/virt/ironic/client_wrapper.py#L55-L6313:03
*** mgoddard has quit IRC13:04
sean-k-mooneyya so it looks like you are right we have not fully removed the use of ironic client13:05
brinzhang0yes, so the ironicclient still avaliable13:05
sean-k-mooneywe should do that13:05
brinzhang0yep13:05
*** mgoddard has joined #openstack-nova13:09
*** rcernin has quit IRC13:10
*** k_mouza has quit IRC13:12
*** k_mouza has joined #openstack-nova13:14
*** nweinber has joined #openstack-nova13:16
*** jhesketh has joined #openstack-nova13:19
openstackgerritsean mooney proposed openstack/nova master: libvirt: delegate ovs plug to os-vif  https://review.opendev.org/60243213:44
*** priteau has joined #openstack-nova13:46
sean-k-mooneyignore ^ for now just updated it to add a depens on against a neutron patch13:46
*** sapd1 has joined #openstack-nova13:49
*** mlavalle has joined #openstack-nova13:59
*** lpetrut has joined #openstack-nova14:02
*** efried has quit IRC14:06
CeeMaclyarwood: https://bugs.launchpad.net/nova/+bug/189662114:13
openstackLaunchpad bug 1896621 in OpenStack Compute (nova) "instance corrupted after volume retype" [Undecided,New]14:13
*** artom has joined #openstack-nova14:15
openstackgerritArtom Lifshitz proposed openstack/nova master: Test for disabling greendns  https://review.opendev.org/75307214:19
*** efried has joined #openstack-nova14:20
artomdansmith, ^^ brain was fried yesterday, so I decided now leave the improved commit message until this morning14:20
dansmithartom: thanks, much better commit message :)14:23
dansmithartom: I was thinking yesterday later... is there some reason we shouldn't just slap an early call to nova.monkeypatch in the unit test __init__ file?14:24
dansmithwe end up patched in the end anyway, right? if we just take the reins and do it as cmd/* does super early, like tests/unit/__init__.py then ... would that do it?14:25
*** Luzi has quit IRC14:25
artomdansmith, true, worth a try, at any rate14:26
*** ygk_12345 has quit IRC14:26
sean-k-mooneydansmith: we did at one point i think and then removed it14:26
sean-k-mooneyhttps://github.com/openstack/nova/commit/ca1a2c42f5d98983b1fdff60993e6e884787a45814:26
dansmithsean-k-mooney: meaning some time in the past? was there a reason?14:27
dansmithhrm14:27
sean-k-mooneywe indeneted to never need to monkey patch the unit tests14:27
sean-k-mooneyapparently14:27
dansmithso we don't end up patched in the end I guess?14:27
dansmithso, there's something else we could do,14:27
dansmithwhich is split monkey_patch() into two things.. one that sets the params and imports eventlet, and one that does the monkey patching (the latter would call the former).. then we could just call the former in unit test init and be able to check for it14:28
dansmiththat would make our unit tests behave more like real life, if it ever mattered, without changing the monkeypatched-ness14:29
dansmithbecause I was thinking that the rest of our unit tests are apparently running *with* greendns, but our prod code does not, which is a bit wonky14:29
dansmithif we split it thusly,14:29
dansmithwe could also put a call to the set-and-import call in the functional init to make sure those tests also run with eventlet configured in the same way as runtime14:30
artomdansmith, to be fair, unit tests should not depend on name resolution... should they?14:30
*** ygk_12345 has joined #openstack-nova14:31
artomAlso, wouldn't that be changing our code to make unit tests happy?14:31
dansmithwouldn't what be changing our code?14:31
*** ygk_12345 has quit IRC14:31
artomSplitting monkey_patch() into 214:31
dansmithno, because the runtime code would be the same exact thing it is now14:31
artomAlso, in the case of greendns at least, we kinda need it to be monkeypatched to test it properly14:32
dansmithit's totally cool to design code so it's easily testable right?14:32
artomTrue14:32
artomIn fact, easy unit tests are usually an indication of good design14:32
dansmiththis is my point.. we're testing all our code with eventlet configured differently than we actually run it with14:32
dansmiththat's dumb and maybe there shouldn't be any behavior change as a result in the kind of tests we do, but.. there could be14:32
sean-k-mooneydansmith: well i think the rational is unittest should never do io14:33
dansmithso facilitating testing that it's configured as we expect, and running tests with it configured that way seems pretty sane14:33
sean-k-mooneydansmith: so eventlets shoudl never context swtich14:33
dansmithsean-k-mooney: sure I understand14:33
dansmithsean-k-mooney: but all our functional tests used to be under unit/ and we still have plenty that do ... stuff :)14:33
artomYeah, functional tests definitely write to temp files14:34
sean-k-mooneyya but they are monkeypatched14:34
artomBut then they import nova.monkey_path properly14:34
sean-k-mooneythe api used to not be monkeypatch in the past if it was run under uwsgi too14:34
sean-k-mooneythe conductor and comptue agent are always patched14:35
artomIs eventlet just there for historical reasons, btw? Have we ever measured performance with and without it?14:35
dansmith?14:35
sean-k-mooneyhad have been since twisted was removed form the code bas although that might predate the conductor. its before i started workign on nova14:35
dansmithI forgot it was actually using our monkey patch14:35
artomOr are we just so certain eventlet's monkeypatching makes our IO so much faster that we don't bother14:36
sean-k-mooneyartom: we have some explcit cases where we spawn thing directly too14:36
sean-k-mooneyits notall implcit14:36
dansmithartom: eventlet is not a matter of speed (at all) and all the non-API services require it for doing more than one thing at a time :)14:36
sean-k-mooneybut i know we have some infinity loops14:36
*** k_mouza has quit IRC14:36
*** dklyle has joined #openstack-nova14:36
sean-k-mooneyif you dont patch it will eventually stop worrking14:36
dansmithwe also have plenty of code that it entirely thread unsafe, and just converting to regular threads will definitely create a million bugs we have to track down :)14:37
*** dklyle has quit IRC14:37
sean-k-mooneyartom: we basically realy on it for coperative processing14:37
artomFair enough14:38
dansmithsean-k-mooney: not basically.. we DO rely on it :)14:38
sean-k-mooneyso unless we used explcit corutines we would not really be able to do things as we do today and even then we woudl need an event loop14:38
*** jangutte_ is now known as jangutter14:38
sean-k-mooneydansmith: correct me if im wrong but we used twisted in the really realy days instead of eventlet right14:39
sean-k-mooneyas in pre catus maybe14:39
dansmithsean-k-mooney: not that I ever knew.. old RAX stuff did I think , or something14:39
dansmithartom: so I just put your test in functional/ and it passes just fine14:40
sean-k-mooneymaybe not once it was open sourced14:40
dansmithbecause functional runs our monkey_patch routine right?14:40
dansmithnot sure why we lost sight of this yesterday14:40
sean-k-mooneydansmith: its in the functionl test __init__.py14:40
dansmithsean-k-mooney: right, I had thought it was doing bare eventlet monkey patching for some reason, but it calls our handler, so I don't see what the problem is14:41
sean-k-mooneyhttps://github.com/openstack/nova/blob/master/nova/tests/functional/__init__.py14:41
artomdansmith, yeah, I said that last night :)14:41
artomIn functional it's fine14:41
sean-k-mooneyno i might of before mdbooth refactored this 3 release ago14:41
artomBut we'd have to add code similar to osprofiler to skip it with an env var14:41
sean-k-mooneyyes it did https://github.com/openstack/nova/blame/59f1f187e5dceb5841a711f265280346d70a972b/nova/tests/functional/__init__.py14:41
artom(Actually, wait, would we? Don't think we would)14:41
dansmithright, which artom eh?14:42
artomBut... it's not a functional test, is it?14:42
sean-k-mooneythis https://github.com/openstack/nova/commit/3c5e2b0e9fac985294a949852bb8c83d4ed77e04 reworkd most of our monkey patching14:42
dansmithartom: yeah, I'm not getting what you're saying.. in the functional set, we can just run it natively and it will test what we want with that environment as it is already14:42
artomdansmith, true14:42
artomBut... it's not a functional test :) It doesn't start any services, access the DB, etc14:43
*** k_mouza has joined #openstack-nova14:43
dansmithsean-k-mooney: okay I totally looked at this file yesterday, but maybe I just "saw" the older bare monkey patching and that stuck in my head14:43
artomLike, if you want it in there I don't care14:43
dansmithartom: you're joking right?14:43
artomNo?14:43
dansmithI think it's fine in functional.14:44
artomSure, I'll move it there14:44
dansmithapologies if I missed something previous about that, but I wasn't chatting with you "last night" about this, so maybe I wasn't around when it came up14:45
artomdansmith, last afternoon?14:45
artomI guess it was morning for you14:45
dansmithokay, well, sorry if I missed it14:45
artom(Let's be honest, https://i.imgur.com/aWxtlff.jpg is my go-to reaction for this kind of thing :P )14:46
*** iurygregory has quit IRC14:46
artomBut because I get a chance to prove dansmith publicly wrong (however insignificant the subject actually is), I'll still do it: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2020-09-21.log.html#t2020-09-21T18:48:2314:47
dansmithah, I see, right at the end14:48
dansmithI had pretty much checked out, but I thought you were saying you'd need a way to turn it off and on (which I guess you were) and didn't go back to check or read what you were saying to grasp the reason14:48
dansmithANYWAY14:48
dansmithI'd just do it there and then we can be done with it :)14:49
sean-k-mooney to defend dansmith that also was not really night :P even in ireland14:49
dansmithheh14:49
sean-k-mooneyby ya lets channel nike and just do it14:49
artomsean-k-mooney, you're in no position to lecture people about time of day :P14:49
sean-k-mooney:)14:49
*** iurygregory has joined #openstack-nova14:51
*** dklyle has joined #openstack-nova14:55
*** abhishekk is now known as abhishekk-afk14:55
*** jawad_axd has quit IRC14:56
openstackgerritArtom Lifshitz proposed openstack/nova master: Test for disabling greendns  https://review.opendev.org/75307214:57
*** mgariepy has quit IRC15:01
openstackgerritMerged openstack/nova master: doc: Fix rendering in the accelerator support doc  https://review.opendev.org/75157415:11
*** belmoreira has quit IRC15:21
openstackgerritMerged openstack/nova master: doc: correct the link to user/flavor.rst  https://review.opendev.org/74017615:22
openstackgerritMerged openstack/nova master: docs: fix aggregate weight multiplier property names  https://review.opendev.org/74612815:27
*** abhishekk-afk is now known as abhishekk15:35
*** xek has quit IRC15:36
*** mgariepy has joined #openstack-nova15:43
*** lpetrut has quit IRC15:49
*** artom has quit IRC15:52
openstackgerritMark Goddard proposed openstack/nova stable/ussuri: docs: fix aggregate weight multiplier property names  https://review.opendev.org/75339215:55
*** ociuhandu_ has joined #openstack-nova15:55
*** ociuhandu has quit IRC15:58
*** LinPeiWen has quit IRC16:00
*** ociuhandu_ has quit IRC16:00
*** irclogbot_0 has quit IRC16:08
*** bhagyashri|rover has quit IRC16:08
*** irclogbot_3 has joined #openstack-nova16:09
*** dosaboy has quit IRC16:09
*** bhagyashris has joined #openstack-nova16:10
*** sapd1 has quit IRC16:11
*** maciejjozefczyk_ has joined #openstack-nova16:11
kashyapIs there a code name for the "x" release yet?  I don't see anything on the list ... so presumably no16:12
*** dosaboy has joined #openstack-nova16:13
*** maciejjozefczyk has quit IRC16:14
*** sapd1 has joined #openstack-nova16:15
*** hamalq has joined #openstack-nova16:16
*** jangutter has quit IRC16:25
*** redrobot has quit IRC16:25
*** jangutter has joined #openstack-nova16:25
*** k_mouza has quit IRC16:25
*** johnsom has quit IRC16:26
*** johnsom has joined #openstack-nova16:27
*** k_mouza has joined #openstack-nova16:34
*** dtantsur is now known as dtantsur|afk16:34
*** k_mouza has quit IRC16:38
*** mlavalle has quit IRC16:41
*** k_mouza has joined #openstack-nova16:42
*** mlavalle has joined #openstack-nova16:42
*** k_mouza has quit IRC16:46
*** k_mouza has joined #openstack-nova16:51
*** derekh has quit IRC16:58
*** k_mouza has quit IRC17:11
*** aj_mailing has joined #openstack-nova17:13
*** xek has joined #openstack-nova17:16
*** k_mouza has joined #openstack-nova17:18
*** k_mouza has quit IRC17:23
*** sapd1 has quit IRC17:34
*** aj_mailing has quit IRC17:35
*** aj_mailing has joined #openstack-nova17:35
*** k_mouza has joined #openstack-nova17:37
*** ociuhandu has joined #openstack-nova17:38
*** artom has joined #openstack-nova17:39
*** ociuhandu has quit IRC17:39
*** ociuhandu has joined #openstack-nova17:40
*** k_mouza has quit IRC17:41
*** hamalq has quit IRC17:41
*** ociuhandu has quit IRC17:45
*** ralonsoh has quit IRC17:46
*** ozzzo has joined #openstack-nova17:46
*** k_mouza has joined #openstack-nova17:46
*** eharney has joined #openstack-nova17:46
*** k_mouza has quit IRC17:51
*** maciejjozefczyk_ has quit IRC17:52
*** tbachman has quit IRC18:07
*** tbachman has joined #openstack-nova18:08
*** rouk has joined #openstack-nova18:09
*** belmoreira has joined #openstack-nova18:14
*** efried has quit IRC18:27
*** efried has joined #openstack-nova18:33
*** gyee has joined #openstack-nova18:34
*** links has quit IRC18:44
*** suryasingh has quit IRC18:49
*** xek has quit IRC18:50
*** JamesBenson has quit IRC18:57
*** vishalmanchanda has quit IRC18:58
*** zzzeek has quit IRC19:08
*** hamalq has joined #openstack-nova19:09
*** zzzeek has joined #openstack-nova19:09
*** priteau has quit IRC19:23
mnaserkashyap: nope don't think we are there yet :)19:32
*** tbachman_ has joined #openstack-nova20:00
*** tbachman has quit IRC20:01
*** tbachman_ is now known as tbachman20:01
openstackgerritLee Yarwood proposed openstack/nova stable/queens: Fix overcommit for NUMA-based instances  https://review.opendev.org/72686820:06
*** tbachman_ has joined #openstack-nova20:19
*** tbachman has quit IRC20:20
*** tbachman_ is now known as tbachman20:20
*** maciejjozefczyk_ has joined #openstack-nova20:31
*** maciejjozefczyk has joined #openstack-nova20:33
*** ociuhandu has joined #openstack-nova20:34
*** maciejjozefczyk_ has quit IRC20:35
*** belmoreira has quit IRC20:40
*** nweinber has quit IRC20:40
*** tosky_ has joined #openstack-nova21:09
*** k_mouza has joined #openstack-nova21:09
*** martinkennelly has quit IRC21:10
*** tosky is now known as Guest3320021:10
*** tosky_ is now known as tosky21:10
*** eharney has quit IRC21:11
*** k_mouza has quit IRC21:14
*** slaweq has quit IRC21:18
*** rouk has quit IRC21:27
*** raildo has quit IRC21:43
*** maciejjozefczyk has quit IRC21:44
*** spatel has joined #openstack-nova21:59
*** spatel has quit IRC21:59
*** gmann has quit IRC22:04
*** arne_wiebalck has quit IRC22:04
*** gregwork has quit IRC22:04
*** nicolasbock has quit IRC22:04
*** gmann has joined #openstack-nova22:05
*** arne_wiebalck has joined #openstack-nova22:05
*** nicolasbock has joined #openstack-nova22:05
*** gouthamr has quit IRC22:06
*** mnaser has quit IRC22:06
*** gregwork has joined #openstack-nova22:08
*** gouthamr has joined #openstack-nova22:09
*** gouthamr has quit IRC22:09
*** mnaser has joined #openstack-nova22:09
*** gouthamr has joined #openstack-nova22:09
*** gouthamr has quit IRC22:09
*** gouthamr has joined #openstack-nova22:10
*** ociuhandu has quit IRC22:46
*** tosky has quit IRC22:48
*** rcernin has joined #openstack-nova22:55
*** tkajinam has joined #openstack-nova22:57
*** mlavalle has quit IRC22:57
*** artom has quit IRC23:01
*** zzzeek has quit IRC23:30
*** zzzeek has joined #openstack-nova23:31
*** spatel has joined #openstack-nova23:44
*** spatel has quit IRC23:49
*** tetsuro has joined #openstack-nova23:57

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!