*** k_mouza has quit IRC | 00:04 | |
*** freenzyfriday has joined #openstack-nova | 00:12 | |
*** freenzyfriday has quit IRC | 00:16 | |
*** k_mouza has joined #openstack-nova | 00:22 | |
*** spatel has joined #openstack-nova | 00:23 | |
*** k_mouza has quit IRC | 00:26 | |
*** spatel has quit IRC | 00:28 | |
*** k_mouza has joined #openstack-nova | 00:32 | |
*** hamalq has quit IRC | 00:32 | |
*** k_mouza has quit IRC | 00:36 | |
*** LinPeiWen has joined #openstack-nova | 00:40 | |
*** JamesBenson has quit IRC | 00:42 | |
*** JamesBenson has joined #openstack-nova | 00:43 | |
*** brinzhang has joined #openstack-nova | 00:44 | |
*** JamesBenson has quit IRC | 00:47 | |
*** yankcrime has quit IRC | 00:53 | |
*** hemna has quit IRC | 00:56 | |
*** hemna has joined #openstack-nova | 00:57 | |
*** freenzyfriday has joined #openstack-nova | 01:10 | |
*** zzzeek has quit IRC | 01:10 | |
*** Liang__ has joined #openstack-nova | 01:10 | |
*** zzzeek has joined #openstack-nova | 01:11 | |
*** k_mouza has joined #openstack-nova | 01:13 | |
*** freenzyfriday has quit IRC | 01:15 | |
*** k_mouza has quit IRC | 01:17 | |
*** JamesBenson has joined #openstack-nova | 01:20 | |
*** JamesBenson has quit IRC | 01:24 | |
*** k_mouza has joined #openstack-nova | 01:26 | |
*** k_mouza has quit IRC | 01:30 | |
*** LinPeiWen has quit IRC | 01:46 | |
*** k_mouza has joined #openstack-nova | 01:57 | |
*** k_mouza has quit IRC | 02:01 | |
*** k_mouza has joined #openstack-nova | 02:23 | |
*** k_mouza has quit IRC | 02:27 | |
*** JamesBenson has joined #openstack-nova | 02:30 | |
*** JamesBenson has quit IRC | 02:34 | |
*** k_mouza has joined #openstack-nova | 02:51 | |
*** freenzyfriday has joined #openstack-nova | 02:55 | |
*** k_mouza has quit IRC | 02:55 | |
*** LinPeiWen has joined #openstack-nova | 02:59 | |
*** freenzyfriday has quit IRC | 03:04 | |
*** JamesBenson has joined #openstack-nova | 03:05 | |
*** psachin has joined #openstack-nova | 03:07 | |
*** JamesBenson has quit IRC | 03:10 | |
*** rcernin has quit IRC | 03:17 | |
*** macz_ has joined #openstack-nova | 03:22 | |
*** macz_ has quit IRC | 03:26 | |
*** psachin has quit IRC | 03:40 | |
*** psachin has joined #openstack-nova | 03:41 | |
*** freenzyfriday has joined #openstack-nova | 03:49 | |
*** freenzyfriday has quit IRC | 03:54 | |
*** rcernin has joined #openstack-nova | 03:55 | |
*** rcernin has quit IRC | 03:56 | |
*** rcernin has joined #openstack-nova | 04:03 | |
*** pmannidi has quit IRC | 04:16 | |
*** mpsairam has joined #openstack-nova | 04:16 | |
*** manoj_kumar_kata has joined #openstack-nova | 04:18 | |
*** evrardjp has quit IRC | 04:33 | |
*** evrardjp has joined #openstack-nova | 04:33 | |
*** vishalmanchanda has joined #openstack-nova | 04:35 | |
*** freenzyfriday has joined #openstack-nova | 04:43 | |
*** freenzyfriday has quit IRC | 04:53 | |
*** whoami-rajat__ has joined #openstack-nova | 05:02 | |
*** zzzeek has quit IRC | 05:02 | |
*** zzzeek has joined #openstack-nova | 05:05 | |
*** ratailor has joined #openstack-nova | 05:07 | |
*** manoj_kumar_kata has quit IRC | 05:25 | |
*** freenzyfriday has joined #openstack-nova | 05:38 | |
*** zzzeek has quit IRC | 05:42 | |
*** zzzeek has joined #openstack-nova | 05:43 | |
*** freenzyfriday has quit IRC | 05:43 | |
*** rpittau|afk is now known as rpittau | 05:43 | |
*** brinzhang_ has joined #openstack-nova | 05:52 | |
*** brinzhang has quit IRC | 05:55 | |
*** manoj_kumar_kata has joined #openstack-nova | 06:05 | |
*** LinPeiWen has quit IRC | 06:11 | |
*** zzzeek has quit IRC | 06:11 | |
*** zzzeek has joined #openstack-nova | 06:12 | |
*** LinPeiWen has joined #openstack-nova | 06:15 | |
*** LinPeiWen has quit IRC | 06:23 | |
*** freenzyfriday has joined #openstack-nova | 06:32 | |
*** songwenping_ has joined #openstack-nova | 06:38 | |
*** freenzyfriday has quit IRC | 06:41 | |
*** songwenping__ has quit IRC | 06:42 | |
*** tkajinam has quit IRC | 06:42 | |
*** tkajinam has joined #openstack-nova | 06:42 | |
*** freenzyfriday has joined #openstack-nova | 06:45 | |
*** jobewan has quit IRC | 06:46 | |
*** jobewan has joined #openstack-nova | 06:48 | |
*** tesseract has joined #openstack-nova | 06:59 | |
*** ralonsoh has joined #openstack-nova | 06:59 | |
*** slaweq has joined #openstack-nova | 07:38 | |
*** rcernin has quit IRC | 07:45 | |
*** tosky has joined #openstack-nova | 07:46 | |
*** sapd1 has joined #openstack-nova | 07:50 | |
*** k_mouza has joined #openstack-nova | 08:20 | |
*** whoami-rajat__ has quit IRC | 08:21 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ignore PCI devices with 32bit domain https://review.opendev.org/756697 | 08:26 |
---|---|---|
*** derekh has joined #openstack-nova | 08:28 | |
*** k_mouza_ has joined #openstack-nova | 08:28 | |
*** k_mouza has quit IRC | 08:31 | |
*** LinPeiWen has joined #openstack-nova | 08:36 | |
*** dtantsur|afk is now known as dtantsur | 08:44 | |
*** ociuhandu has joined #openstack-nova | 08:51 | |
*** hemna_ has joined #openstack-nova | 09:00 | |
*** hemna has quit IRC | 09:00 | |
*** LinPeiWen has quit IRC | 09:05 | |
lyarwood | stephenfin: image defined bdms | 09:06 |
lyarwood | stephenfin: block_device_mappings in the image metadata or something else? | 09:06 |
lyarwood | stephenfin: oh img_mappings | 09:06 |
lyarwood | stephenfin: I didn't think we used it anymore tbh | 09:09 |
lyarwood | stephenfin: I'll take a better look later today | 09:09 |
*** manoj_kumar_kata has quit IRC | 09:14 | |
*** manoj_kumar_kata has joined #openstack-nova | 09:14 | |
*** LinPeiWen has joined #openstack-nova | 09:28 | |
*** yankcrime has joined #openstack-nova | 09:32 | |
*** takamatsu has joined #openstack-nova | 09:37 | |
*** manoj_kumar_kata has quit IRC | 09:40 | |
*** manoj_kumar_kata has joined #openstack-nova | 09:40 | |
openstackgerrit | wangzhh proposed openstack/nova master: Ignore InstanceNotFound exception when host rejoin cluster https://review.opendev.org/757053 | 09:41 |
*** Liang__ has quit IRC | 09:57 | |
sean-k-mooney | lyarwood: we use it here https://github.com/openstack/nova/blob/9fa563666e8500510def19269f740d99cab0e994/nova/compute/api.py#L833-L856 | 10:21 |
sean-k-mooney | which is used here https://github.com/openstack/nova/blob/9fa563666e8500510def19269f740d99cab0e994/nova/compute/api.py#L907 | 10:23 |
lyarwood | sean-k-mooney: right we use block_device_mapping, I don't think we use img_mappings anywhere | 10:25 |
sean-k-mooney | we do | 10:25 |
sean-k-mooney | https://github.com/openstack/nova/blob/9fa563666e8500510def19269f740d99cab0e994/nova/compute/api.py#L933-L934 | 10:25 |
sean-k-mooney | we merge the image mappings with the block device mappings | 10:26 |
sean-k-mooney | before we append the flavor mappings | 10:26 |
sean-k-mooney | so right now we get the mappigns form the commandline the falvaor and iamge and merge them all together | 10:26 |
lyarwood | right but I still don't see any code looking up img_mappings | 10:27 |
sean-k-mooney | this does it https://github.com/openstack/nova/blob/9fa563666e8500510def19269f740d99cab0e994/nova/compute/api.py#L907-L908 | 10:27 |
sean-k-mooney | https://github.com/openstack/nova/blob/9fa563666e8500510def19269f740d99cab0e994/nova/compute/api.py#L841 | 10:27 |
lyarwood | sean-k-mooney: mappings != img_mappings | 10:28 |
sean-k-mooney | in the ovo we store "img_mappings" in the "mappings" field | 10:28 |
lyarwood | sean-k-mooney: that's my point | 10:28 |
sean-k-mooney | lyarwood:yes it is | 10:28 |
sean-k-mooney | https://github.com/openstack/nova/blob/f24e054f5e41dcf45b7ecd20e6d41f4a293a91d2/nova/objects/image_meta.py#L555 | 10:29 |
sean-k-mooney | img_mappings is the legacy name for mappings | 10:29 |
sean-k-mooney | we coalese it and store it in mappings | 10:29 |
lyarwood | mappings is the legacy name | 10:30 |
sean-k-mooney | actully i guess its the other way around | 10:30 |
sean-k-mooney | ok well the lookup should still work | 10:30 |
sean-k-mooney | we are using mappings which will retrun the same valuse as img_mappings | 10:30 |
sean-k-mooney | because of https://github.com/openstack/nova/blob/f24e054f5e41dcf45b7ecd20e6d41f4a293a91d2/nova/objects/image_meta.py#L565-L572 | 10:31 |
lyarwood | I guess the lookup is defined elsewhere? | 10:31 |
sean-k-mooney | actully that the set where is the get | 10:31 |
lyarwood | yeah | 10:32 |
sean-k-mooney | oh we just have it for set so when we build it we set it with the new name | 10:32 |
sean-k-mooney | the get is https://github.com/openstack/nova/blob/f24e054f5e41dcf45b7ecd20e6d41f4a293a91d2/nova/objects/image_meta.py#L657-L685 | 10:33 |
lyarwood | but https://github.com/openstack/nova/blob/9fa563666e8500510def19269f740d99cab0e994/nova/compute/api.py#L841 is specifically using the older name so that's always None | 10:33 |
sean-k-mooney | so is if from here https://github.com/openstack/nova/blob/9fa563666e8500510def19269f740d99cab0e994/nova/compute/api.py#L843-L845 | 10:34 |
sean-k-mooney | not looking at the img_mappings would be a bug unless we had an explict deprecation of this fucntionaliy | 10:37 |
lyarwood | I'm still not entirely sure what it is the dict provides tbh, looking for an example | 10:38 |
lyarwood | virtual image names to device names | 10:39 |
sean-k-mooney | i think you could pass anything you can pass in bdm on the commandline | 10:40 |
lyarwood | no that's stored in block_device_mapping or bdm_v2 | 10:41 |
lyarwood | this is simple dict of things like {'root': '/dev/vda'} AFAICT | 10:41 |
lyarwood | https://github.com/openstack/nova/blob/4cf72ea6bfc58d33da894f248184c08c36055884/nova/block_device.py#L538-L588 | 10:42 |
sean-k-mooney | i see in that case im less concerned | 10:42 |
sean-k-mooney | we dont provide stable/usersetable device names really anyway | 10:43 |
*** tbachman has quit IRC | 10:43 | |
lyarwood | yup I wonder what this is actually used for tbh | 10:43 |
sean-k-mooney | https://github.com/openstack/nova/blob/f24e054f5e41dcf45b7ecd20e6d41f4a293a91d2/nova/objects/image_meta.py#L454-L460 | 10:44 |
sean-k-mooney | it looks like it was never tested when we did the conversion | 10:46 |
sean-k-mooney | to ovos | 10:46 |
lyarwood | yeah we should get everything we need from img_block_device_mapping / block_device_mapping | 10:47 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Lock by instance.uuid lock during swap_volume https://review.opendev.org/754695 | 10:48 |
*** priteau has joined #openstack-nova | 10:50 | |
*** rcernin has joined #openstack-nova | 10:50 | |
*** zzzeek has quit IRC | 10:52 | |
*** zzzeek has joined #openstack-nova | 10:54 | |
*** zzzeek has quit IRC | 11:17 | |
*** zzzeek has joined #openstack-nova | 11:18 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: Include removal of ephemeral backing files in the image cache manager https://review.opendev.org/689422 | 11:24 |
*** rcernin has quit IRC | 11:31 | |
*** ratailor_ has joined #openstack-nova | 11:33 | |
*** hemna_ has quit IRC | 11:33 | |
*** hemna has joined #openstack-nova | 11:34 | |
*** ratailor has quit IRC | 11:34 | |
*** psachin has quit IRC | 11:34 | |
*** ttx has quit IRC | 11:34 | |
*** jamesdenton has quit IRC | 11:34 | |
*** ttx has joined #openstack-nova | 11:36 | |
*** scanepa has joined #openstack-nova | 11:38 | |
*** psachin has joined #openstack-nova | 11:40 | |
*** jamesdenton has joined #openstack-nova | 11:40 | |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/ussuri: Use absolute path during qemu img rebase https://review.opendev.org/757083 | 11:58 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: Use absolute path during qemu img rebase https://review.opendev.org/757084 | 11:59 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: Use absolute path during qemu img rebase https://review.opendev.org/757085 | 11:59 |
*** sapd1 has quit IRC | 12:01 | |
*** slaweq has quit IRC | 12:03 | |
*** slaweq has joined #openstack-nova | 12:17 | |
*** freenzyfriday has quit IRC | 12:26 | |
*** psachin has quit IRC | 12:31 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Add image metadata property reference guide https://review.opendev.org/756867 | 12:48 |
stephenfin | lyarwood: Context on that img_mappings question was ^ I was trying to document what it was for and remove it if it wasn't necessary. I resorted to marking it as internal only and kicking the can down the road :-) | 12:49 |
stephenfin | though it sounds like you and sean-k-mooney might have teased it out, /me reads back up | 12:49 |
lyarwood | stephenfin: yeah tbh I don't think it's being used given what we were talking about above | 12:50 |
lyarwood | brb | 12:50 |
stephenfin | sean-k-mooney: I replied to your questions on that doc review. tl;dr: auto generating this stuff is too hard, and I'm not looking to replace Glance's XML schemas for code-based verification purposes | 12:51 |
sean-k-mooney | stephenfin:ya looking at the code we still have code to use the legacy name | 12:53 |
sean-k-mooney | however the data is nologer stored usign the legacy name so that code is dead | 12:53 |
sean-k-mooney | so i dont think img_mappins is used and we just use the image bdms | 12:54 |
sean-k-mooney | stephenfin: and ya i think if doc strings are not easy to use i guess doing it manually is ok | 12:54 |
sean-k-mooney | it would be nice if they could not get out of sync | 12:55 |
stephenfin | Agreed, but I just don't think it's practical in this case unfortunately | 12:55 |
sean-k-mooney | i would still like to encurage peopel to update glance whenever tehy add new image metadata | 12:55 |
sean-k-mooney | oh by the ay i also didnt repond to the pinning patch | 12:56 |
sean-k-mooney | yes i forgot we reused cpuset to avoid modifing the object | 12:56 |
sean-k-mooney | ill proably remove my -1 later just finishing up a bz comment beofre the bug call so havent got to reviews yet today | 12:57 |
stephenfin | cool | 12:57 |
sean-k-mooney | i saw your latest commnt in email however | 12:57 |
* sean-k-mooney actully read my gerrit emails regurally | 12:58 | |
*** rpittau is now known as rpittau|afk | 13:03 | |
*** ratailor_ has quit IRC | 13:03 | |
*** ratailor has joined #openstack-nova | 13:03 | |
lyarwood | elod: huh weird, I was sure this landed in stable/victoria | 13:09 |
lyarwood | elod: thanks for catching that | 13:09 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/victoria: Use absolute path during qemu img rebase https://review.opendev.org/757098 | 13:10 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/ussuri: Use absolute path during qemu img rebase https://review.opendev.org/757083 | 13:10 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: Use absolute path during qemu img rebase https://review.opendev.org/757084 | 13:10 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: Use absolute path during qemu img rebase https://review.opendev.org/757085 | 13:10 |
*** nweinber has joined #openstack-nova | 13:11 | |
*** ratailor has quit IRC | 13:15 | |
elod | lyarwood: np :) | 13:16 |
CeeMac | afternoon | 13:28 |
CeeMac | quick question, is there a way to set the libvirt cpu_mode using metadata or some such on a flavour/image/instance at all? | 13:28 |
sean-k-mooney | stephenfin: how would you feel about default all instance with a numa toplogy to hw:mem_page_size=small unless otherwise set. this is needed for numa in placment anyway but would you be open to doing this anyway even without numa in placment | 13:28 |
sean-k-mooney | we might want to restrict it to new instance only but we do have customer hit this edgecase a lot | 13:29 |
sean-k-mooney | the set hw:cpu_policy=dediecated and dont realise that unless they also set hw:mem_page_size=small then there vm will eventually get killed by the OOM reaper | 13:30 |
sean-k-mooney | since the vms memory is pined to a numa node but the did nto enable per numa memory tracking | 13:31 |
sean-k-mooney | stephenfin:by the way for your image properties patch should we send a mail to the list to let the glance folks know we are going to move documenation of image properties back into nova | 13:33 |
stephenfin | sean-k-mooney: I don't think an email is necessary. I'll just propose a patch to glance to remove the existing doc and point back to nova. If they want to keep their copy, that's fine | 13:43 |
stephenfin | sean-k-mooney: As for mem pages, I'm not sure. You can't overcommit with 'hw:mem_page_size' set, right? Even if you could, your overcommit would be against memory from that cell, rather than the entire host. Not necessarily a bad thing but both things are changes in behavior | 13:44 |
sean-k-mooney | right now it broken to not set it | 13:47 |
sean-k-mooney | we will use the global memory when determining if the vm wil fit then pin it to one numa node | 13:47 |
sean-k-mooney | so over commit is broken in any case | 13:47 |
sean-k-mooney | once we track numa in placment its not negoicable it has to do numa aware memroy tracking which is what setting that would do | 13:48 |
sean-k-mooney | we have had 2-3 customer hit this in the last year or so | 13:48 |
sean-k-mooney | for numa in placment this is adress by partioning the cloud into numa nost and non numa hosts. | 13:51 |
sean-k-mooney | we currently dont enforce that you se hw:mem_page_size if you have a numa toplogy but its always a bug/user errror to not set it | 13:52 |
stephenfin | if we can figure out a way to do overcommit on a per-node basis, then I'd be okay with that | 13:55 |
stephenfin | otherwise, it's a big change | 13:55 |
sean-k-mooney | well as is said overcomit does not work properly today | 13:56 |
sean-k-mooney | the OOM reaper will kill the vm if the numa node runs out of memory | 13:56 |
sean-k-mooney | even if the othe rnuma node is fully empty | 13:56 |
stephenfin | you could say the same thing about overcommit without NUMA | 13:57 |
sean-k-mooney | its not the same | 13:57 |
stephenfin | no, but it's similar | 13:57 |
sean-k-mooney | if you set over commit to 1.0 e.g. no over commit | 13:57 |
sean-k-mooney | with the current state the vms can be killed becuase the numa node is exausted | 13:58 |
sean-k-mooney | unless you set hw:mem_page_size=small | 13:58 |
stephenfin | yes, I understand that | 13:59 |
sean-k-mooney | its requried for numa in plamcent for numa hosts | 13:59 |
sean-k-mooney | for non numa hosts i was not going to be an issue since numa instance could not land there | 13:59 |
stephenfin | but if you had work and instances evenly distributed between NUMA nodes, then it would behave the same as the non-NUMA case | 13:59 |
sean-k-mooney | so we defered this conversation the last 2 cycles because numa in palcment will prevent it form happening | 13:59 |
sean-k-mooney | stephenfin: without my numa loadbancing feature it wont evenly disturbute | 14:00 |
sean-k-mooney | unless you consume all the cpus on the first node | 14:00 |
sean-k-mooney | even then it won evenly disturbute | 14:00 |
openstackgerrit | Dan Smith proposed openstack/nova master: Allow excluding image type capabilities https://review.opendev.org/756534 | 14:02 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor _claim_pci_device_for_interface_attach to prepare for qos https://review.opendev.org/756895 | 14:03 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Allow extending an existing instance allocation https://review.opendev.org/757109 | 14:03 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Make remove allocation symmetric with add allocation https://review.opendev.org/757110 | 14:03 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Factor out port resource deallocation https://review.opendev.org/757111 | 14:03 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support interface attach with qos ports https://review.opendev.org/756530 | 14:07 |
*** ociuhandu has quit IRC | 14:11 | |
*** ociuhandu has joined #openstack-nova | 14:12 | |
*** k_mouza_ has quit IRC | 14:25 | |
*** k_mouza has joined #openstack-nova | 14:26 | |
CeeMac | any thoughts on if its possible to set the libvirt cpu_mode value against an image, flavour or instance? | 14:40 |
*** slaweq has quit IRC | 14:42 | |
*** lbragstad_ is now known as lbragstad | 14:49 | |
*** freenzyfriday has joined #openstack-nova | 14:51 | |
*** k_mouza has quit IRC | 14:52 | |
*** freenzyfriday has quit IRC | 14:55 | |
*** mlavalle has joined #openstack-nova | 14:57 | |
sean-k-mooney | CeeMac: its not possible and it was reject in both the image and flaovr in the past | 15:03 |
*** k_mouza has joined #openstack-nova | 15:04 | |
sean-k-mooney | CeeMac: we would prefer you to use traits to sate what instuctions you need instead | 15:04 |
sean-k-mooney | we will then schdule you to a host that has a cpu model that you can use | 15:04 |
sean-k-mooney | cpu_mode specificly is defined by the admin in the config and not overrideable because it has live migration implciations | 15:05 |
CeeMac | sean-k-mooney: thanks, I'm trying to expose hardware virtualization to a specific instance and didn't want to go down the line of making a global cpu_mode change | 15:06 |
CeeMac | sean-k-mooney: do you know which / if any specific traits would be avaialable to do that? | 15:06 |
sean-k-mooney | CeeMac: we intentionally dont expose this via a user or public api as its a interoperatblity issue and only applys to one virt dirver | 15:06 |
sean-k-mooney | CeeMac: do you mean nested virt e.g. expose vmx | 15:07 |
CeeMac | yes | 15:07 |
CeeMac | kvm is enabled for nested | 15:07 |
sean-k-mooney | or are you asking to chdule based on qemu vs kvm | 15:07 |
sean-k-mooney | ah | 15:07 |
CeeMac | but the guest isn't seeing the flag | 15:07 |
sean-k-mooney | then you can use vmx i bleive | 15:07 |
sean-k-mooney | https://github.com/openstack/os-traits/blob/master/os_traits/hw/cpu/x86/intel.py#L26 | 15:08 |
sean-k-mooney | so HW_CPU_X86_VMX | 15:08 |
sean-k-mooney | sorry | 15:08 |
sean-k-mooney | HW_CPU_X86_INTEL_VMX | 15:09 |
sean-k-mooney | for amd systems you would use HW_CPU_X86_SVM | 15:09 |
sean-k-mooney | we dont currently have a way to say X or Y unfutetly | 15:09 |
CeeMac | thanks, is that something I can specify directly on an instance? or is it added at the image or flavour? | 15:10 |
sean-k-mooney | no you can only set the required trait in the flaovr/image | 15:10 |
sean-k-mooney | not per instnace | 15:10 |
CeeMac | right | 15:10 |
sean-k-mooney | doign things per instance does not really work with nova | 15:10 |
CeeMac | so its flavour or image? | 15:10 |
sean-k-mooney | yes both work | 15:10 |
CeeMac | yeah i noticed that :) | 15:10 |
CeeMac | cool | 15:10 |
CeeMac | great thanks a lot | 15:10 |
CeeMac | i'll try creatign a custom flavour | 15:11 |
sean-k-mooney | CeeMac: that will just ensure you land on a host that has nested vert enabled | 15:12 |
sean-k-mooney | but all other vms on that host will also get it | 15:12 |
sean-k-mooney | configureing nested virt is a system wide thing | 15:13 |
CeeMac | right | 15:13 |
sean-k-mooney | the other way that people do this without a trait | 15:13 |
CeeMac | so the vmx flag should automatically be exposed to the guest if KVM is configured for nested? | 15:13 |
sean-k-mooney | is to use the instance extra and host aggrates | 15:14 |
sean-k-mooney | am yes if you use host model or host-passthough as the mode | 15:14 |
*** songwenping__ has joined #openstack-nova | 15:14 | |
melwitt | dansmith: I found a small bug in the cherry-pick hash check script, if you wouldn't mind reviewing https://review.opendev.org/756639 | 15:15 |
dansmith | melwitt: cool | 15:16 |
melwitt | thanks! | 15:16 |
CeeMac | i don't have cpu_mode set in nova.conf by the look of it | 15:16 |
*** songwenping_ has quit IRC | 15:17 | |
CeeMac | and looking at the virsh dumpxml for an instance the cpu mode is 'custom' with a fallback model Skylake-Client-IBRS | 15:17 |
sean-k-mooney | CeeMac if you dont set it it default to None which in the libvirt driver is converted to host-model | 15:18 |
melwitt | lyarwood: easy fix for the cherry-pick hash check script if you get a moment https://review.opendev.org/756639 | 15:18 |
*** lpetrut has joined #openstack-nova | 15:19 | |
CeeMac | sean-k-mooney: thanks, i think I recall reading something like that | 15:19 |
CeeMac | i can't seem to find where to set the trait in metadata | 15:19 |
CeeMac | could be veing blind though | 15:19 |
sean-k-mooney | openstack flavor set --property trait:HW_CPU_X86_VMX=retuired <flavor> | 15:20 |
sean-k-mooney | i think that is the correct command | 15:21 |
sean-k-mooney | stephenfin: ^ | 15:21 |
sean-k-mooney | stephenfin: do you know if you have to quote the trait? | 15:21 |
CeeMac | ah yes, the old cli :) | 15:21 |
sean-k-mooney | ... retuired should be required | 15:21 |
CeeMac | got it | 15:21 |
sean-k-mooney | CeeMac: never trust my spelling | 15:22 |
stephenfin | sean-k-mooney: only if there are spaces or things the shell could confuse | 15:22 |
stephenfin | I usually quote to be safe | 15:22 |
sean-k-mooney | ya i often do but i was not sure if it would mess up the parsing of the = | 15:22 |
CeeMac | stephenfin: so "trait:.....required" <flavour> | 15:24 |
stephenfin | CeeMac: Yup. We list the supported versions here https://docs.openstack.org/nova/latest/configuration/extra-specs.html#trait | 15:25 |
stephenfin | *supported traits | 15:25 |
CeeMac | perfect, thanks | 15:25 |
sean-k-mooney | CeeMac: just be aware that we and them together | 15:26 |
sean-k-mooney | so if you use the amd trait and the intel trait then it wont find a host | 15:26 |
CeeMac | right, good to know :) | 15:26 |
sean-k-mooney | if you have a mix you should use a custom extra spec instead of a trait and use host aggreates | 15:26 |
CeeMac | i'm pretty sure at this point I don't want to do it at all, but i'll try it in my test env to be sure | 15:27 |
CeeMac | stephenfin: from that link it looks like I need trait{group}:HW_CPU_X86_VMX | 15:27 |
CeeMac | is the {group} specific to something? | 15:27 |
sean-k-mooney | there was a proposal to support "in" so you coudl do somehtin like trait:in(intel...,amd...)=required | 15:28 |
sean-k-mooney | CeeMac: you shoudl avoid groups | 15:28 |
CeeMac | i can do that | 15:28 |
sean-k-mooney | just leave out the group | 15:28 |
CeeMac | got it | 15:28 |
sean-k-mooney | we allow named or number grousp of triats | 15:28 |
sean-k-mooney | but they are hard to use and we may eventually remove it form the flaovr | 15:28 |
*** k_mouza has quit IRC | 15:28 | |
CeeMac | yeah, i'm not a big fan of "hard to use" so I'm ok with that :D | 15:29 |
sean-k-mooney | groups dont interact well when you have request form multipel sources | 15:29 |
sean-k-mooney | e.g. flavor, neutron and cyborg | 15:29 |
sean-k-mooney | there are some other gotchas so unless you know how its implmented you should avoid them | 15:30 |
CeeMac | i'll avoid them | 15:33 |
CeeMac | to be honest, i'd rather not allow nested virtualisation, but I'm being instructed to see if it is an option, so yeah | 15:33 |
*** k_mouza has joined #openstack-nova | 15:35 | |
*** jangutter_ has joined #openstack-nova | 15:35 | |
*** lpetrut has quit IRC | 15:35 | |
*** freenzyfriday has joined #openstack-nova | 15:37 | |
*** jangutter has quit IRC | 15:39 | |
sean-k-mooney | CeeMac: i always use nested vert and have done for years but its not for everyone | 15:39 |
sean-k-mooney | it has less sharp edges then it used too | 15:39 |
*** k_mouza has quit IRC | 15:39 | |
CeeMac | looks like OSA is set up to support it out of the box as well from a kernel module perspective | 15:40 |
sean-k-mooney | CeeMac:it was enabled by default in the upstream 4.19 kernel | 15:40 |
CeeMac | if it works without me having to make any major changes and reboot everything then I'm ok with that | 15:41 |
CeeMac | oh | 15:41 |
*** macz_ has joined #openstack-nova | 15:41 | |
CeeMac | fair enough :) | 15:41 |
*** k_mouza has joined #openstack-nova | 15:41 | |
CeeMac | instance has deployed using a flavor with that trait | 15:41 |
CeeMac | so looking fine so far | 15:41 |
CeeMac | its more of a legacy issue with my user base than a technical objection | 15:42 |
*** sapd1 has joined #openstack-nova | 15:42 | |
CeeMac | a lot of them still don't understand that IaaS means they're on their own unless they want to pay for support services | 15:43 |
sean-k-mooney | ya | 15:45 |
sean-k-mooney | the old issue wit nested virt was you could not migrate the l1 vm if the l1 guest was running level 2 guests | 15:46 |
CeeMac | ah, yeah i could see that being a problem | 15:46 |
sean-k-mooney | its been fix in 4.19 | 15:47 |
*** freenzyfriday has quit IRC | 15:47 | |
sean-k-mooney | that was on of the technical reason operator did not often use it in the past | 15:47 |
sean-k-mooney | since it limited how they could use live migration | 15:48 |
CeeMac | makes sense | 15:50 |
*** k_mouza has quit IRC | 15:55 | |
*** k_mouza has joined #openstack-nova | 15:57 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Only add a USB controller if it's necessary https://review.opendev.org/756549 | 15:58 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Remove support for '[libvirt] use_usb_tablet' https://review.opendev.org/756550 | 15:58 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Rationalize attachment of USB tablet https://review.opendev.org/756551 | 15:58 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Add support for virtio-based input devices https://review.opendev.org/756552 | 15:58 |
sean-k-mooney | stephenfin: did you add None to the pointer device. the original requirement diring this is to have no input device attached to the guest | 15:59 |
sean-k-mooney | so using virtio wont actully help in the realtime case | 16:00 |
sean-k-mooney | i assume that is just a nice to have while your here | 16:00 |
*** tesseract has quit IRC | 16:01 | |
admin0 | hi guys .. can the default domain be null or "" blank ? | 16:03 |
admin0 | insetad of .novalocal ? | 16:03 |
sean-k-mooney | dns domain | 16:03 |
admin0 | can it be null ? | 16:03 |
admin0 | or some value has to be there | 16:03 |
sean-k-mooney | its set by https://docs.openstack.org/nova/latest/configuration/config.html#api.dhcp_domain | 16:04 |
admin0 | it does not say if it can be left null | 16:04 |
sean-k-mooney | i dont think it can be | 16:05 |
sean-k-mooney | although we have exampel of it being empty | 16:05 |
*** priteau has quit IRC | 16:06 | |
sean-k-mooney | we use it like this | 16:06 |
sean-k-mooney | https://github.com/openstack/nova/blob/58636d34ec68d44952b22947bac01d4b88ae103a/nova/api/metadata/base.py#L533-L536 | 16:06 |
*** k_mouza has quit IRC | 16:06 | |
sean-k-mooney | you would have to set it to "" | 16:06 |
sean-k-mooney | https://github.com/openstack/nova/blob/85c35b4d9d6386866ddf197e4a751f729b726188/nova/conf/api.py#L218-L222 | 16:06 |
sean-k-mooney | but i dont know if that wil work or not | 16:07 |
sean-k-mooney | default might still replace "" | 16:07 |
sean-k-mooney | but it would be easy to test | 16:07 |
sean-k-mooney | just set [api]/dhcp_domain="" | 16:07 |
*** manoj_kumar_kata has quit IRC | 16:10 | |
melwitt | it can be blank. we had it set that way at yahoo | 16:12 |
*** links has joined #openstack-nova | 16:16 | |
*** ociuhandu has quit IRC | 16:21 | |
*** links has quit IRC | 16:25 | |
*** dtantsur is now known as dtantsur|afk | 16:26 | |
*** raildo has quit IRC | 16:30 | |
*** raildo has joined #openstack-nova | 16:30 | |
*** gyee has joined #openstack-nova | 16:32 | |
stephenfin | sean-k-mooney: No, it wasn't helpful. You can't disable the built-in PS2 devices | 16:35 |
*** tosky has quit IRC | 16:35 | |
stephenfin | However | 16:35 |
sean-k-mooney | you cant by generating model=none in the xml | 16:35 |
stephenfin | I don't think that's supported. The only RFE I found for it was DEFERRED | 16:36 |
sean-k-mooney | well the perfromacne team teh filed teh orignal downstream issue had said they disabeld it manually by editing the xml | 16:36 |
stephenfin | they were talking about USB devices | 16:37 |
sean-k-mooney | yes | 16:37 |
stephenfin | you won't get a USB keyboard or pointer device on x86 unless you request them via image metadata properties or nova.conf | 16:37 |
sean-k-mooney | no libvirt will add it | 16:37 |
stephenfin | so all that's necessary is to remove the superfluous USB bus | 16:37 |
stephenfin | not a USB one, it won't | 16:37 |
stephenfin | it'll add a PS2 mouse and keyboard | 16:38 |
stephenfin | not USB | 16:38 |
sean-k-mooney | ok but i think they wanted to remvoe that too | 16:38 |
stephenfin | See above. I don't think that's supported | 16:38 |
sean-k-mooney | ya so your proposing what use virtio? | 16:39 |
sean-k-mooney | or ps2 | 16:39 |
stephenfin | nope | 16:39 |
stephenfin | I've four patches | 16:39 |
sean-k-mooney | they are hoping to remove all interupts related to the input device | 16:39 |
stephenfin | first one is to remove the unnecessary USB bus | 16:39 |
stephenfin | With that, you can set '[compute] pointer_model' to 'none' or 'ps2mouse' and, unset the 'hw_pointer_model' image metadata property prop, and ensure you haven't set 'hw_*_bus' to 'usb' | 16:40 |
stephenfin | and you won't have any USB devices or a USB bus | 16:41 |
stephenfin | the second is a cleanup patch | 16:41 |
sean-k-mooney | well we dont want this to be in the nova.conf really | 16:41 |
sean-k-mooney | that will cause issue for live migation | 16:41 |
stephenfin | the third makes it so that we only attach a USB tablet if graphics (SPICE or VNC) are enabled | 16:41 |
stephenfin | because it's useless otherwise | 16:41 |
*** priteau has joined #openstack-nova | 16:42 | |
stephenfin | and the fourth adds support for virtio devices because they're supposed to be far more performant and it was an easy win | 16:42 |
stephenfin | Agreed. However, I can't remove it until you add that system metadata thing for Q35 | 16:43 |
sean-k-mooney | :( ya | 16:43 |
sean-k-mooney | ok we might want to update the downstream bz to say the input device cant be removed but we are goign to do this instead | 16:44 |
stephenfin | I don't think the PS2 device is a massive issue. It's the USB bus that was doing most of the damage | 16:44 |
stephenfin | But I should check again to be sure | 16:45 |
stephenfin | Monday! For now, it's sunny outside so o/ :) | 16:45 |
sean-k-mooney | i guess thre expect result was actully "no USB and no graphics" | 16:45 |
*** hamalq has joined #openstack-nova | 16:45 | |
sean-k-mooney | so ps2 device or virtio might be fine actully | 16:46 |
sean-k-mooney | based on https://bugzilla.redhat.com/show_bug.cgi?id=1787442 | 16:46 |
openstack | bugzilla.redhat.com bug 1787442 in documentation ""Configuring Real-Time Compute" lacks guest device configuration tuning" [Unspecified,Closed: wontfix] - Assigned to stephenfin | 16:46 |
*** ViniciusCoelho has joined #openstack-nova | 16:46 | |
*** hemna has quit IRC | 16:50 | |
admin0 | sean-k-mooney, i made it blank and it still gives me a .novalocal | 16:50 |
admin0 | is that something from neutron in dhcp ? | 16:51 |
*** hemna has joined #openstack-nova | 16:51 | |
sean-k-mooney | no i think since novalocal is the default of that coning option you have to do ="" | 16:51 |
sean-k-mooney | i dont think blank will actully work | 16:51 |
sean-k-mooney | melwitt: do you recal if ye set dhcp_domain= or dhcp_domain="" | 16:52 |
melwitt | dhcp_domain="" | 16:52 |
melwitt | set to empty string | 16:53 |
melwitt | sorry, that's what I meant when I said "blank" earlier | 16:53 |
sean-k-mooney | ya ok that makes sense | 16:55 |
sean-k-mooney | dhcp_domain= i think will be treated like its unset and the default will be used | 16:55 |
*** derekh has quit IRC | 16:55 | |
sean-k-mooney | admin0: this might only take effect for new vms too | 16:56 |
*** links has joined #openstack-nova | 16:56 | |
admin0 | unless i can modify the dhcp config manually | 16:56 |
sean-k-mooney | for existing vm i think we store there hostname in the db | 16:56 |
sean-k-mooney | you would need to update the instnace.hostname filed in the db | 16:57 |
sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L130 | 16:57 |
*** hemna has quit IRC | 17:10 | |
*** hemna has joined #openstack-nova | 17:12 | |
*** sapd1 has quit IRC | 17:13 | |
*** hemna has quit IRC | 17:44 | |
*** hemna has joined #openstack-nova | 17:49 | |
*** hack-char has quit IRC | 17:50 | |
*** hack-char has joined #openstack-nova | 17:50 | |
*** priteau has quit IRC | 17:58 | |
openstackgerrit | melanie witt proposed openstack/nova stable/queens: [stable-only] Add functional test for bug 1731668 https://review.opendev.org/756636 | 18:00 |
openstack | bug 1731668 in OpenStack Compute (nova) queens "placement: claim allocations fails with IndexError in _ensure_lookup_table_entry" [Low,In progress] https://launchpad.net/bugs/1731668 - Assigned to melanie witt (melwitt) | 18:00 |
openstackgerrit | melanie witt proposed openstack/nova stable/queens: [stable-only] Use a separate transaction for reading after race https://review.opendev.org/756637 | 18:00 |
openstackgerrit | melanie witt proposed openstack/nova stable/queens: [stable-only] Add functional test for bug 1731668 https://review.opendev.org/756636 | 18:03 |
openstack | bug 1731668 in OpenStack Compute (nova) queens "placement: claim allocations fails with IndexError in _ensure_lookup_table_entry" [Low,In progress] https://launchpad.net/bugs/1731668 - Assigned to melanie witt (melwitt) | 18:03 |
openstackgerrit | melanie witt proposed openstack/nova stable/queens: [stable-only] Use a separate transaction for reading after race https://review.opendev.org/756637 | 18:03 |
melwitt | omg uuughh | 18:03 |
openstackgerrit | melanie witt proposed openstack/nova stable/queens: [stable-only] Add functional test for bug 1731668 https://review.opendev.org/756636 | 18:05 |
openstack | bug 1731668 in OpenStack Compute (nova) queens "placement: claim allocations fails with IndexError in _ensure_lookup_table_entry" [Low,In progress] https://launchpad.net/bugs/1731668 - Assigned to melanie witt (melwitt) | 18:05 |
openstackgerrit | melanie witt proposed openstack/nova stable/queens: [stable-only] Use a separate transaction for reading after race https://review.opendev.org/756637 | 18:05 |
melwitt | sorry for the spam | 18:06 |
*** ralonsoh has quit IRC | 18:10 | |
*** vishalmanchanda has quit IRC | 18:15 | |
*** tkajinam has quit IRC | 18:25 | |
*** hemna has quit IRC | 18:26 | |
*** tosky has joined #openstack-nova | 18:32 | |
*** k_mouza has joined #openstack-nova | 18:32 | |
*** links has quit IRC | 18:41 | |
*** priteau has joined #openstack-nova | 18:42 | |
*** priteau has quit IRC | 18:48 | |
openstackgerrit | melanie witt proposed openstack/nova stable/train: Add a workaround config toggle to refuse ceph image upload https://review.opendev.org/757177 | 19:05 |
*** priteau has joined #openstack-nova | 19:14 | |
*** manoj_kumar_kata has joined #openstack-nova | 19:20 | |
*** k_mouza has quit IRC | 19:20 | |
*** ociuhandu has joined #openstack-nova | 19:24 | |
*** priteau has quit IRC | 19:27 | |
melwitt | mnaser: is ^ something you would find useful/appropriate for sta | 19:47 |
melwitt | *stable/train or nah? | 19:47 |
*** zzzeek has quit IRC | 19:49 | |
*** ociuhandu has quit IRC | 19:50 | |
*** manoj_kumar_kata has quit IRC | 19:50 | |
*** zzzeek has joined #openstack-nova | 19:51 | |
*** hemna has joined #openstack-nova | 20:20 | |
*** hemna has quit IRC | 20:32 | |
*** hemna has joined #openstack-nova | 20:32 | |
*** nweinber has quit IRC | 20:37 | |
*** ociuhandu has joined #openstack-nova | 20:51 | |
*** ociuhandu has quit IRC | 21:13 | |
*** ViniciusCoelho has quit IRC | 21:18 | |
*** ociuhandu has joined #openstack-nova | 21:18 | |
*** ociuhandu has quit IRC | 21:25 | |
*** raildo has quit IRC | 21:30 | |
*** freenzyfriday has joined #openstack-nova | 21:32 | |
*** freenzyfriday has quit IRC | 21:37 | |
*** hamalq has quit IRC | 21:37 | |
*** artom has quit IRC | 21:51 | |
*** hamalq has joined #openstack-nova | 22:00 | |
*** freenzyfriday has joined #openstack-nova | 22:26 | |
*** takamatsu has quit IRC | 22:26 | |
*** freenzyfriday has quit IRC | 22:35 | |
*** macz_ has quit IRC | 23:06 | |
*** freenzyfriday has joined #openstack-nova | 23:07 | |
*** freenzyfriday has quit IRC | 23:12 | |
*** mlavalle has quit IRC | 23:19 | |
*** hamalq has quit IRC | 23:26 | |
*** tosky has quit IRC | 23:26 | |
*** songwenping__ has quit IRC | 23:30 | |
*** songwenping__ has joined #openstack-nova | 23:30 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!