Thursday, 2020-10-22

*** tinwood has quit IRC00:03
*** tinwood has joined #openstack-nova00:04
*** sapd1 has joined #openstack-nova00:18
*** gyee has quit IRC00:24
*** hamalq has quit IRC00:44
*** sapd1 has quit IRC00:45
openstackgerritXav Paice proposed openstack/nova stable/ussuri: Set migrate_data.vifs only when using multiple port bindings  https://review.opendev.org/75915101:12
*** lbragstad has quit IRC01:30
openstackgerritXav Paice proposed openstack/nova stable/train: Set migrate_data.vifs only when using multiple port bindings  https://review.opendev.org/75915301:34
*** sapd1 has joined #openstack-nova01:45
*** dlbewley has quit IRC02:18
*** dlbewley has joined #openstack-nova02:23
*** brinzhang has quit IRC02:31
*** sapd1 has quit IRC02:34
*** songwenping__ has quit IRC02:38
*** sapd1 has joined #openstack-nova02:49
*** rcernin has quit IRC02:52
*** rcernin has joined #openstack-nova02:56
*** dklyle has quit IRC03:15
*** links has joined #openstack-nova03:37
*** LinPeiWen has quit IRC03:51
*** LinPeiWen has joined #openstack-nova03:57
*** ratailor has joined #openstack-nova04:18
*** lemko1 has joined #openstack-nova04:25
*** lemko has quit IRC04:26
*** lemko1 is now known as lemko04:26
*** evrardjp has quit IRC04:33
*** evrardjp has joined #openstack-nova04:33
openstackgerritMerged openstack/os-vif master: Fix - os-vif fails to get the correct UpLink Representor  https://review.opendev.org/74589504:49
*** mvorwerk_ has quit IRC05:14
*** whoami-rajat__ has joined #openstack-nova05:16
*** lemko2 has joined #openstack-nova05:23
*** lemko has quit IRC05:24
*** lemko2 is now known as lemko05:24
*** artom has quit IRC05:33
*** artom has joined #openstack-nova05:33
*** dlbewley has quit IRC05:36
*** vishalmanchanda has joined #openstack-nova05:39
*** sapd1 has quit IRC05:41
*** sapd1 has joined #openstack-nova05:58
*** rchurch has quit IRC06:01
*** rchurch has joined #openstack-nova06:03
*** lpetrut has joined #openstack-nova06:09
*** dlbewley has joined #openstack-nova06:09
*** tbachman has quit IRC06:10
*** mvorwerk has joined #openstack-nova06:11
*** tbachman has joined #openstack-nova06:15
*** nightmare_unreal has joined #openstack-nova06:19
*** macz_ has joined #openstack-nova06:19
*** slaweq has joined #openstack-nova06:21
*** dlbewley has quit IRC06:21
*** macz_ has quit IRC06:24
bauzasgood morning Nova06:28
*** yonglihe has joined #openstack-nova06:29
*** noonedeadpunk has quit IRC06:31
*** noonedeadpunk has joined #openstack-nova06:33
*** noonedeadpunk has quit IRC06:34
*** noonedeadpunk has joined #openstack-nova06:39
*** slaweq has quit IRC06:44
*** slaweq has joined #openstack-nova06:46
*** dlbewley has joined #openstack-nova06:50
*** rpittau|afk is now known as rpittau06:54
*** jawad_axd has joined #openstack-nova06:54
*** dlbewley has quit IRC07:04
*** ralonsoh has joined #openstack-nova07:05
gibibauzas: good morning07:11
bauzas:)07:11
*** jraju__ has joined #openstack-nova07:22
*** links has quit IRC07:22
*** andrewbonney has joined #openstack-nova07:24
*** tesseract has joined #openstack-nova07:27
*** dlbewley has joined #openstack-nova07:33
*** dlbewley has quit IRC07:38
*** ociuhandu has joined #openstack-nova07:41
*** rcernin has quit IRC07:42
*** tosky has joined #openstack-nova07:44
*** grandfso has joined #openstack-nova07:47
*** rcernin has joined #openstack-nova07:49
*** Corwin has quit IRC07:50
*** Corwin has joined #openstack-nova07:53
*** rcernin has quit IRC07:54
*** rcernin has joined #openstack-nova08:00
*** macz_ has joined #openstack-nova08:07
*** macz_ has quit IRC08:12
*** rcernin has quit IRC08:12
*** jraju__ has quit IRC08:26
*** dlbewley has joined #openstack-nova08:28
*** dlbewley has quit IRC08:33
*** salmankhan has joined #openstack-nova08:35
*** derekh has joined #openstack-nova08:38
openstackgerritStephen Finucane proposed openstack/nova master: objects: Remove 'BandwidthUsage', 'BandwidthUsageList'  https://review.opendev.org/75911408:49
*** dtantsur|afk is now known as dtantsur08:56
*** iurygregory has quit IRC08:57
gibistephenfin: now I feel making o.vo fields typesafe is fultile. E.g. an o.vo IntegerField accept strings and coerce them to integeres with an int() conversion. So if I type an IntegerField to int then mypy will flag obj.int_field = '123' assignemnet which is valid in o.vo. Also if I map it to str then mypy will not flag obj.int_field = 'bob' which is invalid in o.vo09:05
gibis/flutile/futile09:05
gibiwhich means it is very limited what we can typecheck09:14
gibiList*Fields are complicated as they are coreced from  Iterables but not from str or Mapping myobj.list_of_ints = {1, 2, 3}09:16
gibisorry I wanted to link https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/fields.py#L64809:16
gibibtw  myobj.list_of_ints = {'1', '2', '3'} also accepted by ovo as the elements of the iterable is coerced to int09:17
*** rcernin has joined #openstack-nova09:21
*** rcernin has quit IRC09:25
stephenfingibi: I hadn't considered coercion /o\09:27
*** iurygregory has joined #openstack-nova09:28
stephenfinHmm, that does sound pretty futile alright. Damn :-\09:28
stephenfinI had been thinking it might make sense to at least define the attributes and simply set their type to Any, so that we'd know you could define e.g. 'InstanceNUMACell.cpu_policy' but not '.cpu_policyyyy'. However, I guess we rely on that to store working data09:29
gibistephenfin: I can generate the fields with https://github.com/gibizer/ovo-mypy-plugin and map them to Any. I guess non o.vo fields defined via simply assigning value to them in nova code. So those can be typed in nova code and picked up by mypy09:32
stephenfingibi: I think there's probably value in that. I mean, it sounds like the best we can get unless we wanted to drop the coerce functionality09:34
stephenfinwhich, tbc, I wouldn't be entirely against either; explicit is better than implicit and all that09:35
gibistephenfin: I don't know if the generic RPC code depends on coerce or not. But the specific nova usage of o.vo can be converted to not use coerce09:36
gibior at least to use explicit coerce09:37
gibiinstead of implicit during assignment09:37
stephenfinEven if the RPC code did rely on it, type checking doesn't happen at run time so we could require explicit coercion for non-RPC cases09:39
stephenfini.e. get static type checking working09:39
*** sapd1 has quit IRC09:39
*** sapd1 has joined #openstack-nova09:42
*** k_mouza has joined #openstack-nova09:44
*** salmankhan1 has joined #openstack-nova09:54
*** salmankhan has quit IRC09:55
*** salmankhan1 is now known as salmankhan09:55
gibistephenfin: so then we are back to defining IntegerField as int even though we know that o.vo is more forgiving than that at runtime?10:12
*** dlbewley has joined #openstack-nova10:15
*** jraju__ has joined #openstack-nova10:18
*** jraju__ has quit IRC10:19
*** dlbewley has quit IRC10:20
*** jangutter has joined #openstack-nova10:36
openstackgerritMerged openstack/nova master: virt: Remove 'post_interrupted_snapshot_cleanup' API  https://review.opendev.org/74931310:41
*** rcernin has joined #openstack-nova10:43
*** rcernin has quit IRC10:48
*** mgariepy has quit IRC11:04
*** tbachman has quit IRC11:04
*** jawad_axd has quit IRC11:11
*** sapd1 has quit IRC11:30
*** k_mouza_ has joined #openstack-nova11:43
*** k_mouza has quit IRC11:43
*** k_mouza has joined #openstack-nova11:44
*** spatel has joined #openstack-nova11:46
*** k_mouza_ has quit IRC11:47
*** ratailor has quit IRC11:48
*** spatel has quit IRC11:51
*** takamatsu has joined #openstack-nova11:54
*** nweinber has joined #openstack-nova11:56
*** mgariepy has joined #openstack-nova11:59
*** k_mouza_ has joined #openstack-nova12:07
*** sapd1 has joined #openstack-nova12:08
*** k_mouza has quit IRC12:10
*** sapd1 has quit IRC12:13
*** k_mouza has joined #openstack-nova12:13
*** dlbewley has joined #openstack-nova12:16
*** k_mouza_ has quit IRC12:17
*** rcernin has joined #openstack-nova12:17
*** raildo has joined #openstack-nova12:18
*** martinkennelly has joined #openstack-nova12:18
*** jawad_axd has joined #openstack-nova12:19
*** rcernin has quit IRC12:22
*** dlbewley has quit IRC12:26
*** k_mouza has quit IRC12:29
*** k_mouza has joined #openstack-nova12:29
openstackgerritsean mooney proposed openstack/os-vif stable/victoria: Fix - os-vif fails to get the correct UpLink Representor  https://review.opendev.org/75925512:32
sean-k-mooneylyarwood: can you reivew https://review.opendev.org/#/c/756406 and https://review.opendev.org/#/c/759255/12:33
sean-k-mooneythey are os-vif stable/victoria backports12:33
openstackgerritStephen Finucane proposed openstack/nova master: db: Compact Kilo database migrations  https://review.opendev.org/75925612:35
openstackgerritStephen Finucane proposed openstack/nova master: db: Compact Kilo database migrations  https://review.opendev.org/75839612:36
*** tbachman has joined #openstack-nova12:39
openstackgerritStephen Finucane proposed openstack/nova master: db: Compact Kilo database migrations  https://review.opendev.org/75839612:40
lyarwoodsean-k-mooney: ack will do12:54
lyarwoodsean-k-mooney: done, LGTM.12:57
sean-k-mooneylyarwood:thanks12:59
sean-k-mooneylyarwood: if you fell like doing other reviews https://review.opendev.org/#/q/topic:bug/1895220+(status:open+OR+status:merged) is related to a downstream escalation13:02
sean-k-mooneyi have just rechecked them but i would really like to get thos merged sooner rather then later13:03
lyarwoodsean-k-mooney: ack queued13:04
openstackgerritMerged openstack/nova master: fixtures: Handle binding of first port  https://review.opendev.org/74694913:12
openstackgerritMerged openstack/nova master: Remove self.server dependency form _evacuate_server  https://review.opendev.org/75820913:13
*** efried has quit IRC13:17
*** efried has joined #openstack-nova13:21
*** lpetrut has quit IRC13:22
*** jawad_axd has quit IRC13:28
*** dlbewley has joined #openstack-nova13:31
*** artom has quit IRC13:36
*** dlbewley has quit IRC13:36
*** mvorwerk has quit IRC13:57
*** xek has joined #openstack-nova14:00
*** k_mouza has quit IRC14:01
*** dlbewley has joined #openstack-nova14:02
*** takamatsu is now known as mauro|call14:04
*** mauro|call is now known as takamatsu14:04
*** lemko has quit IRC14:05
*** lemko0 has joined #openstack-nova14:05
*** k_mouza has joined #openstack-nova14:07
*** swp20 has joined #openstack-nova14:11
*** salmankhan has quit IRC14:15
*** sapd1 has joined #openstack-nova14:15
*** grandfso has quit IRC14:24
*** tbachman_ has joined #openstack-nova14:33
*** tbachman has quit IRC14:35
*** tbachman_ is now known as tbachman14:35
*** salmankhan has joined #openstack-nova14:39
*** salmankhan1 has joined #openstack-nova14:42
*** xek has quit IRC14:42
*** xek has joined #openstack-nova14:43
*** salmankhan has quit IRC14:43
*** salmankhan1 is now known as salmankhan14:43
*** macz_ has joined #openstack-nova14:45
*** macz_ has quit IRC14:45
*** READ10 has joined #openstack-nova14:49
*** dlbewley has quit IRC14:49
*** xek has quit IRC14:51
*** xek has joined #openstack-nova14:55
*** lemko0 has quit IRC14:55
*** lemko has joined #openstack-nova14:55
*** jawad_axd has joined #openstack-nova14:55
*** dklyle has joined #openstack-nova14:55
*** mlavalle has joined #openstack-nova15:00
*** jawad_axd has quit IRC15:05
*** tbachman_ has joined #openstack-nova15:10
*** tbachman has quit IRC15:11
*** tbachman_ is now known as tbachman15:11
*** artom has joined #openstack-nova15:19
*** artom has quit IRC15:19
*** artom has joined #openstack-nova15:19
*** gregwork has joined #openstack-nova15:25
*** swp20 has quit IRC15:46
gibinova weekly meeting starts in 12 minutes in #openstack-meeting-315:47
*** rpittau is now known as rpittau|afk15:57
*** swp20 has joined #openstack-nova15:59
* bauzas ducks the head out for the nova meeting15:59
*** mgariepy has quit IRC16:02
*** k_mouza has quit IRC16:06
*** k_mouza_ has joined #openstack-nova16:06
openstackgerritMerged openstack/nova stable/victoria: libvirt: Increase incremental and max sleep time during device detach  https://review.opendev.org/75730516:07
*** hamalq has joined #openstack-nova16:07
*** hamalq has quit IRC16:10
*** hamalq has joined #openstack-nova16:10
*** k_mouza_ has quit IRC16:10
*** mriedem has joined #openstack-nova16:19
*** ociuhandu_ has joined #openstack-nova16:28
*** wwriverrat has quit IRC16:30
*** dtantsur is now known as dtantsur|afk16:31
*** ociuhandu has quit IRC16:32
*** ociuhandu_ has quit IRC16:32
openstackgerritStephen Finucane proposed openstack/nova master: db: Compact Kilo database migrations  https://review.opendev.org/75839616:32
openstackgerritStephen Finucane proposed openstack/nova master: db: Compact Liberty database migrations  https://review.opendev.org/75839716:32
openstackgerritStephen Finucane proposed openstack/nova master: db: Compact Mitaka database migrations  https://review.opendev.org/75839816:32
openstackgerritStephen Finucane proposed openstack/nova master: db: Compact Newton database migrations  https://review.opendev.org/75908516:32
openstackgerritStephen Finucane proposed openstack/nova master: db: Compact Ocata database migrations  https://review.opendev.org/75908616:32
openstackgerritStephen Finucane proposed openstack/nova master: db: Compact Pike database migrations  https://review.opendev.org/75908716:32
openstackgerritStephen Finucane proposed openstack/nova master: db: Compact Queens database migrations  https://review.opendev.org/75908816:32
openstackgerritStephen Finucane proposed openstack/nova master: db: Compact Rocky database migrations  https://review.opendev.org/75908916:32
openstackgerritStephen Finucane proposed openstack/nova master: db: Compact Stein database migrations  https://review.opendev.org/75909016:32
openstackgerritStephen Finucane proposed openstack/nova master: db: Compact Train database migrations  https://review.opendev.org/75909116:32
openstackgerritmelanie witt proposed openstack/nova master: DNM test  https://review.opendev.org/75929416:33
*** valleedelisle has joined #openstack-nova16:37
openstackgerritmelanie witt proposed openstack/nova master: DNM test  https://review.opendev.org/75929416:39
*** mgariepy has joined #openstack-nova16:55
*** derekh has quit IRC17:00
*** ralonsoh has quit IRC17:08
*** valleedelisle has quit IRC17:13
*** jawad_axd has joined #openstack-nova17:17
*** valleedelisle has joined #openstack-nova17:24
*** tesseract has quit IRC17:26
*** andrewbonney has quit IRC17:26
*** jawad_axd has quit IRC17:32
*** vishalmanchanda has quit IRC17:39
*** xek has quit IRC17:41
*** sapd1 has quit IRC17:51
*** nightmare_unreal has quit IRC18:02
*** dklyle has quit IRC18:13
*** salmankhan1 has joined #openstack-nova18:17
*** salmankhan has quit IRC18:20
*** salmankhan1 has quit IRC18:21
*** bbowen has quit IRC18:30
*** KurtB has quit IRC18:35
*** eandersson has quit IRC19:10
*** ccstone has quit IRC19:10
*** ccstone has joined #openstack-nova19:11
*** eandersson has joined #openstack-nova19:11
*** gyee has joined #openstack-nova19:26
*** lbragstad has joined #openstack-nova19:39
*** rcernin has joined #openstack-nova19:43
*** rcernin has quit IRC19:48
*** lbragstad has quit IRC19:56
*** lbragstad has joined #openstack-nova20:03
*** bbowen has joined #openstack-nova20:09
*** salmankhan has joined #openstack-nova20:16
*** salmankhan has quit IRC20:21
*** nweinber has quit IRC20:26
*** slaweq has quit IRC20:26
*** mgariepy has quit IRC20:48
*** mgariepy has joined #openstack-nova21:02
*** slaweq has joined #openstack-nova21:08
*** slaweq has quit IRC21:27
openstackgerritmelanie witt proposed openstack/nova master: DNM test  https://review.opendev.org/75929421:27
*** hamalq_ has joined #openstack-nova21:48
*** dklyle has joined #openstack-nova21:50
*** hamalq has quit IRC21:51
*** mriedem has quit IRC21:54
*** mlavalle has quit IRC22:15
*** rcernin has joined #openstack-nova22:30
*** READ10 has quit IRC22:48
*** rcernin has quit IRC22:49
*** rcernin has joined #openstack-nova22:52
*** tosky has quit IRC22:54
*** benj_ has quit IRC23:21
*** macz_ has joined #openstack-nova23:25
*** benj_ has joined #openstack-nova23:26
*** macz_ has quit IRC23:35
*** tbachman has quit IRC23:40
*** tbachman has joined #openstack-nova23:41
*** tbachman_ has joined #openstack-nova23:44
*** tbachman has quit IRC23:47
*** tbachman_ is now known as tbachman23:47

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!