Tuesday, 2020-10-27

*** macz_ has quit IRC00:09
*** gyee has quit IRC00:21
*** hamalq has quit IRC00:30
*** LinPeiWen has joined #openstack-nova00:31
*** spatel has joined #openstack-nova00:36
*** sapd1_x has joined #openstack-nova00:39
*** sapd1_x has quit IRC00:44
*** NobodyCam_ has joined #openstack-nova00:52
*** NobodyCam has quit IRC00:52
*** NobodyCam_ is now known as NobodyCam00:52
openstackgerritMerged openstack/nova stable/stein: Allow tap interface with multiqueue  https://review.opendev.org/75788600:55
*** mugsie has quit IRC01:00
*** mugsie has joined #openstack-nova01:04
*** raildo has quit IRC01:06
*** dave-mccowan has quit IRC01:20
*** JamesBenson has joined #openstack-nova01:26
*** JamesBenson has quit IRC01:30
*** sapd1_x has joined #openstack-nova01:39
*** sapd1_x has quit IRC02:03
*** JamesBenson has joined #openstack-nova02:06
*** JamesBenson has quit IRC02:10
*** sapd1_x has joined #openstack-nova02:12
*** LinPeiWen has quit IRC02:14
*** JamesBenson has joined #openstack-nova02:21
*** JamesBenson has quit IRC02:25
*** rcernin has quit IRC02:38
*** rcernin has joined #openstack-nova03:06
*** psachin has joined #openstack-nova03:10
*** spatel has quit IRC03:15
*** sapd1_x has quit IRC03:17
*** sapd1_x has joined #openstack-nova03:21
*** rcernin has quit IRC03:26
*** rcernin has joined #openstack-nova03:47
*** LinPeiWen has joined #openstack-nova04:03
*** ratailor has joined #openstack-nova04:21
*** sapd1_x has quit IRC04:36
*** LinPeiWen has quit IRC04:50
*** vishalmanchanda has joined #openstack-nova05:29
*** evrardjp has quit IRC05:33
*** evrardjp has joined #openstack-nova05:33
*** sapd1_x has joined #openstack-nova06:16
*** recyclehero has joined #openstack-nova06:40
*** sapd1_x has quit IRC06:40
*** Diavel has joined #openstack-nova06:47
*** dklyle has quit IRC07:02
*** sapd1_x has joined #openstack-nova07:05
*** ralonsoh has joined #openstack-nova07:07
*** dtantsur|afk is now known as dtantsur07:20
*** rpittau|afk is now known as rpittau07:42
*** sapd1_x has quit IRC07:52
openstackgerritBrin Zhang proposed openstack/nova-specs master: Re-proposes 'Proposal for a safer remote console with password authentication  https://review.opendev.org/75982808:03
openstackgerritBrin Zhang proposed openstack/nova-specs master: Re-proposes 'Proposal for a safer remote console with password authentication  https://review.opendev.org/75982808:07
*** andrewbonney has joined #openstack-nova08:10
*** slaweq has joined #openstack-nova08:11
*** lpetrut has joined #openstack-nova08:11
*** ralonsoh has quit IRC08:13
*** rcernin has quit IRC08:23
*** ircuser-1 has joined #openstack-nova08:24
*** macz_ has joined #openstack-nova08:33
*** sapd1_x has joined #openstack-nova08:33
*** tesseract has joined #openstack-nova08:34
*** tosky has joined #openstack-nova08:36
gibigmann: OK, I moved both of your topic for Thursday08:36
*** ralonsoh has joined #openstack-nova08:37
*** macz_ has quit IRC08:37
bauzasgood morning Nova08:38
gibibauzas: good morning08:39
*** LinPeiWen71 has joined #openstack-nova08:39
lyarwoodMorning08:45
bauzas:)08:47
bauzasgibi: fwiw, I was trying to attend the cyborg session this morning about vGPU management, but I didn't have time for it08:48
bauzasgibi: I'm trying to shepherd their spec https://review.opendev.org/#/c/75892508:48
bauzasbrinzhang_: around ?08:48
openstackgerritJorhson Deng proposed openstack/nova master: Reject to attach and detach volume while task_state is not None  https://review.opendev.org/75891808:50
*** martinkennelly has joined #openstack-nova08:54
gibibauzas: There is a long writeup on https://etherpad.opendev.org/p/nova-wallaby-ptg for the cyborg crossproject about gpus08:59
gibi~L5008:59
bauzasgibi: yup i saw it, but I have a lot of open questions about it09:00
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Only ask tpool.Proxy to autowrap vir* classes  https://review.opendev.org/75983109:01
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Only ask tpool.Proxy to autowrap vir* classes  https://review.opendev.org/75983109:02
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Only ask tpool.Proxy to autowrap vir* classes  https://review.opendev.org/75983109:04
lyarwoodgibi / bauzas / stephenfin ^ should unblock the gate hopefully, based on feedback from the libvirt-python devs09:05
kashyapYeah, that should unblock, based on what DanPB's tests09:05
gibilyarwood, kashyap: thanks for taking care of this issue09:06
bauzaslyarwood: so, no need to use another release ?09:07
kashyap(Thanks also to Mel Witt and DanPB for the root cause analysis :-))09:07
lyarwoodbauzas: hopefully not09:08
*** ociuhandu has joined #openstack-nova09:19
*** ratailor has quit IRC09:26
openstackgerritLee Yarwood proposed openstack/nova master: releasenotes: Add fixes note for bug #1882521  https://review.opendev.org/75897109:30
openstackbug 1882521 in Cinder "Failing device detachments on Focal" [Undecided,New] https://launchpad.net/bugs/188252109:30
lyarwoodstephenfin: ^ updated the releasenote09:30
DiavelHi guys, I wanted to ask for your opinion. Does it make sense to add a notification for compute nodes when an instance metadata gets updated -- see here https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L4232? Currently only the controller sends a notification `instance.update` with `InstanceUpdatePayload` which is fine but imho it could also be useful to have it sent by compute nodes. The thing is I am working on09:39
Diavela tool which consumes amqp messages and runs on every compute node, to simplify life it consumes only messages targeted/emitted for/from the specific compute node. With this the code of the tool I am doing could stay pretty clean.09:39
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Only ask tpool.Proxy to autowrap vir* classes  https://review.opendev.org/75983109:39
gibiDiavel: Hi! the instance metadata change handled fully in the controller. There is an RPC cast to the compute but that was only there for the XenAPI virt driver that is recently removed so the RPC will go away in the future09:42
Diavelgibi: that means that in the future versions if I wanna keep a watch over instance metadata updates I have no other option than to watch controller amqp messages?09:43
gibiDiavel: also duplicating the same notification feels bad to me09:43
gibiDiavel: I assume this is not the only notification that is emited by the controller only09:43
gibiso overall it is good idea to watch for the controller too09:45
gibiyou can configure nova to emit the notification to a specific message bus independently from th RPC config09:46
gibiso you can create a config where every nova service uses the same message bus for notifications09:46
gibiand then you only need to listen to that bus09:46
gibiin a single place09:46
Diavelyeah that's what I am doing.. actually I have configured it so that every compute uses its own message bus and that is consumed by that tool which I am working on09:47
Diavelbut to be honest only the metadata update event is missing09:47
*** jangutter has quit IRC09:47
Diavelotherwise everything else I have tested is sent by compute09:47
*** jangutter has joined #openstack-nova09:48
gibiDiavel: just top of my head instance tags and update on instance attributes like display_name are also handled only on the controller09:51
Diavelgibi: ok got it. Thanks for clarifying this. :)09:53
stephenfinlyarwood: good sleuthing09:55
lyarwoodstephenfin: danpb and melwitt found it tbh10:01
stephenfinFair10:01
stephenfinI'm just happy it's not _my_ mypy stuff causing issues :)10:01
lyarwoodhaha indeed10:02
*** jangutter_ has joined #openstack-nova10:04
*** spatel has joined #openstack-nova10:05
*** jangutter has quit IRC10:07
*** spatel has quit IRC10:10
gibistephenfin: it is someone else's mypy stuff but it is still some typing issue :D10:12
gibiso I guess this is still a negative thing for the typing effort10:12
bauzasstephenfin: I prefer my pie rather than mypy :p10:23
bauzas(a quince pie)10:24
*** takamatsu is now known as mauro|call10:37
*** mauro|call is now known as takamatsu10:37
*** k_mouza has joined #openstack-nova10:46
*** cap has joined #openstack-nova10:49
*** k_mouza has quit IRC10:56
*** k_mouza has joined #openstack-nova10:57
*** k_mouza has quit IRC11:02
*** k_mouza has joined #openstack-nova11:10
*** macz_ has joined #openstack-nova11:25
*** sapd1_x has quit IRC11:28
*** macz_ has quit IRC11:30
*** lpetrut has quit IRC12:01
*** lpetrut has joined #openstack-nova12:03
*** ratailor has joined #openstack-nova12:15
*** raildo has joined #openstack-nova12:23
sean-k-mooneyis the gate currently broken by the libvirt issue by the way?12:27
sean-k-mooneybefore i recheck something12:27
gibisean-k-mooney: yes it is12:27
gibinova-compute fails to start12:28
gibisean-k-mooney: we hope https://review.opendev.org/#/c/759831/ will solve it12:28
sean-k-mooney... ok so there is no point in me asking for reviews i have 2 patches i need to get merged soon12:28
sean-k-mooneyya i saw that earlier i was not sure if it had merged12:29
sean-k-mooneyand i lost the link12:29
sean-k-mooneythanks :)12:29
sean-k-mooney return tuple([cls[1] for cls in classes if cls[0].startswith("vir")]) should work provided they keep to there nameing scheme12:30
sean-k-mooneywell when the gate is green again can people take a look at https://review.opendev.org/#/c/751642/7 and ill recheck https://review.opendev.org/#/c/602432/22 later12:31
gmanngibi: thanks12:31
*** dtantsur is now known as dtantsur|brb12:34
*** bbowen has joined #openstack-nova12:41
*** Luzi has joined #openstack-nova12:55
*** dave-mccowan has joined #openstack-nova13:08
sean-k-mooneylyarwood: gibi  stephenfin just spoke to fungi and frickler in #opendev we might need to make grenade non voting for https://review.opendev.org/#/c/759831/ to merge or merge it to victoria first and forward port it13:12
lyarwoodsean-k-mooney: oh fun13:13
lyarwoodsean-k-mooney: I didn't realise this was also broken in V13:13
fungiusually you merge to the oldest affected branch first and work your way up to the newest13:13
fungiat least if upgrade testing is impacted13:14
sean-k-mooneylyarwood: i saw it broken on a grenade job fro one of frickler patches it failed in the inital stack i think13:14
lyarwoodsean-k-mooney: did we also bump eventlet etc there?13:14
lyarwoodthe other way of fixing this is to revert requirements.txt bumps13:15
sean-k-mooneyactully looking at it again it might be the scond stacking13:15
sean-k-mooneyhttps://zuul.opendev.org/t/openstack/build/89443efd462f4d7fb2e470568546b23213:16
lyarwoodhopefully that's the case13:16
* lyarwood looks13:16
fungiyeah, if that's the case then just fixing in master should be sufficient13:16
sean-k-mooneyit https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_894/759850/1/check/designate-grenade-pdns4/89443ef/controller/logs/screen-n-cpu.txt13:16
sean-k-mooneythere is a grenade.sh log13:16
sean-k-mooneyhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_894/759850/1/check/designate-grenade-pdns4/89443ef/controller/logs/grenade.sh_log.txt13:16
sean-k-mooneyso that means the first stacking passed right13:17
sean-k-mooneye.g. victoia13:17
sean-k-mooneyso this is just a master issue13:17
lyarwoodcoolio13:17
sean-k-mooneywell im not sure about that13:18
sean-k-mooneye.g. i dont know if we alwasy have a grenade.sh log or not in that job13:18
sean-k-mooneyok we are good13:19
sean-k-mooneyhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_894/759850/1/check/designate-grenade-pdns4/89443ef/controller/logs/old/devstacklog.txt13:19
sean-k-mooneywe have a succeful inital devstack run13:19
sean-k-mooneyso ya its failing on the master upgrade13:19
*** nweinber has joined #openstack-nova13:19
openstackgerritLee Yarwood proposed openstack/nova master: releasenotes: Add fixes note for bug #1882521  https://review.opendev.org/75897113:20
openstackbug 1882521 in OpenStack Compute (nova) "Failing device detachments on Focal" [High,Fix released] https://launchpad.net/bugs/1882521 - Assigned to Lee Yarwood (lyarwood)13:20
*** jangutter_ is now known as jangutter13:21
lyarwoodsean-k-mooney: cool, so everything is green in CI at the moment, I'll continue watching it.13:21
gibifingers crossed13:26
*** Luzi has quit IRC13:31
*** brinzhang_ has quit IRC13:37
*** jangutter has quit IRC13:38
*** jangutter has joined #openstack-nova13:38
bauzassean-k-mooney: agreed with you on the "vir" prefix, I'm a bit afraid they could change their naming13:38
bauzasbut let's merge the change now and discuss for it on a FUP13:39
sean-k-mooneyyep if i was very concerned about that i would have -1d13:39
bauzassean-k-mooney: i did in on PS3, but after thinking on it, I finally provided a +213:40
sean-k-mooneyi think we can cross that bridge when it comes up13:40
lyarwoodright, I really doubt it's ever going to change tbh13:41
lyarwoodeven if it did checking for _ wouldn't be enough13:41
lyarwoodso yeah lets cross that bridge if it ever comes up13:41
bauzassure, but i wonder whether we should verify that only LibvirtError should be a private class and maybe if not then stopping the compute service when restarting13:42
bauzaslyarwood: ^13:42
bauzasso in case libvirt supports a new public class that is not having a vir prefix by a new major release (hopefully), then the compute service would stop to run and we would get an exception explaining it13:43
*** sapd1 has quit IRC13:44
*** sapd1 has joined #openstack-nova13:44
bauzasmaybe a overthought so, but here the problem is that I don't see any API situation for python-libvirt13:44
bauzaswe only have https://libvirt.org/python.html that is documented13:44
*** eharney has quit IRC13:45
*** dave-mccowan has quit IRC13:46
*** eharney has joined #openstack-nova14:03
*** dtantsur|brb is now known as dtantsur14:03
*** mlavalle has joined #openstack-nova14:07
*** slaweq is now known as slaweq|ptg14:07
openstackgerritLee Yarwood proposed openstack/nova-specs master: WIP/DNM - Image defined ephemeral storage encryption  https://review.opendev.org/75228414:09
lyarwoodbauzas: sorry my irc client disconnected silently, yeah we can make this more robust but I don't think the return on that effort is going to be high tbh14:23
bauzaslyarwood: I wish libvirt would provide a better robust API14:24
bauzasfor the python bindings14:24
bauzaslike, having a public scheme14:24
lyarwoodbauzas: I'm not sure why you think it isn't14:24
lyarwoodbauzas: oh, well it's basically https://libvirt.org/html/libvirt-libvirt-domain.html14:24
bauzaslyarwood: the problem ties to python, by default you can introspect any object14:24
lyarwoodbauzas: through the two main classes described in your previous link14:25
bauzaslyarwood: yeah, but that's not the python binding API, right?14:25
lyarwoodbauzas: true, we could use better documentation14:26
bauzastotally unrelated, I really would love Gerrit supporing images or memes https://review.opendev.org/#/c/759828/2/specs/wallaby/approved/nova-support-webvnc-with-password-anthentication.rst@17514:26
bauzasI mean the Gerrit UI14:26
bauzashyperlinks would stay plain text for gerrit text clients14:27
bauzasbut for those which are smart...14:27
sean-k-mooneyunicode works14:28
sean-k-mooneyalthough sometimes it can break things14:29
bauzassean-k-mooney: how so ?14:29
sean-k-mooney using unicode in commit messages has broken things in the past14:32
gibibauzas: you can try to add a client side script that resolves the links for you locally14:32
*** lpetrut has quit IRC14:32
sean-k-mooneyi think it broke the zuul parser that looks for depend on14:32
*** dklyle has joined #openstack-nova14:32
sean-k-mooneybut ya you can use code injector14:32
bauzaslol14:32
* bauzas remembers when we all had this JS script running on our browsers14:33
bauzasfor gerrit14:33
sean-k-mooneyi use code injector to allow me to copy form gerrit commits again14:33
sean-k-mooney*comments14:33
*** lpetrut has joined #openstack-nova14:33
sean-k-mooneyyou need to set user-select: text to get comment to be selectable again14:34
openstackgerritLee Yarwood proposed openstack/os-traits master: Add COMPUTE_EPHEMERAL_ENCRYPTION tratis  https://review.opendev.org/75987814:34
*** Luzi has joined #openstack-nova14:44
gibisean-k-mooney: could you paste that code, I could use that too14:46
*** macz_ has joined #openstack-nova14:49
sean-k-mooneyi need to fix it but yes right now i some times need to refresh as it can run too early but before it was quadadic still fast can cleint side i just felt bad14:50
sean-k-mooneyhttp://paste.openstack.org/show/799434/14:51
*** macz_ has quit IRC14:54
gibithanks14:55
sean-k-mooneythe reason it broke is both firefox and chrome change how ineritance works for css14:58
sean-k-mooneyso the default value that was inherited chaned14:59
sean-k-mooneygibi: this is basically what i based it on https://www.smashingmagazine.com/2019/04/mutationobserver-api-guide/15:02
sean-k-mooneygibi: i might just need to add subtree to that list https://www.smashingmagazine.com/2019/04/mutationobserver-api-guide/#childlist-with-subtree15:08
*** david-lyle has joined #openstack-nova15:09
gibithanks15:09
*** dklyle has quit IRC15:09
*** macz_ has joined #openstack-nova15:10
*** macz_ has quit IRC15:10
*** macz_ has joined #openstack-nova15:10
sean-k-mooneyim going to hack on it for 5 mins and see if i can get it back to workign without a refresh15:11
*** LinPeiWen71 has quit IRC15:11
sean-k-mooneygibi: i just need to call it once when the script is loaded and then on mutation http://paste.openstack.org/show/799435/15:14
sean-k-mooneythat should work15:14
sean-k-mooneygibi: also "review\.opendev\.org" is what im using for the site regex/matcher thing for the code injector plugin15:16
sean-k-mooneyi have it set to run on page load15:16
*** lpetrut has quit IRC15:23
*** david-lyle has quit IRC15:30
*** dklyle has joined #openstack-nova15:30
*** gyee has joined #openstack-nova15:34
gibisean-k-mooney: works nicely (after an extra refresh)15:37
bauzasgibi: sean-k-mooney: fwiw dev mode on FF or Chrome works fine15:47
bauzasno need for a plugin15:48
* bauzas reads some newspaper this way15:48
bauzasnewspapers*15:48
sean-k-mooneybauzas: to add it sure but its kind of annoying to have to keep changing it15:48
bauzasI don't really copy/paste a lot15:48
bauzaswhat you can also do is just to click on "reply" at a comment15:49
sean-k-mooneyya but that quotes it15:49
bauzasyou'll get the text with a "> " prefix15:49
bauzasright15:49
bauzasbut easy peasy nope ?15:49
sean-k-mooneyits annoying when you providing code examples15:49
bauzashumm, really ?15:50
sean-k-mooneyyep why do you think i wrote a script :)15:50
sean-k-mooneyi want it to just work15:50
bauzascut -c1 - ?15:50
bauzaswhoops15:50
sean-k-mooneymore work the copy paste :P15:50
bauzascut -c1-15:50
bauzassean-k-mooney: well, if you're lazy enough to copy/paste some hand-written code, then I can understand your point :p15:51
* bauzas notes that he should never write pseudo-code when reviewing sean-k-mooney's changes :p15:51
sean-k-mooneylol i copy paste it but i use my skills to make my job more efficent15:53
sean-k-mooneybut speaking of reviewing my code15:53
sean-k-mooneyhttps://review.opendev.org/#/c/751642/7 and https://review.opendev.org/#/c/602432/22 coudl do with some reivew15:54
bauzassean-k-mooney: ping me those changes next week15:57
bauzasthis week, I focused on open specs15:57
* bauzas is happy to say he's nearly done with it btw., just needs to review kashyap's one plus another cyborg spec15:57
*** dklyle has quit IRC15:59
*** nweinber has quit IRC16:04
*** nweinber has joined #openstack-nova16:05
*** tosky_ has joined #openstack-nova16:07
*** tosky has quit IRC16:08
*** ratailor has quit IRC16:08
*** slaweq|ptg is now known as slaweq16:08
*** JamesBenson has joined #openstack-nova16:12
* bauzas calls it a day, see you folks live tomorrow \o16:20
gibibauzas: see you tomorrow o/16:22
*** dklyle has joined #openstack-nova16:32
*** jdillaman has quit IRC16:35
*** Luzi has quit IRC16:50
*** tosky_ is now known as tosky16:56
*** ralonsoh has quit IRC17:25
*** k_mouza has quit IRC17:25
*** sapd1_x has joined #openstack-nova17:26
*** vishalmanchanda has quit IRC17:30
lyarwoodkashyap: https://bugs.launchpad.net/nova/+bug/1901739 - odd LM issue if you have time tomorrow17:31
openstackLaunchpad bug 1901739 in OpenStack Compute (nova) " libvirt.libvirtError: internal error: missing block job data for disk 'vda'" [Undecided,New]17:31
*** rpittau is now known as rpittau|afk17:34
*** ociuhandu_ has joined #openstack-nova17:35
*** ociuhandu has quit IRC17:38
*** ociuhandu_ has quit IRC17:40
*** JamesBenson has quit IRC17:46
*** martinkennelly has quit IRC17:49
*** Diavel has quit IRC17:49
*** tesseract has quit IRC17:51
*** JamesBenson has joined #openstack-nova18:03
*** mlavalle has quit IRC18:11
*** dtantsur is now known as dtantsur|afk18:13
*** mlavalle has joined #openstack-nova18:14
*** andrewbonney has quit IRC18:21
*** sapd1_x has quit IRC18:32
*** psachin has quit IRC18:39
*** itsjg has joined #openstack-nova19:07
*** ociuhandu has joined #openstack-nova19:13
*** martinkennelly has joined #openstack-nova19:15
*** efried has quit IRC19:36
*** efried has joined #openstack-nova19:37
*** melwitt has joined #openstack-nova20:07
*** ociuhandu has quit IRC20:15
*** ociuhandu has joined #openstack-nova20:16
*** slaweq has quit IRC20:16
*** rpittau|afk is now known as rpittau20:18
*** slaweq has joined #openstack-nova20:19
*** nweinber has quit IRC20:34
*** gouthamr has quit IRC20:58
*** logan- has quit IRC20:58
*** gouthamr has joined #openstack-nova20:58
*** gouthamr has quit IRC20:59
*** gouthamr has joined #openstack-nova20:59
*** logan- has joined #openstack-nova21:01
*** rpittau is now known as rpittau|afk21:03
*** slaweq has quit IRC21:04
*** raildo has quit IRC21:05
*** hamalq has joined #openstack-nova21:20
*** slaweq has joined #openstack-nova21:22
*** k_mouza has joined #openstack-nova22:08
*** ociuhandu has quit IRC22:39
*** rcernin has joined #openstack-nova23:02
*** slaweq has quit IRC23:10
*** mlavalle has quit IRC23:20
*** macz_ has quit IRC23:37
*** tosky has quit IRC23:52

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!