*** tosky has quit IRC | 00:00 | |
*** slaweq has quit IRC | 00:05 | |
*** slaweq has joined #openstack-nova | 00:08 | |
*** tkajinam has quit IRC | 00:16 | |
*** tkajinam has joined #openstack-nova | 00:16 | |
*** imtiazc has joined #openstack-nova | 00:28 | |
*** luksky has quit IRC | 00:29 | |
*** macz_ has quit IRC | 00:39 | |
*** ftarasenko has quit IRC | 00:53 | |
*** benj_ has quit IRC | 00:54 | |
*** zigo has quit IRC | 00:54 | |
*** benj_ has joined #openstack-nova | 00:54 | |
*** mlavalle has quit IRC | 01:04 | |
-openstackstatus- NOTICE: The Gerrit service on review.opendev.org is being restarted quickly to make heap memory and jgit config adjustments, downtime should be less than 5 minutes | 01:09 | |
prometheanfire | any work on the updated mock support? https://review.opendev.org/765680 | 01:38 |
---|---|---|
*** songwenping_ has quit IRC | 01:48 | |
*** songwenping_ has joined #openstack-nova | 01:48 | |
*** zzzeek has quit IRC | 01:52 | |
*** zzzeek has joined #openstack-nova | 01:53 | |
*** amotoki has quit IRC | 02:01 | |
*** amotoki has joined #openstack-nova | 02:02 | |
*** zzzeek has quit IRC | 02:05 | |
*** zzzeek has joined #openstack-nova | 02:06 | |
*** hamalq has quit IRC | 02:12 | |
*** lifeless has quit IRC | 02:25 | |
*** lifeless has joined #openstack-nova | 02:27 | |
melwitt | prometheanfire: I resolved the remaining issues in the proposed patch but need someone to rebase it and handle the merge conflicts. I hoped stephenfin could help with that | 02:30 |
melwitt | I don't have as much of the context on the rest of the patch | 02:30 |
*** macz_ has joined #openstack-nova | 02:31 | |
prometheanfire | melwitt: thanks for the update :D | 02:35 |
*** macz_ has quit IRC | 02:36 | |
melwitt | np | 02:37 |
*** READ10 has joined #openstack-nova | 02:59 | |
*** hemanth_n has joined #openstack-nova | 03:01 | |
*** songwenping__ has joined #openstack-nova | 03:13 | |
*** songwenping_ has quit IRC | 03:16 | |
*** mkrai has joined #openstack-nova | 03:16 | |
*** jamesdenton has quit IRC | 03:17 | |
*** jamesdenton has joined #openstack-nova | 03:18 | |
*** psachin has joined #openstack-nova | 03:20 | |
*** k_mouza has joined #openstack-nova | 03:37 | |
*** k_mouza has quit IRC | 03:42 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List/Update Servers APIs https://review.opendev.org/c/openstack/nova/+/764292 | 03:42 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Replace all_tenants with all_projects in List Server APIs https://review.opendev.org/c/openstack/nova/+/765311 | 03:42 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Replace tenants* with projects* of policies https://review.opendev.org/c/openstack/nova/+/765315 | 03:42 |
*** songwenping_ has joined #openstack-nova | 04:13 | |
*** k_mouza has joined #openstack-nova | 04:13 | |
*** songwenping__ has quit IRC | 04:16 | |
*** k_mouza has quit IRC | 04:17 | |
*** zzzeek has quit IRC | 04:19 | |
*** zzzeek has joined #openstack-nova | 04:21 | |
*** zzzeek has quit IRC | 04:26 | |
*** zzzeek has joined #openstack-nova | 04:27 | |
*** vishalmanchanda has joined #openstack-nova | 04:55 | |
*** zzzeek has quit IRC | 05:26 | |
*** arne_wiebalck has quit IRC | 05:27 | |
*** yonglihe has quit IRC | 05:27 | |
*** yonglihe has joined #openstack-nova | 05:28 | |
*** arne_wiebalck has joined #openstack-nova | 05:29 | |
*** zzzeek has joined #openstack-nova | 05:29 | |
*** evrardjp has quit IRC | 05:33 | |
*** evrardjp has joined #openstack-nova | 05:33 | |
*** mkrai has quit IRC | 05:35 | |
*** mkrai has joined #openstack-nova | 05:35 | |
*** ratailor has joined #openstack-nova | 05:39 | |
*** READ10 has quit IRC | 05:43 | |
*** LinPeiWen has quit IRC | 05:45 | |
*** mkrai has quit IRC | 05:54 | |
*** zzzeek has quit IRC | 06:15 | |
*** zzzeek has joined #openstack-nova | 06:17 | |
*** gyee has quit IRC | 06:28 | |
*** LinPeiWen has joined #openstack-nova | 06:31 | |
*** zzzeek has quit IRC | 06:49 | |
*** zzzeek has joined #openstack-nova | 06:51 | |
*** damien_r has joined #openstack-nova | 07:04 | |
*** damien_r has quit IRC | 07:05 | |
*** lpetrut has joined #openstack-nova | 07:12 | |
*** psachin has quit IRC | 07:17 | |
*** ralonsoh has joined #openstack-nova | 07:19 | |
*** zzzeek has quit IRC | 07:21 | |
*** zzzeek has joined #openstack-nova | 07:23 | |
LarsErikP | melwitt: I noticed whis was merged a few hours ago \o/ can it be backported to ussuri? | 07:25 |
*** dklyle has quit IRC | 07:34 | |
*** lifeless has quit IRC | 07:54 | |
*** lifeless has joined #openstack-nova | 07:56 | |
*** tosky has joined #openstack-nova | 08:02 | |
*** elod_pto is now known as elod | 08:05 | |
openstackgerrit | Mamduh proposed openstack/os-vif stable/ussuri: Refactor code of linux_net to more cleaner and increase performace https://review.opendev.org/c/openstack/os-vif/+/765419 | 08:06 |
*** tesseract has joined #openstack-nova | 08:12 | |
gibi | LarsErikP: sure, it can be backported. But please propose a backport to stable/victoria first then stable/ussuri | 08:12 |
*** andrewbonney has joined #openstack-nova | 08:13 | |
*** rpittau|afk is now known as rpittau | 08:14 | |
LarsErikP | melwitt: Uh.. Don't know what happended there. Forgot the link: https://review.opendev.org/c/openstack/nova/+/759348/ | 08:15 |
LarsErikP | gibi: Uhm.. not sure howto do that. Maybe melwitt could do it, as she fixed this originally? =) | 08:16 |
openstackgerrit | Mamduh proposed openstack/os-vif stable/ussuri: Fix - os-vif fails to get the correct UpLink Representor https://review.opendev.org/c/openstack/os-vif/+/765967 | 08:18 |
openstackgerrit | Lars Erik Pedersen proposed openstack/nova stable/victoria: Omit resource inventories from placement update if zero https://review.opendev.org/c/openstack/nova/+/766177 | 08:20 |
LarsErikP | gibi: I found the button ^ :P | 08:20 |
LarsErikP | should I add reviewers? and.. there is merge conflicts in ussuri. not feeling comfortable to deal with that :S | 08:23 |
openstackgerrit | Mamduh proposed openstack/os-vif stable/train: Refactor code of linux_net to more cleaner and increase performace https://review.opendev.org/c/openstack/os-vif/+/765912 | 08:25 |
gibi | LarsErikP:added some stable cores to the review. Thanks for proposing the backport | 08:30 |
gibi | LarsErikP: as for the ussuri backport, lets merge the victoria one first then I think melwitt can resolv the merge conflict in ussuri or I can take it if needed | 08:31 |
LarsErikP | gibi: good plan :-) thanks so much! | 08:32 |
gibi | LarsErikP: :) | 08:32 |
*** aj_mailing has joined #openstack-nova | 08:41 | |
*** teoobo_ has joined #openstack-nova | 08:41 | |
*** ociuhandu has joined #openstack-nova | 08:42 | |
bauzas | good morning Nova | 08:44 |
*** zzzeek has quit IRC | 08:50 | |
*** zzzeek has joined #openstack-nova | 08:50 | |
*** ociuhandu has quit IRC | 08:52 | |
gibi | bauzas: O/ | 08:55 |
*** rcernin has quit IRC | 08:56 | |
*** rcernin has joined #openstack-nova | 08:56 | |
*** teoobo_ has quit IRC | 08:57 | |
*** ociuhandu has joined #openstack-nova | 08:59 | |
*** teoobo_ has joined #openstack-nova | 09:02 | |
*** derekh has joined #openstack-nova | 09:02 | |
*** CeeMac has quit IRC | 09:07 | |
*** luksky has joined #openstack-nova | 09:10 | |
*** xek__ has joined #openstack-nova | 09:16 | |
*** zzzeek has quit IRC | 09:16 | |
*** zzzeek has joined #openstack-nova | 09:17 | |
*** fudunwei has joined #openstack-nova | 09:20 | |
*** rcernin has quit IRC | 09:23 | |
*** martinkennelly has joined #openstack-nova | 09:25 | |
openstackgerrit | Adrian Chiris proposed openstack/os-vif stable/ussuri: Fix - os-vif fails to get the correct UpLink Representor https://review.opendev.org/c/openstack/os-vif/+/765967 | 09:30 |
*** rcernin has joined #openstack-nova | 09:32 | |
*** zzzeek has quit IRC | 09:40 | |
*** k_mouza has joined #openstack-nova | 09:40 | |
*** zzzeek has joined #openstack-nova | 09:41 | |
lyarwood | elod: morning, have you had anytime to look at the pip failures in stable before I start digging in? | 09:46 |
*** zzzeek has quit IRC | 09:46 | |
lyarwood | elod: https://review.opendev.org/q/Ia2007bc63ef09931ea0197cef29d6a5614ed821a - I was checking in on this series and noticed that everything prior to victoria is failing with pip 20.2.4 | 09:47 |
elod | lyarwood: good morning :) I'm looking at several issues now, which pip failures do you mean? :) | 09:48 |
lyarwood | elod: https://zuul.opendev.org/t/openstack/build/cb6247d4b3644045ab6d83a064e812c6 for example | 09:48 |
*** rcernin has quit IRC | 09:48 | |
lyarwood | actually ussuri looks okay sorry | 09:48 |
lyarwood | ERROR: Package 'bandit' requires a different Python: 2.7.17 not in '>=3.5' | 09:49 |
elod | yes, this bandit is what I just started to look at | 09:49 |
*** zzzeek has joined #openstack-nova | 09:49 | |
*** rcernin has joined #openstack-nova | 09:49 | |
elod | I guess we've got a new bandit version with incorrect setup.cfg :S | 09:49 |
elod | but haven't checked yet | 09:49 |
elod | at least there was a release, for sure: https://pypi.org/project/bandit/#history | 09:51 |
lyarwood | oh it's just a new version that drops py2 support | 09:51 |
lyarwood | okay we can cap this easily on stable where we are still using py2 | 09:51 |
elod | I'll look for the bandit changes and let's see if I can put this new version to disallow-list in global requirements | 09:53 |
lyarwood | https://github.com/PyCQA/bandit/releases/tag/1.6.3 it dropped py2 support | 09:54 |
lyarwood | elod: https://review.opendev.org/c/openstack/requirements/+/766170 | 09:55 |
lyarwood | elod: I *think* that's enough right? | 09:55 |
elod | thanks! setup.cfg looks ok ( https://github.com/PyCQA/bandit/blob/1.6.3/setup.cfg ) so I think this patch with the cap should be OK | 09:56 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: libvirt: Skip encryption metadata lookups if secret already exists on host https://review.opendev.org/c/openstack/nova/+/765771 | 09:57 |
lyarwood | kk testing above | 09:57 |
elod | maybe we need to add that to global-requirements.txt | 09:59 |
lyarwood | hmm it's only a test-requirment in nova | 10:00 |
* lyarwood forgets if that's a valid thing to add to global-requirements | 10:01 | |
*** zzzeek has quit IRC | 10:01 | |
*** macz_ has joined #openstack-nova | 10:02 | |
*** zzzeek has joined #openstack-nova | 10:03 | |
elod | lyarwood: it seems the patch won't work: https://opendev.org/openstack/requirements/src/branch/stable/train/blacklist.txt#L5 | 10:04 |
elod | so if I understand correctly we need to add it to every branch in every test-requirements.txt :/ | 10:05 |
elod | * the bandit cap | 10:05 |
lyarwood | elod: in nova right? | 10:06 |
lyarwood | fun | 10:06 |
elod | yes | 10:06 |
lyarwood | okay I'll do that now | 10:06 |
*** macz_ has quit IRC | 10:07 | |
elod | (and "fortunately" I see lots of bandit failures all along other openstack repos :/ so it will be a nice amount of bandit patch if I'm not mistaken...) | 10:07 |
stephenfin | lyarwood: elod: We should probably move bandit and other linters out of test-requirements.txt and into tox.ini since they're not subject to upper-constraints | 10:08 |
stephenfin | https://github.com/openstack/python-openstackclient/blob/master/tox.ini#L31-L34 | 10:08 |
stephenfin | from https://github.com/openstack/python-openstackclient/commit/20769cd7b27d51da84a324a17922427eba5c6eac | 10:09 |
lyarwood | stephenfin: we can start doing that on master | 10:09 |
lyarwood | stephenfin: I'm not sure we want to change that on stable however right? | 10:09 |
stephenfin | I wouldn't see a reason not to, assuming your issue is derived from the new pip 20.3 resolver, rather than simply uncapped requirements | 10:10 |
stephenfin | If it's the latter, obviously just cap them and be done with it, sure | 10:10 |
lyarwood | it's the latter sorry, I assumed it was pip to begin with | 10:11 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: Cap bandit at 1.6.2 when using py2 https://review.opendev.org/c/openstack/nova/+/766171 | 10:11 |
stephenfin | ah, then yes, cap all the way | 10:11 |
lyarwood | but it just wasn't capped | 10:11 |
lyarwood | okay lets try this again | 10:13 |
elod | hmmm, stephenfin I don't see the benefit of movint from test-req to tox.ini. we use capping in test-req, too | 10:13 |
stephenfin | elod: not for linters, you don't | 10:13 |
stephenfin | https://github.com/openstack/requirements/blob/master/blacklist.txt | 10:13 |
lyarwood | as we just found out :) | 10:13 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: libvirt: Skip encryption metadata lookups if secret already exists on host https://review.opendev.org/c/openstack/nova/+/765771 | 10:13 |
elod | but that just mean there shouldn't be a global cap | 10:13 |
elod | in test-req it's OK | 10:14 |
elod | at least this is how I understand :) | 10:14 |
stephenfin | Hmm, I recall seeing something from mordred about this a while ago on openstack-discuss. Wonder if I can find it... | 10:14 |
lyarwood | actually let me write up a bug for this | 10:16 |
stephenfin | elod, lyarwood: Okay, this is what I was thinking of http://lists.openstack.org/pipermail/openstack-discuss/2020-March/013642.html | 10:16 |
elod | just found it, too, but have to re-read :) | 10:17 |
stephenfin | Not exactly it, but it does describe the issue I was seeing with OSC. Specifically "That means we uninstall and reinstall flake8 at different versions over and over again - and the final state is not one that is completely consistent." | 10:17 |
stephenfin | pip went nuts when those were included | 10:17 |
stephenfin | With that said, we have out own hacking plugins and tests for same, which means we do actually depend on those things to run unit tests. I don't know what the answer for that is :-\ | 10:18 |
stephenfin | Maybe it's just "Not A Problem" (TM)? :) | 10:18 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: Cap bandit at 1.6.2 when using py2 https://review.opendev.org/c/openstack/nova/+/766171 | 10:20 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: libvirt: Skip encryption metadata lookups if secret already exists on host https://review.opendev.org/c/openstack/nova/+/765771 | 10:20 |
lyarwood | oh wait, so adding the cap in test-reqs isn't going to work? | 10:20 |
elod | the uninstall and reinstall is mainly a problem in devstack. but test-req installation is removed in devstack, so that's not a problem anymore. | 10:20 |
elod | lyarwood: i think it will work | 10:21 |
lyarwood | okay something is still installing bandit in the grenade jobs as well on stable/train FWIW | 10:22 |
lyarwood | brb | 10:22 |
elod | the question is whether there are some benefit if we move linters to tox.ini instead. which I don't see yet, as that would add another place where we should look for dependencies... but maybe I'm wrong :X | 10:22 |
stephenfin | elod: Is it actually a dependency? You don't need it to run the main code nor the tests (for anything that doesn't have tests for custom linters, that is). It's a dependency but only in the same way tox is a dependency | 10:24 |
lyarwood | stephenfin: there's a bandit env in tox | 10:25 |
lyarwood | stephenfin: I assume that's why it's there? | 10:25 |
stephenfin | I don't get you. wdym? | 10:25 |
lyarwood | [testenv:bandit] | 10:26 |
lyarwood | # NOTE(browne): This is required for the integration test job of the bandit | 10:26 |
lyarwood | # project. Please do not remove. | 10:26 |
lyarwood | envdir = {toxworkdir}/shared | 10:26 |
lyarwood | commands = bandit -r nova -x tests -n 5 -ll | 10:26 |
lyarwood | ^ in tox.ini on stable/train | 10:26 |
*** littlebogfury11 has joined #openstack-nova | 10:26 | |
stephenfin | oh, okay, I'm not saying we don't need to specify bandit somewhere. I'm saying we don't need to do it in test-requirements.txt because it doesn't need to be subject to e.g. lower-constraints checks | 10:27 |
stephenfin | we can do it in tox.ini instead | 10:27 |
lyarwood | ah right sorry | 10:27 |
lyarwood | yeah well I get elod's point that it's just another place to look for deps but if it isn't needed outside of that tox env then I'd be okay with just listing it there in tox.ini | 10:27 |
stephenfin | In case it helps, the way I was diagnosing those lower-constraints jobs yesterday was to create a new virtualenv, update pip and run the same command as the lower-constraints tox target | 10:28 |
lyarwood | do you want to push a change on master? | 10:28 |
stephenfin | I had to do that because on Fedora 33, I get Python 3.9 in my virtualenv which isn't compatible with a few of the dependencies | 10:28 |
*** littlebogfury11 has quit IRC | 10:28 | |
lyarwood | yeah I just hacked the base python version when working on this the other day | 10:28 |
lyarwood | upgraded pip and reproduced the issue | 10:29 |
lyarwood | but that's different to this issue again | 10:29 |
stephenfin | Fair | 10:29 |
lyarwood | this was just an uncapped dep dropping py2 support | 10:29 |
* stephenfin idly wonders if we should start setting basepython for lower-constraints job | 10:29 | |
lyarwood | tbh I think we might need to do that until py39 is actually supported | 10:29 |
lyarwood | otherwise some of us on modern distros get stung all the damn time | 10:30 |
stephenfin | yuuup | 10:30 |
stephenfin | fwiw, you can also do this | 10:30 |
lyarwood | oh cool there's a LC failure now on stable/train as well | 10:31 |
stephenfin | TOX_CONSTRAINTS_FILE=lower-constraints.txt tox -e py36 | 10:31 |
stephenfin | sub UPPER_ for TOX_ on pre-victoria iirc | 10:31 |
stephenfin | \o/ | 10:31 |
elod | wasn't there another discussion in mailing list that the usage of basepython is discouraged? o:) | 10:31 |
*** rcernin has quit IRC | 10:31 | |
stephenfin | unless this was recently, I fixed that | 10:32 |
lyarwood | ERROR: No matching distribution found for hacking<1.2.0,>=1.1.0 | 10:32 |
lyarwood | ^ stephenfin was that the LC issue you were working on? | 10:32 |
elod | this 'no matching distro' issue seems more like some mirror thing to me. (and again, I might be wrong :X) | 10:33 |
stephenfin | Not that exact, but it looks familiar. That happens because it can't match the dependencies of that hacking version with those required by other dependencies | 10:33 |
stephenfin | It's very misleading | 10:33 |
lyarwood | yeah I thought that the other day but talking to fungi we found https://review.opendev.org/c/openstack/nova/+/765824 | 10:34 |
lyarwood | stephenfin: yeah indeed it's an awful error message | 10:34 |
*** brinzhang_ has quit IRC | 10:34 | |
elod | :S | 10:35 |
lpetrut | hi, I have a quick question about the lower-constraints file: it's supposed to contain only direct dependencies, right? for example, if we need package x, which in turn requires package y, would package y need to be in lower-constraints.txt? | 10:38 |
*** littleboyfury has joined #openstack-nova | 10:39 | |
stephenfin | lpetrut: it would, yes | 10:39 |
stephenfin | However, we haven't been very good around managing that since the tooling situation is quite poor | 10:39 |
stephenfin | So I don't think anyone is going to hold it against you in a review | 10:40 |
lpetrut | stephenfin: thanks for clearing it out. yep, it's really difficult to maintain, I was hoping to be able to limit lower-constraints to direct dependencies | 10:41 |
lpetrut | but I guess that would affect its usefulness | 10:41 |
*** brinzhang has joined #openstack-nova | 10:42 | |
lyarwood | stephenfin: which version of py36 are you using btw? | 10:43 |
*** jangutter has quit IRC | 10:43 | |
*** jangutter has joined #openstack-nova | 10:44 | |
lyarwood | stephenfin: everything is borked for me with 3.6.12 with setuptools 49.1.3 /o\ | 10:44 |
lyarwood | and https://github.com/pypa/setuptools/issues/2017 | 10:45 |
* lyarwood screams into the void | 10:45 | |
stephenfin | I was using 3.6.12, but that was with OSC, not nova | 10:45 |
lpetrut | lywarwood: looks like I'm not the only one having a hard time chasing Python dependencies :) | 10:46 |
lyarwood | yeah it's failing to install MarkupSafe==1.0 | 10:46 |
lyarwood | lpetrut: yup don't you just love python some days? :) | 10:46 |
*** ociuhandu has quit IRC | 10:47 | |
sean-k-mooney | lowerconstriat has more then direct depencies. it was auto generated using pip freeze | 10:51 |
*** LinPeiWen has quit IRC | 10:51 | |
sean-k-mooney | we have removed some of the indirect deps but not all of them | 10:51 |
*** ociuhandu has joined #openstack-nova | 10:51 | |
*** dtantsur|afk is now known as dtantsur | 10:52 | |
sean-k-mooney | lyarwood: just be glad your not dealing with nodejs | 10:52 |
*** littleboyfury has quit IRC | 10:52 | |
*** rcernin has joined #openstack-nova | 10:53 | |
*** littleboyfury has joined #openstack-nova | 10:54 | |
*** mkrai has joined #openstack-nova | 10:56 | |
*** littleboyfury has quit IRC | 11:02 | |
*** littleboyfury has joined #openstack-nova | 11:05 | |
stephenfin | lyarwood: you've probably figured this out already but https://github.com/openstack/nova/blob/stable/train/lower-constraints.txt#L37 | 11:05 |
stephenfin | https://github.com/openstack/nova/blob/stable/train/test-requirements.txt#L5 | 11:06 |
lyarwood | yeah I've been trying to prove that was the issue but I can't build a venv | 11:06 |
lyarwood | let me squash this into my other change | 11:06 |
stephenfin | I'm doing | 11:07 |
stephenfin | deactivate; rm -rf .venv; virtualenv .venv --python=python3.6; source .venv/bin/activate; pip install --upgrade pip; pip install -vvv -c lower-constraints.txt 'hacking>=1.1.0,<1.2.0' | 11:07 |
stephenfin | on repeat | 11:07 |
stephenfin | while playing with lower-constraints.txt | 11:07 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: Cap bandit and raise hacking lower-constraint https://review.opendev.org/c/openstack/nova/+/766171 | 11:09 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: libvirt: Skip encryption metadata lookups if secret already exists on host https://review.opendev.org/c/openstack/nova/+/765771 | 11:09 |
lyarwood | oh right because that moves flake etc | 11:10 |
lyarwood | gah | 11:10 |
lyarwood | so broken | 11:10 |
stephenfin | I wonder if we can start using train-era virtualenv and pip? | 11:11 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: Cap bandit while also raising hacking and flake lower-constraints https://review.opendev.org/c/openstack/nova/+/766171 | 11:13 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: libvirt: Skip encryption metadata lookups if secret already exists on host https://review.opendev.org/c/openstack/nova/+/765771 | 11:13 |
lyarwood | my issue was more with the version of setuptools being pulled in by default by virtualenv, I don't think that's tied to the version of virtualenv itself right? | 11:14 |
stephenfin | I think it is | 11:14 |
lyarwood | ah | 11:14 |
lyarwood | I thouight that was a python version thing | 11:14 |
stephenfin | I saw something from fungi...somewhere this morning | 11:14 |
sean-k-mooney | stephenfin: im not sure about that you can tell virtualenv to download and decompress setuptools | 11:14 |
sean-k-mooney | i think by default it uses your host copy | 11:15 |
sean-k-mooney | there is a --setuptools<version> flag | 11:15 |
stephenfin | if that was the case, why is the gate failing? They (Canonical) are hardly releasing new versions of pip on 18.04 still | 11:16 |
sean-k-mooney | --download might also be needed | 11:16 |
sean-k-mooney | but i think that is for latest | 11:16 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: [stable-only] Cap bandit while also raising hacking and flake lower-constraints https://review.opendev.org/c/openstack/nova/+/766171 | 11:17 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: libvirt: Skip encryption metadata lookups if secret already exists on host https://review.opendev.org/c/openstack/nova/+/765771 | 11:17 |
sean-k-mooney | stephenfin: is it devstack or tox | 11:17 |
stephenfin | lyarwood: this works for me http://paste.openstack.org/show/800886/ | 11:17 |
sean-k-mooney | the job that is failing | 11:17 |
sean-k-mooney | devstack install pip its self | 11:17 |
*** zzzeek has quit IRC | 11:17 | |
stephenfin | I didn't have to bump bandit, weirdly :-\ | 11:17 |
lyarwood | huh weird I didn't need the stestr changes | 11:18 |
lyarwood | \o/ | 11:18 |
lyarwood | either way lets see what the gate says | 11:18 |
stephenfin | lyarwood: for me, it complains that oslo.test 2.6.0 needs stestr 2.0.0 | 11:18 |
lyarwood | that makes sense | 11:18 |
*** zzzeek has joined #openstack-nova | 11:18 | |
lyarwood | stephenfin: oh sorry I was using your previous command | 11:20 |
lyarwood | stephenfin: right so yeah it does, let me update that now | 11:20 |
stephenfin | ah, whoops, yeah, you need to append '-r requirements.txt .' | 11:20 |
stephenfin | hahahaha http://paste.openstack.org/show/800887/ | 11:21 |
stephenfin | that's some dependency tree | 11:21 |
stephenfin | (from pipdeptree) | 11:21 |
stephenfin | sean-k-mooney: you were complaining about nodejs? ^ | 11:22 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: [stable-only] Cap bandit while also raising hacking, flake and stestr LCs https://review.opendev.org/c/openstack/nova/+/766171 | 11:23 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: libvirt: Skip encryption metadata lookups if secret already exists on host https://review.opendev.org/c/openstack/nova/+/765771 | 11:23 |
*** aj_mailing has quit IRC | 11:24 | |
*** tesseract has quit IRC | 11:25 | |
stephenfin | I think it's fair to say the idea of maintaining a comprehensive list of lower-constraints will die pretty soon now | 11:25 |
*** tesseract has joined #openstack-nova | 11:25 | |
sean-k-mooney | stephenfin: that has many many duplicates | 11:26 |
stephenfin | unless that list is updated somewhat regularly, we're going to be playing whack-a-mole as it ages (and it's already pretty well aged) | 11:26 |
sean-k-mooney | well we are not ment to update it ever for stable brances | 11:26 |
sean-k-mooney | its only ment to be updated on master | 11:27 |
stephenfin | you've no choice here. It was wrong | 11:27 |
sean-k-mooney | it was working previously | 11:27 |
lyarwood | `working` | 11:27 |
lyarwood | it wasn't | 11:27 |
stephenfin | no, it wasn't | 11:27 |
lyarwood | it's been borked for a while looking at this | 11:27 |
sean-k-mooney | it was passing ci | 11:27 |
lyarwood | pip wasn't resolving the deps correctly | 11:27 |
stephenfin | def test_advanced_feature(self): | 11:27 |
stephenfin | pass | 11:27 |
lyarwood | it does now and so it's failing in CI | 11:27 |
sean-k-mooney | because of the constrits file? | 11:28 |
stephenfin | advanced feature is working :) | 11:28 |
lyarwood | the new resolver appears to be doing things correctly | 11:28 |
lyarwood | the old one didn't | 11:28 |
stephenfin | previously, the resolver didn't go more than one dependency deep | 11:28 |
sean-k-mooney | this is a behviaor change | 11:28 |
lyarwood | haha really | 11:28 |
sean-k-mooney | we should not be usein gthe new resolve on stable | 11:28 |
stephenfin | so if you required foo=1.0.0 and bar=2.0.0, but bar required foo=1.2.0, it would work | 11:28 |
stephenfin | and it no longer will | 11:29 |
lyarwood | we capped at 20. something but it looks like this has been backported in pip? | 11:29 |
stephenfin | this is 20.3 | 11:29 |
lyarwood | so unless we lower the cap again | 11:29 |
sean-k-mooney | stephenfin: the behvioar of the old resovler was if somethign is listed twice we use the first value | 11:29 |
stephenfin | so we need to cap at less than that | 11:29 |
lyarwood | yeah I thought 21. broke us | 11:29 |
lyarwood | with the new resolver | 11:29 |
sean-k-mooney | that was why the order of deps mattered | 11:29 |
stephenfin | nah, they clearly don't use semver this isn't a major release | 11:30 |
stephenfin | *to say this | 11:30 |
sean-k-mooney | so we need to cap pip right | 11:30 |
stephenfin | ah, it's calver | 11:30 |
sean-k-mooney | and not modify the lower constraits | 11:30 |
stephenfin | we're not changing anything | 11:31 |
lyarwood | oh it was 20.3 | 11:31 |
sean-k-mooney | stephenfin: you not going to modify lower-constraits on stable. ok | 11:31 |
lyarwood | https://review.opendev.org/c/openstack/devstack/+/764803 was what I was thinking about in devstack | 11:31 |
stephenfin | no, we are, but it won't change anything | 11:31 |
stephenfin | because pip wasn't using that | 11:32 |
stephenfin | you can prove it locally too | 11:32 |
sean-k-mooney | pip was in the lower constraits job | 11:32 |
stephenfin | virtualenv .venv --python=python3.6; source .venv/bin/activate; pip install 'pip<20.3'; pip install -c lower-constraints.txt -r requirements.txt -r test-requirements.txt . | 11:32 |
sean-k-mooney | the semantics of the old resovler was if it saw x==1 and later x==2 it ignored the x==2 | 11:32 |
stephenfin | then do pip freeze | 11:33 |
stephenfin | you'll get stestr 2.0.0 and hacking 1.1.0 | 11:33 |
lyarwood | so there was a comment in #openstack-infra that a virtualenv bump introduced pip 20.3 btw | 11:33 |
stephenfin | (do that on stable/train, obviously) | 11:33 |
lyarwood | I'm in favor of fixing LC tbh | 11:33 |
stephenfin | As am I | 11:33 |
lyarwood | yes it's a change but it's a fix | 11:33 |
stephenfin | yup | 11:34 |
lyarwood | and ultimatley you should end up with the same env | 11:34 |
*** ociuhandu has quit IRC | 11:35 | |
lyarwood | brb | 11:35 |
*** ociuhandu has joined #openstack-nova | 11:49 | |
elod | btw, in old stable branches pip should not be version 20.3. so I wonder where this new behavior comes from... :/ | 11:49 |
elod | (as for example, clearly 'hacking===0.12' (in LC) should have contradicted with hacking>=1.0.0 (in test-req) for ages) | 11:52 |
elod | and pip 20.3 resolver issue only appeared in grenade jobs, where pip is bootstrapped directly from pypi... hmmm... | 11:54 |
lyarwood | elod: I think the tox jobs are using it now after a virtualenv change that pulls in pip 20.3 by default | 11:55 |
elod | lyarwood: oh. interesting. so that's why :/ | 11:57 |
*** tbachman has quit IRC | 11:57 | |
*** ociuhandu_ has joined #openstack-nova | 11:58 | |
lyarwood | elod: that said devstack is now failing to deploy swift so maybe we do need https://review.opendev.org/c/openstack/devstack/+/764876 on stable/train | 11:58 |
*** ratailor has quit IRC | 11:59 | |
*** ociuhandu has quit IRC | 12:02 | |
*** rcernin has quit IRC | 12:04 | |
elod | lyarwood: it was/is there in since newton :) https://review.opendev.org/c/openstack/devstack/+/269954 | 12:05 |
elod | so the issue must be something new with swift :/ | 12:06 |
*** imtiazc has quit IRC | 12:09 | |
*** waverider has joined #openstack-nova | 12:13 | |
lyarwood | hmmm I'm not sure that's used with devstack-gate and grenade | 12:14 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: libvirt: Skip encryption metadata lookups if secret already exists on host https://review.opendev.org/c/openstack/nova/+/765771 | 12:14 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: libvirt: Remove native LUKS compat code https://review.opendev.org/c/openstack/nova/+/766210 | 12:14 |
lyarwood | either way <= stable/train is borked now | 12:14 |
*** JamesBenson has joined #openstack-nova | 12:16 | |
lyarwood | ah wait the bandit issue isn't related to pip it's just a broken release for py2 | 12:19 |
lyarwood | gah this is fun | 12:19 |
lyarwood | cinder is attempting to install it as well | 12:20 |
elod | lyarwood: I thought that too first, but as I saw in bandit's setup.cfg it should be OK... or there is something that I'm missing... :X | 12:23 |
elod | ok, meanwhile I read back the opendev infra and there are some things explained, too (new pip causes the errors; new pip is pulled in by latest virtualenv; latest virtualenv is installed via ensure-tox task -- http://eavesdrop.openstack.org/irclogs/%23openstack-infra/%23openstack-infra.2020-12-08.log.html#t2020-12-08T15:05:27 ) | 12:29 |
elod | so now I get why there are latest pip on old stable jobs :/ | 12:32 |
lyarwood | is there a cli for codesearch.opendev.org? | 12:36 |
elod | lyarwood: yes, beagle | 12:38 |
lyarwood | elod: ack thanks | 12:40 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: [stable-only] Cap bandit while also raising hacking, flake and stestr LCs https://review.opendev.org/c/openstack/nova/+/766171 | 12:41 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: libvirt: Remove native LUKS compat code https://review.opendev.org/c/openstack/nova/+/766210 | 12:41 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: libvirt: Skip encryption metadata lookups if secret already exists on host https://review.opendev.org/c/openstack/nova/+/765771 | 12:41 |
lyarwood | hmm that doesn't let you search by branch | 12:49 |
*** ociuhandu_ has quit IRC | 12:51 | |
*** ociuhandu has joined #openstack-nova | 12:51 | |
sean-k-mooney | lyarwood: ya its master only | 12:51 |
elod | just as hound | 12:58 |
lyarwood | elod: coming back to the pip issue, do we want to pin the version of virtualenv? | 13:00 |
lyarwood | elod: on stable that is | 13:00 |
elod | lyarwood: I don't see yet how we can do it, as it is installed via ensure-tox zuul task | 13:01 |
sean-k-mooney | elod: virtualenv has a --pip <version> flag | 13:02 |
sean-k-mooney | so we can add a var to ensure tox for the version | 13:02 |
*** littleboyfury has quit IRC | 13:02 | |
sean-k-mooney | leave it undefiend to the current behavior | 13:02 |
elod | hmmm, that could work | 13:03 |
sean-k-mooney | and override it in the openstack-tox definion per branch | 13:03 |
elod | sorry, need to go AFK, bbl | 13:04 |
*** mkrai has quit IRC | 13:05 | |
*** mkrai has joined #openstack-nova | 13:05 | |
*** ociuhandu has quit IRC | 13:06 | |
*** ociuhandu has joined #openstack-nova | 13:08 | |
*** hemanth_n has quit IRC | 13:12 | |
*** ociuhandu has quit IRC | 13:16 | |
*** waverider has quit IRC | 13:18 | |
*** martinkennelly has quit IRC | 13:22 | |
*** ociuhandu has joined #openstack-nova | 13:24 | |
*** ociuhandu has quit IRC | 13:24 | |
*** martinkennelly has joined #openstack-nova | 13:24 | |
elod | ok, I'm back | 13:26 |
elod | sean-k-mooney: thanks for the idea, I'm looking at if I can make it work | 13:26 |
lyarwood | I can back the lower-constraints changes out of https://review.opendev.org/c/openstack/nova/+/766171 and just handle the bandit cap there | 13:27 |
*** martinkennelly has quit IRC | 13:27 | |
lyarwood | if we can work out a way of capping virtualenv for the tox jobs | 13:27 |
*** martinkennelly has joined #openstack-nova | 13:28 | |
*** k_mouza has quit IRC | 13:28 | |
*** k_mouza has joined #openstack-nova | 13:28 | |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: [stable-only] Cap bandit to 1.6.2 https://review.opendev.org/c/openstack/nova/+/766171 | 13:30 |
openstackgerrit | Mamduh proposed openstack/os-vif stable/stein: Refactor code of linux_net to more cleaner and increase performace https://review.opendev.org/c/openstack/os-vif/+/765914 | 13:37 |
elod | ok, one more addition, the failure came already before the virtualenv 20.2.2 was released... e.g.: https://d13e36a31c498ea1cea8-86befd0513c66a7b4cc05c94ded6a0d4.ssl.cf1.rackcdn.com/periodic-stable/opendev.org/openstack/nova/stable/train/openstack-tox-py27/3fb6863/job-output.txt | 13:37 |
elod | so there should be something else that pulls in latest pip :'( | 13:38 |
lyarwood | elod: two different problems | 13:39 |
lyarwood | elod: the bandit failure is just with the 1.6.3 release | 13:39 |
elod | lyarwood: yes, sorry, you are right | 13:39 |
elod | my bad :X | 13:39 |
lyarwood | elod: and for that I honestly think we need to remove it from the blacklist in requirements | 13:39 |
lyarwood | elod: otherwise we need to update all projects etc | 13:40 |
lyarwood | elod: for both stable/train and stable/stein | 13:40 |
lyarwood | elod: thanks to grenade | 13:40 |
elod | lyarwood: the problem is that it could cause another repositories to break (according to the comment in blacklist.txt) :/ | 13:41 |
elod | however it would be the most convenient way | 13:41 |
*** martinkennelly has quit IRC | 13:42 | |
elod | otherwise lots of branches in lots of repos needs to be patched separately :/ | 13:42 |
lyarwood | elod: I'll propose it and post to the ML | 13:42 |
lyarwood | elod: yeah indeed | 13:42 |
elod | lyarwood: thanks! let's see what we can do | 13:43 |
*** tbachman has joined #openstack-nova | 13:44 | |
elod | lyarwood: or maybe if bandit 1.6.3 gets yanked... there's already the issue reported: https://github.com/PyCQA/bandit/issues/663 | 13:48 |
lyarwood | elod: ah cool | 13:53 |
*** ociuhandu has joined #openstack-nova | 14:00 | |
*** waverider has joined #openstack-nova | 14:04 | |
*** ociuhandu has quit IRC | 14:07 | |
*** ociuhandu has joined #openstack-nova | 14:11 | |
bauzas | gibi: around ? | 14:19 |
bauzas | gibi: I was looking at your comment for https://review.opendev.org/c/openstack/nova/+/749068/2/nova/scheduler/request_filter.py@327 | 14:19 |
bauzas | actually, I think we need to discuss about why we shouldn't be get required_aggregates | 14:20 |
bauzas | this would be because Neutron doesn't create those aggregates | 14:20 |
sean-k-mooney | which aggreates | 14:22 |
bauzas | (well, Nova would create those aggregates as per https://docs.openstack.org/neutron/latest/admin/config-routed-networks.html step 10 ) | 14:22 |
bauzas | sean-k-mooney: see ^ | 14:22 |
sean-k-mooney | neutron creates the nova host aggates and addes server too it for the routed networks | 14:22 |
sean-k-mooney | i.e. neutron calls nova api and relyes on the replciation fo those host aggrates to placment aggreates | 14:23 |
bauzas | sean-k-mooney: is that nova or neutron ? | 14:23 |
*** johanssone has quit IRC | 14:23 | |
bauzas | ah-ha ok | 14:23 |
bauzas | ok, so neutron directly asks the nova api to create the nova aggregates which then automatically creates the placement one | 14:24 |
bauzas | kk | 14:24 |
bauzas | so | 14:24 |
*** bbowen has quit IRC | 14:24 | |
*** teoobo_ has quit IRC | 14:24 | |
*** bbowen has joined #openstack-nova | 14:24 | |
sean-k-mooney | https://github.com/openstack/neutron/blob/master/neutron/services/segments/plugin.py#L272-L289 | 14:24 |
sean-k-mooney | yes when its creatign the RPs and inventories | 14:25 |
bauzas | if an operator uses this prefilter for routed networks, then in case we can't find a routed network related aggregate, should we accept to find any host ? | 14:25 |
sean-k-mooney | no i dont think so | 14:25 |
bauzas | (I mean , when a user asks for a network when creating the instance) | 14:25 |
*** johanssone has joined #openstack-nova | 14:26 | |
sean-k-mooney | can you rephase do you mean "openstack server create --network " | 14:26 |
sean-k-mooney | or somethign else | 14:26 |
bauzas | yup, this | 14:27 |
sean-k-mooney | if a server has a port that is connected to a routed network we shoudl always reuiqre the aggreate if the prefilter is enabled | 14:28 |
bauzas | sean-k-mooney: look at https://review.opendev.org/c/openstack/nova/+/749068/2/nova/scheduler/request_filter.py | 14:28 |
sean-k-mooney | neutron does not allow mixing routed subnets and unrouted subnets in the same network | 14:28 |
bauzas | sean-k-mooney: and gibi's concern on L327 | 14:28 |
bauzas | actually, the prefilter won't ask for any aggregate if we can't find them | 14:29 |
bauzas | it's just the method which would be returning either False or True | 14:29 |
sean-k-mooney | so we shoudl be rejecting the request | 14:29 |
bauzas | but, | 14:29 |
bauzas | returning False won't do anything AFAICT | 14:29 |
sean-k-mooney | i mean raise an excption | 14:30 |
*** noonedeadpunk has quit IRC | 14:30 | |
bauzas | sean-k-mooney: k, i see | 14:31 |
bauzas | sean-k-mooney: that said, just a question | 14:31 |
bauzas | given two networks | 14:31 |
bauzas | one having routed segments, and one without any routed segments | 14:31 |
bauzas | neutron would then create aggregates for the routed segments mapping to net1 | 14:32 |
bauzas | but wouldn't do anything for net2, right? | 14:32 |
sean-k-mooney | in that case you want the intersection fo the aggreates | 14:32 |
sean-k-mooney | yes | 14:32 |
sean-k-mooney | well not the intersection | 14:32 |
bauzas | sean-k-mooney: k, so if a user is passing net2 when creating the instance, then we should be accepting it | 14:32 |
bauzas | and not rejecting the instance creation | 14:33 |
sean-k-mooney | yes althoughg its unlikely that there will be a mix | 14:33 |
*** noonedeadpunk_ has joined #openstack-nova | 14:33 | |
sean-k-mooney | its vlaid but you tend to have one or the other | 14:33 |
bauzas | sure, but then the fact that we can't find aggregates for this network doesn't mean it's a blocker | 14:33 |
sean-k-mooney | correct | 14:33 |
bauzas | hence us not rejecting it | 14:33 |
sean-k-mooney | its only an issue if its a routed network | 14:34 |
bauzas | so we should keep it valid | 14:34 |
sean-k-mooney | since that should always have an aggreate per segment | 14:34 |
bauzas | and me just accepting gibi's change to turn it into True | 14:34 |
sean-k-mooney | you still need to rais in the routed case i think | 14:34 |
bauzas | sean-k-mooney: sure but the prefilter doesn't know why the aggregate wasn't there | 14:34 |
bauzas | nova only knows about aggregates | 14:34 |
sean-k-mooney | but it know if its a routed network request right? | 14:35 |
bauzas | how? | 14:35 |
sean-k-mooney | from the presence of a segment on the neutron subnet | 14:35 |
bauzas | requested_networks is there for *any* network query | 14:35 |
sean-k-mooney | or ip_allocation=defer | 14:35 |
bauzas | sean-k-mooney: sorry but again, we don't know it | 14:36 |
*** ociuhandu has quit IRC | 14:36 | |
sean-k-mooney | utils.get_aggregates_for_routed_network is calling neutron | 14:36 |
sean-k-mooney | so it can check | 14:36 |
*** dcapone2004 has joined #openstack-nova | 14:37 | |
sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/749068/2/nova/network/neutron.py#3539 | 14:38 |
sean-k-mooney | if that retuns segments then its a routed netork | 14:38 |
bauzas | well, shit, you're right | 14:38 |
bauzas | we can raise an exception accordingly | 14:38 |
bauzas | and we do actually | 14:40 |
bauzas | sean-k-mooney: https://review.opendev.org/c/openstack/nova/+/749068/2/nova/scheduler/utils.py@1383 | 14:40 |
bauzas | aaaand we actually do this for *any* segment, which is bad and probably why I'm getting large number of issues | 14:42 |
bauzas | I think I found a bug :)Ã | 14:42 |
gibi | bauzas: sorry, I have to get back to you with this I had a complicated day so fat | 14:43 |
*** ociuhandu has joined #openstack-nova | 14:43 | |
gibi | far | 14:43 |
bauzas | heh no worries | 14:44 |
sean-k-mooney | bauzas: raising PlacementAPIConnectFailure is not really the best | 14:44 |
bauzas | sean-k-mooney: mriedem did that I think in case of any placement call issues | 14:44 |
sean-k-mooney | ya but its not nessialy a connection issue | 14:44 |
bauzas | agreed | 14:45 |
sean-k-mooney | in this case however i dont know if we need to call placemnet at all | 14:45 |
sean-k-mooney | dont we mirror the aggreate to placement using the hostaggret uuid for the placement aggreate uuid | 14:45 |
sean-k-mooney | i think we can just do an api db lookup instead | 14:45 |
bauzas | correxct | 14:45 |
sean-k-mooney | this is how neutron creates the hostaggret | 14:46 |
bauzas | I see your point | 14:46 |
bauzas | if neutron creates a nova aggregate, then I'm ok with your proposal | 14:46 |
bauzas | I wouldn't be OK if neutron was creating a placement aggregate directly | 14:47 |
sean-k-mooney | yep it does then it lookup the uuid of the created nova aggrate and uses that to add its RP too the placment aggreate | 14:47 |
bauzas | your point is fair, I'll change it | 14:47 |
sean-k-mooney | the nova aggreate is named 'Neutron segment id %s' % segment_id | 14:47 |
bauzas | that being said, just a left concern, | 14:48 |
bauzas | if a user passes net2 when creating | 14:48 |
fungi | sorry, was in meetings... i'd never seen pipdeptree before, that's a rather awesome tool | 14:48 |
bauzas | sean-k-mooney: (with net2 having no routed segments) | 14:48 |
sean-k-mooney | it wont enter the for | 14:49 |
bauzas | sean-k-mooney: in this case, we would ask neutron to give us net2's segments, right? | 14:49 |
sean-k-mooney | yep network_api.get_segment_ids_for_network woudl retrun None or [] i think | 14:49 |
bauzas | oh | 14:49 |
fungi | and yeah, i've long asserted that to generate a consistent set of lower constraints you'd need to make it with something like a hacked pip which tries to solve for lowest rather than highest satisfying version of every dependency in the transitive set | 14:49 |
sean-k-mooney | it returns [] | 14:50 |
sean-k-mooney | py | 14:50 |
bauzas | sean-k-mooney: https://review.opendev.org/c/openstack/nova/+/749068/2/nova/network/neutron.py#3548 | 14:50 |
bauzas | sean-k-mooney: say a net2 is not configured for routed networks | 14:50 |
bauzas | sean-k-mooney: what would this API return ? | 14:50 |
sean-k-mooney | i would expect an empty list but lets see what the api ref says | 14:51 |
bauzas | I was thinking that a segment API resource was not only for routed networks | 14:52 |
sean-k-mooney | not is routed netowrks only | 14:52 |
sean-k-mooney | https://docs.openstack.org/api-ref/network/v2/index.html?expanded=list-segments-detail#list-segments | 14:52 |
sean-k-mooney | we are using the list endpoint | 14:52 |
fungi | when the idea of lower constraints jobs was first proposed some years back, i suggested that if people really wanted to do that they should work with the pip maintainers to implement some option to invert version selection, because otherwise the constraints lists wouldn't really be complete or internally consistent... folks said "meh it's good enough" and just punted by guessing some constraints | 14:52 |
sean-k-mooney | so that shoudl return an empy list | 14:52 |
sean-k-mooney | ill check on my home cloud | 14:52 |
bauzas | sean-k-mooney: ack, thanks | 14:52 |
sean-k-mooney | i think the query sting is wrong by the way | 14:57 |
sean-k-mooney | ?network_id=%sfields=id i think should be ?network_id=%s&fields=id | 14:57 |
sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/749068/2/nova/network/neutron.py@3548 | 14:57 |
*** waverider has quit IRC | 15:01 | |
sean-k-mooney | bauzas: ok so i dont have the resouce in my api | 15:02 |
sean-k-mooney | i guess i dont have the api extion enabled | 15:02 |
sean-k-mooney | which ill check now | 15:02 |
bauzas | K | 15:02 |
bauzas | thanks for helping, btw. | 15:02 |
*** waverider has joined #openstack-nova | 15:03 | |
* bauzas just awaits for sean-k-mooney's results but also some French's Council of State court procedure about skiing ban in France :) | 15:04 | |
sean-k-mooney | so ya i dont have the segments extnsion enabled http://paste.openstack.org/show/800901/ | 15:05 |
sean-k-mooney | which mean that we also need to check for that in the nova code | 15:06 |
sean-k-mooney | its just called segment https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/segment.py#L29 | 15:06 |
bauzas | sean-k-mooney: well, we raise_exc=False | 15:08 |
gibi | bauzas: now I read back, It is OK to me what you and sean-k-mooney come up with | 15:10 |
*** ociuhandu has quit IRC | 15:11 | |
sean-k-mooney | bauzas: so we check if the multi provide net extension exist here https://review.opendev.org/c/openstack/nova/+/749068/2/nova/network/neutron.py#3524 | 15:12 |
sean-k-mooney | but we shoudl be checking if the segment extions exists | 15:12 |
*** sapd1 has joined #openstack-nova | 15:13 | |
bauzas | this sounds a reasonable ask | 15:14 |
*** hoonetorg has quit IRC | 15:14 | |
sean-k-mooney | we can cache it the same way we do with the other check so we only do it once. | 15:14 |
bauzas | sean-k-mooney: but my question remains open, do we get an empty list for a network that doesn't do routed segments or whatever else ? | 15:15 |
*** ociuhandu has joined #openstack-nova | 15:15 | |
sean-k-mooney | the api ref does not say but i would expect the list endpoint which we are calling to return an empty list | 15:16 |
sean-k-mooney | i can check there unit tests | 15:16 |
bauzas | sean-k-mooney: thanks | 15:17 |
stephenfin | bauzas, lyarwood, gibi, (anyone else): This is not high priority work, but I have an ass-load of OSC patches that would benefit from some nova devs' eyes | 15:18 |
stephenfin | https://review.opendev.org/q/project:openstack/python-openstackclient+status:open+file:compute+owner:stephenfin%2540redhat.com | 15:18 |
gibi | stephenfin: now queued them for review | 15:18 |
stephenfin | I've been skimming through novaclient commands, mapping them to OSC equivalents, and figuring out what's missing. I'm getting very close to feature parity with those and know where the remaining gaps are | 15:19 |
stephenfin | gibi: \o/ thanks! | 15:19 |
bauzas | stephenfin: opened the link but later, I'm sorry | 15:19 |
stephenfin | Later is good. This is low priority. I just want it to move _eventually_ :) | 15:19 |
bauzas | stephenfin: ping me tomorrow morning then | 15:19 |
* stephenfin would like to be done with OSC gaps in Wallaby | 15:19 | |
*** ociuhandu has quit IRC | 15:20 | |
lyarwood | stephenfin: ack open, I'll start looking through them now | 15:20 |
gibi | stephenfin: there is a probable mitigation for the long standing bug 1823251 https://review.opendev.org/c/openstack/nova/+/765300 | 15:23 |
openstack | bug 1823251 in OpenStack Compute (nova) "Spike in TestNovaMigrationsMySQL.test_walk_versions/test_innodb_tables failures since April 1 2019 on limestone-regionone" [High,Confirmed] https://launchpad.net/bugs/1823251 | 15:23 |
stephenfin | gibi: looking | 15:23 |
gibi | so far I was not able to reproduce the bug with this patch in 10 CI runs | 15:23 |
*** ociuhandu has joined #openstack-nova | 15:25 | |
bauzas | sean-k-mooney: I mean, my concern is to know whether we can know that if we get an empty list of aggregates, it's either fine or not | 15:25 |
*** ralonsoh has quit IRC | 15:27 | |
sean-k-mooney | https://github.com/openstack/neutron/blob/a9fc746249cd34cb7cc594c0b4d74d8ddf65bd46/neutron/tests/unit/extensions/test_segment.py#L341-L351 | 15:27 |
*** ralonsoh has joined #openstack-nova | 15:27 | |
sean-k-mooney | so it will be a list of segments i think but it will be empty still checking | 15:27 |
*** xek_ has joined #openstack-nova | 15:29 | |
*** ociuhandu has quit IRC | 15:30 | |
sean-k-mooney | gibi i hit that bug too | 15:31 |
gibi | sean-k-mooney: all of us hit that during the past one and a half year, we turned that test off during FF many times in the past to make patches land | 15:32 |
*** xek__ has quit IRC | 15:32 | |
gibi | it seems like an unsolvable thing | 15:32 |
sean-k-mooney | oh i mean i have seen it in the last week | 15:32 |
gibi | at least to me | 15:32 |
bauzas | sean-k-mooney: well, ok, so no way to distinct in between networks not using routed segments vs. networks using routed segments but with no aggregate for this segment | 15:33 |
gibi | yeah, recently I seen it almost every day, hence my new atempt to sovle it | 15:33 |
sean-k-mooney | bauzas:right but the later case should never happen | 15:33 |
sean-k-mooney | bauzas: neutron always creates the aggreates if the segments service plugin is loaded | 15:33 |
*** ralonsoh has quit IRC | 15:34 | |
sean-k-mooney | which is what provides routed network support in neutron | 15:34 |
bauzas | sean-k-mooney: ok, so, just checking the extension is enough | 15:35 |
*** ociuhandu has joined #openstack-nova | 15:35 | |
bauzas | and getting no aggregates is totally fine | 15:35 |
sean-k-mooney | getting no segments is fine | 15:35 |
sean-k-mooney | if we get segment but done get aggreates for those segment that a neutorn issue | 15:35 |
gibi | ^^ +1 | 15:36 |
bauzas | ok, then I'll distinct this | 15:36 |
sean-k-mooney | it means neutron could not create them for some reason | 15:36 |
bauzas | in scheduler.utils | 15:36 |
bauzas | okay, I should be able to upload a new rev in 10 mins | 15:36 |
bauzas | still a WIP tho | 15:36 |
sean-k-mooney | cool | 15:36 |
sean-k-mooney | by did i see correctly that you are adding the network request to the request spec | 15:37 |
sean-k-mooney | i might have a use for that in for one of my specs | 15:37 |
*** dklyle has joined #openstack-nova | 15:37 | |
*** ralonsoh has joined #openstack-nova | 15:38 | |
sean-k-mooney | https://review.opendev.org/c/openstack/nova-specs/+/765901/1/specs/wallaby/approved/port-scoped-sriov-numa-affinity.rst#75 | 15:38 |
sean-k-mooney | i was planning to add a prefilter but realised i did not have the requested networks in the prefilter | 15:38 |
sean-k-mooney | so i was going to move it eairler but i think i can just build on your change instead | 15:39 |
sean-k-mooney | bauzas: can you review and provide input on that in particalar | 15:39 |
*** ociuhandu has quit IRC | 15:39 | |
bauzas | sean-k-mooney: okay, will look | 15:40 |
* bauzas does yet another click | 15:40 | |
sean-k-mooney | there is an clean way to do it with out a prefiler but i dont want to break the patern if i dont have to | 15:42 |
*** ociuhandu has joined #openstack-nova | 15:43 | |
*** ralonsoh_ has joined #openstack-nova | 15:45 | |
*** ralonsoh has quit IRC | 15:46 | |
*** ociuhandu has quit IRC | 15:47 | |
*** macz_ has joined #openstack-nova | 15:52 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add requested_networks field to RequestSpec object https://review.opendev.org/c/openstack/nova/+/749977 | 15:53 |
openstackgerrit | Sylvain Bauza proposed openstack/nova master: WIP: Add a routed networks scheduler pre-filter https://review.opendev.org/c/openstack/nova/+/749068 | 15:53 |
*** sapd1 has quit IRC | 15:56 | |
*** mkrai has quit IRC | 15:57 | |
*** amodi has joined #openstack-nova | 16:01 | |
*** sapd1 has joined #openstack-nova | 16:09 | |
*** waverider has quit IRC | 16:09 | |
*** xek has joined #openstack-nova | 16:09 | |
*** xek_ has quit IRC | 16:11 | |
*** xek_ has joined #openstack-nova | 16:11 | |
*** mlavalle has joined #openstack-nova | 16:13 | |
*** xek has quit IRC | 16:15 | |
*** brinzhang has quit IRC | 16:27 | |
*** ociuhandu has joined #openstack-nova | 16:29 | |
melwitt | LarsErikP: I can take care of the merge conflict for the ussuri backport, no worry | 16:30 |
melwitt | for the victoria one, we are currently stuck behind a known gate failure, I posted a note on the review | 16:30 |
*** lpetrut has quit IRC | 16:46 | |
*** hamalq has joined #openstack-nova | 16:53 | |
*** hamalq_ has joined #openstack-nova | 16:55 | |
*** hamalq has quit IRC | 16:59 | |
stephenfin | lyarwood: should I even bother exposing this if it's really internal only? https://review.opendev.org/c/openstack/python-openstackclient/+/765366 | 17:06 |
*** tesseract has quit IRC | 17:06 | |
lyarwood | stephenfin: yeah we could just block it in the cli | 17:07 |
lyarwood | stephenfin: but I'm assuming that will create future up and/or downstream bugs | 17:07 |
lyarwood | stephenfin: but they always have the API | 17:07 |
stephenfin | that's what I'm thinking. I'm not converting e.g. the 'nova reset-network' command | 17:08 |
lyarwood | stephenfin: that said the recently landed update stuff is actually useful outside of swap volume | 17:08 |
lyarwood | stephenfin: so you would just be blocking the swap volume stuff and allowing the volume update flow | 17:08 |
lyarwood | stephenfin: and FWIW this is why I wanted the swap volume flow fork lifted out from this API *before* we landed the volume update stuff | 17:09 |
stephenfin | so I'd drop the dst_volume argument and simply use src_volume for both | 17:09 |
lyarwood | yeah | 17:09 |
stephenfin | I can do that | 17:09 |
*** rpittau is now known as rpittau|afk | 17:12 | |
*** ociuhandu_ has joined #openstack-nova | 17:24 | |
melwitt | stephenfin: while you're here, do you think you might be able to give this patch to use unittest.mock instead of third party mock a refresh from merge conflicts? https://review.opendev.org/c/openstack/nova/+/714676 prometheanfire was asking yesterday if we'd made progress on support for mock 4.0.2 https://review.opendev.org/765680 | 17:26 |
melwitt | *while you're here, I wanted to ask | 17:26 |
*** ociuhandu has quit IRC | 17:27 | |
*** ociuhandu_ has quit IRC | 17:28 | |
*** ociuhandu has joined #openstack-nova | 17:34 | |
*** luksky has quit IRC | 17:35 | |
*** ociuhandu has quit IRC | 17:39 | |
*** hoonetorg has joined #openstack-nova | 17:41 | |
*** jangutter_ has joined #openstack-nova | 17:43 | |
*** jangutter has quit IRC | 17:46 | |
*** k_mouza has quit IRC | 17:46 | |
*** gyee has joined #openstack-nova | 17:57 | |
*** noonedeadpunk_ is now known as noonedeadpunk | 18:01 | |
*** k_mouza has joined #openstack-nova | 18:11 | |
*** derekh has quit IRC | 18:15 | |
*** k_mouza has quit IRC | 18:15 | |
-openstackstatus- NOTICE: The Gerrit service on review.opendev.org is currently responding slowly or timing out due to resource starvation, investigation is underway | 18:16 | |
*** k_mouza has joined #openstack-nova | 18:17 | |
*** jangutter has joined #openstack-nova | 18:23 | |
*** k_mouza has quit IRC | 18:25 | |
*** jangutter_ has quit IRC | 18:25 | |
*** jangutte_ has joined #openstack-nova | 18:25 | |
*** dtantsur is now known as dtantsur|afk | 18:28 | |
*** jangutter has quit IRC | 18:28 | |
*** jangutte_ has quit IRC | 18:40 | |
*** jangutter has joined #openstack-nova | 18:40 | |
*** jangutter has quit IRC | 18:41 | |
*** jangutter has joined #openstack-nova | 18:42 | |
*** aj_mailing has joined #openstack-nova | 18:44 | |
*** nweinber has joined #openstack-nova | 18:52 | |
stephenfin | melwitt: Sorry, missed that. I'd deprioritized that because I couldn't figure out what the gain was. mock (the pypi package) is a rolling backport of upstream changes and as such, any bugs it introduces are things we're going to have to fix when we reach that future Python version anyway | 18:57 |
sean-k-mooney | stephenfin: not always | 18:58 |
stephenfin | so sticking with mock and simply getting it working with 4.0 seemed a wiser course of action, tbh | 18:58 |
melwitt | oh, hm | 18:58 |
sean-k-mooney | we have nit bugs in there backported implemation | 18:58 |
sean-k-mooney | that are not there in the native one | 18:58 |
stephenfin | I don't think so, at least not from reading upstream bug reports | 18:59 |
stephenfin | any bugs are also present in unittest.mock on the either the latest Python or Python master, I don't recall which | 18:59 |
melwitt | stephenfin: I see, ok, I can try that approach then. I didn't realize why the conversion patch wasn't being worked | 18:59 |
sean-k-mooney | our inablity to use one of the mock decortors is due to mock the lib vs unittest.mock | 18:59 |
stephenfin | sean-k-mooney: my understanding of that was that it was also an issue in the Python 3.9 unittest.mock implementation | 19:00 |
sean-k-mooney | i think its teh use of assert raises as a context manager actully | 19:00 |
stephenfin | I can root out the bug report in the morning (dinner time here) | 19:00 |
stephenfin | melwitt: I think that might be a wiser approach, but I'm not the only one with a say here. It just seems foolish to have to work around bugs with e.g. unittest.mock on Python 3.6 when mock 3.x+ doesn't have them | 19:01 |
*** andrewbonney has quit IRC | 19:03 | |
melwitt | stephenfin: no I think what you're saying makes sense, I think that would be a simpler way to address this | 19:03 |
sean-k-mooney | stephenfin: https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertRaises | 19:03 |
melwitt | I can put that together | 19:03 |
sean-k-mooney | with self.assertRaises(SomeException) as cm: | 19:03 |
sean-k-mooney | do_something() | 19:03 |
sean-k-mooney | stephenfin: that does not work with mock the lib | 19:04 |
sean-k-mooney | or at least it did not work in the past | 19:04 |
sean-k-mooney | perhaps its actully caused by soemthing else but that is what we belived it was blocking that form working in nova the last time we investigated | 19:05 |
*** martinkennelly has joined #openstack-nova | 19:16 | |
*** martinkennelly has quit IRC | 19:37 | |
*** waverider has joined #openstack-nova | 19:47 | |
*** waverider has quit IRC | 19:47 | |
*** waverider has joined #openstack-nova | 19:47 | |
*** waverider has quit IRC | 19:48 | |
*** waverider has joined #openstack-nova | 19:48 | |
*** waverider is now known as adrian-a | 19:49 | |
*** adrian-a has quit IRC | 19:51 | |
*** adrian-a_ has joined #openstack-nova | 19:54 | |
*** adrian-a_ has quit IRC | 19:54 | |
*** adrian-a has joined #openstack-nova | 19:55 | |
*** k_mouza has joined #openstack-nova | 19:58 | |
*** k_mouza has quit IRC | 20:03 | |
*** jangutter_ has joined #openstack-nova | 20:06 | |
*** hoonetorg has quit IRC | 20:08 | |
*** jangutter has quit IRC | 20:09 | |
*** jangutter has joined #openstack-nova | 20:11 | |
*** jangutter_ has quit IRC | 20:14 | |
*** adrian-a has quit IRC | 20:24 | |
*** adrian-a has joined #openstack-nova | 20:25 | |
*** ralonsoh_ has quit IRC | 20:28 | |
*** dave-mccowan has joined #openstack-nova | 20:31 | |
*** ociuhandu has joined #openstack-nova | 20:42 | |
*** ociuhandu has quit IRC | 20:46 | |
*** ociuhandu has joined #openstack-nova | 20:48 | |
*** ociuhandu has quit IRC | 20:52 | |
*** vishalmanchanda has quit IRC | 20:54 | |
*** ociuhandu has joined #openstack-nova | 20:59 | |
*** ociuhandu has quit IRC | 21:04 | |
*** sapd1 has quit IRC | 21:04 | |
*** ociuhandu has joined #openstack-nova | 21:10 | |
*** slaweq has quit IRC | 21:12 | |
*** slaweq has joined #openstack-nova | 21:13 | |
*** hack-char has quit IRC | 21:17 | |
*** hack-char has joined #openstack-nova | 21:17 | |
JamesBenson | Hi all, I've modified my nova.conf with `cpu_mode = host-model` in a mixed CPU environment, but not all of my CPU flags passed through. What else am I missing? | 21:57 |
*** rcernin has joined #openstack-nova | 22:02 | |
*** rcernin has quit IRC | 22:04 | |
*** rcernin has joined #openstack-nova | 22:05 | |
*** ociuhandu has quit IRC | 22:09 | |
*** raildo has quit IRC | 22:13 | |
*** ociuhandu has joined #openstack-nova | 22:15 | |
*** ociuhandu has quit IRC | 22:19 | |
*** ociuhandu has joined #openstack-nova | 22:20 | |
*** xek_ has quit IRC | 22:28 | |
*** ociuhandu has quit IRC | 22:34 | |
*** ociuhandu has joined #openstack-nova | 22:41 | |
*** ociuhandu has quit IRC | 22:41 | |
*** nweinber has quit IRC | 22:43 | |
*** slaweq has quit IRC | 23:23 | |
*** lemko3 has joined #openstack-nova | 23:28 | |
*** lemko has quit IRC | 23:31 | |
*** lemko3 is now known as lemko | 23:31 | |
openstackgerrit | melanie witt proposed openstack/nova stable/victoria: WIP [stable-only] Target cell for min bw migration service lookup https://review.opendev.org/c/openstack/nova/+/766364 | 23:40 |
*** fudunwei has quit IRC | 23:40 | |
*** k_mouza has joined #openstack-nova | 23:41 | |
sean-k-mooney | JamesBenson: host model will not pass all the flags | 23:42 |
sean-k-mooney | JamesBenson: some cpu flags are not virtualisable but the real reason is host model chose the clost model to you actual cpu listed in qemus/libvirts cpu model xml file | 23:43 |
sean-k-mooney | those models are ment to represent the common set of flag commen to a specific generation of a cpu not the specific sku | 23:44 |
sean-k-mooney | so if you cpu has feature that are not avaiable on other cpus in the same generation those feature flags likely wont be present | 23:44 |
*** k_mouza has quit IRC | 23:45 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!