| *** martinkennelly has quit IRC | 00:03 | |
| *** tosky has quit IRC | 00:05 | |
| *** ociuhandu has joined #openstack-nova | 00:07 | |
| *** tbachman has joined #openstack-nova | 00:07 | |
| *** bbowen has joined #openstack-nova | 00:08 | |
| *** bbowen_ has quit IRC | 00:10 | |
| *** ociuhandu has quit IRC | 00:14 | |
| *** zzzeek has quit IRC | 00:30 | |
| *** zzzeek has joined #openstack-nova | 00:32 | |
| *** arne_wiebalck has quit IRC | 00:53 | |
| *** arne_wiebalck has joined #openstack-nova | 00:53 | |
| *** rcernin has joined #openstack-nova | 01:17 | |
| *** LinPeiWen has joined #openstack-nova | 01:26 | |
| *** songwenping_ has joined #openstack-nova | 01:29 | |
| brinzhang0 | gmann: hi | 01:35 |
|---|---|---|
| brinzhang0 | gmann: https://review.opendev.org/c/openstack/tempest/+/769120 this tempest depends-on the nova patch, but it seems didnot active, could you give some guide? | 01:36 |
| *** macz_ has quit IRC | 01:49 | |
| *** gyee has quit IRC | 01:52 | |
| *** ociuhandu has joined #openstack-nova | 01:55 | |
| *** hamalq_ has quit IRC | 01:59 | |
| *** gyee has joined #openstack-nova | 02:03 | |
| *** ociuhandu has quit IRC | 02:08 | |
| *** zenkuro has joined #openstack-nova | 02:09 | |
| *** rcernin has quit IRC | 02:26 | |
| *** zzzeek has quit IRC | 02:30 | |
| *** zzzeek has joined #openstack-nova | 02:31 | |
| *** spatel has joined #openstack-nova | 02:44 | |
| *** tbarron has quit IRC | 02:52 | |
| *** artom has quit IRC | 02:52 | |
| *** artom has joined #openstack-nova | 02:53 | |
| *** rcernin has joined #openstack-nova | 02:58 | |
| *** mkrai has joined #openstack-nova | 03:04 | |
| *** rcernin has quit IRC | 03:10 | |
| *** psachin has joined #openstack-nova | 03:32 | |
| *** zzzeek has quit IRC | 03:43 | |
| *** zzzeek has joined #openstack-nova | 03:45 | |
| *** macz_ has joined #openstack-nova | 03:49 | |
| *** zzzeek has quit IRC | 03:53 | |
| *** macz_ has quit IRC | 03:54 | |
| *** zzzeek has joined #openstack-nova | 03:55 | |
| *** sapd1 has joined #openstack-nova | 03:57 | |
| *** zenkuro has quit IRC | 04:08 | |
| *** zenkuro has joined #openstack-nova | 04:09 | |
| *** zzzeek has quit IRC | 04:23 | |
| *** zzzeek has joined #openstack-nova | 04:25 | |
| *** ircuser-1 has joined #openstack-nova | 04:43 | |
| openstackgerrit | zhulipeng proposed openstack/nova master: Fixed multipath residue when evacuating the VM https://review.opendev.org/c/openstack/nova/+/767468 | 04:45 |
| *** ratailor has joined #openstack-nova | 04:57 | |
| *** mkrai has quit IRC | 05:16 | |
| *** mkrai_ has joined #openstack-nova | 05:16 | |
| *** ociuhandu has joined #openstack-nova | 05:32 | |
| *** evrardjp has quit IRC | 05:33 | |
| *** evrardjp has joined #openstack-nova | 05:33 | |
| *** whoami-rajat___ has joined #openstack-nova | 05:36 | |
| *** ociuhandu has quit IRC | 05:38 | |
| *** gyee has quit IRC | 05:44 | |
| *** macz_ has joined #openstack-nova | 05:51 | |
| *** macz_ has quit IRC | 05:55 | |
| *** hemanth_n has joined #openstack-nova | 06:04 | |
| *** spatel has quit IRC | 06:17 | |
| *** zoharm has joined #openstack-nova | 06:20 | |
| *** zoharm has quit IRC | 06:24 | |
| *** zzzeek has quit IRC | 06:31 | |
| *** zzzeek has joined #openstack-nova | 06:33 | |
| *** zzzeek has quit IRC | 06:46 | |
| *** zzzeek has joined #openstack-nova | 06:47 | |
| *** zenkuro has quit IRC | 06:47 | |
| *** zenkuro has joined #openstack-nova | 06:48 | |
| *** mkrai_ has quit IRC | 06:53 | |
| *** mkrai_ has joined #openstack-nova | 06:58 | |
| *** lpetrut has joined #openstack-nova | 07:12 | |
| openstackgerrit | Mamduh proposed openstack/os-vif stable/train: Refactor code of linux_net to more cleaner and increase performace https://review.opendev.org/c/openstack/os-vif/+/765912 | 07:17 |
| *** zzzeek has quit IRC | 07:17 | |
| *** zzzeek has joined #openstack-nova | 07:19 | |
| openstackgerrit | Mamduh proposed openstack/os-vif stable/train: Fix - os-vif fails to get the correct UpLink Representor https://review.opendev.org/c/openstack/os-vif/+/765970 | 07:25 |
| *** rpittau|afk is now known as rpittau | 07:33 | |
| brinzhang0 | gibi: pls review cyborg shelve/unshelve patch while you are free https://review.opendev.org/c/openstack/nova/+/729563, thanks | 07:36 |
| openstackgerrit | Mamduh proposed openstack/os-vif stable/stein: Refactor code of linux_net to more cleaner and increase performace https://review.opendev.org/c/openstack/os-vif/+/765914 | 07:42 |
| *** slaweq has joined #openstack-nova | 07:42 | |
| *** zzzeek has quit IRC | 07:45 | |
| *** zzzeek has joined #openstack-nova | 07:45 | |
| openstackgerrit | Mamduh proposed openstack/os-vif stable/stein: Fix - os-vif fails to get the correct UpLink Representor https://review.opendev.org/c/openstack/os-vif/+/765974 | 07:46 |
| *** zzzeek has quit IRC | 07:50 | |
| *** macz_ has joined #openstack-nova | 07:51 | |
| *** ralonsoh has joined #openstack-nova | 07:52 | |
| *** zzzeek has joined #openstack-nova | 07:53 | |
| *** gary_perkins has quit IRC | 07:54 | |
| *** macz_ has quit IRC | 07:56 | |
| *** gary_perkins has joined #openstack-nova | 07:57 | |
| *** zzzeek has quit IRC | 08:11 | |
| *** zzzeek has joined #openstack-nova | 08:11 | |
| *** andrewbonney has joined #openstack-nova | 08:16 | |
| *** dklyle has quit IRC | 08:16 | |
| *** zzzeek has quit IRC | 08:16 | |
| *** zzzeek has joined #openstack-nova | 08:18 | |
| *** tesseract has joined #openstack-nova | 08:18 | |
| gibi | brinzhang0: done, I have one more issue to fix then it is good to go from my perspective | 08:28 |
| brinzhang0 | gibi: good news, thanks | 08:29 |
| brinzhang0 | gibi: could you please review the PS21, comment by your suggestion https://review.opendev.org/c/openstack/nova/+/729563/21 | 08:32 |
| brinzhang0 | or I missed your mean | 08:33 |
| openstackgerrit | zhangtongjian proposed openstack/nova-specs master: remove unicode from code https://review.opendev.org/c/openstack/nova-specs/+/769260 | 08:38 |
| *** tosky has joined #openstack-nova | 08:39 | |
| *** zzzeek has quit IRC | 08:39 | |
| bauzas | good morning Nova | 08:41 |
| *** zzzeek has joined #openstack-nova | 08:41 | |
| *** ociuhandu has joined #openstack-nova | 08:49 | |
| openstackgerrit | Mamduh proposed openstack/os-vif stable/rocky: Refactor code of linux_net to more cleaner and increase performace https://review.opendev.org/c/openstack/os-vif/+/765962 | 08:55 |
| openstackgerrit | Mamduh proposed openstack/os-vif stable/rocky: Fix - os-vif fails to get the correct UpLink Representor https://review.opendev.org/c/openstack/os-vif/+/765977 | 08:55 |
| *** songwenping__ has joined #openstack-nova | 08:56 | |
| *** songwenping_ has quit IRC | 08:59 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Cyborg shelve/unshelve support https://review.opendev.org/c/openstack/nova/+/729563 | 09:01 |
| brinzhang0 | gibi: done | 09:01 |
| *** xek has joined #openstack-nova | 09:02 | |
| *** ociuhandu has quit IRC | 09:09 | |
| *** ociuhandu has joined #openstack-nova | 09:10 | |
| *** zzzeek has quit IRC | 09:11 | |
| *** zzzeek has joined #openstack-nova | 09:13 | |
| *** ociuhandu has quit IRC | 09:16 | |
| *** zoharm has joined #openstack-nova | 09:17 | |
| *** mkrai_ has quit IRC | 09:23 | |
| *** zzzeek has quit IRC | 09:26 | |
| *** zzzeek has joined #openstack-nova | 09:27 | |
| *** ociuhandu has joined #openstack-nova | 09:28 | |
| *** mkrai_ has joined #openstack-nova | 09:30 | |
| *** ociuhandu has quit IRC | 09:33 | |
| *** ociuhandu has joined #openstack-nova | 09:36 | |
| *** martinkennelly has joined #openstack-nova | 09:41 | |
| *** ociuhandu has quit IRC | 09:42 | |
| *** tkajinam has quit IRC | 09:42 | |
| *** zzzeek has quit IRC | 09:45 | |
| *** zzzeek has joined #openstack-nova | 09:47 | |
| *** ratailor_ has joined #openstack-nova | 09:54 | |
| *** derekh has joined #openstack-nova | 09:54 | |
| *** ratailor_ has quit IRC | 09:55 | |
| *** ratailor_ has joined #openstack-nova | 09:57 | |
| *** ratailor has quit IRC | 09:57 | |
| *** zoharm has quit IRC | 09:57 | |
| *** ratailor_ has quit IRC | 09:57 | |
| openstackgerrit | Mamduh proposed openstack/os-vif stable/rocky: Refactor code of linux_net to more cleaner and increase performace https://review.opendev.org/c/openstack/os-vif/+/765962 | 09:58 |
| openstackgerrit | Mamduh proposed openstack/os-vif stable/rocky: Fix - os-vif fails to get the correct UpLink Representor https://review.opendev.org/c/openstack/os-vif/+/765977 | 09:58 |
| *** ratailor has joined #openstack-nova | 09:58 | |
| *** ratailor has quit IRC | 09:59 | |
| *** ratailor has joined #openstack-nova | 10:02 | |
| *** ociuhandu has joined #openstack-nova | 10:09 | |
| stephenfin | gibi: I'm looking at a bug report where cold migration fails for an SR-IOV instance with "Port update failed for port XXX: Unable to correlate PCI slot 0000:xx:yy.z". Does that ring a bell? | 10:09 |
| stephenfin | It sounds familiar, but I can only find bugs related to unshelve, not cold migration | 10:10 |
| stephenfin | Ah, got it https://bugs.launchpad.net/nova/+bug/1512880 | 10:12 |
| openstack | Launchpad bug 1512880 in OpenStack Compute (nova) newton "Failed cold migration with SR-IOV" [Medium,Fix released] | 10:12 |
| *** songwenping__ has quit IRC | 10:23 | |
| *** ociuhandu has quit IRC | 10:31 | |
| *** rpittau is now known as rpittau|bbl | 10:32 | |
| *** mkrai_ has quit IRC | 10:39 | |
| *** ociuhandu has joined #openstack-nova | 10:40 | |
| *** mkrai has joined #openstack-nova | 10:41 | |
| *** ratailor has quit IRC | 10:54 | |
| gibi | brinzhang0, stephenfin: sorry, I was away | 10:55 |
| *** ociuhandu has quit IRC | 11:13 | |
| *** ociuhandu has joined #openstack-nova | 11:16 | |
| *** ratailor has joined #openstack-nova | 11:16 | |
| *** mkrai has quit IRC | 11:16 | |
| *** zzzeek has quit IRC | 11:26 | |
| *** zzzeek has joined #openstack-nova | 11:28 | |
| *** sapd1 has quit IRC | 11:30 | |
| *** zzzeek has quit IRC | 11:43 | |
| *** zzzeek has joined #openstack-nova | 11:43 | |
| gibi | brinzhang0: one more thing https://review.opendev.org/c/openstack/nova/+/729563 | 11:45 |
| brinzhang0 | gibi: ok, can be remove the excetpion block | 11:48 |
| gibi | brinzhang0: yepp | 11:48 |
| gibi | then I will be +2 | 11:48 |
| brinzhang0 | cool | 11:48 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: WIP: Replace tenant* with project* in codes https://review.opendev.org/c/openstack/nova/+/769329 | 11:48 |
| gibi | brinzhang0: I also started reviewing the tenant_id replacement series and left some comments. I haven't reached the top of that series but I will continue today | 11:49 |
| *** ociuhandu has quit IRC | 11:50 | |
| brinzhang0 | gibi: thank you very much, I will update it after you completed review | 11:50 |
| gibi | brinzhang0: OK, cool | 11:50 |
| brinzhang0 | and there are some novaclient patch and sdk patach need to be submit, but it not urgent | 11:51 |
| gibi | brinzhang0: yepp, does patches needs to be proposed during this cycle too | 11:52 |
| gibi | so that we can have a client release that compatible with the new microverison | 11:52 |
| brinzhang0 | gibi: yes | 11:52 |
| *** mkrai has joined #openstack-nova | 11:53 | |
| brinzhang0 | I just dont want to change the v288, if that need todo, it will be waste so much time :( | 11:53 |
| brinzhang0 | but it depends on os-hypervisor and novnc feature ^^ | 11:54 |
| gibi | brinzhang0: I also reviewed the novnc password patch yesterday and there are some upgrade pieces missing there | 11:55 |
| gibi | right now every 2.88 candidate is blocked by comments, stephenfin works on hypervisor patch to be in sync in the latest spec amendment | 11:55 |
| brinzhang0 | gibi: yeah, I have seen, while we have time will be updated, in latest two days | 11:55 |
| gibi | OK | 11:56 |
| brinzhang0 | yes, I saw the spec update, but there is no time to review into, I will try my best to review and follow this patch asap | 11:57 |
| *** LinPeiWen has quit IRC | 11:58 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Cyborg shelve/unshelve support https://review.opendev.org/c/openstack/nova/+/729563 | 11:58 |
| brinzhang0 | gibi: done by cyborg shelve/unshelve patch, and test the test_api.file in my local, it was past | 11:58 |
| gibi | brinzhang0: looking... | 11:58 |
| *** bbowen has quit IRC | 12:02 | |
| gibi | brinzhang0: thanks. I'm +2 now | 12:02 |
| gibi | stephenfin, bauzas: ^^ shelve - unshelve support with cyborg accelerators looks good to me now but needs a second core | 12:03 |
| brinzhang0 | gibi: thanks | 12:04 |
| brinzhang0 | stephenfin, bauzas: pls review this patch wile you have free time, thanks | 12:04 |
| *** bbowen has joined #openstack-nova | 12:04 | |
| *** bbowen has quit IRC | 12:07 | |
| *** bbowen has joined #openstack-nova | 12:08 | |
| brinzhang0 | gibi: https://review.opendev.org/c/openstack/nova/+/767251 this is a samll change, gmann have already +2 for it, pls review | 12:11 |
| gibi | looking | 12:12 |
| *** ratailor has quit IRC | 12:15 | |
| gibi | brinzhang0: I have one issue about json vs. single quote usage in the example | 12:16 |
| gibi | https://review.opendev.org/c/openstack/nova/+/767251 | 12:16 |
| brinzhang0 | gibi: yeah, will be update | 12:17 |
| *** zzzeek has quit IRC | 12:20 | |
| *** ociuhandu has joined #openstack-nova | 12:20 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Improving the description for unshelve request body https://review.opendev.org/c/openstack/nova/+/767251 | 12:21 |
| *** mkrai has quit IRC | 12:21 | |
| brinzhang0 | gibi: done | 12:21 |
| gibi | looking | 12:22 |
| brinzhang0 | gibi: thanks | 12:23 |
| gibi | gmann: brinzhang0 respun https://review.opendev.org/c/openstack/nova/+/767251 now I'm +2. could you re-review it? | 12:23 |
| *** xek has quit IRC | 12:24 | |
| *** xek has joined #openstack-nova | 12:24 | |
| *** zzzeek has joined #openstack-nova | 12:24 | |
| *** ociuhandu has quit IRC | 12:30 | |
| *** tbarron has joined #openstack-nova | 12:32 | |
| *** ociuhandu has joined #openstack-nova | 12:37 | |
| *** ociuhandu has quit IRC | 12:41 | |
| *** ociuhandu has joined #openstack-nova | 12:41 | |
| *** ociuhandu has quit IRC | 12:42 | |
| *** ociuhandu has joined #openstack-nova | 12:44 | |
| *** rpittau|bbl is now known as rpittau | 12:44 | |
| *** Luzi has joined #openstack-nova | 12:55 | |
| openstackgerrit | Takashi Natsume proposed openstack/python-novaclient master: Deprecate agent commands and APIs https://review.opendev.org/c/openstack/python-novaclient/+/769068 | 12:57 |
| *** ociuhandu has quit IRC | 13:02 | |
| *** ociuhandu has joined #openstack-nova | 13:05 | |
| *** hemanth_n has quit IRC | 13:10 | |
| *** ociuhandu has quit IRC | 13:10 | |
| *** ociuhandu has joined #openstack-nova | 13:13 | |
| *** whoami-rajat___ is now known as whoami-rajat__ | 13:16 | |
| *** hemna has quit IRC | 13:19 | |
| *** ociuhandu has quit IRC | 13:20 | |
| *** hemna has joined #openstack-nova | 13:20 | |
| *** mkrai has joined #openstack-nova | 13:26 | |
| *** ociuhandu has joined #openstack-nova | 13:31 | |
| *** ociuhandu has quit IRC | 13:31 | |
| *** ociuhandu has joined #openstack-nova | 13:32 | |
| *** ociuhandu has quit IRC | 13:38 | |
| *** mgariepy has joined #openstack-nova | 13:40 | |
| *** ociuhandu has joined #openstack-nova | 13:42 | |
| *** Luzi has quit IRC | 13:43 | |
| *** macz_ has joined #openstack-nova | 13:54 | |
| *** macz_ has quit IRC | 13:59 | |
| bauzas | gibi: ack, will look at the shelve cyborg support | 14:03 |
| gibi | bauzas: thanks | 14:03 |
| bauzas | that reminds me I have to rebase my own series on routed networks | 14:04 |
| gibi | stephenfin: I reviewed https://review.opendev.org/c/openstack/nova/+/758396 and I have some questions inline. It was a long step forward, my brain hurts :) | 14:08 |
| gibi | I need some distraction now | 14:08 |
| stephenfin | heh, no problem. Stuck on that PCI unshelve issue from this morning (it's a different issue, it seems) but I'll take a look at some point today, hopefully | 14:09 |
| stephenfin | and thanks! | 14:09 |
| sean-k-mooney | i am reliably informed that the internet has many distrcations | 14:09 |
| sean-k-mooney | stephenfin: do you mean https://bugzilla.redhat.com/show_bug.cgi?id=1911710 | 14:10 |
| openstack | bugzilla.redhat.com bug 1911710 in openstack-nova "[osp 13][neutron] cold migration fails for sriov instance with: Port update failed for port <uuid>c: Unable to correlate PCI slot" [Urgent,New] - Assigned to nova-maint | 14:10 |
| stephenfin | yup | 14:10 |
| sean-k-mooney | cause that is not unshelve | 14:10 |
| sean-k-mooney | different code path | 14:10 |
| gibi | sean-k-mooney: yeah :) | 14:10 |
| sean-k-mooney | the error is raised form here https://github.com/openstack/nova/blob/34c5df7b2b8c7eebbfc8aa0bc3edba501dddcb61/nova/network/neutron.py#L3396-L3398 | 14:12 |
| sean-k-mooney | and it only happens if we have not claimed the pci device we are trying to update the neutron port with if i recall correctly | 14:12 |
| stephenfin | My thinking was that there had been an unshelve on the host before that was using an old record, and the cold migrated instance was trying to use the same record | 14:12 |
| sean-k-mooney | no that gives you a differnet error | 14:13 |
| stephenfin | I'm trying to write a functional test to prove out that theory but have got stuck in the weeds | 14:13 |
| sean-k-mooney | you get someting like libvirtError: Requested operation is not valid: PCI device 0000:5d:17.4 is in use by driver QEMU, domain instance-00003be0 | 14:13 |
| sean-k-mooney | in that case e.g. a libvirt error | 14:13 |
| stephenfin | Ah | 14:14 |
| *** tosky has quit IRC | 14:15 | |
| *** tosky_ has joined #openstack-nova | 14:16 | |
| sean-k-mooney | im donwloadign the customer logs to take a quick look but i would suspect that the device its trying to use is unclaimed | 14:16 |
| *** tosky_ is now known as tosky | 14:16 | |
| stephenfin | hmm, okay if you're looking at that I'll got back to the os-hypervisors work | 14:16 |
| sean-k-mooney | im only going to look at it breifly but want to clarify a few things as peopel have mentioned rebuilds in it so i want to confirm what operation is actully happening | 14:17 |
| sean-k-mooney | ill let you know if i find anything | 14:18 |
| *** qqmber has joined #openstack-nova | 14:18 | |
| stephenfin | On that note, gibi: currently each entry in the 'hypervisors' field of the '/os-hypervisors/detail' response is identical to what '/os-hypervisors/{hypervisor}' returns. If I'm adding 'uptime' to the latter, I assume I should add it to the former also? | 14:18 |
| stephenfin | as an aside, the whole '/os-hypervisors/detail' API is a bit weird and fairly "non-REST'ful" | 14:19 |
| sean-k-mooney | /os-hypervisors/detail is the list endpoint | 14:19 |
| sean-k-mooney | right | 14:20 |
| sean-k-mooney | so i would expect it to be the same | 14:20 |
| sean-k-mooney | well the detailed list endpoint | 14:20 |
| sean-k-mooney | vs just /os-hypervisors | 14:20 |
| stephenfin | Yeah, it's a variant of the list endpoint but with additional detail in each resource | 14:20 |
| stephenfin | I'd expect it to be the same too | 14:20 |
| *** artom has quit IRC | 14:20 | |
| sean-k-mooney | for me you are reall adding the uptime to the os-hyperviors resource | 14:21 |
| sean-k-mooney | rather then just that specific endpoint | 14:21 |
| sean-k-mooney | so showing it in detail makes sense | 14:21 |
| sean-k-mooney | where as previously it was on the stats resouce | 14:22 |
| stephenfin | makes sense | 14:23 |
| *** sapd1 has joined #openstack-nova | 14:25 | |
| sean-k-mooney | it is a migration by the way | 14:25 |
| sean-k-mooney | not a rebuild | 14:25 |
| *** artom has joined #openstack-nova | 14:26 | |
| bauzas | gibi: see https://review.opendev.org/c/openstack/nova/+/729563/26/nova/api/openstack/compute/shelve.py#59 | 14:29 |
| bauzas | unfortunately, ship has sailed for a while | 14:29 |
| bauzas | stephenfin: ^ look too | 14:30 |
| bauzas | AFAIK, we were not blocking flavors using this key before | 14:30 |
| bauzas | stephenfin: what's the correct behaviour when I ask to create a new instance with an unknown key ? | 14:31 |
| bauzas | like 'sylvainb:nice' | 14:31 |
| sean-k-mooney | stephenfin: http://paste.openstack.org/show/801414/ | 14:32 |
| bauzas | I guess this would silently be accepted, right? | 14:32 |
| sean-k-mooney | bauzas: you mean a custom extra spec | 14:33 |
| stephenfin | bauzas: Depends on the API version | 14:33 |
| sean-k-mooney | we allwo that as it might be used by a custome schduler filter | 14:33 |
| bauzas | sean-k-mooney: I mean, what would happen if I was creating a flavor with accel:device_profile metadata key inside without using Cyborg at all ? | 14:34 |
| bauzas | I would expect my instance to be created | 14:34 |
| sean-k-mooney | oh thats allowed | 14:34 |
| sean-k-mooney | it will just not do what you want | 14:34 |
| bauzas | sure | 14:34 |
| bauzas | but here, see | 14:34 |
| sean-k-mooney | we will likely fail because we cant look it up | 14:34 |
| sean-k-mooney | e.g. the device profile | 14:35 |
| bauzas | people creating flavors with this key would previously get a 200 | 14:35 |
| sean-k-mooney | ya | 14:35 |
| bauzas | and now we're returning a 403 because of the cyborg deco | 14:35 |
| bauzas | this is said | 14:35 |
| bauzas | sad | 14:35 |
| sean-k-mooney | sure | 14:35 |
| bauzas | this would have required a microversion | 14:35 |
| sean-k-mooney | no | 14:35 |
| sean-k-mooney | extra specs never require a microverion | 14:36 |
| sean-k-mooney | they are an unversioned part of the api | 14:36 |
| bauzas | changing a 200 to 403 ? | 14:36 |
| dansmith | anything could become a 403 at any point, right? | 14:36 |
| dansmith | like you stop having permission to do something | 14:36 |
| sean-k-mooney | well via a policy change yep | 14:36 |
| bauzas | 403s are said to be accepted without new microversions | 14:36 |
| bauzas | but there is a but | 14:37 |
| bauzas | https://docs.openstack.org/nova/latest/contributor/microversions.html#f2 | 14:37 |
| bauzas | getting a 403 because keystone check obviously doesn't require a new microversion | 14:37 |
| sean-k-mooney | bauzas: to get the flavor extra spec validation you have to opt into it via a new microverion | 14:37 |
| bauzas | either way, the ship has sailed | 14:38 |
| bauzas | this deco is there for a while | 14:38 |
| bauzas | and fwiw, happy to see you around dansmith :) | 14:38 |
| sean-k-mooney | right but fundementally there is noting broken or wrong with this | 14:38 |
| dansmith | bauzas: :) | 14:38 |
| bauzas | sean-k-mooney: sure | 14:38 |
| bauzas | anyway, let's continue to review the change | 14:39 |
| sean-k-mooney | the only way to prevent this is to require that operators addign custom extra specs use either no namespace or custom: | 14:39 |
| sean-k-mooney | that would be an improvment in my view but it would be an api change which would need a microverion for sure | 14:39 |
| bauzas | sean-k-mooney: on a side note, https://review.opendev.org/c/openstack/nova/+/729563/26/nova/api/openstack/compute/shelve.py#59 means that now when you shelve, you're getting a 500 with cyborg, right? | 14:39 |
| bauzas | since the exception wrapper is just added but the decorator was existing... | 14:40 |
| sean-k-mooney | well we have patchs to enable cyborg shelve support right | 14:40 |
| sean-k-mooney | oh it is the patch | 14:41 |
| sean-k-mooney | exception.ForbiddenWithAccelerators should not be raised here anymore | 14:41 |
| sean-k-mooney | bauzas: i havent review this in a while | 14:42 |
| bauzas | sean-k-mooney: well, we decorated shelve() a while ago | 14:43 |
| sean-k-mooney | why would self.compute_api.shelve(context, instance) raise that with this chagne? | 14:43 |
| sean-k-mooney | bauzas: yes i know | 14:43 |
| sean-k-mooney | but that decorator should be removed with this patch | 14:43 |
| bauzas | so we were returning ForbiddenWithAccelerators up to the API | 14:43 |
| sean-k-mooney | that was the whole point | 14:43 |
| sean-k-mooney | we were not going to require a new micorverion for unshelve with cyborg | 14:43 |
| bauzas | so in theory we should have managed such exception | 14:43 |
| *** mgariepy has quit IRC | 14:43 | |
| bauzas | because afaics, we were just passing it thru | 14:44 |
| bauzas | leading to a 500 | 14:44 |
| dansmith | I'm super confused | 14:44 |
| bauzas | now, this patch addes the exception handle | 14:44 |
| dansmith | the point of the decorator was to make the 500 into 403s, acting like "you don't have permission" instead of "this doesn't work" | 14:44 |
| dansmith | so we could enable it later, | 14:44 |
| dansmith | since this was not a new api, just a hole we created | 14:44 |
| sean-k-mooney | so https://review.opendev.org/c/openstack/nova/+/729563/26/nova/compute/api.py#4166 | 14:44 |
| bauzas | dansmith: I totally get it | 14:45 |
| sean-k-mooney | we are doing @block_accelerators(until_service=54) | 14:45 |
| sean-k-mooney | we could also just remove the decorator | 14:45 |
| dansmith | catching the exception now is just to handle walking over the service version right? | 14:45 |
| bauzas | dansmith: but afaics, we were not handling such exception on the API side | 14:45 |
| dansmith | right, exactly, until version 54 | 14:45 |
| *** mgariepy has joined #openstack-nova | 14:46 | |
| sean-k-mooney | i tought we were elsewhwere | 14:46 |
| dansmith | hmm, | 14:47 |
| dansmith | so ForbiddenWithAccelerators has code=403, | 14:47 |
| dansmith | but it doesn't inherit from Forbidden | 14:47 |
| dansmith | so ... maybe we thought we were, but aren't? | 14:47 |
| dansmith | does the API handle anything with code= set and turn that into an http code? | 14:47 |
| sean-k-mooney | i think it does | 14:48 |
| dansmith | if so, then we should be good | 14:48 |
| bauzas | ah-ha ok | 14:48 |
| sean-k-mooney | i think we have a generic handeler for anything that inherits form NovaException | 14:48 |
| dansmith | which also means we probably don't need this special catch | 14:49 |
| bauzas | my only worry is that this handler was returning a 500 | 14:49 |
| bauzas | but given code=403, I guess we're safe | 14:49 |
| dansmith | see, NovaException defaults to code=500, | 14:49 |
| dansmith | so this overrides to 403 which I think is supposed to make us not 500 when this bubbles all the way to the api | 14:49 |
| bauzas | yup, from what I remind | 14:49 |
| dansmith | I'll reply to bauzas | 14:49 |
| bauzas | cool | 14:50 |
| dansmith | as I need a gerrit comment karma in 2021 :P | 14:50 |
| *** ociuhandu has quit IRC | 14:50 | |
| *** ociuhandu has joined #openstack-nova | 14:50 | |
| sean-k-mooney | we probaly could extent that api samples to assert the correct behavior | 14:51 |
| dansmith | do we have api samples tests for failures? I didn't think we did | 14:51 |
| sean-k-mooney | not sure but im pretty sure we dont have any api sample tests for cyborg integration | 14:51 |
| sean-k-mooney | i think we just have https://github.com/openstack/nova/blob/261416aeb0187cc7d420bb74d8b330aa66cc37b6/nova/tests/functional/api_sample_tests/test_shelve.py | 14:53 |
| bauzas | oh no, we don't hzve them :) | 14:53 |
| dansmith | man, it's going to take me a while to get used to new gerrit | 14:53 |
| dansmith | it was only released for one day before I disappeared in 2020 and it looks so foreign to me | 14:53 |
| sean-k-mooney | ya part of it remind me of really really old gerrit | 14:54 |
| sean-k-mooney | but i keep going to click on things that have moved | 14:54 |
| *** ociuhandu has quit IRC | 14:54 | |
| gibi | stephenfin: lets add uptime to both response | 14:55 |
| bauzas | dansmith: good luck with the new gerrit | 14:56 |
| gibi | dansmith: hey, welcome back! | 14:56 |
| dansmith | gibi: o/ | 14:56 |
| bauzas | but I'm finally used to it | 14:56 |
| bauzas | haven't seen yet any fancy new feature that makes it worth tho | 14:56 |
| dansmith | gotta move everything around in a UI every 18 months to stave off dementia I guess | 14:57 |
| gibi | bauzas: one big plus for me that now gerrit shows diffs due to rebase with a different color that diff due the the patch I'm reviewing | 14:57 |
| dansmith | orly | 14:57 |
| bauzas | ah, gtk then | 14:57 |
| bauzas | haven't seen it yet | 14:58 |
| dansmith | I think they could probably have done that without moving everything | 14:58 |
| sean-k-mooney | gibi: oh i havent noticed that yet | 14:58 |
| gibi | for example there are orange lines here due to six removal https://review.opendev.org/c/openstack/nova/+/764292/6..9/nova/api/openstack/compute/servers.py | 14:59 |
| bauzas | dansmith: fwiw, I'll require your expertise in a few weeks for the compute RPC API version bump, still stuck with damn errors | 14:59 |
| sean-k-mooney | dansmith: well im pretty sure the version we were using was eol | 14:59 |
| bauzas | it was | 14:59 |
| sean-k-mooney | dansmith: so just form a security and manatiance point of view we would have needed to eventually move | 14:59 |
| dansmith | bauzas: roger | 14:59 |
| dansmith | sean-k-mooney: no, I know ;) | 15:00 |
| bauzas | and I've been told intermediate versions were providing both UIs | 15:00 |
| sean-k-mooney | yes | 15:00 |
| bauzas | but we were so lagging that when we jumped straight, gerrit removed the old UI meanwhile | 15:00 |
| sean-k-mooney | they did that for about a year or so | 15:00 |
| bauzas | \o/ | 15:00 |
| sean-k-mooney | yep thats effectivly what happened | 15:01 |
| *** nweinber has joined #openstack-nova | 15:02 | |
| *** ociuhandu has joined #openstack-nova | 15:03 | |
| * bauzas should consider asking officially to change his last name to 'Bauzas' | 15:09 | |
| bauzas | this would make our conversations much simplier | 15:09 |
| stephenfin | or, you know, change your nick :) | 15:09 |
| bauzas | you can't imagine how many colleagues were thinking that my last name was ending with an 's' | 15:10 |
| bauzas | damn IRC | 15:10 |
| bauzas | gosh, the cyborg shelve patch is not exactly hairy, but I'd have preferred it being split between the API change and the RPC changes | 15:12 |
| stephenfin | from my brief look, that's probably wise | 15:13 |
| stephenfin | API last, of course | 15:14 |
| bauzas | gibi: any idea why there are conductor changes with https://review.opendev.org/c/openstack/nova/+/729563/26/nova/conductor/manager.py ? | 15:14 |
| bauzas | stephenfin: from someone who fixed some RPC compat break from the last cyborg patch, please understand my cautiousness | 15:14 |
| *** sapd1 has quit IRC | 15:15 | |
| gibi | bauzas: unshelve going through the conductor as it needs to call the scheduler | 15:15 |
| gibi | after shelve offload | 15:15 |
| bauzas | gibi: in rebuild_instance() ? | 15:16 |
| bauzas | anyway, taxi time | 15:17 |
| bauzas | will figure this out when I'm back, 15 min-ish | 15:17 |
| sean-k-mooney | rebuild hits the schduler too to assert the new image is valid for the current host so maybe that | 15:17 |
| gibi | bauzas: I have to guess it is historical, this patch went thorough many many revision | 15:17 |
| bauzas | sean-k-mooney: I just honestly feel they added some fix in the same change | 15:17 |
| gibi | I will find the reason | 15:17 |
| bauzas | but that looks extra | 15:17 |
| sean-k-mooney | ill try to take a look eairlier today although i need to start working on something else too | 15:18 |
| gibi | bauzas: one thing that _create_and_bind_arq_for_instance() has been changed and that is called from multiple places | 15:18 |
| *** jangutter_ has joined #openstack-nova | 15:19 | |
| sean-k-mooney | they are changin form host to host.nodename | 15:19 |
| gibi | but the inlineing of _rebuild_cyborg_arq seems separate | 15:20 |
| sean-k-mooney | i think i reverted that in my rebuild patch for a reason | 15:20 |
| gibi | I think earlier _rebuild_cyborg_arq was extended to handle unshelve too but I asked not to do that | 15:21 |
| *** jangutter has quit IRC | 15:22 | |
| sean-k-mooney | oh they are moveing wherre we get the nodename | 15:23 |
| sean-k-mooney | yah i suspec there is a second caller to _create_and_bind_arq_for_instance | 15:23 |
| gibi | sean-k-mooney: in different action we have different source of the node | 15:23 |
| sean-k-mooney | that only has the hostname not the host | 15:24 |
| sean-k-mooney | here https://review.opendev.org/c/openstack/nova/+/729563/26/nova/conductor/manager.py#1251 | 15:24 |
| *** sapd1 has joined #openstack-nova | 15:28 | |
| sean-k-mooney | gibi: ya im not sure im a fan of folding _rebuild_cyborg_arq into the calling function | 15:31 |
| gibi | that could be a comment | 15:32 |
| sean-k-mooney | the other changes all look correct to me in the conductor manager however | 15:32 |
| sean-k-mooney | well it only had one caller | 15:33 |
| sean-k-mooney | and i intoduced it so ti could be reused for the other opertion so if we are not doing that removing it makes sense | 15:34 |
| sean-k-mooney | its just the calling function is already quite large so its was nice to have it broken out | 15:34 |
| *** sapd1 has quit IRC | 15:35 | |
| gibi | yeah | 15:36 |
| gibi | they tried to reuse it but that would neede a new flag | 15:36 |
| gibi | so I was against that | 15:36 |
| gibi | but we can keep it the hlper | 15:36 |
| gibi | helper | 15:36 |
| *** jangutter has joined #openstack-nova | 15:40 | |
| *** jangutter has quit IRC | 15:41 | |
| *** jangutter_ has quit IRC | 15:41 | |
| *** jangutter has joined #openstack-nova | 15:43 | |
| *** yoctozepto has quit IRC | 15:43 | |
| sean-k-mooney | its a nice to have rather then anything functional so not enough to -1 over | 15:44 |
| *** yoctozepto has joined #openstack-nova | 15:44 | |
| *** abhishekk has quit IRC | 15:44 | |
| *** dklyle has joined #openstack-nova | 15:45 | |
| *** jangutter_ has joined #openstack-nova | 15:48 | |
| *** abhishekk has joined #openstack-nova | 15:48 | |
| *** sapd1 has joined #openstack-nova | 15:50 | |
| *** jangutter has quit IRC | 15:51 | |
| *** macz_ has joined #openstack-nova | 15:57 | |
| *** macz_ has quit IRC | 16:01 | |
| *** gyee has joined #openstack-nova | 16:18 | |
| *** lpetrut has quit IRC | 16:21 | |
| *** sapd1 has quit IRC | 16:59 | |
| *** psachin has quit IRC | 17:00 | |
| *** mkrai has quit IRC | 17:03 | |
| *** rpittau is now known as rpittau|afk | 17:08 | |
| *** ociuhandu has quit IRC | 17:09 | |
| openstackgerrit | Dan Smith proposed openstack/nova stable/victoria: Warn when starting services with older than N-1 computes https://review.opendev.org/c/openstack/nova/+/761923 | 17:12 |
| dansmith | gibi: if you will double-check my edits here I can just +2+W this as I just fixed nits ^ | 17:13 |
| gibi | dansmith: looking | 17:14 |
| gibi | dansmith: thanks, looks good to me | 17:16 |
| dansmith | ack | 17:20 |
| *** ociuhandu has joined #openstack-nova | 17:21 | |
| *** ociuhandu has quit IRC | 17:26 | |
| *** jangutter_ has quit IRC | 17:41 | |
| *** jangutter has joined #openstack-nova | 17:43 | |
| *** tesseract has quit IRC | 17:52 | |
| *** efried has joined #openstack-nova | 17:59 | |
| *** derekh has quit IRC | 18:02 | |
| *** zenkuro has quit IRC | 18:21 | |
| *** ralonsoh has quit IRC | 18:21 | |
| *** dklyle has quit IRC | 18:34 | |
| *** dklyle has joined #openstack-nova | 18:34 | |
| *** whoami-rajat__ has quit IRC | 18:39 | |
| *** mgoddard has quit IRC | 18:45 | |
| *** andrewbonney has quit IRC | 19:15 | |
| *** _mlavalle3 has quit IRC | 19:38 | |
| *** qqmber has quit IRC | 20:08 | |
| *** slaweq has quit IRC | 20:33 | |
| *** dave-mccowan has joined #openstack-nova | 20:41 | |
| *** jmlowe has joined #openstack-nova | 21:00 | |
| *** tbachman has quit IRC | 21:23 | |
| *** tbachman has joined #openstack-nova | 21:26 | |
| *** ircuser-1 has quit IRC | 21:38 | |
| *** xek has quit IRC | 21:40 | |
| *** xek has joined #openstack-nova | 21:40 | |
| *** tosky_ has joined #openstack-nova | 22:12 | |
| *** tosky has quit IRC | 22:13 | |
| *** tosky_ is now known as tosky | 22:17 | |
| *** jamesdenton has quit IRC | 22:19 | |
| *** jamesden_ has joined #openstack-nova | 22:19 | |
| *** tbachman_ has joined #openstack-nova | 22:31 | |
| *** tbachman has quit IRC | 22:32 | |
| *** tbachman_ is now known as tbachman | 22:32 | |
| *** nweinber has quit IRC | 22:32 | |
| *** tkajinam has joined #openstack-nova | 23:01 | |
| *** dave-mccowan has quit IRC | 23:14 | |
| *** dave-mccowan has joined #openstack-nova | 23:15 | |
| *** zzzeek has quit IRC | 23:25 | |
| *** zzzeek has joined #openstack-nova | 23:27 | |
| *** rcernin has joined #openstack-nova | 23:33 | |
| *** rcernin has quit IRC | 23:53 | |
| *** rcernin has joined #openstack-nova | 23:56 | |
| *** rcernin has quit IRC | 23:59 | |
| openstackgerrit | Merged openstack/nova master: Improving the description for unshelve request body https://review.opendev.org/c/openstack/nova/+/767251 | 23:59 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!