*** pfire has joined #openstack-nova | 00:13 | |
pfire | resized a powered off instance, cannot start instance while it is in task state resize finish, cannot confirmresize while in vmstate stopped | 00:14 |
---|---|---|
pfire | should a resize have been allowed in the first place | 00:15 |
*** prometheanfire has joined #openstack-nova | 00:22 | |
*** prometheanfire has quit IRC | 00:24 | |
*** prometheanfire has joined #openstack-nova | 00:27 | |
prometheanfire | got around it by manually starting the instance, then resize could be confirmed (but instance showed up as stopped), and then once instance start was issued the instance was restarted (instead of the state being updated in the db) | 00:28 |
*** pfire has quit IRC | 00:30 | |
*** sapd1 has quit IRC | 00:40 | |
*** swp20 has joined #openstack-nova | 00:45 | |
*** LinPeiWen has joined #openstack-nova | 01:23 | |
*** brinzhang has joined #openstack-nova | 01:35 | |
*** songwenping_ has joined #openstack-nova | 01:38 | |
*** swp20 has quit IRC | 01:41 | |
*** dklyle has joined #openstack-nova | 01:46 | |
*** iurygregory has joined #openstack-nova | 02:07 | |
*** rcernin has quit IRC | 02:59 | |
*** rcernin has joined #openstack-nova | 03:08 | |
*** mkrai has joined #openstack-nova | 03:08 | |
*** rcernin has quit IRC | 03:19 | |
*** sapd1 has joined #openstack-nova | 03:20 | |
*** rcernin has joined #openstack-nova | 03:30 | |
*** psachin has joined #openstack-nova | 03:33 | |
*** hemanth_n has joined #openstack-nova | 03:44 | |
*** vishalmanchanda has joined #openstack-nova | 04:00 | |
openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Fix nova live migration task failed due respone value changed https://review.opendev.org/c/openstack/python-novaclient/+/769872 | 05:39 |
openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.88: Replace tenant* with project* in usage* commands https://review.opendev.org/c/openstack/python-novaclient/+/769675 | 05:39 |
openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.88: Replace tenant* with project* in quota* commands https://review.opendev.org/c/openstack/python-novaclient/+/769869 | 05:39 |
openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: DNM/TEST: function test https://review.opendev.org/c/openstack/python-novaclient/+/770060 | 05:39 |
*** macz_ has joined #openstack-nova | 05:44 | |
*** macz_ has quit IRC | 05:48 | |
*** sapd1 has quit IRC | 06:00 | |
*** mkrai has quit IRC | 07:13 | |
*** sapd1 has joined #openstack-nova | 07:14 | |
openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.88: Replace tenant* with project* in quota* commands https://review.opendev.org/c/openstack/python-novaclient/+/769869 | 07:33 |
openstackgerrit | Hemanth N proposed openstack/nova stable/train: Update pci stat pools based on PCI device changes https://review.opendev.org/c/openstack/nova/+/761725 | 07:36 |
*** ralonsoh has joined #openstack-nova | 07:40 | |
*** hoonetorg has joined #openstack-nova | 07:46 | |
*** slaweq has joined #openstack-nova | 07:51 | |
*** rcernin has quit IRC | 07:51 | |
*** mkrai has joined #openstack-nova | 07:53 | |
*** sapd1 has quit IRC | 08:04 | |
*** tesseract has joined #openstack-nova | 08:10 | |
*** andrewbonney has joined #openstack-nova | 08:13 | |
openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.88: Replace tenant* with project* in limits commands https://review.opendev.org/c/openstack/python-novaclient/+/770065 | 08:14 |
*** chengsheng1 has joined #openstack-nova | 08:14 | |
*** sapd1 has joined #openstack-nova | 08:18 | |
*** lee1 has joined #openstack-nova | 08:19 | |
*** lee1 is now known as lyarwood | 08:19 | |
gibi | good morning nova | 08:19 |
*** xek has joined #openstack-nova | 08:21 | |
chengsheng1 | Please help review the code: https://review.opendev.org/c/openstack/nova/+/762330/ | 08:26 |
openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.88: Replace tenant* with project* in usage* commands https://review.opendev.org/c/openstack/python-novaclient/+/769675 | 08:27 |
openstackgerrit | Manik Sidana proposed openstack/nova master: Fix typo https://review.opendev.org/c/openstack/nova/+/770067 | 08:32 |
*** rpittau|afk is now known as rpittau | 08:33 | |
openstackgerrit | Manik Sidana proposed openstack/nova master: Fix typo in warning message https://review.opendev.org/c/openstack/nova/+/770067 | 08:36 |
openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.88: Replace tenant* with project* in quota* commands https://review.opendev.org/c/openstack/python-novaclient/+/769869 | 08:38 |
*** ralonsoh has quit IRC | 08:38 | |
*** ralonsoh has joined #openstack-nova | 08:41 | |
brinzhang | gibi: good morning, noVNC patch has updated, pls review again https://review.opendev.org/c/openstack/nova/+/622336 | 08:44 |
gibi | brinzhang: ack, | 08:45 |
*** lpetrut has joined #openstack-nova | 08:45 | |
*** yoctozepto has quit IRC | 08:48 | |
*** chengsheng1 has quit IRC | 08:51 | |
*** chengsheng1 has joined #openstack-nova | 08:51 | |
*** kevinz has quit IRC | 08:53 | |
*** sapd1 has quit IRC | 09:16 | |
*** ociuhandu has joined #openstack-nova | 09:18 | |
*** zenkuro has joined #openstack-nova | 09:18 | |
*** vishalmanchanda has quit IRC | 09:18 | |
*** martinkennelly has joined #openstack-nova | 09:31 | |
gibi | lyarwood: if you have time could you check a tempest failure like https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_637/764040/8/check/nova-live-migration/637f5c6/testr_results.html based on logstash we have similar failures pretty fequrently | 09:33 |
gibi | http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22failed%20to%20reach%20available%20status%20(current%20detaching)%20within%20the%20required%20time%5C%22 | 09:33 |
lyarwood | gibi: oh fun, not this again | 09:43 |
*** ociuhandu has quit IRC | 09:43 | |
gibi | monday fun | 09:43 |
lyarwood | Device detach failed for vdb: Unable to detach the device from the live config. | 09:44 |
*** derekh has joined #openstack-nova | 09:44 | |
gibi | I'm not sure that it is only that test case failing with the same symptome | 09:44 |
openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.88: Replace tenant* with project* in limits commands https://review.opendev.org/c/openstack/python-novaclient/+/770065 | 09:52 |
*** ociuhandu has joined #openstack-nova | 09:53 | |
openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.88: Replace tenant* with project* in quota* commands https://review.opendev.org/c/openstack/python-novaclient/+/769869 | 09:55 |
lyarwood | gibi: melwitt wrote an ER query for this before the break in https://bugs.launchpad.net/nova/+bug/1882521 | 09:57 |
openstack | Launchpad bug 1882521 in OpenStack Compute (nova) ussuri "Failing device detachments on Focal" [Undecided,New] | 09:57 |
lyarwood | gibi / melwitt ; looks different to the previous hit within libvirtd logs at least, we only see the device_del commands from libvirtd to QEMU and not the DEVICE_DELETED events being emitted by QEMU. | 09:58 |
lyarwood | gibi / melwitt ; we can try increasing the initial wait again but that's another hackaround | 09:58 |
*** ociuhandu has quit IRC | 09:58 | |
lyarwood | gibi / melwitt ; the ultimate fix for this is waiting for libvirtd to emit events when detaching devices https://review.opendev.org/c/openstack/nova/+/749929 | 09:59 |
*** jangutter_ has joined #openstack-nova | 09:59 | |
gibi | lyarwood: could I help with ^^ somehow? | 10:00 |
openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.88: Replace tenant* with project* in limits commands https://review.opendev.org/c/openstack/python-novaclient/+/770065 | 10:01 |
lyarwood | gibi: I don't have any cycles to spend on it at the moment, feel free to take a look if you do, that's only a PoC change I was using to work out how to tap into the event framework within the libvirt driver | 10:01 |
gibi | lyarwood: ack, I might need more context but I will take a look at that patch | 10:02 |
*** jangutter has quit IRC | 10:03 | |
lyarwood | gibi: https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainEventID & https://libvirt.org/html/libvirt-libvirt-domain.html#virConnectDomainEventDeviceRemovedCallback for the libvirt specific docs | 10:03 |
*** ociuhandu has joined #openstack-nova | 10:09 | |
*** ociuhandu has quit IRC | 10:14 | |
*** ociuhandu has joined #openstack-nova | 10:15 | |
*** jangutter_ has quit IRC | 10:17 | |
*** jangutter has joined #openstack-nova | 10:20 | |
gibi | lyarwood: was this https://review.opendev.org/c/openstack/nova/+/749827 superseeded by https://review.opendev.org/c/openstack/nova/+/755799 ? | 10:21 |
*** jangutter_ has joined #openstack-nova | 10:21 | |
lyarwood | gibi: yeah sorry I'm not sure why I eneded up with a different change there | 10:22 |
gibi | lyarwood: OK I will drop that | 10:23 |
lyarwood | gibi: one thing I've just noticed, there's a 5 second gap between the first and second device_del request in libvirtd, my change was supposed to add a 10 second delay | 10:24 |
*** jangutter has quit IRC | 10:24 | |
gibi | I think on master we have inc_sleep_time=10 | 10:25 |
lyarwood | yeah I think the retry decorator only uses that for the second wait, ./me checks | 10:26 |
*** jangutter_ is now known as jangutter | 10:26 | |
*** ociuhandu has quit IRC | 10:29 | |
*** ociuhandu has joined #openstack-nova | 10:30 | |
gibi | it seem so | 10:31 |
openstackgerrit | Lucas Alvares Gomes proposed openstack/nova master: DO NOT REVIEW: Test OVN devstack module https://review.opendev.org/c/openstack/nova/+/748226 | 10:32 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: WIP/DNM libvirt: Start emitting DeviceRemovedEvent and DeviceRemovalFailedEvent events https://review.opendev.org/c/openstack/nova/+/749929 | 10:32 |
*** zenkuro has quit IRC | 10:33 | |
*** zenkuro has joined #openstack-nova | 10:33 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: WIP/DNM libvirt: Start emitting DeviceRemovedEvent and DeviceRemovalFailedEvent events https://review.opendev.org/c/openstack/nova/+/749929 | 10:37 |
*** dtantsur|afk is now known as dtantsur | 10:37 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: WIP/DNM libvirt: Start emitting DeviceRemovedEvent and DeviceRemovalFailedEvent events https://review.opendev.org/c/openstack/nova/+/749929 | 10:40 |
*** mkrai has quit IRC | 10:54 | |
*** nightmare_unreal has joined #openstack-nova | 10:56 | |
*** avolkov has joined #openstack-nova | 11:07 | |
*** ociuhandu has quit IRC | 11:18 | |
*** ociuhandu has joined #openstack-nova | 11:23 | |
*** ociuhandu has quit IRC | 11:28 | |
*** ociuhandu has joined #openstack-nova | 11:30 | |
*** zzzeek has quit IRC | 11:33 | |
*** ociuhandu has quit IRC | 11:35 | |
*** zzzeek has joined #openstack-nova | 11:35 | |
*** ociuhandu has joined #openstack-nova | 11:43 | |
stephenfin | gibi: Could you re +2 this, please? https://review.opendev.org/c/openstack/nova/+/769520/ | 11:44 |
gibi | stephenfin: oops I missed that, done noew | 11:46 |
gibi | now | 11:46 |
stephenfin | Also, gibi, lyarwood, sean-k-mooney: I addressed your concerns on that OSC change, I think https://review.opendev.org/c/openstack/python-openstackclient/+/762396/ | 11:46 |
stephenfin | gibi++ thanks | 11:46 |
gibi | I'm +1 on the osc patch too | 11:48 |
stephenfin | hurrah | 11:49 |
*** rcernin has joined #openstack-nova | 11:51 | |
*** ociuhandu has quit IRC | 11:51 | |
*** raildo has joined #openstack-nova | 11:53 | |
gibi | gmann: I still see tempest failing with "Multiple possible networks found, use a Network ID to be more specific." on master. e.g.: https://74ab9f21dcdd2e895607-6eadae60e9a1b03c6789f42d51c17d3a.ssl.cf2.rackcdn.com/756894/5/check/nova-next/1fb33ef/testr_results.html | 11:55 |
gibi | dansmith: I have two tempest failures in test_glance_direct_import_image_to_specific_stores[id-82fb131a-dd2b-11ea-aec7-340286b6c574] I tried to create a logstash signature for it but I failed | 11:56 |
gibi | 1) https://zuul.opendev.org/t/openstack/build/4a78ba5901474187a3bdc49cacf84b47/logs | 11:56 |
gibi | 2) https://zuul.opendev.org/t/openstack/build/9488788b59904e6f9bc1280f13fc0a6b/logs | 11:56 |
gibi | dansmith: is this the timeout failure you mentioned on the last week's meeting? | 11:57 |
sean-k-mooney | stephenfin: +1 also | 11:57 |
gibi | dansmith: I also see a full nova-ceph-multistore job timeout here https://zuul.opendev.org/t/openstack/build/8807547b038b4dd983fd7e0bb4cb4b40 it might be related too | 12:02 |
*** ociuhandu has joined #openstack-nova | 12:05 | |
*** hemanth_n has quit IRC | 12:06 | |
*** hemanth_n has joined #openstack-nova | 12:07 | |
*** mgariepy has quit IRC | 12:09 | |
*** ociuhandu has quit IRC | 12:11 | |
*** dviroel has joined #openstack-nova | 12:11 | |
*** zzzeek has quit IRC | 12:19 | |
*** rcernin has quit IRC | 12:21 | |
*** zzzeek has joined #openstack-nova | 12:21 | |
*** Oriz has joined #openstack-nova | 12:23 | |
*** ociuhandu has joined #openstack-nova | 12:24 | |
*** songwenping_ has quit IRC | 12:31 | |
*** songwenping_ has joined #openstack-nova | 12:32 | |
*** ociuhandu has quit IRC | 12:37 | |
*** Luzi has joined #openstack-nova | 12:56 | |
*** ociuhandu has joined #openstack-nova | 13:10 | |
*** mgariepy has joined #openstack-nova | 13:13 | |
*** ociuhandu has quit IRC | 13:14 | |
*** ociuhandu_ has joined #openstack-nova | 13:14 | |
*** artom has joined #openstack-nova | 13:21 | |
*** ociuhandu_ has quit IRC | 13:22 | |
*** lemko has quit IRC | 13:24 | |
*** lemko has joined #openstack-nova | 13:24 | |
*** lemko has quit IRC | 13:34 | |
*** lemko has joined #openstack-nova | 13:35 | |
*** ociuhandu has joined #openstack-nova | 13:35 | |
*** hemanth_n has quit IRC | 13:36 | |
*** ociuhandu has quit IRC | 13:40 | |
*** ociuhandu has joined #openstack-nova | 13:40 | |
*** ociuhandu has quit IRC | 13:40 | |
*** ociuhandu has joined #openstack-nova | 13:41 | |
*** ociuhandu has quit IRC | 13:41 | |
*** yoctozepto has joined #openstack-nova | 13:45 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor ResourceRequest constructor https://review.opendev.org/c/openstack/nova/+/769720 | 13:45 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support interface attach with QoS ports https://review.opendev.org/c/openstack/nova/+/756530 | 13:46 |
*** ociuhandu has joined #openstack-nova | 13:47 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Enable mypy on scheduler/report.py https://review.opendev.org/c/openstack/nova/+/765152 | 13:48 |
gibi | stephenfin: fix your comment in the qos series ^^ | 13:48 |
*** tbachman has quit IRC | 13:50 | |
*** tbachman has joined #openstack-nova | 13:52 | |
*** ralonsoh_ has joined #openstack-nova | 13:59 | |
*** ralonsoh has quit IRC | 13:59 | |
*** sapd1 has joined #openstack-nova | 14:00 | |
*** ralonsoh_ is now known as ralonsoh | 14:01 | |
*** Luzi has quit IRC | 14:04 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova stable/victoria: Add upgrade check about old computes https://review.opendev.org/c/openstack/nova/+/761924 | 14:05 |
stephenfin | gibi: Done. Think I'm +2 on that whole series. I'll leave it to you to find another reviewer | 14:06 |
stephenfin | sean-k-mooney would probably be good to have reviewing it since I think they're re-using part of it for another spec? | 14:07 |
gibi | stephenfin: thanks | 14:07 |
sean-k-mooney | stephenfin: am the routed networks stuff bauzas is doing? | 14:12 |
stephenfin | sean-k-mooney: no, gibi's "attach ports with QoS policies" series | 14:12 |
sean-k-mooney | stephenfin: the only part im reusing form that is the network info in the requst spec | 14:12 |
stephenfin | oh, it's something from bauzas' series you're reusing. nvm so | 14:13 |
sean-k-mooney | oh no i dont need that for anything as far as i am aware but i can review it in anycase | 14:13 |
bauzas | atm working on adding UTs for the WIP patch, btw. ;) | 14:13 |
sean-k-mooney | bauzas: did you see my comments on it | 14:13 |
sean-k-mooney | the functional tests are asserting incorrect behavior | 14:13 |
bauzas | sean-k-mooney: err, no | 14:14 |
sean-k-mooney | look at the move operation tests https://review.opendev.org/c/openstack/nova/+/749068/6/nova/tests/functional/test_servers.py | 14:15 |
sean-k-mooney | the test have 3 host and 2 segments | 14:15 |
sean-k-mooney | the first host is not on any segemnt and the other two are on one each | 14:15 |
sean-k-mooney | so the migrate live migrate and evacuate test should not pass | 14:15 |
bauzas | yup | 14:15 |
bauzas | what? | 14:16 |
sean-k-mooney | since there is not another host on the same segment | 14:16 |
sean-k-mooney | you cant change segments on any move operation | 14:16 |
bauzas | hmmm | 14:16 |
bauzas | then the implementation is not good | 14:16 |
bauzas | I asked for it last month | 14:16 |
sean-k-mooney | unfortunetly it appears so | 14:16 |
bauzas | and I thought we were supporting to move to other segments if they are in the same networks | 14:17 |
sean-k-mooney | no that would change the ip | 14:17 |
sean-k-mooney | segment are mapped to subnets | 14:17 |
bauzas | look at https://review.opendev.org/c/openstack/nova/+/749068/6/nova/scheduler/request_filter.py#316 | 14:17 |
sean-k-mooney | so changing a the segment changes the subnet | 14:17 |
bauzas | we get the all aggregates for the same network | 14:17 |
sean-k-mooney | yes that is for boot | 14:18 |
sean-k-mooney | for move opertation you have to get the aggreate for the current segment | 14:18 |
bauzas | okay, but then for moves, we should only ask for the existed aggregate then | 14:18 |
bauzas | hmmmm, ok | 14:18 |
bauzas | then we need to change this | 14:18 |
bauzas | there are no ways to have different behaviours for request filters | 14:19 |
sean-k-mooney | ya sorry for not seeing that before. we allso will need to add a 4th host that is connected to the same segment as host2 | 14:19 |
sean-k-mooney | bauzas: well if the port has an ip then you know its a move operation or they specified an ip | 14:20 |
sean-k-mooney | in both cases you need to limit the aggreates to the segment corresponing to that ip | 14:20 |
bauzas | sean-k-mooney: aaaaaah yeah | 14:20 |
bauzas | L310 then | 14:20 |
sean-k-mooney | so that can be your check i belive | 14:20 |
bauzas | yeah okay | 14:20 |
bauzas | then I need to know how to get the segment for the port | 14:21 |
bauzas | lemme look if we have it | 14:21 |
sean-k-mooney | you get the via the subnet the ip is from | 14:21 |
sean-k-mooney | then you can get the segment form the subnet | 14:21 |
bauzas | mmmm | 14:21 |
sean-k-mooney | i belive the port will have a subnet id in it | 14:22 |
bauzas | hopefully yeah IIRC | 14:22 |
gmann | gibi: ack, will check today | 14:22 |
gibi | thanks | 14:22 |
gmann | scenario tests should not have this error as Tempest explicitly pass the net id but I will debug if something else causing this or we miss some tests | 14:23 |
sean-k-mooney | bauzas: let me know if you have any issues with that and i can look into that more closely if needed | 14:23 |
* bauzas looks at https://docs.openstack.org/api-ref/network/v2/index.html?expanded=list-subnets-detail#subnets | 14:24 | |
bauzas | to know whether we can the segment from the subnet | 14:25 |
bauzas | as we already get the one from the network | 14:25 |
*** dave-mccowan has quit IRC | 14:25 | |
bauzas | actually wait | 14:25 |
bauzas | sean-k-mooney: I don't think we need to call Neutron for this | 14:25 |
sean-k-mooney | https://docs.openstack.org/api-ref/network/v2/index.html?expanded=list-subnets-detail#id263 | 14:25 |
sean-k-mooney | segment_id is there | 14:26 |
bauzas | sean-k-mooney: we could just get the network related to the subnet and lookup all the segments in this to match the related subnet | 14:26 |
bauzas | see my point ? | 14:26 |
sean-k-mooney | you could but that is more calls to neutron | 14:26 |
bauzas | no | 14:27 |
bauzas | https://review.opendev.org/c/openstack/nova/+/749068/6/nova/network/neutron.py | 14:27 |
bauzas | we already get all the segments | 14:27 |
sean-k-mooney | ah right | 14:27 |
bauzas | in https://review.opendev.org/c/openstack/nova/+/749068/6/nova/scheduler/utils.py we ask the network | 14:27 |
sean-k-mooney | so just filter them | 14:27 |
bauzas | so we get all the segments | 14:28 |
bauzas | and then we filter them | 14:28 |
bauzas | yeah | 14:28 |
*** dave-mccowan has joined #openstack-nova | 14:28 | |
bauzas | okay, I think it's simple to fix then | 14:28 |
sean-k-mooney | unfortunetly the segment dont have the subnet id | 14:28 |
bauzas | we have the subnet name | 14:29 |
bauzas | and the id actually | 14:29 |
sean-k-mooney | it does not have that eitehr | 14:29 |
sean-k-mooney | https://docs.openstack.org/api-ref/network/v2/index.html?expanded=show-segment-details-detail#show-segment-details | 14:29 |
bauzas | https://docs.openstack.org/api-ref/network/v2/index.html?expanded=list-subnets-detail#id264 is what we get | 14:30 |
*** nweinber has joined #openstack-nova | 14:30 | |
bauzas | when calling Neutron for a list of segments related to the network | 14:30 |
bauzas | and I can see both the name and id fields | 14:30 |
bauzas | because the object is the subnet, not the segment | 14:30 |
sean-k-mooney | right but right now we dont list all the subnets | 14:31 |
sean-k-mooney | we just get all the segment by the network id | 14:31 |
sean-k-mooney | so we need to have 1 call to get teh subnet | 14:31 |
sean-k-mooney | it has the segment id in it | 14:31 |
bauzas | oh shit, you're right | 14:32 |
sean-k-mooney | so instead of calling _get_segment_ids_for_network | 14:32 |
bauzas | I was looking at the wrong endpoint | 14:32 |
sean-k-mooney | we just need get_segment_id_for_port | 14:32 |
sean-k-mooney | that uses the subnet_id in the port to do a subnet show | 14:32 |
bauzas | yeah we can't filter | 14:32 |
sean-k-mooney | and pull out the id | 14:32 |
bauzas | ok I can try to fix this | 14:33 |
bauzas | anyway, good catch | 14:33 |
sean-k-mooney | ya its still just one call to neutron either gettign the segment by network or if it has an ip geting the segment for the current ip | 14:33 |
sean-k-mooney | bauzas: fyi the subnet in the port is in port[fixed_ips][0]['subnet_id'] | 14:35 |
sean-k-mooney | well port['fixed_ips'][0]['subnet_id'] for got the '' | 14:35 |
bauzas | yeah | 14:36 |
bauzas | I'm literrally hands-on :) | 14:36 |
bauzas | did a git stash for the UT work I was doing | 14:36 |
bauzas | and I'll have to change a few things | 14:36 |
bauzas | fortunately, you pinged me before I went too far | 14:37 |
*** ralonsoh has quit IRC | 14:37 | |
bauzas | behavioural-driven-development, that is. | 14:37 |
*** ralonsoh has joined #openstack-nova | 14:38 | |
*** tosky has joined #openstack-nova | 14:39 | |
*** ralonsoh has quit IRC | 14:40 | |
bauzas | sean-k-mooney: can we assume a port always have a fixed-ips list with ip addresses in it ? | 14:42 |
bauzas | I can be conservative and double-check we have a list of IPs, and if not, fallback to getting the network id | 14:43 |
bauzas | as we could boot with an unbound port | 14:43 |
bauzas | right ? | 14:43 |
sean-k-mooney | bauzas: no i t wont have a fix ip if it was a new boot | 14:45 |
sean-k-mooney | it will if it has an ip e.g. a move operation or they specified one | 14:45 |
bauzas | okay, so we need to be conservative | 14:45 |
sean-k-mooney | yep but if it has no fixed ip | 14:45 |
bauzas | sure, sec | 14:45 |
*** ociuhandu has quit IRC | 14:45 | |
sean-k-mooney | then any segment in the network is valid | 14:45 |
sean-k-mooney | so you can use the lent of the list to determin how to look it up | 14:46 |
*** ociuhandu has joined #openstack-nova | 14:46 | |
sean-k-mooney | e.g. if port['fixed_ips']: lookup_by_port_subnet else lookup_by_network | 14:46 |
bauzas | that's exactly what I wrotre | 14:48 |
bauzas | pasting it | 14:48 |
bauzas | hmpf, paste.o.o is super slow | 14:48 |
sean-k-mooney | ya it is weird | 14:50 |
bauzas | sean-k-mooney: https://pastebin.com/x0g0anRS | 14:50 |
bauzas | agreed with the logic ? | 14:50 |
bauzas | if so, adding the new neutron knob | 14:50 |
bauzas | (nevermind the pep8 indenting issue, fwiw :) ) | 14:51 |
sean-k-mooney | ya that works | 14:51 |
sean-k-mooney | although i kind of feel like lines 17-22 should be under the if on 13 | 14:52 |
sean-k-mooney | well if/else | 14:52 |
sean-k-mooney | i mean you dont need to do the if network_id as that will always be true | 14:52 |
sean-k-mooney | you could keep the if subnet_id but that will only be set if we go to line 14 in which case we know it wont be empty | 14:53 |
bauzas | yeah, I can improve this | 14:54 |
sean-k-mooney | so you can put lines 21 and 22 on line 15 and lines 18 and 19 on line 17 | 14:54 |
sean-k-mooney | but ya the logic looks correct to me | 14:54 |
*** spotz has joined #openstack-nova | 14:57 | |
*** lpetrut has quit IRC | 15:10 | |
*** ralonsoh has joined #openstack-nova | 15:16 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova stable/victoria: Reproduce bug 1907522 in functional test https://review.opendev.org/c/openstack/nova/+/769736 | 15:23 |
openstack | bug 1907522 in OpenStack Compute (nova) "test_*_with_qos_min_bw_allocation fails in the nova-multi-cell job with: nova.exception.MigrationPreCheckError: Migration pre-check error: Failed to create port bindings for host <host>" [High,In progress] https://launchpad.net/bugs/1907522 - Assigned to Balazs Gibizer (balazs-gibizer) | 15:23 |
openstackgerrit | Balazs Gibizer proposed openstack/nova stable/victoria: Fallback to same-cell resize with qos ports https://review.opendev.org/c/openstack/nova/+/769727 | 15:24 |
*** mgariepy has quit IRC | 15:30 | |
*** martinkennelly has quit IRC | 15:38 | |
*** brinzhang has quit IRC | 15:55 | |
*** dklyle has quit IRC | 15:55 | |
*** dklyle has joined #openstack-nova | 15:55 | |
*** macz_ has joined #openstack-nova | 15:59 | |
*** mgariepy has joined #openstack-nova | 16:06 | |
lyarwood | dansmith: https://review.opendev.org/c/openstack/nova-specs/+/769547 - would you mind hitting PS3 today? Should be good to go now. | 16:10 |
dansmith | roger | 16:11 |
lyarwood | cheers | 16:11 |
openstackgerrit | Dan Smith proposed openstack/nova-specs master: libvirt: Update instance machine type stash spec https://review.opendev.org/c/openstack/nova-specs/+/769547 | 16:15 |
*** ociuhandu has quit IRC | 16:16 | |
*** zenkuro has quit IRC | 16:17 | |
*** zenkuro has joined #openstack-nova | 16:17 | |
*** ociuhandu has joined #openstack-nova | 16:23 | |
*** efried has quit IRC | 16:29 | |
*** kashyap has joined #openstack-nova | 16:31 | |
*** Oriz has quit IRC | 16:32 | |
*** psachin has quit IRC | 16:33 | |
openstackgerrit | Merged openstack/nova-specs master: libvirt: Update instance machine type stash spec https://review.opendev.org/c/openstack/nova-specs/+/769547 | 16:38 |
*** efried has joined #openstack-nova | 16:38 | |
gibi | lyarwood: I'm looking at detach_device_with_retry() codepath detach_device_with_retry | 16:39 |
gibi | lyarwood: and wondering why we have the code set up in a way that we always call an intial detach then after it a detach in a loop | 16:40 |
*** mlavalle has quit IRC | 16:41 | |
gibi | lyarwood: also, I'm wondering what is the way _do_wait_and_retry_detach() normally exit the tool | 16:41 |
gibi | loop | 16:41 |
*** mlavalle has joined #openstack-nova | 16:41 | |
gibi | is it raises DeviceDetachFailed to signal that the detach is done? | 16:42 |
lyarwood | gibi: just in a call | 16:42 |
*** sapd1 has quit IRC | 16:43 | |
gibi | no worries, I will drop soon, so we can talk about it tomorrow morning | 16:43 |
lyarwood | gibi: ack if we could that would be great | 16:43 |
*** sapd1 has joined #openstack-nova | 16:44 | |
gibi | OK | 16:46 |
melwitt | gibi: IIRC it's because the initial detach "should" detach it from persistent + live config but the guest can refuse the live detach as it's an ACPI request. so we retry in case that happens (guest refusal by it's busy). under nominal conditions I think the loop detects it's detached in the first iteration and moves on | 16:48 |
melwitt | *bc it's busy | 16:48 |
gibi | melwitt: thanks. | 16:51 |
gibi | melwitt: both the initial and the retry loop calls _try_detach_device() _try_detach_device | 16:52 |
gibi | https://github.com/openstack/nova/blob/745f835e9d8931261501747130165824334abb4b/nova/virt/libvirt/guest.py#L404 | 16:52 |
gibi | melwitt: so if the first all to _try_detach_device() finishes without exception then when we call the retry loop it calls _try_detach_device() again that will detach again | 16:53 |
gibi | * first call | 16:54 |
melwitt | yeah, IIRC the second call will be a no-op if the guest detached the live config the first call | 16:55 |
*** gyee has joined #openstack-nova | 16:55 | |
melwitt | if the first call did not result in detach of the live config, it will loop N times to keep trying | 16:55 |
gibi | melwitt: ohh, is it because we have the condition in the loop config = get_device_conf_func(device) | 16:55 |
gibi | if config is not None: | 16:56 |
gibi | config = get_device_conf_func(device) | 16:56 |
gibi | if config is not None: | 16:56 |
gibi | sorry | 16:56 |
gibi | back copy paste | 16:56 |
gibi | here https://github.com/openstack/nova/blob/745f835e9d8931261501747130165824334abb4b/nova/virt/libvirt/guest.py#L476 | 16:56 |
melwitt | mmmaybe. I think that only checks whether the persistent config got detached, not the live | 16:57 |
melwitt | I think that only checks whether the persistent detach succeeded and so it will go ahead and try the live detach and get DeviceNotFound | 17:00 |
lyarwood | melwitt++ | 17:00 |
*** ociuhandu_ has joined #openstack-nova | 17:02 | |
melwitt | and DeviceNotFound gets ignored as a no-op | 17:03 |
gibi | melwitt: what is the exit condition of _do_wait_and_retry_detach() ? the retry decorator retries on DeviceDetachFailed exception and if _try_detach_device() succeed without exception then _do_wait_and_retry_detach() raises a DeviceNotFound so that also leads to retry | 17:03 |
gibi | so the exit condition must be that the config become None | 17:05 |
*** ociuhandu has quit IRC | 17:05 | |
*** ociuhandu_ has quit IRC | 17:07 | |
melwitt | hmm.. yeah I see what you're saying. I hadn't thought the detach from live would be reflected in that get_disk but maybe it is | 17:08 |
melwitt | gibi: (it seems like it has to be, like you said) | 17:09 |
gibi | ohh we have two different exceptions in the control flow DeviceDetachFailed and DeviceNotFound, I think I mixed the two | 17:10 |
*** rpittau is now known as rpittau|afk | 17:10 | |
gibi | for the initial detach DeviceNotFound means we failed the detaching | 17:11 |
gibi | in one of the domains | 17:11 |
*** tesseract has quit IRC | 17:11 | |
gibi | and hence we move to retry | 17:12 |
gibi | but in the retry loop we only retry on DeviceDetachFailed not on DeviceNotFound | 17:12 |
*** nightmare_unreal has quit IRC | 17:12 | |
melwitt | gibi: ahhhh yes you got it | 17:12 |
gibi | so the retry loop does not care about DeviceNotFound (partial detach failure) but only cares about the config being not None | 17:13 |
melwitt | that sneaky RetryDecorator | 17:13 |
gibi | this code is hard | 17:13 |
*** haleyb has quit IRC | 17:14 | |
melwitt | yes. this is exactly why lyarwood has plans to refactor it :) | 17:14 |
gibi | but then if the retry loop sees any exception (other than the self inflicted DeviceDetachFailed) e.g. DeviceNotFound then it just let the exception buble up and not retry. So I don't know how this really retries a partial detach failure in libvirt | 17:15 |
gibi | melwitt: yeah, and I try to help him, hence my questions :) | 17:15 |
gibi | (no the exceptions are not inherinting from each other) | 17:16 |
lyarwood | FWIW with an event based approach we would just ask libvirt to detach once and then wait | 17:16 |
*** haleyb has joined #openstack-nova | 17:16 | |
gibi | lyarwood: and if if sends a failed event, we call detach again? | 17:16 |
lyarwood | true yeah we could but it should be easier to write and maintain than this mess | 17:17 |
gibi | lyarwood: or we consider the DeviceRemovalFailedEvent as a permanent failure that we buble up? | 17:18 |
gibi | s/than/and/ | 17:18 |
gibi | nvm | 17:18 |
gibi | that is end of my day. I will continue looking into this tomorrow | 17:18 |
gibi | melwitt, lyarwood: thanks for the help | 17:18 |
*** tosky has quit IRC | 17:24 | |
*** tosky has joined #openstack-nova | 17:25 | |
*** martinkennelly has joined #openstack-nova | 17:26 | |
melwitt | it seems like get_device_conf_func has to be reflecting the live config too, else this doesn't make sense | 17:31 |
*** ociuhandu has joined #openstack-nova | 17:36 | |
*** openstackgerrit has quit IRC | 17:37 | |
*** ociuhandu has quit IRC | 17:41 | |
*** dklyle has quit IRC | 17:47 | |
*** dklyle has joined #openstack-nova | 18:01 | |
*** derekh has quit IRC | 18:05 | |
*** mgoddard has quit IRC | 18:14 | |
*** mgoddard has joined #openstack-nova | 18:15 | |
*** hamalq has joined #openstack-nova | 18:16 | |
*** mgoddard has quit IRC | 18:24 | |
gmann | gibi: melwitt this should fix the multiple-network issue in nova-next job occurring in tempest scenario manager.https://review.opendev.org/c/openstack/tempest/+/770169 | 18:39 |
gmann | Previously i thought it cannot happen in scenario manager but if 'CONF.network.port_vnic_type' and 'CONF.network.port_profile' are not configured then it can occur which is what we saw in nova-next job | 18:39 |
melwitt | woot, thanks gmann | 18:40 |
gmann | this is where it falling on tenant default network which are note present https://zuul.opendev.org/t/openstack/build/ce402610f88a45928ff808bbb4a6303f/log/controller/logs/tempest_log.txt#53439 | 18:41 |
gmann | not | 18:41 |
*** andrewbonney has quit IRC | 18:43 | |
melwitt | I vaguely remember trying to fix it with https://review.opendev.org/c/openstack/tempest/+/716809 a long time ago | 18:43 |
gmann | melwitt: ah i remember now that discussion. base class also need to setup the resources. | 18:45 |
gmann | in my patch I am creating default network resource by default for scenario tests and provide flag for subclass to stop that if needed | 18:46 |
gmann | creating by default should be right thing for scenario testing | 18:46 |
melwitt | yeah, I see. cool | 18:46 |
*** _mlavalle_1 has joined #openstack-nova | 19:05 | |
*** mlavalle has quit IRC | 19:08 | |
*** dtantsur is now known as dtantsur|afk | 19:15 | |
*** nweinber has quit IRC | 19:17 | |
*** gmann is now known as gmann_afk | 19:25 | |
*** nweinber has joined #openstack-nova | 20:00 | |
*** tobias-urdin has joined #openstack-nova | 20:17 | |
*** avolkov has quit IRC | 20:36 | |
*** elod has quit IRC | 20:43 | |
*** ralonsoh has quit IRC | 20:44 | |
*** elod has joined #openstack-nova | 20:45 | |
*** zenkuro has quit IRC | 20:51 | |
*** zenkuro has joined #openstack-nova | 20:52 | |
*** eharney has quit IRC | 20:58 | |
*** ociuhandu has joined #openstack-nova | 21:01 | |
*** eharney has joined #openstack-nova | 21:10 | |
*** gmann_afk is now known as gmann | 21:13 | |
*** zenkuro has quit IRC | 21:19 | |
*** zenkuro has joined #openstack-nova | 21:19 | |
*** lemko has quit IRC | 21:21 | |
*** lemko has joined #openstack-nova | 21:21 | |
*** hoonetorg has quit IRC | 21:22 | |
*** openstackgerrit has joined #openstack-nova | 21:32 | |
openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for resource providers https://review.opendev.org/c/openstack/placement/+/760240 | 21:32 |
openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for aggregates https://review.opendev.org/c/openstack/placement/+/760235 | 21:32 |
openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for allocations https://review.opendev.org/c/openstack/placement/+/760236 | 21:32 |
openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for allocation candidates https://review.opendev.org/c/openstack/placement/+/760237 | 21:32 |
openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for inventories https://review.opendev.org/c/openstack/placement/+/760238 | 21:32 |
openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for resource classes https://review.opendev.org/c/openstack/placement/+/760239 | 21:32 |
openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for traits https://review.opendev.org/c/openstack/placement/+/760241 | 21:32 |
openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for usage https://review.opendev.org/c/openstack/placement/+/760242 | 21:32 |
*** ociuhandu has quit IRC | 21:36 | |
*** hoonetorg has joined #openstack-nova | 21:40 | |
*** raildo has quit IRC | 21:43 | |
*** nweinber has quit IRC | 21:44 | |
*** xek has quit IRC | 21:53 | |
*** zenkuro has quit IRC | 22:05 | |
*** zenkuro has joined #openstack-nova | 22:06 | |
*** rcernin has joined #openstack-nova | 22:07 | |
*** rcernin has quit IRC | 22:09 | |
*** rcernin has joined #openstack-nova | 22:11 | |
openstackgerrit | Merged openstack/nova master: api: Drop statistics-style fields from os-hypervisors https://review.opendev.org/c/openstack/nova/+/764040 | 22:19 |
*** zenkuro has quit IRC | 22:49 | |
*** zenkuro has joined #openstack-nova | 22:50 | |
*** slaweq has quit IRC | 22:51 | |
*** tkajinam has joined #openstack-nova | 22:57 | |
*** zenkuro has quit IRC | 23:06 | |
*** zenkuro has joined #openstack-nova | 23:06 | |
*** rcernin_ has joined #openstack-nova | 23:54 | |
*** rcernin has quit IRC | 23:55 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!