| *** jamesdenton has quit IRC | 00:02 | |
| brinzhang | sean-k-mooney, gibi: got it, thanks, will check | 00:02 |
|---|---|---|
| *** jamesdenton has joined #openstack-nova | 00:03 | |
| gmann | lbragstad: left comment for placement policy - https://review.opendev.org/c/openstack/placement/+/760240/14/placement/tests/functional/fixtures/gabbits.py#763 | 00:03 |
| gmann | lbragstad: if wee can run same or new tests with fixture to check if old token still work or not when enforce_scopy is false | 00:04 |
| gmann | which is what we ship as default. | 00:06 |
| *** tosky has quit IRC | 00:09 | |
| *** spatel has joined #openstack-nova | 00:13 | |
| brinzhang | sean-k-mooney: the os-simple-tenant-usage action will replace with os-simple-project-usage action, the tempest check the os-simple-tenant-usage action, if I dont skip the tempest check, it seems cannot pass | 00:17 |
| brinzhang | sean-k-mooney: is it right? | 00:17 |
| brinzhang | the nova change: https://review.opendev.org/c/openstack/nova/+/768852/7/nova/api/openstack/compute/routes.py#689 | 00:18 |
| *** spatel has quit IRC | 00:18 | |
| brinzhang | gmann: I know you are an expert in tempest, can you help to check? | 00:20 |
| brinzhang | gmann: the tempest patch https://review.opendev.org/c/openstack/tempest/+/769120 | 00:20 |
| gmann | brinzhang: sure, you want to move to openstack-qa ? | 00:22 |
| brinzhang | gmann: of course | 00:24 |
| *** swp20 has joined #openstack-nova | 00:30 | |
| *** rcernin has quit IRC | 00:32 | |
| *** brinzhang_ has joined #openstack-nova | 00:34 | |
| *** songwenping_ has joined #openstack-nova | 00:37 | |
| *** rcernin has joined #openstack-nova | 00:37 | |
| *** brinzhang has quit IRC | 00:37 | |
| *** lbragstad_ has joined #openstack-nova | 00:38 | |
| *** songwenping_ has quit IRC | 00:38 | |
| *** songwenping_ has joined #openstack-nova | 00:39 | |
| *** swp20 has quit IRC | 00:39 | |
| *** lbragstad has quit IRC | 00:40 | |
| gmann | brinzhang_: replied on gerrit for your query about os-simple-tenant-usage action https://review.opendev.org/c/openstack/nova/+/768852 | 00:50 |
| gmann | brinzhang_: we still nee old API route and controller/sample/test etc as this is still valid for old microversion | 00:51 |
| gmann | we do not have microversion knowledge in routes so we can add new one with old one still there and in API method in controller we can return 404 for old API for >2.89 | 00:53 |
| brinzhang_ | gmann: greate, will check | 00:53 |
| gmann | which is nothing but this @wsgi.Controller.api_version("2.1", "2.89") | 00:54 |
| gmann | and new API method can be decorated with @wsgi.Controller.api_version("2.90") | 00:55 |
| gmann | so any user requesting new API will get 404 with <2.90 | 00:55 |
| gmann | basically keep the old API things (test/sample etc) as it is but with capping it with microversion 2.89. | 00:57 |
| brinzhang_ | you mean, I should add @wsgi.Controller.api_version("2.90") in the index and show api? | 00:58 |
| brinzhang_ | s/in/on/ | 00:59 |
| gmann | for new API yes | 00:59 |
| brinzhang_ | https://review.opendev.org/c/openstack/nova/+/768509/10/nova/api/openstack/compute/simple_tenant_usage.py | 00:59 |
| brinzhang_ | gmann: I think I should add two api for 2.90, and add the max version limit the old version | 01:00 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for resource providers https://review.opendev.org/c/openstack/placement/+/760240 | 01:00 |
| gmann | like ServerTopology API added in 2.78 https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/server_topology.py#L26 | 01:00 |
| brinzhang_ | gmann: I am not understand waht you say about the router change | 01:01 |
| gmann | brinzhang_: in routes, you just need to add the new controller and url path and leave old one as it is | 01:01 |
| brinzhang_ | ack | 01:02 |
| gmann | because old API still valid for older microversion. | 01:02 |
| brinzhang_ | gmann: do we need to rename the tenant file? | 01:02 |
| gmann | which one? | 01:02 |
| gmann | this one? https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/simple_tenant_usage.py | 01:03 |
| brinzhang_ | this patch I add the 2.90 support https://review.opendev.org/c/openstack/nova/+/768509/10/nova/api/openstack/compute/simple_tenant_usage.py | 01:03 |
| brinzhang_ | and https://review.opendev.org/c/openstack/nova/+/768852 renamed the tenant* to project* | 01:04 |
| gmann | brinzhang_: there are two part 1. changing the 'tenant' in response etc which is 768509 this is good as you are doing, I had a quick glance | 01:06 |
| brinzhang_ | https://review.opendev.org/c/openstack/nova/+/768509/10/nova/api/openstack/compute/simple_tenant_usage.py#295 | 01:06 |
| gmann | and 2nd is about adding new API method which is 768852 for this we can add new file or new method using old method in existing file | 01:07 |
| brinzhang_ | this patch I should add the @wsgi.Controller.api_version("2.1", "2.89") in the old index and show api, and add @wsgi.Controller.api_version("2.90") to as the new api for index and show, right? | 01:07 |
| gmann | right | 01:07 |
| brinzhang_ | but this change in the 768852 | 01:08 |
| brinzhang_ | as your suggestion | 01:08 |
| gmann | have two option here 1. if rename file then add new controller class which can reuse the old APi method 2. have complete new file with new method which can also use existing method | 01:08 |
| *** _mlavalle_1 has quit IRC | 01:09 | |
| gmann | may be 1st option is better. you can rename file and keep old controller class in that file with all API method as @wsgi.Controller.api_version("2.1", "2.89") | 01:09 |
| gmann | and new controller class with new method with @wsgi.Controller.api_version("2.90") and add these in routes.py | 01:10 |
| gmann | and same way in tests also we can do the same to reuse the code | 01:12 |
| brinzhang_ | gmann: yes, in 768852, we renamed the file, and reused the old test | 01:13 |
| brinzhang_ | I need to keep the old action in the router and add the new action controller | 01:14 |
| gmann | brinzhang_: but you are changing old API route and controller which means old API is completely gone - https://review.opendev.org/c/openstack/nova/+/768852/7/nova/api/openstack/compute/simple_project_usage.py | 01:14 |
| *** dave-mccowan has quit IRC | 01:15 | |
| brinzhang_ | is it need to restort the nova/api/openstack/compute/simple_tenant_usage.py | 01:15 |
| brinzhang_ | file? | 01:15 |
| gmann | for example: GET /os-simple-tenant-usage wil return 404 even for older microversion | 01:15 |
| brinzhang_ | and add the nova/api/openstack/compute/simple_project_usage.py? | 01:15 |
| gmann | that is one option | 01:16 |
| gmann | or other option is | 01:16 |
| *** macz_ has quit IRC | 01:16 | |
| gmann | rename and add SimpleProjectUsageController(SimpleTenantUsageController) as new class there | 01:17 |
| gmann | and in routes.py you can add new path like ('/os-simple-project-usage', { | 01:18 |
| gmann | 'GET': [simple_project_usage_controller, 'index'] | 01:18 |
| gmann | def index() in new controller will just call the old SimpleTenantUsageController.index() and have @wsgi.Controller.api_version("2.90") | 01:19 |
| brinzhang_ | gmann: ok, we will try to use the two option | 01:19 |
| brinzhang_ | a question | 01:20 |
| brinzhang_ | @wsgi.Controller.api_version("2.1", "2.89") and @wsgi.Controller.api_version("2.90") for the api change, is it need to change with the router change? | 01:21 |
| brinzhang_ | I mean keep this change in 768852 patch | 01:21 |
| brinzhang_ | gmann: what do you think? | 01:21 |
| gmann | brinzhang_: in routes.py if you rename the file then 1. for old API route, change import (from nova.api.openstack.compute import simple_tenant_usage -> from nova.api.openstack.compute import simple_project_usage ) | 01:25 |
| gmann | and for new API add new route as separate | 01:25 |
| gmann | brinzhang_: like this http://paste.openstack.org/show/801854/ | 01:29 |
| *** dave-mccowan has joined #openstack-nova | 01:30 | |
| brinzhang_ | gmann: yeah, get it | 01:30 |
| brinzhang_ | gmann: above question is which patch I shuold change the max or min version changing of the index and show usages apis? | 01:31 |
| gmann | but other file like request/response sample file can exist in separate if it become very lengthy and unreadable | 01:32 |
| gmann | brinzhang_: ah that is good question but tricky also. | 01:32 |
| brinzhang_ | ok, I can seperate the route change from 768852 | 01:33 |
| gmann | brinzhang_: it has to be route change in 768852 and 768509 changing the response etc. so 768509 as first will not change anything for older microversion | 01:35 |
| gmann | so you current order of patches is good | 01:35 |
| gmann | this way in 768852 we expose the new API url with new response | 01:36 |
| gmann | and restrict old API with 2.89 and return old response | 01:36 |
| brinzhang_ | ok, just need to do these changes in 768852 ^ | 01:37 |
| brinzhang_ | and keep the 768509 not change | 01:37 |
| *** lbragstad_ is now known as lbragstad | 01:37 | |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for aggregates https://review.opendev.org/c/openstack/placement/+/760235 | 01:37 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for allocations https://review.opendev.org/c/openstack/placement/+/760236 | 01:37 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for allocation candidates https://review.opendev.org/c/openstack/placement/+/760237 | 01:37 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for inventories https://review.opendev.org/c/openstack/placement/+/760238 | 01:37 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for resource classes https://review.opendev.org/c/openstack/placement/+/760239 | 01:37 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for traits https://review.opendev.org/c/openstack/placement/+/760241 | 01:37 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for usage https://review.opendev.org/c/openstack/placement/+/760242 | 01:37 |
| lbragstad | gmann ^ those should have all the bits for testing the deprecated policies | 01:37 |
| gmann | lbragstad: thanks. I will review tomorrow with results. basically almost good to go just need to have new test green | 01:39 |
| gmann | brinzhang_: yes. for this route things. I will review the complete series tomorrow if any thing else missing | 01:40 |
| brinzhang_ | gmann: thanks | 01:40 |
| lbragstad | gmann sounds good - they all pass for me locally, i'll follow up tomorrow | 01:40 |
| gmann | brinzhang_: key thing is to pass the existing tests and Tempest without any change means you are not breaking anything :) | 01:40 |
| gmann | lbragstad: great. | 01:40 |
| gmann | brinzhang_: if you have to change anything then we are introducing some backward incompatible change | 01:41 |
| *** dcapone2004 has quit IRC | 01:41 | |
| brinzhang_ | gmann: yeah, the tempest change will change as your suggestion, and it you can review tomorrow | 01:41 |
| gmann | brinzhang_: +1 | 01:42 |
| brinzhang_ | yes, we cannt break the old test in tempest | 01:42 |
| gmann | I can help on Tempest change tomorrow if anything you miss of need help with. | 01:42 |
| gmann | *or need | 01:42 |
| *** lbragstad has quit IRC | 01:46 | |
| gmann | brinzhang_: going away. will check the series tomorrow. happy Friday to you :) | 01:47 |
| brinzhang_ | gmann: thanks, good night^^ | 01:47 |
| *** hemanth_n has joined #openstack-nova | 02:05 | |
| *** hamalq has quit IRC | 02:24 | |
| *** brinzhang_ has quit IRC | 02:44 | |
| *** brinzhang_ has joined #openstack-nova | 02:45 | |
| *** dklyle has quit IRC | 02:54 | |
| *** david-lyle has joined #openstack-nova | 02:54 | |
| brinzhang_ | gmann: hi are you around? | 03:04 |
| brinzhang_ | nova/tests/functional/api_sample_tests/api_samples/os-simple-project-usage/simple-tenant-usage-get.json.tpl like this file, the sample file do need keep ing the "os-simple-tenant-usage" dir? | 03:05 |
| brinzhang_ | s/ing/under | 03:05 |
| *** rcernin has quit IRC | 03:08 | |
| *** ianw is now known as ianw_pto | 03:12 | |
| *** macz_ has joined #openstack-nova | 03:17 | |
| *** macz_ has quit IRC | 03:21 | |
| *** lbragstad has joined #openstack-nova | 03:25 | |
| *** rcernin has joined #openstack-nova | 03:33 | |
| *** gyee has quit IRC | 03:36 | |
| *** macz_ has joined #openstack-nova | 03:38 | |
| *** tbachman has quit IRC | 03:38 | |
| *** david-lyle has quit IRC | 03:38 | |
| *** zenkuro has quit IRC | 03:40 | |
| *** tbachman has joined #openstack-nova | 03:43 | |
| *** macz_ has quit IRC | 03:43 | |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for resource providers https://review.opendev.org/c/openstack/placement/+/760240 | 03:44 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for aggregates https://review.opendev.org/c/openstack/placement/+/760235 | 03:44 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for allocations https://review.opendev.org/c/openstack/placement/+/760236 | 03:44 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for allocation candidates https://review.opendev.org/c/openstack/placement/+/760237 | 03:44 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for inventories https://review.opendev.org/c/openstack/placement/+/760238 | 03:45 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for resource classes https://review.opendev.org/c/openstack/placement/+/760239 | 03:45 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for traits https://review.opendev.org/c/openstack/placement/+/760241 | 03:45 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for usage https://review.opendev.org/c/openstack/placement/+/760242 | 03:45 |
| *** links has joined #openstack-nova | 03:47 | |
| *** rcernin has quit IRC | 03:48 | |
| *** rcernin has joined #openstack-nova | 04:04 | |
| *** rcernin has quit IRC | 04:05 | |
| *** rcernin has joined #openstack-nova | 04:05 | |
| *** k_mouza has joined #openstack-nova | 04:18 | |
| *** mkrai has joined #openstack-nova | 04:20 | |
| *** k_mouza has quit IRC | 04:22 | |
| *** rouk has joined #openstack-nova | 04:30 | |
| *** vishalmanchanda has joined #openstack-nova | 04:47 | |
| *** manuvakery1 has joined #openstack-nova | 04:55 | |
| *** lbragstad has quit IRC | 05:11 | |
| *** mkrai has quit IRC | 05:22 | |
| *** mkrai_ has joined #openstack-nova | 05:22 | |
| *** psachin has joined #openstack-nova | 05:22 | |
| *** LinPeiWen has joined #openstack-nova | 05:43 | |
| *** ratailor has joined #openstack-nova | 05:44 | |
| *** mkrai_ has quit IRC | 05:51 | |
| *** mkrai has joined #openstack-nova | 05:52 | |
| *** k_mouza has joined #openstack-nova | 06:19 | |
| *** k_mouza has quit IRC | 06:23 | |
| *** sapd1 has quit IRC | 07:07 | |
| *** rcernin has quit IRC | 07:25 | |
| *** rpittau|afk is now known as rpittau | 07:34 | |
| *** rcernin has joined #openstack-nova | 07:37 | |
| *** rcernin has quit IRC | 07:42 | |
| *** ralonsoh has joined #openstack-nova | 07:48 | |
| *** rcernin has joined #openstack-nova | 07:50 | |
| *** slaweq has joined #openstack-nova | 07:54 | |
| *** rcernin has quit IRC | 07:55 | |
| *** luksky has joined #openstack-nova | 08:03 | |
| *** rcernin has joined #openstack-nova | 08:08 | |
| *** mgoddard has quit IRC | 08:11 | |
| *** mgoddard has joined #openstack-nova | 08:11 | |
| *** andrewbonney has joined #openstack-nova | 08:13 | |
| *** rcernin has quit IRC | 08:13 | |
| *** rcernin has joined #openstack-nova | 08:14 | |
| *** tesseract has joined #openstack-nova | 08:16 | |
| *** rcernin has quit IRC | 08:19 | |
| gibi | sean-k-mooney: hi! I don't find the bp https://blueprints.launchpad.net/nova/+spec/port-scoped-sriov-numa-affinity behind https://review.opendev.org/c/openstack/nova-specs/+/765901 spec | 08:20 |
| *** rcernin has joined #openstack-nova | 08:26 | |
| *** rcernin has quit IRC | 08:31 | |
| *** xek_ has joined #openstack-nova | 08:34 | |
| *** rcernin has joined #openstack-nova | 08:44 | |
| *** tosky has joined #openstack-nova | 08:44 | |
| *** mkrai has quit IRC | 08:45 | |
| *** rcernin has quit IRC | 08:49 | |
| *** jamesdenton has quit IRC | 08:49 | |
| *** jamesdenton has joined #openstack-nova | 08:50 | |
| *** nightmare_unreal has joined #openstack-nova | 08:58 | |
| *** ociuhandu has joined #openstack-nova | 09:02 | |
| *** rcernin has joined #openstack-nova | 09:08 | |
| nightmare_unreal | i have submitted a bug report for placement on launchpad but I found there is a storyboard for placement, should I mark it as invalid and submit again on storyboard ? | 09:12 |
| *** rcernin has quit IRC | 09:13 | |
| *** f0o has quit IRC | 09:14 | |
| *** janno has quit IRC | 09:14 | |
| *** PrinzElvis has quit IRC | 09:14 | |
| *** masayukig has quit IRC | 09:14 | |
| *** zigo has quit IRC | 09:14 | |
| *** sorrison has quit IRC | 09:14 | |
| *** f0o has joined #openstack-nova | 09:15 | |
| *** janno has joined #openstack-nova | 09:15 | |
| *** PrinzElvis has joined #openstack-nova | 09:15 | |
| *** masayukig has joined #openstack-nova | 09:15 | |
| *** zigo has joined #openstack-nova | 09:15 | |
| *** sorrison has joined #openstack-nova | 09:15 | |
| *** masterpe has quit IRC | 09:17 | |
| *** rouk has quit IRC | 09:21 | |
| frickler | nightmare_unreal: interesting question. since placement has moved back to nova governance, I'd say it should also revert to using LP, but that's mainly my aversion against sb speaking | 09:22 |
| nightmare_unreal | okay frickler , i will wait for some time . Someone might look at it | 09:23 |
| nightmare_unreal | and will let me know if it should be moved or not | 09:24 |
| frickler | gibi: ^^ ptl topic probably ;) | 09:24 |
| *** rcernin has joined #openstack-nova | 09:25 | |
| *** psachin has quit IRC | 09:26 | |
| gibi | nightmare_unreal, frickler: interesting question, I would not start a move back to launchpad just because we have a single core team | 09:27 |
| gibi | but there could be other legitimate reasons | 09:27 |
| nightmare_unreal | got it | 09:27 |
| gibi | nightmare_unreal: link me to the bug I please | 09:28 |
| nightmare_unreal | gibi: https://bugs.launchpad.net/nova/+bug/1912749 | 09:29 |
| openstack | Launchpad bug 1912749 in OpenStack Compute (nova) "clouds.yaml does not use placement API version variable" [Undecided,New] | 09:29 |
| gibi | thnaks | 09:29 |
| *** rcernin has quit IRC | 09:30 | |
| *** rcernin has joined #openstack-nova | 09:32 | |
| frickler | gibi: I think the main question would be how to integrate storyboard into your bug tracking workflows, assuring that issues created there aren't just getting ignored | 09:40 |
| *** derekh has joined #openstack-nova | 09:48 | |
| *** k_mouza has joined #openstack-nova | 09:59 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: docs: Add reference docs for internal block device structures https://review.opendev.org/c/openstack/nova/+/771711 | 09:59 |
| *** dtantsur|afk is now known as dtantsur | 09:59 | |
| brinzhang_ | gibi: good moning^ | 10:01 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_VIR_ERR_DEVICE_MISSING https://review.opendev.org/c/openstack/nova/+/754702 | 10:03 |
| *** k_mouza_ has joined #openstack-nova | 10:06 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_VIR_ERR_DEVICE_MISSING https://review.opendev.org/c/openstack/nova/+/754702 | 10:07 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Drop support for UML https://review.opendev.org/c/openstack/nova/+/743230 | 10:07 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Drop support for Xen https://review.opendev.org/c/openstack/nova/+/743231 | 10:07 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION and NEXT_MIN_{LIBVIRT,QEMU}_VERSION https://review.opendev.org/c/openstack/nova/+/754700 | 10:07 |
| lyarwood | ^ had to rebase these for the ceph gate fix and to resolve a conflict in the UML and Xen removal changes | 10:07 |
| *** masterpe has joined #openstack-nova | 10:08 | |
| brinzhang_ | lyarwood: morning^ | 10:08 |
| *** k_mouza has quit IRC | 10:09 | |
| *** hemanth_n has quit IRC | 10:13 | |
| *** hemanth_n has joined #openstack-nova | 10:13 | |
| lyarwood | brinzhang_: morning, what's up? | 10:14 |
| gibi | frickler: regardless of the bug tracking tool, we are a bit behind triaging placement bugs due to multiple reasons | 10:16 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Allow encryption tests in nova-ceph-multistore again https://review.opendev.org/c/openstack/nova/+/771837 | 10:16 |
| gibi | lyarwood: plugged back my +2s on the libvirt bump series | 10:20 |
| nightmare_unreal | gibi: did you saw the bug , does it fit on placement project ? | 10:22 |
| openstackgerrit | Wenping Song proposed openstack/nova master: Replace os-simple-tenant-usage with os-simple-project-usage https://review.opendev.org/c/openstack/nova/+/768852 | 10:22 |
| brinzhang_ | lyarwood: this morning, gmann's give me some suggestion to update he tenant-usages patch, but while I do it, I found in one file inherit the orignal class, the function in the class with @wsgi.Controller.api_version limit the request version | 10:22 |
| *** jangutter_ has quit IRC | 10:22 | |
| gibi | nightmare_unreal: I opened in a browser tab, but haven't spent time on it yet | 10:23 |
| nightmare_unreal | gibi: ACK :) | 10:23 |
| gibi | nightmare_unreal: I will try to get to it | 10:23 |
| nightmare_unreal | thanks | 10:23 |
| brinzhang_ | but when I test the case, I cannot reqire the 2.90 index or show api in https://review.opendev.org/c/openstack/nova/+/768852/8/nova/api/openstack/compute/simple_project_usage.py#408 | 10:24 |
| brinzhang_ | lyarwood: the request always request the api in 2.40~2.89, where is wrong? | 10:25 |
| brinzhang_ | lyarwood: that case in https://review.opendev.org/c/openstack/nova/+/768852/8/nova/tests/unit/api/openstack/compute/test_simple_project_usage.py#586 | 10:27 |
| brinzhang_ | lyarwood: I am not sure what I missed, maybe the inherit function is not right | 10:28 |
| lyarwood | brinzhang_: so if a 2.90 request isn't being made then that's an issue with the test not the api code | 10:29 |
| *** yonglihe has quit IRC | 10:29 | |
| lyarwood | brinzhang_: and looking at the test I can't see anything that should stop it, I've never really touched this test code however so it might be something weird like an extra var required somewhere | 10:29 |
| brinzhang_ | lyarwood: I am not found these test cases where need to change, I have spent almost 3 hours on this :( | 10:31 |
| * lyarwood pulls down the change | 10:32 | |
| *** k_mouza has joined #openstack-nova | 10:40 | |
| *** k_mouza_ has quit IRC | 10:44 | |
| lyarwood | brinzhang_: yeah I'm not sure, I thought you had to add a reference to the controller in the test but there's more missing | 10:51 |
| lyarwood | brinzhang_: I'll try to play around with it later if you're still stuck | 10:51 |
| * lyarwood switches context to some downstream stuff | 10:51 | |
| brinzhang_ | lyarwood: thanks, I would like gmann can have a check today | 10:52 |
| brinzhang_ | after dinner I will try to trace it | 10:53 |
| brinzhang_ | gmann: update the project usage patach follow your suggestion, pls help me check the question | 10:54 |
| brinzhang_ | gmann: the case test run failed https://review.opendev.org/c/openstack/nova/+/768852/8/nova/tests/unit/api/openstack/compute/test_simple_project_usage.py#586 | 10:54 |
| *** hemanth_n has quit IRC | 10:57 | |
| *** hemanth_n has joined #openstack-nova | 10:58 | |
| *** hoonetorg has quit IRC | 11:10 | |
| *** mgoddard has quit IRC | 11:30 | |
| *** rcernin has quit IRC | 11:31 | |
| openstackgerrit | Stephen Finucane proposed openstack/placement master: WIP: Allow project readers to see project-specific usages https://review.opendev.org/c/openstack/placement/+/771964 | 11:36 |
| *** rcernin has joined #openstack-nova | 11:38 | |
| *** zenkuro has joined #openstack-nova | 11:54 | |
| *** rcernin has quit IRC | 12:00 | |
| stephenfin | lyarwood: Are you planning to review https://review.opendev.org/c/openstack/nova/+/743231/10 and https://review.opendev.org/c/openstack/nova/+/743230 or do you need to ask someone else to do it? | 12:01 |
| stephenfin | I just reviewed them myself, but while it's been a while I still wrote the bulk of it so probably shouldn't give the sign off :-\ | 12:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Remove 'hypervisor_version' from 'libvirt_info' https://review.opendev.org/c/openstack/nova/+/744199 | 12:02 |
| lyarwood | stephenfin: I've made changes so it might be better to get someone else to approve, I'll review anyway and +1 | 12:03 |
| stephenfin | Makes sense. Maybe bauzas? ^ | 12:03 |
| * stephenfin is just lining up tedious reviews for bauzas this week :) | 12:04 | |
| lyarwood | as a service | 12:04 |
| lyarwood | :D | 12:04 |
| bauzas | stephenfin: at lunch :) | 12:09 |
| bauzas | stephenfin: ping me at 1.30pm your time and I'll look at them ;) | 12:10 |
| nightmare_unreal | question : where does osc reads clouds.yaml file, can't seem to figure out :/ . | 12:21 |
| *** ratailor has quit IRC | 12:27 | |
| *** rcernin has joined #openstack-nova | 12:27 | |
| *** iurygregory_ has joined #openstack-nova | 12:28 | |
| *** iurygregory has quit IRC | 12:28 | |
| *** iurygregory_ is now known as iurygregory | 12:29 | |
| *** k_mouza has quit IRC | 12:43 | |
| *** k_mouza has joined #openstack-nova | 12:44 | |
| *** rcernin has quit IRC | 12:48 | |
| *** k_mouza has quit IRC | 12:54 | |
| *** k_mouza_ has joined #openstack-nova | 12:54 | |
| *** k_mouza has joined #openstack-nova | 12:55 | |
| *** ociuhandu has quit IRC | 12:55 | |
| *** ociuhandu has joined #openstack-nova | 12:56 | |
| *** ociuhandu has quit IRC | 12:58 | |
| *** k_mouza_ has quit IRC | 12:58 | |
| *** ociuhandu has joined #openstack-nova | 12:59 | |
| *** k_mouza has quit IRC | 13:00 | |
| *** k_mouza has joined #openstack-nova | 13:02 | |
| *** ociuhandu has quit IRC | 13:02 | |
| *** ociuhandu has joined #openstack-nova | 13:02 | |
| *** ociuhandu has quit IRC | 13:02 | |
| *** k_mouza has quit IRC | 13:03 | |
| *** ociuhandu has joined #openstack-nova | 13:03 | |
| openstackgerrit | Elod Illes proposed openstack/nova stable/queens: libvirt: Do not reference VIR_ERR_DEVICE_MISSING when libvirt is < v4.1.0 https://review.opendev.org/c/openstack/nova/+/747362 | 13:03 |
| *** k_mouza has joined #openstack-nova | 13:05 | |
| openstackgerrit | Elod Illes proposed openstack/nova stable/queens: libvirt: Do not reference VIR_ERR_DEVICE_MISSING when libvirt is < v4.1.0 https://review.opendev.org/c/openstack/nova/+/747362 | 13:06 |
| *** k_mouza_ has joined #openstack-nova | 13:07 | |
| *** k_mouza has quit IRC | 13:11 | |
| *** hemanth_n has quit IRC | 13:11 | |
| *** ociuhandu has quit IRC | 13:15 | |
| *** tkajinam_ has quit IRC | 13:16 | |
| sean-k-mooney | gmann: gibi we might want to increase the test timeout on tempest-integrated-compute form 2 hours to 3 | 13:29 |
| sean-k-mooney | it timed out on https://review.opendev.org/c/openstack/nova/+/757614 during the senario tests but everything else ran fine | 13:29 |
| sean-k-mooney | it does look like a potentally slow node but we should proably keep an eye on it | 13:29 |
| sean-k-mooney | thats the only time out there https://zuul.opendev.org/t/openstack/builds?job_name=tempest-integrated-compute&project=openstack/nova | 13:31 |
| gibi | sean-k-mooney: ack. looking at the run historyt https://zuul.opendev.org/t/openstack/builds?job_name=tempest-integrated-compute&project=openstack/nova most of the runs are areound 1.5 hours | 13:31 |
| sean-k-mooney | and it normally complete in aboiut 1:20 | 13:31 |
| sean-k-mooney | yep | 13:31 |
| gibi | so let's keep an eye on it | 13:31 |
| gibi | but right now I would not increase yet | 13:31 |
| sean-k-mooney | i think in general the current time out looks right | 13:31 |
| *** mgoddard has joined #openstack-nova | 13:32 | |
| sean-k-mooney | the fact we have a normal run lenght in the next patch in the chain would seam to indicate that the time it ran fro is unrealted to the patch too | 13:33 |
| gibi | yes, I think this was an extra slow node | 13:34 |
| sean-k-mooney | collections.defaultdict(lambda: 0) huh thats a new one | 13:34 |
| sean-k-mooney | so ret: ty.DefaultDict[str, int] = collections.defaultdict(lambda: 0) is default initallising a dictionary where the values will be 0 | 13:36 |
| *** hoonetorg has joined #openstack-nova | 13:37 | |
| gibi | defaultdict takes a callable to produce the default value | 13:37 |
| gibi | sometimes we use int instead of lamba: 0 | 13:38 |
| gibi | both produce 0 | 13:38 |
| gibi | as int() == 0 as well as lambda: 0() == 0 | 13:38 |
| sean-k-mooney | ya its a cleaver solution but also suprisign if you have not seen it before | 13:39 |
| sean-k-mooney | i would have expect to just pass 0 honestly | 13:39 |
| *** hemna has quit IRC | 13:39 | |
| *** ociuhandu has joined #openstack-nova | 13:39 | |
| sean-k-mooney | but i can see why that would not be a good patern in general | 13:40 |
| gibi | you cannot pass 0 as that is not a callable | 13:40 |
| sean-k-mooney | if it was a complex object instead of a literall it would be a problem to allow passing the object directly | 13:40 |
| sean-k-mooney | since it would be shared not cloned | 13:40 |
| sean-k-mooney | hence a callable to produce the defualt value | 13:40 |
| gibi | yepp | 13:40 |
| gibi | so we have to pass something that returns 0 | 13:41 |
| gibi | both int, and lamba:0 is good for that, but a 0 literal is not | 13:41 |
| sean-k-mooney | yep | 13:41 |
| *** lbragstad has joined #openstack-nova | 13:42 | |
| sean-k-mooney | its more a deficite of the api of the datastucture then anything else. its more flexable however then the claical default approch | 13:42 |
| sean-k-mooney | its just different form how get and set_default work | 13:43 |
| sean-k-mooney | but inline with how sorted or filter works where you provide a key funcion as a callable | 13:43 |
| *** hemna has joined #openstack-nova | 13:44 | |
| *** ociuhandu has quit IRC | 13:49 | |
| *** ociuhandu has joined #openstack-nova | 13:50 | |
| nightmare_unreal | how can i access clouds.yaml file once it's loaded. Suppose i want to read some values from it . For context i am trying to read placement_api_version | 13:52 |
| sean-k-mooney | there is a lib for it but OSC will automaticlaly do it for vars in the right format | 13:53 |
| sean-k-mooney | its just a yaml file however so in your own code you can jsut read it with the stardard lib | 13:54 |
| sean-k-mooney | i think its in osc-lib | 13:55 |
| nightmare_unreal | i am working on a bug : osc client does not read placement API version variable . variable name placement_api_version | 13:56 |
| nightmare_unreal | so i am trying to figure out where in osc it reads the yaml file | 13:56 |
| sean-k-mooney | its case sensitive and has to be uppercase just an fyi | 13:57 |
| sean-k-mooney | i think | 13:57 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: docs: Move the LibvirtDistroSupportMatrix wiki page into our docs https://review.opendev.org/c/openstack/nova/+/771981 | 13:57 |
| sean-k-mooney | that would be in osc-placement | 13:57 |
| nightmare_unreal | obvious solution that will not be good is to read the config file in osc_placement plugin and look for that value if it's set then good . | 13:57 |
| lyarwood | stephenfin / kashyap ; ^ would you mind reviewing this, still need to add some versions and work out where it should live (if not in our reference docs) | 13:57 |
| sean-k-mooney | nightmare_unreal: https://github.com/openstack/osc-placement/blob/master/osc_placement/plugin.py#L53 | 13:58 |
| *** mlavalle has joined #openstack-nova | 13:58 | |
| sean-k-mooney | it uses https://github.com/openstack/osc-lib/blob/ec1b7dda0e6dc1ec614a92e24267d058783ad27f/osc_lib/utils/__init__.py#L134-L144 | 13:59 |
| sean-k-mooney | to get the values for the env | 13:59 |
| nightmare_unreal | in clouds.yaml it should be defined like that ? OS_PLACEMENT_API_VERSION but i think there is a file that automatically does that | 13:59 |
| sean-k-mooney | but i think cloud.yaml is expeorted to the evn | 13:59 |
| nightmare_unreal | I see | 13:59 |
| nightmare_unreal | in my head the env is when in cli we explicitly do export OS_BLAH_BLAH | 13:59 |
| sean-k-mooney | yes it is | 14:00 |
| nightmare_unreal | but if it takes clouds.yaml as env | 14:00 |
| nightmare_unreal | then i have to think | 14:00 |
| sean-k-mooney | but i think we extract some paramaters and add them to it | 14:00 |
| sean-k-mooney | i havent looked at this closely but was how i understood it to work | 14:00 |
| gmann | brinzhang_: ack, I will check those in details and see were it is wrong. basically having separate APi controller class should not cause any issue | 14:01 |
| nightmare_unreal | I see. yeah trying to figure it out myself :) | 14:02 |
| sean-k-mooney | so i think this is wher we read the cloud.yaml https://github.com/openstack/osc-lib/blob/ec1b7dda0e6dc1ec614a92e24267d058783ad27f/osc_lib/shell.py#L408-L413 | 14:03 |
| gmann | sean-k-mooney: gibi I thikn 2 hr is even more time for that job disbale swift and does not run swift/keystone/slow tests | 14:03 |
| sean-k-mooney | gmann: ya i mentioned the timeout befor ei check the build page | 14:03 |
| kashyap | lyarwood: Hey, will check; sigh, missed the notif here | 14:03 |
| gmann | ohk | 14:03 |
| sean-k-mooney | gmann: it shoudl be fine just a slow node | 14:03 |
| gmann | sean-k-mooney: yeah. | 14:04 |
| gmann | except tripleo jobs almost all our gate are with max 2 hrs job run | 14:04 |
| sean-k-mooney | yep | 14:04 |
| kashyap | lyarwood: Thanks for moving; I think I have a half-done patch for it somewhere; but didn't update it | 14:05 |
| nightmare_unreal | thanks sean-k-mooney , looking :D | 14:06 |
| sean-k-mooney | that delegating to the sdk now | 14:06 |
| sean-k-mooney | nightmare_unreal: this is what does the actul loading i think https://github.com/openstack/openstacksdk/blob/4ce235d36dfa3420534ad1b145cc7c5f7438e8e0/openstack/config/loader.py#L140 | 14:09 |
| nightmare_unreal | yeah i think so too, looking | 14:10 |
| *** hemna has quit IRC | 14:12 | |
| sean-k-mooney | nightmare_unreal: regardelss of how its parsed i think this is what you are really looking for https://github.com/openstack/openstacksdk/blob/4ce235d36dfa3420534ad1b145cc7c5f7438e8e0/openstack/config/loader.py#L1057 | 14:14 |
| sean-k-mooney | to lookup a value in the config | 14:15 |
| nightmare_unreal | yes exactly , and also to check if the defined key:value in clouds.yaml is read or not | 14:15 |
| nightmare_unreal | thanks | 14:15 |
| kashyap | lyarwood: Do you havea rendered version of it? | 14:16 |
| kashyap | lyarwood: sean-k-mooney: For testing w/ Secure Boot in the Gate ... none of the cloud images are built with EFI partition ... I'm wondering if are allowed to upload new images for testing? | 14:18 |
| lyarwood | kashyap: http://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_8b1/771981/1/check/openstack-tox-docs/8b1d7c4/docs/reference/libvirt-distro-support-matrix.html | 14:19 |
| kashyap | The short context is: you'd need a disk image with EFI partition in it | 14:19 |
| kashyap | I'm thinking of making a custom template image for testing; is it allowed to upload somewhere via the infra and make use of it? | 14:19 |
| * kashyap explores other, less invasive ways meanwhile | 14:19 | |
| lyarwood | kashyap: we shouldn't need to upload an image into CI, we can just host and reference one that does in a test job | 14:19 |
| lyarwood | kashyap: assuming you're talking about the test instances and not the test hosts | 14:20 |
| kashyap | lyarwood: Ah; okay. I'll find a suitable location to host it, once I prepare it | 14:20 |
| *** ociuhandu has quit IRC | 14:20 | |
| *** jamesdenton has quit IRC | 14:20 | |
| kashyap | lyarwood: Test instance, indeed. I'm talking about a guest | 14:20 |
| sean-k-mooney | kashyap: do you mean the guest image e.g. cirros | 14:20 |
| lyarwood | kashyap: right then there's likely best practice our where we can host it, if it needs to be cached etc but we should be able to drop in a suitable image | 14:21 |
| lyarwood | practice around* | 14:21 |
| sean-k-mooney | we are not ment to pull arbiary blobs down in the jobs | 14:21 |
| kashyap | lyarwood: E.g. this is what a guest image that can do EFI/SB should have, to start with: http://paste.openstack.org/show/801871/ | 14:21 |
| kashyap | sean-k-mooney: Yes, guest images indeed. | 14:21 |
| sean-k-mooney | so if we need a special test image we need to have that hostsed/cached by infra | 14:21 |
| kashyap | sean-k-mooney: Okay; I'll check w/ the infra folks. | 14:21 |
| sean-k-mooney | kashyap: are there any test image packaged in distors | 14:21 |
| sean-k-mooney | kashyap: i know we sometimes have isos deistibted by rpms | 14:22 |
| kashyap | No, none do it; most do it via install trees | 14:22 |
| kashyap | sean-k-mooney: For example, see how I test it here: https://kashyapc.fedorapeople.org/Create-a-SecureBoot-enabled-VM.bash | 14:22 |
| sean-k-mooney | what we would praobly want to do is convert that into a diskimage builder element | 14:23 |
| sean-k-mooney | then have nodepool build it for us | 14:23 |
| sean-k-mooney | and cache it on the provieders | 14:23 |
| *** hemna has joined #openstack-nova | 14:24 | |
| lyarwood | can the instances pull images from glance in these envs? | 14:24 |
| lyarwood | or swift | 14:24 |
| lyarwood | I guess so | 14:24 |
| sean-k-mooney | i dont think so . i mean they could but dont have logisn to do so | 14:24 |
| kashyap | Yeah, that's the question. The simplest way to get this going is to have a pre-made template (which I'll make) image that Just Works | 14:25 |
| sean-k-mooney | but ya having nodepool upload it as a glance image to the base cloud was one of the thigns i was thinking of | 14:25 |
| sean-k-mooney | but infra also publish the images too on a webshare | 14:25 |
| sean-k-mooney | here https://nb03.opendev.org/ | 14:27 |
| * kashyap clicks | 14:27 | |
| sean-k-mooney | actully no that the lgos there is a place | 14:27 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: Remove allocations before setting vm_status to SHELVED_OFFLOADED https://review.opendev.org/c/openstack/nova/+/771985 | 14:32 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Remove allocations before setting vm_status to SHELVED_OFFLOADED https://review.opendev.org/c/openstack/nova/+/771986 | 14:32 |
| *** jamesdenton has joined #openstack-nova | 14:45 | |
| *** ociuhandu has joined #openstack-nova | 14:49 | |
| *** rpittau is now known as rpittau|afk | 14:58 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Add spec for configurable-instance-hostnames https://review.opendev.org/c/openstack/nova-specs/+/770842 | 14:58 |
| stephenfin | gibi: Address your comments ^ | 14:58 |
| stephenfin | lyarwood: Fancy looking at that simple spec today? ^ | 14:59 |
| lyarwood | stephenfin: yup | 14:59 |
| lyarwood | stephenfin: wasn't the deadline EOD yesterday ;) | 15:00 |
| gibi | the deadline was EOD yesterday :/ | 15:01 |
| *** tesseract has quit IRC | 15:02 | |
| *** tesseract has joined #openstack-nova | 15:02 | |
| gibi | stephenfin: do you want to persuade me to allow a small deadline extension for that? ;) | 15:02 |
| kashyap | gibi: If it's quick, and stephenfin is on fire, any problem in merging it? I'm asking from a purely bystander PoV :-) I don't need that feature myself | 15:02 |
| * kashyap --> call; back later | 15:02 | |
| gibi | kashyap: no real problem, the worst thing is that we will not have time to implement it or review the implementation of it | 15:03 |
| melwitt | elod: re: https://review.opendev.org/c/openstack/nova/+/747362 I had thought the cherry pick check would catch wrong hashes? :/ | 15:05 |
| kashyap | gibi: (Nod) | 15:05 |
| gibi | sean-k-mooney: hi! I don't find the bp https://blueprints.launchpad.net/nova/+spec/port-scoped-sean-k-mooney: I don't find the bp https://blueprints.launchpad.net/nova/+spec/port-scoped-sriov-numa-affinity behind https://review.opendev.org/c/openstack/nova-specs/+/765901 spec | 15:07 |
| sean-k-mooney | oh i might not have filed it ill check just on a call | 15:07 |
| * gibi almost managed to copy paste that message from the morning ^^ | 15:07 | |
| gibi | sean-k-mooney: cool, thanks | 15:08 |
| gibi | just link me to the bp and I will approve it as the spec was mereged | 15:08 |
| elod | melwitt: it did catch :) | 15:09 |
| *** mugsie has joined #openstack-nova | 15:09 | |
| melwitt | elod: oh, good. ah, it hadn't had its zuul result yet at the time I reviewed. ok, all makes sense now :) | 15:10 |
| stephenfin | gibi: I have the code done and the change is small, but it's also probably not important enough to warrant a spec freeze exception | 15:10 |
| *** spatel has joined #openstack-nova | 15:10 | |
| gibi | stephenfin: let's merge it today | 15:10 |
| gibi | lyarwood: ^^ | 15:10 |
| spatel | sean-k-mooney: thank for you comments - https://bugs.launchpad.net/nova/+bug/1912273 | 15:11 |
| openstack | Launchpad bug 1912273 in OpenStack Compute (nova) "SRIOV instance Error: Exception during message handling: KeyError: 'pci_slot'" [Undecided,Incomplete] | 15:11 |
| lyarwood | gibi: ack, just on a call now, I'll review once this is over | 15:12 |
| gibi | thanks | 15:12 |
| elod | melwitt: the 'zuul summary' maybe a bit misleading as it shows the last runs, but does not show that a new test is running | 15:12 |
| spatel | This is what i have noticed, when my vm get oom and stuck/hung then openstack destroying its all configuration from box (is that normal behavior?) | 15:12 |
| melwitt | elod: yeah, I'm not sure what I did to miss it. might have just been pebkac :P | 15:13 |
| elod | :) | 15:14 |
| elod | anyway, it's fixed now, so we'll see :) | 15:14 |
| melwitt | ++ | 15:15 |
| *** vishalmanchanda has quit IRC | 15:15 | |
| *** mugsie has quit IRC | 15:18 | |
| openstackgerrit | Merged openstack/nova master: libvirt: Stop NVMe and ScaleIO unit tests from calling os-brick https://review.opendev.org/c/openstack/nova/+/771806 | 15:20 |
| *** links has quit IRC | 15:24 | |
| *** tesseract has quit IRC | 15:28 | |
| *** tesseract has joined #openstack-nova | 15:32 | |
| openstackgerrit | Merged openstack/nova master: libvirt: Load and cache volume drivers on-demand https://review.opendev.org/c/openstack/nova/+/741545 | 15:34 |
| openstackgerrit | Merged openstack/nova stable/queens: sync_guest_time: use the proper errno https://review.opendev.org/c/openstack/nova/+/742423 | 15:36 |
| openstackgerrit | Merged openstack/nova stable/queens: libvirt: Remove reference to transient domain when detaching devices https://review.opendev.org/c/openstack/nova/+/608186 | 15:36 |
| openstackgerrit | Merged openstack/nova stable/rocky: [stable-only] Cap bandit and make lower-constraints job non-voting https://review.opendev.org/c/openstack/nova/+/766492 | 15:37 |
| *** nweinber has joined #openstack-nova | 15:43 | |
| *** dklyle has joined #openstack-nova | 15:44 | |
| zigo | In Debian Unstable/Testing, I'm getting this for absolutely everything that connects to rabbit: http://paste.openstack.org/show/801876/ | 15:45 |
| zigo | Does anyone know what's going on ? | 15:46 |
| *** mugsie has joined #openstack-nova | 15:51 | |
| *** nweinber has quit IRC | 15:52 | |
| *** nweinber has joined #openstack-nova | 15:53 | |
| frickler | zigo: looks like this one to me https://bugs.launchpad.net/oslo.messaging/+bug/1902696 | 15:56 |
| openstack | Launchpad bug 1902696 in oslo.messaging "nova-compute fails with Unhandled error: TypeError: _wrap_socket_sni() got an unexpected keyword argument 'ca_certs'" [Undecided,New] | 15:56 |
| zigo | frickler: Thanks ! | 15:57 |
| * bauzas goes off (b/c of our curfew) \o | 15:58 | |
| lyarwood | stephenfin: looking at that spec now btw | 15:58 |
| sean-k-mooney | mnaser: hi o/ do you have time for a qq | 15:59 |
| sean-k-mooney | mnaser: we are talking about nova db archives downstream | 16:00 |
| sean-k-mooney | mnaser: we were just wondering how often you run them at vexhost and with what parmaters | 16:00 |
| sean-k-mooney | mnaser: also if you have the openstck ci cluster tuned differently the the rest of the public cloud | 16:01 |
| lyarwood | artom / bauzas: https://review.opendev.org/c/openstack/nova-specs/+/770842 - you're listed on this review, do you want to give it a look before we +W it? | 16:08 |
| lyarwood | stephenfin: ^ LGTM btw, but I'll give others a chance to also look before we merge | 16:09 |
| *** lpetrut has joined #openstack-nova | 16:10 | |
| openstackgerrit | Merged openstack/nova stable/queens: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/c/openstack/nova/+/742424 | 16:11 |
| *** ganso has quit IRC | 16:12 | |
| artom | lyarwood, stephenfin, as I've just posted in the spec, we should also make OS-EXT-SRV-ATTR:hostname not admin-only by default then, right? | 16:13 |
| artom | Since users can now set it? | 16:13 |
| artom | Not sure I want to -1 over that this close to the deadline... | 16:13 |
| stephenfin | Fair point. I can do a follow-up | 16:13 |
| *** lpetrut has quit IRC | 16:14 | |
| lyarwood | ooooff nice catch yeah | 16:14 |
| lyarwood | that's a new microversion at that point right? | 16:15 |
| stephenfin | this is already a new microversion | 16:15 |
| * lyarwood should make that into a t-shirt for our next ptg | 16:15 | |
| artom | Yeah, it already is, just add the visibility thing to it | 16:15 |
| lyarwood | stephenfin: ah true sorry | 16:15 |
| *** ganso has joined #openstack-nova | 16:15 | |
| lyarwood | brb kid just got home | 16:16 |
| artom | By herself? o_O | 16:16 |
| *** ociuhandu has quit IRC | 16:18 | |
| *** ociuhandu has joined #openstack-nova | 16:19 | |
| *** raildo has joined #openstack-nova | 16:20 | |
| gibi | zigo, frickler: I think this is related https://review.opendev.org/c/openstack/requirements/+/761194 | 16:23 |
| zigo | gibi: I've bumped to 5.0.3, this fixes my issues, but now I'm getting: | 16:24 |
| zigo | AttributeError: 'Semaphore' object has no attribute '_at_fork_reinit' | 16:24 |
| zigo | which looks like a problem with Eventlet + Python 3.9... :( | 16:24 |
| gibi | :/ | 16:24 |
| *** ociuhandu has quit IRC | 16:24 | |
| zigo | https://github.com/eventlet/eventlet/issues/646 | 16:24 |
| gibi | zigo: does eventlet officially states that it supports py3.9? | 16:25 |
| lyarwood | artom: yeah we send them down the mines at ~6 months old around here /s | 16:26 |
| zigo | gibi: I don't know, but Bullseye will be released with it (no py3.8 at all). | 16:26 |
| zigo | This looks like fixing it, I'll try: https://github.com/eventlet/eventlet/pull/664/commits/087f2246ef5380cc5d519f614be7e928ab5ea025 | 16:26 |
| zigo | Debian has already 18 patches in the Eventlet package. | 16:27 |
| zigo | Half a decade ago, there was some discussions to get rid of Eventlet in OpenStack. I'd love to have this effort started some day ! | 16:27 |
| zigo | Eventlet is a Bi... (pardon my language). | 16:27 |
| openstackgerrit | Merged openstack/nova-specs master: Add spec for configurable-instance-hostnames https://review.opendev.org/c/openstack/nova-specs/+/770842 | 16:28 |
| zigo | Oh, we got that one already ... :/ | 16:28 |
| gibi | stephenfin: https://review.opendev.org/c/openstack/nova-specs/+/770842 will you push a followup fixing artom's comments? | 16:29 |
| stephenfin | on it | 16:29 |
| gibi | stephenfin: also I dont find the related bp in launchpad | 16:30 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Refactor usage tests to properly test project personas https://review.opendev.org/c/openstack/placement/+/772061 | 16:30 |
| lbragstad | stephenfin ^ that fixes the tests you modified to expose usage in placement to project users | 16:30 |
| *** macz_ has joined #openstack-nova | 16:30 | |
| stephenfin | lbragstad: oh, the project_id was different /o\ | 16:33 |
| stephenfin | I even wrote a quick unit test that proved it worked, but I figured the unit test was wrong because the functional test was obviously correct /o\ | 16:33 |
| lbragstad | stephenfin right - so the tenancy check was doing what it should | 16:33 |
| lbragstad | but i found something else that's concerning and i'm not sure how it's working now | 16:34 |
| lbragstad | stephenfin https://review.opendev.org/c/openstack/placement/+/772061/1/placement/tests/functional/gabbits/usage-secure-rbac.yaml | 16:34 |
| lbragstad | i added negative tests to ensure project users from anther project can't fetch usage information for projects they don't have authorization on | 16:35 |
| *** macz_ has quit IRC | 16:35 | |
| stephenfin | Oh, I noticed that when I was debugging the rule | 16:35 |
| lbragstad | and the project admin persona test fails consistently because the rule:admin_api rule is appended to the new default, regardless of what we're setting up in fixture | 16:35 |
| lbragstad | i went splunking through the enforce_new_default configuration behavior and it appears to be working as expected | 16:36 |
| stephenfin | Hmm, I'm guessing misconfiguration _somewhere_. We have a lot of examples of project reader policies in nova and I'm pretty sure we have unit tests for them all that prove that other project admins can't access $RESOURCE | 16:37 |
| lbragstad | but that deprecated rule check get appended to the default rule magically | 16:37 |
| lbragstad | yeah... i started looking at the placement fixture structure to see if it was doing something unexpected (not cleaning things up properly)? | 16:38 |
| *** ociuhandu has joined #openstack-nova | 16:38 | |
| stephenfin | gibi: There's the BP https://blueprints.launchpad.net/nova/+spec/configurable-instance-hostnames | 16:38 |
| gibi | stephenfin: on it | 16:38 |
| lbragstad | but i couldn't find anything that stuck out - and i'm not that knowledgeable about gabbi/placement tests | 16:38 |
| lbragstad | so - i pushed what i have based on your patch... but if you pull that down you should be able to recreate the issue, it'll fail the check gate | 16:39 |
| stephenfin | Neither am I. They're tough to debug. I can't figure out how to even get logs from the placement server | 16:39 |
| lbragstad | downgrade gabbi | 16:40 |
| stephenfin | I'll have to poke cdent or efried when they're about, to see if they have any suggestions | 16:40 |
| efried | Howdy. TLDR or should I read scrollback? | 16:41 |
| lbragstad | if you're using gabbi > 2.0.0 the output logging is broken | 16:41 |
| lbragstad | https://github.com/cdent/gabbi/issues/287 | 16:41 |
| stephenfin | lbragstad++ Well that makes my life much easier | 16:41 |
| zigo | gibi: I just looked, Eventlet claims compat with ... python 3.7 ! :/ | 16:42 |
| lbragstad | stephenfin downgrading to 1.49.0 works for me | 16:42 |
| lbragstad | in the sense that you can actually capture stdout in tests | 16:42 |
| *** ociuhandu has quit IRC | 16:42 | |
| gibi | zigo: based on that we cannot even release OpenStack :/ | 16:42 |
| zigo | Yeah... | 16:43 |
| zigo | Or I stay forever on Buster... | 16:43 |
| stephenfin | efried: We're seeing some unusual policy behavior in placement as part of the RBAC work, and I was looking for a way to get more info from the placement server to debug. Sounds like it's just a downgrade of gabbi that's needed ^ | 16:43 |
| * zigo tries the latest version 0.30.0 to see what happens. | 16:43 | |
| efried | cool | 16:43 |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Update spec for configurable-instance-hostnames https://review.opendev.org/c/openstack/nova-specs/+/772065 | 16:45 |
| stephenfin | gibi: And there's the spec amendment ^ | 16:46 |
| stephenfin | bauzas, lyarwood, artom also ^ | 16:46 |
| gibi | stephenfin: thanks | 16:47 |
| *** ociuhandu has joined #openstack-nova | 16:47 | |
| zigo | Great, tests.patcher_test.test_fork_after_monkey_patch fails in Py 3.9 ... :/ | 16:50 |
| *** k_mouza_ has quit IRC | 16:52 | |
| *** jmlowe has quit IRC | 16:52 | |
| melwitt | lyarwood: I wanted to ask you about a failure in test_volume_swap I saw yesterday in the gate, have you seen a thing where it doesn't finish the copy and emits "COPY block job progress, current cursor: 1073741823 final cursor: 1073741824" a lot of times, showing that the cursor is only 1 from the end? | 16:53 |
| melwitt | https://zuul.opendev.org/t/openstack/build/a078a17aa9924517b329cafc3f54fed4/log/controller/logs/screen-n-cpu.txt#11115 | 16:54 |
| lyarwood | melwitt: I've not seen it 1 block (!?) away and not finish no | 16:57 |
| lyarwood | melwitt: it's typically much greater than that, did it get there pretty quickly and then stall? | 16:58 |
| melwitt | ack | 16:58 |
| melwitt | erm.. let me check. | 16:58 |
| melwitt | lyarwood: yeah looks like it actually. got there and then stuck on the last block for 4 minutes | 16:59 |
| melwitt | do you suppose this could be similar to problems with live migration where we've needed post copy/auto converge? | 17:00 |
| melwitt | seems weird | 17:00 |
| lyarwood | yeah it might be but I can't think that the cirros image would be writing that much to the volume if at all | 17:00 |
| lyarwood | I think we write timestamps during the test and that's it | 17:00 |
| melwitt | hm ok | 17:01 |
| *** jmlowe has joined #openstack-nova | 17:02 | |
| lyarwood | melwitt: we could write this up as a Ubuntu QEMU bug again and see if upstream can help debug this further | 17:06 |
| lyarwood | melwitt: assuming there's something we can log that would help them | 17:06 |
| melwitt | lyarwood: good idea, let me go through and collect more data (if there is more) and I'll open one if I can find more to go on | 17:08 |
| kashyap | melwitt: So ... just reading the scrollback; that "current" and "final" cursors differing means: the copy (i.e. migration w/ storage) hasn't finished succesfully | 17:08 |
| kashyap | In the past we've hit that, and debugged on list; and I recall filing a libvirt RFE to fix that ... let me check | 17:08 |
| *** k_mouza has joined #openstack-nova | 17:09 | |
| melwitt | kashyap: yeah, I think I understood that but the weird thing is it quickly gets to the last block and then stays stuck there for 4 minutes until the test wait in tempest times out and kills it | 17:09 |
| kashyap | Hmm | 17:09 |
| kashyap | melwitt: Yeah, this definitely looks ome something new | 17:09 |
| kashyap | Because in that old behaviour, libvirt was just making "educated guess" when the syncing has finished | 17:10 |
| melwitt | I see | 17:10 |
| kashyap | Especially the "current cursor" terminology looks new to me. I haven't seen the word "cursor" in this error's context before | 17:10 |
| lyarwood | this is blockCopy and not blockRebase btw kashyap | 17:11 |
| kashyap | melwitt: I don't want to bore you with a long bug, but for the record, here it is: https://bugzilla.redhat.com/show_bug.cgi?id=1382165 | 17:11 |
| openstack | bugzilla.redhat.com bug 1382165 in libvirt "virDomainGetBlockJobInfo: Adjust job reporting based on QEMU stats & the "ready" field of `query-block-jobs`" [Unspecified,Closed: nextrelease] - Assigned to pkrempa | 17:11 |
| kashyap | lyarwood: I see; nod | 17:11 |
| lyarwood | I think we dropped that workaround a while ago | 17:11 |
| kashyap | Yep | 17:11 |
| kashyap | But just for clarity, blockCopy() is a _superset_ of blockRebase() | 17:11 |
| melwitt | kashyap: any data/background helps :) | 17:11 |
| kashyap | (So whatever worked, or failed w/ Rebase(), will also fails equal w/ Copy()) | 17:12 |
| *** zzzeek has quit IRC | 17:12 | |
| lyarwood | yeah https://review.opendev.org/c/openstack/nova/+/729596 removed it | 17:12 |
| kashyap | melwitt: But yeah; filing an upstream Ubuntu QEMU bug would be cool to start with | 17:12 |
| melwitt | k, I'll collect data points and write something up. thanks for the hints both | 17:13 |
| kashyap | lyarwood: Yep, recall it as much, it just reminded me of it. | 17:13 |
| *** zzzeek has joined #openstack-nova | 17:13 | |
| * lyarwood goes back to ethics training | 17:14 | |
| lyarwood | if anyone has anything they'd like me review please let me know | 17:14 |
| kashyap | melwitt: The libvirtd log might have some interesting stuff in there. /me tries to fish it out | 17:14 |
| lyarwood | PLEASE :| | 17:14 |
| kashyap | LOL | 17:15 |
| melwitt | I feel for you. clicky clicky clicky | 17:15 |
| melwitt | click all the things | 17:15 |
| kashyap | lyarwood: I finished it the next day it came; I'm a free man! | 17:15 |
| stephenfin | kashyap: no one likes a show off | 17:15 |
| * kashyap stops thumping chest over utterly trivial actions | 17:15 | |
| kashyap | stephenfin: LOL | 17:15 |
| lyarwood | ./ban kashyap | 17:15 |
| lyarwood | ^_^ | 17:15 |
| kashyap | stephenfin: I know; the secret pleasure of doing the right thing goes away if one brags | 17:16 |
| kashyap | melwitt: I'm looking at the log file here: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_a07/771749/1/check/nova-next/a078a17/controller/logs/libvirt/index.html | 17:18 |
| kashyap | Hope that's the correct log tree | 17:18 |
| melwitt | kashyap: yes that's right | 17:20 |
| kashyap | melwitt: Unrelated: I know that the "controller" directory has the compute logs, but why is it named "controller"? | 17:21 |
| kashyap | (Because there's also the "compute" top-level directory, which has its own QEMU/libvirt logs. It's always tripping me up | 17:21 |
| melwitt | kashyap: in the case of multi-node job, to identify the "main" node vs one of the additional compute nodes | 17:21 |
| kashyap | I see | 17:21 |
| melwitt | in this case you're in the right place bc the swap volume got stuck on the main node | 17:22 |
| *** ociuhandu_ has joined #openstack-nova | 17:22 | |
| melwitt | if it had happened on the other compute node, you'd want to look in the compute1 dir | 17:22 |
| kashyap | melwitt: It looks like so; because I don't see the failure in this libvirtd log | 17:22 |
| kashyap | And these copy failures are logged to libvirtd. So let me look in the other one | 17:22 |
| sean-k-mooney | lyarwood: you should review gibis qos attach | 17:23 |
| sean-k-mooney | series | 17:23 |
| melwitt | kashyap: would there be a failure though? there was no error. it's just that the cursor never moved from the last block | 17:23 |
| kashyap | melwitt: Not a failure per-se; but in Gate, we have libvirt log filters enabled | 17:23 |
| melwitt | and the test timed out at the tempest level as a result of never seeing the 'available' status for the volume | 17:23 |
| sean-k-mooney | lyarwood: im basically done with it and it looks ready to merge IMO | 17:23 |
| kashyap | melwitt: ... so we should see more fine-grained info. And I was hoping to hurl a useful bit at one of the US-based libvirt developers :D | 17:24 |
| sean-k-mooney | lyarwood: but it need a second core to review | 17:24 |
| melwitt | kashyap: ack | 17:24 |
| kashyap | melwitt: Oh, wait ... I first didn't see this error is _actually_ libvirt error. Looks like it's not | 17:25 |
| * kashyap looks closer | 17:25 | |
| sean-k-mooney | lyarwood: specifclly i was refering to https://review.opendev.org/q/topic:%22bp%252Fsupport-interface-attach-with-qos-ports%22+(status:open%20OR%20status:merged) if you are still lookign for somethign easy to review | 17:25 |
| *** ociuhandu has quit IRC | 17:26 | |
| melwitt | kashyap: yeah it's not emitting an error afaik. it's just that we keep checking the job status and it shows it one block from the end and it stays that way for about 4 minutes and then we give up | 17:26 |
| *** ociuhandu_ has quit IRC | 17:27 | |
| kashyap | melwitt: Have you got the instance name, please? | 17:28 |
| kashyap | Found it | 17:31 |
| melwitt | kashyap: uuid is 185d6573-58ee-47bc-8063-b447673db266, are you wanting the instanceNNNNNN id? | 17:32 |
| melwitt | sorry, I was double checking whether I got the right one | 17:32 |
| kashyap | melwitt: No-no; that's fine :-) | 17:32 |
| melwitt | my eyes are like @_@ | 17:32 |
| kashyap | melwitt: Heh; urgh; my FF browser is hung | 17:33 |
| kashyap | Also there's an unpleasant easter egg in there (I knew it before too): ".txt" files are actually *gzip* files that will devour your RAM, if you try open them in your browser | 17:33 |
| kashyap | Alright it came back. And it's this: instance-00000013 (185d6573-58ee-47bc-8063-b447673db266). Let's see if there's anything useful | 17:35 |
| sean-k-mooney | kashyap: that depend on which of the ci provider the logs are uploaded too | 17:37 |
| sean-k-mooney | the rackspace cloud for reason has there swift cluster configured in such a way that it always compresses them but does not send the correct headers | 17:37 |
| sean-k-mooney | for things like curl to work | 17:37 |
| kashyap | I see | 17:42 |
| kashyap | melwitt: So ... something interesting (at least to me) :-) -- | 17:42 |
| kashyap | I just extracted the exchange between libvirt and QEMU from the giant log here: https://kashyapc.fedorapeople.org/QMP_exchange_libvirtd_22Jan2021_NovaCI.txt | 17:43 |
| kashyap | So ... the copy has actually *succeeded*. Here's the evidence: | 17:43 |
| kashyap | - You `grep` for "blockdev-mirror" in there (at 2021-01-21 05:29:32.630+0000) -- that's the start of the copy job | 17:43 |
| kashyap | - Then there's constant polling going on -- you'll see a lot of "io-status": "ok" going on there | 17:44 |
| kashyap | - Finally, at 2021-01-21 05:34:24.571+0000 | 17:44 |
| kashyap | We get the "ready" flag (which means copy has completed: notice the values of 'len' and 'offset' are equal: | 17:45 |
| kashyap | {"return": [{"auto-finalize": true, "io-status": "ok", "device": "copy-vdb-libvirt-5-format", "auto-dismiss": false, "busy": true, "len": 1073741824, "offset": 1073741824, "status": "running", "paused": false, "speed": 0, "ready": false, "type": "mirror"}], "id": "libvirt-843"} | 17:45 |
| kashyap | melwitt: So, all I can say for now is the copy has succeeded. So I'm not sure why it's saying the copy is not progressing | 17:46 |
| *** ociuhandu has joined #openstack-nova | 17:47 | |
| kashyap | melwitt: I'm out of neurons, and need to make some food ... we can continue the chat in the (future) bug | 17:47 |
| melwitt | thanks kashyap, that's helpful. have a nice weekend o/ | 17:48 |
| kashyap | (I think it can't progress because it has reached the end of the copy -- the value in the error matches what I posted above: 1073741824. Hm, needs further digging.) | 17:51 |
| *** gyee has joined #openstack-nova | 17:51 | |
| kashyap | Have a good weekend, you too! | 17:51 |
| *** ralonsoh has quit IRC | 17:51 | |
| melwitt | kashyap: yeah it seems the job_status api is returning the wrong thing then, or such | 17:51 |
| melwitt | get_job_info https://github.com/openstack/nova/blob/master/nova/virt/libvirt/guest.py#L863-L873 | 17:52 |
| *** ociuhandu has quit IRC | 17:53 | |
| lyarwood | is it just a race? | 17:58 |
| * lyarwood hasn't checked the timestamps | 17:58 | |
| lyarwood | but did libvirtd log the job as finished after n-cpu had already given up? | 17:58 |
| *** tesseract has quit IRC | 17:59 | |
| *** derekh has quit IRC | 18:01 | |
| *** luksky has quit IRC | 18:01 | |
| *** luksky has joined #openstack-nova | 18:03 | |
| *** manuvakery1 has quit IRC | 18:03 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Replace blind retry with libvirt event waiting in detach https://review.opendev.org/c/openstack/nova/+/770246 | 18:10 |
| melwitt | lyarwood: I will check | 18:11 |
| *** slaweq has quit IRC | 18:12 | |
| gibi | have a nice weekend folks! o/ | 18:15 |
| lyarwood | and you gibi \o | 18:16 |
| * lyarwood also drops | 18:16 | |
| *** lbragstad has quit IRC | 18:16 | |
| lyarwood | o/ all | 18:16 |
| sean-k-mooney | o/ | 18:16 |
| melwitt | lyarwood: interesting, it looks like in libvirtd log it shows current == end but what we get in nova when we query is not, it's current == end - 1 | 18:17 |
| melwitt | lyarwood: and also o/ | 18:17 |
| *** dtantsur is now known as dtantsur|afk | 18:17 | |
| sean-k-mooney | gibi: finished reviewing you qos series, +1 on most of it but left two -1s nothing major just look to confirm detach will work too and a minor issue with comments | 18:18 |
| sean-k-mooney | gibi: but ya enjoy your weekend | 18:19 |
| *** lbragstad has joined #openstack-nova | 18:22 | |
| *** nightmare_unreal has quit IRC | 18:25 | |
| gmann | lbragstad: 1 comment on this https://review.opendev.org/c/openstack/placement/+/760240/15/placement/tests/functional/gabbits/resource-provider-legacy-rbac.yaml#20 | 18:26 |
| gmann | lbragstad: we should check all persona for legacy policy also. | 18:27 |
| gmann | basically checking all those tokens with enforce_scope false and true | 18:27 |
| sean-k-mooney | ok im going to finish there too o/ | 18:27 |
| lbragstad | gmann ok - i was thinking you only wanted testing for the default personas that were supported prior to secure RBAC? | 18:30 |
| lbragstad | gmann does nova test system personas and reader personas with enforce_scope=False and enforce_new_defaults=False? | 18:30 |
| openstackgerrit | Merged openstack/nova-specs master: Update spec for configurable-instance-hostnames https://review.opendev.org/c/openstack/nova-specs/+/772065 | 18:30 |
| gmann | lbragstad: yeah we test all those with all those combination of config | 18:31 |
| *** macz_ has joined #openstack-nova | 18:31 | |
| gmann | lbragstad: is there any admin-or-owner rule? | 18:31 |
| lbragstad | for placement? | 18:31 |
| gmann | yeah | 18:32 |
| gmann | for nova I added all persona to check owner thing basically | 18:32 |
| lbragstad | no - all of placement was protected with rule:admin_api which just checks role:admin essentially | 18:32 |
| gmann | ok, in that case system-admin will also be able to access if enforce_scope is false | 18:32 |
| gmann | as no project-id is checked there | 18:33 |
| lbragstad | correct - system-admin will be able to access placement APIs | 18:33 |
| gmann | admin is ok but reader we can make sure if new reader (project or system) cannot access in case of enforce_scope=false because we care changing the check_str to system_reader | 18:34 |
| gmann | does it make sense? | 18:35 |
| sean-k-mooney | we generally dont want project admins to be able to access placment by the way | 18:35 |
| sean-k-mooney | and im not sure domain admins should eb able to either | 18:35 |
| *** macz_ has quit IRC | 18:36 | |
| sean-k-mooney | plamcnet is one of those things that really only system admins should have access too | 18:36 |
| gmann | sean-k-mooney: with new policy rigtht? | 18:36 |
| sean-k-mooney | well system member would be ok too | 18:36 |
| sean-k-mooney | gmann: yep | 18:36 |
| gmann | yeah. that is lbragstad change does | 18:36 |
| gmann | legacy Admin to SYSTEM_ADMIN | 18:37 |
| sean-k-mooney | basically we need to enforce system scope | 18:37 |
| sean-k-mooney | ya | 18:37 |
| gmann | yeah | 18:37 |
| lbragstad | well - there was a note in placement about exposing the usage API to project users | 18:37 |
| sean-k-mooney | there may be uses for system reader or system member/user at somepoint | 18:38 |
| lbragstad | from when mriedem refactored placement's policy enforcement and moved default policies into code | 18:38 |
| lbragstad | stephenfin thought we should address that comment while we're in there mucking with the secure RBAC changes... | 18:38 |
| sean-k-mooney | lbragstad: well currenlty plamcnet is not recommended to be exposed to endusers at all | 18:38 |
| sean-k-mooney | at least in a public cloud case its provide a view into your infrastucre that you dont want normal tenants to have | 18:39 |
| lbragstad | ok - in that case we should let stephenfin know? i'm assume i'm the person with the least amount of placement context | 18:39 |
| lbragstad | https://review.opendev.org/c/openstack/placement/+/771964/1 | 18:39 |
| sean-k-mooney | there is perhaps a usces with unified limits | 18:40 |
| sean-k-mooney | where if we are counting quots with lmits some endpoint might be ok | 18:40 |
| sean-k-mooney | the RP endpoint and allocation candiates endpoint no | 18:40 |
| sean-k-mooney | but looking an allocations for your instance might be ok | 18:41 |
| gmann | but does not it give usages for requested project | 18:41 |
| sean-k-mooney | each resouce provider has the hostname as its name so we cant allow project user to do an RP show for example | 18:41 |
| sean-k-mooney | i though the usage endpoint was teh usage of an invetory | 18:42 |
| sean-k-mooney | ok https://docs.openstack.org/api-ref/placement/?expanded=list-usages-detail#list-usages | 18:43 |
| sean-k-mooney | would be ok for project users | 18:43 |
| sean-k-mooney | that is the quota sutff | 18:44 |
| sean-k-mooney | lbragstad: so https://review.opendev.org/c/openstack/placement/+/771964/1/placement/tests/functional/gabbits/usage-secure-rbac.yaml is fine | 18:44 |
| gmann | yeah it make sense to have project scope there | 18:45 |
| sean-k-mooney | i think /resource_providers /reshaper /allocation_candidates need to be system scope at lest by default | 18:45 |
| sean-k-mooney | im not sure about /allocations/{consumer_uuid} | 18:46 |
| lbragstad | yeah - stephenfin's change was specific to the usage API i believe | 18:47 |
| sean-k-mooney | i think that would actully be ok as it is today for projects too https://docs.openstack.org/api-ref/placement/?expanded=list-allocations-detail#list-allocations | 18:47 |
| lbragstad | because of https://review.opendev.org/c/openstack/placement/+/771964/1/placement/policies/usage.py#52 | 18:47 |
| sean-k-mooney | ya ok i think stephenfin's patch is going in the right direction | 18:49 |
| sean-k-mooney | i dont see anything that is definetly incorrect e.g. too borad | 18:49 |
| sean-k-mooney | ill start it for monday | 18:50 |
| lbragstad | ok - i'd appreciate it, i think there are some things in how placement sets up fixtures that need to be investigated, too https://review.opendev.org/c/openstack/placement/+/772061/1/placement/tests/functional/gabbits/usage-secure-rbac.yaml | 18:51 |
| *** k_mouza has quit IRC | 18:56 | |
| gmann | lbragstad: commented in this ^^. project_id is not passed for policy check | 18:56 |
| *** andrewbonney has quit IRC | 18:56 | |
| gmann | if we pass req.project_id in context.can() then it can fail if it is different from context.project_id | 18:57 |
| gmann | I have not tested that just checked it in code. I faced many such isuse in nova APIs | 18:57 |
| lbragstad | gmann i think we already fixed that in the previous patch | 18:58 |
| gmann | oh, did not see that | 18:58 |
| *** jamesdenton has quit IRC | 19:43 | |
| *** jamesdenton has joined #openstack-nova | 19:43 | |
| *** slaweq has joined #openstack-nova | 19:46 | |
| *** slaweq has quit IRC | 20:01 | |
| *** bbowen has quit IRC | 20:33 | |
| *** nweinber has quit IRC | 20:34 | |
| *** viks____ has quit IRC | 20:50 | |
| *** READ10 has joined #openstack-nova | 20:54 | |
| *** k_mouza has joined #openstack-nova | 20:56 | |
| *** rcernin has joined #openstack-nova | 20:58 | |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for resource providers https://review.opendev.org/c/openstack/placement/+/760240 | 21:01 |
| *** k_mouza has quit IRC | 21:01 | |
| *** rcernin has quit IRC | 21:02 | |
| *** rcernin has joined #openstack-nova | 21:03 | |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for resource providers https://review.opendev.org/c/openstack/placement/+/760240 | 21:05 |
| *** k_mouza has joined #openstack-nova | 21:15 | |
| *** k_mouza has quit IRC | 21:20 | |
| *** rcernin has quit IRC | 21:28 | |
| *** READ10 has quit IRC | 21:41 | |
| *** xek_ has quit IRC | 21:48 | |
| *** macz_ has joined #openstack-nova | 22:33 | |
| *** bbowen has joined #openstack-nova | 22:37 | |
| *** macz_ has quit IRC | 22:37 | |
| *** rcernin has joined #openstack-nova | 22:46 | |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for resource providers https://review.opendev.org/c/openstack/placement/+/760240 | 22:47 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for aggregates https://review.opendev.org/c/openstack/placement/+/760235 | 22:47 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for allocations https://review.opendev.org/c/openstack/placement/+/760236 | 22:47 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for allocation candidates https://review.opendev.org/c/openstack/placement/+/760237 | 22:47 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for inventories https://review.opendev.org/c/openstack/placement/+/760238 | 22:47 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for resource classes https://review.opendev.org/c/openstack/placement/+/760239 | 22:47 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for traits https://review.opendev.org/c/openstack/placement/+/760241 | 22:47 |
| *** spatel has quit IRC | 22:50 | |
| *** zzzeek has quit IRC | 22:56 | |
| *** zzzeek has joined #openstack-nova | 22:57 | |
| *** ociuhandu has joined #openstack-nova | 22:59 | |
| *** ociuhandu has quit IRC | 23:03 | |
| *** jamesdenton has quit IRC | 23:40 | |
| *** jamesdenton has joined #openstack-nova | 23:41 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!