Wednesday, 2021-02-03

*** tosky has quit IRC00:15
*** LinPeiWen42 has joined #openstack-nova00:31
*** sapd1 has joined #openstack-nova01:24
*** martinkennelly has quit IRC01:40
*** dviroel has quit IRC01:54
*** mlavalle has quit IRC01:55
openstackgerritMerged openstack/nova master: zuul: Increase SWIFT_LOOPBACK_DISK_SIZE within nova-lvm job  https://review.opendev.org/c/openstack/nova/+/77270202:06
openstackgerritMerged openstack/nova master: zuul: Mark nova-lvm as voting  https://review.opendev.org/c/openstack/nova/+/77287102:06
openstackgerritWenping Song proposed openstack/nova master: Replaces tenant_id with project_id from Flavor Access APIs  https://review.opendev.org/c/openstack/nova/+/76770402:10
*** zzzeek has quit IRC02:12
*** zzzeek has joined #openstack-nova02:12
*** lbragstad_ has joined #openstack-nova02:14
*** k_mouza has joined #openstack-nova02:15
*** lbragstad has quit IRC02:17
*** hemanth_n has joined #openstack-nova02:19
*** k_mouza has quit IRC02:19
*** rcernin has quit IRC02:37
*** rcernin has joined #openstack-nova02:51
*** tbachman has quit IRC02:51
*** tbachman has joined #openstack-nova02:54
*** tbachman_ has joined #openstack-nova02:56
*** tbachman has quit IRC02:59
*** tbachman_ is now known as tbachman02:59
*** LinPeiWen42 has quit IRC03:13
*** dustinc has joined #openstack-nova03:29
*** lbragstad_ is now known as lbragstad03:51
*** spatel has quit IRC04:13
*** spatel has joined #openstack-nova04:14
*** zul has quit IRC04:16
*** ratailor has joined #openstack-nova04:19
*** LinPeiWen has joined #openstack-nova04:23
*** spatel has quit IRC04:24
*** spatel has joined #openstack-nova04:24
*** links has joined #openstack-nova04:25
*** swp20 has quit IRC04:27
*** swp20 has joined #openstack-nova04:27
*** lemko2 has joined #openstack-nova04:28
*** lemko has quit IRC04:29
*** lemko2 is now known as lemko04:29
*** spatel has quit IRC04:34
*** brinzhang has quit IRC04:52
*** brinzhang has joined #openstack-nova04:53
*** brinzhang_ has joined #openstack-nova05:02
*** brinzhang has quit IRC05:05
*** khomesh24 has joined #openstack-nova05:34
*** xinranwang has joined #openstack-nova05:35
xinranwangHi all, fyi, here is a test report for smartnic support. We have tested the code in local, you can also following the report's instruction to test our patches. https://wiki.openstack.org/wiki/Cyborg/TestReport/IntelNic05:37
*** dustinc has quit IRC05:39
*** lemko has quit IRC05:46
*** lemko7 has joined #openstack-nova05:46
*** khomesh24 has quit IRC05:47
*** sapd1 has quit IRC05:54
*** khomesh24 has joined #openstack-nova05:55
*** khomesh24 has quit IRC05:55
*** khomesh24 has joined #openstack-nova05:56
openstackgerritmelanie witt proposed openstack/nova master: Centralize sqlite FK constraint enforcement  https://review.opendev.org/c/openstack/nova/+/77383305:56
openstackgerritmelanie witt proposed openstack/nova master: WIP Dynamically archive FK related records in archive_deleted_rows  https://review.opendev.org/c/openstack/nova/+/77383405:56
*** rcernin has quit IRC06:08
*** rcernin has joined #openstack-nova06:08
*** ratailor has quit IRC06:14
*** ratailor has joined #openstack-nova06:14
*** rcernin has quit IRC06:17
*** rcernin has joined #openstack-nova06:17
*** rcernin has quit IRC06:17
*** rcernin has joined #openstack-nova06:19
*** k_mouza has joined #openstack-nova06:26
*** ratailor has quit IRC06:28
*** ratailor has joined #openstack-nova06:28
*** k_mouza has quit IRC06:30
*** sapd1 has joined #openstack-nova06:49
*** dasp has joined #openstack-nova07:00
*** dasp_ has quit IRC07:01
*** brinzhang_ has quit IRC07:04
*** brinzhang_ has joined #openstack-nova07:04
*** khomesh24 has quit IRC07:24
*** aarents has joined #openstack-nova07:25
*** slaweq has joined #openstack-nova07:28
*** ralonsoh has joined #openstack-nova07:28
*** vishalmanchanda has joined #openstack-nova07:33
*** sapd1 has quit IRC07:37
*** khomesh24 has joined #openstack-nova07:40
*** sapd1 has joined #openstack-nova07:42
*** ircuser-1 has joined #openstack-nova07:45
*** zenkuro has joined #openstack-nova07:52
*** dklyle has quit IRC07:58
*** zenkuro has quit IRC08:07
*** zenkuro has joined #openstack-nova08:09
*** psachin has joined #openstack-nova08:11
*** zenkuro has quit IRC08:14
*** andrewbonney has joined #openstack-nova08:19
*** tesseract has joined #openstack-nova08:20
*** zenkuro has joined #openstack-nova08:21
*** macz_ has joined #openstack-nova08:23
*** macz_ has quit IRC08:27
*** tesseract has quit IRC08:30
*** tesseract has joined #openstack-nova08:32
*** tosky has joined #openstack-nova08:40
*** rpittau|afk is now known as rpittau08:41
*** zenkuro has quit IRC08:48
*** brinzhang_ has quit IRC08:59
*** brinzhang_ has joined #openstack-nova09:00
*** ociuhandu has joined #openstack-nova09:06
kashyaplyarwood: Thanks for the rebase!09:16
kashyaplyarwood: (On this one: https://review.opendev.org/c/openstack/nova/+/758763)09:17
kashyapIt passed, BTW :-)09:19
lyarwoodkashyap: \o morning, np and cool I'll review now, elod ^ you also if you have time, could you review this please?09:25
kashyapMorning09:27
*** xek has joined #openstack-nova09:28
*** ociuhandu has quit IRC09:28
kashyaplyarwood: The tricky thing is that patch is a band-aid for some scenarios -- but will not fix the more difficult CPU-based live migration problems fully.09:29
kashyaplyarwood: I've been thinking enough that I had a CPU model bug walk into my dream last night!09:29
lyarwoodhaha09:29
kashyapNo kidding; I felt strange waking up09:29
kashyaplyarwood: Given the bug OSP upgrades folks found ... for the fuller solution, a potential process trouble:09:30
lyarwoodkashyap: so that isn't going to resolve the the noTSX part?09:30
*** nightmare_unreal has joined #openstack-nova09:30
kashyaplyarwood: It should, if your CPU problems are _just_ related to TSX09:31
lyarwoodkashyap: ack09:31
lyarwoodstephenfin: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_f6e/769920/3/check/openstack-tox-py38/f6e5b16/testr_results.html btw, looks like my posion patch found *some* get_arch holes09:31
kashyaplyarwood: The aforementioned "process trouble" is: I'm working w/ chengsheng (don't see them on IRC for a while) here (https://review.opendev.org/c/openstack/nova/+/762330/) to switch to newer CPU APIs09:31
stephenfinlyarwood: oh boy :)09:32
kashyapI've suggested a patch split of 5 pieces for ease of reviewing in my comment on PS12.09:32
* stephenfin wonders how09:32
stephenfinlyarwood: Can you look at this. Should unblock circa 10 RBAC patches https://review.opendev.org/c/openstack/placement/+/771852/09:32
stephenfin*?09:33
lyarwoodstephenfin: ack09:33
*** ociuhandu has joined #openstack-nova09:33
kashyapIf chengsheng is busy; I'll split it (and give attribution where due, of course) as per the original spec ... which is not proposed for W -- that's the "too late to get in spec" process part; we uncovered this problem only recently.09:34
lyarwoodstephenfin: ah re the stable placement changes, I'm not a placement stable core09:34
* kashyap --> coffee09:34
stephenfinoh, really?09:34
stephenfinthat sounds like another situation where we should be merging nova and placement09:35
stephenfingibi? ^09:35
lyarwoodyeah it's a old list + stable-maint-core09:35
lyarwoodwhich I'm also not a member of09:35
gibihm09:35
gibido you suggest to add nova-stable-core to placement-stable-core?09:35
lyarwoodkashyap: yeah it's too late for W09:35
kashyaplyarwood: Right, aware of that09:36
stephenfinYeah, I think that's a reasonable move09:36
lyarwoodkashyap: but we can still get it into a good state for X09:36
kashyapYep09:36
lyarwoodgibi: yes I think that would help09:36
kashyaplyarwood: So, what I'm hoping is, if the band-aid backport above will fix most cases, we can get away with solid documentation of the issue.09:36
lyarwoodgibi: given we have outstanding .gitreview changes for stable/victoria still09:36
kashyap(Which, I'm writing)09:36
lyarwoodkashyap: well downstream at least we could backport that09:37
kashyaplyarwood: Sorry, backport what?  The earlier-mentioned train backport?09:38
kashyapIf so, yes, of course09:38
lyarwoodthe feature, it looks pretty self contained in the virt driver09:38
lyarwoodtbh you could even sell that as a bugfix in W09:38
lyarwoodfor me at least09:38
lyarwoodif it's replacing broken behaviour09:38
*** derekh has joined #openstack-nova09:39
lyarwoodstephenfin: ^ would you agree?09:39
lyarwoodstephenfin: context is https://review.opendev.org/c/openstack/nova/+/76233009:39
stephenfinThis is about libvirt using the wrong APIs?09:39
lyarwoodstephenfin: switching over to a different libvirt API for checking CPUs09:39
lyarwoodyeah09:39
stephenfinYeah, I thought that was a bug tbh. Is someone saying otherwise?09:40
* stephenfin promised to review that but hasn't yet /o\09:40
lyarwoodit's associated with a blueprint09:40
kashyaplyarwood: Yeah, it could be argued as a bug-fix in good-faith09:40
*** psachin has quit IRC09:40
lyarwoodcool, lets drop that reference and proceed as a bugfix09:41
kashyaplyarwood: It is associated with a spec even: https://opendev.org/openstack/nova-specs/commit/70811da221035044e2709:41
kashyapSee the work items for the recommended split of patches09:41
openstackgerritWenping Song proposed openstack/nova master: Replaces tenant_id with project_id from List SG API  https://review.opendev.org/c/openstack/nova/+/76672609:42
openstackgerritWenping Song proposed openstack/nova master: Replaces tenant_id with project_id from Flavor Access APIs  https://review.opendev.org/c/openstack/nova/+/76770409:42
lyarwoodMIN_{LIBVIRT,QEMU}_VERSION is beyond the required versions now so I'd say this is even more of a bugfix09:42
lyarwoodwith some pre-written documentation we can use from the spec ;)09:42
kashyaplyarwood: Yeap, yeap09:42
*** psachin has joined #openstack-nova09:44
gibilyarwood, stephenfin: sent a mail about placement-stable-maint to ML http://lists.openstack.org/pipermail/openstack-discuss/2021-February/020186.html09:44
lyarwoodgibi: many thanks09:44
gibiI will couple of days and then I will make the change09:44
*** ociuhandu has quit IRC09:45
lyarwoodack09:45
*** LinPeiWen has quit IRC10:00
elodlyarwood: kashyap: +2+W'd >>> https://review.opendev.org/c/openstack/nova/+/75876310:02
kashyapelod: Thanks!10:02
*** martinkennelly has joined #openstack-nova10:02
elodkashyap: np :)10:02
*** martinkennelly has quit IRC10:02
*** psachin has quit IRC10:04
*** LinPeiWen has joined #openstack-nova10:18
*** ociuhandu has joined #openstack-nova10:19
*** ociuhandu has quit IRC10:24
*** rcernin has quit IRC10:24
*** k_mouza has joined #openstack-nova10:27
*** k_mouza has quit IRC10:31
*** ociuhandu has joined #openstack-nova10:36
*** ociuhandu has quit IRC10:41
*** ociuhandu has joined #openstack-nova10:42
*** dtantsur|afk is now known as dtantsur10:49
*** k_mouza has joined #openstack-nova10:52
*** rcernin has joined #openstack-nova10:55
*** LinPeiWen has quit IRC11:02
*** ratailor has quit IRC11:09
*** ratailor has joined #openstack-nova11:09
*** xinranwang has quit IRC11:13
*** dviroel has joined #openstack-nova11:15
*** rcernin has quit IRC11:15
*** ociuhandu has quit IRC11:27
*** jangutter_ has joined #openstack-nova11:32
*** jangutter has quit IRC11:36
openstackgerritLee Yarwood proposed openstack/nova master: fup: Merge duplicate volume attachment checks  https://review.opendev.org/c/openstack/nova/+/77338011:36
*** LinPeiWen has joined #openstack-nova11:38
*** sapd1 has quit IRC11:49
*** tbachman has quit IRC11:52
*** tbachman has joined #openstack-nova11:53
*** martinkennelly has joined #openstack-nova11:58
*** ociuhandu has joined #openstack-nova11:59
*** martinkennelly has quit IRC11:59
*** martinkennelly has joined #openstack-nova12:00
*** rcernin has joined #openstack-nova12:01
*** jangutter has joined #openstack-nova12:05
*** jangutter_ has quit IRC12:08
*** ociuhandu_ has joined #openstack-nova12:12
*** ociuhandu has quit IRC12:15
*** macz_ has joined #openstack-nova12:20
*** macz_ has quit IRC12:24
*** sapd1 has joined #openstack-nova12:33
*** rcernin has quit IRC12:43
*** ociuhandu_ has quit IRC12:46
*** ociuhandu has joined #openstack-nova12:47
*** hemanth_n has quit IRC13:00
*** martinkennelly has quit IRC13:01
*** sapd1 has quit IRC13:10
*** ociuhandu has quit IRC13:10
*** ociuhandu has joined #openstack-nova13:11
*** ratailor has quit IRC13:14
*** sapd1 has joined #openstack-nova13:22
sean-k-mooney V comes after U ...13:45
sean-k-mooneymeaning i need to backport to Victoria then Ussuri13:46
*** zul has joined #openstack-nova13:50
openstackgerritsean mooney proposed openstack/nova stable/victoria: only wait for plugtime events in pre-live-migration  https://review.opendev.org/c/openstack/nova/+/77074413:51
*** whoami-rajat__ has joined #openstack-nova13:55
sean-k-mooneylyarwood: can you take a look at ^ again13:56
sean-k-mooneynow that its in the correct order13:56
*** lbragstad has quit IRC13:57
bauzassean-k-mooney: fwiw, I'm splitting my -W change for routed networks14:01
bauzasthe functests are saying OK so we know it works14:01
bauzas(for all the move operations)14:01
sean-k-mooneyok14:02
sean-k-mooneyi assume your going to either move teh func tests or the unit tests to a second patch?14:03
sean-k-mooneyfor this type of change i trust the func tests more so would prefer those to stay with the code but ill leave that up to you14:03
sean-k-mooneywe will be reviewing the serise as a whole anyway14:03
bauzasno, I'll have the functests in the same change for the filter14:07
bauzasbut I'll move the renaming of ensure_network_metadata() in a dependent change14:08
*** ociuhandu has quit IRC14:08
*** ociuhandu has joined #openstack-nova14:09
sean-k-mooneycool14:10
*** brinzhang_ has quit IRC14:17
*** brinzhang_ has joined #openstack-nova14:17
*** ociuhandu has quit IRC14:27
*** ociuhandu has joined #openstack-nova14:28
*** ociuhandu has quit IRC14:32
*** zoharm has joined #openstack-nova14:33
*** brinzhang_ has quit IRC14:35
*** lbragstad has joined #openstack-nova14:35
*** brinzhang_ has joined #openstack-nova14:36
*** alex_xu has joined #openstack-nova14:39
gibifyi cores, I'm +2 on the vnc password patch https://review.opendev.org/c/openstack/nova/+/622336/ but it needs a second set of eyes14:48
sean-k-mooneyhum that touches a bunch of files but most are small changes it seams14:56
sean-k-mooneyim not a core but ill take a look at it14:57
gibisean-k-mooney: cool, thanks14:57
sean-k-mooneyit dose not look that difficult to reiew14:57
*** ociuhandu has joined #openstack-nova15:06
*** k_mouza has quit IRC15:14
*** ociuhandu has quit IRC15:15
*** ociuhandu has joined #openstack-nova15:18
*** khomesh24 has quit IRC15:23
*** khomesh24 has joined #openstack-nova15:23
*** sapd1 has quit IRC15:26
sean-k-mooneygibi: -1 because i have a question on allowing console without a password to be created when the nova config has [vnc]/auth_schemes = none,vnc,vencrypt15:31
gibisean-k-mooney: thanks15:32
sean-k-mooneygibi: but other then that the code looks ok15:32
sean-k-mooneymy comments are on the patch but while i woudl prefer not to save the pasword in plain text in novas db it is out of scope to use barbican so i view that as a future imporvment not a requirement for the feature15:33
*** links has quit IRC15:34
openstackgerritBalazs Gibizer proposed openstack/nova stable/ussuri: Reproduce bug 1907522 in functional test  https://review.opendev.org/c/openstack/nova/+/77393015:41
openstackbug 1907522 in OpenStack Compute (nova) victoria "test_*_with_qos_min_bw_allocation fails in the nova-multi-cell job with: nova.exception.MigrationPreCheckError: Migration pre-check error: Failed to create port bindings for host <host>" [Medium,In progress] https://launchpad.net/bugs/1907522 - Assigned to Balazs Gibizer (balazs-gibizer)15:41
openstackgerritBalazs Gibizer proposed openstack/nova stable/ussuri: Fallback to same-cell resize with qos ports  https://review.opendev.org/c/openstack/nova/+/77393215:42
*** dklyle has joined #openstack-nova15:51
*** k_mouza has joined #openstack-nova15:52
*** dklyle has quit IRC15:53
*** david-lyle has joined #openstack-nova15:53
*** ociuhandu_ has joined #openstack-nova16:00
*** sapd1 has joined #openstack-nova16:03
*** ociuhandu has quit IRC16:03
melwittkashyap: took me awhile (sorry) but here's the qemu bug I opened about the block copy taking a long time to end the job after the last block is done https://bugs.launchpad.net/qemu/+bug/191428216:08
openstackLaunchpad bug 1914282 in QEMU "block copy job sometimes hangs on the last block for minutes" [Undecided,New]16:08
kashyapmelwitt: Hello16:08
melwitthello16:08
kashyapmelwitt: Thanks for filing; no need for sorry :-)16:09
kashyapmelwitt: Nice write-up16:09
kashyapmelwitt: One small comment; do you want to attach the pastebin content as a text file to the bug?16:09
kashyapAs pastebins expire16:09
melwittkashyap: oh, yeah, I will do that16:10
kashyapmelwitt: Also, the bug will show up on the main 'qemu-devel' list; so the Block Layer devs should notice it16:10
melwittI thought pastebin wasn't expiration by default but it's a good idea to attach it even so16:10
kashyapIf we don't hear a response in a week, I'll get Eric Blake to have a gander; he knows this inside out, as someone who's worked on QEMU and libvirt16:10
*** LinPeiWen has quit IRC16:11
melwittok great16:11
*** macz_ has joined #openstack-nova16:12
kashyapmelwitt: Is this affecting the Gate quite often?16:13
melwittkashyap: I think no but I don't know for sure bc I haven't figured out a unique fingerprint to logstash for it16:14
* kashyap taps on the table and thinks16:14
melwittlyarwood: I opened this bug yesterday based on a gate failure I saw and was curious if you've ever seen this before? https://bugs.launchpad.net/nova/+bug/191429616:25
openstackLaunchpad bug 1914296 in OpenStack Compute (nova) "tests involving encrypted volumes sometimes (rarely) fail with libvirtError: [...] Volume is not in LUKS format" [Undecided,New]16:25
kashyapmelwitt: Hmm, so I can't see a unique signature either ... as most of the messages are "usual", but they're on loop16:26
kashyapUnless I'm missing something badly, looks like it's tricky to check for its frequency16:26
melwittkashyap: yeah exactly. the only place where I think we have a chance is in the job-output.txt but IIRC that text is also quite generic16:26
melwittI will take another look to see if anything jumps out16:26
kashyapmelwitt: Thank you.  I hope this won't come back to bite us - as we can't (yet) see how often we're hitting it16:27
lyarwoodmelwitt: can't say I have, *clicks*16:28
lyarwoodmelwitt: if it's a block device n-cpu should format it with LUKS before using it16:29
melwittlyarwood: it seems weird bc the error message says both format=luks and then "Volume not in LUKS format", like how is that possible?16:30
*** ociuhandu_ has quit IRC16:30
lyarwoodmelwitt: urgh that chrome tab just died, I'll pull down the log after the call if that's okay16:31
* lyarwood has 64GB of RAM and still chrome tabs die16:31
melwittsure np, just wanted to link you before I forgot16:31
melwittit's not urgent16:31
*** mjturek has joined #openstack-nova16:32
*** mlavalle has joined #openstack-nova16:34
*** ociuhandu has joined #openstack-nova16:38
*** spatel has joined #openstack-nova16:39
*** sapd1 has quit IRC16:50
*** zoharm has quit IRC16:52
kashyapmelwitt: I have attached the QEMU <-> libvirt exchange from the dest-host in the bug.17:13
*** spatel has quit IRC17:14
melwittkashyap: thanks!17:14
kashyapNP.  Thx, you too17:15
*** spatel has joined #openstack-nova17:16
*** ralonsoh has quit IRC17:31
*** ociuhandu_ has joined #openstack-nova17:34
*** khomesh24 has quit IRC17:34
*** k_mouza has quit IRC17:35
*** ociuhandu has quit IRC17:37
*** ociuhandu_ has quit IRC17:38
*** david-lyle is now known as dklyle17:39
*** k_mouza has joined #openstack-nova17:41
sean-k-mooneylyarwood: can you reveiw https://review.opendev.org/c/openstack/nova/+/622336/29/nova/api/openstack/compute/remote_consoles.py#183 and confirm if you expect that to have teh same effect as the issue we discussed downstream17:44
sean-k-mooneywe do not want the password to end up in the image data or in config_dirver/metadata api17:45
sean-k-mooneybut here it may end up in both correct17:45
melwittsean-k-mooney: hm, I'd have thought that should be stored encrypted, same as we do for admin password17:49
sean-k-mooneymelwitt: ya i mentioned that17:49
sean-k-mooneyalthough i dont think it can be17:50
sean-k-mooneythe admin password is not in the libvirt xml17:50
sean-k-mooneywe use the ssh public key to encypt it yes17:50
melwittyes17:50
sean-k-mooneyin this case we wont have the private key to decyprti it ot stick it in the libvirt xml17:50
melwittoh :\17:50
sean-k-mooneyso we can use the ssh public key here17:50
sean-k-mooneybut we coudl use soemthign else17:51
sean-k-mooneye.g. a keystore17:51
sean-k-mooneyor static encyption with a fixed key seeded with the ssk public key or somehtihng17:51
*** k_mouza has quit IRC17:52
melwittyeah.. I guess I'm slowly remembering this spec, and this aspect of it is "better than nothing" I guess (comparing with no novnc password at all)17:52
sean-k-mooneyis fixed key enabled by default17:52
sean-k-mooneybecause if it is using castalain with fixed key to store it would be better17:53
sean-k-mooneyas that would allowy you to plug in barbican to do it proably too17:53
sean-k-mooneythat said as long as we call this out17:53
sean-k-mooneyand ensure we dont make the password visable in ways we did not intend17:53
sean-k-mooneythen  i think its ok to improve it later17:53
melwittI dunno if it is enabled by default. I don't know how to tell17:53
sean-k-mooneythe nova keysotre cofnig? thats a thing i think17:54
prometheanfireany progress on updating mock (nova still holds back the 3.0.5 -> 4.0.3 update)?17:54
sean-k-mooneyprometheanfire: we were tryihng to stop using it entirly at one point17:54
melwittyeah there's a fixed_key conf option but it doesn't have a default value, so that means it's not enabled by default?17:54
melwittprometheanfire: I have a change to the one test that is failing that I need to upload17:55
prometheanfiresean-k-mooney: iirc it was given up on at some point (using the built in)17:55
prometheanfiremelwitt: kk, feel free to add me to the review (or ping me) :D17:56
sean-k-mooneyprometheanfire: i am not aware of a reason not tooo17:56
sean-k-mooneyprometheanfire: i suspect if it was it was just capasity17:56
melwittwill do prometheanfire17:56
*** ociuhandu has joined #openstack-nova17:56
sean-k-mooneymelwitt: ya not sure the https://docs.openstack.org/nova/latest/configuration/config.html#key-manager config is what i was thinking17:56
sean-k-mooneyi was hoptin we had a default fixed key version that was always there if you dont use a real one17:57
prometheanfiresean-k-mooney: well, using the built-in is always preferred17:57
melwittsean-k-mooney: oh I see17:58
sean-k-mooneyprometheanfire: yep we only used mock the lib for python 2 compatiablity17:58
sean-k-mooneymelwitt: anyway i dont think we  have a basic intree keymanager that implemnt the castalin api that we can just assume is a thing17:58
sean-k-mooneymelwitt: well we have https://github.com/openstack/nova/blob/master/nova/keymgr/conf_key_mgr.py17:59
lyarwoodsean-k-mooney: sorry was afk, instance.metadata != instance.system_metadata so I'm not sure if it's going to have any impact18:00
sean-k-mooneylyarwood: right but instace.metadata is the place we store metata we set with --property18:00
sean-k-mooneyand i though that was put in the the instace_system_metatadata table18:01
*** ociuhandu has quit IRC18:01
sean-k-mooneyalthough it could be in instance_extra18:01
lyarwoodsean-k-mooney: the system_metadata issue I was talking about downstream comes from https://github.com/openstack/nova/blob/fefd984fd1294f23677e3df4390e37c7664883a0/nova/utils.py18:01
melwittisn't instance.metadata public?18:01
sean-k-mooneymelwitt: yes18:01
sean-k-mooneywith a nova show18:01
sean-k-mooneyi think18:01
lyarwoodops that didnt link correctly18:01
melwittso the novnc password shouldn't be put in there, right?18:01
openstackgerritSylvain Bauza proposed openstack/nova master: Add requested_networks field to RequestSpec object  https://review.opendev.org/c/openstack/nova/+/74997718:01
openstackgerritSylvain Bauza proposed openstack/nova master: WIP: Add a routed networks scheduler pre-filter  https://review.opendev.org/c/openstack/nova/+/74906818:01
openstackgerritSylvain Bauza proposed openstack/nova master: Rename ensure_network_metadata to amend requested_networks  https://review.opendev.org/c/openstack/nova/+/77395518:01
openstackgerritSylvain Bauza proposed openstack/nova master: Add network and utils methods for getting routed networks and segments  https://review.opendev.org/c/openstack/nova/+/77397618:01
sean-k-mooneymelwitt: correct18:02
lyarwoodhttps://github.com/openstack/nova/blob/fefd984fd1294f23677e3df4390e37c7664883a0/nova/utils.py#L752-L778 was what I wanted to link to18:02
sean-k-mooneyif its there i belive it will be avaiable via the metadata service18:02
melwittif it goes in system_metadata I guess that's ok, IIUC18:02
sean-k-mooneyallowing anyone in the project ot get it18:02
melwittbut not metadata, that will be public to all in the project like you said18:02
*** derekh has quit IRC18:02
lyarwoodmelwitt: so the issue then is it would show up as an image metadata property18:02
sean-k-mooneyyep and the feature is ment to make it so only the user that created the instace can log in18:03
sean-k-mooneyvia vnc with the password they set18:03
melwittoh system_meta gets reflected out of metadata? oh, I didn't know that :\18:03
lyarwoodneither did I until a few hours ago18:03
sean-k-mooneyor i18:03
lyarwoodslightly weird behaviour tbh, I can't think why18:03
melwitthrm18:03
sean-k-mooneyi though it was only stuff with the image_ prefix or img_18:03
sean-k-mooneynot everything becase we store stuff for tpm there too18:04
melwittyeah I had thought system_meta was like internal system info that wasn't put out there18:04
melwittok so you're saying a subset of it is reflected out18:04
sean-k-mooneyno i thouhg only a subset shoudl be relected out via the image18:04
lyarwoodmy reading of https://github.com/openstack/nova/blob/fefd984fd1294f23677e3df4390e37c7664883a0/nova/utils.py#L752-L778 and what I've seen when stashing hw_machine_type in there is that it ends up being reflected in the image metadata properties18:05
sean-k-mooneybut lyarwood  seams to have found all of it might be in a specific case?18:05
melwittoh18:05
sean-k-mooneyso SM_IMAGE_PROP_PREFIX18:05
sean-k-mooneywas ment to be filtering to just the image ones right18:05
lyarwoodyou would assume so18:06
sean-k-mooneyso key = key[len(SM_IMAGE_PROP_PREFIX):]18:07
sean-k-mooneyis striping the key18:07
sean-k-mooneyi think that is the issue18:07
sean-k-mooneybecause you have img_hw_machine_type that matches hw_machine_type which you added18:08
lyarwoodso in my case I've not even set it in the image metadata18:08
lyarwoodI'm only updating it in system_metadata while n-cpu starts18:08
lyarwoodand spawns18:08
lyarwoodand it's still showing up as an image prop18:08
lyarwoodlet me write a func test to show this18:08
*** rpittau is now known as rpittau|afk18:08
sean-k-mooneycan you include your new key with a prfix too18:10
sean-k-mooneye.g. abi_hw_machine_type18:10
sean-k-mooneyi think adding an abi prefix or simialr would stopp it being included18:10
lyarwoodit wouldn't, that's just trimming off SM_IMAGE_PROP_PREFIX from any matching keys18:10
lyarwoodL771-774 will still include it18:11
sean-k-mooneyoh i see18:12
sean-k-mooneywe shoudl be looping over the known filed in the image metadata object18:12
lyarwoodbrb18:12
sean-k-mooneynot everything in the dict18:12
sean-k-mooneyso     for key, value in system_meta.items(): is wrong18:12
sean-k-mooneywell that woudl work but we need to check " if key not in imageMeta.fields(): continue18:13
sean-k-mooneyor similar18:13
*** dtantsur is now known as dtantsur|afk18:16
*** nightmare_unreal has quit IRC18:26
openstackgerritMerged openstack/placement master: policy: Suppress policy deprecation warnings  https://review.opendev.org/c/openstack/placement/+/77185218:36
openstackgerritMerged openstack/placement master: policy: Don't persist default rule changes in tests  https://review.opendev.org/c/openstack/placement/+/77250818:36
openstackgerritMerged openstack/placement master: Implement secure RBAC for resource providers  https://review.opendev.org/c/openstack/placement/+/76024018:38
openstackgerritMerged openstack/placement master: Implement secure RBAC for aggregates  https://review.opendev.org/c/openstack/placement/+/76023518:38
openstackgerritMerged openstack/placement master: Implement secure RBAC for allocations  https://review.opendev.org/c/openstack/placement/+/76023618:39
openstackgerritMerged openstack/placement master: Implement secure RBAC for allocation candidates  https://review.opendev.org/c/openstack/placement/+/76023718:44
openstackgerritMerged openstack/placement master: Implement secure RBAC for inventories  https://review.opendev.org/c/openstack/placement/+/76023818:48
openstackgerritMerged openstack/placement master: Implement secure RBAC for resource classes  https://review.opendev.org/c/openstack/placement/+/76023918:48
openstackgerritMerged openstack/placement master: Implement secure RBAC for traits  https://review.opendev.org/c/openstack/placement/+/76024118:49
openstackgerritMerged openstack/placement master: Implement secure RBAC for usage  https://review.opendev.org/c/openstack/placement/+/76024218:49
openstackgerritMerged openstack/placement master: policy: Remove the deprecated 'placement' rule  https://review.opendev.org/c/openstack/placement/+/77233318:50
*** k_mouza has joined #openstack-nova19:15
*** andrewbonney has quit IRC19:17
*** k_mouza has quit IRC19:19
*** k_mouza has joined #openstack-nova19:35
*** k_mouza has quit IRC19:40
*** rcernin has joined #openstack-nova19:49
openstackgerritMerged openstack/nova stable/ussuri: Use subqueryload() instead of joinedload() for (system_)metadata  https://review.opendev.org/c/openstack/nova/+/76181019:50
openstackgerritMerged openstack/nova stable/victoria: Prevent archiving of pci_devices records because of 'instance_uuid'  https://review.opendev.org/c/openstack/nova/+/75883719:56
*** ociuhandu has joined #openstack-nova20:04
*** rcernin has quit IRC20:20
*** rcernin has joined #openstack-nova20:20
melwittci passed on 3 patches of mine in a row20:23
* melwitt faints20:23
sean-k-mooneylol20:26
*** tesseract has quit IRC20:49
*** rcernin has quit IRC21:22
*** hamalq has joined #openstack-nova21:27
*** whoami-rajat__ has quit IRC21:34
*** ociuhandu has quit IRC21:36
*** k_mouza has joined #openstack-nova21:44
*** k_mouza has quit IRC21:48
*** xek has quit IRC22:03
*** rcernin has joined #openstack-nova22:05
*** rcernin has quit IRC22:06
*** rcernin has joined #openstack-nova22:07
*** openstackgerrit has quit IRC22:11
*** vishalmanchanda has quit IRC22:30
*** slaweq has quit IRC22:41
*** slaweq has joined #openstack-nova22:43
*** rcernin has quit IRC22:45
*** slaweq has quit IRC22:47
*** openstackgerrit has joined #openstack-nova22:52
openstackgerritmelanie witt proposed openstack/nova master: Refactor and rename test_tcp_rst_no_compute_rpcapi  https://review.opendev.org/c/openstack/nova/+/74135122:52
openstackgerritmelanie witt proposed openstack/nova master: Refactor and rename test_tcp_rst_no_compute_rpcapi  https://review.opendev.org/c/openstack/nova/+/74135122:54
openstackgerritMerged openstack/nova stable/train: Handle disabled CPU features to fix live migration failures  https://review.opendev.org/c/openstack/nova/+/75876322:58
*** spatel has quit IRC23:06
openstackgerritmelanie witt proposed openstack/nova master: Refactor and rename test_tcp_rst_no_compute_rpcapi  https://review.opendev.org/c/openstack/nova/+/74135123:18
melwittprometheanfire: this should hopefully work ^ you're already cc'd on the review but in case you miss the gerrit notification23:19
openstackgerritGhanshyam proposed openstack/placement master: DNM: testing direct l-c  https://review.opendev.org/c/openstack/placement/+/77381323:20
*** bbowen_ has quit IRC23:24
*** tosky has quit IRC23:54

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!