Monday, 2021-02-08

« Sunday, 2021-02-07 Index Tuesday, 2021-02-09 »
*** ociuhandu has joined #openstack-nova00:11
*** tosky has quit IRC00:15
*** ociuhandu has quit IRC00:17
openstackgerritMerged openstack/nova master: db: Compact Ocata database migrations  https://review.opendev.org/c/openstack/nova/+/75908600:32
*** ociuhandu has joined #openstack-nova00:55
*** ociuhandu has quit IRC01:00
*** ociuhandu has joined #openstack-nova01:26
*** ociuhandu has quit IRC01:30
*** zzzeek has quit IRC01:39
*** zzzeek has joined #openstack-nova01:41
swp20sean-k-mooney: hi, about the noVNC patch, i think the case in https://review.opendev.org/c/openstack/nova/+/622336/30/nova/tests/unit/api/openstack/compute/test_remote_consoles.py#375 covers what you said.01:47
*** dviroel has quit IRC02:36
*** martinkennelly has quit IRC02:48
*** martinkennelly has joined #openstack-nova02:48
*** martinkennelly has quit IRC02:50
*** rcernin has quit IRC02:52
*** rcernin has joined #openstack-nova02:54
*** ociuhandu has joined #openstack-nova03:11
*** ociuhandu has quit IRC03:15
*** sapd1 has joined #openstack-nova03:19
*** khomesh24 has joined #openstack-nova03:29
*** psachin has joined #openstack-nova03:29
*** mkrai has joined #openstack-nova03:32
openstackgerritMIKI Nobuhiro proposed openstack/nova master: libvirt: add IP address to libvirt guest metadata  https://review.opendev.org/c/openstack/nova/+/75055203:37
*** spatel has joined #openstack-nova03:52
*** vishalmanchanda has joined #openstack-nova03:59
*** mkrai has quit IRC04:33
*** mkrai_ has joined #openstack-nova04:33
*** zzzeek has quit IRC04:34
*** zzzeek has joined #openstack-nova04:37
*** ratailor has joined #openstack-nova04:59
*** ociuhandu has joined #openstack-nova04:59
*** ociuhandu has quit IRC05:04
*** spatel has quit IRC05:05
*** mkrai_ has quit IRC05:20
*** mkrai__ has joined #openstack-nova05:20
*** zzzeek has quit IRC05:33
*** zzzeek has joined #openstack-nova05:36
*** sapd1 has quit IRC05:41
*** zzzeek has quit IRC05:57
*** zzzeek has joined #openstack-nova05:59
*** khomesh24 has quit IRC06:03
*** whoami-rajat__ has joined #openstack-nova06:13
*** ociuhandu has joined #openstack-nova06:38
*** k_mouza has joined #openstack-nova06:40
*** ociuhandu has quit IRC06:42
*** k_mouza has quit IRC06:45
*** sapd1 has joined #openstack-nova06:53
*** mkrai__ has quit IRC07:11
*** nightmare_unreal has joined #openstack-nova07:17
*** sapd1 has quit IRC07:20
*** ralonsoh has joined #openstack-nova07:38
*** sapd1 has joined #openstack-nova07:55
*** slaweq_ has joined #openstack-nova07:59
*** mkrai has joined #openstack-nova08:00
*** zenkuro has joined #openstack-nova08:00
*** rpittau|afk is now known as rpittau08:00
*** rcernin has quit IRC08:12
*** tesseract has joined #openstack-nova08:15
*** slaweq_ is now known as slaweq08:23
*** hemanth_n has joined #openstack-nova08:24
*** ociuhandu has joined #openstack-nova08:26
*** ociuhandu has quit IRC08:31
*** khomesh24 has joined #openstack-nova08:32
*** xek has joined #openstack-nova08:39
*** rcernin has joined #openstack-nova08:43
*** tosky has joined #openstack-nova08:45
*** sapd1 has quit IRC08:49
*** rcernin has quit IRC08:49
*** lyarwood has joined #openstack-nova08:56
*** rcernin has joined #openstack-nova08:58
*** ociuhandu has joined #openstack-nova09:10
*** ociuhandu has quit IRC09:12
*** ociuhandu has joined #openstack-nova09:12
*** sapd1 has joined #openstack-nova09:12
*** zenkuro has quit IRC09:19
*** ociuhandu has quit IRC09:20
*** zenkuro has joined #openstack-nova09:20
* bauzas could be on and off this morning, changing his network backbone by using another switch09:25
*** bauzas has quit IRC09:35
*** bauzas has joined #openstack-nova09:36
gibilyarwood: Hi! What are the patches we need to merge before we can drop one of th grenade job as in https://review.opendev.org/c/openstack/tempest/+/771499 ?09:38
*** jangutter has joined #openstack-nova09:40
lyarwoodgibi: https://review.opendev.org/c/openstack/nova/+/742056 - I think you're confusing this with that moves the job over to zuulv309:41
lyarwoodgibi: I think we can drop the standalone job ahead of that09:41
lyarwoodgibi: but should still try to push the move to zuulv3 along this cycle09:41
*** jangutter_ has quit IRC09:43
*** derekh has joined #openstack-nova09:43
*** rcernin has quit IRC09:47
*** yankcrime has joined #openstack-nova09:50
gibilyarwood: do you mean that we could merge https://review.opendev.org/c/openstack/tempest/+/771499 now without any dependency?09:55
stephenfindansmith: I'm seeing multiple networks found quite often also. I've tried figuring out how to fix that but my Google-fu is failing me :-\09:56
gibistephenfin: I think ther is an open tempest patch for that ^^ let me find it09:56
lyarwoodyeah that should be listed on status.openstack.org iirc09:57
lyarwoodgibi: I believe so yes, the switch to zuulv3 is seperate AFAICT09:58
gibistephenfin: https://review.opendev.org/c/openstack/tempest/+/77016909:58
lyarwoodstephenfin: http://status.openstack.org/elastic-recheck/#184456809:59
gibilyarwood: cool, please not that on Dan's patch09:59
*** k_mouza has joined #openstack-nova09:59
lyarwoodgibi: hmm I see dansmith's note in the change, he might have reasons for waiting until we've completed the switch10:00
lyarwoodgibi: let me sync with him later today, I've likley missing some context on Friday while I was out10:00
gibilyarwood: cool thanks10:01
* lyarwood adds a note to the change10:02
gibigmann: Is there anything I can help with https://review.opendev.org/c/openstack/tempest/+/770169 ?10:05
*** kukacz has quit IRC10:10
openstackgerritJohannes Kulik proposed openstack/nova master: Faults from cell DB missing in GET /servers/detail  https://review.opendev.org/c/openstack/nova/+/69917610:15
*** kukacz has joined #openstack-nova10:18
kashyapgibi: This review you of CPU flags (which we'll discuss in the meeting this evening) has a couple of bugs, I'm fixing it as we speak10:28
kashyap[https://review.opendev.org/c/openstack/nova/+/774240]10:28
kashyapIt should use lstrip() instead of index slicing; and I'm using the wrong libvirt class in libvirt/driver.py.   /me goes to fiddle [after a call]10:29
gibikashyap: OK. which meeting this evening do you refer to ?10:29
kashyapgibi: Err, is there Nova meeting tonight, or am I dreaming?10:30
gibinova meetings are every thursday10:30
kashyapErr, right; thx10:30
*** martinkennelly has joined #openstack-nova10:35
*** martinkennelly has quit IRC10:38
*** martinkennelly has joined #openstack-nova10:38
*** ratailor has quit IRC10:41
*** ratailor has joined #openstack-nova10:41
*** jangutter_ has joined #openstack-nova10:45
*** dtantsur|afk is now known as dtantsur10:48
*** jangutter has quit IRC10:48
*** bauzas has quit IRC10:58
*** k_mouza has quit IRC11:00
*** bauzas has joined #openstack-nova11:01
*** k_mouza has joined #openstack-nova11:06
*** dviroel has joined #openstack-nova11:17
*** sapd1 has quit IRC11:23
*** nightmare_unreal has quit IRC11:36
*** tbachman has quit IRC11:38
*** martinkennelly has quit IRC11:43
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Allow disabling CPU flags via `cpu_model_extra_flags`  https://review.opendev.org/c/openstack/nova/+/77424011:46
*** Luzi has joined #openstack-nova11:55
*** mkrai has quit IRC12:06
gibibauzas: left feedback on your the routed net series12:10
*** xek_ has joined #openstack-nova12:16
*** xek_ has quit IRC12:17
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Allow disabling CPU flags via `cpu_model_extra_flags`  https://review.opendev.org/c/openstack/nova/+/77424012:18
*** xek has quit IRC12:18
kashyapgibi: Hey, --^ fixed the problems in the above; and it works as intended12:20
kashyapNote to self: missing doc update; and a rel note12:25
gibikashyap: ack, will check back12:29
*** hemanth_n has quit IRC12:38
*** sapd1 has joined #openstack-nova12:40
*** xek has joined #openstack-nova12:45
bauzasgibi: ack, will look12:46
*** zenkuro has quit IRC12:48
*** mrch_ has joined #openstack-nova12:48
*** zenkuro has joined #openstack-nova12:49
*** zenkuro has quit IRC12:58
*** zenkuro has joined #openstack-nova12:58
*** mgariepy has quit IRC13:00
*** sapd1 has quit IRC13:00
*** dtantsur is now known as dtantsur|brb13:01
*** sapd1 has joined #openstack-nova13:23
*** mgariepy has joined #openstack-nova13:26
sean-k-mooneylyarwood: by the way you can proably drop the WIP on you machine_type patch in the next revision13:26
*** gouthamr has quit IRC13:26
*** CeeMac has quit IRC13:27
*** whoami-rajat__ has quit IRC13:27
*** guilhermesp has quit IRC13:27
*** dviroel has quit IRC13:27
*** csatari has quit IRC13:27
*** pas-ha_ has quit IRC13:27
*** flaviof has quit IRC13:27
*** johnsom has quit IRC13:27
*** jrosser has quit IRC13:27
*** cz3 has quit IRC13:27
*** gmann has quit IRC13:27
*** knikolla has quit IRC13:27
*** coreycb has quit IRC13:27
*** vishalmanchanda has quit IRC13:27
*** zul has quit IRC13:27
*** nicolasbock has quit IRC13:27
*** mnaser has quit IRC13:27
*** masayukig has quit IRC13:27
*** fyx has quit IRC13:27
sean-k-mooneyill try an review it when its up but feel free to ping me if i dont13:27
*** PrinzElvis has quit IRC13:27
lyarwoodsean-k-mooney: yup planning to, just sorting some tests out and writing docs13:28
*** CeeMac has joined #openstack-nova13:28
*** guilhermesp has joined #openstack-nova13:28
*** johnsom has joined #openstack-nova13:28
*** mnaser has joined #openstack-nova13:28
*** coreycb has joined #openstack-nova13:28
*** masayukig has joined #openstack-nova13:28
lyarwoodsean-k-mooney: thanks again for the review btw13:28
*** cz3 has joined #openstack-nova13:29
gibikashyap: I've left feedback in https://review.opendev.org/c/openstack/nova/+/77424013:29
*** flaviof has joined #openstack-nova13:29
kashyapgibi: Thanks; will look13:29
*** csatari has joined #openstack-nova13:29
*** gouthamr has joined #openstack-nova13:29
*** vishalmanchanda has joined #openstack-nova13:30
*** eharney has joined #openstack-nova13:30
*** nicolasbock has joined #openstack-nova13:30
*** zenkuro has quit IRC13:30
*** alex_xu has quit IRC13:30
*** whoami-rajat__ has joined #openstack-nova13:31
*** gmann has joined #openstack-nova13:31
*** fyx has joined #openstack-nova13:31
*** TheJulia has quit IRC13:32
*** dviroel has joined #openstack-nova13:32
*** knikolla has joined #openstack-nova13:33
*** zul has joined #openstack-nova13:33
*** jrosser has joined #openstack-nova13:34
*** artom has joined #openstack-nova13:38
bauzasgibi: shit about the 2 NICs...13:38
bauzas:(13:38
*** rcernin has joined #openstack-nova13:38
bauzasgibi: unfortunately, we need to express ONE Requestspec for both13:39
bauzascontext : https://review.opendev.org/c/openstack/nova/+/749068/12/nova/scheduler/request_filter.py13:39
* bauzas will take a coffee and will discuss about this in 5/10 mins13:39
bauzasbut we need to express aggregates requirement something like "(agg1 or agg2) AND agg3" in the same spec13:40
bauzasso, like you said, by calling require_aggs() multiple ways13:41
*** nweinber has joined #openstack-nova13:42
*** TheJulia has joined #openstack-nova13:44
gibibauzas: I think we have ONE request spec but we have a list of network requests13:46
gibiand the input in the network request list13:47
gibiand the output is in the Destination13:47
gibimaybe we just need to move the require_aggregate into the for loop13:48
gibiinstead of having it after the for loop13:48
*** PrinzElvis has joined #openstack-nova13:51
*** Luzi has quit IRC13:52
*** rcernin has quit IRC13:53
*** spatel has joined #openstack-nova13:54
*** ratailor has quit IRC13:57
sean-k-mooneystephenfin: by the way just notice the cell db still has plamcnet related tables in it13:58
sean-k-mooneywe dont support that any more right13:59
sean-k-mooneyis that something we should clean up in or after your current db series ?13:59
sean-k-mooneyim thinking a nova manage command to drop them from the cell db and remove them form the compacted schema ?14:00
bauzasgibi: indeed, I'll add a func test and verifying it14:03
gibicoolio14:03
bauzashttps://www.youtube.com/watch?v=fPO76Jlnz6c14:06
kashyapgibi: Heya, so here: https://review.opendev.org/c/openstack/nova/+/774240/3/nova/virt/libvirt/driver.py#460814:07
* gibi clicks14:08
kashyapgibi: I'm testing both the enabling and disabling part in the test.  Would you like me to test something further?14:08
gibiI think the codeblock starging at L698 is not covered while the code blocks starting at L4599 is covered14:09
kashyapgibi: Oh, the one in this method _check_cpu_compatibility()14:10
kashyapgibi: Okay, will figure something out ...14:10
kashyapgibi: I'll respond to the rest on the change; thanks14:10
gibiyes14:10
gibithanks14:10
kashyapgibi: Good catch14:11
*** tbachman has joined #openstack-nova14:21
stephenfinsean-k-mooney: Yeah, I have a patch somewhere to clean those up14:23
stephenfinBut I think it can/should wait til alembic is in place14:23
*** dtantsur|brb is now known as dtantsur14:28
bauzasgibi: 2 secs for a quick question ?14:34
gibibauzas: sure14:35
bauzasgibi: in your example https://review.opendev.org/c/openstack/nova/+/749068/12/nova/scheduler/request_filter.py#32914:35
bauzasgibi: you mention 'agg1 or agg2 AND agg3'14:35
bauzas(the and is priority over the or)14:35
bauzasso, we would get NoValidHosts for your example, right?14:35
gibiif there is no host that is in both agg2 and agg3 or agg1 and agg3 then yes it is a no valid host14:36
gibibut a host can be in multiple aggregated14:36
gibi-d14:36
bauzasok, b/c my functest only has one host per agg14:36
bauzasbut I can try to do something14:37
bauzaslike, adding host5 that's in both aggregates14:37
bauzaslemme try about it14:37
gibiok14:38
*** xek_ has joined #openstack-nova14:47
*** xek has quit IRC14:49
sean-k-mooneystephenfin: sorry was on a call that sounds fine by me14:54
sean-k-mooneystephenfin: i was just inspecting some data in the db for one of my changes and found it odd that those tabels were still there14:55
bauzasI'm absolutely puzzled15:00
bauzaslooks like our HostNameWeigherFixture doesn't work15:00
*** zenkuro has joined #openstack-nova15:01
gibibauzas: that is only handles host1,2,3 in the baseline15:01
bauzasgibi: http://paste.openstack.org/show/802441/15:01
bauzasgibi: aaaaaaah15:01
bauzasso we need to fix this :p15:02
gibiyou can pass in weights to the fixture15:02
bauzasi was thinking the weigher was smarter :)15:02
bauzaswill lookup15:02
bauzastbh, I haven't looked at the fixture yet15:02
bauzasRTFM15:02
gibiit is a good enough fixture :)15:03
bauzasor rather, RTFM15:03
bauzas(read the f*** module)15:03
bauzasok, I see the init call15:03
bauzaswe can pass the weights15:04
bauzasall good, thanks for the quick resolution15:04
gibihappy to help15:04
*** spatel has quit IRC15:08
gmannsean-k-mooney: openstack-tempest-skiplist  is under/from tripleO project. not new i think15:10
gmannstephenfin: yeah, most of functional tests also run with permission to all (""). we might need more work there too15:11
gmanngibi: ah, I missed that. will work on this today15:11
gibigmann: thanks15:11
sean-k-mooneygmann: yep its not. i was just worreid if this was being used sytemwide for all tempest jobs15:14
sean-k-mooneygmann:that would be bad since its disiableing things based on wether its supported or not by ooo but since its only used by ooo its fine15:15
gmannsean-k-mooney: no, I think that may be used in tripleO jobs only15:15
sean-k-mooneyi just would have expected to see ooo/tripleo in the repo name15:15
gmannyeah that is confusing even last month release team also had same confusion and nobody know if it is Tempest repo or something else15:16
gmannand skip list could be maintained in file itself, I do not think separate repo is needed15:16
sean-k-mooneygmann: ya i think they were not thinking baout zuul job inheritance wehn they created it but if it works for them i guess its ok15:17
sean-k-mooneyi just wanted to make sure a patch to that would not skip something in a nova job which it wont so all good15:18
*** khomesh24 has quit IRC15:18
*** tbarron is now known as tbarron|out15:22
*** k_mouza has quit IRC15:25
*** k_mouza has joined #openstack-nova15:26
*** dklyle has joined #openstack-nova15:35
*** vishalmanchanda has quit IRC15:45
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Record the machine_type of instances in system_metadata  https://review.opendev.org/c/openstack/nova/+/76753315:56
openstackgerritLee Yarwood proposed openstack/nova master: nova-manage: Add commands for managing instance machine type  https://review.opendev.org/c/openstack/nova/+/76954815:57
openstackgerritLee Yarwood proposed openstack/nova master: WIP nova-status: Add hw_machine_type check for libvirt instances  https://review.opendev.org/c/openstack/nova/+/77064315:57
*** zenkuro has quit IRC15:57
*** zenkuro has joined #openstack-nova15:57
*** macz_ has joined #openstack-nova16:01
*** k_mouza_ has joined #openstack-nova16:01
*** macz_ has quit IRC16:03
*** nweinber_ has joined #openstack-nova16:03
*** macz_ has joined #openstack-nova16:04
*** nweinber has quit IRC16:04
*** k_mouza has quit IRC16:05
*** k_mouza_ has quit IRC16:08
*** k_mouza has joined #openstack-nova16:08
*** _mlavalle_1 has quit IRC16:15
*** nweinber_ has quit IRC16:23
*** mlavalle has joined #openstack-nova16:27
*** nweinber_ has joined #openstack-nova16:31
dansmithstephenfin: ack on the networks thing, I've seen that one too16:33
openstackgerritSylvain Bauza proposed openstack/nova master: Add net and utils methods for getting routed netks and segments  https://review.opendev.org/c/openstack/nova/+/77397616:38
openstackgerritSylvain Bauza proposed openstack/nova master: Add a routed networks scheduler pre-filter  https://review.opendev.org/c/openstack/nova/+/74906816:38
bauzasgibi: updated, thanks for your comments ^16:38
bauzasadded both functest and UT for verifying it16:39
gibibauzas: on it16:41
*** zenkuro has quit IRC16:46
*** zenkuro has joined #openstack-nova16:47
*** zenkuro has quit IRC16:51
*** zenkuro has joined #openstack-nova16:51
lyarwoodmelwitt: https://review.opendev.org/c/openstack/nova/+/766976 - before I forget, would you mind hitting this today? You reviewed the bugfix on top of it but missed the regression test on Friday.16:52
*** k_mouza has quit IRC16:52
*** k_mouza has joined #openstack-nova16:53
*** spatel has joined #openstack-nova17:00
*** psachin has quit IRC17:03
openstackgerritBalazs Gibizer proposed openstack/nova master: libvirt: Define and emit DeviceRemovedEvent and DeviceRemovalFailedEvent  https://review.opendev.org/c/openstack/nova/+/74992917:04
gibistephenfin: fixed your comment in ^^17:04
*** rpittau is now known as rpittau|afk17:05
openstackgerritBalazs Gibizer proposed openstack/nova master: libvirt: add AsyncDeviceDetachEventsHandler  https://review.opendev.org/c/openstack/nova/+/77238117:06
openstackgerritBalazs Gibizer proposed openstack/nova master: libvirt: allow querying devices from the persistent domain  https://review.opendev.org/c/openstack/nova/+/77238317:06
openstackgerritBalazs Gibizer proposed openstack/nova master: libvirt: parse alias out from device config  https://review.opendev.org/c/openstack/nova/+/77238417:09
openstackgerritBalazs Gibizer proposed openstack/nova master: Replace blind retry with libvirt event waiting in detach  https://review.opendev.org/c/openstack/nova/+/77024617:10
*** artom has quit IRC17:14
gibibauzas: I'm +2 on the routed net series, good job!17:16
bauzasthanks17:16
gibisean-k-mooney: I would appreciate your view on the question in https://review.opendev.org/c/openstack/nova/+/749068/12/nova/scheduler/request_filter.py#31217:17
bauzasgibi: then hopefully I'll switch soon on the compute RPC API version bump now that dansmith is back :)17:17
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Allow disabling CPU flags via `cpu_model_extra_flags`  https://review.opendev.org/c/openstack/nova/+/77424017:17
gibibauzas: awesome :0\17:17
gibi:)17:17
bauzasI was mostly done with it, but faced problems17:17
bauzasnow it will require some rebase, as I think we had a new minor bump due to cyborg shelve/unshelve17:18
gibiyepp17:18
bauzasbut honestly, the test failure puzzles me17:19
*** macz_ has quit IRC17:20
gibidansmith: hi! as per http://lists.openstack.org/pipermail/openstack-discuss/2021-February/020186.html could you help me adding the nova-stable-maint group to the placement-stable-maint group in gerrit. I'm not in the latter so I cannot do the change17:22
bauzasgibi: I can do it17:22
gibibauzas: no you can't17:22
gibiyou are not in the placement-stable-maint as far as I see17:22
gibihttps://review.opendev.org/admin/groups/7b73c52bbb180a693bac4f2fcca01a6dab9c1222,members17:23
bauzasah shit indeed, the other way :)17:23
*** macz_ has joined #openstack-nova17:23
bauzasand not a stable-maint-core :)17:23
gibi:)17:23
*** macz_ has quit IRC17:27
sean-k-mooneygibi: as far as i know its invalid for a port with multiple fixed_ip from different segments to be created17:34
sean-k-mooneygibi: there may be one excption17:34
sean-k-mooneyhaving ips on differnet segment implies that port is on multiple differnt l2 broadcast domain concurrently17:35
sean-k-mooneywhich is not physically possible17:35
sean-k-mooneythe caveate which i think we should declare out of scope would be a situration where you are using routed network with trunk portrs17:35
sean-k-mooneyin principal each subport could be on a different physical network and the the parent port could therefor hoave fixed ips form different segments i think17:36
sean-k-mooneygibi: we might be able to support that at some point but for now i think we would be better off documenting that as a limition in this release17:37
sean-k-mooneyan enable that if someone asks for it in the future17:37
sean-k-mooneygibi: i think multiple fixed ips is fine just they should have the same sgement17:38
*** ralonsoh has quit IRC17:38
sean-k-mooneythey could have different subnets e.g. if you ran out of ips and wantted to add more to a segment via a second subnet17:38
sean-k-mooneybut 1 segment and 1 l2 broadcast domain i hope that makes sense?17:38
sean-k-mooneyill review bauzas  patch in either case17:39
sean-k-mooneytrunk ports being https://specs.openstack.org/openstack/neutron-specs/specs/newton/vlan-aware-vms.html17:40
*** k_mouza_ has joined #openstack-nova17:42
*** k_mouza_ has quit IRC17:42
*** mgariepy has quit IRC17:44
*** k_mouza has quit IRC17:44
*** macz_ has joined #openstack-nova17:45
*** macz_ has quit IRC17:50
*** gyee has joined #openstack-nova17:50
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Allow disabling CPU flags via `cpu_model_extra_flags`  https://review.opendev.org/c/openstack/nova/+/77424017:51
kashyapgibi (and others): For tomm --^ :)17:51
*** macz_ has joined #openstack-nova17:51
kashyapgibi: You must be drowning in review requests.  Sorry for the deluge17:51
*** gyee has quit IRC17:52
*** gyee has joined #openstack-nova17:52
*** macz_ has quit IRC18:00
*** macz_ has joined #openstack-nova18:01
*** derekh has quit IRC18:02
sean-k-mooneyhttps://review.opendev.org/c/openstack/nova/+/749068/12/nova/scheduler/request_filter.py#312 commented inline18:04
dansmithgibi: sorry was on a call, looking now18:04
openstackgerritStephen Finucane proposed openstack/nova master: mypy: Add type annotations to 'nova.pci'  https://review.opendev.org/c/openstack/nova/+/67620918:05
openstackgerritStephen Finucane proposed openstack/nova master: mypy: Add nova.cmd, nova.conf, nova.console  https://review.opendev.org/c/openstack/nova/+/70565718:05
openstackgerritStephen Finucane proposed openstack/nova master: mypy: Add type annotations to top-level modules  https://review.opendev.org/c/openstack/nova/+/70565818:05
openstackgerritStephen Finucane proposed openstack/nova master: trivial: Clean manager.Manager, service.Service signatures  https://review.opendev.org/c/openstack/nova/+/76480618:05
dansmithgibi: how's that?18:06
*** bnemec has quit IRC18:08
*** bnemec has joined #openstack-nova18:10
*** artom has joined #openstack-nova18:11
*** xek_ has quit IRC18:15
*** macz_ has quit IRC18:17
*** macz_ has joined #openstack-nova18:17
*** nweinber_ has quit IRC18:18
*** nweinber has joined #openstack-nova18:18
*** tesseract has quit IRC18:19
*** mrch_ has quit IRC18:20
*** mrch has joined #openstack-nova18:20
gansoHi Nova folks! Does this look like a legit bug to you? I'm thinking of ways to fix it, either change "openstack usage show" to use created_at instead of launched_at (negative side effects are created instances that were launched) or stop updating the launched at field on resize and unshelved. Thinking about it, a cold migration or a stop/start operation does not update the launched field, why should a resize do? https://bugs.launchpad.net/nova/+bug/118:20
openstackLaunchpad bug 1 in Ubuntu Malaysia LoCo Team "Microsoft has a majority market share" [Critical,In progress] - Assigned to MFauzilkamil Zainuddin (apogee)18:20
ganso91505518:20
gansolol it cropped at the bug ID18:20
gansohttps://bugs.launchpad.net/nova/+bug/191505518:20
openstackLaunchpad bug 1915055 in OpenStack Compute (nova) "launched_at's reset when resizing/reverting and unshelving impacts "openstack usage show"" [Undecided,New]18:20
*** macz_ has quit IRC18:21
*** xek has joined #openstack-nova18:22
*** xek has quit IRC18:23
*** mrch has quit IRC18:28
*** macz_ has joined #openstack-nova18:28
sean-k-mooneyganso: we had a bug similar to this not so long ago which we rejected18:32
gansosean-k-mooney: hmmm my search didn't come up with anything. Do you remember why it was rejected?18:33
sean-k-mooneyganso: we decieded not to change the existing behavior18:33
sean-k-mooneybascilly becasue we dont really feel this type of api should be provided by nova and analtics of this type would be better done externally18:34
sean-k-mooneyby consuming the instance life cycle events18:34
sean-k-mooneyit came up in the nova meeting a few weeks ago18:34
sean-k-mooneyhttp://eavesdrop.openstack.org/meetings/nova/2020/nova.2020-12-03-16.00.log.txt18:37
sean-k-mooneyhttps://review.opendev.org/c/openstack/nova/+/71111318:37
gansosean-k-mooney: shouldn't this API be deprecated? From what you said it sounds like you'd like to disencourage its usage18:37
sean-k-mooneyganso: well we already do discuage usage :) but its not deprecated18:38
sean-k-mooneywe resovled to instead update the docs to call out its expected usage i think18:38
sean-k-mooneyganso: this api has a pretty heavy perfomance impact too in comparision to outer apis so it does not scale well18:40
*** macz_ has quit IRC18:40
*** macz_ has joined #openstack-nova18:41
gansosean-k-mooney: thanks for the info, I will close the bug as invalid!18:41
sean-k-mooneyganso: can you like to the previous meeting and that patch that was abandoned for context18:42
gansosean-k-mooney: yes, I will include those links18:42
sean-k-mooneyganso: out of interest what was your usecase for this18:42
gansosean-k-mooney: it was fixing this bug: https://bugs.launchpad.net/nova/+bug/191364118:42
openstackLaunchpad bug 1913641 in OpenStack Compute (nova) "Incorrect Shelved_offloaded instance metrics on openstack usage show output" [Undecided,In progress] - Assigned to Rodrigo Barbieri (rodrigo-barbieri2010)18:42
gansosee the last comment ^18:42
gansoI implemented the fix, but then I found that other issue18:42
sean-k-mooneyah ok well that is likely invalid too18:43
gansoyes. I will close that one too, because it is pointless fixing that without fixing the launched_at being reset18:43
*** mgariepy has joined #openstack-nova18:43
sean-k-mooneyya so i would clouse one of those two bugs as a duplicate of the other then close the scond with refrences to the meeting as wontfix or invalid18:45
sean-k-mooneyganso: melwitt also commened on comment one that it was intended behavior too.18:45
sean-k-mooneyalthough that was more on the difference between counting quota with placement or not18:46
gansosean-k-mooney: my understading from her comment was that it was intentional in the past, but now with that new count_quota_from_placement that it could change, so I moved forward with a fix18:47
sean-k-mooneynot the intent is eventually to remove the current api and only count quota and usage via placment18:48
sean-k-mooneythat is part of teh unified limits work18:48
sean-k-mooneyganso: placment has its own usage api https://docs.openstack.org/api-ref/placement/?expanded=list-usages-detail#usages18:48
sean-k-mooneythat wont give you historic usage over a time interval but it will tell you the current usage of a project18:49
gansosean-k-mooney: thanks!18:51
*** artom has quit IRC18:56
*** spatel has quit IRC18:58
gansosean-k-mooney: I added the comment, but I lack the powers to mark both as "won't fix". I don't see them as duplicates, neither invalid ones. I do think they are legit, but considering the usage API is discouraged, they will not be fixed. Could you please mark both as "won't fix" ?19:07
sean-k-mooneyam sure. you need to be in the nova bug group. its an open team in launchpad so anyone can join but ill update them now19:08
gansooh cool, anyone can join. Will join them now19:08
sean-k-mooneyganso: done if you want to join just join here https://launchpad.net/~nova-bugs19:10
gansosean-k-mooney: just did =)19:10
sean-k-mooneycool i think you need to renew it every 1-2 years but its simple to do19:10
*** spatel has joined #openstack-nova19:15
melwittganso, sean-k-mooney: fwiw ganso's interpretation of my comment is correct, I think it could be debated whether usage should count shelved offloaded instances (same way it could be debated whether quota should count it). that said, I could see it making sense to keep both behaviors consistent (as long as default quota behavior counts shelved offloaded, so does usage). if/when default quota behavior turns to placement counting, usage19:36
melwitt removes counting of shelved offloaded19:36
sean-k-mooneymelwitt: where you in the team meeting when https://review.opendev.org/c/openstack/nova/+/711113 was discuessed19:38
sean-k-mooneythat attempted to cahnge the meaning of the usage api to only cound it when the vm was active and running19:39
melwittno, I missed that19:39
melwittah ok19:39
sean-k-mooneywe decieded not to basically because we did not want to change its current meaning19:39
sean-k-mooneyit could be done but we did not really want too do it as a bug fix19:40
sean-k-mooneyits really an api change and im not sure how open we are to adding more uses of or enhanceing the simple tenant usage api19:40
melwittthanks for that link, that helps19:40
sean-k-mooneypersonally i would be in favor of eventually removing it19:40
melwittI see, was just reading through the irc discussion linked on the abandoned patch19:41
sean-k-mooneywe could revisit this dicussion19:41
sean-k-mooneyif you think there is merit in it19:41
sean-k-mooneybut it feels to me that this should be a spec if we were to change the api behavior19:42
sean-k-mooneywith a new microverion to request the new behaivor19:42
melwitteh.. I don't feel that strongly about it. I hadn't considered the broader view that the simple tenant usage api is obsolete19:43
*** k_mouza has joined #openstack-nova19:44
sean-k-mooneymelwitt: do you know what the status of unified limits is by the way?19:44
melwittI'd be ok with tweaking it to make more sense but I'm also ok if most people think it should be left alone as obsolete19:44
*** hoonetorg has quit IRC19:45
melwittsean-k-mooney: no, I have seen johnthetubaguy around occasionally but haven't seen any activity on unified limits19:45
gansomelwitt, sean-k-mooney: AFAIK it is widely used, despite its falws. If there is no intention in enhancing it further or addressing it flaws, IMO the best way is to deprecate it is usage. Surely other sources of info are better for billing, but a lot of cloud admins use it anyways for billing because it is there and it is convenient19:46
*** rcernin has joined #openstack-nova19:47
*** k_mouza has quit IRC19:48
melwittyeah, that's been my understanding as well. another layer about it is that horizon uses it19:51
*** rcernin has quit IRC19:51
*** whoami-rajat__ has quit IRC19:53
*** macz_ has quit IRC19:59
*** macz_ has joined #openstack-nova19:59
sean-k-mooneyganso: i belive cloudkitty was ment for billing19:59
sean-k-mooneymelwitt: it does but they are the ones that told us the performacne sucked20:00
sean-k-mooneythey use it for the tenant overview page20:00
*** macz_ has quit IRC20:01
sean-k-mooneyganso: https://github.com/openstack/cloudkitty20:01
sean-k-mooneyCloudKitty aims at filling the gap between metrics collection systems like ceilometer and a billing system.20:01
melwittyeah... the performance is tied to the number of deleted instances (it uses those to do the usage over time)20:01
sean-k-mooneymelwitt: yep have you seen the performace of that page on PSI downstream20:01
melwittyes20:01
sean-k-mooneyits not pretty20:02
melwittthat's why I told them they really need to have their archive cron dialed in20:02
sean-k-mooneywell yes that is one reason for that20:02
melwittyes, one of many20:02
sean-k-mooneydid you see the os-archive topic on the mailing list20:02
sean-k-mooneyhttps://github.com/ovh/osarchiver20:03
*** macz_ has joined #openstack-nova20:03
melwittah, yeah20:03
sean-k-mooneyassuimg that becomes an offila project we shoudl perhaps exploer if that would be a better approch20:04
sean-k-mooneye.g. move all archiving external to the services20:04
sean-k-mooneythey apparently dont use shadow tabels at all and that operats on a retention policy archiving/deleteing deleted instance after a period of time20:05
*** macz_ has quit IRC20:05
melwittre: usage, I think that one is a challenge for operators because if you don't use the "easy" way of nova's tenant usage which just uses soft deleted instances, you need something else to store the info on instances from the past, which means another service as you said. so simple tenant usage appeals in that way20:05
sean-k-mooneyya the placment verion is point in time not a historic view20:05
sean-k-mooneythat said im still not conviece this should be an api provide by nova or placment20:06
sean-k-mooneyits nice to have20:07
melwittI wonder if horizon would be ok to have the tenant overview be point in time only20:07
sean-k-mooneyif they are then plamcent solves that usecase20:07
melwittright20:07
sean-k-mooneythat is more or less the only think i used that for20:07
sean-k-mooneymelwitt: placement does not have soft delete or shaddow tabels for alocations right20:08
melwittright20:08
sean-k-mooneythat proably the right choice20:08
sean-k-mooneybut also means we cant look at deleted allcoations20:08
*** xarlos has quit IRC20:08
melwittyeah20:09
sean-k-mooneyat the end of the day i think a small service that subsribes to the instance events versioned notifications20:09
sean-k-mooneyand maintains the usage externally is proably the way to go20:10
sean-k-mooneybut ya extra service20:10
melwittyeah, I agree. I assume that's what cloudkitty did/does20:10
*** macz_ has joined #openstack-nova20:11
*** artom has joined #openstack-nova20:11
sean-k-mooneymelwitt: im not sure if it pulled form celomiter or not20:11
sean-k-mooneyit has a data colector20:11
sean-k-mooneyhttps://github.com/openstack/cloudkitty/tree/master/cloudkitty/collector20:12
sean-k-mooneyso it pulls form gnocchi monasca or prometheus20:12
*** macz_ has quit IRC20:13
*** macz_ has joined #openstack-nova20:14
*** macz_ has quit IRC20:18
*** dtantsur is now known as dtantsur|afk20:20
*** macz_ has joined #openstack-nova20:20
*** xarlos has joined #openstack-nova20:45
*** macz_ has quit IRC20:46
*** macz_ has joined #openstack-nova20:47
*** tbachman has quit IRC20:51
*** macz_ has quit IRC20:52
*** k_mouza has joined #openstack-nova20:59
*** k_mouza has quit IRC21:04
*** tbachman has joined #openstack-nova21:28
*** pmannidi has joined #openstack-nova21:37
openstackgerritMerged openstack/nova master: Add regression test for bug #1908075  https://review.opendev.org/c/openstack/nova/+/76697621:39
openstackbug 1908075 in OpenStack Compute (nova) "Nova allows a non-multiattach volume to be attached to multiple instances *if* its volume state is reset by an admin" [Low,In progress] https://launchpad.net/bugs/1908075 - Assigned to Lee Yarwood (lyarwood)21:39
*** nweinber has quit IRC21:45
*** spatel has quit IRC21:55
*** pmannidi has quit IRC21:56
*** pmannidi has joined #openstack-nova21:57
*** ociuhandu has joined #openstack-nova22:16
*** ociuhandu has quit IRC22:18
*** rcernin has joined #openstack-nova22:24
*** rcernin has quit IRC22:30
*** rcernin has joined #openstack-nova22:30
*** tbachman has quit IRC22:31
*** slaweq has quit IRC22:38
*** zenkuro has quit IRC22:41
openstackgerritMerged openstack/nova master: api: Reject volume attach requests when an active bdm exists  https://review.opendev.org/c/openstack/nova/+/76847222:45
openstackgerritMerged openstack/nova master: fup: Merge duplicate volume attachment checks  https://review.opendev.org/c/openstack/nova/+/77338022:45
*** tbachman has joined #openstack-nova22:49
openstackgerritGhanshyam proposed openstack/nova master: DNM: testing Tempest without 'member' role  https://review.opendev.org/c/openstack/nova/+/77455922:49
*** macz_ has joined #openstack-nova22:56
*** macz_ has quit IRC22:57
*** macz_ has joined #openstack-nova22:58
*** macz_ has quit IRC22:58
*** pmannidi is now known as pmannidi|Away22:59
*** macz_ has joined #openstack-nova22:59
*** macz_ has quit IRC23:00
*** macz_ has joined #openstack-nova23:00
*** macz_ has quit IRC23:02
*** pmannidi|Away has quit IRC23:03
*** CeeMac has quit IRC23:03
*** macz_ has joined #openstack-nova23:04
*** CeeMac has joined #openstack-nova23:04
*** pmannidi has joined #openstack-nova23:06
*** macz_ has quit IRC23:09
*** ebbex has quit IRC23:14
*** ebbex has joined #openstack-nova23:36
« Sunday, 2021-02-07 Index Tuesday, 2021-02-09 »

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!