| melwitt | sounds like good times all around | 00:00 |
|---|---|---|
| sean-k-mooney | neutron list all exteions that are avaiabel not just the ones that are enabled which is __tottaly__ inutitive and not confusing at all.... | 00:00 |
| sean-k-mooney | im not sure what the best way to express sarcasium is on irc | 00:01 |
| *** zzzeek has quit IRC | 00:01 | |
| melwitt | yeah.. whenever I wander into other projects code where they still have extensions, it confuses me | 00:01 |
| melwitt | that was clear sarcasm :) some people use /s though | 00:02 |
| sean-k-mooney | i was originally affrait i forgot a mircoversion and it silent droped it or something | 00:02 |
| *** zzzeek has joined #openstack-nova | 00:02 | |
| sean-k-mooney | *affraid | 00:02 |
| sean-k-mooney | ok ill fix that try it again and if it doesnt work its tomrrows problem | 00:02 |
| melwitt | sounds like a plan | 00:03 |
| sean-k-mooney | although its technially now 00:03 here so i guess todays problem | 00:03 |
| melwitt | 🤞😬🤞 | 00:06 |
| sean-k-mooney | hum ok | 00:15 |
| sean-k-mooney | so that didnt work | 00:15 |
| melwitt | :( | 00:15 |
| sean-k-mooney | and its not in the pci request in either the api db or instance_extra table | 00:15 |
| sean-k-mooney | but both of those are not the same either | 00:15 |
| sean-k-mooney | the instance_extra table version has "alias_name": null, "is_new": false, "numa_policy": null, | 00:16 |
| sean-k-mooney | which are not in the request spec version at all | 00:16 |
| sean-k-mooney | so i think this is not geting saved back into the request spec | 00:17 |
| *** tosky has quit IRC | 00:17 | |
| sean-k-mooney | and then on the compute node i guess we load it form the db which save the default for numa_policy back | 00:17 |
| sean-k-mooney | and well the other fields | 00:17 |
| sean-k-mooney | although no | 00:19 |
| sean-k-mooney | if we loaded it from the db teh default would be different | 00:19 |
| sean-k-mooney | https://github.com/openstack/nova/blob/5b52db409b00e6257e83598efa0d8528ebe380e0/nova/objects/instance_pci_requests.py#L99-L100 | 00:19 |
| sean-k-mooney | thats just weird but ya not nows problem | 00:20 |
| *** pmannidi has quit IRC | 00:28 | |
| *** pmannidi has joined #openstack-nova | 00:30 | |
| *** macz_ has quit IRC | 00:42 | |
| *** mlavalle has quit IRC | 01:10 | |
| *** dklyle has quit IRC | 01:18 | |
| *** dklyle has joined #openstack-nova | 01:18 | |
| *** jangutter_ has joined #openstack-nova | 01:20 | |
| *** jangutter has quit IRC | 01:24 | |
| *** martinkennelly has quit IRC | 01:59 | |
| *** sapd1 has joined #openstack-nova | 02:00 | |
| openstackgerrit | Merged openstack/placement master: Implement secure RBAC for reshaper https://review.opendev.org/c/openstack/placement/+/774827 | 02:08 |
| openstackgerrit | Merged openstack/placement master: policy: Add releasenote for RBAC work https://review.opendev.org/c/openstack/placement/+/774654 | 02:08 |
| *** zzzeek has quit IRC | 02:20 | |
| *** zzzeek has joined #openstack-nova | 02:21 | |
| *** macz_ has joined #openstack-nova | 02:29 | |
| *** macz_ has quit IRC | 02:33 | |
| *** dklyle has quit IRC | 02:51 | |
| *** sapd1 has quit IRC | 02:56 | |
| *** zzzeek has quit IRC | 03:02 | |
| *** zzzeek has joined #openstack-nova | 03:06 | |
| *** tbachman has quit IRC | 03:07 | |
| *** tbachman_ has joined #openstack-nova | 03:07 | |
| *** spatel has joined #openstack-nova | 03:08 | |
| *** tbachman has joined #openstack-nova | 03:23 | |
| *** tbachman_ has quit IRC | 03:24 | |
| *** khomesh24 has joined #openstack-nova | 03:28 | |
| *** khomesh24 has quit IRC | 03:32 | |
| *** khomesh24 has joined #openstack-nova | 03:33 | |
| *** gyee has quit IRC | 03:33 | |
| *** psachin has joined #openstack-nova | 03:44 | |
| *** ratailor has joined #openstack-nova | 04:20 | |
| *** dviroel has quit IRC | 04:28 | |
| *** zzzeek has quit IRC | 05:08 | |
| *** zzzeek has joined #openstack-nova | 05:09 | |
| *** whoami-rajat__ has joined #openstack-nova | 06:03 | |
| *** ircuser-1 has quit IRC | 06:04 | |
| *** sapd1 has joined #openstack-nova | 06:20 | |
| *** vishalmanchanda has joined #openstack-nova | 06:22 | |
| *** spatel has quit IRC | 06:43 | |
| *** ralonsoh has joined #openstack-nova | 06:49 | |
| *** CeeMac has joined #openstack-nova | 07:08 | |
| *** zenkuro has joined #openstack-nova | 07:21 | |
| *** slaweq has joined #openstack-nova | 07:44 | |
| *** rpittau|afk is now known as rpittau | 07:53 | |
| *** belmoreira has joined #openstack-nova | 08:00 | |
| *** nightmare_unreal has joined #openstack-nova | 08:11 | |
| *** andrewbonney has joined #openstack-nova | 08:15 | |
| *** xek has joined #openstack-nova | 08:15 | |
| *** belmoreira has quit IRC | 08:16 | |
| *** tesseract has joined #openstack-nova | 08:19 | |
| *** hemanth_n has joined #openstack-nova | 08:31 | |
| *** tosky has joined #openstack-nova | 08:36 | |
| *** ygk_12345 has joined #openstack-nova | 08:46 | |
| * bauzas isn't enough drunk to work on mypy :p | 09:12 | |
| bauzas | and type hints :p | 09:12 |
| bauzas | stephenfin: :p | 09:12 |
| stephenfin | I don't get the dislike, tbh. They're really just structured comments that are (usually) checked for correctness | 09:13 |
| stephenfin | who doesn't want self-checking comments :) | 09:13 |
| stephenfin | *self-validating? | 09:13 |
| stephenfin | I can stick in a follow-up patch to add them though, seeing as I have them worked out already :D | 09:13 |
| kashyap | stephenfin: FWIW, yeah, I definitely see the value of function annotations | 09:16 |
| kashyap | Although, IIRC, they annotations aren't enforced at runtime | 09:20 |
| stephenfin | not without specific configuration, no | 09:20 |
| stephenfin | https://github.com/beartype/beartype | 09:21 |
| stephenfin | and libraries like it | 09:21 |
| stephenfin | Pretty sure Dropbox or Instagram or someone has a library for doing that too | 09:22 |
| kashyap | I see | 09:23 |
| kashyap | stephenfin: Do you know of any big projects enforcing it? | 09:23 |
| * kashyap is just asking out of curiosity | 09:24 | |
| stephenfin | At runtime? Not sure. Most of Instagram and Dropbox's codebases and type hinted now though, afaik | 09:24 |
| stephenfin | Sphinx uses it everywhere | 09:24 |
| kashyap | (Yeah, at runtime.) I see | 09:25 |
| bauzas | stephenfin: well, static typing is nice, but we have reviews and docstrings | 09:28 |
| bauzas | code reviews* | 09:28 |
| bauzas | it's just adding more complexity for the sake of nothing, since we have documentation for parameters | 09:29 |
| stephenfin | We don't though, and where we do, I've found it's been wrong more than a few times | 09:30 |
| stephenfin | I've already caught a few bugs with what little type hinting I've done | 09:30 |
| bauzas | ~o~ | 09:31 |
| * bauzas shrugs | 09:31 | |
| bauzas | anyway, I'll add them ;) | 09:31 |
| *** rnoriega has quit IRC | 09:32 | |
| openstackgerrit | Vishal Manchanda proposed openstack/nova master: Docs: Correct ``Password injection using the dashboard`` Explanation https://review.opendev.org/c/openstack/nova/+/775084 | 09:32 |
| *** rnoriega has joined #openstack-nova | 09:33 | |
| *** ralonsoh has quit IRC | 09:34 | |
| *** ralonsoh has joined #openstack-nova | 09:34 | |
| *** martinkennelly has joined #openstack-nova | 09:36 | |
| *** pmannidi_ has joined #openstack-nova | 09:37 | |
| *** pmannidi has quit IRC | 09:39 | |
| *** tbachman_ has joined #openstack-nova | 09:43 | |
| *** sapd1 has quit IRC | 09:44 | |
| *** derekh has joined #openstack-nova | 09:45 | |
| *** sapd1 has joined #openstack-nova | 09:45 | |
| *** tbachman has quit IRC | 09:46 | |
| *** tbachman_ is now known as tbachman | 09:46 | |
| gibi | I accept mypy, but I also have some reservation about the ROI of it. Adding proper typing for nested dict passed around is mentally hard and we use a lot of such dicts in our code. | 09:55 |
| gibi | sometimes it feels like we need to retrofit into nova a whole static type hierarchy just to be able to express typing things properly | 09:56 |
| gibi | and than I feel bad about using a dynamic language for that | 09:57 |
| * gibi should go and do some development in Rust | 09:57 | |
| *** dtantsur|afk is now known as dtantsur | 10:00 | |
| kashyap | gibi: Hey, when you get a moment | 10:08 |
| gibi | kashyap: hit me | 10:09 |
| kashyap | gibi: On the test coverage here: https://review.opendev.org/c/openstack/nova/+/774240/5/nova/tests/unit/virt/libvirt/test_driver.py#1524 | 10:09 |
| kashyap | gibi: I'm right now setting up an env to test it properly (in a real env) | 10:09 |
| kashyap | gibi: That said, we don't want to invest too much time right now to do many unit tests there -- as we want to replace (in a different patch series) that part of _check_cpu_compatibility() | 10:10 |
| kashyap | ... to use better and improved libvirt CPU APIs | 10:10 |
| gibi | hm, I remember that patch, where we are with that being merged? | 10:11 |
| kashyap | gibi: It is this one: https://review.opendev.org/c/openstack/nova/+/762330/ | 10:11 |
| kashyap | gibi: Good question | 10:11 |
| kashyap | gibi: That patch needs to be split out into 3 or 4 patches, as I noted in the review | 10:11 |
| kashyap | I might do it if chengsheng doesn't respond there. | 10:11 |
| kashyap | _But_: that needs to be done _on top of_ the disable CPU flags patch | 10:12 |
| kashyap | Because, that helps solve a more important problem for operatorswith lesser code, without having to fix the whole world | 10:12 |
| gibi | so you say that now it is hard and therefore costly to add unit test for _check_cpu_compatibility but after https://review.opendev.org/c/openstack/nova/+/762330/ there will be proper coverage | 10:12 |
| gibi | ? | 10:12 |
| *** macz_ has joined #openstack-nova | 10:12 | |
| kashyap | gibi: Indeed, that's what I mean. You make a good point there, no questions | 10:13 |
| kashyap | gibi: I mean, we keep the unit tests that I included in there, for the minimal coverage there is | 10:13 |
| kashyap | gibi: Also, please take a 4 minutes to read this context I wrote for today's meeting at the bottom: https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | 10:14 |
| gibi | kashyap: OK, let's expedite https://review.opendev.org/c/openstack/nova/+/762330/ after your fix lands | 10:15 |
| kashyap | That should give you context on _why_ I'm doing what I'm doing. And why I'm trying to keep it short and small - to be backportable | 10:15 |
| kashyap | gibi: Yep; thank you. | 10:16 |
| gibi | I need to recover your topic on the agenda, it seems stephenfin overwrote it :) | 10:16 |
| kashyap | Oh no, what have you done, stephenfin :D | 10:17 |
| stephenfin | whoops | 10:17 |
| kashyap | No problem :) I can re-add it -- assuming gibi is already not doing it | 10:17 |
| gibi | I will fix it | 10:17 |
| *** macz_ has quit IRC | 10:17 | |
| kashyap | I spent half hour writing clear sentences to reduce cognitive load, and stephenfin, you erased it :D | 10:18 |
| * kashyap stops teasing | 10:18 | |
| gibi | this is partially my fault as I did not clean up the agenda after the last meeting | 10:18 |
| kashyap | No problem; Wiki maint is a chore | 10:18 |
| *** sapd1 has quit IRC | 10:19 | |
| gibi | kashyap: fixed it, read it. It looks OK to me. If no objection on the meeting then I will approve the bp | 10:21 |
| kashyap | gibi: Understood; we can talk there. | 10:22 |
| gibi | coo | 10:22 |
| gibi | l | 10:22 |
| kashyap | Thanks! /me goes to fix his env. meanwhile to test the damn patch for real | 10:22 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: DNM: trace migration tests to see what steps take too long https://review.opendev.org/c/openstack/nova/+/775094 | 10:33 |
| *** jangutter has joined #openstack-nova | 10:33 | |
| *** jangutter_ has quit IRC | 10:36 | |
| kashyap | Isn't this strange? I have these services enabled for my DevStack run: | 10:48 |
| kashyap | ENABLED_SERVICES=g-api,g-reg,key,n-api,n-cpu,n-sch,n-cond,mysql,rabbit,dstat,quantum,q-svc,q-agt,q-dhcp,q-l3,q-meta | 10:48 |
| kashyap | During stack.sh, I see this fly by: "+./stack.sh:echo_summary:416 echo -e Configuring Horizon" | 10:49 |
| * kashyap wonders why is it configuring Horizon when I didn't tell it to... | 10:49 | |
| *** k_mouza has joined #openstack-nova | 10:53 | |
| kashyap | gibi (or anyone): Have you ever seen this? After 18 minutes of stack.sh, it fails o me like this: -- http://paste.openstack.org/show/802558/ | 10:59 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Record the machine_type of instances in system_metadata https://review.opendev.org/c/openstack/nova/+/767533 | 11:05 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: nova-manage: Add machine_type get command https://review.opendev.org/c/openstack/nova/+/769548 | 11:05 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: nova-manage: Add machine_type update command https://review.opendev.org/c/openstack/nova/+/774896 | 11:05 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP nova-manage: Add machine_type list_unset command https://review.opendev.org/c/openstack/nova/+/774897 | 11:05 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: nova-status: Add hw_machine_type check for libvirt instances https://review.opendev.org/c/openstack/nova/+/770643 | 11:05 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Add a config update workflow test for [libvirt]hw_machine_type https://review.opendev.org/c/openstack/nova/+/774898 | 11:05 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: docs: Add admin docs for configuring and updating machine types https://review.opendev.org/c/openstack/nova/+/774899 | 11:05 |
| lyarwood | kashyap: Didn't find service registered by hostname after 60 seconds | 11:07 |
| kashyap | lyarwood: Yeah; figured out - actually it's a CPU model prob | 11:07 |
| kashyap | I gave a model that is marked as "no" by libvirt | 11:07 |
| kashyap | Thanks for looking :) sean-k-mooney gave the hint, while we're on a call | 11:07 |
| lyarwood | kashyap: so n-cpu didn't start? | 11:07 |
| lyarwood | k | 11:08 |
| kashyap | lyarwood: Saw the exception in journalctl -u devstack@n-cpu | 11:08 |
| gibi | sorry I was away | 11:11 |
| gibi | but I see you solved it | 11:11 |
| kashyap | Yes; no problem. I never count on instant responses :) | 11:12 |
| *** khomesh24 has quit IRC | 11:16 | |
| *** zzzeek has quit IRC | 11:28 | |
| *** zzzeek has joined #openstack-nova | 11:30 | |
| *** macz_ has joined #openstack-nova | 11:34 | |
| *** macz_ has quit IRC | 11:39 | |
| *** ociuhandu has joined #openstack-nova | 11:46 | |
| *** k_mouza has quit IRC | 11:49 | |
| *** k_mouza_ has joined #openstack-nova | 11:49 | |
| *** macz_ has joined #openstack-nova | 11:55 | |
| gibi | sean-k-mooney: hi! here is a bug report https://bugs.launchpad.net/nova/+bug/1915255 based on the git log https://review.opendev.org/c/openstack/nova/+/739131 seems suspicious causing it. Could you please take a look? | 11:56 |
| openstack | Launchpad bug 1915255 in OpenStack Compute (nova) "[Victoria] nova-compute won't start on aarch64 - raises PciDeviceNotFoundById" [Undecided,New] | 11:56 |
| sean-k-mooney | am yes i can take a look | 11:57 |
| sean-k-mooney | so the function that is failing is not one i added but one im started calling | 12:00 |
| *** macz_ has quit IRC | 12:00 | |
| sean-k-mooney | that exception i think shoudl alreay be caught but maybe not in the current code path | 12:00 |
| sean-k-mooney | its failing to look up the parent netdev name for badnwith based schduling | 12:00 |
| sean-k-mooney | we could rewrite that function to call libvirt instead of sysfs possibly | 12:02 |
| *** dviroel has joined #openstack-nova | 12:02 | |
| *** k_mouza_ has quit IRC | 12:03 | |
| *** k_mouza has joined #openstack-nova | 12:03 | |
| gibi | hm, then I will take a look too | 12:14 |
| gibi | lyarwood: hi! Could this be another manifestation of the detach retry bug I'm trying to fix? https://bugs.launchpad.net/nova/+bug/1914664 | 12:15 |
| openstack | Launchpad bug 1914664 in OpenStack Compute (nova) "QEMU monitor read failure in ServerStableDeviceRescueTest" [Undecided,New] | 12:15 |
| sean-k-mooney | gibi: apparently the Cavium ThunderX does not always have a PF assinged to each VF | 12:18 |
| sean-k-mooney | from https://bugs.launchpad.net/charm-nova-compute/+bug/1771662 | 12:18 |
| openstack | Launchpad bug 1771662 in libvirt (Ubuntu Disco) "[bionic] libvirtError: Node device not found: no node device with matching name" [Undecided,Fix released] | 12:18 |
| sean-k-mooney | ibvirt has had the assumption that every VF (virtual function) will | 12:18 |
| sean-k-mooney | have a PF (physical function) assigned, but that does not hold true on | 12:18 |
| gibi | sean-k-mooney: how that is possible? | 12:18 |
| sean-k-mooney | some special Hardware like the Cavium ThunderX | 12:18 |
| sean-k-mooney | i am not sure maybe they mean netdev | 12:18 |
| sean-k-mooney | its possible for the PF to no actully work as a nic and only provide VFs | 12:19 |
| gibi | if there is no parent PF then the whole qos stuff is just breaks down as we modell bw inventory on the PF | 12:19 |
| sean-k-mooney | ya | 12:19 |
| sean-k-mooney | so in any case we need to allow the compute agent to start | 12:20 |
| sean-k-mooney | so we need to deal with the excpeiton | 12:20 |
| sean-k-mooney | but i think this is jus ta case of this is strange hardware | 12:20 |
| gibi | yes, we have to allow the compute to start but then this interface will not be ever selected for a port that has qos request | 12:20 |
| sean-k-mooney | yep | 12:20 |
| gibi | thanks for the triage on this bug | 12:20 |
| sean-k-mooney | so there are two ways we can adress this it looks like the old logic just logged. | 12:22 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/739131/12/nova/pci/utils.py | 12:22 |
| sean-k-mooney | so we can do that | 12:22 |
| sean-k-mooney | or we can also maybe stop using sysfs and use libvirt | 12:22 |
| sean-k-mooney | or both in seperate patchs | 12:22 |
| lyarwood | gibi: looking | 12:23 |
| gibi | lyarwood: thanks | 12:23 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Uncap PrettyTable https://review.opendev.org/c/openstack/nova/+/775142 | 12:23 |
| gibi | sean-k-mooney: as a fix I would just log now | 12:23 |
| sean-k-mooney | oh actully | 12:24 |
| sean-k-mooney | this code is common its not allowed to talk to libvirt | 12:24 |
| gibi | sean-k-mooney: as far as I understand your patch moved away from libvirt for certain reasons | 12:24 |
| sean-k-mooney | that is why we are using sysfs | 12:24 |
| sean-k-mooney | ya libvirt can get out os sync | 12:25 |
| sean-k-mooney | for nodedev names | 12:25 |
| sean-k-mooney | so ya using libvirt here would not be right | 12:25 |
| openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: Uncap PrettyTable https://review.opendev.org/c/openstack/python-novaclient/+/775143 | 12:26 |
| openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: requirements: Remove simplejson https://review.opendev.org/c/openstack/python-novaclient/+/775144 | 12:26 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/739131/12/nova/virt/libvirt/driver.py#b6960 | 12:26 |
| sean-k-mooney | that might be the issue | 12:26 |
| *** ociuhandu has quit IRC | 12:27 | |
| *** ratailor has quit IRC | 12:27 | |
| *** ociuhandu has joined #openstack-nova | 12:27 | |
| sean-k-mooney | ya so my note | 12:28 |
| sean-k-mooney | # NOTE(sean-k-mooney): if the VF is a parent of a netdev | 12:28 |
| sean-k-mooney | # the PF should also have a netdev. | 12:28 |
| *** ociuhandu has quit IRC | 12:28 | |
| sean-k-mooney | i guess is not true for this hardware | 12:28 |
| *** ociuhandu has joined #openstack-nova | 12:28 | |
| sean-k-mooney | so we jus tneed to readd that try except | 12:28 |
| sean-k-mooney | ill triage it now | 12:29 |
| gibi | thanks | 12:31 |
| *** tbachman has quit IRC | 12:34 | |
| lyarwood | gibi / dansmith ; https://bugs.launchpad.net/nova/+bug/1914664 - the test failure looks like a volume quota issue in that job, we might want to track that in another bug while we look at the unrelated detach device trace | 12:36 |
| openstack | Launchpad bug 1914664 in OpenStack Compute (nova) "QEMU monitor read failure in ServerStableDeviceRescueTest" [Undecided,New] | 12:36 |
| *** ociuhandu has quit IRC | 12:41 | |
| *** ociuhandu has joined #openstack-nova | 12:41 | |
| openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: Add support for microversion v2.88 https://review.opendev.org/c/openstack/python-novaclient/+/770573 | 12:45 |
| *** ociuhandu has quit IRC | 12:46 | |
| stephenfin | dansmith: Now that most of the migration compaction series has merged for the main DB, could I ask that you look at the API DB equivalent? I employed the same testing strategy so it should all be very familiar https://review.opendev.org/q/topic:%2522bp/compact-db-migrations-wallaby%2522+status:open+NOT+label:workflow%253E%253D1 | 12:47 |
| *** hemanth_n has quit IRC | 12:47 | |
| *** ociuhandu has joined #openstack-nova | 12:50 | |
| *** mgagne has quit IRC | 12:52 | |
| *** mgagne has joined #openstack-nova | 12:53 | |
| *** luksky has joined #openstack-nova | 12:56 | |
| *** zzzeek has quit IRC | 13:07 | |
| *** zzzeek has joined #openstack-nova | 13:08 | |
| gibi | lyarwood: thanks | 13:10 |
| *** ygk_12345 has quit IRC | 13:20 | |
| *** zzzeek has quit IRC | 13:21 | |
| *** psachin has quit IRC | 13:26 | |
| *** zzzeek has joined #openstack-nova | 13:26 | |
| *** tbachman has joined #openstack-nova | 13:26 | |
| *** ociuhandu has quit IRC | 13:40 | |
| *** ociuhandu has joined #openstack-nova | 13:41 | |
| *** sapd1 has joined #openstack-nova | 13:43 | |
| *** ociuhandu has quit IRC | 13:52 | |
| *** spatel has joined #openstack-nova | 13:53 | |
| *** stand has quit IRC | 13:54 | |
| *** ociuhandu has joined #openstack-nova | 13:54 | |
| dansmith | lyarwood: I already had a fix up for that, I think we lost bug linkage recently | 14:01 |
| gibi | dansmith: we don't have bug linkage since we upgraded the gerrit server | 14:02 |
| dansmith | right | 14:02 |
| dansmith | https://review.opendev.org/c/openstack/devstack/+/774172 | 14:02 |
| dansmith | I opened a different bug I guess I thought it was a separate issue | 14:03 |
| *** ociuhandu has quit IRC | 14:04 | |
| *** lemko has quit IRC | 14:09 | |
| *** lemko has joined #openstack-nova | 14:09 | |
| *** vishalmanchanda has quit IRC | 14:14 | |
| *** ociuhandu has joined #openstack-nova | 14:16 | |
| lyarwood | dansmith: ah wonderful | 14:18 |
| *** ociuhandu has quit IRC | 14:20 | |
| *** ociuhandu has joined #openstack-nova | 14:22 | |
| openstackgerrit | Merged openstack/os-vif master: Resolve dependency issues https://review.opendev.org/c/openstack/os-vif/+/774694 | 14:32 |
| *** ociuhandu has quit IRC | 14:37 | |
| *** ociuhandu has joined #openstack-nova | 14:40 | |
| *** ociuhandu has quit IRC | 14:47 | |
| *** macz_ has joined #openstack-nova | 14:47 | |
| *** ociuhandu has joined #openstack-nova | 14:48 | |
| *** macz_ has quit IRC | 14:52 | |
| *** ociuhandu has quit IRC | 14:55 | |
| *** ociuhandu has joined #openstack-nova | 14:56 | |
| *** belmoreira has joined #openstack-nova | 14:59 | |
| *** ociuhandu has quit IRC | 15:02 | |
| *** ociuhandu has joined #openstack-nova | 15:04 | |
| *** READ10 has joined #openstack-nova | 15:15 | |
| *** ociuhandu has quit IRC | 15:39 | |
| *** ociuhandu has joined #openstack-nova | 15:44 | |
| *** macz_ has joined #openstack-nova | 15:44 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support interface attach with QoS ports https://review.opendev.org/c/openstack/nova/+/756530 | 15:46 |
| gibi | bauzas: fixed up based on your comments ^^ | 15:47 |
| bauzas | gibi: coolio, but working atm on stephenfin's nits with routed networks :p | 15:48 |
| gibi | ack, no worries | 15:48 |
| *** luksky has quit IRC | 15:48 | |
| *** macz_ has quit IRC | 15:48 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove unused Instance method https://review.opendev.org/c/openstack/nova/+/757615 | 15:51 |
| -openstackstatus- NOTICE: Recent POST_FAILURE results from Zuul for builds started prior to 15:47 UTC were due to network connectivity issues reaching one of our log storage providers, and can be safely rechecked | 15:51 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Enable mypy on scheduler/report.py https://review.opendev.org/c/openstack/nova/+/765152 | 15:51 |
| gibi | nova meeting starts in 8 minutes on #openstack-meeting-3 | 15:52 |
| *** dklyle has joined #openstack-nova | 15:52 | |
| *** david-lyle has joined #openstack-nova | 15:54 | |
| *** david-lyle has quit IRC | 15:54 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Record the machine_type of instances in system_metadata https://review.opendev.org/c/openstack/nova/+/767533 | 15:54 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: nova-manage: Add machine_type get command https://review.opendev.org/c/openstack/nova/+/769548 | 15:54 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: nova-manage: Add machine_type update command https://review.opendev.org/c/openstack/nova/+/774896 | 15:54 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP nova-manage: Add machine_type list_unset command https://review.opendev.org/c/openstack/nova/+/774897 | 15:54 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: nova-status: Add hw_machine_type check for libvirt instances https://review.opendev.org/c/openstack/nova/+/770643 | 15:54 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Add a config update workflow test for [libvirt]hw_machine_type https://review.opendev.org/c/openstack/nova/+/774898 | 15:54 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: docs: Add admin docs for configuring and updating machine types https://review.opendev.org/c/openstack/nova/+/774899 | 15:54 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP: nova-next: Start testing the 'q35' machine type https://review.opendev.org/c/openstack/nova/+/708701 | 15:54 |
| *** xek has quit IRC | 15:57 | |
| *** k_mouza_ has joined #openstack-nova | 16:03 | |
| *** luksky has joined #openstack-nova | 16:05 | |
| *** k_mouza has quit IRC | 16:05 | |
| *** macz_ has joined #openstack-nova | 16:09 | |
| *** derekh has quit IRC | 16:10 | |
| *** derekh has joined #openstack-nova | 16:11 | |
| *** mlavalle has joined #openstack-nova | 16:24 | |
| supamatt | nah don't need it | 16:25 |
| supamatt | err sorry wrong chan | 16:25 |
| gmann | lyarwood: gibi elod on placement stable/victoria failure- basically we can backport this to stable/victoria along with .gitreview change - https://review.opendev.org/c/openstack/placement/+/766994 | 16:34 |
| gmann | if that looks fine as per backport policy then I can propose | 16:34 |
| gibi | gmann: I let the stable cores decide on backportability | 16:35 |
| gibi | for me that change make sense | 16:35 |
| lyarwood | gmann: how clean is it on stable/victoria ? | 16:36 |
| lyarwood | gmann: I personally don't mind if it gives us a passing branch in-line with the later releases tbh, my only concern would be if we need to fixup more code across the tree to land it | 16:36 |
| gmann | lyarwood: basically fixing the hacking 4.0.0 checks. so some code style change | 16:36 |
| *** gyee has joined #openstack-nova | 16:37 | |
| lyarwood | gmann: yeah if they are limited to the same or just a few more then I'm fine | 16:37 |
| dansmith | also seems okay to me.. we don't want to be bumping the requirements on stable, but this is just for our own tooling/testing I think, | 16:37 |
| dansmith | and distros really have to do their own version mappings anyway | 16:37 |
| dansmith | gmann: how about a reno to highlight the change and reasoning? | 16:37 |
| dansmith | in the backport | 16:38 |
| gmann | ok, that make sense. usually we do not need to bump hacking in stable but these version conflict made us to do | 16:38 |
| *** ociuhandu has quit IRC | 16:54 | |
| openstackgerrit | Ghanshyam proposed openstack/placement stable/victoria: Fix l-c job and move to latest hacking 4.0.0 https://review.opendev.org/c/openstack/placement/+/775214 | 16:54 |
| *** ociuhandu has joined #openstack-nova | 16:55 | |
| openstackgerrit | Ghanshyam proposed openstack/placement stable/victoria: Fix l-c job and move to latest hacking 4.0.0 https://review.opendev.org/c/openstack/placement/+/775214 | 16:57 |
| *** ociuhandu has quit IRC | 17:01 | |
| elod | gmann: ++ \o/ | 17:02 |
| *** ociuhandu has joined #openstack-nova | 17:03 | |
| gibi | lyarwood: I have feedback in https://review.opendev.org/c/openstack/os-traits/+/759878 | 17:04 |
| lyarwood | stephenfin: re https://review.opendev.org/c/openstack/nova/+/772271 - stupid question, that didn't replace the instance.name, just the instance.hostname right? | 17:05 |
| * lyarwood was sure it didn't but I've got doubts now given the feedback from dansmith | 17:05 | |
| stephenfin | lyarwood: correct. Display name isn't affected | 17:05 |
| lyarwood | kk well dansmith has voted now anyway so we can close this out | 17:05 |
| lyarwood | gibi: looking | 17:06 |
| dansmith | lyarwood: what about what I said is related to display vs hostname? | 17:07 |
| lyarwood | dansmith: nothing but the arguments you put forward suggested that you thought the impact of this landed outside of just instance.hostname that AFAIK is something we only expose through the metadata API | 17:08 |
| *** ociuhandu_ has joined #openstack-nova | 17:12 | |
| lyarwood | ah nvm it's in our show server response, ignore me if you weren't already | 17:12 |
| *** xek has joined #openstack-nova | 17:14 | |
| *** ociuhandu has quit IRC | 17:15 | |
| openstackgerrit | Lee Yarwood proposed openstack/os-traits master: Add COMPUTE_EPHEMERAL_ENCRYPTION tratis https://review.opendev.org/c/openstack/os-traits/+/759878 | 17:15 |
| *** ociuhandu_ has quit IRC | 17:16 | |
| openstackgerrit | Merged openstack/os-traits master: Add COMPUTE_SOCKET_PCI_NUMA_AFFINITY trait https://review.opendev.org/c/openstack/os-traits/+/771705 | 17:16 |
| openstackgerrit | Merged openstack/os-traits master: Add a trait for UEFI Secure Boot support https://review.opendev.org/c/openstack/os-traits/+/770570 | 17:24 |
| dansmith | lyarwood: heh okay | 17:33 |
| dansmith | lyarwood: it's still visible to the user of the instance in a variety of ways, not just the API, but yeah | 17:33 |
| dansmith | lyarwood: back to that volumes quota thing, were you asserting that the qemu monitor reset was related to the inability to create a volume on the glance side? | 17:34 |
| lyarwood | dansmith: no just that the QEMU monitor issue was unrelated to the actual test failure that failed the overall job | 17:36 |
| lyarwood | dansmith: iirc it's a ipv6 test spawned that instance and it looks like the monitor issue was during cleanup and ignored | 17:37 |
| lyarwood | ipv6 test that spawned* | 17:37 |
| *** ociuhandu has joined #openstack-nova | 17:38 | |
| dansmith | ah okay I filed separately because they were separate, so you're just saying that's a known problem? I've seen it before obviously, but haven't in a while and since it was stable rescue, I thought maybe it was related to disk attachments | 17:38 |
| lyarwood | dansmith: I've not seen an EOF from the monitor while detaching a nic recently | 17:41 |
| lyarwood | dansmith: and again to be clear, that trace and the failed test are separate | 17:41 |
| dansmith | yeah I get that | 17:42 |
| *** ociuhandu has quit IRC | 17:42 | |
| lyarwood | kk well we can use this bug for the monitor part as you already have one for the quota bit | 17:42 |
| * lyarwood finds the test that launched the instance and updates the bug subject | 17:42 | |
| dansmith | right, gibi commented on the monitor bug saying it was being tracked in the quota bug | 17:42 |
| lyarwood | oh really? | 17:43 |
| * lyarwood looks | 17:43 | |
| dansmith | so just wanted to makes ure | 17:43 |
| dansmith | oh, sorry sorry, you're just saying I called out the wrong test, I see | 17:43 |
| lyarwood | ah cool I see sorry | 17:43 |
| *** rpittau is now known as rpittau|afk | 17:43 | |
| lyarwood | yup indeed, AttachInterfacesTest is what we want to list, I've updated the subject | 17:44 |
| dansmith | in my mind I had moved past that with the quota bug and fix, but i see what you mean about the title on the other.. the trace is the important thing | 17:44 |
| dansmith | yep, gotcha | 17:44 |
| *** dtantsur is now known as dtantsur|afk | 17:45 | |
| *** tesseract has quit IRC | 17:48 | |
| *** sapd1 has quit IRC | 17:51 | |
| *** ralonsoh has quit IRC | 17:54 | |
| lyarwood | dansmith: ah weird, so it looks like something didn't wait for the nic to detach before deleting the instance | 17:54 |
| dansmith | ah, I guess that would explain the lack of fail | 17:55 |
| lyarwood | dansmith: the EOF monitor error comes out of a request to handle a network-vif-deleted:064543b1-709d-445f-b852-98b59f977aed event from neutron | 17:55 |
| dansmith | kinda sucks to barf something that serious into the logs if we're just nuking the instance underneath | 17:55 |
| lyarwood | dansmith: and right after that n-api gets a DELETE request for the server | 17:55 |
| dansmith | maybe we could ignore if the instance is deleted when we get that error? | 17:55 |
| dansmith | or log.warn instead of EXPLODE | 17:56 |
| *** derekh has quit IRC | 17:57 | |
| lyarwood | dansmith: https://github.com/openstack/nova/blob/fec44e5d38baa0232bf41367303b82dc332eb512/nova/compute/manager.py#L7778-L7790 looks like we try to log at DEBUG in that case but didn't in this instance | 17:58 |
| lyarwood | oh because it's looking at the exception and not checking if the instance is around still | 17:58 |
| dansmith | yeah, so it probably does that right if we triggered the NotFound as a result of pulling up info on the instance, | 18:00 |
| dansmith | but if we failed because its been nuked, we should refresh our world view before we decide who to wake up | 18:01 |
| dansmith | although it's logging a trace, but I don't see it passing the exc_info there | 18:01 |
| * lyarwood wonders why we aren't locking by instance.uuid for both of these operations anyway | 18:03 | |
| lyarwood | need to run and help put a baby to bed, I'll try and finish writing this up before I call it for the day | 18:03 |
| *** songwenping__ has joined #openstack-nova | 18:05 | |
| *** k_mouza_ has quit IRC | 18:05 | |
| *** songwenping_ has quit IRC | 18:06 | |
| *** dklyle has quit IRC | 18:09 | |
| openstackgerrit | Merged openstack/python-novaclient master: Uncap PrettyTable https://review.opendev.org/c/openstack/python-novaclient/+/775143 | 18:11 |
| openstackgerrit | Merged openstack/python-novaclient master: requirements: Remove simplejson https://review.opendev.org/c/openstack/python-novaclient/+/775144 | 18:12 |
| *** READ10 is now known as READ10|away | 18:17 | |
| *** luksky has quit IRC | 18:35 | |
| *** belmoreira has quit IRC | 18:51 | |
| *** READ10|away is now known as READ10 | 18:51 | |
| *** luksky has joined #openstack-nova | 18:52 | |
| *** dklyle has joined #openstack-nova | 18:56 | |
| *** spatel has quit IRC | 19:25 | |
| *** spatel has joined #openstack-nova | 19:28 | |
| *** rchurch has quit IRC | 19:34 | |
| *** rchurch has joined #openstack-nova | 19:35 | |
| *** andrewbonney has quit IRC | 19:42 | |
| *** nightmare_unreal has quit IRC | 19:47 | |
| *** READ10 has quit IRC | 20:18 | |
| sean-k-mooney | lyarwood: can you take a look at https://review.opendev.org/c/openstack/nova/+/759522 and https://review.opendev.org/c/openstack/nova/+/759151 | 20:34 |
| sean-k-mooney | elod: if you could take a look too that would be great that has to go back to train | 20:35 |
| sean-k-mooney | victoria is merged so ussuri is up next | 20:35 |
| sean-k-mooney | there are a few people askinf for this on the bug https://bugs.launchpad.net/nova/+bug/1888395 | 20:36 |
| openstack | Launchpad bug 1888395 in OpenStack Compute (nova) ussuri "live migration of a vm using the single port binding work flow is broken in train as a result of the introduction of sriov live migration" [High,In progress] - Assigned to Billy Olsen (billy-olsen) | 20:36 |
| openstackgerrit | Merged openstack/nova master: db: Compact Stein database migrations https://review.opendev.org/c/openstack/nova/+/759090 | 20:55 |
| openstackgerrit | Ghanshyam proposed openstack/placement stable/victoria: Fix l-c job and move to latest hacking 4.0.0 https://review.opendev.org/c/openstack/placement/+/775214 | 20:58 |
| elod | sean-k-mooney: sure, added to my TODOs, will look into it tomorrow | 20:58 |
| *** ociuhandu has joined #openstack-nova | 21:17 | |
| *** rcernin has joined #openstack-nova | 21:20 | |
| *** k_mouza has joined #openstack-nova | 21:51 | |
| *** k_mouza has quit IRC | 21:56 | |
| *** spatel has quit IRC | 22:03 | |
| *** gmann is now known as gmann_afk | 22:10 | |
| *** k_mouza has joined #openstack-nova | 22:15 | |
| *** dklyle has quit IRC | 22:19 | |
| *** dklyle has joined #openstack-nova | 22:19 | |
| *** k_mouza has quit IRC | 22:22 | |
| *** luksky has quit IRC | 22:25 | |
| *** lemko7 has joined #openstack-nova | 22:29 | |
| *** lemko has quit IRC | 22:30 | |
| *** lemko7 is now known as lemko | 22:30 | |
| *** PrinzElvis has quit IRC | 22:41 | |
| *** PrinzElvis has joined #openstack-nova | 22:41 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Make a couple test jobs run async devstack https://review.opendev.org/c/openstack/nova/+/775293 | 23:01 |
| *** slaweq has quit IRC | 23:09 | |
| *** gmann_afk is now known as gmann | 23:11 | |
| *** ociuhandu has quit IRC | 23:19 | |
| openstackgerrit | Ghanshyam proposed openstack/placement stable/victoria: Fix l-c job and move to latest hacking 4.0.0 https://review.opendev.org/c/openstack/placement/+/775214 | 23:22 |
| *** whoami-rajat__ has quit IRC | 23:43 | |
| *** zenkuro has quit IRC | 23:43 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!