| *** jangutter has joined #openstack-nova | 00:06 | |
| *** xarlos has quit IRC | 00:07 | |
| *** jangutter has quit IRC | 00:11 | |
| *** jangutter has joined #openstack-nova | 00:12 | |
| *** zenkuro has quit IRC | 00:25 | |
| *** zenkuro has joined #openstack-nova | 00:25 | |
| *** k_mouza has joined #openstack-nova | 00:30 | |
| *** macz_ has quit IRC | 00:34 | |
| *** k_mouza has quit IRC | 00:34 | |
| *** tbachman has quit IRC | 00:52 | |
| openstackgerrit | Merged openstack/nova master: cmd: Remove 'nova-manage db null_instance_uuid_scan' https://review.opendev.org/c/openstack/nova/+/773775 | 00:52 |
|---|---|---|
| *** tbachman has joined #openstack-nova | 00:52 | |
| *** macz_ has joined #openstack-nova | 00:55 | |
| openstackgerrit | Merged openstack/nova master: cmd: Remove 'nova-manage db ironic_flavor_migration' https://review.opendev.org/c/openstack/nova/+/773776 | 00:57 |
| *** dviroel has quit IRC | 00:59 | |
| *** macz_ has quit IRC | 01:00 | |
| *** brinzhang has joined #openstack-nova | 01:10 | |
| *** macz_ has joined #openstack-nova | 01:16 | |
| *** macz_ has quit IRC | 01:20 | |
| *** zenkuro has quit IRC | 01:31 | |
| *** macz_ has joined #openstack-nova | 01:37 | |
| *** macz_ has quit IRC | 01:41 | |
| *** k_mouza has joined #openstack-nova | 01:49 | |
| *** macz_ has joined #openstack-nova | 01:58 | |
| *** k_mouza has quit IRC | 02:00 | |
| *** macz_ has quit IRC | 02:02 | |
| *** macz_ has joined #openstack-nova | 02:18 | |
| *** macz_ has quit IRC | 02:23 | |
| *** rcernin has quit IRC | 02:27 | |
| *** macz_ has joined #openstack-nova | 02:58 | |
| *** hemanth_n has joined #openstack-nova | 02:58 | |
| *** macz_ has quit IRC | 03:02 | |
| *** rcernin has joined #openstack-nova | 03:07 | |
| *** mkrai has joined #openstack-nova | 03:14 | |
| openstackgerrit | Billy Olsen proposed openstack/nova stable/train: add functional regression test for bug #1888395 https://review.opendev.org/c/openstack/nova/+/759533 | 03:29 |
| openstack | bug 1888395 in OpenStack Compute (nova) ussuri "live migration of a vm using the single port binding work flow is broken in train as a result of the introduction of sriov live migration" [High,In progress] https://launchpad.net/bugs/1888395 - Assigned to Billy Olsen (billy-olsen) | 03:29 |
| openstackgerrit | Billy Olsen proposed openstack/nova stable/train: Set migrate_data.vifs only when using multiple port bindings https://review.opendev.org/c/openstack/nova/+/759153 | 03:29 |
| *** psachin has joined #openstack-nova | 03:41 | |
| *** khomesh24 has joined #openstack-nova | 03:42 | |
| *** khomesh24 has quit IRC | 03:42 | |
| *** khomesh24 has joined #openstack-nova | 03:43 | |
| *** mkrai has quit IRC | 03:49 | |
| *** mkrai_ has joined #openstack-nova | 03:50 | |
| *** k_mouza has joined #openstack-nova | 04:00 | |
| *** k_mouza has quit IRC | 04:04 | |
| *** k_mouza has joined #openstack-nova | 04:13 | |
| openstackgerrit | Merged openstack/nova master: hardware: Check inventory of shared CPUs for 'mixed' policy https://review.opendev.org/c/openstack/nova/+/756101 | 04:14 |
| *** macz_ has joined #openstack-nova | 04:17 | |
| *** k_mouza has quit IRC | 04:18 | |
| *** macz_ has quit IRC | 04:22 | |
| *** vishalmanchanda has joined #openstack-nova | 04:36 | |
| *** ratailor has joined #openstack-nova | 04:37 | |
| *** macz_ has joined #openstack-nova | 04:38 | |
| *** hamalq has quit IRC | 04:41 | |
| *** macz_ has quit IRC | 04:42 | |
| *** macz_ has joined #openstack-nova | 04:58 | |
| *** gyee has quit IRC | 05:01 | |
| *** macz_ has quit IRC | 05:03 | |
| *** mkrai_ has quit IRC | 05:15 | |
| *** mkrai has joined #openstack-nova | 05:28 | |
| *** whoami-rajat__ has joined #openstack-nova | 06:12 | |
| *** belmoreira has joined #openstack-nova | 06:30 | |
| *** mnaser has quit IRC | 06:32 | |
| *** mnaser has joined #openstack-nova | 06:34 | |
| *** ralonsoh has joined #openstack-nova | 06:41 | |
| *** cz3 has quit IRC | 06:48 | |
| *** cz3 has joined #openstack-nova | 06:49 | |
| *** belmoreira has quit IRC | 07:02 | |
| *** slaweq has joined #openstack-nova | 07:07 | |
| *** bbowen_ has joined #openstack-nova | 07:16 | |
| *** bbowen has quit IRC | 07:17 | |
| *** belmoreira has joined #openstack-nova | 07:17 | |
| *** mkrai has quit IRC | 07:19 | |
| *** mkrai has joined #openstack-nova | 07:29 | |
| *** k_mouza has joined #openstack-nova | 07:29 | |
| *** k_mouza has quit IRC | 07:34 | |
| *** dklyle has quit IRC | 07:38 | |
| *** rcernin has quit IRC | 07:47 | |
| *** luksky has joined #openstack-nova | 07:57 | |
| *** macz_ has joined #openstack-nova | 08:10 | |
| *** rpittau|afk is now known as rpittau | 08:12 | |
| *** rcernin has joined #openstack-nova | 08:12 | |
| *** andrewbonney has joined #openstack-nova | 08:13 | |
| *** macz_ has quit IRC | 08:15 | |
| *** bbowen_ has quit IRC | 08:16 | |
| *** bbowen_ has joined #openstack-nova | 08:16 | |
| *** rcernin has quit IRC | 08:19 | |
| *** rcernin has joined #openstack-nova | 08:26 | |
| *** rcernin has quit IRC | 08:31 | |
| *** ratailor has quit IRC | 08:33 | |
| *** ratailor has joined #openstack-nova | 08:34 | |
| *** rcernin has joined #openstack-nova | 08:37 | |
| *** xarlos has joined #openstack-nova | 08:43 | |
| *** xek has joined #openstack-nova | 08:49 | |
| *** rcernin has quit IRC | 08:51 | |
| *** rcernin has joined #openstack-nova | 08:56 | |
| *** zenkuro has joined #openstack-nova | 08:59 | |
| *** rcernin has quit IRC | 09:02 | |
| *** ociuhandu has joined #openstack-nova | 09:07 | |
| *** tosky has joined #openstack-nova | 09:14 | |
| *** ociuhandu has quit IRC | 09:17 | |
| *** tosky_ has joined #openstack-nova | 09:20 | |
| *** zenkuro has quit IRC | 09:23 | |
| *** tosky has quit IRC | 09:24 | |
| *** zenkuro has joined #openstack-nova | 09:24 | |
| *** tosky_ is now known as tosky | 09:25 | |
| *** rcernin has joined #openstack-nova | 09:28 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Record the machine_type of instances in system_metadata https://review.opendev.org/c/openstack/nova/+/767533 | 09:30 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: nova-manage: Add machine_type get command https://review.opendev.org/c/openstack/nova/+/769548 | 09:30 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: nova-manage: Add machine_type update command https://review.opendev.org/c/openstack/nova/+/774896 | 09:30 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP nova-manage: Add machine_type list_unset command https://review.opendev.org/c/openstack/nova/+/774897 | 09:30 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: nova-status: Add hw_machine_type check for libvirt instances https://review.opendev.org/c/openstack/nova/+/770643 | 09:30 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Add a config update workflow test for [libvirt]hw_machine_type https://review.opendev.org/c/openstack/nova/+/774898 | 09:30 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: docs: Add admin docs for configuring and updating machine types https://review.opendev.org/c/openstack/nova/+/774899 | 09:30 |
| *** rcernin has quit IRC | 09:35 | |
| *** derekh has joined #openstack-nova | 09:39 | |
| swp20 | sean-k-mooney: morning, i have linked irc log in the NOVNC patch, please check https://review.opendev.org/c/openstack/nova/+/622336 | 09:46 |
| *** ociuhandu has joined #openstack-nova | 09:47 | |
| *** k_mouza has joined #openstack-nova | 09:51 | |
| *** rcernin has joined #openstack-nova | 09:59 | |
| *** dtantsur|afk is now known as dtantsur | 10:01 | |
| openstackgerrit | Belmiro Moreira proposed openstack/nova master: Change API unexpected exception message https://review.opendev.org/c/openstack/nova/+/628061 | 10:03 |
| *** ociuhandu has quit IRC | 10:10 | |
| *** zoharm has joined #openstack-nova | 10:11 | |
| *** mkrai has quit IRC | 10:19 | |
| *** ociuhandu has joined #openstack-nova | 10:20 | |
| bauzas | stupid question : given the tox-lower-constraints job failed on https://review.opendev.org/c/openstack/nova/+/773976/6, I guess I can try to reproduce it locally by using the same tox target? | 10:30 |
| *** rcernin has quit IRC | 10:31 | |
| *** jangutter_ has joined #openstack-nova | 10:34 | |
| *** jangutter has quit IRC | 10:38 | |
| *** prometheanfire has quit IRC | 10:42 | |
| lyarwood | bauzas: yes | 10:50 |
| bauzas | it loosely fails | 10:50 |
| bauzas | weirdo | 10:51 |
| bauzas | asked for a recheck b/c I don't understand it a single shit | 10:51 |
| lyarwood | you might need to hardcode the basepython version if you're on Fedora FWIW | 10:51 |
| lyarwood | otherwise it's going to try to use py39 | 10:51 |
| lyarwood | that's likely going to break random stuff in that env | 10:52 |
| lyarwood | tbh I assume your issue is with mock==3.0.0 | 10:53 |
| bauzas | yup | 10:53 |
| lyarwood | try mock.Mock(spec=client.Client)? | 10:53 |
| lyarwood | but yeah I don't get how auto_spec wouldn't work | 10:53 |
| lyarwood | create_autospec* even | 10:54 |
| bauzas | will try, need to lunch | 10:54 |
| bauzas | lyarwood: thanks | 10:54 |
| bauzas | lyarwood: the fun is that I wrote tests for both segments and networks, and they're both using autospec | 10:55 |
| bauzas | but it only fails for networks, not subnets | 10:56 |
| bauzas | so it looks to me unrelated | 10:56 |
| *** prometheanfire has joined #openstack-nova | 11:02 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Mock the os-brick connector within base.ServersTestBase https://review.opendev.org/c/openstack/nova/+/728914 | 11:11 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: tox: Add passenv DISABLE_CHERRY_PICK_CHECK to pep8 https://review.opendev.org/c/openstack/nova/+/776111 | 11:26 |
| lyarwood | elod: ^ thanks btw, I think we were calling the script directly downstream somewhere so I didn't even think about the tox target | 11:27 |
| *** dviroel has joined #openstack-nova | 11:38 | |
| elod | lyarwood: oh, i see, np :) | 11:47 |
| *** ociuhandu has quit IRC | 11:53 | |
| *** k_mouza has quit IRC | 12:16 | |
| *** k_mouza has joined #openstack-nova | 12:17 | |
| gibi | bauzas: went through the routed net series. I have some comments inline but you can convince me to handle those as follow ups | 12:32 |
| gibi | bauzas: at the same time I would like to ask you to look at the last relevant QoS inteface attach patch https://review.opendev.org/c/openstack/nova/+/756530 | 12:33 |
| *** kashyap has quit IRC | 12:36 | |
| *** bbowen_ has quit IRC | 12:49 | |
| *** bbowen_ has joined #openstack-nova | 12:50 | |
| *** bbowen_ has quit IRC | 12:50 | |
| *** rcernin has joined #openstack-nova | 12:58 | |
| *** rcernin has quit IRC | 13:02 | |
| *** ratailor has quit IRC | 13:04 | |
| *** sapd1 has joined #openstack-nova | 13:20 | |
| *** bbowen has joined #openstack-nova | 13:23 | |
| *** khomesh24 has quit IRC | 13:30 | |
| *** macz_ has joined #openstack-nova | 13:41 | |
| *** macz_ has quit IRC | 13:45 | |
| *** hemanth_n has quit IRC | 13:56 | |
| stephenfin | If anyone has some spare review time, https://review.opendev.org/q/topic:%2522poison-os-uname%2522+status:open are easy test improvement patches and getting them merged will help me avoid rebasing them endlessly as I work on the secure boot patches :-D | 14:04 |
| *** xarlos has quit IRC | 14:10 | |
| *** hoonetorg has quit IRC | 14:11 | |
| *** hemna has quit IRC | 14:12 | |
| lyarwood | stephenfin: ack | 14:12 |
| lyarwood | sean-k-mooney: https://github.com/cirros-dev/cirros/issues/64 FYI, got it to work finally | 14:13 |
| *** hemna has joined #openstack-nova | 14:13 | |
| *** spatel_ has joined #openstack-nova | 14:13 | |
| sean-k-mooney | hum https://github.com/lyarwood/cirros/commit/034d2e2e3719d96c4ef14ea859af72d7b5db311f | 14:14 |
| sean-k-mooney | that really should not be needed | 14:14 |
| sean-k-mooney | it shoudl have been automatically loaded | 14:15 |
| lyarwood | it isn't even present in the image | 14:15 |
| sean-k-mooney | but if it fixes it i gues thats ok | 14:15 |
| lyarwood | that's the problem | 14:15 |
| lyarwood | that list is copied in and everything else is dropped | 14:15 |
| lyarwood | I guess that's what keeps the image so small | 14:15 |
| sean-k-mooney | oh they are usign it for that too | 14:15 |
| sean-k-mooney | i see | 14:15 |
| sean-k-mooney | so the fact we can boot at all implies its in the initramfs | 14:16 |
| lyarwood | yeah indeed | 14:16 |
| sean-k-mooney | but its not in the root filesystem | 14:16 |
| lyarwood | I couldn't work out where it was being pulled in tbh | 14:16 |
| lyarwood | likely from a prebuilt initramfs from Ubuntu or something? | 14:16 |
| sean-k-mooney | ya proably | 14:16 |
| sean-k-mooney | cool hopefully that can get merged soon ish | 14:17 |
| sean-k-mooney | you might want to flag this on #openstack-qa | 14:17 |
| sean-k-mooney | i belive one of the people that maintain cirros is on that channel | 14:17 |
| *** psachin has quit IRC | 14:18 | |
| lyarwood | yeah I can do later today | 14:18 |
| sean-k-mooney | lyarwood: if you are taking to them then it would be ice to fix https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1856387 | 14:18 |
| openstack | Launchpad bug 1856387 in linux (Ubuntu Bionic) "Freezing on boot since kernel 4.15.0-72-generic release" [High,Fix released] - Assigned to You-Sheng Yang (vicamo) | 14:18 |
| sean-k-mooney | the current currenle they use is missing the backport | 14:19 |
| sean-k-mooney | *current kernel | 14:19 |
| *** lpetrut has joined #openstack-nova | 14:20 | |
| sean-k-mooney | i tried to fix this in devstack https://review.opendev.org/c/openstack/devstack/+/766079 and nova https://review.opendev.org/q/topic:%22workaround-disable-apic%22+(status:open%20OR%20status:merged) | 14:20 |
| sean-k-mooney | but was told it would be fixed in cirros | 14:20 |
| sean-k-mooney | so it woudl be good to confirm that is fixed. | 14:20 |
| sean-k-mooney | if they are rebuilding the image | 14:21 |
| *** spatel_ has quit IRC | 14:22 | |
| lyarwood | kk | 14:23 |
| *** spatel has joined #openstack-nova | 14:28 | |
| frickler | lyarwood: sean-k-mooney: best discuss in #cirros with smoser directly | 14:30 |
| sean-k-mooney | frickler: ack, wasnt sure who was maintianing it | 14:33 |
| *** hoonetorg has joined #openstack-nova | 14:42 | |
| stephenfin | bauzas: Reviewed the routed networks series again | 14:48 |
| *** zzzeek has quit IRC | 14:49 | |
| *** zzzeek has joined #openstack-nova | 14:50 | |
| *** jhesketh has quit IRC | 14:52 | |
| *** brinzhang has quit IRC | 14:55 | |
| *** brinzhang has joined #openstack-nova | 14:55 | |
| *** brinzhang has quit IRC | 14:57 | |
| *** brinzhang has joined #openstack-nova | 14:58 | |
| *** slaweq has quit IRC | 15:00 | |
| *** ociuhandu has joined #openstack-nova | 15:01 | |
| *** slaweq has joined #openstack-nova | 15:04 | |
| *** ociuhandu has quit IRC | 15:05 | |
| *** ociuhandu has joined #openstack-nova | 15:06 | |
| *** spatel has quit IRC | 15:13 | |
| *** ociuhandu has quit IRC | 15:15 | |
| *** ociuhandu has joined #openstack-nova | 15:16 | |
| *** ociuhandu_ has joined #openstack-nova | 15:19 | |
| *** macz_ has joined #openstack-nova | 15:19 | |
| *** ociuhandu_ has quit IRC | 15:19 | |
| *** ociuhandu_ has joined #openstack-nova | 15:20 | |
| *** k_mouza has quit IRC | 15:20 | |
| *** ociuhandu has quit IRC | 15:21 | |
| *** spatel has joined #openstack-nova | 15:21 | |
| openstackgerrit | Merged openstack/nova master: Run nova-live-migration job with neutron-trunk enabled https://review.opendev.org/c/openstack/nova/+/775838 | 15:22 |
| *** macz_ has quit IRC | 15:24 | |
| *** spatel has quit IRC | 15:32 | |
| *** spatel has joined #openstack-nova | 15:35 | |
| *** spatel has quit IRC | 15:40 | |
| *** dklyle has joined #openstack-nova | 15:41 | |
| *** hemna has quit IRC | 15:41 | |
| *** hemna has joined #openstack-nova | 15:43 | |
| openstackgerrit | Merged openstack/nova master: use psycopg2 binary instead of source package https://review.opendev.org/c/openstack/nova/+/770473 | 15:44 |
| openstackgerrit | Merged openstack/nova stable/ussuri: Add upgrade check about old computes https://review.opendev.org/c/openstack/nova/+/770765 | 15:45 |
| openstackgerrit | Merged openstack/nova stable/ussuri: add functional regression test for bug #1888395 https://review.opendev.org/c/openstack/nova/+/759522 | 15:45 |
| openstack | bug 1888395 in OpenStack Compute (nova) ussuri "live migration of a vm using the single port binding work flow is broken in train as a result of the introduction of sriov live migration" [High,In progress] https://launchpad.net/bugs/1888395 - Assigned to Billy Olsen (billy-olsen) | 15:45 |
| openstackgerrit | Merged openstack/nova stable/ussuri: Set migrate_data.vifs only when using multiple port bindings https://review.opendev.org/c/openstack/nova/+/759151 | 15:45 |
| openstackgerrit | Merged openstack/nova master: tox: Add passenv DISABLE_CHERRY_PICK_CHECK to pep8 https://review.opendev.org/c/openstack/nova/+/776111 | 15:46 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/victoria: tools: Allow check-cherry-picks.sh to be disabled by an env var https://review.opendev.org/c/openstack/nova/+/766023 | 15:50 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/ussuri: tools: Allow check-cherry-picks.sh to be disabled by an env var https://review.opendev.org/c/openstack/nova/+/766024 | 15:51 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: tools: Allow check-cherry-picks.sh to be disabled by an env var https://review.opendev.org/c/openstack/nova/+/766025 | 15:52 |
| *** macz_ has joined #openstack-nova | 15:58 | |
| *** macz_ has quit IRC | 15:59 | |
| *** macz_ has joined #openstack-nova | 15:59 | |
| *** spatel has joined #openstack-nova | 16:05 | |
| *** k_mouza has joined #openstack-nova | 16:14 | |
| *** dklyle has quit IRC | 16:21 | |
| *** lpetrut has quit IRC | 16:25 | |
| *** dklyle has joined #openstack-nova | 16:29 | |
| openstackgerrit | Merged openstack/nova stable/victoria: Disallow CONF.compute.max_disk_devices_to_attach = 0 https://review.opendev.org/c/openstack/nova/+/772984 | 16:31 |
| *** hemna has quit IRC | 16:31 | |
| *** hemna has joined #openstack-nova | 16:32 | |
| *** slaweq has quit IRC | 16:53 | |
| *** rcernin has joined #openstack-nova | 16:58 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: libvirt: Define and emit DeviceRemovedEvent and DeviceRemovalFailedEvent https://review.opendev.org/c/openstack/nova/+/749929 | 16:59 |
| *** ociuhandu_ has quit IRC | 17:02 | |
| *** rcernin has quit IRC | 17:02 | |
| *** ociuhandu has joined #openstack-nova | 17:02 | |
| *** mlavalle has joined #openstack-nova | 17:05 | |
| *** dtantsur is now known as dtantsur|afk | 17:17 | |
| openstackgerrit | Vishal Manchanda proposed openstack/nova master: Docs: Correct ``Password injection using the dashboard`` Explanation https://review.opendev.org/c/openstack/nova/+/775084 | 17:22 |
| bauzas | gibi: thanks for the review | 17:33 |
| bauzas | stephenfin: ack, will try to provide a new revision again | 17:34 |
| *** rpittau is now known as rpittau|afk | 17:41 | |
| *** gyee has joined #openstack-nova | 17:43 | |
| bauzas | stephenfin: wdym by "trailing full stop" https://review.opendev.org/c/openstack/nova/+/773976/6/nova/network/neutron.py@3500 ? | 17:46 |
| stephenfin | just add a full stop at the end of the sentence :) | 17:46 |
| stephenfin | you had it elsewhere | 17:46 |
| bauzas | a dot ? | 17:47 |
| bauzas | OK, can do | 17:47 |
| stephenfin | oh, a period | 17:47 |
| stephenfin | British English | 17:47 |
| stephenfin | yeah | 17:47 |
| bauzas | oh maaaaaan | 17:47 |
| bauzas | artom: how quebecian folks name the end of a phrase ? "un point", right? | 17:47 |
| * bauzas doesn' know why US English is so freaking different from British English (or the other way) | 17:48 | |
| sean-k-mooney | or a "full stop" | 17:49 |
| sean-k-mooney | oh that what you said first | 17:49 |
| sean-k-mooney | bauzas: why is frech frech so differnt for canadian french | 17:50 |
| sean-k-mooney | also stephenfin and i technically speak https://en.wikipedia.org/wiki/Hiberno-English more of the time | 17:50 |
| bauzas | sean-k-mooney: we name it the same AFAIK :p it's "un point" | 17:50 |
| sean-k-mooney | well a decimal point and period/full stop are two different things | 17:51 |
| bauzas | sean-k-mooney: b/c you folks are enough crazy to use a dot for decimal numbers | 17:52 |
| bauzas | sean-k-mooney: we rather use commas | 17:52 |
| sean-k-mooney | we call it a point if its its mid way in a charter and a fullstop or period if its on the base of the charter | 17:52 |
| sean-k-mooney | bauzas: well we call it a decimal point | 17:52 |
| bauzas | like, I'd be happy to pay you 10,000€ in my language | 17:52 |
| bauzas | it's more or less the amount of a pint of beer in Paris | 17:53 |
| sean-k-mooney | would that not be 10 euro in your defintion | 17:53 |
| bauzas | indeed ;) | 17:53 |
| bauzas | 10.000,00€ in my language is ten thousand euros and zero cts | 17:53 |
| sean-k-mooney | also we put the € first so €10,000 is ten thousand euros | 17:54 |
| bauzas | we use dots for thousands | 17:54 |
| *** ociuhandu has quit IRC | 17:54 | |
| bauzas | and commas for decimals | 17:54 |
| *** ralonsoh has quit IRC | 17:54 | |
| sean-k-mooney | yep we use , for thosand seperate and . for decimal point | 17:54 |
| bauzas | you can't imagine how Excels is f**** lots of Frenchs :p | 17:54 |
| sean-k-mooney | although . is techncally not a desimal point but i cant type it in this font | 17:55 |
| sean-k-mooney | most indian languages also dont group by 3 digts | 17:56 |
| sean-k-mooney | · is a descimal point . is a full stop | 17:57 |
| * bauzas now got a headache | 17:58 | |
| sean-k-mooney | no one make that distinction unless they are writing by hand however and even then many done bother anymore | 17:58 |
| bauzas | I even don't know how to set a decimal point on my french keyboard | 17:58 |
| bauzas | I only have full stops | 17:59 |
| sean-k-mooney | you normally cant even on a iso or ansi one | 17:59 |
| bauzas | \o/ | 17:59 |
| bauzas | even your own keyboards don't respect your language, lovely | 17:59 |
| sean-k-mooney | tecnically the on the number pad should be · | 17:59 |
| sean-k-mooney | not . | 17:59 |
| bauzas | anyway | 17:59 |
| sean-k-mooney | its like the fact taht the - on the number pad is different to the one on the number line | 18:00 |
| sean-k-mooney | but many things treat them the same | 18:00 |
| bauzas | gibi: stephenfin: thanks to you, I have to dig into PEP484 to find how to say as type hint result : "it's a bool or None" | 18:00 |
| sean-k-mooney | which is why word always breadk linux command by changing it | 18:00 |
| stephenfin | bauzas: ty.Optional[bool] | 18:00 |
| bauzas | gibi: stephenfin: the whole reason why I hate mypy, it overcomplicates things | 18:00 |
| bauzas | stephenfin: just saw it | 18:00 |
| sean-k-mooney | bauzas: we can agreee to disagree on that :) | 18:01 |
| stephenfin | yeah :) | 18:01 |
| bauzas | https://www.python.org/dev/peps/pep-0484/ is my new bed book | 18:01 |
| openstackgerrit | Jessie Lass proposed openstack/nova master: Add emulation support if host arch != guest arch. https://review.opendev.org/c/openstack/nova/+/772156 | 18:02 |
| bauzas | stephenfin: question, don't you feel we duplicate information between docstrings and type hints ? | 18:04 |
| bauzas | of course, we will miss static type checking with docstrings | 18:04 |
| bauzas | but from a reviewer perspective, this is the exact same metadata | 18:05 |
| sean-k-mooney | bauzas: yes but i would prefer to delete the doc sting if i had to choose | 18:05 |
| stephenfin | gibi already said as much in a review. mypy is for types information, docstring are for context | 18:05 |
| sean-k-mooney | i never really like having the parmaters in the doc stings. they always just felt like a hack due to a lack of typing | 18:06 |
| bauzas | sean-k-mooney: if the API docs are autogenerated based on type hints, I could imagine it | 18:06 |
| stephenfin | that could be done quite easily with Sphinx | 18:06 |
| bauzas | I know | 18:06 |
| stephenfin | except we don't publish API docs so it's a moot point | 18:06 |
| bauzas | is it done already ? | 18:06 |
| stephenfin | it might well be. I haven't looked | 18:06 |
| bauzas | stephenfin: well, we don't publish them, but you can introspect them | 18:06 |
| sean-k-mooney | stephenfin: well we have the api ref | 18:06 |
| bauzas | yuuuuuuuuuup | 18:06 |
| sean-k-mooney | https://docs.openstack.org/api-ref/compute/ | 18:06 |
| sean-k-mooney | is that not the api docs | 18:07 |
| bauzas | and some methods are documented | 18:07 |
| stephenfin | sean-k-mooney: nah, I meant the Python API | 18:07 |
| sean-k-mooney | i use those daylie more then any other docs bar maybe https://docs.openstack.org/nova/latest/configuration/config.html | 18:07 |
| stephenfin | i.e. https://docs.openstack.org/oslo.config/latest/reference/api/modules.html | 18:07 |
| stephenfin | we don't need that since we're not an API | 18:07 |
| sean-k-mooney | stephenfin: oh like you would do with doxigen | 18:07 |
| stephenfin | *a library | 18:07 |
| stephenfin | yeah | 18:08 |
| sean-k-mooney | to have module docs | 18:08 |
| stephenfin | bauzas: you can introspect the type hints too | 18:08 |
| sean-k-mooney | yep and docs string can then just document the function not the types | 18:08 |
| sean-k-mooney | e.g. what it sment to do and if there are any preconditions/post conditions | 18:09 |
| stephenfin | yeah, the "meaning" of the parameters | 18:10 |
| sean-k-mooney | anyway i feel like i shoudl get some work done today so i better go do that :) | 18:11 |
| *** derekh has quit IRC | 18:11 | |
| bauzas | OH MAAAAAAAN | 18:12 |
| bauzas | I eventually found why lower-constraints job is failing | 18:13 |
| bauzas | /o\ | 18:13 |
| bauzas | stephenfin: we can't call neutron_client.list_segments() as you proposed | 18:13 |
| bauzas | because the oldest neutron client we support doesn't have it | 18:14 |
| stephenfin | just bump neutronclient? | 18:14 |
| * bauzas kisses it | 18:14 | |
| *** k_mouza has quit IRC | 18:14 | |
| sean-k-mooney | well that is why having lower constratins is still valuable | 18:14 |
| bauzas | stephenfin: with this change ? woah | 18:14 |
| bauzas | sean-k-mooney: yeah, I kiss this job | 18:14 |
| sean-k-mooney | even if we only list our direct dependcies | 18:14 |
| bauzas | because it showed a potential issue | 18:14 |
| sean-k-mooney | yep | 18:14 |
| stephenfin | bauzas: Then rebase your work on top of https://review.opendev.org/c/openstack/nova/+/706295 :) | 18:15 |
| bauzas | sean-k-mooney: stephenfin: you guys okay with bumping the neutron client for such purpose ? | 18:15 |
| stephenfin | that'll do the bump for you | 18:15 |
| stephenfin | yup, no issues from me | 18:15 |
| sean-k-mooney | bauzas: the alterneive might be to use the sdk but if neutron client did not have it id ont think the sdk will | 18:15 |
| stephenfin | nah, let's not complicate things further. neutronclient works fine | 18:15 |
| sean-k-mooney | am how big a bump | 18:16 |
| sean-k-mooney | i think yes | 18:16 |
| sean-k-mooney | espcally if our current min is quite old | 18:16 |
| artom | bauzas, sorry, 1:1. Oui, c'est un point. | 18:16 |
| stephenfin | bauzas: If you've a choice, can you choose 7.1.0 to avoid conflicts with https://review.opendev.org/c/openstack/nova/+/706295 please | 18:16 |
| bauzas | sean-k-mooney: stephenfin: yeah, will then bump neutronclient to 7.1.0 to avoid the conflict | 18:16 |
| bauzas | hope that gibi will be happy too | 18:17 |
| stephenfin | ta | 18:17 |
| sean-k-mooney | oph i shoudl review https://review.opendev.org/c/openstack/nova/+/706295 | 18:17 |
| sean-k-mooney | i did not know you were doing that | 18:17 |
| sean-k-mooney | why are you doing that by the way | 18:17 |
| sean-k-mooney | is it needed for something | 18:17 |
| sean-k-mooney | or just because | 18:17 |
| stephenfin | it's less confusing IMO. I don't think we should reinvent the wheel | 18:18 |
| sean-k-mooney | going form ksa back to neutron client is a regression though | 18:18 |
| stephenfin | if there's a client that does things for us, let's delegate to them | 18:18 |
| sean-k-mooney | we should be movign to the sdk | 18:18 |
| sean-k-mooney | using ksa was a step on that move | 18:19 |
| stephenfin | Maybe a sideways step more so than a regression, I think | 18:19 |
| stephenfin | Nah, it was because neutronclient didn't support the thing | 18:19 |
| sean-k-mooney | well it ws converted from neutorn client to ksa at somepoint i think | 18:19 |
| stephenfin | Nope | 18:19 |
| stephenfin | I added the feature to neutronclient. It didn't exist before :) | 18:19 |
| sean-k-mooney | ok well using neutorn clinet more feels liek a regression since eventually we want to remove it | 18:20 |
| stephenfin | Also, moving to sdk is a _lot_ of work. We saw that with the ironic series previously | 18:20 |
| sean-k-mooney | we still use the ironic clinet in places | 18:20 |
| stephenfin | My point exactly :) | 18:20 |
| sean-k-mooney | that was never finsihed | 18:20 |
| stephenfin | Wouldn't the ksa calls be replaced by sdk also? | 18:20 |
| sean-k-mooney | yes | 18:20 |
| stephenfin | Right, so neutronclient gets us simpler code for now, and when we switch we're replacing one thing rather than two | 18:21 |
| *** sapd1 has quit IRC | 18:21 | |
| sean-k-mooney | but move backward | 18:21 |
| sean-k-mooney | it would be better to go striat form ksa to sdk | 18:21 |
| stephenfin | I don't see why though. neutronclient is actively supported | 18:21 |
| stephenfin | I mean, I realise that one client to rule them all is better in the long run | 18:22 |
| sean-k-mooney | well this isnt an osc thng | 18:22 |
| stephenfin | one library so | 18:22 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: Regression test https://review.opendev.org/c/openstack/nova/+/776250 | 18:22 |
| sean-k-mooney | its related | 18:22 |
| sean-k-mooney | ya its a libvary that is not ment to be used by any project outside of openstack | 18:22 |
| stephenfin | I don't get why neutronclient is worse than a homemade ksa invocation | 18:22 |
| sean-k-mooney | but enven then we wanted ot encurage the project to stop using them | 18:23 |
| stephenfin | eh, yes and no | 18:23 |
| *** slaweq has joined #openstack-nova | 18:23 | |
| stephenfin | we want to drop use of the project specific CLIs | 18:23 |
| sean-k-mooney | i just dont see why we would bother changin it when it snot broken if we are not going to change it to sdk since that what we want to use long term | 18:23 |
| sean-k-mooney | stephenfin: we want to drop novaclint as a lib too eventually | 18:24 |
| sean-k-mooney | not just as a cli | 18:24 |
| stephenfin | because the SDK change could be 5 years off, and that ksa change and the related code it needs is there now | 18:24 |
| sean-k-mooney | it does not have to be monoltic | 18:24 |
| sean-k-mooney | we have sdk usage already | 18:24 |
| stephenfin | not for neutron though | 18:25 |
| *** spatel has quit IRC | 18:25 | |
| sean-k-mooney | sure but lets add it incrementally | 18:25 |
| stephenfin | eh, idk. While that changeover happens everything is worse and more confusing that it was previously | 18:26 |
| stephenfin | including things like the NeutronFixture | 18:26 |
| sean-k-mooney | well this more or less hould be nitten form mos of nova | 18:26 |
| stephenfin | this makes my life easier, with far less effort than switching to sdk does | 18:26 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: libvirt: start tracking NUMACell.socket for hosts https://review.opendev.org/c/openstack/nova/+/766816 | 18:27 |
| stephenfin | huh? | 18:27 |
| sean-k-mooney | the nova/network/neutorn module will hide that form the rest of nova | 18:27 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: extra specs/image props: add `socket` PCI NUMA affinity https://review.opendev.org/c/openstack/nova/+/772748 | 18:27 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Add `socket` PCI NUMA affinity policy request prefilter https://review.opendev.org/c/openstack/nova/+/772749 | 18:27 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Track host NUMA topology in PCI manager https://review.opendev.org/c/openstack/nova/+/774149 | 18:27 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: pci: implement the `socket` NUMA affinity policy https://review.opendev.org/c/openstack/nova/+/772779 | 18:27 |
| stephenfin | sean-k-mooney: If you do look at the patch, ignore the fact that it's using neutronclient for a bit and tell me it doesn't make e.g. the NeutronFixture easier to grok | 18:28 |
| stephenfin | that's where I'm coming from | 18:28 |
| stephenfin | I'll do the sdk work eventually, once the OSC gaps are closed, but I think this is a win for now | 18:28 |
| sean-k-mooney | well it not going to change the public api of that module so im not sure it will | 18:29 |
| sean-k-mooney | im looking at it now | 18:29 |
| sean-k-mooney | but the frecatorign you are ding im not sure require the code changes | 18:30 |
| sean-k-mooney | none of those private api shoudl be needed in the generic neutron fixture https://review.opendev.org/c/openstack/nova/+/706295/10/nova/tests/fixtures.py#b1769 | 18:31 |
| sean-k-mooney | they should not be called outside the neutron moduule | 18:32 |
| sean-k-mooney | only the public funtion will be | 18:32 |
| stephenfin | They're called inside the neutron module | 18:33 |
| *** andrewbonney has quit IRC | 18:33 | |
| sean-k-mooney | yep which can stub them in its own unit tests | 18:33 |
| stephenfin | NeutronFixture is weird. It mocks APIs from both neutronclient and nova.network.neutron | 18:33 |
| sean-k-mooney | ya | 18:33 |
| sean-k-mooney | i then to use the libvirt version of it too at least when wriging func test | 18:34 |
| stephenfin | no, it we don't stub them out then we need to provide an entire mock of e.g. 'bind_ports_to_host' | 18:34 |
| sean-k-mooney | there is value in this yes | 18:34 |
| sean-k-mooney | well we proably shoudl do htat since we need it for live migration right | 18:34 |
| stephenfin | well we do | 18:35 |
| stephenfin | by mocking out the private APIs it calls | 18:35 |
| stephenfin | that API is the glue. We don't want to mock that out | 18:35 |
| stephenfin | but we do want to mock out the neutron API calls | 18:35 |
| stephenfin | I said above that the fixture is weird because it mocks APIs from both neutronclient and nova.network.neutron | 18:36 |
| sean-k-mooney | yes which is what it was doing before | 18:36 |
| stephenfin | but it really shouldn't be doing that. The reason it has to is because we're providing our own neutronclient implementation of sorts using KSA | 18:36 |
| stephenfin | so it has to mock those | 18:36 |
| stephenfin | things like _create_port_binding | 18:36 |
| stephenfin | which, I'll note, is also what neutronclient uses now that I look at it | 18:37 |
| sean-k-mooney | im surpised that has actully been added to neutronclint | 18:37 |
| sean-k-mooney | it was ment to back in rocky but never happened | 18:37 |
| sean-k-mooney | i cant argue that its not shorter | 18:38 |
| sean-k-mooney | and it appear to more or less be functional | 18:38 |
| stephenfin | yeah, I added it because the ksa stuff confused me | 18:39 |
| stephenfin | What's the easiest thing to do if something confuses you? Delete it! | 18:39 |
| stephenfin | :) | 18:39 |
| sean-k-mooney | well the reason i brougt this up is i am concerned by what it might conflict with | 18:39 |
| sean-k-mooney | in terms of backports | 18:39 |
| sean-k-mooney | stephenfin: it conclitc with https://review.opendev.org/c/openstack/nova/+/653506 | 18:40 |
| sean-k-mooney | whcih we partly fixed a different way but we proably shoudl stil merge this | 18:41 |
| stephenfin | It's easy to rework these things and we bring them back | 18:41 |
| stephenfin | no different to using f-strings in code, surely? :) | 18:41 |
| stephenfin | see what I did there? | 18:41 |
| sean-k-mooney | readding ksa is alot harder | 18:42 |
| sean-k-mooney | i guess on hte backport it will already be there | 18:43 |
| sean-k-mooney | and if the neutron client fucntio you are using is not supprot by the older version of neutron clinet on the stable branch you would have to use ksa anyway | 18:43 |
| stephenfin | yeah, unfortunately so. We can't bump deps either | 18:43 |
| stephenfin | Anyhow, /me really needs to get to the gym | 18:44 |
| stephenfin | (home gym, sadly) | 18:44 |
| stephenfin | o/ | 18:44 |
| sean-k-mooney | i guess we can proceed with thsi but i feel somewhat blind sided by it | 18:44 |
| sean-k-mooney | i just wasnt expecting you to be reworking that | 18:44 |
| sean-k-mooney | enjoy o/ | 18:44 |
| *** jangutter has joined #openstack-nova | 19:02 | |
| *** jangutter_ has quit IRC | 19:06 | |
| *** belmoreira has quit IRC | 19:08 | |
| *** slaweq has quit IRC | 19:20 | |
| *** luksky has quit IRC | 19:51 | |
| *** luksky has joined #openstack-nova | 19:52 | |
| *** elod has quit IRC | 20:17 | |
| *** elod has joined #openstack-nova | 20:19 | |
| *** xek has quit IRC | 20:27 | |
| *** belmoreira has joined #openstack-nova | 20:30 | |
| *** xek has joined #openstack-nova | 20:31 | |
| *** spatel has joined #openstack-nova | 20:33 | |
| *** xek has quit IRC | 20:37 | |
| *** xek has joined #openstack-nova | 20:37 | |
| *** xek has quit IRC | 20:41 | |
| *** xek has joined #openstack-nova | 20:42 | |
| *** xek has quit IRC | 20:44 | |
| *** slaweq has joined #openstack-nova | 20:46 | |
| *** rcernin has joined #openstack-nova | 20:58 | |
| *** rcernin has quit IRC | 21:03 | |
| *** belmoreira has quit IRC | 21:09 | |
| *** belmoreira has joined #openstack-nova | 21:13 | |
| *** rcernin has joined #openstack-nova | 21:22 | |
| *** vishalmanchanda has quit IRC | 21:37 | |
| *** belmoreira has quit IRC | 21:37 | |
| *** belmoreira has joined #openstack-nova | 21:38 | |
| *** eandersson has quit IRC | 21:40 | |
| *** ccstone has quit IRC | 21:40 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Add regression test for bug 1914777 https://review.opendev.org/c/openstack/nova/+/775307 | 21:45 |
| openstack | bug 1914777 in OpenStack Compute (nova) "Possible race condition between n-cpu and n-api when deleting a building instance" [High,In progress] https://launchpad.net/bugs/1914777 - Assigned to melanie witt (melwitt) | 21:45 |
| openstackgerrit | melanie witt proposed openstack/nova master: Handle instance = None in _local_delete_cleanup https://review.opendev.org/c/openstack/nova/+/775308 | 21:45 |
| *** hoonetorg has quit IRC | 21:49 | |
| *** gmann is now known as gmann_afk | 21:51 | |
| *** rcernin has quit IRC | 21:53 | |
| *** rcernin has joined #openstack-nova | 22:00 | |
| *** slaweq has quit IRC | 22:02 | |
| *** zoharm has quit IRC | 22:02 | |
| *** whoami-rajat__ has quit IRC | 22:09 | |
| *** belmoreira has quit IRC | 22:17 | |
| *** belmoreira has joined #openstack-nova | 22:19 | |
| *** jhesketh has joined #openstack-nova | 22:32 | |
| openstackgerrit | Belmiro Moreira proposed openstack/nova master: Change API unexpected exception message https://review.opendev.org/c/openstack/nova/+/628061 | 22:35 |
| *** belmoreira has quit IRC | 22:42 | |
| *** spatel has quit IRC | 23:03 | |
| *** gmann_afk is now known as gmann | 23:22 | |
| *** prometheanfire has quit IRC | 23:27 | |
| *** prometheanfire has joined #openstack-nova | 23:51 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!