Tuesday, 2021-02-23

« Monday, 2021-02-22 Index Wednesday, 2021-02-24 »
*** brinzhang has joined #openstack-nova00:14
*** tosky has quit IRC00:38
*** macz_ has quit IRC00:54
*** _mlavalle_1 has quit IRC00:59
*** __ministry has joined #openstack-nova01:21
*** hamalq has quit IRC01:26
*** benj_ has quit IRC01:53
*** benj_ has joined #openstack-nova01:54
*** spatel has joined #openstack-nova02:23
*** LinPeiWen has joined #openstack-nova02:25
*** spatel has quit IRC03:01
*** spatel has joined #openstack-nova03:04
*** mkrai has joined #openstack-nova03:14
*** ricolin has quit IRC03:15
*** ricolin has joined #openstack-nova03:30
*** mkrai has quit IRC03:35
*** mkrai_ has joined #openstack-nova03:35
*** psachin has joined #openstack-nova03:36
*** macz_ has joined #openstack-nova03:43
*** macz_ has quit IRC03:47
*** khomesh24 has joined #openstack-nova04:14
*** macz_ has joined #openstack-nova04:24
*** martinkennelly has quit IRC04:29
*** macz_ has quit IRC04:29
*** __ministry has quit IRC04:45
*** ratailor has joined #openstack-nova04:46
*** __ministry has joined #openstack-nova04:47
*** mkrai_ has quit IRC04:55
*** mkrai has joined #openstack-nova05:08
*** rcernin has quit IRC05:15
*** rcernin has joined #openstack-nova05:22
*** macz_ has joined #openstack-nova05:24
*** macz_ has quit IRC05:29
*** macz_ has joined #openstack-nova05:45
*** macz_ has quit IRC05:49
*** gyee has quit IRC06:12
*** LinPeiWen has quit IRC06:18
*** vishalmanchanda has joined #openstack-nova06:25
*** xek has joined #openstack-nova06:29
*** spatel has quit IRC06:35
*** LinPeiWen has joined #openstack-nova06:43
*** zzzeek has quit IRC06:45
*** zzzeek has joined #openstack-nova06:46
*** slaweq_ has joined #openstack-nova06:50
openstackgerritLucian Petrut proposed openstack/nova master: hyper-v rbd volume support  https://review.opendev.org/c/openstack/nova/+/76355007:03
*** brinzhang has quit IRC07:13
*** rcernin has quit IRC07:15
*** mkrai has quit IRC07:18
*** ralonsoh has joined #openstack-nova07:21
*** nightmare_unreal has joined #openstack-nova07:27
*** smcginnis has quit IRC07:30
*** smcginnis has joined #openstack-nova07:30
*** hoonetorg has quit IRC07:38
*** zzzeek has quit IRC07:39
*** zzzeek has joined #openstack-nova07:40
openstackgerritYongli He proposed openstack/nova master: Smartnic support - cyborg drive  https://review.opendev.org/c/openstack/nova/+/77136207:48
openstackgerritYongli He proposed openstack/nova master: smartnic support - new vnic type  https://review.opendev.org/c/openstack/nova/+/77136307:48
openstackgerritYongli He proposed openstack/nova master: smartnic support  https://review.opendev.org/c/openstack/nova/+/75894407:48
*** rcernin has joined #openstack-nova07:49
*** dklyle has quit IRC07:57
*** mkrai has joined #openstack-nova07:57
*** rcernin has quit IRC08:06
*** andrewbonney has joined #openstack-nova08:06
*** rcernin has joined #openstack-nova08:09
*** luksky has quit IRC08:17
*** tesseract has joined #openstack-nova08:20
*** macz_ has joined #openstack-nova08:22
*** rcernin has quit IRC08:23
*** macz_ has quit IRC08:26
*** rpittau|afk is now known as rpittau08:28
*** luksky has joined #openstack-nova08:29
*** zoharm has joined #openstack-nova08:30
*** luksky has quit IRC08:49
*** tosky has joined #openstack-nova08:50
*** ociuhandu has joined #openstack-nova08:59
openstackgerritBrin Zhang proposed openstack/nova master: Nova supports password encrypted VNC  https://review.opendev.org/c/openstack/nova/+/62233609:02
openstackgerritBrin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List/Update Servers APIs  https://review.opendev.org/c/openstack/nova/+/76429209:02
openstackgerritBrin Zhang proposed openstack/nova master: Replace all_tenants with all_projects in List Server APIs  https://review.opendev.org/c/openstack/nova/+/76531109:02
openstackgerritBrin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from Rebuild Server API  https://review.opendev.org/c/openstack/nova/+/76638009:02
*** luksky has joined #openstack-nova09:02
openstackgerritBrin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List SG API  https://review.opendev.org/c/openstack/nova/+/76672609:02
*** ociuhandu has quit IRC09:04
openstackgerritBrin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from Flavor Access APIs  https://review.opendev.org/c/openstack/nova/+/76770409:09
*** psachin has quit IRC09:11
*** martinkennelly has joined #openstack-nova09:11
*** ociuhandu has joined #openstack-nova09:12
openstackgerritBrin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List/Show usage APIs  https://review.opendev.org/c/openstack/nova/+/76850909:12
openstackgerritBrin Zhang proposed openstack/nova master: Replace tenants* with projects* of policies  https://review.opendev.org/c/openstack/nova/+/76531509:13
*** LinPeiWen has quit IRC09:16
*** ociuhandu has quit IRC09:24
*** ociuhandu has joined #openstack-nova09:24
*** noonedeadpunk has quit IRC09:26
*** bauzas has quit IRC09:26
*** bauzas has joined #openstack-nova09:27
*** k_mouza has joined #openstack-nova09:27
*** ociuhandu has quit IRC09:28
*** ociuhandu has joined #openstack-nova09:28
*** noonedeadpunk has joined #openstack-nova09:29
*** lpetrut has joined #openstack-nova09:35
*** slaweq_ is now known as slaweq09:40
*** tesseract has quit IRC09:44
*** tesseract has joined #openstack-nova09:47
*** macz_ has joined #openstack-nova09:50
*** derekh has joined #openstack-nova09:51
slaweqgibi: hi, did You saw errors like https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_4f9/777015/1/check/neutron-tempest-multinode-full-py3/4f9f062/testr_results.html already?09:51
slaweqI saw it at least twice in last few days09:51
slaweqin same test09:51
slaweqdo You want me to report new bug for that?09:52
*** macz_ has quit IRC09:54
*** LinPeiWen has joined #openstack-nova10:19
openstackgerritLucas Alvares Gomes proposed openstack/nova master: [OVN] Explicitly set nova-next job to ML2/OVS  https://review.opendev.org/c/openstack/nova/+/77694410:25
openstackgerritLucas Alvares Gomes proposed openstack/nova master: DO NOT REVIEW: Test OVN devstack module  https://review.opendev.org/c/openstack/nova/+/77694510:25
gibislaweq: hi, let me check it10:32
gibislaweq: I see 6 failures in the last 7 days10:36
gibihttp://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22tempest.api.compute.servers.test_delete_server.DeleteServersTestJSON.test_delete_server_while_in_building_state%5C%22%20AND%20message%3A%5C%22FAILED%5C%2210:36
slaweqgibi: do You want me to open LP for that?10:37
gibislaweq: I will check the logs first then I can open an LP. thanks for notifying us10:38
slaweqgibi: thank You10:38
gibiit happens outside of neutron jobs too10:38
*** jangutter_ has quit IRC10:40
*** jangutter has joined #openstack-nova10:40
*** ociuhandu has quit IRC10:45
*** ociuhandu has joined #openstack-nova10:46
gibislaweq: reported https://bugs.launchpad.net/nova/+bug/191658810:47
openstackLaunchpad bug 1916588 in OpenStack Compute (nova) "Delete instance in build state result in HTTP 500: nova.exception.ConstraintNotMet: Constraint not met." [Undecided,New]10:47
slaweqgibi++ thx10:47
*** ociuhandu has quit IRC10:47
*** ociuhandu has joined #openstack-nova10:47
*** k_mouza has quit IRC10:49
*** mkrai has quit IRC10:57
*** k_mouza has joined #openstack-nova10:59
*** rpittau is now known as rpittau|bbl11:00
*** iurygregory_ has joined #openstack-nova11:00
*** iurygregory has quit IRC11:01
*** dtantsur|afk is now known as dtantsur11:03
*** iurygregory_ is now known as iurygregory11:06
*** Luzi has joined #openstack-nova11:13
*** smcginnis has quit IRC11:19
*** __ministry has quit IRC11:24
gibislaweq: it turned out it is a duplicate of https://bugs.launchpad.net/nova/+bug/191477711:26
openstackLaunchpad bug 1914777 in OpenStack Compute (nova) "Possible race condition between n-cpu and n-api when deleting a building instance" [High,In progress] - Assigned to melanie witt (melwitt)11:26
*** smcginnis has joined #openstack-nova11:26
*** belmoreira has joined #openstack-nova11:30
gibislaweq: I've just approved the fix for it https://review.opendev.org/c/openstack/nova/+/77530811:30
slaweqgibi++ thx a lot11:34
*** nightmare_unreal has quit IRC11:37
*** ociuhandu has quit IRC11:40
openstackgerritBrin Zhang proposed openstack/nova master: Replace os-simple-tenant-usage with os-simple-project-usage  https://review.opendev.org/c/openstack/nova/+/76885211:43
*** brinzhang has joined #openstack-nova11:43
openstackgerritBrin Zhang proposed openstack/nova master: Replace tenant_id with project_id in os-quota-sets path  https://review.opendev.org/c/openstack/nova/+/76885111:43
openstackgerritBrin Zhang proposed openstack/nova master: Replace tenant_id with project_id in Limits API  https://review.opendev.org/c/openstack/nova/+/76886211:43
openstackgerritBrin Zhang proposed openstack/nova master: Replace tenant* with project* in codes  https://review.opendev.org/c/openstack/nova/+/76932911:43
*** brinzhang has quit IRC11:45
*** ociuhandu has joined #openstack-nova11:56
*** smcginnis has quit IRC12:01
*** ociuhandu has quit IRC12:01
*** ratailor has quit IRC12:04
*** smcginnis has joined #openstack-nova12:07
*** ociuhandu has joined #openstack-nova12:11
*** ociuhandu has quit IRC12:16
*** LinPeiWen has quit IRC12:23
*** nightmare_unreal has joined #openstack-nova12:26
*** zenkuro has quit IRC12:26
*** zenkuro has joined #openstack-nova12:28
*** ociuhandu has joined #openstack-nova12:29
*** ociuhandu has quit IRC12:42
*** zenkuro has quit IRC12:51
*** zenkuro has joined #openstack-nova12:52
openstackgerritVishal Manchanda proposed openstack/nova master: Docs: Correct ``Password injection using the dashboard`` Explanation  https://review.opendev.org/c/openstack/nova/+/77508412:59
*** rpittau|bbl is now known as rpittau13:01
*** macz_ has joined #openstack-nova13:14
*** macz_ has quit IRC13:18
*** ociuhandu has joined #openstack-nova13:35
*** tbachman has quit IRC13:35
*** tbachman has joined #openstack-nova13:36
*** ociuhandu has quit IRC13:39
*** ociuhandu has joined #openstack-nova13:40
*** ociuhandu has quit IRC13:40
*** ociuhandu has joined #openstack-nova13:42
*** zimmerry has quit IRC13:43
*** tbachman has quit IRC13:43
*** tbachman has joined #openstack-nova13:46
*** ociuhandu has quit IRC13:49
*** ociuhandu has joined #openstack-nova13:53
*** jangutter_ has joined #openstack-nova13:54
*** ociuhandu has quit IRC13:57
*** ociuhandu has joined #openstack-nova13:57
*** spatel has joined #openstack-nova13:57
*** jangutter has quit IRC13:58
*** mlavalle has joined #openstack-nova13:58
*** zimmerry has joined #openstack-nova14:02
openstackgerritBalazs Gibizer proposed openstack/nova master: Follow up for QoS interface attach  https://review.opendev.org/c/openstack/nova/+/77711214:04
gibibauzas, stephenfin: a small fup for QoS based on your comments ^^14:05
*** haleyb has quit IRC14:07
bauzasgibi: ack14:08
* bauzas clicks14:08
bauzastoday is a review day for me14:08
*** haleyb has joined #openstack-nova14:09
bauzasgibi: question14:15
bauzasgibi: when you mention the audit command in the exception, do we raise it to the user ?14:15
bauzasgibi: /me looks at whether we have a sync call for attaching14:16
gibiattach is synch14:16
bauzasok, so the user will get HTTP500, right?14:16
bauzaswith the exception14:17
gibiI assume so14:17
gibilet me check it in a devstack14:17
bauzasgibi: in this case, we shouldn't be explain to use the audit command14:17
bauzasexplaining*14:17
bauzasas the user wouldn't know how to do it14:17
bauzashence my LOG concern14:18
bauzasto not pass it to the user14:18
bauzasbut if we don't, fair enough14:18
openstackgerritLucian Petrut proposed openstack/nova master: hyper-v rbd volume support  https://review.opendev.org/c/openstack/nova/+/76355014:20
gibibauzas: only the name of the exception is returned on the REST API14:24
gibihttp://paste.openstack.org/show/802931/14:24
bauzasoh shit you're right14:25
bauzasjust the first reason14:25
bauzashmmm, even not14:25
bauzaschanged my vote14:26
gibithanks14:27
gibistephenfin: do you know a way to tell mypy that a = {} is really an empty dict that will never have keys?14:27
sean-k-mooneythe presnece of keys is not an atirbute of the type14:28
sean-k-mooneyso that statement does not make sese form a type checking perspectiv14:28
bauzasa parameter being {} by default ?14:28
bauzasI hope we don't do it14:29
bauzasor maybe I misunderstood14:29
gibibauzas: nope, a singalling of a failure here https://github.com/openstack/nova/blob/8ca5d2169fc3ba5cf86f830a93cf92bae925e1f4/nova/network/neutron.py#L65014:29
gibisean-k-mooney: good point14:29
gibisean-k-mooney: but if we only have14:29
gibia = {}14:29
gibiif a:14:29
gibithen this code does not have a key type defined either14:30
sean-k-mooney thats fine14:30
sean-k-mooneyyou dont need to define a key type14:30
sean-k-mooneyyou can just use dict14:30
gibiI can assign a: ty.Dict = {}14:30
sean-k-mooneyyou can but ty.Dict is an alis for dict14:30
gibitrue14:30
gibithank14:30
gibis14:30
bauzasI don't understand the concern but meh to mypy14:31
sean-k-mooneydict is treated like ty.Dict[ty.Any,ty.Any]14:31
bauzasdefaultdict maybe ?14:31
gibisean-k-mooney: yep it is14:31
gibibauzas: if you infer types from the usage of a dict then if the dict is never used (empty) then you cannot infer a key type14:32
gibibauzas: so it is different that defaultdict14:32
bauzasah I see14:32
sean-k-mooneybauzas: gibi just wanted to be a bit more explcit about the contained types then dict of anything14:33
sean-k-mooneywhcih he can do explitcly with the : syntax14:33
bauzasthat's one of the reason why I prefer to signal an nullable variable as None14:33
sean-k-mooneywell its not really nullable14:33
*** vishalmanchanda has quit IRC14:33
gibibauzas: yes, {} and None has a different meaning14:33
gibieven if we tend to mix them14:34
sean-k-mooneythey are different types14:34
bauzassean-k-mooney: I know, I'm just saying that I prefer to have an object with a None value rather than an id and which is empty14:34
sean-k-mooneythere are pros and cons to both14:34
sean-k-mooneyusing Empty collections is generally perfered using None for literals or classes is also genereally perfered14:36
sean-k-mooneyNone tened to be used for singal values and empty collection fo correct type for aggreates14:36
*** jangutter has joined #openstack-nova14:42
*** jangutter_ has quit IRC14:45
sean-k-mooneystephenfin: it will be a while before i push anything but how do you feel about hw:mem_locked=True|False as the name of the new extra spec required for vdpa14:49
sean-k-mooneyso vdpa guest woudl need hw:mem_locked=true and hw:mem_page_size=<anything> set14:50
sean-k-mooneymem_page_size to account for no over commit and correct tracking14:50
jkulikhi, we just upgraded to rocky. is the "sync aggregates" command supposed to be usable with ironic nodes?14:50
sean-k-mooneyand locked for the the dma limiations14:50
jkulikbecause it raises an TooManyComputesForHost ... is there an official way to migrate those aggregates?14:52
*** tbachman_ has joined #openstack-nova14:57
*** tbachman has quit IRC15:01
*** tbachman_ is now known as tbachman15:01
stephenfingibi: Not a clue. That seems like an odd request15:03
gibistephenfin: I stick to dict (aka ty.Dict)15:03
gibiit works15:03
openstackgerritBalazs Gibizer proposed openstack/nova master: Turn on mypy for nova/network/neutron.py  https://review.opendev.org/c/openstack/nova/+/77714615:03
gibistephenfin, bauzas: turned on mypy for nova/network/neutron.py15:04
bauzasgibi: yeah saw it15:04
gibiI will rebase that on top of the routed net patch15:04
bauzaswill look at that and thanks for working on it15:04
openstackgerritLucas Alvares Gomes proposed openstack/nova master: [OVN] Explicitly set nova-next job to ML2/OVS  https://review.opendev.org/c/openstack/nova/+/77694415:05
openstackgerritLucas Alvares Gomes proposed openstack/nova master: DO NOT REVIEW: Test OVN devstack module  https://review.opendev.org/c/openstack/nova/+/77694515:05
sean-k-mooneyi kind of think ^ is inverted15:07
sean-k-mooneywe shoudl proably explcity set nova-next to ovn and keep the rest on ml2/ovs for now and then consider swaping to ovn on more jobs later15:07
*** Luzi has quit IRC15:15
openstackgerritBalazs Gibizer proposed openstack/nova master: Turn on mypy for nova/network/neutron.py  https://review.opendev.org/c/openstack/nova/+/77714615:16
*** dklyle has joined #openstack-nova15:16
*** lucasagomes has joined #openstack-nova15:17
gibistephenfin: I've replied in https://review.opendev.org/c/openstack/nova/+/772381/6/nova/virt/libvirt/driver.py#26315:20
*** ociuhandu has quit IRC15:20
*** ociuhandu has joined #openstack-nova15:21
stephenfinta15:24
*** ociuhandu has quit IRC15:25
*** ociuhandu has joined #openstack-nova15:29
openstackgerritBalazs Gibizer proposed openstack/nova master: Move the guest.get_disk test to test_guest  https://review.opendev.org/c/openstack/nova/+/77715115:35
*** macz_ has joined #openstack-nova15:36
lpetrutHi, about the Windows RBD patch: would you guys be ok with skipping the os-brick dependency until we sort out the lower constraints issue? https://review.opendev.org/c/openstack/nova/+/76355015:37
*** macz_ has quit IRC15:40
openstackgerritBalazs Gibizer proposed openstack/nova master: Enable mypy on libvirt/guest.py  https://review.opendev.org/c/openstack/nova/+/77715516:02
gibistephenfin: this is an interesting one ^^16:03
* stephenfin is almost sure he's a patch locally to do that too, though it might not be complete16:03
stephenfinlooking16:04
gibistephenfin: I did that as a followup for the detach bugfix series16:06
stephenfingibi++ Yup, realize that. Thanks :)16:06
stephenfinSo the unusual thing is the assertion, I assume?16:07
stephenfingibi: Is it just me, or are all those functions in the exception handlers than are accepting a 'guest' parameter broken?16:08
stephenfinIf so, I bet I was the one that broke it too. I recall reworking that stuff recently16:09
* stephenfin looks16:09
stephenfinand attempts to bury the evidence ;)16:09
gibihm, you have a point, mypy only found the last usage of gues but the expcetion handler code also depends on the guest variable16:10
*** macz_ has joined #openstack-nova16:10
gibi_cleanup_failed_start checks the guest before use it16:11
gibiso the exception handlers are good16:11
stephenfinthe guest is useless though16:11
stephenfinthere's no way a function that raises an exception can return something16:12
stephenfinso guest will either always be None or it will be set and an exception won't be raiseed16:12
stephenfin*raised16:12
stephenfinI suspect there was another caller after '_create_guest' previously16:12
stephenfinpower on or something16:12
gibihm, yeah, this can be cleaned up to only run the code that is currently in the finally block of _cleanup_failed_start16:14
stephenfinyeah, https://github.com/openstack/nova/blob/stable/train/nova/virt/libvirt/driver.py#L6351-L635216:15
stephenfinthere was stuff done after '_create_guest' (formerly '_create_domain') previously16:15
stephenfinso I suspect the real solution to that is to stop passing 'guest' to '_cleanup_failed_start' and remove any code that relied on it?16:16
stephenfinwhich is what you just said, sorry :)16:16
gibiI don't know why we try to stop the guest16:16
gibinvm I see it16:16
stephenfinwhy or where?16:17
gibiso in the past there was a case when the guest was fully started16:17
gibiand then we failed16:17
gibiso we need to stop is16:17
gibiit16:17
gibibut now it either starts without exception or fails before it is started16:17
stephenfinif the firewall driver couldn't apply filters, right?16:17
gibiyepp16:17
stephenfinyeah, that's my reading of this too16:17
stephenfinI did the firewall cleanup too but missed that. Apologies16:18
gibihm, I don't know what happens if create_guest fails at libvirt_secret.undefine() in the finally block, at that point we have a running guest I assume16:18
gibibut we don't get back the guest object from the caller16:19
gibito stop it16:19
stephenfinyeah, an exception will still be raised16:19
stephenfinthe finally block just executes stuff before the finally happens, iirc16:20
stephenfinakin to save_and_reraise16:20
gibiso we have to catch possible exceptions from libvirt_secret.undefine(), LOG them, and still return the geust object16:22
gibiguest16:23
stephenfinapparently not16:23
stephenfinhttps://docs.python.org/3/reference/compound_stmts.html#finally16:23
stephenfinIf finally is present, it specifies a ‘cleanup’ handler. The try clause is executed, including any except and else clauses. If an exception occurs in any of the clauses and is not handled, the exception is temporarily saved. The finally clause is executed. If there is a saved exception it is re-raised at the end of the finally clause. If the finally clause raises another exception, the saved exception is set as the context of16:23
stephenfinthe new exception. If the finally clause executes a return, break or continue statement, the saved exception is discarded:16:23
stephenfinSorry16:23
stephenfin If the finally clause raises another exception, the saved exception is set as the context of the new exception.16:23
stephenfinso it'll basically do raise undefine_exception from other_exception16:23
* stephenfin tests16:23
gibiyeah that is how I understand16:24
stephenfinyeah http://paste.openstack.org/show/802935/16:24
gibiif we let the exception propagate from the finally block then we will leave a running guest behind16:25
gibiand the caller cannot stop it16:25
gibias it has no reference to that guest object16:26
stephenfinHmm, good point16:26
stephenfinso if the undefine call fails16:26
stephenfinwe won't have a running guest before that since launching it is the last thing we do (returning won't cause an exception)16:27
*** jdillaman has quit IRC16:28
gibiyou are right sorry16:28
gibiso no need to change here16:29
*** lpetrut has quit IRC16:32
openstackgerritBalazs Gibizer proposed openstack/nova master: Follow up type hints for a634103  https://review.opendev.org/c/openstack/nova/+/77715916:33
*** _mlavalle_1 has joined #openstack-nova16:39
*** _mlavalle_1 has quit IRC16:41
*** mlavalle has quit IRC16:43
*** zimmerry has quit IRC16:44
bauzaswoah, the gate pipeline is late16:44
*** zoharm has quit IRC16:47
gibimaybe it is already the churn before the feature freeze16:54
stephenfinbauzas: There are issues. They were discussing it on #openstack-infra earlier16:55
stephenfinStill are, maybe16:55
bauzaskk16:55
bauzasthanks16:55
*** lucasagomes has quit IRC17:00
prometheanfirewe're coming up on the end of the release cycle and nova still hasn't fixed mock :|17:03
sean-k-mooneyprometheanfire: its not really broken is it.17:05
stephenfinprometheanfire: I thought we'd said that we didn't need to?17:05
stephenfinmock (the third party lib) has fixes that weren't backported to python3.617:06
stephenfinand I'm pretty sure the reason mock was capped at <4.0 (iirc) was because that had its own bug17:06
stephenfinprometheanfire: Can you remind me of the reason nova had to switch? I'd stopped focusing on it because working around python3.6 unittest.mock bugs seemed wrong17:07
sean-k-mooneywel should eventulaly swicht to not useing mock the lib at all17:07
sean-k-mooneyand use the standard lib only17:08
stephenfinsean-k-mooney: why17:08
sean-k-mooneybecause mock the lib has some bugs17:08
sean-k-mooneyit does not fully work the same as the stanard lib17:08
stephenfinSee above17:08
prometheanfirerequirements doesn't cap mock17:08
sean-k-mooneyand since we are pythoh 3 only now we dont need it any more17:08
stephenfinTo the best of my knowledge, it's a carbon copy of unittest.mock from the latest stable python17:08
stephenfinincluding all the new features and bugfixes found therein17:09
prometheanfireif the mock-4 releases are bad they should be masked so they don't bug me every day when the constraints bot review fails because nova doesn't work with the new mock (but other projects aparently do)17:09
stephenfinprometheanfire: I'm almost certain we're seeing the exact same issues with unittest.mock on either python3.9 or python3.1017:10
sean-k-mooneystephenfin: there was deffinlty differnt behavor in the past as code in neutorn would not work in nova17:10
stephenfinand there's an open bug against it but it hasn't gone anywhere17:10
stephenfinprometheanfire: Have you link to a failing constraints bot job?17:11
stephenfin*a link17:11
prometheanfireyep17:11
prometheanfirehttps://review.opendev.org/77696717:11
stephenfinta17:11
* stephenfin looks17:11
prometheanfirewas the previous work abandoned? switching to unittest.mock iirc17:12
stephenfinit's not abandoned in Gerrit terms, but nobody is looking at it17:12
stephenfinhttps://review.opendev.org/c/openstack/nova/+/71467617:12
sean-k-mooneythis is becasue of eventlets and py3917:12
prometheanfirewhich is why I pinged :P17:12
sean-k-mooneythe websocket proxy is broken on py3917:12
sean-k-mooneybecause of dnspython17:13
prometheanfireya, turtles17:13
sean-k-mooneywell actull its brok on 36 too17:13
sean-k-mooneyeventlest does not supprot dnspython 2.017:13
stephenfinprometheanfire: Yes, look https://review.opendev.org/c/openstack/nova/+/714676/9/nova/tests/unit/console/test_websocketproxy.py17:14
prometheanfireonly worked by accident on 3.7 and 3.8?17:14
sean-k-mooneythat websocket issue look kindo fo like the double wrappign issue17:14
prometheanfireya, magicmock17:14
stephenfinprometheanfire: To get it working with stdlib mock, we had to remove the same test that's failing there17:14
stephenfinprometheanfire: We can push a patch to master to remove that test and unblock requirements17:15
stephenfinI'll do that now17:15
sean-k-mooneystephenfin: yep this is one of the case i think where there is a delta between standard mock and mock the lib17:15
prometheanfireif you don't mind17:15
stephenfinsean-k-mooney: I'm saying unittest.mock and mock the lib are having the exact same issue :)17:15
stephenfinbecause they're the same thing17:15
prometheanfireand using mock as a lib is fine, it is one MOVING target for all python versions, vs a locked target per version of supported python17:16
prometheanfirepick your poison kinda17:16
sean-k-mooneymaybe now but again on python 2.7  it was not17:16
sean-k-mooneyanyway we shoudl proably revie https://review.opendev.org/c/openstack/nova/+/71467617:16
sean-k-mooneybut delete the current test i guess works for now17:17
atmarkis there filter can tag a set of computes to a tenant?17:17
stephenfinprometheanfire: Yeah, I was all for dropping it in e.g. oslo projects, but we obviously have way more tests than anything there and when you start looking at the amount of bugs we need to workaround on older stdlib versions it seems less attractive17:17
sean-k-mooneyatmark: yes17:18
stephenfinWe'll do it _eventually_, but it's dropped down my priority list rn (and melwitt's too, evidently)17:18
prometheanfirestephenfin: yep17:18
sean-k-mooneythere is both a post fitler and prefilter https://github.com/openstack/nova/commit/732e202e81142a8ea462a9ebcde9a7226a62a60b17:18
atmarkwill take a look17:19
atmarkthanks17:19
prometheanfirenow I have to check on fasteners (which I think needs a mask of 0.16 at least) and virtualenv (which is a whole... thing)17:19
sean-k-mooneyatmark: the old way is to use https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#aggregatemultitenancyisolation but you should use https://docs.openstack.org/nova/latest/admin/aggregates.html#tenant-isolation-with-placement if you can17:20
sean-k-mooneyatmark: i think the latter was added around rocky17:20
openstackgerritStephen Finucane proposed openstack/nova master: tests: Remove ;test_tcp_rst_no_compute_rpcapi'  https://review.opendev.org/c/openstack/nova/+/77716817:21
stephenfinprometheanfire: ^17:21
prometheanfirethanks17:21
stephenfingibi, melwitt, lyarwood, bauzas: That ^ is taken out of https://review.opendev.org/c/openstack/nova/+/714676 and should unblock mock 4.x in requirements. Could you take a look?17:21
openstackgerritStephen Finucane proposed openstack/nova master: tests: Remove 'test_tcp_rst_no_compute_rpcapi'  https://review.opendev.org/c/openstack/nova/+/77716817:23
stephenfinaha, melwitt already has a better solution https://review.opendev.org/c/openstack/nova/+/741351/17:23
*** ociuhandu_ has joined #openstack-nova17:24
stephenfinprometheanfire: https://review.opendev.org/c/openstack/nova/+/741351 is approved, so that should be fixed once it goes through the gate17:25
melwittstephenfin: I was gonna say, I spent time to rewrite that test proper 🥺 thanks for finding it, I should have pinged you to look but I kept forgetting17:25
prometheanfireawesome, thanks :D17:25
*** tesseract has quit IRC17:26
prometheanfirewas nova the one having problems with fasteners-0.16?17:26
stephenfinThat doesn't ring a bell17:27
prometheanfirek17:27
stephenfindo we use fasteners?17:27
stephenfinI've no idea what that is, tbh17:28
*** ociuhandu has quit IRC17:28
*** ociuhandu_ has quit IRC17:28
sean-k-mooneystephenfin: we do indrectly17:30
sean-k-mooneyits used in oslo17:30
stephenfinOh I guessed that but I meant directly17:31
sean-k-mooneystephenfin: as far as i aware its only use for the fair lock in oslo.concurancy17:31
sean-k-mooneythat is where we use it in nova17:31
prometheanfiremust have been a ml thread that mentioned17:31
sean-k-mooneyall our locks are eventually provided by fasteners17:31
bnemecYes, there was an issue with the latest fasteners release and nova: https://github.com/harlowja/fasteners/issues/3617:32
sean-k-mooneyprometheanfire: i mentioned we could use it to backport a patch in nova for an ironic issue17:32
sean-k-mooneye.g. port the lock to nova directly since we could not depned on oslo17:32
prometheanfirebnemec: should we mask 0.16 (and maybe 0.15)17:33
prometheanfireless deps are nice17:33
bnemecI believe it has been capped since the bug was found.17:34
bnemecNote that fasteners is the thing that does our file locking too. The fair lock stuff was added later.17:34
prometheanfireno, I've been holding 0.15 and 0.16 back for too long :P17:34
*** zimmerry has joined #openstack-nova17:35
prometheanfirelooks like 0.15 was masked but 0.16 has not been https://github.com/openstack/requirements/blob/master/global-requirements.txt#L30817:35
melwittI wonder if dansmith might have some thoughts about the cell func test locking + eventlet issue https://github.com/harlowja/fasteners/issues/36#issuecomment-76040268017:39
*** zimmerry has quit IRC17:40
dansmithsounds like something I would have thoughts on but I am like super deep in my current queue right now17:40
sean-k-mooneyin the func tests we serials the scater gather right17:41
melwittok :( but understandable17:41
openstackgerritChris Dent proposed openstack/placement master: Update traits in tests and requirements  https://review.opendev.org/c/openstack/placement/+/77717417:41
sean-k-mooneyi belve we have a fixture that alteres its executiton17:41
*** rpittau is now known as rpittau|afk17:41
sean-k-mooneyhttps://github.com/openstack/nova/blob/d10c9de25d7e4885a0ed2e5e31747e44f68359ba/nova/tests/unit/test_fixtures.py#L313-L32117:41
sean-k-mooneyso all the functest should be running in 1 thread of executin serially17:42
melwittare we using that in all tests though? I hadn't thought so. oh17:42
sean-k-mooneymaybe not17:43
sean-k-mooneyhttps://github.com/openstack/nova/blob/d10c9de25d7e4885a0ed2e5e31747e44f68359ba/nova/tests/unit/compute/test_compute.py#L145517:43
sean-k-mooneyits used in teh compute unit tests17:43
sean-k-mooneyi tought we had a similar one in place for functional17:43
melwittI found this old patch from March 2020 having to do with monkey patching current_thread https://review.opendev.org/c/openstack/nova/+/707474, it's not clear to me when the problem was last reproduced17:44
melwittthat is, I wonder if it's possible that could have fixed things17:44
sean-k-mooneyi think that is the same eventlet issue that is linked form teh fasteners one17:45
sean-k-mooneyya it is https://github.com/harlowja/fasteners/issues/36#issuecomment-76040268017:46
sean-k-mooneyoh that was done as part of https://bugs.launchpad.net/nova/+bug/186302117:47
openstackLaunchpad bug 1863021 in OpenStack Object Storage (swift) "[SRU] eventlet monkey patch results in assert len(_active) == 1 AssertionError" [Undecided,In progress] - Assigned to Chris MacNaughton (chris.macnaughton)17:47
sean-k-mooneywhich wwas really just wack a mole trying to work around an eventlet bug in every openstack project17:48
*** k_mouza has quit IRC17:49
*** k_mouza has joined #openstack-nova17:49
sean-k-mooneymelwitt: so ya maybe that use to fix it and now its broken again or fastners also need to hack around the eventlet issue17:52
melwittsean-k-mooney: yeah lemme see if I can run the tests successfully locally with the new version17:52
*** zimmerry has joined #openstack-nova17:53
*** khomesh24 has quit IRC17:56
*** zimmerry has quit IRC17:59
*** derekh has quit IRC18:00
*** dtantsur is now known as dtantsur|afk18:00
*** zimmerry has joined #openstack-nova18:03
*** zimmerry has quit IRC18:15
*** mlavalle has joined #openstack-nova18:20
*** lpetrut has joined #openstack-nova18:34
*** lpetrut has quit IRC18:40
*** jangutter_ has joined #openstack-nova19:03
*** jangutter has quit IRC19:06
*** k_mouza_ has joined #openstack-nova19:14
*** zimmerry has joined #openstack-nova19:16
*** jangutter has joined #openstack-nova19:16
*** zimmerry has quit IRC19:16
*** zimmerry has joined #openstack-nova19:17
*** k_mouza_ has quit IRC19:17
*** k_mouza has quit IRC19:18
*** jangutter_ has quit IRC19:19
*** andrewbonney has quit IRC19:34
openstackgerritMerged openstack/nova stable/train: Disallow CONF.compute.max_disk_devices_to_attach = 0  https://review.opendev.org/c/openstack/nova/+/77298619:35
openstackgerritMerged openstack/nova master: Handle instance = None in _local_delete_cleanup  https://review.opendev.org/c/openstack/nova/+/77530819:38
openstackgerritMerged openstack/nova master: Add net & utils methods for routed nets & segments  https://review.opendev.org/c/openstack/nova/+/77397619:39
*** Madkiss has joined #openstack-nova19:40
openstackgerritMerged openstack/nova master: Add a routed networks scheduler pre-filter  https://review.opendev.org/c/openstack/nova/+/74906819:40
*** zimmerry has quit IRC19:45
*** gmann is now known as gmann_lunch19:47
*** zimmerry has joined #openstack-nova19:47
*** nightmare_unreal has quit IRC19:47
*** gmann_lunch is now known as gmann20:07
openstackgerritmelanie witt proposed openstack/nova stable/victoria: Add regression test for bug 1914777  https://review.opendev.org/c/openstack/nova/+/77712120:10
openstackbug 1914777 in OpenStack Compute (nova) "Possible race condition between n-cpu and n-api when deleting a building instance" [High,In progress] https://launchpad.net/bugs/1914777 - Assigned to melanie witt (melwitt)20:10
openstackgerritmelanie witt proposed openstack/nova stable/victoria: Handle instance = None in _local_delete_cleanup  https://review.opendev.org/c/openstack/nova/+/77720920:13
*** gyee has joined #openstack-nova20:14
*** luksky has quit IRC20:17
*** jangutter has quit IRC20:22
*** jangutter has joined #openstack-nova20:23
*** zenkuro has quit IRC20:24
openstackgerritmelanie witt proposed openstack/nova stable/ussuri: Add regression test for bug 1893284  https://review.opendev.org/c/openstack/nova/+/77721620:26
openstackbug 1893284 in OpenStack Compute (nova) ussuri "Per-user quotas not scoped correctly when creating a server" [Low,New] https://launchpad.net/bugs/189328420:26
openstackgerritmelanie witt proposed openstack/nova stable/ussuri: Default user_id when not specified in check_num_instances_quota  https://review.opendev.org/c/openstack/nova/+/77721720:26
openstackgerritmelanie witt proposed openstack/nova stable/ussuri: Add regression test for bug 1914777  https://review.opendev.org/c/openstack/nova/+/77721820:26
openstackgerritmelanie witt proposed openstack/nova stable/ussuri: Handle instance = None in _local_delete_cleanup  https://review.opendev.org/c/openstack/nova/+/77721920:26
openstackbug 1914777 in OpenStack Compute (nova) victoria "Possible race condition between n-cpu and n-api when deleting a building instance" [High,In progress] https://launchpad.net/bugs/1914777 - Assigned to melanie witt (melwitt)20:26
*** zzzeek has quit IRC20:29
*** luksky has joined #openstack-nova20:30
*** hamalq has joined #openstack-nova20:30
*** zzzeek has joined #openstack-nova20:31
*** rcernin has joined #openstack-nova20:44
*** slaweq has quit IRC20:50
*** rcernin has quit IRC21:01
*** knikolla has quit IRC21:11
*** knikolla has joined #openstack-nova21:11
*** k_mouza has joined #openstack-nova21:18
*** k_mouza has quit IRC21:23
*** zimmerry has quit IRC21:27
*** spatel has quit IRC21:35
*** spatel has joined #openstack-nova21:38
*** rcernin has joined #openstack-nova21:46
*** spatel has quit IRC21:49
*** rcernin has quit IRC21:57
*** rcernin has joined #openstack-nova21:57
openstackgerritMerged openstack/nova master: FUP: Catch and reraise routed nets exception  https://review.opendev.org/c/openstack/nova/+/77669422:04
*** spatel has joined #openstack-nova22:11
*** spatel has quit IRC22:11
*** luksky has quit IRC22:16
*** xek has quit IRC22:26
*** ralonsoh has quit IRC22:31
openstackgerritMerged openstack/nova master: Refactor and rename test_tcp_rst_no_compute_rpcapi  https://review.opendev.org/c/openstack/nova/+/74135122:41
openstackgerritmelanie witt proposed openstack/nova stable/ussuri: Raise InstanceMappingNotFound if StaleDataError is encountered  https://review.opendev.org/c/openstack/nova/+/77725322:44
openstackgerritmelanie witt proposed openstack/nova stable/train: Raise InstanceMappingNotFound if StaleDataError is encountered  https://review.opendev.org/c/openstack/nova/+/77725422:45
*** Corwin has quit IRC22:46
*** dansmith has quit IRC22:46
*** valleedelisle has quit IRC22:46
*** Corwin has joined #openstack-nova22:48
*** dansmith has joined #openstack-nova22:48
*** valleedelisle has joined #openstack-nova22:48
*** tkajinam has joined #openstack-nova22:51
*** k_mouza has joined #openstack-nova23:19
*** tobias-urdin has quit IRC23:22
*** k_mouza has quit IRC23:23
*** belmoreira has quit IRC23:26
*** tkajinam has quit IRC23:40
*** tkajinam has joined #openstack-nova23:40
« Monday, 2021-02-22 Index Wednesday, 2021-02-24 »

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!