| *** mlavalle has quit IRC | 00:03 | |
| *** tosky has quit IRC | 00:09 | |
| *** zhanglong has joined #openstack-nova | 00:41 | |
| *** macz_ has joined #openstack-nova | 00:42 | |
| *** macz_ has quit IRC | 00:47 | |
| *** rouk has quit IRC | 01:23 | |
| *** rcernin has quit IRC | 01:34 | |
| *** rcernin has joined #openstack-nova | 01:45 | |
| *** rcernin has quit IRC | 01:46 | |
| *** rcernin has joined #openstack-nova | 01:46 | |
| *** LinPeiWen2 has joined #openstack-nova | 02:19 | |
| *** sapd1 has joined #openstack-nova | 02:36 | |
| *** tamas_erdei has joined #openstack-nova | 02:37 | |
| *** terdei has quit IRC | 02:39 | |
| *** tamas_erdei has quit IRC | 02:42 | |
| *** pawan-gupta has joined #openstack-nova | 02:45 | |
| *** rcernin has quit IRC | 02:45 | |
| *** zhanglong has quit IRC | 02:48 | |
| *** sapd1 has quit IRC | 02:56 | |
| *** rcernin has joined #openstack-nova | 02:57 | |
| *** rcernin has quit IRC | 02:57 | |
| *** rcernin has joined #openstack-nova | 02:58 | |
| *** hemanth_n has joined #openstack-nova | 03:15 | |
| *** zhanglong has joined #openstack-nova | 03:20 | |
| *** whoami-rajat has joined #openstack-nova | 03:31 | |
| *** rcernin has quit IRC | 03:31 | |
| *** rcernin has joined #openstack-nova | 03:38 | |
| openstackgerrit | Rico Lin proposed openstack/nova master: [Arm64] Makesure read bytes from jason files https://review.opendev.org/c/openstack/nova/+/782634 | 03:40 |
|---|---|---|
| *** zhanglong has quit IRC | 03:46 | |
| *** rcernin has quit IRC | 03:52 | |
| *** rcernin has joined #openstack-nova | 03:52 | |
| *** rcernin has quit IRC | 03:53 | |
| *** rcernin has joined #openstack-nova | 03:54 | |
| *** links has joined #openstack-nova | 04:20 | |
| *** jamesdenton has quit IRC | 04:30 | |
| *** jamesden_ has joined #openstack-nova | 04:31 | |
| *** macz_ has joined #openstack-nova | 04:41 | |
| *** vishalmanchanda has joined #openstack-nova | 04:42 | |
| *** macz_ has quit IRC | 04:46 | |
| *** ratailor has joined #openstack-nova | 04:49 | |
| *** jamesden_ has quit IRC | 04:55 | |
| *** jamesdenton has joined #openstack-nova | 04:55 | |
| *** macz_ has joined #openstack-nova | 05:02 | |
| *** macz_ has quit IRC | 05:06 | |
| *** Techy2493 has joined #openstack-nova | 05:27 | |
| *** jamesdenton has quit IRC | 05:32 | |
| *** zhanglong has joined #openstack-nova | 05:36 | |
| openstackgerrit | Josephine Seifert proposed openstack/nova stable/train: Add config parameter 'live_migration_scheme' to live migration with tls guide https://review.opendev.org/c/openstack/nova/+/782430 | 05:38 |
| *** Luzi has joined #openstack-nova | 05:40 | |
| *** jamesdenton has joined #openstack-nova | 05:40 | |
| *** Techy2493 has quit IRC | 05:44 | |
| *** jamesdenton has quit IRC | 05:52 | |
| *** psachin has joined #openstack-nova | 05:53 | |
| *** jamesdenton has joined #openstack-nova | 05:53 | |
| *** jraju__ has joined #openstack-nova | 06:00 | |
| *** links has quit IRC | 06:00 | |
| *** psachin has quit IRC | 06:01 | |
| *** gokhani has joined #openstack-nova | 06:03 | |
| *** fnordahl has joined #openstack-nova | 06:10 | |
| *** ralonsoh has joined #openstack-nova | 06:38 | |
| *** martinkennelly has quit IRC | 06:49 | |
| *** dklyle has quit IRC | 06:49 | |
| *** psachin has joined #openstack-nova | 06:51 | |
| *** martinkennelly has joined #openstack-nova | 06:51 | |
| openstackgerrit | Rico Lin proposed openstack/nova master: [Arm64] Makesure read bytes from jason files https://review.opendev.org/c/openstack/nova/+/782634 | 07:00 |
| *** lpetrut has joined #openstack-nova | 07:06 | |
| openstackgerrit | Rico Lin proposed openstack/nova master: [Arm64][libvirt] Fix read bytes from jason files https://review.opendev.org/c/openstack/nova/+/782634 | 07:13 |
| ricolin | stephenfin, I created a bug for the arm64 bionic issue here https://bugs.launchpad.net/nova/+bug/1921073 | 07:14 |
| openstack | Launchpad bug 1921073 in OpenStack Compute (nova) "[arm64][libvirt] firmware metadata files not found for arm64 on ubuntu 18.04" [Undecided,New] | 07:14 |
| ricolin | Also launchpad and patch for focal arm64 libvirt issue I mentioned in https://review.opendev.org/c/openstack/nova/+/781210 | 07:15 |
| ricolin | https://review.opendev.org/c/openstack/nova/+/782634 | 07:15 |
| *** cgoncalves has quit IRC | 07:18 | |
| ricolin | stephenfin, gibi bauzas kashyap takashin lyarwood ^^^ | 07:19 |
| *** cgoncalves has joined #openstack-nova | 07:20 | |
| *** cgoncalves has quit IRC | 07:20 | |
| *** cgoncalves has joined #openstack-nova | 07:21 | |
| *** csatari has quit IRC | 07:25 | |
| *** csatari has joined #openstack-nova | 07:28 | |
| *** zhanglong has quit IRC | 07:32 | |
| *** mkrai has joined #openstack-nova | 07:33 | |
| *** martinkennelly has quit IRC | 07:40 | |
| *** mkrai has quit IRC | 07:55 | |
| *** mkrai_ has joined #openstack-nova | 07:55 | |
| *** luksky has joined #openstack-nova | 07:55 | |
| *** khomesh24 has joined #openstack-nova | 08:00 | |
| *** rcernin has quit IRC | 08:09 | |
| *** andrewbonney has joined #openstack-nova | 08:12 | |
| *** mkrai_ has quit IRC | 08:14 | |
| *** rpittau|afk is now known as rpittau | 08:19 | |
| *** mkrai has joined #openstack-nova | 08:19 | |
| *** ricolin has quit IRC | 08:27 | |
| *** ricolin has joined #openstack-nova | 08:32 | |
| *** dtantsur|afk is now known as dtantsur | 08:32 | |
| *** hrw has joined #openstack-nova | 08:32 | |
| hrw | morning | 08:32 |
| hrw | does anyone uses nova on Debian 'buster'? | 08:33 |
| hrw | I am trying to get it working again in Kolla. so far updated libvirt and libvirt-python to 7.0.0, installed 2020.05 qemu-efi-aarch64 firmware. This gave me nova passing further. | 08:34 |
| *** gokhani has quit IRC | 08:36 | |
| ricolin | hrw, do you facing the same issue as I'm on Ubuntu 'bionic'? https://bugs.launchpad.net/nova/+bug/1921073 | 08:38 |
| openstack | Launchpad bug 1921073 in OpenStack Compute (nova) "[arm64][libvirt] firmware metadata files not found for arm64 on ubuntu 18.04" [Undecided,New] | 08:38 |
| *** gokhani has joined #openstack-nova | 08:40 | |
| hrw | ricolin: do yourself a favor. move to 20.04 | 08:40 |
| hrw | ricolin: I solved that problem with qemu-efi-aarch64 from buster-backports | 08:40 |
| *** tosky has joined #openstack-nova | 08:41 | |
| ricolin | hrw, already moved and it works with 20.04 (https://review.opendev.org/c/openstack/devstack/+/708317) | 08:45 |
| hrw | https://paste.debian.net/1190776/ is where I am now | 08:47 |
| ricolin | hrw, for that case, I think this fix works https://review.opendev.org/c/openstack/nova/+/782634 | 08:49 |
| *** rcernin has joined #openstack-nova | 08:52 | |
| *** khomesh24 has quit IRC | 08:54 | |
| hrw | hm. need to install with nova in developer mode then | 08:55 |
| *** lucasagomes has joined #openstack-nova | 08:55 | |
| *** derekh has joined #openstack-nova | 08:56 | |
| *** rcernin has quit IRC | 08:57 | |
| kashyap | sean-k-mooney: My internet connection last evening was super flaky here (they were, and still are, reworking roads here). | 08:57 |
| hrw | ricolin: thanks. | 08:58 |
| hrw | redeploying now | 08:58 |
| kashyap | ricolin: Is this the one that was breaking the AArch64 CI? | 08:58 |
| ricolin | hrw, I'm now looking at issue with delete volume backups in https://zuul.opendev.org/t/openstack/build/22b514f0bb2041d9b744cc0b37df8bf9 | 08:59 |
| ricolin | kashyap, yes | 08:59 |
| hrw | ricolin: step by step. I first want to get something running. | 09:00 |
| *** khomesh24 has joined #openstack-nova | 09:00 | |
| hrw | already have 3 patches in kolla queue to get to current state ;D | 09:01 |
| *** vishalmanchanda has quit IRC | 09:01 | |
| kashyap | ricolin: The "rb" --> read and binary, yeah? | 09:01 |
| hrw | mgoddard: yes | 09:02 |
| hrw | kashyap: yes | 09:02 |
| ricolin | hrw, will check your kolla patches, maybe I'm facing same issues you ware faced! | 09:02 |
| ricolin | kashyap, yes as hrw said:) | 09:02 |
| *** abhishekk is now known as abhishekk|away | 09:03 | |
| mgoddard | hrw: me? | 09:03 |
| ricolin | read and make all output from file in binary mode | 09:03 |
| hrw | mgoddard: sorry | 09:03 |
| kashyap | hrw: ricolin: Nice debugging. It's the Python-3 only thing, I guess? | 09:03 |
| *** macz_ has joined #openstack-nova | 09:04 | |
| hrw | kashyap: I would say that it is old open() behaviour but maybe I am too long in py3 | 09:04 |
| hrw | anyway it is probably usual bytes != chars thing | 09:05 |
| *** ociuhandu has joined #openstack-nova | 09:06 | |
| *** brinzhang has quit IRC | 09:07 | |
| *** rcernin has joined #openstack-nova | 09:08 | |
| *** macz_ has quit IRC | 09:09 | |
| *** ociuhandu has quit IRC | 09:10 | |
| *** ociuhandu has joined #openstack-nova | 09:17 | |
| *** dtantsur has quit IRC | 09:22 | |
| *** ociuhandu has quit IRC | 09:22 | |
| *** dtantsur has joined #openstack-nova | 09:26 | |
| bauzas | stephenfin: dansmith: lyarwood: I'm a bit afraid of loosing the RPC API bump merge to be in Xena, could you please look at this one ? | 09:26 |
| *** mkrai has quit IRC | 09:26 | |
| bauzas | context : https://review.opendev.org/c/openstack/nova/+/761452 | 09:27 |
| *** ociuhandu has joined #openstack-nova | 09:27 | |
| *** dtantsur has quit IRC | 09:28 | |
| *** mkrai has joined #openstack-nova | 09:28 | |
| *** dtantsur has joined #openstack-nova | 09:30 | |
| *** brinzhang has joined #openstack-nova | 09:30 | |
| *** zhanglong has joined #openstack-nova | 09:30 | |
| *** rcernin has quit IRC | 09:32 | |
| *** dtantsur has quit IRC | 09:36 | |
| *** ociuhandu has quit IRC | 09:36 | |
| hrw | ricolin: https://review.opendev.org/c/openstack/nova/+/782634 got me closer ;D | 09:37 |
| hrw | now it is at: 2021-03-24 10:36:23.905 7 ERROR nova.compute.manager [instance: ef71de37-1a2b-4f60-9fb4-d5942ffe7fc4] libvirt.libvirtError: unable to open '/sys/fs/cgroup/machine/qemu-1-instance-00000002.libvirt-qemu/': No such file or directory | 09:37 |
| *** dtantsur has joined #openstack-nova | 09:38 | |
| hrw | ricolin: +1 | 09:39 |
| *** sapd1 has joined #openstack-nova | 09:40 | |
| *** vishalmanchanda has joined #openstack-nova | 09:42 | |
| *** ociuhandu has joined #openstack-nova | 09:42 | |
| *** ociuhandu has quit IRC | 09:48 | |
| *** zhanglong has quit IRC | 09:53 | |
| *** rcernin has joined #openstack-nova | 09:57 | |
| *** ociuhandu has joined #openstack-nova | 10:01 | |
| *** rcernin has quit IRC | 10:02 | |
| *** ociuhandu has quit IRC | 10:02 | |
| *** ociuhandu has joined #openstack-nova | 10:03 | |
| *** brinzhang_ has joined #openstack-nova | 10:03 | |
| *** brinzhang has quit IRC | 10:06 | |
| *** rcernin has joined #openstack-nova | 10:12 | |
| *** rcernin has quit IRC | 10:22 | |
| *** jangutter_ has joined #openstack-nova | 10:24 | |
| *** jangutter has quit IRC | 10:27 | |
| *** mkrai has quit IRC | 10:45 | |
| *** ociuhandu has quit IRC | 10:46 | |
| gibi | fyi, there is an intermittent unit test failure in the gate since https://review.opendev.org/c/openstack/nova/+/733627 merged. https://bugs.launchpad.net/nova/+bug/1921098 | 10:47 |
| openstack | Launchpad bug 1921098 in OpenStack Compute (nova) "test_init_application_called_twice unit test fails intermittently" [High,Triaged] - Assigned to Balazs Gibizer (balazs-gibizer) | 10:47 |
| *** ociuhandu has joined #openstack-nova | 10:47 | |
| gibi | I'm will push a patch soon | 10:47 |
| *** ociuhandu has quit IRC | 10:54 | |
| *** rcernin has joined #openstack-nova | 11:01 | |
| *** ociuhandu has joined #openstack-nova | 11:01 | |
| *** rcernin has quit IRC | 11:01 | |
| *** mgariepy has quit IRC | 11:03 | |
| *** rcernin has joined #openstack-nova | 11:04 | |
| *** ociuhandu has quit IRC | 11:07 | |
| *** brinzhang0 has joined #openstack-nova | 11:08 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Reset global wsgi app state in unit test https://review.opendev.org/c/openstack/nova/+/782691 | 11:08 |
| gibi | stephenfin, lyarwood, bauzas: could you hit it please ^^ ? | 11:10 |
| *** brinzhang_ has quit IRC | 11:12 | |
| gibi | lyarwood, stephenfin if you know how to make it nicer then a follow up is appreciated https://review.opendev.org/c/openstack/nova/+/779446/1/doc/source/admin/hw-machine-type.rst#26 | 11:16 |
| stephenfin | gibi: done | 11:17 |
| *** ociuhandu has joined #openstack-nova | 11:18 | |
| lyarwood | aaaaaand done | 11:18 |
| lyarwood | stephenfin: I'll sort that machine type doc issue out now | 11:18 |
| * lyarwood was sure he built and checked this locally | 11:19 | |
| stephenfin | lyarwood: It's not you - it's the theme | 11:20 |
| stephenfin | There's a <div> with multiple <p> elements inside. The <p> elements are getting styled instead of the <div> | 11:20 |
| stephenfin | gibi: | 11:21 |
| gibi | lyarwood, stephenfin : if it cannot be fixed then fine :) | 11:23 |
| gibi | btw, I have a micro nit also in https://review.opendev.org/c/openstack/nova/+/779479/3/nova/api/openstack/compute/rest_api_version_history.rst#1138 | 11:23 |
| gibi | and thanks for the review on the unit test fix | 11:24 |
| gibi | :) | 11:24 |
| * gibi now goes through stephen's doc patches | 11:24 | |
| lyarwood | gibi: kk I can respin that | 11:25 |
| lyarwood | ah nvm it's in the gate | 11:27 |
| gibi | yeah, it is totally OK not to fix it | 11:27 |
| gibi | I just wanted to note that the anchor generation works differently if the label starts with a number | 11:27 |
| gibi | so we should prefer labels starting with a nonnumber for stable achors | 11:27 |
| gibi | but this one will work for the case you added it | 11:28 |
| gibi | as the anchor and the ref is in the same doc | 11:28 |
| gibi | and sphinx magic helps | 11:28 |
| lyarwood | it's in a different doc? | 11:28 |
| gibi | it is generated by the same single sphinx run so the anchor is resolved properly | 11:31 |
| gibi | but externally (ie, from the python-novaclient docs) you would need to refer to the numeric id of the ancor 'id80' but that is not stable | 11:31 |
| gibi | sphinx generates proper labelled achnors if the label starts with a nonnumber | 11:32 |
| lyarwood | kk | 11:32 |
| *** ociuhandu has quit IRC | 11:33 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: doc: Use a non-numerical anchor when referencing microversions https://review.opendev.org/c/openstack/nova/+/782696 | 11:33 |
| *** sapd1 has quit IRC | 11:37 | |
| *** macz_ has joined #openstack-nova | 11:41 | |
| *** macz_ has quit IRC | 11:45 | |
| *** mgariepy has joined #openstack-nova | 11:57 | |
| *** rcernin has quit IRC | 11:58 | |
| *** macz_ has joined #openstack-nova | 12:01 | |
| *** ociuhandu has joined #openstack-nova | 12:03 | |
| *** ociuhandu has quit IRC | 12:04 | |
| *** ociuhandu has joined #openstack-nova | 12:05 | |
| *** ociuhandu has quit IRC | 12:05 | |
| *** macz_ has quit IRC | 12:06 | |
| *** rcernin has joined #openstack-nova | 12:06 | |
| openstackgerrit | Rico Lin proposed openstack/nova master: [Arm64][libvirt] Fix read bytes from json files https://review.opendev.org/c/openstack/nova/+/782634 | 12:10 |
| *** ociuhandu has joined #openstack-nova | 12:11 | |
| hrw | can someone point me to doc about how nova/libvirt create cgroupv2 dirs? | 12:13 |
| *** rcernin has quit IRC | 12:22 | |
| *** ociuhandu has quit IRC | 12:23 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: doc: Use a non-numerical anchor when referencing microversions https://review.opendev.org/c/openstack/nova/+/782696 | 12:26 |
| *** hemanth_n has quit IRC | 12:31 | |
| *** owalsh has quit IRC | 12:32 | |
| *** ociuhandu has joined #openstack-nova | 12:32 | |
| *** ratailor has quit IRC | 12:33 | |
| lyarwood | https://review.opendev.org/q/topic:bug/1917619 & https://review.opendev.org/q/topic:bug/1919487 could use reviews if anyone has bandwidth this week btw | 12:35 |
| * lyarwood needs to drop for a few hours for childcare | 12:35 | |
| lyarwood | gibi / stephenfin ; https://review.opendev.org/c/openstack/nova/+/768466 also this that gets us closer to finally closing out our migration to native zuulv3 jobs | 12:36 |
| lyarwood | it has taken ages to land all the required stuff in devstack and the ceph plugin | 12:36 |
| * lyarwood really drops this time | 12:36 | |
| stephenfin | lyarwood: ack | 12:37 |
| stephenfin | bauzas: Looking at the RPC change now. Can we rename parameters in this change? | 12:37 |
| *** ociuhandu has quit IRC | 12:39 | |
| *** ociuhandu has joined #openstack-nova | 12:40 | |
| *** sean-k-mooney has joined #openstack-nova | 12:43 | |
| *** psachin has quit IRC | 12:50 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Clarify value for 'hw:cpu_realtime' extra spec https://review.opendev.org/c/openstack/nova/+/782708 | 12:51 |
| *** ociuhandu has quit IRC | 12:55 | |
| *** martinkennelly has joined #openstack-nova | 12:58 | |
| *** LinPeiWen2 has quit IRC | 12:59 | |
| *** ociuhandu has joined #openstack-nova | 13:01 | |
| *** ociuhandu has quit IRC | 13:02 | |
| *** ociuhandu has joined #openstack-nova | 13:02 | |
| *** macz_ has joined #openstack-nova | 13:03 | |
| *** macz_ has quit IRC | 13:08 | |
| *** brinzhang0 has quit IRC | 13:09 | |
| *** jamesdenton has quit IRC | 13:13 | |
| *** jamesdenton has joined #openstack-nova | 13:13 | |
| *** ociuhandu has quit IRC | 13:16 | |
| openstackgerrit | Merged openstack/nova master: docs: Add version{added,changed} notes to the hw_machine_type guide https://review.opendev.org/c/openstack/nova/+/779446 | 13:23 |
| openstackgerrit | Merged openstack/nova master: docs: Add note about rescuing bfv instances with the 2.87 microversion https://review.opendev.org/c/openstack/nova/+/779479 | 13:24 |
| *** ociuhandu has joined #openstack-nova | 13:25 | |
| openstackgerrit | Merged openstack/nova master: Reset global wsgi app state in unit test https://review.opendev.org/c/openstack/nova/+/782691 | 13:26 |
| openstackgerrit | Merged openstack/nova master: docs: Add a resource limits guide https://review.opendev.org/c/openstack/nova/+/781433 | 13:27 |
| *** belmoreira has joined #openstack-nova | 13:27 | |
| *** ociuhandu has quit IRC | 13:30 | |
| *** dansmith has quit IRC | 13:31 | |
| *** tesseract has joined #openstack-nova | 13:33 | |
| *** pawan-gupta has quit IRC | 13:33 | |
| *** ociuhandu has joined #openstack-nova | 13:35 | |
| *** dansmith has joined #openstack-nova | 13:38 | |
| *** ociuhandu has quit IRC | 13:41 | |
| *** ociuhandu has joined #openstack-nova | 13:53 | |
| *** sapd1 has joined #openstack-nova | 14:00 | |
| *** ociuhandu has quit IRC | 14:04 | |
| *** ociuhandu has joined #openstack-nova | 14:04 | |
| bauzas | stephenfin: whoops, just saw your question | 14:18 |
| bauzas | stephenfin: please, don't ask to change the instance_type for my change | 14:19 |
| bauzas | I know about this fact, but changing the parameter for this change is not related to the needed behaviour ? | 14:19 |
| bauzas | right? | 14:19 |
| *** owalsh has joined #openstack-nova | 14:29 | |
| bauzas | stephenfin: actually, I do understand your concern | 14:30 |
| bauzas | problem is, changing this param name would also need to modify the rpcapi module | 14:31 |
| bauzas | and then the tests... | 14:31 |
| bauzas | something saying : if ver==6.0: <use flavor for the param name>; <use instance_type> | 14:32 |
| dansmith | I understand the desire for consistency, | 14:32 |
| dansmith | but it's pretty late to be changing that, and it's been that way since forever | 14:32 |
| dansmith | so I'm pretty meh about it, as you might expect :) | 14:32 |
| *** ociuhandu has quit IRC | 14:33 | |
| bauzas | yeah :( | 14:33 |
| bauzas | I honestly haven't thought about changing this before | 14:34 |
| bauzas | and the fact I was redefining what would be the compute RPC | 14:34 |
| bauzas | I just looked at what was changed | 14:34 |
| bauzas | and now, looks like it's difficult for me to do it as we would need to change a lot of stuff here | 14:35 |
| dansmith | the client can look at the version to determine which param to send, and the v5 proxy can just convert the old to the new | 14:35 |
| dansmith | I don't really know how much test damage there will be, since those usually dispatch positionally | 14:35 |
| dansmith | but I just think it's pretty late to jam that in here | 14:35 |
| *** lpetrut has quit IRC | 14:39 | |
| bauzas | dansmith: surely, I'm not saying this is impossible | 14:40 |
| bauzas | dansmith: just the fact that the ship mostly sailed | 14:41 |
| bauzas | and yes, this would mean the client would have to pass different arguments based on the version it discovers | 14:41 |
| bauzas | something we usually do | 14:41 |
| bauzas | but something we need to amend tests as well | 14:41 |
| dansmith | yeah | 14:41 |
| bauzas | dansmith: we could tho deprecate instance_type in a 6.1 and pass a new arg named flavor, right? | 14:42 |
| bauzas | so, later with 7.0, we would just get rid of the deprecated instance_type | 14:42 |
| sean-k-mooney | given this is internal an we all know that instance_type is the flavor | 14:43 |
| sean-k-mooney | im not sure there is much gain form that | 14:43 |
| dansmith | bauzas: that's a bad idea, IMHO | 14:43 |
| sean-k-mooney | but we could i guess | 14:43 |
| dansmith | sean-k-mooney: I agree, this is not a huge deal | 14:43 |
| *** Luzi has quit IRC | 14:43 | |
| bauzas | dansmith: well, that's what we do when we want to rename o.vo fields, nope ? | 14:43 |
| dansmith | sean-k-mooney: we could even docstring it to explain, or just set flavor=instance_type as the first line of the method :) | 14:43 |
| bauzas | deprecating the old field and adding a new one | 14:43 |
| sean-k-mooney | dansmith: yep | 14:43 |
| bauzas | dansmith: that's the easy part | 14:44 |
| sean-k-mooney | bauzas: am not quite | 14:44 |
| sean-k-mooney | we do add a new filed | 14:44 |
| dansmith | bauzas: yeah, but you just have to handle both until the next major version.. we usually do that for a _format_ change not just a name change | 14:44 |
| sean-k-mooney | but we transrom form one to the other | 14:44 |
| sean-k-mooney | we dont really deprecate | 14:44 |
| bauzas | dansmith: well, you're right, sounds a bit nitty to do this for just a param change | 14:44 |
| sean-k-mooney | we add support for converting in make compatible so we normally wont set both for example | 14:45 |
| bauzas | but yeah, in Xena we could s/instance_type/flavor in the inner of the method and just leave the wire unchanged | 14:45 |
| bauzas | stephenfin: does this sound acceptable to you ? | 14:46 |
| *** mkrai has joined #openstack-nova | 14:51 | |
| *** ociuhandu has joined #openstack-nova | 14:51 | |
| tosky | melwitt: hi, do you remember if this workaround can be removed, or at least restricted to queens and rocky (or just queens)? https://opendev.org/openstack/devstack-plugin-ceph/src/branch/master/devstack/plugin.sh#L33 | 14:56 |
| *** ociuhandu has quit IRC | 14:58 | |
| *** dklyle has joined #openstack-nova | 14:58 | |
| *** dklyle has quit IRC | 14:59 | |
| melwitt | tosky: hm, originally that was only for queens but I see this commit added the master branch https://opendev.org/openstack/devstack-plugin-ceph/commit/39de6df04130cf2f221fb5ba2a9b5ff597de332a so I think you need to ask frickler whether we still need master branch | 15:04 |
| *** ociuhandu has joined #openstack-nova | 15:04 | |
| *** hack-char has quit IRC | 15:08 | |
| *** ociuhandu has quit IRC | 15:08 | |
| melwitt | gibi: thanks for finding and fixing the wsgi app unit test bug! | 15:08 |
| *** macz_ has joined #openstack-nova | 15:09 | |
| *** gokhani has quit IRC | 15:09 | |
| *** macz_ has quit IRC | 15:09 | |
| *** macz_ has joined #openstack-nova | 15:10 | |
| *** hack-char has joined #openstack-nova | 15:10 | |
| *** dklyle has joined #openstack-nova | 15:10 | |
| *** __ministry1 has joined #openstack-nova | 15:21 | |
| *** ociuhandu has joined #openstack-nova | 15:22 | |
| stephenfin | bauzas: dansmith: Yeah, that's fine if it's way too much work. With that said, I'm surprised that it _is_ a lot of work. I expected it would just be a shim, and iirc there are only a handful of places where we explicitly set the 'instance_type' kwarg directly in tests | 15:23 |
| stephenfin | I also have a patch ready to replace instance_type everywhere else, if that was a blocker, though making it a dependency might be too much churn | 15:23 |
| dansmith | stephenfin: I'm not sure it is a lot of work, as noted above, but I think bauzas was saying that he tried and a bunch of tests fail | 15:23 |
| stephenfin | It's really not a big deal, I agree, but I think it's so trivial and we won't have a chance to fix it until 7.0, which it's reasonable to suggest won't ever happen :) | 15:24 |
| stephenfin | Ah, that would be fair | 15:24 |
| * stephenfin looks at the patch to replace references elsewhere and sees what happens | 15:25 | |
| dansmith | stephenfin: it's just not a big enough deal to justify the uncertainty at this point to me | 15:25 |
| gibi | melwitt: I saw it failing today and remembered that there was a recent change in the wsgi_app | 15:26 |
| dansmith | it's just internal developer-only cleanliness and just isn't that important, I think is the assertion the three of us are making above | 15:26 |
| melwitt | gibi: u rock :) | 15:26 |
| gibi | :) | 15:26 |
| dansmith | but it's bauzas' baby, so whatever he wants to do, IMHO | 15:26 |
| *** ociuhandu has quit IRC | 15:26 | |
| bauzas | stephenfin: well, again, I'm not saying it's impossible to do | 15:29 |
| *** stand has joined #openstack-nova | 15:29 | |
| bauzas | stephenfin: but in order to change the param name, we need to also modify the RPC client to provide the right name between the versions | 15:30 |
| bauzas | and if so, we need to write tests | 15:30 |
| bauzas | (and change some tests which would pass the original name directly) | 15:30 |
| stephenfin | If it helps, I count 7 existing tests we'd need to change | 15:30 |
| bauzas | stephenfin: my only concern is the time | 15:31 |
| dansmith | bauzas: yeah, also the new tests, for sure | 15:31 |
| bauzas | RC1 is tomorrow | 15:31 |
| bauzas | and we can't merge later if we want this for Wallaby | 15:31 |
| stephenfin | ack, okay that is super close | 15:33 |
| tosky | melwitt: thanks, will do; I suspect master is not affected (we switched to focal since then, and probably ceph version), but let's see | 15:33 |
| melwitt | ack, sounds cool | 15:33 |
| bauzas | stephenfin: but again, your concern is valid | 15:36 |
| bauzas | what we can do for Xena is at least to change the var name within the methods | 15:36 |
| bauzas | and just keep this ugly param name as it is | 15:37 |
| bauzas | until we cut a new RPC version | 15:37 |
| bauzas | but writing a good fat comment above the method explaining that 7.0 should change this param would also help to not miss the target again | 15:37 |
| *** mlavalle has joined #openstack-nova | 15:39 | |
| gibi | lyarwood: I have a question/suggestion in https://review.opendev.org/c/openstack/nova/+/781138/4/nova/compute/api.py#5495 | 15:46 |
| *** markmcclain has joined #openstack-nova | 15:53 | |
| openstackgerrit | Ghanshyam proposed openstack/nova master: DNM: testing tempest https://review.opendev.org/c/openstack/nova/+/782798 | 15:54 |
| *** tbachman has quit IRC | 15:57 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: DNM: Rename 'instance_type' parameter https://review.opendev.org/c/openstack/nova/+/782804 | 15:58 |
| stephenfin | bauzas: ^ I can change my vote if you _really_ don't want to do this, but fwict that's all we need ^ | 15:59 |
| *** tbachman has joined #openstack-nova | 15:59 | |
| stephenfin | I couldn't find an example of a good test to make sure the calls are translated. I could do a simple mock of the v6 method and use 'assert_called_with', but we don't use named kwargs in the v5 proxy so there isn't really anything to check | 16:00 |
| bauzas | stephenfin: first thing, you'd need to rebase your change on top of my RPC bump so we would also need to modify the 5.0 proxy to pass the right arg name | 16:00 |
| stephenfin | did I not do that? | 16:00 |
| * stephenfin looks | 16:00 | |
| stephenfin | yeah, it's on top of your change already | 16:01 |
| bauzas | oh | 16:01 |
| bauzas | sorry, missed this | 16:01 |
| bauzas | but, | 16:01 |
| bauzas | we need to pass the right arg within the 5.0 proxy | 16:01 |
| stephenfin | see above - you're doing that already | 16:01 |
| dansmith | the client needs to pass a different arg for 5.x | 16:02 |
| bauzas | like https://review.opendev.org/c/openstack/nova/+/782804/1/nova/compute/manager.py#10706 | 16:02 |
| dansmith | and we need a test for both modes | 16:02 |
| stephenfin | aha, gotcha. Sec | 16:02 |
| bauzas | stephenfin: we call the 6.0 method within the 5.0 proxy one | 16:02 |
| lyarwood | gibi: yup good point, it's always provided by c-vol but yeah it isn't required in the api so .get() is safer | 16:02 |
| bauzas | so, instance_type should be transformed into flavor | 16:02 |
| bauzas | within the proxty | 16:03 |
| *** ociuhandu has joined #openstack-nova | 16:03 | |
| gibi | lyarwood: if it is always provided then we should document it in our API ref | 16:03 |
| bauzas | stephenfin: and then we would need to test the API versioning | 16:03 |
| dansmith | bauzas: and the client needs the same, based on the version pin | 16:03 |
| bauzas | yup | 16:03 |
| bauzas | https://review.opendev.org/c/openstack/nova/+/782804/1/nova/compute/rpcapi.py#963 | 16:03 |
| bauzas | we should say s/t like "if not can_send(6.0): instance_type = flavor | 16:04 |
| dansmith | no, you can't do that, | 16:04 |
| bauzas | and then pass instance_type instead of flavor | 16:04 |
| dansmith | because it'll break if we introduce a 6.1 | 16:04 |
| dansmith | it needs to check the first digit I think | 16:04 |
| bauzas | oh yea | 16:04 |
| bauzas | sorry | 16:04 |
| bauzas | indeed | 16:04 |
| bauzas | we would only pin the change to 6.0 | 16:05 |
| bauzas | but yeah | 16:05 |
| dansmith | for now, but then we have to fix that immediately before the next RPC minor or we'll start sending the 5.x version for 6.1, so I think we need to be more careful | 16:05 |
| * bauzas looks at how to check this | 16:05 | |
| lyarwood | gibi: I can do that in a fup but I think that would be a microversion bump right? | 16:05 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: Convert client also https://review.opendev.org/c/openstack/nova/+/782810 | 16:06 |
| stephenfin | dansmith: like that? (need tests obv) ^ | 16:06 |
| gibi | lyarwood: if it is already provided and we are not rejecting it then it is a bug in the API ref | 16:06 |
| bauzas | dansmith: right, and 7.0 bump could also just support 6.y where y>1 | 16:06 |
| gibi | I guess we are not really enforcing schema on that api | 16:06 |
| gibi | lyarwood: it is totally OK to fix the API ref separately | 16:06 |
| gibi | later | 16:06 |
| lyarwood | kk | 16:06 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Reject requests to commit intermediary snapshot of an inactive instance https://review.opendev.org/c/openstack/nova/+/781138 | 16:07 |
| bauzas | stephenfin: no, for the reason dansmith mentioned | 16:07 |
| bauzas | we can't only accept 6.0 | 16:07 |
| dansmith | bauzas: well, I might be wrong about that in this case, I was kinda thinking of it differently | 16:07 |
| dansmith | I guess this works because can_send_version(6.0) will be true even once we move to 6.1 | 16:08 |
| stephenfin | well then weren't we doing that already? | 16:08 |
| stephenfin | currently we're passing version=5.1 | 16:08 |
| bauzas | dansmith: not if we bumped 7.0 and we only support 6.5 and later (per say) | 16:08 |
| dansmith | bauzas: yeah, but this will all be removed before we'd bump to 7, | 16:09 |
| dansmith | I was worried about the version calculus for 6.x where x>0 not 7 | 16:09 |
| stephenfin | so we'd have to change that if we added a 6.x that affected that method | 16:09 |
| bauzas | stephenfin: no, we pass either 6.0, 5.1 or 5.0 depending on the server | 16:10 |
| dansmith | *depending on the pin | 16:10 |
| bauzas | right | 16:10 |
| stephenfin | cctxt = client.prepare(server=host, version=version) | 16:10 |
| bauzas | that's the client version | 16:10 |
| stephenfin | oh, I '_ver' is doing the magic | 16:10 |
| bauzas | not the service version we discover based on the pin | 16:11 |
| stephenfin | *the '_ver' method | 16:11 |
| bauzas | the _ver method is temporary | 16:11 |
| bauzas | just to avoid reproducing dumb checks | 16:12 |
| bauzas | that's the pattern we used in the past bumps and I shamelessly reproduced it | 16:12 |
| dansmith | patterns are good :) | 16:13 |
| bauzas | provided people understand them. | 16:13 |
| dansmith | stephenfin: you also want to change the client signature to use flavor too, I'm sure | 16:14 |
| stephenfin | I don't think so. Not yet | 16:14 |
| stephenfin | Keep it small | 16:14 |
| dansmith | why? | 16:14 |
| stephenfin | That's v. easy fix in a follow-up | 16:14 |
| stephenfin | I mean I can but it's more test damage | 16:15 |
| bauzas | right | 16:15 |
| dansmith | well, that's the point here | 16:15 |
| bauzas | some methods pass kwargs | 16:15 |
| bauzas | then, you're dommed | 16:15 |
| bauzas | doomed* | 16:15 |
| dansmith | either we're going for consistency or we aren't right? | 16:15 |
| stephenfin | *eventual consistency | 16:18 |
| stephenfin | I can change the other things whenever. I can only change this right now | 16:18 |
| *** tbachman_ has joined #openstack-nova | 16:18 | |
| stephenfin | and I have the follow-up ready. I just don't think it's wise to merge it right now since it's huge | 16:18 |
| *** tesseract has quit IRC | 16:18 | |
| *** tbachman has quit IRC | 16:19 | |
| *** tbachman_ is now known as tbachman | 16:19 | |
| dansmith | well, my opinion is that this is all just naming and not useful for paying down any real debt (like deprecated parameters) so I'd vote to just punt on it anyway | 16:21 |
| *** mgariepy has quit IRC | 16:21 | |
| *** gyee has joined #openstack-nova | 16:23 | |
| bauzas | the other problem I see is with the gate | 16:24 |
| bauzas | getting at least a grenade-multinode result | 16:24 |
| dansmith | for sure we need to see and scrutinize a grenade-multinode result at least | 16:24 |
| bauzas | the good thing is that both prep_resize and resize_instance() are tested IIRC | 16:25 |
| *** ociuhandu has quit IRC | 16:26 | |
| bauzas | I have to stop now as I need to taxi my daughter to some doctor's appointment | 16:31 |
| bauzas | but I can be back later on in the evening | 16:31 |
| *** hamalq has joined #openstack-nova | 16:32 | |
| * bauzas rushes off | 16:35 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: DNM: Rename 'instance_type' parameter https://review.opendev.org/c/openstack/nova/+/782804 | 16:36 |
| *** __ministry1 has quit IRC | 16:38 | |
| *** dtantsur is now known as dtantsur|brb | 16:43 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: rpc: Rename 'instance_type' client argument https://review.opendev.org/c/openstack/nova/+/782825 | 16:48 |
| *** masterpe has quit IRC | 16:48 | |
| stephenfin | dansmith: A'ight, there's the client change ^ Pretty simple after all. I think I'd still keep it separate but we could squash it in if we wanted to | 16:48 |
| stephenfin | Also, for the previous patch, there doesn't appear to have been a test for backleveling of 'prep_resize' so we might want to adding that as a follow-up even if we don't do this (it seems to be working fine, thankfully, based on the test) | 16:49 |
| stephenfin | I realize it doesn't ultimately matter, but when it's this easy I really do think we should be including this. It'd mean we're just left with some DB/o.vo references to instance types. I could live with those | 16:50 |
| *** masterpe has joined #openstack-nova | 16:51 | |
| *** mkrai has quit IRC | 16:51 | |
| *** ociuhandu has joined #openstack-nova | 16:52 | |
| *** ociuhandu_ has joined #openstack-nova | 16:57 | |
| *** hack-char has quit IRC | 17:00 | |
| *** khomesh24 has quit IRC | 17:00 | |
| *** ociuhandu has quit IRC | 17:00 | |
| *** ociuhandu_ has quit IRC | 17:01 | |
| *** hack-char has joined #openstack-nova | 17:01 | |
| *** mgariepy has joined #openstack-nova | 17:06 | |
| *** ociuhandu has joined #openstack-nova | 17:07 | |
| *** hack-char has quit IRC | 17:07 | |
| *** lucasagomes has quit IRC | 17:08 | |
| *** hack-char has joined #openstack-nova | 17:09 | |
| *** ociuhandu has quit IRC | 17:11 | |
| *** khomesh24 has joined #openstack-nova | 17:22 | |
| *** rpittau is now known as rpittau|afk | 17:24 | |
| *** jraju__ has quit IRC | 17:29 | |
| stephenfin | oh, lovely http://paste.openstack.org/show/803882/ | 17:57 |
| stephenfin | creating a resource provider on placement with a duplicate name results in a HTTP 5xx | 17:58 |
| melwitt | amazed that hasn't been hit until now | 17:59 |
| stephenfin | You and me both. That's super dumb | 17:59 |
| melwitt | hehehe | 18:00 |
| stephenfin | I won't be able to work on it today, but if anyone else has time the simple reproducer is to use microversion 1.20 and create a resource provider specifying only the name | 18:00 |
| stephenfin | nope, don't even need the microversion | 18:01 |
| stephenfin | $ openstack resource provider create foo; openstack resource provider create foo | 18:01 |
| stephenfin | delightful | 18:01 |
| melwitt | :) | 18:01 |
| melwitt | that'd be easy to add to the gabbits I think | 18:02 |
| *** jamesdenton has quit IRC | 18:04 | |
| *** jamesdenton has joined #openstack-nova | 18:05 | |
| stephenfin | for sure | 18:05 |
| stephenfin | I'll take a look tomorrow, no doubt | 18:05 |
| melwitt | kewl | 18:05 |
| *** andrewbonney has quit IRC | 18:12 | |
| *** rcernin has joined #openstack-nova | 18:19 | |
| *** khomesh24 has quit IRC | 18:21 | |
| *** rcernin has quit IRC | 18:23 | |
| *** dtantsur|brb is now known as dtantsur | 18:33 | |
| *** Techy2493 has joined #openstack-nova | 18:45 | |
| sean-k-mooney | we defintly have hit duplicte RPs before | 18:55 |
| sean-k-mooney | but i tough that gave you a 4XX error | 18:55 |
| sean-k-mooney | you get this if you rename a compute node and change its hostname or you delete the compute service and its created with a different uuid | 18:56 |
| sean-k-mooney | sorry only the later case has the name conflcit | 18:56 |
| sean-k-mooney | where you keep the same compute node hostname but delete the compute service and let it get recteated | 18:56 |
| sean-k-mooney | the compute service uuid change but the RP name will be the same | 18:57 |
| sean-k-mooney | stephenfin: melwitt we have test for that in placment already i think https://github.com/openstack/placement/blob/master/placement/tests/functional/gabbits/resource-provider-duplication.yaml | 18:58 |
| sean-k-mooney | https://github.com/openstack/placement/blob/master/placement/tests/functional/gabbits/resource-provider-duplication.yaml#L30-L37 | 18:59 |
| sean-k-mooney | same name different uuid | 18:59 |
| sean-k-mooney | stephenfin: it shoudl return a 409 ^ | 18:59 |
| sean-k-mooney | stephenfin: those test are 4 years old too | 18:59 |
| sean-k-mooney | so something else is going on | 19:00 |
| sean-k-mooney | https://bugs.launchpad.net/nova/+bug/1693349 | 19:00 |
| openstack | Launchpad bug 1693349 in OpenStack Compute (nova) "trying to create a resource provider with an already in use uuid causes misleading error" [Low,Fix released] - Assigned to Chris Dent (cdent) | 19:00 |
| *** Techy2493 has quit IRC | 19:01 | |
| sean-k-mooney | stephenfin: fixed by https://review.opendev.org/c/openstack/nova/+/468928/ | 19:02 |
| sean-k-mooney | stephenfin: where did you get that failure form ? | 19:02 |
| sean-k-mooney | it was fixxed in nova in queens before placment was split out | 19:03 |
| *** ralonsoh has quit IRC | 19:07 | |
| *** dtantsur is now known as dtantsur|afk | 19:08 | |
| *** terdei has joined #openstack-nova | 19:46 | |
| *** belmoreira has quit IRC | 20:14 | |
| *** tbachman has quit IRC | 20:18 | |
| *** tbachman has joined #openstack-nova | 20:31 | |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/nova stable/rocky: Use subqueryload() instead of joinedload() for (system_)metadata https://review.opendev.org/c/openstack/nova/+/761813 | 20:41 |
| *** ociuhandu has joined #openstack-nova | 20:43 | |
| *** ociuhandu has quit IRC | 20:48 | |
| *** jamesdenton has quit IRC | 20:52 | |
| *** jamesden_ has joined #openstack-nova | 20:52 | |
| *** hamalq has quit IRC | 20:59 | |
| *** hamalq has joined #openstack-nova | 21:00 | |
| *** rcernin has joined #openstack-nova | 21:01 | |
| *** rcernin has quit IRC | 21:01 | |
| *** rcernin has joined #openstack-nova | 21:02 | |
| *** tbachman has quit IRC | 21:06 | |
| *** jangutter has joined #openstack-nova | 21:22 | |
| *** jamesden_ has quit IRC | 21:25 | |
| *** jamesdenton has joined #openstack-nova | 21:25 | |
| *** jangutter_ has quit IRC | 21:25 | |
| melwitt | lyarwood: can't remember if I've linked you this gate bug I opened semi recently so if I didn't, fyi https://bugs.launchpad.net/openstack-gate/+bug/1919920 | 21:26 |
| openstack | Launchpad bug 1919920 in OpenStack-Gate "volume related tests sometimes fail with "Could not open '/dev/sdb': Permission denied" on stable/(ussuri|train|stein)" [Undecided,New] | 21:26 |
| melwitt | seeing it on stable | 21:27 |
| *** Techy2493 has joined #openstack-nova | 22:06 | |
| *** rcernin has quit IRC | 22:11 | |
| *** rcernin has joined #openstack-nova | 22:26 | |
| *** whoami-rajat has quit IRC | 22:30 | |
| *** rcernin has quit IRC | 22:31 | |
| *** rcernin has joined #openstack-nova | 22:32 | |
| *** ganso has quit IRC | 22:41 | |
| *** vishalmanchanda has quit IRC | 22:41 | |
| *** ganso has joined #openstack-nova | 22:44 | |
| *** Techy2493 has quit IRC | 23:00 | |
| *** slaweq has quit IRC | 23:02 | |
| *** macz_ has quit IRC | 23:15 | |
| *** stand has quit IRC | 23:20 | |
| *** jamesdenton has quit IRC | 23:32 | |
| *** jamesdenton has joined #openstack-nova | 23:34 | |
| *** gyee has quit IRC | 23:35 | |
| *** tbachman has joined #openstack-nova | 23:37 | |
| *** Underknowledge has quit IRC | 23:40 | |
| *** efried has quit IRC | 23:48 | |
| *** Underknowledge has joined #openstack-nova | 23:51 | |
| *** Underknowledge has quit IRC | 23:54 | |
| *** Underknowledge has joined #openstack-nova | 23:54 | |
| *** Underknowledge has quit IRC | 23:59 | |
| *** Underknowledge has joined #openstack-nova | 23:59 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!