Thursday, 2021-04-01

*** hamalq has quit IRC00:02
*** ikla has joined #openstack-nova00:07
iklacan I use ceph for my instance and local disk for ephemeral storage?00:08
iklaappears to be either or00:09
iklarbd or local00:09
iklaor can I pass a local partition in?00:10
*** mlavalle has quit IRC00:10
*** martinkennelly has quit IRC00:13
*** jamesden_ has quit IRC00:17
*** jamesdenton has joined #openstack-nova00:18
*** ikla has quit IRC00:36
*** macz_ has joined #openstack-nova00:54
*** ikla has joined #openstack-nova00:55
*** macz_ has quit IRC00:58
*** rcernin_ has joined #openstack-nova00:59
*** rcernin has quit IRC00:59
*** xinranwang has joined #openstack-nova01:49
*** swp20 has joined #openstack-nova01:58
*** brinzhang_ is now known as brinzhang02:04
*** jangutter_ has joined #openstack-nova02:14
*** jangutter has quit IRC02:17
*** rcernin_ has quit IRC02:20
*** rcernin_ has joined #openstack-nova02:25
*** rcernin_ has quit IRC02:39
*** rcernin_ has joined #openstack-nova02:40
*** rcernin_ has quit IRC03:01
*** rcernin_ has joined #openstack-nova03:07
*** jamesdenton has quit IRC03:11
*** jamesdenton has joined #openstack-nova03:12
*** mkrai has joined #openstack-nova03:30
*** tkajinam has quit IRC03:51
*** tkajinam has joined #openstack-nova03:51
*** tkajinam has quit IRC03:52
*** tkajinam has joined #openstack-nova03:53
*** mkrai has quit IRC04:03
*** macz_ has joined #openstack-nova04:12
*** macz_ has quit IRC04:16
*** whoami-rajat has joined #openstack-nova04:17
*** ratailor has joined #openstack-nova04:23
*** xek has quit IRC04:33
*** xinranwang has quit IRC04:38
*** ratailor_ has joined #openstack-nova04:44
*** ratailor has quit IRC04:47
*** mkrai has joined #openstack-nova05:01
*** ratailor__ has joined #openstack-nova05:10
*** ratailor_ has quit IRC05:13
*** Luzi has joined #openstack-nova05:31
*** links has joined #openstack-nova05:47
*** macz_ has joined #openstack-nova05:56
*** macz_ has quit IRC06:01
*** tkajinam has quit IRC06:02
*** tkajinam has joined #openstack-nova06:03
*** tkajinam has quit IRC06:03
*** tkajinam has joined #openstack-nova06:03
*** jangutter has joined #openstack-nova06:05
*** jangutter_ has quit IRC06:08
*** lpetrut has joined #openstack-nova06:30
*** jamesdenton has quit IRC06:42
*** jamesden_ has joined #openstack-nova06:42
*** happyhemant has joined #openstack-nova06:48
*** viks____ has joined #openstack-nova06:55
gibi_awaysean-k-mooney, artom: about requester_id in InstancePciRequest, this is the past info I have about deciding not to put the flavorid into the requester_id https://review.opendev.org/c/openstack/nova/+/625310/25/nova/pci/request.py#22006:58
*** gibi_away is now known as gibi06:58
*** luksky has joined #openstack-nova07:01
*** rcernin_ has quit IRC07:03
*** dklyle has quit IRC07:05
*** lemko has joined #openstack-nova07:08
*** sorin-mihai has quit IRC07:22
*** sorin-mihai has joined #openstack-nova07:22
*** sapd1 has joined #openstack-nova07:23
*** CeeMac has quit IRC07:24
gibibauzas: hi! I've propose and RC2 patch and but a -W on it until next week https://review.opendev.org/c/openstack/releases/+/78420107:27
*** ratailor has joined #openstack-nova07:35
*** ratailor__ has quit IRC07:36
*** xek has joined #openstack-nova07:42
*** jamesden_ has quit IRC07:45
*** jamesdenton has joined #openstack-nova07:45
*** tosky has joined #openstack-nova07:45
*** ociuhandu has joined #openstack-nova07:56
*** MrClayPole has quit IRC08:01
*** lucasagomes has joined #openstack-nova08:02
*** MrClayPole has joined #openstack-nova08:03
*** mkrai has quit IRC08:11
*** ociuhandu has quit IRC08:14
*** ociuhandu has joined #openstack-nova08:15
*** ociuhandu has quit IRC08:21
*** derekh has joined #openstack-nova08:23
gibilyarwood: I put a heavy -1 to https://review.opendev.org/c/openstack/nova/+/78413008:28
sean-k-mooneygibi: we could encode if its the flavorid/port id in the string08:28
sean-k-mooneyi do not belive its defined as a uuid08:28
sean-k-mooneyso we could do flavor/<uuid> and port/<uuid> if we needed too08:29
*** martinkennelly has joined #openstack-nova08:29
sean-k-mooneynormally i would say just add a requester_type08:29
*** ociuhandu has joined #openstack-nova08:29
sean-k-mooneybut that would be a db change08:29
gibisean-k-mooney: it wasn't filled not becasue we don't know what to put there, we did not put flavor there as nobody uses that information08:29
sean-k-mooneyah yes08:30
sean-k-mooneythat makes sense i guess08:30
gibisean-k-mooney: and there later some source information is also added to the ovo in I292a0e2d840bbf657ba6d0932f9a3decbcb2778f08:30
gibihttps://review.opendev.org/c/openstack/nova/+/659101/4/nova/objects/instance_pci_requests.py08:30
sean-k-mooneyyes i remember that08:31
gibiI have no issue if somebody starts adding flavorid tehre08:31
gibithere08:31
sean-k-mooneyya i think we can use store the uuid directly08:31
gibiyepp08:31
sean-k-mooneyand use that source property to figure it out if we need too08:31
gibiand we can add a fallback to the ovo that if the requester_id is None then it looks up the flavor stored in the instance08:32
sean-k-mooneyhave you seen artoms change by the way https://review.opendev.org/c/openstack/nova/+/78416808:33
sean-k-mooneyi still need to properly review it but at first glance this seams like a workable solution going forward08:33
sean-k-mooneyim still debating if we want to add somethign to populate the requeter id for exsiting recoreds08:34
*** ociuhandu has quit IRC08:34
sean-k-mooneypossibly as a nova manage command or something on init_host as a seperate patch08:34
*** sapd1 has quit IRC08:35
sean-k-mooneywhat i was thinkng was loop over all the claimed devices without requester_id set, then lookup the port info form the network info cache and try and use the pci slot to corralte the pci devices to the ports08:36
gibisean-k-mooney: haven't looked that review yet08:39
sean-k-mooneyits still WIP so not quite ready for review yet but the core chagne is there and the previous patch add a functional repoducer which passes after the change08:42
*** ociuhandu has joined #openstack-nova08:44
*** dtantsur|afk is now known as dtantsur08:44
lyarwoodgibi: replied, not sure I agree tbh, seems like a trivial requirement to codify to avoid operators borking things08:45
lyarwoodgibi: we had an example downstream of evacuations from 2019 being cleaned up recently in 2021 that spawned this btw08:45
lyarwoodgibi: somehow in the iterim the instance(s) had been migrated back to the original host08:46
lyarwoodgibi: I assume with manual operator intervention to cleanup instance dirs etc08:46
lyarwoodgibi: thankfully no data was lost but I'm just trying to avoid a future situation where we don't get as lucky08:46
lyarwoodgibi: and again it's specifically for the force down, evacuate and force up usecase. Outside of that I agree that a periodic or something would be useful08:47
gibilyarwood: this is a slippery slope as then when the next bug cames that after force_down + evac the VM volume became corrupted due to two VMs writing it then somebody can say that we should not evacuate a VM if we cannot pervent VM duplication08:47
gibias soon as the admin used force_down we should stop caring08:47
lyarwoodgibi: this isn't trying to resolve any issues during the initial force down08:48
lyarwoodgibi: *only* when the operator forces the service back up08:48
lyarwoodgibi: and we are given the chance to check the state of the migrations08:48
sean-k-mooneyso the alternitive here would be to make the action for what happens when we discover vms in this state configureable08:48
lyarwoodgibi: anything that happens before the force up is out of scope for this08:48
sean-k-mooneylike the running_delete_instance_action08:48
sean-k-mooneyour current behavior is hardcoded reap the instance basically08:49
lyarwoodyeah as I said yesterday sean-k-mooney you would force up the compute service first before moving them08:49
lyarwoodmoving them back*08:49
lyarwoodso checking during force up makes more sense tbh08:49
*** ociuhandu has quit IRC08:49
*** ociuhandu has joined #openstack-nova08:50
gibilyarwood: so the goal is to check if the system is in consistent state before we allow forecing the compute up08:50
*** ociuhandu has quit IRC08:50
sean-k-mooneyya im not really against that check but i do kind fo agree with gibi that once they do force down then they are assuming resposiblity to some degree08:50
sean-k-mooneygibi: yes08:50
lyarwoodgibi: correct, evacuation migration records in done with a source host pointing at the localhost meaning a service restart is required08:51
*** ociuhandu has joined #openstack-nova08:51
lyarwoodsean-k-mooney: yup agree but docs have been proven time and time again not to be enough to avoid PEBKAC08:51
sean-k-mooneylyarwood: would an alternitive be to do an rpc on force up?08:51
sean-k-mooneybasically to trigger what woudl be done on service restart08:52
lyarwoodsean-k-mooney: yeah we could do that moving forward and backport this check?08:52
sean-k-mooneywell i dont know if that was a good idea or not08:52
lyarwoodsean-k-mooney: and/or have a periodic that triggers this08:52
sean-k-mooneyjust tinking things through08:53
gibisean-k-mooney: while you could trigger the evac cleanup during force up we could think through what else needs to be done. Like clean up local deleted instances.08:53
lyarwoodwe have a periodic for that right08:53
sean-k-mooneylocal deleted yes08:53
sean-k-mooneyi tought we did for evacuated instance but stephenfin did not find one when he quickly search on the triage call08:54
sean-k-mooneyit might exist already but proably not08:54
gibilyarwood: yepp we have _cleanup_running_deleted_instances08:54
gibisean-k-mooney: there is no periodic for evac cleanup I've checked08:54
gibiwe have _error_out_instances_whose_build_was_interrupted during init_host as well08:56
gibithat also someting that is only done in init_host08:56
gibias might need to be done after forece up08:56
sean-k-mooneyon a related note there was also  https://review.opendev.org/c/openstack/nova/+/627765 before08:57
*** jangutter_ has joined #openstack-nova08:57
sean-k-mooneyin this case looking at orpahned instance which are deleted instance that have been purged from the database before that periodic runs08:58
gibianyhow we are divergin. Lee only wants a backportable thing now08:58
lyarwoodLee always wants a backportable thing ;)08:58
sean-k-mooneyyes to block  more latent vms in thsi state08:59
lyarwoodbut yeah I think this API change is backportable, a periodic could also be but adding a RPC call from the API during force up wouldn't be08:59
sean-k-mooneylyarwood: i assume we woudl return a 40908:59
lyarwoodyup08:59
lyarwoodthat's how I've written it at the moment09:00
sean-k-mooneyproably with that is its a new return code09:00
gibiI still don't like trying to build in safety into a workflow that we marked unsafe at the beginning. But if you frame the whole thing in a way that before nova assumes responsibility again about this compute node after a force_down we do some consistency check, then I can be convinced to remove my -109:00
sean-k-mooneywhich is normally a microverison bump09:00
*** jangutter has quit IRC09:00
lyarwoodyeah but AFAIK we don't require microversion bumps for new error codes09:00
sean-k-mooneyi think we do09:00
lyarwoodI've asked gmann about this before09:00
sean-k-mooneyit think that only if we are converting from a 50009:00
sean-k-mooneyto the flow chart09:01
*** ociuhandu has quit IRC09:01
lyarwoodsean-k-mooney: I was just looking for that, can you share the link?09:02
sean-k-mooneyhttps://docs.openstack.org/nova/latest/contributor/microversions.html09:02
lyarwoodta09:02
sean-k-mooneyso yes we need a microversion if you  use 40909:02
sean-k-mooneyso 400?09:02
gibiI think we need to keep it 400 for a backportable fix09:02
gibicurrent clients are not prepared for 40909:02
gibiso it is breaking them09:02
sean-k-mooneyyep09:03
lyarwoodkk understood, with a TODO to move to 409 with a new microversion in Xena?09:04
sean-k-mooneyam sure we could09:05
gibihm09:05
sean-k-mooneyas long as we have a good error message09:05
gibiwe have have this as well09:05
sean-k-mooneyi dont know if its needed09:05
gibi        An obvious regression bug in an admin-only API where the bug can still be fixed upstream on active stable branches. Admin-only APIs are less of a concern for interoperability and generally a regression in behavior can be dealt with as a bug fix when the documentation clearly shows the API behavior was unexpectedly regressed. See 3 for an example. Intentional behavior changes to an admin-only09:05
gibiAPI do require a microversion, like the 2.53 microversion for example.09:05
gibinvm, this bug is not a regression09:05
gibiit is a new behavior09:06
sean-k-mooneycorrect and the other exemption https://docs.openstack.org/nova/latest/contributor/microversions.html#id309:06
sean-k-mooneyalso does not apply to 40909:06
sean-k-mooneyalso this is not a 50009:06
gibilyarwood: yeah, let's keep a todo for Xena09:07
*** mkrai has joined #openstack-nova09:07
sean-k-mooneylyarwood: you coudl just write both patches now. technially master is now xena09:07
sean-k-mooneyalthough we might want to hold off api microverion bumps until the release is actully done09:08
lyarwoodyup I'll get it posted later today before the break (./me is off until Tuesday after today).09:08
gibiyepp, master is not fully open to Xena yet09:08
lyarwoodthanks both :)09:08
sean-k-mooneyya ill be on pto till tuesday too09:09
gibiI guess it is true for most of us09:11
sean-k-mooneylyarwood: by the way partly while im off and partly early next week i plann to dismantel my home cloud and reinstall it and do some hardware tweeks09:12
sean-k-mooneydo you need any data form your vms09:12
lyarwoodsean-k-mooney: ack, nope I don't nuke away09:12
sean-k-mooneycool ill be backing up a few thign but one of the change ill be doing is swaping my current cinder lvm sotrage for ceph so ill be easing most of the stroage09:13
sean-k-mooneyalso doing an os reinstall moving form cenots 8 to stream wroked for a while but now im getting some repo conflictis so doing a reinstall to fix that09:14
lyarwoodhuh I had assumed this was all running on Ubuntu tbh09:14
lyarwoodbut cool09:14
*** ociuhandu has joined #openstack-nova09:14
sean-k-mooneyhehe well it will be soon09:14
sean-k-mooneystephenfin: convicned me to try centos 8 for it then it lifecycle changed09:15
stephenfindon't dare try to shift the blame to me - this is all on you :P09:15
sean-k-mooneyit is09:15
stephenfinyour fault for listening to me ;)09:16
sean-k-mooneyi also listend to you about tryign fedora on my laptop09:16
sean-k-mooneyi should have know better09:16
stephenfinha!09:16
stephenfinfair09:16
sean-k-mooneybut ya am the version of container d that is ship in stream is not happy with docker09:16
kashyapIt's not all that bad ;-)09:16
* stephenfin has been bitten by Fedora bugs twice in the past month, but is sticking with it09:16
sean-k-mooneyso i had to pin the packages09:16
stephenfinmainly for multiple Python versions without external repos09:17
kashyapAlso, a gentle reminder: many virt and kernel bugs get first fixed in Fedora09:17
sean-k-mooneyi have hit a few other things like that that im hoping to avoid09:17
sean-k-mooneykashyap: yep but i very realy hit those09:17
stephenfinkashyap: You'd swear you worked for Red Hat or something 0:)09:17
kashyapstephenfin: LOL, it's not about Red Hat, really :)09:17
sean-k-mooneykashyap: what i have hit is selinux being unhappy with me on fedora alot09:17
kashyapstephenfin: I'm speaking with my upstream hat, really :)09:17
lyarwoodsean-k-mooney: there's a command and a shiny website for that problem09:18
lyarwoodmakes someone cry however so you might not want to try it09:18
sean-k-mooneyset it to permissive mode09:18
kashyapstephenfin: Also, I closely w/ the virt upstreams and downstreams to the point that I feel part of those teams too :)09:19
lyarwoodsean-k-mooney: https://stopdisablingselinux.com/09:19
kashyapsean-k-mooney: It's not about bugs, per se.  Even new virt features first land in Fedora, BTW :)09:19
kashyapAnd kernel, of course09:19
lyarwoodbut yeah selinux can be a royal PITA09:19
sean-k-mooneylyarwood: well i have tried using the command to updat the policy that you get prometed with when there is a failure by the way09:20
kashyaplyarwood: Go tell that to Red Hat It's part of the value prop ;-)09:20
sean-k-mooneykashyap: sure but i dont want bleeding edge for my infra i was new but stable which is why i normally go with debiab/ubuntu distros with the mainline kernel09:21
lyarwoodit can add value and still be a PITA to use ;)09:21
sean-k-mooneycentos with some tweeks i coudl live with09:21
sean-k-mooneyfedora not so much for anything i want to not have to maintain too much09:21
kashyaplyarwood: Heh, sure09:22
kashyaplyarwood: It took me and RHT virt team several weeks to debug a crazy VMs+container interaction bug.09:22
sean-k-mooneykashyap: lyarwood  by the way the main thing that anowyed me about selinux recently is it does not allow you to use iso form your home directoy to create vms in virt-manager09:23
kashyaplyarwood: Here's my summary notes, for your "bedtime SELinux reading": https://kashyapc.fedorapeople.org/SELinux_libvirt_and_QEMU_in_a_container.html09:23
* kashyap ducks09:23
sean-k-mooneyi rememebr you working on that ya09:23
lyarwoodsean-k-mooney: yeah I've updated policykit to launch domains as my normal user without sudo but I still copy disks into /var/lib/libvirt/images etc09:24
sean-k-mooneyto be fair apparmor is not nessisarly any eaiser to debug or work with so i think any security system is going to be complex by nature of all the context they need to work and that you need to understand them09:25
sean-k-mooneyits those kind of things that are unfreidly to new comers and make distos feel unpolished however09:27
sean-k-mooneyi kind of get why you might not want libvirt or qemu being able to read/write your home directory09:27
sean-k-mooneybut since i can add it as a location in virt manger and select the image i would expect it to work or give me an error when i try to add the storage pool location09:28
lyarwoodremind me again, where are the irc chat logs for this channel?09:29
sean-k-mooneyill get it one sec09:29
sean-k-mooneyhttp://eavesdrop.openstack.org/irclogs/%23openstack-nova/09:29
lyarwoodta09:29
*** luksky has quit IRC09:41
*** luksky has joined #openstack-nova09:42
sean-k-mooneygibi: shall i prepare the patch to move the implemtned specs to the correct directory? have the blueprints been updated in launchpad?09:44
sean-k-mooneyim mostly done i need to fix a few files names too wehre the file name did not match the blueprint name09:55
*** sapd1 has joined #openstack-nova09:56
*** k_mouza has joined #openstack-nova09:56
*** elod is now known as elod_afk10:01
*** zzzeek has quit IRC10:03
*** zzzeek has joined #openstack-nova10:05
sean-k-mooneylyarwood: mind if i create a second blueprint for the linux part of the ephemeral sotrage encyption10:06
sean-k-mooneylyarwood: the spec repo tooling assume the file name of the spec matches the repo10:06
sean-k-mooney*blueprint10:06
sean-k-mooneybut we have 2 specs for the saem bluepinrt10:06
sean-k-mooneyi can also just move or in this case not move that one by hand10:06
sean-k-mooneywhich ever you prefer10:07
lyarwoodsean-k-mooney: yeah I don't mind having a second blueprint for the libvirt part10:07
lyarwoodsean-k-mooney: keeps the bean counters happy :)10:08
sean-k-mooneyok ill creeated and make one depend on the the other10:08
sean-k-mooney* create it10:08
lyarwoodcool TIL you can do that with blueprints10:09
sean-k-mooneyyep we rarely do and i have not don it in a very long time so trying to rememebr how10:10
gibisean-k-mooney: thanks for preparing that patch I forgot10:11
sean-k-mooneyno worries i did it last time i think and i have done it at least one other time so i dont mind the script does most of the work10:12
sean-k-mooneyjust fixing the warnign form the inccorect file names now10:12
gibithanks10:14
sean-k-mooneylyarwood: there https://blueprints.launchpad.net/nova/+spec/ephemeral-encryption-libvirt you can see the depency tree at the bottom10:19
sean-k-mooneywe dont ofter use that feature but when doing cross project stuff we proably shoudl use it more10:20
*** swp20 has quit IRC10:23
*** ociuhandu has quit IRC10:39
openstackgerritsean mooney proposed openstack/nova-specs master: Move the implemented specs for the wallaby release  https://review.opendev.org/c/openstack/nova-specs/+/78436910:39
sean-k-mooneygibi: so assuming the blueprint status is correcct that should be correct10:41
sean-k-mooneylooking at the list we had a fairly good completion ratio10:41
gibiyepp we had ~70%10:49
*** sapd1 has quit IRC10:53
*** k_mouza has quit IRC11:04
*** ociuhandu has joined #openstack-nova11:09
*** mkrai has quit IRC11:10
*** rcernin_ has joined #openstack-nova11:11
*** k_mouza has joined #openstack-nova11:12
*** sapd1 has joined #openstack-nova11:20
artomWait, how the hell did Zuul not yet run on a patch I proposed last evening?11:21
gibiartom: there was some outage11:21
sean-k-mooneyzuul restart11:21
gibido a recheck to queue it11:22
sean-k-mooneyall pending jobs got lost so just recheck11:22
artomAh11:22
sean-k-mooneyit was mention on th emailing list but i recall was " something something ooo ...."11:22
sean-k-mooneythen i stopped caring11:23
*** ociuhandu has quit IRC11:23
artomLulz11:26
*** k_mouza has quit IRC11:28
*** jamesdenton has quit IRC11:31
*** jamesden_ has joined #openstack-nova11:32
openstackgerritMerged openstack/nova-specs master: Move the implemented specs for the wallaby release  https://review.opendev.org/c/openstack/nova-specs/+/78436911:35
*** rcernin_ has quit IRC11:48
*** ociuhandu has joined #openstack-nova11:52
openstackgerritMerged openstack/nova master: docs: Rewrite 'nova-manage db' docs to use proper directives  https://review.opendev.org/c/openstack/nova/+/67750911:55
openstackgerritMerged openstack/nova master: docs: Rewrite 'nova-manage api_db', 'cell_v2' docs  https://review.opendev.org/c/openstack/nova/+/72619211:56
openstackgerritMerged openstack/nova master: docs: Rewrite 'nova-manage placement' docs  https://review.opendev.org/c/openstack/nova/+/72619311:57
*** ociuhandu has quit IRC11:57
openstackgerritMerged openstack/nova master: docs: Rewrite 'nova-manage libvirt' docs  https://review.opendev.org/c/openstack/nova/+/78150411:58
*** k_mouza has joined #openstack-nova12:00
*** ociuhandu has joined #openstack-nova12:08
*** mkrai has joined #openstack-nova12:09
*** ociuhandu has quit IRC12:13
*** jraju__ has joined #openstack-nova12:17
*** links has quit IRC12:17
*** mkrai has quit IRC12:18
*** ociuhandu has joined #openstack-nova12:24
*** bhagyashris has quit IRC12:28
*** ociuhandu has quit IRC12:29
*** bhagyashris has joined #openstack-nova12:29
*** sapd1 has quit IRC12:31
gibicores: my today's doctor's appointment got pushed back to 17:50 CEST which means I cannot chair today's nova meeting. I updated the agenda on the wiki, and I might be able to follow the meeting. Who will volunteer to chair the meeting?12:38
*** jangutter_ is now known as jangutter12:38
*** ociuhandu has joined #openstack-nova12:40
*** ratailor has quit IRC12:45
*** ociuhandu has quit IRC12:47
gibilyarwood, bauzas, stephenfin, ^^ any volunteers :)12:55
bauzasgibi: i can do12:55
gibibauzas: thanks, it is sold to you then :)12:55
bauzas18:00 CEST, right?12:55
gibi18:00 CEST yes12:55
bauzaskk12:55
*** stand has joined #openstack-nova12:55
bauzasgibi: any agenda already ?12:56
gibibauzas: the agenda is up to date on the wiki https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting12:56
*** ociuhandu has joined #openstack-nova13:00
bauzasgibi: all good, thanks13:02
bauzasgibi: fwiw, as schools are closing next week, I'll take 2 days off on next Thursday and Friday13:02
gibibauzas: ack,13:03
bauzas(and Monday is a bank holiday)13:03
bauzasthen, children will be on vacations for 2 weeks and then back to schools (hopefully)13:03
*** ociuhandu has quit IRC13:04
*** ociuhandu has joined #openstack-nova13:05
*** jamesden_ has quit IRC13:07
*** jamesdenton has joined #openstack-nova13:07
stephenfingibi: If you've a chance, could you take a look at https://review.opendev.org/c/openstack/nova/+/726195/ and the other few patches in that series today? Would be nice to close that out13:10
gibistephenfin: will try13:14
stephenfingood enough for me. Thanks13:14
*** jamesdenton has quit IRC13:19
*** jamesden_ has joined #openstack-nova13:20
*** Luzi has quit IRC13:25
*** derekh has quit IRC13:33
*** derekh has joined #openstack-nova13:34
*** dklyle has joined #openstack-nova13:36
*** derekh has quit IRC13:36
*** derekh has joined #openstack-nova13:36
yonglihegibi, alex,  xinren repropose the spec, hope you have time slot for that. btw, code alse rebased and addressed comments:  Repropose smartnic support spec https://review.opendev.org/c/openstack/nova-specs/+/78363213:46
gibiyonglihe: ack13:46
yonglihethanks, i gonna run, have a good day.13:47
gmannsean-k-mooney: lyarwood gibi basically if new return error code is new to that API (not from existing one) then we need microversion bump. and these are general return error code for all APis 400, 403, 404 and 41513:49
gmannsean-k-mooney: lyarwood gibi which APIs is this? I think most of server APIs have 409 exist return code13:51
gibios-services/{id}/force_doewn PUT13:55
gmannyeah 409 is not there https://github.com/openstack/nova/blob/50fdbc752a9ca9c31488140ef2997ed59d861a41/nova/api/openstack/compute/services.py#L35813:59
gibiyepp14:02
gibiI accept 400 as a compromise for backportability14:02
gmann+114:03
sean-k-mooneygmann: yep that is basically what we discusssd on irc this morning 400 for backport reasons. 409 is more correct but would require version bump so we cant use it14:17
sean-k-mooneyat least not yet14:17
sean-k-mooneywe can make it use 409 in a followup patch if we wish too14:17
*** sapd1 has joined #openstack-nova14:20
gmannbut we would not be able to backport 409 if do in follow up due to microvesion bump.14:23
sean-k-mooneycorrect14:27
sean-k-mooneyso we were suggeing using 400 and backporting that14:27
sean-k-mooneyand leavign a todo to make it a 409 at some other point in the future14:27
sean-k-mooneywe coudl bundel it with some of the ohter todos we have14:28
sean-k-mooneywe have one for consitent return codes for unimplemnted feature for example14:28
gmannyeah. make sense14:28
*** elod_afk is now known as elod14:29
*** lbragstad has quit IRC14:36
*** jangutter_ has joined #openstack-nova14:40
*** jangutte_ has joined #openstack-nova14:41
*** jangutter has quit IRC14:42
*** k-s-dean has joined #openstack-nova14:45
*** jangutter_ has quit IRC14:45
*** lpetrut has quit IRC14:45
*** belmoreira has joined #openstack-nova14:58
*** macz_ has joined #openstack-nova15:02
*** tkajinam has quit IRC15:02
*** macz_ has quit IRC15:03
*** macz_ has joined #openstack-nova15:04
*** dtantsur is now known as dtantsur|afk15:06
artomIs Zuul... OK?15:19
artomhttps://downforeveryoneorjustme.com/zuul.opendev.org ah :(15:19
melwittsee #opendev for details, they've been debugging issues since yesterday15:20
*** belmoreira has quit IRC15:22
*** belmoreira has joined #openstack-nova15:28
*** mlavalle has joined #openstack-nova15:33
*** derekh has quit IRC15:45
*** whoami-rajat has quit IRC15:47
bauzasfolks, gentle reminder, nova meeting in 9 mins on #openstack-meeting-315:51
*** lucasagomes has quit IRC15:59
*** ociuhandu has quit IRC16:00
bauzasmeeting started on #openstack-meeting-316:00
*** jraju__ has quit IRC16:08
*** k_mouza has quit IRC16:24
*** ociuhandu has joined #openstack-nova16:27
*** happyhemant has quit IRC16:27
*** ociuhandu has quit IRC16:33
*** jamesden_ has quit IRC16:33
*** jamesdenton has joined #openstack-nova16:34
*** hamalq has joined #openstack-nova16:40
*** k-s-dean has quit IRC16:41
* stephenfin knocks off; back on the 12th o/16:57
gibistephenfin: enjoy o/17:01
*** bbowen_ has quit IRC17:02
*** sorin-mihai has quit IRC17:06
*** k_mouza has joined #openstack-nova17:09
*** jangutter has joined #openstack-nova17:09
*** jangutte_ has quit IRC17:12
*** k_mouza has quit IRC17:13
*** belmoreira has quit IRC17:39
*** viks____ has quit IRC18:07
sean-k-mooneyartom: by the way you proably want https://zuul.openstack.org/18:18
sean-k-mooneyhttps://zuul.opendev.org/tenants has all then tenants18:19
sean-k-mooneybut zuul.openstack.org will show you the openstack ci dashboard18:19
artomsean-k-mooney, I was just copy-pasting from the logs url18:34
openstackgerritLee Yarwood proposed openstack/nova master: Add regression test for bug #1922053  https://review.opendev.org/c/openstack/nova/+/78412918:41
openstackbug 1922053 in OpenStack Compute (nova) "Operators can force up compute services with `done` evacuation migration records still active against the host" [Medium,In progress] https://launchpad.net/bugs/1922053 - Assigned to Lee Yarwood (lyarwood)18:41
openstackgerritLee Yarwood proposed openstack/nova master: api: Reject requests to force up computes when `done` evacuation records exist  https://review.opendev.org/c/openstack/nova/+/78413018:41
*** jamesdenton has quit IRC18:48
*** jamesden_ has joined #openstack-nova18:48
*** jangutter_ has joined #openstack-nova19:32
*** jangutter has quit IRC19:35
*** jamesden_ is now known as jamesdenton19:46
*** slaweq_ has joined #openstack-nova19:51
*** slaweq has quit IRC19:52
*** CeeMac has joined #openstack-nova19:54
*** ociuhandu has joined #openstack-nova20:20
*** k_mouza has joined #openstack-nova20:25
openstackgerritArtom Lifshitz proposed openstack/nova master: Neutron fixture: don't clobber profile and vif_details if empty  https://review.opendev.org/c/openstack/nova/+/78338520:27
openstackgerritArtom Lifshitz proposed openstack/nova master: Test SRIOV port move operations with PCI conflicts  https://review.opendev.org/c/openstack/nova/+/78308420:27
openstackgerritArtom Lifshitz proposed openstack/nova master: Update SRIOV port pci_slot when unshelving  https://review.opendev.org/c/openstack/nova/+/78416820:27
sean-k-mooney:)20:28
sean-k-mooneyno more WIP20:28
artomYeah, rewrite the ugly [0] logic, and added a unit test20:28
artomAnd a release note20:28
artomAnd the bug reference20:28
artomAnd my axe!20:28
sean-k-mooneyah yes your using next()20:29
*** k_mouza has quit IRC20:29
sean-k-mooneyyou technially have extra ()20:29
sean-k-mooneythat you dont need20:29
sean-k-mooneyequest = next((r for r in instance.pci_requests.requests20:30
sean-k-mooney                            if r.requester_id == port['id']))20:30
artomNo, that's needed20:30
artomWait, is it?20:30
artomMaybe it isn't...20:30
artomWhat you pass to next() has to be an interator20:30
sean-k-mooneyyou are creating a touple20:30
artom*iterator, not a list/tuple20:31
sean-k-mooneybut you can pass the generator expression driectly to next20:31
sean-k-mooneyiterator or generator20:31
sean-k-mooney"r for r in instance.pci_requests.requests" is a generator expression20:31
artomOh yeah, works without the extra ( )20:32
artomTIL20:32
openstackgerritArtom Lifshitz proposed openstack/nova master: Update SRIOV port pci_slot when unshelving  https://review.opendev.org/c/openstack/nova/+/78416820:32
sean-k-mooneywith the extra () its doing a touple comprehention and then it taking the first element20:32
sean-k-mooneywithout it its iterating the generator untile the first value is yeilded20:32
sean-k-mooneyso its faster too since it will early exit20:33
sean-k-mooneyartom: thats a python 3 thing by the way20:35
artomOh20:35
artomHrmm20:35
artomWell, no, it's fine, Train is Python320:35
sean-k-mooneyits easy to add them back when you get to train20:35
sean-k-mooneyits both20:35
artomAh, it's OSP16 that's py3-only20:35
artomBecause RHEL820:35
sean-k-mooneyussuri was the first one that is pyton 3 only20:36
sean-k-mooneyyes20:36
sean-k-mooneywhich is proably the only time rhel has done someting first :)20:36
artom*snerk*20:37
*** ociuhandu has quit IRC20:38
openstackgerritsean mooney proposed openstack/nova stable/train: add functional regression test for bug #1888395  https://review.opendev.org/c/openstack/nova/+/75953320:40
openstackbug 1888395 in OpenStack Compute (nova) train "live migration of a vm using the single port binding work flow is broken in train as a result of the introduction of sriov live migration" [High,In progress] https://launchpad.net/bugs/1888395 - Assigned to Billy Olsen (billy-olsen)20:40
openstackgerritsean mooney proposed openstack/nova stable/train: Set migrate_data.vifs only when using multiple port bindings  https://review.opendev.org/c/openstack/nova/+/75915320:40
*** luksky has quit IRC20:51
*** luksky has joined #openstack-nova20:51
*** tbachman has quit IRC21:03
*** tbachman has joined #openstack-nova21:11
*** ociuhandu has joined #openstack-nova21:38
*** lemko9 has joined #openstack-nova21:42
*** ociuhandu has quit IRC21:42
*** lemko has quit IRC21:42
*** lemko9 is now known as lemko21:42
*** osmanlicilegi has quit IRC21:44
*** jamesdenton has quit IRC22:10
*** jamesden_ has joined #openstack-nova22:11
*** eharney has quit IRC22:54
*** tkajinam has joined #openstack-nova22:57
*** tkajinam has quit IRC22:57
*** tkajinam has joined #openstack-nova22:58
*** amodi has quit IRC23:14
*** jamesden_ has quit IRC23:24
*** jamesdenton has joined #openstack-nova23:24
*** luksky has quit IRC23:30
*** jangutter_ has quit IRC23:38
*** tosky has quit IRC23:40
*** martinkennelly has quit IRC23:41
*** martinkennelly has joined #openstack-nova23:42
*** macz_ has quit IRC23:50
*** macz_ has joined #openstack-nova23:56

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!