Thursday, 2021-05-06

*** tkajinam has quit IRC00:01
*** tkajinam has joined #openstack-nova00:02
*** LinPeiWen42 has joined #openstack-nova00:40
*** brinzhang has joined #openstack-nova00:47
openstackgerritmelanie witt proposed openstack/nova master: WIP Enable unified limits in the nova-next job  https://review.opendev.org/c/openstack/nova/+/78996300:53
*** martinkennelly has quit IRC01:01
*** whoami-rajat has quit IRC01:04
*** hemanth_n has joined #openstack-nova01:34
*** bbowen_ has quit IRC01:52
*** ebbex has quit IRC01:52
*** tamas_erdei has quit IRC01:52
*** mgoddard has quit IRC01:52
*** smcginnis has quit IRC01:52
*** purplerbot has quit IRC01:52
*** tristanC has quit IRC01:52
*** andreaf has quit IRC01:52
*** mloza has quit IRC01:52
*** Corwin has quit IRC01:53
*** bbowen_ has joined #openstack-nova01:54
*** ebbex has joined #openstack-nova01:54
*** tamas_erdei has joined #openstack-nova01:54
*** mgoddard has joined #openstack-nova01:54
*** smcginnis has joined #openstack-nova01:54
*** purplerbot has joined #openstack-nova01:54
*** tristanC has joined #openstack-nova01:54
*** andreaf has joined #openstack-nova01:54
*** mloza has joined #openstack-nova01:54
*** Corwin has joined #openstack-nova01:54
*** markmcclain has quit IRC01:55
*** markmcclain has joined #openstack-nova01:57
*** brinzhang_ has joined #openstack-nova02:01
*** brinzhang has quit IRC02:05
openstackgerritBrin Zhang proposed openstack/nova master: Replace os-simple-tenant-usage with os-simple-project-usage  https://review.opendev.org/c/openstack/nova/+/76885202:34
openstackgerritBrin Zhang proposed openstack/nova master: Replace tenant_id with project_id in os-quota-sets path  https://review.opendev.org/c/openstack/nova/+/76885102:34
openstackgerritBrin Zhang proposed openstack/nova master: Replace tenant_id with project_id in Limits API  https://review.opendev.org/c/openstack/nova/+/76886202:34
openstackgerritBrin Zhang proposed openstack/nova master: Replace tenant* with project* in codes  https://review.opendev.org/c/openstack/nova/+/76932902:34
*** sapd1_x has joined #openstack-nova02:42
*** macz_ has joined #openstack-nova02:43
openstackgerritDavid Vallee Delisle proposed openstack/os-vif master: Creating oslo.config.opts entry_points for plugins  https://review.opendev.org/c/openstack/os-vif/+/78964502:44
*** sapd1_x has quit IRC02:46
*** macz_ has quit IRC02:47
*** sapd1 has joined #openstack-nova03:22
*** openstackgerrit has quit IRC03:31
*** psachin has joined #openstack-nova03:37
*** mkrai has joined #openstack-nova03:46
*** sorrison has joined #openstack-nova03:54
*** mkrai has quit IRC04:18
*** ratailor has joined #openstack-nova04:32
*** rcernin has quit IRC04:35
*** mkrai has joined #openstack-nova04:38
*** rcernin has joined #openstack-nova04:38
*** mkrai has quit IRC05:41
*** mkrai has joined #openstack-nova05:47
*** zzzeek has quit IRC05:52
*** sapd1 has quit IRC05:52
*** zzzeek has joined #openstack-nova05:54
*** vishalmanchanda has joined #openstack-nova05:57
*** openstackgerrit has joined #openstack-nova05:59
openstackgerritBalazs Gibizer proposed openstack/placement master: Adapt to SQLAlchemy 1.4  https://review.opendev.org/c/openstack/placement/+/78992105:59
openstackgerritBalazs Gibizer proposed openstack/placement master: DNM: test with SQLAlchemy 1.4  https://review.opendev.org/c/openstack/placement/+/78992205:59
*** slaweq has joined #openstack-nova06:15
*** dklyle has quit IRC06:18
*** ralonsoh has joined #openstack-nova06:31
*** whoami-rajat has joined #openstack-nova06:35
*** mkrai has quit IRC06:50
*** _mlavalle_1 has joined #openstack-nova07:12
*** andrewbonney has joined #openstack-nova07:13
*** rpittau|afk is now known as rpittau07:14
*** belmoreira has joined #openstack-nova07:15
*** mlavalle has quit IRC07:15
*** ociuhandu has joined #openstack-nova07:17
*** sapd1 has joined #openstack-nova07:22
*** rcernin has quit IRC07:36
openstackgerritBalazs Gibizer proposed openstack/placement master: Adapt to SQLAlchemy 1.4  https://review.opendev.org/c/openstack/placement/+/78992107:36
openstackgerritBalazs Gibizer proposed openstack/placement master: DNM: test with SQLAlchemy 1.4  https://review.opendev.org/c/openstack/placement/+/78992207:37
openstackgerritmelanie witt proposed openstack/nova master: WIP Enable unified limits in the nova-next job  https://review.opendev.org/c/openstack/nova/+/78996307:43
*** tosky has joined #openstack-nova07:47
openstackgerritmelanie witt proposed openstack/nova master: WIP Enable unified limits in the nova-next job  https://review.opendev.org/c/openstack/nova/+/78996307:48
*** ociuhandu has quit IRC07:50
openstackgerritmelanie witt proposed openstack/nova master: WIP Enable unified limits in the nova-next job  https://review.opendev.org/c/openstack/nova/+/78996307:54
*** dtantsur|afk is now known as dtantsur07:56
*** derekh has joined #openstack-nova08:00
*** sapd1 has quit IRC08:01
*** rcernin has joined #openstack-nova08:01
*** sapd1 has joined #openstack-nova08:04
*** rcernin has quit IRC08:07
*** lucasagomes has joined #openstack-nova08:09
*** hemanth_n has quit IRC08:10
*** rcernin has joined #openstack-nova08:20
*** nightmare_unreal has joined #openstack-nova08:21
*** ociuhandu has joined #openstack-nova08:21
*** rcernin has quit IRC08:26
*** ociuhandu has quit IRC08:29
*** rcernin has joined #openstack-nova08:34
*** mkrai has joined #openstack-nova08:37
*** martinkennelly has joined #openstack-nova08:37
*** ociuhandu has joined #openstack-nova08:58
*** ociuhandu_ has joined #openstack-nova09:01
openstackgerritTakashi Natsume proposed openstack/python-novaclient master: Refactor constructing request body  https://review.opendev.org/c/openstack/python-novaclient/+/79001709:01
*** ociuhandu has quit IRC09:04
*** sapd1 has quit IRC09:23
*** k_mouza has joined #openstack-nova09:31
*** rcernin has quit IRC09:32
*** ociuhandu_ has quit IRC09:36
*** ociuhandu has joined #openstack-nova09:37
*** k_mouza has quit IRC10:00
*** k_mouza has joined #openstack-nova10:06
sean-k-mooneygibi: do you remember this http://lists.openstack.org/pipermail/openstack-discuss/2019-November/011044.html10:08
gibisean-k-mooney: yes10:08
sean-k-mooneywe might need to go impmente the api change and neutron code10:08
gibiI think we fixed it in neutron10:08
sean-k-mooneynope10:09
sean-k-mooneyits still using socket.gethostname()10:09
gibihttps://bugs.launchpad.net/neutron/+bug/185384010:09
openstackLaunchpad bug 1853840 in neutron "Neutron fails to create bandwidth providers if CONF.host is set" [High,Fix released] - Assigned to Bence Romsics (bence-romsics)10:09
gibithere is configuration to override it10:09
gibiat least in neutron10:09
sean-k-mooneythere is10:09
sean-k-mooneybut you should not need to do that by default10:10
sean-k-mooneyhttps://bugzilla.redhat.com/show_bug.cgi?id=1900500 and https://bugzilla.redhat.com/show_bug.cgi?id=195207310:11
openstackbugzilla.redhat.com bug 1900500 in openstack-neutron "Hostname in neutron agent's config don't match what is stored in placement by nova" [High,New] - Assigned to skaplons10:11
openstackbugzilla.redhat.com bug 1952073 in openstack-nova "[OSP16.1] Failed to schedule VMs with minimum bandwidth - SR-IOV bandwidth aware scheduling" [High,Closed: duplicate] - Assigned to nova-maint10:11
sean-k-mooneyare basically caused by this10:11
sean-k-mooneythey could use the config options10:11
gibithe fix was the config opiton10:11
gibioption10:11
gibiI don't get why they don't use it10:11
gibiwhy they cannot use it10:11
sean-k-mooneythey could but really neutron should use the hypervior api no?10:12
sean-k-mooneygibi: they can totally workaround it using the config options10:13
gibiI assume this naming is static so it can be configured deployment time10:13
sean-k-mooneyit could but the UX of that approch sucks10:13
sean-k-mooneyit works but it would be nice if it just worked out of hte box10:14
gibiI don't get how this can be working without input from the deployer who know what are the matching host names10:14
sean-k-mooneyby default socket.gethostname() will match the hostname returned by libvirt10:15
gibiif the neutron agent sees a different hostname than the nova-compute then how can the nova hypervisor API help in that10:15
sean-k-mooneygibi: we reqire the [DEFAULT]/host config option to be the same in both the nova and neutron config10:16
sean-k-mooneyso you can find the compute service assocatied with the host10:16
sean-k-mooneythen get its uuid10:17
gibiso the problematic case is when the hypervisor_hostname != hostname? But why that happen in case of libvirt?10:17
sean-k-mooneybecause of https://github.com/libvirt/libvirt/blob/master/src/util/virutil.c#L454-L47310:17
sean-k-mooneyif you have the fqdn as the canonical host name in /etc/hosts then libvirt will return an fqdn but socket.gethostname() will be the short hostname10:18
*** mkrai has quit IRC10:18
gibiand don't we require CONF.host to be set to fqdn is enough in this case?10:19
gibisorry my english is breaking up :010:20
gibiso if in this case CONF.host is set to fqdn then everything is in synch isn't it?10:20
sean-k-mooneynope ooo already hardcodes that to the fqdn10:20
gibidon't we use that fqdn as the RP name ?10:21
sean-k-mooneyno10:21
sean-k-mooneywell somethimes10:21
sean-k-mooneywe do not use the config value10:21
sean-k-mooneyso we use what libvirt returns10:21
sean-k-mooneysocket.gethostname will never be the fqdn10:22
*** k_mouza has quit IRC10:22
sean-k-mooneylibvirt will return the fqdn if you have "172.17.1.17 compute-0.redhat.local compute-0" and short name if you have "172.17.1.17 compute-0 compute-0.redhat.locaL"10:22
sean-k-mooneygibi: one way to fix this is to try using the hostname and then the fqdn to lookup the rp10:23
sean-k-mooneygibi: we could also start using socket.gethostname in nova in the libvirt driver10:24
sean-k-mooneyfor hypervior hostname10:24
*** rcernin has joined #openstack-nova10:24
*** rcernin has quit IRC10:25
*** rcernin has joined #openstack-nova10:25
sean-k-mooneygibi: we can look at fixing this in ooo10:27
sean-k-mooneyby having it generate the name that libvirt will return and put it in the neutorn config or we can do https://bugzilla.redhat.com/show_bug.cgi?id=195736310:27
openstackbugzilla.redhat.com bug 1957363 in tripleo-ansible "Canonical name should be a short name instead of FQDN" [High,New] - Assigned to rhos-maint10:27
*** tesseract has joined #openstack-nova10:27
*** k_mouza has joined #openstack-nova10:28
gibiI see that the name returned from libvirt is highly host configuration dependent. But I don't think we have to automate all the possible combinations to work, if there is at least one set of configuration that make the system work for every libvirt case10:28
sean-k-mooneywell since this is not a problem with devstack as we see form the ci jobs it pretty clear that its actully caused by ooo's configuration of the host10:29
sean-k-mooneygibi: the defualt we have in code do work out of the box just not as deployed by ooo10:29
gibidoes tripleo configures the hostname on the compute host ?10:30
gibiI mean the /etc/hosts and /etc/hostname10:30
sean-k-mooneyyes10:30
sean-k-mooneyboth10:30
sean-k-mooneyit templates out /etc/host with the fqdn first10:30
sean-k-mooneyit alsso sets /etc/hostname10:30
sean-k-mooneyone way to "fix" it woudl be to put the fqdn in /etc/hostname10:31
sean-k-mooneybut that is kind of a hack10:31
gibiso then tripleo can make actually configures (indirectly) what hypervisor hostname libvirt returns10:31
gibis/can make//10:31
sean-k-mooneyyep10:31
gibiand also tripleo configures CONF.host for each services10:31
sean-k-mooneyyep it does10:32
gibiso then tripleo needs to make these configrations consistent10:32
gibiat least in my eyes10:32
sean-k-mooneyyep idealy10:32
sean-k-mooneybut alos in a way that does not change hypervior hostname10:32
sean-k-mooneyon upragde10:32
sean-k-mooneybecause that would break nova10:32
sean-k-mooneyi think the current problem is i think that chnage may have already happened which i might need to check10:33
gibiso the problem is that the current config is not fully consistent and blocks the bandwidth feature, but making the config consistent would result in breaking nova as the we don't tolerate hostname changes10:33
sean-k-mooneywell osp 13(queens) on rhel7 used the same config as as we used in osp 16(train) on rhel 810:35
sean-k-mooneyso in queens we already had placement RPs but only nova used them10:35
sean-k-mooneyi need to alk one of our downstream peopel what the hypervior hostname is on 13 and 16  and see if it has changed10:36
sean-k-mooneyand proably compare the filed bettwen both10:36
sean-k-mooneygibi: at a minim ooo shoudl be setting the neutron hostname mapping automatically when using the bandwith feature10:37
sean-k-mooneygibi: there is a patch against netruon right now https://review.opendev.org/c/openstack/neutron/+/78889310:38
gibiit is needed there as CONF.host is fqdn but libvirt returns short names?10:38
sean-k-mooneygibi: well i think that is actully the correct behaivor10:39
sean-k-mooneyi.e. we have always talk about the hypervior_hostname as beign a hostname not an fqdn10:39
gibiIf we all agree that hypervisor_hostname is always expected to be the shortname, and we require the CONF.host to always be fqdn, then neutron can simply get the shortname out from the fqdn to look up the RP10:41
gibibut if every config can be either short or fqdn in all combinations then we are lost10:41
sean-k-mooneywell we do not retuire CONF.host to alwasy be the fqdn10:41
sean-k-mooneyits normally the sort name too10:41
gibiI think we should write up the list of supported config combinations10:42
gibiand then fix what is broken10:42
sean-k-mooneyright now technially both value can be short name or fqdn10:42
sean-k-mooneybut hypervior_hostname was alwasy intended to be the sortname and host defualt to the short name10:42
sean-k-mooneywe talked about this at the dublin ptg at some lenght as some operators wanted to use FQDNs for both10:43
gibiand libvirt uses fqdn is some cases already based on the comment you linked from the code10:43
sean-k-mooneygibi: yes only if you set the canonical hostname in /etc/hosts to an fqdn10:44
gibiso again, I think we first agree on what config fqdn/sortname combination OpenStack wants to supprot10:44
gibithen fix the system to work in these scenarios10:44
*** k_mouza_ has joined #openstack-nova10:45
*** k_mouza has quit IRC10:45
sean-k-mooneyya10:45
sean-k-mooneyya personally i would prefer to either onlyu use hostname or only use FQDNs10:47
gibiyepp, that would be clean and self consistent all the way10:48
sean-k-mooneyi prefer hostnames but that is just a preference10:48
sean-k-mooneythe delta in function ality is fqdns allows host-1.rack-1.mydomain and host-1.rack-2.mydomain to work10:48
sean-k-mooneywhere as hostnames only requires tehm all to be unique10:49
gibiyepp, I see the need for FQDNs in big deployments10:49
gibior at least accept the need10:49
sean-k-mooneythe only issue if we use FQDNs only is sometime we will still end up with hostnames10:50
sean-k-mooneyi.e. if you dont have the FQDN in /etc/hosts10:50
sean-k-mooneywell that and we told all the other service to use socket.gethostname()10:51
*** sapd1 has joined #openstack-nova10:51
sean-k-mooneyi even changed cyborg to use gethostnaem form getfqdn https://github.com/openstack/cyborg/commit/ec0eab0ffb4fc18574dbd937f29545832d317e4c10:51
sean-k-mooneyafter that intial email thread10:51
sean-k-mooneygibi: part of me feels like we should add a fucntion to oslo.utils10:53
sean-k-mooneyand then just have everyone use that10:53
sean-k-mooneyand then in nova we can perhaps think about have a reshape or soemthing to normalise the RPs10:53
gibiI think you can rename without reshape10:54
sean-k-mooneythe fact this currently depend on the virt driver you use is less then ideal.10:54
sean-k-mooneygibi: ya i think you are right10:54
sean-k-mooneythe allocation dont need to move10:54
gibiyepp10:54
sean-k-mooneywhat we can do its encode the libvirt logic which is in the neutron patch in an oslo patch10:55
sean-k-mooneyand then use that10:55
sean-k-mooneyfor libvirt at least it woudl not change behaivor and for other driver i suspect it wont either10:55
gibiI cannot comment on other drivers cases10:55
sean-k-mooneywell ironic they use the ironic node uuid as the name right?10:56
sean-k-mooneynot sure what hyperv or vmware does10:56
gibiyes. but I don't know if neutron ever needs that10:56
gibithat = ironic node name10:56
sean-k-mooneyya the neutron agent dont run on the ironic nodes10:56
gibiI have to jump to a call from the top of the hour10:57
gibiI linked this discussion to the neutron patch for reference10:57
sean-k-mooneyno worries thanks for litening10:57
sean-k-mooneyill try an follow up downstream and see if we can come to can concreate conclutions10:58
gibiOK10:59
gibisorry for being dense10:59
sean-k-mooneyyou werent being dense10:59
sean-k-mooneyit helped10:59
gibithen I'm glad :)11:00
*** ratailor_ has joined #openstack-nova11:14
*** ratailor has quit IRC11:16
*** sapd1 has quit IRC11:17
*** rcernin has quit IRC11:24
*** zzzeek has quit IRC11:39
*** zzzeek has joined #openstack-nova11:42
*** artom has quit IRC11:48
*** __ministry has quit IRC11:51
*** ociuhandu has quit IRC11:52
*** derekh has quit IRC12:17
*** ociuhandu has joined #openstack-nova12:18
sean-k-mooneygibi: would adding a new weigher need a spec. or could that be a specless blueprint12:18
gibiif the config of the weigher is trivial then I'm OK with a specless bp12:18
sean-k-mooneyi have 2 that i think might be useful. 1 is weighe based on the number of runing instnace and the other is a weigher that prefers the current host an instance is on12:19
gibiplease note that today all the weigher is turned on by default so more weigher means a more complex behavior.12:20
gibi* all the weighers are12:21
sean-k-mooneyyep12:21
sean-k-mooneywe may  or may not want that for these12:22
sean-k-mooneybasically our perf team has a bunch of hosts with differnt size for ram disk and cpu12:22
sean-k-mooneyand they are booting a bunch of small instance and they are all landing on 2 hosts because it has much more ram,cpu and disk then the others12:23
gibiI think it is a valid need to have weighers that are not turned on by default12:24
sean-k-mooneyas in the have 46 hosts and booted about 520 instace at this point and they have 2 host with 237 and 247 instances12:24
sean-k-mooneyso having a pretty dumb weither that jsut spread or packed by instances would help them. im goign to get them to set host_subset_size=46 so its just a random choice for now12:25
sean-k-mooneythat will get the the even distibution they want but i think it coudl be useful12:26
sean-k-mooneythe current host weigher would be so that people that want resize to same host to not change host could expess that preference if they really wanted too by truning on that weither12:27
*** ociuhandu has quit IRC12:27
sean-k-mooneygibi: im going to proably right a mini spec for moveing some of the fitlers to placmenet native approch so i could also add this there too12:27
gibihm, I think if allow_resize_to_same_host=False then we add the scheduler will ignore the current host12:28
sean-k-mooneyjust make it a generic schduling enhancements spec.12:28
gibisean-k-mooney: that also works for me12:28
sean-k-mooneygibi: it will the host manager will remove it12:28
sean-k-mooneybut if you set it to ture there is no prefernce for stayingon the same host or not staying on the same host12:28
gibiohh, I did not know that, then I see why you need the weigher12:29
sean-k-mooneywell need is a stong word but it might be nice ot have12:29
gibiyeah, I agree12:30
sean-k-mooneywe ocationally get customer confused by that, its not that common but it happens12:30
*** ociuhandu has joined #openstack-nova12:41
*** rmart04 has joined #openstack-nova12:42
rmart04Hello, having some IRC issues, hopefully this works!12:42
rmart04I've noticed that in VM's on Stein / host-passthrough cpu mode and dedicated core pinning policy, that the L2 and L3 cache values for the CPU do not match the physical CPU. Is this expected? Any way to configure?12:43
gibibelmoreira: thanks for the report https://bugs.launchpad.net/nova/+bug/1924123 it is an interesting finding. Unfortunately it is not easy to fix.12:47
openstackLaunchpad bug 1924123 in OpenStack Compute (nova) "If source compute node is overcommitted instances can't be migrated" [Medium,Triaged]12:47
*** ratailor_ has quit IRC12:47
sean-k-mooneyrmart04: yes12:50
sean-k-mooneyyou can also configure passthough of the host cache info but we dont do that in nova today12:50
rmart04Ah, ok so possible in Libvirt/KVM but not exposed to nova?12:53
sean-k-mooneycorrect12:53
sean-k-mooneyhttps://libvirt.org/formatdomain.html#cpu-model-and-topology12:54
sean-k-mooneyyou can add <cache mode='passthrough'/>12:54
sean-k-mooneyto the cpu element12:54
*** ociuhandu has quit IRC12:54
rmart04Interesting, is there anyway to add config like this that will persist? Or is it a case of modifying the XML and rebooting the VM in nova and when its trashed, start again?12:55
sean-k-mooneynot without modifying the nova code to add it no12:55
rmart04OK12:55
rmart04thanks for the information!!12:55
sean-k-mooneywe regenerate teh xml every time we move the vm or reboot it12:55
rmart04spot on as always12:55
sean-k-mooneythis is proably something we could add as a feature but its never really come up12:56
*** ociuhandu has joined #openstack-nova13:04
*** dustinc has joined #openstack-nova13:07
*** tesseract has quit IRC13:13
*** rmart04 has quit IRC13:14
*** sapd1 has joined #openstack-nova13:16
*** dave-mccowan has joined #openstack-nova14:05
*** lemko is now known as lemko114:14
*** lemko1 is now known as lemko14:14
*** lemko is now known as lemko_114:15
*** lemko_1 is now known as lemko14:15
openstackgerritTobias Urdin proposed openstack/nova master: When Nova-Api runs behind the load balancer or Reverse proxy, Loadbalancer IP is getting logged in nova_api.log instead of end user source ip by RequestLog  https://review.opendev.org/c/openstack/nova/+/78676614:19
*** artom has joined #openstack-nova14:25
*** dklyle has joined #openstack-nova14:56
*** vishalmanchanda has quit IRC14:56
*** rcernin has joined #openstack-nova15:20
*** rcernin has quit IRC15:25
*** gyee has joined #openstack-nova15:26
*** psachin has quit IRC15:27
*** macz_ has joined #openstack-nova15:35
*** macz_ has quit IRC15:35
*** macz_ has joined #openstack-nova15:35
*** rpittau is now known as rpittau|afk15:42
openstackgerritBalazs Gibizer proposed openstack/nova-specs master: QoS minimum guaranteed packet rate  https://review.opendev.org/c/openstack/nova-specs/+/78501415:46
*** ociuhandu_ has joined #openstack-nova15:48
*** ociuhandu has quit IRC15:51
*** ociuhandu_ has quit IRC15:52
gibinova meeting starts in 4 minutes in #openstack-meeting-315:56
*** lucasagomes has quit IRC16:01
*** dtantsur is now known as dtantsur|afk16:02
*** ociuhandu has joined #openstack-nova16:08
*** ociuhandu has quit IRC16:12
*** mgoddard has quit IRC16:13
*** mgoddard has joined #openstack-nova16:15
*** k_mouza_ has quit IRC16:30
*** k_mouza has joined #openstack-nova16:30
sean-k-mooneydansmith: artom  how we are fixing this for them is having them change all the config value to lowercase to match what neturon is expecting. and then doing a db update of all the things16:51
dansmithyeah, I like the hardening of course, but in the interim we have to provide them a way to migrate and fix, since we don't control rabbit16:52
dansmithso either we say "don't change it once you've set it" (which seems reasonable to me) or we say we're going to change everybody, so get your homework done (also reasonable)16:53
dansmithif neutron is making some change that is going to require consistency then presumably the latter is the only option16:53
*** ralonsoh has quit IRC16:58
bauzasI don't have a particular opinion on how we should fix those RPC issues, but I'm frightened by us trying to change the queue names16:59
bauzasas it's a impactful and visible change17:00
bauzasanyhow, time to stop17:01
artomMy brain has mostly checked out at this point (I know, it's only 13:00 here), and I need to run errands anyways17:01
artomI'll post a spec... I want to say next week?17:01
sean-k-mooneywell we can have this just be a workaround config option and never enable it by default17:03
openstackgerritElod Illes proposed openstack/placement master: Add periodic-stable-jobs template  https://review.opendev.org/c/openstack/placement/+/77538417:12
*** andrewbonney has quit IRC17:13
*** macz_ has quit IRC17:15
dansmithsean-k-mooney: artom: We could probably lower() the hostname on service.create() and not service.update() in the short term17:15
dansmiththat won't fix the cell mapping issue, but sounds like that's not the primary concern (or the biggest impact)17:15
artomSo what's the call mapping issue again?17:18
sean-k-mooneydansmith: am maybe. that word normalise any new service yes17:21
dansmithsean-k-mooney: we could do the same for cell mappings actually17:21
sean-k-mooneydansmith: althougy we would have to ensure that compute agents used the host value form the service record not form the config when settin up rpc17:21
dansmithsean-k-mooney: yeah17:22
sean-k-mooneyim not actully sure where that happens i was expecting to see it here but here https://github.com/openstack/nova/blob/master/nova/cmd/compute.py but i guess its elsewhere17:23
sean-k-mooneyproably in the compute manager17:24
sean-k-mooneyah17:26
dansmithit's probably buried in rpc.py17:26
sean-k-mooneyhttps://github.com/openstack/nova/blob/7953c0197d1a4466cb5b78070d47626c92f9db6e/nova/compute/rpcapi.py#L5317:26
sean-k-mooneyproably but that is where we get the name17:26
sean-k-mooneywe are using instance.host17:26
dansmithyeah, which might also bring some problems updating those as well17:28
dansmithunless we use instance.host to look up service.hostname case insensitively and then use the result17:28
sean-k-mooneywe are usign instace.host for the server filed in the client17:31
sean-k-mooneyso if we look at the srever side of the rpc it has to match17:32
sean-k-mooneywhich is likly using the host value form the config17:32
sean-k-mooneyhttps://github.com/openstack/nova/blob/7953c0197d1a4466cb5b78070d47626c92f9db6e/nova/service.py#L184-L19417:33
*** macz_ has joined #openstack-nova17:34
sean-k-mooneyso ya its usign self.host which shoudl be form the conf17:34
dansmithright,17:34
dansmithI'm saying that (a) instance.host has to be kept to match service.hostname, so we can't change one without the other17:34
sean-k-mooneyoh yes17:35
dansmithand (b) we could make service.hostname lowercase on create and make sure that instance.host comes from service.hostname going forward17:35
dansmithbut we sill have the problem of fixing current people or just telling them "don't do that"17:35
sean-k-mooneyyes which i think it likely is17:35
sean-k-mooneyya i dont know if this is something we woudl want to do with a nova manage command or something17:36
sean-k-mooneylike "normalise_host"17:36
sean-k-mooneywith a nova status check17:37
dansmiththat'll be expensive for cern-level people17:37
sean-k-mooneyyep17:37
sean-k-mooneyif the out come of this is just we wont fix it that is also ok i guess but im concened by our db scema being case inseitive today17:37
*** hamalq has joined #openstack-nova17:38
sean-k-mooneyi dont know if we can normalise on loading form the db?17:38
dansmithwell, we can't without requiring the cloud to be quiesced I think17:39
*** hamalq has quit IRC17:39
dansmithyou'd have to make sure that they all start normalizing at the same time I think,17:39
dansmithor start doing a lot of extra db queries to check for consistency to decide which value to use17:39
*** hamalq has joined #openstack-nova17:40
sean-k-mooneywell or a one time set this config value on all hosts now operation17:40
sean-k-mooneybut ya its not a simple solution in anycase17:40
sean-k-mooneyi wonder if we could have the service listen on 2 queues17:42
sean-k-mooneythe lowercase one and whatever is in the file17:42
sean-k-mooney,,,17:42
*** vishalmanchanda has joined #openstack-nova17:43
sean-k-mooneyi was going to say then just start sendign to the lower case one if you trun it on in the contoler config17:43
dansmiththat would be a super complicated and expensive alternative to "don't rename hosts" :)17:43
sean-k-mooneyyep17:43
melwittor "don't use UpPerCAse"17:43
sean-k-mooneyya se the thing is hostnames ans fqdns for that matter are technicaly case senseitive17:44
sean-k-mooneybut often that is ignored17:44
clarkbI don't think dns treats them that way17:45
clarkbDNS record types, and the values of TXT and SPF records are case sensitive, but everything else is not17:46
sean-k-mooneygood to know17:47
sean-k-mooneyi may have been mixing that up with email since the case matters there or at least it used too17:47
sean-k-mooneyalthough no one follows the spec when it comes to email17:48
*** k_mouza has quit IRC17:51
sean-k-mooneyok im going to call it a day o/17:54
dansmithright, what clarkb said17:57
*** belmoreira has quit IRC18:01
openstackgerritmelanie witt proposed openstack/nova master: Add test coverage for requestlog X-Forwarded-For  https://review.opendev.org/c/openstack/nova/+/79013918:25
*** zul_ has joined #openstack-nova18:56
*** rcernin has joined #openstack-nova19:21
*** rcernin has quit IRC19:25
*** sapd1 has quit IRC19:32
*** ociuhandu has joined #openstack-nova19:36
*** ociuhandu has quit IRC19:40
*** k_mouza has joined #openstack-nova19:53
*** k_mouza has quit IRC19:57
*** slaweq has quit IRC20:38
*** k_mouza has joined #openstack-nova20:49
*** k_mouza has quit IRC20:55
*** whoami-rajat has quit IRC21:04
*** hoonetorg has joined #openstack-nova21:05
*** hoonetorg has quit IRC21:05
*** artom has quit IRC21:07
*** vishalmanchanda has quit IRC21:12
*** k_mouza has joined #openstack-nova21:14
*** artom has joined #openstack-nova21:16
*** nightmare_unreal has quit IRC21:36
*** rcernin has joined #openstack-nova21:36
*** zul_ has quit IRC21:55
*** rcernin has quit IRC21:58
*** k_mouza has quit IRC22:42
*** damien_r has quit IRC22:43
*** damien_r has joined #openstack-nova22:46
openstackgerritmelanie witt proposed openstack/nova master: WIP Enable unified limits in the nova-next job  https://review.opendev.org/c/openstack/nova/+/78996322:49
*** rcernin has joined #openstack-nova23:02
*** macz_ has quit IRC23:14
*** tosky has quit IRC23:17
*** dustinc has quit IRC23:34
*** hamalq has quit IRC23:42
*** k_mouza has joined #openstack-nova23:59

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!