Friday, 2021-06-04

*** bhagyashris_ has joined #openstack-nova00:31
*** bhagyashris has quit IRC00:38
*** swp20 has joined #openstack-nova00:39
*** benj_ has quit IRC01:37
*** benj_ has joined #openstack-nova02:00
*** brinzhang0 has quit IRC03:29
*** brinzhang0 has joined #openstack-nova03:30
*** hemanth_n has joined #openstack-nova03:50
*** abhishekk has joined #openstack-nova05:11
*** abhishekk is now known as akekane|home05:12
*** ralonsoh has joined #openstack-nova05:30
*** halali_ has quit IRC05:51
*** slaweq_ has joined #openstack-nova06:00
*** slaweq has left #openstack-nova06:02
*** slaweq_ has quit IRC06:03
*** slaweq_ has joined #openstack-nova06:03
*** halali_ has joined #openstack-nova06:04
*** LinPeiWen has quit IRC06:08
*** LinPeiWen has joined #openstack-nova06:11
*** vishalmanchanda has joined #openstack-nova06:15
*** dklyle has quit IRC06:16
*** bhagyashris_ is now known as bhagyashris06:33
*** LinPeiWen has quit IRC06:35
*** halali_ has quit IRC06:45
*** LinPeiWen has joined #openstack-nova06:48
opendevreviewBalazs Gibizer proposed openstack/nova master: Remove unnecessary mocks from unit test  https://review.opendev.org/c/openstack/nova/+/79463707:05
*** rpittau|afk is now known as rpittau07:05
*** halali_ has joined #openstack-nova07:08
*** tosky has joined #openstack-nova07:23
*** andrewbonney has joined #openstack-nova07:32
*** slaweq has joined #openstack-nova07:36
*** slaweq_ has quit IRC07:41
*** akekane|home has quit IRC07:41
*** lucasagomes has joined #openstack-nova08:04
*** slaweq_ has joined #openstack-nova08:05
*** slaweq_ has quit IRC08:11
*** lucasagomes has quit IRC08:19
*** CeeMac has joined #openstack-nova08:19
*** martinkennelly has joined #openstack-nova08:20
*** martinkennelly_ has joined #openstack-nova08:20
*** lucasagomes has joined #openstack-nova08:26
kashyaplyarwood: Mornin'.  When you're about, it's not entirley clear to me if the grenade-multinode time-out is your patch's problem: https://review.opendev.org/c/openstack/nova/+/794639/08:43
kashyapInvalid volume + request time-out08:43
*** lucasagomes has quit IRC08:48
*** lucasagomes has joined #openstack-nova08:49
lyarwoodit's not08:50
lyarwoodthis looks like another detach timeout issue08:50
* lyarwood looks08:50
lyarwoodso much nicer to debug this now thanks to gibi's rewrite08:52
* gibi glad to hear that 08:52
lyarwood:)08:52
lyarwoodso I think we need to add a dump of the instance console when we fail to detach08:53
lyarwoodas this might be an issue within the guestOS but without that it's impossible to say08:53
lyarwoodn-cpu and libvirt appear to be doing the correct things at the correct time08:53
kashyapHm08:57
*** lucasagomes has quit IRC09:05
lyarwoodkashyap: https://review.opendev.org/c/openstack/tempest/+/794757 I'll try some runs with this to see what the guest is up to09:21
kashyaplyarwood: Nice; that's quick!09:23
*** lucasagomes has joined #openstack-nova09:25
*** lucasagomes has quit IRC09:37
*** lucasagomes has joined #openstack-nova09:43
*** brinzhang_ has joined #openstack-nova09:47
*** jangutter has joined #openstack-nova09:48
*** lucasagomes has quit IRC09:54
*** jangutter_ has quit IRC09:54
*** brinzhang0 has quit IRC09:55
opendevreviewLee Yarwood proposed openstack/nova master: libvirt: Set driver_iommu when attaching virtio devices to SEV instance  https://review.opendev.org/c/openstack/nova/+/79463909:56
opendevreviewLee Yarwood proposed openstack/nova master: DNM testing tempest volume detach failure capture of console  https://review.opendev.org/c/openstack/nova/+/79476609:56
*** lucasagomes has joined #openstack-nova09:59
*** jangutter has quit IRC10:01
*** jangutter has joined #openstack-nova10:02
*** jangutter has quit IRC10:14
*** jangutter has joined #openstack-nova10:15
opendevreviewMerged openstack/placement master: Add 'cryptography' package to test-requirements.txt  https://review.opendev.org/c/openstack/placement/+/78728910:18
opendevreviewMerged openstack/nova master: Fix RequestLevelParams persistence handling in RequestSpec  https://review.opendev.org/c/openstack/nova/+/79150210:20
*** brinzhang_ has quit IRC10:21
*** jangutter has quit IRC10:23
*** jangutter has joined #openstack-nova10:24
*** swp20 has quit IRC10:33
*** lucasagomes has quit IRC10:53
*** lucasagomes has joined #openstack-nova10:58
*** derekh has joined #openstack-nova11:05
*** hemanth_n has quit IRC11:26
*** osmanlicilegi has quit IRC11:38
*** cgoncalves has quit IRC11:59
*** osmanlicilegi has joined #openstack-nova12:00
*** cgoncalves has joined #openstack-nova12:01
*** osmanlicilegi has quit IRC12:11
*** osmanlicilegi has joined #openstack-nova12:35
*** lucasagomes has quit IRC12:38
kashyapsean-k-mooney: Hey, I'm trying to add a new video device model ... "bochs" display12:40
kashyapsean-k-mooney: It is recommended by the QEMU folks for UEFI guests as a safe alternative12:41
* kashyap brings a draft patch...12:41
opendevreviewKashyap Chamarthy proposed openstack/nova master: Allow 'bochs' as a display device option  https://review.opendev.org/c/openstack/nova/+/79479612:41
kashyapsean-k-mooney: --^  When you get a minute,  let me know what is missing there :)12:42
sean-k-mooneysure12:42
kashyapsean-k-mooney: A blueprint is an overkill for this; shall I just file a bug?12:43
sean-k-mooneyno this is a feature12:43
kashyapsean-k-mooney: I think I also need to bump the hash for ImageMetaProps?12:43
sean-k-mooneywhen i added virtio i had to actully do a spec if i recal12:43
sean-k-mooneyyou need to do a few thing12:44
kashyapsean-k-mooney: Okay, I'll just file a blueprint.12:44
sean-k-mooneyyou need to create a new trait in os-traits12:44
sean-k-mooneyyou will alos need to update i think the notification objects but i have not reviewed the patch yet12:44
kashyapOh, trait too12:44
kashyap(I haven't added the notification object)12:44
sean-k-mooneyhttps://github.com/openstack/os-traits/blob/master/os_traits/compute/graphics.py#L1512:45
sean-k-mooneyos just MODEL_BOCHS12:45
opendevreviewLee Yarwood proposed openstack/nova-specs master: Add attachmentId to responses of the os-volume_attachments API  https://review.opendev.org/c/openstack/nova-specs/+/79479912:45
sean-k-mooneykashyap: we have a placement prefilter that allows you to schdule to nodes that have support for the model12:46
*** osmanlicilegi has quit IRC12:46
kashyapsean-k-mooney: Wouldn't all nodes have support for the model in a given deployment, given that min_libvirt_version satisifes that requirement?12:47
* kashyap goes to add the trait12:47
opendevreviewLee Yarwood proposed openstack/nova-specs master: Add attachmentId to responses of the os-volume_attachments API  https://review.opendev.org/c/openstack/nova-specs/+/79479912:47
sean-k-mooneyoh and technially a change to glance https://review.opendev.org/c/openstack/glance/+/647735 but that is more a nice to have12:49
kashyapsean-k-mooney: Got a link to your virtio-gpu patch?12:49
sean-k-mooneykashyap: this is how i added virtio-gpu https://review.opendev.org/c/openstack/nova/+/64773312:50
kashyapsean-k-mooney: Noted on the Glance part12:50
*** bhagyashris_ has joined #openstack-nova12:50
sean-k-mooneytechnially i just added all the video moeles that were not already supported when i did that change not just virtio but you could be able to just follow the same steps12:51
*** osmanlicilegi has joined #openstack-nova12:55
kashyapsean-k-mooney: So, here we go, the specless-bp: https://blueprints.launchpad.net/nova/+spec/add-bochs-display-device12:55
sean-k-mooneykashyap: do you need to  add a test for uefi fo this model type12:55
sean-k-mooneye.g. hw_fireware_type=uefi12:55
*** lucasagomes has joined #openstack-nova12:56
sean-k-mooneywe proably should assuming it wont work with a bios boot12:56
*** bhagyashris has quit IRC12:56
kashyapsean-k-mooney: For BIOS boot, "this device might be useable as well" is what the QEMU dev writes12:57
sean-k-mooneykashyap: ack on the blueprint that hsould be more or less enough we can disucss it at the meeting on tueday12:57
kashyapOkido12:57
sean-k-mooneykashyap: ok so we dont need to put a gard in place at the api12:57
sean-k-mooneyin valdiate_falvor_image_nostatus12:58
kashyapsean-k-mooney: BTW, a silly question: what are the hashes based on, when bumping the ImageMetaPros?12:58
*** bhagyashris_ is now known as bhagyashris12:58
sean-k-mooneythey are computed based in the filed defintions of the the object by olso.versioned.objects12:58
kashyap(When bumping it in unit/test_objects.py, i.e.)12:58
kashyapI see, based on the string length, looks like md512:59
sean-k-mooneythat or sha1 proably12:59
*** rloo has joined #openstack-nova13:01
sean-k-mooneythey are just used in tests so we can change the hash algoritiom freely provide we update the tests13:01
kashyapsean-k-mooney: md5() for sure :-) --13:01
kashyap    fingerprint = '%s-%s' % (obj_class.VERSION, md5(13:01
kashyap(Source: https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/fixture.py#L274)13:01
sean-k-mooneyah ya it is md513:02
sean-k-mooneyand it has  usedforsecurity=Fals13:02
sean-k-mooneyso no issue with fips13:02
kashyapsean-k-mooney: BTW, what would be be the full expanded trait here, for video models, when an operator configures it?13:05
sean-k-mooneyCOMPUTE_GRAPHICS_MODEL_BOCHS13:05
sean-k-mooneyits in COMPUTE since its an atribute of what the hypervior can vituralise13:05
sean-k-mooneyHW_ is used for descibing atributes of the phsyical hardware13:06
kashyapI see13:06
sean-k-mooneyso just add MODEL_BOCHS here https://github.com/openstack/os-traits/blob/master/os_traits/compute/graphics.py#L1913:06
sean-k-mooneylike https://github.com/openstack/os-traits/commit/95668fdd59bf526277874ca50c4800ebd3aafb2613:07
kashyapsean-k-mooney: Yep; done.  I recall also reworking the layout of CPU-related traits, which was more confusing before :D13:08
sean-k-mooneycommon x86 ones are here https://github.com/openstack/os-traits/blob/master/os_traits/hw/cpu/x86/__init__.py13:09
sean-k-mooneybut we have vendor specific ones in there own module https://github.com/openstack/os-traits/blob/master/os_traits/hw/cpu/x86/intel.py https://github.com/openstack/os-traits/blob/master/os_traits/hw/cpu/x86/amd.py13:10
sean-k-mooneyim not sure why https://github.com/openstack/os-traits/blob/master/os_traits/hw/cpu/amd.py is here though13:11
kashyapsean-k-mooney: Right; it was before haphazard; I reworked it in this commit: https://github.com/openstack/os-traits/commit/93d2ff782f13:11
sean-k-mooneyunless amd plan to support SEV on non x8613:11
sean-k-mooneyoh right it dperecated13:12
kashyapYep; see the ASCII "diagram" in the commit message :)13:12
sean-k-mooneyso to not break the placemnt prefilter you will need to both have a depends on the os-triats patch and we will have to do an os traits release13:13
sean-k-mooneykashyap: the tempest jobs will pull in the os-traits patch correctly13:14
kashyapI see13:14
sean-k-mooneybut the upstream tox jobs wont13:14
sean-k-mooneybecause of how things are installed int eh venv13:14
*** cgoncalves has quit IRC13:14
kashyapsean-k-mooney: So is this the correct config for operator? — trait:COMPUTE_GRAPHICS_MODEL_BOCHS=true13:14
sean-k-mooneyno13:14
kashyapDo correct13:14
sean-k-mooneyin the image they set hw_video_model=bochs13:15
sean-k-mooneyand the prefilter will generate trait:COMPUTE_GRAPHICS_MODEL_BOCHS=reuqired13:15
*** cgoncalves has joined #openstack-nova13:15
sean-k-mooneyin the placemnet query13:15
sean-k-mooneykashyap: traits never change how an xml is generated directly13:15
kashyapsean-k-mooney: Ah, right; I first wrote "required", and then wrote 'true'13:16
sean-k-mooneyadding trait:COMPUTE_GRAPHICS_MODEL_BOCHS=reuqired to the flavor for example woudl jsut ensure it laned on a host with supprot for it but we would still default to cirrus graphics13:16
opendevreviewKashyap Chamarthy proposed openstack/os-traits master: Add a trait for the "bochs" display device  https://review.opendev.org/c/openstack/os-traits/+/79480713:17
*** luksky has joined #openstack-nova13:36
*** rpittau is now known as rpittau|afk13:37
opendevreviewBalazs Gibizer proposed openstack/nova master: Reject server create with extended resource req  https://review.opendev.org/c/openstack/nova/+/79361913:39
opendevreviewBalazs Gibizer proposed openstack/nova master: Reject server operations with extended resource req  https://review.opendev.org/c/openstack/nova/+/79362013:39
kashyapsean-k-mooney: By notification object, you mean this one, right?  notification_samples/common_payloads/ImageMetaPropsPayload.json13:39
sean-k-mooneywell that the api sample13:40
opendevreviewBalazs Gibizer proposed openstack/nova master: Add same_subtree field to RequestLevelParams  https://review.opendev.org/c/openstack/nova/+/79150313:42
opendevreviewBalazs Gibizer proposed openstack/nova master: Bump min placement microversion to 1.36  https://review.opendev.org/c/openstack/nova/+/79150413:42
sean-k-mooneyi mean this https://github.com/openstack/nova/blob/master/nova/notifications/objects/image.py#L2213:42
sean-k-mooneywell actully https://github.com/openstack/nova/blob/master/nova/notifications/objects/image.py#L107 proably13:43
sean-k-mooneyyou will need to bump this to 1.8 https://github.com/openstack/nova/blob/master/nova/notifications/objects/image.py#L12713:43
sean-k-mooneyand add the version comment13:43
*** abhishekk has joined #openstack-nova13:44
opendevreviewBalazs Gibizer proposed openstack/nova master: Support same_subtree in allocation_canadidate query  https://review.opendev.org/c/openstack/nova/+/79150513:46
opendevreviewBalazs Gibizer proposed openstack/nova master: Support the new port resource_request format  https://review.opendev.org/c/openstack/nova/+/78720813:49
opendevreviewBalazs Gibizer proposed openstack/nova master: Transfer RequestLevelParams from ports to scheduling  https://review.opendev.org/c/openstack/nova/+/79150613:51
opendevreviewBalazs Gibizer proposed openstack/nova master: [func test] ports with both bw and pps resources  https://review.opendev.org/c/openstack/nova/+/79239413:53
opendevreviewBalazs Gibizer proposed openstack/nova master: [func test] move unshelve test to the proper place  https://review.opendev.org/c/openstack/nova/+/79362113:55
*** lucasagomes has quit IRC14:18
opendevreviewBalazs Gibizer proposed openstack/nova master: [func test] ports with both bw and pps resources  https://review.opendev.org/c/openstack/nova/+/79239414:19
opendevreviewBalazs Gibizer proposed openstack/nova master: [func test] move unshelve test to the proper place  https://review.opendev.org/c/openstack/nova/+/79362114:20
opendevreviewVictor Coutellier proposed openstack/nova master: Allow configuration of direct-snapshot feature  https://review.opendev.org/c/openstack/nova/+/79483714:21
*** lucasagomes has joined #openstack-nova14:21
*** lucasagomes has quit IRC14:34
*** lucasagomes has joined #openstack-nova14:35
*** gmann is now known as gmann_afk14:40
*** kashyap has quit IRC14:43
*** lucasagomes has quit IRC14:46
*** dklyle has joined #openstack-nova14:46
*** lucasagomes has joined #openstack-nova14:50
*** gmann_afk is now known as gmann15:13
opendevreviewSylvain Bauza proposed openstack/nova-specs master: Add generic mdevs to Nova  https://review.opendev.org/c/openstack/nova-specs/+/79279615:24
*** lucasagomes has quit IRC15:45
*** lucasagomes has joined #openstack-nova15:48
opendevreviewMerged openstack/nova stable/train: add functional regression test for bug #1888395  https://review.opendev.org/c/openstack/nova/+/75953315:52
opendevmeetbug 1888395 in OpenStack Compute (nova) train "live migration of a vm using the single port binding work flow is broken in train as a result of the introduction of sriov live migration" [High,In progress] https://launchpad.net/bugs/1888395 - Assigned to sean mooney (sean-k-mooney)15:52
opendevreviewMerged openstack/nova stable/train: Set migrate_data.vifs only when using multiple port bindings  https://review.opendev.org/c/openstack/nova/+/75915315:52
*** lucasagomes has quit IRC16:04
opendevreviewGhanshyam proposed openstack/nova master: DNM: testing  https://review.opendev.org/c/openstack/nova/+/79486316:28
*** derekh has quit IRC16:34
*** akekane_ has joined #openstack-nova16:44
*** abhishekk has quit IRC16:44
*** ralonsoh has quit IRC16:47
*** abhishekk has joined #openstack-nova16:51
*** akekane_ has quit IRC16:52
gansoLooks like the stable/wallaby grenade CI job is misconfigured: https://6ba5c0d21853f43b6382-b0014becc5640974ea321328f0a307e3.ssl.cf2.rackcdn.com/794328/1/check/nova-grenade-multinode/79f8e0a/job-output.txt17:00
*** abhishekk has quit IRC17:22
*** andrewbonney has quit IRC17:46
melwittganso: we are working on it https://review.opendev.org/c/openstack/nova/+/79434518:45
gansomelwitt: thanks!19:02
opendevreviewAde Lee proposed openstack/nova master: Add check job for FIPS  https://review.opendev.org/c/openstack/nova/+/79051919:34
*** vishalmanchanda has quit IRC19:54
*** gmann is now known as gmann_afk21:51
*** jangutter_ has joined #openstack-nova21:59
*** jangutter_ has quit IRC21:59
*** jangutter_ has joined #openstack-nova22:00
*** jangutte_ has joined #openstack-nova22:01
*** jangutte_ has quit IRC22:01
*** tosky has quit IRC22:01
*** jangutter_ has quit IRC22:01
*** jangutter_ has joined #openstack-nova22:02
*** jangutter_ has quit IRC22:02
*** jangutter_ has joined #openstack-nova22:04
*** jangutter has quit IRC22:06
*** rloo has quit IRC22:11
*** luksky has quit IRC23:09
*** martinkennelly has quit IRC23:34
*** martinkennelly_ has quit IRC23:34
*** whoami-rajat has quit IRC23:40

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!