*** bhagyashris_ has joined #openstack-nova | 00:31 | |
*** bhagyashris has quit IRC | 00:38 | |
*** swp20 has joined #openstack-nova | 00:39 | |
*** benj_ has quit IRC | 01:37 | |
*** benj_ has joined #openstack-nova | 02:00 | |
*** brinzhang0 has quit IRC | 03:29 | |
*** brinzhang0 has joined #openstack-nova | 03:30 | |
*** hemanth_n has joined #openstack-nova | 03:50 | |
*** abhishekk has joined #openstack-nova | 05:11 | |
*** abhishekk is now known as akekane|home | 05:12 | |
*** ralonsoh has joined #openstack-nova | 05:30 | |
*** halali_ has quit IRC | 05:51 | |
*** slaweq_ has joined #openstack-nova | 06:00 | |
*** slaweq has left #openstack-nova | 06:02 | |
*** slaweq_ has quit IRC | 06:03 | |
*** slaweq_ has joined #openstack-nova | 06:03 | |
*** halali_ has joined #openstack-nova | 06:04 | |
*** LinPeiWen has quit IRC | 06:08 | |
*** LinPeiWen has joined #openstack-nova | 06:11 | |
*** vishalmanchanda has joined #openstack-nova | 06:15 | |
*** dklyle has quit IRC | 06:16 | |
*** bhagyashris_ is now known as bhagyashris | 06:33 | |
*** LinPeiWen has quit IRC | 06:35 | |
*** halali_ has quit IRC | 06:45 | |
*** LinPeiWen has joined #openstack-nova | 06:48 | |
opendevreview | Balazs Gibizer proposed openstack/nova master: Remove unnecessary mocks from unit test https://review.opendev.org/c/openstack/nova/+/794637 | 07:05 |
---|---|---|
*** rpittau|afk is now known as rpittau | 07:05 | |
*** halali_ has joined #openstack-nova | 07:08 | |
*** tosky has joined #openstack-nova | 07:23 | |
*** andrewbonney has joined #openstack-nova | 07:32 | |
*** slaweq has joined #openstack-nova | 07:36 | |
*** slaweq_ has quit IRC | 07:41 | |
*** akekane|home has quit IRC | 07:41 | |
*** lucasagomes has joined #openstack-nova | 08:04 | |
*** slaweq_ has joined #openstack-nova | 08:05 | |
*** slaweq_ has quit IRC | 08:11 | |
*** lucasagomes has quit IRC | 08:19 | |
*** CeeMac has joined #openstack-nova | 08:19 | |
*** martinkennelly has joined #openstack-nova | 08:20 | |
*** martinkennelly_ has joined #openstack-nova | 08:20 | |
*** lucasagomes has joined #openstack-nova | 08:26 | |
kashyap | lyarwood: Mornin'. When you're about, it's not entirley clear to me if the grenade-multinode time-out is your patch's problem: https://review.opendev.org/c/openstack/nova/+/794639/ | 08:43 |
kashyap | Invalid volume + request time-out | 08:43 |
*** lucasagomes has quit IRC | 08:48 | |
*** lucasagomes has joined #openstack-nova | 08:49 | |
lyarwood | it's not | 08:50 |
lyarwood | this looks like another detach timeout issue | 08:50 |
* lyarwood looks | 08:50 | |
lyarwood | so much nicer to debug this now thanks to gibi's rewrite | 08:52 |
* gibi glad to hear that | 08:52 | |
lyarwood | :) | 08:52 |
lyarwood | so I think we need to add a dump of the instance console when we fail to detach | 08:53 |
lyarwood | as this might be an issue within the guestOS but without that it's impossible to say | 08:53 |
lyarwood | n-cpu and libvirt appear to be doing the correct things at the correct time | 08:53 |
kashyap | Hm | 08:57 |
*** lucasagomes has quit IRC | 09:05 | |
lyarwood | kashyap: https://review.opendev.org/c/openstack/tempest/+/794757 I'll try some runs with this to see what the guest is up to | 09:21 |
kashyap | lyarwood: Nice; that's quick! | 09:23 |
*** lucasagomes has joined #openstack-nova | 09:25 | |
*** lucasagomes has quit IRC | 09:37 | |
*** lucasagomes has joined #openstack-nova | 09:43 | |
*** brinzhang_ has joined #openstack-nova | 09:47 | |
*** jangutter has joined #openstack-nova | 09:48 | |
*** lucasagomes has quit IRC | 09:54 | |
*** jangutter_ has quit IRC | 09:54 | |
*** brinzhang0 has quit IRC | 09:55 | |
opendevreview | Lee Yarwood proposed openstack/nova master: libvirt: Set driver_iommu when attaching virtio devices to SEV instance https://review.opendev.org/c/openstack/nova/+/794639 | 09:56 |
opendevreview | Lee Yarwood proposed openstack/nova master: DNM testing tempest volume detach failure capture of console https://review.opendev.org/c/openstack/nova/+/794766 | 09:56 |
*** lucasagomes has joined #openstack-nova | 09:59 | |
*** jangutter has quit IRC | 10:01 | |
*** jangutter has joined #openstack-nova | 10:02 | |
*** jangutter has quit IRC | 10:14 | |
*** jangutter has joined #openstack-nova | 10:15 | |
opendevreview | Merged openstack/placement master: Add 'cryptography' package to test-requirements.txt https://review.opendev.org/c/openstack/placement/+/787289 | 10:18 |
opendevreview | Merged openstack/nova master: Fix RequestLevelParams persistence handling in RequestSpec https://review.opendev.org/c/openstack/nova/+/791502 | 10:20 |
*** brinzhang_ has quit IRC | 10:21 | |
*** jangutter has quit IRC | 10:23 | |
*** jangutter has joined #openstack-nova | 10:24 | |
*** swp20 has quit IRC | 10:33 | |
*** lucasagomes has quit IRC | 10:53 | |
*** lucasagomes has joined #openstack-nova | 10:58 | |
*** derekh has joined #openstack-nova | 11:05 | |
*** hemanth_n has quit IRC | 11:26 | |
*** osmanlicilegi has quit IRC | 11:38 | |
*** cgoncalves has quit IRC | 11:59 | |
*** osmanlicilegi has joined #openstack-nova | 12:00 | |
*** cgoncalves has joined #openstack-nova | 12:01 | |
*** osmanlicilegi has quit IRC | 12:11 | |
*** osmanlicilegi has joined #openstack-nova | 12:35 | |
*** lucasagomes has quit IRC | 12:38 | |
kashyap | sean-k-mooney: Hey, I'm trying to add a new video device model ... "bochs" display | 12:40 |
kashyap | sean-k-mooney: It is recommended by the QEMU folks for UEFI guests as a safe alternative | 12:41 |
* kashyap brings a draft patch... | 12:41 | |
opendevreview | Kashyap Chamarthy proposed openstack/nova master: Allow 'bochs' as a display device option https://review.opendev.org/c/openstack/nova/+/794796 | 12:41 |
kashyap | sean-k-mooney: --^ When you get a minute, let me know what is missing there :) | 12:42 |
sean-k-mooney | sure | 12:42 |
kashyap | sean-k-mooney: A blueprint is an overkill for this; shall I just file a bug? | 12:43 |
sean-k-mooney | no this is a feature | 12:43 |
kashyap | sean-k-mooney: I think I also need to bump the hash for ImageMetaProps? | 12:43 |
sean-k-mooney | when i added virtio i had to actully do a spec if i recal | 12:43 |
sean-k-mooney | you need to do a few thing | 12:44 |
kashyap | sean-k-mooney: Okay, I'll just file a blueprint. | 12:44 |
sean-k-mooney | you need to create a new trait in os-traits | 12:44 |
sean-k-mooney | you will alos need to update i think the notification objects but i have not reviewed the patch yet | 12:44 |
kashyap | Oh, trait too | 12:44 |
kashyap | (I haven't added the notification object) | 12:44 |
sean-k-mooney | https://github.com/openstack/os-traits/blob/master/os_traits/compute/graphics.py#L15 | 12:45 |
sean-k-mooney | os just MODEL_BOCHS | 12:45 |
opendevreview | Lee Yarwood proposed openstack/nova-specs master: Add attachmentId to responses of the os-volume_attachments API https://review.opendev.org/c/openstack/nova-specs/+/794799 | 12:45 |
sean-k-mooney | kashyap: we have a placement prefilter that allows you to schdule to nodes that have support for the model | 12:46 |
*** osmanlicilegi has quit IRC | 12:46 | |
kashyap | sean-k-mooney: Wouldn't all nodes have support for the model in a given deployment, given that min_libvirt_version satisifes that requirement? | 12:47 |
* kashyap goes to add the trait | 12:47 | |
opendevreview | Lee Yarwood proposed openstack/nova-specs master: Add attachmentId to responses of the os-volume_attachments API https://review.opendev.org/c/openstack/nova-specs/+/794799 | 12:47 |
sean-k-mooney | oh and technially a change to glance https://review.opendev.org/c/openstack/glance/+/647735 but that is more a nice to have | 12:49 |
kashyap | sean-k-mooney: Got a link to your virtio-gpu patch? | 12:49 |
sean-k-mooney | kashyap: this is how i added virtio-gpu https://review.opendev.org/c/openstack/nova/+/647733 | 12:50 |
kashyap | sean-k-mooney: Noted on the Glance part | 12:50 |
*** bhagyashris_ has joined #openstack-nova | 12:50 | |
sean-k-mooney | technially i just added all the video moeles that were not already supported when i did that change not just virtio but you could be able to just follow the same steps | 12:51 |
*** osmanlicilegi has joined #openstack-nova | 12:55 | |
kashyap | sean-k-mooney: So, here we go, the specless-bp: https://blueprints.launchpad.net/nova/+spec/add-bochs-display-device | 12:55 |
sean-k-mooney | kashyap: do you need to add a test for uefi fo this model type | 12:55 |
sean-k-mooney | e.g. hw_fireware_type=uefi | 12:55 |
*** lucasagomes has joined #openstack-nova | 12:56 | |
sean-k-mooney | we proably should assuming it wont work with a bios boot | 12:56 |
*** bhagyashris has quit IRC | 12:56 | |
kashyap | sean-k-mooney: For BIOS boot, "this device might be useable as well" is what the QEMU dev writes | 12:57 |
sean-k-mooney | kashyap: ack on the blueprint that hsould be more or less enough we can disucss it at the meeting on tueday | 12:57 |
kashyap | Okido | 12:57 |
sean-k-mooney | kashyap: ok so we dont need to put a gard in place at the api | 12:57 |
sean-k-mooney | in valdiate_falvor_image_nostatus | 12:58 |
kashyap | sean-k-mooney: BTW, a silly question: what are the hashes based on, when bumping the ImageMetaPros? | 12:58 |
*** bhagyashris_ is now known as bhagyashris | 12:58 | |
sean-k-mooney | they are computed based in the filed defintions of the the object by olso.versioned.objects | 12:58 |
kashyap | (When bumping it in unit/test_objects.py, i.e.) | 12:58 |
kashyap | I see, based on the string length, looks like md5 | 12:59 |
sean-k-mooney | that or sha1 proably | 12:59 |
*** rloo has joined #openstack-nova | 13:01 | |
sean-k-mooney | they are just used in tests so we can change the hash algoritiom freely provide we update the tests | 13:01 |
kashyap | sean-k-mooney: md5() for sure :-) -- | 13:01 |
kashyap | fingerprint = '%s-%s' % (obj_class.VERSION, md5( | 13:01 |
kashyap | (Source: https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/fixture.py#L274) | 13:01 |
sean-k-mooney | ah ya it is md5 | 13:02 |
sean-k-mooney | and it has usedforsecurity=Fals | 13:02 |
sean-k-mooney | so no issue with fips | 13:02 |
kashyap | sean-k-mooney: BTW, what would be be the full expanded trait here, for video models, when an operator configures it? | 13:05 |
sean-k-mooney | COMPUTE_GRAPHICS_MODEL_BOCHS | 13:05 |
sean-k-mooney | its in COMPUTE since its an atribute of what the hypervior can vituralise | 13:05 |
sean-k-mooney | HW_ is used for descibing atributes of the phsyical hardware | 13:06 |
kashyap | I see | 13:06 |
sean-k-mooney | so just add MODEL_BOCHS here https://github.com/openstack/os-traits/blob/master/os_traits/compute/graphics.py#L19 | 13:06 |
sean-k-mooney | like https://github.com/openstack/os-traits/commit/95668fdd59bf526277874ca50c4800ebd3aafb26 | 13:07 |
kashyap | sean-k-mooney: Yep; done. I recall also reworking the layout of CPU-related traits, which was more confusing before :D | 13:08 |
sean-k-mooney | common x86 ones are here https://github.com/openstack/os-traits/blob/master/os_traits/hw/cpu/x86/__init__.py | 13:09 |
sean-k-mooney | but we have vendor specific ones in there own module https://github.com/openstack/os-traits/blob/master/os_traits/hw/cpu/x86/intel.py https://github.com/openstack/os-traits/blob/master/os_traits/hw/cpu/x86/amd.py | 13:10 |
sean-k-mooney | im not sure why https://github.com/openstack/os-traits/blob/master/os_traits/hw/cpu/amd.py is here though | 13:11 |
kashyap | sean-k-mooney: Right; it was before haphazard; I reworked it in this commit: https://github.com/openstack/os-traits/commit/93d2ff782f | 13:11 |
sean-k-mooney | unless amd plan to support SEV on non x86 | 13:11 |
sean-k-mooney | oh right it dperecated | 13:12 |
kashyap | Yep; see the ASCII "diagram" in the commit message :) | 13:12 |
sean-k-mooney | so to not break the placemnt prefilter you will need to both have a depends on the os-triats patch and we will have to do an os traits release | 13:13 |
sean-k-mooney | kashyap: the tempest jobs will pull in the os-traits patch correctly | 13:14 |
kashyap | I see | 13:14 |
sean-k-mooney | but the upstream tox jobs wont | 13:14 |
sean-k-mooney | because of how things are installed int eh venv | 13:14 |
*** cgoncalves has quit IRC | 13:14 | |
kashyap | sean-k-mooney: So is this the correct config for operator? — trait:COMPUTE_GRAPHICS_MODEL_BOCHS=true | 13:14 |
sean-k-mooney | no | 13:14 |
kashyap | Do correct | 13:14 |
sean-k-mooney | in the image they set hw_video_model=bochs | 13:15 |
sean-k-mooney | and the prefilter will generate trait:COMPUTE_GRAPHICS_MODEL_BOCHS=reuqired | 13:15 |
*** cgoncalves has joined #openstack-nova | 13:15 | |
sean-k-mooney | in the placemnet query | 13:15 |
sean-k-mooney | kashyap: traits never change how an xml is generated directly | 13:15 |
kashyap | sean-k-mooney: Ah, right; I first wrote "required", and then wrote 'true' | 13:16 |
sean-k-mooney | adding trait:COMPUTE_GRAPHICS_MODEL_BOCHS=reuqired to the flavor for example woudl jsut ensure it laned on a host with supprot for it but we would still default to cirrus graphics | 13:16 |
opendevreview | Kashyap Chamarthy proposed openstack/os-traits master: Add a trait for the "bochs" display device https://review.opendev.org/c/openstack/os-traits/+/794807 | 13:17 |
*** luksky has joined #openstack-nova | 13:36 | |
*** rpittau is now known as rpittau|afk | 13:37 | |
opendevreview | Balazs Gibizer proposed openstack/nova master: Reject server create with extended resource req https://review.opendev.org/c/openstack/nova/+/793619 | 13:39 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Reject server operations with extended resource req https://review.opendev.org/c/openstack/nova/+/793620 | 13:39 |
kashyap | sean-k-mooney: By notification object, you mean this one, right? notification_samples/common_payloads/ImageMetaPropsPayload.json | 13:39 |
sean-k-mooney | well that the api sample | 13:40 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Add same_subtree field to RequestLevelParams https://review.opendev.org/c/openstack/nova/+/791503 | 13:42 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Bump min placement microversion to 1.36 https://review.opendev.org/c/openstack/nova/+/791504 | 13:42 |
sean-k-mooney | i mean this https://github.com/openstack/nova/blob/master/nova/notifications/objects/image.py#L22 | 13:42 |
sean-k-mooney | well actully https://github.com/openstack/nova/blob/master/nova/notifications/objects/image.py#L107 proably | 13:43 |
sean-k-mooney | you will need to bump this to 1.8 https://github.com/openstack/nova/blob/master/nova/notifications/objects/image.py#L127 | 13:43 |
sean-k-mooney | and add the version comment | 13:43 |
*** abhishekk has joined #openstack-nova | 13:44 | |
opendevreview | Balazs Gibizer proposed openstack/nova master: Support same_subtree in allocation_canadidate query https://review.opendev.org/c/openstack/nova/+/791505 | 13:46 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Support the new port resource_request format https://review.opendev.org/c/openstack/nova/+/787208 | 13:49 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Transfer RequestLevelParams from ports to scheduling https://review.opendev.org/c/openstack/nova/+/791506 | 13:51 |
opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] ports with both bw and pps resources https://review.opendev.org/c/openstack/nova/+/792394 | 13:53 |
opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move unshelve test to the proper place https://review.opendev.org/c/openstack/nova/+/793621 | 13:55 |
*** lucasagomes has quit IRC | 14:18 | |
opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] ports with both bw and pps resources https://review.opendev.org/c/openstack/nova/+/792394 | 14:19 |
opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move unshelve test to the proper place https://review.opendev.org/c/openstack/nova/+/793621 | 14:20 |
opendevreview | Victor Coutellier proposed openstack/nova master: Allow configuration of direct-snapshot feature https://review.opendev.org/c/openstack/nova/+/794837 | 14:21 |
*** lucasagomes has joined #openstack-nova | 14:21 | |
*** lucasagomes has quit IRC | 14:34 | |
*** lucasagomes has joined #openstack-nova | 14:35 | |
*** gmann is now known as gmann_afk | 14:40 | |
*** kashyap has quit IRC | 14:43 | |
*** lucasagomes has quit IRC | 14:46 | |
*** dklyle has joined #openstack-nova | 14:46 | |
*** lucasagomes has joined #openstack-nova | 14:50 | |
*** gmann_afk is now known as gmann | 15:13 | |
opendevreview | Sylvain Bauza proposed openstack/nova-specs master: Add generic mdevs to Nova https://review.opendev.org/c/openstack/nova-specs/+/792796 | 15:24 |
*** lucasagomes has quit IRC | 15:45 | |
*** lucasagomes has joined #openstack-nova | 15:48 | |
opendevreview | Merged openstack/nova stable/train: add functional regression test for bug #1888395 https://review.opendev.org/c/openstack/nova/+/759533 | 15:52 |
opendevmeet | bug 1888395 in OpenStack Compute (nova) train "live migration of a vm using the single port binding work flow is broken in train as a result of the introduction of sriov live migration" [High,In progress] https://launchpad.net/bugs/1888395 - Assigned to sean mooney (sean-k-mooney) | 15:52 |
opendevreview | Merged openstack/nova stable/train: Set migrate_data.vifs only when using multiple port bindings https://review.opendev.org/c/openstack/nova/+/759153 | 15:52 |
*** lucasagomes has quit IRC | 16:04 | |
opendevreview | Ghanshyam proposed openstack/nova master: DNM: testing https://review.opendev.org/c/openstack/nova/+/794863 | 16:28 |
*** derekh has quit IRC | 16:34 | |
*** akekane_ has joined #openstack-nova | 16:44 | |
*** abhishekk has quit IRC | 16:44 | |
*** ralonsoh has quit IRC | 16:47 | |
*** abhishekk has joined #openstack-nova | 16:51 | |
*** akekane_ has quit IRC | 16:52 | |
ganso | Looks like the stable/wallaby grenade CI job is misconfigured: https://6ba5c0d21853f43b6382-b0014becc5640974ea321328f0a307e3.ssl.cf2.rackcdn.com/794328/1/check/nova-grenade-multinode/79f8e0a/job-output.txt | 17:00 |
*** abhishekk has quit IRC | 17:22 | |
*** andrewbonney has quit IRC | 17:46 | |
melwitt | ganso: we are working on it https://review.opendev.org/c/openstack/nova/+/794345 | 18:45 |
ganso | melwitt: thanks! | 19:02 |
opendevreview | Ade Lee proposed openstack/nova master: Add check job for FIPS https://review.opendev.org/c/openstack/nova/+/790519 | 19:34 |
*** vishalmanchanda has quit IRC | 19:54 | |
*** gmann is now known as gmann_afk | 21:51 | |
*** jangutter_ has joined #openstack-nova | 21:59 | |
*** jangutter_ has quit IRC | 21:59 | |
*** jangutter_ has joined #openstack-nova | 22:00 | |
*** jangutte_ has joined #openstack-nova | 22:01 | |
*** jangutte_ has quit IRC | 22:01 | |
*** tosky has quit IRC | 22:01 | |
*** jangutter_ has quit IRC | 22:01 | |
*** jangutter_ has joined #openstack-nova | 22:02 | |
*** jangutter_ has quit IRC | 22:02 | |
*** jangutter_ has joined #openstack-nova | 22:04 | |
*** jangutter has quit IRC | 22:06 | |
*** rloo has quit IRC | 22:11 | |
*** luksky has quit IRC | 23:09 | |
*** martinkennelly has quit IRC | 23:34 | |
*** martinkennelly_ has quit IRC | 23:34 | |
*** whoami-rajat has quit IRC | 23:40 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!