| *** martinkennelly_ has quit IRC | 00:02 | |
| *** martinkennelly has quit IRC | 00:02 | |
| *** derekh has quit IRC | 00:04 | |
| opendevreview | Merged openstack/nova master: Remove unnecessary mocks from unit test https://review.opendev.org/c/openstack/nova/+/794637 | 00:23 |
|---|---|---|
| *** rloo has quit IRC | 00:23 | |
| *** rloo has joined #openstack-nova | 00:24 | |
| opendevreview | Merged openstack/nova master: docs: Address TODO https://review.opendev.org/c/openstack/nova/+/792363 | 00:24 |
| *** suzhengwei__ has joined #openstack-nova | 00:47 | |
| opendevreview | Merged openstack/nova master: Create a fixture around fake_notifier https://review.opendev.org/c/openstack/nova/+/758446 | 00:54 |
| opendevreview | Merged openstack/nova master: Use NotificationFixture for legacy notifications too https://review.opendev.org/c/openstack/nova/+/758448 | 00:55 |
| *** brinzhang has joined #openstack-nova | 00:55 | |
| *** brinzhang_ has quit IRC | 01:00 | |
| *** suzhengwei__ has quit IRC | 01:02 | |
| *** suzhengwei__ has joined #openstack-nova | 01:02 | |
| opendevreview | melanie witt proposed openstack/nova stable/ussuri: zuul: Replace grenade and nova-grenade-multinode with grenade-multinode https://review.opendev.org/c/openstack/nova/+/794675 | 01:20 |
| opendevreview | melanie witt proposed openstack/nova stable/ussuri: zuul: Start to migrate nova-live-migration to zuulv3 https://review.opendev.org/c/openstack/nova/+/795432 | 01:20 |
| opendevreview | melanie witt proposed openstack/nova stable/ussuri: zuul: Replace nova-live-migration with zuulv3 jobs https://review.opendev.org/c/openstack/nova/+/795433 | 01:20 |
| opendevreview | melanie witt proposed openstack/nova stable/ussuri: Remove broken legacy zuul jobs https://review.opendev.org/c/openstack/nova/+/795374 | 01:22 |
| *** brinzhang has quit IRC | 01:22 | |
| *** brinzhang has joined #openstack-nova | 01:23 | |
| *** suzhengwei__ has quit IRC | 01:32 | |
| opendevreview | melanie witt proposed openstack/nova stable/train: zuul: Replace grenade and nova-grenade-multinode with grenade-multinode https://review.opendev.org/c/openstack/nova/+/794686 | 01:35 |
| opendevreview | melanie witt proposed openstack/nova stable/train: zuul: Start to migrate nova-live-migration to zuulv3 https://review.opendev.org/c/openstack/nova/+/795435 | 01:35 |
| opendevreview | melanie witt proposed openstack/nova stable/train: zuul: Replace nova-live-migration with zuulv3 jobs https://review.opendev.org/c/openstack/nova/+/795436 | 01:35 |
| *** suzhengwei__ has joined #openstack-nova | 02:03 | |
| *** suzhengwei__ has quit IRC | 04:17 | |
| *** vishalmanchanda has joined #openstack-nova | 04:37 | |
| *** abhishekk has joined #openstack-nova | 04:47 | |
| *** brinzhang_ has joined #openstack-nova | 05:16 | |
| *** brinzhang0 has joined #openstack-nova | 05:17 | |
| *** brinzhang has quit IRC | 05:22 | |
| *** brinzhang_ has quit IRC | 05:24 | |
| *** suzhengwei__ has joined #openstack-nova | 05:31 | |
| *** luksky has joined #openstack-nova | 05:56 | |
| opendevreview | Yongli He proposed openstack/nova master: Smartnic support - cyborg drive https://review.opendev.org/c/openstack/nova/+/771362 | 06:06 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support - new vnic type https://review.opendev.org/c/openstack/nova/+/771363 | 06:06 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support https://review.opendev.org/c/openstack/nova/+/758944 | 06:06 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support - reject server move and suspend https://review.opendev.org/c/openstack/nova/+/779913 | 06:06 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support - functional tests https://review.opendev.org/c/openstack/nova/+/780147 | 06:06 |
| *** whoami-rajat has joined #openstack-nova | 06:12 | |
| *** ralonsoh has joined #openstack-nova | 06:29 | |
| *** osmanlic- has joined #openstack-nova | 06:45 | |
| *** osmanlicilegi has quit IRC | 06:45 | |
| *** dklyle has quit IRC | 06:58 | |
| *** mdbooth has quit IRC | 06:58 | |
| *** osmanlic- has quit IRC | 07:01 | |
| gibi | lyarwood: hi! Please file a bp for https://review.opendev.org/c/openstack/nova-specs/+/794799 then I will +2 | 07:02 |
| *** osmanlicilegi has joined #openstack-nova | 07:05 | |
| *** andrewbonney has joined #openstack-nova | 07:16 | |
| opendevreview | Merged openstack/nova-specs master: Re-propose Unified Limits in Nova https://review.opendev.org/c/openstack/nova-specs/+/789585 | 07:17 |
| opendevreview | Wenping Song proposed openstack/nova master: Replaces tenant_id with project_id from List/Update Servers APIs https://review.opendev.org/c/openstack/nova/+/764292 | 07:19 |
| *** swp20 has joined #openstack-nova | 07:22 | |
| lyarwood | gibi: yup will do shortly | 07:35 |
| gibi | thanks | 07:40 |
| lyarwood | I shouldn't say shortly, I'm currently stuck in standing traffic after the school run. \o/ | 07:45 |
| gibi | lyarwood: ohh. no worries. | 07:49 |
| gibi | bauzas: I left a suggestion in the mdev spec https://review.opendev.org/c/openstack/nova-specs/+/792796 about trait support. | 07:49 |
| gibi | (I know bauzas is on PTO) | 07:49 |
| *** tosky has joined #openstack-nova | 07:53 | |
| opendevreview | Balazs Gibizer proposed openstack/nova-specs master: Fix the bp link in the cyborg admin token spec https://review.opendev.org/c/openstack/nova-specs/+/795493 | 08:00 |
| *** martinkennelly has joined #openstack-nova | 08:05 | |
| *** martinkennelly_ has joined #openstack-nova | 08:05 | |
| *** derekh has joined #openstack-nova | 08:08 | |
| *** lucasagomes has joined #openstack-nova | 08:10 | |
| opendevreview | Wenping Song proposed openstack/nova stable/train: Change get console auth token policy to RULE_ADMIN_OR_OWNER https://review.opendev.org/c/openstack/nova/+/795496 | 08:21 |
| *** abhishekk has quit IRC | 08:23 | |
| *** suzhengwei__ has quit IRC | 09:11 | |
| *** suzhengwei__ has joined #openstack-nova | 09:11 | |
| *** rpittau|afk is now known as rpittau | 09:22 | |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [DNM]Test with sqla 1.4 and try to tease out slow tests https://review.opendev.org/c/openstack/nova/+/795506 | 09:24 |
| *** belmoreira has joined #openstack-nova | 09:28 | |
| *** mdbooth has joined #openstack-nova | 09:42 | |
| stephenfin | gibi++ Thanks for the review on the RPC 6.0 cleanup series. Delighted to not have to rebase that again :-D | 09:45 |
| opendevreview | Lee Yarwood proposed openstack/nova-specs master: Add attachmentId to responses of the os-volume_attachments API https://review.opendev.org/c/openstack/nova-specs/+/794799 | 09:49 |
| lyarwood | gibi: would you mind hitting https://review.opendev.org/c/openstack/nova/+/794639 and https://review.opendev.org/c/openstack/nova/+/793463 if you have time today please? | 09:54 |
| lyarwood | happy to help with any reviews in return | 09:54 |
| gibi | lyarwood: queued them up | 09:55 |
| lyarwood | many thanks | 09:55 |
| opendevreview | Luigi Toscano proposed openstack/nova stable/ussuri: Remove broken legacy zuul jobs https://review.opendev.org/c/openstack/nova/+/795374 | 10:02 |
| sean-k-mooney | this is not something we can do right https://review.opendev.org/c/openstack/nova/+/795496 | 10:08 |
| sean-k-mooney | am is gerrit broken? | 10:10 |
| gibi | sean-k-mooney: I agree that patch seems strange | 10:12 |
| gibi | at least is needs a lot of arguing in the commit message why the author wants this | 10:13 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [DNM]Test with sqla 1.4 and try to tease out slow tests https://review.opendev.org/c/openstack/nova/+/795506 | 10:13 |
| sean-k-mooney | gibi: well ideally if they did want this it would be done on master first not on stable/train | 10:14 |
| gibi | sean-k-mooney: yes. | 10:14 |
| sean-k-mooney | with either a bug or blueprint | 10:14 |
| gibi | sean-k-mooney: and zuul will also vote -1 as it is not a backport | 10:14 |
| gibi | so we have automatic rejection for such cahnges | 10:14 |
| gibi | changes | 10:14 |
| sean-k-mooney | what this is doing is allowing you to look up the connection details if you happen to fined a token | 10:14 |
| sean-k-mooney | gibi: beacuase of the pep8 cherry-pick check or something else | 10:15 |
| sean-k-mooney | i was not aware of sometrhing that did that automatically | 10:15 |
| gibi | sean-k-mooney: yepp | 10:16 |
| gibi | sean-k-mooney: we have our own script | 10:16 |
| gibi | sean-k-mooney: as part of pep8 | 10:16 |
| gibi | https://github.com/openstack/nova/blob/master/tools/check-cherry-picks.sh | 10:16 |
| sean-k-mooney | i tought the cherry pick script would only detect this if you had cherry-pick lines | 10:16 |
| sean-k-mooney | i did not think it would run on this patch | 10:16 |
| gibi | sean-k-mooney: it reject things that does not have cherry-pick lines and does not have [stable only] heading | 10:17 |
| sean-k-mooney | ah echo 'Stable branch requires either cherry-pick -x headers or [stable-only] tag!' | 10:17 |
| sean-k-mooney | ya | 10:17 |
| sean-k-mooney | ok i did not think we had that last bit. neet | 10:18 |
| swp20 | sean-k-mooney: recently, our client meet the problem that the instance's owner has no permission to get console auth token with T version. From U we have used new policy rule, so i propose this patch base on Train branch: https://review.opendev.org/c/openstack/nova/+/795496 | 10:30 |
| *** kashyap has joined #openstack-nova | 10:31 | |
| * kashyap was accidentally hanging out on the Libera -nova network | 10:31 | |
| sean-k-mooney | swp20: that cahnge does not allow them to get a console auth token | 10:31 |
| sean-k-mooney | swp20: it allows them to use a token to get the connection info | 10:32 |
| swp20 | we have tested this change works. | 10:32 |
| sean-k-mooney | well you can do it in you policy.json without the code change but that is not what the rule is for | 10:33 |
| sean-k-mooney | that is for https://docs.openstack.org/api-ref/compute/?expanded=show-console-connection-information-detail#show-console-connection-information | 10:34 |
| lyarwood | sean-k-mooney: the host there is the compute host right? | 10:36 |
| sean-k-mooney | i think its the proxy | 10:37 |
| sean-k-mooney | but it could be | 10:37 |
| swp20 | sean-k-mooney: how can i do in policy.json? does the instance's own donnot has the permission? | 10:45 |
| sean-k-mooney | this is what i would have used in the past https://docs.openstack.org/api-ref/compute/?expanded=get-vnc-console-os-getvncconsole-action-deprecated-detail#get-vnc-console-os-getvncconsole-action-deprecated | 10:49 |
| sean-k-mooney | that will give you the console url and the auth token | 10:49 |
| sean-k-mooney | the newer way woudl be to use https://docs.openstack.org/api-ref/compute/?expanded=create-console-detail#create-console | 10:51 |
| *** abhishekk has joined #openstack-nova | 10:52 | |
| swp20 | this is no what we want. | 10:53 |
| sean-k-mooney | swp20: to override the policy in policy.json you just do "rule name":["rules"] | 10:53 |
| sean-k-mooney | swp20: it is what you said your customer wanted the creaqte api will return a new auth token/url for the server console | 10:54 |
| swp20 | we have two platform A and B, A platform want use the console token to visit the instance on B platform, we need the host and port with the api https://docs.openstack.org/api-ref/compute/?expanded=show-console-connection-information-detail,create-console-detail#show-console-connection-information | 10:56 |
| sean-k-mooney | swp20: why does A not just use the create api on b to get the url and token | 10:57 |
| sean-k-mooney | swp20: is A unwaware of the server uuid | 10:57 |
| swp20 | yes, A is unware of the server uuid. | 10:57 |
| sean-k-mooney | i see well given the console_token is not intended to be used by normal users as a handel to identify a server im not conviced we should make that change in code | 10:58 |
| swp20 | or A use no admin account. | 10:58 |
| sean-k-mooney | you can do it locally on your cloud though | 10:59 |
| sean-k-mooney | A presumable owns the server | 10:59 |
| sean-k-mooney | correct | 10:59 |
| swp20 | with the new policy rule, dose the system_reader has the permission? | 11:00 |
| sean-k-mooney | in the patch you added | 11:01 |
| swp20 | not in the patch. i find the rule change to SYSTEM_READER after U. | 11:02 |
| sean-k-mooney | no it does no tsupport the new project scopes and roles | 11:02 |
| sean-k-mooney | check_str='is_admin:True or project_id:%(project_id)s', | 11:02 |
| sean-k-mooney | system_reader will not allow the owner of the token to use that endpoint no | 11:03 |
| swp20 | ack, thanks. | 11:03 |
| sean-k-mooney | swp20: this api endpoint was only intended to help admins debug console issues | 11:04 |
| swp20 | but maybe the user has the requirement. | 11:04 |
| sean-k-mooney | how does A get the console token for the server on B | 11:05 |
| sean-k-mooney | the console tokens expire and are only valid for a short period of time so they are not ment to be used to identify the server | 11:06 |
| sean-k-mooney | the default token time to live is 10 minutes https://docs.openstack.org/nova/latest/configuration/config.html#consoleauth.token_ttl | 11:07 |
| swp20 | and the doc has no desciption. | 11:07 |
| swp20 | i will ask the client what's his scenes. | 11:07 |
| swp20 | i rememered, they just want to visit the instance through host and port. | 11:08 |
| sean-k-mooney | well a normal end user shoudl not know the host on which the instnace is running | 11:09 |
| sean-k-mooney | unless its a private cloud that is a pretty big security risk | 11:09 |
| swp20 | yeah, it's a really a private cloud.:') | 11:10 |
| sean-k-mooney | the sample policy.json is rendered here https://docs.openstack.org/nova/latest/configuration/sample-policy.html | 11:11 |
| sean-k-mooney | they just need to put that in /etc/nova/policy.json and uncomment #"os_compute_api:os-console-auth-tokens": "rule:system_reader_api" | 11:11 |
| sean-k-mooney | then update the rule | 11:12 |
| swp20 | got it, thanks. | 11:12 |
| sean-k-mooney | just make sure you customer is aware of the console auth token ttl and the fact that in theory the tokens could be resused | 11:13 |
| sean-k-mooney | its very unlikely but it can happen | 11:14 |
| swp20 | yeah, right. | 11:14 |
| sean-k-mooney | if they are storing the token in a db somewhere and expecting to be able to use it days later its going to break there usecase | 11:14 |
| swp20 | ack | 11:16 |
| swp20 | i'll abandon this patch and talk to my customer. | 11:17 |
| *** suzhengwei__ has quit IRC | 11:37 | |
| *** suzhengwei__ has joined #openstack-nova | 11:37 | |
| *** suzhengwei__ has quit IRC | 11:43 | |
| *** suzhengwei__ has joined #openstack-nova | 11:43 | |
| *** abhishekk has quit IRC | 11:52 | |
| *** mdbooth has quit IRC | 12:02 | |
| *** raildo has joined #openstack-nova | 12:18 | |
| *** raildo has quit IRC | 12:18 | |
| *** raildo has joined #openstack-nova | 12:18 | |
| *** artom has quit IRC | 12:28 | |
| *** suzhengwei__ has quit IRC | 12:38 | |
| *** Corwin has joined #openstack-nova | 12:41 | |
| opendevreview | Stephen Finucane proposed openstack/nova master: requirements: Add typing-paramiko https://review.opendev.org/c/openstack/nova/+/795533 | 12:45 |
| stephenfin | gate is down - we need that (and the related requirements fix) to unblock it ^ | 12:45 |
| stephenfin | s/down/broken/ | 12:46 |
| opendevreview | Stephen Finucane proposed openstack/nova master: requirements: Add types-paramiko https://review.opendev.org/c/openstack/nova/+/795533 | 12:49 |
| * lyarwood looks | 12:56 | |
| *** rloo has joined #openstack-nova | 12:57 | |
| lyarwood | stephenfin: Why the Depends-On? | 13:03 |
| stephenfin | because we need to get it in u-c before the requirements job will pass, no? | 13:03 |
| lyarwood | stephenfin: ah does that actually fail if we don't have a uc for a given test-requirement? | 13:06 |
| lyarwood | TIL | 13:06 |
| stephenfin | I'm pretty sure it does, yeah | 13:06 |
| *** raildo has quit IRC | 13:06 | |
| amodi | lyarwood: hi, can u help out with the issue in https://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/786979, when u can. i don't have a devstack env to debug | 13:08 |
| lyarwood | stephenfin: requirements-check looks like it's failing in the nova change | 13:08 |
| lyarwood | ERROR: Package 'types-paramiko' is used in test-requirements.txt but not in lower-constraints.txt | 13:09 |
| stephenfin | drat, will fix | 13:09 |
| gibi | stephenfin: what is the way to reproduce the issue? I run tox -e mypy -r locally but it passes on nova master | 13:10 |
| lyarwood | amodi: looking | 13:10 |
| stephenfin | gibi: that did the trick for me. Only odd thing for me is the use of Python 3.9 | 13:11 |
| stephenfin | since it's F34 | 13:11 |
| opendevreview | Stephen Finucane proposed openstack/nova master: requirements: Add types-paramiko https://review.opendev.org/c/openstack/nova/+/795533 | 13:11 |
| stephenfin | lyarwood: ^ | 13:11 |
| gibi | gibizer@riverbed:~/upstream/git/nova [master] [000] [15:09:30] | 13:11 |
| gibi | $ source .tox/shared/bin/activate | 13:12 |
| gibi | gibizer@riverbed:~/upstream/git/nova (shared)[master] [000] [15:11:46] | 13:12 |
| gibi | $ python --version | 13:12 |
| gibi | I use python 3.9 too | 13:12 |
| gibi | Python 3.9.2 | 13:12 |
| gibi | gibizer@riverbed:~/upstream/git/nova (shared)[master] [000] [15:11:48] | 13:12 |
| stephenfin | odd | 13:12 |
| stephenfin | here's the first failing job I saw https://review.opendev.org/c/openstack/nova/+/778547 | 13:12 |
| stephenfin | look at the pep8 env | 13:12 |
| sean-k-mooney | stephenfin: what is types-paramiko used for | 13:13 |
| stephenfin | type hints for paramiko | 13:13 |
| sean-k-mooney | which is what the ssh lib we use | 13:13 |
| stephenfin | correct | 13:13 |
| sean-k-mooney | hum its not really a test-requireemnt is it | 13:14 |
| stephenfin | it is. mypy isn't a runtime dependency | 13:14 |
| sean-k-mooney | oh for the mypy job? | 13:14 |
| sean-k-mooney | ok | 13:14 |
| sean-k-mooney | stephenfin: did you ever add mypy to pre-commit? | 13:15 |
| stephenfin | not yet, no. Just haven't set aside the time to figure it out | 13:15 |
| sean-k-mooney | no worries | 13:15 |
| gibi | I cannot reproduce it with pep8 env either. but it seem my machine installs a bit older mypy than the gate job | 13:16 |
| * gibi cleans cache | 13:16 | |
| tosky | melwitt: I think there is a chicken-and-egg problem with the backports, you may either need to squash them (but maybe that would be too much) or set the failing legacy job in the first patch to non-vpting, to have it replaced with a native one with one of the newer patches | 13:19 |
| gibi | stephenfin: OK it needs a new mypy version to | 13:19 |
| gibi | o | 13:19 |
| lyarwood | amodi: updated, can you build a devstack env and get this passing before you push another revision? | 13:19 |
| gibi | stephenfin: it does not fail with mypy==0.812 but it fails with mypy==0.901 | 13:20 |
| stephenfin | hmm, good spot. I saw the release date on types-paramiko was pretty recent so I figured that was it | 13:20 |
| stephenfin | I'll see if I can figure out what changed | 13:20 |
| lyarwood | so we could cap mypy to unblock the gate instead right? | 13:21 |
| amodi | lyarwood: um, i havent deployed one in a long time and how would i deploy with these parameters, ill hv to figure out | 13:21 |
| sean-k-mooney | lyarwood: ya that would work if we use UC for it | 13:21 |
| stephenfin | lyarwood: we'd have to cap it | 13:22 |
| stephenfin | no uncap | 13:22 |
| stephenfin | the higher version is the issue | 13:22 |
| sean-k-mooney | its in test-requrimets not installed in the tox.ini | 13:22 |
| sean-k-mooney | so if we cap it in upper-constratints in the requirements repo it shoudl work | 13:23 |
| gibi | stephenfin: "The upcoming switch to modular typeshed in mypy 0.900" | 13:23 |
| gibi | that was hit us | 13:23 |
| stephenfin | ahhh | 13:23 |
| kashyap | stephenfin: Saw your review on that display change. I'll respond in a bit | 13:23 |
| kashyap | Thank you | 13:23 |
| stephenfin | wonderful \o/ | 13:23 |
| gibi | https://mypy-lang.blogspot.com/2021/05/the-upcoming-switch-to-modular-typeshed.html | 13:23 |
| gibi | we are lucky that only one thing was missing so far :) | 13:24 |
| sean-k-mooney | :( non nova type definition we can steal | 13:24 |
| sean-k-mooney | i wonder is there a way we can tell it to ignore third party libs if the hints are not present | 13:26 |
| sean-k-mooney | i.e. can we supress the error and maybe make ti a warning | 13:26 |
| sean-k-mooney | "You can also now run mypy --install-types to install all missing stub packages in the mypy run (or the previous run, if you don’t pass any files to check): " | 13:29 |
| sean-k-mooney | we could look at that or perhaps using --ignore-missing-imports | 13:29 |
| stephenfin | We already have that configured via '[mypy] ignore_missing_imports = true' in setup.cfg | 13:30 |
| stephenfin | apparently it doesn't work for things in typeshed | 13:30 |
| sean-k-mooney | ya it is ignored for thing that were previously bundeled | 13:30 |
| sean-k-mooney | https://mypy-lang.blogspot.com/2021/06/ | 13:30 |
| sean-k-mooney | https://mypy-lang.blogspot.com/2021/06/mypy-0900-released.html | 13:30 |
| sean-k-mooney | oh TypeGuard we can now do user defined narrowing | 13:31 |
| amodi | lyarwood: https://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/786979/20/whitebox_tempest_plugin/config.py#138 | 13:31 |
| sean-k-mooney | stephenfin: do we want to consider adding mypy --install-types to the command | 13:34 |
| sean-k-mooney | before we run mypy | 13:34 |
| stephenfin | hmm, that would be a good short-term fix | 13:34 |
| stephenfin | long-term though, I suspect these things might want to be tracked? | 13:35 |
| sean-k-mooney | im not sure | 13:35 |
| sean-k-mooney | they might want to be yes | 13:35 |
| sean-k-mooney | but since its just for type checking im not sure | 13:35 |
| stephenfin | fair point | 13:35 |
| stephenfin | lemme try that | 13:35 |
| *** abhishekk has joined #openstack-nova | 13:39 | |
| sean-k-mooney | stephenfin: by the way we could use https://github.com/pre-commit/mirrors-mypy | 13:40 |
| *** Gues_____ is now known as jamesdenton | 13:40 | |
| opendevreview | Rodrigo Barbieri proposed openstack/nova stable/victoria: Error anti-affinity violation on migrations https://review.opendev.org/c/openstack/nova/+/795542 | 13:41 |
| stephenfin | 'mypy --install-types' is interactive | 13:42 |
| stephenfin | :( | 13:42 |
| stephenfin | so I have to pipe 'yes' into it | 13:43 |
| stephenfin | lovely | 13:43 |
| stephenfin | sean-k-mooney: https://github.com/python/mypy/issues/10600#issuecomment-857351152 | 13:43 |
| stephenfin | see next comment | 13:43 |
| stephenfin | I wouldn't recommend running --install-types as it currently works in CI, since in the worst case it can almost double the mypy runtime. It also produces noisy output, as mentioned above. | 13:43 |
| stephenfin | </quote> | 13:43 |
| stephenfin | so we can do it to unblock the gate, but it definitely shouldn't stay | 13:44 |
| sean-k-mooney | stephenfin: ok i guess we can just run it once do a freeze before and after and see what it adds | 13:44 |
| sean-k-mooney | if this happens again | 13:44 |
| stephenfin | Successfully installed types-cryptography-0.1.1 types-enum34-0.1.5 types-ipaddress-0.1.2 types-paramiko-0.1.3 | 13:44 |
| stephenfin | I guess not all of those are actually needed since we don't typecheck everything | 13:44 |
| sean-k-mooney | not right now at least | 13:45 |
| sean-k-mooney | but if we expand the checking they proably will be | 13:45 |
| opendevreview | Stephen Finucane proposed openstack/nova master: requirements: Add types-paramiko https://review.opendev.org/c/openstack/nova/+/795533 | 13:46 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tox: Install mypy type stubs https://review.opendev.org/c/openstack/nova/+/795544 | 13:46 |
| stephenfin | lyarwood, gibi: Alternate approach ^ | 13:46 |
| *** spatel has joined #openstack-nova | 14:11 | |
| spatel | sean-k-mooney morning! i am trying to delete one of vm which doesn't existing on compute machine (i can't see it on compute host). i am not able to delete it, any good way to clean up ? | 14:12 |
| gibi | stephenfin: https://review.opendev.org/c/openstack/nova/+/795544 doesnt seem to work | 14:13 |
| *** tosky has quit IRC | 14:16 | |
| * stephenfin looks | 14:17 | |
| stephenfin | oh, well then | 14:17 |
| stephenfin | so I guess you need to run it, let it build a cache, then run it again to install the missing deps | 14:17 |
| stephenfin | so that won't work | 14:18 |
| stephenfin | pity :-( | 14:18 |
| *** tosky has joined #openstack-nova | 14:19 | |
| opendevreview | Stephen Finucane proposed openstack/nova master: requirements: Add types-paramiko https://review.opendev.org/c/openstack/nova/+/795533 | 14:19 |
| stephenfin | back to v2 we go | 14:19 |
| sean-k-mooney | spatel: i think we have force delete option | 14:24 |
| spatel | hmm --force ? | 14:24 |
| sean-k-mooney | spatel: if the vm no longere exits on the compute node but is still in the nova db that is what i woudl try next | 14:25 |
| spatel | perfect! let me try | 14:25 |
| sean-k-mooney | well i was thinking of "nova force-delete <server uuid>" | 14:25 |
| sean-k-mooney | let me check if its in osc | 14:25 |
| sean-k-mooney | yes there is a --force | 14:26 |
| sean-k-mooney | os openstack server delete --force <uuid> | 14:26 |
| spatel | penstack server delete: error: unrecognized arguments: --force | 14:27 |
| spatel | I am running victoria | 14:27 |
| spatel | nova force-delete works! | 14:28 |
| spatel | sean-k-mooney openstack server delete doesn't have --force option | 14:29 |
| sean-k-mooney | it does in the latest release | 14:30 |
| sean-k-mooney | spatel: stephenfin added it along with closing most of the other gaps recently | 14:30 |
| *** jparker has quit IRC | 14:30 | |
| spatel | may be available in current release but not in victoria | 14:31 |
| sean-k-mooney | when i said recent i ment in the last month or so | 14:31 |
| sean-k-mooney | nova force-delete does exactly the same thing | 14:32 |
| *** jparker has joined #openstack-nova | 14:32 | |
| opendevreview | sean mooney proposed openstack/osc-placement master: default to max version when no session https://review.opendev.org/c/openstack/osc-placement/+/794276 | 14:33 |
| sean-k-mooney | gibi: filed https://storyboard.openstack.org/#!/story/2008958 and updated ^ | 14:33 |
| sean-k-mooney | gibi: let me know if there is anything else i need to do | 14:33 |
| sean-k-mooney | storyboard is still kind of a pain to naveigate but its got much faster then i rememeber | 14:34 |
| opendevreview | Balazs Gibizer proposed openstack/osc-placement master: default to max version when no session https://review.opendev.org/c/openstack/osc-placement/+/794276 | 14:39 |
| gibi | sean-k-mooney: thanks. just added the task number to the commit message too ^^ | 14:40 |
| gibi | this will connect the review to the task in storyboard | 14:40 |
| sean-k-mooney | oh ok i have seen both but i tought task was optional | 14:40 |
| gibi | and update its state | 14:40 |
| sean-k-mooney | oh ok | 14:40 |
| sean-k-mooney | cool | 14:40 |
| sean-k-mooney | am general question | 14:40 |
| sean-k-mooney | if placment is going to remain a deliverable of compute | 14:41 |
| sean-k-mooney | do we want to continue to maintain both storyboard and lauchpad | 14:41 |
| sean-k-mooney | i also just realised the placement repariting spec should have been proposed in the placement repo | 14:41 |
| sean-k-mooney | since that is where placment specs are ment to be tracked | 14:42 |
| sean-k-mooney | https://docs.openstack.org/placement/latest/specs/index.html | 14:42 |
| gibi | sean-k-mooney: I checked the placement repo but it does not have specs folder | 14:42 |
| sean-k-mooney | its in the docs folder | 14:42 |
| sean-k-mooney | so that it renders there | 14:42 |
| gibi | /o\ | 14:42 |
| sean-k-mooney | https://github.com/openstack/placement/tree/master/doc/source/specs | 14:43 |
| sean-k-mooney | i kind of forgot this was there until i rememebred a few days ago | 14:43 |
| gibi | OK, I will move the re-prenting spec to the placement repo :/ | 14:44 |
| sean-k-mooney | well i was not going to ask you to do that | 14:45 |
| sean-k-mooney | just going forward do we want to keep the split | 14:45 |
| sean-k-mooney | e.g. nova has nova-specs and launchpad placement has in repo specs and sotry borad | 14:45 |
| sean-k-mooney | this is more a wider team question or mailing list topic | 14:46 |
| gibi | I don't feel the power to do a migration from storyboard | 14:46 |
| sean-k-mooney | but that bug just reminded me of it | 14:46 |
| gibi | we have very few incoming things in placemnet | 14:46 |
| sean-k-mooney | true | 14:47 |
| sean-k-mooney | do we want to add it to the meeting adgenda | 14:47 |
| sean-k-mooney | we have the bug review for nova in lanuch pad | 14:48 |
| sean-k-mooney | do we have somethign that will do the same for story borad | 14:48 |
| sean-k-mooney | e.g. a linke to the open stories | 14:48 |
| sean-k-mooney | its pretty stable and well tested so placment bugs are rare | 14:48 |
| gibi | sean-k-mooney: please put it up to the agenda. Honestly I don't think it worth the effort to do extra things with placement but it make sense to discuss it | 14:50 |
| sean-k-mooney | oh i was suggesting adding a "check for open placment bugs" item | 14:52 |
| sean-k-mooney | like when we do the nova bug review | 14:52 |
| sean-k-mooney | more just to prompt use to look for placment bugs if tehy areever reported | 14:52 |
| sean-k-mooney | most get brought up here anyway since nova typicly is what finds them if they exist | 14:53 |
| gibi | honestly I don't belive that people will start looking at open bug reports in placement by that prompt. but I might be negative | 14:57 |
| sean-k-mooney | ok then lets leave it be so | 15:01 |
| melwitt | tosky: guh, ok, I was wondering if there might be something like that since the fails. I'll look into a potential squash, thanks for the hint | 15:03 |
| gibi | I just don't have the bandwidth to do a proper care for placement as well, but it seem that placement does not require that level of care most of the time | 15:04 |
| *** dklyle has joined #openstack-nova | 15:04 | |
| masterpe[m] | Hi, we have Train running, yesterday we got the error "No valid host was found. There are not enough hosts available" on our platform. If I count the free RAM and vcpu of the nodes, I should have enough resources left to get the instances started. Is there something that I miss? | 15:05 |
| melwitt | sean-k-mooney, gibi: I knew that placement had its own specs repo but I thought it was intentional that proposed spec to the nova-specs repo since the projects are back together again /shrug | 15:05 |
| melwitt | gibi: there is a review I have hanging around if you might be able to spare some time, it is not urgent https://review.opendev.org/c/openstack/nova/+/780395 | 15:09 |
| sean-k-mooney | melwitt: ya so i didnt know i we had decied to not use the in repos specs or not | 15:15 |
| sean-k-mooney | e.g. if we had jsut defaulted to nova-spec or if it was intentional | 15:15 |
| melwitt | sean-k-mooney: no, I'm not saying there was a decision, I had assumed something like that had occurred because of where the re-parent spec was proposed, but I was wrong | 15:16 |
| gibi | melwitt: queued that up for review | 15:19 |
| melwitt | thank you gibi | 15:20 |
| *** LinPeiWen has quit IRC | 15:25 | |
| opendevreview | Pierre Riteau proposed openstack/nova master: Fix typos in minimum version policy docs https://review.opendev.org/c/openstack/nova/+/795575 | 15:26 |
| melwitt | masterpe[m]: you need to look at the debug level logs in the placement api logs and the nova-scheduler logs to see details about why no valid host was found | 15:26 |
| masterpe[m] | To solve it for now I enabled a node that was disabled/marked as spare. So I need to enable debug mode to troubleshoot? | 15:28 |
| *** suzhengwei__ has joined #openstack-nova | 15:31 | |
| melwitt | masterpe[m]: to get full detail, yes. what you can do without debug mode is check whether there is a message like "no allocation candidates" in the nova-scheduler log, if you see that, it's likely cpu/ram/disk (as those resources are filtered by placement service) | 15:32 |
| melwitt | if you don't see that, it means one or more of the nova side scheduler filters eliminated all hosts | 15:33 |
| opendevreview | Balazs Gibizer proposed openstack/placement master: [DNM]: test consumer_type rollback due to consumer_gen conflict https://review.opendev.org/c/openstack/placement/+/795577 | 15:34 |
| melwitt | gibi: oh heh, I had wondered if you saw my latest confusing comment. I was thinking the same thing this morning that it would be best to check what happens with a test. thanks for doing that | 15:36 |
| gibi | melwitt: yeah, you are right the whole PUT /allocations/{uuid} call is not a single transaction | 15:36 |
| gibi | so with the current implementation we can leak a consumer_type update from a rejected call :/ | 15:37 |
| gibi | unfortunatly create a test case for a real race is too hard | 15:39 |
| melwitt | gibi: ah, I see your new comment on the review. yeah ok, agree we need something higher up the stack then in order to not leak (or some other better idea yet to be thought of) :( I will work on it | 15:39 |
| gibi | it is hard :/ | 15:40 |
| melwitt | yeah, would require faking things with mocks at best. I didn't explore that yet so not sure how messy or possible | 15:42 |
| *** swp20 has quit IRC | 15:44 | |
| spatel | sean-k-mooney periodically i am seeing this issue on my nova logs not sure if this is bug or not - http://paste.openstack.org/show/806496/ | 15:46 |
| melwitt | spatel: that error means connection to the database failed while trying to write a service record update (heartbeat), not a bug. error being emitted from pymysql client | 15:51 |
| spatel | melwitt today i said terraform to build 20 vm and 4 vm failed and stick in BUILD process, when i check their compute nodes i found that error | 15:52 |
| melwitt | spatel: that paste wouldn't be directly related to a build failure (that paste is a service record update for a service heartbeat) so you'd need to look at which errors are related to the build fail, if any | 15:55 |
| *** suzhengwei__ has quit IRC | 16:01 | |
| spatel | let me see, may be issue of rabbitmq in that case | 16:03 |
| melwitt | dansmith: someone linked this review in the freenode channel and I thought you might have opinion about it. it's a proposal to allow config of rbd direct snapshot to enable an operator to disallow the fast clone, with the use case being the operator is migrating the backend and the fast clone wouldn't honor the glance backend config (I don't fully understand this part) https://review.opendev.org/c/openstack/nova/+/794837 | 16:05 |
| *** lucasagomes has quit IRC | 16:14 | |
| *** rpittau is now known as rpittau|afk | 16:16 | |
| spatel | melwitt also noticed periodically rabbitMQ connection reset error from nova-api - http://paste.openstack.org/show/806498/ | 16:30 |
| spatel | is this a normal behavior ? | 16:31 |
| melwitt | spatel: it's not uncommon but it's not desirable. I have seen it many times, related to environmental issues like network disruptions. it's also similar to the DBConnectionError you pasted earlier, that one was about the pymysql client failing to be able to connect to the database, these rabbit errors are showing connection reset or closed trying to connect to rabbitmq | 16:35 |
| spatel | These controller and compute node on same rack | 16:37 |
| spatel | let me restart my whole rabbitMQ cluster | 16:37 |
| spatel | when i delete vm they getting stuck in deleting state | 16:38 |
| *** artom has joined #openstack-nova | 17:04 | |
| *** andrewbonney has quit IRC | 17:05 | |
| dansmith | melwitt: ack, thanks | 17:14 |
| *** abhishekk has quit IRC | 17:25 | |
| *** ralonsoh has quit IRC | 17:34 | |
| opendevreview | Artom Lifshitz proposed openstack/nova master: docs: Explicitly state lack of support for node renaming https://review.opendev.org/c/openstack/nova/+/795607 | 17:39 |
| *** derekh has quit IRC | 17:45 | |
| artom | Huh, looks like the docs gate is broken on nova/crypto.py | 17:58 |
| artom | ^^ somehow failed it | 17:58 |
| artom | Actually, just pep8 in general is broken: https://zuul.opendev.org/t/openstack/build/0b3b9315c9cb4d489f2ffb1355145a99 | 18:03 |
| artom | Ah, it's mypy... | 18:04 |
| *** whoami-rajat has quit IRC | 18:13 | |
| lyarwood | artom: the fix for that is in the gate | 18:16 |
| artom | lyarwood, oh. And here I was filing a bug and writing a fix. | 18:16 |
| lyarwood | https://review.opendev.org/c/openstack/nova/+/795533 | 18:16 |
| lyarwood | Always enjoyable when that happens ^_^ | 18:17 |
| artom | I mean, no mailing list message, no bug filed, nothing :P | 18:18 |
| artom | Hrmm, I wonder if my fix could stiff have value | 18:18 |
| artom | I guess not, since we'll need to manually update requirements anyways? | 18:21 |
| artom | I did it by just adding `python -m mypy --install-types` to tools/mypywrap.sh | 18:21 |
| lyarwood | Yeah I think stephenfin tried that earlier | 18:23 |
| lyarwood | but it wasn't enough in the gate for some reason | 18:23 |
| artom | I guess because lower-constraints.txt? | 18:24 |
| *** hemna has quit IRC | 18:35 | |
| *** belmoreira has quit IRC | 18:36 | |
| *** hemna has joined #openstack-nova | 18:37 | |
| cz3 | This is probably a trivial question... I wanted to import Nova modules into interactive Python shell, but I cannot figure out how to load the config from default nova.conf. Is `CONF = nova.conf.CONF` supposed to handle this? | 18:42 |
| cz3 | I wanted to play around with objects module through interactive shell but the lack of loaded config is blocking me | 18:43 |
| artom | cz3, never tried it myself, but looking at the code, yeah, import nova.conf; CONF = nova.conf.CONF should do it | 18:45 |
| cz3 | yeah, that's what I tried... doesn't seem to work. looks like it is still trying to use the defaults. I assume that because it tries to look up things in sqlite instead of mysql that I have in nova.conf | 18:49 |
| artom | Maybe it's not finding the config file, and using the defaults... | 18:51 |
| artom | In fact, if you're importing it via Python (and not via running a Python executable on the command line), I'm not even sure how it finds the config file to use... | 18:52 |
| artom | I *think* you want to do CONF = nova.conf.CONF(project='nova') in such a case... | 18:54 |
| artom | And then it'll look for nova.conf in the "normal" places | 18:54 |
| cz3 | yes, I will poke around the nova.conf.CONF, maybe it needs some additional parameters when it is imported into interactive shell | 18:56 |
| sean-k-mooney | cz3: you need to initalise the conf form the file too | 18:56 |
| sean-k-mooney | if you just import it it will get the default form code | 18:56 |
| sean-k-mooney | we do this https://github.com/openstack/nova/blob/master/nova/config.py#L94-L98 | 18:57 |
| sean-k-mooney | where conf is CONF = nova.conf.CONF | 18:57 |
| sean-k-mooney | all the command lets initalise it here https://github.com/openstack/nova/blob/d64edd3da2336a5c7c8f69cced45272cbaf638a9/nova/cmd/status.py#L374 | 19:02 |
| sean-k-mooney | well liek ^ | 19:02 |
| sean-k-mooney | so "import nova.conf; from nova import config; CONF = nova.conf.CONF; config.parse_args(sys.argv)" | 19:03 |
| sean-k-mooney | cz3: if you do that i think it should work | 19:03 |
| sean-k-mooney | although im not sure you need to initalise rpc or configre the db | 19:04 |
| cz3 | in this case I just need the db access | 19:05 |
| sean-k-mooney | which looks like its jsut sqlalchemy_api.configure(CONF) | 19:06 |
| cz3 | sean-k-mooney: config.parse_args did the trick | 19:07 |
| cz3 | thank you! | 19:07 |
| sean-k-mooney | in any case i would use https://github.com/openstack/nova/blob/master/nova/cmd/manage.py as a reference | 19:07 |
| sean-k-mooney | no worries | 19:07 |
| sean-k-mooney | CONF(argv[1:], | 19:08 |
| sean-k-mooney | project='nova', | 19:08 |
| sean-k-mooney | version=version.version_string(), | 19:08 |
| sean-k-mooney | default_config_files=default_config_files) | 19:08 |
| sean-k-mooney | that is likely the bit you really needed | 19:08 |
| sean-k-mooney | that is invokeing the gloabl constuctor for the singelton | 19:08 |
| cz3 | I actually aim to add something to nova-manage and send it over for review, just wanted to test few things beforehand | 19:09 |
| cz3 | I emailed the openstack-discuss list last week about this, it was re: request_specs regeneration | 19:09 |
| cz3 | where I wanted to find a way to sync extra_specs from flavor data into existing instances | 19:09 |
| sean-k-mooney | oh yes i remember | 19:10 |
| cz3 | long time ago I did something like this by directly appending stuff into request_spec json in database, but this time I want to do it the proper way | 19:10 |
| cz3 | I know that flavors are supposed to be immutable etc. but in this case I just want the existing request_specs to reflect the actual reality and not make the scheduler migrate instances where it was not supposed to after underlying flavor was updated with extra_specs | 19:13 |
| cz3 | I will try to add that to nova-manage and send it over to review via gerrit, maybe it will be good enough to get upstreamed | 19:15 |
| sean-k-mooney | the main consurn we woudl have it that such an update can lead to the vm being broken or on an invalid host also | 19:15 |
| sean-k-mooney | on one hand nova manage is admin only and require direct acess to the server hosting the cloud to get the configs | 19:16 |
| sean-k-mooney | but from a downstream product point of view im not sure we would support customer executing this command | 19:16 |
| sean-k-mooney | we may be with the caveat tha that if you break things you fix them | 19:17 |
| sean-k-mooney | its something we would have to think about | 19:17 |
| cz3 | yeah, I do share the concern, I don't want to send something that would end up breaking deployments for other people if used improperly | 19:18 |
| sean-k-mooney | you proably would need to run som of the flavor/image compatiabity checks before doing the update to make it safe | 19:18 |
| sean-k-mooney | our add a --yes-i-really-really-mean-it flag | 19:18 |
| sean-k-mooney | anyway o/ time to go have dinner | 19:19 |
| cz3 | sure | 19:19 |
| cz3 | thanks again! | 19:20 |
| *** kashyap has quit IRC | 19:50 | |
| *** vishalmanchanda has quit IRC | 19:55 | |
| *** spatel has quit IRC | 20:42 | |
| *** efried has quit IRC | 21:16 | |
| *** efried has joined #openstack-nova | 21:21 | |
| *** brinzhang_ has joined #openstack-nova | 21:43 | |
| *** brinzhang has joined #openstack-nova | 21:45 | |
| *** brinzhang0 has quit IRC | 21:50 | |
| *** brinzhang0 has joined #openstack-nova | 21:50 | |
| *** brinzhang_ has quit IRC | 21:51 | |
| *** brinzhang has quit IRC | 21:53 | |
| opendevreview | melanie witt proposed openstack/nova stable/ussuri: zuul: Start to migrate nova-live-migration to zuulv3 https://review.opendev.org/c/openstack/nova/+/795432 | 21:57 |
| opendevreview | melanie witt proposed openstack/nova stable/ussuri: Remove broken legacy zuul jobs https://review.opendev.org/c/openstack/nova/+/795374 | 21:57 |
| *** luksky has quit IRC | 21:58 | |
| *** luksky has joined #openstack-nova | 22:00 | |
| tosky | melwitt: an supersquash! Would it make sense to change the first line of the commit message? It is more than just that single commit it was taken from | 22:07 |
| opendevreview | melanie witt proposed openstack/nova master: api: Log correct client IP if load balancer in use https://review.opendev.org/c/openstack/nova/+/786766 | 22:21 |
| gmann | stephenfin: can you check if anything else you want to add in this spec, leaving +w to you https://review.opendev.org/c/openstack/nova-specs/+/791620 | 22:25 |
| *** tosky has quit IRC | 22:47 | |
| *** whoami-rajat has joined #openstack-nova | 22:58 | |
| *** luksky has quit IRC | 23:43 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!