| noonedeadpunk | gotcha, thanks folks. | 05:21 |
|---|---|---|
| noonedeadpunk | we were just tend to do upgrades once per year, so we usually jump through releases and that used to work nicely. But feels we would need to change that approach | 05:23 |
| gibi | sean-k-mooney: re: moving the instance claim to the conductor. The idea itself make sense. I don't know how big of a surgery it is needed in the conductor / compute impementation. Also I guess due to rolling upgrade we need some way to do claim in both places for a release. | 07:09 |
| gibi | gmann: we have a bug report about policies https://bugs.launchpad.net/nova/+bug/1934478 If you have time could you please check it and triage it? | 07:19 |
| aarents | Hi nova! | 07:27 |
| aarents | thks gibi for quick triage of https://bugs.launchpad.net/nova/+bug/1934742 I'm on the way to propose something I plan to prod downstream. | 07:27 |
| gibi | aarents: ack. your suggestion about synchronizing the port delete handling with the the interface attach/detach make sense to me | 07:28 |
| *** rpittau|afk is now known as rpittau | 07:30 | |
| opendevreview | Lee Yarwood proposed openstack/nova master: zuul: Add CentOS 8 stream integrated compute tempest job to gate https://review.opendev.org/c/openstack/nova/+/797616 | 08:12 |
| opendevreview | wushiming proposed openstack/placement master: Changed minversion in tox to 3.18.0 https://review.opendev.org/c/openstack/placement/+/799601 | 08:15 |
| bauzas | good spec review day, folks | 08:28 |
| * bauzas will update his own spec | 08:28 | |
| opendevreview | Alexandre arents proposed openstack/nova master: Synchronize network-vif-deleted event processing https://review.opendev.org/c/openstack/nova/+/799606 | 08:30 |
| bauzas | gibi: sean-k-mooney: do you folks agree on fast-approving a new revision for https://review.opendev.org/c/openstack/nova-specs/+/792796/3/specs/xena/approved/generic-mdevs.rst if I just fix the nits ? | 08:55 |
| sean-k-mooney[m] | ill be starting soon but yes that works for me | 08:56 |
| sean-k-mooney[m] | gibi: my idea for the compute claim in the conductor was to add a new rpc for the instance claim that returns true or false indicating if the claim succeeded. the side effect of the claim would be to store the claim object in a dict on the compute node indexed by the instance uuid. then we wrap the instance claim in spawn with a lookup in the dict and only do the claim if none found. | 09:02 |
| sean-k-mooney[m] | in the conductor we can check the compute service version to determin if the compute is upgraded | 09:04 |
| opendevreview | Sylvain Bauza proposed openstack/nova-specs master: Add generic mdevs to Nova https://review.opendev.org/c/openstack/nova-specs/+/792796 | 09:16 |
| bauzas | gibi: sean-k-mooney: nits fixed ^ | 09:16 |
| sean-k-mooney | looks good +2 from me. ill +w if gibi does not get to it later today | 09:20 |
| bauzas | humpf, looking at https://review.opendev.org/q/project:openstack%252Fnova-specs+status:open I can't see a lot of specs needing my thoughts :( | 09:48 |
| *** bhagyashris_ is now known as bhagyashris|ruck | 09:50 | |
| stephenfin | bauzas: that's good new, no? | 09:53 |
| stephenfin | *news | 09:53 |
| bauzas | stephenfin: well, maybe :) | 09:53 |
| lyarwood | I'm about to drop a few today | 09:53 |
| lyarwood | trying to catch up after two pretty unproductive weeks | 09:53 |
| bauzas | maybe I'll only look at one spec https://review.opendev.org/c/openstack/nova-specs/+/787458 | 09:53 |
| bauzas | this one is large ^ | 09:53 |
| lyarwood | stephenfin: that's going to include the nova-manage commands for hardware model updates btw | 09:54 |
| stephenfin | okay, sweet | 09:54 |
| * stephenfin is cleaning up the odd failures in the alembic series and will then start reviews | 09:54 | |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Unify 'nova.db.api', 'nova.db.sqlalchemy.api' https://review.opendev.org/c/openstack/nova/+/799524 | 10:05 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Move remaining 'nova.db.sqlalchemy' modules https://review.opendev.org/c/openstack/nova/+/799525 | 10:05 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Post reshuffle cleanup https://review.opendev.org/c/openstack/nova/+/799526 | 10:05 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Add initial alembic migration for main DB https://review.opendev.org/c/openstack/nova/+/799527 | 10:05 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Add initial alembic migration for API DB https://review.opendev.org/c/openstack/nova/+/799528 | 10:05 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Trivial style changes https://review.opendev.org/c/openstack/nova/+/799529 | 10:05 |
| opendevreview | Stephen Finucane proposed openstack/nova master: WIP: db: Integrate alembic https://review.opendev.org/c/openstack/nova/+/799530 | 10:05 |
| opendevreview | Lee Yarwood proposed openstack/nova-specs master: Add nova-manage commands to show and refresh connection_info https://review.opendev.org/c/openstack/nova-specs/+/799624 | 10:12 |
| opendevreview | sean mooney proposed openstack/os-vif master: update os-vif ci to account for devstack default changes https://review.opendev.org/c/openstack/os-vif/+/798038 | 10:14 |
| opendevreview | sean mooney proposed openstack/os-vif master: add configurable per port bridges https://review.opendev.org/c/openstack/os-vif/+/798055 | 10:14 |
| opendevreview | Merged openstack/os-resource-classes master: [doc] Redirect people to #openstack-nova https://review.opendev.org/c/openstack/os-resource-classes/+/793833 | 10:22 |
| sean-k-mooney | stephenfin: care to pass an eye over the pci in placement draft https://review.opendev.org/c/openstack/nova-specs/+/791047/2/specs/xena/approved/pci-device-tracking-in-placement.rst | 10:41 |
| stephenfin | already looking :) | 10:41 |
| sean-k-mooney | :) | 10:41 |
| sean-k-mooney | ill be reworkign it to include the "do instance claim via conductor" part later today | 10:42 |
| sean-k-mooney | ill be afk for 20 mins just an fyi | 10:50 |
| gibi | bauzas: +Ad the mdev spec | 11:09 |
| gibi | sean-k-mooney: re: claim in conductor: so you say that the claim still happens on the compute service via a dedicated rpc call? | 11:11 |
| sean-k-mooney[m] | yes via a dedicated rpc call since the instance claim need to claim things in the resource tracker on that node. to do it entirely on the conductor we would need to make other change so that the resource tracker state is entirely reflected in the db which i don’t think it currently is | 11:15 |
| sean-k-mooney[m] | the pci devices and numa info should be | 11:16 |
| sean-k-mooney[m] | but mdevs are not and there may be other info missing to do it entirely in the conductor | 11:16 |
| sean-k-mooney[m] | we could try to confirm what the gaps would be i have not looked closely enough at what the claim is doing to confirm | 11:17 |
| gibi | but if the conductor calls the compute to claim, then how is that different from the currently existing rpc cast from the conductor to the compute to do the instance lifecycle operation? | 11:18 |
| sean-k-mooney[m] | well its a call for one so its synchronous, it will also happen earlier before we call any other service | 11:19 |
| sean-k-mooney[m] | the claims themselves are not currently stored in the db at least not directly | 11:19 |
| sean-k-mooney[m] | pci devices are claimed in the db and the instance numa topology blob contains any cpu or huge page assignments | 11:20 |
| sean-k-mooney[m] | but as far as i know there is no instance claim object stored in the db at any point which the compute node could retrieve in the periodic task when its doing its resource update | 11:21 |
| sean-k-mooney[m] | i could be wrong? | 11:22 |
| sean-k-mooney[m] | but even for migrations ect i think the move claims only exist in memory inside the migration context | 11:23 |
| gibi | so in case of a new instance build the scheduling happens here https://github.com/openstack/nova/blob/e7a7fd51d12d045ff134d55a4a1749c1feee0386/nova/conductor/manager.py#L1518 and the rpc cast to the compute is at the bottom of the function https://github.com/openstack/nova/blob/e7a7fd51d12d045ff134d55a4a1749c1feee0386/nova/conductor/manager.py#L1692 | 11:26 |
| gibi | inbetween I only see external calls to cyborg to bind arqs | 11:26 |
| gibi | the rest is pure python code afaik | 11:27 |
| gibi | anyhow my point is that I cannot really see the gain just by looking at it in theory. | 11:28 |
| gibi | I think a small PoC would be good to show that i) moving the claim to a separate rpc call is possible without blowing up both service and ii) we can make a claim a lot earlier than today by that move | 11:30 |
| opendevreview | Merged openstack/nova-specs master: Add generic mdevs to Nova https://review.opendev.org/c/openstack/nova-specs/+/792796 | 11:32 |
| sean-k-mooney | gibi: ack a small poc is resonable i can see if we can whip one up quickly | 11:34 |
| * lyarwood heads offline for a few hours but will be back this evening working on and reviewing specs if anyone has anything to send his way | 11:38 | |
| sean-k-mooney | /away | 11:41 |
| sean-k-mooney | basically i was hping to move it before we create the block device mappings https://github.com/openstack/nova/blob/e7a7fd51d12d045ff134d55a4a1749c1feee0386/nova/conductor/manager.py#L1645 | 11:42 |
| sean-k-mooney | proably to here at the latest https://github.com/openstack/nova/blob/e7a7fd51d12d045ff134d55a4a1749c1feee0386/nova/conductor/manager.py#L1625 | 11:43 |
| sean-k-mooney | i was orginally hopping to do it around here https://github.com/openstack/nova/blob/e7a7fd51d12d045ff134d55a4a1749c1feee0386/nova/conductor/manager.py#L1539 but that might be too early | 11:44 |
| sean-k-mooney | realistically it proably should be after the az and quota check https://github.com/openstack/nova/blob/e7a7fd51d12d045ff134d55a4a1749c1feee0386/nova/conductor/manager.py#L1586-L1614 | 11:46 |
| sean-k-mooney | so doing it per instance near the start of this loop would be earlest we could do it https://github.com/openstack/nova/blob/e7a7fd51d12d045ff134d55a4a1749c1feee0386/nova/conductor/manager.py#L1616-L1631 | 11:48 |
| gibi | sean-k-mooney: that bdm creation also just calling the db nothing realy time consuming happens there either | 11:51 |
| sean-k-mooney | the current instance claim happens here in the compute https://github.com/openstack/nova/blob/052cf963583ab7c6bbe4fcbf7bfe69f8f6733bdb/nova/compute/manager.py#L2383 | 11:52 |
| sean-k-mooney | so tere is not much on the comptue side before it | 11:52 |
| sean-k-mooney | i dont know it kindof feels wrong to me that we dont do the instance claim and placement allocation creation at the same time | 11:54 |
| sean-k-mooney | that woudl involve moveign the instnace claim even eairlier | 11:54 |
| gibi | I agree that we should do placement and compute claim as close as possible | 11:58 |
| gibi | for me a distance is mostly due to the RPC boundary | 11:58 |
| gibi | not the code between the placemetn allocation call and the instance claim | 11:58 |
| gibi | (except that cybor arq thing that also trigger external calls :/) | 11:58 |
| sean-k-mooney | this is where that happens correct | 12:12 |
| sean-k-mooney | https://github.com/openstack/nova/blob/052cf963583ab7c6bbe4fcbf7bfe69f8f6733bdb/nova/scheduler/filter_scheduler.py#L238-L241 | 12:12 |
| sean-k-mooney | we could do it here i guess https://github.com/openstack/nova/blob/052cf963583ab7c6bbe4fcbf7bfe69f8f6733bdb/nova/scheduler/utils.py#L1255 | 12:13 |
| sean-k-mooney | basiclly if the placment claim succeed we then to the instance claim | 12:14 |
| gibi | if we can do that there then that would be the closest thing possible | 12:15 |
| sean-k-mooney | ok ill see if i can poc that then the only issue with that is we need to make sure to release the instance_claim on the host if we fail for some reaosn but that shoudl be doable | 12:15 |
| gibi | lyarwood: left some comments in the nova-manage refres connection_info spec https://review.opendev.org/c/openstack/nova-specs/+/799624 | 12:15 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Align availability zone info with forced host https://review.opendev.org/c/openstack/nova/+/798145 | 12:16 |
| gibi | sean-k-mooney: yeah, cleanup could be tricky as now a claim might need to be cleaned both from the conductor if something fails before the rpc cast or cleaned from the compute if the e.g. the virt driver fails | 12:17 |
| stephenfin | bauzas: gibi: I think that matches up with what was requested? ^ | 12:17 |
| stephenfin | (the AZ-host mismatch patch) | 12:17 |
| gibi | stephenfin: looking | 12:17 |
| bauzas | stephenfin: will look | 12:18 |
| * stephenfin goes for a late lunch before getting back to spec reviews, bbiab | 12:18 | |
| *** osmanlicilegi is now known as Guest4 | 13:34 | |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Align availability zone info with forced host https://review.opendev.org/c/openstack/nova/+/798145 | 13:40 |
| stephenfin | bauzas: ^ | 13:40 |
| bauzas | stephenfin: ta, will look | 13:41 |
| * bauzas just tries to understand new acronyms with https://review.opendev.org/c/openstack/nova-specs/+/787458/9/specs/xena/approved/integration-with-off-path-network-backends.rst ;) | 13:42 | |
| gmann | gibi: ack, will check today | 13:58 |
| gibi | gmann: thanks | 13:59 |
| opendevreview | sean mooney proposed openstack/nova master: [DNM] testing os-vif use unreleased os-vif version to test live migration and upgrades https://review.opendev.org/c/openstack/nova/+/799680 | 14:55 |
| bauzas | sean-k-mooney: around ? | 15:02 |
| gibi | stephenfin: seems like the keystone doc job is broken since sqlalchemy 1.4 due to the the warning that is actually fixed by oslo.db 10.0.0 | 15:15 |
| stephenfin | oh, wonderful. So a catch-22? | 15:15 |
| gibi | a bit yes | 15:16 |
| gibi | you have more knowledge about sphinx, can we temporary turn off in it to treat warnings as errors? | 15:16 |
| gibi | that would be a way out | 15:16 |
| stephenfin | what's the link to the patch again? | 15:17 |
| gibi | btw, I'm OK to delete the keystone test, so I will abandon my patch | 15:17 |
| stephenfin | wait, got it | 15:17 |
| gibi | https://review.opendev.org/c/openstack/keystone/+/799670 | 15:17 |
| gibi | waiting... | 15:18 |
| gibi | stephenfin: at least the 10.0.0 req bump now green with a depends on on my keystone patch https://review.opendev.org/c/openstack/requirements/+/799054 | 15:21 |
| stephenfin | gibi: https://review.opendev.org/c/openstack/keystone/+/799682 | 15:22 |
| gibi | I'm not sure I can follow what that patch does. Does this syntax override the cache_ok.__doc__ ? | 15:24 |
| ganso | bauzas, lyarwood, melwitt: When you have a minute could you please take a look at this backport https://review.opendev.org/c/openstack/nova/+/798717 ? Thanks in advance! | 15:24 |
| stephenfin | yujp | 15:24 |
| stephenfin | *yup | 15:24 |
| gibi | jezus that feels like a bug in python :) | 15:24 |
| gibi | or at least an obscure feature | 15:24 |
| gibi | OK, so this will fix the doc bug, then we move your test fix top of it and then update the version bump patch to point to your test fix | 15:25 |
| gibi | I will update the requirement bump patch... | 15:26 |
| stephenfin | It's not Python - it's Sphinx. It's just attempting to do docstring inheritance which would be a sensible thing if you owned the entire subclassed stack | 15:26 |
| stephenfin | Sounds good to me | 15:27 |
| gibi | done | 15:27 |
| gmann | gibi: done, it is as expected because we still support legacy policy so old token can create server. added comment and marked as invalid until author has further query on usage part https://bugs.launchpad.net/nova/+bug/1934478 | 15:29 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Trivial style changes https://review.opendev.org/c/openstack/nova/+/799529 | 15:31 |
| opendevreview | Stephen Finucane proposed openstack/nova master: WIP: db: Integrate alembic https://review.opendev.org/c/openstack/nova/+/799530 | 15:31 |
| opendevreview | Stephen Finucane proposed openstack/nova master: fixup! db: Post reshuffle cleanup https://review.opendev.org/c/openstack/nova/+/799683 | 15:31 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Normalize migrations tests https://review.opendev.org/c/openstack/nova/+/799684 | 15:31 |
| gibi | gmann: thank you | 15:35 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Post reshuffle cleanup https://review.opendev.org/c/openstack/nova/+/799526 | 15:41 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Add initial alembic migration for main DB https://review.opendev.org/c/openstack/nova/+/799527 | 15:41 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Add initial alembic migration for API DB https://review.opendev.org/c/openstack/nova/+/799528 | 15:41 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Trivial style changes https://review.opendev.org/c/openstack/nova/+/799529 | 15:41 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Normalize migrations tests https://review.opendev.org/c/openstack/nova/+/799684 | 15:41 |
| opendevreview | Stephen Finucane proposed openstack/nova master: WIP: db: Integrate alembic https://review.opendev.org/c/openstack/nova/+/799530 | 15:41 |
| gibi | nova meeting starts in 15 minutes here in the channel | 15:45 |
| gibi | stephenfin: I only have a naming question in https://review.opendev.org/c/openstack/nova/+/798145/4/nova/tests/unit/api/openstack/compute/test_servers.py#4537 | 15:49 |
| stephenfin | gibi: open to ideas on naming. I don't have anything better :) | 15:55 |
| gibi | stephenfin: I'm wondering if that is really a mismatch case as both the default az is zone1 and the host is in zone1 | 15:56 |
| gibi | never mind | 15:57 |
| gibi | I see your reasoning in the review now | 15:57 |
| gibi | #startmeeting nova | 16:00 |
| opendevmeet | Meeting started Tue Jul 6 16:00:10 2021 UTC and is due to finish in 60 minutes. The chair is gibi. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
| opendevmeet | The meeting name has been set to 'nova' | 16:00 |
| gibi | o/ | 16:00 |
| elodilles | o/ | 16:00 |
| stephenfin | o/ | 16:00 |
| bauzas | \o | 16:00 |
| gmann | o/ | 16:00 |
| gibi | #topic Bugs (stuck/critical) | 16:01 |
| gibi | no critical bugs | 16:01 |
| gibi | #link 25 new untriaged bugs (+2 since the last meeting): #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New | 16:01 |
| sean-k-mooney | o/ | 16:01 |
| gibi | is there any specific bug that we need to talk about | 16:01 |
| gibi | ? | 16:01 |
| gibi | #topic Gate status | 16:03 |
| gibi | Nova gate bugs #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure | 16:03 |
| gibi | the latest in that list https://bugs.launchpad.net/nova/+bug/1934519 | 16:04 |
| gibi | it solved itself magically | 16:04 |
| gibi | is there any recent gate issue that is happening but not in this list? | 16:04 |
| gibi | #topic Release Planning | 16:05 |
| sean-k-mooney | just a note that i finaly fixed the os-vif gate | 16:05 |
| gibi | sean-k-mooney: thanks | 16:06 |
| sean-k-mooney | although the patch still needs review | 16:06 |
| gibi | link it up here please | 16:06 |
| sean-k-mooney | sure one sec continue on while i find it | 16:06 |
| sean-k-mooney | https://review.opendev.org/c/openstack/os-vif/+/798038 | 16:06 |
| sean-k-mooney | all 3 jobs were using ovn instead of the mix of backend that is fixed by that patch | 16:07 |
| gibi | thanks, I will check it after the meeting | 16:07 |
| gibi | so | 16:07 |
| gibi | #topic Release Planning | 16:07 |
| gibi | Milestone 2 is next Thursday (15 of July) which is spec freeze | 16:07 |
| gibi | Today is spec review day #link http://lists.openstack.org/pipermail/openstack-discuss/2021-June/023083.html | 16:07 |
| gibi | we already have 15 bps approved | 16:08 |
| gibi | that seems plenty | 16:08 |
| gibi | we have 8 open specs | 16:08 |
| gibi | all of them has some form of feedback already | 16:08 |
| gibi | so we did a good job reviewing specs today | 16:09 |
| gibi | there is still time to land them | 16:09 |
| gibi | but I hoping for a spec freeze without any FFE | 16:09 |
| gibi | any qustions comment about the coming milestone? | 16:09 |
| bauzas | nope | 16:10 |
| gibi | #topic Stable Branches | 16:11 |
| gibi | stable gates are not blocked as far as I know | 16:11 |
| gibi | this patch could spare us some rechecks if merged all the way back till pike: https://review.opendev.org/q/Id3e4452883f6a3cf44ff58b39ded82e882e28c23 | 16:11 |
| gibi | EOM (from elodilles ) | 16:11 |
| gibi | do we want to push some stable releases around M2? | 16:11 |
| elodilles | that might be good i think | 16:12 |
| bauzas | do we need some review eyes for the stable branches ? | 16:12 |
| elodilles | as we haven't released recently (maybe 1-2 month ago) | 16:13 |
| elodilles | bauzas: reviews are always welcome on stable branches :) | 16:13 |
| gibi | elodilles: you can hit me with the release patches | 16:14 |
| elodilles | but I don't have any specific patch (except the one linked above) | 16:14 |
| elodilles | gibi: what is the best timing? ASAP now, or just after ML2? | 16:15 |
| gibi | elodilles: I think we can be flexible | 16:15 |
| gibi | whathever fits the stable team agenda | 16:15 |
| elodilles | OK, I'll check the release content and will see | 16:15 |
| gibi | cool, thanks | 16:16 |
| gibi | any other stable business for today? | 16:16 |
| elodilles | nothing from me | 16:16 |
| gibi | #topic Sub/related team Highlights | 16:17 |
| gibi | Libvirt (bauzas) | 16:17 |
| bauzas | nothing to tell | 16:17 |
| gibi | #topic Open discussion | 16:17 |
| gibi | there is one topic on the agenda | 16:17 |
| gibi | yonglihe: Hi, gibi and everyone, here is the smartnic patch set status: 6 of 7 patches got +2 from alex_xu, the functional testing is under reviewing. seems a bulk of core time needed, thanks anyone's help on it, sincerely. https://review.opendev.org/q/topic:%22bp%252Fsriov-smartnic-support%22+(status:open%20OR%20status:merged) | 16:17 |
| gibi | so basicly yonglihe asking for review | 16:18 |
| gibi | I'm pretty swamped these days so if somebody has time, then please go ahead | 16:18 |
| sean-k-mooney | oh that reminds me ill respin the review priorty patch sorry forgot to do that | 16:19 |
| gibi | sean-k-mooney: good point, we can start using that | 16:19 |
| stephenfin | I have one other thing to add | 16:19 |
| sean-k-mooney | ill do that after the meeting | 16:19 |
| gibi | thanks | 16:19 |
| gibi | I see no cores queueing up for reviewing the smart nic impl so I will keep it on my radar | 16:19 |
| gibi | stephenfin: stage is yours then | 16:20 |
| stephenfin | I brought up the changes to os-vif stable core membership on openstack-discuss a week and a half ago and didn't hear any objections http://lists.openstack.org/pipermail/openstack-discuss/2021-June/023305.html | 16:20 |
| stephenfin | so I think we can proceed with that change now | 16:20 |
| gibi | elodilles, lyarwood, sean-k-mooney: any last minute objection? | 16:21 |
| sean-k-mooney | not form me | 16:21 |
| gibi | or from anybody else? | 16:21 |
| gibi | then lets do it | 16:21 |
| elodilles | no objection from me | 16:21 |
| gibi | cool | 16:22 |
| gibi | then I will note the agreement in the review https://review.opendev.org/c/openstack/project-config/+/798071 | 16:22 |
| gibi | anything else for today? | 16:23 |
| gibi | if not then thanks for joining today. | 16:24 |
| gibi | #endmeeting | 16:24 |
| opendevmeet | Meeting ended Tue Jul 6 16:24:41 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:24 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2021/nova.2021-07-06-16.00.html | 16:24 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2021/nova.2021-07-06-16.00.txt | 16:24 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2021/nova.2021-07-06-16.00.log.html | 16:24 |
| sean-k-mooney | gibi: cool am i started reviewing the placment chagne by the way i got intrupted yesteday so just pushed what i have sofar. ill review it porperly again tomorow | 16:25 |
| sean-k-mooney | https://review.opendev.org/c/openstack/placement/+/784020 | 16:25 |
| sean-k-mooney | so far it look pretty good but i think you can simplfy it slightly | 16:26 |
| gibi | sean-k-mooney: thanks a lot | 16:26 |
| sean-k-mooney | tl;dr i dont think we need one branc to set it to none and another to set it to a different value although what you have now is still technially correct and will work | 16:27 |
| stephenfin | bauzas: have I answered your questions on https://review.opendev.org/c/openstack/nova-specs/+/793199 ? Care to bump your +1 if so? | 16:27 |
| gibi | sean-k-mooney: ack, I will look into that suggestion later this week | 16:28 |
| gibi | my brain already fried for today | 16:28 |
| gmann | stephenfin: gibi can you check policy warnings patches https://review.opendev.org/c/openstack/nova/+/799422 and placement which is already reviewed by stephenfin https://review.opendev.org/c/openstack/placement/+/799418 | 16:28 |
| bauzas | stephenfin: just did +W | 16:28 |
| sean-k-mooney | ack i was not leand towrad -1 more of a nit anyway | 16:29 |
| gibi | gmann: ack | 16:29 |
| gmann | thanks | 16:30 |
| sean-k-mooney | brb | 16:34 |
| * bauzas calls the day | 16:36 | |
| stephenfin | gmann: Apologies for inflicting unnecessary pain on you there. The warning seemed like the only way to get people to use the new thing, but it is very noisy to be fair | 16:36 |
| stephenfin | i.e. https://github.com/openstack/oslo.policy/blob/3.7.0/oslo_policy/policy.py#L1538 | 16:37 |
| gmann | stephenfin: yeah, I am updating all the current usage for those warning https://review.opendev.org/q/topic:%22fix-oslo-policy-warnings%22+(status:open%20OR%20status:merged) | 16:37 |
| gmann | stephenfin: and once we merge all these then I am thinking to convert it to error from oslo side so that all the DeprecatedRule usgae in new RBAC work will be proper | 16:38 |
| opendevreview | Merged openstack/nova-specs master: Repropose "vm-boot-with-unaddressed-port" spec https://review.opendev.org/c/openstack/nova-specs/+/793199 | 16:39 |
| *** rpittau is now known as rpittau|afk | 16:39 | |
| sean-k-mooney | ralonsoh: stephenfin: https://review.opendev.org/c/openstack/nova/+/799680 so it looks that os-vif patch works well | 16:49 |
| sean-k-mooney | i modified the nova live migration and grenade jobs to use it | 16:49 |
| ralonsoh | sean-k-mooney, do you think we need to add more testing? to add more tempest tests? | 16:50 |
| ralonsoh | just for the spec | 16:50 |
| sean-k-mooney | i think the exising jobs can be configured to cover the different cases. e.g. we can test ovn with per port bridges in nova-livemigration but use ml2/ovs with iptables in nova-livemigration-ceph | 16:51 |
| sean-k-mooney | ralonsoh: i would hope that neutron has a live migration jobs too where it can be enabled. | 16:52 |
| ralonsoh | sean-k-mooney, btw, I think you should add neutron dependency to this patch | 16:52 |
| sean-k-mooney | on the os-vif side i may add a grenade job | 16:52 |
| sean-k-mooney | ralonsoh: against which patch? the spec? | 16:52 |
| ralonsoh | this nova patch | 16:52 |
| sean-k-mooney | sorry can you rephase that | 16:53 |
| ralonsoh | changing when we send the plugged event | 16:53 |
| ralonsoh | but of course | 16:53 |
| ralonsoh | we need Nova to accept this | 16:53 |
| ralonsoh | nevermind | 16:53 |
| sean-k-mooney | oh right that is a sperate change | 16:53 |
| ralonsoh | ok, I'll push Neutron patch first | 16:53 |
| sean-k-mooney | the corrent nova behavior is to just not wait for ovn in prelive migration | 16:54 |
| ralonsoh | exactly and wait for the port plug event | 16:54 |
| sean-k-mooney | so once your neutron patch is up we can add a nova one that will make it start waiting | 16:54 |
| sean-k-mooney | ping me when the neutorn patch is up if you would like me to write the nova one. its should not be that hard but i probaly will not get to it until monday | 16:55 |
| ralonsoh | sean-k-mooney, sure, tomorrow | 16:55 |
| sean-k-mooney | ralonsoh: no worries its getting late for you | 16:58 |
| *** mgoddard- is now known as mgoddard | 17:26 | |
| stephenfin | sean-k-mooney: https://review.opendev.org/c/openstack/os-vif/+/798055 looks pretty good. If you've time to address my comments tonight I'll +2 in the AM | 17:26 |
| * stephenfin finishes for the day | 17:27 | |
| sean-k-mooney | stephenfin: am i want to poc something else this evening but ill adress it tomorow | 17:28 |
| opendevreview | Merged openstack/placement master: Fix oslo policy DeprecatedRule warnings https://review.opendev.org/c/openstack/placement/+/799418 | 17:35 |
| opendevreview | Merged openstack/nova master: Fix oslo policy DeprecatedRule warnings https://review.opendev.org/c/openstack/nova/+/799422 | 18:16 |
| opendevreview | Merged openstack/os-vif master: update os-vif ci to account for devstack default changes https://review.opendev.org/c/openstack/os-vif/+/798038 | 18:52 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!