| opendevreview | Ghanshyam proposed openstack/nova master: DNM: testing https://review.opendev.org/c/openstack/nova/+/794863 | 01:31 |
|---|---|---|
| opendevreview | Takashi Kajinami proposed openstack/nova master: Fix request path to query a resource provider by uuid https://review.opendev.org/c/openstack/nova/+/800855 | 02:28 |
| zhangtongjian | songwenping__:hi | 03:33 |
| zhangtongjian | songwenping__: hello | 03:34 |
| *** akekane_ is now known as abhishekk | 07:15 | |
| *** rpittau|afk is now known as rpittau | 07:24 | |
| bauzas | hola folks | 08:06 |
| * bauzas is back from one week off | 08:06 | |
| bauzas | just reading a few things | 08:09 |
| bauzas | mnaser: never ever play with default_schedule_zone=nova ;) see the big warning quote in red on our upstream docs : https://docs.openstack.org/nova/latest/admin/availability-zones.html | 08:10 |
| gibi | bauzas: o/ | 08:28 |
| gibi | bauzas: welcome back | 08:28 |
| gibi | bauzas: if you are looking for a review for warm up then I suggest https://review.opendev.org/c/openstack/placement/+/784020 :) | 08:28 |
| *** akekane_ is now known as abhishekk | 08:57 | |
| bauzas | gibi: doing email scrubbing will look for surez | 09:06 |
| gibi | thanks | 09:25 |
| * gibi has to drop of for a whiel | 09:25 | |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Silence SQLAlchemy warnings https://review.opendev.org/c/openstack/nova/+/800900 | 09:47 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Remove unnecessary warnings filter https://review.opendev.org/c/openstack/nova/+/800901 | 09:47 |
| stephenfin | bauzas: Think you could look at the first of those. It's dead simple and would remove a *lot* of noise from our CI logs. I'll bug gibi/melwitt when they're back | 09:54 |
| stephenfin | / around | 09:54 |
| bauzas | stephenfin: ack | 10:03 |
| opendevreview | Stephen Finucane proposed openstack/placement master: objects: Replace implicit conversion of SELECT into FROM https://review.opendev.org/c/openstack/placement/+/800910 | 10:43 |
| opendevreview | Stephen Finucane proposed openstack/placement master: tox: Remove psycopg2 warning filter https://review.opendev.org/c/openstack/placement/+/800911 | 10:43 |
| stephenfin | bauzas: Another two for you. That should get rid of all of our warnings, hopefully ^ | 10:44 |
| stephenfin | gibi: Care to look at https://review.opendev.org/c/openstack/nova/+/800900 to silence all those awful SQLAlchemy warnings for now? | 11:00 |
| gibi | stephenfin: thanks for creating that WA ^^ | 11:13 |
| opendevreview | Merged openstack/placement master: Move placement specs from nova https://review.opendev.org/c/openstack/placement/+/800769 | 11:16 |
| opendevreview | Merged openstack/nova master: tests: Silence SQLAlchemy warnings https://review.opendev.org/c/openstack/nova/+/800900 | 11:44 |
| gibi | gmann: I've read the spec and the IRC discussion about the hypervisor uuid. I think if we want to make progress in X then we should go with the microversion route (option 3 in the spec) as we have specfreeze today. This should not prevent us to continue talking about creating some solution that is backportable. | 11:44 |
| gibi | gmann: regarding the backportable fix; is there a way today for the admin to customize the new RBAC policies in a way to implement option 1? | 11:46 |
| gibi | I got that our default is not good for them out of the box, but is there a way for them to change the policy.yaml in a way that solves the listing problem? | 11:47 |
| opendevreview | Merged openstack/nova-specs master: Re-propose nova-audit spec for Xena https://review.opendev.org/c/openstack/nova-specs/+/800570 | 11:50 |
| *** iurygregory_ is now known as iurygregory | 12:07 | |
| opendevreview | Yongli He proposed openstack/nova master: Smartnic support - cyborg drive https://review.opendev.org/c/openstack/nova/+/771362 | 12:08 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support - new vnic type https://review.opendev.org/c/openstack/nova/+/771363 | 12:08 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support - create arqs https://review.opendev.org/c/openstack/nova/+/758944 | 12:08 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support - build instance with smartnic arqs https://review.opendev.org/c/openstack/nova/+/798249 | 12:08 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support - cleanup arqs https://review.opendev.org/c/openstack/nova/+/798054 | 12:08 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support - reject server move and suspend https://review.opendev.org/c/openstack/nova/+/779913 | 12:08 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support - functional tests https://review.opendev.org/c/openstack/nova/+/780147 | 12:08 |
| ganso | bauzas, lyarwood: Hi! sorry to bother about this again, if you could please take a look at backport https://review.opendev.org/c/openstack/nova/+/800114 when you have a minute, it is the last in the series, just needs one last +2 and +W to go. Thanks in advance! | 12:52 |
| opendevreview | Alexandre arents proposed openstack/nova master: libvirt: Abort live-migration job when monitoring fails https://review.opendev.org/c/openstack/nova/+/764435 | 14:07 |
| aarents | lyarwood: thks for review https://review.opendev.org/c/openstack/nova/+/764435 , I fixed the nits, As I said in comments I'm wondering if it closes also https://bugs.launchpad.net/nova/+bug/1536589 https://bugs.launchpad.net/nova/+bug/1924585 | 14:12 |
| aarents | (older bugs I didn't see before) | 14:13 |
| gmann | gibi: for option1, it cannot be olved via modified poliyc.yaml as GET hypervisor API is scoped to 'system' which is not overridable in policy. | 14:26 |
| gmann | gibi: but we have workaround in different way, 1. system admin give hypervisor name to project admin via non-api way (some document, email or so) 2. assigning the multi role to token like project admin gets the system admin role for that specific request. | 14:28 |
| gibi | gmann: I guess making the scope overridable via policy.yaml would also be considered a feature and hence wont be backportable | 14:30 |
| gmann | gibi: regarding spec for Xena, as we still support legacy policy we have not broken operator yet. I am not so confident/confirm on what solution is best for which use case from operator. I think it is better not to hurry for Xena. | 14:30 |
| gmann | gibi: humm, that will change the design of new RBAC. initial thought was to keep scope as hardcoded for secure security. | 14:30 |
| gibi | gmann: OK, then that is probably a rabbit hole we don't want to go down | 14:31 |
| gmann | yeah, or need more discussion as these project-admin issue were not considered before | 14:32 |
| gmann | I think we should discuss this again in PTG, and also what other project doing for their project-mapped resources need system info | 14:32 |
| gmann | having a consistent solution among all service will matter for operator even that is not best | 14:33 |
| gibi | maybe we can create a simple WA config flag in nova conf that changes the scope of the hypervisor API. that would be ugly but backportable | 14:33 |
| gmann | we have flag to disable the scope check so that is what operator can do. for scope, I am more inclined towards hardcoded only. | 14:35 |
| gmann | but that flag is for all the policy not for particular one | 14:35 |
| gmann | gibi: dansmith but on backport I am re-thinking - does it solve the issue of interrogability or feature-notification ? as many cloud might be upgrading from ocata or less where we cannot backport ? | 14:36 |
| gmann | gibi: dansmith ah sorry, new RBAC is since ussuri so we are good if any backportable soltuion. | 14:37 |
| gmann | and for < ussuri, we anyways have old policy keep working for them | 14:37 |
| gibi | gmann: so the disable scope check flag can be used as a WA? | 14:40 |
| gmann | gibi: right, "disable scope check + override policy.yaml" is WA | 14:41 |
| gmann | that way I think this is not so bad right? | 14:42 |
| gibi | is that enough for stable branches or you would like some extra help for the deployers? | 14:42 |
| gibi | for me it does not sound bad | 14:42 |
| gmann | and fix the default with microversion... ? | 14:43 |
| gibi | yep, fix the situation master | 14:43 |
| gmann | my only concern is disable scope check is for all the policy. BUT nobody has moved to scope check yet so I think it is fine. | 14:45 |
| gmann | gibi: do i have time to make it in Xena. if i update the spec today (right after the TC meeting 1.15 hr from now) ? | 14:45 |
| gmann | I think I am fine on 'doing it in microversion + document the WA' | 14:46 |
| melwitt | elodilles: heads up, I backported the super squash to stable/train https://review.opendev.org/c/openstack/nova/+/795435 here, although ... afaict the gate is no longer broken on train? not sure what happened | 15:10 |
| gibi | gmann: sure. I will review the spec after you updated and we can ask sean-k-mooney or dansmith to give the other +2 | 15:10 |
| gmann | gibi: thanks | 15:12 |
| gibi | gmann: also I don't think anyone will be mad if we land that spec tomorrow :) | 15:13 |
| gmann | gibi: ack | 15:17 |
| gibi | gmann: just ping me when the spec is up. I will be on and off during my evening / night but I will be working as my wife does too | 15:18 |
| gmann | gibi: sure, thanks | 15:19 |
| opendevreview | Merged openstack/nova stable/stein: Error anti-affinity violation on migrations https://review.opendev.org/c/openstack/nova/+/800114 | 15:25 |
| opendevreview | Balazs Gibizer proposed openstack/placement master: Bump os-resource-classes requirements https://review.opendev.org/c/openstack/placement/+/796595 | 15:39 |
| elodilles | melwitt: the gate was not broken in train, but tosky suggested that for convenience we should backport the zuulv3 job patch to train as well. however I am not fond of this patch to backport when we don't really need it o:) | 15:41 |
| melwitt | elodilles: ah, ok, I wasn't 100% clear on the context there. I am neutral about it | 15:42 |
| elodilles | well, I don't have hard feelings either, so if stable cores insist then I'm not completely against it :) | 15:43 |
| melwitt | I think I got lost in all the CI fail that I thought stable/train was also failing 😆 | 15:45 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Parse extended resource request from the port data https://review.opendev.org/c/openstack/nova/+/800085 | 15:45 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Transfer RequestLevelParams from ports to scheduling https://review.opendev.org/c/openstack/nova/+/791506 | 15:45 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Support boot with extended resource request https://review.opendev.org/c/openstack/nova/+/800086 | 15:45 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Support move ops with extended resource request https://review.opendev.org/c/openstack/nova/+/800087 | 15:45 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [func test]Refactor interface attach with qos https://review.opendev.org/c/openstack/nova/+/800088 | 15:45 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Support interaface attach / detach with new resource request format https://review.opendev.org/c/openstack/nova/+/800089 | 15:45 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move unshelve test to the proper place https://review.opendev.org/c/openstack/nova/+/793621 | 15:45 |
| elodilles | melwitt: Lee explained somewhere why it is not failing in Train, but I don't find that comment now :/ but anyway, fortunately Train is not blocked by this \o/ | 15:50 |
| melwitt | ack | 15:51 |
| *** rpittau is now known as rpittau|afk | 16:17 | |
| tosky | elodilles, melwitt: yeah, I've added my comments to the patch, I think it makes sense anyway (the long term plan was to remove the legacy jobs anyway) | 17:02 |
| opendevreview | Balazs Gibizer proposed openstack/placement master: Bump os-resource-classes requirements https://review.opendev.org/c/openstack/placement/+/796595 | 17:17 |
| opendevreview | Balazs Gibizer proposed openstack/placement master: Bump os-resource-classes requirements https://review.opendev.org/c/openstack/placement/+/796595 | 17:30 |
| opendevreview | Balazs Gibizer proposed openstack/placement master: Bump os-resource-classes requirements https://review.opendev.org/c/openstack/placement/+/796595 | 17:40 |
| *** __ministry1 is now known as __ministry | 17:45 | |
| gmann | gibi: dansmith melwitt sean-k-mooney As we need to do the hypervisor uuid support via microversion, and while updating spec for that, I thought it is good chance to remove the legacy way of force host things (via availability_zone) in same microversion + standardizing existing field itself instead of adding new one. | 17:49 |
| gmann | with that I will leave this for xena and we can discuss in PTG for the improvement I added here https://review.opendev.org/c/openstack/nova-specs/+/793011/3/specs/xena/approved/allow-project-admin-list-hypervisors.rst#44 | 17:49 |
| dansmith | gmann: I'm okay with that and I think others are pro-that as well | 17:51 |
| gibi | gmann: ack. please add it to the ptg etherhpad https://etherpad.opendev.org/p/nova-yoga-ptg | 17:52 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] create pps resource on OVS agent RP https://review.opendev.org/c/openstack/nova/+/787205 | 17:52 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move port creation to the NeutronFixture https://review.opendev.org/c/openstack/nova/+/787206 | 17:52 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] neutron fixture for extended resource request https://review.opendev.org/c/openstack/nova/+/794306 | 17:52 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Detect extended_resource_request neutron API extension https://review.opendev.org/c/openstack/nova/+/793618 | 17:52 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Reject server create with extended resource req https://review.opendev.org/c/openstack/nova/+/793619 | 17:52 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Reject server operations with extended resource req https://review.opendev.org/c/openstack/nova/+/793620 | 17:52 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Add same_subtree field to RequestLevelParams https://review.opendev.org/c/openstack/nova/+/791503 | 17:52 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Bump os-resource-classes to 1.1.0 https://review.opendev.org/c/openstack/nova/+/800976 | 17:52 |
| gmann | sure | 17:52 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Bump min placement microversion to 1.36 https://review.opendev.org/c/openstack/nova/+/791504 | 17:59 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Support same_subtree in allocation_canadidate query https://review.opendev.org/c/openstack/nova/+/791505 | 18:01 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] refactor assertPortMatchesAllocation https://review.opendev.org/c/openstack/nova/+/792458 | 18:01 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] refactor asserts in qos tests https://review.opendev.org/c/openstack/nova/+/798930 | 18:01 |
| gmann | gibi: done | 18:05 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] ports with both bw and pps resources https://review.opendev.org/c/openstack/nova/+/792394 | 18:07 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Parse extended resource request from the port data https://review.opendev.org/c/openstack/nova/+/800085 | 18:07 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Transfer RequestLevelParams from ports to scheduling https://review.opendev.org/c/openstack/nova/+/791506 | 18:07 |
| *** ministry is now known as __ministry | 18:09 | |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Support boot with extended resource request https://review.opendev.org/c/openstack/nova/+/800086 | 18:14 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Support move ops with extended resource request https://review.opendev.org/c/openstack/nova/+/800087 | 18:14 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [func test]Refactor interface attach with qos https://review.opendev.org/c/openstack/nova/+/800088 | 18:16 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Support interaface attach / detach with new resource request format https://review.opendev.org/c/openstack/nova/+/800089 | 18:16 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move unshelve test to the proper place https://review.opendev.org/c/openstack/nova/+/793621 | 18:16 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Bump os-resource-classes to 1.1.0 https://review.opendev.org/c/openstack/nova/+/800976 | 18:53 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] create pps resource on OVS agent RP https://review.opendev.org/c/openstack/nova/+/787205 | 18:53 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move port creation to the NeutronFixture https://review.opendev.org/c/openstack/nova/+/787206 | 18:53 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] neutron fixture for extended resource request https://review.opendev.org/c/openstack/nova/+/794306 | 18:53 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Detect extended_resource_request neutron API extension https://review.opendev.org/c/openstack/nova/+/793618 | 18:56 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Reject server create with extended resource req https://review.opendev.org/c/openstack/nova/+/793619 | 18:57 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Reject server operations with extended resource req https://review.opendev.org/c/openstack/nova/+/793620 | 18:59 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Add same_subtree field to RequestLevelParams https://review.opendev.org/c/openstack/nova/+/791503 | 18:59 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Bump min placement microversion to 1.36 https://review.opendev.org/c/openstack/nova/+/791504 | 18:59 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Support same_subtree in allocation_canadidate query https://review.opendev.org/c/openstack/nova/+/791505 | 18:59 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] refactor assertPortMatchesAllocation https://review.opendev.org/c/openstack/nova/+/792458 | 19:01 |
| spatel | sean-k-mooney hey! | 19:01 |
| spatel | Any idea about this error during instance create? | 19:02 |
| spatel | ERROR (BadRequest): The requested availability zone is not available (HTTP 400) (Request-ID: req-aa7f2176-105b-4da8-8516-24310a85927a) | 19:02 |
| spatel | I saw this reference - https://bugs.launchpad.net/fuel/+bug/1610309 | 19:02 |
| spatel | I am running stein | 19:02 |
| amodi | spatel: does the az with the name u're trying to provide exist already? | 19:03 |
| spatel | Yes | 19:04 |
| spatel | look ate this https://paste.opendev.org/show/807515/ | 19:04 |
| spatel | amodi I have created foo and its saying not available | 19:04 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] refactor asserts in qos tests https://review.opendev.org/c/openstack/nova/+/798930 | 19:05 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] ports with both bw and pps resources https://review.opendev.org/c/openstack/nova/+/792394 | 19:05 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Parse extended resource request from the port data https://review.opendev.org/c/openstack/nova/+/800085 | 19:05 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Transfer RequestLevelParams from ports to scheduling https://review.opendev.org/c/openstack/nova/+/791506 | 19:05 |
| amodi | spatel: yes so it looks like u need to make it 'available' first, the instance creation error won't persist | 19:07 |
| amodi | im not an expert, so that was my best guess | 19:07 |
| spatel | mostly they are available when you create but this is very odd | 19:09 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Support boot with extended resource request https://review.opendev.org/c/openstack/nova/+/800086 | 19:16 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Support move ops with extended resource request https://review.opendev.org/c/openstack/nova/+/800087 | 19:16 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [func test]Refactor interface attach with qos https://review.opendev.org/c/openstack/nova/+/800088 | 19:18 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Support interaface attach / detach with new resource request format https://review.opendev.org/c/openstack/nova/+/800089 | 19:18 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move unshelve test to the proper place https://review.opendev.org/c/openstack/nova/+/793621 | 19:18 |
| spatel | found my problem, on that AZ all the compute nodes where disabled in openstack that is why it was showing not available :) | 20:18 |
| spatel | sorry for confusion | 20:18 |
| JayF | Is there a known issue with stable/wallaby CI? I've been trying to get https://review.opendev.org/c/openstack/nova/+/799772 through the gate and there's a barrage of random-seeming failures. The change itself is in the ironic driver; the failures are clearly unrelated. | 21:28 |
| JayF | I feel a little bad rechecking something 5+ times to get it through, so I thought I'd check to ensure there's not any known issues with stable/wallaby gate. | 21:28 |
| JayF | A majority, but not all of the failures have been a 400 error around Invalid Volume (details in comments on the patch) | 21:30 |
| sean-k-mooney | at least on of the failures is the device detach bug for volume detach | 21:31 |
| sean-k-mooney | Device detach failed for vdb: Run out of retry while detaching device vdb with device alias virtio-disk1 | 21:31 |
| JayF | That sounds like it matches the error I was referring to | 21:31 |
| sean-k-mooney | JayF: that is a known isue | 21:31 |
| JayF | Is there a backportable patch for it? Or just keep slamming rechecks | 21:31 |
| sean-k-mooney | there is a fix for it im not sure if it has been backported | 21:31 |
| sean-k-mooney | tl;dr qemu change the behavior so that trying to detach a volume that is detaching woudl cancel the detach and reslut in an error | 21:32 |
| sean-k-mooney | that broke nova retry logic | 21:32 |
| JayF | hmm. Maybe I'll dig and see if it backports cleanly. I obviously know a lot more about Ironic than nova, but if I can get it fixed why not :D | 21:32 |
| sean-k-mooney | the fix is to use event instead of a retry loop | 21:32 |
| sean-k-mooney | JayF: gibi and lyarwood have looked at backporting it | 21:33 |
| sean-k-mooney | let me see if i can find it | 21:33 |
| JayF | This patch I'm trying to land fixes a nasty bug in Ironic that we have confirmed multiple operators are experiencing, so I'm trying to get it backported as far as possible :D I appreciate the help | 21:33 |
| sean-k-mooney | did you say this was wallaby or is it an older release | 21:35 |
| sean-k-mooney | it looks like ist on wallaby https://review.opendev.org/c/openstack/nova/+/788720 | 21:35 |
| JayF | Right now wallaby, when that lands I'll go w-1, and so on until it's not clean :) | 21:35 |
| JayF | but I know my deployment will need it for wallaby, and a couple others at a minimum | 21:36 |
| JayF | Uh oh. So it shouldn't be happening :-| | 21:36 |
| sean-k-mooney | so the event change patch has been backported to wallaby already so you might be hitting the other detach bug | 21:36 |
| sean-k-mooney | there is an issue where the guest seam to not respond to the detach properly in all caes | 21:37 |
| sean-k-mooney | as a workaround we were looking ad modifying tempest to not do detaches when not needed | 21:37 |
| JayF | That sounds good, so for now I'm going to keep rechecking and hope to win the gate-lottery. I'd offer to review the tempest workaround but I'm not sure a +1 form me would be that helpful :D | 21:39 |
| sean-k-mooney | JayF: https://review.opendev.org/c/openstack/tempest/+/794757 i think this might be it | 21:40 |
| sean-k-mooney | unfortuetly lee i snot around for the next 2 week due to real world stuff so not sure if that is going to proguress | 21:40 |
| JayF | That's fine :) I'm honestly surprised to have gotten the concierge bug walkthrough with you, and I appreciate it :D. | 21:41 |
| sean-k-mooney | JayF: in general device detach has been flakeing in the jobs for the last why and it does not really seam to be related ot change in nova code | 21:41 |
| JayF | It's extra annoying for VM errors to be cratering an ironic-driver-only change :P | 21:41 |
| sean-k-mooney | the latest issue may be a regression in qemu | 21:41 |
| sean-k-mooney | JayF: yes | 21:41 |
| JayF | I guess targetting a bunch of different qemu versions might have a similar problems to what we see in Ironic with ... unfortunately designed hardware BMCs :P | 21:42 |
| sean-k-mooney | ill ask gibi tomorrow if we should consider making the job non voteing. it generally has not been wedgeing the gate but it has been failing frequetly enough that we might want to consider skiping the test or just manually reviewing the job for now | 21:43 |
| JayF | thanks! I'll keep idling in here, feel free to ping me if there's anything I can do to help :) | 21:44 |
| JayF | [or if you ever need someone with the big review hammer in Ironic :D] | 21:45 |
| sean-k-mooney | i wonder if we could make the live migation jobs skip on change that only affect the ironic driver | 21:45 |
| sean-k-mooney | you know since i dont precive that mattering to your use case unless the laws of physic cahnge | 21:46 |
| JayF | I think that's a potentially wise change to make, but don't underestimate the ability of python to violate the laws of physics :P | 21:46 |
| sean-k-mooney | im pretty sure we could add nova/test/unit/virt/ironic and nova/virt/ironic to the irrelevent files list | 21:47 |
| JayF | I'd be happy to +1 such a change | 21:48 |
| sean-k-mooney | so we would jsut need to add those here https://github.com/openstack/nova/blob/master/.zuul.yaml#L93-L107 | 21:49 |
| JayF | and, for purposes of my patch, it'd also need to be backported | 21:49 |
| sean-k-mooney | well that used selse where so we would have to refactor slightly it should not be terrible. yep we would have to backport it first | 21:50 |
| JayF | hmm where else would it need to go :) | 21:50 |
| JayF | I was already on the way to making the change against main branch | 21:51 |
| sean-k-mooney | currently the deffinition of *nova-base-irrelevant-files is in the live migraiton job we would need to move that to say nova-next which also uses it | 21:52 |
| sean-k-mooney | then defein a new nova-live-migration-irrelavent-files that the ceph job would also use | 21:52 |
| sean-k-mooney | although that may or may not be enough to get your patch to pass | 21:53 |
| sean-k-mooney | e.g. the grenade job might fail in a similar way | 21:53 |
| JayF | Yeah, we've seen it fail on several different jobs for sure. Reducing the number of times we have to roll the dice will only raise the likelihood of that patch getting landed, though | 21:53 |
| sean-k-mooney | am its late for me corrently so im going to call it a night | 21:54 |
| JayF | o/ have a good one | 21:54 |
| sean-k-mooney | for now i would just recheck it again o/ | 21:54 |
| JayF | I'm getting really good at it by now :D Thanks again, have a nice night | 21:55 |
| opendevreview | MarkMielke proposed openstack/nova master: extend_volume of libvirt/volume/iscsi should not use device_path https://review.opendev.org/c/openstack/nova/+/801003 | 23:07 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!