Thursday, 2021-07-29

*** Guest2352 is now known as prometheanfire00:34
*** prometheanfire is now known as Guest264000:35
*** Guest2640 is now known as prometheanfire00:36
*** rpittau|afk is now known as rpittau07:10
opendevreviewArtom Lifshitz proposed openstack/nova stable/wallaby: Reproducer unit test for bug 1860312  https://review.opendev.org/c/openstack/nova/+/80284008:45
opendevreviewArtom Lifshitz proposed openstack/nova stable/wallaby: Allow deletion of compute service with no compute nodes  https://review.opendev.org/c/openstack/nova/+/80284108:46
opendevreviewArtom Lifshitz proposed openstack/nova stable/victoria: Reproducer unit test for bug 1860312  https://review.opendev.org/c/openstack/nova/+/80284208:49
opendevreviewArtom Lifshitz proposed openstack/nova stable/victoria: Allow deletion of compute service with no compute nodes  https://review.opendev.org/c/openstack/nova/+/80284308:49
opendevreviewArtom Lifshitz proposed openstack/nova stable/ussuri: Reproducer unit test for bug 1860312  https://review.opendev.org/c/openstack/nova/+/80284608:57
opendevreviewArtom Lifshitz proposed openstack/nova stable/ussuri: Allow deletion of compute service with no compute nodes  https://review.opendev.org/c/openstack/nova/+/80284708:57
opendevreviewArtom Lifshitz proposed openstack/nova stable/train: Reproducer unit test for bug 1860312  https://review.opendev.org/c/openstack/nova/+/80284809:01
opendevreviewArtom Lifshitz proposed openstack/nova stable/train: Allow deletion of compute service with no compute nodes  https://review.opendev.org/c/openstack/nova/+/80284909:01
opendevreviewQiu Fossen proposed openstack/nova master: Allow migrating PMEM's data  https://review.opendev.org/c/openstack/nova/+/80222509:56
opendevreviewMerged openstack/placement master: Fix SQL query counting the number of individual consumers having allocations by only selecting the aggregated consumer_id column.  https://review.opendev.org/c/openstack/placement/+/80141911:07
stephenfinbauzas: lyarwood: Dead simple typo fix here if you have 5 seconds https://review.opendev.org/c/openstack/nova/+/80085511:26
bauzasack11:27
bauzasstephenfin: we need a test, right?11:27
stephenfineh, I thought about it. didn't seem worth the effort11:28
opendevreviewStephen Finucane proposed openstack/nova master: tests: Remove 'stub_out_trusted_certs'  https://review.opendev.org/c/openstack/nova/+/76543211:47
opendevreviewTakashi Kajinami proposed openstack/nova master: Clean up allocations left by evacuation when deleting service  https://review.opendev.org/c/openstack/nova/+/77869611:48
opendevreviewTakashi Kajinami proposed openstack/nova master: Clean up allocations left by evacuation when deleting service  https://review.opendev.org/c/openstack/nova/+/77869611:50
sean-k-mooneyah they used & assuming the were appendign to an existing query string effectivly11:56
sean-k-mooneyya that fix is correct11:56
sean-k-mooneya unit test would be nice but im kindof with stephen. in this cae im not sure its required11:58
sean-k-mooneyit should not be hard to add as a follow up if ye want i woudl be tempetd to say though a better follow up would be to extra this funciton form manage.py and put the resouce provider query into the SchedulerReportClient and then just use it form nova manage12:02
sean-k-mooney*extract12:03
sean-k-mooneynova manage should not really be wriging its own functions for interacting with placment it should just use common ones and focus on the cli aspect and the business logic of the thing its tryign to do12:04
lyarwoodstephenfin: sorry was afk looks like it's already in12:14
* lyarwood tries to look at the nova-lvm failures before his next call13:06
opendevreviewStephen Finucane proposed openstack/nova master: tests: Add test for bug #1936278  https://review.opendev.org/c/openstack/nova/+/80289313:54
stephenfinbauzas: FYI ^13:54
bauzasta13:59
stephenfinbauzas: lyarwood: You think you folks could look at https://review.opendev.org/c/openstack/nova/+/773643 and the patch above it to get those nice docs fixes in? Trying to close out what I can :)14:16
lyarwoodstephenfin: ack14:39
opendevreviewStephen Finucane proposed openstack/nova master: manager: Reduce unnecessary calls  https://review.opendev.org/c/openstack/nova/+/79502714:56
opendevreviewStephen Finucane proposed openstack/nova master: Moved all calls from _ENFORCER.authorize to a separate _authorize method  https://review.opendev.org/c/openstack/nova/+/74908015:46
*** rpittau is now known as rpittau|afk16:03
bauzassean-k-mooney: still around ? can't find where we uppercase the RC names in https://github.com/openstack/placement/blob/3c51c6413bfc316cad8bb9d50b6fbffc83069b79/placement/objects/resource_class.py#L3316:38
bauzasthe API accepts lowercasing for the name but I'm almost sure we do create the RC object with uppercase name16:39
bauzasjust can't find where16:39
opendevreviewSylvain Bauza proposed openstack/nova master: Rename vgpu options to mdev  https://review.opendev.org/c/openstack/nova/+/80160716:56
opendevreviewSylvain Bauza proposed openstack/nova master: DNM (yet) : Expose the mdev class  https://review.opendev.org/c/openstack/nova/+/80174316:56
opendevreviewSylvain Bauza proposed openstack/nova master: WIP Provide the mdev class for every PCI device  https://review.opendev.org/c/openstack/nova/+/80291816:56
opendevreviewSylvain Bauza proposed openstack/nova master: WIP Provide the mdev class for every PCI device  https://review.opendev.org/c/openstack/nova/+/80291817:00
melwittbauzas: you likely already found it but it doesn't look like lowercase is allowed https://github.com/openstack/placement/blob/3c51c6413bfc316cad8bb9d50b6fbffc83069b79/placement/schemas/common.py#L17-L2117:01
sean-k-mooneybauzas: sorry yes im still here17:21
sean-k-mooneybauzas: i think there is a normalise fucntion17:22
sean-k-mooneymaybe this one https://github.com/openstack/placement/blob/3c51c6413bfc316cad8bb9d50b6fbffc83069b79/placement/util.py#L23317:23
sean-k-mooneywell that is just checkign the query stiring but i think there is a helper util for it17:23
sean-k-mooneybauzas: the api should not accpet lowercase17:25
sean-k-mooneybauzas: here |https://github.com/openstack/os-resource-classes/blob/145ed791d050725394dbd786a5d45600da656812/os_resource_classes/__init__.py#L94-L11317:26
sean-k-mooneybauzas: its in os-resouce-classes17:26
sean-k-mooneythat used to also be in placment https://github.com/openstack/placement/blob/1257198effa3b41d206d18356dded543810da6fd/nova/rc_fields.py#L58-L6617:28
sean-k-mooney bauzas  i think melwitt  is right that the scema will rejct it if its not uppercase17:38
sean-k-mooneybauzas: and we will not do the conversion automatically 17:38
sean-k-mooneybut os-resource-class does provide teh function to do the normalisation which you should use17:38
sean-k-mooneywe do use it in nova i belive17:38
sean-k-mooneyyep we do https://github.com/openstack/nova/blob/d64edd3da2336a5c7c8f69cced45272cbaf638a9/nova/tests/functional/compute/test_resource_tracker.py#L52917:39
sean-k-mooneywell actully here https://github.com/openstack/nova/blob/052cf963583ab7c6bbe4fcbf7bfe69f8f6733bdb/nova/scheduler/utils.py#L30417:40
sean-k-mooneybut anytime we constoct a custom RC name we should use it really 17:41
opendevreviewSamuel proposed openstack/nova-specs master: Migrate Instance Between Projects  https://review.opendev.org/c/openstack/nova-specs/+/80203420:52
opendevreviewSamuel proposed openstack/nova-specs master: Migrate Instance Between Projects  https://review.opendev.org/c/openstack/nova-specs/+/80203420:57
*** amodi_ is now known as amodi21:31
opendevreviewVlad Gusev proposed openstack/nova stable/train: Reject open redirection in the console proxy  https://review.opendev.org/c/openstack/nova/+/79180722:01
opendevreviewVlad Gusev proposed openstack/nova stable/stein: Reject open redirection in the console proxy  https://review.opendev.org/c/openstack/nova/+/80293522:03
opendevreviewSamuel proposed openstack/nova-specs master: Migrate Instance Between Projects  https://review.opendev.org/c/openstack/nova-specs/+/80203422:04
opendevreviewmelanie witt proposed openstack/nova master: Add stub unified limits driver  https://review.opendev.org/c/openstack/nova/+/71213722:26
opendevreviewmelanie witt proposed openstack/nova master: Assert quota related API behavior when noop  https://review.opendev.org/c/openstack/nova/+/71214022:26
opendevreviewmelanie witt proposed openstack/nova master: Make unified limits APIs return reserved of 0  https://review.opendev.org/c/openstack/nova/+/71214122:26
opendevreviewmelanie witt proposed openstack/nova master: Add logic to enforce local api and db limits  https://review.opendev.org/c/openstack/nova/+/71213922:26
opendevreviewmelanie witt proposed openstack/nova master: Enforce api and db limits  https://review.opendev.org/c/openstack/nova/+/71214222:26
opendevreviewmelanie witt proposed openstack/nova master: Update quota_class APIs for db and api limits  https://review.opendev.org/c/openstack/nova/+/71214322:26
opendevreviewmelanie witt proposed openstack/nova master: Update limit APIs  https://review.opendev.org/c/openstack/nova/+/71270722:26
opendevreviewmelanie witt proposed openstack/nova master: Update quota sets APIs  https://review.opendev.org/c/openstack/nova/+/71274922:26
opendevreviewmelanie witt proposed openstack/nova master: Tell oslo.limit how to count nova resources  https://review.opendev.org/c/openstack/nova/+/71330122:26
opendevreviewmelanie witt proposed openstack/nova master: Enforce resource limits using oslo.limit  https://review.opendev.org/c/openstack/nova/+/61518022:26
opendevreviewmelanie witt proposed openstack/nova master: Add legacy limits and usage to unified limits  https://review.opendev.org/c/openstack/nova/+/71349822:26
opendevreviewmelanie witt proposed openstack/nova master: Update quota apis with keystone limits and usage  https://review.opendev.org/c/openstack/nova/+/71349922:26
opendevreviewmelanie witt proposed openstack/nova master: Add reno for unified limits  https://review.opendev.org/c/openstack/nova/+/71527122:26
opendevreviewVlad Gusev proposed openstack/nova stable/stein: Reject open redirection in the console proxy  https://review.opendev.org/c/openstack/nova/+/80293523:01

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!