| opendevreview | Brin Zhang proposed openstack/nova master: Replace all_tenants with all_projects in List Server APIs https://review.opendev.org/c/openstack/nova/+/765311 | 00:18 |
|---|---|---|
| opendevreview | Qiu Fossen proposed openstack/nova master: Allow migrating PMEM's data https://review.opendev.org/c/openstack/nova/+/802225 | 01:45 |
| opendevreview | melanie witt proposed openstack/placement master: Switch ConsumerType to use an AttributeCache https://review.opendev.org/c/openstack/placement/+/679486 | 03:06 |
| lyarwood | gibi: Morning, https://bugs.launchpad.net/nova/+bug/1939108 but on the positive side, logsearch++ | 07:55 |
| aarents | bauzas: thanks for https://review.opendev.org/c/openstack/nova/+/764435 review, I applied the rephrasing. | 08:06 |
| gibi | lyarwood: morning! could this be related to the guest blocking or delaying the detach attempt? I vaguly remember we discussed such option before | 08:13 |
| lyarwood | gibi: yeah it's likely that, I need to push the tempest change ahead to rework detach so we actually dump the console to know either way | 08:14 |
| lyarwood | iirc it was failing on something random the last time I rechecked | 08:15 |
| lyarwood | https://review.opendev.org/c/openstack/tempest/+/794757 | 08:15 |
| lyarwood | yeah unrelated test_create_list_show_delete_interfaces_by_network_port ssh timeouts | 08:15 |
| lyarwood | /o\ | 08:15 |
| lyarwood | rechecks again | 08:15 |
| lyarwood | actually rebase as it has been that long | 08:16 |
| lyarwood | gibi: https://github.com/gibizer/zuul-log-search-config/pull/1 btw, have a few ideas about the tool itself but I might not have time to hack on it until next week | 08:20 |
| gibi | ohh, ok, lets hope the console log reveale something, other than that we can only increase timeout for the single detach attempt or increase the amount of retry we do | 08:29 |
| lyarwood | indeed, 1 hit in the last 100 failures however suggests we are somewhere close to getting this right in CI finally | 08:30 |
| * lyarwood looks at the test_delete_while_in_verify_resize_status func failures | 08:31 | |
| gibi | lyarwood: if you have ideas about the feel free to note them in an github issue or directly in the TODO.md in the repo | 08:31 |
| lyarwood | ack will do, it's mostly basic stuff like an argument for number of days back to search for etc and maybe a handler for logstash but that's it at the moment | 08:31 |
| gibi | lyarwood: thanks for looking at that func faiure I had the intention to look at both func faiures but I had no time since and probablny not even today | 08:31 |
| bauzas | aarents: thanks for the ping, just rechecked and +2d | 08:40 |
| aarents | bauzas: thanks | 08:43 |
| opendevreview | Pierre Libeau proposed openstack/nova master: Move file system freeze after end of mirroring https://review.opendev.org/c/openstack/nova/+/803713 | 09:08 |
| opendevreview | Lee Yarwood proposed openstack/nova master: func: Increase rpc_response_timeout in TestMultiCellMigrate tests https://review.opendev.org/c/openstack/nova/+/803714 | 09:08 |
| lyarwood | gibi / bauzas / stephenfin ; ^ okay I think that's a pretty trivial fix to the functional failures, I don't get why it's suddenly an issue but as this RPC call to the conductor then calls down to the source I'm assuming we've added some additional overhead somewhere and were not creeping over the 1 second timeout in the test. | 09:09 |
| lyarwood | are now* | 09:10 |
| gibi | lyarwood: will check soon | 09:12 |
| kashyap | lyarwood: What's the "best" manual way to change the video model for an existing instance? (Asking for a friend.) Is the following painful approach the only way? | 09:42 |
| kashyap | lyarwood: (1) Stop the instance. (2) snapshot it (what kind?). (3) Update the metadata on the snapshot image to use 'virtio' display dev. (4) Then rebuild the instance using the snapshot | 09:43 |
| kashyap | Any better way than that? | 09:43 |
| kashyap | (Besides the future goodness of 'nova-manage' command akin to machine_type update) | 09:43 |
| lyarwood | if you want to persist the instance data then yeah I think that's the only way | 09:44 |
| lyarwood | I don't think resize would change it | 09:44 |
| kashyap | I see. | 09:45 |
| kashyap | And for new instances, obviously start with: openstack image set --property hw_video_model=virtio [...] | 09:45 |
| lyarwood | yeah | 09:46 |
| kashyap | Or: | 09:48 |
| kashyap | $ openstack server create --flavor m1.micro \ | 09:48 |
| kashyap | --image Fedora34 \ | 09:48 |
| kashyap | --property 'hw_video_model=virtio' vm1 | 09:48 |
| kashyap | Thanks! | 09:48 |
| lyarwood | I don't think the second command is valid? | 09:52 |
| * lyarwood wonders what --property even translates to | 09:53 | |
| lyarwood | oh it's metadata | 09:54 |
| lyarwood | so yeah that isn't going to do anything kashyap | 09:55 |
| kashyap | lyarwood: Oh, I see. So what's the way again to set the prop while creating the server? | 09:55 |
| lyarwood | For new servers you would update the associated image | 09:56 |
| lyarwood | for the existing server case you'd update the snapshot image | 09:56 |
| lyarwood | and then in both create a new server from the image | 09:57 |
| opendevreview | Merged openstack/nova master: compute: Avoid duplicate BDMs during reserve_block_device_name https://review.opendev.org/c/openstack/nova/+/801990 | 09:57 |
| stephenfin | kashyap: Echoing what lyarwood said, we don't expose this kind of knob via flavor extra specs. It's only possible via image metadata properties which rn require a rebuild to change | 09:58 |
| kashyap | stephenfin: lyarwood: Thank you very much, both. I don't have this top off my head. | 09:58 |
| stephenfin | kashyap: you can find a full list of all supported extra specs here https://docs.openstack.org/nova/latest/configuration/extra-specs.html | 09:59 |
| kashyap | I'll correct my mistake on a bugzilla | 09:59 |
| opendevreview | Lee Yarwood proposed openstack/nova stable/wallaby: Add functional test for bug 1937375 https://review.opendev.org/c/openstack/nova/+/803717 | 10:01 |
| opendevreview | Lee Yarwood proposed openstack/nova stable/wallaby: compute: Avoid duplicate BDMs during reserve_block_device_name https://review.opendev.org/c/openstack/nova/+/803718 | 10:01 |
| pjakuszew | kashyap: I wrote a script which modifes extra_specs on existing instances, though I consider it dangerous | 10:02 |
| kashyap | pjakuszew: Heh, understood. The intersting question is - did it work reliably for you, without any nasty side-effects? | 10:02 |
| opendevreview | Lee Yarwood proposed openstack/nova stable/victoria: Add functional test for bug 1937375 https://review.opendev.org/c/openstack/nova/+/803720 | 10:03 |
| opendevreview | Lee Yarwood proposed openstack/nova stable/victoria: compute: Avoid duplicate BDMs during reserve_block_device_name https://review.opendev.org/c/openstack/nova/+/803721 | 10:03 |
| pjakuszew | kashyap: In my case it was a case of adding a cpu_type key to a flavor, then syncing the flavor metadata to instance and reqspec extra_specs - in your case (hw_video_model=virtio) I guess you will have to do a hard reboot so the libvirt xmls will be regenerated | 10:04 |
| kashyap | pjakuszew: Yep; in this case hard-reboot is unavoidable | 10:05 |
| pjakuszew | let me check it, one sec | 10:06 |
| kashyap | pjakuszew: Note, though: I don't have any environment to try this out. I'm just documenting some stuff due to a fallout downstream | 10:13 |
| kashyap | But thank you! :) | 10:13 |
| pjakuszew | kashyap: sure, I'm checking the differences between the xmls with and without properties right now | 10:15 |
| pjakuszew | so I can check if the metadata change was properly propagated after hard reboot later | 10:15 |
| opendevreview | Lee Yarwood proposed openstack/nova stable/ussuri: Add functional test for bug 1937375 https://review.opendev.org/c/openstack/nova/+/803722 | 10:16 |
| opendevreview | Lee Yarwood proposed openstack/nova stable/ussuri: compute: Avoid duplicate BDMs during reserve_block_device_name https://review.opendev.org/c/openstack/nova/+/803723 | 10:16 |
| bauzas | wow, I can see light at the end of the tunnel : https://events.linuxfoundation.org/kubecon-cloudnativecon-north-america/register/ | 10:17 |
| kashyap | pjakuszew: Thank you; do keep me posted. And post a link to your script - perhaps that can be added in some dangerous_utils/ directory | 10:21 |
| kashyap | bauzas: That's still living in la-la-land for LF -- I doubt many will register until the dust settles with the Delta variant | 10:22 |
| bauzas | kashyap: yup and the travel ban is still effective, but that's a fresh change at least for dometic flights | 10:22 |
| kashyap | bauzas: Domestic flights in the US, you mean? | 10:24 |
| bauzas | yup | 10:24 |
| bauzas | this gives us some direction | 10:24 |
| pjakuszew | kashyap: this is something I wanted to add into nova_manage in a more accessible form, actually | 10:24 |
| opendevreview | Merged openstack/nova master: func: Increase rpc_response_timeout in TestMultiCellMigrate tests https://review.opendev.org/c/openstack/nova/+/803714 | 10:25 |
| bauzas | conferences could run for a mixed virtual+physical system until restrictions slowly improve | 10:25 |
| kashyap | Mixed confs suck like hell :-( It frustrates both in-person and the remotees | 10:25 |
| kashyap | "Can you hear me? Oh, I was talking to myself. Anybody there? Oh, you all went for a coffee break? Never mind" | 10:26 |
| pjakuszew | kashyap: are these server properties visible in the libvirt xml in your case? looks like adding that property both under server create --property and manually on another one doesn't seem to propagate | 10:34 |
| kashyap | pjakuszew: They are not; see stephenfin's comment earlier | 10:34 |
| pjakuszew | oh I overlooked that | 10:34 |
| kashyap | pjakuszew: Only way for existing instances are what lyarwood mentioned earlier (snapshot the image; adjust the property; and then boot an instance off the updated snapshot image) | 10:35 |
| opendevreview | Lee Yarwood proposed openstack/nova stable/train: Add functional test for bug 1937375 https://review.opendev.org/c/openstack/nova/+/803727 | 10:43 |
| opendevreview | Lee Yarwood proposed openstack/nova stable/train: compute: Avoid duplicate BDMs during reserve_block_device_name https://review.opendev.org/c/openstack/nova/+/803728 | 10:43 |
| opendevreview | Merged openstack/nova master: fup: Move _wait_for_volume_attach into InstanceHelperMixin https://review.opendev.org/c/openstack/nova/+/802623 | 10:50 |
| lyarwood | stephenfin / gibi ; https://review.opendev.org/c/openstack/nova/+/802801/ could I get a +W on this now it's passing again with the above func test landed | 11:50 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [nova-manage]support extended resource request https://review.opendev.org/c/openstack/nova/+/802060 | 12:58 |
| bauzas | stephenfin: hola, before I leave, I'd appreciate if you could just look at the last rev for https://review.opendev.org/q/topic:%22bp%252Fgeneric-mdevs%22+(status:open%20OR%20status:merged) we need a second pair of eyes | 13:15 |
| bauzas | since you already looked at it | 13:15 |
| sean-k-mooney | bauzas: im off today but i will sync with the rest of the team and see if i can push the mdev work forward while your on pto | 13:27 |
| kashyap | sean-k-mooney: Don't taint your free day with work... | 13:27 |
| sean-k-mooney | :) that is why im not going to review today | 13:28 |
| sean-k-mooney | anyway i have almost finished what i need to do on my laptop soo ill be gone soonish | 13:28 |
| bauzas | kashyap: by the way, I apologize for you, my co-worker for the mdev series ;) | 13:29 |
| bauzas | kashyap: we hadn't time to discuss about this blueprint :p | 13:29 |
| bauzas | sean-k-mooney: as you want, anyway I'll be back on Tuesday, 2 days before FF | 13:30 |
| kashyap | bauzas: I was supposed to pair on it, right? Yeah, downstream-- stuff completely engulfed me :-( | 13:30 |
| bauzas | ;) | 13:30 |
| bauzas | kashyap: heh no worries | 13:30 |
| stephenfin | bauzas: will do | 13:31 |
| bauzas | ta | 13:31 |
| kashyap | bauzas: I was reading the mdev class code yesterday and then had to reboot the laptop and my memory flushed it. I know, I sound lame. | 13:33 |
| kashyap | bauzas: Did you get around to testing it on real hardware? Or "don't ask?" | 13:36 |
| bauzas | kashyap: I did | 13:37 |
| bauzas | I even bubbled the hostname in some pastebin, whoops | 13:37 |
| bauzas | :) | 13:37 |
| bauzas | I was smart enough to keep the hardware that was given for me for testing the Ampere GPU :p | 13:37 |
| bauzas | so, technically, I tested this series against MIG-backed vGPUs ;) | 13:38 |
| kashyap | I see; yeah, I know the hardware acquis on this PITA | 13:38 |
| kashyap | s/on this/here is a/ | 13:38 |
| bauzas | hopefully I should still have this server when I'm back :p | 13:39 |
| kashyap | bauzas: The only thing I know about MIG is that it can divide the GPU into several "mini GPUs". | 13:39 |
| kashyap | s/mini/flexible/ | 13:40 |
| gibi | I associate to a fighter jet when I see MIG. Can we virtualize fighter jets these days? :) | 13:52 |
| kashyap | gibi: Heh, I too had to overwrite my memory to refer to a GPU instead of a fighter-jet | 13:55 |
| bauzas | gibi: lolelly | 13:58 |
| gibi | we had MIGs in the past, nowadays we have Grippens | 13:59 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Block servers with vGPU and device profile in heal_allocations https://review.opendev.org/c/openstack/nova/+/803603 | 14:00 |
| gibi | bauzas: fixed the failing unit tests there ^^ | 14:01 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Rename 'parameter_types.hostname' -> 'fqdn' https://review.opendev.org/c/openstack/nova/+/778549 | 14:08 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Speed up 'servers' API tests https://review.opendev.org/c/openstack/nova/+/778732 | 14:08 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add support for 'hostname' parameter https://review.opendev.org/c/openstack/nova/+/778550 | 14:08 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Pass request to 'addresses' view builder https://review.opendev.org/c/openstack/nova/+/803753 | 14:08 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Remove unnecessary 'base_' prefix from schemas https://review.opendev.org/c/openstack/nova/+/803754 | 14:08 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Sanity check some tests https://review.opendev.org/c/openstack/nova/+/803755 | 14:08 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Remove various legacy extension prefixes https://review.opendev.org/c/openstack/nova/+/803756 | 14:08 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api-ref: Rename prefixed parameter definitions https://review.opendev.org/c/openstack/nova/+/803757 | 14:08 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api-ref: Update docs for microversion 2.89 https://review.opendev.org/c/openstack/nova/+/803758 | 14:08 |
| bauzas | gibi: maybe you got my last +2 before I leave | 14:11 |
| gibi | bauzas: thanks | 14:11 |
| opendevreview | Felix Huettner proposed openstack/nova stable/stein: Add functional test for bug 1937375 https://review.opendev.org/c/openstack/nova/+/803762 | 14:27 |
| opendevreview | Felix Huettner proposed openstack/nova stable/stein: compute: Avoid duplicate BDMs during reserve_block_device_name https://review.opendev.org/c/openstack/nova/+/803763 | 14:27 |
| opendevreview | Felix Huettner proposed openstack/nova stable/rocky: Add functional test for bug 1937375 https://review.opendev.org/c/openstack/nova/+/803764 | 14:29 |
| opendevreview | Felix Huettner proposed openstack/nova stable/rocky: compute: Avoid duplicate BDMs during reserve_block_device_name https://review.opendev.org/c/openstack/nova/+/803765 | 14:29 |
| opendevreview | Felix Huettner proposed openstack/nova stable/queens: Add functional test for bug 1937375 https://review.opendev.org/c/openstack/nova/+/803766 | 14:30 |
| opendevreview | Felix Huettner proposed openstack/nova stable/queens: compute: Avoid duplicate BDMs during reserve_block_device_name https://review.opendev.org/c/openstack/nova/+/803767 | 14:30 |
| opendevreview | Merged openstack/nova master: Add regression test for bug 1938326 https://review.opendev.org/c/openstack/nova/+/802801 | 14:34 |
| stephenfin | bauzas: done. Left comments on the last three patches in the series | 14:38 |
| bauzas | stephenfin: OK, I have 20 mins to look at them ;) | 14:38 |
| *** rpittau is now known as rpittau|afk | 14:43 | |
| gibi | stephenfin: I have a question about the documentation of the ignoring of use_db_reconnect in https://review.opendev.org/c/openstack/nova/+/799524/3//COMMIT_MSG#24 | 15:11 |
| stephenfin | gibi: I can look into removing it from nova's config opts, but I have deprecated the option in oslo.db so we will be dropping it soon enough | 15:12 |
| stephenfin | gibi: https://review.opendev.org/c/openstack/oslo.db/+/798133 | 15:12 |
| stephenfin | oh, wait, wrong config option | 15:13 |
| stephenfin | :) | 15:13 |
| gibi | you almost tricked me :) | 15:13 |
| stephenfin | gibi: how about a simple check on nova-compute startup to warn if the option is set to a non-default value? | 15:14 |
| stephenfin | i.e. "this option don't do nothing, foooool" | 15:14 |
| stephenfin | I don't think the config generator supports excluding individual opts | 15:14 |
| gibi | stephenfin: you mean other services than nova-compute as nova-compute cannot use direct db access | 15:15 |
| stephenfin | sorry, yes | 15:15 |
| gibi | an added warning works for me | 15:16 |
| stephenfin | actually | 15:16 |
| stephenfin | I have a patch to register options ourselves somewhere | 15:16 |
| stephenfin | wonder can I simply del that option... | 15:16 |
| stephenfin | actually, that won't help the docs generation problem | 15:16 |
| stephenfin | warning it is | 15:17 |
| gibi | ack | 15:17 |
| opendevreview | Sylvain Bauza proposed openstack/nova master: Provide the mdev class for every PCI device https://review.opendev.org/c/openstack/nova/+/802918 | 15:22 |
| opendevreview | Sylvain Bauza proposed openstack/nova master: Provide and use other RCs for mdevs if needed https://review.opendev.org/c/openstack/nova/+/803233 | 15:22 |
| opendevreview | Sylvain Bauza proposed openstack/nova master: Expose the mdev class https://review.opendev.org/c/openstack/nova/+/801743 | 15:22 |
| opendevreview | Sylvain Bauza proposed openstack/nova master: WIP: Cleanup GPU vs. mdev wording https://review.opendev.org/c/openstack/nova/+/803379 | 15:22 |
| bauzas | gibi: stephenfin: uploaded latest rev of mdev series due to stephenfin's nits ^ | 15:22 |
| bauzas | stephenfin: to make it clear, we accept FOO as a mdev_class option value | 15:22 |
| bauzas | then, we persist FOO in the object set | 15:22 |
| stephenfin | bauzas: okay, what is FOO used for in that case? | 15:22 |
| stephenfin | does it correspond to something on the device or in libvirt? | 15:23 |
| bauzas | but when looking at the mdev_classes, we use the normalize_rc command to provide a CUSTOM_FOO RC name | 15:23 |
| stephenfin | or is it purely used as an identifier? | 15:23 |
| bauzas | that's why we have the helper and why we don't directly return the list of classes | 15:23 |
| bauzas | stephenfin: no, purely an identifier given by the operator | 15:23 |
| stephenfin | Okay, then why not insist on the CUSTOM_ prefix? | 15:24 |
| bauzas | it could be STEPHENFIN | 15:24 |
| bauzas | stephenfin: we could... but we haven't said this in the spec ;) | 15:24 |
| stephenfin | it seems sensible, given this will be used placement | 15:24 |
| stephenfin | I personally would expect my device with mdev_class FOO to use the same value in placement | 15:25 |
| stephenfin | ...if I didn't know better | 15:25 |
| stephenfin | ;) | 15:25 |
| stephenfin | bauzas: does it make sense to you to do that though? We can amend the spec if needed | 15:25 |
| bauzas | well, I wanted to stop working at 5pm :p | 15:26 |
| bauzas | but I could do this this evening | 15:26 |
| bauzas | I need to change a few things but ok | 15:26 |
| bauzas | stephenfin: do you know how to accept an option value to have a specific prefix ? | 15:27 |
| stephenfin | bauzas: like oslo.confg? | 15:28 |
| bauzas | in oslo.config yes | 15:28 |
| stephenfin | I just assumed we'd regex it away | 15:28 |
| bauzas | oh shit you're right | 15:28 |
| stephenfin | i.e. something like (VGPU|CUSTOM_[A-Z_]) | 15:28 |
| stephenfin | but more complete | 15:28 |
| stephenfin | :) | 15:28 |
| zigo | bauzas: Hi there ! After a failed migration (mistake in the host ssh keys), I cannot start a GPU instance, it's telling me: "libvirt.libvirtError: internal error: Device 0000:41:00.0 is already in use" | 15:31 |
| zigo | How can I fix this ? | 15:31 |
| zigo | bauzas: I'm asking you because it's an instance with a GPU, as you can see... | 15:31 |
| bauzas | zigo: sorrry, I need to go off | 15:31 |
| bauzas | but looks like you already use the mdev | 15:31 |
| bauzas | in another guest | 15:32 |
| zigo | bauzas: No that's not the case. | 15:32 |
| zigo | It's the only instance of this cloud with a GPU. | 15:32 |
| zigo | (even though we have many available: one per compute) | 15:32 |
| zigo | bauzas: Will you be able to help me later on? | 15:33 |
| zigo | bauzas: It's an instance for Debconf, so it's a good cause ! :) | 15:33 |
| gibi | zigo: bauzas is about to drop of for 3 weeks of PTO in -34 minutes. so your question came just in time :) | 15:35 |
| zigo | Ah, shit ... :) | 15:35 |
| zigo | I'll figure it out, no worries. | 15:35 |
| zigo | bauzas: Have nice holidays ! | 15:35 |
| bauzas | and I need to work on stephenfin's concern | 15:35 |
| gibi | zigo: so no other instance is using pci device 0000:41:00.0 on that host? | 15:36 |
| zigo | gibi: Nop. | 15:36 |
| gibi | still libvirt says it is used | 15:36 |
| stephenfin | gibi: I've all but the nova-manage patch of the BW series reviewed. I assume that one can wait a while (it's in merge conflict). Also, melwitt is probably well placed to review that specifically | 15:36 |
| gibi | stephenfin: thanks a lot. I'm still chewing on on your db series. | 15:36 |
| gibi | stephenfin: sure the nova-manage part is the least important and it still misses some test coverage | 15:37 |
| gibi | stephenfin: so you are out next week, will you be back still before the FF? | 15:37 |
| stephenfin | nope, I'm here next week but I'm starting my move the new team | 15:37 |
| gibi | zigo: have you tried to restart libvirtd ? | 15:37 |
| gibi | stephenfin: ohh, then I mixed it | 15:38 |
| gibi | stephenfin: I will be out next week :/ | 15:38 |
| stephenfin | I was supposed to be away but things came up | 15:38 |
| stephenfin | I'll still be around for the rest of the cycle but in a reduced capacity | 15:38 |
| stephenfin | so keep reviewing what I've already reviewed and rebasing my own patches, but no new work | 15:38 |
| gibi | stephenfin: OK, I might corner you with some re-review for the packet rate series if needed and you wil see if you have time or not | 15:38 |
| stephenfin | yup, sounds good :) | 15:39 |
| stephenfin | there are two patches with TODOs left that I can see still | 15:39 |
| gibi | zigo: it feels like it is some internal incosistency inside libvirtd | 15:39 |
| gibi | stephenfin: yeah, the ones that needs the neutron counterpart to define the name of the extension | 15:40 |
| gibi | stephenfin: the naming of api_db_api import made me chuckle :) that name well summarizes why naming is one of the hardest thing in programming | 15:43 |
| stephenfin | Yeah :-( | 15:43 |
| gibi | it is sooo historical | 15:43 |
| stephenfin | I tried many alternatives and kept coming back to that | 15:43 |
| gibi | it is not a fault of the current series at all | 15:44 |
| gibi | the current series just distilled it to a well visible name | 15:44 |
| stephenfin | I did considered removing the main DB's 'api' module and folding it in to nova.objects like we did for the API DB, but that was even more work in an already bloated series | 15:45 |
| stephenfin | so... | 15:45 |
| gibi | that api is huge so yeah | 15:46 |
| gibi | it is impressive that you could push through this amount of refactoring in nova | 15:48 |
| opendevreview | Sylvain Bauza proposed openstack/nova master: Provide the mdev class for every PCI device https://review.opendev.org/c/openstack/nova/+/802918 | 15:54 |
| opendevreview | Sylvain Bauza proposed openstack/nova master: Provide and use other RCs for mdevs if needed https://review.opendev.org/c/openstack/nova/+/803233 | 15:54 |
| opendevreview | Sylvain Bauza proposed openstack/nova master: Expose the mdev class https://review.opendev.org/c/openstack/nova/+/801743 | 15:54 |
| opendevreview | Sylvain Bauza proposed openstack/nova master: WIP: Cleanup GPU vs. mdev wording https://review.opendev.org/c/openstack/nova/+/803379 | 15:54 |
| bauzas | stephenfin: gibi: last round before I leave : change of the option value to be CUSTOM_ something | 15:54 |
| bauzas | gibi: sorry if I may ask you to review just before you leave, but the changes are femtonits | 15:55 |
| bauzas | I prevented to rebase | 15:55 |
| bauzas | so, PS_n-2 to PS should show the very few differences | 15:55 |
| stephenfin | bauzas: Thanks. I'll start looking now but I will have to leave myself soon enough | 15:56 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Exclude the 'use_db_reconnect' option https://review.opendev.org/c/openstack/nova/+/803778 | 15:56 |
| stephenfin | Worst case scenario, one of us can tweak it while you're away to get it over the line | 15:56 |
| stephenfin | gibi: ^ | 15:57 |
| stephenfin | turns out I _could_ just modify what we were registering since I stopped registering the oslo.db opts in https://review.opendev.org/c/openstack/nova/+/799523/ | 15:57 |
| bauzas | stephenfin: I was planning to end at 5pm | 15:58 |
| bauzas | looks like I was on the wrong timezone when I said this | 15:58 |
| stephenfin | bauzas: it's still only 9am in California ;) | 15:58 |
| bauzas | perfect timing for starting my day again | 15:59 |
| stephenfin | bauzas: Can you bang this ~50 line change in as the last thing before you leave? :D https://review.opendev.org/c/openstack/nova/+/799523/ | 15:59 |
| bauzas | stephenfin: you eventually got my last approval before I leave, gibi you lose | 16:01 |
| stephenfin | \o/ | 16:01 |
| stephenfin | winner winner | 16:01 |
| bauzas | this is like the olympics, money time | 16:01 |
| stephenfin | enjoy your PTO o. | 16:02 |
| bauzas | stephenfin: be sure I'll haunt you when I'm back even if you're not lurking this chan | 16:02 |
| ade_lee | stephenfin, lyarwood hey -- I started to look at the failures in the fips ci job -- https://review.opendev.org/c/openstack/nova/+/790519 | 16:02 |
| ade_lee | stephenfin, lyarwood looks like the bootfromvolume test is failing - and I think its because iscsid is not happy because its chap algorithm needs to be set to something other than md5 | 16:03 |
| ade_lee | not sure how to do that in the test .. | 16:04 |
| *** bauzas is now known as bauzas_away | 16:04 | |
| gibi | bauzas_away: enjoy, I will look at your mdev series still today | 16:05 |
| stephenfin | ade_lee: The test that's failing is an integration test running on devstack VM, so you're going to need to modify some configuration via devstack or a plugin | 16:05 |
| bauzas_away | gibi: thanks, appreciated | 16:05 |
| bauzas_away | anyway, back on tuesday means 2 days of work before FF, that's totally doable to merge things | 16:06 |
| ade_lee | stephenfin, lyarwood in barbican, we do special test stuff on devstack with a script at https://github.com/openstack/barbican/blob/master/devstack/lib/barbican for instance , but I don't see anything similar in nova | 16:06 |
| gibi | bauzas_away: :D you are such an optimist :D | 16:06 |
| ade_lee | though as this is something that will likely show up elsewhere - its prob best to look in devstack itself .. | 16:07 |
| ade_lee | looking .. | 16:07 |
| stephenfin | ade_lee: this isn't stuff I'm intimately familiar with, but we do some stuff as a post-run job. For example, you can see the stuff in roles/run-evacuate-hook which is run as part of the nova-live-migration job | 16:08 |
| stephenfin | pre-run probably won't do though since that'll surely run before DevStack even gets started, though maybe that's okay... | 16:09 |
| stephenfin | doing it in DevStack (hidden behind a config option) or via a DevStack plugin would certainly be easier I suspect | 16:10 |
| ade_lee | stephenfin, yeah and more useful as this will undoubtedly show up in cinder fips tests amongst others | 16:11 |
| stephenfin | yup | 16:11 |
| gibi | I'm dropping off for a week of vacation | 16:38 |
| gibi | back on 16th of Aug | 16:38 |
| *** gibi is now known as gibi_pto | 16:38 | |
| gibi_pto | o/ | 16:39 |
| stephenfin | o/ | 16:39 |
| opendevreview | Stephen Finucane proposed openstack/nova master: WIP: Expand type hints for nova.block_device https://review.opendev.org/c/openstack/nova/+/742170 | 16:39 |
| opendevreview | Stephen Finucane proposed openstack/nova master: mypy: Follow-up for I4a9c1ee486beda070ee0a4a9734a7ec9e2629a67 https://review.opendev.org/c/openstack/nova/+/803787 | 16:39 |
| opendevreview | Merged openstack/nova master: db: Move main DB migrations https://review.opendev.org/c/openstack/nova/+/799519 | 16:57 |
| gmann | gibi_pto: have good vacation. | 17:31 |
| gmann | stephenfin: reviewed this hostname series, I think we need to leave the legacy extensions prefix things for non-related APIs and do only for hostname field https://review.opendev.org/c/openstack/nova/+/778550 | 17:32 |
| gmann | left comment in https://review.opendev.org/c/openstack/nova/+/803756/1 | 17:33 |
| opendevreview | Ade Lee proposed openstack/nova master: Add check job for FIPS https://review.opendev.org/c/openstack/nova/+/790519 | 18:34 |
| *** bnemec is now known as bnemec-pto | 19:40 | |
| opendevreview | Merged openstack/nova master: libvirt: Handle silent failures to extend volume within os-brick https://review.opendev.org/c/openstack/nova/+/801714 | 20:39 |
| *** goberle_ is now known as goberle | 20:43 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!