| *** abhishekk is now known as akekane|home | 05:21 | |
| *** akekane|home is now known as abhishekk | 05:22 | |
| *** rpittau|afk is now known as rpittau | 07:52 | |
| *** akekane_ is now known as abhishekk | 08:26 | |
| stephenfin | lyarwood: Any chance you could cast an eye over a little more of the DB series this week, in the absence of gibi and bauzas? It starts on this patch which _looks_ huge but was mostly an invocation of sed :) https://review.opendev.org/c/openstack/nova/+/799524/ | 09:07 |
|---|---|---|
| lyarwood | yarp, was up most the night but II'll make a start once this coffee kicks in | 09:07 |
| lyarwood | I'll* | 09:08 |
| opendevreview | Stephen Finucane proposed openstack/nova-specs master: Amend configurable-instance-hostnames for more response changes https://review.opendev.org/c/openstack/nova-specs/+/803892 | 09:38 |
| kashyap | stephenfin: Hey, when you get a min, maybe you can settle this dispute here: https://review.opendev.org/c/openstack/nova/+/798680/3/nova/virt/libvirt/config.py#2058 | 09:49 |
| * kashyap corrects a small thinko there | 09:50 | |
| stephenfin | kashyap: I think you're correct. Those classes are used to build XML for new instances. I don't think we use it to parse anything for existing instances. | 09:51 |
| kashyap | stephenfin: Exactly so; thank you very much. I was wondering if I was confusing myself | 09:51 |
| stephenfin | unrelated: have we agreed on virtio? Doesn't that have impacts for Windows guests? | 09:52 |
| kashyap | stephenfin: Right; I've discussed this at length w/ the QEMU graphics maint, and 'virtio' seems good for both | 09:53 |
| kashyap | stephenfin: What more: | 09:53 |
| kashyap | stephenfin: I got a Red Hat virt QE to test both Windows and Linux guests with 'cirrus' and do some live migration tests | 09:53 |
| kashyap | (with 'cirrus', changed to 'virtio', i.e.) And the tests succeed. See my comment on PS 3 (Aug 04 4:27 PM) | 09:54 |
| stephenfin | kashyap: What are your thoughts on whipping up a doc with the current and future default device models, the reasons for these choices, and the commands one can use to migrate existing instances from one to the other | 09:54 |
| stephenfin | in lieu of a spec or anything else | 09:54 |
| kashyap | stephenfin: "Device models" --> You're talking only of video, or others too? | 09:55 |
| stephenfin | there's a lot of context embedded in various reviews, IRC convos and emails now. It would be good to get it all transcribed somewhere | 09:55 |
| stephenfin | That depends. Are you personally just targeting video right now? | 09:55 |
| kashyap | stephenfin: Yes, right now only 'video'. And yes, I fully agree: the context is across sources, and only those who're immersed in it can have a semblance of clarity. | 09:56 |
| stephenfin | If so, yes, just video for now, but lets name the document generically (doc/source/user/libvirt-device-models.rst ?) so we can expand on it later | 09:56 |
| stephenfin | presumably via lyarwood's efforts | 09:56 |
| kashyap | stephenfin: I'm always up for docs such as what you describe. | 09:56 |
| stephenfin | spot on. I'd be happy to review that. We can use it as a stand-in for a spec and point to it from other reviews | 09:57 |
| stephenfin | Plus, we've decent docs afterwards | 09:57 |
| kashyap | stephenfin: Yeah; I'll throw in a place-holder, so I that I won't forget it after PTO starting this Thu | 09:58 |
| kashyap | stephenfin: Thanks, as always for your relentless care for thoughtful docs! :) | 09:58 |
| kashyap | (Just to wrap-up the video model one temporarily: the move from 'cirrus' to 'virtio' is far less disruptive based on the tests we've done so far - due to the graceful fallback that 'virtio' provides in case there are guest drivers.) | 10:01 |
| opendevreview | Stephen Finucane proposed openstack/nova-specs master: Revert "Amend configurable-instance-hostnames to include response changes" https://review.opendev.org/c/openstack/nova-specs/+/803895 | 10:01 |
| stephenfin | gmann: I've proposed two competing spec amendments: one proposes removing all extension prefixes for various '/servers' and '/flavors' APIs, and the other proposes not removing any (so 'OS-EXT-SRV-ATTR:hostname' stays the same) | 10:03 |
| stephenfin | gmann: The perfectionist in me would prefer the former. The realist says the latter might be wiser, at least for this microversion. | 10:04 |
| stephenfin | gmann: https://review.opendev.org/c/openstack/nova-specs/+/803892 (remove all prefixes) https://review.opendev.org/c/openstack/nova-specs/+/803895 (remove no prefixes) | 10:04 |
| slaweq | hi nova-stable-maint team, can You take a look at https://review.opendev.org/c/openstack/nova/+/791420 ? | 13:04 |
| slaweq | it already have +2 from elodilles_pto but it needs second one :) | 13:05 |
| lyarwood | ack will do | 13:06 |
| gmann | stephenfin: ack, will check and comment, thanks | 13:54 |
| lyarwood | stephenfin: https://zuul.opendev.org/t/openstack/build/6cedd9d4547c4f608553ace4701d4709 - did you see that docs failure on your https://review.opendev.org/c/openstack/nova/+/799523/ change btw? | 14:04 |
| stephenfin | lyarwood: No, I did not | 14:21 |
| * stephenfin looks | 14:21 | |
| stephenfin | lyarwood: Sigh, that failed 8 times in a row. I missed it because there were quite a few random failures elsewhere and I got lazy and stopped checking the logs :-( | 14:32 |
| stephenfin | lyarwood: The issue is that this change should not be here but rather in the next patch in the series https://review.opendev.org/c/openstack/nova/+/799523/1/etc/nova/nova-config-generator.conf | 14:32 |
| * lyarwood feels a rebase coming | 14:32 | |
| stephenfin | afraid so | 14:33 |
| lyarwood | RIP the gate | 14:33 |
| lyarwood | but cool at least it's fixed then | 14:33 |
| stephenfin | Much maligned but ultimately missed | 14:33 |
| lyarwood | the series looks good overall btw, I went through to the end but wanted to look at a few things in more detail before voting either way | 14:34 |
| lyarwood | mostly with the automatic migrations at the end tbh | 14:34 |
| stephenfin | anything else obvious you want fixed before I push this rebase? | 14:35 |
| lyarwood | nothing at the moment no | 14:35 |
| stephenfin | I dragged the follow-up into the series after the patch it fixed | 14:35 |
| lyarwood | cool | 14:35 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Register database config options ourselves https://review.opendev.org/c/openstack/nova/+/799523 | 14:38 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Unify 'nova.db.api', 'nova.db.sqlalchemy.api' https://review.opendev.org/c/openstack/nova/+/799524 | 14:38 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Exclude the 'use_db_reconnect' option https://review.opendev.org/c/openstack/nova/+/803778 | 14:38 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Move remaining 'nova.db.sqlalchemy' modules https://review.opendev.org/c/openstack/nova/+/799525 | 14:38 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Post reshuffle cleanup https://review.opendev.org/c/openstack/nova/+/799526 | 14:38 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Avoid use of ALTER in initial migration https://review.opendev.org/c/openstack/nova/+/800076 | 14:38 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Add initial alembic migration for main DB https://review.opendev.org/c/openstack/nova/+/799527 | 14:38 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Add initial alembic migration for API DB https://review.opendev.org/c/openstack/nova/+/799528 | 14:38 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Trivial style changes https://review.opendev.org/c/openstack/nova/+/799529 | 14:38 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Normalize migrations tests https://review.opendev.org/c/openstack/nova/+/799684 | 14:38 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Integrate alembic https://review.opendev.org/c/openstack/nova/+/799530 | 14:38 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Enable auto-generation of migrations https://review.opendev.org/c/openstack/nova/+/800077 | 14:38 |
| opendevreview | Stephen Finucane proposed openstack/nova master: docs: Add documentation on database migrations https://review.opendev.org/c/openstack/nova/+/800078 | 14:38 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Final cleanups https://review.opendev.org/c/openstack/nova/+/800484 | 14:38 |
| stephenfin | okay, https://review.opendev.org/c/openstack/nova/+/799523/ now excludes the one line change to etc/nova/nova-config-generator.conf. https://review.opendev.org/c/openstack/nova/+/799524 is the opposite, in that it now includes this. Both otherwise unchanged | 14:39 |
| opendevreview | Merged openstack/nova stable/rocky: [neutron] Get only ID and name of the SGs from Neutron https://review.opendev.org/c/openstack/nova/+/791420 | 15:04 |
| opendevreview | Slawek Kaplonski proposed openstack/nova stable/queens: [neutron] Get only ID and name of the SGs from Neutron https://review.opendev.org/c/openstack/nova/+/791421 | 15:05 |
| *** rpittau is now known as rpittau|afk | 16:26 | |
| lyarwood | kashyap: https://zuul.opendev.org/t/openstack/build/3c4856a7e156479e8b7bda3135389b64/log/controller/logs/screen-n-cpu.txt?severity=4 - one for tomorrow but I'm seeing `qemu unexpectedly closed the monitor: Could not allocate dynamic translator buffer` errors in the CentOS job, grepping around I think this is SELinux related but could use a hand tracking it down. | 16:55 |
| opendevreview | Merged openstack/nova master: db: Register database config options ourselves https://review.opendev.org/c/openstack/nova/+/799523 | 18:19 |
| *** lbragstad_ is now known as lbragstad | 21:17 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!