| opendevreview | Merged openstack/nova master: smartnic support - new vnic type https://review.opendev.org/c/openstack/nova/+/771363 | 02:28 |
|---|---|---|
| *** rpittau|afk is now known as rpittau | 07:08 | |
| gibi | lyarwood: good find about the deatch issue | 07:35 |
| gibi | gmann, artom, lyarwood: replied in https://github.com/openstack/nova/blob/a6690e8a3e6e4b009fb821257170cf1bd06fab7d/nova/api/openstack/compute/volumes.py#L231 | 07:38 |
| *** redrobot1 is now known as redrobot | 07:59 | |
| gibi | cores: I'm happy to trade some reviews today. I would need a second core on the pps series in return https://review.opendev.org/q/topic:bp/qos-minimum-guaranteed-packet-rate+project:openstack/nova+status:open | 08:12 |
| gibi | stephenfin: do I undernstand correctly the we no longer need to add db migration backport placeholders as alembic handles that transparentl? | 08:54 |
| stephenfin | gibi: correct | 09:10 |
| gibi | stephenfin: cool thanks | 09:10 |
| stephenfin | gibi: Just for context, the tl;dr: is that the reference to the predecessor is stored in the migration file itself, as opposed to encoded in the filename via an incrementing integer. If you want to slot stuff in, you can simply modify the references as part of the backport or introduce an additional branch | 09:13 |
| stephenfin | I'm sure we'll figure it out if/when we come to it :) | 09:13 |
| gibi | OK. If there is a way then sure we will find that when we need it | 09:13 |
| gibi | then I removed the placeholder todo from the release checklist | 09:15 |
| stephenfin | I wonder if we want to work on adding a trivial migration this cycle to test the machinery? | 09:15 |
| stephenfin | Remove one of the unused tables from the main DB or something like that | 09:15 |
| gibi | would removal of a tabla be special as it is a contraction? | 09:17 |
| gibi | but yes a test would be nice to have | 09:27 |
| gibi | I'm happy to review it | 09:27 |
| opendevreview | Stephen Finucane proposed openstack/os-traits master: Add 'COMPUTE_FIRMWARE_UEFI', 'COMPUTE_FIRMWARE_BIOS' https://review.opendev.org/c/openstack/os-traits/+/779495 | 09:54 |
| stephenfin | gibi: sean-k-mooney: As requested ^ | 09:54 |
| stephenfin | gibi: As for the migration: good point. We can address a TODO on the base migration instead | 09:55 |
| stephenfin | (I'll also get to the PPS series before EOW btw) | 09:55 |
| ignaziocassano | Hello, I just updated my kolla wallaby installation, and seems the bug 1815989 has not solved yet. | 10:04 |
| opendevreview | Merged openstack/nova master: smartnic support - create arqs https://review.opendev.org/c/openstack/nova/+/758944 | 10:04 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Rename 'parameter_types.hostname' -> 'fqdn' https://review.opendev.org/c/openstack/nova/+/778549 | 10:19 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Pass request to 'addresses' view builder https://review.opendev.org/c/openstack/nova/+/803753 | 10:19 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Remove unnecessary 'base_' prefix from schemas https://review.opendev.org/c/openstack/nova/+/803754 | 10:19 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add support for 'hostname' parameter https://review.opendev.org/c/openstack/nova/+/778550 | 10:19 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Speed up 'servers' API tests https://review.opendev.org/c/openstack/nova/+/778732 | 10:19 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Sanity check some tests https://review.opendev.org/c/openstack/nova/+/803755 | 10:23 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add support for 'hostname' parameter https://review.opendev.org/c/openstack/nova/+/778550 | 10:23 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Speed up 'servers' API tests https://review.opendev.org/c/openstack/nova/+/778732 | 10:23 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add support for 'hostname' parameter https://review.opendev.org/c/openstack/nova/+/778550 | 11:01 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Speed up 'servers' API tests https://review.opendev.org/c/openstack/nova/+/778732 | 11:01 |
| gibi | there seems to be a close competition for getting version 2.89 :) | 11:05 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api-ref: Rename prefixed parameter definitions https://review.opendev.org/c/openstack/nova/+/803757 | 11:10 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Drop extension prefixes and legacy fields https://review.opendev.org/c/openstack/nova/+/805186 | 11:10 |
| stephenfin | I noticed :) I can move mine if necessary | 11:10 |
| gibi | so far no clear winners so don't move it yet :) | 11:12 |
| gibi | stephenfin: I left feedback in https://review.opendev.org/c/openstack/nova/+/778550 | 11:32 |
| sean-k-mooney | stephenfin: +1 on https://review.opendev.org/c/openstack/os-traits/+/779495 now thanks | 11:45 |
| sean-k-mooney | stephenfin: i kasyap around this week | 11:46 |
| stephenfin | no, he's still on PTO afaik | 11:46 |
| sean-k-mooney | i can go update his os-traits patch then https://review.opendev.org/c/openstack/os-traits/+/794807 | 11:46 |
| opendevreview | sean mooney proposed openstack/os-traits master: Add a trait for the "bochs" display device https://review.opendev.org/c/openstack/os-traits/+/794807 | 11:53 |
| opendevreview | Lee Yarwood proposed openstack/nova master: WIP compute: Remove no-op setup_networks_on_host calls https://review.opendev.org/c/openstack/nova/+/803191 | 12:11 |
| opendevreview | Lee Yarwood proposed openstack/nova master: nova-manage: Introduce volume show, refresh, get_connector commands https://review.opendev.org/c/openstack/nova/+/800634 | 12:12 |
| opendevreview | Lee Yarwood proposed openstack/nova master: fixtures: Add legacy APIs to cinder fixture https://review.opendev.org/c/openstack/nova/+/805195 | 12:12 |
| lyarwood | gibi: ^ if you have time this week reviews on the above ^ nova-manage command change would really be appreciated | 12:16 |
| lyarwood | huh that skipped pre-commit somehow | 12:20 |
| lyarwood | weird the hook went AWOL | 12:23 |
| sean-k-mooney | lyarwood:.... https://github.com/cirros-dev/cirros/issues/69 | 12:24 |
| sean-k-mooney | you kknow that i brought up this io apic issue a few months ago too | 12:25 |
| lyarwood | can't recall no | 12:25 |
| lyarwood | link? | 12:25 |
| sean-k-mooney | https://review.opendev.org/q/topic:%22workaround-disable-apic%22 | 12:25 |
| sean-k-mooney | lyarwood: i mentioned it to you when they were doing the cirrus image respine for the sata dirver | 12:26 |
| sean-k-mooney | i also had a devstack based fix https://review.opendev.org/c/openstack/devstack/+/766079 | 12:26 |
| lyarwood | kk I honestly don't remember this coming up before tbh | 12:28 |
| sean-k-mooney | the guest command line is not used normally by the way | 12:29 |
| sean-k-mooney | lyarwood: it wont be used with qcow images for example | 12:29 |
| sean-k-mooney | its only used if we pass a seperate kernel image | 12:29 |
| lyarwood | eh? | 12:29 |
| lyarwood | right, that's the command line embedded in the image itself | 12:29 |
| lyarwood | so that's always used | 12:29 |
| sean-k-mooney | not in the nova patch | 12:30 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/96090 | 12:30 |
| lyarwood | right | 12:30 |
| sean-k-mooney | that wont be used by default | 12:30 |
| lyarwood | I'm talking about my change in Cirros | 12:30 |
| sean-k-mooney | ah right | 12:30 |
| lyarwood | that's why I pushed this, I didn't think we could just leave out the entire apic libvirt conf part out tbh | 12:31 |
| lyarwood | if that's an option we can revive your workaround | 12:31 |
| sean-k-mooney | it can be disabled yes | 12:31 |
| lyarwood | then lets do that I guess | 12:31 |
| sean-k-mooney | or we can change to the split image which is what my devstack patch does | 12:31 |
| lyarwood | right, I'm not keen on that tbh | 12:32 |
| sean-k-mooney | ok lets keep the cirrus patch and ill revive the nova ones which we can use as a workaround until cirrus is fixed | 12:32 |
| lyarwood | if it's fixed tbh | 12:32 |
| sean-k-mooney | altough really they should just update there kerenl | 12:32 |
| lyarwood | I don't think they will go for this | 12:32 |
| lyarwood | yeah | 12:32 |
| sean-k-mooney | ok those are revieved https://review.opendev.org/q/topic:%22workaround-disable-apic%22+(status:open%20OR%20status:merged) we can update the DNM chagne to set it on our jobs or better yet do that in the base devstack job | 12:35 |
| lyarwood | yeah mind if I rebase and play around with it? | 12:35 |
| sean-k-mooney | go for it | 12:36 |
| opendevreview | Lee Yarwood proposed openstack/nova master: fixtures: Add legacy APIs to cinder fixture https://review.opendev.org/c/openstack/nova/+/805195 | 12:36 |
| opendevreview | Lee Yarwood proposed openstack/nova master: nova-manage: Introduce volume show, refresh, get_connector commands https://review.opendev.org/c/openstack/nova/+/800634 | 12:36 |
| sean-k-mooney | nice find by the way | 12:36 |
| sean-k-mooney | i saw the perodic hang so if fixed it but did not link that to the detach issue | 12:36 |
| sean-k-mooney | most of the cases i saw prevent cloud init form working initally so we did not get that far | 12:37 |
| lyarwood | thanks yeah the tempest rewrite that dumps the console log finally found it | 12:38 |
| lyarwood | might try to add that in other places as well tbh | 12:38 |
| sean-k-mooney | the console dump ya that how i saw it for cloud init since that is dumped anyway | 12:39 |
| sean-k-mooney | without that i would not have seen it either so it is very useful if the test fails | 12:40 |
| sean-k-mooney | lyarwood: feel like doing some os-traits reviews? there are 3 that would be nice to land by client freeze | 12:48 |
| sean-k-mooney | * non-client freeze | 12:49 |
| lyarwood | yeah sure I'll clean this up and take a look | 12:49 |
| sean-k-mooney | https://review.opendev.org/c/openstack/os-traits/+/794807 https://review.opendev.org/c/openstack/os-traits/+/779495 and https://review.opendev.org/c/openstack/os-traits/+/753579 | 12:49 |
| sean-k-mooney | first one is kasyaps and then next two are stephens | 12:50 |
| ganso | gibi, sean-k-mooney, melwitt: Hi! I believe all concerns so far have been addressed, if you have a minute could you please take another look at that 1vcpu patch https://review.opendev.org/c/openstack/nova/+/804303 ? Thanks in advance | 13:02 |
| sean-k-mooney | im ok with this version although you could have used instance.flavor instead of instance.get_flavor() but its fine | 13:05 |
| sean-k-mooney | it will do the same thing | 13:05 |
| opendevreview | sean mooney proposed openstack/os-vif master: extend per-port bridge support to vhost-user https://review.opendev.org/c/openstack/os-vif/+/805214 | 13:13 |
| sean-k-mooney | stephenfin: can you cast your eyes over ^ i think i fixed the nits form the previous patch for tap interfaces too. | 13:15 |
| opendevreview | Lee Yarwood proposed openstack/nova master: workarounds: Add libvirt_disable_apic https://review.opendev.org/c/openstack/nova/+/766043 | 13:17 |
| gibi | lyarwood: left feedback in https://review.opendev.org/c/openstack/nova/+/800634 | 13:18 |
| lyarwood | ack thanks | 13:22 |
| opendevreview | sean mooney proposed openstack/os-vif master: Use TCP keepalives for ovsdb connections https://review.opendev.org/c/openstack/os-vif/+/805223 | 13:49 |
| opendevreview | Merged openstack/os-traits master: Add a trait for the "bochs" display device https://review.opendev.org/c/openstack/os-traits/+/794807 | 14:06 |
| opendevreview | Lee Yarwood proposed openstack/nova master: nova-manage: Introduce volume show, refresh, get_connector commands https://review.opendev.org/c/openstack/nova/+/800634 | 14:18 |
| opendevreview | Merged openstack/os-traits master: Add 'COMPUTE_FIRMWARE_UEFI', 'COMPUTE_FIRMWARE_BIOS' https://review.opendev.org/c/openstack/os-traits/+/779495 | 14:31 |
| opendevreview | Merged openstack/os-traits master: List traits in documentation https://review.opendev.org/c/openstack/os-traits/+/753579 | 14:32 |
| opendevreview | sean mooney proposed openstack/os-vif master: Use TCP keepalives for ovsdb connections https://review.opendev.org/c/openstack/os-vif/+/805223 | 15:01 |
| gibi | sean-k-mooney: I'm out tomorrow (national holiday). Do you think we need to wait with the os-vif last release for Xena? | 15:03 |
| gibi | sean-k-mooney: I can probably check back tomorrow late afternoon and approve the updated release patch if needed | 15:05 |
| opendevreview | Merged openstack/nova master: smartnic support - build instance with smartnic arqs https://review.opendev.org/c/openstack/nova/+/798249 | 15:05 |
| *** rpittau is now known as rpittau|afk | 15:51 | |
| opendevreview | Merged openstack/nova-specs master: Revert "Amend configurable-instance-hostnames to include response changes" https://review.opendev.org/c/openstack/nova-specs/+/803895 | 16:01 |
| sean-k-mooney | gibi: am honestly i can just backport the things im working on so no we can go ahead | 16:18 |
| gibi | sean-k-mooney: ok, then I approve the release patch | 16:19 |
| sean-k-mooney | cool enjoy your PTO tomorrow | 16:19 |
| gibi | sean-k-mooney: thanks | 16:20 |
| stephenfin | grr, once again bitten by the fact that setting Mock.return_value and Mock.side_effect seems to return the former once and then fall back to the side_effect for all other calls :-( | 16:21 |
| gibi | interesting | 16:22 |
| stephenfin | I think you mean annoying :) | 16:22 |
| gibi | :) | 16:22 |
| gibi | interesting design | 16:22 |
| gibi | I would make return_value and side_effect mutually exclusive | 16:22 |
| stephenfin | So would I. Doing it any other way seems like an anti-pattern | 16:23 |
| stephenfin | If you want a different result or the first call from every other, implement that in the side effect | 16:23 |
| stephenfin | I suspect a bug or edge case, tbh | 16:23 |
| gibi | agree | 16:26 |
| sean-k-mooney | dont we normally | 16:28 |
| sean-k-mooney | i have never seen both used | 16:28 |
| sean-k-mooney | at least i have always used only one or the other | 16:28 |
| opendevreview | Lee Yarwood proposed openstack/nova master: api: Introduce microversion 2.89 adjusting os-volume_attachments https://review.opendev.org/c/openstack/nova/+/804275 | 16:28 |
| stephenfin | I was using a mock configured in a setUp way up in the file | 16:28 |
| sean-k-mooney | perhaps we should add a hacking chekc | 16:28 |
| stephenfin | and missed the fact that it was configured with side_effect | 16:29 |
| sean-k-mooney | ah ok | 16:29 |
| sean-k-mooney | that is harder to catch | 16:29 |
| stephenfin | it was particularly annoying since normally when I see the error I was seeing, it's because I've mocked something twice by accident | 16:29 |
| stephenfin | so I was looking exclusively for that, but the ID of the mock objects were the same in multiple places (i.e. it wasn't that) | 16:30 |
| stephenfin | anyway | 16:30 |
| opendevreview | Merged openstack/nova master: api: Rename 'parameter_types.hostname' -> 'fqdn' https://review.opendev.org/c/openstack/nova/+/778549 | 16:44 |
| opendevreview | Lee Yarwood proposed openstack/python-novaclient master: Microversion 2.89 - os-volume_attachments https://review.opendev.org/c/openstack/python-novaclient/+/805022 | 16:52 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add support for 'hostname' parameter https://review.opendev.org/c/openstack/nova/+/778550 | 16:53 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Speed up 'servers' API tests https://review.opendev.org/c/openstack/nova/+/778732 | 16:53 |
| lyarwood | melwitt: https://review.opendev.org/c/openstack/nova/+/800634 - Would you mind taking a look at this and the stack under it this week if you get time? | 16:56 |
| * lyarwood has the consumer_types stuff queued up for the morning | 16:56 | |
| *** mtreinish_ is now known as mtreinish | 17:22 | |
| gmann | lyarwood: as we are renaming 'id' field too can you quickly append the spec also before we merge the code https://review.opendev.org/c/openstack/nova-specs/+/794799 | 17:33 |
| gmann | I am hoping no issue to update the spec now. gibi ? | 17:34 |
| sean-k-mooney | gmann:the spec is already approved and this would be a minor change so i think that is ok | 17:37 |
| gmann | sean-k-mooney: yeah, it is just to update documentation for what we agreed during implementation | 17:38 |
| opendevreview | Merged openstack/nova master: smartnic support - cleanup arqs https://review.opendev.org/c/openstack/nova/+/798054 | 18:02 |
| opendevreview | Merged openstack/nova master: smartnic support - reject server move and suspend https://review.opendev.org/c/openstack/nova/+/779913 | 18:13 |
| opendevreview | Merged openstack/nova master: smartnic support - functional tests https://review.opendev.org/c/openstack/nova/+/780147 | 18:13 |
| opendevreview | Merged openstack/nova master: Fix 1vcpu error with multiqueue and vif_type=tap https://review.opendev.org/c/openstack/nova/+/804303 | 18:38 |
| sean-k-mooney | melwitt: i have some nits in https://review.opendev.org/c/openstack/placement/+/679441 | 19:02 |
| sean-k-mooney | the -1 is because of https://review.opendev.org/c/openstack/placement/+/679441/25/api-ref/source/parameters.yaml#210 the regex allows 0-9 also https://review.opendev.org/c/openstack/placement/+/679441/25/placement/schemas/common.py#23 | 19:03 |
| sean-k-mooney | im not sure if that was intentional or not. i dont see why it would cause a problem but wanted to draw your attention to it | 19:04 |
| melwitt | sean-k-mooney: k will look, thx for reviewing | 19:08 |
| melwitt | lyarwood: yes sorry it slipped my mind yesterday 😣 | 19:08 |
| melwitt | sean-k-mooney: replied | 20:14 |
| opendevreview | Rodrigo Barbieri proposed openstack/nova stable/wallaby: Fix 1vcpu error with multiqueue and vif_type=tap https://review.opendev.org/c/openstack/nova/+/805304 | 20:57 |
| opendevreview | Merged openstack/nova master: api: Pass request to 'addresses' view builder https://review.opendev.org/c/openstack/nova/+/803753 | 20:58 |
| opendevreview | Merged openstack/nova master: api: Remove unnecessary 'base_' prefix from schemas https://review.opendev.org/c/openstack/nova/+/803754 | 20:58 |
| opendevreview | Merged openstack/nova master: tests: Sanity check some tests https://review.opendev.org/c/openstack/nova/+/803755 | 20:58 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!