opendevreview | MaAoyu proposed openstack/nova master: swap multiattach volume, report an error VolumeNotFound https://review.opendev.org/c/openstack/nova/+/807025 | 01:07 |
---|---|---|
*** oklhost_ is now known as oklhost | 06:11 | |
opendevreview | Victor Coutellier proposed openstack/nova master: VMware: Support volumes backed by VStorageObject https://review.opendev.org/c/openstack/nova/+/808791 | 06:25 |
gibi | o/ | 08:05 |
opendevreview | alecorps proposed openstack/nova master: VMware: Support volumes backed by VStorageObject https://review.opendev.org/c/openstack/nova/+/808791 | 08:12 |
lyarwood | \o | 08:22 |
lyarwood | bauzas: https://review.opendev.org/c/openstack/nova/+/807714 - would you mind hitting this today please | 08:22 |
bauzas | lyarwood: sure, will look | 08:22 |
lyarwood | thanks | 08:22 |
bauzas | this time, I clicked on the right button :D | 08:23 |
bauzas | https://i.gifer.com/IqTa.gif | 08:25 |
bauzas | or rather https://www.youtube.com/watch?v=Kz0PSSreCuE (wasn't able to find this one before ;) ) | 08:26 |
lyarwood | ^_^ | 08:30 |
gibi | :) | 08:41 |
opendevreview | Merged openstack/nova master: Add more retries to TestMigrateFromDownHost tests https://review.opendev.org/c/openstack/nova/+/807714 | 09:09 |
opendevreview | Lee Yarwood proposed openstack/nova master: WIP configdrive: Move mkisofs_cmd default to mkisofs https://review.opendev.org/c/openstack/nova/+/808921 | 10:05 |
opendevreview | Lee Yarwood proposed openstack/nova master: configdrive: Add TODO to replace vfat creation code with virt-make-fs https://review.opendev.org/c/openstack/nova/+/808922 | 10:20 |
opendevreview | alecorps proposed openstack/nova master: VMware: Support volumes backed by VStorageObject https://review.opendev.org/c/openstack/nova/+/808791 | 10:22 |
opendevreview | Lee Yarwood proposed openstack/nova stable/train: guestfs: With libguestfs >= v1.41.1 decode returned bytes to string https://review.opendev.org/c/openstack/nova/+/787903 | 10:58 |
bauzas | folks, I'm a bit offloaded by something internal, but you can ping me for reviews | 12:55 |
bauzas | gibi: I remember I need to update the doc change for the mdev support, but hopefully, I'll do it tomorrow | 12:55 |
gibi | bauzas: ack. no worries. I don' track any super important open patches for RC1. | 13:01 |
gibi | bauzas: for the mdev doc, sure, we can merge that even on Friday as it low risk | 13:02 |
opendevreview | Fabian Wiesel proposed openstack/nova master: Vmware: Fix indentation in conditionals https://review.opendev.org/c/openstack/nova/+/806391 | 13:08 |
opendevreview | Vlad Gusev proposed openstack/nova stable/stein: Abort live-migration during instance_init https://review.opendev.org/c/openstack/nova/+/806881 | 13:10 |
*** lbragstad_ is now known as lbragstad | 13:15 | |
spatel | sean-k-mooney Default NIC bind to NUMA0 so is that NIC feature or CPU, i am planning to buy some hardware i looking for that feature where my NIC bind to both NUMA zone | 13:15 |
spatel | I meant VF for SRIOV or DPCK | 13:16 |
spatel | DPDK | 13:16 |
opendevreview | Merged openstack/nova master: Address release note nits for cpu-resources series https://review.opendev.org/c/openstack/nova/+/705667 | 13:22 |
spatel | Assuming its NIC feature to map with NUMA, as per basic google :) | 13:22 |
sean-k-mooney | spatel: by default the nic binds to the first numa node in a cpu socket | 13:26 |
spatel | Yes, that is correct | 13:26 |
sean-k-mooney | so if you have a 2 socket system then it will bind to the firt numa node of the cpu socket that the pci lanes attach too | 13:26 |
sean-k-mooney | we have a new socket affinity policy to reflect that also | 13:27 |
sean-k-mooney | which allows the device to be used if the cpu and devce are form the same socket | 13:27 |
spatel | in which condition NIC will bind to both NUMA0 and NUMA1 ? | 13:27 |
spatel | Do i need to buy special NIC or special CPU? | 13:27 |
sean-k-mooney | it wont unless you have a nic with 2 uplinks | 13:27 |
spatel | I have Intel X710 with 2x10G port (does that work to bind dual NUMA?) | 13:28 |
skazi | hi, can someone please take a look at https://review.opendev.org/c/openstack/nova/+/791807 and older backports? | 13:38 |
skazi | the Ussuri version is already merged | 13:38 |
skazi | Zuul says +1 | 13:38 |
skazi | we need this fix all the way back to Rocky :o) | 13:39 |
skazi | thx! | 13:39 |
*** whoami-rajat__ is now known as whoami-rajat | 14:00 | |
*** abhishekk is now known as abhishekk|away | 14:31 | |
bauzas | gibi: oh shit, forgot our team meeting was today and it conflicts with some physiotherapist appointmnet | 14:35 |
gibi | bauzas: ack | 14:35 |
sean-k-mooney | skazi: that is a partial fix you also need https://review.opendev.org/c/openstack/nova/+/806629 | 15:10 |
elodilles | skazi: that patch is a squash of two patch out of which one patch is still not merged on ussuri. (also worth to mention that there is another fix to make the bug completely dissappear... and that is still open in victoria: https://review.opendev.org/q/topic:bug/1927677 ) | 15:38 |
gibi | nova meeting starts in 12 minutes here in the channel | 15:48 |
*** abhishekk|away is now known as abhishekk | 15:51 | |
gibi | #startmeeting nova | 16:00 |
opendevmeet | Meeting started Tue Sep 14 16:00:05 2021 UTC and is due to finish in 60 minutes. The chair is gibi. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
opendevmeet | The meeting name has been set to 'nova' | 16:00 |
gibi | o/ | 16:00 |
elodilles | o/ | 16:01 |
gibi | lets wait a bit for the others | 16:02 |
gibi | if only elodilles and me are here then I will be extra quick | 16:05 |
gibi | so we have to cut RC1 this week | 16:06 |
gibi | release tracking etherpad is here https://etherpad.opendev.org/p/nova-xena-rc-potential | 16:06 |
gibi | please review the reno prelude before Friday | 16:06 |
gibi | prelude: #link https://review.opendev.org/c/openstack/nova/+/807786 | 16:06 |
gibi | that is the only thing I'm tracking as still have to land before RC1 | 16:07 |
gibi | I looked at the untriaged backlog and I don't see any obvious regression for xena | 16:07 |
gibi | if you do have such bug / fix then let me know | 16:07 |
sean-k-mooney | oh o/ | 16:08 |
gibi | sean-k-mooney: o/ | 16:08 |
sean-k-mooney | im here but a litte distracted | 16:08 |
gibi | that was all important I wanted to say | 16:08 |
gibi | elodilles, sean-k-mooney: is there anything to discuss? | 16:08 |
elodilles | one thing regarding stable | 16:08 |
gibi | go | 16:09 |
sean-k-mooney | ah tere was a question about when to do the next stable release right | 16:09 |
elodilles | yesterday we got a question whether we are planning to release | 16:09 |
elodilles | on stable | 16:09 |
elodilles | sean-k-mooney: that's it :) | 16:09 |
elodilles | last release was exactly 2 months ago | 16:09 |
elodilles | so I guess we could prepare releases | 16:10 |
gibi | I'm happy to check release patches but I think I lost my PTL approve power since the election results were merged | 16:10 |
elodilles | that's probably true :) | 16:10 |
sean-k-mooney | do we want to wait until after rc1 is out and done with | 16:10 |
gibi | so you have to ping bauzas to approve them | 16:10 |
elodilles | then we need bauzas either as PTL or as release liaison :) | 16:10 |
gibi | hopefully somebody can take the release liason over from bauzas | 16:11 |
elodilles | (he owns both role now) | 16:11 |
gibi | sean-k-mooney: is there a connection? | 16:11 |
sean-k-mooney | just gate capastity so no not really | 16:11 |
elodilles | and sean-k-mooney question is the next one: do we want to wait for something? | 16:11 |
sean-k-mooney | we might want to wait for the open redirect cve fixes | 16:12 |
elodilles | if not, then I can prepare the releases today or tomorrow | 16:12 |
sean-k-mooney | thats really the only thing im thinking of | 16:12 |
sean-k-mooney | they are merged to usuri i think so we could start with W->U | 16:13 |
elodilles | sean-k-mooney: some part are merged back till ussuri, | 16:13 |
elodilles | but if i'm not mistaken there is one part which is still waiting for review in victoria | 16:13 |
sean-k-mooney | and and do train after | 16:13 |
sean-k-mooney | ah right for the /// case | 16:13 |
elodilles | (reminder: train is EM, so there won't be any release) | 16:13 |
sean-k-mooney | ah ok cool | 16:13 |
gibi | I agree to release Wallaby now, then land the cve last fix to V and release that | 16:14 |
elodilles | https://review.opendev.org/c/openstack/nova/+/806626 | 16:14 |
elodilles | this needs stable review ^^^ | 16:14 |
gibi | then backort the last cve fix to U etc. | 16:14 |
elodilles | and the also ussuri version of it | 16:14 |
gibi | can I get stable power? | 16:14 |
gibi | ;) | 16:14 |
elodilles | :] | 16:14 |
sean-k-mooney | ok so are we agreed we shoudl merge those then release them | 16:15 |
sean-k-mooney | once we get the ack for bauzas | 16:15 |
elodilles | sounds good to me | 16:15 |
sean-k-mooney | lyarwood: melwitt if you have time to review those on stable that would also help | 16:16 |
elodilles | yes, reviews are welcome and appreciated for those patches | 16:16 |
sean-k-mooney | if there is nothing else we can likely wrap the meeting there | 16:17 |
gibi | yeah | 16:17 |
gibi | anything else? | 16:17 |
elodilles | nothing from me :X | 16:18 |
gibi | then lets close this | 16:18 |
gibi | #endmeeting | 16:18 |
opendevmeet | Meeting ended Tue Sep 14 16:18:30 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:18 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2021/nova.2021-09-14-16.00.html | 16:18 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2021/nova.2021-09-14-16.00.txt | 16:18 |
opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2021/nova.2021-09-14-16.00.log.html | 16:18 |
gibi | thanks | 16:20 |
elodilles | thanks o/ | 16:21 |
*** artom_ is now known as artom | 16:36 | |
artom | elodilles, while we're kinda on the topic (con't from the meeting, sorta), could you give an opinion on https://review.opendev.org/c/openstack/nova/+/791481 ? | 16:37 |
artom | It's "blocking" a few backports, so it'd be good to get fixed on whether it's get-in-able or not | 16:38 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: fixtures: Handle binding of first port https://review.opendev.org/c/openstack/nova/+/796905 | 16:40 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: Neutron fixture: don't clobber profile and vif_details if empty https://review.opendev.org/c/openstack/nova/+/796906 | 16:40 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: functional: Add live migration tests for PCI, SR-IOV servers https://review.opendev.org/c/openstack/nova/+/796907 | 16:40 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: Test SRIOV port move operations with PCI conflicts https://review.opendev.org/c/openstack/nova/+/796908 | 16:40 |
opendevreview | Artom Lifshitz proposed openstack/nova stable/victoria: Update SRIOV port pci_slot when unshelving https://review.opendev.org/c/openstack/nova/+/796909 | 16:40 |
artom | For now I've just stacked on top | 16:40 |
elodilles | artom: well, it's test-only so that's good. on the other hand it is just refactoring (which is usually refused to accept as valid backport - if it's not some trivial change), thus I think it's not really "blocking". I understand that it makes backporting easier for some cases, but... | 17:04 |
artom | elodilles, so the alternative is that every backport that goes back to train (and Red Hat has to care about stable/train for a loooon time) is harder to write and review because it'll have a note about having to adjust method params or w/e | 17:05 |
elodilles | well, there will be ONE point where a patch needs modification / resolve of conflicts, but further back it can be still clean | 17:06 |
artom | elodilles, right, I meant in the sense that *every* patch going back to train will need that modification | 17:07 |
artom | As opposed to landing the test refactor and forgetting about it | 17:07 |
elodilles | let's say if we backport it till train then a patch that needs backport to stein will need the very same modification (though I understand that stein expects way less backports) | 17:08 |
artom | elodilles, ah, I see your point. We'd just be pushing back the point at which we need manual adjustments to the backport | 17:09 |
elodilles | exactly | 17:10 |
artom | I agree, I just don't know how much of an issue it will be in practice... | 17:10 |
elodilles | it depends on the amount of similar patches I think :) | 17:11 |
artom | elodilles, so, you have more experience reviewing stable branches, what would you say the ratio of RH to non-RH backports is? | 17:11 |
artom | Or to put it slightly different, RH care about stable/train (queens is still a thing, though we expect way less work on it now) | 17:12 |
elodilles | definitely RH wins over non-RH, that's true :) | 17:12 |
artom | I'm trying to tread carefully here, because this is *not* just throwing our weight around | 17:13 |
artom | If CERN (to name a random example) or Vexxhost or whoever are still running stein a need loads of backports to it, it's a different conversation | 17:13 |
elodilles | anyway, I'm not completely against backporting this, I'm just thinking as well where is the line and maybe this is somewhere there :) | 17:16 |
artom_ | But if stable/train happens to be the stable branch that's most popular by virtue of being what RH supports, it would make sense to me to make backports to train as easy as possible? <-- repeating myself in case it didn't send before my connection dropped | 17:17 |
mnaser | artom: thanks for thinking of us :) we don't care about stein anymore (thankfully :]) | 17:17 |
mnaser | in the next few weeks wallaby will be the only thing we care about | 17:18 |
artom_ | mnaser, \o/ | 17:18 |
*** artom_ is now known as artom | 17:22 | |
artom | Dammit, how the crap does a new func test cause this trace: | 17:23 |
artom | 2021-09-14 13:22:47,973 ERROR [nova.api.openstack.wsgi] Unexpected exception in API method | 17:23 |
artom | Traceback (most recent call last): | 17:23 |
artom | File "/home/artom/src/nova/.tox/functional-py36/lib/python3.6/site-packages/urllib3/connectionpool.py", line 417, in _make_request | 17:23 |
artom | httplib_response = conn.getresponse(buffering=True) | 17:23 |
artom | TypeError: getresponse() got an unexpected keyword argument 'buffering' | 17:23 |
elodilles | artom: another aspect is when we backport *everything* to train, then we make it harder (or even impossible?) to other contributors (with less weight) to backport a change from train to stein as they would require to resolve a mass of conflicts | 17:23 |
artom | elodilles, valid point, though I'd counter that part of that has already been done, by virtue of the backport chain already existing for train | 17:26 |
artom | So you know you need at least those patches | 17:26 |
artom | Like, I'm willing to bite that bullet, because I think overall it saves man hours | 17:26 |
artom | I'll happily resolve conflicts for someone's stable/stein backport if it means making stable/train backporting easier | 17:27 |
artom | The question is - how do we even advertise that? | 17:27 |
artom | To let backporters know | 17:27 |
elodilles | :) valid question :) | 17:27 |
elodilles | anyway, I'll sleep on it and will review the patch tomorrow | 17:28 |
artom | elodilles, ack, thanks for the conversation :) | 17:29 |
elodilles | artom: np :) | 17:30 |
spatel | anyone has any experience with server.com to rent servers? | 17:30 |
spatel | I am planning to rent to build openstack so looking for good feedback if anyone has :) | 17:31 |
artom | elodilles, one last data point, FWIW, in the last 6 months, there's been 3 "pages" of patches to stable/train, vs 1 for stable/stein | 17:33 |
artom | https://review.opendev.org/q/project:openstack/nova+branch:stable/train+-age:6month https://review.opendev.org/q/project:openstack/nova+branch:stable/stein+-age:6month | 17:34 |
artom | So about 3 times more backports to train than stein | 17:34 |
artom | Tbh, I expected a bigger difference, I thought stein would be way less active | 17:35 |
artom | Looks like we need Vlad Gusev, he's the main stein contributor who's not RH | 17:35 |
opendevreview | Merged openstack/nova stable/ussuri: Reduce mocking in test_reject_open_redirect for compat https://review.opendev.org/c/openstack/nova/+/803094 | 18:22 |
skazi | elodilles: thx for additional info I didn't know that | 18:39 |
skazi | elodilles: thx for additional info I didn't know that :o( | 18:39 |
skazi | sean-k-mooney: thank you too! | 18:40 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!