| opendevreview | Danil proposed openstack/nova master: Check if the InstanceNUMACell.pcpuset attribute exist prior to relying on it. This change enables support for the VM instances with with pinned CPUs (hw:cpu_policy=dedicated) that were created before upgrading the OpenStack Nova to Victoria release. https://review.opendev.org/c/openstack/nova/+/815923 | 00:06 |
|---|---|---|
| opendevreview | melanie witt proposed openstack/nova stable/train: Clear rebalanced compute nodes from resource tracker https://review.opendev.org/c/openstack/nova/+/811822 | 01:48 |
| opendevreview | melanie witt proposed openstack/nova stable/train: Invalidate provider tree when compute node disappears https://review.opendev.org/c/openstack/nova/+/811823 | 01:48 |
| opendevreview | melanie witt proposed openstack/nova stable/train: Prevent deletion of a compute node belonging to another host https://review.opendev.org/c/openstack/nova/+/811824 | 01:48 |
| opendevreview | melanie witt proposed openstack/nova stable/train: Fix inactive session error in compute node creation https://review.opendev.org/c/openstack/nova/+/811825 | 01:48 |
| brinzhang_ | gibi: ack, wenpingsong__ will propose it later | 06:09 |
| *** brinzhang_ is now known as brinzhang | 06:12 | |
| *** songwenping__ is now known as songwenping | 06:12 | |
| gibi | brinzhang: OK, cool, let me know if I can help | 06:59 |
| brinzhang | gibi: ack | 07:02 |
| brinzhang | wenpingsong: ^^ | 07:02 |
| gibi | prometheanfire: ack, I remember looking at that failure and then got distracted, let me see if I can quickly fix it | 07:05 |
| *** ianw is now known as ianw_pto | 07:13 | |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Fix unit test for oslo.concurrency 4.5 https://review.opendev.org/c/openstack/nova/+/815940 | 07:40 |
| gibi | prometheanfire: ^^ | 07:41 |
| gibi | bauzas: a small unit test fix ^^ to unblock the requirement bump | 07:43 |
| bauzas | gibi : apologies but I'm off until Tuesday | 07:57 |
| bauzas | (heading to Paris) | 07:58 |
| gibi | bauzas: ohh, I remember now. Enjoy | 08:12 |
| em_ | is there any way to add /remove/change the ssh-key of an cloud-init instance after the creation | 08:31 |
| em_ | openstack server set --property? | 08:31 |
| gibi | em_: I think you can only use rebuild to inject a new keypair | 09:32 |
| em_ | does rebuild white the database? | 09:40 |
| em_ | sorry disk | 09:40 |
| gibi | yes it will rewrite the root disk of the VM from the original image | 10:00 |
| em_ | so the concept is to never write data on the root disk, only on ephi? | 10:15 |
| sean-k-mooney[m] | rebuild willl erase the ephemeral disks too | 10:16 |
| sean-k-mooney[m] | rebuild is a distructive operation that should only be used to erase all data in the vm that is no stored in cinder volumes | 10:17 |
| gibi | sean-k-mooney[m]: ohh, will rebuild replace ephemerals with an empty disk? | 10:17 |
| sean-k-mooney[m] | cloud init by default does not run on each boot so there is no reliable way to change the ssh key pair | 10:17 |
| gibi | (make sense though as the name is _ephemeral_ | 10:17 |
| gibi | ) | 10:17 |
| sean-k-mooney[m] | even if we updated it in the db cloud-init would not rerun on the next boot unless you altered its default behavior | 10:18 |
| sean-k-mooney[m] | if you need to rotate an ssh key or add a new one you really need to do that by sshing in wiht the orignal and adding it manually | 10:19 |
| sean-k-mooney[m] | gibi there used to be an api extention tat allowed you to ask for it to no be erased pre microversions | 10:20 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [nova-manage]support extended resource request https://review.opendev.org/c/openstack/nova/+/802060 | 10:20 |
| sean-k-mooney[m] | but we never actully made that part of the api when we removed extentions | 10:21 |
| sean-k-mooney[m] | and it was never supported by libvirt if i understand corectly | 10:21 |
| gibi | ohh, OK, I learned new things today \o/ | 10:22 |
| sean-k-mooney[m] | https://github.com/openstack/nova/blob/liberty-eol/nova/api/openstack/compute/legacy_v2/contrib/preserve_ephemeral_rebuild.py | 10:23 |
| *** dpawlik5 is now known as dpawlik | 10:25 | |
| sean-k-mooney[m] | oh i guess we still support tht | 10:28 |
| sean-k-mooney[m] | its not documented anywhere | 10:28 |
| sean-k-mooney[m] | it looks like you set preserve_ephemeral=true in the server metadata | 10:28 |
| sean-k-mooney[m] | https://github.com/openstack/nova/blob/50fdbc752a9ca9c31488140ef2997ed59d861a41/nova/api/openstack/compute/helpers.py#L96-L103 | 10:29 |
| sean-k-mooney[m] | i think this was only supported by ironic however | 10:29 |
| sean-k-mooney[m] | yep its not supported int he default implemetation https://github.com/openstack/nova/blob/50fdbc752a9ca9c31488140ef2997ed59d861a41/nova/compute/manager.py#L3234-L3238 | 10:33 |
| sean-k-mooney[m] | so libvirt does not support it | 10:33 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Reno for qos-minimum-guaranteed-packet-rate https://review.opendev.org/c/openstack/nova/+/805046 | 10:34 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: DNM: Test nova-manage placement heal_allocations with new Neutron https://review.opendev.org/c/openstack/nova/+/815952 | 10:47 |
| *** lbragstad4 is now known as lbragstad | 11:07 | |
| opendevreview | Federico Ressi proposed openstack/nova master: Debug Nova APIs call failures https://review.opendev.org/c/openstack/nova/+/806683 | 11:10 |
| gibi | gmann: are you around? | 14:41 |
| gmann | gibi: hi | 14:41 |
| gibi | hi | 14:41 |
| gibi | I'm trying to figure out the issue in the bandwidth tempest tests https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_9ab/802060/18/check/nova-next/9ab4682/testr_results.html | 14:42 |
| gibi | it seems that the tempest code now thinks that the new neutron API extension is enabled | 14:42 |
| gibi | but that is not merged yet https://review.opendev.org/c/openstack/neutron/+/805637 | 14:42 |
| gmann | gibi: ah, got it. | 14:44 |
| gibi | there is | 14:44 |
| gibi | api_extensions = all | 14:44 |
| gibi | in the tempest conf | 14:44 |
| gmann | gibi: I think we should make depends-on in otherway around | 14:44 |
| gmann | tempest tests should be depends-on on neutron? or neutron patch fail on existing test? | 14:44 |
| gibi | the neutron patch is OK to land as that adds the extension that makes the test passing | 14:45 |
| gibi | I have another nova patch the fails now until the neutron patch lands | 14:45 |
| gibi | and also the newer tempest patches adding pps coverage are failing unit the neutron patch lands | 14:45 |
| gmann | gibi: you mean tempest existing test (before https://review.opendev.org/c/openstack/tempest/+/809168) fail ? | 14:45 |
| gibi | I mean the test we adapeted to the new neutron API in https://review.opendev.org/c/openstack/tempest/+/809168 now fails for other patches as the neutron patch haven't landed yet | 14:46 |
| gibi | which is due to the fact that tempest is configured that all the API extensions are available even the one that is not merged yet | 14:47 |
| gmann | gibi: yeah. but if we revert 809168 and merge the series after neutron patch then is it fine? | 14:47 |
| gmann | tempest seriesw | 14:47 |
| gibi | I would keep the 809168 and wait for https://review.opendev.org/c/openstack/neutron/+/805637 to land clearing up the situation | 14:48 |
| gmann | or existing assert which was modified in 809168 will fail if neutron patch merged as it change the response? | 14:48 |
| gibi | yepp we need 809168 before we land the neutron API change as that would break existing tempest | 14:48 |
| gibi | so I think we are OK as is now | 14:48 |
| gibi | just cannot land the nova change https://review.opendev.org/c/openstack/nova/+/802060 until the neutron API extension lands | 14:49 |
| gmann | gibi: I am wondering why neutron gate is not blocked as neutron-ovs-tempest-multinode-full fail after 809168 | 14:49 |
| gibi | maybe it is :) | 14:49 |
| gibi | let me check | 14:49 |
| gmann | yeah because my DNM patch was just on neutron master https://review.opendev.org/c/openstack/neutron/+/815898 | 14:49 |
| gmann | https://zuul.openstack.org/builds?job_name=neutron-ovs-tempest-multinode-full | 14:50 |
| gibi | yepp your DNM patch shows that the ovs job is blocked | 14:51 |
| gibi | this is a deadlock, we cannot have 809168 before the neutron API extension as that block everythin except the API extension patch, but we cannot have the neutron API extension before 809168, because that also blocks everything except the tempest patch | 14:53 |
| gibi | /o\ | 14:53 |
| gibi | and this is basically because tempest + devstack declares a neutron API extension exists before it is really exists | 14:54 |
| gmann | gibi: but i am confused as test modified/merged in 809168 is passing in few pass of same job https://zuul.openstack.org/builds?job_name=neutron-ovs-tempest-multinode-full | 14:55 |
| gmann | and failing instances of that job does now run that tests | 14:55 |
| gmann | so I am not clear if master gate is blocked and if not then why | 14:55 |
| gmann | gibi: we have the way to unblock this type of deadlock in tempest which is common way when API change. but test is passing on current master after 809168 is not clear to me | 14:56 |
| gibi | I think the test is not passing on current master, except in https://review.opendev.org/c/openstack/neutron/+/805637 | 14:57 |
| gibi | our patches top that | 14:57 |
| gibi | s/our/or/ | 14:57 |
| gmann | gibi: ah yeah, its in the series patches only. let me check failing one then | 14:58 |
| gibi | your DNM patch is a good example how the neutron master fails today | 14:59 |
| gmann | yeah | 14:59 |
| prometheanfire | gibi: thanks | 15:01 |
| gmann | gibi: for deadlock we can do: step1. revert the 809168 to unblock the gate and for neutron/nova change to land -> step 1. skip the test in tempest which is allow neutron change to merge 2. unskip the tempest test along with revert of revert of809168 | 15:02 |
| gmann | that is how we land bug fixes in projects if tempest test block that | 15:02 |
| gibi | sounds complicated | 15:03 |
| gmann | gibi: ah this is +A so we can just wait for this? https://review.opendev.org/c/openstack/neutron/+/805637/12 | 15:03 |
| gibi | gmann: yeah, if I know that the current recheck of 805637 will be successfully then yes | 15:04 |
| gibi | it is friday, I can recheck it during the weekend | 15:04 |
| gibi | so probably we not loosing much if we keep the gate broken for the weekend | 15:04 |
| gmann | gibi: +1, sure. I will also keep monitoring it. | 15:05 |
| gibi | gmann: OK, thanks | 15:05 |
| gmann | gibi: just for future ref if needed. this is process in tempest side https://docs.openstack.org/tempest/latest/HACKING.html#bug-fix-on-core-project-needing-tempest-changes | 15:05 |
| gibi | then fingers crossed | 15:05 |
| * gibi clicks | 15:05 | |
| gmann | my bad that i did not realize the full flow | 15:05 |
| gibi | OK, so we all the new neutron API extension that breaks existing tempest test we need to temporary disable the test, merge the API extension, merge the tempest adaptation, and then re-enable the test | 15:07 |
| gibi | s/we/with/ | 15:07 |
| gmann | yeah, and for any type of bug fix in project if that is blocked by tempest tests | 15:08 |
| gibi | ack | 15:08 |
| gibi | melwitt: hi! I've fixed and replied to your comments in https://review.opendev.org/c/openstack/nova/+/802060 please ignore the nova-next failure for now, it is due and ordering issue, we need to land https://review.opendev.org/c/openstack/neutron/+/805637 (which is on the gate) first. See our discussion with gmann above ^^ | 15:19 |
| opendevreview | Merged openstack/nova stable/xena: Reproduce bug 1944759 https://review.opendev.org/c/openstack/nova/+/810910 | 16:00 |
| spatel | sean-k-mooney[m] morning | 17:03 |
| gibi | gmann: so far so good, 805637 cleared the check queue and now running in the gate queue | 18:35 |
| gmann | +1 | 18:53 |
| gmann | seems ovs multinode job again failing | 20:04 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!