gmann | yuval: cool. | 00:36 |
---|---|---|
opendevreview | melanie witt proposed openstack/nova master: Add wrapper for oslo.concurrency lockutils.ReaderWriterLock() https://review.opendev.org/c/openstack/nova/+/824280 | 04:16 |
*** hemna0 is now known as hemna | 07:38 | |
EugenMayer | How do you all handle nat reflection issues. so a vm/server connecting to an other service via the public IP, which happens to be hosted in the same openstack and is also the IP of the gateway for the commucation. So usualy nat reflection - any hints? | 08:47 |
opendevreview | yuval proposed openstack/nova-specs master: lightos volume driver spec https://review.opendev.org/c/openstack/nova-specs/+/824191 | 08:52 |
yuval | dear core reviewer - I have update the nova spec for lightos driver, can you please review? | 08:53 |
gibi | yuval: hi! I will take a look | 08:53 |
opendevreview | Lior Friedman proposed openstack/nova master: support use_multipath for nvme driver https://review.opendev.org/c/openstack/nova/+/824353 | 08:54 |
opendevreview | Ghanshyam proposed openstack/nova master: Server actions APIs scoped to project scope https://review.opendev.org/c/openstack/nova/+/824358 | 09:02 |
opendevreview | Lior Friedman proposed openstack/nova master: support use_multipath for nvme driver https://review.opendev.org/c/openstack/nova/+/823941 | 09:04 |
*** elodille1 is now known as elodilles | 09:29 | |
EugenMayer | considering this older commit to fix nat-reflextion issues https://github.com/openstack/nova/commit/b61e1ea12cd41ea507b1f6496ec1413c93bd679b .. is this even working/used with OVN networking? | 09:51 |
sean-k-mooney1 | EugenMayer: nat reflection is not something done by nova | 10:02 |
sean-k-mooney1 | EugenMayer: the neutron routers i think will do that | 10:03 |
EugenMayer | sean-k-mooney1 i assume it is a neutron topic, but that commit is somehow in the nova namespace | 10:03 |
sean-k-mooney1 | EugenMayer: nova used to have nova networks to use instead of neutron | 10:03 |
EugenMayer | sean-k-mooney1 asking there too - i cannot pin down the right project right now. Thank you for the hint | 10:03 |
EugenMayer | ah - i see. so it was 'nova back then'. Sorry i was not here back then | 10:03 |
EugenMayer | understood. The nova here is the 'old network nova nowdays replaced by neutron' | 10:04 |
sean-k-mooney1 | it was nova when nova did networking | 10:04 |
EugenMayer | This also means that particular patch has no affect/sense today. Could be entirely oncovereed | 10:04 |
sean-k-mooney1 | but today its in neutron | 10:04 |
EugenMayer | i see. As so often, thank you for clearing the fog out for me! | 10:05 |
sean-k-mooney1 | EugenMayer: i think that code has been entirly deleted a release or two ago | 10:05 |
sean-k-mooney1 | https://github.com/openstack/nova/tree/master/nova/network | 10:05 |
EugenMayer | I see. Do you know of any position right now if people basically are at 'use split DNS or deal with the consequences?' | 10:06 |
sean-k-mooney1 | well its kind of an odd issue | 10:07 |
sean-k-mooney1 | in that you seam to be tryign to use the same ip for two things | 10:07 |
sean-k-mooney1 | using it as the default gateway and as a vm | 10:07 |
sean-k-mooney1 | like you would normally reserve the default gateway ip so it could not be used for floating ips | 10:09 |
*** sean-k-mooney1 is now known as sean-k-mooney | 10:09 | |
opendevreview | Merged openstack/nova master: Enable min pps tempest testing in nova-next https://review.opendev.org/c/openstack/nova/+/811748 | 10:38 |
opendevreview | Lee Yarwood proposed openstack/nova master: WIP libvirt: Register defaults for undefined hw image properties https://review.opendev.org/c/openstack/nova/+/800708 | 11:26 |
opendevreview | Lee Yarwood proposed openstack/nova master: WIP manage: Add image_property commands https://review.opendev.org/c/openstack/nova/+/824392 | 11:26 |
opendevreview | yuval proposed openstack/nova-specs master: lightos volume driver spec https://review.opendev.org/c/openstack/nova-specs/+/824191 | 12:24 |
sean-k-mooney | gibi: bauzas im ok with the latest version of ^ by the way. given the scope fo the nova change is small i think this is more then enough detail for now | 12:58 |
sean-k-mooney | more detail can be included in the documentation and or cidner driver | 12:58 |
gibi | sean-k-mooney: ack, I will check back to that today | 13:00 |
sean-k-mooney | gibi while i have you regarding teh ttl for healthcheck | 13:02 |
gibi | yes | 13:02 |
sean-k-mooney | so you think i shoudl keep the ttl, remove the stale_multipleer and intoduce a new state unkonwn | 13:03 |
sean-k-mooney | and if the ttl is expired for a reading report it as unknown or pass? | 13:03 |
sean-k-mooney | or perhaps warn? | 13:03 |
gibi | keep the ttl, remove the stale_multiplier, do not introduce unknow state | 13:03 |
sean-k-mooney | ok | 13:04 |
gibi | move from fail -> pass if ttl expires | 13:04 |
gibi | basicaly if it is unknown the report pass | 13:04 |
gibi | that will attract trafic | 13:04 |
gibi | so if it is still faulty we will detect it | 13:04 |
sean-k-mooney | ok that works for nova-api certenly | 13:04 |
sean-k-mooney | not sure about other services | 13:05 |
sean-k-mooney | i think it shoudl be workable | 13:06 |
sean-k-mooney | ill incoperate that into the next version | 13:06 |
sean-k-mooney | i kind of feel like if all are expired the state shoudl be warn but we can debate that in the implemetion | 13:06 |
sean-k-mooney | unless you feel that shoudl be stated in the spec | 13:06 |
sean-k-mooney | for now i think im going to follow dansmith's advise of sepcify that warn is a viald value but in initally do not use it in the implemenation | 13:07 |
gibi | you view also make sense, we don't know the state so we warn that it might be faulty. | 13:07 |
sean-k-mooney | i.e. only start usign warn after we have the basic pass fail stuff workign | 13:08 |
sean-k-mooney | gibi ya so the IETF draft recommend treating warn as still "passing" but that somethign might be wrong | 13:08 |
gibi | I'm OK to define warn, but not use it in the first implementation | 13:09 |
gibi | maybe we can gather some feedback from the field what operators want to see when the service don't know the state of it dpes | 13:09 |
gibi | *deps | 13:09 |
sean-k-mooney | ya that sounds resonabl that we shoudl ask there input | 13:10 |
gibi | so I won't block on having warn | 13:10 |
gibi | with the same logic I would add ttl but not yet add stale_multiplier | 13:11 |
gibi | we can add that later if we want to use warn for stale | 13:11 |
opendevreview | Jonathan Race proposed openstack/nova-specs master: Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova-specs/+/824044 | 13:14 |
chateaulav | morning all | 13:18 |
sean-k-mooney | o/ | 13:19 |
*** dasm|off is now known as dasm | 14:00 | |
chateaulav | kashyap: can you link the spec: https://review.opendev.org/c/openstack/nova-specs/+/824044 to the blueprint: https://blueprints.launchpad.net/nova/+spec/pick-guest-arch-based-on-host-arch-in-libvirt-driver | 14:01 |
kashyap | chateaulav: It is already linked to in the Whiteboard at the bottom, under "2022 Additions" -- are you looking for something more? | 14:02 |
chateaulav | ok gotcha, i know it has the "Set the URL for this specification" link above blueprint. wasnt sure if that needed to be set or not | 14:04 |
chateaulav | just want to make sure you all have everything to hopefully get the spec approved | 14:04 |
sean-k-mooney | chateaulav: we generally set the url to the html version of the spec when it has merged | 14:06 |
sean-k-mooney | you can set it to the review for now if you want | 14:06 |
sean-k-mooney | well o kashyap could but ya we normally wait for it to merge before we do that | 14:07 |
sean-k-mooney | chateaulav: everything looks correct to me form a lanuchpad point of view | 14:08 |
sean-k-mooney | so dont worry about that aspect | 14:08 |
chateaulav | cool, my first spec so wanted to make sure. | 14:10 |
sean-k-mooney | chateaulav: by the way regarding testing | 14:12 |
sean-k-mooney | i see two ways to approch this form a tempest point of view | 14:12 |
sean-k-mooney | you could extend tempest with expicite tests for booting with emulation and add some addtional senario tests gated bhind a feature flag | 14:13 |
sean-k-mooney | or we coudl just use tempest as is but tweak the job to use a non native arch image and set teh image proerty in via devstack local.sh | 14:13 |
sean-k-mooney | the latere woudl inovle adding addtional ci jobs to nova's pipepline | 14:14 |
sean-k-mooney | im not sure we really want to add + for every emulated achitrrue to run on every patch | 14:14 |
sean-k-mooney | but i would be supproted if haveing one emulated arch tested on every patch and runnign weekly jobs for the rest | 14:15 |
chateaulav | I think doing the tweak and having one designated arch run would be good | 14:19 |
chateaulav | as the overall goal is to ensure emulation is functional | 14:19 |
sean-k-mooney | ack so i would suggest testing aarch64 by default in the check pipline | 14:19 |
sean-k-mooney | and then addign all fo them to a the periodic-weekly pipline and then experimental pipeline | 14:20 |
sean-k-mooney | that way we can review the status of the other arch jobs in our weekly meeting without much impact to the ci workload | 14:21 |
sean-k-mooney | you could also filter the josb to only run on changes to the libvirt driver and compute module i can help with that | 14:22 |
chateaulav | sounds good. and greatly appreciated | 14:22 |
*** artom__ is now known as artom | 14:27 | |
opendevreview | yuval proposed openstack/nova-specs master: lightos volume driver spec https://review.opendev.org/c/openstack/nova-specs/+/824191 | 14:43 |
opendevreview | yuval proposed openstack/nova-specs master: lightos volume driver spec https://review.opendev.org/c/openstack/nova-specs/+/824191 | 15:47 |
yuval | ^fixed doc auto testing | 15:47 |
opendevreview | Merged openstack/nova master: Add wrapper for oslo.concurrency lockutils.ReaderWriterLock() https://review.opendev.org/c/openstack/nova/+/824280 | 15:56 |
*** xek_ is now known as xek | 16:02 | |
opendevreview | Jonathan Race proposed openstack/nova-specs master: Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova-specs/+/824044 | 16:08 |
opendevreview | Takashi Kajinami proposed openstack/nova master: List auth plugin parameters for [keystone] section https://review.opendev.org/c/openstack/nova/+/824458 | 16:32 |
opendevreview | yuval proposed openstack/nova-specs master: lightos volume driver spec https://review.opendev.org/c/openstack/nova-specs/+/824191 | 17:01 |
opendevreview | Merged openstack/nova stable/wallaby: Reproduce bug 1953359 https://review.opendev.org/c/openstack/nova/+/820554 | 17:46 |
opendevreview | Merged openstack/nova stable/wallaby: Extend the reproducer for 1953359 and 1952915 https://review.opendev.org/c/openstack/nova/+/821943 | 17:46 |
opendevreview | Ghanshyam proposed openstack/nova master: Move rule_if_system() method to base test class https://review.opendev.org/c/openstack/nova/+/824475 | 17:56 |
opendevreview | Ghanshyam proposed openstack/nova master: Server actions APIs scoped to project scope https://review.opendev.org/c/openstack/nova/+/824358 | 17:57 |
chateaulav | just a question, i may have miss read a the process docs. for submitting the spec should it be under nova-specs/specs/yoga/ as i currently have it under the implemented directory? | 18:23 |
yuval | chateaulav: I think the pep8 fails if you dont put it under approved/implemented | 18:56 |
chateaulav | ok, just want to make sure im not creating extra work | 18:58 |
sean-k-mooney | it shoudl be put under approved | 19:00 |
chateaulav | ok | 19:00 |
sean-k-mooney | and the name of the file shoudl match the blueprint name | 19:00 |
chateaulav | sean-k.mooney: thanks, will fix | 19:00 |
sean-k-mooney | you can run the check locally with "tox -e pep8,docs" | 19:00 |
sean-k-mooney | we have a script that will move it form approved to implemented if the feature is complted at the end of the cycle | 19:01 |
sean-k-mooney | i or other will run it and it uses the name of the file to check if the blueptirn is marked as complete | 19:01 |
opendevreview | Jonathan Race proposed openstack/nova-specs master: Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova-specs/+/824044 | 19:02 |
chateaulav | sean-k-mooney: ack, placed it in the right area now. my bad... lol. dont know if the +2 needs readded with the new patchset or if that auto adds itself. | 19:05 |
sean-k-mooney | it will be lost but ill try and review it tomorrow if i agree its ready i can fast approve but if not we will get to it tomorrow | 19:07 |
opendevreview | Iago Filipe proposed openstack/nova master: Remove deprecated opts from VNC conf https://review.opendev.org/c/openstack/nova/+/824478 | 19:07 |
chateaulav | gibi had already done so. | 19:08 |
chateaulav | gibi: sorry for the extra work.. | 19:08 |
sean-k-mooney | its fine :) dont worry | 19:08 |
sean-k-mooney | it need 2 +2 and a +w to merge | 19:08 |
chateaulav | cool | 19:08 |
sean-k-mooney | so we will review it again tomorow/tonight | 19:09 |
sean-k-mooney | the cutoff is not untill close of busniess tomrorow anyway but this should be merged by then | 19:09 |
opendevreview | Iago Filipe proposed openstack/nova master: Remove deprecated opts from VNC conf https://review.opendev.org/c/openstack/nova/+/824478 | 19:09 |
sean-k-mooney | with that in mind i should go back to updating my own spec | 19:11 |
opendevreview | Iago Filipe proposed openstack/nova master: Remove deprecated opts from VNC conf https://review.opendev.org/c/openstack/nova/+/824478 | 21:19 |
*** dasm is now known as dasm|off | 22:45 | |
opendevreview | sean mooney proposed openstack/nova-specs master: add per process healthcheck spec https://review.opendev.org/c/openstack/nova-specs/+/821279 | 23:38 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!