| opendevreview | melanie witt proposed openstack/nova master: Add logic to enforce local api and db limits https://review.opendev.org/c/openstack/nova/+/712139 | 06:38 |
|---|---|---|
| opendevreview | melanie witt proposed openstack/nova master: Enforce api and db limits https://review.opendev.org/c/openstack/nova/+/712142 | 06:38 |
| opendevreview | melanie witt proposed openstack/nova master: Update quota_class APIs for db and api limits https://review.opendev.org/c/openstack/nova/+/712143 | 06:38 |
| opendevreview | melanie witt proposed openstack/nova master: Update limit APIs https://review.opendev.org/c/openstack/nova/+/712707 | 06:38 |
| opendevreview | melanie witt proposed openstack/nova master: Update quota sets APIs https://review.opendev.org/c/openstack/nova/+/712749 | 06:38 |
| opendevreview | melanie witt proposed openstack/nova master: Tell oslo.limit how to count nova resources https://review.opendev.org/c/openstack/nova/+/713301 | 06:38 |
| opendevreview | melanie witt proposed openstack/nova master: Enforce resource limits using oslo.limit https://review.opendev.org/c/openstack/nova/+/615180 | 06:38 |
| opendevreview | melanie witt proposed openstack/nova master: Add legacy limits and usage to placement unified limits https://review.opendev.org/c/openstack/nova/+/713498 | 06:38 |
| opendevreview | melanie witt proposed openstack/nova master: Update quota apis with keystone limits and usage https://review.opendev.org/c/openstack/nova/+/713499 | 06:38 |
| opendevreview | melanie witt proposed openstack/nova master: Add reno for unified limits https://review.opendev.org/c/openstack/nova/+/715271 | 06:38 |
| opendevreview | melanie witt proposed openstack/nova master: Enable unified limits in the nova-next job https://review.opendev.org/c/openstack/nova/+/789963 | 06:38 |
| *** hemna1 is now known as hemna | 07:37 | |
| *** amoralej|off is now known as amoralej | 08:11 | |
| gibi | melwitt: thanks a lot for the quick re-review on the any-traits series | 08:31 |
| *** Uggla|afk is now known as Uggla | 08:33 | |
| *** mnasiadka_ is now known as mnasiadka | 09:18 | |
| *** akekane__ is now known as abhishekk | 09:26 | |
| tobias-urdin | gibi: sorry for the delay but i've updated the bugfix as requested https://review.opendev.org/c/openstack/nova/+/827865 | 10:50 |
| gibi | tobias-urdin: thanks. I'm +2 on the fix | 10:58 |
| sean-k-mooney | looks good to me too | 11:01 |
| opendevreview | Felix Huettner proposed openstack/nova master: Gracefull recovery when attaching volume fails https://review.opendev.org/c/openstack/nova/+/828516 | 11:07 |
| tobias-urdin | thx, you guys ok with backporting with the rename of the internal function in libvirt driver? | 11:22 |
| sean-k-mooney | its not part of the driver api so it should be fine | 11:22 |
| tobias-urdin | ack | 11:22 |
| gibi | yepp, feel free to propose the backports | 11:24 |
| opendevreview | Tobias Urdin proposed openstack/nova stable/wallaby: libvirt: Add announce-self post live-migration workaround https://review.opendev.org/c/openstack/nova/+/825178 | 11:24 |
| sean-k-mooney | gibi: dmitriis im +2 on all the off-path backend series bar the docs patch at the end | 11:56 |
| dmitriis | sean-k-mooney: ack, I am finishing up some changes to the doc patch | 11:57 |
| dmitriis | interestingly, the mlx5 driver doesn't allow "trusted" to be set on a VF so I'll document that as a limitation | 11:57 |
| dmitriis | i.e. some drivers may not allow you to do that which will limit the use of the promisc mode presumably - I'll explore more | 11:58 |
| dmitriis | $ sudo ip link set enp130s0f0 vf 0 trust on ; echo $? | 11:59 |
| dmitriis | RTNETLINK answers: Operation not permitted | 11:59 |
| dmitriis | 2 | 11:59 |
| dmitriis | $ sudo ip link set enp130s0f0 vf 0 trust off ; echo $? | 11:59 |
| dmitriis | RTNETLINK answers: Operation not permitted | 11:59 |
| dmitriis | 2 | 11:59 |
| sean-k-mooney | dmitriis: ya it depend on the driver | 11:59 |
| sean-k-mooney | but honestly i hate that feature so meh | 11:59 |
| sean-k-mooney | promisc mode is a security threat and it degrades performance | 12:00 |
| dmitriis | sean-k-mooney: yeah, just trying to go through various combinations that may break | 12:00 |
| dmitriis | agreed | 12:00 |
| sean-k-mooney | at some point i woudl liek to stop using the binding_profile to enabel that too and actully have a api extension instead | 12:00 |
| sean-k-mooney | this is currently the only value that can be set in the binding_profile that is not set by nova | 12:01 |
| sean-k-mooney | and as a result we have to filter what we store in it | 12:01 |
| sean-k-mooney | when clearing it as you saw | 12:01 |
| dmitriis | yes, it feels very unnatural | 12:02 |
| sean-k-mooney | ok i have an apointment in 40 mins so i better go. ill be back in a few hours | 12:04 |
| dmitriis | sean-k-mooney: thanks a lot for all the support on this patch series - it's been quite a challenge to get it to this point | 12:04 |
| sean-k-mooney | ack your almost there | 12:04 |
| gibi | sean-k-mooney: I will check it a bit later | 12:29 |
| opendevreview | Felix Huettner proposed openstack/nova master: Gracefull recovery when attaching volume fails https://review.opendev.org/c/openstack/nova/+/828516 | 12:57 |
| *** artom__ is now known as artom | 13:03 | |
| artom | gdi test_tagged_attachment is failing in nova-next on xena as well | 13:03 |
| opendevreview | Felix Huettner proposed openstack/nova master: Gracefull recovery when attaching volume fails https://review.opendev.org/c/openstack/nova/+/828516 | 13:03 |
| *** amoralej is now known as amoralej|lunch | 13:07 | |
| opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: Add nova-ovs-hybrid-plug job https://review.opendev.org/c/openstack/nova/+/828418 | 13:10 |
| opendevreview | Artom Lifshitz proposed openstack/nova stable/wallaby: Revert "Revert resize: wait for events according to hybrid plug" https://review.opendev.org/c/openstack/nova/+/828419 | 13:10 |
| opendevreview | Merged openstack/nova master: Cleanup old resize instances dir before resize https://review.opendev.org/c/openstack/nova/+/827865 | 13:16 |
| opendevreview | Dmitrii Shcherbakov proposed openstack/nova master: Document remote-managed port usage considerations https://review.opendev.org/c/openstack/nova/+/827513 | 13:17 |
| *** dasm|off is now known as dasm | 13:17 | |
| opendevreview | Alexey Stupnikov proposed openstack/nova master: Fix clean-up process for aborted queued live migrations https://review.opendev.org/c/openstack/nova/+/828374 | 13:30 |
| opendevreview | Tobias Urdin proposed openstack/nova stable/xena: Cleanup old resize instances dir before resize https://review.opendev.org/c/openstack/nova/+/828407 | 13:33 |
| *** amoralej|lunch is now known as amoralej | 13:59 | |
| gibi | gmann: can I fix this bug outside of an api microversion? or this also needs an api microversion to be fixed? https://review.opendev.org/c/openstack/placement/+/826491/7#message-af8324d5631836fe3ec8052192994f9a42e00492 | 14:26 |
| gibi | sean-k-mooney, bauzas, melwitt ^^ | 14:27 |
| sean-k-mooney | we have not done a release yet with any traits so if its a bug in the any traits impl i dont think we need a microversion | 14:28 |
| sean-k-mooney | just reading now | 14:28 |
| opendevreview | Artom Lifshitz proposed openstack/nova stable/xena: Add nova-ovs-hybrid-plug job https://review.opendev.org/c/openstack/nova/+/828413 | 14:29 |
| opendevreview | Artom Lifshitz proposed openstack/nova stable/xena: Revert "Revert resize: wait for events according to hybrid plug" https://review.opendev.org/c/openstack/nova/+/828414 | 14:29 |
| opendevreview | Artom Lifshitz proposed openstack/nova stable/xena: skip test_tagged_attachment in nova-next https://review.opendev.org/c/openstack/nova/+/828542 | 14:29 |
| gibi | sean-k-mooney: this is a bug without any traits | 14:30 |
| * sean-k-mooney stable/xena feels so odd to me | 14:30 | |
| sean-k-mooney | oh sorry i was ment to read the comment not the commit message | 14:30 |
| gibi | sean-k-mooney: today placement accepts !!!!!!FOO as a forbidden trait as it strips all the ! | 14:30 |
| sean-k-mooney | i didnt scorll down | 14:30 |
| sean-k-mooney | ah | 14:31 |
| sean-k-mooney | well i thinkn that shoudl be fixable if you make it a 400 | 14:31 |
| sean-k-mooney | given ! is not allowed in a trait other then to mark it forbiden | 14:31 |
| sean-k-mooney | gibi: is there an error in our regex for validation or do we only validate that in nova | 14:32 |
| gibi | placement does not validate that with a schema | 14:32 |
| sean-k-mooney | ah ok https://github.com/openstack/nova/blob/master/nova/api/validation/extra_specs/traits.py | 14:32 |
| sean-k-mooney | so we do if you enable the extra spec validation | 14:32 |
| sean-k-mooney | but i guess images and direct request could still contian the invalid traits | 14:33 |
| gibi | this is pretty similar to the repeate query arg bug, something that as HTTP200 would be HTTP400 if we fix the bug so we could break clients relying on the faulty behavior (e.g sending !!FOO) | 14:34 |
| sean-k-mooney | right well at least im consitent i think we shoudl be fixing both without a microverion | 14:35 |
| gibi | yeah :0 | 14:35 |
| gibi | :) | 14:35 |
| gibi | it is differnt in a way that now in 1.39 I can choose to a) fix the bug (as proposed) b) keep the faulty !!! accepted | 14:35 |
| sean-k-mooney | i really dont like input validation bugs since they can lead to sql injection issues | 14:36 |
| sean-k-mooney | yes ya you could fix it as part of the feature | 14:37 |
| sean-k-mooney | and nova coudl just always start using 1.39 if its supported by placment | 14:37 |
| sean-k-mooney | stephenfin: didnt ye make osc-placement use the latest microversion recently | 14:37 |
| sean-k-mooney | like in xena? | 14:38 |
| gibi | I think it is last microversion up until the gap in support | 14:38 |
| * gibi finds the patch | 14:39 | |
| sean-k-mooney | we have 1.38 support | 14:39 |
| sean-k-mooney | for consumer types | 14:39 |
| sean-k-mooney | so assuming you add 1.39 support for any traits we shoudl be ok form that perspective | 14:40 |
| gibi | I don't find the patch but my env defaults to 1.29 not 1.38 | 14:42 |
| sean-k-mooney | https://github.com/openstack/osc-placement/commits/master | 14:42 |
| sean-k-mooney | i was just looking at the recent patches | 14:42 |
| sean-k-mooney | ah yes | 14:43 |
| sean-k-mooney | MAX_VERSION_NO_GAP = '1.29' | 14:43 |
| sean-k-mooney | https://github.com/openstack/osc-placement/blob/281ace20df8bd01f4cb8ae29c39d80e754a9d0a3/osc_placement/version.py#L57 | 14:43 |
| gibi | yepp, so that gets picked when nothing is provided in the CLI | 14:43 |
| sean-k-mooney | yes ok so we would need to close the gap to have a new micorvesion auto micked | 14:44 |
| sean-k-mooney | so 30-36 | 14:44 |
| gibi | yes | 14:44 |
| sean-k-mooney | ok well i would hope we could fix it with out a microverion but if we do need one then i guess that can improve the ux | 14:45 |
| sean-k-mooney | 1.30 - ‘/reshaper’, 1.31 - ‘in_tree’ 1.32 - Support forbidden aggregates 1.33 - Support string request group suffixes 1.34 - Request group mappings in allocation candidates¶ 1.35 - Support ‘root_required’ and 1.36 - Support ‘same_subtree’ | 14:47 |
| sean-k-mooney | so ingnoring 1.30 which we proably shoudl add as unused | 14:47 |
| sean-k-mooney | the rest seam to be allocation canidate related | 14:48 |
| sean-k-mooney | do we want osc-placemetn to be able to get allcoation candiates | 14:48 |
| sean-k-mooney | i guess it alreday can https://github.com/openstack/osc-placement/blob/master/osc_placement/resources/allocation_candidate.py | 14:48 |
| gibi | it can today | 14:50 |
| gibi | even with multiple requrest groups | 14:50 |
| sean-k-mooney | ya i guess that is somehwat useful for debuging | 14:50 |
| sean-k-mooney | you can get teh query form the sechduler log and try and recreate it i guess | 14:50 |
| sean-k-mooney | well i guess its useful if you are using placment for things other then openstack or in a standalone mode | 14:51 |
| sean-k-mooney | like the fidge/sandwich demos | 14:51 |
| opendevreview | Balazs Gibizer proposed openstack/osc-placement master: Support microversion 1.39 https://review.opendev.org/c/openstack/osc-placement/+/828545 | 14:54 |
| bauzas | gibi: sorry, just starting my day after ~4h of meetings | 14:55 |
| bauzas | (lovely) | 14:56 |
| gibi | bauzas: that sounds hard | 14:56 |
| gibi | why soo many meetings? | 14:56 |
| bauzas | internal needs (research tax credits discussion, documentation, mentoring...) | 14:58 |
| gibi | all the fun stuff :) | 15:03 |
| Uggla | bauzas, mentoring was not so long. ;) | 15:03 |
| bauzas | ;) | 15:03 |
| gibi | hups :) | 15:04 |
| opendevreview | Alexey Stupnikov proposed openstack/nova master: Revert instance's state when queued live migration is aborted https://review.opendev.org/c/openstack/nova/+/828570 | 15:19 |
| opendevreview | Dmitrii Shcherbakov proposed openstack/nova-specs master: Late Amendments to the Off-path Backends Spec https://review.opendev.org/c/openstack/nova-specs/+/828177 | 15:23 |
| bauzas | melwitt: just saying, your whole series got trampled because of a wrong assert in the base patch | 15:32 |
| bauzas | oh wait, no | 15:33 |
| bauzas | weird | 15:33 |
| bauzas | moving to another bp | 15:33 |
| dansmith | bauzas: eh? | 15:45 |
| bauzas | dansmith: maybe I was drunk | 15:46 |
| bauzas | dansmith: but the base patch got a shitty number of failures and I just looked at the py38 one | 15:46 |
| dansmith | the base patch was +1 from zuul last I looked | 15:46 |
| bauzas | or maybe it's just a side effect of omicron and me just fooling because of the office room lockdown since 3 days | 15:46 |
| * dansmith is very confused | 15:47 | |
| bauzas | dansmith: talking of https://review.opendev.org/c/openstack/nova/+/712139/30 | 15:47 |
| bauzas | and sorry, not the base patch, the first patch to be rebased from what I've seen, probably hence the confusion | 15:48 |
| dansmith | oh that's far from the base patch | 15:48 |
| dansmith | yeah | 15:48 |
| dansmith | oh yeah I see the fails | 15:49 |
| dansmith | the version I uploaded yesterday was +1 from zuul, so maybe her changes in the set after that had a problem | 15:50 |
| dansmith | I'll check with her when she's around | 15:50 |
| gibi | sean-k-mooney: I'm also +2 on the remote managed port series. Just to double check we don't have any open neutron dependency as the vnic type definition is merged. Am I correct? | 16:02 |
| sean-k-mooney | yes and no | 16:04 |
| sean-k-mooney | technially neutorn-lib has not been released with that change yet | 16:04 |
| sean-k-mooney | but nova does not use it | 16:04 |
| sean-k-mooney | im not sure if the neutron patches have merged dmitriis? | 16:04 |
| sean-k-mooney | gibi: nova wont break without them but obviously it wont work until nueton merge the ml2/ovn change | 16:04 |
| gibi | sean-k-mooney: OK then we have the same understanding | 16:05 |
| melwitt | bauzas: thanks for the heads up, I haven't gotten a chance to look at the CI results yet. I uploaded that late last night | 16:05 |
| bauzas | np | 16:05 |
| dmitriis | sean-k-mooney: https://review.opendev.org/c/openstack/neutron-lib/+/828174 the lib patch is in | 16:05 |
| gibi | the name of the new vnci type is fixed now so we can merge the nova side of that and at max neutron will not allow creating such port yet but that does not break nova | 16:05 |
| sean-k-mooney | dmitriis: right but neutron uses neutron-lib form pypi | 16:06 |
| sean-k-mooney | dmitriis: so until the release happens they cant use it in there unit tests | 16:06 |
| dmitriis | sean-k-mooney: also waiting for this to land https://review.opendev.org/c/openstack/releases/+/828452 | 16:06 |
| sean-k-mooney | yep | 16:06 |
| sean-k-mooney | gibi: correct | 16:06 |
| gibi | sean-k-mooney: cool | 16:06 |
| sean-k-mooney | until the neutron change land there api validation will reject the vnic type | 16:06 |
| gibi | then I pull the trigger on the series up until the doc | 16:06 |
| sean-k-mooney | ack works for me | 16:07 |
| sean-k-mooney | ok going to join donstream meeting | 16:07 |
| *** ralonsoh_ is now known as ralonsoh | 16:40 | |
| opendevreview | melanie witt proposed openstack/nova master: Add logic to enforce local api and db limits https://review.opendev.org/c/openstack/nova/+/712139 | 16:40 |
| opendevreview | melanie witt proposed openstack/nova master: Enforce api and db limits https://review.opendev.org/c/openstack/nova/+/712142 | 16:40 |
| opendevreview | melanie witt proposed openstack/nova master: Update quota_class APIs for db and api limits https://review.opendev.org/c/openstack/nova/+/712143 | 16:40 |
| opendevreview | melanie witt proposed openstack/nova master: Update limit APIs https://review.opendev.org/c/openstack/nova/+/712707 | 16:40 |
| opendevreview | melanie witt proposed openstack/nova master: Update quota sets APIs https://review.opendev.org/c/openstack/nova/+/712749 | 16:40 |
| opendevreview | melanie witt proposed openstack/nova master: Tell oslo.limit how to count nova resources https://review.opendev.org/c/openstack/nova/+/713301 | 16:40 |
| opendevreview | melanie witt proposed openstack/nova master: Enforce resource limits using oslo.limit https://review.opendev.org/c/openstack/nova/+/615180 | 16:40 |
| opendevreview | melanie witt proposed openstack/nova master: Add legacy limits and usage to placement unified limits https://review.opendev.org/c/openstack/nova/+/713498 | 16:40 |
| opendevreview | melanie witt proposed openstack/nova master: Update quota apis with keystone limits and usage https://review.opendev.org/c/openstack/nova/+/713499 | 16:40 |
| opendevreview | melanie witt proposed openstack/nova master: Add reno for unified limits https://review.opendev.org/c/openstack/nova/+/715271 | 16:40 |
| opendevreview | melanie witt proposed openstack/nova master: Enable unified limits in the nova-next job https://review.opendev.org/c/openstack/nova/+/789963 | 16:40 |
| opendevreview | Balazs Gibizer proposed openstack/osc-placement master: Support microversion 1.39 https://review.opendev.org/c/openstack/osc-placement/+/828545 | 16:54 |
| gmann | gibi: replied - https://review.opendev.org/c/openstack/placement/+/826491/7/placement/util.py#426 | 17:10 |
| gmann | it is same API behavior change that you also mentioned. !!!FOO is accepted as valid trait in code and there was no error at the down layer too so it is bad interface but success case for user. Now we are changing it to failure so break user. we should do this change in microversion only. any reason not to do as part of 1.39 ? | 17:10 |
| gmann | we have lot of such cases in APIs in past and currently too | 17:10 |
| gmann | main purpose of microversion was to improve the interface "not to be used incorrectly" without breaking the success case. | 17:11 |
| gmann | * one of the purpose | 17:11 |
| opendevreview | melanie witt proposed openstack/placement master: Make perfload jobs fail if write allocation fails https://review.opendev.org/c/openstack/placement/+/828438 | 17:33 |
| bauzas | gmann: about the gate failure you mentioned yesterday at the nova meeting, do we have an open bug report against it ? | 17:39 |
| bauzas | context : | 17:39 |
| bauzas | https://meetings.opendev.org/meetings/nova/2022/nova.2022-02-08-16.00.log.html#l-112 | 17:39 |
| * bauzas has to look at some internal bug we have that's probably related https://bugs.launchpad.net/tripleo/+bug/1960310 | 17:40 | |
| gmann | bauzas: yes, this one https://bugs.launchpad.net/devstack/+bug/1960346 | 17:44 |
| bauzas | gmann: thanks | 17:46 |
| opendevreview | sean mooney proposed openstack/nova master: docs: Document virtio-net multiqueue https://review.opendev.org/c/openstack/nova/+/792362 | 18:00 |
| opendevreview | Stephen Finucane proposed openstack/nova master: doc: Split up notifications document https://review.opendev.org/c/openstack/nova/+/828598 | 18:09 |
| opendevreview | Stephen Finucane proposed openstack/nova master: doc: Remove useless contributor/api-2 doc https://review.opendev.org/c/openstack/nova/+/828599 | 18:09 |
| opendevreview | Stephen Finucane proposed openstack/nova master: doc: Correct version for virtio-net multiqueue https://review.opendev.org/c/openstack/nova/+/828601 | 18:13 |
| stephenfin | sean-k-mooney: Want to +2+W that ^ | 18:13 |
| stephenfin | Rather than respin the base patch | 18:13 |
| stephenfin | I'd do it myself but good to sanity check | 18:14 |
| sean-k-mooney | sure i can take a look | 18:15 |
| sean-k-mooney | so you restacked teh chain | 18:15 |
| sean-k-mooney | did you read my comment as to why this was needed | 18:16 |
| sean-k-mooney | discussing it with fungi and other one suggestion was to modify zuul or to comment when submit failes in this case | 18:16 |
| sean-k-mooney | basically "this patch is in merge confclit please rebase" | 18:17 |
| *** amoralej is now known as amoralej|off | 18:17 | |
| fungi | it's not technically in "merge conflict" so much as that it has an outdated parent change, and so gerrit will refuse to create a merge commit for it when asked | 18:18 |
| sean-k-mooney | fungi: ya you are right the imporant bit though is "you need to do something" before this can merge | 18:19 |
| fungi | its parent got a new revision and then was merged, but this change did not get rebased when its parent was updated | 18:19 |
| fungi | so that's what needs to be done, yeah | 18:19 |
| sean-k-mooney | fungi: is that technially a job failure fomment or an actul zuul change. e.g. is the submit implemented as a job or part of zuul when using the gerrit driver | 18:20 |
| fungi | zuul would need to get a new feature in its gerrit source connection driver to report that error to the change | 18:21 |
| sean-k-mooney | basically im wondering is this a chagne to the project-config repo for the job/pipline definition or a change in zuul | 18:21 |
| sean-k-mooney | ack | 18:21 |
| fungi | you can actually see it indicated in the gerrit webui if you're not colorblind (no joke), the way they decide to show it is by making the "(merged)" next to the parent change red instead of grey | 18:21 |
| fungi | they couldn't make that more subtle if they tried | 18:21 |
| sean-k-mooney | is it? | 18:22 |
| sean-k-mooney | i dont see that on https://review.opendev.org/c/openstack/nova/+/792362/8 | 18:22 |
| sean-k-mooney | we might not be able to see this now since i have rebased | 18:23 |
| sean-k-mooney | also im using dark mode so that might also be a thing | 18:23 |
| sean-k-mooney | was that in the relation changed section | 18:24 |
| sean-k-mooney | fungi: oh ok so its grey for me normally and its orange for me in this case | 18:25 |
| sean-k-mooney | ya that is really not clear | 18:25 |
| sean-k-mooney | like if i hover over it the alt text is just relation chain | 18:25 |
| fungi | indeed. you have to be looking for it, and able to see that orange/red color distinct from grey | 18:25 |
| fungi | and know what it means | 18:26 |
| sean-k-mooney | right the last bit is the gap | 18:26 |
| sean-k-mooney | ther is nothing in the ui that tells you what that means | 18:26 |
| sean-k-mooney | ux bug i guess | 18:26 |
| fungi | though if you click the parent change in the relation list, then you'll be taken to the outdated patchset which you can see in its patchset drop-down once there | 18:26 |
| sean-k-mooney | right | 18:27 |
| sean-k-mooney | but since zuul does not enforece the same restrcions | 18:27 |
| sean-k-mooney | and the test pass | 18:27 |
| sean-k-mooney | there is a disconenct | 18:27 |
| sean-k-mooney | stephenfin: i proably dont have the brain capasity today to review https://review.opendev.org/q/topic:notifications-docs properly so ill leave the tab open and try to review them tomorrow | 18:31 |
| stephenfin | sean-k-mooney: oh yeah, I just meant https://review.opendev.org/c/openstack/nova/+/828601 | 18:31 |
| stephenfin | the others can wait, for sure :) | 18:31 |
| sean-k-mooney | by the way im off friday and monday so if i dont get to it tomrrow ping me on tuesday and ill review them then | 18:32 |
| chateaulav | sean-k-mooney: I seperated the patch into 3. As clarification on submitting them for review, do i follow this process? https://docs.opendev.org/opendev/infra-manual/latest/developers.html#adding-a-dependency | 18:35 |
| sean-k-mooney | you can normally i just do "git review -t <gerrit topic>" from the top patch | 18:36 |
| sean-k-mooney | so if you have the 3 commits locally | 18:36 |
| sean-k-mooney | i rebase againt master | 18:36 |
| sean-k-mooney | then git review -t <bp/<blueprint name> | 18:37 |
| sean-k-mooney | that will submit all patches not on the target branch and update the relevent reviews | 18:37 |
| sean-k-mooney | you only need to do git review -d $PARENT_CHANGE_NUMBER and git review -x $CHILD_CHANGE_NUMBER | 18:38 |
| sean-k-mooney | if you are changing the base and dont want to do an rebase | 18:38 |
| sean-k-mooney | or interactive rebase | 18:38 |
| sean-k-mooney | chateaulav: does that make sense | 18:38 |
| sean-k-mooney | chateaulav: i assume the dep you need is the os-traits bump | 18:39 |
| chateaulav | https://www.irccloud.com/pastebin/S4uju6sp/ | 18:40 |
| chateaulav | sean-k-mooney: the os-trait one i got. it is for the 3 patchsets within nova | 18:40 |
| sean-k-mooney | ya so the simplet thing to do in your case is do git-reveiew -d <os-traits patch> | 18:41 |
| sean-k-mooney | then git review -x your thee pathces | 18:41 |
| sean-k-mooney | then do git review -t <topic> | 18:41 |
| sean-k-mooney | but before you do that give me one sec | 18:42 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/826675 | 18:42 |
| sean-k-mooney | the os-traits patch has not merged yet and is in the ci | 18:43 |
| sean-k-mooney | so whwen you do the git-review you need to ensure you do not rebase that | 18:43 |
| sean-k-mooney | or it will restat the ci jobs | 18:43 |
| sean-k-mooney | so either wait for that to merge which should happen this evening | 18:43 |
| chateaulav | k | 18:43 |
| sean-k-mooney | or when you do the finall git review pass -R i belive to prevent git review form rebasing | 18:43 |
| chateaulav | that makes more sense, appreciate it. | 18:44 |
| sean-k-mooney | ya so checking man git-review | 18:44 |
| sean-k-mooney | -R, --no-rebase | 18:44 |
| sean-k-mooney | Do not automatically perform a rebase before submitting the change to Gerrit. | 18:45 |
| sean-k-mooney | When submitting a change for review, you will usually want it to be based on the tip of upstream branch in order to avoid possible conflicts. | 18:45 |
| sean-k-mooney | When amending a change and rebasing the new patchset, the Gerrit web interface will show a difference between the two patchsets which contains | 18:45 |
| sean-k-mooney | all commits in between. This may confuse many reviewers that would expect to see a much simpler difference. | 18:45 |
| chateaulav | yeah, i have that open. | 18:45 |
| sean-k-mooney | Also can be used for --compare to skip automatic rebase of fetched reviews. | 18:45 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/822053 i the current patch right | 18:47 |
| sean-k-mooney | oh you have them as 3 seperate reviews right | 18:47 |
| sean-k-mooney | but not in a relation chain | 18:47 |
| sean-k-mooney | ya so that is simpel to fix using the steps above | 18:48 |
| chateaulav | sean-k-mooney: awesome, ill wait for tomorrow then after the merge and then submit next patchset. following that method. Thank you again! | 18:48 |
| sean-k-mooney | no worries | 18:48 |
| sean-k-mooney | just so you know i normaly just use an interactive rebase locally | 18:48 |
| sean-k-mooney | so on the local branch you aget all the patches in the relation change working and then git review | 18:49 |
| sean-k-mooney | and if you are working with other people patches as a base add -R | 18:49 |
| chateaulav | Makes sense. im steadily getting super familiar with the various processes. Thanks! | 18:51 |
| sean-k-mooney | i have quickly just fixed the topic by the way https://review.opendev.org/q/topic:bp%252Fpick-guest-arch-based-on-host-arch-in-libvirt-driver | 18:51 |
| sean-k-mooney | so now they how up correctly although you still need to fix the git history | 18:52 |
| chateaulav | ok | 19:03 |
| opendevreview | Jonathan Race proposed openstack/nova master: object/notification for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828369 | 20:19 |
| opendevreview | Jonathan Race proposed openstack/nova master: driver/secheduler/docs for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/822053 | 20:19 |
| opendevreview | Jonathan Race proposed openstack/nova master: zuul-job for Adds Pick guest CPU architecture based on host arch in libvirt driver support https://review.opendev.org/c/openstack/nova/+/828372 | 20:19 |
| chateaulav | sean-k-mooney: one more question if i may. so i think i got the relational aspect done. i understand what you mean now. so with working with each patchset is it best to have a different local branch for each patchset, or just one local branch and switch between the commits? anyone can chime in too, I truly appreciate all the help! | 20:28 |
| opendevreview | Merged openstack/nova master: Update announce self workaround opt description https://review.opendev.org/c/openstack/nova/+/826829 | 20:42 |
| opendevreview | Merged openstack/nova master: [yoga] Include pf mac and vf num in port updates https://review.opendev.org/c/openstack/nova/+/824833 | 20:59 |
| opendevreview | Merged openstack/nova master: Introduce remote_managed tag for PCI devs https://review.opendev.org/c/openstack/nova/+/824834 | 20:59 |
| opendevreview | Merged openstack/nova master: Bump os-traits to 2.7.0 https://review.opendev.org/c/openstack/nova/+/826675 | 21:00 |
| opendevreview | Merged openstack/nova master: Add supports_remote_managed_ports capability https://review.opendev.org/c/openstack/nova/+/827839 | 21:00 |
| opendevreview | Merged openstack/nova master: Filter computes without remote-managed ports early https://review.opendev.org/c/openstack/nova/+/812111 | 21:00 |
| opendevreview | Merged openstack/nova master: [yoga] Add support for VNIC_REMOTE_MANAGED https://review.opendev.org/c/openstack/nova/+/824835 | 21:00 |
| opendevreview | Merged openstack/nova master: requirements: Bump minimum testtools to 2.5.0 https://review.opendev.org/c/openstack/nova/+/822820 | 21:09 |
| opendevreview | Merged openstack/nova master: Move optional build dependencies to 'extras' https://review.opendev.org/c/openstack/nova/+/822749 | 21:09 |
| opendevreview | Merged openstack/nova master: tox: Install extras https://review.opendev.org/c/openstack/nova/+/822750 | 21:09 |
| opendevreview | Merged openstack/placement master: Refactor trait normalization https://review.opendev.org/c/openstack/placement/+/825847 | 21:32 |
| opendevreview | Merged openstack/nova master: docs: Document virtio-net multiqueue https://review.opendev.org/c/openstack/nova/+/792362 | 21:32 |
| opendevreview | Merged openstack/nova master: doc: Correct version for virtio-net multiqueue https://review.opendev.org/c/openstack/nova/+/828601 | 21:32 |
| opendevreview | melanie witt proposed openstack/nova stable/xena: libvirt: Add announce-self post live-migration workaround https://review.opendev.org/c/openstack/nova/+/825064 | 22:26 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!